{"action":"created","issue":{"url":"https://api.github.com/repos/4ian/GDevelop/issues/731","repository_url":"https://api.github.com/repos/4ian/GDevelop","labels_url":"https://api.github.com/repos/4ian/GDevelop/issues/731/labels{/name}","comments_url":"https://api.github.com/repos/4ian/GDevelop/issues/731/comments","events_url":"https://api.github.com/repos/4ian/GDevelop/issues/731/events","html_url":"https://github.com/4ian/GDevelop/pull/731","id":378036299,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4ODM3MDEz","number":731,"title":"Piskel in GD refactor+ ability to store layers - WIP","user":{"login":"blurymind","id":6495061,"node_id":"MDQ6VXNlcjY0OTUwNjE=","avatar_url":"https://avatars0.githubusercontent.com/u/6495061?v=4","gravatar_id":"","url":"https://api.github.com/users/blurymind","html_url":"https://github.com/blurymind","followers_url":"https://api.github.com/users/blurymind/followers","following_url":"https://api.github.com/users/blurymind/following{/other_user}","gists_url":"https://api.github.com/users/blurymind/gists{/gist_id}","starred_url":"https://api.github.com/users/blurymind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blurymind/subscriptions","organizations_url":"https://api.github.com/users/blurymind/orgs","repos_url":"https://api.github.com/users/blurymind/repos","events_url":"https://api.github.com/users/blurymind/events{/privacy}","received_events_url":"https://api.github.com/users/blurymind/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2018-11-06T21:15:54Z","updated_at":"2018-11-10T18:12:10Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/4ian/GDevelop/pulls/731","html_url":"https://github.com/4ian/GDevelop/pull/731","diff_url":"https://github.com/4ian/GDevelop/pull/731.diff","patch_url":"https://github.com/4ian/GDevelop/pull/731.patch"},"body":"Addressing this: https://github.com/4ian/GDevelop/issues/696\r\n\r\nThis is still a wip, so please bare with me.\r\n\r\nThings I need to still do before review is ready to be done:\r\n- [x] Strip out the old pathEditor code and plug in the new reusable one for piskel-main\r\n- [x] Use a timer approach to loading piskel\r\n- [x] Replace old functions syntax with arrow functions\r\n- [x] Store metadata if more than one layer used\r\n- [x] If a tiledSprite is being edited by piskel - set piskel to tiled mode\r\n- [x] If metadata is saved to an animation, store metadata in a direction object, if its a tiledsprite- store it in an image resource object\r\n- [x] use the metadata to load the layers when it exists - if not - use image sequence\r\n- [x] Finalize the new path editor code in piskel\r\n- [x] Replace string methods with path methods in piskel-main where applicable \r\n- [x] Make the game object creation code in piskel and jfxr more reusable \r\n- [ ] Address corner cases such as what to do when user is editing in Gdevelop's spritelist an image sequence with layers that was made in piskel\r\n- [x] Update to the latest version of piskel, test for regressions\r\n- [x] Get it to pass flow checks if its not\r\n- [ ] test for and fix regressions in jfxr/piskel\r\n\r\nBasically that is the plan 🤓 🎨 👨‍🎨 \r\nFeedback/suggestions welcome :) "},"comment":{"url":"https://api.github.com/repos/4ian/GDevelop/issues/comments/437604333","html_url":"https://github.com/4ian/GDevelop/pull/731#issuecomment-437604333","issue_url":"https://api.github.com/repos/4ian/GDevelop/issues/731","id":437604333,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzYwNDMzMw==","user":{"login":"blurymind","id":6495061,"node_id":"MDQ6VXNlcjY0OTUwNjE=","avatar_url":"https://avatars0.githubusercontent.com/u/6495061?v=4","gravatar_id":"","url":"https://api.github.com/users/blurymind","html_url":"https://github.com/blurymind","followers_url":"https://api.github.com/users/blurymind/followers","following_url":"https://api.github.com/users/blurymind/following{/other_user}","gists_url":"https://api.github.com/users/blurymind/gists{/gist_id}","starred_url":"https://api.github.com/users/blurymind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blurymind/subscriptions","organizations_url":"https://api.github.com/users/blurymind/orgs","repos_url":"https://api.github.com/users/blurymind/repos","events_url":"https://api.github.com/users/blurymind/events{/privacy}","received_events_url":"https://api.github.com/users/blurymind/received_events","type":"User","site_admin":false},"created_at":"2018-11-10T18:12:10Z","updated_at":"2018-11-10T18:12:10Z","author_association":"CONTRIBUTOR","body":"Just to confirm  - storing and loading metadata on an image object works. \r\nLoading it from a Direction object after restarting Gdevelop doesnt work, even though it was written to project.json"}}
{"actor":{"display_login":"blurymind"}}