{"action":"created","comment":{"url":"https://api.github.com/repos/xi-editor/xi-editor/pulls/comments/228295257","pull_request_review_id":168536478,"id":228295257,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODI5NTI1Nw==","diff_hunk":"@@ -4,7 +4,7 @@ description = \"A generic rope data structure built on top of B-Trees.\"\n license = \"Apache-2.0\"\n name = \"xi-rope\"\n repository = \"https://github.com/google/xi-editor\"\n-version = \"0.2.0\"\n+version = \"0.2.1\"","path":"rust/rope/Cargo.toml","position":5,"original_position":5,"commit_id":"9470601949a1447a28cb223aef468c5d21b14c52","original_commit_id":"9470601949a1447a28cb223aef468c5d21b14c52","user":{"login":"jansol","id":2588851,"node_id":"MDQ6VXNlcjI1ODg4NTE=","avatar_url":"https://avatars3.githubusercontent.com/u/2588851?v=4","gravatar_id":"","url":"https://api.github.com/users/jansol","html_url":"https://github.com/jansol","followers_url":"https://api.github.com/users/jansol/followers","following_url":"https://api.github.com/users/jansol/following{/other_user}","gists_url":"https://api.github.com/users/jansol/gists{/gist_id}","starred_url":"https://api.github.com/users/jansol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jansol/subscriptions","organizations_url":"https://api.github.com/users/jansol/orgs","repos_url":"https://api.github.com/users/jansol/repos","events_url":"https://api.github.com/users/jansol/events{/privacy}","received_events_url":"https://api.github.com/users/jansol/received_events","type":"User","site_admin":false},"body":"Cargo docs mention that official semver does not actually specify 0.x.y as a special case but that cargo among others considers any 0.x.y version bumps to be breaking changes.","created_at":"2018-10-25T18:55:27Z","updated_at":"2018-10-25T18:55:28Z","html_url":"https://github.com/xi-editor/xi-editor/pull/941#discussion_r228295257","pull_request_url":"https://api.github.com/repos/xi-editor/xi-editor/pulls/941","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/xi-editor/xi-editor/pulls/comments/228295257"},"html":{"href":"https://github.com/xi-editor/xi-editor/pull/941#discussion_r228295257"},"pull_request":{"href":"https://api.github.com/repos/xi-editor/xi-editor/pulls/941"}},"in_reply_to_id":228287703},"pull_request":{"url":"https://api.github.com/repos/xi-editor/xi-editor/pulls/941","id":225473244,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NDczMjQ0","html_url":"https://github.com/xi-editor/xi-editor/pull/941","diff_url":"https://github.com/xi-editor/xi-editor/pull/941.diff","patch_url":"https://github.com/xi-editor/xi-editor/pull/941.patch","issue_url":"https://api.github.com/repos/xi-editor/xi-editor/issues/941","number":941,"state":"open","locked":false,"title":"Make all intervals closed_open","user":{"login":"cmyr","id":3330916,"node_id":"MDQ6VXNlcjMzMzA5MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/3330916?v=4","gravatar_id":"","url":"https://api.github.com/users/cmyr","html_url":"https://github.com/cmyr","followers_url":"https://api.github.com/users/cmyr/followers","following_url":"https://api.github.com/users/cmyr/following{/other_user}","gists_url":"https://api.github.com/users/cmyr/gists{/gist_id}","starred_url":"https://api.github.com/users/cmyr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmyr/subscriptions","organizations_url":"https://api.github.com/users/cmyr/orgs","repos_url":"https://api.github.com/users/cmyr/repos","events_url":"https://api.github.com/users/cmyr/events{/privacy}","received_events_url":"https://api.github.com/users/cmyr/received_events","type":"User","site_admin":false},"body":"This is a step towards #914, removing the interval data type completely.\r\nIn order to simplify those changes, this changes the implementation of\r\nInterval to only ever represent a closed-open range; this will make it easier\r\nto reason about whatever changes are required to get wrapping and spans working\r\nagain.\r\n\r\n## Review Checklist\r\n<!---\r\nHere is a list of the things everyone should make sure they do before they want their PR to be merged.\r\n--->\r\n- [ ] I have responded to reviews and made changes where appropriate.\r\n- [x] I have tested the code with `cargo test --all` / `./rust/run_all_checks`.\r\n- [x] I have updated comments / documentation related to the changes I made.\r\n- [x] I have rebased my PR branch onto xi-editor/master.\r\n","created_at":"2018-10-24T16:37:08Z","updated_at":"2018-10-25T18:55:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"930ba7d8ea5234939f023f67e15b188d8f4caabc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/xi-editor/xi-editor/pulls/941/commits","review_comments_url":"https://api.github.com/repos/xi-editor/xi-editor/pulls/941/comments","review_comment_url":"https://api.github.com/repos/xi-editor/xi-editor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xi-editor/xi-editor/issues/941/comments","statuses_url":"https://api.github.com/repos/xi-editor/xi-editor/statuses/9470601949a1447a28cb223aef468c5d21b14c52","head":{"label":"cmyr:fixup/only-closed-open","ref":"fixup/only-closed-open","sha":"9470601949a1447a28cb223aef468c5d21b14c52","user":{"login":"cmyr","id":3330916,"node_id":"MDQ6VXNlcjMzMzA5MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/3330916?v=4","gravatar_id":"","url":"https://api.github.com/users/cmyr","html_url":"https://github.com/cmyr","followers_url":"https://api.github.com/users/cmyr/followers","following_url":"https://api.github.com/users/cmyr/following{/other_user}","gists_url":"https://api.github.com/users/cmyr/gists{/gist_id}","starred_url":"https://api.github.com/users/cmyr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmyr/subscriptions","organizations_url":"https://api.github.com/users/cmyr/orgs","repos_url":"https://api.github.com/users/cmyr/repos","events_url":"https://api.github.com/users/cmyr/events{/privacy}","received_events_url":"https://api.github.com/users/cmyr/received_events","type":"User","site_admin":false},"repo":{"id":83341143,"node_id":"MDEwOlJlcG9zaXRvcnk4MzM0MTE0Mw==","name":"xi-editor","full_name":"cmyr/xi-editor","private":false,"owner":{"login":"cmyr","id":3330916,"node_id":"MDQ6VXNlcjMzMzA5MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/3330916?v=4","gravatar_id":"","url":"https://api.github.com/users/cmyr","html_url":"https://github.com/cmyr","followers_url":"https://api.github.com/users/cmyr/followers","following_url":"https://api.github.com/users/cmyr/following{/other_user}","gists_url":"https://api.github.com/users/cmyr/gists{/gist_id}","starred_url":"https://api.github.com/users/cmyr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmyr/subscriptions","organizations_url":"https://api.github.com/users/cmyr/orgs","repos_url":"https://api.github.com/users/cmyr/repos","events_url":"https://api.github.com/users/cmyr/events{/privacy}","received_events_url":"https://api.github.com/users/cmyr/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cmyr/xi-editor","description":"A modern editor with a backend written in Rust.","fork":true,"url":"https://api.github.com/repos/cmyr/xi-editor","forks_url":"https://api.github.com/repos/cmyr/xi-editor/forks","keys_url":"https://api.github.com/repos/cmyr/xi-editor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cmyr/xi-editor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cmyr/xi-editor/teams","hooks_url":"https://api.github.com/repos/cmyr/xi-editor/hooks","issue_events_url":"https://api.github.com/repos/cmyr/xi-editor/issues/events{/number}","events_url":"https://api.github.com/repos/cmyr/xi-editor/events","assignees_url":"https://api.github.com/repos/cmyr/xi-editor/assignees{/user}","branches_url":"https://api.github.com/repos/cmyr/xi-editor/branches{/branch}","tags_url":"https://api.github.com/repos/cmyr/xi-editor/tags","blobs_url":"https://api.github.com/repos/cmyr/xi-editor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cmyr/xi-editor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cmyr/xi-editor/git/refs{/sha}","trees_url":"https://api.github.com/repos/cmyr/xi-editor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cmyr/xi-editor/statuses/{sha}","languages_url":"https://api.github.com/repos/cmyr/xi-editor/languages","stargazers_url":"https://api.github.com/repos/cmyr/xi-editor/stargazers","contributors_url":"https://api.github.com/repos/cmyr/xi-editor/contributors","subscribers_url":"https://api.github.com/repos/cmyr/xi-editor/subscribers","subscription_url":"https://api.github.com/repos/cmyr/xi-editor/subscription","commits_url":"https://api.github.com/repos/cmyr/xi-editor/commits{/sha}","git_commits_url":"https://api.github.com/repos/cmyr/xi-editor/git/commits{/sha}","comments_url":"https://api.github.com/repos/cmyr/xi-editor/comments{/number}","issue_comment_url":"https://api.github.com/repos/cmyr/xi-editor/issues/comments{/number}","contents_url":"https://api.github.com/repos/cmyr/xi-editor/contents/{+path}","compare_url":"https://api.github.com/repos/cmyr/xi-editor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cmyr/xi-editor/merges","archive_url":"https://api.github.com/repos/cmyr/xi-editor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cmyr/xi-editor/downloads","issues_url":"https://api.github.com/repos/cmyr/xi-editor/issues{/number}","pulls_url":"https://api.github.com/repos/cmyr/xi-editor/pulls{/number}","milestones_url":"https://api.github.com/repos/cmyr/xi-editor/milestones{/number}","notifications_url":"https://api.github.com/repos/cmyr/xi-editor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cmyr/xi-editor/labels{/name}","releases_url":"https://api.github.com/repos/cmyr/xi-editor/releases{/id}","deployments_url":"https://api.github.com/repos/cmyr/xi-editor/deployments","created_at":"2017-02-27T18:08:20Z","updated_at":"2018-09-18T18:35:35Z","pushed_at":"2018-10-25T01:27:38Z","git_url":"git://github.com/cmyr/xi-editor.git","ssh_url":"git@github.com:cmyr/xi-editor.git","clone_url":"https://github.com/cmyr/xi-editor.git","svn_url":"https://github.com/cmyr/xi-editor","homepage":"","size":7110,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"xi-editor:master","ref":"master","sha":"58be28a64bb7030832a54db3c7fe2d61395cc286","user":{"login":"xi-editor","id":43351123,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzMzUxMTIz","avatar_url":"https://avatars3.githubusercontent.com/u/43351123?v=4","gravatar_id":"","url":"https://api.github.com/users/xi-editor","html_url":"https://github.com/xi-editor","followers_url":"https://api.github.com/users/xi-editor/followers","following_url":"https://api.github.com/users/xi-editor/following{/other_user}","gists_url":"https://api.github.com/users/xi-editor/gists{/gist_id}","starred_url":"https://api.github.com/users/xi-editor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xi-editor/subscriptions","organizations_url":"https://api.github.com/users/xi-editor/orgs","repos_url":"https://api.github.com/users/xi-editor/repos","events_url":"https://api.github.com/users/xi-editor/events{/privacy}","received_events_url":"https://api.github.com/users/xi-editor/received_events","type":"Organization","site_admin":false},"repo":{"id":57167764,"node_id":"MDEwOlJlcG9zaXRvcnk1NzE2Nzc2NA==","name":"xi-editor","full_name":"xi-editor/xi-editor","private":false,"owner":{"login":"xi-editor","id":43351123,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzMzUxMTIz","avatar_url":"https://avatars3.githubusercontent.com/u/43351123?v=4","gravatar_id":"","url":"https://api.github.com/users/xi-editor","html_url":"https://github.com/xi-editor","followers_url":"https://api.github.com/users/xi-editor/followers","following_url":"https://api.github.com/users/xi-editor/following{/other_user}","gists_url":"https://api.github.com/users/xi-editor/gists{/gist_id}","starred_url":"https://api.github.com/users/xi-editor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xi-editor/subscriptions","organizations_url":"https://api.github.com/users/xi-editor/orgs","repos_url":"https://api.github.com/users/xi-editor/repos","events_url":"https://api.github.com/users/xi-editor/events{/privacy}","received_events_url":"https://api.github.com/users/xi-editor/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/xi-editor/xi-editor","description":"A modern editor with a backend written in Rust. https://xi-editor.github.io/xi-editor","fork":false,"url":"https://api.github.com/repos/xi-editor/xi-editor","forks_url":"https://api.github.com/repos/xi-editor/xi-editor/forks","keys_url":"https://api.github.com/repos/xi-editor/xi-editor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xi-editor/xi-editor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xi-editor/xi-editor/teams","hooks_url":"https://api.github.com/repos/xi-editor/xi-editor/hooks","issue_events_url":"https://api.github.com/repos/xi-editor/xi-editor/issues/events{/number}","events_url":"https://api.github.com/repos/xi-editor/xi-editor/events","assignees_url":"https://api.github.com/repos/xi-editor/xi-editor/assignees{/user}","branches_url":"https://api.github.com/repos/xi-editor/xi-editor/branches{/branch}","tags_url":"https://api.github.com/repos/xi-editor/xi-editor/tags","blobs_url":"https://api.github.com/repos/xi-editor/xi-editor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xi-editor/xi-editor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xi-editor/xi-editor/git/refs{/sha}","trees_url":"https://api.github.com/repos/xi-editor/xi-editor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xi-editor/xi-editor/statuses/{sha}","languages_url":"https://api.github.com/repos/xi-editor/xi-editor/languages","stargazers_url":"https://api.github.com/repos/xi-editor/xi-editor/stargazers","contributors_url":"https://api.github.com/repos/xi-editor/xi-editor/contributors","subscribers_url":"https://api.github.com/repos/xi-editor/xi-editor/subscribers","subscription_url":"https://api.github.com/repos/xi-editor/xi-editor/subscription","commits_url":"https://api.github.com/repos/xi-editor/xi-editor/commits{/sha}","git_commits_url":"https://api.github.com/repos/xi-editor/xi-editor/git/commits{/sha}","comments_url":"https://api.github.com/repos/xi-editor/xi-editor/comments{/number}","issue_comment_url":"https://api.github.com/repos/xi-editor/xi-editor/issues/comments{/number}","contents_url":"https://api.github.com/repos/xi-editor/xi-editor/contents/{+path}","compare_url":"https://api.github.com/repos/xi-editor/xi-editor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xi-editor/xi-editor/merges","archive_url":"https://api.github.com/repos/xi-editor/xi-editor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xi-editor/xi-editor/downloads","issues_url":"https://api.github.com/repos/xi-editor/xi-editor/issues{/number}","pulls_url":"https://api.github.com/repos/xi-editor/xi-editor/pulls{/number}","milestones_url":"https://api.github.com/repos/xi-editor/xi-editor/milestones{/number}","notifications_url":"https://api.github.com/repos/xi-editor/xi-editor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xi-editor/xi-editor/labels{/name}","releases_url":"https://api.github.com/repos/xi-editor/xi-editor/releases{/id}","deployments_url":"https://api.github.com/repos/xi-editor/xi-editor/deployments","created_at":"2016-04-26T23:03:23Z","updated_at":"2018-10-25T16:46:12Z","pushed_at":"2018-10-25T16:46:07Z","git_url":"git://github.com/xi-editor/xi-editor.git","ssh_url":"git@github.com:xi-editor/xi-editor.git","clone_url":"https://github.com/xi-editor/xi-editor.git","svn_url":"https://github.com/xi-editor/xi-editor","homepage":"","size":6363,"stargazers_count":15023,"watchers_count":15023,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":549,"mirror_url":null,"archived":false,"open_issues_count":141,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":549,"open_issues":141,"watchers":15023,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xi-editor/xi-editor/pulls/941"},"html":{"href":"https://github.com/xi-editor/xi-editor/pull/941"},"issue":{"href":"https://api.github.com/repos/xi-editor/xi-editor/issues/941"},"comments":{"href":"https://api.github.com/repos/xi-editor/xi-editor/issues/941/comments"},"review_comments":{"href":"https://api.github.com/repos/xi-editor/xi-editor/pulls/941/comments"},"review_comment":{"href":"https://api.github.com/repos/xi-editor/xi-editor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xi-editor/xi-editor/pulls/941/commits"},"statuses":{"href":"https://api.github.com/repos/xi-editor/xi-editor/statuses/9470601949a1447a28cb223aef468c5d21b14c52"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jansol"}}