{"action":"created","comment":{"url":"https://api.github.com/repos/smallrye/smallrye-open-api/pulls/comments/244774703","pull_request_review_id":188727738,"id":244774703,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDc3NDcwMw==","diff_hunk":"@@ -0,0 +1,66 @@\n+package io.smallrye.openapi.runtime.scanner;\n+\n+import java.util.Collection;\n+\n+import org.eclipse.microprofile.openapi.models.parameters.Parameter.In;\n+import org.jboss.jandex.ClassInfo;\n+import org.jboss.jandex.MethodInfo;\n+import org.jboss.jandex.MethodParameterInfo;\n+import org.jboss.jandex.Type;\n+\n+import io.smallrye.openapi.runtime.util.JandexUtil.JaxRsParameterInfo;\n+\n+/**\n+ * Extension point for supporting extensions to JAX-RS.\n+ */\n+public interface AnnotationScannerExtension {\n+\n+    /**\n+     * Determines where an @Parameter can be found (examples include Query,\n+     * Path, Header, Cookie, etc).\n+     * \n+     * @param paramInfo\n+     * @return the parameter location, or null if unknown\n+     */\n+    public default In parameterIn(MethodParameterInfo paramInfo) {\n+        return null;","path":"implementation/src/main/java/io/smallrye/openapi/runtime/scanner/AnnotationScannerExtension.java","position":null,"original_position":26,"commit_id":"a1cb1e6184ddf6a80e213cbc32f7a703293fb44e","original_commit_id":"e11a83fe23699e2d71886b06543078c74c7733e5","user":{"login":"FroMage","id":179265,"node_id":"MDQ6VXNlcjE3OTI2NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/179265?v=4","gravatar_id":"","url":"https://api.github.com/users/FroMage","html_url":"https://github.com/FroMage","followers_url":"https://api.github.com/users/FroMage/followers","following_url":"https://api.github.com/users/FroMage/following{/other_user}","gists_url":"https://api.github.com/users/FroMage/gists{/gist_id}","starred_url":"https://api.github.com/users/FroMage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FroMage/subscriptions","organizations_url":"https://api.github.com/users/FroMage/orgs","repos_url":"https://api.github.com/users/FroMage/repos","events_url":"https://api.github.com/users/FroMage/events{/privacy}","received_events_url":"https://api.github.com/users/FroMage/received_events","type":"User","site_admin":false},"body":"Because providing a default impl makes it instantly obvious to users what a valid default return value is. This shows that returning `null` is acceptable and will allow other extensions to participate. Otherwise you have to rely on javadoc and have no code to prove it.","created_at":"2019-01-02T15:59:57Z","updated_at":"2019-01-02T15:59:57Z","html_url":"https://github.com/smallrye/smallrye-open-api/pull/50#discussion_r244774703","pull_request_url":"https://api.github.com/repos/smallrye/smallrye-open-api/pulls/50","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/smallrye/smallrye-open-api/pulls/comments/244774703"},"html":{"href":"https://github.com/smallrye/smallrye-open-api/pull/50#discussion_r244774703"},"pull_request":{"href":"https://api.github.com/repos/smallrye/smallrye-open-api/pulls/50"}},"in_reply_to_id":244770636},"pull_request":{"url":"https://api.github.com/repos/smallrye/smallrye-open-api/pulls/50","id":235036880,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MDM2ODgw","html_url":"https://github.com/smallrye/smallrye-open-api/pull/50","diff_url":"https://github.com/smallrye/smallrye-open-api/pull/50.diff","patch_url":"https://github.com/smallrye/smallrye-open-api/pull/50.patch","issue_url":"https://api.github.com/repos/smallrye/smallrye-open-api/issues/50","number":50,"state":"closed","locked":false,"title":"Added support for CompletionStage and extensions","user":{"login":"FroMage","id":179265,"node_id":"MDQ6VXNlcjE3OTI2NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/179265?v=4","gravatar_id":"","url":"https://api.github.com/users/FroMage","html_url":"https://github.com/FroMage","followers_url":"https://api.github.com/users/FroMage/followers","following_url":"https://api.github.com/users/FroMage/following{/other_user}","gists_url":"https://api.github.com/users/FroMage/gists{/gist_id}","starred_url":"https://api.github.com/users/FroMage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FroMage/subscriptions","organizations_url":"https://api.github.com/users/FroMage/orgs","repos_url":"https://api.github.com/users/FroMage/repos","events_url":"https://api.github.com/users/FroMage/events{/privacy}","received_events_url":"https://api.github.com/users/FroMage/received_events","type":"User","site_admin":false},"body":"This is a preview PR for #46\r\n\r\nDon't merge it until https://github.com/wildfly/jandex/pull/43 is merged and jandex is released. However, this should support:\r\n\r\n- the JAX-RS 2.1 return type of `CompletionStage`\r\n- the ability to register extensions to the scanning process for:\r\n    - custom types such as RESTEasy `@*Param` that use the method parameter name\r\n    - custom async return types such as RESTEasy support for RxJava 1&2 `Single`\r\n\r\nPlease review so we can get this merged ASAP when Jandex is released. Thanks.","created_at":"2018-11-30T16:07:33Z","updated_at":"2019-01-02T15:59:57Z","closed_at":"2019-01-02T15:58:59Z","merged_at":"2019-01-02T15:58:59Z","merge_commit_sha":"49986269898fb94cab57ebeea9390e7c143e4495","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/smallrye/smallrye-open-api/pulls/50/commits","review_comments_url":"https://api.github.com/repos/smallrye/smallrye-open-api/pulls/50/comments","review_comment_url":"https://api.github.com/repos/smallrye/smallrye-open-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/smallrye/smallrye-open-api/issues/50/comments","statuses_url":"https://api.github.com/repos/smallrye/smallrye-open-api/statuses/a1cb1e6184ddf6a80e213cbc32f7a703293fb44e","head":{"label":"FroMage:extensions","ref":"extensions","sha":"a1cb1e6184ddf6a80e213cbc32f7a703293fb44e","user":{"login":"FroMage","id":179265,"node_id":"MDQ6VXNlcjE3OTI2NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/179265?v=4","gravatar_id":"","url":"https://api.github.com/users/FroMage","html_url":"https://github.com/FroMage","followers_url":"https://api.github.com/users/FroMage/followers","following_url":"https://api.github.com/users/FroMage/following{/other_user}","gists_url":"https://api.github.com/users/FroMage/gists{/gist_id}","starred_url":"https://api.github.com/users/FroMage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FroMage/subscriptions","organizations_url":"https://api.github.com/users/FroMage/orgs","repos_url":"https://api.github.com/users/FroMage/repos","events_url":"https://api.github.com/users/FroMage/events{/privacy}","received_events_url":"https://api.github.com/users/FroMage/received_events","type":"User","site_admin":false},"repo":{"id":159846971,"node_id":"MDEwOlJlcG9zaXRvcnkxNTk4NDY5NzE=","name":"smallrye-open-api","full_name":"FroMage/smallrye-open-api","private":false,"owner":{"login":"FroMage","id":179265,"node_id":"MDQ6VXNlcjE3OTI2NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/179265?v=4","gravatar_id":"","url":"https://api.github.com/users/FroMage","html_url":"https://github.com/FroMage","followers_url":"https://api.github.com/users/FroMage/followers","following_url":"https://api.github.com/users/FroMage/following{/other_user}","gists_url":"https://api.github.com/users/FroMage/gists{/gist_id}","starred_url":"https://api.github.com/users/FroMage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FroMage/subscriptions","organizations_url":"https://api.github.com/users/FroMage/orgs","repos_url":"https://api.github.com/users/FroMage/repos","events_url":"https://api.github.com/users/FroMage/events{/privacy}","received_events_url":"https://api.github.com/users/FroMage/received_events","type":"User","site_admin":false},"html_url":"https://github.com/FroMage/smallrye-open-api","description":null,"fork":true,"url":"https://api.github.com/repos/FroMage/smallrye-open-api","forks_url":"https://api.github.com/repos/FroMage/smallrye-open-api/forks","keys_url":"https://api.github.com/repos/FroMage/smallrye-open-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FroMage/smallrye-open-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FroMage/smallrye-open-api/teams","hooks_url":"https://api.github.com/repos/FroMage/smallrye-open-api/hooks","issue_events_url":"https://api.github.com/repos/FroMage/smallrye-open-api/issues/events{/number}","events_url":"https://api.github.com/repos/FroMage/smallrye-open-api/events","assignees_url":"https://api.github.com/repos/FroMage/smallrye-open-api/assignees{/user}","branches_url":"https://api.github.com/repos/FroMage/smallrye-open-api/branches{/branch}","tags_url":"https://api.github.com/repos/FroMage/smallrye-open-api/tags","blobs_url":"https://api.github.com/repos/FroMage/smallrye-open-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FroMage/smallrye-open-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FroMage/smallrye-open-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/FroMage/smallrye-open-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FroMage/smallrye-open-api/statuses/{sha}","languages_url":"https://api.github.com/repos/FroMage/smallrye-open-api/languages","stargazers_url":"https://api.github.com/repos/FroMage/smallrye-open-api/stargazers","contributors_url":"https://api.github.com/repos/FroMage/smallrye-open-api/contributors","subscribers_url":"https://api.github.com/repos/FroMage/smallrye-open-api/subscribers","subscription_url":"https://api.github.com/repos/FroMage/smallrye-open-api/subscription","commits_url":"https://api.github.com/repos/FroMage/smallrye-open-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/FroMage/smallrye-open-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/FroMage/smallrye-open-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/FroMage/smallrye-open-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/FroMage/smallrye-open-api/contents/{+path}","compare_url":"https://api.github.com/repos/FroMage/smallrye-open-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FroMage/smallrye-open-api/merges","archive_url":"https://api.github.com/repos/FroMage/smallrye-open-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FroMage/smallrye-open-api/downloads","issues_url":"https://api.github.com/repos/FroMage/smallrye-open-api/issues{/number}","pulls_url":"https://api.github.com/repos/FroMage/smallrye-open-api/pulls{/number}","milestones_url":"https://api.github.com/repos/FroMage/smallrye-open-api/milestones{/number}","notifications_url":"https://api.github.com/repos/FroMage/smallrye-open-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FroMage/smallrye-open-api/labels{/name}","releases_url":"https://api.github.com/repos/FroMage/smallrye-open-api/releases{/id}","deployments_url":"https://api.github.com/repos/FroMage/smallrye-open-api/deployments","created_at":"2018-11-30T16:03:45Z","updated_at":"2018-11-30T16:03:47Z","pushed_at":"2019-01-02T15:56:14Z","git_url":"git://github.com/FroMage/smallrye-open-api.git","ssh_url":"git@github.com:FroMage/smallrye-open-api.git","clone_url":"https://github.com/FroMage/smallrye-open-api.git","svn_url":"https://github.com/FroMage/smallrye-open-api","homepage":null,"size":269,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"smallrye:master","ref":"master","sha":"daea042aea451342456c2d4b001bda7dbaf5effe","user":{"login":"smallrye","id":38892730,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4ODkyNzMw","avatar_url":"https://avatars3.githubusercontent.com/u/38892730?v=4","gravatar_id":"","url":"https://api.github.com/users/smallrye","html_url":"https://github.com/smallrye","followers_url":"https://api.github.com/users/smallrye/followers","following_url":"https://api.github.com/users/smallrye/following{/other_user}","gists_url":"https://api.github.com/users/smallrye/gists{/gist_id}","starred_url":"https://api.github.com/users/smallrye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smallrye/subscriptions","organizations_url":"https://api.github.com/users/smallrye/orgs","repos_url":"https://api.github.com/users/smallrye/repos","events_url":"https://api.github.com/users/smallrye/events{/privacy}","received_events_url":"https://api.github.com/users/smallrye/received_events","type":"Organization","site_admin":false},"repo":{"id":134901201,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ5MDEyMDE=","name":"smallrye-open-api","full_name":"smallrye/smallrye-open-api","private":false,"owner":{"login":"smallrye","id":38892730,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4ODkyNzMw","avatar_url":"https://avatars3.githubusercontent.com/u/38892730?v=4","gravatar_id":"","url":"https://api.github.com/users/smallrye","html_url":"https://github.com/smallrye","followers_url":"https://api.github.com/users/smallrye/followers","following_url":"https://api.github.com/users/smallrye/following{/other_user}","gists_url":"https://api.github.com/users/smallrye/gists{/gist_id}","starred_url":"https://api.github.com/users/smallrye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smallrye/subscriptions","organizations_url":"https://api.github.com/users/smallrye/orgs","repos_url":"https://api.github.com/users/smallrye/repos","events_url":"https://api.github.com/users/smallrye/events{/privacy}","received_events_url":"https://api.github.com/users/smallrye/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/smallrye/smallrye-open-api","description":null,"fork":false,"url":"https://api.github.com/repos/smallrye/smallrye-open-api","forks_url":"https://api.github.com/repos/smallrye/smallrye-open-api/forks","keys_url":"https://api.github.com/repos/smallrye/smallrye-open-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smallrye/smallrye-open-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smallrye/smallrye-open-api/teams","hooks_url":"https://api.github.com/repos/smallrye/smallrye-open-api/hooks","issue_events_url":"https://api.github.com/repos/smallrye/smallrye-open-api/issues/events{/number}","events_url":"https://api.github.com/repos/smallrye/smallrye-open-api/events","assignees_url":"https://api.github.com/repos/smallrye/smallrye-open-api/assignees{/user}","branches_url":"https://api.github.com/repos/smallrye/smallrye-open-api/branches{/branch}","tags_url":"https://api.github.com/repos/smallrye/smallrye-open-api/tags","blobs_url":"https://api.github.com/repos/smallrye/smallrye-open-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smallrye/smallrye-open-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smallrye/smallrye-open-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/smallrye/smallrye-open-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smallrye/smallrye-open-api/statuses/{sha}","languages_url":"https://api.github.com/repos/smallrye/smallrye-open-api/languages","stargazers_url":"https://api.github.com/repos/smallrye/smallrye-open-api/stargazers","contributors_url":"https://api.github.com/repos/smallrye/smallrye-open-api/contributors","subscribers_url":"https://api.github.com/repos/smallrye/smallrye-open-api/subscribers","subscription_url":"https://api.github.com/repos/smallrye/smallrye-open-api/subscription","commits_url":"https://api.github.com/repos/smallrye/smallrye-open-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/smallrye/smallrye-open-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/smallrye/smallrye-open-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/smallrye/smallrye-open-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/smallrye/smallrye-open-api/contents/{+path}","compare_url":"https://api.github.com/repos/smallrye/smallrye-open-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smallrye/smallrye-open-api/merges","archive_url":"https://api.github.com/repos/smallrye/smallrye-open-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smallrye/smallrye-open-api/downloads","issues_url":"https://api.github.com/repos/smallrye/smallrye-open-api/issues{/number}","pulls_url":"https://api.github.com/repos/smallrye/smallrye-open-api/pulls{/number}","milestones_url":"https://api.github.com/repos/smallrye/smallrye-open-api/milestones{/number}","notifications_url":"https://api.github.com/repos/smallrye/smallrye-open-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smallrye/smallrye-open-api/labels{/name}","releases_url":"https://api.github.com/repos/smallrye/smallrye-open-api/releases{/id}","deployments_url":"https://api.github.com/repos/smallrye/smallrye-open-api/deployments","created_at":"2018-05-25T20:20:58Z","updated_at":"2019-01-02T15:59:03Z","pushed_at":"2019-01-02T15:59:53Z","git_url":"git://github.com/smallrye/smallrye-open-api.git","ssh_url":"git@github.com:smallrye/smallrye-open-api.git","clone_url":"https://github.com/smallrye/smallrye-open-api.git","svn_url":"https://github.com/smallrye/smallrye-open-api","homepage":null,"size":276,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":15,"license":null,"forks":10,"open_issues":15,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/smallrye/smallrye-open-api/pulls/50"},"html":{"href":"https://github.com/smallrye/smallrye-open-api/pull/50"},"issue":{"href":"https://api.github.com/repos/smallrye/smallrye-open-api/issues/50"},"comments":{"href":"https://api.github.com/repos/smallrye/smallrye-open-api/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/smallrye/smallrye-open-api/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/smallrye/smallrye-open-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/smallrye/smallrye-open-api/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/smallrye/smallrye-open-api/statuses/a1cb1e6184ddf6a80e213cbc32f7a703293fb44e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"FroMage"}}