{"action":"closed","number":4351,"pull_request":{"url":"https://api.github.com/repos/BabylonJS/Babylon.js/pulls/4351","id":189477553,"html_url":"https://github.com/BabylonJS/Babylon.js/pull/4351","diff_url":"https://github.com/BabylonJS/Babylon.js/pull/4351.diff","patch_url":"https://github.com/BabylonJS/Babylon.js/pull/4351.patch","issue_url":"https://api.github.com/repos/BabylonJS/Babylon.js/issues/4351","number":4351,"state":"closed","locked":false,"title":"[Viewer] Lab feature - global light rotation for the configuration","user":{"login":"RaananW","id":1381702,"avatar_url":"https://avatars0.githubusercontent.com/u/1381702?v=4","gravatar_id":"","url":"https://api.github.com/users/RaananW","html_url":"https://github.com/RaananW","followers_url":"https://api.github.com/users/RaananW/followers","following_url":"https://api.github.com/users/RaananW/following{/other_user}","gists_url":"https://api.github.com/users/RaananW/gists{/gist_id}","starred_url":"https://api.github.com/users/RaananW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaananW/subscriptions","organizations_url":"https://api.github.com/users/RaananW/orgs","repos_url":"https://api.github.com/users/RaananW/repos","events_url":"https://api.github.com/users/RaananW/events{/privacy}","received_events_url":"https://api.github.com/users/RaananW/received_events","type":"User","site_admin":false},"body":"The global light rotation will turn the shadow lights in the scene around the UP axis and will set the target again (per default to 0,0,0) so that the shadows will be updated correctly.\r\nNote that the changes are from the current state of the light, so a second call with global light rotation of 0.1 will result in 0.2 rotation.\r\n\r\nDemo (updating global light rotation on every frame, amount 0.01):\r\n\r\n![babylonjs viewer - basic usage - edited](https://user-images.githubusercontent.com/1381702/40327921-dae6907c-5d44-11e8-82cc-ebd4206983f0.gif)\r\n\r\nCode for the demo:\r\n\r\n```javascript\r\nviewer.sceneManager.scene.registerBeforeRender(() => {\r\n                            viewer.updateConfiguration({\r\n                                lab: {\r\n                                    globalLightRotation: 0.01\r\n                                }\r\n                            })\r\n                        });\r\n```\r\nIssue - https://github.com/BabylonJS/Babylon.js/issues/4347","created_at":"2018-05-21T20:18:49Z","updated_at":"2018-05-22T13:45:58Z","closed_at":"2018-05-22T13:45:57Z","merged_at":"2018-05-22T13:45:57Z","merge_commit_sha":"210d3581697f42912275de15a3d30edf1da5fa1f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/BabylonJS/Babylon.js/pulls/4351/commits","review_comments_url":"https://api.github.com/repos/BabylonJS/Babylon.js/pulls/4351/comments","review_comment_url":"https://api.github.com/repos/BabylonJS/Babylon.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BabylonJS/Babylon.js/issues/4351/comments","statuses_url":"https://api.github.com/repos/BabylonJS/Babylon.js/statuses/97410d5bae416a98d41044e8347cac690aded39e","head":{"label":"RaananW:configuration-stuff","ref":"configuration-stuff","sha":"97410d5bae416a98d41044e8347cac690aded39e","user":{"login":"RaananW","id":1381702,"avatar_url":"https://avatars0.githubusercontent.com/u/1381702?v=4","gravatar_id":"","url":"https://api.github.com/users/RaananW","html_url":"https://github.com/RaananW","followers_url":"https://api.github.com/users/RaananW/followers","following_url":"https://api.github.com/users/RaananW/following{/other_user}","gists_url":"https://api.github.com/users/RaananW/gists{/gist_id}","starred_url":"https://api.github.com/users/RaananW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaananW/subscriptions","organizations_url":"https://api.github.com/users/RaananW/orgs","repos_url":"https://api.github.com/users/RaananW/repos","events_url":"https://api.github.com/users/RaananW/events{/privacy}","received_events_url":"https://api.github.com/users/RaananW/received_events","type":"User","site_admin":false},"repo":{"id":27167103,"name":"Babylon.js","full_name":"RaananW/Babylon.js","owner":{"login":"RaananW","id":1381702,"avatar_url":"https://avatars0.githubusercontent.com/u/1381702?v=4","gravatar_id":"","url":"https://api.github.com/users/RaananW","html_url":"https://github.com/RaananW","followers_url":"https://api.github.com/users/RaananW/followers","following_url":"https://api.github.com/users/RaananW/following{/other_user}","gists_url":"https://api.github.com/users/RaananW/gists{/gist_id}","starred_url":"https://api.github.com/users/RaananW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaananW/subscriptions","organizations_url":"https://api.github.com/users/RaananW/orgs","repos_url":"https://api.github.com/users/RaananW/repos","events_url":"https://api.github.com/users/RaananW/events{/privacy}","received_events_url":"https://api.github.com/users/RaananW/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RaananW/Babylon.js","description":"Babylon.js: a complete JavaScript framework for building 3D games with HTML 5 and WebGL","fork":true,"url":"https://api.github.com/repos/RaananW/Babylon.js","forks_url":"https://api.github.com/repos/RaananW/Babylon.js/forks","keys_url":"https://api.github.com/repos/RaananW/Babylon.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RaananW/Babylon.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RaananW/Babylon.js/teams","hooks_url":"https://api.github.com/repos/RaananW/Babylon.js/hooks","issue_events_url":"https://api.github.com/repos/RaananW/Babylon.js/issues/events{/number}","events_url":"https://api.github.com/repos/RaananW/Babylon.js/events","assignees_url":"https://api.github.com/repos/RaananW/Babylon.js/assignees{/user}","branches_url":"https://api.github.com/repos/RaananW/Babylon.js/branches{/branch}","tags_url":"https://api.github.com/repos/RaananW/Babylon.js/tags","blobs_url":"https://api.github.com/repos/RaananW/Babylon.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RaananW/Babylon.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RaananW/Babylon.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/RaananW/Babylon.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RaananW/Babylon.js/statuses/{sha}","languages_url":"https://api.github.com/repos/RaananW/Babylon.js/languages","stargazers_url":"https://api.github.com/repos/RaananW/Babylon.js/stargazers","contributors_url":"https://api.github.com/repos/RaananW/Babylon.js/contributors","subscribers_url":"https://api.github.com/repos/RaananW/Babylon.js/subscribers","subscription_url":"https://api.github.com/repos/RaananW/Babylon.js/subscription","commits_url":"https://api.github.com/repos/RaananW/Babylon.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/RaananW/Babylon.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/RaananW/Babylon.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/RaananW/Babylon.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/RaananW/Babylon.js/contents/{+path}","compare_url":"https://api.github.com/repos/RaananW/Babylon.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RaananW/Babylon.js/merges","archive_url":"https://api.github.com/repos/RaananW/Babylon.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RaananW/Babylon.js/downloads","issues_url":"https://api.github.com/repos/RaananW/Babylon.js/issues{/number}","pulls_url":"https://api.github.com/repos/RaananW/Babylon.js/pulls{/number}","milestones_url":"https://api.github.com/repos/RaananW/Babylon.js/milestones{/number}","notifications_url":"https://api.github.com/repos/RaananW/Babylon.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RaananW/Babylon.js/labels{/name}","releases_url":"https://api.github.com/repos/RaananW/Babylon.js/releases{/id}","deployments_url":"https://api.github.com/repos/RaananW/Babylon.js/deployments","created_at":"2014-11-26T08:35:20Z","updated_at":"2018-05-22T11:46:06Z","pushed_at":"2018-05-22T11:46:02Z","git_url":"git://github.com/RaananW/Babylon.js.git","ssh_url":"git@github.com:RaananW/Babylon.js.git","clone_url":"https://github.com/RaananW/Babylon.js.git","svn_url":"https://github.com/RaananW/Babylon.js","homepage":null,"size":1187019,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"BabylonJS:master","ref":"master","sha":"4384c14d716ee3560f3233a78888cff748c035df","user":{"login":"BabylonJS","id":4855800,"avatar_url":"https://avatars1.githubusercontent.com/u/4855800?v=4","gravatar_id":"","url":"https://api.github.com/users/BabylonJS","html_url":"https://github.com/BabylonJS","followers_url":"https://api.github.com/users/BabylonJS/followers","following_url":"https://api.github.com/users/BabylonJS/following{/other_user}","gists_url":"https://api.github.com/users/BabylonJS/gists{/gist_id}","starred_url":"https://api.github.com/users/BabylonJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BabylonJS/subscriptions","organizations_url":"https://api.github.com/users/BabylonJS/orgs","repos_url":"https://api.github.com/users/BabylonJS/repos","events_url":"https://api.github.com/users/BabylonJS/events{/privacy}","received_events_url":"https://api.github.com/users/BabylonJS/received_events","type":"Organization","site_admin":false},"repo":{"id":11007313,"name":"Babylon.js","full_name":"BabylonJS/Babylon.js","owner":{"login":"BabylonJS","id":4855800,"avatar_url":"https://avatars1.githubusercontent.com/u/4855800?v=4","gravatar_id":"","url":"https://api.github.com/users/BabylonJS","html_url":"https://github.com/BabylonJS","followers_url":"https://api.github.com/users/BabylonJS/followers","following_url":"https://api.github.com/users/BabylonJS/following{/other_user}","gists_url":"https://api.github.com/users/BabylonJS/gists{/gist_id}","starred_url":"https://api.github.com/users/BabylonJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BabylonJS/subscriptions","organizations_url":"https://api.github.com/users/BabylonJS/orgs","repos_url":"https://api.github.com/users/BabylonJS/repos","events_url":"https://api.github.com/users/BabylonJS/events{/privacy}","received_events_url":"https://api.github.com/users/BabylonJS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BabylonJS/Babylon.js","description":"Babylon.js: a complete JavaScript framework for building 3D games with HTML 5 and WebGL","fork":false,"url":"https://api.github.com/repos/BabylonJS/Babylon.js","forks_url":"https://api.github.com/repos/BabylonJS/Babylon.js/forks","keys_url":"https://api.github.com/repos/BabylonJS/Babylon.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BabylonJS/Babylon.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BabylonJS/Babylon.js/teams","hooks_url":"https://api.github.com/repos/BabylonJS/Babylon.js/hooks","issue_events_url":"https://api.github.com/repos/BabylonJS/Babylon.js/issues/events{/number}","events_url":"https://api.github.com/repos/BabylonJS/Babylon.js/events","assignees_url":"https://api.github.com/repos/BabylonJS/Babylon.js/assignees{/user}","branches_url":"https://api.github.com/repos/BabylonJS/Babylon.js/branches{/branch}","tags_url":"https://api.github.com/repos/BabylonJS/Babylon.js/tags","blobs_url":"https://api.github.com/repos/BabylonJS/Babylon.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BabylonJS/Babylon.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BabylonJS/Babylon.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/BabylonJS/Babylon.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BabylonJS/Babylon.js/statuses/{sha}","languages_url":"https://api.github.com/repos/BabylonJS/Babylon.js/languages","stargazers_url":"https://api.github.com/repos/BabylonJS/Babylon.js/stargazers","contributors_url":"https://api.github.com/repos/BabylonJS/Babylon.js/contributors","subscribers_url":"https://api.github.com/repos/BabylonJS/Babylon.js/subscribers","subscription_url":"https://api.github.com/repos/BabylonJS/Babylon.js/subscription","commits_url":"https://api.github.com/repos/BabylonJS/Babylon.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/BabylonJS/Babylon.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/BabylonJS/Babylon.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/BabylonJS/Babylon.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/BabylonJS/Babylon.js/contents/{+path}","compare_url":"https://api.github.com/repos/BabylonJS/Babylon.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BabylonJS/Babylon.js/merges","archive_url":"https://api.github.com/repos/BabylonJS/Babylon.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BabylonJS/Babylon.js/downloads","issues_url":"https://api.github.com/repos/BabylonJS/Babylon.js/issues{/number}","pulls_url":"https://api.github.com/repos/BabylonJS/Babylon.js/pulls{/number}","milestones_url":"https://api.github.com/repos/BabylonJS/Babylon.js/milestones{/number}","notifications_url":"https://api.github.com/repos/BabylonJS/Babylon.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BabylonJS/Babylon.js/labels{/name}","releases_url":"https://api.github.com/repos/BabylonJS/Babylon.js/releases{/id}","deployments_url":"https://api.github.com/repos/BabylonJS/Babylon.js/deployments","created_at":"2013-06-27T20:40:42Z","updated_at":"2018-05-22T12:11:17Z","pushed_at":"2018-05-22T13:45:57Z","git_url":"git://github.com/BabylonJS/Babylon.js.git","ssh_url":"git@github.com:BabylonJS/Babylon.js.git","clone_url":"https://github.com/BabylonJS/Babylon.js.git","svn_url":"https://github.com/BabylonJS/Babylon.js","homepage":"http://www.babylonjs.com","size":1186573,"stargazers_count":6794,"watchers_count":6794,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1458,"mirror_url":null,"archived":false,"open_issues_count":67,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1458,"open_issues":67,"watchers":6794,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BabylonJS/Babylon.js/pulls/4351"},"html":{"href":"https://github.com/BabylonJS/Babylon.js/pull/4351"},"issue":{"href":"https://api.github.com/repos/BabylonJS/Babylon.js/issues/4351"},"comments":{"href":"https://api.github.com/repos/BabylonJS/Babylon.js/issues/4351/comments"},"review_comments":{"href":"https://api.github.com/repos/BabylonJS/Babylon.js/pulls/4351/comments"},"review_comment":{"href":"https://api.github.com/repos/BabylonJS/Babylon.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BabylonJS/Babylon.js/pulls/4351/commits"},"statuses":{"href":"https://api.github.com/repos/BabylonJS/Babylon.js/statuses/97410d5bae416a98d41044e8347cac690aded39e"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"RaananW","id":1381702,"avatar_url":"https://avatars0.githubusercontent.com/u/1381702?v=4","gravatar_id":"","url":"https://api.github.com/users/RaananW","html_url":"https://github.com/RaananW","followers_url":"https://api.github.com/users/RaananW/followers","following_url":"https://api.github.com/users/RaananW/following{/other_user}","gists_url":"https://api.github.com/users/RaananW/gists{/gist_id}","starred_url":"https://api.github.com/users/RaananW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaananW/subscriptions","organizations_url":"https://api.github.com/users/RaananW/orgs","repos_url":"https://api.github.com/users/RaananW/repos","events_url":"https://api.github.com/users/RaananW/events{/privacy}","received_events_url":"https://api.github.com/users/RaananW/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":67,"deletions":21,"changed_files":5}}
{"actor":{"display_login":"RaananW"}}