{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/installer/issues/556","repository_url":"https://api.github.com/repos/openshift/installer","labels_url":"https://api.github.com/repos/openshift/installer/issues/556/labels{/name}","comments_url":"https://api.github.com/repos/openshift/installer/issues/556/comments","events_url":"https://api.github.com/repos/openshift/installer/issues/556/events","html_url":"https://github.com/openshift/installer/pull/556","id":374585279,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MjU1MjUx","number":556,"title":"WIP: RFC: pkg/assets: Merkle DAG asset library","user":{"login":"wking","id":209920,"node_id":"MDQ6VXNlcjIwOTkyMA==","avatar_url":"https://avatars1.githubusercontent.com/u/209920?v=4","gravatar_id":"","url":"https://api.github.com/users/wking","html_url":"https://github.com/wking","followers_url":"https://api.github.com/users/wking/followers","following_url":"https://api.github.com/users/wking/following{/other_user}","gists_url":"https://api.github.com/users/wking/gists{/gist_id}","starred_url":"https://api.github.com/users/wking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wking/subscriptions","organizations_url":"https://api.github.com/users/wking/orgs","repos_url":"https://api.github.com/users/wking/repos","events_url":"https://api.github.com/users/wking/events{/privacy}","received_events_url":"https://api.github.com/users/wking/received_events","type":"User","site_admin":false},"labels":[{"id":959732229,"node_id":"MDU6TGFiZWw5NTk3MzIyMjk=","url":"https://api.github.com/repos/openshift/installer/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":959731323,"node_id":"MDU6TGFiZWw5NTk3MzEzMjM=","url":"https://api.github.com/repos/openshift/installer/labels/do-not-merge/work-in-progress","name":"do-not-merge/work-in-progress","color":"e11d21","default":false},{"id":959732996,"node_id":"MDU6TGFiZWw5NTk3MzI5OTY=","url":"https://api.github.com/repos/openshift/installer/labels/needs-rebase","name":"needs-rebase","color":"BDBDBD","default":false},{"id":959730581,"node_id":"MDU6TGFiZWw5NTk3MzA1ODE=","url":"https://api.github.com/repos/openshift/installer/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":17,"created_at":"2018-10-27T00:15:16Z","updated_at":"2018-11-29T22:45:05Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/openshift/installer/pulls/556","html_url":"https://github.com/openshift/installer/pull/556","diff_url":"https://github.com/openshift/installer/pull/556.diff","patch_url":"https://github.com/openshift/installer/pull/556.patch"},"body":"Our current `pkg/asset` approach requires multiple stages to run, and selecting those stages requires some dev planning and user education.  This new package allows us to dump the whole asset graph at once, and then edit/rebuild multiple times while maintaining a consistent asset state.  I *think* this will be easier for folks to wrap their heads around, but I'm not always the best judge of approachability ;).  Check out the updated user docs (included in the PR) for an overview of the new approach.\n\nIf folks think this approach is worthwhile, I can keep working through the process of porting our old assets over to the new framework.  Currently there are only a handful as a proof-of-concept."},"comment":{"url":"https://api.github.com/repos/openshift/installer/issues/comments/443022155","html_url":"https://github.com/openshift/installer/pull/556#issuecomment-443022155","issue_url":"https://api.github.com/repos/openshift/installer/issues/556","id":443022155,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MzAyMjE1NQ==","user":{"login":"openshift-ci-robot","id":30189103,"node_id":"MDQ6VXNlcjMwMTg5MTAz","avatar_url":"https://avatars1.githubusercontent.com/u/30189103?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift-ci-robot","html_url":"https://github.com/openshift-ci-robot","followers_url":"https://api.github.com/users/openshift-ci-robot/followers","following_url":"https://api.github.com/users/openshift-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/openshift-ci-robot/orgs","repos_url":"https://api.github.com/users/openshift-ci-robot/repos","events_url":"https://api.github.com/users/openshift-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-11-29T22:45:05Z","updated_at":"2018-11-29T22:45:05Z","author_association":"NONE","body":"@wking: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nci/prow/yaml-lint | 39100607e48ea3eabcb2e4a045407dd69cbbdc14 | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_installer/556/pull-ci-openshift-installer-yaml-lint/1714) | `/test yaml-lint`\nci/prow/govet | 39100607e48ea3eabcb2e4a045407dd69cbbdc14 | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_installer/556/pull-ci-openshift-installer-master-govet/1304) | `/test govet`\nci/prow/gofmt | 39100607e48ea3eabcb2e4a045407dd69cbbdc14 | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_installer/556/pull-ci-openshift-installer-master-gofmt/1301) | `/test gofmt`\nci/prow/unit | 39100607e48ea3eabcb2e4a045407dd69cbbdc14 | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_installer/556/pull-ci-openshift-installer-master-unit/1303) | `/test unit`\nci/prow/images | 39100607e48ea3eabcb2e4a045407dd69cbbdc14 | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_installer/556/pull-ci-openshift-installer-master-images/1220) | `/test images`\nci/prow/e2e-aws | 39100607e48ea3eabcb2e4a045407dd69cbbdc14 | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_installer/556/pull-ci-openshift-installer-master-e2e-aws/1557) | `/test e2e-aws`\nci/prow/e2e-libvirt | 39100607e48ea3eabcb2e4a045407dd69cbbdc14 | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_installer/556/pull-ci-openshift-installer-master-e2e-libvirt/20) | `/test e2e-libvirt`\nci/prow/tf-fmt | 39100607e48ea3eabcb2e4a045407dd69cbbdc14 | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_installer/556/pull-ci-openshift-installer-tf-fmt/1717) | `/test tf-fmt`\nci/prow/shellcheck | a025942e075aa01ab392de27597a52cab0ac0c5a | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_installer/556/pull-ci-openshift-installer-shellcheck/1828) | `/test shellcheck`\nci/prow/golint | a025942e075aa01ab392de27597a52cab0ac0c5a | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_installer/556/pull-ci-openshift-installer-master-golint/1414) | `/test golint`\n\n[Full PR test history](https://openshift-gce-devel.appspot.com/pr/openshift_installer/556). [Your PR dashboard](https://openshift-gce-devel.appspot.com/pr/wking). Please help us cut down on flakes by [linking to](https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/openshift/installer/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"openshift-ci-robot"}}