{"action":"created","issue":{"url":"https://api.github.com/repos/e2nIEE/pandapower/issues/208","repository_url":"https://api.github.com/repos/e2nIEE/pandapower","labels_url":"https://api.github.com/repos/e2nIEE/pandapower/issues/208/labels{/name}","comments_url":"https://api.github.com/repos/e2nIEE/pandapower/issues/208/comments","events_url":"https://api.github.com/repos/e2nIEE/pandapower/issues/208/events","html_url":"https://github.com/e2nIEE/pandapower/issues/208","id":379762245,"node_id":"MDU6SXNzdWUzNzk3NjIyNDU=","number":208,"title":"Changing the signing system for generators","user":{"login":"lthurner","id":23637821,"node_id":"MDQ6VXNlcjIzNjM3ODIx","avatar_url":"https://avatars1.githubusercontent.com/u/23637821?v=4","gravatar_id":"","url":"https://api.github.com/users/lthurner","html_url":"https://github.com/lthurner","followers_url":"https://api.github.com/users/lthurner/followers","following_url":"https://api.github.com/users/lthurner/following{/other_user}","gists_url":"https://api.github.com/users/lthurner/gists{/gist_id}","starred_url":"https://api.github.com/users/lthurner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lthurner/subscriptions","organizations_url":"https://api.github.com/users/lthurner/orgs","repos_url":"https://api.github.com/users/lthurner/repos","events_url":"https://api.github.com/users/lthurner/events{/privacy}","received_events_url":"https://api.github.com/users/lthurner/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/e2nIEE/pandapower/milestones/1","html_url":"https://github.com/e2nIEE/pandapower/milestone/1","labels_url":"https://api.github.com/repos/e2nIEE/pandapower/milestones/1/labels","id":3815226,"node_id":"MDk6TWlsZXN0b25lMzgxNTIyNg==","number":1,"title":"pandapower 2.0","description":"Pandapower goes optimization!","creator":{"login":"friederikemeier","id":11868107,"node_id":"MDQ6VXNlcjExODY4MTA3","avatar_url":"https://avatars0.githubusercontent.com/u/11868107?v=4","gravatar_id":"","url":"https://api.github.com/users/friederikemeier","html_url":"https://github.com/friederikemeier","followers_url":"https://api.github.com/users/friederikemeier/followers","following_url":"https://api.github.com/users/friederikemeier/following{/other_user}","gists_url":"https://api.github.com/users/friederikemeier/gists{/gist_id}","starred_url":"https://api.github.com/users/friederikemeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/friederikemeier/subscriptions","organizations_url":"https://api.github.com/users/friederikemeier/orgs","repos_url":"https://api.github.com/users/friederikemeier/repos","events_url":"https://api.github.com/users/friederikemeier/events{/privacy}","received_events_url":"https://api.github.com/users/friederikemeier/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":1,"state":"open","created_at":"2018-11-12T17:34:40Z","updated_at":"2018-11-13T12:06:54Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2018-11-12T12:49:18Z","updated_at":"2018-11-13T14:12:59Z","closed_at":null,"author_association":"COLLABORATOR","body":"pandapower was traditionally developed as a tool for distribution system analysis, so that our initial decision was to keep all power system values from the load viewpoint. This wasn't a bad decision at the time, but since pandapower has moved to higher voltage levels, this is becoming increasingly impractical. For example, constraints for a generator with a maximum power of 1MW have to be defined as min_p_kw=-1000 and max_p_kw=0. Because of the negative sign of generated power, costs also have to be entered as negative values.\r\n\r\nAll this is obviously not very intuitive, but of course changing this would not be backwards compatible and break a lot of code, so that we have not tackled this problem. This issue now came up again with the PowerModels interface #207, and it might be time to adress this issue even if it will make a major release necessary.\r\n\r\nThe suggestion is to change the power values in gen, sgen and ext_grid to the generation viewpoint and leave everything else like it is now. Of course the definition of constraints and cost values would also have to be adapted accordingly.\r\n "},"comment":{"url":"https://api.github.com/repos/e2nIEE/pandapower/issues/comments/438279733","html_url":"https://github.com/e2nIEE/pandapower/issues/208#issuecomment-438279733","issue_url":"https://api.github.com/repos/e2nIEE/pandapower/issues/208","id":438279733,"node_id":"MDEyOklzc3VlQ29tbWVudDQzODI3OTczMw==","user":{"login":"lthurner","id":23637821,"node_id":"MDQ6VXNlcjIzNjM3ODIx","avatar_url":"https://avatars1.githubusercontent.com/u/23637821?v=4","gravatar_id":"","url":"https://api.github.com/users/lthurner","html_url":"https://github.com/lthurner","followers_url":"https://api.github.com/users/lthurner/followers","following_url":"https://api.github.com/users/lthurner/following{/other_user}","gists_url":"https://api.github.com/users/lthurner/gists{/gist_id}","starred_url":"https://api.github.com/users/lthurner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lthurner/subscriptions","organizations_url":"https://api.github.com/users/lthurner/orgs","repos_url":"https://api.github.com/users/lthurner/repos","events_url":"https://api.github.com/users/lthurner/events{/privacy}","received_events_url":"https://api.github.com/users/lthurner/received_events","type":"User","site_admin":false},"created_at":"2018-11-13T14:12:59Z","updated_at":"2018-11-13T14:12:59Z","author_association":"COLLABORATOR","body":"There are some elements that can have both negative and positive active power. Storage is one of them, but there are also shunts, wards/xwards and ext_grids. To have as least changes as possible, I would only change the signing system in the cases where it is clear that it should behave like a generator (which from my perspective is gen, ext_grid and sgen, but of course this is up for debate) and leave all other elements as they are now."}}
{"actor":{"display_login":"lthurner"}}