{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/232781433","pull_request_review_id":174055439,"id":232781433,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjc4MTQzMw==","diff_hunk":"@@ -2400,21 +2401,21 @@ void TFDeabstraction::evaluateAttributesAndDoPacking(\n                       \"' \" + message.str());\n     };\n \n-    // Ok, we have an attribute argument, we should have been able to fold it\n-    // through our constexpr evaluation logic.\n+    // Ok, we have an attribute argument, try const-folding it through our\n+    // constexpr evaluation logic, so that we can run it in the graph. If this\n+    // fails, we will run it out-of-graph (via eager op dispatch).\n+    auto attrIdentifier =\n+        context.getIdentifier(argument.getArgumentNameWithSuffix());\n     auto it = constants.find(argumentValue);\n     if (it == constants.end() || !it->second.isConstant()) {\n-      // TODO: improve the diagnostic to talk about the parameter label in\n-      // the user code, not the internal op attribute.  The bookkeeping for\n-      // this isn't obvious though.\n-      diagnoseInvalidAttr(\"requires a constant argument\");\n-\n-      // If we have more specific information about what went wrong, emit\n-      // notes.\n-      if (it != constants.end() &&\n-          it->second.getKind() == SymbolicValue::Unknown)\n-        it->second.emitUnknownDiagnosticNotes(origInstLoc);\n-      return;\n+      LLVM_DEBUG(llvm::dbgs() << \"  graph_op \" << *origInst\n+                              << \" has a dynamic attr: \" << argumentValue\n+                              << \" and will be evaluated out-of-graph.\\n\");\n+      runOutOfGraph = true;\n+      opBuilder.addArgument(\n+          argumentValue,\n+          attrIdentifier.str() /*std::get<0>(argumentNameAndLowering)*/);","path":"lib/SILOptimizer/Mandatory/TFDeabstraction.cpp","position":38,"original_position":38,"commit_id":"dc71f657a98c9cbd931b4de086e2237010ac17db","original_commit_id":"dc71f657a98c9cbd931b4de086e2237010ac17db","user":{"login":"rxwei","id":856507,"node_id":"MDQ6VXNlcjg1NjUwNw==","avatar_url":"https://avatars0.githubusercontent.com/u/856507?v=4","gravatar_id":"","url":"https://api.github.com/users/rxwei","html_url":"https://github.com/rxwei","followers_url":"https://api.github.com/users/rxwei/followers","following_url":"https://api.github.com/users/rxwei/following{/other_user}","gists_url":"https://api.github.com/users/rxwei/gists{/gist_id}","starred_url":"https://api.github.com/users/rxwei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rxwei/subscriptions","organizations_url":"https://api.github.com/users/rxwei/orgs","repos_url":"https://api.github.com/users/rxwei/repos","events_url":"https://api.github.com/users/rxwei/events{/privacy}","received_events_url":"https://api.github.com/users/rxwei/received_events","type":"User","site_admin":false},"body":" Is the comment unnecessary?","created_at":"2018-11-12T19:21:07Z","updated_at":"2018-11-12T19:29:21Z","html_url":"https://github.com/apple/swift/pull/20507#discussion_r232781433","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/20507","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/232781433"},"html":{"href":"https://github.com/apple/swift/pull/20507#discussion_r232781433"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/20507"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/20507","id":230142818,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMTQyODE4","html_url":"https://github.com/apple/swift/pull/20507","diff_url":"https://github.com/apple/swift/pull/20507.diff","patch_url":"https://github.com/apple/swift/pull/20507.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/20507","number":20507,"state":"open","locked":false,"title":"Taught graph mode to execute graph_op's with dynamic attributes.","user":{"login":"mhong","id":969799,"node_id":"MDQ6VXNlcjk2OTc5OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/969799?v=4","gravatar_id":"","url":"https://api.github.com/users/mhong","html_url":"https://github.com/mhong","followers_url":"https://api.github.com/users/mhong/followers","following_url":"https://api.github.com/users/mhong/following{/other_user}","gists_url":"https://api.github.com/users/mhong/gists{/gist_id}","starred_url":"https://api.github.com/users/mhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhong/subscriptions","organizations_url":"https://api.github.com/users/mhong/orgs","repos_url":"https://api.github.com/users/mhong/repos","events_url":"https://api.github.com/users/mhong/events{/privacy}","received_events_url":"https://api.github.com/users/mhong/received_events","type":"User","site_admin":false},"body":"This involves a simple change in the deabstraction and partition passes. In the\r\nformer pass, we mark the graph_op with a new bit indicating it will run \"out of\r\ngraph\" (i.e., via eager op dispatch), when we fail to const-evaluate any\r\nattribute of it. In the latter pass, we exclude those graph_op's marked\r\nout-of-graph from tensorOpSet, so that they are not considered when extracting\r\nthe graph function. Effectively, they are treated like host functions such as\r\n`atariSimulator()`.\r\n\r\nExtended the graph_op infra to support instruction creation and mutation with this new \"out-of-graph\" bit. We chose not to extend `GraphOperationBuilder::Builder` accordingly in order to avoid unnecessary interface complexity, because its many existing callers do not care about this bit.\r\n\r\nAdjusted some compiler tests, and turned on the entire runtime test suite on\r\ndynamic attrs in graph mode!\r\n","created_at":"2018-11-12T13:57:22Z","updated_at":"2018-11-12T19:29:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f076e512dc66b9e1b8e186704cd95136206dacbc","assignee":null,"assignees":[],"requested_reviewers":[{"login":"marcrasi","id":5945760,"node_id":"MDQ6VXNlcjU5NDU3NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/5945760?v=4","gravatar_id":"","url":"https://api.github.com/users/marcrasi","html_url":"https://github.com/marcrasi","followers_url":"https://api.github.com/users/marcrasi/followers","following_url":"https://api.github.com/users/marcrasi/following{/other_user}","gists_url":"https://api.github.com/users/marcrasi/gists{/gist_id}","starred_url":"https://api.github.com/users/marcrasi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcrasi/subscriptions","organizations_url":"https://api.github.com/users/marcrasi/orgs","repos_url":"https://api.github.com/users/marcrasi/repos","events_url":"https://api.github.com/users/marcrasi/events{/privacy}","received_events_url":"https://api.github.com/users/marcrasi/received_events","type":"User","site_admin":false},{"login":"bgogul","id":6721579,"node_id":"MDQ6VXNlcjY3MjE1Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/6721579?v=4","gravatar_id":"","url":"https://api.github.com/users/bgogul","html_url":"https://github.com/bgogul","followers_url":"https://api.github.com/users/bgogul/followers","following_url":"https://api.github.com/users/bgogul/following{/other_user}","gists_url":"https://api.github.com/users/bgogul/gists{/gist_id}","starred_url":"https://api.github.com/users/bgogul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgogul/subscriptions","organizations_url":"https://api.github.com/users/bgogul/orgs","repos_url":"https://api.github.com/users/bgogul/repos","events_url":"https://api.github.com/users/bgogul/events{/privacy}","received_events_url":"https://api.github.com/users/bgogul/received_events","type":"User","site_admin":false},{"login":"lattner","id":15152540,"node_id":"MDQ6VXNlcjE1MTUyNTQw","avatar_url":"https://avatars0.githubusercontent.com/u/15152540?v=4","gravatar_id":"","url":"https://api.github.com/users/lattner","html_url":"https://github.com/lattner","followers_url":"https://api.github.com/users/lattner/followers","following_url":"https://api.github.com/users/lattner/following{/other_user}","gists_url":"https://api.github.com/users/lattner/gists{/gist_id}","starred_url":"https://api.github.com/users/lattner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lattner/subscriptions","organizations_url":"https://api.github.com/users/lattner/orgs","repos_url":"https://api.github.com/users/lattner/repos","events_url":"https://api.github.com/users/lattner/events{/privacy}","received_events_url":"https://api.github.com/users/lattner/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/20507/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/20507/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/20507/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/dc71f657a98c9cbd931b4de086e2237010ac17db","head":{"label":"mhong:dynamic_attr_gpe","ref":"dynamic_attr_gpe","sha":"dc71f657a98c9cbd931b4de086e2237010ac17db","user":{"login":"mhong","id":969799,"node_id":"MDQ6VXNlcjk2OTc5OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/969799?v=4","gravatar_id":"","url":"https://api.github.com/users/mhong","html_url":"https://github.com/mhong","followers_url":"https://api.github.com/users/mhong/followers","following_url":"https://api.github.com/users/mhong/following{/other_user}","gists_url":"https://api.github.com/users/mhong/gists{/gist_id}","starred_url":"https://api.github.com/users/mhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhong/subscriptions","organizations_url":"https://api.github.com/users/mhong/orgs","repos_url":"https://api.github.com/users/mhong/repos","events_url":"https://api.github.com/users/mhong/events{/privacy}","received_events_url":"https://api.github.com/users/mhong/received_events","type":"User","site_admin":false},"repo":{"id":119768422,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk3Njg0MjI=","name":"swift","full_name":"mhong/swift","private":false,"owner":{"login":"mhong","id":969799,"node_id":"MDQ6VXNlcjk2OTc5OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/969799?v=4","gravatar_id":"","url":"https://api.github.com/users/mhong","html_url":"https://github.com/mhong","followers_url":"https://api.github.com/users/mhong/followers","following_url":"https://api.github.com/users/mhong/following{/other_user}","gists_url":"https://api.github.com/users/mhong/gists{/gist_id}","starred_url":"https://api.github.com/users/mhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhong/subscriptions","organizations_url":"https://api.github.com/users/mhong/orgs","repos_url":"https://api.github.com/users/mhong/repos","events_url":"https://api.github.com/users/mhong/events{/privacy}","received_events_url":"https://api.github.com/users/mhong/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mhong/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/mhong/swift","forks_url":"https://api.github.com/repos/mhong/swift/forks","keys_url":"https://api.github.com/repos/mhong/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mhong/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mhong/swift/teams","hooks_url":"https://api.github.com/repos/mhong/swift/hooks","issue_events_url":"https://api.github.com/repos/mhong/swift/issues/events{/number}","events_url":"https://api.github.com/repos/mhong/swift/events","assignees_url":"https://api.github.com/repos/mhong/swift/assignees{/user}","branches_url":"https://api.github.com/repos/mhong/swift/branches{/branch}","tags_url":"https://api.github.com/repos/mhong/swift/tags","blobs_url":"https://api.github.com/repos/mhong/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mhong/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mhong/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/mhong/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mhong/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/mhong/swift/languages","stargazers_url":"https://api.github.com/repos/mhong/swift/stargazers","contributors_url":"https://api.github.com/repos/mhong/swift/contributors","subscribers_url":"https://api.github.com/repos/mhong/swift/subscribers","subscription_url":"https://api.github.com/repos/mhong/swift/subscription","commits_url":"https://api.github.com/repos/mhong/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/mhong/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/mhong/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/mhong/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/mhong/swift/contents/{+path}","compare_url":"https://api.github.com/repos/mhong/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mhong/swift/merges","archive_url":"https://api.github.com/repos/mhong/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mhong/swift/downloads","issues_url":"https://api.github.com/repos/mhong/swift/issues{/number}","pulls_url":"https://api.github.com/repos/mhong/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/mhong/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/mhong/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mhong/swift/labels{/name}","releases_url":"https://api.github.com/repos/mhong/swift/releases{/id}","deployments_url":"https://api.github.com/repos/mhong/swift/deployments","created_at":"2018-02-01T01:57:03Z","updated_at":"2018-02-01T01:57:33Z","pushed_at":"2018-11-12T14:02:00Z","git_url":"git://github.com/mhong/swift.git","ssh_url":"git@github.com:mhong/swift.git","clone_url":"https://github.com/mhong/swift.git","svn_url":"https://github.com/mhong/swift","homepage":"https://swift.org/","size":350193,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:tensorflow","ref":"tensorflow","sha":"3fa89b02d809294292dcb225dba717f95c6d2d17","user":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"node_id":"MDEwOlJlcG9zaXRvcnk0NDgzODk0OQ==","name":"swift","full_name":"apple/swift","private":false,"owner":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2018-11-12T19:20:08Z","pushed_at":"2018-11-12T19:18:34Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org","size":361727,"stargazers_count":45732,"watchers_count":45732,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7255,"mirror_url":null,"archived":false,"open_issues_count":434,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7255,"open_issues":434,"watchers":45732,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/20507"},"html":{"href":"https://github.com/apple/swift/pull/20507"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/20507"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/20507/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/20507/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/20507/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/dc71f657a98c9cbd931b4de086e2237010ac17db"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"rxwei"}}