{"action":"created","comment":{"url":"https://api.github.com/repos/tablexi/nucore-open/pulls/comments/174243949","pull_request_review_id":103564475,"id":174243949,"diff_hunk":"@@ -20,9 +20,18 @@ def initialize\n     end\n \n     # GET /facilities/:facility_id/occupancies\n-    # Provided by NewInprocessController\n-    # def index\n-    # end\n+    def index\n+      order_details = new_or_in_process_orders.joins(:order)\n+\n+      @search_form = TransactionSearch::SearchForm.new(params[:search], defaults: { date_range_field: \"ordered_at\" })\n+      @search = TransactionSearch::Searcher.new(TransactionSearch::ProductSearcher).search(order_details, @search_form)","path":"vendor/engines/secure_rooms/app/controllers/secure_rooms/facility_occupancies_controller.rb","position":20,"original_position":20,"commit_id":"b778d72585a490b36e479b921ab80fb608cd8700","original_commit_id":"b778d72585a490b36e479b921ab80fb608cd8700","user":{"login":"meara","id":4624197,"avatar_url":"https://avatars2.githubusercontent.com/u/4624197?v=4","gravatar_id":"","url":"https://api.github.com/users/meara","html_url":"https://github.com/meara","followers_url":"https://api.github.com/users/meara/followers","following_url":"https://api.github.com/users/meara/following{/other_user}","gists_url":"https://api.github.com/users/meara/gists{/gist_id}","starred_url":"https://api.github.com/users/meara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meara/subscriptions","organizations_url":"https://api.github.com/users/meara/orgs","repos_url":"https://api.github.com/users/meara/repos","events_url":"https://api.github.com/users/meara/events{/privacy}","received_events_url":"https://api.github.com/users/meara/received_events","type":"User","site_admin":false},"body":"I thought that was weird too, but I wasn't sure it was worth pushing back on.","created_at":"2018-03-13T18:43:49Z","updated_at":"2018-03-13T18:43:49Z","html_url":"https://github.com/tablexi/nucore-open/pull/1440#discussion_r174243949","pull_request_url":"https://api.github.com/repos/tablexi/nucore-open/pulls/1440","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/tablexi/nucore-open/pulls/comments/174243949"},"html":{"href":"https://github.com/tablexi/nucore-open/pull/1440#discussion_r174243949"},"pull_request":{"href":"https://api.github.com/repos/tablexi/nucore-open/pulls/1440"}},"in_reply_to_id":174241144},"pull_request":{"url":"https://api.github.com/repos/tablexi/nucore-open/pulls/1440","id":174483224,"html_url":"https://github.com/tablexi/nucore-open/pull/1440","diff_url":"https://github.com/tablexi/nucore-open/pull/1440.diff","patch_url":"https://github.com/tablexi/nucore-open/pull/1440.patch","issue_url":"https://api.github.com/repos/tablexi/nucore-open/issues/1440","number":1440,"state":"open","locked":false,"title":"[#87522] update new/inprocess/problem tabs for orders/reservations/occupancies…","user":{"login":"meara","id":4624197,"avatar_url":"https://avatars2.githubusercontent.com/u/4624197?v=4","gravatar_id":"","url":"https://api.github.com/users/meara","html_url":"https://github.com/meara","followers_url":"https://api.github.com/users/meara/followers","following_url":"https://api.github.com/users/meara/following{/other_user}","gists_url":"https://api.github.com/users/meara/gists{/gist_id}","starred_url":"https://api.github.com/users/meara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meara/subscriptions","organizations_url":"https://api.github.com/users/meara/orgs","repos_url":"https://api.github.com/users/meara/repos","events_url":"https://api.github.com/users/meara/events{/privacy}","received_events_url":"https://api.github.com/users/meara/received_events","type":"User","site_admin":false},"body":"… per NU reqs\r\n\r\nFrom NU:\r\n```\r\nWe need a few changes on the Orders/Reservations/Occupancies tabs:\r\n\r\nOrders, Reservations: New/In Process: Lock billing status at Ordered (gray out selection), add Order Statuses filter\r\nProblem Orders: Lock billing status at Ordered (gray out selection), Add Payment Source filter\r\n\r\nOccupancies: New/In Process: Remove everything except Products filter\r\nProblem Orders: Lock billing status at Ordered (gray out selection), Add Payment Source filter\r\n```","created_at":"2018-03-12T20:19:21Z","updated_at":"2018-03-13T18:43:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1378210e59cf6264c0057573224cad8a48e4234","assignee":null,"assignees":[],"requested_reviewers":[{"login":"giladshanan","id":30355046,"avatar_url":"https://avatars2.githubusercontent.com/u/30355046?v=4","gravatar_id":"","url":"https://api.github.com/users/giladshanan","html_url":"https://github.com/giladshanan","followers_url":"https://api.github.com/users/giladshanan/followers","following_url":"https://api.github.com/users/giladshanan/following{/other_user}","gists_url":"https://api.github.com/users/giladshanan/gists{/gist_id}","starred_url":"https://api.github.com/users/giladshanan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giladshanan/subscriptions","organizations_url":"https://api.github.com/users/giladshanan/orgs","repos_url":"https://api.github.com/users/giladshanan/repos","events_url":"https://api.github.com/users/giladshanan/events{/privacy}","received_events_url":"https://api.github.com/users/giladshanan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":552635076,"url":"https://api.github.com/repos/tablexi/nucore-open/labels/NU","name":"NU","color":"571963","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/tablexi/nucore-open/pulls/1440/commits","review_comments_url":"https://api.github.com/repos/tablexi/nucore-open/pulls/1440/comments","review_comment_url":"https://api.github.com/repos/tablexi/nucore-open/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tablexi/nucore-open/issues/1440/comments","statuses_url":"https://api.github.com/repos/tablexi/nucore-open/statuses/b778d72585a490b36e479b921ab80fb608cd8700","head":{"label":"tablexi:87522-orders/reservations/occupancies-filtering-bounceback","ref":"87522-orders/reservations/occupancies-filtering-bounceback","sha":"b778d72585a490b36e479b921ab80fb608cd8700","user":{"login":"tablexi","id":229702,"avatar_url":"https://avatars1.githubusercontent.com/u/229702?v=4","gravatar_id":"","url":"https://api.github.com/users/tablexi","html_url":"https://github.com/tablexi","followers_url":"https://api.github.com/users/tablexi/followers","following_url":"https://api.github.com/users/tablexi/following{/other_user}","gists_url":"https://api.github.com/users/tablexi/gists{/gist_id}","starred_url":"https://api.github.com/users/tablexi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tablexi/subscriptions","organizations_url":"https://api.github.com/users/tablexi/orgs","repos_url":"https://api.github.com/users/tablexi/repos","events_url":"https://api.github.com/users/tablexi/events{/privacy}","received_events_url":"https://api.github.com/users/tablexi/received_events","type":"Organization","site_admin":false},"repo":{"id":1439473,"name":"nucore-open","full_name":"tablexi/nucore-open","owner":{"login":"tablexi","id":229702,"avatar_url":"https://avatars1.githubusercontent.com/u/229702?v=4","gravatar_id":"","url":"https://api.github.com/users/tablexi","html_url":"https://github.com/tablexi","followers_url":"https://api.github.com/users/tablexi/followers","following_url":"https://api.github.com/users/tablexi/following{/other_user}","gists_url":"https://api.github.com/users/tablexi/gists{/gist_id}","starred_url":"https://api.github.com/users/tablexi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tablexi/subscriptions","organizations_url":"https://api.github.com/users/tablexi/orgs","repos_url":"https://api.github.com/users/tablexi/repos","events_url":"https://api.github.com/users/tablexi/events{/privacy}","received_events_url":"https://api.github.com/users/tablexi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tablexi/nucore-open","description":"Northwestern University Core Facility Management Software (NUCore)","fork":false,"url":"https://api.github.com/repos/tablexi/nucore-open","forks_url":"https://api.github.com/repos/tablexi/nucore-open/forks","keys_url":"https://api.github.com/repos/tablexi/nucore-open/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tablexi/nucore-open/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tablexi/nucore-open/teams","hooks_url":"https://api.github.com/repos/tablexi/nucore-open/hooks","issue_events_url":"https://api.github.com/repos/tablexi/nucore-open/issues/events{/number}","events_url":"https://api.github.com/repos/tablexi/nucore-open/events","assignees_url":"https://api.github.com/repos/tablexi/nucore-open/assignees{/user}","branches_url":"https://api.github.com/repos/tablexi/nucore-open/branches{/branch}","tags_url":"https://api.github.com/repos/tablexi/nucore-open/tags","blobs_url":"https://api.github.com/repos/tablexi/nucore-open/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tablexi/nucore-open/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tablexi/nucore-open/git/refs{/sha}","trees_url":"https://api.github.com/repos/tablexi/nucore-open/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tablexi/nucore-open/statuses/{sha}","languages_url":"https://api.github.com/repos/tablexi/nucore-open/languages","stargazers_url":"https://api.github.com/repos/tablexi/nucore-open/stargazers","contributors_url":"https://api.github.com/repos/tablexi/nucore-open/contributors","subscribers_url":"https://api.github.com/repos/tablexi/nucore-open/subscribers","subscription_url":"https://api.github.com/repos/tablexi/nucore-open/subscription","commits_url":"https://api.github.com/repos/tablexi/nucore-open/commits{/sha}","git_commits_url":"https://api.github.com/repos/tablexi/nucore-open/git/commits{/sha}","comments_url":"https://api.github.com/repos/tablexi/nucore-open/comments{/number}","issue_comment_url":"https://api.github.com/repos/tablexi/nucore-open/issues/comments{/number}","contents_url":"https://api.github.com/repos/tablexi/nucore-open/contents/{+path}","compare_url":"https://api.github.com/repos/tablexi/nucore-open/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tablexi/nucore-open/merges","archive_url":"https://api.github.com/repos/tablexi/nucore-open/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tablexi/nucore-open/downloads","issues_url":"https://api.github.com/repos/tablexi/nucore-open/issues{/number}","pulls_url":"https://api.github.com/repos/tablexi/nucore-open/pulls{/number}","milestones_url":"https://api.github.com/repos/tablexi/nucore-open/milestones{/number}","notifications_url":"https://api.github.com/repos/tablexi/nucore-open/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tablexi/nucore-open/labels{/name}","releases_url":"https://api.github.com/repos/tablexi/nucore-open/releases{/id}","deployments_url":"https://api.github.com/repos/tablexi/nucore-open/deployments","created_at":"2011-03-04T13:45:37Z","updated_at":"2018-03-12T14:52:04Z","pushed_at":"2018-03-13T15:39:23Z","git_url":"git://github.com/tablexi/nucore-open.git","ssh_url":"git@github.com:tablexi/nucore-open.git","clone_url":"https://github.com/tablexi/nucore-open.git","svn_url":"https://github.com/tablexi/nucore-open","homepage":"","size":71598,"stargazers_count":9,"watchers_count":9,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":10,"open_issues":11,"watchers":9,"default_branch":"master"}},"base":{"label":"tablexi:master","ref":"master","sha":"70ee0fcc67980b03c55d574283635c08cd8dceed","user":{"login":"tablexi","id":229702,"avatar_url":"https://avatars1.githubusercontent.com/u/229702?v=4","gravatar_id":"","url":"https://api.github.com/users/tablexi","html_url":"https://github.com/tablexi","followers_url":"https://api.github.com/users/tablexi/followers","following_url":"https://api.github.com/users/tablexi/following{/other_user}","gists_url":"https://api.github.com/users/tablexi/gists{/gist_id}","starred_url":"https://api.github.com/users/tablexi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tablexi/subscriptions","organizations_url":"https://api.github.com/users/tablexi/orgs","repos_url":"https://api.github.com/users/tablexi/repos","events_url":"https://api.github.com/users/tablexi/events{/privacy}","received_events_url":"https://api.github.com/users/tablexi/received_events","type":"Organization","site_admin":false},"repo":{"id":1439473,"name":"nucore-open","full_name":"tablexi/nucore-open","owner":{"login":"tablexi","id":229702,"avatar_url":"https://avatars1.githubusercontent.com/u/229702?v=4","gravatar_id":"","url":"https://api.github.com/users/tablexi","html_url":"https://github.com/tablexi","followers_url":"https://api.github.com/users/tablexi/followers","following_url":"https://api.github.com/users/tablexi/following{/other_user}","gists_url":"https://api.github.com/users/tablexi/gists{/gist_id}","starred_url":"https://api.github.com/users/tablexi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tablexi/subscriptions","organizations_url":"https://api.github.com/users/tablexi/orgs","repos_url":"https://api.github.com/users/tablexi/repos","events_url":"https://api.github.com/users/tablexi/events{/privacy}","received_events_url":"https://api.github.com/users/tablexi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tablexi/nucore-open","description":"Northwestern University Core Facility Management Software (NUCore)","fork":false,"url":"https://api.github.com/repos/tablexi/nucore-open","forks_url":"https://api.github.com/repos/tablexi/nucore-open/forks","keys_url":"https://api.github.com/repos/tablexi/nucore-open/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tablexi/nucore-open/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tablexi/nucore-open/teams","hooks_url":"https://api.github.com/repos/tablexi/nucore-open/hooks","issue_events_url":"https://api.github.com/repos/tablexi/nucore-open/issues/events{/number}","events_url":"https://api.github.com/repos/tablexi/nucore-open/events","assignees_url":"https://api.github.com/repos/tablexi/nucore-open/assignees{/user}","branches_url":"https://api.github.com/repos/tablexi/nucore-open/branches{/branch}","tags_url":"https://api.github.com/repos/tablexi/nucore-open/tags","blobs_url":"https://api.github.com/repos/tablexi/nucore-open/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tablexi/nucore-open/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tablexi/nucore-open/git/refs{/sha}","trees_url":"https://api.github.com/repos/tablexi/nucore-open/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tablexi/nucore-open/statuses/{sha}","languages_url":"https://api.github.com/repos/tablexi/nucore-open/languages","stargazers_url":"https://api.github.com/repos/tablexi/nucore-open/stargazers","contributors_url":"https://api.github.com/repos/tablexi/nucore-open/contributors","subscribers_url":"https://api.github.com/repos/tablexi/nucore-open/subscribers","subscription_url":"https://api.github.com/repos/tablexi/nucore-open/subscription","commits_url":"https://api.github.com/repos/tablexi/nucore-open/commits{/sha}","git_commits_url":"https://api.github.com/repos/tablexi/nucore-open/git/commits{/sha}","comments_url":"https://api.github.com/repos/tablexi/nucore-open/comments{/number}","issue_comment_url":"https://api.github.com/repos/tablexi/nucore-open/issues/comments{/number}","contents_url":"https://api.github.com/repos/tablexi/nucore-open/contents/{+path}","compare_url":"https://api.github.com/repos/tablexi/nucore-open/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tablexi/nucore-open/merges","archive_url":"https://api.github.com/repos/tablexi/nucore-open/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tablexi/nucore-open/downloads","issues_url":"https://api.github.com/repos/tablexi/nucore-open/issues{/number}","pulls_url":"https://api.github.com/repos/tablexi/nucore-open/pulls{/number}","milestones_url":"https://api.github.com/repos/tablexi/nucore-open/milestones{/number}","notifications_url":"https://api.github.com/repos/tablexi/nucore-open/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tablexi/nucore-open/labels{/name}","releases_url":"https://api.github.com/repos/tablexi/nucore-open/releases{/id}","deployments_url":"https://api.github.com/repos/tablexi/nucore-open/deployments","created_at":"2011-03-04T13:45:37Z","updated_at":"2018-03-12T14:52:04Z","pushed_at":"2018-03-13T15:39:23Z","git_url":"git://github.com/tablexi/nucore-open.git","ssh_url":"git@github.com:tablexi/nucore-open.git","clone_url":"https://github.com/tablexi/nucore-open.git","svn_url":"https://github.com/tablexi/nucore-open","homepage":"","size":71598,"stargazers_count":9,"watchers_count":9,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":10,"open_issues":11,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tablexi/nucore-open/pulls/1440"},"html":{"href":"https://github.com/tablexi/nucore-open/pull/1440"},"issue":{"href":"https://api.github.com/repos/tablexi/nucore-open/issues/1440"},"comments":{"href":"https://api.github.com/repos/tablexi/nucore-open/issues/1440/comments"},"review_comments":{"href":"https://api.github.com/repos/tablexi/nucore-open/pulls/1440/comments"},"review_comment":{"href":"https://api.github.com/repos/tablexi/nucore-open/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tablexi/nucore-open/pulls/1440/commits"},"statuses":{"href":"https://api.github.com/repos/tablexi/nucore-open/statuses/b778d72585a490b36e479b921ab80fb608cd8700"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"meara"}}