{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/206744610","pull_request_review_id":142215824,"id":206744610,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjc0NDYxMA==","diff_hunk":"@@ -136,6 +136,66 @@ func newTestPods() []runtime.Object {\n \t}\n }\n \n+func newBestEffortTestPods() []runtime.Object {\n+\treturn []runtime.Object{\n+\t\t&v1.Pod{\n+\t\t\tObjectMeta: metav1.ObjectMeta{Name: \"pod-running\", Namespace: \"testing\"},\n+\t\t\tStatus:     v1.PodStatus{Phase: v1.PodRunning},\n+\t\t\tSpec: v1.PodSpec{\n+\t\t\t\tVolumes:    []v1.Volume{{Name: \"vol\"}},\n+\t\t\t\tContainers: []v1.Container{{Name: \"ctr\", Image: \"image\", Resources: getResourceRequirements(getResourceList(\"\", \"\"), getResourceList(\"\", \"\"))}},\n+\t\t\t},\n+\t\t},\n+\t\t&v1.Pod{\n+\t\t\tObjectMeta: metav1.ObjectMeta{Name: \"pod-running-2\", Namespace: \"testing\"},","path":"pkg/controller/resourcequota/resource_quota_controller_test.go","position":15,"original_position":15,"commit_id":"e7649705ab3d88d5b27619db774419909bc2aa78","original_commit_id":"e7649705ab3d88d5b27619db774419909bc2aa78","user":{"login":"vikaschoudhary16","id":11936386,"node_id":"MDQ6VXNlcjExOTM2Mzg2","avatar_url":"https://avatars3.githubusercontent.com/u/11936386?v=4","gravatar_id":"","url":"https://api.github.com/users/vikaschoudhary16","html_url":"https://github.com/vikaschoudhary16","followers_url":"https://api.github.com/users/vikaschoudhary16/followers","following_url":"https://api.github.com/users/vikaschoudhary16/following{/other_user}","gists_url":"https://api.github.com/users/vikaschoudhary16/gists{/gist_id}","starred_url":"https://api.github.com/users/vikaschoudhary16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vikaschoudhary16/subscriptions","organizations_url":"https://api.github.com/users/vikaschoudhary16/orgs","repos_url":"https://api.github.com/users/vikaschoudhary16/repos","events_url":"https://api.github.com/users/vikaschoudhary16/events{/privacy}","received_events_url":"https://api.github.com/users/vikaschoudhary16/received_events","type":"User","site_admin":false},"body":"@sjenning  Assuming \"this test case and the previous one\" refering to `newBestEffortTestPods()` and `newTestPods()`, this utility function has two best effort pods while in previous one there is no best effort pods. This utility fucntion is added to test `ResourceQuotaScopeBestEffort`. \r\n","created_at":"2018-08-01T03:15:45Z","updated_at":"2018-08-01T03:15:45Z","html_url":"https://github.com/kubernetes/kubernetes/pull/66351#discussion_r206744610","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/66351","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/206744610"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/66351#discussion_r206744610"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/66351"}},"in_reply_to_id":206661699},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/66351","id":202356967,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMzU2OTY3","html_url":"https://github.com/kubernetes/kubernetes/pull/66351","diff_url":"https://github.com/kubernetes/kubernetes/pull/66351.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/66351.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/66351","number":66351,"state":"open","locked":false,"title":"Add unit tests to cover scopes and scope selectors during quota sync logic","user":{"login":"vikaschoudhary16","id":11936386,"node_id":"MDQ6VXNlcjExOTM2Mzg2","avatar_url":"https://avatars3.githubusercontent.com/u/11936386?v=4","gravatar_id":"","url":"https://api.github.com/users/vikaschoudhary16","html_url":"https://github.com/vikaschoudhary16","followers_url":"https://api.github.com/users/vikaschoudhary16/followers","following_url":"https://api.github.com/users/vikaschoudhary16/following{/other_user}","gists_url":"https://api.github.com/users/vikaschoudhary16/gists{/gist_id}","starred_url":"https://api.github.com/users/vikaschoudhary16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vikaschoudhary16/subscriptions","organizations_url":"https://api.github.com/users/vikaschoudhary16/orgs","repos_url":"https://api.github.com/users/vikaschoudhary16/repos","events_url":"https://api.github.com/users/vikaschoudhary16/events{/privacy}","received_events_url":"https://api.github.com/users/vikaschoudhary16/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n4. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\nAdds unit tests to cover scopes and scope selectors fields in the quota spec. Existing unit test for quota sync does not cover scopes.\r\n\r\nAlso while adding tests found a minor issue with 'Exists' scope selector operator. This is also being fixed in this PR.\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nUnit tests for scopes and scope selectors in the quota spec\r\n```\r\n/cc @derekwaynecarr @sjenning @bsalamat @kubernetes/sig-scheduling-pr-reviews @kubernetes/sig-node-pr-reviews ","created_at":"2018-07-18T19:33:42Z","updated_at":"2018-08-01T03:15:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f2de794141bd4313e0d607e5a1e2bcb0d4a725f7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"derekwaynecarr","id":6233452,"node_id":"MDQ6VXNlcjYyMzM0NTI=","avatar_url":"https://avatars3.githubusercontent.com/u/6233452?v=4","gravatar_id":"","url":"https://api.github.com/users/derekwaynecarr","html_url":"https://github.com/derekwaynecarr","followers_url":"https://api.github.com/users/derekwaynecarr/followers","following_url":"https://api.github.com/users/derekwaynecarr/following{/other_user}","gists_url":"https://api.github.com/users/derekwaynecarr/gists{/gist_id}","starred_url":"https://api.github.com/users/derekwaynecarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekwaynecarr/subscriptions","organizations_url":"https://api.github.com/users/derekwaynecarr/orgs","repos_url":"https://api.github.com/users/derekwaynecarr/repos","events_url":"https://api.github.com/users/derekwaynecarr/events{/privacy}","received_events_url":"https://api.github.com/users/derekwaynecarr/received_events","type":"User","site_admin":false},{"login":"bsalamat","id":14308438,"node_id":"MDQ6VXNlcjE0MzA4NDM4","avatar_url":"https://avatars3.githubusercontent.com/u/14308438?v=4","gravatar_id":"","url":"https://api.github.com/users/bsalamat","html_url":"https://github.com/bsalamat","followers_url":"https://api.github.com/users/bsalamat/followers","following_url":"https://api.github.com/users/bsalamat/following{/other_user}","gists_url":"https://api.github.com/users/bsalamat/gists{/gist_id}","starred_url":"https://api.github.com/users/bsalamat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsalamat/subscriptions","organizations_url":"https://api.github.com/users/bsalamat/orgs","repos_url":"https://api.github.com/users/bsalamat/repos","events_url":"https://api.github.com/users/bsalamat/events{/privacy}","received_events_url":"https://api.github.com/users/bsalamat/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":267761362,"node_id":"MDU6TGFiZWwyNjc3NjEzNjI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/feature","name":"kind/feature","color":"c7def8","default":false},{"id":114528223,"node_id":"MDU6TGFiZWwxMTQ1MjgyMjM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/priority/important-soon","name":"priority/important-soon","color":"eb6420","default":false},{"id":200149833,"node_id":"MDU6TGFiZWwyMDAxNDk4MzM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":173493665,"node_id":"MDU6TGFiZWwxNzM0OTM2NjU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/node","name":"sig/node","color":"d2b48c","default":false},{"id":125550211,"node_id":"MDU6TGFiZWwxMjU1NTAyMTE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/scheduling","name":"sig/scheduling","color":"d2b48c","default":false},{"id":253450978,"node_id":"MDU6TGFiZWwyNTM0NTA5Nzg=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false},{"id":611767149,"node_id":"MDU6TGFiZWw2MTE3NjcxNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/status/approved-for-milestone","name":"status/approved-for-milestone","color":"fef2c0","default":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/39","html_url":"https://github.com/kubernetes/kubernetes/milestone/39","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/39/labels","id":2913712,"node_id":"MDk6TWlsZXN0b25lMjkxMzcxMg==","number":39,"title":"v1.12","description":"","creator":{"login":"thockin","id":5595220,"node_id":"MDQ6VXNlcjU1OTUyMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/5595220?v=4","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"open_issues":38,"closed_issues":25,"state":"open","created_at":"2017-11-15T06:32:51Z","updated_at":"2018-07-31T08:43:58Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/66351/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/66351/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/66351/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/e7649705ab3d88d5b27619db774419909bc2aa78","head":{"label":"vikaschoudhary16:fix-scopeselector-exist-operator","ref":"fix-scopeselector-exist-operator","sha":"e7649705ab3d88d5b27619db774419909bc2aa78","user":{"login":"vikaschoudhary16","id":11936386,"node_id":"MDQ6VXNlcjExOTM2Mzg2","avatar_url":"https://avatars3.githubusercontent.com/u/11936386?v=4","gravatar_id":"","url":"https://api.github.com/users/vikaschoudhary16","html_url":"https://github.com/vikaschoudhary16","followers_url":"https://api.github.com/users/vikaschoudhary16/followers","following_url":"https://api.github.com/users/vikaschoudhary16/following{/other_user}","gists_url":"https://api.github.com/users/vikaschoudhary16/gists{/gist_id}","starred_url":"https://api.github.com/users/vikaschoudhary16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vikaschoudhary16/subscriptions","organizations_url":"https://api.github.com/users/vikaschoudhary16/orgs","repos_url":"https://api.github.com/users/vikaschoudhary16/repos","events_url":"https://api.github.com/users/vikaschoudhary16/events{/privacy}","received_events_url":"https://api.github.com/users/vikaschoudhary16/received_events","type":"User","site_admin":false},"repo":{"id":70860655,"node_id":"MDEwOlJlcG9zaXRvcnk3MDg2MDY1NQ==","name":"kubernetes","full_name":"vikaschoudhary16/kubernetes","owner":{"login":"vikaschoudhary16","id":11936386,"node_id":"MDQ6VXNlcjExOTM2Mzg2","avatar_url":"https://avatars3.githubusercontent.com/u/11936386?v=4","gravatar_id":"","url":"https://api.github.com/users/vikaschoudhary16","html_url":"https://github.com/vikaschoudhary16","followers_url":"https://api.github.com/users/vikaschoudhary16/followers","following_url":"https://api.github.com/users/vikaschoudhary16/following{/other_user}","gists_url":"https://api.github.com/users/vikaschoudhary16/gists{/gist_id}","starred_url":"https://api.github.com/users/vikaschoudhary16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vikaschoudhary16/subscriptions","organizations_url":"https://api.github.com/users/vikaschoudhary16/orgs","repos_url":"https://api.github.com/users/vikaschoudhary16/repos","events_url":"https://api.github.com/users/vikaschoudhary16/events{/privacy}","received_events_url":"https://api.github.com/users/vikaschoudhary16/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vikaschoudhary16/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/vikaschoudhary16/kubernetes","forks_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/forks","keys_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/teams","hooks_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/events","assignees_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/tags","blobs_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/languages","stargazers_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/subscription","commits_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/merges","archive_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/downloads","issues_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/deployments","created_at":"2016-10-14T00:56:54Z","updated_at":"2018-07-09T09:48:59Z","pushed_at":"2018-07-30T09:39:41Z","git_url":"git://github.com/vikaschoudhary16/kubernetes.git","ssh_url":"git@github.com:vikaschoudhary16/kubernetes.git","clone_url":"https://github.com/vikaschoudhary16/kubernetes.git","svn_url":"https://github.com/vikaschoudhary16/kubernetes","homepage":"http://kubernetes.io","size":564985,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"2486d51eb9d9bb3b43fba23b2ac52d4a863e3973","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU4MDQ5OA==","name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2018-08-01T03:14:24Z","pushed_at":"2018-08-01T03:11:25Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":795918,"stargazers_count":39449,"watchers_count":39449,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13756,"mirror_url":null,"archived":false,"open_issues_count":3144,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":13756,"open_issues":3144,"watchers":39449,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/66351"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/66351"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/66351"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/66351/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/66351/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/66351/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/e7649705ab3d88d5b27619db774419909bc2aa78"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"vikaschoudhary16"}}