{"action":"created","comment":{"url":"https://api.github.com/repos/emotion-js/emotion/pulls/comments/188362881","pull_request_review_id":120326073,"id":188362881,"diff_hunk":"@@ -0,0 +1,3 @@\n+import { emotionPrimitive } from './emotionPrimitive'","path":"packages/emotion-primitives/src/index.js","position":1,"original_position":1,"commit_id":"ec9357997abac75de861593354897bbc64a85328","original_commit_id":"ec9357997abac75de861593354897bbc64a85328","user":{"login":"Andarist","id":9800850,"avatar_url":"https://avatars2.githubusercontent.com/u/9800850?v=4","gravatar_id":"","url":"https://api.github.com/users/Andarist","html_url":"https://github.com/Andarist","followers_url":"https://api.github.com/users/Andarist/followers","following_url":"https://api.github.com/users/Andarist/following{/other_user}","gists_url":"https://api.github.com/users/Andarist/gists{/gist_id}","starred_url":"https://api.github.com/users/Andarist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Andarist/subscriptions","organizations_url":"https://api.github.com/users/Andarist/orgs","repos_url":"https://api.github.com/users/Andarist/repos","events_url":"https://api.github.com/users/Andarist/events{/privacy}","received_events_url":"https://api.github.com/users/Andarist/received_events","type":"User","site_admin":false},"body":"also it seems that u should export a default here (instead of named export) with\r\n```js\r\nexport { emotionPrimitive as default } from './emotionPrimitive'\r\n```","created_at":"2018-05-15T17:00:32Z","updated_at":"2018-05-15T17:00:33Z","html_url":"https://github.com/emotion-js/emotion/pull/658#discussion_r188362881","pull_request_url":"https://api.github.com/repos/emotion-js/emotion/pulls/658","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/emotion-js/emotion/pulls/comments/188362881"},"html":{"href":"https://github.com/emotion-js/emotion/pull/658#discussion_r188362881"},"pull_request":{"href":"https://api.github.com/repos/emotion-js/emotion/pulls/658"}},"in_reply_to_id":188361411},"pull_request":{"url":"https://api.github.com/repos/emotion-js/emotion/pulls/658","id":187765463,"html_url":"https://github.com/emotion-js/emotion/pull/658","diff_url":"https://github.com/emotion-js/emotion/pull/658.diff","patch_url":"https://github.com/emotion-js/emotion/pull/658.patch","issue_url":"https://api.github.com/repos/emotion-js/emotion/issues/658","number":658,"state":"open","locked":false,"title":"Emotion Primitives","user":{"login":"nitin42","id":16336071,"avatar_url":"https://avatars1.githubusercontent.com/u/16336071?v=4","gravatar_id":"","url":"https://api.github.com/users/nitin42","html_url":"https://github.com/nitin42","followers_url":"https://api.github.com/users/nitin42/followers","following_url":"https://api.github.com/users/nitin42/following{/other_user}","gists_url":"https://api.github.com/users/nitin42/gists{/gist_id}","starred_url":"https://api.github.com/users/nitin42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nitin42/subscriptions","organizations_url":"https://api.github.com/users/nitin42/orgs","repos_url":"https://api.github.com/users/nitin42/repos","events_url":"https://api.github.com/users/nitin42/events{/privacy}","received_events_url":"https://api.github.com/users/nitin42/received_events","type":"User","site_admin":false},"body":"<!--\r\nThanks for your interest in the project. I appreciate bugs filed and PRs submitted!\r\n\r\nPlease make sure that you are familiar with and follow the Code of Conduct for\r\nthis project (found in the CODE_OF_CONDUCT.md file).\r\n\r\nAlso, please make sure you're familiar with and follow the instructions in the\r\ncontributing guidelines (found in the CONTRIBUTING.md file).\r\n\r\nIf you're new to contributing to open source projects, you might find this free\r\nvideo course helpful: http://kcd.im/pull-request\r\n\r\nPlease fill out the information below to expedite the review and (hopefully)\r\nmerge of your pull request!\r\n-->\r\n\r\n<!-- What changes are being made? (What feature/bug is being fixed here?) -->\r\n**What**: Add `emotion-primitives` to emotion monorepo\r\n\r\n<!-- Why are these changes necessary? -->\r\n**Why**:\r\n\r\n<!-- How were these changes implemented? -->\r\n**How**: Integration with React primitives\r\n\r\n<!-- Have you done all of these things?  -->\r\n**Checklist**:\r\n<!-- add \"N/A\" to the end of each line that's irrelevant to your changes -->\r\n<!-- to check an item, place an \"x\" in the box like so: \"- [x] Documentation\" -->\r\n- [ ] Documentation\r\n- [x] Tests\r\n- [ ] Code complete\r\n\r\n<!-- feel free to add additional comments -->\r\n\r\n**TODO**\r\n\r\n- [x] Render primitives on Web\r\n- [x] Add tests\r\n- [ ] Example folder\r\n- [ ] Improve error warnings\r\n- [ ] Build\r\n- [ ] Add all emotion features like Theming support, passing props to interpolate functions, `withComponent` and etc for React Native and Sketch\r\n\r\n**STATUS**\r\n\r\n* Renders on Web ✅\r\n* Renders on Sketch ✅\r\n* Renders on Native (yet to test)\r\n\r\nOnce this is done, we can extract parts for React Native and create a separate package `emotion-native`.\r\n\r\n### Not ready to be reviewed.","created_at":"2018-05-14T09:20:27Z","updated_at":"2018-05-15T17:00:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2531c197e92f70bba350671734a37eae992814c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":934065434,"url":"https://api.github.com/repos/emotion-js/emotion/labels/WIP","name":"WIP","color":"9de886","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/emotion-js/emotion/pulls/658/commits","review_comments_url":"https://api.github.com/repos/emotion-js/emotion/pulls/658/comments","review_comment_url":"https://api.github.com/repos/emotion-js/emotion/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emotion-js/emotion/issues/658/comments","statuses_url":"https://api.github.com/repos/emotion-js/emotion/statuses/ec9357997abac75de861593354897bbc64a85328","head":{"label":"nitin42:emotion-primitives","ref":"emotion-primitives","sha":"ec9357997abac75de861593354897bbc64a85328","user":{"login":"nitin42","id":16336071,"avatar_url":"https://avatars1.githubusercontent.com/u/16336071?v=4","gravatar_id":"","url":"https://api.github.com/users/nitin42","html_url":"https://github.com/nitin42","followers_url":"https://api.github.com/users/nitin42/followers","following_url":"https://api.github.com/users/nitin42/following{/other_user}","gists_url":"https://api.github.com/users/nitin42/gists{/gist_id}","starred_url":"https://api.github.com/users/nitin42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nitin42/subscriptions","organizations_url":"https://api.github.com/users/nitin42/orgs","repos_url":"https://api.github.com/users/nitin42/repos","events_url":"https://api.github.com/users/nitin42/events{/privacy}","received_events_url":"https://api.github.com/users/nitin42/received_events","type":"User","site_admin":false},"repo":{"id":97098286,"name":"emotion","full_name":"nitin42/emotion","owner":{"login":"nitin42","id":16336071,"avatar_url":"https://avatars1.githubusercontent.com/u/16336071?v=4","gravatar_id":"","url":"https://api.github.com/users/nitin42","html_url":"https://github.com/nitin42","followers_url":"https://api.github.com/users/nitin42/followers","following_url":"https://api.github.com/users/nitin42/following{/other_user}","gists_url":"https://api.github.com/users/nitin42/gists{/gist_id}","starred_url":"https://api.github.com/users/nitin42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nitin42/subscriptions","organizations_url":"https://api.github.com/users/nitin42/orgs","repos_url":"https://api.github.com/users/nitin42/repos","events_url":"https://api.github.com/users/nitin42/events{/privacy}","received_events_url":"https://api.github.com/users/nitin42/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nitin42/emotion","description":"⚡️ The Next Generation of CSS-in-JS","fork":true,"url":"https://api.github.com/repos/nitin42/emotion","forks_url":"https://api.github.com/repos/nitin42/emotion/forks","keys_url":"https://api.github.com/repos/nitin42/emotion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nitin42/emotion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nitin42/emotion/teams","hooks_url":"https://api.github.com/repos/nitin42/emotion/hooks","issue_events_url":"https://api.github.com/repos/nitin42/emotion/issues/events{/number}","events_url":"https://api.github.com/repos/nitin42/emotion/events","assignees_url":"https://api.github.com/repos/nitin42/emotion/assignees{/user}","branches_url":"https://api.github.com/repos/nitin42/emotion/branches{/branch}","tags_url":"https://api.github.com/repos/nitin42/emotion/tags","blobs_url":"https://api.github.com/repos/nitin42/emotion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nitin42/emotion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nitin42/emotion/git/refs{/sha}","trees_url":"https://api.github.com/repos/nitin42/emotion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nitin42/emotion/statuses/{sha}","languages_url":"https://api.github.com/repos/nitin42/emotion/languages","stargazers_url":"https://api.github.com/repos/nitin42/emotion/stargazers","contributors_url":"https://api.github.com/repos/nitin42/emotion/contributors","subscribers_url":"https://api.github.com/repos/nitin42/emotion/subscribers","subscription_url":"https://api.github.com/repos/nitin42/emotion/subscription","commits_url":"https://api.github.com/repos/nitin42/emotion/commits{/sha}","git_commits_url":"https://api.github.com/repos/nitin42/emotion/git/commits{/sha}","comments_url":"https://api.github.com/repos/nitin42/emotion/comments{/number}","issue_comment_url":"https://api.github.com/repos/nitin42/emotion/issues/comments{/number}","contents_url":"https://api.github.com/repos/nitin42/emotion/contents/{+path}","compare_url":"https://api.github.com/repos/nitin42/emotion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nitin42/emotion/merges","archive_url":"https://api.github.com/repos/nitin42/emotion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nitin42/emotion/downloads","issues_url":"https://api.github.com/repos/nitin42/emotion/issues{/number}","pulls_url":"https://api.github.com/repos/nitin42/emotion/pulls{/number}","milestones_url":"https://api.github.com/repos/nitin42/emotion/milestones{/number}","notifications_url":"https://api.github.com/repos/nitin42/emotion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nitin42/emotion/labels{/name}","releases_url":"https://api.github.com/repos/nitin42/emotion/releases{/id}","deployments_url":"https://api.github.com/repos/nitin42/emotion/deployments","created_at":"2017-07-13T08:22:22Z","updated_at":"2017-07-13T08:22:24Z","pushed_at":"2018-05-14T09:18:09Z","git_url":"git://github.com/nitin42/emotion.git","ssh_url":"git@github.com:nitin42/emotion.git","clone_url":"https://github.com/nitin42/emotion.git","svn_url":"https://github.com/nitin42/emotion","homepage":"https://emotion.sh/","size":2930,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emotion-js:master","ref":"master","sha":"ef05dc4c8e151957c3d6786fea651aef683c76de","user":{"login":"emotion-js","id":31557565,"avatar_url":"https://avatars0.githubusercontent.com/u/31557565?v=4","gravatar_id":"","url":"https://api.github.com/users/emotion-js","html_url":"https://github.com/emotion-js","followers_url":"https://api.github.com/users/emotion-js/followers","following_url":"https://api.github.com/users/emotion-js/following{/other_user}","gists_url":"https://api.github.com/users/emotion-js/gists{/gist_id}","starred_url":"https://api.github.com/users/emotion-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emotion-js/subscriptions","organizations_url":"https://api.github.com/users/emotion-js/orgs","repos_url":"https://api.github.com/users/emotion-js/repos","events_url":"https://api.github.com/users/emotion-js/events{/privacy}","received_events_url":"https://api.github.com/users/emotion-js/received_events","type":"Organization","site_admin":false},"repo":{"id":92570536,"name":"emotion","full_name":"emotion-js/emotion","owner":{"login":"emotion-js","id":31557565,"avatar_url":"https://avatars0.githubusercontent.com/u/31557565?v=4","gravatar_id":"","url":"https://api.github.com/users/emotion-js","html_url":"https://github.com/emotion-js","followers_url":"https://api.github.com/users/emotion-js/followers","following_url":"https://api.github.com/users/emotion-js/following{/other_user}","gists_url":"https://api.github.com/users/emotion-js/gists{/gist_id}","starred_url":"https://api.github.com/users/emotion-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emotion-js/subscriptions","organizations_url":"https://api.github.com/users/emotion-js/orgs","repos_url":"https://api.github.com/users/emotion-js/repos","events_url":"https://api.github.com/users/emotion-js/events{/privacy}","received_events_url":"https://api.github.com/users/emotion-js/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emotion-js/emotion","description":"style as a function of state","fork":false,"url":"https://api.github.com/repos/emotion-js/emotion","forks_url":"https://api.github.com/repos/emotion-js/emotion/forks","keys_url":"https://api.github.com/repos/emotion-js/emotion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emotion-js/emotion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emotion-js/emotion/teams","hooks_url":"https://api.github.com/repos/emotion-js/emotion/hooks","issue_events_url":"https://api.github.com/repos/emotion-js/emotion/issues/events{/number}","events_url":"https://api.github.com/repos/emotion-js/emotion/events","assignees_url":"https://api.github.com/repos/emotion-js/emotion/assignees{/user}","branches_url":"https://api.github.com/repos/emotion-js/emotion/branches{/branch}","tags_url":"https://api.github.com/repos/emotion-js/emotion/tags","blobs_url":"https://api.github.com/repos/emotion-js/emotion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emotion-js/emotion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emotion-js/emotion/git/refs{/sha}","trees_url":"https://api.github.com/repos/emotion-js/emotion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emotion-js/emotion/statuses/{sha}","languages_url":"https://api.github.com/repos/emotion-js/emotion/languages","stargazers_url":"https://api.github.com/repos/emotion-js/emotion/stargazers","contributors_url":"https://api.github.com/repos/emotion-js/emotion/contributors","subscribers_url":"https://api.github.com/repos/emotion-js/emotion/subscribers","subscription_url":"https://api.github.com/repos/emotion-js/emotion/subscription","commits_url":"https://api.github.com/repos/emotion-js/emotion/commits{/sha}","git_commits_url":"https://api.github.com/repos/emotion-js/emotion/git/commits{/sha}","comments_url":"https://api.github.com/repos/emotion-js/emotion/comments{/number}","issue_comment_url":"https://api.github.com/repos/emotion-js/emotion/issues/comments{/number}","contents_url":"https://api.github.com/repos/emotion-js/emotion/contents/{+path}","compare_url":"https://api.github.com/repos/emotion-js/emotion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emotion-js/emotion/merges","archive_url":"https://api.github.com/repos/emotion-js/emotion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emotion-js/emotion/downloads","issues_url":"https://api.github.com/repos/emotion-js/emotion/issues{/number}","pulls_url":"https://api.github.com/repos/emotion-js/emotion/pulls{/number}","milestones_url":"https://api.github.com/repos/emotion-js/emotion/milestones{/number}","notifications_url":"https://api.github.com/repos/emotion-js/emotion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emotion-js/emotion/labels{/name}","releases_url":"https://api.github.com/repos/emotion-js/emotion/releases{/id}","deployments_url":"https://api.github.com/repos/emotion-js/emotion/deployments","created_at":"2017-05-27T04:23:45Z","updated_at":"2018-05-15T16:23:38Z","pushed_at":"2018-05-15T16:36:10Z","git_url":"git://github.com/emotion-js/emotion.git","ssh_url":"git@github.com:emotion-js/emotion.git","clone_url":"https://github.com/emotion-js/emotion.git","svn_url":"https://github.com/emotion-js/emotion","homepage":"https://emotion.sh/","size":3637,"stargazers_count":3581,"watchers_count":3581,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":211,"mirror_url":null,"archived":false,"open_issues_count":64,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":211,"open_issues":64,"watchers":3581,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emotion-js/emotion/pulls/658"},"html":{"href":"https://github.com/emotion-js/emotion/pull/658"},"issue":{"href":"https://api.github.com/repos/emotion-js/emotion/issues/658"},"comments":{"href":"https://api.github.com/repos/emotion-js/emotion/issues/658/comments"},"review_comments":{"href":"https://api.github.com/repos/emotion-js/emotion/pulls/658/comments"},"review_comment":{"href":"https://api.github.com/repos/emotion-js/emotion/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emotion-js/emotion/pulls/658/commits"},"statuses":{"href":"https://api.github.com/repos/emotion-js/emotion/statuses/ec9357997abac75de861593354897bbc64a85328"}},"author_association":"NONE"}}
{"actor":{"display_login":"Andarist"}}