{"action":"created","issue":{"url":"https://api.github.com/repos/electron/electron/issues/13869","repository_url":"https://api.github.com/repos/electron/electron","labels_url":"https://api.github.com/repos/electron/electron/issues/13869/labels{/name}","comments_url":"https://api.github.com/repos/electron/electron/issues/13869/comments","events_url":"https://api.github.com/repos/electron/electron/issues/13869/events","html_url":"https://github.com/electron/electron/pull/13869","id":345658117,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NzI4NTEw","number":13869,"title":"fix: use OOPIF for webview tag","user":{"login":"zcbenz","id":639601,"node_id":"MDQ6VXNlcjYzOTYwMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/639601?v=4","gravatar_id":"","url":"https://api.github.com/users/zcbenz","html_url":"https://github.com/zcbenz","followers_url":"https://api.github.com/users/zcbenz/followers","following_url":"https://api.github.com/users/zcbenz/following{/other_user}","gists_url":"https://api.github.com/users/zcbenz/gists{/gist_id}","starred_url":"https://api.github.com/users/zcbenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zcbenz/subscriptions","organizations_url":"https://api.github.com/users/zcbenz/orgs","repos_url":"https://api.github.com/users/zcbenz/repos","events_url":"https://api.github.com/users/zcbenz/events{/privacy}","received_events_url":"https://api.github.com/users/zcbenz/received_events","type":"User","site_admin":true},"labels":[{"id":969709864,"node_id":"MDU6TGFiZWw5Njk3MDk4NjQ=","url":"https://api.github.com/repos/electron/electron/labels/target/3-0-x","name":"target/3-0-x","color":"f22fa2","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-07-30T08:24:18Z","updated_at":"2018-08-16T22:30:11Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/electron/electron/pulls/13869","html_url":"https://github.com/electron/electron/pull/13869","diff_url":"https://github.com/electron/electron/pull/13869.diff","patch_url":"https://github.com/electron/electron/pull/13869.patch"},"body":"Close https://github.com/electron/electron/issues/13503.\r\nClose #12291.\r\n\r\nnotes: Migrate `<webview>` to use out-of-process iframe.\r\n"},"comment":{"url":"https://api.github.com/repos/electron/electron/issues/comments/413703937","html_url":"https://github.com/electron/electron/pull/13869#issuecomment-413703937","issue_url":"https://api.github.com/repos/electron/electron/issues/13869","id":413703937,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzcwMzkzNw==","user":{"login":"zcbenz","id":639601,"node_id":"MDQ6VXNlcjYzOTYwMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/639601?v=4","gravatar_id":"","url":"https://api.github.com/users/zcbenz","html_url":"https://github.com/zcbenz","followers_url":"https://api.github.com/users/zcbenz/followers","following_url":"https://api.github.com/users/zcbenz/following{/other_user}","gists_url":"https://api.github.com/users/zcbenz/gists{/gist_id}","starred_url":"https://api.github.com/users/zcbenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zcbenz/subscriptions","organizations_url":"https://api.github.com/users/zcbenz/orgs","repos_url":"https://api.github.com/users/zcbenz/repos","events_url":"https://api.github.com/users/zcbenz/events{/privacy}","received_events_url":"https://api.github.com/users/zcbenz/received_events","type":"User","site_admin":true},"created_at":"2018-08-16T22:30:11Z","updated_at":"2018-08-16T22:30:11Z","author_association":"CONTRIBUTOR","body":"> not ok 886 chromium feature window.opener access from works when origin matches\r\n> Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure \"done()\" is called; if returning a Promise, ensure it resolves. (C:\\projects\\electron-39ng6\\spec\\chromium-spec.js)\r\n\r\nAfter more investigation with it, I think it is caused by some issues with `window.open` implementation, not with the webview implementation. After rerunning the CI job the flaky failure is gone.\r\n\r\nThis PR should be ready to go."}}
{"actor":{"display_login":"zcbenz"}}