{"action":"created","comment":{"url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/pulls/comments/175498606","pull_request_review_id":105037593,"id":175498606,"diff_hunk":"@@ -2,10 +2,4 @@\n \n = render partial: 'layouts/header', locals: { page_heading: t('page_headings.edit_agfs_claim') }\n \n-- present(@claim) do |claim|\n-  .grid-row.grid-sidebar\n-    .column-two-thirds.first\n-      = render partial: 'form', locals: { claim: claim }\n-\n-    .column-one-third.first\n-      = render partial: 'external_users/claims/summary_claims_sidebar', locals: { claim: claim, display_buttons: false }\n+= render partial: 'external_users/claims/layout_proxy', locals: { claim: @claim, display_buttons: false }","path":"app/views/external_users/advocates/claims/edit.html.haml","position":11,"original_position":11,"commit_id":"d67aec196c2f01ac44dd99944ceabfb163f6e1d0","original_commit_id":"d67aec196c2f01ac44dd99944ceabfb163f6e1d0","user":{"login":"lostie","id":67125,"avatar_url":"https://avatars2.githubusercontent.com/u/67125?v=4","gravatar_id":"","url":"https://api.github.com/users/lostie","html_url":"https://github.com/lostie","followers_url":"https://api.github.com/users/lostie/followers","following_url":"https://api.github.com/users/lostie/following{/other_user}","gists_url":"https://api.github.com/users/lostie/gists{/gist_id}","starred_url":"https://api.github.com/users/lostie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lostie/subscriptions","organizations_url":"https://api.github.com/users/lostie/orgs","repos_url":"https://api.github.com/users/lostie/repos","events_url":"https://api.github.com/users/lostie/events{/privacy}","received_events_url":"https://api.github.com/users/lostie/received_events","type":"User","site_admin":false},"body":"**[not a blocker/nit pick]** I find this name a bit confusing since it doesn't tell me its even related to the form rendering. \r\n\r\n💭  Would `external_users/claims/form_wrapper` or `external_users/claims/form_layout` be more clear of the intent of that _template_?","created_at":"2018-03-19T16:28:33Z","updated_at":"2018-03-19T16:28:33Z","html_url":"https://github.com/ministryofjustice/Claim-for-Crown-Court-Defence/pull/2282#discussion_r175498606","pull_request_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/pulls/2282","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/pulls/comments/175498606"},"html":{"href":"https://github.com/ministryofjustice/Claim-for-Crown-Court-Defence/pull/2282#discussion_r175498606"},"pull_request":{"href":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/pulls/2282"}}},"pull_request":{"url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/pulls/2282","id":175883738,"html_url":"https://github.com/ministryofjustice/Claim-for-Crown-Court-Defence/pull/2282","diff_url":"https://github.com/ministryofjustice/Claim-for-Crown-Court-Defence/pull/2282.diff","patch_url":"https://github.com/ministryofjustice/Claim-for-Crown-Court-Defence/pull/2282.patch","issue_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/issues/2282","number":2282,"state":"open","locked":false,"title":"Sidebar: Show / Hide on pages as required","user":{"login":"cleargif","id":3668907,"avatar_url":"https://avatars1.githubusercontent.com/u/3668907?v=4","gravatar_id":"","url":"https://api.github.com/users/cleargif","html_url":"https://github.com/cleargif","followers_url":"https://api.github.com/users/cleargif/followers","following_url":"https://api.github.com/users/cleargif/following{/other_user}","gists_url":"https://api.github.com/users/cleargif/gists{/gist_id}","starred_url":"https://api.github.com/users/cleargif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cleargif/subscriptions","organizations_url":"https://api.github.com/users/cleargif/orgs","repos_url":"https://api.github.com/users/cleargif/repos","events_url":"https://api.github.com/users/cleargif/events{/privacy}","received_events_url":"https://api.github.com/users/cleargif/received_events","type":"User","site_admin":false},"body":"#### What\r\n- Introducing a new partial to cut down on duplication\r\n- Apply logic to show / hide the sidebar as required\r\n\r\n#### Ticket\r\n[Sidebar: Show / Hide on pages as required](https://www.pivotaltracker.com/story/show/156087810)\r\n\r\n#### Why\r\nThe side bar should only be shown on some pages.\r\n","created_at":"2018-03-19T12:25:15Z","updated_at":"2018-03-19T16:28:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"55520b8d7548415e59f1363752da23c3aa192707","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":188884129,"url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":334361185,"url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/labels/frontend","name":"frontend","color":"207de5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/pulls/2282/commits","review_comments_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/pulls/2282/comments","review_comment_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/issues/2282/comments","statuses_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/statuses/d67aec196c2f01ac44dd99944ceabfb163f6e1d0","head":{"label":"ministryofjustice:ui-sidebar-show-hide","ref":"ui-sidebar-show-hide","sha":"d67aec196c2f01ac44dd99944ceabfb163f6e1d0","user":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars3.githubusercontent.com/u/2203574?v=4","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"repo":{"id":32451549,"name":"Claim-for-Crown-Court-Defence","full_name":"ministryofjustice/Claim-for-Crown-Court-Defence","owner":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars3.githubusercontent.com/u/2203574?v=4","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ministryofjustice/Claim-for-Crown-Court-Defence","description":"Claim for Crown Court Defence, formerly Advocate Defence Payments (ADP), aka Crime Billing Online (CBO)","fork":false,"url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence","forks_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/forks","keys_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/teams","hooks_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/hooks","issue_events_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/issues/events{/number}","events_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/events","assignees_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/assignees{/user}","branches_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/branches{/branch}","tags_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/tags","blobs_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/git/refs{/sha}","trees_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/statuses/{sha}","languages_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/languages","stargazers_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/stargazers","contributors_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/contributors","subscribers_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/subscribers","subscription_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/subscription","commits_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/commits{/sha}","git_commits_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/git/commits{/sha}","comments_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/comments{/number}","issue_comment_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/issues/comments{/number}","contents_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/contents/{+path}","compare_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/merges","archive_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/downloads","issues_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/issues{/number}","pulls_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/pulls{/number}","milestones_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/milestones{/number}","notifications_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/labels{/name}","releases_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/releases{/id}","deployments_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/deployments","created_at":"2015-03-18T10:10:18Z","updated_at":"2018-03-16T14:44:24Z","pushed_at":"2018-03-19T16:24:22Z","git_url":"git://github.com/ministryofjustice/Claim-for-Crown-Court-Defence.git","ssh_url":"git@github.com:ministryofjustice/Claim-for-Crown-Court-Defence.git","clone_url":"https://github.com/ministryofjustice/Claim-for-Crown-Court-Defence.git","svn_url":"https://github.com/ministryofjustice/Claim-for-Crown-Court-Defence","homepage":"","size":15575,"stargazers_count":6,"watchers_count":6,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":13,"watchers":6,"default_branch":"master"}},"base":{"label":"ministryofjustice:master","ref":"master","sha":"bf427e74747ba25dbc1ee44b5d25db4e6a66c2e5","user":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars3.githubusercontent.com/u/2203574?v=4","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"repo":{"id":32451549,"name":"Claim-for-Crown-Court-Defence","full_name":"ministryofjustice/Claim-for-Crown-Court-Defence","owner":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars3.githubusercontent.com/u/2203574?v=4","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ministryofjustice/Claim-for-Crown-Court-Defence","description":"Claim for Crown Court Defence, formerly Advocate Defence Payments (ADP), aka Crime Billing Online (CBO)","fork":false,"url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence","forks_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/forks","keys_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/teams","hooks_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/hooks","issue_events_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/issues/events{/number}","events_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/events","assignees_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/assignees{/user}","branches_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/branches{/branch}","tags_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/tags","blobs_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/git/refs{/sha}","trees_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/statuses/{sha}","languages_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/languages","stargazers_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/stargazers","contributors_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/contributors","subscribers_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/subscribers","subscription_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/subscription","commits_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/commits{/sha}","git_commits_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/git/commits{/sha}","comments_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/comments{/number}","issue_comment_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/issues/comments{/number}","contents_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/contents/{+path}","compare_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/merges","archive_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/downloads","issues_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/issues{/number}","pulls_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/pulls{/number}","milestones_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/milestones{/number}","notifications_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/labels{/name}","releases_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/releases{/id}","deployments_url":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/deployments","created_at":"2015-03-18T10:10:18Z","updated_at":"2018-03-16T14:44:24Z","pushed_at":"2018-03-19T16:24:22Z","git_url":"git://github.com/ministryofjustice/Claim-for-Crown-Court-Defence.git","ssh_url":"git@github.com:ministryofjustice/Claim-for-Crown-Court-Defence.git","clone_url":"https://github.com/ministryofjustice/Claim-for-Crown-Court-Defence.git","svn_url":"https://github.com/ministryofjustice/Claim-for-Crown-Court-Defence","homepage":"","size":15575,"stargazers_count":6,"watchers_count":6,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":13,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/pulls/2282"},"html":{"href":"https://github.com/ministryofjustice/Claim-for-Crown-Court-Defence/pull/2282"},"issue":{"href":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/issues/2282"},"comments":{"href":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/issues/2282/comments"},"review_comments":{"href":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/pulls/2282/comments"},"review_comment":{"href":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/pulls/2282/commits"},"statuses":{"href":"https://api.github.com/repos/ministryofjustice/Claim-for-Crown-Court-Defence/statuses/d67aec196c2f01ac44dd99944ceabfb163f6e1d0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lostie"}}