{"action":"created","comment":{"url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/pulls/comments/211910158","pull_request_review_id":148428092,"id":211910158,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTkxMDE1OA==","diff_hunk":"@@ -227,4 +227,74 @@ public function addRole($role);\n      * @return static\n      */\n     public function removeRole($role);\n+\n+    /**\n+     * Checks whether the user's account has expired.\n+     *\n+     * Internally, if this method returns false, the authentication system\n+     * will throw an AccountExpiredException and prevent login.\n+     *\n+     * @return bool true if the user's account is non expired, false otherwise\n+     *\n+     * @see AccountExpiredException\n+     */\n+    public function isAccountNonExpired();\n+\n+    /**\n+     * Checks whether the user is locked.\n+     *\n+     * Internally, if this method returns false, the authentication system\n+     * will throw a LockedException and prevent login.\n+     *\n+     * @return bool true if the user is not locked, false otherwise\n+     *\n+     * @see LockedException\n+     */\n+    public function isAccountNonLocked();\n+\n+    /**\n+     * Checks whether the user's credentials (password) has expired.\n+     *\n+     * Internally, if this method returns false, the authentication system\n+     * will throw a CredentialsExpiredException and prevent login.\n+     *\n+     * @return bool true if the user's credentials are non expired, false otherwise\n+     *\n+     * @see CredentialsExpiredException\n+     */\n+    public function isCredentialsNonExpired();\n+\n+    /**\n+     * Checks whether the user is enabled.\n+     *\n+     * Internally, if this method returns false, the authentication system\n+     * will throw a DisabledException and prevent login.\n+     *\n+     * @return bool true if the user is enabled, false otherwise\n+     *\n+     * @see DisabledException\n+     */\n+    public function isEnabled();\n+}\n+\n+// This is required to support apps that explicitly check if a user is an instance of AdvancedUserInterface\n+if (interface_exists('\\Symfony\\Component\\Security\\Core\\User\\AdvancedUserInterface')) {","path":"Model/UserInterface.php","position":73,"original_position":73,"commit_id":"3fd0e9789ba08602b5873a164cfe5e61a8ebfd68","original_commit_id":"3fd0e9789ba08602b5873a164cfe5e61a8ebfd68","user":{"login":"stof","id":439401,"node_id":"MDQ6VXNlcjQzOTQwMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/439401?v=4","gravatar_id":"","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"body":"that won't work fine, as it will detect the version of the wrong component","created_at":"2018-08-22T10:49:20Z","updated_at":"2018-08-22T10:49:20Z","html_url":"https://github.com/FriendsOfSymfony/FOSUserBundle/pull/2815#discussion_r211910158","pull_request_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/pulls/2815","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/pulls/comments/211910158"},"html":{"href":"https://github.com/FriendsOfSymfony/FOSUserBundle/pull/2815#discussion_r211910158"},"pull_request":{"href":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/pulls/2815"}},"in_reply_to_id":211897742},"pull_request":{"url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/pulls/2815","id":199891872,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5ODkxODcy","html_url":"https://github.com/FriendsOfSymfony/FOSUserBundle/pull/2815","diff_url":"https://github.com/FriendsOfSymfony/FOSUserBundle/pull/2815.diff","patch_url":"https://github.com/FriendsOfSymfony/FOSUserBundle/pull/2815.patch","issue_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/issues/2815","number":2815,"state":"open","locked":false,"title":"Migrated SF AdvancedUserInterface to FOS UserInterface","user":{"login":"Devtronic","id":2362734,"node_id":"MDQ6VXNlcjIzNjI3MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2362734?v=4","gravatar_id":"","url":"https://api.github.com/users/Devtronic","html_url":"https://github.com/Devtronic","followers_url":"https://api.github.com/users/Devtronic/followers","following_url":"https://api.github.com/users/Devtronic/following{/other_user}","gists_url":"https://api.github.com/users/Devtronic/gists{/gist_id}","starred_url":"https://api.github.com/users/Devtronic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Devtronic/subscriptions","organizations_url":"https://api.github.com/users/Devtronic/orgs","repos_url":"https://api.github.com/users/Devtronic/repos","events_url":"https://api.github.com/users/Devtronic/events{/privacy}","received_events_url":"https://api.github.com/users/Devtronic/received_events","type":"User","site_admin":false},"body":"AdvancedUserInterface is deprecated since Symfony 4.1\r\n- https://symfony.com/blog/new-in-symfony-4-1-deprecated-the-advanceduserinterface\r\n- https://github.com/symfony/symfony/pull/23508\r\n\r\nIssues:\r\n- #2803 Deprecation with Symfony 4.1 - AdvancedUserInterface\r\n- #2802 Deprecation with Symfony 4.1 - AbstractToken::hasUserChanged","created_at":"2018-07-07T10:55:15Z","updated_at":"2018-08-22T10:49:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"47eb9170a7c339b9d193843e292562406b07b9ec","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/pulls/2815/commits","review_comments_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/pulls/2815/comments","review_comment_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/issues/2815/comments","statuses_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/statuses/3fd0e9789ba08602b5873a164cfe5e61a8ebfd68","head":{"label":"Devtronic:Issue_2803_AdvancedUserInterface","ref":"Issue_2803_AdvancedUserInterface","sha":"3fd0e9789ba08602b5873a164cfe5e61a8ebfd68","user":{"login":"Devtronic","id":2362734,"node_id":"MDQ6VXNlcjIzNjI3MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2362734?v=4","gravatar_id":"","url":"https://api.github.com/users/Devtronic","html_url":"https://github.com/Devtronic","followers_url":"https://api.github.com/users/Devtronic/followers","following_url":"https://api.github.com/users/Devtronic/following{/other_user}","gists_url":"https://api.github.com/users/Devtronic/gists{/gist_id}","starred_url":"https://api.github.com/users/Devtronic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Devtronic/subscriptions","organizations_url":"https://api.github.com/users/Devtronic/orgs","repos_url":"https://api.github.com/users/Devtronic/repos","events_url":"https://api.github.com/users/Devtronic/events{/privacy}","received_events_url":"https://api.github.com/users/Devtronic/received_events","type":"User","site_admin":false},"repo":{"id":140076239,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAwNzYyMzk=","name":"FOSUserBundle","full_name":"Devtronic/FOSUserBundle","owner":{"login":"Devtronic","id":2362734,"node_id":"MDQ6VXNlcjIzNjI3MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2362734?v=4","gravatar_id":"","url":"https://api.github.com/users/Devtronic","html_url":"https://github.com/Devtronic","followers_url":"https://api.github.com/users/Devtronic/followers","following_url":"https://api.github.com/users/Devtronic/following{/other_user}","gists_url":"https://api.github.com/users/Devtronic/gists{/gist_id}","starred_url":"https://api.github.com/users/Devtronic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Devtronic/subscriptions","organizations_url":"https://api.github.com/users/Devtronic/orgs","repos_url":"https://api.github.com/users/Devtronic/repos","events_url":"https://api.github.com/users/Devtronic/events{/privacy}","received_events_url":"https://api.github.com/users/Devtronic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Devtronic/FOSUserBundle","description":"Provides user management for your Symfony project. Compatible with Doctrine ORM & ODM, and custom storages.","fork":true,"url":"https://api.github.com/repos/Devtronic/FOSUserBundle","forks_url":"https://api.github.com/repos/Devtronic/FOSUserBundle/forks","keys_url":"https://api.github.com/repos/Devtronic/FOSUserBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Devtronic/FOSUserBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Devtronic/FOSUserBundle/teams","hooks_url":"https://api.github.com/repos/Devtronic/FOSUserBundle/hooks","issue_events_url":"https://api.github.com/repos/Devtronic/FOSUserBundle/issues/events{/number}","events_url":"https://api.github.com/repos/Devtronic/FOSUserBundle/events","assignees_url":"https://api.github.com/repos/Devtronic/FOSUserBundle/assignees{/user}","branches_url":"https://api.github.com/repos/Devtronic/FOSUserBundle/branches{/branch}","tags_url":"https://api.github.com/repos/Devtronic/FOSUserBundle/tags","blobs_url":"https://api.github.com/repos/Devtronic/FOSUserBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Devtronic/FOSUserBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Devtronic/FOSUserBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/Devtronic/FOSUserBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Devtronic/FOSUserBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/Devtronic/FOSUserBundle/languages","stargazers_url":"https://api.github.com/repos/Devtronic/FOSUserBundle/stargazers","contributors_url":"https://api.github.com/repos/Devtronic/FOSUserBundle/contributors","subscribers_url":"https://api.github.com/repos/Devtronic/FOSUserBundle/subscribers","subscription_url":"https://api.github.com/repos/Devtronic/FOSUserBundle/subscription","commits_url":"https://api.github.com/repos/Devtronic/FOSUserBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/Devtronic/FOSUserBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/Devtronic/FOSUserBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/Devtronic/FOSUserBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/Devtronic/FOSUserBundle/contents/{+path}","compare_url":"https://api.github.com/repos/Devtronic/FOSUserBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Devtronic/FOSUserBundle/merges","archive_url":"https://api.github.com/repos/Devtronic/FOSUserBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Devtronic/FOSUserBundle/downloads","issues_url":"https://api.github.com/repos/Devtronic/FOSUserBundle/issues{/number}","pulls_url":"https://api.github.com/repos/Devtronic/FOSUserBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/Devtronic/FOSUserBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/Devtronic/FOSUserBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Devtronic/FOSUserBundle/labels{/name}","releases_url":"https://api.github.com/repos/Devtronic/FOSUserBundle/releases{/id}","deployments_url":"https://api.github.com/repos/Devtronic/FOSUserBundle/deployments","created_at":"2018-07-07T10:53:51Z","updated_at":"2018-07-07T10:53:53Z","pushed_at":"2018-08-21T06:02:26Z","git_url":"git://github.com/Devtronic/FOSUserBundle.git","ssh_url":"git@github.com:Devtronic/FOSUserBundle.git","clone_url":"https://github.com/Devtronic/FOSUserBundle.git","svn_url":"https://github.com/Devtronic/FOSUserBundle","homepage":"https://symfony.com/doc/master/bundles/FOSUserBundle/index.html","size":3553,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FriendsOfSymfony:master","ref":"master","sha":"d41c5a9b95075e6bd95ffa11746514e3e9630539","user":{"login":"FriendsOfSymfony","id":529709,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyOTcwOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/529709?v=4","gravatar_id":"","url":"https://api.github.com/users/FriendsOfSymfony","html_url":"https://github.com/FriendsOfSymfony","followers_url":"https://api.github.com/users/FriendsOfSymfony/followers","following_url":"https://api.github.com/users/FriendsOfSymfony/following{/other_user}","gists_url":"https://api.github.com/users/FriendsOfSymfony/gists{/gist_id}","starred_url":"https://api.github.com/users/FriendsOfSymfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FriendsOfSymfony/subscriptions","organizations_url":"https://api.github.com/users/FriendsOfSymfony/orgs","repos_url":"https://api.github.com/users/FriendsOfSymfony/repos","events_url":"https://api.github.com/users/FriendsOfSymfony/events{/privacy}","received_events_url":"https://api.github.com/users/FriendsOfSymfony/received_events","type":"Organization","site_admin":false},"repo":{"id":1193527,"node_id":"MDEwOlJlcG9zaXRvcnkxMTkzNTI3","name":"FOSUserBundle","full_name":"FriendsOfSymfony/FOSUserBundle","owner":{"login":"FriendsOfSymfony","id":529709,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyOTcwOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/529709?v=4","gravatar_id":"","url":"https://api.github.com/users/FriendsOfSymfony","html_url":"https://github.com/FriendsOfSymfony","followers_url":"https://api.github.com/users/FriendsOfSymfony/followers","following_url":"https://api.github.com/users/FriendsOfSymfony/following{/other_user}","gists_url":"https://api.github.com/users/FriendsOfSymfony/gists{/gist_id}","starred_url":"https://api.github.com/users/FriendsOfSymfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FriendsOfSymfony/subscriptions","organizations_url":"https://api.github.com/users/FriendsOfSymfony/orgs","repos_url":"https://api.github.com/users/FriendsOfSymfony/repos","events_url":"https://api.github.com/users/FriendsOfSymfony/events{/privacy}","received_events_url":"https://api.github.com/users/FriendsOfSymfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FriendsOfSymfony/FOSUserBundle","description":"Provides user management for your Symfony project. Compatible with Doctrine ORM & ODM, and custom storages.","fork":true,"url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle","forks_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/forks","keys_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/teams","hooks_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/hooks","issue_events_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/issues/events{/number}","events_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/events","assignees_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/assignees{/user}","branches_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/branches{/branch}","tags_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/tags","blobs_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/languages","stargazers_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/stargazers","contributors_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/contributors","subscribers_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/subscribers","subscription_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/subscription","commits_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/contents/{+path}","compare_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/merges","archive_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/downloads","issues_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/issues{/number}","pulls_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/labels{/name}","releases_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/releases{/id}","deployments_url":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/deployments","created_at":"2010-12-23T15:50:55Z","updated_at":"2018-08-21T17:33:46Z","pushed_at":"2018-08-22T10:33:59Z","git_url":"git://github.com/FriendsOfSymfony/FOSUserBundle.git","ssh_url":"git@github.com:FriendsOfSymfony/FOSUserBundle.git","clone_url":"https://github.com/FriendsOfSymfony/FOSUserBundle.git","svn_url":"https://github.com/FriendsOfSymfony/FOSUserBundle","homepage":"https://symfony.com/doc/master/bundles/FOSUserBundle/index.html","size":3546,"stargazers_count":2819,"watchers_count":2819,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1554,"mirror_url":null,"archived":false,"open_issues_count":186,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1554,"open_issues":186,"watchers":2819,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/pulls/2815"},"html":{"href":"https://github.com/FriendsOfSymfony/FOSUserBundle/pull/2815"},"issue":{"href":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/issues/2815"},"comments":{"href":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/issues/2815/comments"},"review_comments":{"href":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/pulls/2815/comments"},"review_comment":{"href":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/pulls/2815/commits"},"statuses":{"href":"https://api.github.com/repos/FriendsOfSymfony/FOSUserBundle/statuses/3fd0e9789ba08602b5873a164cfe5e61a8ebfd68"}},"author_association":"NONE"}}
{"actor":{"display_login":"stof"}}