{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/72452","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/72452/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/72452/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/72452/events","html_url":"https://github.com/kubernetes/kubernetes/pull/72452","id":394945902,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNTM4Mjk5","number":72452,"title":"Adjust node_exporter CPU params","user":{"login":"SuperQ","id":1320667,"node_id":"MDQ6VXNlcjEzMjA2Njc=","avatar_url":"https://avatars1.githubusercontent.com/u/1320667?v=4","gravatar_id":"","url":"https://api.github.com/users/SuperQ","html_url":"https://github.com/SuperQ","followers_url":"https://api.github.com/users/SuperQ/followers","following_url":"https://api.github.com/users/SuperQ/following{/other_user}","gists_url":"https://api.github.com/users/SuperQ/gists{/gist_id}","starred_url":"https://api.github.com/users/SuperQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SuperQ/subscriptions","organizations_url":"https://api.github.com/users/SuperQ/orgs","repos_url":"https://api.github.com/users/SuperQ/repos","events_url":"https://api.github.com/users/SuperQ/events{/privacy}","received_events_url":"https://api.github.com/users/SuperQ/received_events","type":"User","site_admin":false},"labels":[{"id":477397085,"node_id":"MDU6TGFiZWw0NzczOTcwODU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20no","name":"cncf-cla: no","color":"e11d21","default":false},{"id":680152113,"node_id":"MDU6TGFiZWw2ODAxNTIxMTM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/do-not-merge/release-note-label-needed","name":"do-not-merge/release-note-label-needed","color":"e11d21","default":false},{"id":122775691,"node_id":"MDU6TGFiZWwxMjI3NzU2OTE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/cleanup","name":"kind/cleanup","color":"c7def8","default":false},{"id":1111992057,"node_id":"MDU6TGFiZWwxMTExOTkyMDU3","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-priority","name":"needs-priority","color":"ededed","default":false},{"id":1086787260,"node_id":"MDU6TGFiZWwxMDg2Nzg3MjYw","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/ok-to-test","name":"ok-to-test","color":"15dd18","default":false},{"id":173494222,"node_id":"MDU6TGFiZWwxNzM0OTQyMjI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/cluster-lifecycle","name":"sig/cluster-lifecycle","color":"d2b48c","default":false},{"id":253450793,"node_id":"MDU6TGFiZWwyNTM0NTA3OTM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XS","name":"size/XS","color":"009900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-12-31T08:26:02Z","updated_at":"2019-01-02T09:35:38Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/72452","html_url":"https://github.com/kubernetes/kubernetes/pull/72452","diff_url":"https://github.com/kubernetes/kubernetes/pull/72452.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/72452.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n\r\n1. If this is your first time, please read our contributor guidelines: https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request. For reference on required PR/issue labels, read here:\r\nhttps://git.k8s.io/community/contributors/devel/release.md#issue-kind-label\r\n3. Ensure you have added or ran the appropriate tests for your PR: https://git.k8s.io/community/contributors/devel/testing.md\r\n4. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n5. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n6. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What type of PR is this?**\r\n> Uncomment only one, leave it on its own line:\r\n>\r\n> /kind api-change\r\n> /kind bug\r\n/kind cleanup\r\n> /kind design\r\n> /kind documentation\r\n> /kind failing-test\r\n> /kind feature\r\n> /kind flake\r\n\r\n**What this PR does / why we need it**:\r\n\r\nThe node_exporter CPU use is bursty, as it needs a bit of CPU at scrape time. Don't set a CPU limit to avoid collection stalls.\r\n\r\nSet the request to 100m to more closely match the typical max core needs.\r\n\r\n**Which issue(s) this PR fixes**:\r\n<!-- \r\n*Automatically closes linked issue when PR is merged.\r\nUsage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.\r\n_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*\r\n-->\r\nFixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Does this PR introduce a user-facing change?**:\r\n\r\nNone\r\n\r\n```release-note\r\n\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/450819341","html_url":"https://github.com/kubernetes/kubernetes/pull/72452#issuecomment-450819341","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/72452","id":450819341,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDgxOTM0MQ==","user":{"login":"SuperQ","id":1320667,"node_id":"MDQ6VXNlcjEzMjA2Njc=","avatar_url":"https://avatars1.githubusercontent.com/u/1320667?v=4","gravatar_id":"","url":"https://api.github.com/users/SuperQ","html_url":"https://github.com/SuperQ","followers_url":"https://api.github.com/users/SuperQ/followers","following_url":"https://api.github.com/users/SuperQ/following{/other_user}","gists_url":"https://api.github.com/users/SuperQ/gists{/gist_id}","starred_url":"https://api.github.com/users/SuperQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SuperQ/subscriptions","organizations_url":"https://api.github.com/users/SuperQ/orgs","repos_url":"https://api.github.com/users/SuperQ/repos","events_url":"https://api.github.com/users/SuperQ/events{/privacy}","received_events_url":"https://api.github.com/users/SuperQ/received_events","type":"User","site_admin":false},"created_at":"2019-01-02T09:35:38Z","updated_at":"2019-01-02T09:35:38Z","author_association":"NONE","body":"Another option would be to move the files to a \"tests\" directory, rather than \"addons\". This would make it more clear that the files are not meant to be consumed by end users."}}
{"actor":{"display_login":"SuperQ"}}