{"action":"created","issue":{"url":"https://api.github.com/repos/ratson/cordova-plugin-admob-free/issues/186","repository_url":"https://api.github.com/repos/ratson/cordova-plugin-admob-free","labels_url":"https://api.github.com/repos/ratson/cordova-plugin-admob-free/issues/186/labels{/name}","comments_url":"https://api.github.com/repos/ratson/cordova-plugin-admob-free/issues/186/comments","events_url":"https://api.github.com/repos/ratson/cordova-plugin-admob-free/issues/186/events","html_url":"https://github.com/ratson/cordova-plugin-admob-free/pull/186","id":306437431,"node_id":"MDExOlB1bGxSZXF1ZXN0MTc1ODgwNzkz","number":186,"title":"Add space for non-overlapping bottom banners on iPhone X","user":{"login":"MBuchalik","id":8061217,"node_id":"MDQ6VXNlcjgwNjEyMTc=","avatar_url":"https://avatars2.githubusercontent.com/u/8061217?v=4","gravatar_id":"","url":"https://api.github.com/users/MBuchalik","html_url":"https://github.com/MBuchalik","followers_url":"https://api.github.com/users/MBuchalik/followers","following_url":"https://api.github.com/users/MBuchalik/following{/other_user}","gists_url":"https://api.github.com/users/MBuchalik/gists{/gist_id}","starred_url":"https://api.github.com/users/MBuchalik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MBuchalik/subscriptions","organizations_url":"https://api.github.com/users/MBuchalik/orgs","repos_url":"https://api.github.com/users/MBuchalik/repos","events_url":"https://api.github.com/users/MBuchalik/events{/privacy}","received_events_url":"https://api.github.com/users/MBuchalik/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-03-19T12:11:56Z","updated_at":"2018-06-08T23:43:35Z","closed_at":"2018-03-23T16:21:17Z","author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/ratson/cordova-plugin-admob-free/pulls/186","html_url":"https://github.com/ratson/cordova-plugin-admob-free/pull/186","diff_url":"https://github.com/ratson/cordova-plugin-admob-free/pull/186.diff","patch_url":"https://github.com/ratson/cordova-plugin-admob-free/pull/186.patch"},"body":"This PR adds basic support for iPhone X. Please note the following:\r\n- Only bottom banners are affected that don't overlap the WebView.\r\n- I don't have an Obj C background. So: Please look at the changes carefully. \r\n- The idea is based on https://github.com/appfeel/admob-google-cordova/commit/0bdea388a25cb59b887b5a99847470c76097cb81\r\n- I added a black background for the webView's superview. Otherwise, the bottom part would be white which - in my opinion - doesn't look that great.\r\n\r\n## How did I test it?\r\nUnfortunately, I don't have a physical iPhone X for testing. All tests were made in the iOS simulator with the test ad ID provided by Google.\r\n\r\nBelow, you can find a few screenshots. I hope this PR will be useful for you. :smiley:\r\n\r\n![iphone-x-portrait](https://user-images.githubusercontent.com/8061217/37594907-fe13d082-2b76-11e8-93c4-2b825692f29d.png)\r\n![iphone-x-landscape](https://user-images.githubusercontent.com/8061217/37594906-fdf31234-2b76-11e8-9381-3c8328c5ee13.png)\r\n![iphone-6s-portrait](https://user-images.githubusercontent.com/8061217/37594904-fdd1e0be-2b76-11e8-8828-b6dd89a7de60.png)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/ratson/cordova-plugin-admob-free/issues/comments/395920216","html_url":"https://github.com/ratson/cordova-plugin-admob-free/pull/186#issuecomment-395920216","issue_url":"https://api.github.com/repos/ratson/cordova-plugin-admob-free/issues/186","id":395920216,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NTkyMDIxNg==","user":{"login":"tennist","id":23710022,"node_id":"MDQ6VXNlcjIzNzEwMDIy","avatar_url":"https://avatars3.githubusercontent.com/u/23710022?v=4","gravatar_id":"","url":"https://api.github.com/users/tennist","html_url":"https://github.com/tennist","followers_url":"https://api.github.com/users/tennist/followers","following_url":"https://api.github.com/users/tennist/following{/other_user}","gists_url":"https://api.github.com/users/tennist/gists{/gist_id}","starred_url":"https://api.github.com/users/tennist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tennist/subscriptions","organizations_url":"https://api.github.com/users/tennist/orgs","repos_url":"https://api.github.com/users/tennist/repos","events_url":"https://api.github.com/users/tennist/events{/privacy}","received_events_url":"https://api.github.com/users/tennist/received_events","type":"User","site_admin":false},"created_at":"2018-06-08T23:43:35Z","updated_at":"2018-06-08T23:43:35Z","author_association":"NONE","body":"@MBuchalik  I just submitted a pull request that I believe solves my issue and keep your app looking the way you want it to.  We can work together to build upon my solution if you feel like it, however, my apps do not need any further enhancement.\r\n\r\nAlso,  I am open to help others that might need to implement this solution into the other banner ad placement locations (top, top-overlay, or bottom-overlay)."}}
{"actor":{"display_login":"tennist"}}