{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/169202009","pull_request_review_id":97690115,"id":169202009,"diff_hunk":"@@ -78,7 +78,15 @@ rec {\n     } @ t:\n \n     let\n-      testDriverName = \"nixos-test-driver-${name}\";\n+      maxTestNameLen = 50;","path":"nixos/lib/testing.nix","position":5,"original_position":5,"commit_id":"d81136d1dfdc7473424d8ea4eb5ccd2a92cca6fd","original_commit_id":"d81136d1dfdc7473424d8ea4eb5ccd2a92cca6fd","user":{"login":"grahamc","id":76716,"avatar_url":"https://avatars3.githubusercontent.com/u/76716?v=4","gravatar_id":"","url":"https://api.github.com/users/grahamc","html_url":"https://github.com/grahamc","followers_url":"https://api.github.com/users/grahamc/followers","following_url":"https://api.github.com/users/grahamc/following{/other_user}","gists_url":"https://api.github.com/users/grahamc/gists{/gist_id}","starred_url":"https://api.github.com/users/grahamc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grahamc/subscriptions","organizations_url":"https://api.github.com/users/grahamc/orgs","repos_url":"https://api.github.com/users/grahamc/repos","events_url":"https://api.github.com/users/grahamc/events{/privacy}","received_events_url":"https://api.github.com/users/grahamc/received_events","type":"User","site_admin":false},"body":"Can you document here how you came up with 50?","created_at":"2018-02-20T01:49:48Z","updated_at":"2018-02-20T01:49:48Z","html_url":"https://github.com/NixOS/nixpkgs/pull/35173#discussion_r169202009","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/35173","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/169202009"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/35173#discussion_r169202009"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/35173"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/35173","id":169934898,"html_url":"https://github.com/NixOS/nixpkgs/pull/35173","diff_url":"https://github.com/NixOS/nixpkgs/pull/35173.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/35173.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/35173","number":35173,"state":"open","locked":false,"title":"makeTest: Only allow test names of up to 50 characters","user":{"login":"manveru","id":3507,"avatar_url":"https://avatars1.githubusercontent.com/u/3507?v=4","gravatar_id":"","url":"https://api.github.com/users/manveru","html_url":"https://github.com/manveru","followers_url":"https://api.github.com/users/manveru/followers","following_url":"https://api.github.com/users/manveru/following{/other_user}","gists_url":"https://api.github.com/users/manveru/gists{/gist_id}","starred_url":"https://api.github.com/users/manveru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manveru/subscriptions","organizations_url":"https://api.github.com/users/manveru/orgs","repos_url":"https://api.github.com/users/manveru/repos","events_url":"https://api.github.com/users/manveru/events{/privacy}","received_events_url":"https://api.github.com/users/manveru/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\nhttps://github.com/NixOS/nixpkgs/issues/34393\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n","created_at":"2018-02-19T11:19:29Z","updated_at":"2018-02-20T01:49:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"522ae4ecb5a8185938c026fee10d1645b4f3f0dd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":737642262,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%200","name":"10.rebuild-darwin: 0","color":"eeffee","default":false},{"id":737642408,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%200","name":"10.rebuild-linux: 0","color":"eeffee","default":false},{"id":60265212,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20nixos","name":"6.topic: nixos","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/35173/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/35173/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/35173/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/d81136d1dfdc7473424d8ea4eb5ccd2a92cca6fd","head":{"label":"manveru:max-test-name-length","ref":"max-test-name-length","sha":"d81136d1dfdc7473424d8ea4eb5ccd2a92cca6fd","user":{"login":"manveru","id":3507,"avatar_url":"https://avatars1.githubusercontent.com/u/3507?v=4","gravatar_id":"","url":"https://api.github.com/users/manveru","html_url":"https://github.com/manveru","followers_url":"https://api.github.com/users/manveru/followers","following_url":"https://api.github.com/users/manveru/following{/other_user}","gists_url":"https://api.github.com/users/manveru/gists{/gist_id}","starred_url":"https://api.github.com/users/manveru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manveru/subscriptions","organizations_url":"https://api.github.com/users/manveru/orgs","repos_url":"https://api.github.com/users/manveru/repos","events_url":"https://api.github.com/users/manveru/events{/privacy}","received_events_url":"https://api.github.com/users/manveru/received_events","type":"User","site_admin":false},"repo":{"id":45301675,"name":"nixpkgs","full_name":"manveru/nixpkgs","owner":{"login":"manveru","id":3507,"avatar_url":"https://avatars1.githubusercontent.com/u/3507?v=4","gravatar_id":"","url":"https://api.github.com/users/manveru","html_url":"https://github.com/manveru","followers_url":"https://api.github.com/users/manveru/followers","following_url":"https://api.github.com/users/manveru/following{/other_user}","gists_url":"https://api.github.com/users/manveru/gists{/gist_id}","starred_url":"https://api.github.com/users/manveru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manveru/subscriptions","organizations_url":"https://api.github.com/users/manveru/orgs","repos_url":"https://api.github.com/users/manveru/repos","events_url":"https://api.github.com/users/manveru/events{/privacy}","received_events_url":"https://api.github.com/users/manveru/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/manveru/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/manveru/nixpkgs","forks_url":"https://api.github.com/repos/manveru/nixpkgs/forks","keys_url":"https://api.github.com/repos/manveru/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/manveru/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/manveru/nixpkgs/teams","hooks_url":"https://api.github.com/repos/manveru/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/manveru/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/manveru/nixpkgs/events","assignees_url":"https://api.github.com/repos/manveru/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/manveru/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/manveru/nixpkgs/tags","blobs_url":"https://api.github.com/repos/manveru/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/manveru/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/manveru/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/manveru/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/manveru/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/manveru/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/manveru/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/manveru/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/manveru/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/manveru/nixpkgs/subscription","commits_url":"https://api.github.com/repos/manveru/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/manveru/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/manveru/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/manveru/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/manveru/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/manveru/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/manveru/nixpkgs/merges","archive_url":"https://api.github.com/repos/manveru/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/manveru/nixpkgs/downloads","issues_url":"https://api.github.com/repos/manveru/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/manveru/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/manveru/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/manveru/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/manveru/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/manveru/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/manveru/nixpkgs/deployments","created_at":"2015-10-31T12:56:21Z","updated_at":"2016-01-25T16:51:51Z","pushed_at":"2018-02-19T21:56:18Z","git_url":"git://github.com/manveru/nixpkgs.git","ssh_url":"git@github.com:manveru/nixpkgs.git","clone_url":"https://github.com/manveru/nixpkgs.git","svn_url":"https://github.com/manveru/nixpkgs","homepage":null,"size":644888,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"2a6c7aebcd27acf44149df1433546a7e5d3de420","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-02-19T20:53:17Z","pushed_at":"2018-02-20T01:48:17Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":719680,"stargazers_count":2227,"watchers_count":2227,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2571,"mirror_url":null,"archived":false,"open_issues_count":2889,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2571,"open_issues":2889,"watchers":2227,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/35173"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/35173"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/35173"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/35173/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/35173/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/35173/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/d81136d1dfdc7473424d8ea4eb5ccd2a92cca6fd"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"grahamc"}}