{"action":"closed","number":4879,"pull_request":{"url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/4879","id":208744764,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NzQ0NzY0","html_url":"https://github.com/vuetifyjs/vuetify/pull/4879","diff_url":"https://github.com/vuetifyjs/vuetify/pull/4879.diff","patch_url":"https://github.com/vuetifyjs/vuetify/pull/4879.patch","issue_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues/4879","number":4879,"state":"closed","locked":false,"title":"Feat/v autocomplete issue4663 - open on items change","user":{"login":"dkichler","id":1474899,"node_id":"MDQ6VXNlcjE0NzQ4OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/1474899?v=4","gravatar_id":"","url":"https://api.github.com/users/dkichler","html_url":"https://github.com/dkichler","followers_url":"https://api.github.com/users/dkichler/followers","following_url":"https://api.github.com/users/dkichler/following{/other_user}","gists_url":"https://api.github.com/users/dkichler/gists{/gist_id}","starred_url":"https://api.github.com/users/dkichler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkichler/subscriptions","organizations_url":"https://api.github.com/users/dkichler/orgs","repos_url":"https://api.github.com/users/dkichler/repos","events_url":"https://api.github.com/users/dkichler/events{/privacy}","received_events_url":"https://api.github.com/users/dkichler/received_events","type":"User","site_admin":false},"body":"<!--\r\nMAKE SURE TO READ THE CONTRIBUTING GUIDE BEFORE CREATING A PR\r\nhttps://github.com/vuetifyjs/vuetify/blob/master/.github/CONTRIBUTING.md\r\n-->\r\n\r\n<!-- Provide a general summary of your changes in the Title above -->\r\n<!-- Keep the title short and descriptive, as it will be used as a commit message -->\r\n\r\n## Description\r\nAdds a prop for controlling the behaviour of opening the menu when the input holds focus and the `items` change.  Current behaviour is to open the menu (when not already open) in all cases.  The prop allows this behaviour to be overridden. \r\n\r\n## Motivation and Context\r\nThis gives the client more flexibility in controlling when the menu is invoked.  Partially fixes #4663 \r\n\r\nDefault behaviour has been maintained in this PR, but given how many developers have been reporting it as a bug, there may be merit in changing default behaviour to suppress the menu opening instead.\r\n\r\n## How Has This Been Tested?\r\nThere are specs included in the PR demonstrating existing default behaviour, as well as (new) overridden behaviour to suppress the menu from being invoked. \r\n\r\nI have also tested the changes manually in a local environment.\r\n\r\n## Markup:\r\n<!--- Paste markup for testing your change --->\r\n<details>\r\n\r\nStandard (will become default with the proposed solution) use case, autocomplete does not open when items change:\r\n```vue\r\n<v-btn label=\"Change contact types\" @click=\"changesContactTypesImmediately\">Change</v-btn>\r\n\r\n<v-autocomplete :items=\"filteredContactNames(contactTypes)\"\r\n                :label=\"contactLabel\"\r\n                :item-text=\"contactName\"\r\n                v-model=\"contact\">\r\n</v-autocomplete>\r\n```\r\n\r\nUse case where there is an async call responsible for updating `items`, and the clients wishes for the menu to open when the call finishes and the menu holds focus:\r\n```vue\r\n<v-autocomplete :items=\"filteredContactNames(contactTypes)\"\r\n                :label=\"contactLabel\"\r\n                :item-text=\"contactName\"\r\n                open-on-items-changed\r\n                v-model=\"contact\">\r\n</v-autocomplete>\r\n```\r\n</details>\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n    - addresses a 'bug' issue, but I would argue is closer to new functionality.\r\n- [x] New feature (non-breaking change which adds functionality) \r\n    - as per the new prop\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n- [ ] Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] The PR title is no longer than 64 characters.\r\n- [x] The PR is submitted to the correct branch (`master` for bug fixes, `dev` for new features and breaking changes).  \r\n    - I think this could be argued either way - I've targeted `dev` considering the new prop.\r\n- [x] My code follows the code style of this project.\r\n- [x] My change requires a change to the documentation.\r\n- [ ] I have created a PR in the [documentation](https://github.com/vuetifyjs/vuetifyjs.com) with the necessary changes.\r\n    - will wait for initial feedback on this PR\r\n","created_at":"2018-08-16T04:50:32Z","updated_at":"2018-09-13T19:56:09Z","closed_at":"2018-09-13T19:56:09Z","merged_at":null,"merge_commit_sha":"ca6f97b028719445bce7b64fca8da8f3ae6ad99d","assignee":{"login":"johnleider","id":9064066,"node_id":"MDQ6VXNlcjkwNjQwNjY=","avatar_url":"https://avatars3.githubusercontent.com/u/9064066?v=4","gravatar_id":"","url":"https://api.github.com/users/johnleider","html_url":"https://github.com/johnleider","followers_url":"https://api.github.com/users/johnleider/followers","following_url":"https://api.github.com/users/johnleider/following{/other_user}","gists_url":"https://api.github.com/users/johnleider/gists{/gist_id}","starred_url":"https://api.github.com/users/johnleider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnleider/subscriptions","organizations_url":"https://api.github.com/users/johnleider/orgs","repos_url":"https://api.github.com/users/johnleider/repos","events_url":"https://api.github.com/users/johnleider/events{/privacy}","received_events_url":"https://api.github.com/users/johnleider/received_events","type":"User","site_admin":false},"assignees":[{"login":"johnleider","id":9064066,"node_id":"MDQ6VXNlcjkwNjQwNjY=","avatar_url":"https://avatars3.githubusercontent.com/u/9064066?v=4","gravatar_id":"","url":"https://api.github.com/users/johnleider","html_url":"https://github.com/johnleider","followers_url":"https://api.github.com/users/johnleider/followers","following_url":"https://api.github.com/users/johnleider/following{/other_user}","gists_url":"https://api.github.com/users/johnleider/gists{/gist_id}","starred_url":"https://api.github.com/users/johnleider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnleider/subscriptions","organizations_url":"https://api.github.com/users/johnleider/orgs","repos_url":"https://api.github.com/users/johnleider/repos","events_url":"https://api.github.com/users/johnleider/events{/privacy}","received_events_url":"https://api.github.com/users/johnleider/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"KaelWD","id":16421948,"node_id":"MDQ6VXNlcjE2NDIxOTQ4","avatar_url":"https://avatars2.githubusercontent.com/u/16421948?v=4","gravatar_id":"","url":"https://api.github.com/users/KaelWD","html_url":"https://github.com/KaelWD","followers_url":"https://api.github.com/users/KaelWD/followers","following_url":"https://api.github.com/users/KaelWD/following{/other_user}","gists_url":"https://api.github.com/users/KaelWD/gists{/gist_id}","starred_url":"https://api.github.com/users/KaelWD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KaelWD/subscriptions","organizations_url":"https://api.github.com/users/KaelWD/orgs","repos_url":"https://api.github.com/users/KaelWD/repos","events_url":"https://api.github.com/users/KaelWD/events{/privacy}","received_events_url":"https://api.github.com/users/KaelWD/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/4879/commits","review_comments_url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/4879/comments","review_comment_url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues/4879/comments","statuses_url":"https://api.github.com/repos/vuetifyjs/vuetify/statuses/acd8de2dc0c7bfd850a22193cb33f4f09db5ef80","head":{"label":"dkichler:feat/v-autocomplete-issue4663","ref":"feat/v-autocomplete-issue4663","sha":"acd8de2dc0c7bfd850a22193cb33f4f09db5ef80","user":{"login":"dkichler","id":1474899,"node_id":"MDQ6VXNlcjE0NzQ4OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/1474899?v=4","gravatar_id":"","url":"https://api.github.com/users/dkichler","html_url":"https://github.com/dkichler","followers_url":"https://api.github.com/users/dkichler/followers","following_url":"https://api.github.com/users/dkichler/following{/other_user}","gists_url":"https://api.github.com/users/dkichler/gists{/gist_id}","starred_url":"https://api.github.com/users/dkichler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkichler/subscriptions","organizations_url":"https://api.github.com/users/dkichler/orgs","repos_url":"https://api.github.com/users/dkichler/repos","events_url":"https://api.github.com/users/dkichler/events{/privacy}","received_events_url":"https://api.github.com/users/dkichler/received_events","type":"User","site_admin":false},"repo":{"id":144794732,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ3OTQ3MzI=","name":"vuetify","full_name":"dkichler/vuetify","owner":{"login":"dkichler","id":1474899,"node_id":"MDQ6VXNlcjE0NzQ4OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/1474899?v=4","gravatar_id":"","url":"https://api.github.com/users/dkichler","html_url":"https://github.com/dkichler","followers_url":"https://api.github.com/users/dkichler/followers","following_url":"https://api.github.com/users/dkichler/following{/other_user}","gists_url":"https://api.github.com/users/dkichler/gists{/gist_id}","starred_url":"https://api.github.com/users/dkichler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkichler/subscriptions","organizations_url":"https://api.github.com/users/dkichler/orgs","repos_url":"https://api.github.com/users/dkichler/repos","events_url":"https://api.github.com/users/dkichler/events{/privacy}","received_events_url":"https://api.github.com/users/dkichler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dkichler/vuetify","description":"Material Component Framework for Vue.js 2","fork":true,"url":"https://api.github.com/repos/dkichler/vuetify","forks_url":"https://api.github.com/repos/dkichler/vuetify/forks","keys_url":"https://api.github.com/repos/dkichler/vuetify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dkichler/vuetify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dkichler/vuetify/teams","hooks_url":"https://api.github.com/repos/dkichler/vuetify/hooks","issue_events_url":"https://api.github.com/repos/dkichler/vuetify/issues/events{/number}","events_url":"https://api.github.com/repos/dkichler/vuetify/events","assignees_url":"https://api.github.com/repos/dkichler/vuetify/assignees{/user}","branches_url":"https://api.github.com/repos/dkichler/vuetify/branches{/branch}","tags_url":"https://api.github.com/repos/dkichler/vuetify/tags","blobs_url":"https://api.github.com/repos/dkichler/vuetify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dkichler/vuetify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dkichler/vuetify/git/refs{/sha}","trees_url":"https://api.github.com/repos/dkichler/vuetify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dkichler/vuetify/statuses/{sha}","languages_url":"https://api.github.com/repos/dkichler/vuetify/languages","stargazers_url":"https://api.github.com/repos/dkichler/vuetify/stargazers","contributors_url":"https://api.github.com/repos/dkichler/vuetify/contributors","subscribers_url":"https://api.github.com/repos/dkichler/vuetify/subscribers","subscription_url":"https://api.github.com/repos/dkichler/vuetify/subscription","commits_url":"https://api.github.com/repos/dkichler/vuetify/commits{/sha}","git_commits_url":"https://api.github.com/repos/dkichler/vuetify/git/commits{/sha}","comments_url":"https://api.github.com/repos/dkichler/vuetify/comments{/number}","issue_comment_url":"https://api.github.com/repos/dkichler/vuetify/issues/comments{/number}","contents_url":"https://api.github.com/repos/dkichler/vuetify/contents/{+path}","compare_url":"https://api.github.com/repos/dkichler/vuetify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dkichler/vuetify/merges","archive_url":"https://api.github.com/repos/dkichler/vuetify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dkichler/vuetify/downloads","issues_url":"https://api.github.com/repos/dkichler/vuetify/issues{/number}","pulls_url":"https://api.github.com/repos/dkichler/vuetify/pulls{/number}","milestones_url":"https://api.github.com/repos/dkichler/vuetify/milestones{/number}","notifications_url":"https://api.github.com/repos/dkichler/vuetify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dkichler/vuetify/labels{/name}","releases_url":"https://api.github.com/repos/dkichler/vuetify/releases{/id}","deployments_url":"https://api.github.com/repos/dkichler/vuetify/deployments","created_at":"2018-08-15T02:18:17Z","updated_at":"2018-08-15T02:18:21Z","pushed_at":"2018-09-06T04:34:43Z","git_url":"git://github.com/dkichler/vuetify.git","ssh_url":"git@github.com:dkichler/vuetify.git","clone_url":"https://github.com/dkichler/vuetify.git","svn_url":"https://github.com/dkichler/vuetify","homepage":"https://vuetifyjs.com","size":15071,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"vuetifyjs:dev","ref":"dev","sha":"a4438289867621101748601ba06f05ff3d324e93","user":{"login":"vuetifyjs","id":22138497,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTM4NDk3","avatar_url":"https://avatars3.githubusercontent.com/u/22138497?v=4","gravatar_id":"","url":"https://api.github.com/users/vuetifyjs","html_url":"https://github.com/vuetifyjs","followers_url":"https://api.github.com/users/vuetifyjs/followers","following_url":"https://api.github.com/users/vuetifyjs/following{/other_user}","gists_url":"https://api.github.com/users/vuetifyjs/gists{/gist_id}","starred_url":"https://api.github.com/users/vuetifyjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuetifyjs/subscriptions","organizations_url":"https://api.github.com/users/vuetifyjs/orgs","repos_url":"https://api.github.com/users/vuetifyjs/repos","events_url":"https://api.github.com/users/vuetifyjs/events{/privacy}","received_events_url":"https://api.github.com/users/vuetifyjs/received_events","type":"Organization","site_admin":false},"repo":{"id":67962648,"node_id":"MDEwOlJlcG9zaXRvcnk2Nzk2MjY0OA==","name":"vuetify","full_name":"vuetifyjs/vuetify","owner":{"login":"vuetifyjs","id":22138497,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTM4NDk3","avatar_url":"https://avatars3.githubusercontent.com/u/22138497?v=4","gravatar_id":"","url":"https://api.github.com/users/vuetifyjs","html_url":"https://github.com/vuetifyjs","followers_url":"https://api.github.com/users/vuetifyjs/followers","following_url":"https://api.github.com/users/vuetifyjs/following{/other_user}","gists_url":"https://api.github.com/users/vuetifyjs/gists{/gist_id}","starred_url":"https://api.github.com/users/vuetifyjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuetifyjs/subscriptions","organizations_url":"https://api.github.com/users/vuetifyjs/orgs","repos_url":"https://api.github.com/users/vuetifyjs/repos","events_url":"https://api.github.com/users/vuetifyjs/events{/privacy}","received_events_url":"https://api.github.com/users/vuetifyjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vuetifyjs/vuetify","description":"Material Component Framework for Vue.js 2","fork":false,"url":"https://api.github.com/repos/vuetifyjs/vuetify","forks_url":"https://api.github.com/repos/vuetifyjs/vuetify/forks","keys_url":"https://api.github.com/repos/vuetifyjs/vuetify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vuetifyjs/vuetify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vuetifyjs/vuetify/teams","hooks_url":"https://api.github.com/repos/vuetifyjs/vuetify/hooks","issue_events_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues/events{/number}","events_url":"https://api.github.com/repos/vuetifyjs/vuetify/events","assignees_url":"https://api.github.com/repos/vuetifyjs/vuetify/assignees{/user}","branches_url":"https://api.github.com/repos/vuetifyjs/vuetify/branches{/branch}","tags_url":"https://api.github.com/repos/vuetifyjs/vuetify/tags","blobs_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/refs{/sha}","trees_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vuetifyjs/vuetify/statuses/{sha}","languages_url":"https://api.github.com/repos/vuetifyjs/vuetify/languages","stargazers_url":"https://api.github.com/repos/vuetifyjs/vuetify/stargazers","contributors_url":"https://api.github.com/repos/vuetifyjs/vuetify/contributors","subscribers_url":"https://api.github.com/repos/vuetifyjs/vuetify/subscribers","subscription_url":"https://api.github.com/repos/vuetifyjs/vuetify/subscription","commits_url":"https://api.github.com/repos/vuetifyjs/vuetify/commits{/sha}","git_commits_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/commits{/sha}","comments_url":"https://api.github.com/repos/vuetifyjs/vuetify/comments{/number}","issue_comment_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues/comments{/number}","contents_url":"https://api.github.com/repos/vuetifyjs/vuetify/contents/{+path}","compare_url":"https://api.github.com/repos/vuetifyjs/vuetify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vuetifyjs/vuetify/merges","archive_url":"https://api.github.com/repos/vuetifyjs/vuetify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vuetifyjs/vuetify/downloads","issues_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues{/number}","pulls_url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls{/number}","milestones_url":"https://api.github.com/repos/vuetifyjs/vuetify/milestones{/number}","notifications_url":"https://api.github.com/repos/vuetifyjs/vuetify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vuetifyjs/vuetify/labels{/name}","releases_url":"https://api.github.com/repos/vuetifyjs/vuetify/releases{/id}","deployments_url":"https://api.github.com/repos/vuetifyjs/vuetify/deployments","created_at":"2016-09-12T00:39:35Z","updated_at":"2018-09-13T17:34:49Z","pushed_at":"2018-09-13T17:02:01Z","git_url":"git://github.com/vuetifyjs/vuetify.git","ssh_url":"git@github.com:vuetifyjs/vuetify.git","clone_url":"https://github.com/vuetifyjs/vuetify.git","svn_url":"https://github.com/vuetifyjs/vuetify","homepage":"https://vuetifyjs.com","size":15147,"stargazers_count":13170,"watchers_count":13170,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1150,"mirror_url":null,"archived":false,"open_issues_count":476,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1150,"open_issues":476,"watchers":13170,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/4879"},"html":{"href":"https://github.com/vuetifyjs/vuetify/pull/4879"},"issue":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/issues/4879"},"comments":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/issues/4879/comments"},"review_comments":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/4879/comments"},"review_comment":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/4879/commits"},"statuses":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/statuses/acd8de2dc0c7bfd850a22193cb33f4f09db5ef80"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":false,"mergeable_state":"unstable","merged_by":null,"comments":9,"review_comments":6,"maintainer_can_modify":false,"commits":4,"additions":28,"deletions":20,"changed_files":2}}
{"actor":{"display_login":"dkichler"}}