{"push_id":3057613667,"size":68,"distinct_size":10,"ref":"refs/heads/user-item","head":"1a17f8a41e9286cc542f731b0a3ef9a5b2fafed8","before":"8f765d6d55b087defff59ed4255fbe00dd1a4b50","commits":[{"sha":"83fb5582d8a71c6bf9dc5b90d8678d0a7025c404","author":{"name":"Greg Price","email":"79e2475f81a6317276bf7cbb3958b20d289b78df@zulipchat.com"},"message":"i18n: Pull translations from Transifex.\n\nThanks to our translation contributors for the additional and improved\ntranslations in Italian, Chinese, Japanese, Czech, and Portuguese.\nAlso add two languages which we've newly opened up on Transifex but\ndon't yet have translations in.","distinct":false,"url":"https://api.github.com/repos/jainkuniya/zulip-mobile/commits/83fb5582d8a71c6bf9dc5b90d8678d0a7025c404"},{"sha":"e0b0b97d2f4d411da3d46f68ea73b9a651c450b1","author":{"name":"Greg Price","email":"79e2475f81a6317276bf7cbb3958b20d289b78df@zulipchat.com"},"message":"android build: Fix warnings about ignored old build-tools versions.\n\nThis eliminates the noisiest of the several kinds of\ndeprecation-warning spew that our third-party dependencies generate --\none set of lines like this (with varying version numbers) for each of\nour 11 dependencies:\n\n  WARNING: The specified Android SDK Build Tools version (25.0.2) is ignored, as it is below the minimum supported version (28.0.3) for Android Gradle Plugin 3.2.1.\n  Android SDK Build Tools 28.0.3 will be used.\n  To suppress this warning, remove \"buildToolsVersion '25.0.2'\" from your build.gradle file, as each version of the Android Gradle Plugin now has a default version of the build tools.\n\nA couple of other kinds remain.  But now the complete output of\n`./gradlew assembleDebug` can fit on a single screen!","distinct":false,"url":"https://api.github.com/repos/jainkuniya/zulip-mobile/commits/e0b0b97d2f4d411da3d46f68ea73b9a651c450b1"},{"sha":"8b53d65197efa95909be846f58255b22396da322","author":{"name":"Vishwesh Jainkuniya","email":"adfd5c9cc509da49e6dc5c1123db843b98e2a728@gmail.com"},"message":"emoji: Straighten out emoji-reaction types.\n\nThe type we called SlimEventReaction doesn't describe anything we\nactually see at runtime, and nor does the generality of `user: any` in\nEventReaction.  Instead, both reaction events and reactions in message\nfetch results look a lot like what we have in EventReactionCommon.\n\nSo, pull that out and call it Reaction.  Replace uses of EventReaction\nand SlimEventReaction with that.  Because it's part of the server API,\nput it in apiTypes.js.\n\nThis is a pure type-annotations change.","distinct":false,"url":"https://api.github.com/repos/jainkuniya/zulip-mobile/commits/8b53d65197efa95909be846f58255b22396da322"},{"sha":"5f640ce686891b6022e34ababa99891b9700af56","author":{"name":"Vishwesh Jainkuniya","email":"adfd5c9cc509da49e6dc5c1123db843b98e2a728@gmail.com"},"message":"emoji: Put a `reactions` in Outbox objects, to match Message.","distinct":false,"url":"https://api.github.com/repos/jainkuniya/zulip-mobile/commits/5f640ce686891b6022e34ababa99891b9700af56"},{"sha":"2c68c1339428761dc665dffb3734e6197473b7d0","author":{"name":"Greg Price","email":"79e2475f81a6317276bf7cbb3958b20d289b78df@zulipchat.com"},"message":"emoji: Fix minor formatting on Reaction type.\n\n* Keep Reaction next to its helper ReactionType.\n* Put properties in logical order (general to specific),\n  matching zerver/models.py.\n* Trim trailing blank line in jsdoc, and collapse to\n  single line when it fits.\n* Blank line before jsdoc (on emoji_code).\n\nAlso update the \"see also\" on ReactionType.","distinct":false,"url":"https://api.github.com/repos/jainkuniya/zulip-mobile/commits/2c68c1339428761dc665dffb3734e6197473b7d0"},{"sha":"2f4a0ebfa9205b31a695a2a9440fab398ee21fba","author":{"name":"Vishwesh Jainkuniya","email":"adfd5c9cc509da49e6dc5c1123db843b98e2a728@gmail.com"},"message":"messageReducers: Store forgotten fields on a reaction event.\n\nWe had a type error, which Flow awkwardly does not find.  (This is\nfacebook/flow#6871 .)  As a result, we were dropping these two\nproperties in our Redux store, which ends with us failing to include\nthem when we ask the server to add or remove our own reaction after\nthe user taps the reaction's display in the UI.\n\nFixes #2784.\n\n[greg: added discussion of type error]","distinct":false,"url":"https://api.github.com/repos/jainkuniya/zulip-mobile/commits/2f4a0ebfa9205b31a695a2a9440fab398ee21fba"},{"sha":"3d1f20cf65b683ee9cdefd0fbdd65a0374814ef9","author":{"name":"Greg Price","email":"79e2475f81a6317276bf7cbb3958b20d289b78df@zulipchat.com"},"message":"docs: Start a changelog file.\n\nI already prepare this information to be used in various ways: it goes\non the App Store, the Play Store, and GitHub to accompany each\nrelease, and it's often handy to refer back to.  Start keeping it in a\nmore convenient in-tree location for all of us to easily refer to.","distinct":false,"url":"https://api.github.com/repos/jainkuniya/zulip-mobile/commits/3d1f20cf65b683ee9cdefd0fbdd65a0374814ef9"},{"sha":"781e7903987c3fbf4fc9c39059fb0beb9ab6978e","author":{"name":"Greg Price","email":"79e2475f81a6317276bf7cbb3958b20d289b78df@zulipchat.com"},"message":"android build: Get all our dependencies on the right compileSdkVersion.\n\nCompile everything with the same SDK version we use for our own code.\n\nWithout this, a release build fails with errors from AAPT about\nmissing resources, in any of several dependencies.","distinct":false,"url":"https://api.github.com/repos/jainkuniya/zulip-mobile/commits/781e7903987c3fbf4fc9c39059fb0beb9ab6978e"},{"sha":"54e5a4f4e0a551a207947af0f7977cca1988613d","author":{"name":"Greg Price","email":"79e2475f81a6317276bf7cbb3958b20d289b78df@zulipchat.com"},"message":"android build: Simplify our Gradle code for buildToolsVersion a bit.\n\nThis applies a couple of small tricks learned in the code for\n`compileSdkVersion`: use `subprojects` to exclude the root project,\nand `project.hasProperty`.","distinct":false,"url":"https://api.github.com/repos/jainkuniya/zulip-mobile/commits/54e5a4f4e0a551a207947af0f7977cca1988613d"},{"sha":"833d083a9cb87f1c1f82b6bf855813fd6cd72c15","author":{"name":"Greg Price","email":"79e2475f81a6317276bf7cbb3958b20d289b78df@zulipchat.com"},"message":"android build: Make release bundler work with new Android plugin.\n\nWithout this change, a release build succeeds... but crashes on\nstartup because it can't find `index.android.bundle`, the file that\nshould contain all our JS.  It can't find that file for the excellent\nreason that there is no such file in assets/ inside the APK, as there\npreviously was in release builds.  Presumably this is due to some\ncombination of the upgrades to RN, to the Android Gradle plugin, and\nto other build-time dependencies which we've done since 19.2.102.\n\nSome poking around finds that the bundle is getting placed in the same\ndirectory as it was in previous release builds:\n  app/build/intermediates/assets/release/\nbut other assets which are still making it into the APK are going into\na different directory:\n  app/build/intermediates/merged_assets/release/mergeReleaseAssets/out\nSo I guess that's the new place that assets should go.\n\nFurther poking around finds where the old directory name is coming\nfrom: `react.gradle` hardcodes it.  Fixed upstream in commit\nfacebook/react-native@e90319e9f (facebook/react-native#21782)...\nthough by hardcoding a different scheme, so that still seems\nvulnerable to breaking on a future plugin version. 🤷\n\nAnyway, for the present: fortunately, we can override the bad old\nhardcode with our own hardcode in our config, as a workaround.\nDo that.","distinct":false,"url":"https://api.github.com/repos/jainkuniya/zulip-mobile/commits/833d083a9cb87f1c1f82b6bf855813fd6cd72c15"},{"sha":"5b7de6c3a83a68f98877273893bf462825ac6b37","author":{"name":"Greg Price","email":"79e2475f81a6317276bf7cbb3958b20d289b78df@zulipchat.com"},"message":"version: 20.0.103 release.","distinct":false,"url":"https://api.github.com/repos/jainkuniya/zulip-mobile/commits/5b7de6c3a83a68f98877273893bf462825ac6b37"},{"sha":"28cfec7e6ab121da2a4535b46bd8b5a89f85c919","author":{"name":"Greg Price","email":"79e2475f81a6317276bf7cbb3958b20d289b78df@zulipchat.com"},"message":"changelog: Add \"highlights\" corresponding to notes in app stores.\n\nFor release notes on the Play Store and Apple's App Store, the more\ndetailed list and the references to specific issue and PR numbers\naren't appropriate for the medium.  Include here a copy of the\nmore-summarized notes I just posted on the Play Store (in our beta\nchannel) and plan to post on Apple's App Store shortly.\n\nAlso note the date of the release.","distinct":false,"url":"https://api.github.com/repos/jainkuniya/zulip-mobile/commits/28cfec7e6ab121da2a4535b46bd8b5a89f85c919"},{"sha":"db14ee715d90ef67bb3f2d94d42c020d50d64940","author":{"name":"Greg Price","email":"79e2475f81a6317276bf7cbb3958b20d289b78df@zulipchat.com"},"message":"changelog: Explain the dating convention.","distinct":false,"url":"https://api.github.com/repos/jainkuniya/zulip-mobile/commits/db14ee715d90ef67bb3f2d94d42c020d50d64940"},{"sha":"cf4d701c35204d73f93cebc43c4380ea4d9f2e7a","author":{"name":"Boris Yankov","email":"1fc8c31f144cfb4b993a76e874a19b43338c69c4@gmail.com"},"message":"Remove require cycles in `/common` components\n\nThese changes in the `import` clauses help remove all\n'require cycles' that React Native have found in the `/common`\ncomponents.","distinct":false,"url":"https://api.github.com/repos/jainkuniya/zulip-mobile/commits/cf4d701c35204d73f93cebc43c4380ea4d9f2e7a"},{"sha":"0055df205d69b1d054c771780053c5ec0381fbb4","author":{"name":"Boris Yankov","email":"1fc8c31f144cfb4b993a76e874a19b43338c69c4@gmail.com"},"message":"Extract several functions out of `utils/message`\n\nTo remove `require cycles` and for better logical organizaion,\nextract the functions in `utils/message` that operae on recipients\nto another file `utils/recipients.js`.","distinct":false,"url":"https://api.github.com/repos/jainkuniya/zulip-mobile/commits/0055df205d69b1d054c771780053c5ec0381fbb4"},{"sha":"08f1bfdd0b4dcb2aaf734ef590e6a78ca386618a","author":{"name":"Boris Yankov","email":"1fc8c31f144cfb4b993a76e874a19b43338c69c4@gmail.com"},"message":"Remove require cycles in action imports\n\nChanges import paths whenever an action requires another action\nand that would lead to a require cycle.","distinct":false,"url":"https://api.github.com/repos/jainkuniya/zulip-mobile/commits/08f1bfdd0b4dcb2aaf734ef590e6a78ca386618a"},{"sha":"69100d1e67ae85c17448e50df2f035b726fefe22","author":{"name":"Boris Yankov","email":"1fc8c31f144cfb4b993a76e874a19b43338c69c4@gmail.com"},"message":"Reactivate Reactotron!\n\nRefresh our config and use of Reactotron in order to improve our\nability to debug the app.\n\nThis:\n * Updates dependencies to the latest Reactotron version\n * Simplifies the config, some of the `use` lines were not needed as\n   `useReactNative` already enabled them\n * enable again, but only for __DEV__\n * includes `__DEV__` as a ESLint global, preventing an error\n * turns the Reactotron `import` into a non-hoistable `require` and\n   moves it inside the `if` to not include in production builds\n * leaves `reactotronRedux` for a next commit, requires more changes","distinct":false,"url":"https://api.github.com/repos/jainkuniya/zulip-mobile/commits/69100d1e67ae85c17448e50df2f035b726fefe22"},{"sha":"f2e1d57916a8ef3e9bcd4cae1128379efdd13a66","author":{"name":"Boris Yankov","email":"1fc8c31f144cfb4b993a76e874a19b43338c69c4@gmail.com"},"message":"reactotron: Enable `reactotronRedux`.\n\n* adds `reactotronRedux` dynamic require\n* adds conditional import of either the plain Redux createStore or\n  the one from `Reactotron`\n* adds a check for Jest running the Reactotron code, if so bail out\n  (this fixes a `WebSocket` not defined error failing in Jest)","distinct":false,"url":"https://api.github.com/repos/jainkuniya/zulip-mobile/commits/f2e1d57916a8ef3e9bcd4cae1128379efdd13a66"},{"sha":"51e1a9cb0a93ba2ad36312ffe1db41ae7cfd004a","author":{"name":"Boris Yankov","email":"1fc8c31f144cfb4b993a76e874a19b43338c69c4@gmail.com"},"message":"Fix message loading indicators not showing\n\nWhen we navigate to a new narrow, there are three cases regarding\nthe existence of messages:\n * there are no messages\n * there are messages\n * there are currently no messages but fetching\n\nIn case (3) we are showing a \"message loading\" indicator.\n\nCurrently though, we are showing it quite rarely. This is caused\nby us first navigating to the narrow and then starting to load new\nmessages (the logic is 'show if no messages but fetching').\n\nWe are smart enough to update that state even if the order is\nnavigation then loading, but it takes some time. Our new handshake\nalgorithm slows things down a bit too. Thus it seems we no longer\nshow the loading indicator in many cases.\n\nThe solution is simple and effective. First do the fetching, then\ndo the actual navigation to the narrow.","distinct":false,"url":"https://api.github.com/repos/jainkuniya/zulip-mobile/commits/51e1a9cb0a93ba2ad36312ffe1db41ae7cfd004a"},{"sha":"0e5d0363190a4bd88b030a879a0cdb3bc318b4b0","author":{"name":"Boris Yankov","email":"1fc8c31f144cfb4b993a76e874a19b43338c69c4@gmail.com"},"message":"docs: Remove WebView console.log instructions\n\nNow an outdated advice, remove the `console.log` instructions\nboth from documentation and `MessageListWeb.js` comments.","distinct":false,"url":"https://api.github.com/repos/jainkuniya/zulip-mobile/commits/0e5d0363190a4bd88b030a879a0cdb3bc318b4b0"}]}
{"actor":{"display_login":"gnprice"}}