{"action":"created","issue":{"url":"https://api.github.com/repos/nicolargo/glances/issues/1253","repository_url":"https://api.github.com/repos/nicolargo/glances","labels_url":"https://api.github.com/repos/nicolargo/glances/issues/1253/labels{/name}","comments_url":"https://api.github.com/repos/nicolargo/glances/issues/1253/comments","events_url":"https://api.github.com/repos/nicolargo/glances/issues/1253/events","html_url":"https://github.com/nicolargo/glances/pull/1253","id":317660851,"number":1253,"title":"Use https URLs for checking external IP","user":{"login":"viq","id":639461,"avatar_url":"https://avatars0.githubusercontent.com/u/639461?v=4","gravatar_id":"","url":"https://api.github.com/users/viq","html_url":"https://github.com/viq","followers_url":"https://api.github.com/users/viq/followers","following_url":"https://api.github.com/users/viq/following{/other_user}","gists_url":"https://api.github.com/users/viq/gists{/gist_id}","starred_url":"https://api.github.com/users/viq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viq/subscriptions","organizations_url":"https://api.github.com/users/viq/orgs","repos_url":"https://api.github.com/users/viq/repos","events_url":"https://api.github.com/users/viq/events{/privacy}","received_events_url":"https://api.github.com/users/viq/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-04-25T14:45:08Z","updated_at":"2018-04-29T20:25:30Z","closed_at":"2018-04-29T20:24:07Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/nicolargo/glances/pulls/1253","html_url":"https://github.com/nicolargo/glances/pull/1253","diff_url":"https://github.com/nicolargo/glances/pull/1253.diff","patch_url":"https://github.com/nicolargo/glances/pull/1253.patch"},"body":"Processing JSON from connection that could be changed by attacker in path sounds scary, and all those services serve over https as well.\r\n\r\n#### Description\r\n\r\nCheck own IP over https. Glances processes output returned, which sometimes is JSON, and doing that over plaintext http which could be transparently modified in flight is scary.\r\n\r\n#### Resume\r\n\r\n* Bug fix: yes\r\n* New feature: no"},"comment":{"url":"https://api.github.com/repos/nicolargo/glances/issues/comments/385278899","html_url":"https://github.com/nicolargo/glances/pull/1253#issuecomment-385278899","issue_url":"https://api.github.com/repos/nicolargo/glances/issues/1253","id":385278899,"user":{"login":"nicolargo","id":776747,"avatar_url":"https://avatars0.githubusercontent.com/u/776747?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolargo","html_url":"https://github.com/nicolargo","followers_url":"https://api.github.com/users/nicolargo/followers","following_url":"https://api.github.com/users/nicolargo/following{/other_user}","gists_url":"https://api.github.com/users/nicolargo/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolargo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolargo/subscriptions","organizations_url":"https://api.github.com/users/nicolargo/orgs","repos_url":"https://api.github.com/users/nicolargo/repos","events_url":"https://api.github.com/users/nicolargo/events{/privacy}","received_events_url":"https://api.github.com/users/nicolargo/received_events","type":"User","site_admin":false},"created_at":"2018-04-29T20:25:30Z","updated_at":"2018-04-29T20:25:30Z","author_association":"OWNER","body":"Done in commit 8b6b0d3"}}
{"actor":{"display_login":"nicolargo"}}