{"action":"created","comment":{"url":"https://api.github.com/repos/patternfly/patternfly-react/pulls/comments/226868718","pull_request_review_id":166791377,"id":226868718,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjg2ODcxOA==","diff_hunk":"@@ -42,14 +42,16 @@ const variantToIcon = {\n   [ProgressVariant.success]: CheckCircleIcon\n };\n \n-const ProgressContainer = ({ value, title, parentId, variant, measureLocation }) => {\n+const ProgressContainer = ({ value, title, parentId, label, variant, measureLocation }) => {\n   const StatusIcon = variantToIcon.hasOwnProperty(variant) && variantToIcon[variant];\n   return (\n     <Fragment>\n       <div className={css(styles.progressDescription)} id={`${parentId}-description`}>\n         {title}\n       </div>\n       <div className={css(styles.progressStatus)}>\n+        {/* TODO: add padding to label */}\n+        {label}\n         {(measureLocation === ProgressMeasureLocation.top || measureLocation === ProgressMeasureLocation.outside) && (\n           <span className={css(styles.progressMeasure)}>{value}%</span>\n         )}","path":"packages/patternfly-4/react-core/src/components/Progress/ProgressContainer.js","position":56,"original_position":17,"commit_id":"353ea44dfacb42d094a1724af3fb1beb2fc16f35","original_commit_id":"d0a886e5aac4db7dc4884bc00d3eee52cfa892b1","user":{"login":"karelhala","id":3439771,"node_id":"MDQ6VXNlcjM0Mzk3NzE=","avatar_url":"https://avatars0.githubusercontent.com/u/3439771?v=4","gravatar_id":"","url":"https://api.github.com/users/karelhala","html_url":"https://github.com/karelhala","followers_url":"https://api.github.com/users/karelhala/followers","following_url":"https://api.github.com/users/karelhala/following{/other_user}","gists_url":"https://api.github.com/users/karelhala/gists{/gist_id}","starred_url":"https://api.github.com/users/karelhala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karelhala/subscriptions","organizations_url":"https://api.github.com/users/karelhala/orgs","repos_url":"https://api.github.com/users/karelhala/repos","events_url":"https://api.github.com/users/karelhala/events{/privacy}","received_events_url":"https://api.github.com/users/karelhala/received_events","type":"User","site_admin":false},"body":"Your example fits this as well, you'll just use `measureLocation={ProgressMeasureLocation.none}` and pass your own label which will be whatever you'll want (string, node, number). If we'd were to force parentheses we'll be targeting only this specific example. But what if someone would want to show `Already donwloaded: 50 %`? We'd have to have another branching here.\r\n\r\nBut you are correct that I should add styles applied to progress number on top of those custom styles (so label has some padding).","created_at":"2018-10-21T16:18:48Z","updated_at":"2018-10-21T16:18:48Z","html_url":"https://github.com/patternfly/patternfly-react/pull/822#discussion_r226868718","pull_request_url":"https://api.github.com/repos/patternfly/patternfly-react/pulls/822","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/patternfly/patternfly-react/pulls/comments/226868718"},"html":{"href":"https://github.com/patternfly/patternfly-react/pull/822#discussion_r226868718"},"pull_request":{"href":"https://api.github.com/repos/patternfly/patternfly-react/pulls/822"}},"in_reply_to_id":226847644},"pull_request":{"url":"https://api.github.com/repos/patternfly/patternfly-react/pulls/822","id":224504411,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NTA0NDEx","html_url":"https://github.com/patternfly/patternfly-react/pull/822","diff_url":"https://github.com/patternfly/patternfly-react/pull/822.diff","patch_url":"https://github.com/patternfly/patternfly-react/pull/822.patch","issue_url":"https://api.github.com/repos/patternfly/patternfly-react/issues/822","number":822,"state":"open","locked":false,"title":"feat(Labeled progress): allow consumers to pass additional label for progressbar","user":{"login":"karelhala","id":3439771,"node_id":"MDQ6VXNlcjM0Mzk3NzE=","avatar_url":"https://avatars0.githubusercontent.com/u/3439771?v=4","gravatar_id":"","url":"https://api.github.com/users/karelhala","html_url":"https://github.com/karelhala","followers_url":"https://api.github.com/users/karelhala/followers","following_url":"https://api.github.com/users/karelhala/following{/other_user}","gists_url":"https://api.github.com/users/karelhala/gists{/gist_id}","starred_url":"https://api.github.com/users/karelhala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karelhala/subscriptions","organizations_url":"https://api.github.com/users/karelhala/orgs","repos_url":"https://api.github.com/users/karelhala/repos","events_url":"https://api.github.com/users/karelhala/events{/privacy}","received_events_url":"https://api.github.com/users/karelhala/received_events","type":"User","site_admin":false},"body":"#784\r\n\r\n<!--\r\nThanks for your interest in patternfly-react. We appreciate all issues filed and PRs submitted!\r\n\r\nPlease make sure you're familiar with and follow the instructions in the\r\ncontributing guidelines (found in the CONTRIBUTING.md file).\r\n\r\nPlease fill out the information below to expedite the review and (hopefully)\r\nmerge of your pull request!\r\n-->\r\n\r\n<!-- What changes are being made? (What issue is being addressed here?) -->\r\n\r\n**What**:\r\nTo make it possible for consumers to show what indicates current progress we have to allow them pass additional label. This PR addresses such issue by adding new prop `label` to progress component.\r\n<!-- Are there any upstream issues or separate issues you need to reference? -->\r\n\r\n","created_at":"2018-10-20T22:09:39Z","updated_at":"2018-10-21T16:18:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ea27cda17fcb9942e31ef5609d6c5b480727ef8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"amarie401","id":20052391,"node_id":"MDQ6VXNlcjIwMDUyMzkx","avatar_url":"https://avatars0.githubusercontent.com/u/20052391?v=4","gravatar_id":"","url":"https://api.github.com/users/amarie401","html_url":"https://github.com/amarie401","followers_url":"https://api.github.com/users/amarie401/followers","following_url":"https://api.github.com/users/amarie401/following{/other_user}","gists_url":"https://api.github.com/users/amarie401/gists{/gist_id}","starred_url":"https://api.github.com/users/amarie401/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amarie401/subscriptions","organizations_url":"https://api.github.com/users/amarie401/orgs","repos_url":"https://api.github.com/users/amarie401/repos","events_url":"https://api.github.com/users/amarie401/events{/privacy}","received_events_url":"https://api.github.com/users/amarie401/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":956908271,"node_id":"MDU6TGFiZWw5NTY5MDgyNzE=","url":"https://api.github.com/repos/patternfly/patternfly-react/labels/PF4","name":"PF4","color":"20457c","default":false},{"id":556406380,"node_id":"MDU6TGFiZWw1NTY0MDYzODA=","url":"https://api.github.com/repos/patternfly/patternfly-react/labels/enhancement%20:rocket:","name":"enhancement :rocket:","color":"84b6eb","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/patternfly/patternfly-react/pulls/822/commits","review_comments_url":"https://api.github.com/repos/patternfly/patternfly-react/pulls/822/comments","review_comment_url":"https://api.github.com/repos/patternfly/patternfly-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/patternfly/patternfly-react/issues/822/comments","statuses_url":"https://api.github.com/repos/patternfly/patternfly-react/statuses/353ea44dfacb42d094a1724af3fb1beb2fc16f35","head":{"label":"karelhala:progressbar-label","ref":"progressbar-label","sha":"353ea44dfacb42d094a1724af3fb1beb2fc16f35","user":{"login":"karelhala","id":3439771,"node_id":"MDQ6VXNlcjM0Mzk3NzE=","avatar_url":"https://avatars0.githubusercontent.com/u/3439771?v=4","gravatar_id":"","url":"https://api.github.com/users/karelhala","html_url":"https://github.com/karelhala","followers_url":"https://api.github.com/users/karelhala/followers","following_url":"https://api.github.com/users/karelhala/following{/other_user}","gists_url":"https://api.github.com/users/karelhala/gists{/gist_id}","starred_url":"https://api.github.com/users/karelhala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karelhala/subscriptions","organizations_url":"https://api.github.com/users/karelhala/orgs","repos_url":"https://api.github.com/users/karelhala/repos","events_url":"https://api.github.com/users/karelhala/events{/privacy}","received_events_url":"https://api.github.com/users/karelhala/received_events","type":"User","site_admin":false},"repo":{"id":121513591,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE1MTM1OTE=","name":"patternfly-react","full_name":"karelhala/patternfly-react","private":false,"owner":{"login":"karelhala","id":3439771,"node_id":"MDQ6VXNlcjM0Mzk3NzE=","avatar_url":"https://avatars0.githubusercontent.com/u/3439771?v=4","gravatar_id":"","url":"https://api.github.com/users/karelhala","html_url":"https://github.com/karelhala","followers_url":"https://api.github.com/users/karelhala/followers","following_url":"https://api.github.com/users/karelhala/following{/other_user}","gists_url":"https://api.github.com/users/karelhala/gists{/gist_id}","starred_url":"https://api.github.com/users/karelhala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karelhala/subscriptions","organizations_url":"https://api.github.com/users/karelhala/orgs","repos_url":"https://api.github.com/users/karelhala/repos","events_url":"https://api.github.com/users/karelhala/events{/privacy}","received_events_url":"https://api.github.com/users/karelhala/received_events","type":"User","site_admin":false},"html_url":"https://github.com/karelhala/patternfly-react","description":"This project will provide a set of React UI components for the PatternFly project","fork":true,"url":"https://api.github.com/repos/karelhala/patternfly-react","forks_url":"https://api.github.com/repos/karelhala/patternfly-react/forks","keys_url":"https://api.github.com/repos/karelhala/patternfly-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/karelhala/patternfly-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/karelhala/patternfly-react/teams","hooks_url":"https://api.github.com/repos/karelhala/patternfly-react/hooks","issue_events_url":"https://api.github.com/repos/karelhala/patternfly-react/issues/events{/number}","events_url":"https://api.github.com/repos/karelhala/patternfly-react/events","assignees_url":"https://api.github.com/repos/karelhala/patternfly-react/assignees{/user}","branches_url":"https://api.github.com/repos/karelhala/patternfly-react/branches{/branch}","tags_url":"https://api.github.com/repos/karelhala/patternfly-react/tags","blobs_url":"https://api.github.com/repos/karelhala/patternfly-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/karelhala/patternfly-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/karelhala/patternfly-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/karelhala/patternfly-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/karelhala/patternfly-react/statuses/{sha}","languages_url":"https://api.github.com/repos/karelhala/patternfly-react/languages","stargazers_url":"https://api.github.com/repos/karelhala/patternfly-react/stargazers","contributors_url":"https://api.github.com/repos/karelhala/patternfly-react/contributors","subscribers_url":"https://api.github.com/repos/karelhala/patternfly-react/subscribers","subscription_url":"https://api.github.com/repos/karelhala/patternfly-react/subscription","commits_url":"https://api.github.com/repos/karelhala/patternfly-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/karelhala/patternfly-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/karelhala/patternfly-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/karelhala/patternfly-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/karelhala/patternfly-react/contents/{+path}","compare_url":"https://api.github.com/repos/karelhala/patternfly-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/karelhala/patternfly-react/merges","archive_url":"https://api.github.com/repos/karelhala/patternfly-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/karelhala/patternfly-react/downloads","issues_url":"https://api.github.com/repos/karelhala/patternfly-react/issues{/number}","pulls_url":"https://api.github.com/repos/karelhala/patternfly-react/pulls{/number}","milestones_url":"https://api.github.com/repos/karelhala/patternfly-react/milestones{/number}","notifications_url":"https://api.github.com/repos/karelhala/patternfly-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/karelhala/patternfly-react/labels{/name}","releases_url":"https://api.github.com/repos/karelhala/patternfly-react/releases{/id}","deployments_url":"https://api.github.com/repos/karelhala/patternfly-react/deployments","created_at":"2018-02-14T13:26:34Z","updated_at":"2018-02-14T13:26:36Z","pushed_at":"2018-10-21T12:09:17Z","git_url":"git://github.com/karelhala/patternfly-react.git","ssh_url":"git@github.com:karelhala/patternfly-react.git","clone_url":"https://github.com/karelhala/patternfly-react.git","svn_url":"https://github.com/karelhala/patternfly-react","homepage":"https://rawgit.com/patternfly/patternfly-react/gh-pages/index.html","size":10182,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"patternfly:master","ref":"master","sha":"2e79a9516b6324cbc91a0f89957b9361a5fecd5f","user":{"login":"patternfly","id":6391110,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzOTExMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6391110?v=4","gravatar_id":"","url":"https://api.github.com/users/patternfly","html_url":"https://github.com/patternfly","followers_url":"https://api.github.com/users/patternfly/followers","following_url":"https://api.github.com/users/patternfly/following{/other_user}","gists_url":"https://api.github.com/users/patternfly/gists{/gist_id}","starred_url":"https://api.github.com/users/patternfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patternfly/subscriptions","organizations_url":"https://api.github.com/users/patternfly/orgs","repos_url":"https://api.github.com/users/patternfly/repos","events_url":"https://api.github.com/users/patternfly/events{/privacy}","received_events_url":"https://api.github.com/users/patternfly/received_events","type":"Organization","site_admin":false},"repo":{"id":84372347,"node_id":"MDEwOlJlcG9zaXRvcnk4NDM3MjM0Nw==","name":"patternfly-react","full_name":"patternfly/patternfly-react","private":false,"owner":{"login":"patternfly","id":6391110,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzOTExMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6391110?v=4","gravatar_id":"","url":"https://api.github.com/users/patternfly","html_url":"https://github.com/patternfly","followers_url":"https://api.github.com/users/patternfly/followers","following_url":"https://api.github.com/users/patternfly/following{/other_user}","gists_url":"https://api.github.com/users/patternfly/gists{/gist_id}","starred_url":"https://api.github.com/users/patternfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patternfly/subscriptions","organizations_url":"https://api.github.com/users/patternfly/orgs","repos_url":"https://api.github.com/users/patternfly/repos","events_url":"https://api.github.com/users/patternfly/events{/privacy}","received_events_url":"https://api.github.com/users/patternfly/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/patternfly/patternfly-react","description":"A set of React components for the PatternFly project. ","fork":false,"url":"https://api.github.com/repos/patternfly/patternfly-react","forks_url":"https://api.github.com/repos/patternfly/patternfly-react/forks","keys_url":"https://api.github.com/repos/patternfly/patternfly-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/patternfly/patternfly-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/patternfly/patternfly-react/teams","hooks_url":"https://api.github.com/repos/patternfly/patternfly-react/hooks","issue_events_url":"https://api.github.com/repos/patternfly/patternfly-react/issues/events{/number}","events_url":"https://api.github.com/repos/patternfly/patternfly-react/events","assignees_url":"https://api.github.com/repos/patternfly/patternfly-react/assignees{/user}","branches_url":"https://api.github.com/repos/patternfly/patternfly-react/branches{/branch}","tags_url":"https://api.github.com/repos/patternfly/patternfly-react/tags","blobs_url":"https://api.github.com/repos/patternfly/patternfly-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/patternfly/patternfly-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/patternfly/patternfly-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/patternfly/patternfly-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/patternfly/patternfly-react/statuses/{sha}","languages_url":"https://api.github.com/repos/patternfly/patternfly-react/languages","stargazers_url":"https://api.github.com/repos/patternfly/patternfly-react/stargazers","contributors_url":"https://api.github.com/repos/patternfly/patternfly-react/contributors","subscribers_url":"https://api.github.com/repos/patternfly/patternfly-react/subscribers","subscription_url":"https://api.github.com/repos/patternfly/patternfly-react/subscription","commits_url":"https://api.github.com/repos/patternfly/patternfly-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/patternfly/patternfly-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/patternfly/patternfly-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/patternfly/patternfly-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/patternfly/patternfly-react/contents/{+path}","compare_url":"https://api.github.com/repos/patternfly/patternfly-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/patternfly/patternfly-react/merges","archive_url":"https://api.github.com/repos/patternfly/patternfly-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/patternfly/patternfly-react/downloads","issues_url":"https://api.github.com/repos/patternfly/patternfly-react/issues{/number}","pulls_url":"https://api.github.com/repos/patternfly/patternfly-react/pulls{/number}","milestones_url":"https://api.github.com/repos/patternfly/patternfly-react/milestones{/number}","notifications_url":"https://api.github.com/repos/patternfly/patternfly-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/patternfly/patternfly-react/labels{/name}","releases_url":"https://api.github.com/repos/patternfly/patternfly-react/releases{/id}","deployments_url":"https://api.github.com/repos/patternfly/patternfly-react/deployments","created_at":"2017-03-08T22:31:12Z","updated_at":"2018-10-19T21:20:37Z","pushed_at":"2018-10-21T12:09:18Z","git_url":"git://github.com/patternfly/patternfly-react.git","ssh_url":"git@github.com:patternfly/patternfly-react.git","clone_url":"https://github.com/patternfly/patternfly-react.git","svn_url":"https://github.com/patternfly/patternfly-react","homepage":"http://patternfly-react.surge.sh","size":19520,"stargazers_count":151,"watchers_count":151,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":100,"mirror_url":null,"archived":false,"open_issues_count":126,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":100,"open_issues":126,"watchers":151,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/patternfly/patternfly-react/pulls/822"},"html":{"href":"https://github.com/patternfly/patternfly-react/pull/822"},"issue":{"href":"https://api.github.com/repos/patternfly/patternfly-react/issues/822"},"comments":{"href":"https://api.github.com/repos/patternfly/patternfly-react/issues/822/comments"},"review_comments":{"href":"https://api.github.com/repos/patternfly/patternfly-react/pulls/822/comments"},"review_comment":{"href":"https://api.github.com/repos/patternfly/patternfly-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/patternfly/patternfly-react/pulls/822/commits"},"statuses":{"href":"https://api.github.com/repos/patternfly/patternfly-react/statuses/353ea44dfacb42d094a1724af3fb1beb2fc16f35"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"karelhala"}}