{"push_id":2812847703,"size":6,"distinct_size":6,"ref":"refs/heads/master","head":"682d8338d6cb84375582e9b0e3141bd9ec086e96","before":"1c75105afd56b9c4d9e32ceccfbc482999368b39","commits":[{"sha":"914bb13c461011aab2221dbdd4b4af2f0961db82","author":{"name":"jonas","email":"bb0728496681fb424c06eb1953eb3843cec5458d@users.noreply.github.com"},"message":"Many commits (~12) joined in one + Fix data structure for d3 chart\n\nFull history and explanation in this\n[file](tree/master/misc/history-2nd-merge-from-ellvrt.md)\n\nCurrent commit detached from this repo:\nhttps://github.com/ellvtr/ellvtr-status-page-old-fork/tree/jonas","distinct":true,"url":"https://api.github.com/repos/ellvtr/status-page/commits/914bb13c461011aab2221dbdd4b4af2f0961db82"},{"sha":"2104b03deecb66e5f1bf2974ba683cbc758ec6fd","author":{"name":"jonas","email":"bb0728496681fb424c06eb1953eb3843cec5458d@users.noreply.github.com"},"message":"Many commits joined in one\n\nFixes #5 #6 #8 #15\n\nFull history and explanation below.\nCurrent commit detached from this repo:\nhttps://github.com/ellvtr/ellvtr-status-page-old-fork/tree/jonas\n\n== CONTEXT ==\nI couldn't make a pull request from my first fork. So I\ndetached my fork because the git history was not compatible\nwith the original repo.\nSee full commit history in this repo, branch `jonas`:\nhttps://github.com/ellvtr/ellvtr-status-page-old-fork/tree/jonas\n\n== Git history - since last PR merge: ==\n\ncommit 93f3b3f289070370da7221c9abb829aaa6c1834c\nAuthor: jonas <ellvtr@users.noreply.github.com>\nDate:   Thu Aug 16 10:14:11 2018 +0200\n\n    Many commits (~12) joined in one + Fix data structure for d3 chart\n\n    Full history and explanation in this\n    [file](tree/master/misc/history-2nd-merge-from-ellvrt.md)\n\n    Current commit detached from this repo:\n    https://github.com/ellvtr/ellvtr-status-page-old-fork/tree/jonas\n\ncommit 03cfa6773a8ac2634770250d24bc1359dd0b8890\nAuthor: Jonas Ellehauge <ellvtr@users.noreply.github.com>\nDate:   Wed Aug 15 16:17:34 2018 +0200\n\n    Fix data structure for d3 chart\n\n    Fixes #15\n    There was a bug in `restructureAndPersistData` on nmservice;\n    it only added the network key as a node for each network;\n    now it loops through each node and adds it to\n    `restructuredData`.\n    Added file with correct structure `/mock/data/restructuredData2.json`\n\ncommit 22035e0966435718657302b3728c734c5daf8fda\nAuthor: Jonas Ellehauge <ellvtr@users.noreply.github.com>\nDate:   Wed Aug 15 14:54:41 2018 +0200\n\n    Fix data structure for d3 chart\n\n    Issue #15\n\n    Fixed partly: `initGraphData` in home.component created\n    empty `Link` instances with undefined properties. Chart now\n    renders but has no links between nodes.\n\n    Another problem is, that the `restructureData` generated by\n    `restructureAndPersistData` in nmservice does not have links\n    between its nodes. See the outcome in the file\n    `/mock/data/restructuredData.json(.txt)` which derived from\n    `/mock/data/network-info.json`.\n\ncommit 1ca10da111e46374794f9101e510e96077be7635\nAuthor: Jonas Ellehauge <ellvtr@users.noreply.github.com>\nDate:   Wed Aug 15 11:53:50 2018 +0200\n\n    Simplify / refactor home component and nmservice & extra mock endpoint no longer in use\n\n    See issues #6 #7\n\n    nmservice `restructureAndPersistData` and `retrievePersistedDataForGraph`\n    refactored to return data, not promise.\n\n    Home component `updateMetrics` and `initGraphData` no longer handle\n    promise.\n\n    `graph.visual.service.ts` also adapted to function returning data, not\n    promise.\n\n    `host:3000/data` endpoint no longer needed, `/mock/serv.js` changed\n    accordingly.\n\ncommit 6e40de3f98e019f43cf8dca4359e7f90419162b8\nAuthor: Jonas Ellehauge <ellvtr@users.noreply.github.com>\nDate:   Wed Aug 15 10:39:13 2018 +0200\n\n    Simplify / refactor home component and nmservice\n\n    See issues #6 #7\n\n    Simplified and removed much code; still remains to\n    change 2 async promise functions in to sequential and\n    find bug in `restructuredData` which doesn't work\n\n    WIP thorough refactoring of\n    `<homecomp>.updateMetrics`, `<nmservice>.restructureAndPersistData`\n    and `<nmservice>.retrievePersistedDataForGraph`\n\ncommit a14a075ff6721988568d324a5169d3ac7c1a536a\nAuthor: jonas <ellvtr@users.noreply.github.com>\nDate:   Tue Aug 14 12:17:02 2018 +0200\n\n    Reconstruct lost code after rebase error\n\n    I rebased repo in order to change past commit emails. During the rebase there were\n    merge conflicts; after fixing those, git asked me to add the files and I\n    only added the conflicting file resulting in all other files to go missing.\n    I managed to find them in another directory and some were still open in the editor.\n\ncommit 6232413c0c0979a8e50a7b5469ae5df51350f461\nAuthor: Jonas Ellehauge <ellvtr@users.noreply.github.com>\nDate:   Tue Aug 14 11:06:37 2018 +0200\n\n    Move d3 chart out of `footer` element and remove loads of redundant whitespace in html\n\ncommit 0b5460a32d417f79eb3dabbe8a05bf767bfc2acf\nAuthor: Jonas Ellehauge <ellvtr@users.noreply.github.com>\nDate:   Tue Aug 14 10:35:18 2018 +0200\n\n    Simplify/improve home component\n\n    See issue #8.\n    Loads of redundant markup removed again and style improved.\n    Just noticed that layout is not responsive. May need to re-design from\n    scratch using e.g. bootstrap or foundation or similar.\n\ncommit ef6d9b46559cf8bcc271b3eac0404e9f7286aeae\nAuthor: Jonas Ellehauge <ellvtr@users.noreply.github.com>\nDate:   Tue Aug 14 09:31:20 2018 +0200\n\n    Simplify/improve home component\n\n    See issue #8.\n    Removed hundreds of lines of redundant markup and ts code.\n    Minor improvements to styling / layout.\n\ncommit cd7f90b30270cd4ac4bc1d1473c48059af3293c4\nAuthor: Jonas Ellehauge <ellvtr@users.noreply.github.com>\nDate:   Mon Aug 13 21:13:13 2018 +0200\n\n    Improve styling and markup on buttons for largest/busiest network\n\ncommit b13b582914a3b53074fc25e915bdb45a6eac7422\nAuthor: Jonas Ellehauge <ellvtr@users.noreply.github.com>\nDate:   Mon Aug 13 15:21:53 2018 +0200\n\n    Fix component / template to reflect active tab\n\n    See issue #5\n\ncommit bc1c385ed9dea31364fae8b0766d9ac866802705\nAuthor: Jonas Ellehauge <ellvtr@users.noreply.github.com>\nDate:   Fri Aug 10 10:14:59 2018 +0200\n\n    Change review header in markdown\n\ncommit e0e2a6d6f308e374801114f0315b90cf022a123c\nAuthor: Jonas Ellehauge <ellvtr@users.noreply.github.com>\nDate:   Thu Aug 9 20:45:36 2018 +0200\n\n    Update code review with new content and fix formatting","distinct":true,"url":"https://api.github.com/repos/ellvtr/status-page/commits/2104b03deecb66e5f1bf2974ba683cbc758ec6fd"},{"sha":"9fc63bd57e4fcdfd52e42397b073b86d98906713","author":{"name":"jonas","email":"bb0728496681fb424c06eb1953eb3843cec5458d@users.noreply.github.com"},"message":"Many commits (~12) joined in one + Fix data structure for d3 chart\n\nFull history and explanation in this\n[file](tree/master/misc/history-2nd-merge-from-ellvrt.md)\n\nCurrent commit detached from this repo:\nhttps://github.com/ellvtr/ellvtr-status-page-old-fork/tree/jonas","distinct":true,"url":"https://api.github.com/repos/ellvtr/status-page/commits/9fc63bd57e4fcdfd52e42397b073b86d98906713"},{"sha":"8d3b0a3e1e9d89cce723eb310750ac7587cb42c4","author":{"name":"jonas","email":"bb0728496681fb424c06eb1953eb3843cec5458d@users.noreply.github.com"},"message":"Many commits joined in one\n\nFixes #5 #6 #8 #15\n\nFull history and explanation below.\nCurrent commit detached from this repo:\nhttps://github.com/ellvtr/ellvtr-status-page-old-fork/tree/jonas\n\n== CONTEXT ==\nI couldn't make a pull request from my first fork. So I\ndetached my fork because the git history was not compatible\nwith the original repo.\nSee full commit history in this repo, branch `jonas`:\nhttps://github.com/ellvtr/ellvtr-status-page-old-fork/tree/jonas\n\n== Git history - since last PR merge: ==\n\ncommit 93f3b3f289070370da7221c9abb829aaa6c1834c\nAuthor: jonas <ellvtr@users.noreply.github.com>\nDate:   Thu Aug 16 10:14:11 2018 +0200\n\n    Many commits (~12) joined in one + Fix data structure for d3 chart\n\n    Full history and explanation in this\n    [file](tree/master/misc/history-2nd-merge-from-ellvrt.md)\n\n    Current commit detached from this repo:\n    https://github.com/ellvtr/ellvtr-status-page-old-fork/tree/jonas\n\ncommit 03cfa6773a8ac2634770250d24bc1359dd0b8890\nAuthor: Jonas Ellehauge <ellvtr@users.noreply.github.com>\nDate:   Wed Aug 15 16:17:34 2018 +0200\n\n    Fix data structure for d3 chart\n\n    Fixes #15\n    There was a bug in `restructureAndPersistData` on nmservice;\n    it only added the network key as a node for each network;\n    now it loops through each node and adds it to\n    `restructuredData`.\n    Added file with correct structure `/mock/data/restructuredData2.json`\n\ncommit 22035e0966435718657302b3728c734c5daf8fda\nAuthor: Jonas Ellehauge <ellvtr@users.noreply.github.com>\nDate:   Wed Aug 15 14:54:41 2018 +0200\n\n    Fix data structure for d3 chart\n\n    Issue #15\n\n    Fixed partly: `initGraphData` in home.component created\n    empty `Link` instances with undefined properties. Chart now\n    renders but has no links between nodes.\n\n    Another problem is, that the `restructureData` generated by\n    `restructureAndPersistData` in nmservice does not have links\n    between its nodes. See the outcome in the file\n    `/mock/data/restructuredData.json(.txt)` which derived from\n    `/mock/data/network-info.json`.\n\ncommit 1ca10da111e46374794f9101e510e96077be7635\nAuthor: Jonas Ellehauge <ellvtr@users.noreply.github.com>\nDate:   Wed Aug 15 11:53:50 2018 +0200\n\n    Simplify / refactor home component and nmservice & extra mock endpoint no longer in use\n\n    See issues #6 #7\n\n    nmservice `restructureAndPersistData` and `retrievePersistedDataForGraph`\n    refactored to return data, not promise.\n\n    Home component `updateMetrics` and `initGraphData` no longer handle\n    promise.\n\n    `graph.visual.service.ts` also adapted to function returning data, not\n    promise.\n\n    `host:3000/data` endpoint no longer needed, `/mock/serv.js` changed\n    accordingly.\n\ncommit 6e40de3f98e019f43cf8dca4359e7f90419162b8\nAuthor: Jonas Ellehauge <ellvtr@users.noreply.github.com>\nDate:   Wed Aug 15 10:39:13 2018 +0200\n\n    Simplify / refactor home component and nmservice\n\n    See issues #6 #7\n\n    Simplified and removed much code; still remains to\n    change 2 async promise functions in to sequential and\n    find bug in `restructuredData` which doesn't work\n\n    WIP thorough refactoring of\n    `<homecomp>.updateMetrics`, `<nmservice>.restructureAndPersistData`\n    and `<nmservice>.retrievePersistedDataForGraph`\n\ncommit a14a075ff6721988568d324a5169d3ac7c1a536a\nAuthor: jonas <ellvtr@users.noreply.github.com>\nDate:   Tue Aug 14 12:17:02 2018 +0200\n\n    Reconstruct lost code after rebase error\n\n    I rebased repo in order to change past commit emails. During the rebase there were\n    merge conflicts; after fixing those, git asked me to add the files and I\n    only added the conflicting file resulting in all other files to go missing.\n    I managed to find them in another directory and some were still open in the editor.\n\ncommit 6232413c0c0979a8e50a7b5469ae5df51350f461\nAuthor: Jonas Ellehauge <ellvtr@users.noreply.github.com>\nDate:   Tue Aug 14 11:06:37 2018 +0200\n\n    Move d3 chart out of `footer` element and remove loads of redundant whitespace in html\n\ncommit 0b5460a32d417f79eb3dabbe8a05bf767bfc2acf\nAuthor: Jonas Ellehauge <ellvtr@users.noreply.github.com>\nDate:   Tue Aug 14 10:35:18 2018 +0200\n\n    Simplify/improve home component\n\n    See issue #8.\n    Loads of redundant markup removed again and style improved.\n    Just noticed that layout is not responsive. May need to re-design from\n    scratch using e.g. bootstrap or foundation or similar.\n\ncommit ef6d9b46559cf8bcc271b3eac0404e9f7286aeae\nAuthor: Jonas Ellehauge <ellvtr@users.noreply.github.com>\nDate:   Tue Aug 14 09:31:20 2018 +0200\n\n    Simplify/improve home component\n\n    See issue #8.\n    Removed hundreds of lines of redundant markup and ts code.\n    Minor improvements to styling / layout.\n\ncommit cd7f90b30270cd4ac4bc1d1473c48059af3293c4\nAuthor: Jonas Ellehauge <ellvtr@users.noreply.github.com>\nDate:   Mon Aug 13 21:13:13 2018 +0200\n\n    Improve styling and markup on buttons for largest/busiest network\n\ncommit b13b582914a3b53074fc25e915bdb45a6eac7422\nAuthor: Jonas Ellehauge <ellvtr@users.noreply.github.com>\nDate:   Mon Aug 13 15:21:53 2018 +0200\n\n    Fix component / template to reflect active tab\n\n    See issue #5\n\ncommit bc1c385ed9dea31364fae8b0766d9ac866802705\nAuthor: Jonas Ellehauge <ellvtr@users.noreply.github.com>\nDate:   Fri Aug 10 10:14:59 2018 +0200\n\n    Change review header in markdown\n\ncommit e0e2a6d6f308e374801114f0315b90cf022a123c\nAuthor: Jonas Ellehauge <ellvtr@users.noreply.github.com>\nDate:   Thu Aug 9 20:45:36 2018 +0200\n\n    Update code review with new content and fix formatting","distinct":true,"url":"https://api.github.com/repos/ellvtr/status-page/commits/8d3b0a3e1e9d89cce723eb310750ac7587cb42c4"},{"sha":"629d0ec102c58bf1b48a3a5695f9b38649991fc8","author":{"name":"jonas","email":"bb0728496681fb424c06eb1953eb3843cec5458d@users.noreply.github.com"},"message":"Handle frontend REST errors gracefully\n\nSee #12. Simple implementation; because the error is caught within the home component.","distinct":true,"url":"https://api.github.com/repos/ellvtr/status-page/commits/629d0ec102c58bf1b48a3a5695f9b38649991fc8"},{"sha":"682d8338d6cb84375582e9b0e3141bd9ec086e96","author":{"name":"jonas","email":"bb0728496681fb424c06eb1953eb3843cec5458d@users.noreply.github.com"},"message":"Rewrite and fix js logic for \"largest networks\" and \"busiest networks\"\n\nFixes #9 and fixes #10\n\nDid major rewriting and simplifying of `net.metrics.service.ts`\n(mostly but not only methods `updateLargestNetworks`\nand `updateBusiestNetworks`) and consequently of view\n`home.component.*` - plus added a new data\nmodel `NMNetwork.ts`.\n\nChanged mock data to better show case different views.","distinct":true,"url":"https://api.github.com/repos/ellvtr/status-page/commits/682d8338d6cb84375582e9b0e3141bd9ec086e96"}]}
{"actor":{"display_login":"palango"}}