{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/225908775","pull_request_review_id":165604822,"id":225908775,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTkwODc3NQ==","diff_hunk":"@@ -8784,7 +8784,7 @@ with pkgs;\n \n   sparse = callPackage ../development/tools/analysis/sparse { };\n \n-  speedtest-cli = callPackage ../tools/networking/speedtest-cli { };\n+  speedtest-cli = with pythonPackages; toPythonApplication speedtest-cli;","path":"pkgs/top-level/all-packages.nix","position":5,"original_position":5,"commit_id":"3511e52d1576970c8574462f6d880d65dae9129f","original_commit_id":"3511e52d1576970c8574462f6d880d65dae9129f","user":{"login":"dotlambda","id":6806011,"node_id":"MDQ6VXNlcjY4MDYwMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/6806011?v=4","gravatar_id":"","url":"https://api.github.com/users/dotlambda","html_url":"https://github.com/dotlambda","followers_url":"https://api.github.com/users/dotlambda/followers","following_url":"https://api.github.com/users/dotlambda/following{/other_user}","gists_url":"https://api.github.com/users/dotlambda/gists{/gist_id}","starred_url":"https://api.github.com/users/dotlambda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotlambda/subscriptions","organizations_url":"https://api.github.com/users/dotlambda/orgs","repos_url":"https://api.github.com/users/dotlambda/repos","events_url":"https://api.github.com/users/dotlambda/events{/privacy}","received_events_url":"https://api.github.com/users/dotlambda/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n  speedtest-cli = with python3Packages; toPythonApplication speedtest-cli;\r\n```","created_at":"2018-10-17T12:37:59Z","updated_at":"2018-10-17T12:39:43Z","html_url":"https://github.com/NixOS/nixpkgs/pull/48596#discussion_r225908775","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/48596","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/225908775"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/48596#discussion_r225908775"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/48596"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/48596","id":223420363,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNDIwMzYz","html_url":"https://github.com/NixOS/nixpkgs/pull/48596","diff_url":"https://github.com/NixOS/nixpkgs/pull/48596.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/48596.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/48596","number":48596,"state":"open","locked":false,"title":"speedtest-cli: move to pythonPackages, add to home-assistant","user":{"login":"makefu","id":115218,"node_id":"MDQ6VXNlcjExNTIxOA==","avatar_url":"https://avatars3.githubusercontent.com/u/115218?v=4","gravatar_id":"","url":"https://api.github.com/users/makefu","html_url":"https://github.com/makefu","followers_url":"https://api.github.com/users/makefu/followers","following_url":"https://api.github.com/users/makefu/following{/other_user}","gists_url":"https://api.github.com/users/makefu/gists{/gist_id}","starred_url":"https://api.github.com/users/makefu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makefu/subscriptions","organizations_url":"https://api.github.com/users/makefu/orgs","repos_url":"https://api.github.com/users/makefu/repos","events_url":"https://api.github.com/users/makefu/events{/privacy}","received_events_url":"https://api.github.com/users/makefu/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\nBe able to use the speedtest component in home-assistant\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n","created_at":"2018-10-16T22:52:34Z","updated_at":"2018-10-17T12:39:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c6cc6638328b6b5b743075ee175427fbbe7cd209","assignee":null,"assignees":[],"requested_reviewers":[{"login":"FRidh","id":2129135,"node_id":"MDQ6VXNlcjIxMjkxMzU=","avatar_url":"https://avatars3.githubusercontent.com/u/2129135?v=4","gravatar_id":"","url":"https://api.github.com/users/FRidh","html_url":"https://github.com/FRidh","followers_url":"https://api.github.com/users/FRidh/followers","following_url":"https://api.github.com/users/FRidh/following{/other_user}","gists_url":"https://api.github.com/users/FRidh/gists{/gist_id}","starred_url":"https://api.github.com/users/FRidh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FRidh/subscriptions","organizations_url":"https://api.github.com/users/FRidh/orgs","repos_url":"https://api.github.com/users/FRidh/repos","events_url":"https://api.github.com/users/FRidh/events{/privacy}","received_events_url":"https://api.github.com/users/FRidh/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":731735222,"node_id":"MDU6TGFiZWw3MzE3MzUyMjI=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%201-10","name":"10.rebuild-darwin: 1-10","color":"eeffee","default":false},{"id":731733923,"node_id":"MDU6TGFiZWw3MzE3MzM5MjM=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%201-10","name":"10.rebuild-linux: 1-10","color":"eeffee","default":false},{"id":9820195,"node_id":"MDU6TGFiZWw5ODIwMTk1","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20python","name":"6.topic: python","color":"fef2c0","default":false},{"id":290122734,"node_id":"MDU6TGFiZWwyOTAxMjI3MzQ=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20package%20(new)","name":"8.has: package (new)","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/48596/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/48596/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/48596/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/3511e52d1576970c8574462f6d880d65dae9129f","head":{"label":"makefu:pkgs/pythonPackages.speedtest-cli/init","ref":"pkgs/pythonPackages.speedtest-cli/init","sha":"3511e52d1576970c8574462f6d880d65dae9129f","user":{"login":"makefu","id":115218,"node_id":"MDQ6VXNlcjExNTIxOA==","avatar_url":"https://avatars3.githubusercontent.com/u/115218?v=4","gravatar_id":"","url":"https://api.github.com/users/makefu","html_url":"https://github.com/makefu","followers_url":"https://api.github.com/users/makefu/followers","following_url":"https://api.github.com/users/makefu/following{/other_user}","gists_url":"https://api.github.com/users/makefu/gists{/gist_id}","starred_url":"https://api.github.com/users/makefu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makefu/subscriptions","organizations_url":"https://api.github.com/users/makefu/orgs","repos_url":"https://api.github.com/users/makefu/repos","events_url":"https://api.github.com/users/makefu/events{/privacy}","received_events_url":"https://api.github.com/users/makefu/received_events","type":"User","site_admin":false},"repo":{"id":40236601,"node_id":"MDEwOlJlcG9zaXRvcnk0MDIzNjYwMQ==","name":"nixpkgs","full_name":"makefu/nixpkgs","private":false,"owner":{"login":"makefu","id":115218,"node_id":"MDQ6VXNlcjExNTIxOA==","avatar_url":"https://avatars3.githubusercontent.com/u/115218?v=4","gravatar_id":"","url":"https://api.github.com/users/makefu","html_url":"https://github.com/makefu","followers_url":"https://api.github.com/users/makefu/followers","following_url":"https://api.github.com/users/makefu/following{/other_user}","gists_url":"https://api.github.com/users/makefu/gists{/gist_id}","starred_url":"https://api.github.com/users/makefu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makefu/subscriptions","organizations_url":"https://api.github.com/users/makefu/orgs","repos_url":"https://api.github.com/users/makefu/repos","events_url":"https://api.github.com/users/makefu/events{/privacy}","received_events_url":"https://api.github.com/users/makefu/received_events","type":"User","site_admin":false},"html_url":"https://github.com/makefu/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/makefu/nixpkgs","forks_url":"https://api.github.com/repos/makefu/nixpkgs/forks","keys_url":"https://api.github.com/repos/makefu/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/makefu/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/makefu/nixpkgs/teams","hooks_url":"https://api.github.com/repos/makefu/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/makefu/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/makefu/nixpkgs/events","assignees_url":"https://api.github.com/repos/makefu/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/makefu/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/makefu/nixpkgs/tags","blobs_url":"https://api.github.com/repos/makefu/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/makefu/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/makefu/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/makefu/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/makefu/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/makefu/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/makefu/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/makefu/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/makefu/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/makefu/nixpkgs/subscription","commits_url":"https://api.github.com/repos/makefu/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/makefu/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/makefu/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/makefu/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/makefu/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/makefu/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/makefu/nixpkgs/merges","archive_url":"https://api.github.com/repos/makefu/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/makefu/nixpkgs/downloads","issues_url":"https://api.github.com/repos/makefu/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/makefu/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/makefu/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/makefu/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/makefu/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/makefu/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/makefu/nixpkgs/deployments","created_at":"2015-08-05T09:26:14Z","updated_at":"2018-10-07T21:35:11Z","pushed_at":"2018-10-17T08:18:11Z","git_url":"git://github.com/makefu/nixpkgs.git","ssh_url":"git@github.com:makefu/nixpkgs.git","clone_url":"https://github.com/makefu/nixpkgs.git","svn_url":"https://github.com/makefu/nixpkgs","homepage":null,"size":778759,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"35c037c2f5c7d67c5c119d69808730b0d84cd7c7","user":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQyNzE2","name":"nixpkgs","full_name":"NixOS/nixpkgs","private":false,"owner":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-10-17T10:58:51Z","pushed_at":"2018-10-17T12:12:08Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":869889,"stargazers_count":2897,"watchers_count":2897,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3078,"mirror_url":null,"archived":false,"open_issues_count":3331,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3078,"open_issues":3331,"watchers":2897,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/48596"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/48596"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/48596"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/48596/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/48596/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/48596/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/3511e52d1576970c8574462f6d880d65dae9129f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dotlambda"}}