{"action":"created","comment":{"url":"https://api.github.com/repos/CGAL/cgal/pulls/comments/188868161","pull_request_review_id":120930093,"id":188868161,"diff_hunk":"@@ -40,27 +41,13 @@\n #pragma GCC diagnostic ignored \"-Wunused-parameter\"\n #endif\n \n-#ifdef BOOST_PARAMETER_MAX_ARITY\n-#  if (BOOST_PARAMETER_MAX_ARITY < 8)\n-#    error \"BOOST_PARAMETER_MAX_ARITY must be at least 8 for CGAL::lloyd_optimize_mesh_2()\"\n-#  endif\n-#else\n-#  define  BOOST_PARAMETER_MAX_ARITY 8\n-#endif\n-#include <boost/parameter.hpp>\n-#include <boost/parameter/name.hpp>\n-\n namespace CGAL\n {\n namespace parameters\n {\n   \n \n BOOST_PARAMETER_NAME( cdt )\n-BOOST_PARAMETER_NAME( (max_iteration_number, tag) max_iteration_number_ )\n-BOOST_PARAMETER_NAME( (convergence, tag) convergence_)\n-BOOST_PARAMETER_NAME( (time_limit, tag) time_limit_ )\n-BOOST_PARAMETER_NAME( (freeze_bound, tag) freeze_bound_)\n BOOST_PARAMETER_NAME( (seeds_begin, tag) seeds_begin_)\n BOOST_PARAMETER_NAME( (seeds_end, tag) seeds_end_)\n BOOST_PARAMETER_NAME( (mark, tag) mark_)","path":"Mesh_2/include/CGAL/lloyd_optimize_mesh_2.h","position":35,"original_position":35,"commit_id":"47ab0f29afedb95ae536d55c32c7cfa9e73779da","original_commit_id":"47ab0f29afedb95ae536d55c32c7cfa9e73779da","user":{"login":"MaelRL","id":5074170,"avatar_url":"https://avatars2.githubusercontent.com/u/5074170?v=4","gravatar_id":"","url":"https://api.github.com/users/MaelRL","html_url":"https://github.com/MaelRL","followers_url":"https://api.github.com/users/MaelRL/followers","following_url":"https://api.github.com/users/MaelRL/following{/other_user}","gists_url":"https://api.github.com/users/MaelRL/gists{/gist_id}","starred_url":"https://api.github.com/users/MaelRL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaelRL/subscriptions","organizations_url":"https://api.github.com/users/MaelRL/orgs","repos_url":"https://api.github.com/users/MaelRL/repos","events_url":"https://api.github.com/users/MaelRL/events{/privacy}","received_events_url":"https://api.github.com/users/MaelRL/received_events","type":"User","site_admin":false},"body":"All the named parameters were regrouped in /BGL even if they are only used in a single function of PMP. Maybe it ought to be the same with the parameters.","created_at":"2018-05-17T07:56:44Z","updated_at":"2018-05-17T07:59:03Z","html_url":"https://github.com/CGAL/cgal/pull/3092#discussion_r188868161","pull_request_url":"https://api.github.com/repos/CGAL/cgal/pulls/3092","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/comments/188868161"},"html":{"href":"https://github.com/CGAL/cgal/pull/3092#discussion_r188868161"},"pull_request":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/3092"}}},"pull_request":{"url":"https://api.github.com/repos/CGAL/cgal/pulls/3092","id":188404570,"html_url":"https://github.com/CGAL/cgal/pull/3092","diff_url":"https://github.com/CGAL/cgal/pull/3092.diff","patch_url":"https://github.com/CGAL/cgal/pull/3092.patch","issue_url":"https://api.github.com/repos/CGAL/cgal/issues/3092","number":3092,"state":"open","locked":false,"title":"Infrastructure : Test compilation of headers","user":{"login":"maxGimeno","id":11310805,"avatar_url":"https://avatars0.githubusercontent.com/u/11310805?v=4","gravatar_id":"","url":"https://api.github.com/users/maxGimeno","html_url":"https://github.com/maxGimeno","followers_url":"https://api.github.com/users/maxGimeno/followers","following_url":"https://api.github.com/users/maxGimeno/following{/other_user}","gists_url":"https://api.github.com/users/maxGimeno/gists{/gist_id}","starred_url":"https://api.github.com/users/maxGimeno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxGimeno/subscriptions","organizations_url":"https://api.github.com/users/maxGimeno/orgs","repos_url":"https://api.github.com/users/maxGimeno/repos","events_url":"https://api.github.com/users/maxGimeno/events{/privacy}","received_events_url":"https://api.github.com/users/maxGimeno/received_events","type":"User","site_admin":false},"body":"## Summary of Changes\r\n\r\nThis adds a step to check_headers that creates a cpp file including all checked headers and tries to build it.\r\nHere is the said file on my machine :\r\n[test_headers.cpp](https://gist.github.com/maxGimeno/ac6f69b63f4bccfe8cfa297d6c2a53a8)\r\n@CGAL/geometryfactory  We should work to fix the errors that are generated by the compilation of that file. There are quite a few.\r\n## Release Management\r\n\r\n* Affected package(s):Installation\r\n* Issue(s) solved (if any): fix #3089 \r\n\r\n","created_at":"2018-05-16T11:42:48Z","updated_at":"2018-05-17T07:59:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"24ebb169fc4b9f4a64fd54a6d33a6363d8f68ea5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CGAL/cgal/pulls/3092/commits","review_comments_url":"https://api.github.com/repos/CGAL/cgal/pulls/3092/comments","review_comment_url":"https://api.github.com/repos/CGAL/cgal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CGAL/cgal/issues/3092/comments","statuses_url":"https://api.github.com/repos/CGAL/cgal/statuses/47ab0f29afedb95ae536d55c32c7cfa9e73779da","head":{"label":"maxGimeno:Travis-Check_including_all_headers-GF","ref":"Travis-Check_including_all_headers-GF","sha":"47ab0f29afedb95ae536d55c32c7cfa9e73779da","user":{"login":"maxGimeno","id":11310805,"avatar_url":"https://avatars0.githubusercontent.com/u/11310805?v=4","gravatar_id":"","url":"https://api.github.com/users/maxGimeno","html_url":"https://github.com/maxGimeno","followers_url":"https://api.github.com/users/maxGimeno/followers","following_url":"https://api.github.com/users/maxGimeno/following{/other_user}","gists_url":"https://api.github.com/users/maxGimeno/gists{/gist_id}","starred_url":"https://api.github.com/users/maxGimeno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxGimeno/subscriptions","organizations_url":"https://api.github.com/users/maxGimeno/orgs","repos_url":"https://api.github.com/users/maxGimeno/repos","events_url":"https://api.github.com/users/maxGimeno/events{/privacy}","received_events_url":"https://api.github.com/users/maxGimeno/received_events","type":"User","site_admin":false},"repo":{"id":38375573,"name":"cgal","full_name":"maxGimeno/cgal","owner":{"login":"maxGimeno","id":11310805,"avatar_url":"https://avatars0.githubusercontent.com/u/11310805?v=4","gravatar_id":"","url":"https://api.github.com/users/maxGimeno","html_url":"https://github.com/maxGimeno","followers_url":"https://api.github.com/users/maxGimeno/followers","following_url":"https://api.github.com/users/maxGimeno/following{/other_user}","gists_url":"https://api.github.com/users/maxGimeno/gists{/gist_id}","starred_url":"https://api.github.com/users/maxGimeno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxGimeno/subscriptions","organizations_url":"https://api.github.com/users/maxGimeno/orgs","repos_url":"https://api.github.com/users/maxGimeno/repos","events_url":"https://api.github.com/users/maxGimeno/events{/privacy}","received_events_url":"https://api.github.com/users/maxGimeno/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maxGimeno/cgal","description":"The public CGAL repository","fork":true,"url":"https://api.github.com/repos/maxGimeno/cgal","forks_url":"https://api.github.com/repos/maxGimeno/cgal/forks","keys_url":"https://api.github.com/repos/maxGimeno/cgal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maxGimeno/cgal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maxGimeno/cgal/teams","hooks_url":"https://api.github.com/repos/maxGimeno/cgal/hooks","issue_events_url":"https://api.github.com/repos/maxGimeno/cgal/issues/events{/number}","events_url":"https://api.github.com/repos/maxGimeno/cgal/events","assignees_url":"https://api.github.com/repos/maxGimeno/cgal/assignees{/user}","branches_url":"https://api.github.com/repos/maxGimeno/cgal/branches{/branch}","tags_url":"https://api.github.com/repos/maxGimeno/cgal/tags","blobs_url":"https://api.github.com/repos/maxGimeno/cgal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maxGimeno/cgal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maxGimeno/cgal/git/refs{/sha}","trees_url":"https://api.github.com/repos/maxGimeno/cgal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maxGimeno/cgal/statuses/{sha}","languages_url":"https://api.github.com/repos/maxGimeno/cgal/languages","stargazers_url":"https://api.github.com/repos/maxGimeno/cgal/stargazers","contributors_url":"https://api.github.com/repos/maxGimeno/cgal/contributors","subscribers_url":"https://api.github.com/repos/maxGimeno/cgal/subscribers","subscription_url":"https://api.github.com/repos/maxGimeno/cgal/subscription","commits_url":"https://api.github.com/repos/maxGimeno/cgal/commits{/sha}","git_commits_url":"https://api.github.com/repos/maxGimeno/cgal/git/commits{/sha}","comments_url":"https://api.github.com/repos/maxGimeno/cgal/comments{/number}","issue_comment_url":"https://api.github.com/repos/maxGimeno/cgal/issues/comments{/number}","contents_url":"https://api.github.com/repos/maxGimeno/cgal/contents/{+path}","compare_url":"https://api.github.com/repos/maxGimeno/cgal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maxGimeno/cgal/merges","archive_url":"https://api.github.com/repos/maxGimeno/cgal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maxGimeno/cgal/downloads","issues_url":"https://api.github.com/repos/maxGimeno/cgal/issues{/number}","pulls_url":"https://api.github.com/repos/maxGimeno/cgal/pulls{/number}","milestones_url":"https://api.github.com/repos/maxGimeno/cgal/milestones{/number}","notifications_url":"https://api.github.com/repos/maxGimeno/cgal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maxGimeno/cgal/labels{/name}","releases_url":"https://api.github.com/repos/maxGimeno/cgal/releases{/id}","deployments_url":"https://api.github.com/repos/maxGimeno/cgal/deployments","created_at":"2015-07-01T14:25:52Z","updated_at":"2017-01-20T17:02:24Z","pushed_at":"2018-05-17T07:42:54Z","git_url":"git://github.com/maxGimeno/cgal.git","ssh_url":"git@github.com:maxGimeno/cgal.git","clone_url":"https://github.com/maxGimeno/cgal.git","svn_url":"https://github.com/maxGimeno/cgal","homepage":"http://www.cgal.org","size":559559,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"CGAL:master","ref":"master","sha":"d2a61c656a77928c1b658c8f9e7f625ee989c104","user":{"login":"CGAL","id":5746664,"avatar_url":"https://avatars0.githubusercontent.com/u/5746664?v=4","gravatar_id":"","url":"https://api.github.com/users/CGAL","html_url":"https://github.com/CGAL","followers_url":"https://api.github.com/users/CGAL/followers","following_url":"https://api.github.com/users/CGAL/following{/other_user}","gists_url":"https://api.github.com/users/CGAL/gists{/gist_id}","starred_url":"https://api.github.com/users/CGAL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CGAL/subscriptions","organizations_url":"https://api.github.com/users/CGAL/orgs","repos_url":"https://api.github.com/users/CGAL/repos","events_url":"https://api.github.com/users/CGAL/events{/privacy}","received_events_url":"https://api.github.com/users/CGAL/received_events","type":"Organization","site_admin":false},"repo":{"id":24677392,"name":"cgal","full_name":"CGAL/cgal","owner":{"login":"CGAL","id":5746664,"avatar_url":"https://avatars0.githubusercontent.com/u/5746664?v=4","gravatar_id":"","url":"https://api.github.com/users/CGAL","html_url":"https://github.com/CGAL","followers_url":"https://api.github.com/users/CGAL/followers","following_url":"https://api.github.com/users/CGAL/following{/other_user}","gists_url":"https://api.github.com/users/CGAL/gists{/gist_id}","starred_url":"https://api.github.com/users/CGAL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CGAL/subscriptions","organizations_url":"https://api.github.com/users/CGAL/orgs","repos_url":"https://api.github.com/users/CGAL/repos","events_url":"https://api.github.com/users/CGAL/events{/privacy}","received_events_url":"https://api.github.com/users/CGAL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CGAL/cgal","description":"The public CGAL repository, see the README below","fork":false,"url":"https://api.github.com/repos/CGAL/cgal","forks_url":"https://api.github.com/repos/CGAL/cgal/forks","keys_url":"https://api.github.com/repos/CGAL/cgal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CGAL/cgal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CGAL/cgal/teams","hooks_url":"https://api.github.com/repos/CGAL/cgal/hooks","issue_events_url":"https://api.github.com/repos/CGAL/cgal/issues/events{/number}","events_url":"https://api.github.com/repos/CGAL/cgal/events","assignees_url":"https://api.github.com/repos/CGAL/cgal/assignees{/user}","branches_url":"https://api.github.com/repos/CGAL/cgal/branches{/branch}","tags_url":"https://api.github.com/repos/CGAL/cgal/tags","blobs_url":"https://api.github.com/repos/CGAL/cgal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CGAL/cgal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CGAL/cgal/git/refs{/sha}","trees_url":"https://api.github.com/repos/CGAL/cgal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CGAL/cgal/statuses/{sha}","languages_url":"https://api.github.com/repos/CGAL/cgal/languages","stargazers_url":"https://api.github.com/repos/CGAL/cgal/stargazers","contributors_url":"https://api.github.com/repos/CGAL/cgal/contributors","subscribers_url":"https://api.github.com/repos/CGAL/cgal/subscribers","subscription_url":"https://api.github.com/repos/CGAL/cgal/subscription","commits_url":"https://api.github.com/repos/CGAL/cgal/commits{/sha}","git_commits_url":"https://api.github.com/repos/CGAL/cgal/git/commits{/sha}","comments_url":"https://api.github.com/repos/CGAL/cgal/comments{/number}","issue_comment_url":"https://api.github.com/repos/CGAL/cgal/issues/comments{/number}","contents_url":"https://api.github.com/repos/CGAL/cgal/contents/{+path}","compare_url":"https://api.github.com/repos/CGAL/cgal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CGAL/cgal/merges","archive_url":"https://api.github.com/repos/CGAL/cgal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CGAL/cgal/downloads","issues_url":"https://api.github.com/repos/CGAL/cgal/issues{/number}","pulls_url":"https://api.github.com/repos/CGAL/cgal/pulls{/number}","milestones_url":"https://api.github.com/repos/CGAL/cgal/milestones{/number}","notifications_url":"https://api.github.com/repos/CGAL/cgal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CGAL/cgal/labels{/name}","releases_url":"https://api.github.com/repos/CGAL/cgal/releases{/id}","deployments_url":"https://api.github.com/repos/CGAL/cgal/deployments","created_at":"2014-10-01T12:22:47Z","updated_at":"2018-05-17T05:34:32Z","pushed_at":"2018-05-17T07:42:56Z","git_url":"git://github.com/CGAL/cgal.git","ssh_url":"git@github.com:CGAL/cgal.git","clone_url":"https://github.com/CGAL/cgal.git","svn_url":"https://github.com/CGAL/cgal","homepage":"https://github.com/CGAL/cgal#readme","size":570165,"stargazers_count":884,"watchers_count":884,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":380,"mirror_url":null,"archived":false,"open_issues_count":262,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":380,"open_issues":262,"watchers":884,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/3092"},"html":{"href":"https://github.com/CGAL/cgal/pull/3092"},"issue":{"href":"https://api.github.com/repos/CGAL/cgal/issues/3092"},"comments":{"href":"https://api.github.com/repos/CGAL/cgal/issues/3092/comments"},"review_comments":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/3092/comments"},"review_comment":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/3092/commits"},"statuses":{"href":"https://api.github.com/repos/CGAL/cgal/statuses/47ab0f29afedb95ae536d55c32c7cfa9e73779da"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"MaelRL"}}