{"action":"created","issue":{"url":"https://api.github.com/repos/serverless/serverless/issues/4708","repository_url":"https://api.github.com/repos/serverless/serverless","labels_url":"https://api.github.com/repos/serverless/serverless/issues/4708/labels{/name}","comments_url":"https://api.github.com/repos/serverless/serverless/issues/4708/comments","events_url":"https://api.github.com/repos/serverless/serverless/issues/4708/events","html_url":"https://github.com/serverless/serverless/pull/4708","id":293908857,"number":4708,"title":"Stop throwing errors if alexaSkill is not in the events list","user":{"login":"kobim","id":679761,"avatar_url":"https://avatars1.githubusercontent.com/u/679761?v=4","gravatar_id":"","url":"https://api.github.com/users/kobim","html_url":"https://github.com/kobim","followers_url":"https://api.github.com/users/kobim/followers","following_url":"https://api.github.com/users/kobim/following{/other_user}","gists_url":"https://api.github.com/users/kobim/gists{/gist_id}","starred_url":"https://api.github.com/users/kobim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kobim/subscriptions","organizations_url":"https://api.github.com/users/kobim/orgs","repos_url":"https://api.github.com/users/kobim/repos","events_url":"https://api.github.com/users/kobim/events{/privacy}","received_events_url":"https://api.github.com/users/kobim/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-02-02T14:38:37Z","updated_at":"2018-02-02T18:11:02Z","closed_at":"2018-02-02T16:48:46Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/serverless/serverless/pulls/4708","html_url":"https://github.com/serverless/serverless/pull/4708","diff_url":"https://github.com/serverless/serverless/pull/4708.diff","patch_url":"https://github.com/serverless/serverless/pull/4708.patch"},"body":"<!--\r\n1. Please check out and follow our Contributing Guidelines: https://github.com/serverless/serverless/blob/master/CONTRIBUTING.md\r\n2. Do not remove any section of the template. If something is not applicable leave it empty but leave it in the PR\r\n3. Please follow the template, otherwise we'll have to ask you to update it and it will take longer until your PR is merged\r\n-->\r\n\r\n## What did you implement:\r\n\r\n#4701 changes were throwing an error if an event other than `alexaSkill` was present in the events list. This fixes the issue.\r\n\r\n<!--\r\nBriefly describe the feature if no issue exists for this PR\r\n-->\r\n\r\n## How did you implement it:\r\n\r\nMaking sure the event is `alexaSkill` (whether as a string or an object)\r\n<!--\r\nIf this is a nontrivial change please briefly describe your implementation so its easy for us to understand and review your code.\r\n-->\r\n\r\n## How can we verify it:\r\n\r\nA simple serverless.yml with an http handler for a function.\r\n<!--\r\nAdd any applicable config, commands, screenshots or other resources\r\nto make it easy for us to verify this works. The easier you make it for us\r\nto review a PR, the faster we can review and merge it.\r\n\r\nExamples:\r\n* serverless.yml - Fully functioning to easily deploy changes\r\n* Screenshots - Showing the difference between your output and the master\r\n* Cloud Configuration - List cloud resources and show that the correct configuration is in place (e.g. AWS CLI commands)\r\n* Other - Anything else that comes to mind to help us evaluate\r\n-->\r\n\r\n## Todos:\r\n\r\n- [x] Write tests\r\n- [x] Write documentation\r\n- [x] Fix linting errors\r\n- [x] Make sure code coverage hasn't dropped\r\n- [x] Provide verification config / commands / resources\r\n- [x] Enable \"Allow edits from maintainers\" for this PR\r\n- [x] Update the messages below\r\n\r\n***Is this ready for review?:*** YES\r\n***Is it a breaking change?:*** NO\r\n"},"comment":{"url":"https://api.github.com/repos/serverless/serverless/issues/comments/362661338","html_url":"https://github.com/serverless/serverless/pull/4708#issuecomment-362661338","issue_url":"https://api.github.com/repos/serverless/serverless/issues/4708","id":362661338,"user":{"login":"HyperBrain","id":5524702,"avatar_url":"https://avatars3.githubusercontent.com/u/5524702?v=4","gravatar_id":"","url":"https://api.github.com/users/HyperBrain","html_url":"https://github.com/HyperBrain","followers_url":"https://api.github.com/users/HyperBrain/followers","following_url":"https://api.github.com/users/HyperBrain/following{/other_user}","gists_url":"https://api.github.com/users/HyperBrain/gists{/gist_id}","starred_url":"https://api.github.com/users/HyperBrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HyperBrain/subscriptions","organizations_url":"https://api.github.com/users/HyperBrain/orgs","repos_url":"https://api.github.com/users/HyperBrain/repos","events_url":"https://api.github.com/users/HyperBrain/events{/privacy}","received_events_url":"https://api.github.com/users/HyperBrain/received_events","type":"User","site_admin":false},"created_at":"2018-02-02T18:11:02Z","updated_at":"2018-02-02T18:11:02Z","author_association":"MEMBER","body":"No problem :)"}}
{"actor":{"display_login":"HyperBrain"}}