{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/pay-connector/pulls/comments/226577620","pull_request_review_id":166434214,"id":226577620,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjU3NzYyMA==","diff_hunk":"@@ -262,14 +268,19 @@ public void shouldReturnErrorWithoutChangingChargeState_IfOriginalStateIsNotEnte\n \n     @Test\n     public void shouldReturn202_WhenGatewayAuthorisationResponseIsDelayed() throws NoSuchFieldException, IllegalAccessException {\n-        ExecutorServiceConfig conf = app.getConf().getExecutorServiceConfig();\n+        ExecutorServiceConfig conf = testContext.getExecutorServiceConfig();\n         Field timeoutInSeconds = conf.getClass().getDeclaredField(\"timeoutInSeconds\");\n         timeoutInSeconds.setAccessible(true);\n         timeoutInSeconds.setInt(conf, 0);\n \n         String chargeId = createNewChargeWithNoTransactionId(ENTERING_CARD_DETAILS);\n         String message = format(\"Authorisation for charge already in progress, %s\", chargeId);\n-        authoriseAndVerifyFor(chargeId, validCardDetails, message, 202);\n+        try {\n+            authoriseAndVerifyFor(chargeId, validCardDetails, message, 202);\n+        } finally {\n+            timeoutInSeconds.setInt(conf, 1);\n+            timeoutInSeconds.setAccessible(false);","path":"src/test/java/uk/gov/pay/connector/it/resources/CardAuthoriseResourceITest.java","position":70,"original_position":70,"commit_id":"3fa2c5ab663b879f688518021a9eced2579f492e","original_commit_id":"3fa2c5ab663b879f688518021a9eced2579f492e","user":{"login":"oswaldquek","id":9698354,"node_id":"MDQ6VXNlcjk2OTgzNTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9698354?v=4","gravatar_id":"","url":"https://api.github.com/users/oswaldquek","html_url":"https://github.com/oswaldquek","followers_url":"https://api.github.com/users/oswaldquek/followers","following_url":"https://api.github.com/users/oswaldquek/following{/other_user}","gists_url":"https://api.github.com/users/oswaldquek/gists{/gist_id}","starred_url":"https://api.github.com/users/oswaldquek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oswaldquek/subscriptions","organizations_url":"https://api.github.com/users/oswaldquek/orgs","repos_url":"https://api.github.com/users/oswaldquek/repos","events_url":"https://api.github.com/users/oswaldquek/events{/privacy}","received_events_url":"https://api.github.com/users/oswaldquek/received_events","type":"User","site_admin":false},"body":"Yeah maybe better to extract this test out into its own test class with a different config yaml.","created_at":"2018-10-19T08:58:46Z","updated_at":"2018-10-19T08:58:46Z","html_url":"https://github.com/alphagov/pay-connector/pull/737#discussion_r226577620","pull_request_url":"https://api.github.com/repos/alphagov/pay-connector/pulls/737","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/alphagov/pay-connector/pulls/comments/226577620"},"html":{"href":"https://github.com/alphagov/pay-connector/pull/737#discussion_r226577620"},"pull_request":{"href":"https://api.github.com/repos/alphagov/pay-connector/pulls/737"}},"in_reply_to_id":226229998},"pull_request":{"url":"https://api.github.com/repos/alphagov/pay-connector/pulls/737","id":222181706,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMTgxNzA2","html_url":"https://github.com/alphagov/pay-connector/pull/737","diff_url":"https://github.com/alphagov/pay-connector/pull/737.diff","patch_url":"https://github.com/alphagov/pay-connector/pull/737.patch","issue_url":"https://api.github.com/repos/alphagov/pay-connector/issues/737","number":737,"state":"open","locked":false,"title":"PP-4276: Use direct debit connector's DropwizardJUnitRunner","user":{"login":"oswaldquek","id":9698354,"node_id":"MDQ6VXNlcjk2OTgzNTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9698354?v=4","gravatar_id":"","url":"https://api.github.com/users/oswaldquek","html_url":"https://github.com/oswaldquek","followers_url":"https://api.github.com/users/oswaldquek/followers","following_url":"https://api.github.com/users/oswaldquek/following{/other_user}","gists_url":"https://api.github.com/users/oswaldquek/gists{/gist_id}","starred_url":"https://api.github.com/users/oswaldquek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oswaldquek/subscriptions","organizations_url":"https://api.github.com/users/oswaldquek/orgs","repos_url":"https://api.github.com/users/oswaldquek/repos","events_url":"https://api.github.com/users/oswaldquek/events{/privacy}","received_events_url":"https://api.github.com/users/oswaldquek/received_events","type":"User","site_admin":false},"body":"This commit largely copies's dd-connector's DropwizardJUnitRunner which spins\r\nup the dropwizard app and postgres container only once for all tests that use\r\nit. This commit reduces the build time from ~20minutes to <10minutes.\r\n    \r\nIn the ChargingITestBase we have had to make the\r\n[worldpay|smartpay|epdq]MockClients static as some tests fail when all the\r\ntests are being run. Probably some weird connection pooling issue.\r\n    \r\n@oswaldquek, @georgeracu\r\n","created_at":"2018-10-11T15:26:44Z","updated_at":"2018-10-19T08:58:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c7401a2bbc678762bca939bbd00abe99ce13d38","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/pay-connector/pulls/737/commits","review_comments_url":"https://api.github.com/repos/alphagov/pay-connector/pulls/737/comments","review_comment_url":"https://api.github.com/repos/alphagov/pay-connector/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/pay-connector/issues/737/comments","statuses_url":"https://api.github.com/repos/alphagov/pay-connector/statuses/3fa2c5ab663b879f688518021a9eced2579f492e","head":{"label":"alphagov:PP-4276","ref":"PP-4276","sha":"3fa2c5ab663b879f688518021a9eced2579f492e","user":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":39890257,"node_id":"MDEwOlJlcG9zaXRvcnkzOTg5MDI1Nw==","name":"pay-connector","full_name":"alphagov/pay-connector","private":false,"owner":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/alphagov/pay-connector","description":"The Payments Connector in Java (Dropwizard)","fork":false,"url":"https://api.github.com/repos/alphagov/pay-connector","forks_url":"https://api.github.com/repos/alphagov/pay-connector/forks","keys_url":"https://api.github.com/repos/alphagov/pay-connector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/pay-connector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/pay-connector/teams","hooks_url":"https://api.github.com/repos/alphagov/pay-connector/hooks","issue_events_url":"https://api.github.com/repos/alphagov/pay-connector/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/pay-connector/events","assignees_url":"https://api.github.com/repos/alphagov/pay-connector/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/pay-connector/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/pay-connector/tags","blobs_url":"https://api.github.com/repos/alphagov/pay-connector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/pay-connector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/pay-connector/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/pay-connector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/pay-connector/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/pay-connector/languages","stargazers_url":"https://api.github.com/repos/alphagov/pay-connector/stargazers","contributors_url":"https://api.github.com/repos/alphagov/pay-connector/contributors","subscribers_url":"https://api.github.com/repos/alphagov/pay-connector/subscribers","subscription_url":"https://api.github.com/repos/alphagov/pay-connector/subscription","commits_url":"https://api.github.com/repos/alphagov/pay-connector/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/pay-connector/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/pay-connector/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/pay-connector/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/pay-connector/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/pay-connector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/pay-connector/merges","archive_url":"https://api.github.com/repos/alphagov/pay-connector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/pay-connector/downloads","issues_url":"https://api.github.com/repos/alphagov/pay-connector/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/pay-connector/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/pay-connector/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/pay-connector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/pay-connector/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/pay-connector/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/pay-connector/deployments","created_at":"2015-07-29T11:38:35Z","updated_at":"2018-10-18T15:17:31Z","pushed_at":"2018-10-18T16:12:47Z","git_url":"git://github.com/alphagov/pay-connector.git","ssh_url":"git@github.com:alphagov/pay-connector.git","clone_url":"https://github.com/alphagov/pay-connector.git","svn_url":"https://github.com/alphagov/pay-connector","homepage":null,"size":16873,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"2b345be929de317930eee7cb79766a6f15764e2e","user":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":39890257,"node_id":"MDEwOlJlcG9zaXRvcnkzOTg5MDI1Nw==","name":"pay-connector","full_name":"alphagov/pay-connector","private":false,"owner":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/alphagov/pay-connector","description":"The Payments Connector in Java (Dropwizard)","fork":false,"url":"https://api.github.com/repos/alphagov/pay-connector","forks_url":"https://api.github.com/repos/alphagov/pay-connector/forks","keys_url":"https://api.github.com/repos/alphagov/pay-connector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/pay-connector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/pay-connector/teams","hooks_url":"https://api.github.com/repos/alphagov/pay-connector/hooks","issue_events_url":"https://api.github.com/repos/alphagov/pay-connector/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/pay-connector/events","assignees_url":"https://api.github.com/repos/alphagov/pay-connector/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/pay-connector/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/pay-connector/tags","blobs_url":"https://api.github.com/repos/alphagov/pay-connector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/pay-connector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/pay-connector/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/pay-connector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/pay-connector/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/pay-connector/languages","stargazers_url":"https://api.github.com/repos/alphagov/pay-connector/stargazers","contributors_url":"https://api.github.com/repos/alphagov/pay-connector/contributors","subscribers_url":"https://api.github.com/repos/alphagov/pay-connector/subscribers","subscription_url":"https://api.github.com/repos/alphagov/pay-connector/subscription","commits_url":"https://api.github.com/repos/alphagov/pay-connector/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/pay-connector/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/pay-connector/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/pay-connector/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/pay-connector/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/pay-connector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/pay-connector/merges","archive_url":"https://api.github.com/repos/alphagov/pay-connector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/pay-connector/downloads","issues_url":"https://api.github.com/repos/alphagov/pay-connector/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/pay-connector/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/pay-connector/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/pay-connector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/pay-connector/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/pay-connector/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/pay-connector/deployments","created_at":"2015-07-29T11:38:35Z","updated_at":"2018-10-18T15:17:31Z","pushed_at":"2018-10-18T16:12:47Z","git_url":"git://github.com/alphagov/pay-connector.git","ssh_url":"git@github.com:alphagov/pay-connector.git","clone_url":"https://github.com/alphagov/pay-connector.git","svn_url":"https://github.com/alphagov/pay-connector","homepage":null,"size":16873,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/pay-connector/pulls/737"},"html":{"href":"https://github.com/alphagov/pay-connector/pull/737"},"issue":{"href":"https://api.github.com/repos/alphagov/pay-connector/issues/737"},"comments":{"href":"https://api.github.com/repos/alphagov/pay-connector/issues/737/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/pay-connector/pulls/737/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/pay-connector/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/pay-connector/pulls/737/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/pay-connector/statuses/3fa2c5ab663b879f688518021a9eced2579f492e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"oswaldquek"}}