{"action":"created","comment":{"url":"https://api.github.com/repos/Rokid/ShadowNode/pulls/comments/242401168","pull_request_review_id":185900059,"id":242401168,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjQwMTE2OA==","diff_hunk":"@@ -0,0 +1,17 @@\n+'use strict';\n+\n+var assert = require('assert');\n+var fixtures = require('../common/fixtures');\n+\n+assert.strictEqual(\n+  require.resolve('test_util').toLowerCase(),","path":"test/run_pass/test_require_resolve.js","position":7,"original_position":7,"commit_id":"4054409e7a644833926397b9d53488fd77929eb7","original_commit_id":"4054409e7a644833926397b9d53488fd77929eb7","user":{"login":"legendecas","id":8500303,"node_id":"MDQ6VXNlcjg1MDAzMDM=","avatar_url":"https://avatars3.githubusercontent.com/u/8500303?v=4","gravatar_id":"","url":"https://api.github.com/users/legendecas","html_url":"https://github.com/legendecas","followers_url":"https://api.github.com/users/legendecas/followers","following_url":"https://api.github.com/users/legendecas/following{/other_user}","gists_url":"https://api.github.com/users/legendecas/gists{/gist_id}","starred_url":"https://api.github.com/users/legendecas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/legendecas/subscriptions","organizations_url":"https://api.github.com/users/legendecas/orgs","repos_url":"https://api.github.com/users/legendecas/repos","events_url":"https://api.github.com/users/legendecas/events{/privacy}","received_events_url":"https://api.github.com/users/legendecas/received_events","type":"User","site_admin":false},"body":"Requiring relative modules without leading `./` are not guaranteed on API stability. Tests could cover cases with leading `./` instead.","created_at":"2018-12-18T04:05:34Z","updated_at":"2018-12-18T04:06:31Z","html_url":"https://github.com/Rokid/ShadowNode/pull/445#discussion_r242401168","pull_request_url":"https://api.github.com/repos/Rokid/ShadowNode/pulls/445","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Rokid/ShadowNode/pulls/comments/242401168"},"html":{"href":"https://github.com/Rokid/ShadowNode/pull/445#discussion_r242401168"},"pull_request":{"href":"https://api.github.com/repos/Rokid/ShadowNode/pulls/445"}}},"pull_request":{"url":"https://api.github.com/repos/Rokid/ShadowNode/pulls/445","id":239123137,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5MTIzMTM3","html_url":"https://github.com/Rokid/ShadowNode/pull/445","diff_url":"https://github.com/Rokid/ShadowNode/pull/445.diff","patch_url":"https://github.com/Rokid/ShadowNode/pull/445.patch","issue_url":"https://api.github.com/repos/Rokid/ShadowNode/issues/445","number":445,"state":"open","locked":false,"title":"module: build require.resolve","user":{"login":"Txiaozhe","id":14943539,"node_id":"MDQ6VXNlcjE0OTQzNTM5","avatar_url":"https://avatars0.githubusercontent.com/u/14943539?v=4","gravatar_id":"","url":"https://api.github.com/users/Txiaozhe","html_url":"https://github.com/Txiaozhe","followers_url":"https://api.github.com/users/Txiaozhe/followers","following_url":"https://api.github.com/users/Txiaozhe/following{/other_user}","gists_url":"https://api.github.com/users/Txiaozhe/gists{/gist_id}","starred_url":"https://api.github.com/users/Txiaozhe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Txiaozhe/subscriptions","organizations_url":"https://api.github.com/users/Txiaozhe/orgs","repos_url":"https://api.github.com/users/Txiaozhe/repos","events_url":"https://api.github.com/users/Txiaozhe/events{/privacy}","received_events_url":"https://api.github.com/users/Txiaozhe/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `npm test` passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] documentation is changed or added\r\n","created_at":"2018-12-17T12:12:09Z","updated_at":"2018-12-18T04:06:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1bb337d5b14785c92b8c5008a8158025a1dc0dc0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Rokid/ShadowNode/pulls/445/commits","review_comments_url":"https://api.github.com/repos/Rokid/ShadowNode/pulls/445/comments","review_comment_url":"https://api.github.com/repos/Rokid/ShadowNode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Rokid/ShadowNode/issues/445/comments","statuses_url":"https://api.github.com/repos/Rokid/ShadowNode/statuses/4054409e7a644833926397b9d53488fd77929eb7","head":{"label":"Txiaozhe:build-require-resolve","ref":"build-require-resolve","sha":"4054409e7a644833926397b9d53488fd77929eb7","user":{"login":"Txiaozhe","id":14943539,"node_id":"MDQ6VXNlcjE0OTQzNTM5","avatar_url":"https://avatars0.githubusercontent.com/u/14943539?v=4","gravatar_id":"","url":"https://api.github.com/users/Txiaozhe","html_url":"https://github.com/Txiaozhe","followers_url":"https://api.github.com/users/Txiaozhe/followers","following_url":"https://api.github.com/users/Txiaozhe/following{/other_user}","gists_url":"https://api.github.com/users/Txiaozhe/gists{/gist_id}","starred_url":"https://api.github.com/users/Txiaozhe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Txiaozhe/subscriptions","organizations_url":"https://api.github.com/users/Txiaozhe/orgs","repos_url":"https://api.github.com/users/Txiaozhe/repos","events_url":"https://api.github.com/users/Txiaozhe/events{/privacy}","received_events_url":"https://api.github.com/users/Txiaozhe/received_events","type":"User","site_admin":false},"repo":{"id":160775236,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA3NzUyMzY=","name":"ShadowNode","full_name":"Txiaozhe/ShadowNode","private":false,"owner":{"login":"Txiaozhe","id":14943539,"node_id":"MDQ6VXNlcjE0OTQzNTM5","avatar_url":"https://avatars0.githubusercontent.com/u/14943539?v=4","gravatar_id":"","url":"https://api.github.com/users/Txiaozhe","html_url":"https://github.com/Txiaozhe","followers_url":"https://api.github.com/users/Txiaozhe/followers","following_url":"https://api.github.com/users/Txiaozhe/following{/other_user}","gists_url":"https://api.github.com/users/Txiaozhe/gists{/gist_id}","starred_url":"https://api.github.com/users/Txiaozhe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Txiaozhe/subscriptions","organizations_url":"https://api.github.com/users/Txiaozhe/orgs","repos_url":"https://api.github.com/users/Txiaozhe/repos","events_url":"https://api.github.com/users/Txiaozhe/events{/privacy}","received_events_url":"https://api.github.com/users/Txiaozhe/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Txiaozhe/ShadowNode","description":"Use Node.js in your end devices :)","fork":true,"url":"https://api.github.com/repos/Txiaozhe/ShadowNode","forks_url":"https://api.github.com/repos/Txiaozhe/ShadowNode/forks","keys_url":"https://api.github.com/repos/Txiaozhe/ShadowNode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Txiaozhe/ShadowNode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Txiaozhe/ShadowNode/teams","hooks_url":"https://api.github.com/repos/Txiaozhe/ShadowNode/hooks","issue_events_url":"https://api.github.com/repos/Txiaozhe/ShadowNode/issues/events{/number}","events_url":"https://api.github.com/repos/Txiaozhe/ShadowNode/events","assignees_url":"https://api.github.com/repos/Txiaozhe/ShadowNode/assignees{/user}","branches_url":"https://api.github.com/repos/Txiaozhe/ShadowNode/branches{/branch}","tags_url":"https://api.github.com/repos/Txiaozhe/ShadowNode/tags","blobs_url":"https://api.github.com/repos/Txiaozhe/ShadowNode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Txiaozhe/ShadowNode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Txiaozhe/ShadowNode/git/refs{/sha}","trees_url":"https://api.github.com/repos/Txiaozhe/ShadowNode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Txiaozhe/ShadowNode/statuses/{sha}","languages_url":"https://api.github.com/repos/Txiaozhe/ShadowNode/languages","stargazers_url":"https://api.github.com/repos/Txiaozhe/ShadowNode/stargazers","contributors_url":"https://api.github.com/repos/Txiaozhe/ShadowNode/contributors","subscribers_url":"https://api.github.com/repos/Txiaozhe/ShadowNode/subscribers","subscription_url":"https://api.github.com/repos/Txiaozhe/ShadowNode/subscription","commits_url":"https://api.github.com/repos/Txiaozhe/ShadowNode/commits{/sha}","git_commits_url":"https://api.github.com/repos/Txiaozhe/ShadowNode/git/commits{/sha}","comments_url":"https://api.github.com/repos/Txiaozhe/ShadowNode/comments{/number}","issue_comment_url":"https://api.github.com/repos/Txiaozhe/ShadowNode/issues/comments{/number}","contents_url":"https://api.github.com/repos/Txiaozhe/ShadowNode/contents/{+path}","compare_url":"https://api.github.com/repos/Txiaozhe/ShadowNode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Txiaozhe/ShadowNode/merges","archive_url":"https://api.github.com/repos/Txiaozhe/ShadowNode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Txiaozhe/ShadowNode/downloads","issues_url":"https://api.github.com/repos/Txiaozhe/ShadowNode/issues{/number}","pulls_url":"https://api.github.com/repos/Txiaozhe/ShadowNode/pulls{/number}","milestones_url":"https://api.github.com/repos/Txiaozhe/ShadowNode/milestones{/number}","notifications_url":"https://api.github.com/repos/Txiaozhe/ShadowNode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Txiaozhe/ShadowNode/labels{/name}","releases_url":"https://api.github.com/repos/Txiaozhe/ShadowNode/releases{/id}","deployments_url":"https://api.github.com/repos/Txiaozhe/ShadowNode/deployments","created_at":"2018-12-07T05:27:54Z","updated_at":"2018-12-12T11:06:40Z","pushed_at":"2018-12-17T12:28:44Z","git_url":"git://github.com/Txiaozhe/ShadowNode.git","ssh_url":"git@github.com:Txiaozhe/ShadowNode.git","clone_url":"https://github.com/Txiaozhe/ShadowNode.git","svn_url":"https://github.com/Txiaozhe/ShadowNode","homepage":"https://rokid.github.io/ShadowNode/","size":10043,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Rokid:master","ref":"master","sha":"859d60c4ada28ed946af009eafffc73cbb3b4f61","user":{"login":"Rokid","id":19773259,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NzczMjU5","avatar_url":"https://avatars2.githubusercontent.com/u/19773259?v=4","gravatar_id":"","url":"https://api.github.com/users/Rokid","html_url":"https://github.com/Rokid","followers_url":"https://api.github.com/users/Rokid/followers","following_url":"https://api.github.com/users/Rokid/following{/other_user}","gists_url":"https://api.github.com/users/Rokid/gists{/gist_id}","starred_url":"https://api.github.com/users/Rokid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rokid/subscriptions","organizations_url":"https://api.github.com/users/Rokid/orgs","repos_url":"https://api.github.com/users/Rokid/repos","events_url":"https://api.github.com/users/Rokid/events{/privacy}","received_events_url":"https://api.github.com/users/Rokid/received_events","type":"Organization","site_admin":false},"repo":{"id":114971968,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ5NzE5Njg=","name":"ShadowNode","full_name":"Rokid/ShadowNode","private":false,"owner":{"login":"Rokid","id":19773259,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NzczMjU5","avatar_url":"https://avatars2.githubusercontent.com/u/19773259?v=4","gravatar_id":"","url":"https://api.github.com/users/Rokid","html_url":"https://github.com/Rokid","followers_url":"https://api.github.com/users/Rokid/followers","following_url":"https://api.github.com/users/Rokid/following{/other_user}","gists_url":"https://api.github.com/users/Rokid/gists{/gist_id}","starred_url":"https://api.github.com/users/Rokid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rokid/subscriptions","organizations_url":"https://api.github.com/users/Rokid/orgs","repos_url":"https://api.github.com/users/Rokid/repos","events_url":"https://api.github.com/users/Rokid/events{/privacy}","received_events_url":"https://api.github.com/users/Rokid/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Rokid/ShadowNode","description":"Use Node.js in your end devices :)","fork":false,"url":"https://api.github.com/repos/Rokid/ShadowNode","forks_url":"https://api.github.com/repos/Rokid/ShadowNode/forks","keys_url":"https://api.github.com/repos/Rokid/ShadowNode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Rokid/ShadowNode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Rokid/ShadowNode/teams","hooks_url":"https://api.github.com/repos/Rokid/ShadowNode/hooks","issue_events_url":"https://api.github.com/repos/Rokid/ShadowNode/issues/events{/number}","events_url":"https://api.github.com/repos/Rokid/ShadowNode/events","assignees_url":"https://api.github.com/repos/Rokid/ShadowNode/assignees{/user}","branches_url":"https://api.github.com/repos/Rokid/ShadowNode/branches{/branch}","tags_url":"https://api.github.com/repos/Rokid/ShadowNode/tags","blobs_url":"https://api.github.com/repos/Rokid/ShadowNode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Rokid/ShadowNode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Rokid/ShadowNode/git/refs{/sha}","trees_url":"https://api.github.com/repos/Rokid/ShadowNode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Rokid/ShadowNode/statuses/{sha}","languages_url":"https://api.github.com/repos/Rokid/ShadowNode/languages","stargazers_url":"https://api.github.com/repos/Rokid/ShadowNode/stargazers","contributors_url":"https://api.github.com/repos/Rokid/ShadowNode/contributors","subscribers_url":"https://api.github.com/repos/Rokid/ShadowNode/subscribers","subscription_url":"https://api.github.com/repos/Rokid/ShadowNode/subscription","commits_url":"https://api.github.com/repos/Rokid/ShadowNode/commits{/sha}","git_commits_url":"https://api.github.com/repos/Rokid/ShadowNode/git/commits{/sha}","comments_url":"https://api.github.com/repos/Rokid/ShadowNode/comments{/number}","issue_comment_url":"https://api.github.com/repos/Rokid/ShadowNode/issues/comments{/number}","contents_url":"https://api.github.com/repos/Rokid/ShadowNode/contents/{+path}","compare_url":"https://api.github.com/repos/Rokid/ShadowNode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Rokid/ShadowNode/merges","archive_url":"https://api.github.com/repos/Rokid/ShadowNode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Rokid/ShadowNode/downloads","issues_url":"https://api.github.com/repos/Rokid/ShadowNode/issues{/number}","pulls_url":"https://api.github.com/repos/Rokid/ShadowNode/pulls{/number}","milestones_url":"https://api.github.com/repos/Rokid/ShadowNode/milestones{/number}","notifications_url":"https://api.github.com/repos/Rokid/ShadowNode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Rokid/ShadowNode/labels{/name}","releases_url":"https://api.github.com/repos/Rokid/ShadowNode/releases{/id}","deployments_url":"https://api.github.com/repos/Rokid/ShadowNode/deployments","created_at":"2017-12-21T06:40:28Z","updated_at":"2018-12-17T07:45:39Z","pushed_at":"2018-12-17T12:28:45Z","git_url":"git://github.com/Rokid/ShadowNode.git","ssh_url":"git@github.com:Rokid/ShadowNode.git","clone_url":"https://github.com/Rokid/ShadowNode.git","svn_url":"https://github.com/Rokid/ShadowNode","homepage":"https://rokid.github.io/ShadowNode/","size":10052,"stargazers_count":363,"watchers_count":363,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":61,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":24,"open_issues":61,"watchers":363,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Rokid/ShadowNode/pulls/445"},"html":{"href":"https://github.com/Rokid/ShadowNode/pull/445"},"issue":{"href":"https://api.github.com/repos/Rokid/ShadowNode/issues/445"},"comments":{"href":"https://api.github.com/repos/Rokid/ShadowNode/issues/445/comments"},"review_comments":{"href":"https://api.github.com/repos/Rokid/ShadowNode/pulls/445/comments"},"review_comment":{"href":"https://api.github.com/repos/Rokid/ShadowNode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Rokid/ShadowNode/pulls/445/commits"},"statuses":{"href":"https://api.github.com/repos/Rokid/ShadowNode/statuses/4054409e7a644833926397b9d53488fd77929eb7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"legendecas"}}