{"action":"created","comment":{"url":"https://api.github.com/repos/python-trio/trio/pulls/comments/183012213","pull_request_review_id":113929443,"id":183012213,"diff_hunk":"@@ -30,19 +30,4 @@ def capture(cls, sync_fn, *args):\n # ensure that isinstance(Value(), Result)/issubclass(Value, Result) and etc\n # don't break\n Result.register(Value)\n-Result.register(Error)\n-\n-__deprecated_attributes__ = {\n-    \"Result\":\n-        _deprecate.DeprecatedAttribute(\n-            Result, \"0.5.0\", issue=494, instead=\"outcome.Outcome\"\n-        ),\n-    \"Value\":\n-        _deprecate.DeprecatedAttribute(\n-            Value, \"0.5.0\", issue=494, instead=\"outcome.Value\"\n-        ),\n-    \"Error\":\n-        _deprecate.DeprecatedAttribute(\n-            Error, \"0.5.0\", issue=494, instead=\"outcome.Error\"\n-        )\n-}\n+Result.register(Error)","path":"trio/_core/_result.py","position":null,"original_position":20,"commit_id":"768fdcfffe52096cacd9d13f4a7f87a2a0e82a4d","original_commit_id":"6587bbf8985a4e42fbeecfa552c8f686150ae463","user":{"login":"Fuyukai","id":8783751,"avatar_url":"https://avatars1.githubusercontent.com/u/8783751?v=4","gravatar_id":"","url":"https://api.github.com/users/Fuyukai","html_url":"https://github.com/Fuyukai","followers_url":"https://api.github.com/users/Fuyukai/followers","following_url":"https://api.github.com/users/Fuyukai/following{/other_user}","gists_url":"https://api.github.com/users/Fuyukai/gists{/gist_id}","starred_url":"https://api.github.com/users/Fuyukai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fuyukai/subscriptions","organizations_url":"https://api.github.com/users/Fuyukai/orgs","repos_url":"https://api.github.com/users/Fuyukai/repos","events_url":"https://api.github.com/users/Fuyukai/events{/privacy}","received_events_url":"https://api.github.com/users/Fuyukai/received_events","type":"User","site_admin":false},"body":"Whoops, missed that. Surprised yapf didn't catch it.","created_at":"2018-04-20T10:39:57Z","updated_at":"2018-04-20T10:39:57Z","html_url":"https://github.com/python-trio/trio/pull/503#discussion_r183012213","pull_request_url":"https://api.github.com/repos/python-trio/trio/pulls/503","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/python-trio/trio/pulls/comments/183012213"},"html":{"href":"https://github.com/python-trio/trio/pull/503#discussion_r183012213"},"pull_request":{"href":"https://api.github.com/repos/python-trio/trio/pulls/503"}},"in_reply_to_id":183011708},"pull_request":{"url":"https://api.github.com/repos/python-trio/trio/pulls/503","id":182334357,"html_url":"https://github.com/python-trio/trio/pull/503","diff_url":"https://github.com/python-trio/trio/pull/503.diff","patch_url":"https://github.com/python-trio/trio/pull/503.patch","issue_url":"https://api.github.com/repos/python-trio/trio/issues/503","number":503,"state":"open","locked":false,"title":"Switch to using standalone Outcome library.","user":{"login":"Fuyukai","id":8783751,"avatar_url":"https://avatars1.githubusercontent.com/u/8783751?v=4","gravatar_id":"","url":"https://api.github.com/users/Fuyukai","html_url":"https://github.com/Fuyukai","followers_url":"https://api.github.com/users/Fuyukai/followers","following_url":"https://api.github.com/users/Fuyukai/following{/other_user}","gists_url":"https://api.github.com/users/Fuyukai/gists{/gist_id}","starred_url":"https://api.github.com/users/Fuyukai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fuyukai/subscriptions","organizations_url":"https://api.github.com/users/Fuyukai/orgs","repos_url":"https://api.github.com/users/Fuyukai/repos","events_url":"https://api.github.com/users/Fuyukai/events{/privacy}","received_events_url":"https://api.github.com/users/Fuyukai/received_events","type":"User","site_admin":false},"body":"Closes #494. Closes #505.\r\n\r\nNot sure what to do about the Result object section in hazmat docs yet.","created_at":"2018-04-17T23:55:35Z","updated_at":"2018-04-20T10:39:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e3bd93d6d29d386935ce9824099446cfe351ab88","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/python-trio/trio/pulls/503/commits","review_comments_url":"https://api.github.com/repos/python-trio/trio/pulls/503/comments","review_comment_url":"https://api.github.com/repos/python-trio/trio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/python-trio/trio/issues/503/comments","statuses_url":"https://api.github.com/repos/python-trio/trio/statuses/768fdcfffe52096cacd9d13f4a7f87a2a0e82a4d","head":{"label":"Fuyukai:use-outcome","ref":"use-outcome","sha":"768fdcfffe52096cacd9d13f4a7f87a2a0e82a4d","user":{"login":"Fuyukai","id":8783751,"avatar_url":"https://avatars1.githubusercontent.com/u/8783751?v=4","gravatar_id":"","url":"https://api.github.com/users/Fuyukai","html_url":"https://github.com/Fuyukai","followers_url":"https://api.github.com/users/Fuyukai/followers","following_url":"https://api.github.com/users/Fuyukai/following{/other_user}","gists_url":"https://api.github.com/users/Fuyukai/gists{/gist_id}","starred_url":"https://api.github.com/users/Fuyukai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fuyukai/subscriptions","organizations_url":"https://api.github.com/users/Fuyukai/orgs","repos_url":"https://api.github.com/users/Fuyukai/repos","events_url":"https://api.github.com/users/Fuyukai/events{/privacy}","received_events_url":"https://api.github.com/users/Fuyukai/received_events","type":"User","site_admin":false},"repo":{"id":114502561,"name":"trio","full_name":"Fuyukai/trio","owner":{"login":"Fuyukai","id":8783751,"avatar_url":"https://avatars1.githubusercontent.com/u/8783751?v=4","gravatar_id":"","url":"https://api.github.com/users/Fuyukai","html_url":"https://github.com/Fuyukai","followers_url":"https://api.github.com/users/Fuyukai/followers","following_url":"https://api.github.com/users/Fuyukai/following{/other_user}","gists_url":"https://api.github.com/users/Fuyukai/gists{/gist_id}","starred_url":"https://api.github.com/users/Fuyukai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fuyukai/subscriptions","organizations_url":"https://api.github.com/users/Fuyukai/orgs","repos_url":"https://api.github.com/users/Fuyukai/repos","events_url":"https://api.github.com/users/Fuyukai/events{/privacy}","received_events_url":"https://api.github.com/users/Fuyukai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Fuyukai/trio","description":"Trio – Pythonic async I/O for humans and snake people 🐍","fork":true,"url":"https://api.github.com/repos/Fuyukai/trio","forks_url":"https://api.github.com/repos/Fuyukai/trio/forks","keys_url":"https://api.github.com/repos/Fuyukai/trio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Fuyukai/trio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Fuyukai/trio/teams","hooks_url":"https://api.github.com/repos/Fuyukai/trio/hooks","issue_events_url":"https://api.github.com/repos/Fuyukai/trio/issues/events{/number}","events_url":"https://api.github.com/repos/Fuyukai/trio/events","assignees_url":"https://api.github.com/repos/Fuyukai/trio/assignees{/user}","branches_url":"https://api.github.com/repos/Fuyukai/trio/branches{/branch}","tags_url":"https://api.github.com/repos/Fuyukai/trio/tags","blobs_url":"https://api.github.com/repos/Fuyukai/trio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Fuyukai/trio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Fuyukai/trio/git/refs{/sha}","trees_url":"https://api.github.com/repos/Fuyukai/trio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Fuyukai/trio/statuses/{sha}","languages_url":"https://api.github.com/repos/Fuyukai/trio/languages","stargazers_url":"https://api.github.com/repos/Fuyukai/trio/stargazers","contributors_url":"https://api.github.com/repos/Fuyukai/trio/contributors","subscribers_url":"https://api.github.com/repos/Fuyukai/trio/subscribers","subscription_url":"https://api.github.com/repos/Fuyukai/trio/subscription","commits_url":"https://api.github.com/repos/Fuyukai/trio/commits{/sha}","git_commits_url":"https://api.github.com/repos/Fuyukai/trio/git/commits{/sha}","comments_url":"https://api.github.com/repos/Fuyukai/trio/comments{/number}","issue_comment_url":"https://api.github.com/repos/Fuyukai/trio/issues/comments{/number}","contents_url":"https://api.github.com/repos/Fuyukai/trio/contents/{+path}","compare_url":"https://api.github.com/repos/Fuyukai/trio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Fuyukai/trio/merges","archive_url":"https://api.github.com/repos/Fuyukai/trio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Fuyukai/trio/downloads","issues_url":"https://api.github.com/repos/Fuyukai/trio/issues{/number}","pulls_url":"https://api.github.com/repos/Fuyukai/trio/pulls{/number}","milestones_url":"https://api.github.com/repos/Fuyukai/trio/milestones{/number}","notifications_url":"https://api.github.com/repos/Fuyukai/trio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Fuyukai/trio/labels{/name}","releases_url":"https://api.github.com/repos/Fuyukai/trio/releases{/id}","deployments_url":"https://api.github.com/repos/Fuyukai/trio/deployments","created_at":"2017-12-17T01:54:20Z","updated_at":"2017-12-17T01:54:22Z","pushed_at":"2018-04-20T10:39:16Z","git_url":"git://github.com/Fuyukai/trio.git","ssh_url":"git@github.com:Fuyukai/trio.git","clone_url":"https://github.com/Fuyukai/trio.git","svn_url":"https://github.com/Fuyukai/trio","homepage":"","size":2005,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"python-trio:master","ref":"master","sha":"94d49f95ffba3634197c173b771dca80ebc70b08","user":{"login":"python-trio","id":26335827,"avatar_url":"https://avatars2.githubusercontent.com/u/26335827?v=4","gravatar_id":"","url":"https://api.github.com/users/python-trio","html_url":"https://github.com/python-trio","followers_url":"https://api.github.com/users/python-trio/followers","following_url":"https://api.github.com/users/python-trio/following{/other_user}","gists_url":"https://api.github.com/users/python-trio/gists{/gist_id}","starred_url":"https://api.github.com/users/python-trio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python-trio/subscriptions","organizations_url":"https://api.github.com/users/python-trio/orgs","repos_url":"https://api.github.com/users/python-trio/repos","events_url":"https://api.github.com/users/python-trio/events{/privacy}","received_events_url":"https://api.github.com/users/python-trio/received_events","type":"Organization","site_admin":false},"repo":{"id":79083614,"name":"trio","full_name":"python-trio/trio","owner":{"login":"python-trio","id":26335827,"avatar_url":"https://avatars2.githubusercontent.com/u/26335827?v=4","gravatar_id":"","url":"https://api.github.com/users/python-trio","html_url":"https://github.com/python-trio","followers_url":"https://api.github.com/users/python-trio/followers","following_url":"https://api.github.com/users/python-trio/following{/other_user}","gists_url":"https://api.github.com/users/python-trio/gists{/gist_id}","starred_url":"https://api.github.com/users/python-trio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python-trio/subscriptions","organizations_url":"https://api.github.com/users/python-trio/orgs","repos_url":"https://api.github.com/users/python-trio/repos","events_url":"https://api.github.com/users/python-trio/events{/privacy}","received_events_url":"https://api.github.com/users/python-trio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/python-trio/trio","description":"Trio – Pythonic async I/O for humans and snake people 🐍","fork":false,"url":"https://api.github.com/repos/python-trio/trio","forks_url":"https://api.github.com/repos/python-trio/trio/forks","keys_url":"https://api.github.com/repos/python-trio/trio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python-trio/trio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python-trio/trio/teams","hooks_url":"https://api.github.com/repos/python-trio/trio/hooks","issue_events_url":"https://api.github.com/repos/python-trio/trio/issues/events{/number}","events_url":"https://api.github.com/repos/python-trio/trio/events","assignees_url":"https://api.github.com/repos/python-trio/trio/assignees{/user}","branches_url":"https://api.github.com/repos/python-trio/trio/branches{/branch}","tags_url":"https://api.github.com/repos/python-trio/trio/tags","blobs_url":"https://api.github.com/repos/python-trio/trio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python-trio/trio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python-trio/trio/git/refs{/sha}","trees_url":"https://api.github.com/repos/python-trio/trio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python-trio/trio/statuses/{sha}","languages_url":"https://api.github.com/repos/python-trio/trio/languages","stargazers_url":"https://api.github.com/repos/python-trio/trio/stargazers","contributors_url":"https://api.github.com/repos/python-trio/trio/contributors","subscribers_url":"https://api.github.com/repos/python-trio/trio/subscribers","subscription_url":"https://api.github.com/repos/python-trio/trio/subscription","commits_url":"https://api.github.com/repos/python-trio/trio/commits{/sha}","git_commits_url":"https://api.github.com/repos/python-trio/trio/git/commits{/sha}","comments_url":"https://api.github.com/repos/python-trio/trio/comments{/number}","issue_comment_url":"https://api.github.com/repos/python-trio/trio/issues/comments{/number}","contents_url":"https://api.github.com/repos/python-trio/trio/contents/{+path}","compare_url":"https://api.github.com/repos/python-trio/trio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python-trio/trio/merges","archive_url":"https://api.github.com/repos/python-trio/trio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python-trio/trio/downloads","issues_url":"https://api.github.com/repos/python-trio/trio/issues{/number}","pulls_url":"https://api.github.com/repos/python-trio/trio/pulls{/number}","milestones_url":"https://api.github.com/repos/python-trio/trio/milestones{/number}","notifications_url":"https://api.github.com/repos/python-trio/trio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python-trio/trio/labels{/name}","releases_url":"https://api.github.com/repos/python-trio/trio/releases{/id}","deployments_url":"https://api.github.com/repos/python-trio/trio/deployments","created_at":"2017-01-16T04:45:25Z","updated_at":"2018-04-20T06:24:25Z","pushed_at":"2018-04-20T10:39:17Z","git_url":"git://github.com/python-trio/trio.git","ssh_url":"git@github.com:python-trio/trio.git","clone_url":"https://github.com/python-trio/trio.git","svn_url":"https://github.com/python-trio/trio","homepage":"https://trio.readthedocs.io","size":1948,"stargazers_count":793,"watchers_count":793,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"archived":false,"open_issues_count":157,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":52,"open_issues":157,"watchers":793,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/python-trio/trio/pulls/503"},"html":{"href":"https://github.com/python-trio/trio/pull/503"},"issue":{"href":"https://api.github.com/repos/python-trio/trio/issues/503"},"comments":{"href":"https://api.github.com/repos/python-trio/trio/issues/503/comments"},"review_comments":{"href":"https://api.github.com/repos/python-trio/trio/pulls/503/comments"},"review_comment":{"href":"https://api.github.com/repos/python-trio/trio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/python-trio/trio/pulls/503/commits"},"statuses":{"href":"https://api.github.com/repos/python-trio/trio/statuses/768fdcfffe52096cacd9d13f4a7f87a2a0e82a4d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Fuyukai"}}