{"action":"closed","number":159,"pull_request":{"url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/pulls/159","id":169454384,"html_url":"https://github.com/cms-gem-daq-project/vfatqc-python-scripts/pull/159","diff_url":"https://github.com/cms-gem-daq-project/vfatqc-python-scripts/pull/159.diff","patch_url":"https://github.com/cms-gem-daq-project/vfatqc-python-scripts/pull/159.patch","issue_url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/issues/159","number":159,"state":"closed","locked":false,"title":"Bug Fix [V3]: sbitThreshScanParallel.py not properly storing output data","user":{"login":"bdorney","id":6432141,"avatar_url":"https://avatars0.githubusercontent.com/u/6432141?v=4","gravatar_id":"","url":"https://api.github.com/users/bdorney","html_url":"https://github.com/bdorney","followers_url":"https://api.github.com/users/bdorney/followers","following_url":"https://api.github.com/users/bdorney/following{/other_user}","gists_url":"https://api.github.com/users/bdorney/gists{/gist_id}","starred_url":"https://api.github.com/users/bdorney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdorney/subscriptions","organizations_url":"https://api.github.com/users/bdorney/orgs","repos_url":"https://api.github.com/users/bdorney/repos","events_url":"https://api.github.com/users/bdorney/events{/privacy}","received_events_url":"https://api.github.com/users/bdorney/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\nImproper array indexing was causing crashes in `sbitThreshScanParallel.py`\r\n\r\n### Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [X] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue(s) here. -->\r\nThe scan `sbitThreshScanParallel.py` was crashing.\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\nRan successfully without crashes; see: http://cmsonline.cern.ch/cms-elog/1028798\r\n\r\n### Screenshots (if appropriate):\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [X] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [X] I have added tests to cover my changes.\r\n- [X] All new and existing tests passed.\r\n\r\n<!--- Template thanks to https://www.talater.com/open-source-templates/#/page/99 -->\r\n","created_at":"2018-02-15T18:49:24Z","updated_at":"2018-03-09T15:42:40Z","closed_at":"2018-03-09T15:42:40Z","merged_at":"2018-03-09T15:42:40Z","merge_commit_sha":"a79dcdcb64ace707d8282d1e0616dd47c434982b","assignee":{"login":"bdorney","id":6432141,"avatar_url":"https://avatars0.githubusercontent.com/u/6432141?v=4","gravatar_id":"","url":"https://api.github.com/users/bdorney","html_url":"https://github.com/bdorney","followers_url":"https://api.github.com/users/bdorney/followers","following_url":"https://api.github.com/users/bdorney/following{/other_user}","gists_url":"https://api.github.com/users/bdorney/gists{/gist_id}","starred_url":"https://api.github.com/users/bdorney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdorney/subscriptions","organizations_url":"https://api.github.com/users/bdorney/orgs","repos_url":"https://api.github.com/users/bdorney/repos","events_url":"https://api.github.com/users/bdorney/events{/privacy}","received_events_url":"https://api.github.com/users/bdorney/received_events","type":"User","site_admin":false},"assignees":[{"login":"bdorney","id":6432141,"avatar_url":"https://avatars0.githubusercontent.com/u/6432141?v=4","gravatar_id":"","url":"https://api.github.com/users/bdorney","html_url":"https://github.com/bdorney","followers_url":"https://api.github.com/users/bdorney/followers","following_url":"https://api.github.com/users/bdorney/following{/other_user}","gists_url":"https://api.github.com/users/bdorney/gists{/gist_id}","starred_url":"https://api.github.com/users/bdorney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdorney/subscriptions","organizations_url":"https://api.github.com/users/bdorney/orgs","repos_url":"https://api.github.com/users/bdorney/repos","events_url":"https://api.github.com/users/bdorney/events{/privacy}","received_events_url":"https://api.github.com/users/bdorney/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"jsturdy","id":5197820,"avatar_url":"https://avatars1.githubusercontent.com/u/5197820?v=4","gravatar_id":"","url":"https://api.github.com/users/jsturdy","html_url":"https://github.com/jsturdy","followers_url":"https://api.github.com/users/jsturdy/followers","following_url":"https://api.github.com/users/jsturdy/following{/other_user}","gists_url":"https://api.github.com/users/jsturdy/gists{/gist_id}","starred_url":"https://api.github.com/users/jsturdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsturdy/subscriptions","organizations_url":"https://api.github.com/users/jsturdy/orgs","repos_url":"https://api.github.com/users/jsturdy/repos","events_url":"https://api.github.com/users/jsturdy/events{/privacy}","received_events_url":"https://api.github.com/users/jsturdy/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":490990131,"url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/labels/Priority:%20High","name":"Priority: High","color":"ff8000","default":false},{"id":490990132,"url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/labels/Status:%20Review%20Needed","name":"Status: Review Needed","color":"ff8000","default":false},{"id":490990137,"url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/labels/Type:%20Bugfix","name":"Type: Bugfix","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/pulls/159/commits","review_comments_url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/pulls/159/comments","review_comment_url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/issues/159/comments","statuses_url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/statuses/cba8388b62bf784da27be447744c0014535cb124","head":{"label":"bdorney:bugFix_sbitThreshParallelV3","ref":"bugFix_sbitThreshParallelV3","sha":"cba8388b62bf784da27be447744c0014535cb124","user":{"login":"bdorney","id":6432141,"avatar_url":"https://avatars0.githubusercontent.com/u/6432141?v=4","gravatar_id":"","url":"https://api.github.com/users/bdorney","html_url":"https://github.com/bdorney","followers_url":"https://api.github.com/users/bdorney/followers","following_url":"https://api.github.com/users/bdorney/following{/other_user}","gists_url":"https://api.github.com/users/bdorney/gists{/gist_id}","starred_url":"https://api.github.com/users/bdorney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdorney/subscriptions","organizations_url":"https://api.github.com/users/bdorney/orgs","repos_url":"https://api.github.com/users/bdorney/repos","events_url":"https://api.github.com/users/bdorney/events{/privacy}","received_events_url":"https://api.github.com/users/bdorney/received_events","type":"User","site_admin":false},"repo":{"id":73500748,"name":"vfatqc-python-scripts","full_name":"bdorney/vfatqc-python-scripts","owner":{"login":"bdorney","id":6432141,"avatar_url":"https://avatars0.githubusercontent.com/u/6432141?v=4","gravatar_id":"","url":"https://api.github.com/users/bdorney","html_url":"https://github.com/bdorney","followers_url":"https://api.github.com/users/bdorney/followers","following_url":"https://api.github.com/users/bdorney/following{/other_user}","gists_url":"https://api.github.com/users/bdorney/gists{/gist_id}","starred_url":"https://api.github.com/users/bdorney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdorney/subscriptions","organizations_url":"https://api.github.com/users/bdorney/orgs","repos_url":"https://api.github.com/users/bdorney/repos","events_url":"https://api.github.com/users/bdorney/events{/privacy}","received_events_url":"https://api.github.com/users/bdorney/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bdorney/vfatqc-python-scripts","description":null,"fork":true,"url":"https://api.github.com/repos/bdorney/vfatqc-python-scripts","forks_url":"https://api.github.com/repos/bdorney/vfatqc-python-scripts/forks","keys_url":"https://api.github.com/repos/bdorney/vfatqc-python-scripts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bdorney/vfatqc-python-scripts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bdorney/vfatqc-python-scripts/teams","hooks_url":"https://api.github.com/repos/bdorney/vfatqc-python-scripts/hooks","issue_events_url":"https://api.github.com/repos/bdorney/vfatqc-python-scripts/issues/events{/number}","events_url":"https://api.github.com/repos/bdorney/vfatqc-python-scripts/events","assignees_url":"https://api.github.com/repos/bdorney/vfatqc-python-scripts/assignees{/user}","branches_url":"https://api.github.com/repos/bdorney/vfatqc-python-scripts/branches{/branch}","tags_url":"https://api.github.com/repos/bdorney/vfatqc-python-scripts/tags","blobs_url":"https://api.github.com/repos/bdorney/vfatqc-python-scripts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bdorney/vfatqc-python-scripts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bdorney/vfatqc-python-scripts/git/refs{/sha}","trees_url":"https://api.github.com/repos/bdorney/vfatqc-python-scripts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bdorney/vfatqc-python-scripts/statuses/{sha}","languages_url":"https://api.github.com/repos/bdorney/vfatqc-python-scripts/languages","stargazers_url":"https://api.github.com/repos/bdorney/vfatqc-python-scripts/stargazers","contributors_url":"https://api.github.com/repos/bdorney/vfatqc-python-scripts/contributors","subscribers_url":"https://api.github.com/repos/bdorney/vfatqc-python-scripts/subscribers","subscription_url":"https://api.github.com/repos/bdorney/vfatqc-python-scripts/subscription","commits_url":"https://api.github.com/repos/bdorney/vfatqc-python-scripts/commits{/sha}","git_commits_url":"https://api.github.com/repos/bdorney/vfatqc-python-scripts/git/commits{/sha}","comments_url":"https://api.github.com/repos/bdorney/vfatqc-python-scripts/comments{/number}","issue_comment_url":"https://api.github.com/repos/bdorney/vfatqc-python-scripts/issues/comments{/number}","contents_url":"https://api.github.com/repos/bdorney/vfatqc-python-scripts/contents/{+path}","compare_url":"https://api.github.com/repos/bdorney/vfatqc-python-scripts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bdorney/vfatqc-python-scripts/merges","archive_url":"https://api.github.com/repos/bdorney/vfatqc-python-scripts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bdorney/vfatqc-python-scripts/downloads","issues_url":"https://api.github.com/repos/bdorney/vfatqc-python-scripts/issues{/number}","pulls_url":"https://api.github.com/repos/bdorney/vfatqc-python-scripts/pulls{/number}","milestones_url":"https://api.github.com/repos/bdorney/vfatqc-python-scripts/milestones{/number}","notifications_url":"https://api.github.com/repos/bdorney/vfatqc-python-scripts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bdorney/vfatqc-python-scripts/labels{/name}","releases_url":"https://api.github.com/repos/bdorney/vfatqc-python-scripts/releases{/id}","deployments_url":"https://api.github.com/repos/bdorney/vfatqc-python-scripts/deployments","created_at":"2016-11-11T18:16:19Z","updated_at":"2016-11-11T18:16:25Z","pushed_at":"2018-03-09T15:38:25Z","git_url":"git://github.com/bdorney/vfatqc-python-scripts.git","ssh_url":"git@github.com:bdorney/vfatqc-python-scripts.git","clone_url":"https://github.com/bdorney/vfatqc-python-scripts.git","svn_url":"https://github.com/bdorney/vfatqc-python-scripts","homepage":null,"size":22882,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cms-gem-daq-project:rpc-playground","ref":"rpc-playground","sha":"54fb5f696751215b25079599f2dc761b6ec54154","user":{"login":"cms-gem-daq-project","id":9051054,"avatar_url":"https://avatars0.githubusercontent.com/u/9051054?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-gem-daq-project","html_url":"https://github.com/cms-gem-daq-project","followers_url":"https://api.github.com/users/cms-gem-daq-project/followers","following_url":"https://api.github.com/users/cms-gem-daq-project/following{/other_user}","gists_url":"https://api.github.com/users/cms-gem-daq-project/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-gem-daq-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-gem-daq-project/subscriptions","organizations_url":"https://api.github.com/users/cms-gem-daq-project/orgs","repos_url":"https://api.github.com/users/cms-gem-daq-project/repos","events_url":"https://api.github.com/users/cms-gem-daq-project/events{/privacy}","received_events_url":"https://api.github.com/users/cms-gem-daq-project/received_events","type":"Organization","site_admin":false},"repo":{"id":58535542,"name":"vfatqc-python-scripts","full_name":"cms-gem-daq-project/vfatqc-python-scripts","owner":{"login":"cms-gem-daq-project","id":9051054,"avatar_url":"https://avatars0.githubusercontent.com/u/9051054?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-gem-daq-project","html_url":"https://github.com/cms-gem-daq-project","followers_url":"https://api.github.com/users/cms-gem-daq-project/followers","following_url":"https://api.github.com/users/cms-gem-daq-project/following{/other_user}","gists_url":"https://api.github.com/users/cms-gem-daq-project/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-gem-daq-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-gem-daq-project/subscriptions","organizations_url":"https://api.github.com/users/cms-gem-daq-project/orgs","repos_url":"https://api.github.com/users/cms-gem-daq-project/repos","events_url":"https://api.github.com/users/cms-gem-daq-project/events{/privacy}","received_events_url":"https://api.github.com/users/cms-gem-daq-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-gem-daq-project/vfatqc-python-scripts","description":null,"fork":false,"url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts","forks_url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/forks","keys_url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/teams","hooks_url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/hooks","issue_events_url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/issues/events{/number}","events_url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/events","assignees_url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/assignees{/user}","branches_url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/branches{/branch}","tags_url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/tags","blobs_url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/languages","stargazers_url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/stargazers","contributors_url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/contributors","subscribers_url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/subscribers","subscription_url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/subscription","commits_url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/contents/{+path}","compare_url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/merges","archive_url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/downloads","issues_url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/issues{/number}","pulls_url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/labels{/name}","releases_url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/releases{/id}","deployments_url":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/deployments","created_at":"2016-05-11T10:27:58Z","updated_at":"2017-07-10T12:48:27Z","pushed_at":"2018-03-09T15:42:40Z","git_url":"git://github.com/cms-gem-daq-project/vfatqc-python-scripts.git","ssh_url":"git@github.com:cms-gem-daq-project/vfatqc-python-scripts.git","clone_url":"https://github.com/cms-gem-daq-project/vfatqc-python-scripts.git","svn_url":"https://github.com/cms-gem-daq-project/vfatqc-python-scripts","homepage":null,"size":22865,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":10,"license":null,"forks":12,"open_issues":10,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/pulls/159"},"html":{"href":"https://github.com/cms-gem-daq-project/vfatqc-python-scripts/pull/159"},"issue":{"href":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/issues/159"},"comments":{"href":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/issues/159/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/pulls/159/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/pulls/159/commits"},"statuses":{"href":"https://api.github.com/repos/cms-gem-daq-project/vfatqc-python-scripts/statuses/cba8388b62bf784da27be447744c0014535cb124"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"bdorney","id":6432141,"avatar_url":"https://avatars0.githubusercontent.com/u/6432141?v=4","gravatar_id":"","url":"https://api.github.com/users/bdorney","html_url":"https://github.com/bdorney","followers_url":"https://api.github.com/users/bdorney/followers","following_url":"https://api.github.com/users/bdorney/following{/other_user}","gists_url":"https://api.github.com/users/bdorney/gists{/gist_id}","starred_url":"https://api.github.com/users/bdorney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdorney/subscriptions","organizations_url":"https://api.github.com/users/bdorney/orgs","repos_url":"https://api.github.com/users/bdorney/repos","events_url":"https://api.github.com/users/bdorney/events{/privacy}","received_events_url":"https://api.github.com/users/bdorney/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":6,"additions":32,"deletions":18,"changed_files":2}}
{"actor":{"display_login":"bdorney"}}