{"action":"closed","number":132,"pull_request":{"url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/pulls/132","id":182391857,"html_url":"https://github.com/DEFRA/waste-carriers-renewals/pull/132","diff_url":"https://github.com/DEFRA/waste-carriers-renewals/pull/132.diff","patch_url":"https://github.com/DEFRA/waste-carriers-renewals/pull/132.patch","issue_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/issues/132","number":132,"state":"closed","locked":false,"title":" Checks for can_renew include expires_on","user":{"login":"irisfaraway","id":13369917,"avatar_url":"https://avatars2.githubusercontent.com/u/13369917?v=4","gravatar_id":"","url":"https://api.github.com/users/irisfaraway","html_url":"https://github.com/irisfaraway","followers_url":"https://api.github.com/users/irisfaraway/followers","following_url":"https://api.github.com/users/irisfaraway/following{/other_user}","gists_url":"https://api.github.com/users/irisfaraway/gists{/gist_id}","starred_url":"https://api.github.com/users/irisfaraway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irisfaraway/subscriptions","organizations_url":"https://api.github.com/users/irisfaraway/orgs","repos_url":"https://api.github.com/users/irisfaraway/repos","events_url":"https://api.github.com/users/irisfaraway/events{/privacy}","received_events_url":"https://api.github.com/users/irisfaraway/received_events","type":"User","site_admin":false},"body":"https://eaflood.atlassian.net/browse/WC-185\r\n\r\nCurrently there will be a brief window when a registration is officially EXPIRED but it is still recorded as ACTIVE in the service. This is due to the timing of when the job that marks expired registrations is run.\r\n\r\nTo avoid any issues with someone renewing before the expiry job runs, we should make sure that a registration cannot be renewed if the current date is equal to or after the expires_on date.","created_at":"2018-04-18T07:38:37Z","updated_at":"2018-04-23T08:43:24Z","closed_at":"2018-04-23T08:43:24Z","merged_at":"2018-04-23T08:43:24Z","merge_commit_sha":"b4adf6a451aaa2847afffc3a0b0af6a552010e42","assignee":{"login":"irisfaraway","id":13369917,"avatar_url":"https://avatars2.githubusercontent.com/u/13369917?v=4","gravatar_id":"","url":"https://api.github.com/users/irisfaraway","html_url":"https://github.com/irisfaraway","followers_url":"https://api.github.com/users/irisfaraway/followers","following_url":"https://api.github.com/users/irisfaraway/following{/other_user}","gists_url":"https://api.github.com/users/irisfaraway/gists{/gist_id}","starred_url":"https://api.github.com/users/irisfaraway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irisfaraway/subscriptions","organizations_url":"https://api.github.com/users/irisfaraway/orgs","repos_url":"https://api.github.com/users/irisfaraway/repos","events_url":"https://api.github.com/users/irisfaraway/events{/privacy}","received_events_url":"https://api.github.com/users/irisfaraway/received_events","type":"User","site_admin":false},"assignees":[{"login":"irisfaraway","id":13369917,"avatar_url":"https://avatars2.githubusercontent.com/u/13369917?v=4","gravatar_id":"","url":"https://api.github.com/users/irisfaraway","html_url":"https://github.com/irisfaraway","followers_url":"https://api.github.com/users/irisfaraway/followers","following_url":"https://api.github.com/users/irisfaraway/following{/other_user}","gists_url":"https://api.github.com/users/irisfaraway/gists{/gist_id}","starred_url":"https://api.github.com/users/irisfaraway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irisfaraway/subscriptions","organizations_url":"https://api.github.com/users/irisfaraway/orgs","repos_url":"https://api.github.com/users/irisfaraway/repos","events_url":"https://api.github.com/users/irisfaraway/events{/privacy}","received_events_url":"https://api.github.com/users/irisfaraway/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/pulls/132/commits","review_comments_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/pulls/132/comments","review_comment_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/issues/132/comments","statuses_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/statuses/43de734fa310e1d35b1e694d834094abb6b04f44","head":{"label":"DEFRA:feature/renewal-checks-expires-on","ref":"feature/renewal-checks-expires-on","sha":"43de734fa310e1d35b1e694d834094abb6b04f44","user":{"login":"DEFRA","id":5528822,"avatar_url":"https://avatars2.githubusercontent.com/u/5528822?v=4","gravatar_id":"","url":"https://api.github.com/users/DEFRA","html_url":"https://github.com/DEFRA","followers_url":"https://api.github.com/users/DEFRA/followers","following_url":"https://api.github.com/users/DEFRA/following{/other_user}","gists_url":"https://api.github.com/users/DEFRA/gists{/gist_id}","starred_url":"https://api.github.com/users/DEFRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DEFRA/subscriptions","organizations_url":"https://api.github.com/users/DEFRA/orgs","repos_url":"https://api.github.com/users/DEFRA/repos","events_url":"https://api.github.com/users/DEFRA/events{/privacy}","received_events_url":"https://api.github.com/users/DEFRA/received_events","type":"Organization","site_admin":false},"repo":{"id":111112709,"name":"waste-carriers-renewals","full_name":"DEFRA/waste-carriers-renewals","owner":{"login":"DEFRA","id":5528822,"avatar_url":"https://avatars2.githubusercontent.com/u/5528822?v=4","gravatar_id":"","url":"https://api.github.com/users/DEFRA","html_url":"https://github.com/DEFRA","followers_url":"https://api.github.com/users/DEFRA/followers","following_url":"https://api.github.com/users/DEFRA/following{/other_user}","gists_url":"https://api.github.com/users/DEFRA/gists{/gist_id}","starred_url":"https://api.github.com/users/DEFRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DEFRA/subscriptions","organizations_url":"https://api.github.com/users/DEFRA/orgs","repos_url":"https://api.github.com/users/DEFRA/repos","events_url":"https://api.github.com/users/DEFRA/events{/privacy}","received_events_url":"https://api.github.com/users/DEFRA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DEFRA/waste-carriers-renewals","description":"The renewals service for the Waste carriers digital service","fork":false,"url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals","forks_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/forks","keys_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/teams","hooks_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/hooks","issue_events_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/issues/events{/number}","events_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/events","assignees_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/assignees{/user}","branches_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/branches{/branch}","tags_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/tags","blobs_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/git/refs{/sha}","trees_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/statuses/{sha}","languages_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/languages","stargazers_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/stargazers","contributors_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/contributors","subscribers_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/subscribers","subscription_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/subscription","commits_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/commits{/sha}","git_commits_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/git/commits{/sha}","comments_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/comments{/number}","issue_comment_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/issues/comments{/number}","contents_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/contents/{+path}","compare_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/merges","archive_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/downloads","issues_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/issues{/number}","pulls_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/pulls{/number}","milestones_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/milestones{/number}","notifications_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/labels{/name}","releases_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/releases{/id}","deployments_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/deployments","created_at":"2017-11-17T14:29:21Z","updated_at":"2018-04-20T14:23:37Z","pushed_at":"2018-04-23T08:43:24Z","git_url":"git://github.com/DEFRA/waste-carriers-renewals.git","ssh_url":"git@github.com:DEFRA/waste-carriers-renewals.git","clone_url":"https://github.com/DEFRA/waste-carriers-renewals.git","svn_url":"https://github.com/DEFRA/waste-carriers-renewals","homepage":null,"size":541,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"DEFRA:master","ref":"master","sha":"7c958e0544cba0978284e624e4a1e70c48dc3287","user":{"login":"DEFRA","id":5528822,"avatar_url":"https://avatars2.githubusercontent.com/u/5528822?v=4","gravatar_id":"","url":"https://api.github.com/users/DEFRA","html_url":"https://github.com/DEFRA","followers_url":"https://api.github.com/users/DEFRA/followers","following_url":"https://api.github.com/users/DEFRA/following{/other_user}","gists_url":"https://api.github.com/users/DEFRA/gists{/gist_id}","starred_url":"https://api.github.com/users/DEFRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DEFRA/subscriptions","organizations_url":"https://api.github.com/users/DEFRA/orgs","repos_url":"https://api.github.com/users/DEFRA/repos","events_url":"https://api.github.com/users/DEFRA/events{/privacy}","received_events_url":"https://api.github.com/users/DEFRA/received_events","type":"Organization","site_admin":false},"repo":{"id":111112709,"name":"waste-carriers-renewals","full_name":"DEFRA/waste-carriers-renewals","owner":{"login":"DEFRA","id":5528822,"avatar_url":"https://avatars2.githubusercontent.com/u/5528822?v=4","gravatar_id":"","url":"https://api.github.com/users/DEFRA","html_url":"https://github.com/DEFRA","followers_url":"https://api.github.com/users/DEFRA/followers","following_url":"https://api.github.com/users/DEFRA/following{/other_user}","gists_url":"https://api.github.com/users/DEFRA/gists{/gist_id}","starred_url":"https://api.github.com/users/DEFRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DEFRA/subscriptions","organizations_url":"https://api.github.com/users/DEFRA/orgs","repos_url":"https://api.github.com/users/DEFRA/repos","events_url":"https://api.github.com/users/DEFRA/events{/privacy}","received_events_url":"https://api.github.com/users/DEFRA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DEFRA/waste-carriers-renewals","description":"The renewals service for the Waste carriers digital service","fork":false,"url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals","forks_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/forks","keys_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/teams","hooks_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/hooks","issue_events_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/issues/events{/number}","events_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/events","assignees_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/assignees{/user}","branches_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/branches{/branch}","tags_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/tags","blobs_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/git/refs{/sha}","trees_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/statuses/{sha}","languages_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/languages","stargazers_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/stargazers","contributors_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/contributors","subscribers_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/subscribers","subscription_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/subscription","commits_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/commits{/sha}","git_commits_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/git/commits{/sha}","comments_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/comments{/number}","issue_comment_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/issues/comments{/number}","contents_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/contents/{+path}","compare_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/merges","archive_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/downloads","issues_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/issues{/number}","pulls_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/pulls{/number}","milestones_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/milestones{/number}","notifications_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/labels{/name}","releases_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/releases{/id}","deployments_url":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/deployments","created_at":"2017-11-17T14:29:21Z","updated_at":"2018-04-20T14:23:37Z","pushed_at":"2018-04-23T08:43:24Z","git_url":"git://github.com/DEFRA/waste-carriers-renewals.git","ssh_url":"git@github.com:DEFRA/waste-carriers-renewals.git","clone_url":"https://github.com/DEFRA/waste-carriers-renewals.git","svn_url":"https://github.com/DEFRA/waste-carriers-renewals","homepage":null,"size":541,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/pulls/132"},"html":{"href":"https://github.com/DEFRA/waste-carriers-renewals/pull/132"},"issue":{"href":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/issues/132"},"comments":{"href":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/issues/132/comments"},"review_comments":{"href":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/pulls/132/comments"},"review_comment":{"href":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/pulls/132/commits"},"statuses":{"href":"https://api.github.com/repos/DEFRA/waste-carriers-renewals/statuses/43de734fa310e1d35b1e694d834094abb6b04f44"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"irisfaraway","id":13369917,"avatar_url":"https://avatars2.githubusercontent.com/u/13369917?v=4","gravatar_id":"","url":"https://api.github.com/users/irisfaraway","html_url":"https://github.com/irisfaraway","followers_url":"https://api.github.com/users/irisfaraway/followers","following_url":"https://api.github.com/users/irisfaraway/following{/other_user}","gists_url":"https://api.github.com/users/irisfaraway/gists{/gist_id}","starred_url":"https://api.github.com/users/irisfaraway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irisfaraway/subscriptions","organizations_url":"https://api.github.com/users/irisfaraway/orgs","repos_url":"https://api.github.com/users/irisfaraway/repos","events_url":"https://api.github.com/users/irisfaraway/events{/privacy}","received_events_url":"https://api.github.com/users/irisfaraway/received_events","type":"User","site_admin":false},"comments":1,"review_comments":5,"maintainer_can_modify":false,"commits":13,"additions":141,"deletions":16,"changed_files":9}}
{"actor":{"display_login":"irisfaraway"}}