{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/msphpsql/issues/789","repository_url":"https://api.github.com/repos/Microsoft/msphpsql","labels_url":"https://api.github.com/repos/Microsoft/msphpsql/issues/789/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/msphpsql/issues/789/comments","events_url":"https://api.github.com/repos/Microsoft/msphpsql/issues/789/events","html_url":"https://github.com/Microsoft/msphpsql/pull/789","id":330017768,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMTI5MDMz","number":789,"title":"Use SQLSRV_ASSERT for checking NULL ptrs","user":{"login":"yitam","id":21340756,"node_id":"MDQ6VXNlcjIxMzQwNzU2","avatar_url":"https://avatars1.githubusercontent.com/u/21340756?v=4","gravatar_id":"","url":"https://api.github.com/users/yitam","html_url":"https://github.com/yitam","followers_url":"https://api.github.com/users/yitam/followers","following_url":"https://api.github.com/users/yitam/following{/other_user}","gists_url":"https://api.github.com/users/yitam/gists{/gist_id}","starred_url":"https://api.github.com/users/yitam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yitam/subscriptions","organizations_url":"https://api.github.com/users/yitam/orgs","repos_url":"https://api.github.com/users/yitam/repos","events_url":"https://api.github.com/users/yitam/events{/privacy}","received_events_url":"https://api.github.com/users/yitam/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-06T20:20:15Z","updated_at":"2018-06-06T20:44:55Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/Microsoft/msphpsql/pulls/789","html_url":"https://github.com/Microsoft/msphpsql/pull/789","diff_url":"https://github.com/Microsoft/msphpsql/pull/789.diff","patch_url":"https://github.com/Microsoft/msphpsql/pull/789.patch"},"body":"Use SQLSRV_ASSERT to ensure the subsequent code will not dereference any null pointers (Clang Analyzer reports)\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/microsoft/msphpsql/789)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/Microsoft/msphpsql/issues/comments/395207696","html_url":"https://github.com/Microsoft/msphpsql/pull/789#issuecomment-395207696","issue_url":"https://api.github.com/repos/Microsoft/msphpsql/issues/789","id":395207696,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NTIwNzY5Ng==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-06-06T20:44:55Z","updated_at":"2018-06-06T20:44:55Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/Microsoft/msphpsql/pull/789?src=pr&el=h1) Report\n> Merging [#789](https://codecov.io/gh/Microsoft/msphpsql/pull/789?src=pr&el=desc) into [dev](https://codecov.io/gh/Microsoft/msphpsql/commit/3585bf5a5c5a52107d572b7533881bc005dfd5e4?src=pr&el=desc) will **increase** coverage by `<.01%`.\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/Microsoft/msphpsql/pull/789/graphs/tree.svg?width=650&height=150&token=ACXioUeEw3&src=pr)](https://codecov.io/gh/Microsoft/msphpsql/pull/789?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##              dev     #789      +/-   ##\n==========================================\n+ Coverage   80.06%   80.06%   +<.01%     \n==========================================\n  Files          25       25              \n  Lines        7323     7325       +2     \n==========================================\n+ Hits         5863     5865       +2     \n  Misses       1460     1460\n```\n\n\n| [Impacted Files](https://codecov.io/gh/Microsoft/msphpsql/pull/789?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [.../php-7.1.18-src/ext/sqlsrv/shared/core\\_results.cpp](https://codecov.io/gh/Microsoft/msphpsql/pull/789/diff?src=pr&el=tree#diff-cHJvamVjdHMvcGhwLXNkay9waHBkZXYvdmMxNC94ODYvcGhwLTcuMS4xOC1zcmMvZXh0L3NxbHNydi9zaGFyZWQvY29yZV9yZXN1bHRzLmNwcA==) | `74.22% <0%> (+0.04%)` | :arrow_up: |\n| [...-7.1.18-src/ext/pdo\\_sqlsrv/shared/core\\_results.cpp](https://codecov.io/gh/Microsoft/msphpsql/pull/789/diff?src=pr&el=tree#diff-cHJvamVjdHMvcGhwLXNkay9waHBkZXYvdmMxNC94ODYvcGhwLTcuMS4xOC1zcmMvZXh0L3Bkb19zcWxzcnYvc2hhcmVkL2NvcmVfcmVzdWx0cy5jcHA=) | `59.96% <0%> (+0.07%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/Microsoft/msphpsql/pull/789?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/Microsoft/msphpsql/pull/789?src=pr&el=footer). Last update [3585bf5...44d1bb3](https://codecov.io/gh/Microsoft/msphpsql/pull/789?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}