{"action":"created","comment":{"url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/pulls/comments/239538792","pull_request_review_id":182351708,"id":239538792,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTUzODc5Mg==","diff_hunk":"@@ -53,9 +53,9 @@ Currently, the best method for debugging Excel custom functions is to first [sid\n \n If your add-in fails to register, [verify that SSL certificates are correctly configured](https://github.com/OfficeDev/generator-office/blob/master/src/docs/ssl.md) for the web server that's hosting your add-in application.\n \n-## Mapping function names to JSON metadata\n+## Associating function names with JSON metadata\n \n-As described in the [custom functions overview](custom-functions-overview.md) article, a custom functions project must include a JSON metadata file which provides the information that Excel requires to register the custom functions and make them available to end users. Additionally, within the JavaScript file that defines your custom functions, you must provide information to specify which function object in the JSON metadata file corresponds to each custom function in the JavaScript file.\n+As described in the [custom functions overview](custom-functions-overview.md) article, a custom functions project must include a JSON metadata file which provides the information that Excel requires to register the custom functions and make them available to end users. Additionally, within the JavaScript file that defines your custom functions, you must provide information to specify which function object in the JSON metadata file corresponds to each custom function in the JavaScript file. The process of tying these two together is called \"associating.\"\n \n For example, the following code sample defines the custom function `add` and then specifies that the function `add` corresponds to the object in the JSON metadata file where the value of the `id` property is **ADD**.","path":"docs/excel/custom-functions-best-practices.md","position":10,"original_position":10,"commit_id":"dac6e2f9b700530610bfcfca72964db987a3c340","original_commit_id":"dac6e2f9b700530610bfcfca72964db987a3c340","user":{"login":"AlexJerabek","id":38896772,"node_id":"MDQ6VXNlcjM4ODk2Nzcy","avatar_url":"https://avatars3.githubusercontent.com/u/38896772?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexJerabek","html_url":"https://github.com/AlexJerabek","followers_url":"https://api.github.com/users/AlexJerabek/followers","following_url":"https://api.github.com/users/AlexJerabek/following{/other_user}","gists_url":"https://api.github.com/users/AlexJerabek/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexJerabek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexJerabek/subscriptions","organizations_url":"https://api.github.com/users/AlexJerabek/orgs","repos_url":"https://api.github.com/users/AlexJerabek/repos","events_url":"https://api.github.com/users/AlexJerabek/events{/privacy}","received_events_url":"https://api.github.com/users/AlexJerabek/received_events","type":"User","site_admin":false},"body":"Since you've established what associating means, you could simplify this text by using it.","created_at":"2018-12-06T17:15:59Z","updated_at":"2018-12-06T17:17:39Z","html_url":"https://github.com/OfficeDev/office-js-docs-pr/pull/602#discussion_r239538792","pull_request_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/pulls/602","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/pulls/comments/239538792"},"html":{"href":"https://github.com/OfficeDev/office-js-docs-pr/pull/602#discussion_r239538792"},"pull_request":{"href":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/pulls/602"}}},"pull_request":{"url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/pulls/602","id":236380420,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MzgwNDIw","html_url":"https://github.com/OfficeDev/office-js-docs-pr/pull/602","diff_url":"https://github.com/OfficeDev/office-js-docs-pr/pull/602.diff","patch_url":"https://github.com/OfficeDev/office-js-docs-pr/pull/602.patch","issue_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/issues/602","number":602,"state":"open","locked":false,"title":"[Excel] (Custom Functions) CustomFunctions.Associate() changes","user":{"login":"mscharlock","id":26179395,"node_id":"MDQ6VXNlcjI2MTc5Mzk1","avatar_url":"https://avatars1.githubusercontent.com/u/26179395?v=4","gravatar_id":"","url":"https://api.github.com/users/mscharlock","html_url":"https://github.com/mscharlock","followers_url":"https://api.github.com/users/mscharlock/followers","following_url":"https://api.github.com/users/mscharlock/following{/other_user}","gists_url":"https://api.github.com/users/mscharlock/gists{/gist_id}","starred_url":"https://api.github.com/users/mscharlock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mscharlock/subscriptions","organizations_url":"https://api.github.com/users/mscharlock/orgs","repos_url":"https://api.github.com/users/mscharlock/repos","events_url":"https://api.github.com/users/mscharlock/events{/privacy}","received_events_url":"https://api.github.com/users/mscharlock/received_events","type":"User","site_admin":false},"body":"CustomFunctions.Mapping() has now become CustomFunctions.Associate() in the 12/10 fork. ","created_at":"2018-12-06T01:36:53Z","updated_at":"2018-12-06T17:17:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"55964738f55d18e0d0cad2d73ce88f854b894737","assignee":null,"assignees":[],"requested_reviewers":[{"login":"davidchesnut","id":8559338,"node_id":"MDQ6VXNlcjg1NTkzMzg=","avatar_url":"https://avatars0.githubusercontent.com/u/8559338?v=4","gravatar_id":"","url":"https://api.github.com/users/davidchesnut","html_url":"https://github.com/davidchesnut","followers_url":"https://api.github.com/users/davidchesnut/followers","following_url":"https://api.github.com/users/davidchesnut/following{/other_user}","gists_url":"https://api.github.com/users/davidchesnut/gists{/gist_id}","starred_url":"https://api.github.com/users/davidchesnut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidchesnut/subscriptions","organizations_url":"https://api.github.com/users/davidchesnut/orgs","repos_url":"https://api.github.com/users/davidchesnut/repos","events_url":"https://api.github.com/users/davidchesnut/events{/privacy}","received_events_url":"https://api.github.com/users/davidchesnut/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1006208750,"node_id":"MDU6TGFiZWwxMDA2MjA4NzUw","url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/labels/hold:%20do-not-merge","name":"hold: do-not-merge","color":"b60205","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/pulls/602/commits","review_comments_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/pulls/602/comments","review_comment_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/issues/602/comments","statuses_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/statuses/dac6e2f9b700530610bfcfca72964db987a3c340","head":{"label":"OfficeDev:michelle-cfmaptoassociate","ref":"michelle-cfmaptoassociate","sha":"dac6e2f9b700530610bfcfca72964db987a3c340","user":{"login":"OfficeDev","id":6789362,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3ODkzNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6789362?v=4","gravatar_id":"","url":"https://api.github.com/users/OfficeDev","html_url":"https://github.com/OfficeDev","followers_url":"https://api.github.com/users/OfficeDev/followers","following_url":"https://api.github.com/users/OfficeDev/following{/other_user}","gists_url":"https://api.github.com/users/OfficeDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OfficeDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfficeDev/subscriptions","organizations_url":"https://api.github.com/users/OfficeDev/orgs","repos_url":"https://api.github.com/users/OfficeDev/repos","events_url":"https://api.github.com/users/OfficeDev/events{/privacy}","received_events_url":"https://api.github.com/users/OfficeDev/received_events","type":"Organization","site_admin":false},"repo":{"id":109723362,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk3MjMzNjI=","name":"office-js-docs-pr","full_name":"OfficeDev/office-js-docs-pr","private":false,"owner":{"login":"OfficeDev","id":6789362,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3ODkzNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6789362?v=4","gravatar_id":"","url":"https://api.github.com/users/OfficeDev","html_url":"https://github.com/OfficeDev","followers_url":"https://api.github.com/users/OfficeDev/followers","following_url":"https://api.github.com/users/OfficeDev/following{/other_user}","gists_url":"https://api.github.com/users/OfficeDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OfficeDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfficeDev/subscriptions","organizations_url":"https://api.github.com/users/OfficeDev/orgs","repos_url":"https://api.github.com/users/OfficeDev/repos","events_url":"https://api.github.com/users/OfficeDev/events{/privacy}","received_events_url":"https://api.github.com/users/OfficeDev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OfficeDev/office-js-docs-pr","description":"Microsoft Office Add-ins Documentation","fork":false,"url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr","forks_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/forks","keys_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/teams","hooks_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/hooks","issue_events_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/issues/events{/number}","events_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/events","assignees_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/assignees{/user}","branches_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/branches{/branch}","tags_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/tags","blobs_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/git/refs{/sha}","trees_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/statuses/{sha}","languages_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/languages","stargazers_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/stargazers","contributors_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/contributors","subscribers_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/subscribers","subscription_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/subscription","commits_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/commits{/sha}","git_commits_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/git/commits{/sha}","comments_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/comments{/number}","issue_comment_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/issues/comments{/number}","contents_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/contents/{+path}","compare_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/merges","archive_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/downloads","issues_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/issues{/number}","pulls_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/pulls{/number}","milestones_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/milestones{/number}","notifications_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/labels{/name}","releases_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/releases{/id}","deployments_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/deployments","created_at":"2017-11-06T16:53:41Z","updated_at":"2018-12-06T06:18:44Z","pushed_at":"2018-12-06T02:01:00Z","git_url":"git://github.com/OfficeDev/office-js-docs-pr.git","ssh_url":"git@github.com:OfficeDev/office-js-docs-pr.git","clone_url":"https://github.com/OfficeDev/office-js-docs-pr.git","svn_url":"https://github.com/OfficeDev/office-js-docs-pr","homepage":"https://docs.microsoft.com/en-us/office/dev/add-ins","size":40993,"stargazers_count":177,"watchers_count":177,"language":"PowerShell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":78,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":78,"open_issues":10,"watchers":177,"default_branch":"master"}},"base":{"label":"OfficeDev:master","ref":"master","sha":"d20fd994b50607ef2dc0fbea41f5c18b1c2d5fdb","user":{"login":"OfficeDev","id":6789362,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3ODkzNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6789362?v=4","gravatar_id":"","url":"https://api.github.com/users/OfficeDev","html_url":"https://github.com/OfficeDev","followers_url":"https://api.github.com/users/OfficeDev/followers","following_url":"https://api.github.com/users/OfficeDev/following{/other_user}","gists_url":"https://api.github.com/users/OfficeDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OfficeDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfficeDev/subscriptions","organizations_url":"https://api.github.com/users/OfficeDev/orgs","repos_url":"https://api.github.com/users/OfficeDev/repos","events_url":"https://api.github.com/users/OfficeDev/events{/privacy}","received_events_url":"https://api.github.com/users/OfficeDev/received_events","type":"Organization","site_admin":false},"repo":{"id":109723362,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk3MjMzNjI=","name":"office-js-docs-pr","full_name":"OfficeDev/office-js-docs-pr","private":false,"owner":{"login":"OfficeDev","id":6789362,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3ODkzNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6789362?v=4","gravatar_id":"","url":"https://api.github.com/users/OfficeDev","html_url":"https://github.com/OfficeDev","followers_url":"https://api.github.com/users/OfficeDev/followers","following_url":"https://api.github.com/users/OfficeDev/following{/other_user}","gists_url":"https://api.github.com/users/OfficeDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OfficeDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfficeDev/subscriptions","organizations_url":"https://api.github.com/users/OfficeDev/orgs","repos_url":"https://api.github.com/users/OfficeDev/repos","events_url":"https://api.github.com/users/OfficeDev/events{/privacy}","received_events_url":"https://api.github.com/users/OfficeDev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OfficeDev/office-js-docs-pr","description":"Microsoft Office Add-ins Documentation","fork":false,"url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr","forks_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/forks","keys_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/teams","hooks_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/hooks","issue_events_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/issues/events{/number}","events_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/events","assignees_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/assignees{/user}","branches_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/branches{/branch}","tags_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/tags","blobs_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/git/refs{/sha}","trees_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/statuses/{sha}","languages_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/languages","stargazers_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/stargazers","contributors_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/contributors","subscribers_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/subscribers","subscription_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/subscription","commits_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/commits{/sha}","git_commits_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/git/commits{/sha}","comments_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/comments{/number}","issue_comment_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/issues/comments{/number}","contents_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/contents/{+path}","compare_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/merges","archive_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/downloads","issues_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/issues{/number}","pulls_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/pulls{/number}","milestones_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/milestones{/number}","notifications_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/labels{/name}","releases_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/releases{/id}","deployments_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/deployments","created_at":"2017-11-06T16:53:41Z","updated_at":"2018-12-06T06:18:44Z","pushed_at":"2018-12-06T02:01:00Z","git_url":"git://github.com/OfficeDev/office-js-docs-pr.git","ssh_url":"git@github.com:OfficeDev/office-js-docs-pr.git","clone_url":"https://github.com/OfficeDev/office-js-docs-pr.git","svn_url":"https://github.com/OfficeDev/office-js-docs-pr","homepage":"https://docs.microsoft.com/en-us/office/dev/add-ins","size":40993,"stargazers_count":177,"watchers_count":177,"language":"PowerShell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":78,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":78,"open_issues":10,"watchers":177,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/pulls/602"},"html":{"href":"https://github.com/OfficeDev/office-js-docs-pr/pull/602"},"issue":{"href":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/issues/602"},"comments":{"href":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/issues/602/comments"},"review_comments":{"href":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/pulls/602/comments"},"review_comment":{"href":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/pulls/602/commits"},"statuses":{"href":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/statuses/dac6e2f9b700530610bfcfca72964db987a3c340"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"AlexJerabek"}}