{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/20551","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/20551/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/20551/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/20551/events","html_url":"https://github.com/nodejs/node/pull/20551","id":320550723,"number":20551,"title":"fs: refactor promises version of lchown and lchmod","user":{"login":"cjihrig","id":2512748,"avatar_url":"https://avatars1.githubusercontent.com/u/2512748?v=4","gravatar_id":"","url":"https://api.github.com/users/cjihrig","html_url":"https://github.com/cjihrig","followers_url":"https://api.github.com/users/cjihrig/followers","following_url":"https://api.github.com/users/cjihrig/following{/other_user}","gists_url":"https://api.github.com/users/cjihrig/gists{/gist_id}","starred_url":"https://api.github.com/users/cjihrig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjihrig/subscriptions","organizations_url":"https://api.github.com/users/cjihrig/orgs","repos_url":"https://api.github.com/users/cjihrig/repos","events_url":"https://api.github.com/users/cjihrig/events{/privacy}","received_events_url":"https://api.github.com/users/cjihrig/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-06T00:02:55Z","updated_at":"2018-05-06T00:53:59Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/20551","html_url":"https://github.com/nodejs/node/pull/20551","diff_url":"https://github.com/nodejs/node/pull/20551.diff","patch_url":"https://github.com/nodejs/node/pull/20551.patch"},"body":"Check for platform support first to save a level of indentation. This is just a style thing, but it simplifies the code a bit IMO.\r\n\r\nIn case anyone points it out in the diff, `lchown()` is currently calling `fchmod()` (incorrectly). I didn't update it because @ChALkeR has a fix for it in #20407.\r\n\r\n##### Checklist\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/386845614","html_url":"https://github.com/nodejs/node/pull/20551#issuecomment-386845614","issue_url":"https://api.github.com/repos/nodejs/node/issues/20551","id":386845614,"user":{"login":"mscdex","id":54666,"avatar_url":"https://avatars0.githubusercontent.com/u/54666?v=4","gravatar_id":"","url":"https://api.github.com/users/mscdex","html_url":"https://github.com/mscdex","followers_url":"https://api.github.com/users/mscdex/followers","following_url":"https://api.github.com/users/mscdex/following{/other_user}","gists_url":"https://api.github.com/users/mscdex/gists{/gist_id}","starred_url":"https://api.github.com/users/mscdex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mscdex/subscriptions","organizations_url":"https://api.github.com/users/mscdex/orgs","repos_url":"https://api.github.com/users/mscdex/repos","events_url":"https://api.github.com/users/mscdex/events{/privacy}","received_events_url":"https://api.github.com/users/mscdex/received_events","type":"User","site_admin":false},"created_at":"2018-05-06T00:53:59Z","updated_at":"2018-05-06T00:53:59Z","author_association":"CONTRIBUTOR","body":"What if we just did the check during startup instead of each function call?"}}
{"actor":{"display_login":"mscdex"}}