{"action":"created","comment":{"url":"https://api.github.com/repos/RasaHQ/rasa_core/pulls/comments/244979800","pull_request_review_id":188984014,"id":244979800,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDk3OTgwMA==","diff_hunk":"@@ -56,13 +62,14 @@ def __init__(self,\n         self.current_epoch = current_epoch\n \n     def _load_params(self, **kwargs: Dict[Text, Any]) -> None:\n-        config = copy.deepcopy(self.defaults)\n-        config.update(kwargs)\n+        self.config = copy.deepcopy(dict(self.defaults, **self.tf_defaults))","path":"rasa_core/policies/keras_policy.py","position":24,"original_position":24,"commit_id":"4395cf4df5fe9f7af7c40900fb8848baa359c100","original_commit_id":"4395cf4df5fe9f7af7c40900fb8848baa359c100","user":{"login":"Ghostvv","id":4136956,"node_id":"MDQ6VXNlcjQxMzY5NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/4136956?v=4","gravatar_id":"","url":"https://api.github.com/users/Ghostvv","html_url":"https://github.com/Ghostvv","followers_url":"https://api.github.com/users/Ghostvv/followers","following_url":"https://api.github.com/users/Ghostvv/following{/other_user}","gists_url":"https://api.github.com/users/Ghostvv/gists{/gist_id}","starred_url":"https://api.github.com/users/Ghostvv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ghostvv/subscriptions","organizations_url":"https://api.github.com/users/Ghostvv/orgs","repos_url":"https://api.github.com/users/Ghostvv/repos","events_url":"https://api.github.com/users/Ghostvv/events{/privacy}","received_events_url":"https://api.github.com/users/Ghostvv/received_events","type":"User","site_admin":false},"body":"since we persist only `tf_config` now in both policies, no need for `self.` here. We needed it in previous iterations where the whole config was persisted\r\n```suggestion\r\n        config = copy.deepcopy(dict(self.defaults, **self.tf_defaults))\r\n```","created_at":"2019-01-03T12:04:15Z","updated_at":"2019-01-03T12:21:55Z","html_url":"https://github.com/RasaHQ/rasa_core/pull/1494#discussion_r244979800","pull_request_url":"https://api.github.com/repos/RasaHQ/rasa_core/pulls/1494","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/RasaHQ/rasa_core/pulls/comments/244979800"},"html":{"href":"https://github.com/RasaHQ/rasa_core/pull/1494#discussion_r244979800"},"pull_request":{"href":"https://api.github.com/repos/RasaHQ/rasa_core/pulls/1494"}}},"pull_request":{"url":"https://api.github.com/repos/RasaHQ/rasa_core/pulls/1494","id":239329416,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5MzI5NDE2","html_url":"https://github.com/RasaHQ/rasa_core/pull/1494","diff_url":"https://github.com/RasaHQ/rasa_core/pull/1494.diff","patch_url":"https://github.com/RasaHQ/rasa_core/pull/1494.patch","issue_url":"https://api.github.com/repos/RasaHQ/rasa_core/issues/1494","number":1494,"state":"open","locked":false,"title":"add tf-config paramter","user":{"login":"GaoQ1","id":15179604,"node_id":"MDQ6VXNlcjE1MTc5NjA0","avatar_url":"https://avatars3.githubusercontent.com/u/15179604?v=4","gravatar_id":"","url":"https://api.github.com/users/GaoQ1","html_url":"https://github.com/GaoQ1","followers_url":"https://api.github.com/users/GaoQ1/followers","following_url":"https://api.github.com/users/GaoQ1/following{/other_user}","gists_url":"https://api.github.com/users/GaoQ1/gists{/gist_id}","starred_url":"https://api.github.com/users/GaoQ1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GaoQ1/subscriptions","organizations_url":"https://api.github.com/users/GaoQ1/orgs","repos_url":"https://api.github.com/users/GaoQ1/repos","events_url":"https://api.github.com/users/GaoQ1/events{/privacy}","received_events_url":"https://api.github.com/users/GaoQ1/received_events","type":"User","site_admin":false},"body":"**Proposed changes**:\r\n- add tf-config parameter\r\n- fixes #1472\r\n\r\n**Status (please check what you already did)**:\r\n- [x] made PR ready for code review\r\n- [ ] added some tests for the functionality\r\n- [ ] updated the documentation\r\n- [ ] updated the changelog","created_at":"2018-12-18T00:38:03Z","updated_at":"2019-01-03T12:21:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4c328d50861dc79f1bcc52fe447d4cd830a8336","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/RasaHQ/rasa_core/pulls/1494/commits","review_comments_url":"https://api.github.com/repos/RasaHQ/rasa_core/pulls/1494/comments","review_comment_url":"https://api.github.com/repos/RasaHQ/rasa_core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RasaHQ/rasa_core/issues/1494/comments","statuses_url":"https://api.github.com/repos/RasaHQ/rasa_core/statuses/4395cf4df5fe9f7af7c40900fb8848baa359c100","head":{"label":"GaoQ1:master","ref":"master","sha":"4395cf4df5fe9f7af7c40900fb8848baa359c100","user":{"login":"GaoQ1","id":15179604,"node_id":"MDQ6VXNlcjE1MTc5NjA0","avatar_url":"https://avatars3.githubusercontent.com/u/15179604?v=4","gravatar_id":"","url":"https://api.github.com/users/GaoQ1","html_url":"https://github.com/GaoQ1","followers_url":"https://api.github.com/users/GaoQ1/followers","following_url":"https://api.github.com/users/GaoQ1/following{/other_user}","gists_url":"https://api.github.com/users/GaoQ1/gists{/gist_id}","starred_url":"https://api.github.com/users/GaoQ1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GaoQ1/subscriptions","organizations_url":"https://api.github.com/users/GaoQ1/orgs","repos_url":"https://api.github.com/users/GaoQ1/repos","events_url":"https://api.github.com/users/GaoQ1/events{/privacy}","received_events_url":"https://api.github.com/users/GaoQ1/received_events","type":"User","site_admin":false},"repo":{"id":162207278,"node_id":"MDEwOlJlcG9zaXRvcnkxNjIyMDcyNzg=","name":"rasa_core","full_name":"GaoQ1/rasa_core","private":false,"owner":{"login":"GaoQ1","id":15179604,"node_id":"MDQ6VXNlcjE1MTc5NjA0","avatar_url":"https://avatars3.githubusercontent.com/u/15179604?v=4","gravatar_id":"","url":"https://api.github.com/users/GaoQ1","html_url":"https://github.com/GaoQ1","followers_url":"https://api.github.com/users/GaoQ1/followers","following_url":"https://api.github.com/users/GaoQ1/following{/other_user}","gists_url":"https://api.github.com/users/GaoQ1/gists{/gist_id}","starred_url":"https://api.github.com/users/GaoQ1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GaoQ1/subscriptions","organizations_url":"https://api.github.com/users/GaoQ1/orgs","repos_url":"https://api.github.com/users/GaoQ1/repos","events_url":"https://api.github.com/users/GaoQ1/events{/privacy}","received_events_url":"https://api.github.com/users/GaoQ1/received_events","type":"User","site_admin":false},"html_url":"https://github.com/GaoQ1/rasa_core","description":"🤖 Open source chatbot framework with machine learning-based dialogue management - Build contextual AI assistants","fork":true,"url":"https://api.github.com/repos/GaoQ1/rasa_core","forks_url":"https://api.github.com/repos/GaoQ1/rasa_core/forks","keys_url":"https://api.github.com/repos/GaoQ1/rasa_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GaoQ1/rasa_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GaoQ1/rasa_core/teams","hooks_url":"https://api.github.com/repos/GaoQ1/rasa_core/hooks","issue_events_url":"https://api.github.com/repos/GaoQ1/rasa_core/issues/events{/number}","events_url":"https://api.github.com/repos/GaoQ1/rasa_core/events","assignees_url":"https://api.github.com/repos/GaoQ1/rasa_core/assignees{/user}","branches_url":"https://api.github.com/repos/GaoQ1/rasa_core/branches{/branch}","tags_url":"https://api.github.com/repos/GaoQ1/rasa_core/tags","blobs_url":"https://api.github.com/repos/GaoQ1/rasa_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GaoQ1/rasa_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GaoQ1/rasa_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/GaoQ1/rasa_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GaoQ1/rasa_core/statuses/{sha}","languages_url":"https://api.github.com/repos/GaoQ1/rasa_core/languages","stargazers_url":"https://api.github.com/repos/GaoQ1/rasa_core/stargazers","contributors_url":"https://api.github.com/repos/GaoQ1/rasa_core/contributors","subscribers_url":"https://api.github.com/repos/GaoQ1/rasa_core/subscribers","subscription_url":"https://api.github.com/repos/GaoQ1/rasa_core/subscription","commits_url":"https://api.github.com/repos/GaoQ1/rasa_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/GaoQ1/rasa_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/GaoQ1/rasa_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/GaoQ1/rasa_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/GaoQ1/rasa_core/contents/{+path}","compare_url":"https://api.github.com/repos/GaoQ1/rasa_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GaoQ1/rasa_core/merges","archive_url":"https://api.github.com/repos/GaoQ1/rasa_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GaoQ1/rasa_core/downloads","issues_url":"https://api.github.com/repos/GaoQ1/rasa_core/issues{/number}","pulls_url":"https://api.github.com/repos/GaoQ1/rasa_core/pulls{/number}","milestones_url":"https://api.github.com/repos/GaoQ1/rasa_core/milestones{/number}","notifications_url":"https://api.github.com/repos/GaoQ1/rasa_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GaoQ1/rasa_core/labels{/name}","releases_url":"https://api.github.com/repos/GaoQ1/rasa_core/releases{/id}","deployments_url":"https://api.github.com/repos/GaoQ1/rasa_core/deployments","created_at":"2018-12-18T00:28:49Z","updated_at":"2019-01-02T11:35:03Z","pushed_at":"2019-01-02T11:35:00Z","git_url":"git://github.com/GaoQ1/rasa_core.git","ssh_url":"git@github.com:GaoQ1/rasa_core.git","clone_url":"https://github.com/GaoQ1/rasa_core.git","svn_url":"https://github.com/GaoQ1/rasa_core","homepage":"https://rasa.com/docs/core/","size":633845,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RasaHQ:master","ref":"master","sha":"5a65c499825f4034c898f4932198ebf4f0617ba8","user":{"login":"RasaHQ","id":21214473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjE0NDcz","avatar_url":"https://avatars0.githubusercontent.com/u/21214473?v=4","gravatar_id":"","url":"https://api.github.com/users/RasaHQ","html_url":"https://github.com/RasaHQ","followers_url":"https://api.github.com/users/RasaHQ/followers","following_url":"https://api.github.com/users/RasaHQ/following{/other_user}","gists_url":"https://api.github.com/users/RasaHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/RasaHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RasaHQ/subscriptions","organizations_url":"https://api.github.com/users/RasaHQ/orgs","repos_url":"https://api.github.com/users/RasaHQ/repos","events_url":"https://api.github.com/users/RasaHQ/events{/privacy}","received_events_url":"https://api.github.com/users/RasaHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":103934044,"node_id":"MDEwOlJlcG9zaXRvcnkxMDM5MzQwNDQ=","name":"rasa_core","full_name":"RasaHQ/rasa_core","private":false,"owner":{"login":"RasaHQ","id":21214473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjE0NDcz","avatar_url":"https://avatars0.githubusercontent.com/u/21214473?v=4","gravatar_id":"","url":"https://api.github.com/users/RasaHQ","html_url":"https://github.com/RasaHQ","followers_url":"https://api.github.com/users/RasaHQ/followers","following_url":"https://api.github.com/users/RasaHQ/following{/other_user}","gists_url":"https://api.github.com/users/RasaHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/RasaHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RasaHQ/subscriptions","organizations_url":"https://api.github.com/users/RasaHQ/orgs","repos_url":"https://api.github.com/users/RasaHQ/repos","events_url":"https://api.github.com/users/RasaHQ/events{/privacy}","received_events_url":"https://api.github.com/users/RasaHQ/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/RasaHQ/rasa_core","description":"🤖 Open source chatbot framework with machine learning-based dialogue management - Build contextual AI assistants","fork":false,"url":"https://api.github.com/repos/RasaHQ/rasa_core","forks_url":"https://api.github.com/repos/RasaHQ/rasa_core/forks","keys_url":"https://api.github.com/repos/RasaHQ/rasa_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RasaHQ/rasa_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RasaHQ/rasa_core/teams","hooks_url":"https://api.github.com/repos/RasaHQ/rasa_core/hooks","issue_events_url":"https://api.github.com/repos/RasaHQ/rasa_core/issues/events{/number}","events_url":"https://api.github.com/repos/RasaHQ/rasa_core/events","assignees_url":"https://api.github.com/repos/RasaHQ/rasa_core/assignees{/user}","branches_url":"https://api.github.com/repos/RasaHQ/rasa_core/branches{/branch}","tags_url":"https://api.github.com/repos/RasaHQ/rasa_core/tags","blobs_url":"https://api.github.com/repos/RasaHQ/rasa_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RasaHQ/rasa_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RasaHQ/rasa_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/RasaHQ/rasa_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RasaHQ/rasa_core/statuses/{sha}","languages_url":"https://api.github.com/repos/RasaHQ/rasa_core/languages","stargazers_url":"https://api.github.com/repos/RasaHQ/rasa_core/stargazers","contributors_url":"https://api.github.com/repos/RasaHQ/rasa_core/contributors","subscribers_url":"https://api.github.com/repos/RasaHQ/rasa_core/subscribers","subscription_url":"https://api.github.com/repos/RasaHQ/rasa_core/subscription","commits_url":"https://api.github.com/repos/RasaHQ/rasa_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/RasaHQ/rasa_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/RasaHQ/rasa_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/RasaHQ/rasa_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/RasaHQ/rasa_core/contents/{+path}","compare_url":"https://api.github.com/repos/RasaHQ/rasa_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RasaHQ/rasa_core/merges","archive_url":"https://api.github.com/repos/RasaHQ/rasa_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RasaHQ/rasa_core/downloads","issues_url":"https://api.github.com/repos/RasaHQ/rasa_core/issues{/number}","pulls_url":"https://api.github.com/repos/RasaHQ/rasa_core/pulls{/number}","milestones_url":"https://api.github.com/repos/RasaHQ/rasa_core/milestones{/number}","notifications_url":"https://api.github.com/repos/RasaHQ/rasa_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RasaHQ/rasa_core/labels{/name}","releases_url":"https://api.github.com/repos/RasaHQ/rasa_core/releases{/id}","deployments_url":"https://api.github.com/repos/RasaHQ/rasa_core/deployments","created_at":"2017-09-18T12:07:12Z","updated_at":"2019-01-03T10:59:00Z","pushed_at":"2019-01-03T12:14:13Z","git_url":"git://github.com/RasaHQ/rasa_core.git","ssh_url":"git@github.com:RasaHQ/rasa_core.git","clone_url":"https://github.com/RasaHQ/rasa_core.git","svn_url":"https://github.com/RasaHQ/rasa_core","homepage":"https://rasa.com/docs/core/","size":667669,"stargazers_count":1482,"watchers_count":1482,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":761,"mirror_url":null,"archived":false,"open_issues_count":137,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":761,"open_issues":137,"watchers":1482,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RasaHQ/rasa_core/pulls/1494"},"html":{"href":"https://github.com/RasaHQ/rasa_core/pull/1494"},"issue":{"href":"https://api.github.com/repos/RasaHQ/rasa_core/issues/1494"},"comments":{"href":"https://api.github.com/repos/RasaHQ/rasa_core/issues/1494/comments"},"review_comments":{"href":"https://api.github.com/repos/RasaHQ/rasa_core/pulls/1494/comments"},"review_comment":{"href":"https://api.github.com/repos/RasaHQ/rasa_core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RasaHQ/rasa_core/pulls/1494/commits"},"statuses":{"href":"https://api.github.com/repos/RasaHQ/rasa_core/statuses/4395cf4df5fe9f7af7c40900fb8848baa359c100"}},"author_association":"NONE"}}
{"actor":{"display_login":"Ghostvv"}}