{"action":"closed","issue":{"url":"https://api.github.com/repos/TresAmigosSD/SMV/issues/1304","repository_url":"https://api.github.com/repos/TresAmigosSD/SMV","labels_url":"https://api.github.com/repos/TresAmigosSD/SMV/issues/1304/labels{/name}","comments_url":"https://api.github.com/repos/TresAmigosSD/SMV/issues/1304/comments","events_url":"https://api.github.com/repos/TresAmigosSD/SMV/issues/1304/events","html_url":"https://github.com/TresAmigosSD/SMV/issues/1304","id":337675895,"node_id":"MDU6SXNzdWUzMzc2NzU4OTU=","number":1304,"title":"More extensive release validation","user":{"login":"laneb","id":8392543,"node_id":"MDQ6VXNlcjgzOTI1NDM=","avatar_url":"https://avatars2.githubusercontent.com/u/8392543?v=4","gravatar_id":"","url":"https://api.github.com/users/laneb","html_url":"https://github.com/laneb","followers_url":"https://api.github.com/users/laneb/followers","following_url":"https://api.github.com/users/laneb/following{/other_user}","gists_url":"https://api.github.com/users/laneb/gists{/gist_id}","starred_url":"https://api.github.com/users/laneb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laneb/subscriptions","organizations_url":"https://api.github.com/users/laneb/orgs","repos_url":"https://api.github.com/users/laneb/repos","events_url":"https://api.github.com/users/laneb/events{/privacy}","received_events_url":"https://api.github.com/users/laneb/received_events","type":"User","site_admin":false},"labels":[{"id":819601411,"node_id":"MDU6TGFiZWw4MTk2MDE0MTE=","url":"https://api.github.com/repos/TresAmigosSD/SMV/labels/discussion","name":"discussion","color":"f77ba2","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-07-02T21:49:12Z","updated_at":"2018-07-09T19:06:45Z","closed_at":"2018-07-09T19:06:45Z","author_association":"CONTRIBUTOR","body":"Up until the release of `2r0`, we have validated new release artifacts by running the tests in a docker container against the single targeted Spark patch version with a single Python version - I think 3.6 most recently, since that appears to be what `apt-get` installs by default for Python 3. The image for the container is based on the `Dockerfile` from the release branch.\r\n\r\nWe should validate the artifact against all supported Spark minor versions and Python versions. The new make target `test-thorough` should satisfy this, but if we continue to run the tests in Docker, we'll need to build an image with the dev dependencies. Particularly, the official SMV image won't include all of the supported Python versions. We _could_ install these and any future dependencies in the official SMV images, but it would come at the cost of a larger image. This image for testing would not need to be hosted.\r\n\r\nAlternatively, we could remove Docker from the mix. I believe we started using Docker to build and test the release to ensure a standardized environment (particularly Java version). If we shift the release responsibilities into the CI, there is less need for Docker since we can standardize the environment in the CI. However, continuing to utilize Docker will ease any future transition between CI platforms.\r\n\r\nIf we do create a new image, we have the option the utilize it to install dependencies for standard dev testing. However, I'd be hesitant to do this, because I currently see degraded performance when `smv-release` runs the tests in Docker. "}}
{"actor":{"display_login":"laneb"}}