{"action":"created","comment":{"url":"https://api.github.com/repos/iotaledger/iri-regression/pulls/comments/223722859","pull_request_review_id":162917450,"id":223722859,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzcyMjg1OQ==","diff_hunk":"@@ -41,56 +42,60 @@\n @step(r'\"([^\"]*)\" is called on \"([^\"]*)\" with:')\n def api_method_is_called(step,apiCall,nodeName):\n     logger.info('%s is called on %s',apiCall,nodeName)\n-    config['apiCall'] = apiCall\n-    config['nodeId'] = nodeName\n+    world.config['apiCall'] = apiCall\n+    world.config['nodeId'] = nodeName\n     arg_list = step.hashes\n \n     options = {}\n     api_utils.prepare_options(arg_list, options)\n-    responses[apiCall] = {}\n \n     api = api_utils.prepare_api_call(nodeName)\n     response = api_utils.fetch_call(apiCall, api, options)\n \n     assert type(response) is dict, 'There may be something wrong with the response format: {}'.format(response)\n     \n-    responses[apiCall] = {}\n-    responses[apiCall][nodeName] = response\n+    world.responses[apiCall] = {}\n+    world.responses[apiCall][nodeName] = response\n \n #This method is identical to the method above, but creates a new thread\n #TODO: Find a way to pass aloe.world variable between threads to eliminate need for duplicate code\n @step(r'\"([^\"]*)\" is called in parallel on \"([^\"]*)\" with:')\n def threaded_call(step,apiCall,node):\n     logger.info(\"Creating thread for {}\".format(apiCall))\n-    config['apiCall'] = apiCall\n-    config['nodeId'] = node\n+    world.config['apiCall'] = apiCall\n+    world.config['nodeId'] = node\n     arg_list = step.hashes\n \n     options = {}\n     api_utils.prepare_options(arg_list, options)\n     api = api_utils.prepare_api_call(node)\n \n-    def make_call(api,options):\n+    def make_call(api,options,q):\n         response = api_utils.fetch_call(apiCall, api, options)\n+        responses = q.get()","path":"PythonRegression/tests/features/steps/api_test_steps.py","position":61,"original_position":61,"commit_id":"bf25451da867752e7453c6275cff3f157c7e2a74","original_commit_id":"bf25451da867752e7453c6275cff3f157c7e2a74","user":{"login":"GalRogozinski","id":7954839,"node_id":"MDQ6VXNlcjc5NTQ4Mzk=","avatar_url":"https://avatars3.githubusercontent.com/u/7954839?v=4","gravatar_id":"","url":"https://api.github.com/users/GalRogozinski","html_url":"https://github.com/GalRogozinski","followers_url":"https://api.github.com/users/GalRogozinski/followers","following_url":"https://api.github.com/users/GalRogozinski/following{/other_user}","gists_url":"https://api.github.com/users/GalRogozinski/gists{/gist_id}","starred_url":"https://api.github.com/users/GalRogozinski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GalRogozinski/subscriptions","organizations_url":"https://api.github.com/users/GalRogozinski/orgs","repos_url":"https://api.github.com/users/GalRogozinski/repos","events_url":"https://api.github.com/users/GalRogozinski/events{/privacy}","received_events_url":"https://api.github.com/users/GalRogozinski/received_events","type":"User","site_admin":false},"body":"looking at it again why do you need a queue?","created_at":"2018-10-09T14:24:07Z","updated_at":"2018-10-09T14:40:19Z","html_url":"https://github.com/iotaledger/iri-regression/pull/50#discussion_r223722859","pull_request_url":"https://api.github.com/repos/iotaledger/iri-regression/pulls/50","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/iotaledger/iri-regression/pulls/comments/223722859"},"html":{"href":"https://github.com/iotaledger/iri-regression/pull/50#discussion_r223722859"},"pull_request":{"href":"https://api.github.com/repos/iotaledger/iri-regression/pulls/50"}}},"pull_request":{"url":"https://api.github.com/repos/iotaledger/iri-regression/pulls/50","id":220111973,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMTExOTcz","html_url":"https://github.com/iotaledger/iri-regression/pull/50","diff_url":"https://github.com/iotaledger/iri-regression/pull/50.diff","patch_url":"https://github.com/iotaledger/iri-regression/pull/50.patch","issue_url":"https://api.github.com/repos/iotaledger/iri-regression/issues/50","number":50,"state":"open","locked":false,"title":"Move variables to world environment","user":{"login":"DyrellC","id":34013004,"node_id":"MDQ6VXNlcjM0MDEzMDA0","avatar_url":"https://avatars2.githubusercontent.com/u/34013004?v=4","gravatar_id":"","url":"https://api.github.com/users/DyrellC","html_url":"https://github.com/DyrellC","followers_url":"https://api.github.com/users/DyrellC/followers","following_url":"https://api.github.com/users/DyrellC/following{/other_user}","gists_url":"https://api.github.com/users/DyrellC/gists{/gist_id}","starred_url":"https://api.github.com/users/DyrellC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DyrellC/subscriptions","organizations_url":"https://api.github.com/users/DyrellC/orgs","repos_url":"https://api.github.com/users/DyrellC/repos","events_url":"https://api.github.com/users/DyrellC/events{/privacy}","received_events_url":"https://api.github.com/users/DyrellC/received_events","type":"User","site_admin":false},"body":"### Description\r\nAs per https://github.com/iotaledger/iri-regression/issues/46, all configuration and response values have been moved to the `aloe.world` global environment for ease of access. An `@after.each_example` hook has been added to the `machine_configurations_steps.py` file to clear any variables that remain in `world.config` and `world.responses` following each scenario. \r\n","created_at":"2018-10-03T17:05:20Z","updated_at":"2018-10-09T14:40:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"802561bf4082969a81cff698be87671a1a68d714","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/iotaledger/iri-regression/pulls/50/commits","review_comments_url":"https://api.github.com/repos/iotaledger/iri-regression/pulls/50/comments","review_comment_url":"https://api.github.com/repos/iotaledger/iri-regression/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iotaledger/iri-regression/issues/50/comments","statuses_url":"https://api.github.com/repos/iotaledger/iri-regression/statuses/bf25451da867752e7453c6275cff3f157c7e2a74","head":{"label":"DyrellC:fix-world","ref":"fix-world","sha":"bf25451da867752e7453c6275cff3f157c7e2a74","user":{"login":"DyrellC","id":34013004,"node_id":"MDQ6VXNlcjM0MDEzMDA0","avatar_url":"https://avatars2.githubusercontent.com/u/34013004?v=4","gravatar_id":"","url":"https://api.github.com/users/DyrellC","html_url":"https://github.com/DyrellC","followers_url":"https://api.github.com/users/DyrellC/followers","following_url":"https://api.github.com/users/DyrellC/following{/other_user}","gists_url":"https://api.github.com/users/DyrellC/gists{/gist_id}","starred_url":"https://api.github.com/users/DyrellC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DyrellC/subscriptions","organizations_url":"https://api.github.com/users/DyrellC/orgs","repos_url":"https://api.github.com/users/DyrellC/repos","events_url":"https://api.github.com/users/DyrellC/events{/privacy}","received_events_url":"https://api.github.com/users/DyrellC/received_events","type":"User","site_admin":false},"repo":{"id":150643999,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA2NDM5OTk=","name":"iri-regression","full_name":"DyrellC/iri-regression","private":false,"owner":{"login":"DyrellC","id":34013004,"node_id":"MDQ6VXNlcjM0MDEzMDA0","avatar_url":"https://avatars2.githubusercontent.com/u/34013004?v=4","gravatar_id":"","url":"https://api.github.com/users/DyrellC","html_url":"https://github.com/DyrellC","followers_url":"https://api.github.com/users/DyrellC/followers","following_url":"https://api.github.com/users/DyrellC/following{/other_user}","gists_url":"https://api.github.com/users/DyrellC/gists{/gist_id}","starred_url":"https://api.github.com/users/DyrellC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DyrellC/subscriptions","organizations_url":"https://api.github.com/users/DyrellC/orgs","repos_url":"https://api.github.com/users/DyrellC/repos","events_url":"https://api.github.com/users/DyrellC/events{/privacy}","received_events_url":"https://api.github.com/users/DyrellC/received_events","type":"User","site_admin":false},"html_url":"https://github.com/DyrellC/iri-regression","description":null,"fork":true,"url":"https://api.github.com/repos/DyrellC/iri-regression","forks_url":"https://api.github.com/repos/DyrellC/iri-regression/forks","keys_url":"https://api.github.com/repos/DyrellC/iri-regression/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DyrellC/iri-regression/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DyrellC/iri-regression/teams","hooks_url":"https://api.github.com/repos/DyrellC/iri-regression/hooks","issue_events_url":"https://api.github.com/repos/DyrellC/iri-regression/issues/events{/number}","events_url":"https://api.github.com/repos/DyrellC/iri-regression/events","assignees_url":"https://api.github.com/repos/DyrellC/iri-regression/assignees{/user}","branches_url":"https://api.github.com/repos/DyrellC/iri-regression/branches{/branch}","tags_url":"https://api.github.com/repos/DyrellC/iri-regression/tags","blobs_url":"https://api.github.com/repos/DyrellC/iri-regression/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DyrellC/iri-regression/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DyrellC/iri-regression/git/refs{/sha}","trees_url":"https://api.github.com/repos/DyrellC/iri-regression/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DyrellC/iri-regression/statuses/{sha}","languages_url":"https://api.github.com/repos/DyrellC/iri-regression/languages","stargazers_url":"https://api.github.com/repos/DyrellC/iri-regression/stargazers","contributors_url":"https://api.github.com/repos/DyrellC/iri-regression/contributors","subscribers_url":"https://api.github.com/repos/DyrellC/iri-regression/subscribers","subscription_url":"https://api.github.com/repos/DyrellC/iri-regression/subscription","commits_url":"https://api.github.com/repos/DyrellC/iri-regression/commits{/sha}","git_commits_url":"https://api.github.com/repos/DyrellC/iri-regression/git/commits{/sha}","comments_url":"https://api.github.com/repos/DyrellC/iri-regression/comments{/number}","issue_comment_url":"https://api.github.com/repos/DyrellC/iri-regression/issues/comments{/number}","contents_url":"https://api.github.com/repos/DyrellC/iri-regression/contents/{+path}","compare_url":"https://api.github.com/repos/DyrellC/iri-regression/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DyrellC/iri-regression/merges","archive_url":"https://api.github.com/repos/DyrellC/iri-regression/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DyrellC/iri-regression/downloads","issues_url":"https://api.github.com/repos/DyrellC/iri-regression/issues{/number}","pulls_url":"https://api.github.com/repos/DyrellC/iri-regression/pulls{/number}","milestones_url":"https://api.github.com/repos/DyrellC/iri-regression/milestones{/number}","notifications_url":"https://api.github.com/repos/DyrellC/iri-regression/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DyrellC/iri-regression/labels{/name}","releases_url":"https://api.github.com/repos/DyrellC/iri-regression/releases{/id}","deployments_url":"https://api.github.com/repos/DyrellC/iri-regression/deployments","created_at":"2018-09-27T20:28:18Z","updated_at":"2018-10-02T23:12:57Z","pushed_at":"2018-10-04T00:42:06Z","git_url":"git://github.com/DyrellC/iri-regression.git","ssh_url":"git@github.com:DyrellC/iri-regression.git","clone_url":"https://github.com/DyrellC/iri-regression.git","svn_url":"https://github.com/DyrellC/iri-regression","homepage":null,"size":118,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"iotaledger:master","ref":"master","sha":"9ca26fc9eec4a57601032e538fd51d2b143c6896","user":{"login":"iotaledger","id":20126597,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMTI2NTk3","avatar_url":"https://avatars3.githubusercontent.com/u/20126597?v=4","gravatar_id":"","url":"https://api.github.com/users/iotaledger","html_url":"https://github.com/iotaledger","followers_url":"https://api.github.com/users/iotaledger/followers","following_url":"https://api.github.com/users/iotaledger/following{/other_user}","gists_url":"https://api.github.com/users/iotaledger/gists{/gist_id}","starred_url":"https://api.github.com/users/iotaledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iotaledger/subscriptions","organizations_url":"https://api.github.com/users/iotaledger/orgs","repos_url":"https://api.github.com/users/iotaledger/repos","events_url":"https://api.github.com/users/iotaledger/events{/privacy}","received_events_url":"https://api.github.com/users/iotaledger/received_events","type":"Organization","site_admin":false},"repo":{"id":139697734,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk2OTc3MzQ=","name":"iri-regression","full_name":"iotaledger/iri-regression","private":false,"owner":{"login":"iotaledger","id":20126597,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMTI2NTk3","avatar_url":"https://avatars3.githubusercontent.com/u/20126597?v=4","gravatar_id":"","url":"https://api.github.com/users/iotaledger","html_url":"https://github.com/iotaledger","followers_url":"https://api.github.com/users/iotaledger/followers","following_url":"https://api.github.com/users/iotaledger/following{/other_user}","gists_url":"https://api.github.com/users/iotaledger/gists{/gist_id}","starred_url":"https://api.github.com/users/iotaledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iotaledger/subscriptions","organizations_url":"https://api.github.com/users/iotaledger/orgs","repos_url":"https://api.github.com/users/iotaledger/repos","events_url":"https://api.github.com/users/iotaledger/events{/privacy}","received_events_url":"https://api.github.com/users/iotaledger/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/iotaledger/iri-regression","description":null,"fork":false,"url":"https://api.github.com/repos/iotaledger/iri-regression","forks_url":"https://api.github.com/repos/iotaledger/iri-regression/forks","keys_url":"https://api.github.com/repos/iotaledger/iri-regression/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iotaledger/iri-regression/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iotaledger/iri-regression/teams","hooks_url":"https://api.github.com/repos/iotaledger/iri-regression/hooks","issue_events_url":"https://api.github.com/repos/iotaledger/iri-regression/issues/events{/number}","events_url":"https://api.github.com/repos/iotaledger/iri-regression/events","assignees_url":"https://api.github.com/repos/iotaledger/iri-regression/assignees{/user}","branches_url":"https://api.github.com/repos/iotaledger/iri-regression/branches{/branch}","tags_url":"https://api.github.com/repos/iotaledger/iri-regression/tags","blobs_url":"https://api.github.com/repos/iotaledger/iri-regression/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iotaledger/iri-regression/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iotaledger/iri-regression/git/refs{/sha}","trees_url":"https://api.github.com/repos/iotaledger/iri-regression/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iotaledger/iri-regression/statuses/{sha}","languages_url":"https://api.github.com/repos/iotaledger/iri-regression/languages","stargazers_url":"https://api.github.com/repos/iotaledger/iri-regression/stargazers","contributors_url":"https://api.github.com/repos/iotaledger/iri-regression/contributors","subscribers_url":"https://api.github.com/repos/iotaledger/iri-regression/subscribers","subscription_url":"https://api.github.com/repos/iotaledger/iri-regression/subscription","commits_url":"https://api.github.com/repos/iotaledger/iri-regression/commits{/sha}","git_commits_url":"https://api.github.com/repos/iotaledger/iri-regression/git/commits{/sha}","comments_url":"https://api.github.com/repos/iotaledger/iri-regression/comments{/number}","issue_comment_url":"https://api.github.com/repos/iotaledger/iri-regression/issues/comments{/number}","contents_url":"https://api.github.com/repos/iotaledger/iri-regression/contents/{+path}","compare_url":"https://api.github.com/repos/iotaledger/iri-regression/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iotaledger/iri-regression/merges","archive_url":"https://api.github.com/repos/iotaledger/iri-regression/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iotaledger/iri-regression/downloads","issues_url":"https://api.github.com/repos/iotaledger/iri-regression/issues{/number}","pulls_url":"https://api.github.com/repos/iotaledger/iri-regression/pulls{/number}","milestones_url":"https://api.github.com/repos/iotaledger/iri-regression/milestones{/number}","notifications_url":"https://api.github.com/repos/iotaledger/iri-regression/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iotaledger/iri-regression/labels{/name}","releases_url":"https://api.github.com/repos/iotaledger/iri-regression/releases{/id}","deployments_url":"https://api.github.com/repos/iotaledger/iri-regression/deployments","created_at":"2018-07-04T09:09:21Z","updated_at":"2018-10-02T19:10:02Z","pushed_at":"2018-10-09T06:28:32Z","git_url":"git://github.com/iotaledger/iri-regression.git","ssh_url":"git@github.com:iotaledger/iri-regression.git","clone_url":"https://github.com/iotaledger/iri-regression.git","svn_url":"https://github.com/iotaledger/iri-regression","homepage":null,"size":123,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":24,"license":null,"forks":2,"open_issues":24,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iotaledger/iri-regression/pulls/50"},"html":{"href":"https://github.com/iotaledger/iri-regression/pull/50"},"issue":{"href":"https://api.github.com/repos/iotaledger/iri-regression/issues/50"},"comments":{"href":"https://api.github.com/repos/iotaledger/iri-regression/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/iotaledger/iri-regression/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/iotaledger/iri-regression/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iotaledger/iri-regression/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/iotaledger/iri-regression/statuses/bf25451da867752e7453c6275cff3f157c7e2a74"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"GalRogozinski"}}