{"action":"created","comment":{"url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/pulls/comments/170185458","pull_request_review_id":98833184,"id":170185458,"diff_hunk":"@@ -1,8 +1,8 @@\n import {h, Component} from 'preact';\n+import {get_sign_in_out} from \"../../js/auth-helpers\";\n import style from './style';\n \n-import Menu from 'preact-material-components/Menu';\n-import Button from 'preact-material-components/Button';\n+import { Menu, Button } from 'preact-material-components';","path":"client/src/components/Nav/index.js","position":7,"original_position":7,"commit_id":"648d65b387d843be4d54868433ac23a6710a4fd4","original_commit_id":"648d65b387d843be4d54868433ac23a6710a4fd4","user":{"login":"motosharpley","id":17731807,"avatar_url":"https://avatars1.githubusercontent.com/u/17731807?v=4","gravatar_id":"","url":"https://api.github.com/users/motosharpley","html_url":"https://github.com/motosharpley","followers_url":"https://api.github.com/users/motosharpley/followers","following_url":"https://api.github.com/users/motosharpley/following{/other_user}","gists_url":"https://api.github.com/users/motosharpley/gists{/gist_id}","starred_url":"https://api.github.com/users/motosharpley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/motosharpley/subscriptions","organizations_url":"https://api.github.com/users/motosharpley/orgs","repos_url":"https://api.github.com/users/motosharpley/repos","events_url":"https://api.github.com/users/motosharpley/events{/privacy}","received_events_url":"https://api.github.com/users/motosharpley/received_events","type":"User","site_admin":false},"body":"Yep I know you went this route because of a testing issue, however there is nothing special about the button or menu coming from material components at this point we can get this fairly easily with vanilla css/js especially considering how few instances we are going to have. Sorry for pointing you to preact-material-components to begin with.\r\nin addition just for everyone's info what I have discovered in working on this topic is that importing the component features as an object like this vs the individual imports bloats surprisingly heavy on any component library not just material components. It had the same effect with semantic-ui-react as well which is targeted as a version specific for this environment(react-preact etc) so lesson here beware of the hidden cost of unnecessary libraries   ","created_at":"2018-02-23T07:55:54Z","updated_at":"2018-02-23T07:55:54Z","html_url":"https://github.com/TheDevPath/googleMaps-offline-navigator/pull/157#discussion_r170185458","pull_request_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/pulls/157","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/pulls/comments/170185458"},"html":{"href":"https://github.com/TheDevPath/googleMaps-offline-navigator/pull/157#discussion_r170185458"},"pull_request":{"href":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/pulls/157"}},"in_reply_to_id":170135740},"pull_request":{"url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/pulls/157","id":170896300,"html_url":"https://github.com/TheDevPath/googleMaps-offline-navigator/pull/157","diff_url":"https://github.com/TheDevPath/googleMaps-offline-navigator/pull/157.diff","patch_url":"https://github.com/TheDevPath/googleMaps-offline-navigator/pull/157.patch","issue_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/issues/157","number":157,"state":"open","locked":false,"title":"use api for signin and register","user":{"login":"seckboy","id":6200031,"avatar_url":"https://avatars3.githubusercontent.com/u/6200031?v=4","gravatar_id":"","url":"https://api.github.com/users/seckboy","html_url":"https://github.com/seckboy","followers_url":"https://api.github.com/users/seckboy/followers","following_url":"https://api.github.com/users/seckboy/following{/other_user}","gists_url":"https://api.github.com/users/seckboy/gists{/gist_id}","starred_url":"https://api.github.com/users/seckboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seckboy/subscriptions","organizations_url":"https://api.github.com/users/seckboy/orgs","repos_url":"https://api.github.com/users/seckboy/repos","events_url":"https://api.github.com/users/seckboy/events{/privacy}","received_events_url":"https://api.github.com/users/seckboy/received_events","type":"User","site_admin":false},"body":"## Issue Number:\r\n125\r\n## Issue Description:\r\nConnect signin and register to api\r\n\r\n### Summary of solution:\r\n1. Used axios to connect to api\r\n2. Created client/src/js/auth-helpers.js \r\n3. Used cookies to store token\r\n\r\n### Can this issue be closed?\r\nYes\r\n\r\n### Should any new issues be added as a result of this solution?\r\nWe need a new issue to hook up forgot password and change password. These may need additions to backend api. Also perhaps a new issue to hide Profile, Maps, etc unless signed in.\r\n\r\n### Have you named your branch in a descriptive way? Remember to name your branch in a unique and descriptive manner in order to properly reflect the issue or feature.\r\nNamed attach-signin-to-api\r\n\r\n### Thanks for contributing!\r\n","created_at":"2018-02-22T23:34:04Z","updated_at":"2018-02-23T07:55:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d73c2c77e02377f38e1b94b6e97befbba054f231","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":808479707,"url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/labels/review","name":"review","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/pulls/157/commits","review_comments_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/pulls/157/comments","review_comment_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/issues/157/comments","statuses_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/statuses/648d65b387d843be4d54868433ac23a6710a4fd4","head":{"label":"seckboy:attach-signin-to-api","ref":"attach-signin-to-api","sha":"648d65b387d843be4d54868433ac23a6710a4fd4","user":{"login":"seckboy","id":6200031,"avatar_url":"https://avatars3.githubusercontent.com/u/6200031?v=4","gravatar_id":"","url":"https://api.github.com/users/seckboy","html_url":"https://github.com/seckboy","followers_url":"https://api.github.com/users/seckboy/followers","following_url":"https://api.github.com/users/seckboy/following{/other_user}","gists_url":"https://api.github.com/users/seckboy/gists{/gist_id}","starred_url":"https://api.github.com/users/seckboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seckboy/subscriptions","organizations_url":"https://api.github.com/users/seckboy/orgs","repos_url":"https://api.github.com/users/seckboy/repos","events_url":"https://api.github.com/users/seckboy/events{/privacy}","received_events_url":"https://api.github.com/users/seckboy/received_events","type":"User","site_admin":false},"repo":{"id":120117839,"name":"googleMaps-offline-navigator","full_name":"seckboy/googleMaps-offline-navigator","owner":{"login":"seckboy","id":6200031,"avatar_url":"https://avatars3.githubusercontent.com/u/6200031?v=4","gravatar_id":"","url":"https://api.github.com/users/seckboy","html_url":"https://github.com/seckboy","followers_url":"https://api.github.com/users/seckboy/followers","following_url":"https://api.github.com/users/seckboy/following{/other_user}","gists_url":"https://api.github.com/users/seckboy/gists{/gist_id}","starred_url":"https://api.github.com/users/seckboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seckboy/subscriptions","organizations_url":"https://api.github.com/users/seckboy/orgs","repos_url":"https://api.github.com/users/seckboy/repos","events_url":"https://api.github.com/users/seckboy/events{/privacy}","received_events_url":"https://api.github.com/users/seckboy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/seckboy/googleMaps-offline-navigator","description":"Open source project for Grow with Google Udacity Scholarship Challenge - Navigation app using offline first strategy and google maps api","fork":true,"url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator","forks_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/forks","keys_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/teams","hooks_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/hooks","issue_events_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/issues/events{/number}","events_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/events","assignees_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/assignees{/user}","branches_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/branches{/branch}","tags_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/tags","blobs_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/git/refs{/sha}","trees_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/statuses/{sha}","languages_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/languages","stargazers_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/stargazers","contributors_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/contributors","subscribers_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/subscribers","subscription_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/subscription","commits_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/commits{/sha}","git_commits_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/git/commits{/sha}","comments_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/comments{/number}","issue_comment_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/issues/comments{/number}","contents_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/contents/{+path}","compare_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/merges","archive_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/downloads","issues_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/issues{/number}","pulls_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/pulls{/number}","milestones_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/milestones{/number}","notifications_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/labels{/name}","releases_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/releases{/id}","deployments_url":"https://api.github.com/repos/seckboy/googleMaps-offline-navigator/deployments","created_at":"2018-02-03T18:24:59Z","updated_at":"2018-02-03T18:25:01Z","pushed_at":"2018-02-22T23:29:14Z","git_url":"git://github.com/seckboy/googleMaps-offline-navigator.git","ssh_url":"git@github.com:seckboy/googleMaps-offline-navigator.git","clone_url":"https://github.com/seckboy/googleMaps-offline-navigator.git","svn_url":"https://github.com/seckboy/googleMaps-offline-navigator","homepage":null,"size":1420,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"TheDevPath:development","ref":"development","sha":"8f4ca8990daf63ed2c4727d2769fb07fd2c22202","user":{"login":"TheDevPath","id":34627465,"avatar_url":"https://avatars0.githubusercontent.com/u/34627465?v=4","gravatar_id":"","url":"https://api.github.com/users/TheDevPath","html_url":"https://github.com/TheDevPath","followers_url":"https://api.github.com/users/TheDevPath/followers","following_url":"https://api.github.com/users/TheDevPath/following{/other_user}","gists_url":"https://api.github.com/users/TheDevPath/gists{/gist_id}","starred_url":"https://api.github.com/users/TheDevPath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheDevPath/subscriptions","organizations_url":"https://api.github.com/users/TheDevPath/orgs","repos_url":"https://api.github.com/users/TheDevPath/repos","events_url":"https://api.github.com/users/TheDevPath/events{/privacy}","received_events_url":"https://api.github.com/users/TheDevPath/received_events","type":"Organization","site_admin":false},"repo":{"id":117900050,"name":"googleMaps-offline-navigator","full_name":"TheDevPath/googleMaps-offline-navigator","owner":{"login":"TheDevPath","id":34627465,"avatar_url":"https://avatars0.githubusercontent.com/u/34627465?v=4","gravatar_id":"","url":"https://api.github.com/users/TheDevPath","html_url":"https://github.com/TheDevPath","followers_url":"https://api.github.com/users/TheDevPath/followers","following_url":"https://api.github.com/users/TheDevPath/following{/other_user}","gists_url":"https://api.github.com/users/TheDevPath/gists{/gist_id}","starred_url":"https://api.github.com/users/TheDevPath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheDevPath/subscriptions","organizations_url":"https://api.github.com/users/TheDevPath/orgs","repos_url":"https://api.github.com/users/TheDevPath/repos","events_url":"https://api.github.com/users/TheDevPath/events{/privacy}","received_events_url":"https://api.github.com/users/TheDevPath/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TheDevPath/googleMaps-offline-navigator","description":"Open Source Project for Grow with Google Udacity Scholarship Challenge - Navigation app using offline first strategy and google maps api - To get started please refer to the README.md - CONTRIBUTING.md and the project Wiki","fork":false,"url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator","forks_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/forks","keys_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/teams","hooks_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/hooks","issue_events_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/issues/events{/number}","events_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/events","assignees_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/assignees{/user}","branches_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/branches{/branch}","tags_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/tags","blobs_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/git/refs{/sha}","trees_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/statuses/{sha}","languages_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/languages","stargazers_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/stargazers","contributors_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/contributors","subscribers_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/subscribers","subscription_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/subscription","commits_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/commits{/sha}","git_commits_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/git/commits{/sha}","comments_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/comments{/number}","issue_comment_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/issues/comments{/number}","contents_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/contents/{+path}","compare_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/merges","archive_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/downloads","issues_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/issues{/number}","pulls_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/pulls{/number}","milestones_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/milestones{/number}","notifications_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/labels{/name}","releases_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/releases{/id}","deployments_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/deployments","created_at":"2018-01-17T22:23:57Z","updated_at":"2018-02-22T04:03:21Z","pushed_at":"2018-02-23T07:46:59Z","git_url":"git://github.com/TheDevPath/googleMaps-offline-navigator.git","ssh_url":"git@github.com:TheDevPath/googleMaps-offline-navigator.git","clone_url":"https://github.com/TheDevPath/googleMaps-offline-navigator.git","svn_url":"https://github.com/TheDevPath/googleMaps-offline-navigator","homepage":"","size":1113,"stargazers_count":27,"watchers_count":27,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":41,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":41,"open_issues":29,"watchers":27,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/pulls/157"},"html":{"href":"https://github.com/TheDevPath/googleMaps-offline-navigator/pull/157"},"issue":{"href":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/issues/157"},"comments":{"href":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/issues/157/comments"},"review_comments":{"href":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/pulls/157/comments"},"review_comment":{"href":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/pulls/157/commits"},"statuses":{"href":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/statuses/648d65b387d843be4d54868433ac23a6710a4fd4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"motosharpley"}}