{"action":"created","comment":{"url":"https://api.github.com/repos/freedomofpress/securedrop/pulls/comments/168614659","pull_request_review_id":97013865,"id":168614659,"diff_hunk":"@@ -9,11 +9,7 @@\n import sys\n import tempfile\n \n-# By default let's assume we're testing against the development VM.\n-try:\n-    target_host = sys.argv[1]\n-except IndexError:\n-    target_host = \"development\"\n+target_host = sys.argv[1]","path":"testinfra/test.py","position":9,"original_position":9,"commit_id":"c8d4e20203b7dfbe2d8e72ec6de3ec79a157ab91","original_commit_id":"b96319699ed312763543b579a6927079f68b246d","user":{"login":"heartsucker","id":3998464,"avatar_url":"https://avatars0.githubusercontent.com/u/3998464?v=4","gravatar_id":"","url":"https://api.github.com/users/heartsucker","html_url":"https://github.com/heartsucker","followers_url":"https://api.github.com/users/heartsucker/followers","following_url":"https://api.github.com/users/heartsucker/following{/other_user}","gists_url":"https://api.github.com/users/heartsucker/gists{/gist_id}","starred_url":"https://api.github.com/users/heartsucker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heartsucker/subscriptions","organizations_url":"https://api.github.com/users/heartsucker/orgs","repos_url":"https://api.github.com/users/heartsucker/repos","events_url":"https://api.github.com/users/heartsucker/events{/privacy}","received_events_url":"https://api.github.com/users/heartsucker/received_events","type":"User","site_admin":false},"body":"Also fair.","created_at":"2018-02-15T21:33:34Z","updated_at":"2018-02-15T21:33:35Z","html_url":"https://github.com/freedomofpress/securedrop/pull/2990#discussion_r168614659","pull_request_url":"https://api.github.com/repos/freedomofpress/securedrop/pulls/2990","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/freedomofpress/securedrop/pulls/comments/168614659"},"html":{"href":"https://github.com/freedomofpress/securedrop/pull/2990#discussion_r168614659"},"pull_request":{"href":"https://api.github.com/repos/freedomofpress/securedrop/pulls/2990"}},"in_reply_to_id":168578169},"pull_request":{"url":"https://api.github.com/repos/freedomofpress/securedrop/pulls/2990","id":168364392,"html_url":"https://github.com/freedomofpress/securedrop/pull/2990","diff_url":"https://github.com/freedomofpress/securedrop/pull/2990.diff","patch_url":"https://github.com/freedomofpress/securedrop/pull/2990.patch","issue_url":"https://api.github.com/repos/freedomofpress/securedrop/issues/2990","number":2990,"state":"open","locked":false,"title":"tests: docker based development environment","user":{"login":"dachary","id":433594,"avatar_url":"https://avatars0.githubusercontent.com/u/433594?v=4","gravatar_id":"","url":"https://api.github.com/users/dachary","html_url":"https://github.com/dachary","followers_url":"https://api.github.com/users/dachary/followers","following_url":"https://api.github.com/users/dachary/following{/other_user}","gists_url":"https://api.github.com/users/dachary/gists{/gist_id}","starred_url":"https://api.github.com/users/dachary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dachary/subscriptions","organizations_url":"https://api.github.com/users/dachary/orgs","repos_url":"https://api.github.com/users/dachary/repos","events_url":"https://api.github.com/users/dachary/events{/privacy}","received_events_url":"https://api.github.com/users/dachary/received_events","type":"User","site_admin":false},"body":"## Status\r\n\r\nReady for review\r\n\r\n## Description of Changes\r\n\r\nFixes #2902 \r\n\r\nA docker image that contains all dependencies installed (deb and pip) replaces the former image. The script part (running Xvfb, ./manage.py etc.) is delegated to scripts in the bin directory instead. This minimal image is the basis to run tests, shell interaction, screenshot generation etc.\r\n\r\nThe creation of the image is no longer a separate makefile target: it is always created or updated before running a command in the container. Checking the image does not need to update does not take long and the delay imposed when running a command in the container is minimal.\r\n\r\nThe bin/dev-shell does something different (for docker build and docker run) if it runs in CircleCI or not. It would be unecessarily complicated to unify the two because:\r\n\r\n* bind mounting the directory or running under the same user in the host and in the container is not required for CI\r\n* the docker container does not run on the same host as the CI\r\n* the CI needs explicit instructions to use the Docker cache\r\n\r\nThe bind/dev-deps daemons are run from with functions that capture their output to reduce the output cluter: it is only displayed in case a daemon fails.\r\n\r\nA function to create a demo user with the same credentials as http://demo.securedrop.club is added to facilitate testing.\r\n\r\n## Testing\r\n\r\n* make docs\r\n* firefox localhost:8000 and verify the documentation changes\r\n* run the documentation samples to verify they work as expected\r\n* verify `pytest --pages-layout tests` is run successfully by CI\r\n\r\n## Deployment\r\n\r\nN/A\r\n\r\n## Checklist\r\n\r\n### If you made changes to the app code:\r\n\r\n- [x] Unit and functional tests pass on the development VM\r\n\r\n### If you made changes to the system configuration:\r\n\r\n- [x] [Configuration tests](https://docs.securedrop.org/en/latest/development/testing_configuration_tests.html) pass\r\n\r\n### If you made changes to documentation:\r\n\r\n- [x] Doc linting passed locally\r\n","created_at":"2018-02-09T23:14:27Z","updated_at":"2018-02-15T21:33:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f1ca185766d4306bc7322ee45167e087caa81ab","assignee":null,"assignees":[],"requested_reviewers":[{"login":"conorsch","id":657862,"avatar_url":"https://avatars0.githubusercontent.com/u/657862?v=4","gravatar_id":"","url":"https://api.github.com/users/conorsch","html_url":"https://github.com/conorsch","followers_url":"https://api.github.com/users/conorsch/followers","following_url":"https://api.github.com/users/conorsch/following{/other_user}","gists_url":"https://api.github.com/users/conorsch/gists{/gist_id}","starred_url":"https://api.github.com/users/conorsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conorsch/subscriptions","organizations_url":"https://api.github.com/users/conorsch/orgs","repos_url":"https://api.github.com/users/conorsch/repos","events_url":"https://api.github.com/users/conorsch/events{/privacy}","received_events_url":"https://api.github.com/users/conorsch/received_events","type":"User","site_admin":false},{"login":"msheiny","id":1727935,"avatar_url":"https://avatars0.githubusercontent.com/u/1727935?v=4","gravatar_id":"","url":"https://api.github.com/users/msheiny","html_url":"https://github.com/msheiny","followers_url":"https://api.github.com/users/msheiny/followers","following_url":"https://api.github.com/users/msheiny/following{/other_user}","gists_url":"https://api.github.com/users/msheiny/gists{/gist_id}","starred_url":"https://api.github.com/users/msheiny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msheiny/subscriptions","organizations_url":"https://api.github.com/users/msheiny/orgs","repos_url":"https://api.github.com/users/msheiny/repos","events_url":"https://api.github.com/users/msheiny/events{/privacy}","received_events_url":"https://api.github.com/users/msheiny/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":616447641,"url":"https://api.github.com/repos/freedomofpress/securedrop/labels/development%20env","name":"development env","color":"bfd4f2","default":false},{"id":96394577,"url":"https://api.github.com/repos/freedomofpress/securedrop/labels/feature","name":"feature","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/freedomofpress/securedrop/pulls/2990/commits","review_comments_url":"https://api.github.com/repos/freedomofpress/securedrop/pulls/2990/comments","review_comment_url":"https://api.github.com/repos/freedomofpress/securedrop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/freedomofpress/securedrop/issues/2990/comments","statuses_url":"https://api.github.com/repos/freedomofpress/securedrop/statuses/c8d4e20203b7dfbe2d8e72ec6de3ec79a157ab91","head":{"label":"freedomofpress:wip-dachary-develop-i18n","ref":"wip-dachary-develop-i18n","sha":"c8d4e20203b7dfbe2d8e72ec6de3ec79a157ab91","user":{"login":"freedomofpress","id":5388147,"avatar_url":"https://avatars1.githubusercontent.com/u/5388147?v=4","gravatar_id":"","url":"https://api.github.com/users/freedomofpress","html_url":"https://github.com/freedomofpress","followers_url":"https://api.github.com/users/freedomofpress/followers","following_url":"https://api.github.com/users/freedomofpress/following{/other_user}","gists_url":"https://api.github.com/users/freedomofpress/gists{/gist_id}","starred_url":"https://api.github.com/users/freedomofpress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freedomofpress/subscriptions","organizations_url":"https://api.github.com/users/freedomofpress/orgs","repos_url":"https://api.github.com/users/freedomofpress/repos","events_url":"https://api.github.com/users/freedomofpress/events{/privacy}","received_events_url":"https://api.github.com/users/freedomofpress/received_events","type":"Organization","site_admin":false},"repo":{"id":3156820,"name":"securedrop","full_name":"freedomofpress/securedrop","owner":{"login":"freedomofpress","id":5388147,"avatar_url":"https://avatars1.githubusercontent.com/u/5388147?v=4","gravatar_id":"","url":"https://api.github.com/users/freedomofpress","html_url":"https://github.com/freedomofpress","followers_url":"https://api.github.com/users/freedomofpress/followers","following_url":"https://api.github.com/users/freedomofpress/following{/other_user}","gists_url":"https://api.github.com/users/freedomofpress/gists{/gist_id}","starred_url":"https://api.github.com/users/freedomofpress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freedomofpress/subscriptions","organizations_url":"https://api.github.com/users/freedomofpress/orgs","repos_url":"https://api.github.com/users/freedomofpress/repos","events_url":"https://api.github.com/users/freedomofpress/events{/privacy}","received_events_url":"https://api.github.com/users/freedomofpress/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/freedomofpress/securedrop","description":"GitHub repository for the SecureDrop whistleblower platform. Do not submit tips here!","fork":false,"url":"https://api.github.com/repos/freedomofpress/securedrop","forks_url":"https://api.github.com/repos/freedomofpress/securedrop/forks","keys_url":"https://api.github.com/repos/freedomofpress/securedrop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freedomofpress/securedrop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freedomofpress/securedrop/teams","hooks_url":"https://api.github.com/repos/freedomofpress/securedrop/hooks","issue_events_url":"https://api.github.com/repos/freedomofpress/securedrop/issues/events{/number}","events_url":"https://api.github.com/repos/freedomofpress/securedrop/events","assignees_url":"https://api.github.com/repos/freedomofpress/securedrop/assignees{/user}","branches_url":"https://api.github.com/repos/freedomofpress/securedrop/branches{/branch}","tags_url":"https://api.github.com/repos/freedomofpress/securedrop/tags","blobs_url":"https://api.github.com/repos/freedomofpress/securedrop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freedomofpress/securedrop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freedomofpress/securedrop/git/refs{/sha}","trees_url":"https://api.github.com/repos/freedomofpress/securedrop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freedomofpress/securedrop/statuses/{sha}","languages_url":"https://api.github.com/repos/freedomofpress/securedrop/languages","stargazers_url":"https://api.github.com/repos/freedomofpress/securedrop/stargazers","contributors_url":"https://api.github.com/repos/freedomofpress/securedrop/contributors","subscribers_url":"https://api.github.com/repos/freedomofpress/securedrop/subscribers","subscription_url":"https://api.github.com/repos/freedomofpress/securedrop/subscription","commits_url":"https://api.github.com/repos/freedomofpress/securedrop/commits{/sha}","git_commits_url":"https://api.github.com/repos/freedomofpress/securedrop/git/commits{/sha}","comments_url":"https://api.github.com/repos/freedomofpress/securedrop/comments{/number}","issue_comment_url":"https://api.github.com/repos/freedomofpress/securedrop/issues/comments{/number}","contents_url":"https://api.github.com/repos/freedomofpress/securedrop/contents/{+path}","compare_url":"https://api.github.com/repos/freedomofpress/securedrop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freedomofpress/securedrop/merges","archive_url":"https://api.github.com/repos/freedomofpress/securedrop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freedomofpress/securedrop/downloads","issues_url":"https://api.github.com/repos/freedomofpress/securedrop/issues{/number}","pulls_url":"https://api.github.com/repos/freedomofpress/securedrop/pulls{/number}","milestones_url":"https://api.github.com/repos/freedomofpress/securedrop/milestones{/number}","notifications_url":"https://api.github.com/repos/freedomofpress/securedrop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freedomofpress/securedrop/labels{/name}","releases_url":"https://api.github.com/repos/freedomofpress/securedrop/releases{/id}","deployments_url":"https://api.github.com/repos/freedomofpress/securedrop/deployments","created_at":"2012-01-11T19:57:55Z","updated_at":"2018-02-14T18:47:59Z","pushed_at":"2018-02-15T21:16:39Z","git_url":"git://github.com/freedomofpress/securedrop.git","ssh_url":"git@github.com:freedomofpress/securedrop.git","clone_url":"https://github.com/freedomofpress/securedrop.git","svn_url":"https://github.com/freedomofpress/securedrop","homepage":"https://securedrop.org/","size":63712,"stargazers_count":2325,"watchers_count":2325,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":436,"mirror_url":null,"archived":false,"open_issues_count":357,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":436,"open_issues":357,"watchers":2325,"default_branch":"develop"}},"base":{"label":"freedomofpress:develop","ref":"develop","sha":"e5cc9a0f629d6fe4c16c33f31fbd78341895853c","user":{"login":"freedomofpress","id":5388147,"avatar_url":"https://avatars1.githubusercontent.com/u/5388147?v=4","gravatar_id":"","url":"https://api.github.com/users/freedomofpress","html_url":"https://github.com/freedomofpress","followers_url":"https://api.github.com/users/freedomofpress/followers","following_url":"https://api.github.com/users/freedomofpress/following{/other_user}","gists_url":"https://api.github.com/users/freedomofpress/gists{/gist_id}","starred_url":"https://api.github.com/users/freedomofpress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freedomofpress/subscriptions","organizations_url":"https://api.github.com/users/freedomofpress/orgs","repos_url":"https://api.github.com/users/freedomofpress/repos","events_url":"https://api.github.com/users/freedomofpress/events{/privacy}","received_events_url":"https://api.github.com/users/freedomofpress/received_events","type":"Organization","site_admin":false},"repo":{"id":3156820,"name":"securedrop","full_name":"freedomofpress/securedrop","owner":{"login":"freedomofpress","id":5388147,"avatar_url":"https://avatars1.githubusercontent.com/u/5388147?v=4","gravatar_id":"","url":"https://api.github.com/users/freedomofpress","html_url":"https://github.com/freedomofpress","followers_url":"https://api.github.com/users/freedomofpress/followers","following_url":"https://api.github.com/users/freedomofpress/following{/other_user}","gists_url":"https://api.github.com/users/freedomofpress/gists{/gist_id}","starred_url":"https://api.github.com/users/freedomofpress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freedomofpress/subscriptions","organizations_url":"https://api.github.com/users/freedomofpress/orgs","repos_url":"https://api.github.com/users/freedomofpress/repos","events_url":"https://api.github.com/users/freedomofpress/events{/privacy}","received_events_url":"https://api.github.com/users/freedomofpress/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/freedomofpress/securedrop","description":"GitHub repository for the SecureDrop whistleblower platform. Do not submit tips here!","fork":false,"url":"https://api.github.com/repos/freedomofpress/securedrop","forks_url":"https://api.github.com/repos/freedomofpress/securedrop/forks","keys_url":"https://api.github.com/repos/freedomofpress/securedrop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freedomofpress/securedrop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freedomofpress/securedrop/teams","hooks_url":"https://api.github.com/repos/freedomofpress/securedrop/hooks","issue_events_url":"https://api.github.com/repos/freedomofpress/securedrop/issues/events{/number}","events_url":"https://api.github.com/repos/freedomofpress/securedrop/events","assignees_url":"https://api.github.com/repos/freedomofpress/securedrop/assignees{/user}","branches_url":"https://api.github.com/repos/freedomofpress/securedrop/branches{/branch}","tags_url":"https://api.github.com/repos/freedomofpress/securedrop/tags","blobs_url":"https://api.github.com/repos/freedomofpress/securedrop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freedomofpress/securedrop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freedomofpress/securedrop/git/refs{/sha}","trees_url":"https://api.github.com/repos/freedomofpress/securedrop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freedomofpress/securedrop/statuses/{sha}","languages_url":"https://api.github.com/repos/freedomofpress/securedrop/languages","stargazers_url":"https://api.github.com/repos/freedomofpress/securedrop/stargazers","contributors_url":"https://api.github.com/repos/freedomofpress/securedrop/contributors","subscribers_url":"https://api.github.com/repos/freedomofpress/securedrop/subscribers","subscription_url":"https://api.github.com/repos/freedomofpress/securedrop/subscription","commits_url":"https://api.github.com/repos/freedomofpress/securedrop/commits{/sha}","git_commits_url":"https://api.github.com/repos/freedomofpress/securedrop/git/commits{/sha}","comments_url":"https://api.github.com/repos/freedomofpress/securedrop/comments{/number}","issue_comment_url":"https://api.github.com/repos/freedomofpress/securedrop/issues/comments{/number}","contents_url":"https://api.github.com/repos/freedomofpress/securedrop/contents/{+path}","compare_url":"https://api.github.com/repos/freedomofpress/securedrop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freedomofpress/securedrop/merges","archive_url":"https://api.github.com/repos/freedomofpress/securedrop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freedomofpress/securedrop/downloads","issues_url":"https://api.github.com/repos/freedomofpress/securedrop/issues{/number}","pulls_url":"https://api.github.com/repos/freedomofpress/securedrop/pulls{/number}","milestones_url":"https://api.github.com/repos/freedomofpress/securedrop/milestones{/number}","notifications_url":"https://api.github.com/repos/freedomofpress/securedrop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freedomofpress/securedrop/labels{/name}","releases_url":"https://api.github.com/repos/freedomofpress/securedrop/releases{/id}","deployments_url":"https://api.github.com/repos/freedomofpress/securedrop/deployments","created_at":"2012-01-11T19:57:55Z","updated_at":"2018-02-14T18:47:59Z","pushed_at":"2018-02-15T21:16:39Z","git_url":"git://github.com/freedomofpress/securedrop.git","ssh_url":"git@github.com:freedomofpress/securedrop.git","clone_url":"https://github.com/freedomofpress/securedrop.git","svn_url":"https://github.com/freedomofpress/securedrop","homepage":"https://securedrop.org/","size":63712,"stargazers_count":2325,"watchers_count":2325,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":436,"mirror_url":null,"archived":false,"open_issues_count":357,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":436,"open_issues":357,"watchers":2325,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/freedomofpress/securedrop/pulls/2990"},"html":{"href":"https://github.com/freedomofpress/securedrop/pull/2990"},"issue":{"href":"https://api.github.com/repos/freedomofpress/securedrop/issues/2990"},"comments":{"href":"https://api.github.com/repos/freedomofpress/securedrop/issues/2990/comments"},"review_comments":{"href":"https://api.github.com/repos/freedomofpress/securedrop/pulls/2990/comments"},"review_comment":{"href":"https://api.github.com/repos/freedomofpress/securedrop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/freedomofpress/securedrop/pulls/2990/commits"},"statuses":{"href":"https://api.github.com/repos/freedomofpress/securedrop/statuses/c8d4e20203b7dfbe2d8e72ec6de3ec79a157ab91"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"heartsucker"}}