{"action":"created","comment":{"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments/204577526","pull_request_review_id":139682647,"id":204577526,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDU3NzUyNg==","diff_hunk":"@@ -325,7 +325,7 @@ public override object Clone()\n                     continue;\n                 }\n \n-                send.Inventory.Add(inv);\n+                send.Inventory.Add(new InventoryVector(peer.AddSupportedOptions(InventoryType.MSG_TX), inv.Hash));","path":"src/Stratis.Bitcoin.Features.MemoryPool/MempoolBehavior.cs","position":5,"original_position":5,"commit_id":"265af091dcef52942a3f9f739c9ec0698fd4531c","original_commit_id":"265af091dcef52942a3f9f739c9ec0698fd4531c","user":{"login":"noescape00","id":10259355,"node_id":"MDQ6VXNlcjEwMjU5MzU1","avatar_url":"https://avatars0.githubusercontent.com/u/10259355?v=4","gravatar_id":"","url":"https://api.github.com/users/noescape00","html_url":"https://github.com/noescape00","followers_url":"https://api.github.com/users/noescape00/followers","following_url":"https://api.github.com/users/noescape00/following{/other_user}","gists_url":"https://api.github.com/users/noescape00/gists{/gist_id}","starred_url":"https://api.github.com/users/noescape00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noescape00/subscriptions","organizations_url":"https://api.github.com/users/noescape00/orgs","repos_url":"https://api.github.com/users/noescape00/repos","events_url":"https://api.github.com/users/noescape00/events{/privacy}","received_events_url":"https://api.github.com/users/noescape00/received_events","type":"User","site_admin":false},"body":"Why not \r\n\r\n```\r\ninv.Type = peer.AddSupportedOptions(InventoryType.MSG_TX);\r\nsend.Inventory.Add(inv);\r\n```\r\n\r\nto avoid creating a new instance of `InventoryVector`","created_at":"2018-07-23T22:52:07Z","updated_at":"2018-07-23T22:52:07Z","html_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1703#discussion_r204577526","pull_request_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1703","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments/204577526"},"html":{"href":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1703#discussion_r204577526"},"pull_request":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1703"}}},"pull_request":{"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1703","id":203085521,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMDg1NTIx","html_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1703","diff_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1703.diff","patch_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1703.patch","issue_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1703","number":1703,"state":"open","locked":false,"title":"When sending getdata message for tx inventory add appropriate witness flags","user":{"login":"mikedennis","id":24234359,"node_id":"MDQ6VXNlcjI0MjM0MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/24234359?v=4","gravatar_id":"","url":"https://api.github.com/users/mikedennis","html_url":"https://github.com/mikedennis","followers_url":"https://api.github.com/users/mikedennis/followers","following_url":"https://api.github.com/users/mikedennis/following{/other_user}","gists_url":"https://api.github.com/users/mikedennis/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedennis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedennis/subscriptions","organizations_url":"https://api.github.com/users/mikedennis/orgs","repos_url":"https://api.github.com/users/mikedennis/repos","events_url":"https://api.github.com/users/mikedennis/events{/privacy}","received_events_url":"https://api.github.com/users/mikedennis/received_events","type":"User","site_admin":false},"body":"Related to issue #631 \r\n\r\nI finally think I got to the bottom of this issue. We weren't adding the witness flags when requesting txs using \"getdata\" after receiving inventory. This is why the peers were sending us invalid txs. This fits with the reasoning that Nicolas mentioned in the original issue. I had missed this location when I had looked at this code previously.\r\n\r\nI've been running the bitcoin testnet for a while and haven't seen any of these invalid txs come through yet so I'm hopefully this is the fix.\r\n\r\nI will also try syncing from scratch.","created_at":"2018-07-23T00:22:58Z","updated_at":"2018-07-23T22:52:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"24f0d734ec9378d6e2f1ecf6a3394f41c6b7d251","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1703/commits","review_comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1703/comments","review_comment_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1703/comments","statuses_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/265af091dcef52942a3f9f739c9ec0698fd4531c","head":{"label":"mikedennis:issue-631-1","ref":"issue-631-1","sha":"265af091dcef52942a3f9f739c9ec0698fd4531c","user":{"login":"mikedennis","id":24234359,"node_id":"MDQ6VXNlcjI0MjM0MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/24234359?v=4","gravatar_id":"","url":"https://api.github.com/users/mikedennis","html_url":"https://github.com/mikedennis","followers_url":"https://api.github.com/users/mikedennis/followers","following_url":"https://api.github.com/users/mikedennis/following{/other_user}","gists_url":"https://api.github.com/users/mikedennis/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedennis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedennis/subscriptions","organizations_url":"https://api.github.com/users/mikedennis/orgs","repos_url":"https://api.github.com/users/mikedennis/repos","events_url":"https://api.github.com/users/mikedennis/events{/privacy}","received_events_url":"https://api.github.com/users/mikedennis/received_events","type":"User","site_admin":false},"repo":{"id":96908927,"node_id":"MDEwOlJlcG9zaXRvcnk5NjkwODkyNw==","name":"StratisBitcoinFullNode","full_name":"mikedennis/StratisBitcoinFullNode","owner":{"login":"mikedennis","id":24234359,"node_id":"MDQ6VXNlcjI0MjM0MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/24234359?v=4","gravatar_id":"","url":"https://api.github.com/users/mikedennis","html_url":"https://github.com/mikedennis","followers_url":"https://api.github.com/users/mikedennis/followers","following_url":"https://api.github.com/users/mikedennis/following{/other_user}","gists_url":"https://api.github.com/users/mikedennis/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedennis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedennis/subscriptions","organizations_url":"https://api.github.com/users/mikedennis/orgs","repos_url":"https://api.github.com/users/mikedennis/repos","events_url":"https://api.github.com/users/mikedennis/events{/privacy}","received_events_url":"https://api.github.com/users/mikedennis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mikedennis/StratisBitcoinFullNode","description":"Bitcoin full node in C#","fork":true,"url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode","forks_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/forks","keys_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/teams","hooks_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/hooks","issue_events_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/issues/events{/number}","events_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/events","assignees_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/assignees{/user}","branches_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/branches{/branch}","tags_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/tags","blobs_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/git/refs{/sha}","trees_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/statuses/{sha}","languages_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/languages","stargazers_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/stargazers","contributors_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/contributors","subscribers_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/subscribers","subscription_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/subscription","commits_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/commits{/sha}","git_commits_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/git/commits{/sha}","comments_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/comments{/number}","issue_comment_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/issues/comments{/number}","contents_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/contents/{+path}","compare_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/merges","archive_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/downloads","issues_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/issues{/number}","pulls_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/pulls{/number}","milestones_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/milestones{/number}","notifications_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/labels{/name}","releases_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/releases{/id}","deployments_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/deployments","created_at":"2017-07-11T15:32:38Z","updated_at":"2018-07-21T16:43:16Z","pushed_at":"2018-07-23T00:15:35Z","git_url":"git://github.com/mikedennis/StratisBitcoinFullNode.git","ssh_url":"git@github.com:mikedennis/StratisBitcoinFullNode.git","clone_url":"https://github.com/mikedennis/StratisBitcoinFullNode.git","svn_url":"https://github.com/mikedennis/StratisBitcoinFullNode","homepage":"https://stratisplatform.com","size":34633,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"stratisproject:master","ref":"master","sha":"cd32dd2fb0595aa859c57edfa44ecf7c8e71f232","user":{"login":"stratisproject","id":15229748,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjI5NzQ4","avatar_url":"https://avatars0.githubusercontent.com/u/15229748?v=4","gravatar_id":"","url":"https://api.github.com/users/stratisproject","html_url":"https://github.com/stratisproject","followers_url":"https://api.github.com/users/stratisproject/followers","following_url":"https://api.github.com/users/stratisproject/following{/other_user}","gists_url":"https://api.github.com/users/stratisproject/gists{/gist_id}","starred_url":"https://api.github.com/users/stratisproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratisproject/subscriptions","organizations_url":"https://api.github.com/users/stratisproject/orgs","repos_url":"https://api.github.com/users/stratisproject/repos","events_url":"https://api.github.com/users/stratisproject/events{/privacy}","received_events_url":"https://api.github.com/users/stratisproject/received_events","type":"Organization","site_admin":false},"repo":{"id":67271290,"node_id":"MDEwOlJlcG9zaXRvcnk2NzI3MTI5MA==","name":"StratisBitcoinFullNode","full_name":"stratisproject/StratisBitcoinFullNode","owner":{"login":"stratisproject","id":15229748,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjI5NzQ4","avatar_url":"https://avatars0.githubusercontent.com/u/15229748?v=4","gravatar_id":"","url":"https://api.github.com/users/stratisproject","html_url":"https://github.com/stratisproject","followers_url":"https://api.github.com/users/stratisproject/followers","following_url":"https://api.github.com/users/stratisproject/following{/other_user}","gists_url":"https://api.github.com/users/stratisproject/gists{/gist_id}","starred_url":"https://api.github.com/users/stratisproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratisproject/subscriptions","organizations_url":"https://api.github.com/users/stratisproject/orgs","repos_url":"https://api.github.com/users/stratisproject/repos","events_url":"https://api.github.com/users/stratisproject/events{/privacy}","received_events_url":"https://api.github.com/users/stratisproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stratisproject/StratisBitcoinFullNode","description":"Bitcoin full node in C#","fork":false,"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode","forks_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/forks","keys_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/teams","hooks_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/hooks","issue_events_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/events{/number}","events_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/events","assignees_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/assignees{/user}","branches_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/branches{/branch}","tags_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/tags","blobs_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/refs{/sha}","trees_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/{sha}","languages_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/languages","stargazers_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/stargazers","contributors_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/contributors","subscribers_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/subscribers","subscription_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/subscription","commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/commits{/sha}","git_commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/commits{/sha}","comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/comments{/number}","issue_comment_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/comments{/number}","contents_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/contents/{+path}","compare_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/merges","archive_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/downloads","issues_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues{/number}","pulls_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls{/number}","milestones_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/milestones{/number}","notifications_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/labels{/name}","releases_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/releases{/id}","deployments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/deployments","created_at":"2016-09-03T04:32:51Z","updated_at":"2018-07-23T22:02:53Z","pushed_at":"2018-07-23T22:02:49Z","git_url":"git://github.com/stratisproject/StratisBitcoinFullNode.git","ssh_url":"git@github.com:stratisproject/StratisBitcoinFullNode.git","clone_url":"https://github.com/stratisproject/StratisBitcoinFullNode.git","svn_url":"https://github.com/stratisproject/StratisBitcoinFullNode","homepage":"https://stratisplatform.com","size":31846,"stargazers_count":515,"watchers_count":515,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":231,"mirror_url":null,"archived":false,"open_issues_count":118,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":231,"open_issues":118,"watchers":515,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1703"},"html":{"href":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1703"},"issue":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1703"},"comments":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1703/comments"},"review_comments":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1703/comments"},"review_comment":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1703/commits"},"statuses":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/265af091dcef52942a3f9f739c9ec0698fd4531c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"noescape00"}}