{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/56619","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/56619/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/56619/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/56619/events","html_url":"https://github.com/kubernetes/kubernetes/pull/56619","id":278033053,"node_id":"MDExOlB1bGxSZXF1ZXN0MTU1NTQzNjY1","number":56619,"title":"move runtimeService to generic runtime in kubelet","user":{"login":"oulinbao","id":7589619,"node_id":"MDQ6VXNlcjc1ODk2MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/7589619?v=4","gravatar_id":"","url":"https://api.github.com/users/oulinbao","html_url":"https://github.com/oulinbao","followers_url":"https://api.github.com/users/oulinbao/followers","following_url":"https://api.github.com/users/oulinbao/following{/other_user}","gists_url":"https://api.github.com/users/oulinbao/gists{/gist_id}","starred_url":"https://api.github.com/users/oulinbao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oulinbao/subscriptions","organizations_url":"https://api.github.com/users/oulinbao/orgs","repos_url":"https://api.github.com/users/oulinbao/repos","events_url":"https://api.github.com/users/oulinbao/events{/privacy}","received_events_url":"https://api.github.com/users/oulinbao/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":778118402,"node_id":"MDU6TGFiZWw3NzgxMTg0MDI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/lifecycle/rotten","name":"lifecycle/rotten","color":"604460","default":false},{"id":240247879,"node_id":"MDU6TGFiZWwyNDAyNDc4Nzk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-rebase","name":"needs-rebase","color":"BDBDBD","default":false},{"id":349530249,"node_id":"MDU6TGFiZWwzNDk1MzAyNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":253450895,"node_id":"MDU6TGFiZWwyNTM0NTA4OTU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/S","name":"size/S","color":"77bb00","default":false}],"state":"open","locked":false,"assignee":{"login":"dashpole","id":3262098,"node_id":"MDQ6VXNlcjMyNjIwOTg=","avatar_url":"https://avatars1.githubusercontent.com/u/3262098?v=4","gravatar_id":"","url":"https://api.github.com/users/dashpole","html_url":"https://github.com/dashpole","followers_url":"https://api.github.com/users/dashpole/followers","following_url":"https://api.github.com/users/dashpole/following{/other_user}","gists_url":"https://api.github.com/users/dashpole/gists{/gist_id}","starred_url":"https://api.github.com/users/dashpole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dashpole/subscriptions","organizations_url":"https://api.github.com/users/dashpole/orgs","repos_url":"https://api.github.com/users/dashpole/repos","events_url":"https://api.github.com/users/dashpole/events{/privacy}","received_events_url":"https://api.github.com/users/dashpole/received_events","type":"User","site_admin":false},"assignees":[{"login":"dashpole","id":3262098,"node_id":"MDQ6VXNlcjMyNjIwOTg=","avatar_url":"https://avatars1.githubusercontent.com/u/3262098?v=4","gravatar_id":"","url":"https://api.github.com/users/dashpole","html_url":"https://github.com/dashpole","followers_url":"https://api.github.com/users/dashpole/followers","following_url":"https://api.github.com/users/dashpole/following{/other_user}","gists_url":"https://api.github.com/users/dashpole/gists{/gist_id}","starred_url":"https://api.github.com/users/dashpole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dashpole/subscriptions","organizations_url":"https://api.github.com/users/dashpole/orgs","repos_url":"https://api.github.com/users/dashpole/repos","events_url":"https://api.github.com/users/dashpole/events{/privacy}","received_events_url":"https://api.github.com/users/dashpole/received_events","type":"User","site_admin":false},{"login":"derekwaynecarr","id":6233452,"node_id":"MDQ6VXNlcjYyMzM0NTI=","avatar_url":"https://avatars3.githubusercontent.com/u/6233452?v=4","gravatar_id":"","url":"https://api.github.com/users/derekwaynecarr","html_url":"https://github.com/derekwaynecarr","followers_url":"https://api.github.com/users/derekwaynecarr/followers","following_url":"https://api.github.com/users/derekwaynecarr/following{/other_user}","gists_url":"https://api.github.com/users/derekwaynecarr/gists{/gist_id}","starred_url":"https://api.github.com/users/derekwaynecarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekwaynecarr/subscriptions","organizations_url":"https://api.github.com/users/derekwaynecarr/orgs","repos_url":"https://api.github.com/users/derekwaynecarr/repos","events_url":"https://api.github.com/users/derekwaynecarr/events{/privacy}","received_events_url":"https://api.github.com/users/derekwaynecarr/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2017-11-30T08:18:18Z","updated_at":"2018-07-18T03:57:52Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/56619","html_url":"https://github.com/kubernetes/kubernetes/pull/56619","diff_url":"https://github.com/kubernetes/kubernetes/pull/56619.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/56619.patch"},"body":"**What this PR does / why we need it**:\r\nrefactor runtimeService field in Kubelet struct, move it to kubeGenericRuntimeManager\r\n\r\n**Special notes for your reviewer**:\r\nRuntimeService is used in containerManager start function, and I convert kubecontainer.Runtime to KubeGenericRuntime directly. It seems like that rkt does not use RuntimeService. So, is this modification ok? Do u have other methods? Looking forward your ideas. Thanks.\r\n\r\n**Release note**:\r\n```release-note\r\nNone\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/405801381","html_url":"https://github.com/kubernetes/kubernetes/pull/56619#issuecomment-405801381","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/56619","id":405801381,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTgwMTM4MQ==","user":{"login":"fejta-bot","id":30488982,"node_id":"MDQ6VXNlcjMwNDg4OTgy","avatar_url":"https://avatars1.githubusercontent.com/u/30488982?v=4","gravatar_id":"","url":"https://api.github.com/users/fejta-bot","html_url":"https://github.com/fejta-bot","followers_url":"https://api.github.com/users/fejta-bot/followers","following_url":"https://api.github.com/users/fejta-bot/following{/other_user}","gists_url":"https://api.github.com/users/fejta-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/fejta-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fejta-bot/subscriptions","organizations_url":"https://api.github.com/users/fejta-bot/orgs","repos_url":"https://api.github.com/users/fejta-bot/repos","events_url":"https://api.github.com/users/fejta-bot/events{/privacy}","received_events_url":"https://api.github.com/users/fejta-bot/received_events","type":"User","site_admin":false},"created_at":"2018-07-18T03:57:52Z","updated_at":"2018-07-18T03:57:52Z","author_association":"NONE","body":"Rotten issues close after 30d of inactivity.\nReopen the issue with `/reopen`.\nMark the issue as fresh with `/remove-lifecycle rotten`.\n\nSend feedback to sig-testing, kubernetes/test-infra and/or [fejta](https://github.com/fejta).\n/close"}}
{"actor":{"display_login":"fejta-bot"}}