{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/pulls/comments/190399536","pull_request_review_id":122767852,"id":190399536,"diff_hunk":"@@ -136,7 +136,7 @@ function Controller ($stateParams, CollectionsApi, EventNotifications, ShoppingC\n       targetId: vm.serviceTemplate.id,\n       targetType: 'service_template'\n     }\n-    const url = `${vm.dialogUrl}/${vm.serviceTemplate.id}`\n+    const url = `${vm.dialogUrl}/${vm.dialogId}`","path":"client/app/states/catalogs/details/details.state.js","position":14,"original_position":14,"commit_id":"9a2df894a1566b2d078307b44e4a874ed3189f3e","original_commit_id":"9a2df894a1566b2d078307b44e4a874ed3189f3e","user":{"login":"eclarizio","id":164557,"avatar_url":"https://avatars1.githubusercontent.com/u/164557?v=4","gravatar_id":"","url":"https://api.github.com/users/eclarizio","html_url":"https://github.com/eclarizio","followers_url":"https://api.github.com/users/eclarizio/followers","following_url":"https://api.github.com/users/eclarizio/following{/other_user}","gists_url":"https://api.github.com/users/eclarizio/gists{/gist_id}","starred_url":"https://api.github.com/users/eclarizio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclarizio/subscriptions","organizations_url":"https://api.github.com/users/eclarizio/orgs","repos_url":"https://api.github.com/users/eclarizio/repos","events_url":"https://api.github.com/users/eclarizio/events{/privacy}","received_events_url":"https://api.github.com/users/eclarizio/received_events","type":"User","site_admin":false},"body":"Ah, this won't work. You'll either have to use the id from one of the previous lines (`idList.dialogId`) or use `vm.parsedDialogs.id`.","created_at":"2018-05-23T21:08:19Z","updated_at":"2018-05-23T21:08:19Z","html_url":"https://github.com/ManageIQ/manageiq-ui-service/pull/1438#discussion_r190399536","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/pulls/1438","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/pulls/comments/190399536"},"html":{"href":"https://github.com/ManageIQ/manageiq-ui-service/pull/1438#discussion_r190399536"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/pulls/1438"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/pulls/1438","id":190011949,"html_url":"https://github.com/ManageIQ/manageiq-ui-service/pull/1438","diff_url":"https://github.com/ManageIQ/manageiq-ui-service/pull/1438.diff","patch_url":"https://github.com/ManageIQ/manageiq-ui-service/pull/1438.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/issues/1438","number":1438,"state":"open","locked":false,"title":"[WIP] Change service dialog api call to match CUI","user":{"login":"d-m-u","id":16326669,"avatar_url":"https://avatars0.githubusercontent.com/u/16326669?v=4","gravatar_id":"","url":"https://api.github.com/users/d-m-u","html_url":"https://github.com/d-m-u","followers_url":"https://api.github.com/users/d-m-u/followers","following_url":"https://api.github.com/users/d-m-u/following{/other_user}","gists_url":"https://api.github.com/users/d-m-u/gists{/gist_id}","starred_url":"https://api.github.com/users/d-m-u/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-m-u/subscriptions","organizations_url":"https://api.github.com/users/d-m-u/orgs","repos_url":"https://api.github.com/users/d-m-u/repos","events_url":"https://api.github.com/users/d-m-u/events{/privacy}","received_events_url":"https://api.github.com/users/d-m-u/received_events","type":"User","site_admin":false},"body":"Fix for https://bugzilla.redhat.com/show_bug.cgi?id=1578080 \r\n\r\nThe classic ui api call for service dialogs is the one we should be using so we don't end up with eeeeeeeetooooomaaaaaany automate calls. \r\n\r\nWIP cause tests","created_at":"2018-05-23T15:14:00Z","updated_at":"2018-05-23T21:08:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c46d5034d7dd46588908a6a6607ca8cda13e2a19","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":383077002,"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/labels/blocker","name":"blocker","color":"000000","default":false},{"id":325293601,"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/labels/wip","name":"wip","color":"eeeeee","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/pulls/1438/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/pulls/1438/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/issues/1438/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/statuses/9a2df894a1566b2d078307b44e4a874ed3189f3e","head":{"label":"d-m-u:fixing_sui_api_call_to_match_cui","ref":"fixing_sui_api_call_to_match_cui","sha":"9a2df894a1566b2d078307b44e4a874ed3189f3e","user":{"login":"d-m-u","id":16326669,"avatar_url":"https://avatars0.githubusercontent.com/u/16326669?v=4","gravatar_id":"","url":"https://api.github.com/users/d-m-u","html_url":"https://github.com/d-m-u","followers_url":"https://api.github.com/users/d-m-u/followers","following_url":"https://api.github.com/users/d-m-u/following{/other_user}","gists_url":"https://api.github.com/users/d-m-u/gists{/gist_id}","starred_url":"https://api.github.com/users/d-m-u/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-m-u/subscriptions","organizations_url":"https://api.github.com/users/d-m-u/orgs","repos_url":"https://api.github.com/users/d-m-u/repos","events_url":"https://api.github.com/users/d-m-u/events{/privacy}","received_events_url":"https://api.github.com/users/d-m-u/received_events","type":"User","site_admin":false},"repo":{"id":123594639,"name":"manageiq-ui-service","full_name":"d-m-u/manageiq-ui-service","owner":{"login":"d-m-u","id":16326669,"avatar_url":"https://avatars0.githubusercontent.com/u/16326669?v=4","gravatar_id":"","url":"https://api.github.com/users/d-m-u","html_url":"https://github.com/d-m-u","followers_url":"https://api.github.com/users/d-m-u/followers","following_url":"https://api.github.com/users/d-m-u/following{/other_user}","gists_url":"https://api.github.com/users/d-m-u/gists{/gist_id}","starred_url":"https://api.github.com/users/d-m-u/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-m-u/subscriptions","organizations_url":"https://api.github.com/users/d-m-u/orgs","repos_url":"https://api.github.com/users/d-m-u/repos","events_url":"https://api.github.com/users/d-m-u/events{/privacy}","received_events_url":"https://api.github.com/users/d-m-u/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/d-m-u/manageiq-ui-service","description":"Service UI for ManageIQ","fork":true,"url":"https://api.github.com/repos/d-m-u/manageiq-ui-service","forks_url":"https://api.github.com/repos/d-m-u/manageiq-ui-service/forks","keys_url":"https://api.github.com/repos/d-m-u/manageiq-ui-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d-m-u/manageiq-ui-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d-m-u/manageiq-ui-service/teams","hooks_url":"https://api.github.com/repos/d-m-u/manageiq-ui-service/hooks","issue_events_url":"https://api.github.com/repos/d-m-u/manageiq-ui-service/issues/events{/number}","events_url":"https://api.github.com/repos/d-m-u/manageiq-ui-service/events","assignees_url":"https://api.github.com/repos/d-m-u/manageiq-ui-service/assignees{/user}","branches_url":"https://api.github.com/repos/d-m-u/manageiq-ui-service/branches{/branch}","tags_url":"https://api.github.com/repos/d-m-u/manageiq-ui-service/tags","blobs_url":"https://api.github.com/repos/d-m-u/manageiq-ui-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d-m-u/manageiq-ui-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d-m-u/manageiq-ui-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/d-m-u/manageiq-ui-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d-m-u/manageiq-ui-service/statuses/{sha}","languages_url":"https://api.github.com/repos/d-m-u/manageiq-ui-service/languages","stargazers_url":"https://api.github.com/repos/d-m-u/manageiq-ui-service/stargazers","contributors_url":"https://api.github.com/repos/d-m-u/manageiq-ui-service/contributors","subscribers_url":"https://api.github.com/repos/d-m-u/manageiq-ui-service/subscribers","subscription_url":"https://api.github.com/repos/d-m-u/manageiq-ui-service/subscription","commits_url":"https://api.github.com/repos/d-m-u/manageiq-ui-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/d-m-u/manageiq-ui-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/d-m-u/manageiq-ui-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/d-m-u/manageiq-ui-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/d-m-u/manageiq-ui-service/contents/{+path}","compare_url":"https://api.github.com/repos/d-m-u/manageiq-ui-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d-m-u/manageiq-ui-service/merges","archive_url":"https://api.github.com/repos/d-m-u/manageiq-ui-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d-m-u/manageiq-ui-service/downloads","issues_url":"https://api.github.com/repos/d-m-u/manageiq-ui-service/issues{/number}","pulls_url":"https://api.github.com/repos/d-m-u/manageiq-ui-service/pulls{/number}","milestones_url":"https://api.github.com/repos/d-m-u/manageiq-ui-service/milestones{/number}","notifications_url":"https://api.github.com/repos/d-m-u/manageiq-ui-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d-m-u/manageiq-ui-service/labels{/name}","releases_url":"https://api.github.com/repos/d-m-u/manageiq-ui-service/releases{/id}","deployments_url":"https://api.github.com/repos/d-m-u/manageiq-ui-service/deployments","created_at":"2018-03-02T15:17:39Z","updated_at":"2018-03-02T15:17:41Z","pushed_at":"2018-05-23T15:30:53Z","git_url":"git://github.com/d-m-u/manageiq-ui-service.git","ssh_url":"git@github.com:d-m-u/manageiq-ui-service.git","clone_url":"https://github.com/d-m-u/manageiq-ui-service.git","svn_url":"https://github.com/d-m-u/manageiq-ui-service","homepage":"","size":12612,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"46cc0b7a4c15b07c7e56f0048f6911b85d5fbe96","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":51539656,"name":"manageiq-ui-service","full_name":"ManageIQ/manageiq-ui-service","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq-ui-service","description":"Service UI for ManageIQ","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service","forks_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/deployments","created_at":"2016-02-11T19:17:13Z","updated_at":"2018-05-18T18:37:16Z","pushed_at":"2018-05-23T15:30:54Z","git_url":"git://github.com/ManageIQ/manageiq-ui-service.git","ssh_url":"git@github.com:ManageIQ/manageiq-ui-service.git","clone_url":"https://github.com/ManageIQ/manageiq-ui-service.git","svn_url":"https://github.com/ManageIQ/manageiq-ui-service","homepage":"","size":12697,"stargazers_count":23,"watchers_count":23,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":67,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":67,"open_issues":10,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/pulls/1438"},"html":{"href":"https://github.com/ManageIQ/manageiq-ui-service/pull/1438"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/issues/1438"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/issues/1438/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/pulls/1438/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/pulls/1438/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/statuses/9a2df894a1566b2d078307b44e4a874ed3189f3e"}},"author_association":"NONE"}}
{"actor":{"display_login":"eclarizio"}}