{"action":"created","comment":{"url":"https://api.github.com/repos/replicatedhq/ship/pulls/comments/227110780","pull_request_review_id":167076002,"id":227110780,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzExMDc4MA==","diff_hunk":"@@ -19,8 +19,9 @@ import (\n \t\"gopkg.in/yaml.v2\"\n )\n \n-func DefaultHelmRelease(chartPath string) api.Spec {\n-\treturn api.Spec{\n+func (r *Resolver) DefaultHelmRelease(chartPath string) api.Spec {\n+\tnoOutro := r.Viper.GetBool(\"no-outro\")","path":"pkg/specs/chart.go","position":7,"original_position":7,"commit_id":"ba7b07e743e7ae5b598ec03f706e63d7135d874a","original_commit_id":"ba7b07e743e7ae5b598ec03f706e63d7135d874a","user":{"login":"dexhorthy","id":3730605,"node_id":"MDQ6VXNlcjM3MzA2MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/3730605?v=4","gravatar_id":"","url":"https://api.github.com/users/dexhorthy","html_url":"https://github.com/dexhorthy","followers_url":"https://api.github.com/users/dexhorthy/followers","following_url":"https://api.github.com/users/dexhorthy/following{/other_user}","gists_url":"https://api.github.com/users/dexhorthy/gists{/gist_id}","starred_url":"https://api.github.com/users/dexhorthy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dexhorthy/subscriptions","organizations_url":"https://api.github.com/users/dexhorthy/orgs","repos_url":"https://api.github.com/users/dexhorthy/repos","events_url":"https://api.github.com/users/dexhorthy/events{/privacy}","received_events_url":"https://api.github.com/users/dexhorthy/received_events","type":"User","site_admin":false},"body":"I think in general we prefer to set these as fields on `(r *Resolver)` where possible in the `New` function, rather than accessing `r.Viper` inside a method. \r\n\r\nFor example, check out https://github.com/replicatedhq/ship/blob/master/pkg/ship/ship.go#L79","created_at":"2018-10-22T19:42:04Z","updated_at":"2018-10-22T19:42:04Z","html_url":"https://github.com/replicatedhq/ship/pull/653#discussion_r227110780","pull_request_url":"https://api.github.com/repos/replicatedhq/ship/pulls/653","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/replicatedhq/ship/pulls/comments/227110780"},"html":{"href":"https://github.com/replicatedhq/ship/pull/653#discussion_r227110780"},"pull_request":{"href":"https://api.github.com/repos/replicatedhq/ship/pulls/653"}}},"pull_request":{"url":"https://api.github.com/repos/replicatedhq/ship/pulls/653","id":224788592,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0Nzg4NTky","html_url":"https://github.com/replicatedhq/ship/pull/653","diff_url":"https://github.com/replicatedhq/ship/pull/653.diff","patch_url":"https://github.com/replicatedhq/ship/pull/653.patch","issue_url":"https://api.github.com/repos/replicatedhq/ship/issues/653","number":653,"state":"open","locked":false,"title":"[ch15317] Added no-outro flag for optional confirm step","user":{"login":"10Dimensional","id":4061899,"node_id":"MDQ6VXNlcjQwNjE4OTk=","avatar_url":"https://avatars3.githubusercontent.com/u/4061899?v=4","gravatar_id":"","url":"https://api.github.com/users/10Dimensional","html_url":"https://github.com/10Dimensional","followers_url":"https://api.github.com/users/10Dimensional/followers","following_url":"https://api.github.com/users/10Dimensional/following{/other_user}","gists_url":"https://api.github.com/users/10Dimensional/gists{/gist_id}","starred_url":"https://api.github.com/users/10Dimensional/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/10Dimensional/subscriptions","organizations_url":"https://api.github.com/users/10Dimensional/orgs","repos_url":"https://api.github.com/users/10Dimensional/repos","events_url":"https://api.github.com/users/10Dimensional/events{/privacy}","received_events_url":"https://api.github.com/users/10Dimensional/received_events","type":"User","site_admin":false},"body":"What I Did\r\n------------\r\nAdded a `--no-outro` flag to optionally remove the outro step from the ship lifecycle.\r\n\r\nHow I Did it\r\n------------\r\nAdded boolean `--no-outro` flag in `pkg/cli/root.go`. Then check for the flag when creating the ship lifecycle.\r\n\r\nHow to verify it\r\n------------\r\nRun `ship init` with `--no-outro`\r\n\r\nDescription for the Changelog\r\n------------\r\nAdded a `--no-outro` flag to optionally remove the outro step from the ship lifecycle.\r\n\r\n\r\nPicture of a Boat (not required but encouraged)\r\n------------\r\n⛵️ \r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n<!-- (thanks https://github.com/docker/docker for this template) -->\r\n\r\n","created_at":"2018-10-22T19:34:59Z","updated_at":"2018-10-22T19:42:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"38951befce0c5a63dfb7ed719337b5ccf8e38882","assignee":null,"assignees":[],"requested_reviewers":[{"login":"laverya","id":2318911,"node_id":"MDQ6VXNlcjIzMTg5MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/2318911?v=4","gravatar_id":"","url":"https://api.github.com/users/laverya","html_url":"https://github.com/laverya","followers_url":"https://api.github.com/users/laverya/followers","following_url":"https://api.github.com/users/laverya/following{/other_user}","gists_url":"https://api.github.com/users/laverya/gists{/gist_id}","starred_url":"https://api.github.com/users/laverya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laverya/subscriptions","organizations_url":"https://api.github.com/users/laverya/orgs","repos_url":"https://api.github.com/users/laverya/repos","events_url":"https://api.github.com/users/laverya/events{/privacy}","received_events_url":"https://api.github.com/users/laverya/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/replicatedhq/ship/pulls/653/commits","review_comments_url":"https://api.github.com/repos/replicatedhq/ship/pulls/653/comments","review_comment_url":"https://api.github.com/repos/replicatedhq/ship/pulls/comments{/number}","comments_url":"https://api.github.com/repos/replicatedhq/ship/issues/653/comments","statuses_url":"https://api.github.com/repos/replicatedhq/ship/statuses/ba7b07e743e7ae5b598ec03f706e63d7135d874a","head":{"label":"10Dimensional:master","ref":"master","sha":"ba7b07e743e7ae5b598ec03f706e63d7135d874a","user":{"login":"10Dimensional","id":4061899,"node_id":"MDQ6VXNlcjQwNjE4OTk=","avatar_url":"https://avatars3.githubusercontent.com/u/4061899?v=4","gravatar_id":"","url":"https://api.github.com/users/10Dimensional","html_url":"https://github.com/10Dimensional","followers_url":"https://api.github.com/users/10Dimensional/followers","following_url":"https://api.github.com/users/10Dimensional/following{/other_user}","gists_url":"https://api.github.com/users/10Dimensional/gists{/gist_id}","starred_url":"https://api.github.com/users/10Dimensional/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/10Dimensional/subscriptions","organizations_url":"https://api.github.com/users/10Dimensional/orgs","repos_url":"https://api.github.com/users/10Dimensional/repos","events_url":"https://api.github.com/users/10Dimensional/events{/privacy}","received_events_url":"https://api.github.com/users/10Dimensional/received_events","type":"User","site_admin":false},"repo":{"id":146650711,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY2NTA3MTE=","name":"ship","full_name":"10Dimensional/ship","private":false,"owner":{"login":"10Dimensional","id":4061899,"node_id":"MDQ6VXNlcjQwNjE4OTk=","avatar_url":"https://avatars3.githubusercontent.com/u/4061899?v=4","gravatar_id":"","url":"https://api.github.com/users/10Dimensional","html_url":"https://github.com/10Dimensional","followers_url":"https://api.github.com/users/10Dimensional/followers","following_url":"https://api.github.com/users/10Dimensional/following{/other_user}","gists_url":"https://api.github.com/users/10Dimensional/gists{/gist_id}","starred_url":"https://api.github.com/users/10Dimensional/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/10Dimensional/subscriptions","organizations_url":"https://api.github.com/users/10Dimensional/orgs","repos_url":"https://api.github.com/users/10Dimensional/repos","events_url":"https://api.github.com/users/10Dimensional/events{/privacy}","received_events_url":"https://api.github.com/users/10Dimensional/received_events","type":"User","site_admin":false},"html_url":"https://github.com/10Dimensional/ship","description":"Reducing the Operational Overhead of Maintaining 3rd-party Applications in Kubernetes","fork":true,"url":"https://api.github.com/repos/10Dimensional/ship","forks_url":"https://api.github.com/repos/10Dimensional/ship/forks","keys_url":"https://api.github.com/repos/10Dimensional/ship/keys{/key_id}","collaborators_url":"https://api.github.com/repos/10Dimensional/ship/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/10Dimensional/ship/teams","hooks_url":"https://api.github.com/repos/10Dimensional/ship/hooks","issue_events_url":"https://api.github.com/repos/10Dimensional/ship/issues/events{/number}","events_url":"https://api.github.com/repos/10Dimensional/ship/events","assignees_url":"https://api.github.com/repos/10Dimensional/ship/assignees{/user}","branches_url":"https://api.github.com/repos/10Dimensional/ship/branches{/branch}","tags_url":"https://api.github.com/repos/10Dimensional/ship/tags","blobs_url":"https://api.github.com/repos/10Dimensional/ship/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/10Dimensional/ship/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/10Dimensional/ship/git/refs{/sha}","trees_url":"https://api.github.com/repos/10Dimensional/ship/git/trees{/sha}","statuses_url":"https://api.github.com/repos/10Dimensional/ship/statuses/{sha}","languages_url":"https://api.github.com/repos/10Dimensional/ship/languages","stargazers_url":"https://api.github.com/repos/10Dimensional/ship/stargazers","contributors_url":"https://api.github.com/repos/10Dimensional/ship/contributors","subscribers_url":"https://api.github.com/repos/10Dimensional/ship/subscribers","subscription_url":"https://api.github.com/repos/10Dimensional/ship/subscription","commits_url":"https://api.github.com/repos/10Dimensional/ship/commits{/sha}","git_commits_url":"https://api.github.com/repos/10Dimensional/ship/git/commits{/sha}","comments_url":"https://api.github.com/repos/10Dimensional/ship/comments{/number}","issue_comment_url":"https://api.github.com/repos/10Dimensional/ship/issues/comments{/number}","contents_url":"https://api.github.com/repos/10Dimensional/ship/contents/{+path}","compare_url":"https://api.github.com/repos/10Dimensional/ship/compare/{base}...{head}","merges_url":"https://api.github.com/repos/10Dimensional/ship/merges","archive_url":"https://api.github.com/repos/10Dimensional/ship/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/10Dimensional/ship/downloads","issues_url":"https://api.github.com/repos/10Dimensional/ship/issues{/number}","pulls_url":"https://api.github.com/repos/10Dimensional/ship/pulls{/number}","milestones_url":"https://api.github.com/repos/10Dimensional/ship/milestones{/number}","notifications_url":"https://api.github.com/repos/10Dimensional/ship/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/10Dimensional/ship/labels{/name}","releases_url":"https://api.github.com/repos/10Dimensional/ship/releases{/id}","deployments_url":"https://api.github.com/repos/10Dimensional/ship/deployments","created_at":"2018-08-29T19:51:48Z","updated_at":"2018-10-22T17:28:22Z","pushed_at":"2018-10-22T17:28:20Z","git_url":"git://github.com/10Dimensional/ship.git","ssh_url":"git@github.com:10Dimensional/ship.git","clone_url":"https://github.com/10Dimensional/ship.git","svn_url":"https://github.com/10Dimensional/ship","homepage":"","size":115519,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"replicatedhq:master","ref":"master","sha":"bebf32f7c39f3c1d14130b9401065edffdb4c69e","user":{"login":"replicatedhq","id":13105802,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTA1ODAy","avatar_url":"https://avatars3.githubusercontent.com/u/13105802?v=4","gravatar_id":"","url":"https://api.github.com/users/replicatedhq","html_url":"https://github.com/replicatedhq","followers_url":"https://api.github.com/users/replicatedhq/followers","following_url":"https://api.github.com/users/replicatedhq/following{/other_user}","gists_url":"https://api.github.com/users/replicatedhq/gists{/gist_id}","starred_url":"https://api.github.com/users/replicatedhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/replicatedhq/subscriptions","organizations_url":"https://api.github.com/users/replicatedhq/orgs","repos_url":"https://api.github.com/users/replicatedhq/repos","events_url":"https://api.github.com/users/replicatedhq/events{/privacy}","received_events_url":"https://api.github.com/users/replicatedhq/received_events","type":"Organization","site_admin":false},"repo":{"id":126047712,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYwNDc3MTI=","name":"ship","full_name":"replicatedhq/ship","private":false,"owner":{"login":"replicatedhq","id":13105802,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTA1ODAy","avatar_url":"https://avatars3.githubusercontent.com/u/13105802?v=4","gravatar_id":"","url":"https://api.github.com/users/replicatedhq","html_url":"https://github.com/replicatedhq","followers_url":"https://api.github.com/users/replicatedhq/followers","following_url":"https://api.github.com/users/replicatedhq/following{/other_user}","gists_url":"https://api.github.com/users/replicatedhq/gists{/gist_id}","starred_url":"https://api.github.com/users/replicatedhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/replicatedhq/subscriptions","organizations_url":"https://api.github.com/users/replicatedhq/orgs","repos_url":"https://api.github.com/users/replicatedhq/repos","events_url":"https://api.github.com/users/replicatedhq/events{/privacy}","received_events_url":"https://api.github.com/users/replicatedhq/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/replicatedhq/ship","description":"Reducing the Operational Overhead of Maintaining 3rd-party Applications in Kubernetes","fork":false,"url":"https://api.github.com/repos/replicatedhq/ship","forks_url":"https://api.github.com/repos/replicatedhq/ship/forks","keys_url":"https://api.github.com/repos/replicatedhq/ship/keys{/key_id}","collaborators_url":"https://api.github.com/repos/replicatedhq/ship/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/replicatedhq/ship/teams","hooks_url":"https://api.github.com/repos/replicatedhq/ship/hooks","issue_events_url":"https://api.github.com/repos/replicatedhq/ship/issues/events{/number}","events_url":"https://api.github.com/repos/replicatedhq/ship/events","assignees_url":"https://api.github.com/repos/replicatedhq/ship/assignees{/user}","branches_url":"https://api.github.com/repos/replicatedhq/ship/branches{/branch}","tags_url":"https://api.github.com/repos/replicatedhq/ship/tags","blobs_url":"https://api.github.com/repos/replicatedhq/ship/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/replicatedhq/ship/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/replicatedhq/ship/git/refs{/sha}","trees_url":"https://api.github.com/repos/replicatedhq/ship/git/trees{/sha}","statuses_url":"https://api.github.com/repos/replicatedhq/ship/statuses/{sha}","languages_url":"https://api.github.com/repos/replicatedhq/ship/languages","stargazers_url":"https://api.github.com/repos/replicatedhq/ship/stargazers","contributors_url":"https://api.github.com/repos/replicatedhq/ship/contributors","subscribers_url":"https://api.github.com/repos/replicatedhq/ship/subscribers","subscription_url":"https://api.github.com/repos/replicatedhq/ship/subscription","commits_url":"https://api.github.com/repos/replicatedhq/ship/commits{/sha}","git_commits_url":"https://api.github.com/repos/replicatedhq/ship/git/commits{/sha}","comments_url":"https://api.github.com/repos/replicatedhq/ship/comments{/number}","issue_comment_url":"https://api.github.com/repos/replicatedhq/ship/issues/comments{/number}","contents_url":"https://api.github.com/repos/replicatedhq/ship/contents/{+path}","compare_url":"https://api.github.com/repos/replicatedhq/ship/compare/{base}...{head}","merges_url":"https://api.github.com/repos/replicatedhq/ship/merges","archive_url":"https://api.github.com/repos/replicatedhq/ship/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/replicatedhq/ship/downloads","issues_url":"https://api.github.com/repos/replicatedhq/ship/issues{/number}","pulls_url":"https://api.github.com/repos/replicatedhq/ship/pulls{/number}","milestones_url":"https://api.github.com/repos/replicatedhq/ship/milestones{/number}","notifications_url":"https://api.github.com/repos/replicatedhq/ship/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/replicatedhq/ship/labels{/name}","releases_url":"https://api.github.com/repos/replicatedhq/ship/releases{/id}","deployments_url":"https://api.github.com/repos/replicatedhq/ship/deployments","created_at":"2018-03-20T16:24:26Z","updated_at":"2018-10-19T23:13:21Z","pushed_at":"2018-10-22T19:35:00Z","git_url":"git://github.com/replicatedhq/ship.git","ssh_url":"git@github.com:replicatedhq/ship.git","clone_url":"https://github.com/replicatedhq/ship.git","svn_url":"https://github.com/replicatedhq/ship","homepage":"","size":115326,"stargazers_count":45,"watchers_count":45,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":14,"open_issues":28,"watchers":45,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/replicatedhq/ship/pulls/653"},"html":{"href":"https://github.com/replicatedhq/ship/pull/653"},"issue":{"href":"https://api.github.com/repos/replicatedhq/ship/issues/653"},"comments":{"href":"https://api.github.com/repos/replicatedhq/ship/issues/653/comments"},"review_comments":{"href":"https://api.github.com/repos/replicatedhq/ship/pulls/653/comments"},"review_comment":{"href":"https://api.github.com/repos/replicatedhq/ship/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/replicatedhq/ship/pulls/653/commits"},"statuses":{"href":"https://api.github.com/repos/replicatedhq/ship/statuses/ba7b07e743e7ae5b598ec03f706e63d7135d874a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"dexhorthy"}}