{"action":"closed","number":26256,"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/26256","id":222764763,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNzY0NzYz","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/26256","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/26256.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/26256.patch","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/26256","number":26256,"state":"closed","locked":false,"title":"Add an optional translation context for option items","user":{"login":"Qrox","id":11890223,"node_id":"MDQ6VXNlcjExODkwMjIz","avatar_url":"https://avatars2.githubusercontent.com/u/11890223?v=4","gravatar_id":"","url":"https://api.github.com/users/Qrox","html_url":"https://github.com/Qrox","followers_url":"https://api.github.com/users/Qrox/followers","following_url":"https://api.github.com/users/Qrox/following{/other_user}","gists_url":"https://api.github.com/users/Qrox/gists{/gist_id}","starred_url":"https://api.github.com/users/Qrox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Qrox/subscriptions","organizations_url":"https://api.github.com/users/Qrox/orgs","repos_url":"https://api.github.com/users/Qrox/repos","events_url":"https://api.github.com/users/Qrox/events{/privacy}","received_events_url":"https://api.github.com/users/Qrox/received_events","type":"User","site_admin":false},"body":"#### Summary\r\n```SUMMARY: I18N \"Add an optional translation context for option items\"```\r\n\r\n#### Purpose of change\r\nIn the options for auto pulp/butchery and auto forage, one option is \"disabled\", which is also the name for an effect (as in \"physically disabled\"), and other languages (such as Chinese) may have different words for these two meanings. This PR adds an optional translation context to the option items so they can be properly translated in such cases. The option items for auto pulp/butchery and auto forage are updated to use the new optional translation context.\r\n\r\nAs a bonus, I fixed a place where the code is using the untranslated string's size for popup width calculation.","created_at":"2018-10-15T02:28:51Z","updated_at":"2018-10-25T17:28:46Z","closed_at":"2018-10-25T17:28:46Z","merged_at":null,"merge_commit_sha":"c58d0fff23756d5c6366a7cd10d06303ddb14977","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/26256/commits","review_comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/26256/comments","review_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/26256/comments","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/3334349546ec029bb6e81ffde72107b08125523f","head":{"label":"Qrox:translation-context","ref":"translation-context","sha":"3334349546ec029bb6e81ffde72107b08125523f","user":{"login":"Qrox","id":11890223,"node_id":"MDQ6VXNlcjExODkwMjIz","avatar_url":"https://avatars2.githubusercontent.com/u/11890223?v=4","gravatar_id":"","url":"https://api.github.com/users/Qrox","html_url":"https://github.com/Qrox","followers_url":"https://api.github.com/users/Qrox/followers","following_url":"https://api.github.com/users/Qrox/following{/other_user}","gists_url":"https://api.github.com/users/Qrox/gists{/gist_id}","starred_url":"https://api.github.com/users/Qrox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Qrox/subscriptions","organizations_url":"https://api.github.com/users/Qrox/orgs","repos_url":"https://api.github.com/users/Qrox/repos","events_url":"https://api.github.com/users/Qrox/events{/privacy}","received_events_url":"https://api.github.com/users/Qrox/received_events","type":"User","site_admin":false},"repo":{"id":87902528,"node_id":"MDEwOlJlcG9zaXRvcnk4NzkwMjUyOA==","name":"Cataclysm-DDA","full_name":"Qrox/Cataclysm-DDA","private":false,"owner":{"login":"Qrox","id":11890223,"node_id":"MDQ6VXNlcjExODkwMjIz","avatar_url":"https://avatars2.githubusercontent.com/u/11890223?v=4","gravatar_id":"","url":"https://api.github.com/users/Qrox","html_url":"https://github.com/Qrox","followers_url":"https://api.github.com/users/Qrox/followers","following_url":"https://api.github.com/users/Qrox/following{/other_user}","gists_url":"https://api.github.com/users/Qrox/gists{/gist_id}","starred_url":"https://api.github.com/users/Qrox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Qrox/subscriptions","organizations_url":"https://api.github.com/users/Qrox/orgs","repos_url":"https://api.github.com/users/Qrox/repos","events_url":"https://api.github.com/users/Qrox/events{/privacy}","received_events_url":"https://api.github.com/users/Qrox/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Qrox/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":true,"url":"https://api.github.com/repos/Qrox/Cataclysm-DDA","forks_url":"https://api.github.com/repos/Qrox/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/Qrox/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Qrox/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Qrox/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/Qrox/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/Qrox/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/Qrox/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/Qrox/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/Qrox/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/Qrox/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/Qrox/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Qrox/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Qrox/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/Qrox/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Qrox/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/Qrox/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/Qrox/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/Qrox/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/Qrox/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/Qrox/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/Qrox/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/Qrox/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/Qrox/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/Qrox/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/Qrox/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/Qrox/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Qrox/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/Qrox/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Qrox/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/Qrox/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/Qrox/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/Qrox/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/Qrox/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Qrox/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/Qrox/Cataclysm-DDA/releases{/id}","deployments_url":"https://api.github.com/repos/Qrox/Cataclysm-DDA/deployments","created_at":"2017-04-11T07:18:23Z","updated_at":"2018-09-14T10:40:26Z","pushed_at":"2018-10-25T15:52:55Z","git_url":"git://github.com/Qrox/Cataclysm-DDA.git","ssh_url":"git@github.com:Qrox/Cataclysm-DDA.git","clone_url":"https://github.com/Qrox/Cataclysm-DDA.git","svn_url":"https://github.com/Qrox/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":1356248,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CleverRaven:master","ref":"master","sha":"fbe9044f4ec9945620888a51a1c8c85644885e51","user":{"login":"CleverRaven","id":4367009,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNjcwMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/4367009?v=4","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"repo":{"id":5973855,"node_id":"MDEwOlJlcG9zaXRvcnk1OTczODU1","name":"Cataclysm-DDA","full_name":"CleverRaven/Cataclysm-DDA","private":false,"owner":{"login":"CleverRaven","id":4367009,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNjcwMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/4367009?v=4","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CleverRaven/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.","fork":false,"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","forks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/releases{/id}","deployments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/deployments","created_at":"2012-09-26T22:57:43Z","updated_at":"2018-10-25T15:22:04Z","pushed_at":"2018-10-25T17:27:33Z","git_url":"git://github.com/CleverRaven/Cataclysm-DDA.git","ssh_url":"git@github.com:CleverRaven/Cataclysm-DDA.git","clone_url":"https://github.com/CleverRaven/Cataclysm-DDA.git","svn_url":"https://github.com/CleverRaven/Cataclysm-DDA","homepage":"http://cataclysmdda.org","size":1356094,"stargazers_count":2202,"watchers_count":2202,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1470,"mirror_url":null,"archived":false,"open_issues_count":1089,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1470,"open_issues":1089,"watchers":2202,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/26256"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/26256"},"issue":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/26256"},"comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/26256/comments"},"review_comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/26256/comments"},"review_comment":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/26256/commits"},"statuses":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/3334349546ec029bb6e81ffde72107b08125523f"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":29,"deletions":12,"changed_files":2}}
{"actor":{"display_login":"Qrox"}}