{"action":"created","issue":{"url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/10941","repository_url":"https://api.github.com/repos/Yoast/wordpress-seo","labels_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/10941/labels{/name}","comments_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/10941/comments","events_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/10941/events","html_url":"https://github.com/Yoast/wordpress-seo/pull/10941","id":358034379,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzOTAyMjc4","number":10941,"title":"Fix FAQ title and element names","user":{"login":"IreneStr","id":17744553,"node_id":"MDQ6VXNlcjE3NzQ0NTUz","avatar_url":"https://avatars3.githubusercontent.com/u/17744553?v=4","gravatar_id":"","url":"https://api.github.com/users/IreneStr","html_url":"https://github.com/IreneStr","followers_url":"https://api.github.com/users/IreneStr/followers","following_url":"https://api.github.com/users/IreneStr/following{/other_user}","gists_url":"https://api.github.com/users/IreneStr/gists{/gist_id}","starred_url":"https://api.github.com/users/IreneStr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IreneStr/subscriptions","organizations_url":"https://api.github.com/users/IreneStr/orgs","repos_url":"https://api.github.com/users/IreneStr/repos","events_url":"https://api.github.com/users/IreneStr/events{/privacy}","received_events_url":"https://api.github.com/users/IreneStr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-09-07T11:43:24Z","updated_at":"2018-09-07T12:20:02Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/10941","html_url":"https://github.com/Yoast/wordpress-seo/pull/10941","diff_url":"https://github.com/Yoast/wordpress-seo/pull/10941.diff","patch_url":"https://github.com/Yoast/wordpress-seo/pull/10941.patch"},"body":"## Summary\r\n\r\nThis PR can be summarized in the following changelog entry:\r\n\r\n* N/A\r\n\r\n## Relevant technical choices:\r\n\r\n* Renamed HTML elements (see issue).\r\n* Changed the`<strong>` title to a `<h2>`.\r\n\r\n### Old HTML:\r\n````html\r\n<script type=\"application/ld+json\">{\"@context\":\"http:\\/\\/schema.org\",\"@graph\":[{\"@type\":\"FAQPage\",\"name\":\"This is a title\"},{\"@type\":\"Question\",\"name\":\"Question 1\",\"answerCount\":1,\"acceptedAnswer\":{\"@type\":\"Answer\",\"text\":\"Answer 1\"}},{\"@type\":\"Question\",\"name\":\"Question 2\",\"answerCount\":1,\"acceptedAnswer\":{\"@type\":\"Answer\",\"text\":\"Answer 2\"}}]}</script>\r\n<div class=\"schema-faq wp-block-yoast-faq-block\">\r\n  <strong class=\"schema-faq-title\" id=\"this-is-a-title\">This is a title</strong>\r\n    <div class=\"schema-faq-question\"><strong class=\"schema-faq-question-question\">Question 1</strong>\r\n        <p class=\"schema-faq-question-answer\">Answer 1</p>\r\n    </div>\r\n    <div class=\"schema-faq-question\"><strong class=\"schema-faq-question-question\">Question 2</strong>\r\n        <p class=\"schema-faq-question-answer\">Answer 2</p>\r\n    </div>\r\n</div>\r\n````\r\n\r\n### New HTML:\r\n````html\r\n<script type=\"application/ld+json\">{\"@context\":\"http:\\/\\/schema.org\",\"@graph\":[{\"@type\":\"FAQPage\",\"name\":\"This is a title\"},{\"@type\":\"Question\",\"name\":\"Question 1\",\"answerCount\":1,\"acceptedAnswer\":{\"@type\":\"Answer\",\"text\":\"Answer 1\"}},{\"@type\":\"Question\",\"name\":\"Question 2\",\"answerCount\":1,\"acceptedAnswer\":{\"@type\":\"Answer\",\"text\":\"Answer 2\"}}]}</script>\r\n<div class=\"schema-faq wp-block-yoast-faq-block\">\r\n    <h2 class=\"schema-faq-title\" id=\"this-is-a-title\">This is a title</h2>\r\n    <div class=\"schema-faq-section\"><strong class=\"schema-faq-question\">Question 1</strong>\r\n        <p class=\"schema-faq-answer\">Answer 1</p>\r\n    </div>\r\n    <div class=\"schema-faq-section\"><strong class=\"schema-faq-question\">Question 2</strong>\r\n        <p class=\"schema-faq-answer\">Answer 2</p>\r\n    </div>\r\n</div>\r\n````\r\n\r\n## Test instructions\r\n\r\nThis PR can be tested by following these steps:\r\n\r\n* Don't forget to build the CSS. `yarn start` will not build the CSS.\r\n* Check that the FAQ title is a H2 **on both the backend and the frontend** (view page source).\r\n* Check that all HTML elements on the frontend (view page source) are renamed properly. See #10937 for the old and new names.\r\n\r\n## Quality assurance\r\n\r\n* [x] I have tested this code to the best of my abilities\r\n* [ ] I have added unit tests to verify the code works as intended\r\n\r\nFixes #10937 \r\n"},"comment":{"url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/comments/419422195","html_url":"https://github.com/Yoast/wordpress-seo/pull/10941#issuecomment-419422195","issue_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/10941","id":419422195,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTQyMjE5NQ==","user":{"login":"andizer","id":325040,"node_id":"MDQ6VXNlcjMyNTA0MA==","avatar_url":"https://avatars0.githubusercontent.com/u/325040?v=4","gravatar_id":"","url":"https://api.github.com/users/andizer","html_url":"https://github.com/andizer","followers_url":"https://api.github.com/users/andizer/followers","following_url":"https://api.github.com/users/andizer/following{/other_user}","gists_url":"https://api.github.com/users/andizer/gists{/gist_id}","starred_url":"https://api.github.com/users/andizer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andizer/subscriptions","organizations_url":"https://api.github.com/users/andizer/orgs","repos_url":"https://api.github.com/users/andizer/repos","events_url":"https://api.github.com/users/andizer/events{/privacy}","received_events_url":"https://api.github.com/users/andizer/received_events","type":"User","site_admin":false},"created_at":"2018-09-07T12:20:02Z","updated_at":"2018-09-07T12:20:02Z","author_association":"CONTRIBUTOR","body":"Acceptance done 👍 "}}
{"actor":{"display_login":"andizer"}}