{"action":"created","issue":{"url":"https://api.github.com/repos/libgit2/libgit2/issues/4732","repository_url":"https://api.github.com/repos/libgit2/libgit2","labels_url":"https://api.github.com/repos/libgit2/libgit2/issues/4732/labels{/name}","comments_url":"https://api.github.com/repos/libgit2/libgit2/issues/4732/comments","events_url":"https://api.github.com/repos/libgit2/libgit2/issues/4732/events","html_url":"https://github.com/libgit2/libgit2/pull/4732","id":343245615,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyOTU0OTM0","number":4732,"title":"Squash some leaks","user":{"login":"ethomson","id":1130014,"node_id":"MDQ6VXNlcjExMzAwMTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1130014?v=4","gravatar_id":"","url":"https://api.github.com/users/ethomson","html_url":"https://github.com/ethomson","followers_url":"https://api.github.com/users/ethomson/followers","following_url":"https://api.github.com/users/ethomson/following{/other_user}","gists_url":"https://api.github.com/users/ethomson/gists{/gist_id}","starred_url":"https://api.github.com/users/ethomson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethomson/subscriptions","organizations_url":"https://api.github.com/users/ethomson/orgs","repos_url":"https://api.github.com/users/ethomson/repos","events_url":"https://api.github.com/users/ethomson/events{/privacy}","received_events_url":"https://api.github.com/users/ethomson/received_events","type":"User","site_admin":false},"labels":[{"id":1025924465,"node_id":"MDU6TGFiZWwxMDI1OTI0NDY1","url":"https://api.github.com/repos/libgit2/libgit2/labels/backport-0.27.6","name":"backport-0.27.6","color":"9cb5e2","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-07-20T20:58:59Z","updated_at":"2018-12-14T14:42:57Z","closed_at":"2018-07-23T11:38:41Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/libgit2/libgit2/pulls/4732","html_url":"https://github.com/libgit2/libgit2/pull/4732","diff_url":"https://github.com/libgit2/libgit2/pull/4732.diff","patch_url":"https://github.com/libgit2/libgit2/pull/4732.patch"},"body":"When running valgrind on the `online::push` tests, some leaks became apparent.  Two in the tests themselves, one in the product code that occurs when restarting a push on an existing remote."},"comment":{"url":"https://api.github.com/repos/libgit2/libgit2/issues/comments/447345328","html_url":"https://github.com/libgit2/libgit2/pull/4732#issuecomment-447345328","issue_url":"https://api.github.com/repos/libgit2/libgit2/issues/4732","id":447345328,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NzM0NTMyOA==","user":{"login":"carlosmn","id":335443,"node_id":"MDQ6VXNlcjMzNTQ0Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/335443?v=4","gravatar_id":"","url":"https://api.github.com/users/carlosmn","html_url":"https://github.com/carlosmn","followers_url":"https://api.github.com/users/carlosmn/followers","following_url":"https://api.github.com/users/carlosmn/following{/other_user}","gists_url":"https://api.github.com/users/carlosmn/gists{/gist_id}","starred_url":"https://api.github.com/users/carlosmn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlosmn/subscriptions","organizations_url":"https://api.github.com/users/carlosmn/orgs","repos_url":"https://api.github.com/users/carlosmn/repos","events_url":"https://api.github.com/users/carlosmn/events{/privacy}","received_events_url":"https://api.github.com/users/carlosmn/received_events","type":"User","site_admin":true},"created_at":"2018-12-14T14:42:57Z","updated_at":"2018-12-14T14:42:57Z","author_association":"MEMBER","body":"The built-in transports store a partsed version of the url themselves during initialisation and ignore the URL passed in in `action`.\r\n\r\nThis does look like a bug in the aforementioned commit. We run `git_smart__reset_stream` all the time in RPC (i.e. HTTP) mode and while it might make sense to clear the current stream, we definitely want to keep the url around."}}
{"actor":{"display_login":"carlosmn"}}