{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/237101196","pull_request_review_id":179317250,"id":237101196,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzEwMTE5Ng==","diff_hunk":"@@ -230,9 +230,17 @@ class CommandOutput {\n class Job {\n public:\n   enum class Condition {\n+    // There was no input map, or the map makred this Job as dirty","path":"include/swift/Driver/Job.h","position":4,"original_position":4,"commit_id":"4c61354ff8fb47cdc0c0b1a65d2d4e9745c13160","original_commit_id":"4c61354ff8fb47cdc0c0b1a65d2d4e9745c13160","user":{"login":"Azoy","id":11344077,"node_id":"MDQ6VXNlcjExMzQ0MDc3","avatar_url":"https://avatars2.githubusercontent.com/u/11344077?v=4","gravatar_id":"","url":"https://api.github.com/users/Azoy","html_url":"https://github.com/Azoy","followers_url":"https://api.github.com/users/Azoy/followers","following_url":"https://api.github.com/users/Azoy/following{/other_user}","gists_url":"https://api.github.com/users/Azoy/gists{/gist_id}","starred_url":"https://api.github.com/users/Azoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azoy/subscriptions","organizations_url":"https://api.github.com/users/Azoy/orgs","repos_url":"https://api.github.com/users/Azoy/repos","events_url":"https://api.github.com/users/Azoy/events{/privacy}","received_events_url":"https://api.github.com/users/Azoy/received_events","type":"User","site_admin":false},"body":"Typo: `marked`","created_at":"2018-11-28T14:18:38Z","updated_at":"2018-11-28T14:18:45Z","html_url":"https://github.com/apple/swift/pull/20823#discussion_r237101196","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/20823","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/237101196"},"html":{"href":"https://github.com/apple/swift/pull/20823#discussion_r237101196"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/20823"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/20823","id":234152605,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0MTUyNjA1","html_url":"https://github.com/apple/swift/pull/20823","diff_url":"https://github.com/apple/swift/pull/20823.diff","patch_url":"https://github.com/apple/swift/pull/20823.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/20823","number":20823,"state":"open","locked":false,"title":"[Driver] NFC: Added some comments around incremental compilation.","user":{"login":"davidungar","id":461264,"node_id":"MDQ6VXNlcjQ2MTI2NA==","avatar_url":"https://avatars1.githubusercontent.com/u/461264?v=4","gravatar_id":"","url":"https://api.github.com/users/davidungar","html_url":"https://github.com/davidungar","followers_url":"https://api.github.com/users/davidungar/followers","following_url":"https://api.github.com/users/davidungar/following{/other_user}","gists_url":"https://api.github.com/users/davidungar/gists{/gist_id}","starred_url":"https://api.github.com/users/davidungar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidungar/subscriptions","organizations_url":"https://api.github.com/users/davidungar/orgs","repos_url":"https://api.github.com/users/davidungar/repos","events_url":"https://api.github.com/users/davidungar/events{/privacy}","received_events_url":"https://api.github.com/users/davidungar/received_events","type":"User","site_admin":false},"body":"<!-- What's in this pull request? -->\r\nBased on my own investigation, and conversations with Jordan, have added some comments. Zero changes to actual code. Pay particular attention to the comment for `InitialOutOfDateCommands`, where (if I read the code right) I had to reverse the sense of a comment. Either the code or the comment was wrong before.\r\n\r\n<!-- If this pull request resolves any bugs in the Swift bug tracker, provide a link: -->\r\n\r\n\r\n<!--\r\nBefore merging this pull request, you must run the Swift continuous integration tests.\r\nFor information about triggering CI builds via @swift-ci, see:\r\nhttps://github.com/apple/swift/blob/master/docs/ContinuousIntegration.md#swift-ci\r\n\r\nThank you for your contribution to Swift!\r\n-->","created_at":"2018-11-28T05:28:38Z","updated_at":"2018-11-28T14:18:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f1d224ae45f8d06b029261a530a8f92a6584f5b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"graydon","id":14097,"node_id":"MDQ6VXNlcjE0MDk3","avatar_url":"https://avatars3.githubusercontent.com/u/14097?v=4","gravatar_id":"","url":"https://api.github.com/users/graydon","html_url":"https://github.com/graydon","followers_url":"https://api.github.com/users/graydon/followers","following_url":"https://api.github.com/users/graydon/following{/other_user}","gists_url":"https://api.github.com/users/graydon/gists{/gist_id}","starred_url":"https://api.github.com/users/graydon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graydon/subscriptions","organizations_url":"https://api.github.com/users/graydon/orgs","repos_url":"https://api.github.com/users/graydon/repos","events_url":"https://api.github.com/users/graydon/events{/privacy}","received_events_url":"https://api.github.com/users/graydon/received_events","type":"User","site_admin":false},{"login":"jrose-apple","id":15097531,"node_id":"MDQ6VXNlcjE1MDk3NTMx","avatar_url":"https://avatars2.githubusercontent.com/u/15097531?v=4","gravatar_id":"","url":"https://api.github.com/users/jrose-apple","html_url":"https://github.com/jrose-apple","followers_url":"https://api.github.com/users/jrose-apple/followers","following_url":"https://api.github.com/users/jrose-apple/following{/other_user}","gists_url":"https://api.github.com/users/jrose-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/jrose-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrose-apple/subscriptions","organizations_url":"https://api.github.com/users/jrose-apple/orgs","repos_url":"https://api.github.com/users/jrose-apple/repos","events_url":"https://api.github.com/users/jrose-apple/events{/privacy}","received_events_url":"https://api.github.com/users/jrose-apple/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/20823/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/20823/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/20823/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/4c61354ff8fb47cdc0c0b1a65d2d4e9745c13160","head":{"label":"davidungar:master-with-comments","ref":"master-with-comments","sha":"4c61354ff8fb47cdc0c0b1a65d2d4e9745c13160","user":{"login":"davidungar","id":461264,"node_id":"MDQ6VXNlcjQ2MTI2NA==","avatar_url":"https://avatars1.githubusercontent.com/u/461264?v=4","gravatar_id":"","url":"https://api.github.com/users/davidungar","html_url":"https://github.com/davidungar","followers_url":"https://api.github.com/users/davidungar/followers","following_url":"https://api.github.com/users/davidungar/following{/other_user}","gists_url":"https://api.github.com/users/davidungar/gists{/gist_id}","starred_url":"https://api.github.com/users/davidungar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidungar/subscriptions","organizations_url":"https://api.github.com/users/davidungar/orgs","repos_url":"https://api.github.com/users/davidungar/repos","events_url":"https://api.github.com/users/davidungar/events{/privacy}","received_events_url":"https://api.github.com/users/davidungar/received_events","type":"User","site_admin":false},"repo":{"id":100639829,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA2Mzk4Mjk=","name":"swift","full_name":"davidungar/swift","private":false,"owner":{"login":"davidungar","id":461264,"node_id":"MDQ6VXNlcjQ2MTI2NA==","avatar_url":"https://avatars1.githubusercontent.com/u/461264?v=4","gravatar_id":"","url":"https://api.github.com/users/davidungar","html_url":"https://github.com/davidungar","followers_url":"https://api.github.com/users/davidungar/followers","following_url":"https://api.github.com/users/davidungar/following{/other_user}","gists_url":"https://api.github.com/users/davidungar/gists{/gist_id}","starred_url":"https://api.github.com/users/davidungar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidungar/subscriptions","organizations_url":"https://api.github.com/users/davidungar/orgs","repos_url":"https://api.github.com/users/davidungar/repos","events_url":"https://api.github.com/users/davidungar/events{/privacy}","received_events_url":"https://api.github.com/users/davidungar/received_events","type":"User","site_admin":false},"html_url":"https://github.com/davidungar/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/davidungar/swift","forks_url":"https://api.github.com/repos/davidungar/swift/forks","keys_url":"https://api.github.com/repos/davidungar/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidungar/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidungar/swift/teams","hooks_url":"https://api.github.com/repos/davidungar/swift/hooks","issue_events_url":"https://api.github.com/repos/davidungar/swift/issues/events{/number}","events_url":"https://api.github.com/repos/davidungar/swift/events","assignees_url":"https://api.github.com/repos/davidungar/swift/assignees{/user}","branches_url":"https://api.github.com/repos/davidungar/swift/branches{/branch}","tags_url":"https://api.github.com/repos/davidungar/swift/tags","blobs_url":"https://api.github.com/repos/davidungar/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidungar/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidungar/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidungar/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidungar/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/davidungar/swift/languages","stargazers_url":"https://api.github.com/repos/davidungar/swift/stargazers","contributors_url":"https://api.github.com/repos/davidungar/swift/contributors","subscribers_url":"https://api.github.com/repos/davidungar/swift/subscribers","subscription_url":"https://api.github.com/repos/davidungar/swift/subscription","commits_url":"https://api.github.com/repos/davidungar/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidungar/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidungar/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidungar/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidungar/swift/contents/{+path}","compare_url":"https://api.github.com/repos/davidungar/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidungar/swift/merges","archive_url":"https://api.github.com/repos/davidungar/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidungar/swift/downloads","issues_url":"https://api.github.com/repos/davidungar/swift/issues{/number}","pulls_url":"https://api.github.com/repos/davidungar/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/davidungar/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/davidungar/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidungar/swift/labels{/name}","releases_url":"https://api.github.com/repos/davidungar/swift/releases{/id}","deployments_url":"https://api.github.com/repos/davidungar/swift/deployments","created_at":"2017-08-17T19:50:47Z","updated_at":"2017-08-17T19:51:19Z","pushed_at":"2018-11-28T07:41:17Z","git_url":"git://github.com/davidungar/swift.git","ssh_url":"git@github.com:davidungar/swift.git","clone_url":"https://github.com/davidungar/swift.git","svn_url":"https://github.com/davidungar/swift","homepage":"https://swift.org/","size":346862,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"1cf17d9e7bce62d20fd1a988f3bad5578368d3c4","user":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"node_id":"MDEwOlJlcG9zaXRvcnk0NDgzODk0OQ==","name":"swift","full_name":"apple/swift","private":false,"owner":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2018-11-28T12:30:13Z","pushed_at":"2018-11-28T08:50:11Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org","size":367374,"stargazers_count":45864,"watchers_count":45864,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7283,"mirror_url":null,"archived":false,"open_issues_count":441,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7283,"open_issues":441,"watchers":45864,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/20823"},"html":{"href":"https://github.com/apple/swift/pull/20823"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/20823"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/20823/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/20823/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/20823/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/4c61354ff8fb47cdc0c0b1a65d2d4e9745c13160"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Azoy"}}