{"action":"created","issue":{"url":"https://api.github.com/repos/openjournals/joss-reviews/issues/766","repository_url":"https://api.github.com/repos/openjournals/joss-reviews","labels_url":"https://api.github.com/repos/openjournals/joss-reviews/issues/766/labels{/name}","comments_url":"https://api.github.com/repos/openjournals/joss-reviews/issues/766/comments","events_url":"https://api.github.com/repos/openjournals/joss-reviews/issues/766/events","html_url":"https://github.com/openjournals/joss-reviews/issues/766","id":329822612,"node_id":"MDU6SXNzdWUzMjk4MjI2MTI=","number":766,"title":"[REVIEW]: General binary file parser.","user":{"login":"whedon","id":18508068,"node_id":"MDQ6VXNlcjE4NTA4MDY4","avatar_url":"https://avatars3.githubusercontent.com/u/18508068?v=4","gravatar_id":"","url":"https://api.github.com/users/whedon","html_url":"https://github.com/whedon","followers_url":"https://api.github.com/users/whedon/followers","following_url":"https://api.github.com/users/whedon/following{/other_user}","gists_url":"https://api.github.com/users/whedon/gists{/gist_id}","starred_url":"https://api.github.com/users/whedon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whedon/subscriptions","organizations_url":"https://api.github.com/users/whedon/orgs","repos_url":"https://api.github.com/users/whedon/repos","events_url":"https://api.github.com/users/whedon/events{/privacy}","received_events_url":"https://api.github.com/users/whedon/received_events","type":"User","site_admin":false},"labels":[{"id":330465313,"node_id":"MDU6TGFiZWwzMzA0NjUzMTM=","url":"https://api.github.com/repos/openjournals/joss-reviews/labels/review","name":"review","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"hainesr","id":143558,"node_id":"MDQ6VXNlcjE0MzU1OA==","avatar_url":"https://avatars3.githubusercontent.com/u/143558?v=4","gravatar_id":"","url":"https://api.github.com/users/hainesr","html_url":"https://github.com/hainesr","followers_url":"https://api.github.com/users/hainesr/followers","following_url":"https://api.github.com/users/hainesr/following{/other_user}","gists_url":"https://api.github.com/users/hainesr/gists{/gist_id}","starred_url":"https://api.github.com/users/hainesr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hainesr/subscriptions","organizations_url":"https://api.github.com/users/hainesr/orgs","repos_url":"https://api.github.com/users/hainesr/repos","events_url":"https://api.github.com/users/hainesr/events{/privacy}","received_events_url":"https://api.github.com/users/hainesr/received_events","type":"User","site_admin":false},"assignees":[{"login":"hainesr","id":143558,"node_id":"MDQ6VXNlcjE0MzU1OA==","avatar_url":"https://avatars3.githubusercontent.com/u/143558?v=4","gravatar_id":"","url":"https://api.github.com/users/hainesr","html_url":"https://github.com/hainesr","followers_url":"https://api.github.com/users/hainesr/followers","following_url":"https://api.github.com/users/hainesr/following{/other_user}","gists_url":"https://api.github.com/users/hainesr/gists{/gist_id}","starred_url":"https://api.github.com/users/hainesr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hainesr/subscriptions","organizations_url":"https://api.github.com/users/hainesr/orgs","repos_url":"https://api.github.com/users/hainesr/repos","events_url":"https://api.github.com/users/hainesr/events{/privacy}","received_events_url":"https://api.github.com/users/hainesr/received_events","type":"User","site_admin":false},{"login":"Smattr","id":203893,"node_id":"MDQ6VXNlcjIwMzg5Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/203893?v=4","gravatar_id":"","url":"https://api.github.com/users/Smattr","html_url":"https://github.com/Smattr","followers_url":"https://api.github.com/users/Smattr/followers","following_url":"https://api.github.com/users/Smattr/following{/other_user}","gists_url":"https://api.github.com/users/Smattr/gists{/gist_id}","starred_url":"https://api.github.com/users/Smattr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Smattr/subscriptions","organizations_url":"https://api.github.com/users/Smattr/orgs","repos_url":"https://api.github.com/users/Smattr/repos","events_url":"https://api.github.com/users/Smattr/events{/privacy}","received_events_url":"https://api.github.com/users/Smattr/received_events","type":"User","site_admin":false},{"login":"danielskatz","id":2913845,"node_id":"MDQ6VXNlcjI5MTM4NDU=","avatar_url":"https://avatars1.githubusercontent.com/u/2913845?v=4","gravatar_id":"","url":"https://api.github.com/users/danielskatz","html_url":"https://github.com/danielskatz","followers_url":"https://api.github.com/users/danielskatz/followers","following_url":"https://api.github.com/users/danielskatz/following{/other_user}","gists_url":"https://api.github.com/users/danielskatz/gists{/gist_id}","starred_url":"https://api.github.com/users/danielskatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielskatz/subscriptions","organizations_url":"https://api.github.com/users/danielskatz/orgs","repos_url":"https://api.github.com/users/danielskatz/repos","events_url":"https://api.github.com/users/danielskatz/events{/privacy}","received_events_url":"https://api.github.com/users/danielskatz/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2018-06-06T11:13:09Z","updated_at":"2018-06-08T11:43:43Z","closed_at":null,"author_association":"COLLABORATOR","body":"**Submitting author:** @jfjlaros (<a href=\"http://orcid.org/0000-0002-8715-7371\">J.F.J. Laros</a>)\n**Repository:** <a href=\"https://github.com/jfjlaros/bin-parser\" target =\"_blank\">https://github.com/jfjlaros/bin-parser</a>\n**Version:** 0.0.20\n**Editor:** @danielskatz\n**Reviewer:** @hainesr, @Smattr\n**Archive:** Pending\n\n## Status\n\n[![status](http://joss.theoj.org/papers/345778df6874891e84c712cc0d665549/status.svg)](http://joss.theoj.org/papers/345778df6874891e84c712cc0d665549)\n\nStatus badge code:\n\n```\nHTML: <a href=\"http://joss.theoj.org/papers/345778df6874891e84c712cc0d665549\"><img src=\"http://joss.theoj.org/papers/345778df6874891e84c712cc0d665549/status.svg\"></a>\nMarkdown: [![status](http://joss.theoj.org/papers/345778df6874891e84c712cc0d665549/status.svg)](http://joss.theoj.org/papers/345778df6874891e84c712cc0d665549)\n```\n**Reviewers and authors**:\n\nPlease avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the <a href=\"https://github.com/jfjlaros/bin-parser\" target=\"_blank\">target repository</a> and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)\n\n## Reviewer instructions & questions\n\n@hainesr & @Smattr, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:\n1. Make sure you're logged in to your GitHub account\n2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations\n\nThe reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @danielskatz know.\n\n## Review checklist for @hainesr\n### Conflict of interest\n\n- [x] As the reviewer I confirm that I have read the [JOSS conflict of interest policy](https://github.com/openjournals/joss/blob/master/COI.md) and that there are no conflicts of interest for me to review this work.\n\n### Code of Conduct\n\n- [x] I confirm that I read and will adhere to the [JOSS code of conduct](https://joss.theoj.org/about#code_of_conduct).\n\n### General checks\n\n- [x] **Repository:** Is the source code for this software available at the <a target=\"_blank\" href=\"https://github.com/jfjlaros/bin-parser\">repository url</a>?\n- [x] **License:** Does the repository contain a plain-text LICENSE file with the contents of an [OSI approved](https://opensource.org/licenses/alphabetical) software license?\n- [ ] **Version:** Does the release version given match the GitHub release (0.0.20)?\n- [x] **Authorship:** Has the submitting author (@jfjlaros) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?\n\n### Functionality\n\n- [ ] **Installation:** Does installation proceed as outlined in the documentation?\n- [ ] **Functionality:** Have the functional claims of the software been confirmed?\n- [ ] **Performance:** If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)\n\n### Documentation\n\n- [x] **A statement of need:** Do the authors clearly state what problems the software is designed to solve and who the target audience is?\n- [x] **Installation instructions:** Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.\n- [x] **Example usage:** Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).\n- [x] **Functionality documentation:** Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?\n- [x] **Automated tests:** Are there automated tests or manual steps described so that the function of the software can be verified?\n- [x] **Community guidelines:** Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support\n\n### Software paper\n\n- [x] **Authors:** Does the `paper.md` file include a list of authors with their affiliations?\n- [x] **A statement of need:** Do the authors clearly state what problems the software is designed to solve and who the target audience is?\n- [ ] **References:** Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?\n\n## Review checklist for @Smattr\n### Conflict of interest\n\n- [x] As the reviewer I confirm that I have read the [JOSS conflict of interest policy](https://github.com/openjournals/joss/blob/master/COI.md) and that there are no conflicts of interest for me to review this work.\n\n### Code of Conduct\n\n- [x] I confirm that I read and will adhere to the [JOSS code of conduct](https://joss.theoj.org/about#code_of_conduct).\n\n### General checks\n\n- [x] **Repository:** Is the source code for this software available at the <a target=\"_blank\" href=\"https://github.com/jfjlaros/bin-parser\">repository url</a>?\n- [x] **License:** Does the repository contain a plain-text LICENSE file with the contents of an [OSI approved](https://opensource.org/licenses/alphabetical) software license?\n- [ ] **Version:** Does the release version given match the GitHub release (0.0.20)?\n- [x] **Authorship:** Has the submitting author (@jfjlaros) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?\n\n### Functionality\n\n- [ ] **Installation:** Does installation proceed as outlined in the documentation?\n- [ ] **Functionality:** Have the functional claims of the software been confirmed?\n- [ ] **Performance:** If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)\n\n### Documentation\n\n- [ ] **A statement of need:** Do the authors clearly state what problems the software is designed to solve and who the target audience is?\n- [ ] **Installation instructions:** Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.\n- [ ] **Example usage:** Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).\n- [ ] **Functionality documentation:** Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?\n- [ ] **Automated tests:** Are there automated tests or manual steps described so that the function of the software can be verified?\n- [ ] **Community guidelines:** Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support\n\n### Software paper\n\n- [ ] **Authors:** Does the `paper.md` file include a list of authors with their affiliations?\n- [ ] **A statement of need:** Do the authors clearly state what problems the software is designed to solve and who the target audience is?\n- [ ] **References:** Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?\n\n"},"comment":{"url":"https://api.github.com/repos/openjournals/joss-reviews/issues/comments/395736132","html_url":"https://github.com/openjournals/joss-reviews/issues/766#issuecomment-395736132","issue_url":"https://api.github.com/repos/openjournals/joss-reviews/issues/766","id":395736132,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NTczNjEzMg==","user":{"login":"danielskatz","id":2913845,"node_id":"MDQ6VXNlcjI5MTM4NDU=","avatar_url":"https://avatars1.githubusercontent.com/u/2913845?v=4","gravatar_id":"","url":"https://api.github.com/users/danielskatz","html_url":"https://github.com/danielskatz","followers_url":"https://api.github.com/users/danielskatz/followers","following_url":"https://api.github.com/users/danielskatz/following{/other_user}","gists_url":"https://api.github.com/users/danielskatz/gists{/gist_id}","starred_url":"https://api.github.com/users/danielskatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielskatz/subscriptions","organizations_url":"https://api.github.com/users/danielskatz/orgs","repos_url":"https://api.github.com/users/danielskatz/repos","events_url":"https://api.github.com/users/danielskatz/events{/privacy}","received_events_url":"https://api.github.com/users/danielskatz/received_events","type":"User","site_admin":false},"created_at":"2018-06-08T11:43:42Z","updated_at":"2018-06-08T11:43:42Z","author_association":"COLLABORATOR","body":"👋 @arfon - see question above"}}
{"actor":{"display_login":"danielskatz"}}