{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-portal/pulls/comments/197889568","pull_request_review_id":131705612,"id":197889568,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Nzg4OTU2OA==","diff_hunk":"@@ -0,0 +1,63 @@\n+import axios from 'axios';\n+import qs from 'query-string';\n+\n+import {\n+  LOGIN_FAILURE,\n+  LOGIN_REQUEST,\n+  LOGIN_SUCCESS,\n+} from '../constants/loginForm';\n+\n+const setLoginPending = loading => ({\n+  type: LOGIN_REQUEST,\n+  payload: { loading },\n+});\n+\n+const setLoginSuccess = isLoginSuccess => ({\n+  type: LOGIN_SUCCESS,\n+  payload: { isLoginSuccess },\n+});","path":"src/data/actions/loginForm.js","position":18,"original_position":18,"commit_id":"42b456eeec22f7861ad7a9c993478d1664aceeac","original_commit_id":"42b456eeec22f7861ad7a9c993478d1664aceeac","user":{"login":"adamstankiewicz","id":2828721,"node_id":"MDQ6VXNlcjI4Mjg3MjE=","avatar_url":"https://avatars0.githubusercontent.com/u/2828721?v=4","gravatar_id":"","url":"https://api.github.com/users/adamstankiewicz","html_url":"https://github.com/adamstankiewicz","followers_url":"https://api.github.com/users/adamstankiewicz/followers","following_url":"https://api.github.com/users/adamstankiewicz/following{/other_user}","gists_url":"https://api.github.com/users/adamstankiewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/adamstankiewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamstankiewicz/subscriptions","organizations_url":"https://api.github.com/users/adamstankiewicz/orgs","repos_url":"https://api.github.com/users/adamstankiewicz/repos","events_url":"https://api.github.com/users/adamstankiewicz/events{/privacy}","received_events_url":"https://api.github.com/users/adamstankiewicz/received_events","type":"User","site_admin":false},"body":"You don't need to pass the `isLoginSuccess` variable into this function as `isLoginSuccess: true` can be set within the reducer for the `LOGIN_SUCCESS` action.","created_at":"2018-06-25T18:05:22Z","updated_at":"2018-06-25T19:02:08Z","html_url":"https://github.com/edx/edx-portal/pull/10#discussion_r197889568","pull_request_url":"https://api.github.com/repos/edx/edx-portal/pulls/10","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-portal/pulls/comments/197889568"},"html":{"href":"https://github.com/edx/edx-portal/pull/10#discussion_r197889568"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-portal/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-portal/pulls/10","id":195918321,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1OTE4MzIx","html_url":"https://github.com/edx/edx-portal/pull/10","diff_url":"https://github.com/edx/edx-portal/pull/10.diff","patch_url":"https://github.com/edx/edx-portal/pull/10.patch","issue_url":"https://api.github.com/repos/edx/edx-portal/issues/10","number":10,"state":"open","locked":false,"title":"Added Login Page w/ authentication","user":{"login":"jonalexvasquez","id":17130221,"node_id":"MDQ6VXNlcjE3MTMwMjIx","avatar_url":"https://avatars1.githubusercontent.com/u/17130221?v=4","gravatar_id":"","url":"https://api.github.com/users/jonalexvasquez","html_url":"https://github.com/jonalexvasquez","followers_url":"https://api.github.com/users/jonalexvasquez/followers","following_url":"https://api.github.com/users/jonalexvasquez/following{/other_user}","gists_url":"https://api.github.com/users/jonalexvasquez/gists{/gist_id}","starred_url":"https://api.github.com/users/jonalexvasquez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonalexvasquez/subscriptions","organizations_url":"https://api.github.com/users/jonalexvasquez/orgs","repos_url":"https://api.github.com/users/jonalexvasquez/repos","events_url":"https://api.github.com/users/jonalexvasquez/events{/privacy}","received_events_url":"https://api.github.com/users/jonalexvasquez/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-19T18:29:28Z","updated_at":"2018-06-25T19:02:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e17443b40acb703d229eebc4dfbf1e70cc362249","assignee":null,"assignees":[],"requested_reviewers":[{"login":"brittneyexline","id":524809,"node_id":"MDQ6VXNlcjUyNDgwOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/524809?v=4","gravatar_id":"","url":"https://api.github.com/users/brittneyexline","html_url":"https://github.com/brittneyexline","followers_url":"https://api.github.com/users/brittneyexline/followers","following_url":"https://api.github.com/users/brittneyexline/following{/other_user}","gists_url":"https://api.github.com/users/brittneyexline/gists{/gist_id}","starred_url":"https://api.github.com/users/brittneyexline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brittneyexline/subscriptions","organizations_url":"https://api.github.com/users/brittneyexline/orgs","repos_url":"https://api.github.com/users/brittneyexline/repos","events_url":"https://api.github.com/users/brittneyexline/events{/privacy}","received_events_url":"https://api.github.com/users/brittneyexline/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-portal/pulls/10/commits","review_comments_url":"https://api.github.com/repos/edx/edx-portal/pulls/10/comments","review_comment_url":"https://api.github.com/repos/edx/edx-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-portal/issues/10/comments","statuses_url":"https://api.github.com/repos/edx/edx-portal/statuses/42b456eeec22f7861ad7a9c993478d1664aceeac","head":{"label":"edx:jvasquez/LoginForm","ref":"jvasquez/LoginForm","sha":"42b456eeec22f7861ad7a9c993478d1664aceeac","user":{"login":"edx","id":3179841,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzk4NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":132906257,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI5MDYyNTc=","name":"edx-portal","full_name":"edx/edx-portal","owner":{"login":"edx","id":3179841,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzk4NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-portal","description":"edx-portal is a frontend that provides branded learning experiences.","fork":false,"url":"https://api.github.com/repos/edx/edx-portal","forks_url":"https://api.github.com/repos/edx/edx-portal/forks","keys_url":"https://api.github.com/repos/edx/edx-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-portal/teams","hooks_url":"https://api.github.com/repos/edx/edx-portal/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-portal/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-portal/events","assignees_url":"https://api.github.com/repos/edx/edx-portal/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-portal/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-portal/tags","blobs_url":"https://api.github.com/repos/edx/edx-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-portal/languages","stargazers_url":"https://api.github.com/repos/edx/edx-portal/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-portal/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-portal/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-portal/subscription","commits_url":"https://api.github.com/repos/edx/edx-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-portal/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-portal/merges","archive_url":"https://api.github.com/repos/edx/edx-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-portal/downloads","issues_url":"https://api.github.com/repos/edx/edx-portal/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-portal/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-portal/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-portal/deployments","created_at":"2018-05-10T13:44:58Z","updated_at":"2018-06-19T20:14:20Z","pushed_at":"2018-06-25T17:34:50Z","git_url":"git://github.com/edx/edx-portal.git","ssh_url":"git@github.com:edx/edx-portal.git","clone_url":"https://github.com/edx/edx-portal.git","svn_url":"https://github.com/edx/edx-portal","homepage":null,"size":444,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":2,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"8ca6010b92f55fa64fa271e76e9a3d8f759a49b8","user":{"login":"edx","id":3179841,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzk4NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":132906257,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI5MDYyNTc=","name":"edx-portal","full_name":"edx/edx-portal","owner":{"login":"edx","id":3179841,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzk4NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-portal","description":"edx-portal is a frontend that provides branded learning experiences.","fork":false,"url":"https://api.github.com/repos/edx/edx-portal","forks_url":"https://api.github.com/repos/edx/edx-portal/forks","keys_url":"https://api.github.com/repos/edx/edx-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-portal/teams","hooks_url":"https://api.github.com/repos/edx/edx-portal/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-portal/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-portal/events","assignees_url":"https://api.github.com/repos/edx/edx-portal/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-portal/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-portal/tags","blobs_url":"https://api.github.com/repos/edx/edx-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-portal/languages","stargazers_url":"https://api.github.com/repos/edx/edx-portal/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-portal/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-portal/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-portal/subscription","commits_url":"https://api.github.com/repos/edx/edx-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-portal/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-portal/merges","archive_url":"https://api.github.com/repos/edx/edx-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-portal/downloads","issues_url":"https://api.github.com/repos/edx/edx-portal/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-portal/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-portal/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-portal/deployments","created_at":"2018-05-10T13:44:58Z","updated_at":"2018-06-19T20:14:20Z","pushed_at":"2018-06-25T17:34:50Z","git_url":"git://github.com/edx/edx-portal.git","ssh_url":"git@github.com:edx/edx-portal.git","clone_url":"https://github.com/edx/edx-portal.git","svn_url":"https://github.com/edx/edx-portal","homepage":null,"size":444,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":2,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-portal/pulls/10"},"html":{"href":"https://github.com/edx/edx-portal/pull/10"},"issue":{"href":"https://api.github.com/repos/edx/edx-portal/issues/10"},"comments":{"href":"https://api.github.com/repos/edx/edx-portal/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-portal/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-portal/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-portal/statuses/42b456eeec22f7861ad7a9c993478d1664aceeac"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"adamstankiewicz"}}