{"action":"closed","number":2995,"pull_request":{"url":"https://api.github.com/repos/duplicati/duplicati/pulls/2995","id":166124452,"html_url":"https://github.com/duplicati/duplicati/pull/2995","diff_url":"https://github.com/duplicati/duplicati/pull/2995.diff","patch_url":"https://github.com/duplicati/duplicati/pull/2995.patch","issue_url":"https://api.github.com/repos/duplicati/duplicati/issues/2995","number":2995,"state":"closed","locked":false,"title":"Use double instead of long for Utility.FormatSizeString","user":{"login":"TekkiWuff","id":31596699,"avatar_url":"https://avatars3.githubusercontent.com/u/31596699?v=4","gravatar_id":"","url":"https://api.github.com/users/TekkiWuff","html_url":"https://github.com/TekkiWuff","followers_url":"https://api.github.com/users/TekkiWuff/followers","following_url":"https://api.github.com/users/TekkiWuff/following{/other_user}","gists_url":"https://api.github.com/users/TekkiWuff/gists{/gist_id}","starred_url":"https://api.github.com/users/TekkiWuff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TekkiWuff/subscriptions","organizations_url":"https://api.github.com/users/TekkiWuff/orgs","repos_url":"https://api.github.com/users/TekkiWuff/repos","events_url":"https://api.github.com/users/TekkiWuff/events{/privacy}","received_events_url":"https://api.github.com/users/TekkiWuff/received_events","type":"User","site_admin":false},"body":"This _should_ fix the issue described in #2994.\r\n\r\nUsing `double` instead of `long` for `FormatSizeString` should help, since floating point numbers have a seperate sign bit, thus being able to represent the same range for positve and negative numbers. And since the method is only used for printing rounded numbers anyway, the potential loss of precisions shouldn't matter.\r\n\r\nI couldn't test this myself though, since I cannot reproduce the error, but `Math.Abs(double.MinValue)` works fine.\r\n\r\nThis does NOT change all the calls to this method, some of which still force a cast to `long` when calling it. Should maybe done in a seperate pull request?","created_at":"2018-01-30T23:14:16Z","updated_at":"2018-02-08T21:02:45Z","closed_at":"2018-02-08T21:02:45Z","merged_at":"2018-02-08T21:02:45Z","merge_commit_sha":"f6bb6d3d4fb2e6c86ad62eece55c01f320743877","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/duplicati/duplicati/pulls/2995/commits","review_comments_url":"https://api.github.com/repos/duplicati/duplicati/pulls/2995/comments","review_comment_url":"https://api.github.com/repos/duplicati/duplicati/pulls/comments{/number}","comments_url":"https://api.github.com/repos/duplicati/duplicati/issues/2995/comments","statuses_url":"https://api.github.com/repos/duplicati/duplicati/statuses/dab0e1102bccc2582001d4945b2c0a3478706597","head":{"label":"TekkiWuff:bugfix/issue-2994","ref":"bugfix/issue-2994","sha":"dab0e1102bccc2582001d4945b2c0a3478706597","user":{"login":"TekkiWuff","id":31596699,"avatar_url":"https://avatars3.githubusercontent.com/u/31596699?v=4","gravatar_id":"","url":"https://api.github.com/users/TekkiWuff","html_url":"https://github.com/TekkiWuff","followers_url":"https://api.github.com/users/TekkiWuff/followers","following_url":"https://api.github.com/users/TekkiWuff/following{/other_user}","gists_url":"https://api.github.com/users/TekkiWuff/gists{/gist_id}","starred_url":"https://api.github.com/users/TekkiWuff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TekkiWuff/subscriptions","organizations_url":"https://api.github.com/users/TekkiWuff/orgs","repos_url":"https://api.github.com/users/TekkiWuff/repos","events_url":"https://api.github.com/users/TekkiWuff/events{/privacy}","received_events_url":"https://api.github.com/users/TekkiWuff/received_events","type":"User","site_admin":false},"repo":{"id":102509390,"name":"duplicati","full_name":"TekkiWuff/duplicati","owner":{"login":"TekkiWuff","id":31596699,"avatar_url":"https://avatars3.githubusercontent.com/u/31596699?v=4","gravatar_id":"","url":"https://api.github.com/users/TekkiWuff","html_url":"https://github.com/TekkiWuff","followers_url":"https://api.github.com/users/TekkiWuff/followers","following_url":"https://api.github.com/users/TekkiWuff/following{/other_user}","gists_url":"https://api.github.com/users/TekkiWuff/gists{/gist_id}","starred_url":"https://api.github.com/users/TekkiWuff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TekkiWuff/subscriptions","organizations_url":"https://api.github.com/users/TekkiWuff/orgs","repos_url":"https://api.github.com/users/TekkiWuff/repos","events_url":"https://api.github.com/users/TekkiWuff/events{/privacy}","received_events_url":"https://api.github.com/users/TekkiWuff/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TekkiWuff/duplicati","description":"Store securely encrypted backups in the cloud!","fork":true,"url":"https://api.github.com/repos/TekkiWuff/duplicati","forks_url":"https://api.github.com/repos/TekkiWuff/duplicati/forks","keys_url":"https://api.github.com/repos/TekkiWuff/duplicati/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TekkiWuff/duplicati/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TekkiWuff/duplicati/teams","hooks_url":"https://api.github.com/repos/TekkiWuff/duplicati/hooks","issue_events_url":"https://api.github.com/repos/TekkiWuff/duplicati/issues/events{/number}","events_url":"https://api.github.com/repos/TekkiWuff/duplicati/events","assignees_url":"https://api.github.com/repos/TekkiWuff/duplicati/assignees{/user}","branches_url":"https://api.github.com/repos/TekkiWuff/duplicati/branches{/branch}","tags_url":"https://api.github.com/repos/TekkiWuff/duplicati/tags","blobs_url":"https://api.github.com/repos/TekkiWuff/duplicati/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TekkiWuff/duplicati/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TekkiWuff/duplicati/git/refs{/sha}","trees_url":"https://api.github.com/repos/TekkiWuff/duplicati/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TekkiWuff/duplicati/statuses/{sha}","languages_url":"https://api.github.com/repos/TekkiWuff/duplicati/languages","stargazers_url":"https://api.github.com/repos/TekkiWuff/duplicati/stargazers","contributors_url":"https://api.github.com/repos/TekkiWuff/duplicati/contributors","subscribers_url":"https://api.github.com/repos/TekkiWuff/duplicati/subscribers","subscription_url":"https://api.github.com/repos/TekkiWuff/duplicati/subscription","commits_url":"https://api.github.com/repos/TekkiWuff/duplicati/commits{/sha}","git_commits_url":"https://api.github.com/repos/TekkiWuff/duplicati/git/commits{/sha}","comments_url":"https://api.github.com/repos/TekkiWuff/duplicati/comments{/number}","issue_comment_url":"https://api.github.com/repos/TekkiWuff/duplicati/issues/comments{/number}","contents_url":"https://api.github.com/repos/TekkiWuff/duplicati/contents/{+path}","compare_url":"https://api.github.com/repos/TekkiWuff/duplicati/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TekkiWuff/duplicati/merges","archive_url":"https://api.github.com/repos/TekkiWuff/duplicati/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TekkiWuff/duplicati/downloads","issues_url":"https://api.github.com/repos/TekkiWuff/duplicati/issues{/number}","pulls_url":"https://api.github.com/repos/TekkiWuff/duplicati/pulls{/number}","milestones_url":"https://api.github.com/repos/TekkiWuff/duplicati/milestones{/number}","notifications_url":"https://api.github.com/repos/TekkiWuff/duplicati/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TekkiWuff/duplicati/labels{/name}","releases_url":"https://api.github.com/repos/TekkiWuff/duplicati/releases{/id}","deployments_url":"https://api.github.com/repos/TekkiWuff/duplicati/deployments","created_at":"2017-09-05T17:14:03Z","updated_at":"2017-09-05T17:14:08Z","pushed_at":"2018-02-02T15:41:07Z","git_url":"git://github.com/TekkiWuff/duplicati.git","ssh_url":"git@github.com:TekkiWuff/duplicati.git","clone_url":"https://github.com/TekkiWuff/duplicati.git","svn_url":"https://github.com/TekkiWuff/duplicati","homepage":"","size":84641,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"duplicati:master","ref":"master","sha":"851248ddbf4d92d3fd4952e7c0f8ccbaf039a509","user":{"login":"duplicati","id":8270231,"avatar_url":"https://avatars1.githubusercontent.com/u/8270231?v=4","gravatar_id":"","url":"https://api.github.com/users/duplicati","html_url":"https://github.com/duplicati","followers_url":"https://api.github.com/users/duplicati/followers","following_url":"https://api.github.com/users/duplicati/following{/other_user}","gists_url":"https://api.github.com/users/duplicati/gists{/gist_id}","starred_url":"https://api.github.com/users/duplicati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duplicati/subscriptions","organizations_url":"https://api.github.com/users/duplicati/orgs","repos_url":"https://api.github.com/users/duplicati/repos","events_url":"https://api.github.com/users/duplicati/events{/privacy}","received_events_url":"https://api.github.com/users/duplicati/received_events","type":"Organization","site_admin":false},"repo":{"id":22636263,"name":"duplicati","full_name":"duplicati/duplicati","owner":{"login":"duplicati","id":8270231,"avatar_url":"https://avatars1.githubusercontent.com/u/8270231?v=4","gravatar_id":"","url":"https://api.github.com/users/duplicati","html_url":"https://github.com/duplicati","followers_url":"https://api.github.com/users/duplicati/followers","following_url":"https://api.github.com/users/duplicati/following{/other_user}","gists_url":"https://api.github.com/users/duplicati/gists{/gist_id}","starred_url":"https://api.github.com/users/duplicati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duplicati/subscriptions","organizations_url":"https://api.github.com/users/duplicati/orgs","repos_url":"https://api.github.com/users/duplicati/repos","events_url":"https://api.github.com/users/duplicati/events{/privacy}","received_events_url":"https://api.github.com/users/duplicati/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/duplicati/duplicati","description":"Store securely encrypted backups in the cloud!","fork":false,"url":"https://api.github.com/repos/duplicati/duplicati","forks_url":"https://api.github.com/repos/duplicati/duplicati/forks","keys_url":"https://api.github.com/repos/duplicati/duplicati/keys{/key_id}","collaborators_url":"https://api.github.com/repos/duplicati/duplicati/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/duplicati/duplicati/teams","hooks_url":"https://api.github.com/repos/duplicati/duplicati/hooks","issue_events_url":"https://api.github.com/repos/duplicati/duplicati/issues/events{/number}","events_url":"https://api.github.com/repos/duplicati/duplicati/events","assignees_url":"https://api.github.com/repos/duplicati/duplicati/assignees{/user}","branches_url":"https://api.github.com/repos/duplicati/duplicati/branches{/branch}","tags_url":"https://api.github.com/repos/duplicati/duplicati/tags","blobs_url":"https://api.github.com/repos/duplicati/duplicati/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/duplicati/duplicati/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/duplicati/duplicati/git/refs{/sha}","trees_url":"https://api.github.com/repos/duplicati/duplicati/git/trees{/sha}","statuses_url":"https://api.github.com/repos/duplicati/duplicati/statuses/{sha}","languages_url":"https://api.github.com/repos/duplicati/duplicati/languages","stargazers_url":"https://api.github.com/repos/duplicati/duplicati/stargazers","contributors_url":"https://api.github.com/repos/duplicati/duplicati/contributors","subscribers_url":"https://api.github.com/repos/duplicati/duplicati/subscribers","subscription_url":"https://api.github.com/repos/duplicati/duplicati/subscription","commits_url":"https://api.github.com/repos/duplicati/duplicati/commits{/sha}","git_commits_url":"https://api.github.com/repos/duplicati/duplicati/git/commits{/sha}","comments_url":"https://api.github.com/repos/duplicati/duplicati/comments{/number}","issue_comment_url":"https://api.github.com/repos/duplicati/duplicati/issues/comments{/number}","contents_url":"https://api.github.com/repos/duplicati/duplicati/contents/{+path}","compare_url":"https://api.github.com/repos/duplicati/duplicati/compare/{base}...{head}","merges_url":"https://api.github.com/repos/duplicati/duplicati/merges","archive_url":"https://api.github.com/repos/duplicati/duplicati/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/duplicati/duplicati/downloads","issues_url":"https://api.github.com/repos/duplicati/duplicati/issues{/number}","pulls_url":"https://api.github.com/repos/duplicati/duplicati/pulls{/number}","milestones_url":"https://api.github.com/repos/duplicati/duplicati/milestones{/number}","notifications_url":"https://api.github.com/repos/duplicati/duplicati/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/duplicati/duplicati/labels{/name}","releases_url":"https://api.github.com/repos/duplicati/duplicati/releases{/id}","deployments_url":"https://api.github.com/repos/duplicati/duplicati/deployments","created_at":"2014-08-05T08:28:16Z","updated_at":"2018-02-08T18:07:09Z","pushed_at":"2018-02-08T21:02:45Z","git_url":"git://github.com/duplicati/duplicati.git","ssh_url":"git@github.com:duplicati/duplicati.git","clone_url":"https://github.com/duplicati/duplicati.git","svn_url":"https://github.com/duplicati/duplicati","homepage":"","size":85422,"stargazers_count":2532,"watchers_count":2532,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":354,"mirror_url":null,"archived":false,"open_issues_count":802,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":354,"open_issues":802,"watchers":2532,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/duplicati/duplicati/pulls/2995"},"html":{"href":"https://github.com/duplicati/duplicati/pull/2995"},"issue":{"href":"https://api.github.com/repos/duplicati/duplicati/issues/2995"},"comments":{"href":"https://api.github.com/repos/duplicati/duplicati/issues/2995/comments"},"review_comments":{"href":"https://api.github.com/repos/duplicati/duplicati/pulls/2995/comments"},"review_comment":{"href":"https://api.github.com/repos/duplicati/duplicati/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/duplicati/duplicati/pulls/2995/commits"},"statuses":{"href":"https://api.github.com/repos/duplicati/duplicati/statuses/dab0e1102bccc2582001d4945b2c0a3478706597"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"kenkendk","id":1510755,"avatar_url":"https://avatars1.githubusercontent.com/u/1510755?v=4","gravatar_id":"","url":"https://api.github.com/users/kenkendk","html_url":"https://github.com/kenkendk","followers_url":"https://api.github.com/users/kenkendk/followers","following_url":"https://api.github.com/users/kenkendk/following{/other_user}","gists_url":"https://api.github.com/users/kenkendk/gists{/gist_id}","starred_url":"https://api.github.com/users/kenkendk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenkendk/subscriptions","organizations_url":"https://api.github.com/users/kenkendk/orgs","repos_url":"https://api.github.com/users/kenkendk/repos","events_url":"https://api.github.com/users/kenkendk/events{/privacy}","received_events_url":"https://api.github.com/users/kenkendk/received_events","type":"User","site_admin":false},"comments":12,"review_comments":1,"maintainer_can_modify":false,"commits":1,"additions":7,"deletions":7,"changed_files":1}}
{"actor":{"display_login":"kenkendk"}}