{"action":"created","comment":{"url":"https://api.github.com/repos/PyCQA/pep8-naming/pulls/comments/191650238","pull_request_review_id":124258834,"id":191650238,"diff_hunk":"@@ -437,6 +437,6 @@ def _extract_names(assignment_target):\n \n def is_mixed_case(name):\n     stripped_name = name.strip('_')\n-    head = stripped_name[:1]\n-    tail = stripped_name[1:]\n-    return head.islower() and tail and not (tail.islower() or tail.isdigit())\n+    head_is_lower = stripped_name[:1].islower()\n+    tail_has_upper = any(map(str.isupper, stripped_name[1:]))","path":"src/pep8ext_naming.py","position":8,"original_position":8,"commit_id":"fffb1a7d74f1cd9ba407be68ce04e9b573368e97","original_commit_id":"fffb1a7d74f1cd9ba407be68ce04e9b573368e97","user":{"login":"5j9","id":1055747,"avatar_url":"https://avatars0.githubusercontent.com/u/1055747?v=4","gravatar_id":"","url":"https://api.github.com/users/5j9","html_url":"https://github.com/5j9","followers_url":"https://api.github.com/users/5j9/followers","following_url":"https://api.github.com/users/5j9/following{/other_user}","gists_url":"https://api.github.com/users/5j9/gists{/gist_id}","starred_url":"https://api.github.com/users/5j9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/5j9/subscriptions","organizations_url":"https://api.github.com/users/5j9/orgs","repos_url":"https://api.github.com/users/5j9/repos","events_url":"https://api.github.com/users/5j9/events{/privacy}","received_events_url":"https://api.github.com/users/5j9/received_events","type":"User","site_admin":false},"body":"On second thought, I don't like it that this is not lazy-evaluated. I'll fix it with the next commit.","created_at":"2018-05-30T06:03:22Z","updated_at":"2018-05-30T06:03:22Z","html_url":"https://github.com/PyCQA/pep8-naming/pull/70#discussion_r191650238","pull_request_url":"https://api.github.com/repos/PyCQA/pep8-naming/pulls/70","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/PyCQA/pep8-naming/pulls/comments/191650238"},"html":{"href":"https://github.com/PyCQA/pep8-naming/pull/70#discussion_r191650238"},"pull_request":{"href":"https://api.github.com/repos/PyCQA/pep8-naming/pulls/70"}}},"pull_request":{"url":"https://api.github.com/repos/PyCQA/pep8-naming/pulls/70","id":191341242,"html_url":"https://github.com/PyCQA/pep8-naming/pull/70","diff_url":"https://github.com/PyCQA/pep8-naming/pull/70.diff","patch_url":"https://github.com/PyCQA/pep8-naming/pull/70.patch","issue_url":"https://api.github.com/repos/PyCQA/pep8-naming/issues/70","number":70,"state":"open","locked":false,"title":"Make is_mixed_case always return a Boolean value","user":{"login":"5j9","id":1055747,"avatar_url":"https://avatars0.githubusercontent.com/u/1055747?v=4","gravatar_id":"","url":"https://api.github.com/users/5j9","html_url":"https://github.com/5j9","followers_url":"https://api.github.com/users/5j9/followers","following_url":"https://api.github.com/users/5j9/following{/other_user}","gists_url":"https://api.github.com/users/5j9/gists{/gist_id}","starred_url":"https://api.github.com/users/5j9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/5j9/subscriptions","organizations_url":"https://api.github.com/users/5j9/orgs","repos_url":"https://api.github.com/users/5j9/repos","events_url":"https://api.github.com/users/5j9/events{/privacy}","received_events_url":"https://api.github.com/users/5j9/received_events","type":"User","site_admin":false},"body":"When the tail is '', e.g. when the name is 'a', is_mixed_case returns ''\r\nwhich is somewhat unexpected.","created_at":"2018-05-30T05:56:10Z","updated_at":"2018-05-30T06:03:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5433b45a708c63034e9092f9f8f21f2bcd2d646e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PyCQA/pep8-naming/pulls/70/commits","review_comments_url":"https://api.github.com/repos/PyCQA/pep8-naming/pulls/70/comments","review_comment_url":"https://api.github.com/repos/PyCQA/pep8-naming/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PyCQA/pep8-naming/issues/70/comments","statuses_url":"https://api.github.com/repos/PyCQA/pep8-naming/statuses/fffb1a7d74f1cd9ba407be68ce04e9b573368e97","head":{"label":"5j9:is_mixed_case","ref":"is_mixed_case","sha":"fffb1a7d74f1cd9ba407be68ce04e9b573368e97","user":{"login":"5j9","id":1055747,"avatar_url":"https://avatars0.githubusercontent.com/u/1055747?v=4","gravatar_id":"","url":"https://api.github.com/users/5j9","html_url":"https://github.com/5j9","followers_url":"https://api.github.com/users/5j9/followers","following_url":"https://api.github.com/users/5j9/following{/other_user}","gists_url":"https://api.github.com/users/5j9/gists{/gist_id}","starred_url":"https://api.github.com/users/5j9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/5j9/subscriptions","organizations_url":"https://api.github.com/users/5j9/orgs","repos_url":"https://api.github.com/users/5j9/repos","events_url":"https://api.github.com/users/5j9/events{/privacy}","received_events_url":"https://api.github.com/users/5j9/received_events","type":"User","site_admin":false},"repo":{"id":132489334,"name":"pep8-naming","full_name":"5j9/pep8-naming","owner":{"login":"5j9","id":1055747,"avatar_url":"https://avatars0.githubusercontent.com/u/1055747?v=4","gravatar_id":"","url":"https://api.github.com/users/5j9","html_url":"https://github.com/5j9","followers_url":"https://api.github.com/users/5j9/followers","following_url":"https://api.github.com/users/5j9/following{/other_user}","gists_url":"https://api.github.com/users/5j9/gists{/gist_id}","starred_url":"https://api.github.com/users/5j9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/5j9/subscriptions","organizations_url":"https://api.github.com/users/5j9/orgs","repos_url":"https://api.github.com/users/5j9/repos","events_url":"https://api.github.com/users/5j9/events{/privacy}","received_events_url":"https://api.github.com/users/5j9/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/5j9/pep8-naming","description":"Naming Convention checker for Python","fork":true,"url":"https://api.github.com/repos/5j9/pep8-naming","forks_url":"https://api.github.com/repos/5j9/pep8-naming/forks","keys_url":"https://api.github.com/repos/5j9/pep8-naming/keys{/key_id}","collaborators_url":"https://api.github.com/repos/5j9/pep8-naming/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/5j9/pep8-naming/teams","hooks_url":"https://api.github.com/repos/5j9/pep8-naming/hooks","issue_events_url":"https://api.github.com/repos/5j9/pep8-naming/issues/events{/number}","events_url":"https://api.github.com/repos/5j9/pep8-naming/events","assignees_url":"https://api.github.com/repos/5j9/pep8-naming/assignees{/user}","branches_url":"https://api.github.com/repos/5j9/pep8-naming/branches{/branch}","tags_url":"https://api.github.com/repos/5j9/pep8-naming/tags","blobs_url":"https://api.github.com/repos/5j9/pep8-naming/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/5j9/pep8-naming/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/5j9/pep8-naming/git/refs{/sha}","trees_url":"https://api.github.com/repos/5j9/pep8-naming/git/trees{/sha}","statuses_url":"https://api.github.com/repos/5j9/pep8-naming/statuses/{sha}","languages_url":"https://api.github.com/repos/5j9/pep8-naming/languages","stargazers_url":"https://api.github.com/repos/5j9/pep8-naming/stargazers","contributors_url":"https://api.github.com/repos/5j9/pep8-naming/contributors","subscribers_url":"https://api.github.com/repos/5j9/pep8-naming/subscribers","subscription_url":"https://api.github.com/repos/5j9/pep8-naming/subscription","commits_url":"https://api.github.com/repos/5j9/pep8-naming/commits{/sha}","git_commits_url":"https://api.github.com/repos/5j9/pep8-naming/git/commits{/sha}","comments_url":"https://api.github.com/repos/5j9/pep8-naming/comments{/number}","issue_comment_url":"https://api.github.com/repos/5j9/pep8-naming/issues/comments{/number}","contents_url":"https://api.github.com/repos/5j9/pep8-naming/contents/{+path}","compare_url":"https://api.github.com/repos/5j9/pep8-naming/compare/{base}...{head}","merges_url":"https://api.github.com/repos/5j9/pep8-naming/merges","archive_url":"https://api.github.com/repos/5j9/pep8-naming/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/5j9/pep8-naming/downloads","issues_url":"https://api.github.com/repos/5j9/pep8-naming/issues{/number}","pulls_url":"https://api.github.com/repos/5j9/pep8-naming/pulls{/number}","milestones_url":"https://api.github.com/repos/5j9/pep8-naming/milestones{/number}","notifications_url":"https://api.github.com/repos/5j9/pep8-naming/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/5j9/pep8-naming/labels{/name}","releases_url":"https://api.github.com/repos/5j9/pep8-naming/releases{/id}","deployments_url":"https://api.github.com/repos/5j9/pep8-naming/deployments","created_at":"2018-05-07T16:42:56Z","updated_at":"2018-05-29T17:33:53Z","pushed_at":"2018-05-30T05:54:07Z","git_url":"git://github.com/5j9/pep8-naming.git","ssh_url":"git@github.com:5j9/pep8-naming.git","clone_url":"https://github.com/5j9/pep8-naming.git","svn_url":"https://github.com/5j9/pep8-naming","homepage":"pypi.python.org/pypi/pep8-naming","size":95,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PyCQA:master","ref":"master","sha":"4620c1efb983c6af79ec2d3e9764bcf7c83abeb9","user":{"login":"PyCQA","id":8749848,"avatar_url":"https://avatars0.githubusercontent.com/u/8749848?v=4","gravatar_id":"","url":"https://api.github.com/users/PyCQA","html_url":"https://github.com/PyCQA","followers_url":"https://api.github.com/users/PyCQA/followers","following_url":"https://api.github.com/users/PyCQA/following{/other_user}","gists_url":"https://api.github.com/users/PyCQA/gists{/gist_id}","starred_url":"https://api.github.com/users/PyCQA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PyCQA/subscriptions","organizations_url":"https://api.github.com/users/PyCQA/orgs","repos_url":"https://api.github.com/users/PyCQA/repos","events_url":"https://api.github.com/users/PyCQA/events{/privacy}","received_events_url":"https://api.github.com/users/PyCQA/received_events","type":"Organization","site_admin":false},"repo":{"id":8113165,"name":"pep8-naming","full_name":"PyCQA/pep8-naming","owner":{"login":"PyCQA","id":8749848,"avatar_url":"https://avatars0.githubusercontent.com/u/8749848?v=4","gravatar_id":"","url":"https://api.github.com/users/PyCQA","html_url":"https://github.com/PyCQA","followers_url":"https://api.github.com/users/PyCQA/followers","following_url":"https://api.github.com/users/PyCQA/following{/other_user}","gists_url":"https://api.github.com/users/PyCQA/gists{/gist_id}","starred_url":"https://api.github.com/users/PyCQA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PyCQA/subscriptions","organizations_url":"https://api.github.com/users/PyCQA/orgs","repos_url":"https://api.github.com/users/PyCQA/repos","events_url":"https://api.github.com/users/PyCQA/events{/privacy}","received_events_url":"https://api.github.com/users/PyCQA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PyCQA/pep8-naming","description":"Naming Convention checker for Python","fork":false,"url":"https://api.github.com/repos/PyCQA/pep8-naming","forks_url":"https://api.github.com/repos/PyCQA/pep8-naming/forks","keys_url":"https://api.github.com/repos/PyCQA/pep8-naming/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PyCQA/pep8-naming/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PyCQA/pep8-naming/teams","hooks_url":"https://api.github.com/repos/PyCQA/pep8-naming/hooks","issue_events_url":"https://api.github.com/repos/PyCQA/pep8-naming/issues/events{/number}","events_url":"https://api.github.com/repos/PyCQA/pep8-naming/events","assignees_url":"https://api.github.com/repos/PyCQA/pep8-naming/assignees{/user}","branches_url":"https://api.github.com/repos/PyCQA/pep8-naming/branches{/branch}","tags_url":"https://api.github.com/repos/PyCQA/pep8-naming/tags","blobs_url":"https://api.github.com/repos/PyCQA/pep8-naming/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PyCQA/pep8-naming/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PyCQA/pep8-naming/git/refs{/sha}","trees_url":"https://api.github.com/repos/PyCQA/pep8-naming/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PyCQA/pep8-naming/statuses/{sha}","languages_url":"https://api.github.com/repos/PyCQA/pep8-naming/languages","stargazers_url":"https://api.github.com/repos/PyCQA/pep8-naming/stargazers","contributors_url":"https://api.github.com/repos/PyCQA/pep8-naming/contributors","subscribers_url":"https://api.github.com/repos/PyCQA/pep8-naming/subscribers","subscription_url":"https://api.github.com/repos/PyCQA/pep8-naming/subscription","commits_url":"https://api.github.com/repos/PyCQA/pep8-naming/commits{/sha}","git_commits_url":"https://api.github.com/repos/PyCQA/pep8-naming/git/commits{/sha}","comments_url":"https://api.github.com/repos/PyCQA/pep8-naming/comments{/number}","issue_comment_url":"https://api.github.com/repos/PyCQA/pep8-naming/issues/comments{/number}","contents_url":"https://api.github.com/repos/PyCQA/pep8-naming/contents/{+path}","compare_url":"https://api.github.com/repos/PyCQA/pep8-naming/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PyCQA/pep8-naming/merges","archive_url":"https://api.github.com/repos/PyCQA/pep8-naming/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PyCQA/pep8-naming/downloads","issues_url":"https://api.github.com/repos/PyCQA/pep8-naming/issues{/number}","pulls_url":"https://api.github.com/repos/PyCQA/pep8-naming/pulls{/number}","milestones_url":"https://api.github.com/repos/PyCQA/pep8-naming/milestones{/number}","notifications_url":"https://api.github.com/repos/PyCQA/pep8-naming/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PyCQA/pep8-naming/labels{/name}","releases_url":"https://api.github.com/repos/PyCQA/pep8-naming/releases{/id}","deployments_url":"https://api.github.com/repos/PyCQA/pep8-naming/deployments","created_at":"2013-02-09T18:32:52Z","updated_at":"2018-05-30T04:35:55Z","pushed_at":"2018-05-30T05:56:11Z","git_url":"git://github.com/PyCQA/pep8-naming.git","ssh_url":"git@github.com:PyCQA/pep8-naming.git","clone_url":"https://github.com/PyCQA/pep8-naming.git","svn_url":"https://github.com/PyCQA/pep8-naming","homepage":"pypi.python.org/pypi/pep8-naming","size":94,"stargazers_count":121,"watchers_count":121,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":33,"open_issues":10,"watchers":121,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PyCQA/pep8-naming/pulls/70"},"html":{"href":"https://github.com/PyCQA/pep8-naming/pull/70"},"issue":{"href":"https://api.github.com/repos/PyCQA/pep8-naming/issues/70"},"comments":{"href":"https://api.github.com/repos/PyCQA/pep8-naming/issues/70/comments"},"review_comments":{"href":"https://api.github.com/repos/PyCQA/pep8-naming/pulls/70/comments"},"review_comment":{"href":"https://api.github.com/repos/PyCQA/pep8-naming/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PyCQA/pep8-naming/pulls/70/commits"},"statuses":{"href":"https://api.github.com/repos/PyCQA/pep8-naming/statuses/fffb1a7d74f1cd9ba407be68ce04e9b573368e97"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"5j9"}}