{"action":"created","comment":{"url":"https://api.github.com/repos/KyberNetwork/reserve-data/pulls/comments/200224200","pull_request_review_id":134497205,"id":200224200,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDIyNDIwMA==","diff_hunk":"@@ -2,16 +2,38 @@ package common\n \n import ethereum \"github.com/ethereum/go-ethereum/common\"\n \n+// TokenExchangeSetting contains necessary information on exchange to List a token on the fly\n+type TokenExchangeSetting struct {\n+\tDepositAddress string\n+\tInfo           ExchangeInfo\n+\tFee            TokenFee\n+\tMinDeposit     float64\n+}\n+\n+type TokenListing struct {\n+\tToken       Token                           `json:\"token\"`\n+\tExchange    map[string]TokenExchangeSetting `json:\"exchanges\"`\n+\tPWIEq       PWIEquationTokenV2              `json:\"pwis_equation\"`\n+\tTargetQty   TargetQtyV2                     `json:\"target_qty\"`\n+\tQuadraticEq RebalanceQuadraticEquation      `json:\"rebalance_quadratic\"`\n+}\n+\n+type TokenFee struct {\n+\tTrading  float64\n+\tWithDraw float64\n+\tDeposit  float64\n+}\n+\n type Token struct {\n-\tID                      string\n-\tName                    string\n-\tAddress                 string\n-\tDecimal                 int64\n-\tActive                  bool\n-\tInternal                bool\n-\tMinimalRecordResolution string\n-\tMaxTotalImbalance       string\n-\tMaxPerBlockImbalance    string\n+\tID                      string `json:\"id\"`\n+\tName                    string `json:\"name\"`\n+\tAddress                 string `json:\"address\"`\n+\tDecimal                 int64  `json:\"decimals\"`","path":"common/token.go","position":39,"original_position":39,"commit_id":"83d9fafea4eabf36e276ec289939834ce5385207","original_commit_id":"83d9fafea4eabf36e276ec289939834ce5385207","user":{"login":"halink0803","id":5054560,"node_id":"MDQ6VXNlcjUwNTQ1NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/5054560?v=4","gravatar_id":"","url":"https://api.github.com/users/halink0803","html_url":"https://github.com/halink0803","followers_url":"https://api.github.com/users/halink0803/followers","following_url":"https://api.github.com/users/halink0803/following{/other_user}","gists_url":"https://api.github.com/users/halink0803/gists{/gist_id}","starred_url":"https://api.github.com/users/halink0803/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halink0803/subscriptions","organizations_url":"https://api.github.com/users/halink0803/orgs","repos_url":"https://api.github.com/users/halink0803/repos","events_url":"https://api.github.com/users/halink0803/events{/privacy}","received_events_url":"https://api.github.com/users/halink0803/received_events","type":"User","site_admin":false},"body":"\"Decimal\" or \"Decimals\", why json parse is different?","created_at":"2018-07-05T03:14:18Z","updated_at":"2018-07-05T04:04:53Z","html_url":"https://github.com/KyberNetwork/reserve-data/pull/332#discussion_r200224200","pull_request_url":"https://api.github.com/repos/KyberNetwork/reserve-data/pulls/332","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/KyberNetwork/reserve-data/pulls/comments/200224200"},"html":{"href":"https://github.com/KyberNetwork/reserve-data/pull/332#discussion_r200224200"},"pull_request":{"href":"https://api.github.com/repos/KyberNetwork/reserve-data/pulls/332"}}},"pull_request":{"url":"https://api.github.com/repos/KyberNetwork/reserve-data/pulls/332","id":197333947,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MzMzOTQ3","html_url":"https://github.com/KyberNetwork/reserve-data/pull/332","diff_url":"https://github.com/KyberNetwork/reserve-data/pull/332.diff","patch_url":"https://github.com/KyberNetwork/reserve-data/pull/332.patch","issue_url":"https://api.github.com/repos/KyberNetwork/reserve-data/issues/332","number":332,"state":"open","locked":false,"title":"add and implement list-token API","user":{"login":"cyberliem","id":13779034,"node_id":"MDQ6VXNlcjEzNzc5MDM0","avatar_url":"https://avatars3.githubusercontent.com/u/13779034?v=4","gravatar_id":"","url":"https://api.github.com/users/cyberliem","html_url":"https://github.com/cyberliem","followers_url":"https://api.github.com/users/cyberliem/followers","following_url":"https://api.github.com/users/cyberliem/following{/other_user}","gists_url":"https://api.github.com/users/cyberliem/gists{/gist_id}","starred_url":"https://api.github.com/users/cyberliem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyberliem/subscriptions","organizations_url":"https://api.github.com/users/cyberliem/orgs","repos_url":"https://api.github.com/users/cyberliem/repos","events_url":"https://api.github.com/users/cyberliem/events{/privacy}","received_events_url":"https://api.github.com/users/cyberliem/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-26T08:00:24Z","updated_at":"2018-07-05T04:04:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"68a25bd92d1cc7dfd83eeee41ee12bfee00a3319","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/KyberNetwork/reserve-data/pulls/332/commits","review_comments_url":"https://api.github.com/repos/KyberNetwork/reserve-data/pulls/332/comments","review_comment_url":"https://api.github.com/repos/KyberNetwork/reserve-data/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KyberNetwork/reserve-data/issues/332/comments","statuses_url":"https://api.github.com/repos/KyberNetwork/reserve-data/statuses/83d9fafea4eabf36e276ec289939834ce5385207","head":{"label":"KyberNetwork:list_delist_token_on_fly","ref":"list_delist_token_on_fly","sha":"83d9fafea4eabf36e276ec289939834ce5385207","user":{"login":"KyberNetwork","id":28812853,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODEyODUz","avatar_url":"https://avatars0.githubusercontent.com/u/28812853?v=4","gravatar_id":"","url":"https://api.github.com/users/KyberNetwork","html_url":"https://github.com/KyberNetwork","followers_url":"https://api.github.com/users/KyberNetwork/followers","following_url":"https://api.github.com/users/KyberNetwork/following{/other_user}","gists_url":"https://api.github.com/users/KyberNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/KyberNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KyberNetwork/subscriptions","organizations_url":"https://api.github.com/users/KyberNetwork/orgs","repos_url":"https://api.github.com/users/KyberNetwork/repos","events_url":"https://api.github.com/users/KyberNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/KyberNetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":106377436,"node_id":"MDEwOlJlcG9zaXRvcnkxMDYzNzc0MzY=","name":"reserve-data","full_name":"KyberNetwork/reserve-data","owner":{"login":"KyberNetwork","id":28812853,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODEyODUz","avatar_url":"https://avatars0.githubusercontent.com/u/28812853?v=4","gravatar_id":"","url":"https://api.github.com/users/KyberNetwork","html_url":"https://github.com/KyberNetwork","followers_url":"https://api.github.com/users/KyberNetwork/followers","following_url":"https://api.github.com/users/KyberNetwork/following{/other_user}","gists_url":"https://api.github.com/users/KyberNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/KyberNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KyberNetwork/subscriptions","organizations_url":"https://api.github.com/users/KyberNetwork/orgs","repos_url":"https://api.github.com/users/KyberNetwork/repos","events_url":"https://api.github.com/users/KyberNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/KyberNetwork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KyberNetwork/reserve-data","description":"Kyber Reserve core component that helps manage reserves of tokens. It maintains market views, calculates prices and executes pricing/rebalancing instructions from analytic component.","fork":false,"url":"https://api.github.com/repos/KyberNetwork/reserve-data","forks_url":"https://api.github.com/repos/KyberNetwork/reserve-data/forks","keys_url":"https://api.github.com/repos/KyberNetwork/reserve-data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KyberNetwork/reserve-data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KyberNetwork/reserve-data/teams","hooks_url":"https://api.github.com/repos/KyberNetwork/reserve-data/hooks","issue_events_url":"https://api.github.com/repos/KyberNetwork/reserve-data/issues/events{/number}","events_url":"https://api.github.com/repos/KyberNetwork/reserve-data/events","assignees_url":"https://api.github.com/repos/KyberNetwork/reserve-data/assignees{/user}","branches_url":"https://api.github.com/repos/KyberNetwork/reserve-data/branches{/branch}","tags_url":"https://api.github.com/repos/KyberNetwork/reserve-data/tags","blobs_url":"https://api.github.com/repos/KyberNetwork/reserve-data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KyberNetwork/reserve-data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KyberNetwork/reserve-data/git/refs{/sha}","trees_url":"https://api.github.com/repos/KyberNetwork/reserve-data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KyberNetwork/reserve-data/statuses/{sha}","languages_url":"https://api.github.com/repos/KyberNetwork/reserve-data/languages","stargazers_url":"https://api.github.com/repos/KyberNetwork/reserve-data/stargazers","contributors_url":"https://api.github.com/repos/KyberNetwork/reserve-data/contributors","subscribers_url":"https://api.github.com/repos/KyberNetwork/reserve-data/subscribers","subscription_url":"https://api.github.com/repos/KyberNetwork/reserve-data/subscription","commits_url":"https://api.github.com/repos/KyberNetwork/reserve-data/commits{/sha}","git_commits_url":"https://api.github.com/repos/KyberNetwork/reserve-data/git/commits{/sha}","comments_url":"https://api.github.com/repos/KyberNetwork/reserve-data/comments{/number}","issue_comment_url":"https://api.github.com/repos/KyberNetwork/reserve-data/issues/comments{/number}","contents_url":"https://api.github.com/repos/KyberNetwork/reserve-data/contents/{+path}","compare_url":"https://api.github.com/repos/KyberNetwork/reserve-data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KyberNetwork/reserve-data/merges","archive_url":"https://api.github.com/repos/KyberNetwork/reserve-data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KyberNetwork/reserve-data/downloads","issues_url":"https://api.github.com/repos/KyberNetwork/reserve-data/issues{/number}","pulls_url":"https://api.github.com/repos/KyberNetwork/reserve-data/pulls{/number}","milestones_url":"https://api.github.com/repos/KyberNetwork/reserve-data/milestones{/number}","notifications_url":"https://api.github.com/repos/KyberNetwork/reserve-data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KyberNetwork/reserve-data/labels{/name}","releases_url":"https://api.github.com/repos/KyberNetwork/reserve-data/releases{/id}","deployments_url":"https://api.github.com/repos/KyberNetwork/reserve-data/deployments","created_at":"2017-10-10T06:32:00Z","updated_at":"2018-07-04T02:46:19Z","pushed_at":"2018-07-04T17:00:47Z","git_url":"git://github.com/KyberNetwork/reserve-data.git","ssh_url":"git@github.com:KyberNetwork/reserve-data.git","clone_url":"https://github.com/KyberNetwork/reserve-data.git","svn_url":"https://github.com/KyberNetwork/reserve-data","homepage":"","size":59750,"stargazers_count":34,"watchers_count":34,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":18,"open_issues":9,"watchers":34,"default_branch":"develop"}},"base":{"label":"KyberNetwork:reorganize_core_setting","ref":"reorganize_core_setting","sha":"3cbf739097d096337b7b321ba15a208a95b863d1","user":{"login":"KyberNetwork","id":28812853,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODEyODUz","avatar_url":"https://avatars0.githubusercontent.com/u/28812853?v=4","gravatar_id":"","url":"https://api.github.com/users/KyberNetwork","html_url":"https://github.com/KyberNetwork","followers_url":"https://api.github.com/users/KyberNetwork/followers","following_url":"https://api.github.com/users/KyberNetwork/following{/other_user}","gists_url":"https://api.github.com/users/KyberNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/KyberNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KyberNetwork/subscriptions","organizations_url":"https://api.github.com/users/KyberNetwork/orgs","repos_url":"https://api.github.com/users/KyberNetwork/repos","events_url":"https://api.github.com/users/KyberNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/KyberNetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":106377436,"node_id":"MDEwOlJlcG9zaXRvcnkxMDYzNzc0MzY=","name":"reserve-data","full_name":"KyberNetwork/reserve-data","owner":{"login":"KyberNetwork","id":28812853,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODEyODUz","avatar_url":"https://avatars0.githubusercontent.com/u/28812853?v=4","gravatar_id":"","url":"https://api.github.com/users/KyberNetwork","html_url":"https://github.com/KyberNetwork","followers_url":"https://api.github.com/users/KyberNetwork/followers","following_url":"https://api.github.com/users/KyberNetwork/following{/other_user}","gists_url":"https://api.github.com/users/KyberNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/KyberNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KyberNetwork/subscriptions","organizations_url":"https://api.github.com/users/KyberNetwork/orgs","repos_url":"https://api.github.com/users/KyberNetwork/repos","events_url":"https://api.github.com/users/KyberNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/KyberNetwork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KyberNetwork/reserve-data","description":"Kyber Reserve core component that helps manage reserves of tokens. It maintains market views, calculates prices and executes pricing/rebalancing instructions from analytic component.","fork":false,"url":"https://api.github.com/repos/KyberNetwork/reserve-data","forks_url":"https://api.github.com/repos/KyberNetwork/reserve-data/forks","keys_url":"https://api.github.com/repos/KyberNetwork/reserve-data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KyberNetwork/reserve-data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KyberNetwork/reserve-data/teams","hooks_url":"https://api.github.com/repos/KyberNetwork/reserve-data/hooks","issue_events_url":"https://api.github.com/repos/KyberNetwork/reserve-data/issues/events{/number}","events_url":"https://api.github.com/repos/KyberNetwork/reserve-data/events","assignees_url":"https://api.github.com/repos/KyberNetwork/reserve-data/assignees{/user}","branches_url":"https://api.github.com/repos/KyberNetwork/reserve-data/branches{/branch}","tags_url":"https://api.github.com/repos/KyberNetwork/reserve-data/tags","blobs_url":"https://api.github.com/repos/KyberNetwork/reserve-data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KyberNetwork/reserve-data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KyberNetwork/reserve-data/git/refs{/sha}","trees_url":"https://api.github.com/repos/KyberNetwork/reserve-data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KyberNetwork/reserve-data/statuses/{sha}","languages_url":"https://api.github.com/repos/KyberNetwork/reserve-data/languages","stargazers_url":"https://api.github.com/repos/KyberNetwork/reserve-data/stargazers","contributors_url":"https://api.github.com/repos/KyberNetwork/reserve-data/contributors","subscribers_url":"https://api.github.com/repos/KyberNetwork/reserve-data/subscribers","subscription_url":"https://api.github.com/repos/KyberNetwork/reserve-data/subscription","commits_url":"https://api.github.com/repos/KyberNetwork/reserve-data/commits{/sha}","git_commits_url":"https://api.github.com/repos/KyberNetwork/reserve-data/git/commits{/sha}","comments_url":"https://api.github.com/repos/KyberNetwork/reserve-data/comments{/number}","issue_comment_url":"https://api.github.com/repos/KyberNetwork/reserve-data/issues/comments{/number}","contents_url":"https://api.github.com/repos/KyberNetwork/reserve-data/contents/{+path}","compare_url":"https://api.github.com/repos/KyberNetwork/reserve-data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KyberNetwork/reserve-data/merges","archive_url":"https://api.github.com/repos/KyberNetwork/reserve-data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KyberNetwork/reserve-data/downloads","issues_url":"https://api.github.com/repos/KyberNetwork/reserve-data/issues{/number}","pulls_url":"https://api.github.com/repos/KyberNetwork/reserve-data/pulls{/number}","milestones_url":"https://api.github.com/repos/KyberNetwork/reserve-data/milestones{/number}","notifications_url":"https://api.github.com/repos/KyberNetwork/reserve-data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KyberNetwork/reserve-data/labels{/name}","releases_url":"https://api.github.com/repos/KyberNetwork/reserve-data/releases{/id}","deployments_url":"https://api.github.com/repos/KyberNetwork/reserve-data/deployments","created_at":"2017-10-10T06:32:00Z","updated_at":"2018-07-04T02:46:19Z","pushed_at":"2018-07-04T17:00:47Z","git_url":"git://github.com/KyberNetwork/reserve-data.git","ssh_url":"git@github.com:KyberNetwork/reserve-data.git","clone_url":"https://github.com/KyberNetwork/reserve-data.git","svn_url":"https://github.com/KyberNetwork/reserve-data","homepage":"","size":59750,"stargazers_count":34,"watchers_count":34,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":18,"open_issues":9,"watchers":34,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/KyberNetwork/reserve-data/pulls/332"},"html":{"href":"https://github.com/KyberNetwork/reserve-data/pull/332"},"issue":{"href":"https://api.github.com/repos/KyberNetwork/reserve-data/issues/332"},"comments":{"href":"https://api.github.com/repos/KyberNetwork/reserve-data/issues/332/comments"},"review_comments":{"href":"https://api.github.com/repos/KyberNetwork/reserve-data/pulls/332/comments"},"review_comment":{"href":"https://api.github.com/repos/KyberNetwork/reserve-data/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KyberNetwork/reserve-data/pulls/332/commits"},"statuses":{"href":"https://api.github.com/repos/KyberNetwork/reserve-data/statuses/83d9fafea4eabf36e276ec289939834ce5385207"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"halink0803"}}