{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react-native/issues/20602","repository_url":"https://api.github.com/repos/facebook/react-native","labels_url":"https://api.github.com/repos/facebook/react-native/issues/20602/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/20602/comments","events_url":"https://api.github.com/repos/facebook/react-native/issues/20602/events","html_url":"https://github.com/facebook/react-native/pull/20602","id":349136370,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MzIzMTEy","number":20602,"title":"ReactActivity extends AppCompatActivity","user":{"login":"dulmandakh","id":178494,"node_id":"MDQ6VXNlcjE3ODQ5NA==","avatar_url":"https://avatars2.githubusercontent.com/u/178494?v=4","gravatar_id":"","url":"https://api.github.com/users/dulmandakh","html_url":"https://github.com/dulmandakh","followers_url":"https://api.github.com/users/dulmandakh/followers","following_url":"https://api.github.com/users/dulmandakh/following{/other_user}","gists_url":"https://api.github.com/users/dulmandakh/gists{/gist_id}","starred_url":"https://api.github.com/users/dulmandakh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dulmandakh/subscriptions","organizations_url":"https://api.github.com/users/dulmandakh/orgs","repos_url":"https://api.github.com/users/dulmandakh/repos","events_url":"https://api.github.com/users/dulmandakh/events{/privacy}","received_events_url":"https://api.github.com/users/dulmandakh/received_events","type":"User","site_admin":false},"labels":[{"id":869757822,"node_id":"MDU6TGFiZWw4Njk3NTc4MjI=","url":"https://api.github.com/repos/facebook/react-native/labels/:clipboard:No%20Release%20Notes","name":":clipboard:No Release Notes","color":"d4c5f9","default":false},{"id":868807707,"node_id":"MDU6TGFiZWw4Njg4MDc3MDc=","url":"https://api.github.com/repos/facebook/react-native/labels/:clock1:PR%20Waiting%20on%20FB","name":":clock1:PR Waiting on FB","color":"0052cc","default":false},{"id":934239421,"node_id":"MDU6TGFiZWw5MzQyMzk0MjE=","url":"https://api.github.com/repos/facebook/react-native/labels/:white_check_mark:Test%20Plan","name":":white_check_mark:Test Plan","color":"0e8a16","default":false},{"id":196858975,"node_id":"MDU6TGFiZWwxOTY4NTg5NzU=","url":"https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed","name":"CLA Signed","color":"ffffff","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-08-09T13:49:48Z","updated_at":"2018-09-13T17:14:54Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/20602","html_url":"https://github.com/facebook/react-native/pull/20602","diff_url":"https://github.com/facebook/react-native/pull/20602.diff","patch_url":"https://github.com/facebook/react-native/pull/20602.patch"},"body":"With this PR, ReactActivity extends AppCompatActivity per Google recommendation. \r\n\r\nThis is subset of https://github.com/facebook/react-native/pull/19950, based on lessons learned from conversation. If merged, I'll create smaller, less distruptive PRs to land changes from the original PR.\r\n\r\nTest Plan:\r\n----------\r\nEverything builds and works normally."},"comment":{"url":"https://api.github.com/repos/facebook/react-native/issues/comments/421083230","html_url":"https://github.com/facebook/react-native/pull/20602#issuecomment-421083230","issue_url":"https://api.github.com/repos/facebook/react-native/issues/20602","id":421083230,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTA4MzIzMA==","user":{"login":"hramos","id":165856,"node_id":"MDQ6VXNlcjE2NTg1Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/165856?v=4","gravatar_id":"","url":"https://api.github.com/users/hramos","html_url":"https://github.com/hramos","followers_url":"https://api.github.com/users/hramos/followers","following_url":"https://api.github.com/users/hramos/following{/other_user}","gists_url":"https://api.github.com/users/hramos/gists{/gist_id}","starred_url":"https://api.github.com/users/hramos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hramos/subscriptions","organizations_url":"https://api.github.com/users/hramos/orgs","repos_url":"https://api.github.com/users/hramos/repos","events_url":"https://api.github.com/users/hramos/events{/privacy}","received_events_url":"https://api.github.com/users/hramos/received_events","type":"User","site_admin":false},"created_at":"2018-09-13T17:14:54Z","updated_at":"2018-09-13T17:14:54Z","author_association":"CONTRIBUTOR","body":"Here's some of the errors I saw:\r\n\r\n```\r\njs/react-native-github/RNTester/android/app/src/main/java/com/facebook/react/uiapp/RNTesterApplication.java:37: error: cannot find symbol\r\n      return BuildConfig.DEBUG;\r\n             ^\r\n```\r\n\r\nOne of the other errors I saw, is related to the Navigator that was removed. I recognized this as one of the errors that has since been fixed on master, so I'm rebasing the internal diff and waiting for tests to run again. These can take a few hours to run (hence it can take a day or two to see these through)."}}
{"actor":{"display_login":"hramos"}}