{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/python-language-server/pulls/comments/216749258","pull_request_review_id":154305310,"id":216749258,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjc0OTI1OA==","diff_hunk":"@@ -603,26 +603,29 @@ private sealed class ReloadModulesQueueItem : IAnalyzable {\n             }\n         }\n \n-        internal void EnqueueItem(IDocument doc, AnalysisPriority priority = AnalysisPriority.Normal, bool enqueueForAnalysis = true) {\n+        internal void EnqueueItem(IDocument doc, AnalysisPriority priority = AnalysisPriority.Normal, bool parse = true, bool enqueueForAnalysis = true) {\n             _disposableBag.ThrowIfDisposed();\n             var pending = _pendingAnalysisEnqueue.Incremented();\n             try {\n-                Task<IAnalysisCookie> cookieTask;\n-                using (GetDocumentParseCounter(doc, out var count)) {\n-                    if (count > 3) {\n-                        // Rough check to prevent unbounded queueing. If we have\n-                        // multiple parses in queue, we will get the latest doc\n-                        // version in one of the ones to come.\n-                        return;\n-                    }\n-                    TraceMessage($\"Parsing document {doc.DocumentUri}\");\n-                    cookieTask = ParseQueue.Enqueue(doc, Analyzer.LanguageVersion);\n-                }\n-\n                 if (doc is ProjectEntry entry) {\n                     entry.ResetCompleteAnalysis();\n                 }\n \n+                // If we don't need to parse, use null cooking\n+                var cookieTask = Task.FromResult<IAnalysisCookie>(null);","path":"src/LanguageServer/Impl/Implementation/Server.cs","position":53,"original_position":53,"commit_id":"d7ea75281336e05bdc4e924a08825fb1751ea5c2","original_commit_id":"d7ea75281336e05bdc4e924a08825fb1751ea5c2","user":{"login":"MikhailArkhipov","id":12820357,"node_id":"MDQ6VXNlcjEyODIwMzU3","avatar_url":"https://avatars2.githubusercontent.com/u/12820357?v=4","gravatar_id":"","url":"https://api.github.com/users/MikhailArkhipov","html_url":"https://github.com/MikhailArkhipov","followers_url":"https://api.github.com/users/MikhailArkhipov/followers","following_url":"https://api.github.com/users/MikhailArkhipov/following{/other_user}","gists_url":"https://api.github.com/users/MikhailArkhipov/gists{/gist_id}","starred_url":"https://api.github.com/users/MikhailArkhipov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikhailArkhipov/subscriptions","organizations_url":"https://api.github.com/users/MikhailArkhipov/orgs","repos_url":"https://api.github.com/users/MikhailArkhipov/repos","events_url":"https://api.github.com/users/MikhailArkhipov/events{/privacy}","received_events_url":"https://api.github.com/users/MikhailArkhipov/received_events","type":"User","site_admin":false},"body":"Yes, since we didn't reparse","created_at":"2018-09-11T17:14:23Z","updated_at":"2018-09-11T17:14:23Z","html_url":"https://github.com/Microsoft/python-language-server/pull/82#discussion_r216749258","pull_request_url":"https://api.github.com/repos/Microsoft/python-language-server/pulls/82","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/python-language-server/pulls/comments/216749258"},"html":{"href":"https://github.com/Microsoft/python-language-server/pull/82#discussion_r216749258"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/python-language-server/pulls/82"}},"in_reply_to_id":216741675},"pull_request":{"url":"https://api.github.com/repos/Microsoft/python-language-server/pulls/82","id":214474974,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NDc0OTc0","html_url":"https://github.com/Microsoft/python-language-server/pull/82","diff_url":"https://github.com/Microsoft/python-language-server/pull/82.diff","patch_url":"https://github.com/Microsoft/python-language-server/pull/82.patch","issue_url":"https://api.github.com/repos/Microsoft/python-language-server/issues/82","number":82,"state":"open","locked":false,"title":"Fix CompletionAfterLoad test","user":{"login":"MikhailArkhipov","id":12820357,"node_id":"MDQ6VXNlcjEyODIwMzU3","avatar_url":"https://avatars2.githubusercontent.com/u/12820357?v=4","gravatar_id":"","url":"https://api.github.com/users/MikhailArkhipov","html_url":"https://github.com/MikhailArkhipov","followers_url":"https://api.github.com/users/MikhailArkhipov/followers","following_url":"https://api.github.com/users/MikhailArkhipov/following{/other_user}","gists_url":"https://api.github.com/users/MikhailArkhipov/gists{/gist_id}","starred_url":"https://api.github.com/users/MikhailArkhipov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikhailArkhipov/subscriptions","organizations_url":"https://api.github.com/users/MikhailArkhipov/orgs","repos_url":"https://api.github.com/users/MikhailArkhipov/repos","events_url":"https://api.github.com/users/MikhailArkhipov/events{/privacy}","received_events_url":"https://api.github.com/users/MikhailArkhipov/received_events","type":"User","site_admin":false},"body":"Actually looks like product bug. When adding/removing files, for dependent files we should be going through normal chain via `EnqueueItem` which does many useful things and not directly calling `AnalysisQueue.Enqueue`. We do can save on not parsing, but events should be fired and diagnostics should be updated.","created_at":"2018-09-10T23:46:57Z","updated_at":"2018-09-11T17:14:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"48a56e2ebe17be5e48f589448e633e8166c0b322","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/python-language-server/pulls/82/commits","review_comments_url":"https://api.github.com/repos/Microsoft/python-language-server/pulls/82/comments","review_comment_url":"https://api.github.com/repos/Microsoft/python-language-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/python-language-server/issues/82/comments","statuses_url":"https://api.github.com/repos/Microsoft/python-language-server/statuses/d7ea75281336e05bdc4e924a08825fb1751ea5c2","head":{"label":"MikhailArkhipov:master","ref":"master","sha":"d7ea75281336e05bdc4e924a08825fb1751ea5c2","user":{"login":"MikhailArkhipov","id":12820357,"node_id":"MDQ6VXNlcjEyODIwMzU3","avatar_url":"https://avatars2.githubusercontent.com/u/12820357?v=4","gravatar_id":"","url":"https://api.github.com/users/MikhailArkhipov","html_url":"https://github.com/MikhailArkhipov","followers_url":"https://api.github.com/users/MikhailArkhipov/followers","following_url":"https://api.github.com/users/MikhailArkhipov/following{/other_user}","gists_url":"https://api.github.com/users/MikhailArkhipov/gists{/gist_id}","starred_url":"https://api.github.com/users/MikhailArkhipov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikhailArkhipov/subscriptions","organizations_url":"https://api.github.com/users/MikhailArkhipov/orgs","repos_url":"https://api.github.com/users/MikhailArkhipov/repos","events_url":"https://api.github.com/users/MikhailArkhipov/events{/privacy}","received_events_url":"https://api.github.com/users/MikhailArkhipov/received_events","type":"User","site_admin":false},"repo":{"id":147745457,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc3NDU0NTc=","name":"python-language-server","full_name":"MikhailArkhipov/python-language-server","owner":{"login":"MikhailArkhipov","id":12820357,"node_id":"MDQ6VXNlcjEyODIwMzU3","avatar_url":"https://avatars2.githubusercontent.com/u/12820357?v=4","gravatar_id":"","url":"https://api.github.com/users/MikhailArkhipov","html_url":"https://github.com/MikhailArkhipov","followers_url":"https://api.github.com/users/MikhailArkhipov/followers","following_url":"https://api.github.com/users/MikhailArkhipov/following{/other_user}","gists_url":"https://api.github.com/users/MikhailArkhipov/gists{/gist_id}","starred_url":"https://api.github.com/users/MikhailArkhipov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikhailArkhipov/subscriptions","organizations_url":"https://api.github.com/users/MikhailArkhipov/orgs","repos_url":"https://api.github.com/users/MikhailArkhipov/repos","events_url":"https://api.github.com/users/MikhailArkhipov/events{/privacy}","received_events_url":"https://api.github.com/users/MikhailArkhipov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MikhailArkhipov/python-language-server","description":"Microsoft Language Server for Python","fork":true,"url":"https://api.github.com/repos/MikhailArkhipov/python-language-server","forks_url":"https://api.github.com/repos/MikhailArkhipov/python-language-server/forks","keys_url":"https://api.github.com/repos/MikhailArkhipov/python-language-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MikhailArkhipov/python-language-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MikhailArkhipov/python-language-server/teams","hooks_url":"https://api.github.com/repos/MikhailArkhipov/python-language-server/hooks","issue_events_url":"https://api.github.com/repos/MikhailArkhipov/python-language-server/issues/events{/number}","events_url":"https://api.github.com/repos/MikhailArkhipov/python-language-server/events","assignees_url":"https://api.github.com/repos/MikhailArkhipov/python-language-server/assignees{/user}","branches_url":"https://api.github.com/repos/MikhailArkhipov/python-language-server/branches{/branch}","tags_url":"https://api.github.com/repos/MikhailArkhipov/python-language-server/tags","blobs_url":"https://api.github.com/repos/MikhailArkhipov/python-language-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MikhailArkhipov/python-language-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MikhailArkhipov/python-language-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/MikhailArkhipov/python-language-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MikhailArkhipov/python-language-server/statuses/{sha}","languages_url":"https://api.github.com/repos/MikhailArkhipov/python-language-server/languages","stargazers_url":"https://api.github.com/repos/MikhailArkhipov/python-language-server/stargazers","contributors_url":"https://api.github.com/repos/MikhailArkhipov/python-language-server/contributors","subscribers_url":"https://api.github.com/repos/MikhailArkhipov/python-language-server/subscribers","subscription_url":"https://api.github.com/repos/MikhailArkhipov/python-language-server/subscription","commits_url":"https://api.github.com/repos/MikhailArkhipov/python-language-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/MikhailArkhipov/python-language-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/MikhailArkhipov/python-language-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/MikhailArkhipov/python-language-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/MikhailArkhipov/python-language-server/contents/{+path}","compare_url":"https://api.github.com/repos/MikhailArkhipov/python-language-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MikhailArkhipov/python-language-server/merges","archive_url":"https://api.github.com/repos/MikhailArkhipov/python-language-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MikhailArkhipov/python-language-server/downloads","issues_url":"https://api.github.com/repos/MikhailArkhipov/python-language-server/issues{/number}","pulls_url":"https://api.github.com/repos/MikhailArkhipov/python-language-server/pulls{/number}","milestones_url":"https://api.github.com/repos/MikhailArkhipov/python-language-server/milestones{/number}","notifications_url":"https://api.github.com/repos/MikhailArkhipov/python-language-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MikhailArkhipov/python-language-server/labels{/name}","releases_url":"https://api.github.com/repos/MikhailArkhipov/python-language-server/releases{/id}","deployments_url":"https://api.github.com/repos/MikhailArkhipov/python-language-server/deployments","created_at":"2018-09-06T23:38:01Z","updated_at":"2018-09-10T23:43:48Z","pushed_at":"2018-09-11T17:13:38Z","git_url":"git://github.com/MikhailArkhipov/python-language-server.git","ssh_url":"git@github.com:MikhailArkhipov/python-language-server.git","clone_url":"https://github.com/MikhailArkhipov/python-language-server.git","svn_url":"https://github.com/MikhailArkhipov/python-language-server","homepage":null,"size":1574,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"60e7c98e718762203b471dd27dd3c823f41b875c","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":145901977,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU5MDE5Nzc=","name":"python-language-server","full_name":"Microsoft/python-language-server","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/python-language-server","description":"Microsoft Language Server for Python","fork":false,"url":"https://api.github.com/repos/Microsoft/python-language-server","forks_url":"https://api.github.com/repos/Microsoft/python-language-server/forks","keys_url":"https://api.github.com/repos/Microsoft/python-language-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/python-language-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/python-language-server/teams","hooks_url":"https://api.github.com/repos/Microsoft/python-language-server/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/python-language-server/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/python-language-server/events","assignees_url":"https://api.github.com/repos/Microsoft/python-language-server/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/python-language-server/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/python-language-server/tags","blobs_url":"https://api.github.com/repos/Microsoft/python-language-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/python-language-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/python-language-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/python-language-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/python-language-server/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/python-language-server/languages","stargazers_url":"https://api.github.com/repos/Microsoft/python-language-server/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/python-language-server/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/python-language-server/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/python-language-server/subscription","commits_url":"https://api.github.com/repos/Microsoft/python-language-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/python-language-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/python-language-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/python-language-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/python-language-server/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/python-language-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/python-language-server/merges","archive_url":"https://api.github.com/repos/Microsoft/python-language-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/python-language-server/downloads","issues_url":"https://api.github.com/repos/Microsoft/python-language-server/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/python-language-server/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/python-language-server/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/python-language-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/python-language-server/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/python-language-server/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/python-language-server/deployments","created_at":"2018-08-23T20:09:46Z","updated_at":"2018-09-11T16:28:14Z","pushed_at":"2018-09-11T16:28:13Z","git_url":"git://github.com/Microsoft/python-language-server.git","ssh_url":"git@github.com:Microsoft/python-language-server.git","clone_url":"https://github.com/Microsoft/python-language-server.git","svn_url":"https://github.com/Microsoft/python-language-server","homepage":null,"size":1588,"stargazers_count":9,"watchers_count":9,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":51,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":51,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/python-language-server/pulls/82"},"html":{"href":"https://github.com/Microsoft/python-language-server/pull/82"},"issue":{"href":"https://api.github.com/repos/Microsoft/python-language-server/issues/82"},"comments":{"href":"https://api.github.com/repos/Microsoft/python-language-server/issues/82/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/python-language-server/pulls/82/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/python-language-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/python-language-server/pulls/82/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/python-language-server/statuses/d7ea75281336e05bdc4e924a08825fb1751ea5c2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"MikhailArkhipov"}}