{"action":"created","comment":{"url":"https://api.github.com/repos/voxpupuli/puppet-rundeck/pulls/comments/224987719","pull_request_review_id":164493351,"id":224987719,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDk4NzcxOQ==","diff_hunk":"@@ -61,7 +55,7 @@\n     'framework.ssh.keypath'     => '/var/lib/rundeck/.ssh/id_rsa',\n     'framework.ssh.user'        => 'rundeck',\n     'framework.ssh.timeout'     => '0',\n-    'rundeck.server.uuid'       => $rdeck_uuid,\n+    'rundeck.server.uuid'       => fqdn_uuid($::fqdn),","path":"manifests/params.pp","position":18,"original_position":18,"commit_id":"819a2716f1efa7d2b56e130051660a1e9abefe99","original_commit_id":"819a2716f1efa7d2b56e130051660a1e9abefe99","user":{"login":"bastelfreak","id":341866,"node_id":"MDQ6VXNlcjM0MTg2Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/341866?v=4","gravatar_id":"","url":"https://api.github.com/users/bastelfreak","html_url":"https://github.com/bastelfreak","followers_url":"https://api.github.com/users/bastelfreak/followers","following_url":"https://api.github.com/users/bastelfreak/following{/other_user}","gists_url":"https://api.github.com/users/bastelfreak/gists{/gist_id}","starred_url":"https://api.github.com/users/bastelfreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bastelfreak/subscriptions","organizations_url":"https://api.github.com/users/bastelfreak/orgs","repos_url":"https://api.github.com/users/bastelfreak/repos","events_url":"https://api.github.com/users/bastelfreak/events{/privacy}","received_events_url":"https://api.github.com/users/bastelfreak/received_events","type":"User","site_admin":false},"body":"can you please use `$facts['fqdn']` instead?","created_at":"2018-10-14T10:41:26Z","updated_at":"2018-10-14T10:41:26Z","html_url":"https://github.com/voxpupuli/puppet-rundeck/pull/401#discussion_r224987719","pull_request_url":"https://api.github.com/repos/voxpupuli/puppet-rundeck/pulls/401","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/voxpupuli/puppet-rundeck/pulls/comments/224987719"},"html":{"href":"https://github.com/voxpupuli/puppet-rundeck/pull/401#discussion_r224987719"},"pull_request":{"href":"https://api.github.com/repos/voxpupuli/puppet-rundeck/pulls/401"}}},"pull_request":{"url":"https://api.github.com/repos/voxpupuli/puppet-rundeck/pulls/401","id":219524662,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NTI0NjYy","html_url":"https://github.com/voxpupuli/puppet-rundeck/pull/401","diff_url":"https://github.com/voxpupuli/puppet-rundeck/pull/401.diff","patch_url":"https://github.com/voxpupuli/puppet-rundeck/pull/401.patch","issue_url":"https://api.github.com/repos/voxpupuli/puppet-rundeck/issues/401","number":401,"state":"open","locked":false,"title":"Turn serialnumber into UUID","user":{"login":"jescholl","id":5530993,"node_id":"MDQ6VXNlcjU1MzA5OTM=","avatar_url":"https://avatars3.githubusercontent.com/u/5530993?v=4","gravatar_id":"","url":"https://api.github.com/users/jescholl","html_url":"https://github.com/jescholl","followers_url":"https://api.github.com/users/jescholl/followers","following_url":"https://api.github.com/users/jescholl/following{/other_user}","gists_url":"https://api.github.com/users/jescholl/gists{/gist_id}","starred_url":"https://api.github.com/users/jescholl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jescholl/subscriptions","organizations_url":"https://api.github.com/users/jescholl/orgs","repos_url":"https://api.github.com/users/jescholl/repos","events_url":"https://api.github.com/users/jescholl/events{/privacy}","received_events_url":"https://api.github.com/users/jescholl/received_events","type":"User","site_admin":false},"body":"#### Pull Request (PR) description\r\nThis PR generates the server UUID from the serial number rather than just using the serial number directly, since serial numbers are rarely valid RFC 4122 UUIDs.\r\n\r\nWith cluster mode enabled, Rundeck requires that `rundeck.server.uuid` be a valid RFC 4122 UUID ([Rundeck source](https://github.com/rundeck/rundeck/blob/d4d1b189728c82953fae1c6d39b5665f817e3549/rundeckapp/grails-app/conf/BootStrap.groovy#L183-L197)).\r\n\r\n\r\n#### This Pull Request (PR) fixes the following issues\r\nn/a","created_at":"2018-10-01T21:39:37Z","updated_at":"2018-10-14T10:41:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a55d3f17135011a443594655ff1ac7521c274f66","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/voxpupuli/puppet-rundeck/pulls/401/commits","review_comments_url":"https://api.github.com/repos/voxpupuli/puppet-rundeck/pulls/401/comments","review_comment_url":"https://api.github.com/repos/voxpupuli/puppet-rundeck/pulls/comments{/number}","comments_url":"https://api.github.com/repos/voxpupuli/puppet-rundeck/issues/401/comments","statuses_url":"https://api.github.com/repos/voxpupuli/puppet-rundeck/statuses/819a2716f1efa7d2b56e130051660a1e9abefe99","head":{"label":"jescholl:serialnumber_to_uuid","ref":"serialnumber_to_uuid","sha":"819a2716f1efa7d2b56e130051660a1e9abefe99","user":{"login":"jescholl","id":5530993,"node_id":"MDQ6VXNlcjU1MzA5OTM=","avatar_url":"https://avatars3.githubusercontent.com/u/5530993?v=4","gravatar_id":"","url":"https://api.github.com/users/jescholl","html_url":"https://github.com/jescholl","followers_url":"https://api.github.com/users/jescholl/followers","following_url":"https://api.github.com/users/jescholl/following{/other_user}","gists_url":"https://api.github.com/users/jescholl/gists{/gist_id}","starred_url":"https://api.github.com/users/jescholl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jescholl/subscriptions","organizations_url":"https://api.github.com/users/jescholl/orgs","repos_url":"https://api.github.com/users/jescholl/repos","events_url":"https://api.github.com/users/jescholl/events{/privacy}","received_events_url":"https://api.github.com/users/jescholl/received_events","type":"User","site_admin":false},"repo":{"id":140750426,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA3NTA0MjY=","name":"puppet-rundeck","full_name":"jescholl/puppet-rundeck","private":false,"owner":{"login":"jescholl","id":5530993,"node_id":"MDQ6VXNlcjU1MzA5OTM=","avatar_url":"https://avatars3.githubusercontent.com/u/5530993?v=4","gravatar_id":"","url":"https://api.github.com/users/jescholl","html_url":"https://github.com/jescholl","followers_url":"https://api.github.com/users/jescholl/followers","following_url":"https://api.github.com/users/jescholl/following{/other_user}","gists_url":"https://api.github.com/users/jescholl/gists{/gist_id}","starred_url":"https://api.github.com/users/jescholl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jescholl/subscriptions","organizations_url":"https://api.github.com/users/jescholl/orgs","repos_url":"https://api.github.com/users/jescholl/repos","events_url":"https://api.github.com/users/jescholl/events{/privacy}","received_events_url":"https://api.github.com/users/jescholl/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jescholl/puppet-rundeck","description":"Module for managing the installatation and configuration of the rundeck orchestration tool","fork":true,"url":"https://api.github.com/repos/jescholl/puppet-rundeck","forks_url":"https://api.github.com/repos/jescholl/puppet-rundeck/forks","keys_url":"https://api.github.com/repos/jescholl/puppet-rundeck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jescholl/puppet-rundeck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jescholl/puppet-rundeck/teams","hooks_url":"https://api.github.com/repos/jescholl/puppet-rundeck/hooks","issue_events_url":"https://api.github.com/repos/jescholl/puppet-rundeck/issues/events{/number}","events_url":"https://api.github.com/repos/jescholl/puppet-rundeck/events","assignees_url":"https://api.github.com/repos/jescholl/puppet-rundeck/assignees{/user}","branches_url":"https://api.github.com/repos/jescholl/puppet-rundeck/branches{/branch}","tags_url":"https://api.github.com/repos/jescholl/puppet-rundeck/tags","blobs_url":"https://api.github.com/repos/jescholl/puppet-rundeck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jescholl/puppet-rundeck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jescholl/puppet-rundeck/git/refs{/sha}","trees_url":"https://api.github.com/repos/jescholl/puppet-rundeck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jescholl/puppet-rundeck/statuses/{sha}","languages_url":"https://api.github.com/repos/jescholl/puppet-rundeck/languages","stargazers_url":"https://api.github.com/repos/jescholl/puppet-rundeck/stargazers","contributors_url":"https://api.github.com/repos/jescholl/puppet-rundeck/contributors","subscribers_url":"https://api.github.com/repos/jescholl/puppet-rundeck/subscribers","subscription_url":"https://api.github.com/repos/jescholl/puppet-rundeck/subscription","commits_url":"https://api.github.com/repos/jescholl/puppet-rundeck/commits{/sha}","git_commits_url":"https://api.github.com/repos/jescholl/puppet-rundeck/git/commits{/sha}","comments_url":"https://api.github.com/repos/jescholl/puppet-rundeck/comments{/number}","issue_comment_url":"https://api.github.com/repos/jescholl/puppet-rundeck/issues/comments{/number}","contents_url":"https://api.github.com/repos/jescholl/puppet-rundeck/contents/{+path}","compare_url":"https://api.github.com/repos/jescholl/puppet-rundeck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jescholl/puppet-rundeck/merges","archive_url":"https://api.github.com/repos/jescholl/puppet-rundeck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jescholl/puppet-rundeck/downloads","issues_url":"https://api.github.com/repos/jescholl/puppet-rundeck/issues{/number}","pulls_url":"https://api.github.com/repos/jescholl/puppet-rundeck/pulls{/number}","milestones_url":"https://api.github.com/repos/jescholl/puppet-rundeck/milestones{/number}","notifications_url":"https://api.github.com/repos/jescholl/puppet-rundeck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jescholl/puppet-rundeck/labels{/name}","releases_url":"https://api.github.com/repos/jescholl/puppet-rundeck/releases{/id}","deployments_url":"https://api.github.com/repos/jescholl/puppet-rundeck/deployments","created_at":"2018-07-12T18:26:32Z","updated_at":"2018-09-28T23:10:50Z","pushed_at":"2018-10-08T17:43:10Z","git_url":"git://github.com/jescholl/puppet-rundeck.git","ssh_url":"git@github.com:jescholl/puppet-rundeck.git","clone_url":"https://github.com/jescholl/puppet-rundeck.git","svn_url":"https://github.com/jescholl/puppet-rundeck","homepage":"https://forge.puppet.com/puppet/rundeck","size":839,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"voxpupuli:master","ref":"master","sha":"abd2a572875fb36bef48b7355d352ef10a869f99","user":{"login":"voxpupuli","id":8693967,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2OTM5Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/8693967?v=4","gravatar_id":"","url":"https://api.github.com/users/voxpupuli","html_url":"https://github.com/voxpupuli","followers_url":"https://api.github.com/users/voxpupuli/followers","following_url":"https://api.github.com/users/voxpupuli/following{/other_user}","gists_url":"https://api.github.com/users/voxpupuli/gists{/gist_id}","starred_url":"https://api.github.com/users/voxpupuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voxpupuli/subscriptions","organizations_url":"https://api.github.com/users/voxpupuli/orgs","repos_url":"https://api.github.com/users/voxpupuli/repos","events_url":"https://api.github.com/users/voxpupuli/events{/privacy}","received_events_url":"https://api.github.com/users/voxpupuli/received_events","type":"Organization","site_admin":false},"repo":{"id":18207323,"node_id":"MDEwOlJlcG9zaXRvcnkxODIwNzMyMw==","name":"puppet-rundeck","full_name":"voxpupuli/puppet-rundeck","private":false,"owner":{"login":"voxpupuli","id":8693967,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2OTM5Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/8693967?v=4","gravatar_id":"","url":"https://api.github.com/users/voxpupuli","html_url":"https://github.com/voxpupuli","followers_url":"https://api.github.com/users/voxpupuli/followers","following_url":"https://api.github.com/users/voxpupuli/following{/other_user}","gists_url":"https://api.github.com/users/voxpupuli/gists{/gist_id}","starred_url":"https://api.github.com/users/voxpupuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voxpupuli/subscriptions","organizations_url":"https://api.github.com/users/voxpupuli/orgs","repos_url":"https://api.github.com/users/voxpupuli/repos","events_url":"https://api.github.com/users/voxpupuli/events{/privacy}","received_events_url":"https://api.github.com/users/voxpupuli/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/voxpupuli/puppet-rundeck","description":"Module for managing the installatation and configuration of the rundeck orchestration tool","fork":false,"url":"https://api.github.com/repos/voxpupuli/puppet-rundeck","forks_url":"https://api.github.com/repos/voxpupuli/puppet-rundeck/forks","keys_url":"https://api.github.com/repos/voxpupuli/puppet-rundeck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/voxpupuli/puppet-rundeck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/voxpupuli/puppet-rundeck/teams","hooks_url":"https://api.github.com/repos/voxpupuli/puppet-rundeck/hooks","issue_events_url":"https://api.github.com/repos/voxpupuli/puppet-rundeck/issues/events{/number}","events_url":"https://api.github.com/repos/voxpupuli/puppet-rundeck/events","assignees_url":"https://api.github.com/repos/voxpupuli/puppet-rundeck/assignees{/user}","branches_url":"https://api.github.com/repos/voxpupuli/puppet-rundeck/branches{/branch}","tags_url":"https://api.github.com/repos/voxpupuli/puppet-rundeck/tags","blobs_url":"https://api.github.com/repos/voxpupuli/puppet-rundeck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/voxpupuli/puppet-rundeck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/voxpupuli/puppet-rundeck/git/refs{/sha}","trees_url":"https://api.github.com/repos/voxpupuli/puppet-rundeck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/voxpupuli/puppet-rundeck/statuses/{sha}","languages_url":"https://api.github.com/repos/voxpupuli/puppet-rundeck/languages","stargazers_url":"https://api.github.com/repos/voxpupuli/puppet-rundeck/stargazers","contributors_url":"https://api.github.com/repos/voxpupuli/puppet-rundeck/contributors","subscribers_url":"https://api.github.com/repos/voxpupuli/puppet-rundeck/subscribers","subscription_url":"https://api.github.com/repos/voxpupuli/puppet-rundeck/subscription","commits_url":"https://api.github.com/repos/voxpupuli/puppet-rundeck/commits{/sha}","git_commits_url":"https://api.github.com/repos/voxpupuli/puppet-rundeck/git/commits{/sha}","comments_url":"https://api.github.com/repos/voxpupuli/puppet-rundeck/comments{/number}","issue_comment_url":"https://api.github.com/repos/voxpupuli/puppet-rundeck/issues/comments{/number}","contents_url":"https://api.github.com/repos/voxpupuli/puppet-rundeck/contents/{+path}","compare_url":"https://api.github.com/repos/voxpupuli/puppet-rundeck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/voxpupuli/puppet-rundeck/merges","archive_url":"https://api.github.com/repos/voxpupuli/puppet-rundeck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/voxpupuli/puppet-rundeck/downloads","issues_url":"https://api.github.com/repos/voxpupuli/puppet-rundeck/issues{/number}","pulls_url":"https://api.github.com/repos/voxpupuli/puppet-rundeck/pulls{/number}","milestones_url":"https://api.github.com/repos/voxpupuli/puppet-rundeck/milestones{/number}","notifications_url":"https://api.github.com/repos/voxpupuli/puppet-rundeck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/voxpupuli/puppet-rundeck/labels{/name}","releases_url":"https://api.github.com/repos/voxpupuli/puppet-rundeck/releases{/id}","deployments_url":"https://api.github.com/repos/voxpupuli/puppet-rundeck/deployments","created_at":"2014-03-28T09:35:23Z","updated_at":"2018-10-13T18:15:20Z","pushed_at":"2018-10-13T18:15:20Z","git_url":"git://github.com/voxpupuli/puppet-rundeck.git","ssh_url":"git@github.com:voxpupuli/puppet-rundeck.git","clone_url":"https://github.com/voxpupuli/puppet-rundeck.git","svn_url":"https://github.com/voxpupuli/puppet-rundeck","homepage":"https://forge.puppet.com/puppet/rundeck","size":854,"stargazers_count":32,"watchers_count":32,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":116,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":116,"open_issues":18,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/voxpupuli/puppet-rundeck/pulls/401"},"html":{"href":"https://github.com/voxpupuli/puppet-rundeck/pull/401"},"issue":{"href":"https://api.github.com/repos/voxpupuli/puppet-rundeck/issues/401"},"comments":{"href":"https://api.github.com/repos/voxpupuli/puppet-rundeck/issues/401/comments"},"review_comments":{"href":"https://api.github.com/repos/voxpupuli/puppet-rundeck/pulls/401/comments"},"review_comment":{"href":"https://api.github.com/repos/voxpupuli/puppet-rundeck/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/voxpupuli/puppet-rundeck/pulls/401/commits"},"statuses":{"href":"https://api.github.com/repos/voxpupuli/puppet-rundeck/statuses/819a2716f1efa7d2b56e130051660a1e9abefe99"}},"author_association":"NONE"}}
{"actor":{"display_login":"bastelfreak"}}