{"action":"closed","issue":{"url":"https://api.github.com/repos/reactioncommerce/reaction/issues/3637","repository_url":"https://api.github.com/repos/reactioncommerce/reaction","labels_url":"https://api.github.com/repos/reactioncommerce/reaction/issues/3637/labels{/name}","comments_url":"https://api.github.com/repos/reactioncommerce/reaction/issues/3637/comments","events_url":"https://api.github.com/repos/reactioncommerce/reaction/issues/3637/events","html_url":"https://github.com/reactioncommerce/reaction/issues/3637","id":293732576,"number":3637,"title":"Product Images are using full res image and not the processed versions","user":{"login":"nnnnat","id":1135948,"avatar_url":"https://avatars0.githubusercontent.com/u/1135948?v=4","gravatar_id":"","url":"https://api.github.com/users/nnnnat","html_url":"https://github.com/nnnnat","followers_url":"https://api.github.com/users/nnnnat/followers","following_url":"https://api.github.com/users/nnnnat/following{/other_user}","gists_url":"https://api.github.com/users/nnnnat/gists{/gist_id}","starred_url":"https://api.github.com/users/nnnnat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nnnnat/subscriptions","organizations_url":"https://api.github.com/users/nnnnat/orgs","repos_url":"https://api.github.com/users/nnnnat/repos","events_url":"https://api.github.com/users/nnnnat/events{/privacy}","received_events_url":"https://api.github.com/users/nnnnat/received_events","type":"User","site_admin":false},"labels":[{"id":377481506,"url":"https://api.github.com/repos/reactioncommerce/reaction/labels/bug","name":"bug","color":"ff3737","default":true},{"id":695679879,"url":"https://api.github.com/repos/reactioncommerce/reaction/labels/impact-major","name":"impact-major","color":"d93f0b","default":false},{"id":539719712,"url":"https://api.github.com/repos/reactioncommerce/reaction/labels/performance","name":"performance","color":"FF00FF","default":false}],"state":"closed","locked":false,"assignee":{"login":"kieckhafer","id":4482263,"avatar_url":"https://avatars2.githubusercontent.com/u/4482263?v=4","gravatar_id":"","url":"https://api.github.com/users/kieckhafer","html_url":"https://github.com/kieckhafer","followers_url":"https://api.github.com/users/kieckhafer/followers","following_url":"https://api.github.com/users/kieckhafer/following{/other_user}","gists_url":"https://api.github.com/users/kieckhafer/gists{/gist_id}","starred_url":"https://api.github.com/users/kieckhafer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kieckhafer/subscriptions","organizations_url":"https://api.github.com/users/kieckhafer/orgs","repos_url":"https://api.github.com/users/kieckhafer/repos","events_url":"https://api.github.com/users/kieckhafer/events{/privacy}","received_events_url":"https://api.github.com/users/kieckhafer/received_events","type":"User","site_admin":false},"assignees":[{"login":"kieckhafer","id":4482263,"avatar_url":"https://avatars2.githubusercontent.com/u/4482263?v=4","gravatar_id":"","url":"https://api.github.com/users/kieckhafer","html_url":"https://github.com/kieckhafer","followers_url":"https://api.github.com/users/kieckhafer/followers","following_url":"https://api.github.com/users/kieckhafer/following{/other_user}","gists_url":"https://api.github.com/users/kieckhafer/gists{/gist_id}","starred_url":"https://api.github.com/users/kieckhafer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kieckhafer/subscriptions","organizations_url":"https://api.github.com/users/kieckhafer/orgs","repos_url":"https://api.github.com/users/kieckhafer/repos","events_url":"https://api.github.com/users/kieckhafer/events{/privacy}","received_events_url":"https://api.github.com/users/kieckhafer/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/reactioncommerce/reaction/milestones/65","html_url":"https://github.com/reactioncommerce/reaction/milestone/65","labels_url":"https://api.github.com/repos/reactioncommerce/reaction/milestones/65/labels","id":3101912,"number":65,"title":"Bugfix Sprint 1","description":"Manually top to bottom walkthrough and cleanup.  Writing scripts for crowdsourcing QA.","creator":{"login":"spencern","id":1203639,"avatar_url":"https://avatars0.githubusercontent.com/u/1203639?v=4","gravatar_id":"","url":"https://api.github.com/users/spencern","html_url":"https://github.com/spencern","followers_url":"https://api.github.com/users/spencern/followers","following_url":"https://api.github.com/users/spencern/following{/other_user}","gists_url":"https://api.github.com/users/spencern/gists{/gist_id}","starred_url":"https://api.github.com/users/spencern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spencern/subscriptions","organizations_url":"https://api.github.com/users/spencern/orgs","repos_url":"https://api.github.com/users/spencern/repos","events_url":"https://api.github.com/users/spencern/events{/privacy}","received_events_url":"https://api.github.com/users/spencern/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":23,"state":"open","created_at":"2018-02-09T05:51:38Z","updated_at":"2018-02-20T18:14:04Z","due_on":"2018-02-19T08:00:00Z","closed_at":null},"comments":2,"created_at":"2018-02-02T00:28:16Z","updated_at":"2018-02-20T18:14:04Z","closed_at":"2018-02-20T18:14:04Z","author_association":"MEMBER","body":"When I was working on this [PR](https://github.com/reactioncommerce/reaction/pull/3631) I started to notice the full resolution product image was being used in almost every instance. I thought it was only in my branch but I've tested it on master and have seen it every time. Can someone test and confirm I'm not crazy?\r\n\r\n### Expected behavior\r\n- Product images should be referencing the appropriate image crop in the `src` attribute.\r\n- For example, product images on the invoice page should be using the `thumbnail` crop\r\n- The image `src` path should look something like this `/assets/files/Media/Z5v7ARFEjWKdoSymL/shoe.jpg?token=eyJhdXRoVG9rZW4iOiJwVnVKS2J5WVRjcG1yOG03QU4ybk15ZkFPb2VXUzJjaGh6Y0VERHZwckxvIn0%3D&store=thumbnail`\r\n\r\n### Actual behavior\r\n- Product images are only referencing the full resolution uploaded image\r\n- Product image `src` path looks like this `/assets/files/Media/Z5v7ARFEjWKdoSymL/shoe.jpg?token=eyJhdXRoVG9rZW4iOiJwVnVKS2J5WVRjcG1yOG03QU4ybk15ZkFPb2VXUzJjaGh6Y0VERHZwckxvIn0%3D` without the `&store={size}`\r\n\r\n### Steps to reproduce the behavior\r\n- Run `reaction reset` to get a fresh reaction store.\r\n- Login as admin and upload new product images to the sample product\r\n- Upload images to each product variant\r\n- Check the `src` and image info of the new product images to see it's referencing the original uploaded image and not the cropped version\r\n- In another browser purchase both product variants as a guest\r\n- On the invoice page, inspect the product thumbnails to see it referencing the full image and not the thumbnail version\r\n\r\n**screenshots**\r\n<img width=\"1680\" alt=\"product-detail\" src=\"https://user-images.githubusercontent.com/1135948/35709952-94ca8438-077a-11e8-9765-2c50e433be05.png\">\r\nexample of small image referencing the og image\r\n\r\n<br/>\r\n\r\n<img width=\"614\" alt=\"product-varient\" src=\"https://user-images.githubusercontent.com/1135948/35710002-c84ae0dc-077a-11e8-95c8-c2af087bc40d.png\">\r\nproduct variant images referencing the og image and not the small square version\r\n\r\n<br/>\r\n<br/>\r\n\r\n<img width=\"308\" alt=\"invoice-thumbnails\" src=\"https://user-images.githubusercontent.com/1135948/35710052-f7f9b3a8-077a-11e8-848b-935b4e5c999b.png\">\r\nproduct thumbnail on the invoice/receipt page using the og image and not the thumbnail version\r\n\r\n### Notes\r\n**Possible Cause**\r\nI did some poking around the code base and I think the issue might be coming from these React Components ([media.js](https://github.com/reactioncommerce/reaction/blob/f40ff536c139d70da02ca10ae12655247452d658/imports/plugins/core/ui/client/components/media/media.js#L88) & [mediaGallery.js](https://github.com/reactioncommerce/reaction/blob/f40ff536c139d70da02ca10ae12655247452d658/imports/plugins/core/ui/client/containers/mediaGallery.js#L87)) I'm still pretty new to RC so I might be totally wrong about this.\r\n\r\n**Possible related issue**\r\n#3399 \r\n\r\n**Images I used**\r\n![bike](https://user-images.githubusercontent.com/1135948/35710409-ed06fa76-077c-11e8-965a-107b27526384.jpg)\r\n![shoe](https://user-images.githubusercontent.com/1135948/35710410-ed1bb7e0-077c-11e8-8eaf-35eaa8328204.jpg)\r\n\r\n### Versions\r\n```shell\r\nNode: 9.4.0\r\nNPM: 5.6.0\r\nMeteor Node: 8.9.3\r\nMeteor NPM: 5.5.1\r\nReaction CLI: 0.26.4\r\nReaction: 1.7.0\r\nReaction branch: master\r\n```"}}
{"actor":{"display_login":"spencern"}}