{"push_id":3084679590,"size":10,"distinct_size":2,"ref":"refs/heads/bugfix/naming-constant-name-cop","head":"2611c067d5c93febe304919d96b17dec6f41e2df","before":"913d562e4d037c3496b988eaa801d3d101363e17","commits":[{"sha":"437abe62ff16c74567cfee88f52357af18e0b70e","author":{"name":"Koichi ITO","email":"62fb6e080cf43b35af11716cc49ab9063e71c433@gmail.com"},"message":"[Fix #6509] Fix an incorrect auto-correct for `Style/RaiseArgs`\n\nFixes #6509.\n\nThis PR fixes an incorrect auto-correct for `Style/RaiseArgs` when\nan exception object is assigned to a local variable.\n\nThe following is an issue example.\n\n```console\n% rubocop -V\n0.60.0 (using Parser 2.5.3.0, running on ruby 2.5.3 x86_64-darwin17)\n% cat example.rb\ndef do_something\n  klass = RuntimeError\n  raise klass.new('hi')\nend\n```\n\n## Before\n\n```console\n% rubocop -a example.rb --only Style/RaiseArgs\n(snip)\n% cat example.rb\ndef do_something\n  klass = RuntimeError\n  raise , 'hi'\nend\n```\n\n## After\n\n```console\n% rubocop -a example.rb --only Style/RaiseArgs\n(snip)\n% cat example.rb\ndef do_something\n  klass = RuntimeError\n  raise klass, 'hi'\nend\n```","distinct":false,"url":"https://api.github.com/repos/tatsuyafw/rubocop/commits/437abe62ff16c74567cfee88f52357af18e0b70e"},{"sha":"3cae42e0756591ab375ad21a38d662678978f498","author":{"name":"Ted Johansson","email":"72983587b9c0659e0b236adfb3d0e84524ad7c78@gmail.com"},"message":"Add missing test case for TrailingCommaInArguments spec","distinct":false,"url":"https://api.github.com/repos/tatsuyafw/rubocop/commits/3cae42e0756591ab375ad21a38d662678978f498"},{"sha":"3b84c5e49391509b5af315c0db988f724eaf826b","author":{"name":"Ted Johansson","email":"72983587b9c0659e0b236adfb3d0e84524ad7c78@gmail.com"},"message":"Simplify complex TrailingComma#multiline? method","distinct":false,"url":"https://api.github.com/repos/tatsuyafw/rubocop/commits/3b84c5e49391509b5af315c0db988f724eaf826b"},{"sha":"3aa93511378d78e0a3712a8b5748e7e583ab0c64","author":{"name":"Genadi Samokovarov","email":"4df7f3dad182da66af235a1249daf95d26b3dee6@gmail.com"},"message":"Parentheses omission check for method calls with logical operators\n\nThis is an edge case for the newly introduced alternative style for the\n`Style/MethodCallWithArgsParentheses` cop that enforces the parentheses\nomission method calls style.\n\nWhen you call methods guarding them with logical operators, you could\nhave wanted to be explicit, or you could caused a syntax error when you\nomit the parentheses. This change relaxes the `omit_parentheses` style\ncheck for those cases.","distinct":false,"url":"https://api.github.com/repos/tatsuyafw/rubocop/commits/3aa93511378d78e0a3712a8b5748e7e583ab0c64"},{"sha":"51912f1702feb635390ff2c6fa9053685cc14b4f","author":{"name":"Genadi Samokovarov","email":"4df7f3dad182da66af235a1249daf95d26b3dee6@gmail.com"},"message":"Allow parentheses presence in method kw and regular splats","distinct":false,"url":"https://api.github.com/repos/tatsuyafw/rubocop/commits/51912f1702feb635390ff2c6fa9053685cc14b4f"},{"sha":"b59f5a37bfec03e8876a61a358e248519884191a","author":{"name":"Genadi Samokovarov","email":"4df7f3dad182da66af235a1249daf95d26b3dee6@gmail.com"},"message":"Allow parentheses in block passing","distinct":false,"url":"https://api.github.com/repos/tatsuyafw/rubocop/commits/b59f5a37bfec03e8876a61a358e248519884191a"},{"sha":"9c3d75614fce4eb6478cb5fb1ed691907189ebfe","author":{"name":"Genadi Samokovarov","email":"4df7f3dad182da66af235a1249daf95d26b3dee6@gmail.com"},"message":"Accept parentheses for super calls without arguments\n\nThat's a way to signal that you want to pass no arguments to the\n\"parent\" method.","distinct":false,"url":"https://api.github.com/repos/tatsuyafw/rubocop/commits/9c3d75614fce4eb6478cb5fb1ed691907189ebfe"},{"sha":"c32d96888b0a778e63dda5c2329c63907739473a","author":{"name":"Koichi ITO","email":"62fb6e080cf43b35af11716cc49ab9063e71c433@gmail.com"},"message":"[Fix #6511] Fix an incorrect auto-correct for `Style/EmptyCaseCondition` (#6513)\n\nFixes #6511.\r\n\r\nThis issue is a regression by #6257.\r\n\r\nThis PR fixes an incorrect auto-correct for `Style/EmptyCaseCondition` when\r\nused as an argument of a method. The following is an issue example.\r\n\r\n```ruby\r\n# example.rb\r\ndo_some_work case\r\n             when object.nil?\r\n               Object.new\r\n             else\r\n               object\r\n             end\r\n```\r\n\r\nThe following is a reproduction step.\r\n\r\n```console\r\n% rubocop -V\r\n0.60.0 (using Parser 2.5.3.0, running on ruby 2.5.3 x86_64-darwin17)\r\n% rubocop -a example.rb --only Style/EmptyCaseCondition\r\n% cat example.rb\r\n             # example.rb\r\n             if object.nil?\r\n               Object.new\r\n             else\r\n               object\r\n             end\r\n```\r\n\r\nThe above has a bug to remove method call.\r\n\r\nThis PR will make the following corrections.\r\n\r\n```console\r\n% rubocop -V\r\n0.60.0 (using Parser 2.5.3.0, running on ruby 2.5.3 x86_64-darwin17)\r\n% rubocop -a example.rb --only Style/EmptyCaseCondition\r\n% cat example.rb\r\n# example.rb\r\ndo_some_work if object.nil?\r\n               Object.new\r\n             else\r\n               object\r\n             end\r\n```","distinct":false,"url":"https://api.github.com/repos/tatsuyafw/rubocop/commits/c32d96888b0a778e63dda5c2329c63907739473a"},{"sha":"aa2c86fd45463acd2818650898771bd9bed8731b","author":{"name":"Koichi ITO","email":"62fb6e080cf43b35af11716cc49ab9063e71c433@gmail.com"},"message":"Tweak a documentation for `Performance/OpenStruct`\n\nFollow up of #6486.\n\nThis PR displays details missing in the document.","distinct":true,"url":"https://api.github.com/repos/tatsuyafw/rubocop/commits/aa2c86fd45463acd2818650898771bd9bed8731b"},{"sha":"2611c067d5c93febe304919d96b17dec6f41e2df","author":{"name":"Tatsuya Hoshino","email":"0bff36f3ac60f027a58b4a9b42e06dd7e9d6404d@gmail.com"},"message":"[Fix #6100] Fix a false positive in `Naming/ConstantName` cop\n\nThis cop would register an offense when rhs is a conditional expression\nlike the following code:\n\n```\nLol = if true then Foo else Bar end\n```\n\nThis change fixes that.","distinct":true,"url":"https://api.github.com/repos/tatsuyafw/rubocop/commits/2611c067d5c93febe304919d96b17dec6f41e2df"}]}
{"actor":{"display_login":"tatsuyafw"}}