{"action":"created","issue":{"url":"https://api.github.com/repos/dennisweissmann/DeviceKit/issues/161","repository_url":"https://api.github.com/repos/dennisweissmann/DeviceKit","labels_url":"https://api.github.com/repos/dennisweissmann/DeviceKit/issues/161/labels{/name}","comments_url":"https://api.github.com/repos/dennisweissmann/DeviceKit/issues/161/comments","events_url":"https://api.github.com/repos/dennisweissmann/DeviceKit/issues/161/events","html_url":"https://github.com/dennisweissmann/DeviceKit/pull/161","id":390710701,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NDE0Nzc2","number":161,"title":"Added more expansive orientation support","user":{"login":"AdiAyyakad","id":901668,"node_id":"MDQ6VXNlcjkwMTY2OA==","avatar_url":"https://avatars1.githubusercontent.com/u/901668?v=4","gravatar_id":"","url":"https://api.github.com/users/AdiAyyakad","html_url":"https://github.com/AdiAyyakad","followers_url":"https://api.github.com/users/AdiAyyakad/followers","following_url":"https://api.github.com/users/AdiAyyakad/following{/other_user}","gists_url":"https://api.github.com/users/AdiAyyakad/gists{/gist_id}","starred_url":"https://api.github.com/users/AdiAyyakad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdiAyyakad/subscriptions","organizations_url":"https://api.github.com/users/AdiAyyakad/orgs","repos_url":"https://api.github.com/users/AdiAyyakad/repos","events_url":"https://api.github.com/users/AdiAyyakad/events{/privacy}","received_events_url":"https://api.github.com/users/AdiAyyakad/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-13T14:45:24Z","updated_at":"2018-12-13T14:48:06Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/dennisweissmann/DeviceKit/pulls/161","html_url":"https://github.com/dennisweissmann/DeviceKit/pull/161","diff_url":"https://github.com/dennisweissmann/DeviceKit/pull/161.diff","patch_url":"https://github.com/dennisweissmann/DeviceKit/pull/161.patch"},"body":"The current `Orientation` enum isn't really accurate - there are many types of orientations that iOS supports so I think those should be properly represented in the enum."},"comment":{"url":"https://api.github.com/repos/dennisweissmann/DeviceKit/issues/comments/446994199","html_url":"https://github.com/dennisweissmann/DeviceKit/pull/161#issuecomment-446994199","issue_url":"https://api.github.com/repos/dennisweissmann/DeviceKit/issues/161","id":446994199,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0Njk5NDE5OQ==","user":{"login":"devicekit-danger-bot","id":29066222,"node_id":"MDQ6VXNlcjI5MDY2MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/29066222?v=4","gravatar_id":"","url":"https://api.github.com/users/devicekit-danger-bot","html_url":"https://github.com/devicekit-danger-bot","followers_url":"https://api.github.com/users/devicekit-danger-bot/followers","following_url":"https://api.github.com/users/devicekit-danger-bot/following{/other_user}","gists_url":"https://api.github.com/users/devicekit-danger-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/devicekit-danger-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devicekit-danger-bot/subscriptions","organizations_url":"https://api.github.com/users/devicekit-danger-bot/orgs","repos_url":"https://api.github.com/users/devicekit-danger-bot/repos","events_url":"https://api.github.com/users/devicekit-danger-bot/events{/privacy}","received_events_url":"https://api.github.com/users/devicekit-danger-bot/received_events","type":"User","site_admin":false},"created_at":"2018-12-13T14:48:06Z","updated_at":"2018-12-13T14:48:06Z","author_association":"NONE","body":"<!--\n  0 Errors\n  4 Warnings: Plist changed, don’t forget to...\n  0 Messages\n  1 Markdown\n-->\n<table>\n  <thead>\n    <tr>\n      <th width=\"50\"></th>\n      <th width=\"100%\" data-danger-table=\"true\" data-kind=\"Warning\">\n          4 Warnings\n      </th>\n     </tr>\n  </thead>\n  <tbody>\n    <tr>\n      <td>:warning:</td>\n      <td data-sticky=\"false\">Plist changed, don’t forget to localize your plist values</td>\n    </tr>\n    <tr>\n      <td>:warning:</td>\n      <td data-sticky=\"false\"><a href=\"https://github.com/dennisweissmann/DeviceKit/blob/7d71a421c43e3fd4a3ff0ccc3b6f0745b63b3731/Source/Device.generated.swift#L290\">Source/Device.generated.swift#L290</a> - Function body should span 40 lines or less excluding comments and whitespace: currently spans 63 lines</td>\n    </tr>\n    <tr>\n      <td>:warning:</td>\n      <td data-sticky=\"false\"><a href=\"https://github.com/dennisweissmann/DeviceKit/blob/7d71a421c43e3fd4a3ff0ccc3b6f0745b63b3731/Source/Device.generated.swift#L607\">Source/Device.generated.swift#L607</a> - TODOs should be resolved (Longterm we need a better solu…).</td>\n    </tr>\n    <tr>\n      <td>:warning:</td>\n      <td data-sticky=\"false\"><a href=\"https://github.com/dennisweissmann/DeviceKit/blob/7d71a421c43e3fd4a3ff0ccc3b6f0745b63b3731/Source/Device.generated.swift#L1149\">Source/Device.generated.swift#L1149</a> - Prefer empty collection over optional collection.</td>\n    </tr>\n  </tbody>\n</table>\n\n### SwiftLint found issues\n\n#### Warnings\n\nFile | Line | Reason |\n| --- | ----- | ----- |\nDevice.generated.swift | 1149 | Prefer empty collection over optional collection. \nDevice.generated.swift | 607 | TODOs should be resolved (Longterm we need a better solu...). \nDevice.generated.swift | 290 | Function body should span 40 lines or less excluding comments and whitespace: currently spans 63 lines \n\n\n<p align=\"right\" data-meta=\"generated_by_danger\">\n  Generated by :no_entry_sign: <a href=\"https://danger.systems/\">Danger</a>\n</p>\n"}}
{"actor":{"display_login":"devicekit-danger-bot"}}