{"action":"opened","number":103,"pull_request":{"url":"https://api.github.com/repos/Ref12/Codex/pulls/103","id":182598110,"html_url":"https://github.com/Ref12/Codex/pull/103","diff_url":"https://github.com/Ref12/Codex/pull/103.diff","patch_url":"https://github.com/Ref12/Codex/pull/103.patch","issue_url":"https://api.github.com/repos/Ref12/Codex/issues/103","number":103,"state":"open","locked":false,"title":"Delete Microsoft.Build.* assemblies from build output and use Microsoft.Build.Locator","user":{"login":"DustinCampbell","id":116161,"avatar_url":"https://avatars0.githubusercontent.com/u/116161?v=4","gravatar_id":"","url":"https://api.github.com/users/DustinCampbell","html_url":"https://github.com/DustinCampbell","followers_url":"https://api.github.com/users/DustinCampbell/followers","following_url":"https://api.github.com/users/DustinCampbell/following{/other_user}","gists_url":"https://api.github.com/users/DustinCampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/DustinCampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DustinCampbell/subscriptions","organizations_url":"https://api.github.com/users/DustinCampbell/orgs","repos_url":"https://api.github.com/users/DustinCampbell/repos","events_url":"https://api.github.com/users/DustinCampbell/events{/privacy}","received_events_url":"https://api.github.com/users/DustinCampbell/received_events","type":"User","site_admin":false},"body":"Fixes #102\r\n\r\nCodex directly and indirectly references the `Microsoft.Build`, `Microsoft.Build.Framework`, `Microsoft.Build.Tasks.Core` and `Microsoft.Build.Utilities.Core` packages, causing those assemblies to be copied to the build output. Then, when Codex uses the MSBuild APIs it loads these specific `Microsoft.Build*` assemblies, but they aren't compatible with the tasks and targets in the MSBuild toolset installed with more recent versions of VS 2017. So, bad things happen. :smile:\r\n\r\nThis change removes the offending assemblies from the build output as a custom build step. In the future, if Codex is converted over to using `<PackageReference/>` rather than `packages.config` the custom build step can be removed and the package references for those MSBuild packages should have the `ExcludeAssets=\"Runtime\"` and `PrivateAssets=\"All\"` attributes included on them to ensure they don't get copied.\r\n\r\nWith the `Microsoft.Build.*` assemblies removed, Codex needs to find them somewhere. So, this change adds the `Microsoft.Build.Locator` package and along with a call to `MSBuildLocator.RegisterDefaults()`. This installs an `AppDomain.AssemblyResolve` that will resolve the `Microsoft.Build.*` assemblies from the default instance of VS 2017 that is found on the current machine. So, the versions of those assemblies that are loaded will be compatible with the tasks and targets in the instance of VS.","created_at":"2018-04-18T20:46:11Z","updated_at":"2018-04-18T20:46:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Ref12/Codex/pulls/103/commits","review_comments_url":"https://api.github.com/repos/Ref12/Codex/pulls/103/comments","review_comment_url":"https://api.github.com/repos/Ref12/Codex/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Ref12/Codex/issues/103/comments","statuses_url":"https://api.github.com/repos/Ref12/Codex/statuses/4c45ab520b4cfc099c15408cc8407c0a9231181f","head":{"label":"DustinCampbell:use-msbuildlocator","ref":"use-msbuildlocator","sha":"4c45ab520b4cfc099c15408cc8407c0a9231181f","user":{"login":"DustinCampbell","id":116161,"avatar_url":"https://avatars0.githubusercontent.com/u/116161?v=4","gravatar_id":"","url":"https://api.github.com/users/DustinCampbell","html_url":"https://github.com/DustinCampbell","followers_url":"https://api.github.com/users/DustinCampbell/followers","following_url":"https://api.github.com/users/DustinCampbell/following{/other_user}","gists_url":"https://api.github.com/users/DustinCampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/DustinCampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DustinCampbell/subscriptions","organizations_url":"https://api.github.com/users/DustinCampbell/orgs","repos_url":"https://api.github.com/users/DustinCampbell/repos","events_url":"https://api.github.com/users/DustinCampbell/events{/privacy}","received_events_url":"https://api.github.com/users/DustinCampbell/received_events","type":"User","site_admin":false},"repo":{"id":130118597,"name":"Codex","full_name":"DustinCampbell/Codex","owner":{"login":"DustinCampbell","id":116161,"avatar_url":"https://avatars0.githubusercontent.com/u/116161?v=4","gravatar_id":"","url":"https://api.github.com/users/DustinCampbell","html_url":"https://github.com/DustinCampbell","followers_url":"https://api.github.com/users/DustinCampbell/followers","following_url":"https://api.github.com/users/DustinCampbell/following{/other_user}","gists_url":"https://api.github.com/users/DustinCampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/DustinCampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DustinCampbell/subscriptions","organizations_url":"https://api.github.com/users/DustinCampbell/orgs","repos_url":"https://api.github.com/users/DustinCampbell/repos","events_url":"https://api.github.com/users/DustinCampbell/events{/privacy}","received_events_url":"https://api.github.com/users/DustinCampbell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DustinCampbell/Codex","description":"An extensible platform for indexing and exploring inspired by Source Browser","fork":true,"url":"https://api.github.com/repos/DustinCampbell/Codex","forks_url":"https://api.github.com/repos/DustinCampbell/Codex/forks","keys_url":"https://api.github.com/repos/DustinCampbell/Codex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DustinCampbell/Codex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DustinCampbell/Codex/teams","hooks_url":"https://api.github.com/repos/DustinCampbell/Codex/hooks","issue_events_url":"https://api.github.com/repos/DustinCampbell/Codex/issues/events{/number}","events_url":"https://api.github.com/repos/DustinCampbell/Codex/events","assignees_url":"https://api.github.com/repos/DustinCampbell/Codex/assignees{/user}","branches_url":"https://api.github.com/repos/DustinCampbell/Codex/branches{/branch}","tags_url":"https://api.github.com/repos/DustinCampbell/Codex/tags","blobs_url":"https://api.github.com/repos/DustinCampbell/Codex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DustinCampbell/Codex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DustinCampbell/Codex/git/refs{/sha}","trees_url":"https://api.github.com/repos/DustinCampbell/Codex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DustinCampbell/Codex/statuses/{sha}","languages_url":"https://api.github.com/repos/DustinCampbell/Codex/languages","stargazers_url":"https://api.github.com/repos/DustinCampbell/Codex/stargazers","contributors_url":"https://api.github.com/repos/DustinCampbell/Codex/contributors","subscribers_url":"https://api.github.com/repos/DustinCampbell/Codex/subscribers","subscription_url":"https://api.github.com/repos/DustinCampbell/Codex/subscription","commits_url":"https://api.github.com/repos/DustinCampbell/Codex/commits{/sha}","git_commits_url":"https://api.github.com/repos/DustinCampbell/Codex/git/commits{/sha}","comments_url":"https://api.github.com/repos/DustinCampbell/Codex/comments{/number}","issue_comment_url":"https://api.github.com/repos/DustinCampbell/Codex/issues/comments{/number}","contents_url":"https://api.github.com/repos/DustinCampbell/Codex/contents/{+path}","compare_url":"https://api.github.com/repos/DustinCampbell/Codex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DustinCampbell/Codex/merges","archive_url":"https://api.github.com/repos/DustinCampbell/Codex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DustinCampbell/Codex/downloads","issues_url":"https://api.github.com/repos/DustinCampbell/Codex/issues{/number}","pulls_url":"https://api.github.com/repos/DustinCampbell/Codex/pulls{/number}","milestones_url":"https://api.github.com/repos/DustinCampbell/Codex/milestones{/number}","notifications_url":"https://api.github.com/repos/DustinCampbell/Codex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DustinCampbell/Codex/labels{/name}","releases_url":"https://api.github.com/repos/DustinCampbell/Codex/releases{/id}","deployments_url":"https://api.github.com/repos/DustinCampbell/Codex/deployments","created_at":"2018-04-18T20:31:48Z","updated_at":"2018-04-18T20:31:51Z","pushed_at":"2018-04-18T20:35:15Z","git_url":"git://github.com/DustinCampbell/Codex.git","ssh_url":"git@github.com:DustinCampbell/Codex.git","clone_url":"https://github.com/DustinCampbell/Codex.git","svn_url":"https://github.com/DustinCampbell/Codex","homepage":null,"size":6084,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Ref12:master","ref":"master","sha":"189b075bb5b2212c09c877a2af5d5fe0a78b28a2","user":{"login":"Ref12","id":29315643,"avatar_url":"https://avatars2.githubusercontent.com/u/29315643?v=4","gravatar_id":"","url":"https://api.github.com/users/Ref12","html_url":"https://github.com/Ref12","followers_url":"https://api.github.com/users/Ref12/followers","following_url":"https://api.github.com/users/Ref12/following{/other_user}","gists_url":"https://api.github.com/users/Ref12/gists{/gist_id}","starred_url":"https://api.github.com/users/Ref12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ref12/subscriptions","organizations_url":"https://api.github.com/users/Ref12/orgs","repos_url":"https://api.github.com/users/Ref12/repos","events_url":"https://api.github.com/users/Ref12/events{/privacy}","received_events_url":"https://api.github.com/users/Ref12/received_events","type":"Organization","site_admin":false},"repo":{"id":95313988,"name":"Codex","full_name":"Ref12/Codex","owner":{"login":"Ref12","id":29315643,"avatar_url":"https://avatars2.githubusercontent.com/u/29315643?v=4","gravatar_id":"","url":"https://api.github.com/users/Ref12","html_url":"https://github.com/Ref12","followers_url":"https://api.github.com/users/Ref12/followers","following_url":"https://api.github.com/users/Ref12/following{/other_user}","gists_url":"https://api.github.com/users/Ref12/gists{/gist_id}","starred_url":"https://api.github.com/users/Ref12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ref12/subscriptions","organizations_url":"https://api.github.com/users/Ref12/orgs","repos_url":"https://api.github.com/users/Ref12/repos","events_url":"https://api.github.com/users/Ref12/events{/privacy}","received_events_url":"https://api.github.com/users/Ref12/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Ref12/Codex","description":"An extensible platform for indexing and exploring inspired by Source Browser","fork":false,"url":"https://api.github.com/repos/Ref12/Codex","forks_url":"https://api.github.com/repos/Ref12/Codex/forks","keys_url":"https://api.github.com/repos/Ref12/Codex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ref12/Codex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ref12/Codex/teams","hooks_url":"https://api.github.com/repos/Ref12/Codex/hooks","issue_events_url":"https://api.github.com/repos/Ref12/Codex/issues/events{/number}","events_url":"https://api.github.com/repos/Ref12/Codex/events","assignees_url":"https://api.github.com/repos/Ref12/Codex/assignees{/user}","branches_url":"https://api.github.com/repos/Ref12/Codex/branches{/branch}","tags_url":"https://api.github.com/repos/Ref12/Codex/tags","blobs_url":"https://api.github.com/repos/Ref12/Codex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ref12/Codex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ref12/Codex/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ref12/Codex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ref12/Codex/statuses/{sha}","languages_url":"https://api.github.com/repos/Ref12/Codex/languages","stargazers_url":"https://api.github.com/repos/Ref12/Codex/stargazers","contributors_url":"https://api.github.com/repos/Ref12/Codex/contributors","subscribers_url":"https://api.github.com/repos/Ref12/Codex/subscribers","subscription_url":"https://api.github.com/repos/Ref12/Codex/subscription","commits_url":"https://api.github.com/repos/Ref12/Codex/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ref12/Codex/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ref12/Codex/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ref12/Codex/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ref12/Codex/contents/{+path}","compare_url":"https://api.github.com/repos/Ref12/Codex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ref12/Codex/merges","archive_url":"https://api.github.com/repos/Ref12/Codex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ref12/Codex/downloads","issues_url":"https://api.github.com/repos/Ref12/Codex/issues{/number}","pulls_url":"https://api.github.com/repos/Ref12/Codex/pulls{/number}","milestones_url":"https://api.github.com/repos/Ref12/Codex/milestones{/number}","notifications_url":"https://api.github.com/repos/Ref12/Codex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ref12/Codex/labels{/name}","releases_url":"https://api.github.com/repos/Ref12/Codex/releases{/id}","deployments_url":"https://api.github.com/repos/Ref12/Codex/deployments","created_at":"2017-06-24T17:58:16Z","updated_at":"2018-04-18T17:25:53Z","pushed_at":"2018-04-18T17:25:50Z","git_url":"git://github.com/Ref12/Codex.git","ssh_url":"git@github.com:Ref12/Codex.git","clone_url":"https://github.com/Ref12/Codex.git","svn_url":"https://github.com/Ref12/Codex","homepage":null,"size":6084,"stargazers_count":5,"watchers_count":5,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":94,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":94,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Ref12/Codex/pulls/103"},"html":{"href":"https://github.com/Ref12/Codex/pull/103"},"issue":{"href":"https://api.github.com/repos/Ref12/Codex/issues/103"},"comments":{"href":"https://api.github.com/repos/Ref12/Codex/issues/103/comments"},"review_comments":{"href":"https://api.github.com/repos/Ref12/Codex/pulls/103/comments"},"review_comment":{"href":"https://api.github.com/repos/Ref12/Codex/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Ref12/Codex/pulls/103/commits"},"statuses":{"href":"https://api.github.com/repos/Ref12/Codex/statuses/4c45ab520b4cfc099c15408cc8407c0a9231181f"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":40,"deletions":1,"changed_files":4}}
{"actor":{"display_login":"DustinCampbell"}}