{"action":"closed","number":7773,"pull_request":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/7773","id":217616560,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NjE2NTYw","html_url":"https://github.com/pingcap/tidb/pull/7773","diff_url":"https://github.com/pingcap/tidb/pull/7773.diff","patch_url":"https://github.com/pingcap/tidb/pull/7773.patch","issue_url":"https://api.github.com/repos/pingcap/tidb/issues/7773","number":7773,"state":"closed","locked":false,"title":"add windows build support","user":{"login":"AndrewDi","id":7589147,"node_id":"MDQ6VXNlcjc1ODkxNDc=","avatar_url":"https://avatars1.githubusercontent.com/u/7589147?v=4","gravatar_id":"","url":"https://api.github.com/users/AndrewDi","html_url":"https://github.com/AndrewDi","followers_url":"https://api.github.com/users/AndrewDi/followers","following_url":"https://api.github.com/users/AndrewDi/following{/other_user}","gists_url":"https://api.github.com/users/AndrewDi/gists{/gist_id}","starred_url":"https://api.github.com/users/AndrewDi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndrewDi/subscriptions","organizations_url":"https://api.github.com/users/AndrewDi/orgs","repos_url":"https://api.github.com/users/AndrewDi/repos","events_url":"https://api.github.com/users/AndrewDi/events{/privacy}","received_events_url":"https://api.github.com/users/AndrewDi/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for contributing to TiDB! Please read TiDB's [CONTRIBUTING](https://github.com/pingcap/tidb/blob/master/CONTRIBUTING.md) document **BEFORE** filing this PR.\r\n-->\r\n\r\n### What problem does this PR solve? <!--add issue link with summary if exists-->\r\nWhen building tidb on windows, go build retrun with some linux signal errors:\r\n`# command-line-arguments\r\nsrc\\github.com\\pingcap\\tidb\\tidb-server\\main.go:441:34: undefined: syscall.SIGUSR1\r\nsrc\\github.com\\pingcap\\tidb\\tidb-server\\main.go:446:14: undefined: syscall.SIGUSR1 \r\n` \r\n\r\n### What is changed and how it works?\r\nadd windows build support!\r\nChange SIGUSR1 from go system control to user control by define custom signal:\r\n`sigUsr1  := syscall.Signal(0x1e)`\r\n\r\n### Check List <!--REMOVE the items that are not applicable-->\r\n\r\nTests <!-- At least one of them must be included. -->\r\n\r\n\r\n - Manual test (add detailed scripts or steps below)\r\n1. Running tidb-server with MockStore\r\n2. kill -30 $pid\r\n3. Custom signal still can handle dump goroutine stack request.\r\n\r\nCode changes\r\n\r\nSide effects\r\n\r\n\r\nRelated changes\r\n - Need to be included in the release note\r\nSupport windows build, but build on windows should only be use in developer environment.","created_at":"2018-09-24T10:49:02Z","updated_at":"2018-09-26T09:09:14Z","closed_at":"2018-09-26T09:09:14Z","merged_at":"2018-09-26T09:09:14Z","merge_commit_sha":"1f84db5cd7e390d99776a43e5db228022f871477","assignee":{"login":"lysu","id":528332,"node_id":"MDQ6VXNlcjUyODMzMg==","avatar_url":"https://avatars3.githubusercontent.com/u/528332?v=4","gravatar_id":"","url":"https://api.github.com/users/lysu","html_url":"https://github.com/lysu","followers_url":"https://api.github.com/users/lysu/followers","following_url":"https://api.github.com/users/lysu/following{/other_user}","gists_url":"https://api.github.com/users/lysu/gists{/gist_id}","starred_url":"https://api.github.com/users/lysu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lysu/subscriptions","organizations_url":"https://api.github.com/users/lysu/orgs","repos_url":"https://api.github.com/users/lysu/repos","events_url":"https://api.github.com/users/lysu/events{/privacy}","received_events_url":"https://api.github.com/users/lysu/received_events","type":"User","site_admin":false},"assignees":[{"login":"lysu","id":528332,"node_id":"MDQ6VXNlcjUyODMzMg==","avatar_url":"https://avatars3.githubusercontent.com/u/528332?v=4","gravatar_id":"","url":"https://api.github.com/users/lysu","html_url":"https://github.com/lysu","followers_url":"https://api.github.com/users/lysu/followers","following_url":"https://api.github.com/users/lysu/following{/other_user}","gists_url":"https://api.github.com/users/lysu/gists{/gist_id}","starred_url":"https://api.github.com/users/lysu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lysu/subscriptions","organizations_url":"https://api.github.com/users/lysu/orgs","repos_url":"https://api.github.com/users/lysu/repos","events_url":"https://api.github.com/users/lysu/events{/privacy}","received_events_url":"https://api.github.com/users/lysu/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":799107676,"node_id":"MDU6TGFiZWw3OTkxMDc2NzY=","url":"https://api.github.com/repos/pingcap/tidb/labels/component/tools","name":"component/tools","color":"cbf232","default":false},{"id":564578474,"node_id":"MDU6TGFiZWw1NjQ1Nzg0NzQ=","url":"https://api.github.com/repos/pingcap/tidb/labels/contribution","name":"contribution","color":"b0ff5b","default":false},{"id":564600738,"node_id":"MDU6TGFiZWw1NjQ2MDA3Mzg=","url":"https://api.github.com/repos/pingcap/tidb/labels/status/LGT2","name":"status/LGT2","color":"5319e7","default":false},{"id":256872088,"node_id":"MDU6TGFiZWwyNTY4NzIwODg=","url":"https://api.github.com/repos/pingcap/tidb/labels/type/enhancement","name":"type/enhancement","color":"84b6eb","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/tidb/pulls/7773/commits","review_comments_url":"https://api.github.com/repos/pingcap/tidb/pulls/7773/comments","review_comment_url":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/tidb/issues/7773/comments","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/e0cb28bc6084d4db69a8ee8727fdf99b119e7b4e","head":{"label":"AndrewDi:adaptive_to_windows","ref":"adaptive_to_windows","sha":"e0cb28bc6084d4db69a8ee8727fdf99b119e7b4e","user":{"login":"AndrewDi","id":7589147,"node_id":"MDQ6VXNlcjc1ODkxNDc=","avatar_url":"https://avatars1.githubusercontent.com/u/7589147?v=4","gravatar_id":"","url":"https://api.github.com/users/AndrewDi","html_url":"https://github.com/AndrewDi","followers_url":"https://api.github.com/users/AndrewDi/followers","following_url":"https://api.github.com/users/AndrewDi/following{/other_user}","gists_url":"https://api.github.com/users/AndrewDi/gists{/gist_id}","starred_url":"https://api.github.com/users/AndrewDi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndrewDi/subscriptions","organizations_url":"https://api.github.com/users/AndrewDi/orgs","repos_url":"https://api.github.com/users/AndrewDi/repos","events_url":"https://api.github.com/users/AndrewDi/events{/privacy}","received_events_url":"https://api.github.com/users/AndrewDi/received_events","type":"User","site_admin":false},"repo":{"id":107108540,"node_id":"MDEwOlJlcG9zaXRvcnkxMDcxMDg1NDA=","name":"tidb","full_name":"AndrewDi/tidb","private":false,"owner":{"login":"AndrewDi","id":7589147,"node_id":"MDQ6VXNlcjc1ODkxNDc=","avatar_url":"https://avatars1.githubusercontent.com/u/7589147?v=4","gravatar_id":"","url":"https://api.github.com/users/AndrewDi","html_url":"https://github.com/AndrewDi","followers_url":"https://api.github.com/users/AndrewDi/followers","following_url":"https://api.github.com/users/AndrewDi/following{/other_user}","gists_url":"https://api.github.com/users/AndrewDi/gists{/gist_id}","starred_url":"https://api.github.com/users/AndrewDi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndrewDi/subscriptions","organizations_url":"https://api.github.com/users/AndrewDi/orgs","repos_url":"https://api.github.com/users/AndrewDi/repos","events_url":"https://api.github.com/users/AndrewDi/events{/privacy}","received_events_url":"https://api.github.com/users/AndrewDi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/AndrewDi/tidb","description":"TiDB is a distributed NewSQL database compatible with MySQL protocol ","fork":true,"url":"https://api.github.com/repos/AndrewDi/tidb","forks_url":"https://api.github.com/repos/AndrewDi/tidb/forks","keys_url":"https://api.github.com/repos/AndrewDi/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AndrewDi/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AndrewDi/tidb/teams","hooks_url":"https://api.github.com/repos/AndrewDi/tidb/hooks","issue_events_url":"https://api.github.com/repos/AndrewDi/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/AndrewDi/tidb/events","assignees_url":"https://api.github.com/repos/AndrewDi/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/AndrewDi/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/AndrewDi/tidb/tags","blobs_url":"https://api.github.com/repos/AndrewDi/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AndrewDi/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AndrewDi/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/AndrewDi/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AndrewDi/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/AndrewDi/tidb/languages","stargazers_url":"https://api.github.com/repos/AndrewDi/tidb/stargazers","contributors_url":"https://api.github.com/repos/AndrewDi/tidb/contributors","subscribers_url":"https://api.github.com/repos/AndrewDi/tidb/subscribers","subscription_url":"https://api.github.com/repos/AndrewDi/tidb/subscription","commits_url":"https://api.github.com/repos/AndrewDi/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/AndrewDi/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/AndrewDi/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/AndrewDi/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/AndrewDi/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/AndrewDi/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AndrewDi/tidb/merges","archive_url":"https://api.github.com/repos/AndrewDi/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AndrewDi/tidb/downloads","issues_url":"https://api.github.com/repos/AndrewDi/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/AndrewDi/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/AndrewDi/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/AndrewDi/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AndrewDi/tidb/labels{/name}","releases_url":"https://api.github.com/repos/AndrewDi/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/AndrewDi/tidb/deployments","created_at":"2017-10-16T09:45:47Z","updated_at":"2018-09-25T23:55:52Z","pushed_at":"2018-09-26T08:41:15Z","git_url":"git://github.com/AndrewDi/tidb.git","ssh_url":"git@github.com:AndrewDi/tidb.git","clone_url":"https://github.com/AndrewDi/tidb.git","svn_url":"https://github.com/AndrewDi/tidb","homepage":"https://pingcap.com","size":57005,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"4b5d83bcc479e95f950940f64cf51a8663b31240","user":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":41986369,"node_id":"MDEwOlJlcG9zaXRvcnk0MTk4NjM2OQ==","name":"tidb","full_name":"pingcap/tidb","private":false,"owner":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pingcap/tidb","description":"TiDB is a distributed HTAP database compatible with the MySQL protocol ","fork":false,"url":"https://api.github.com/repos/pingcap/tidb","forks_url":"https://api.github.com/repos/pingcap/tidb/forks","keys_url":"https://api.github.com/repos/pingcap/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tidb/teams","hooks_url":"https://api.github.com/repos/pingcap/tidb/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tidb/events","assignees_url":"https://api.github.com/repos/pingcap/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tidb/tags","blobs_url":"https://api.github.com/repos/pingcap/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tidb/languages","stargazers_url":"https://api.github.com/repos/pingcap/tidb/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tidb/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tidb/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tidb/subscription","commits_url":"https://api.github.com/repos/pingcap/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tidb/merges","archive_url":"https://api.github.com/repos/pingcap/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tidb/downloads","issues_url":"https://api.github.com/repos/pingcap/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tidb/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tidb/deployments","created_at":"2015-09-06T04:01:52Z","updated_at":"2018-09-26T07:58:39Z","pushed_at":"2018-09-26T09:09:14Z","git_url":"git://github.com/pingcap/tidb.git","ssh_url":"git@github.com:pingcap/tidb.git","clone_url":"https://github.com/pingcap/tidb.git","svn_url":"https://github.com/pingcap/tidb","homepage":"https://pingcap.com","size":82871,"stargazers_count":15079,"watchers_count":15079,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2133,"mirror_url":null,"archived":false,"open_issues_count":560,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2133,"open_issues":560,"watchers":15079,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/7773"},"html":{"href":"https://github.com/pingcap/tidb/pull/7773"},"issue":{"href":"https://api.github.com/repos/pingcap/tidb/issues/7773"},"comments":{"href":"https://api.github.com/repos/pingcap/tidb/issues/7773/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/7773/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/7773/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/tidb/statuses/e0cb28bc6084d4db69a8ee8727fdf99b119e7b4e"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ngaut","id":878009,"node_id":"MDQ6VXNlcjg3ODAwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/878009?v=4","gravatar_id":"","url":"https://api.github.com/users/ngaut","html_url":"https://github.com/ngaut","followers_url":"https://api.github.com/users/ngaut/followers","following_url":"https://api.github.com/users/ngaut/following{/other_user}","gists_url":"https://api.github.com/users/ngaut/gists{/gist_id}","starred_url":"https://api.github.com/users/ngaut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngaut/subscriptions","organizations_url":"https://api.github.com/users/ngaut/orgs","repos_url":"https://api.github.com/users/ngaut/repos","events_url":"https://api.github.com/users/ngaut/events{/privacy}","received_events_url":"https://api.github.com/users/ngaut/received_events","type":"User","site_admin":false},"comments":9,"review_comments":8,"maintainer_can_modify":false,"commits":2,"additions":105,"deletions":35,"changed_files":3}}
{"actor":{"display_login":"ngaut"}}