{"action":"created","comment":{"url":"https://api.github.com/repos/hypothesis/h/pulls/comments/215550103","pull_request_review_id":152836728,"id":215550103,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTU1MDEwMw==","diff_hunk":"@@ -409,3 +421,27 @@ class SearchParamsSchema(colander.Schema):\n         missing=colander.drop,\n         description=\"Limit the results to annotations made by the specified user.\",\n     )\n+\n+    def validator(self, node, cstruct):\n+        sort = cstruct['sort']\n+        search_after = cstruct.get('search_after', None)\n+\n+        if search_after:\n+            if sort in [\"updated\", \"created\"]:\n+                self._parsable_date(node, search_after)\n+\n+            # offset must be set to 0 if search_after is specified.\n+            cstruct[\"offset\"] = 0\n+\n+    def _parsable_date(self, node, value):","path":"h/schemas/annotation.py","position":51,"original_position":51,"commit_id":"1ff3965dca1a3645a9de867146e0889ade0d0054","original_commit_id":"1ff3965dca1a3645a9de867146e0889ade0d0054","user":{"login":"robertknight","id":2458,"node_id":"MDQ6VXNlcjI0NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/2458?v=4","gravatar_id":"","url":"https://api.github.com/users/robertknight","html_url":"https://github.com/robertknight","followers_url":"https://api.github.com/users/robertknight/followers","following_url":"https://api.github.com/users/robertknight/following{/other_user}","gists_url":"https://api.github.com/users/robertknight/gists{/gist_id}","starred_url":"https://api.github.com/users/robertknight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertknight/subscriptions","organizations_url":"https://api.github.com/users/robertknight/orgs","repos_url":"https://api.github.com/users/robertknight/repos","events_url":"https://api.github.com/users/robertknight/events{/privacy}","received_events_url":"https://api.github.com/users/robertknight/received_events","type":"User","site_admin":false},"body":"This function name gives the impression it returns a value. Perhaps `_try_parsing_date`?","created_at":"2018-09-06T09:08:02Z","updated_at":"2018-09-06T09:49:23Z","html_url":"https://github.com/hypothesis/h/pull/5235#discussion_r215550103","pull_request_url":"https://api.github.com/repos/hypothesis/h/pulls/5235","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hypothesis/h/pulls/comments/215550103"},"html":{"href":"https://github.com/hypothesis/h/pull/5235#discussion_r215550103"},"pull_request":{"href":"https://api.github.com/repos/hypothesis/h/pulls/5235"}}},"pull_request":{"url":"https://api.github.com/repos/hypothesis/h/pulls/5235","id":210611410,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNjExNDEw","html_url":"https://github.com/hypothesis/h/pull/5235","diff_url":"https://github.com/hypothesis/h/pull/5235.diff","patch_url":"https://github.com/hypothesis/h/pull/5235.patch","issue_url":"https://api.github.com/repos/hypothesis/h/issues/5235","number":5235,"state":"open","locked":false,"title":"Fix sliding window","user":{"login":"hmstepanek","id":30059933,"node_id":"MDQ6VXNlcjMwMDU5OTMz","avatar_url":"https://avatars1.githubusercontent.com/u/30059933?v=4","gravatar_id":"","url":"https://api.github.com/users/hmstepanek","html_url":"https://github.com/hmstepanek","followers_url":"https://api.github.com/users/hmstepanek/followers","following_url":"https://api.github.com/users/hmstepanek/following{/other_user}","gists_url":"https://api.github.com/users/hmstepanek/gists{/gist_id}","starred_url":"https://api.github.com/users/hmstepanek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmstepanek/subscriptions","organizations_url":"https://api.github.com/users/hmstepanek/orgs","repos_url":"https://api.github.com/users/hmstepanek/repos","events_url":"https://api.github.com/users/hmstepanek/events{/privacy}","received_events_url":"https://api.github.com/users/hmstepanek/received_events","type":"User","site_admin":false},"body":"Use search_after instead of search from to page through large sets of annotations.\r\nThis is a fix for https://github.com/orgs/hypothesis/projects/23.","created_at":"2018-08-24T00:39:56Z","updated_at":"2018-09-06T09:49:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"13065e167a42e0b1ddc9e0c0da386bd3e66ee71a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":967821595,"node_id":"MDU6TGFiZWw5Njc4MjE1OTU=","url":"https://api.github.com/repos/hypothesis/h/labels/Upgrade%20Elasticsearch","name":"Upgrade Elasticsearch","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/hypothesis/h/pulls/5235/commits","review_comments_url":"https://api.github.com/repos/hypothesis/h/pulls/5235/comments","review_comment_url":"https://api.github.com/repos/hypothesis/h/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hypothesis/h/issues/5235/comments","statuses_url":"https://api.github.com/repos/hypothesis/h/statuses/1ff3965dca1a3645a9de867146e0889ade0d0054","head":{"label":"hypothesis:fix-sliding-window","ref":"fix-sliding-window","sha":"1ff3965dca1a3645a9de867146e0889ade0d0054","user":{"login":"hypothesis","id":1243215,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDMyMTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1243215?v=4","gravatar_id":"","url":"https://api.github.com/users/hypothesis","html_url":"https://github.com/hypothesis","followers_url":"https://api.github.com/users/hypothesis/followers","following_url":"https://api.github.com/users/hypothesis/following{/other_user}","gists_url":"https://api.github.com/users/hypothesis/gists{/gist_id}","starred_url":"https://api.github.com/users/hypothesis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hypothesis/subscriptions","organizations_url":"https://api.github.com/users/hypothesis/orgs","repos_url":"https://api.github.com/users/hypothesis/repos","events_url":"https://api.github.com/users/hypothesis/events{/privacy}","received_events_url":"https://api.github.com/users/hypothesis/received_events","type":"Organization","site_admin":false},"repo":{"id":3910945,"node_id":"MDEwOlJlcG9zaXRvcnkzOTEwOTQ1","name":"h","full_name":"hypothesis/h","owner":{"login":"hypothesis","id":1243215,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDMyMTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1243215?v=4","gravatar_id":"","url":"https://api.github.com/users/hypothesis","html_url":"https://github.com/hypothesis","followers_url":"https://api.github.com/users/hypothesis/followers","following_url":"https://api.github.com/users/hypothesis/following{/other_user}","gists_url":"https://api.github.com/users/hypothesis/gists{/gist_id}","starred_url":"https://api.github.com/users/hypothesis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hypothesis/subscriptions","organizations_url":"https://api.github.com/users/hypothesis/orgs","repos_url":"https://api.github.com/users/hypothesis/repos","events_url":"https://api.github.com/users/hypothesis/events{/privacy}","received_events_url":"https://api.github.com/users/hypothesis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hypothesis/h","description":"Annotate with anyone, anywhere.","fork":false,"url":"https://api.github.com/repos/hypothesis/h","forks_url":"https://api.github.com/repos/hypothesis/h/forks","keys_url":"https://api.github.com/repos/hypothesis/h/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hypothesis/h/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hypothesis/h/teams","hooks_url":"https://api.github.com/repos/hypothesis/h/hooks","issue_events_url":"https://api.github.com/repos/hypothesis/h/issues/events{/number}","events_url":"https://api.github.com/repos/hypothesis/h/events","assignees_url":"https://api.github.com/repos/hypothesis/h/assignees{/user}","branches_url":"https://api.github.com/repos/hypothesis/h/branches{/branch}","tags_url":"https://api.github.com/repos/hypothesis/h/tags","blobs_url":"https://api.github.com/repos/hypothesis/h/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hypothesis/h/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hypothesis/h/git/refs{/sha}","trees_url":"https://api.github.com/repos/hypothesis/h/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hypothesis/h/statuses/{sha}","languages_url":"https://api.github.com/repos/hypothesis/h/languages","stargazers_url":"https://api.github.com/repos/hypothesis/h/stargazers","contributors_url":"https://api.github.com/repos/hypothesis/h/contributors","subscribers_url":"https://api.github.com/repos/hypothesis/h/subscribers","subscription_url":"https://api.github.com/repos/hypothesis/h/subscription","commits_url":"https://api.github.com/repos/hypothesis/h/commits{/sha}","git_commits_url":"https://api.github.com/repos/hypothesis/h/git/commits{/sha}","comments_url":"https://api.github.com/repos/hypothesis/h/comments{/number}","issue_comment_url":"https://api.github.com/repos/hypothesis/h/issues/comments{/number}","contents_url":"https://api.github.com/repos/hypothesis/h/contents/{+path}","compare_url":"https://api.github.com/repos/hypothesis/h/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hypothesis/h/merges","archive_url":"https://api.github.com/repos/hypothesis/h/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hypothesis/h/downloads","issues_url":"https://api.github.com/repos/hypothesis/h/issues{/number}","pulls_url":"https://api.github.com/repos/hypothesis/h/pulls{/number}","milestones_url":"https://api.github.com/repos/hypothesis/h/milestones{/number}","notifications_url":"https://api.github.com/repos/hypothesis/h/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hypothesis/h/labels{/name}","releases_url":"https://api.github.com/repos/hypothesis/h/releases{/id}","deployments_url":"https://api.github.com/repos/hypothesis/h/deployments","created_at":"2012-04-02T19:56:59Z","updated_at":"2018-09-06T08:52:34Z","pushed_at":"2018-09-06T02:05:01Z","git_url":"git://github.com/hypothesis/h.git","ssh_url":"git@github.com:hypothesis/h.git","clone_url":"https://github.com/hypothesis/h.git","svn_url":"https://github.com/hypothesis/h","homepage":"https://hypothes.is/","size":30363,"stargazers_count":1220,"watchers_count":1220,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":273,"mirror_url":null,"archived":false,"open_issues_count":92,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":273,"open_issues":92,"watchers":1220,"default_branch":"master"}},"base":{"label":"hypothesis:master","ref":"master","sha":"ad6d028b92cc298c687884fbac2fb4cdc74f37e7","user":{"login":"hypothesis","id":1243215,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDMyMTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1243215?v=4","gravatar_id":"","url":"https://api.github.com/users/hypothesis","html_url":"https://github.com/hypothesis","followers_url":"https://api.github.com/users/hypothesis/followers","following_url":"https://api.github.com/users/hypothesis/following{/other_user}","gists_url":"https://api.github.com/users/hypothesis/gists{/gist_id}","starred_url":"https://api.github.com/users/hypothesis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hypothesis/subscriptions","organizations_url":"https://api.github.com/users/hypothesis/orgs","repos_url":"https://api.github.com/users/hypothesis/repos","events_url":"https://api.github.com/users/hypothesis/events{/privacy}","received_events_url":"https://api.github.com/users/hypothesis/received_events","type":"Organization","site_admin":false},"repo":{"id":3910945,"node_id":"MDEwOlJlcG9zaXRvcnkzOTEwOTQ1","name":"h","full_name":"hypothesis/h","owner":{"login":"hypothesis","id":1243215,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDMyMTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1243215?v=4","gravatar_id":"","url":"https://api.github.com/users/hypothesis","html_url":"https://github.com/hypothesis","followers_url":"https://api.github.com/users/hypothesis/followers","following_url":"https://api.github.com/users/hypothesis/following{/other_user}","gists_url":"https://api.github.com/users/hypothesis/gists{/gist_id}","starred_url":"https://api.github.com/users/hypothesis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hypothesis/subscriptions","organizations_url":"https://api.github.com/users/hypothesis/orgs","repos_url":"https://api.github.com/users/hypothesis/repos","events_url":"https://api.github.com/users/hypothesis/events{/privacy}","received_events_url":"https://api.github.com/users/hypothesis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hypothesis/h","description":"Annotate with anyone, anywhere.","fork":false,"url":"https://api.github.com/repos/hypothesis/h","forks_url":"https://api.github.com/repos/hypothesis/h/forks","keys_url":"https://api.github.com/repos/hypothesis/h/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hypothesis/h/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hypothesis/h/teams","hooks_url":"https://api.github.com/repos/hypothesis/h/hooks","issue_events_url":"https://api.github.com/repos/hypothesis/h/issues/events{/number}","events_url":"https://api.github.com/repos/hypothesis/h/events","assignees_url":"https://api.github.com/repos/hypothesis/h/assignees{/user}","branches_url":"https://api.github.com/repos/hypothesis/h/branches{/branch}","tags_url":"https://api.github.com/repos/hypothesis/h/tags","blobs_url":"https://api.github.com/repos/hypothesis/h/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hypothesis/h/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hypothesis/h/git/refs{/sha}","trees_url":"https://api.github.com/repos/hypothesis/h/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hypothesis/h/statuses/{sha}","languages_url":"https://api.github.com/repos/hypothesis/h/languages","stargazers_url":"https://api.github.com/repos/hypothesis/h/stargazers","contributors_url":"https://api.github.com/repos/hypothesis/h/contributors","subscribers_url":"https://api.github.com/repos/hypothesis/h/subscribers","subscription_url":"https://api.github.com/repos/hypothesis/h/subscription","commits_url":"https://api.github.com/repos/hypothesis/h/commits{/sha}","git_commits_url":"https://api.github.com/repos/hypothesis/h/git/commits{/sha}","comments_url":"https://api.github.com/repos/hypothesis/h/comments{/number}","issue_comment_url":"https://api.github.com/repos/hypothesis/h/issues/comments{/number}","contents_url":"https://api.github.com/repos/hypothesis/h/contents/{+path}","compare_url":"https://api.github.com/repos/hypothesis/h/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hypothesis/h/merges","archive_url":"https://api.github.com/repos/hypothesis/h/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hypothesis/h/downloads","issues_url":"https://api.github.com/repos/hypothesis/h/issues{/number}","pulls_url":"https://api.github.com/repos/hypothesis/h/pulls{/number}","milestones_url":"https://api.github.com/repos/hypothesis/h/milestones{/number}","notifications_url":"https://api.github.com/repos/hypothesis/h/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hypothesis/h/labels{/name}","releases_url":"https://api.github.com/repos/hypothesis/h/releases{/id}","deployments_url":"https://api.github.com/repos/hypothesis/h/deployments","created_at":"2012-04-02T19:56:59Z","updated_at":"2018-09-06T08:52:34Z","pushed_at":"2018-09-06T02:05:01Z","git_url":"git://github.com/hypothesis/h.git","ssh_url":"git@github.com:hypothesis/h.git","clone_url":"https://github.com/hypothesis/h.git","svn_url":"https://github.com/hypothesis/h","homepage":"https://hypothes.is/","size":30363,"stargazers_count":1220,"watchers_count":1220,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":273,"mirror_url":null,"archived":false,"open_issues_count":92,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":273,"open_issues":92,"watchers":1220,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hypothesis/h/pulls/5235"},"html":{"href":"https://github.com/hypothesis/h/pull/5235"},"issue":{"href":"https://api.github.com/repos/hypothesis/h/issues/5235"},"comments":{"href":"https://api.github.com/repos/hypothesis/h/issues/5235/comments"},"review_comments":{"href":"https://api.github.com/repos/hypothesis/h/pulls/5235/comments"},"review_comment":{"href":"https://api.github.com/repos/hypothesis/h/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hypothesis/h/pulls/5235/commits"},"statuses":{"href":"https://api.github.com/repos/hypothesis/h/statuses/1ff3965dca1a3645a9de867146e0889ade0d0054"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"robertknight"}}