{"action":"opened","number":3181,"pull_request":{"url":"https://api.github.com/repos/acquia/blt/pulls/3181","id":223982168,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzOTgyMTY4","html_url":"https://github.com/acquia/blt/pull/3181","diff_url":"https://github.com/acquia/blt/pull/3181.diff","patch_url":"https://github.com/acquia/blt/pull/3181.patch","issue_url":"https://api.github.com/repos/acquia/blt/issues/3181","number":3181,"state":"open","locked":false,"title":"Account for named arguments in Twig filter and function linting.","user":{"login":"wu-edward","id":25017813,"node_id":"MDQ6VXNlcjI1MDE3ODEz","avatar_url":"https://avatars1.githubusercontent.com/u/25017813?v=4","gravatar_id":"","url":"https://api.github.com/users/wu-edward","html_url":"https://github.com/wu-edward","followers_url":"https://api.github.com/users/wu-edward/followers","following_url":"https://api.github.com/users/wu-edward/following{/other_user}","gists_url":"https://api.github.com/users/wu-edward/gists{/gist_id}","starred_url":"https://api.github.com/users/wu-edward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wu-edward/subscriptions","organizations_url":"https://api.github.com/users/wu-edward/orgs","repos_url":"https://api.github.com/users/wu-edward/repos","events_url":"https://api.github.com/users/wu-edward/events{/privacy}","received_events_url":"https://api.github.com/users/wu-edward/received_events","type":"User","site_admin":false},"body":"Fixes #3178 \r\n--------\r\n\r\nChanges proposed:\r\n---------\r\n(What are you proposing we change?)\r\n\r\n- Set Twig filters and functions added to the Twig environment BLT uses for linting to be variadic to account for named arguments.\r\n\r\nSteps to replicate the issue:\r\n----------\r\n(If this PR is not fixing a defect/bug, you can remove this section.)\r\n\r\n1. Create a Twig template in a custom theme template directory that includes:\r\n`{{ drupal_entity('block', 'particle_employersmenu', check_access=false) }}`\r\n2. Whitelist the `drupal_entity` function in blt/blt.yml per https://blt.readthedocs.io/en/latest/extending-blt/#teststwiglintall\r\n3. Run `tests:twig:lint:all` and observe error message\r\n\r\nSteps to verify the solution:\r\n-----------\r\n(How does someone verify that this does what you think does?)\r\n\r\n1. Apply this commit to BLT\r\n2. Run issue replication steps, and confirm that linting now shows no errors.\r\n\r\n \r\n","created_at":"2018-10-18T14:37:18Z","updated_at":"2018-10-18T14:37:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/acquia/blt/pulls/3181/commits","review_comments_url":"https://api.github.com/repos/acquia/blt/pulls/3181/comments","review_comment_url":"https://api.github.com/repos/acquia/blt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/acquia/blt/issues/3181/comments","statuses_url":"https://api.github.com/repos/acquia/blt/statuses/5a7303d3b8982a83d44d4ba979dd306aa9ca0e4a","head":{"label":"wu-edward:twig-function-arguments","ref":"twig-function-arguments","sha":"5a7303d3b8982a83d44d4ba979dd306aa9ca0e4a","user":{"login":"wu-edward","id":25017813,"node_id":"MDQ6VXNlcjI1MDE3ODEz","avatar_url":"https://avatars1.githubusercontent.com/u/25017813?v=4","gravatar_id":"","url":"https://api.github.com/users/wu-edward","html_url":"https://github.com/wu-edward","followers_url":"https://api.github.com/users/wu-edward/followers","following_url":"https://api.github.com/users/wu-edward/following{/other_user}","gists_url":"https://api.github.com/users/wu-edward/gists{/gist_id}","starred_url":"https://api.github.com/users/wu-edward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wu-edward/subscriptions","organizations_url":"https://api.github.com/users/wu-edward/orgs","repos_url":"https://api.github.com/users/wu-edward/repos","events_url":"https://api.github.com/users/wu-edward/events{/privacy}","received_events_url":"https://api.github.com/users/wu-edward/received_events","type":"User","site_admin":false},"repo":{"id":88886251,"node_id":"MDEwOlJlcG9zaXRvcnk4ODg4NjI1MQ==","name":"blt","full_name":"wu-edward/blt","private":false,"owner":{"login":"wu-edward","id":25017813,"node_id":"MDQ6VXNlcjI1MDE3ODEz","avatar_url":"https://avatars1.githubusercontent.com/u/25017813?v=4","gravatar_id":"","url":"https://api.github.com/users/wu-edward","html_url":"https://github.com/wu-edward","followers_url":"https://api.github.com/users/wu-edward/followers","following_url":"https://api.github.com/users/wu-edward/following{/other_user}","gists_url":"https://api.github.com/users/wu-edward/gists{/gist_id}","starred_url":"https://api.github.com/users/wu-edward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wu-edward/subscriptions","organizations_url":"https://api.github.com/users/wu-edward/orgs","repos_url":"https://api.github.com/users/wu-edward/repos","events_url":"https://api.github.com/users/wu-edward/events{/privacy}","received_events_url":"https://api.github.com/users/wu-edward/received_events","type":"User","site_admin":false},"html_url":"https://github.com/wu-edward/blt","description":"Acquia's Build & Launch tools for Drupal 8.","fork":true,"url":"https://api.github.com/repos/wu-edward/blt","forks_url":"https://api.github.com/repos/wu-edward/blt/forks","keys_url":"https://api.github.com/repos/wu-edward/blt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wu-edward/blt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wu-edward/blt/teams","hooks_url":"https://api.github.com/repos/wu-edward/blt/hooks","issue_events_url":"https://api.github.com/repos/wu-edward/blt/issues/events{/number}","events_url":"https://api.github.com/repos/wu-edward/blt/events","assignees_url":"https://api.github.com/repos/wu-edward/blt/assignees{/user}","branches_url":"https://api.github.com/repos/wu-edward/blt/branches{/branch}","tags_url":"https://api.github.com/repos/wu-edward/blt/tags","blobs_url":"https://api.github.com/repos/wu-edward/blt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wu-edward/blt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wu-edward/blt/git/refs{/sha}","trees_url":"https://api.github.com/repos/wu-edward/blt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wu-edward/blt/statuses/{sha}","languages_url":"https://api.github.com/repos/wu-edward/blt/languages","stargazers_url":"https://api.github.com/repos/wu-edward/blt/stargazers","contributors_url":"https://api.github.com/repos/wu-edward/blt/contributors","subscribers_url":"https://api.github.com/repos/wu-edward/blt/subscribers","subscription_url":"https://api.github.com/repos/wu-edward/blt/subscription","commits_url":"https://api.github.com/repos/wu-edward/blt/commits{/sha}","git_commits_url":"https://api.github.com/repos/wu-edward/blt/git/commits{/sha}","comments_url":"https://api.github.com/repos/wu-edward/blt/comments{/number}","issue_comment_url":"https://api.github.com/repos/wu-edward/blt/issues/comments{/number}","contents_url":"https://api.github.com/repos/wu-edward/blt/contents/{+path}","compare_url":"https://api.github.com/repos/wu-edward/blt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wu-edward/blt/merges","archive_url":"https://api.github.com/repos/wu-edward/blt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wu-edward/blt/downloads","issues_url":"https://api.github.com/repos/wu-edward/blt/issues{/number}","pulls_url":"https://api.github.com/repos/wu-edward/blt/pulls{/number}","milestones_url":"https://api.github.com/repos/wu-edward/blt/milestones{/number}","notifications_url":"https://api.github.com/repos/wu-edward/blt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wu-edward/blt/labels{/name}","releases_url":"https://api.github.com/repos/wu-edward/blt/releases{/id}","deployments_url":"https://api.github.com/repos/wu-edward/blt/deployments","created_at":"2017-04-20T16:17:25Z","updated_at":"2017-04-20T16:17:27Z","pushed_at":"2018-10-18T14:27:16Z","git_url":"git://github.com/wu-edward/blt.git","ssh_url":"git@github.com:wu-edward/blt.git","clone_url":"https://github.com/wu-edward/blt.git","svn_url":"https://github.com/wu-edward/blt","homepage":"","size":3810,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"8.x"}},"base":{"label":"acquia:9.2.x","ref":"9.2.x","sha":"1d2f22be4458b61b471ef97c463373040ef042cf","user":{"login":"acquia","id":514789,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxNDc4OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/514789?v=4","gravatar_id":"","url":"https://api.github.com/users/acquia","html_url":"https://github.com/acquia","followers_url":"https://api.github.com/users/acquia/followers","following_url":"https://api.github.com/users/acquia/following{/other_user}","gists_url":"https://api.github.com/users/acquia/gists{/gist_id}","starred_url":"https://api.github.com/users/acquia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acquia/subscriptions","organizations_url":"https://api.github.com/users/acquia/orgs","repos_url":"https://api.github.com/users/acquia/repos","events_url":"https://api.github.com/users/acquia/events{/privacy}","received_events_url":"https://api.github.com/users/acquia/received_events","type":"Organization","site_admin":false},"repo":{"id":57239027,"node_id":"MDEwOlJlcG9zaXRvcnk1NzIzOTAyNw==","name":"blt","full_name":"acquia/blt","private":false,"owner":{"login":"acquia","id":514789,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxNDc4OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/514789?v=4","gravatar_id":"","url":"https://api.github.com/users/acquia","html_url":"https://github.com/acquia","followers_url":"https://api.github.com/users/acquia/followers","following_url":"https://api.github.com/users/acquia/following{/other_user}","gists_url":"https://api.github.com/users/acquia/gists{/gist_id}","starred_url":"https://api.github.com/users/acquia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acquia/subscriptions","organizations_url":"https://api.github.com/users/acquia/orgs","repos_url":"https://api.github.com/users/acquia/repos","events_url":"https://api.github.com/users/acquia/events{/privacy}","received_events_url":"https://api.github.com/users/acquia/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/acquia/blt","description":"Acquia's toolset for automating Drupal 8 development, testing, and deployment.","fork":false,"url":"https://api.github.com/repos/acquia/blt","forks_url":"https://api.github.com/repos/acquia/blt/forks","keys_url":"https://api.github.com/repos/acquia/blt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acquia/blt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acquia/blt/teams","hooks_url":"https://api.github.com/repos/acquia/blt/hooks","issue_events_url":"https://api.github.com/repos/acquia/blt/issues/events{/number}","events_url":"https://api.github.com/repos/acquia/blt/events","assignees_url":"https://api.github.com/repos/acquia/blt/assignees{/user}","branches_url":"https://api.github.com/repos/acquia/blt/branches{/branch}","tags_url":"https://api.github.com/repos/acquia/blt/tags","blobs_url":"https://api.github.com/repos/acquia/blt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acquia/blt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acquia/blt/git/refs{/sha}","trees_url":"https://api.github.com/repos/acquia/blt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acquia/blt/statuses/{sha}","languages_url":"https://api.github.com/repos/acquia/blt/languages","stargazers_url":"https://api.github.com/repos/acquia/blt/stargazers","contributors_url":"https://api.github.com/repos/acquia/blt/contributors","subscribers_url":"https://api.github.com/repos/acquia/blt/subscribers","subscription_url":"https://api.github.com/repos/acquia/blt/subscription","commits_url":"https://api.github.com/repos/acquia/blt/commits{/sha}","git_commits_url":"https://api.github.com/repos/acquia/blt/git/commits{/sha}","comments_url":"https://api.github.com/repos/acquia/blt/comments{/number}","issue_comment_url":"https://api.github.com/repos/acquia/blt/issues/comments{/number}","contents_url":"https://api.github.com/repos/acquia/blt/contents/{+path}","compare_url":"https://api.github.com/repos/acquia/blt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acquia/blt/merges","archive_url":"https://api.github.com/repos/acquia/blt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acquia/blt/downloads","issues_url":"https://api.github.com/repos/acquia/blt/issues{/number}","pulls_url":"https://api.github.com/repos/acquia/blt/pulls{/number}","milestones_url":"https://api.github.com/repos/acquia/blt/milestones{/number}","notifications_url":"https://api.github.com/repos/acquia/blt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acquia/blt/labels{/name}","releases_url":"https://api.github.com/repos/acquia/blt/releases{/id}","deployments_url":"https://api.github.com/repos/acquia/blt/deployments","created_at":"2016-04-27T19:04:48Z","updated_at":"2018-10-17T20:06:45Z","pushed_at":"2018-10-17T22:12:12Z","git_url":"git://github.com/acquia/blt.git","ssh_url":"git@github.com:acquia/blt.git","clone_url":"https://github.com/acquia/blt.git","svn_url":"https://github.com/acquia/blt","homepage":"https://acquia-pso.github.io/blt-blog/","size":4175,"stargazers_count":319,"watchers_count":319,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":269,"mirror_url":null,"archived":false,"open_issues_count":127,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":269,"open_issues":127,"watchers":319,"default_branch":"10.0.x"}},"_links":{"self":{"href":"https://api.github.com/repos/acquia/blt/pulls/3181"},"html":{"href":"https://github.com/acquia/blt/pull/3181"},"issue":{"href":"https://api.github.com/repos/acquia/blt/issues/3181"},"comments":{"href":"https://api.github.com/repos/acquia/blt/issues/3181/comments"},"review_comments":{"href":"https://api.github.com/repos/acquia/blt/pulls/3181/comments"},"review_comment":{"href":"https://api.github.com/repos/acquia/blt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/acquia/blt/pulls/3181/commits"},"statuses":{"href":"https://api.github.com/repos/acquia/blt/statuses/5a7303d3b8982a83d44d4ba979dd306aa9ca0e4a"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":14,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"wu-edward"}}