{"action":"created","comment":{"url":"https://api.github.com/repos/nim-lang/Nim/pulls/comments/184674664","pull_request_review_id":115921283,"id":184674664,"diff_hunk":"@@ -229,31 +232,29 @@ proc normalize[T: Duration|Time](seconds, nanoseconds: int64): T =\n     result.seconds -= 1\n   result.nanosecond = nanosecond.int\n \n-proc initTime*(unix: int64, nanosecond: NanosecondRange): Time =\n-  ## Create a ``Time`` from a unix timestamp and a nanosecond part.\n-  result.seconds = unix\n-  result.nanosecond = nanosecond\n+# Forward declarations\n+proc utcZoneInfoFromUtc(time: Time): ZonedTime {.tags: [], raises: [], benign .}\n+  ## Forward declaration\n+proc utcZoneInfoFromTz(adjTime: Time): ZonedTime {.tags: [], raises: [], benign .}\n+  ## Forward declaration\n+proc localZoneInfoFromUtc(time: Time): ZonedTime {.tags: [], raises: [], benign .}\n+  ## Forward declaration\n+proc localZoneInfoFromTz(adjTime: Time): ZonedTime {.tags: [], raises: [], benign .}\n+  ## Forward declaration\n+proc initTime*(unix: int64, nanosecond: NanosecondRange): Time \n+  {.tags: [], raises: [], benign noSideEffect.}\n+  ## Forward declaration\n+\n+proc initDuration*(nanoseconds, microseconds, milliseconds,\n+                   seconds, minutes, hours, days, weeks: int64 = 0): Duration ","path":"lib/pure/times.nim","position":32,"original_position":32,"commit_id":"fa9b7d1efed9985e902ecbf2b64ecaeade574dc5","original_commit_id":"fa9b7d1efed9985e902ecbf2b64ecaeade574dc5","user":{"login":"GULPF","id":1022431,"avatar_url":"https://avatars1.githubusercontent.com/u/1022431?v=4","gravatar_id":"","url":"https://api.github.com/users/GULPF","html_url":"https://github.com/GULPF","followers_url":"https://api.github.com/users/GULPF/followers","following_url":"https://api.github.com/users/GULPF/following{/other_user}","gists_url":"https://api.github.com/users/GULPF/gists{/gist_id}","starred_url":"https://api.github.com/users/GULPF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GULPF/subscriptions","organizations_url":"https://api.github.com/users/GULPF/orgs","repos_url":"https://api.github.com/users/GULPF/repos","events_url":"https://api.github.com/users/GULPF/events{/privacy}","received_events_url":"https://api.github.com/users/GULPF/received_events","type":"User","site_admin":false},"body":"The order is because of compatibility with `initTimeInterval`.  The proc was not added in this PR, only moved around.","created_at":"2018-04-27T12:38:27Z","updated_at":"2018-04-27T12:38:27Z","html_url":"https://github.com/nim-lang/Nim/pull/7664#discussion_r184674664","pull_request_url":"https://api.github.com/repos/nim-lang/Nim/pulls/7664","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/nim-lang/Nim/pulls/comments/184674664"},"html":{"href":"https://github.com/nim-lang/Nim/pull/7664#discussion_r184674664"},"pull_request":{"href":"https://api.github.com/repos/nim-lang/Nim/pulls/7664"}},"in_reply_to_id":184674493},"pull_request":{"url":"https://api.github.com/repos/nim-lang/Nim/pulls/7664","id":183085748,"html_url":"https://github.com/nim-lang/Nim/pull/7664","diff_url":"https://github.com/nim-lang/Nim/pull/7664.diff","patch_url":"https://github.com/nim-lang/Nim/pull/7664.patch","issue_url":"https://api.github.com/repos/nim-lang/Nim/issues/7664","number":7664,"state":"open","locked":false,"title":"WIP: Feature/times fixup","user":{"login":"survivorm","id":2362776,"avatar_url":"https://avatars0.githubusercontent.com/u/2362776?v=4","gravatar_id":"","url":"https://api.github.com/users/survivorm","html_url":"https://github.com/survivorm","followers_url":"https://api.github.com/users/survivorm/followers","following_url":"https://api.github.com/users/survivorm/following{/other_user}","gists_url":"https://api.github.com/users/survivorm/gists{/gist_id}","starred_url":"https://api.github.com/users/survivorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/survivorm/subscriptions","organizations_url":"https://api.github.com/users/survivorm/orgs","repos_url":"https://api.github.com/users/survivorm/repos","events_url":"https://api.github.com/users/survivorm/events{/privacy}","received_events_url":"https://api.github.com/users/survivorm/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-04-20T14:50:25Z","updated_at":"2018-04-27T12:38:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b4b5d7a02bba3f333c3771057a7b2c40de3538a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nim-lang/Nim/pulls/7664/commits","review_comments_url":"https://api.github.com/repos/nim-lang/Nim/pulls/7664/comments","review_comment_url":"https://api.github.com/repos/nim-lang/Nim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nim-lang/Nim/issues/7664/comments","statuses_url":"https://api.github.com/repos/nim-lang/Nim/statuses/fa9b7d1efed9985e902ecbf2b64ecaeade574dc5","head":{"label":"survivorm:feature/times_fixup","ref":"feature/times_fixup","sha":"fa9b7d1efed9985e902ecbf2b64ecaeade574dc5","user":{"login":"survivorm","id":2362776,"avatar_url":"https://avatars0.githubusercontent.com/u/2362776?v=4","gravatar_id":"","url":"https://api.github.com/users/survivorm","html_url":"https://github.com/survivorm","followers_url":"https://api.github.com/users/survivorm/followers","following_url":"https://api.github.com/users/survivorm/following{/other_user}","gists_url":"https://api.github.com/users/survivorm/gists{/gist_id}","starred_url":"https://api.github.com/users/survivorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/survivorm/subscriptions","organizations_url":"https://api.github.com/users/survivorm/orgs","repos_url":"https://api.github.com/users/survivorm/repos","events_url":"https://api.github.com/users/survivorm/events{/privacy}","received_events_url":"https://api.github.com/users/survivorm/received_events","type":"User","site_admin":false},"repo":{"id":129701957,"name":"Nim","full_name":"survivorm/Nim","owner":{"login":"survivorm","id":2362776,"avatar_url":"https://avatars0.githubusercontent.com/u/2362776?v=4","gravatar_id":"","url":"https://api.github.com/users/survivorm","html_url":"https://github.com/survivorm","followers_url":"https://api.github.com/users/survivorm/followers","following_url":"https://api.github.com/users/survivorm/following{/other_user}","gists_url":"https://api.github.com/users/survivorm/gists{/gist_id}","starred_url":"https://api.github.com/users/survivorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/survivorm/subscriptions","organizations_url":"https://api.github.com/users/survivorm/orgs","repos_url":"https://api.github.com/users/survivorm/repos","events_url":"https://api.github.com/users/survivorm/events{/privacy}","received_events_url":"https://api.github.com/users/survivorm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/survivorm/Nim","description":"Nim is a compiled, garbage-collected systems programming language with a design that focuses on efficiency, expressiveness, and elegance (in that order of priority).","fork":true,"url":"https://api.github.com/repos/survivorm/Nim","forks_url":"https://api.github.com/repos/survivorm/Nim/forks","keys_url":"https://api.github.com/repos/survivorm/Nim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/survivorm/Nim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/survivorm/Nim/teams","hooks_url":"https://api.github.com/repos/survivorm/Nim/hooks","issue_events_url":"https://api.github.com/repos/survivorm/Nim/issues/events{/number}","events_url":"https://api.github.com/repos/survivorm/Nim/events","assignees_url":"https://api.github.com/repos/survivorm/Nim/assignees{/user}","branches_url":"https://api.github.com/repos/survivorm/Nim/branches{/branch}","tags_url":"https://api.github.com/repos/survivorm/Nim/tags","blobs_url":"https://api.github.com/repos/survivorm/Nim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/survivorm/Nim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/survivorm/Nim/git/refs{/sha}","trees_url":"https://api.github.com/repos/survivorm/Nim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/survivorm/Nim/statuses/{sha}","languages_url":"https://api.github.com/repos/survivorm/Nim/languages","stargazers_url":"https://api.github.com/repos/survivorm/Nim/stargazers","contributors_url":"https://api.github.com/repos/survivorm/Nim/contributors","subscribers_url":"https://api.github.com/repos/survivorm/Nim/subscribers","subscription_url":"https://api.github.com/repos/survivorm/Nim/subscription","commits_url":"https://api.github.com/repos/survivorm/Nim/commits{/sha}","git_commits_url":"https://api.github.com/repos/survivorm/Nim/git/commits{/sha}","comments_url":"https://api.github.com/repos/survivorm/Nim/comments{/number}","issue_comment_url":"https://api.github.com/repos/survivorm/Nim/issues/comments{/number}","contents_url":"https://api.github.com/repos/survivorm/Nim/contents/{+path}","compare_url":"https://api.github.com/repos/survivorm/Nim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/survivorm/Nim/merges","archive_url":"https://api.github.com/repos/survivorm/Nim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/survivorm/Nim/downloads","issues_url":"https://api.github.com/repos/survivorm/Nim/issues{/number}","pulls_url":"https://api.github.com/repos/survivorm/Nim/pulls{/number}","milestones_url":"https://api.github.com/repos/survivorm/Nim/milestones{/number}","notifications_url":"https://api.github.com/repos/survivorm/Nim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/survivorm/Nim/labels{/name}","releases_url":"https://api.github.com/repos/survivorm/Nim/releases{/id}","deployments_url":"https://api.github.com/repos/survivorm/Nim/deployments","created_at":"2018-04-16T07:23:14Z","updated_at":"2018-04-25T09:27:08Z","pushed_at":"2018-04-27T11:40:55Z","git_url":"git://github.com/survivorm/Nim.git","ssh_url":"git@github.com:survivorm/Nim.git","clone_url":"https://github.com/survivorm/Nim.git","svn_url":"https://github.com/survivorm/Nim","homepage":"http://nim-lang.org/","size":67987,"stargazers_count":0,"watchers_count":0,"language":"Nim","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"nim-lang:devel","ref":"devel","sha":"ce36b8efd6795500694e954979e1ccb97058583d","user":{"login":"nim-lang","id":603863,"avatar_url":"https://avatars1.githubusercontent.com/u/603863?v=4","gravatar_id":"","url":"https://api.github.com/users/nim-lang","html_url":"https://github.com/nim-lang","followers_url":"https://api.github.com/users/nim-lang/followers","following_url":"https://api.github.com/users/nim-lang/following{/other_user}","gists_url":"https://api.github.com/users/nim-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/nim-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nim-lang/subscriptions","organizations_url":"https://api.github.com/users/nim-lang/orgs","repos_url":"https://api.github.com/users/nim-lang/repos","events_url":"https://api.github.com/users/nim-lang/events{/privacy}","received_events_url":"https://api.github.com/users/nim-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":842037,"name":"Nim","full_name":"nim-lang/Nim","owner":{"login":"nim-lang","id":603863,"avatar_url":"https://avatars1.githubusercontent.com/u/603863?v=4","gravatar_id":"","url":"https://api.github.com/users/nim-lang","html_url":"https://github.com/nim-lang","followers_url":"https://api.github.com/users/nim-lang/followers","following_url":"https://api.github.com/users/nim-lang/following{/other_user}","gists_url":"https://api.github.com/users/nim-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/nim-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nim-lang/subscriptions","organizations_url":"https://api.github.com/users/nim-lang/orgs","repos_url":"https://api.github.com/users/nim-lang/repos","events_url":"https://api.github.com/users/nim-lang/events{/privacy}","received_events_url":"https://api.github.com/users/nim-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nim-lang/Nim","description":"Nim is a compiled, garbage-collected systems programming language with a design that focuses on efficiency, expressiveness, and elegance (in that order of priority).","fork":false,"url":"https://api.github.com/repos/nim-lang/Nim","forks_url":"https://api.github.com/repos/nim-lang/Nim/forks","keys_url":"https://api.github.com/repos/nim-lang/Nim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nim-lang/Nim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nim-lang/Nim/teams","hooks_url":"https://api.github.com/repos/nim-lang/Nim/hooks","issue_events_url":"https://api.github.com/repos/nim-lang/Nim/issues/events{/number}","events_url":"https://api.github.com/repos/nim-lang/Nim/events","assignees_url":"https://api.github.com/repos/nim-lang/Nim/assignees{/user}","branches_url":"https://api.github.com/repos/nim-lang/Nim/branches{/branch}","tags_url":"https://api.github.com/repos/nim-lang/Nim/tags","blobs_url":"https://api.github.com/repos/nim-lang/Nim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nim-lang/Nim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nim-lang/Nim/git/refs{/sha}","trees_url":"https://api.github.com/repos/nim-lang/Nim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nim-lang/Nim/statuses/{sha}","languages_url":"https://api.github.com/repos/nim-lang/Nim/languages","stargazers_url":"https://api.github.com/repos/nim-lang/Nim/stargazers","contributors_url":"https://api.github.com/repos/nim-lang/Nim/contributors","subscribers_url":"https://api.github.com/repos/nim-lang/Nim/subscribers","subscription_url":"https://api.github.com/repos/nim-lang/Nim/subscription","commits_url":"https://api.github.com/repos/nim-lang/Nim/commits{/sha}","git_commits_url":"https://api.github.com/repos/nim-lang/Nim/git/commits{/sha}","comments_url":"https://api.github.com/repos/nim-lang/Nim/comments{/number}","issue_comment_url":"https://api.github.com/repos/nim-lang/Nim/issues/comments{/number}","contents_url":"https://api.github.com/repos/nim-lang/Nim/contents/{+path}","compare_url":"https://api.github.com/repos/nim-lang/Nim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nim-lang/Nim/merges","archive_url":"https://api.github.com/repos/nim-lang/Nim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nim-lang/Nim/downloads","issues_url":"https://api.github.com/repos/nim-lang/Nim/issues{/number}","pulls_url":"https://api.github.com/repos/nim-lang/Nim/pulls{/number}","milestones_url":"https://api.github.com/repos/nim-lang/Nim/milestones{/number}","notifications_url":"https://api.github.com/repos/nim-lang/Nim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nim-lang/Nim/labels{/name}","releases_url":"https://api.github.com/repos/nim-lang/Nim/releases{/id}","deployments_url":"https://api.github.com/repos/nim-lang/Nim/deployments","created_at":"2010-08-16T20:38:58Z","updated_at":"2018-04-27T09:06:21Z","pushed_at":"2018-04-27T11:48:41Z","git_url":"git://github.com/nim-lang/Nim.git","ssh_url":"git@github.com:nim-lang/Nim.git","clone_url":"https://github.com/nim-lang/Nim.git","svn_url":"https://github.com/nim-lang/Nim","homepage":"http://nim-lang.org/","size":66920,"stargazers_count":4801,"watchers_count":4801,"language":"Nim","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":658,"mirror_url":null,"archived":false,"open_issues_count":1345,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":658,"open_issues":1345,"watchers":4801,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/nim-lang/Nim/pulls/7664"},"html":{"href":"https://github.com/nim-lang/Nim/pull/7664"},"issue":{"href":"https://api.github.com/repos/nim-lang/Nim/issues/7664"},"comments":{"href":"https://api.github.com/repos/nim-lang/Nim/issues/7664/comments"},"review_comments":{"href":"https://api.github.com/repos/nim-lang/Nim/pulls/7664/comments"},"review_comment":{"href":"https://api.github.com/repos/nim-lang/Nim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nim-lang/Nim/pulls/7664/commits"},"statuses":{"href":"https://api.github.com/repos/nim-lang/Nim/statuses/fa9b7d1efed9985e902ecbf2b64ecaeade574dc5"}},"author_association":"NONE"}}
{"actor":{"display_login":"GULPF"}}