{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/pulls/comments/215154793","pull_request_review_id":152356930,"id":215154793,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTE1NDc5Mw==","diff_hunk":"@@ -755,6 +756,7 @@ MBED_NOINLINE static int benchmark_ctr_drbg()\n     if (ret == MBEDTLS_ERR_AES_FEATURE_UNAVAILABLE) {","path":"benchmark/main.cpp","position":749,"original_position":9,"commit_id":"764885a6e493ed7a49d94e4d84d92dc6991c366a","original_commit_id":"5ce6826b687641ee87f2f8c0fd38696473a6b575","user":{"login":"RonEld","id":22030476,"node_id":"MDQ6VXNlcjIyMDMwNDc2","avatar_url":"https://avatars0.githubusercontent.com/u/22030476?v=4","gravatar_id":"","url":"https://api.github.com/users/RonEld","html_url":"https://github.com/RonEld","followers_url":"https://api.github.com/users/RonEld/followers","following_url":"https://api.github.com/users/RonEld/following{/other_user}","gists_url":"https://api.github.com/users/RonEld/gists{/gist_id}","starred_url":"https://api.github.com/users/RonEld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RonEld/subscriptions","organizations_url":"https://api.github.com/users/RonEld/orgs","repos_url":"https://api.github.com/users/RonEld/repos","events_url":"https://api.github.com/users/RonEld/events{/privacy}","received_events_url":"https://api.github.com/users/RonEld/received_events","type":"User","site_admin":false},"body":"I think that in all the other `MBEDTLS_ERR_AES_FEATURE_UNAVAILABLE` we should print and skip the specific test, as it's a reasonable error to return.\r\nFor ctr_drbg, it means that ctr_drbg will fail, as it uses AES256 only, unless configured to 128 bit, as introduced in https://github.com/ARMmbed/mbedtls/pull/1902\r\nSo, this error is not a valid error for ctr_drbg, IMHO.\r\nIf it's only for the printout, well, the `PRINT_ERROR` will handle this, no?","created_at":"2018-09-05T06:58:50Z","updated_at":"2018-09-05T06:58:50Z","html_url":"https://github.com/ARMmbed/mbed-os-example-tls/pull/194#discussion_r215154793","pull_request_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/pulls/194","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/pulls/comments/215154793"},"html":{"href":"https://github.com/ARMmbed/mbed-os-example-tls/pull/194#discussion_r215154793"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/pulls/194"}},"in_reply_to_id":214705442},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/pulls/194","id":208101719,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MTAxNzE5","html_url":"https://github.com/ARMmbed/mbed-os-example-tls/pull/194","diff_url":"https://github.com/ARMmbed/mbed-os-example-tls/pull/194.diff","patch_url":"https://github.com/ARMmbed/mbed-os-example-tls/pull/194.patch","issue_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/issues/194","number":194,"state":"open","locked":false,"title":"Refactor benchmark to mitigate memory problems","user":{"login":"andresag01","id":3746901,"node_id":"MDQ6VXNlcjM3NDY5MDE=","avatar_url":"https://avatars3.githubusercontent.com/u/3746901?v=4","gravatar_id":"","url":"https://api.github.com/users/andresag01","html_url":"https://github.com/andresag01","followers_url":"https://api.github.com/users/andresag01/followers","following_url":"https://api.github.com/users/andresag01/following{/other_user}","gists_url":"https://api.github.com/users/andresag01/gists{/gist_id}","starred_url":"https://api.github.com/users/andresag01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresag01/subscriptions","organizations_url":"https://api.github.com/users/andresag01/orgs","repos_url":"https://api.github.com/users/andresag01/repos","events_url":"https://api.github.com/users/andresag01/events{/privacy}","received_events_url":"https://api.github.com/users/andresag01/received_events","type":"User","site_admin":false},"body":"This PR entirely refactors the benchmark example to fix the memory usage issues in Mbed OS (particularly stack overflows). The idea is to run the benchmark for each module in a completely different (noinline) function. Also, some objects are moved to either to the global section or are allocated dynamically.\r\n\r\nThis PR also includes changes to:\r\n* Remove \\r\\n in favour of \\n\r\n* Remove the todo struct which was a remainder from when the program was command line (https://github.com/ARMmbed/mbed-os-example-tls/issues/170)\r\n* Check for errors at every stage (https://github.com/ARMmbed/mbed-os-example-tls/issues/172)\r\n* Enable more test cases by manually defining more MBEDTLS_* macros in a user config\r\n* Consistently use mbedtls_printf (https://github.com/ARMmbed/mbed-os-example-tls/issues/185)\r\n* Remove use of memory_buffer_alloc module (https://github.com/ARMmbed/mbed-os-example-tls/issues/171)\r\n\r\nAlso addresses: https://github.com/ARMmbed/mbed-os-example-tls/issues/52, https://github.com/ARMmbed/mbed-os-example-tls/issues/29, https://github.com/ARMmbed/mbed-os-example-tls/issues/15 and https://github.com/ARMmbed/mbed-os-example-tls/issues/184\r\n\r\n**NOTE:** This PR is currently under development. I have checked that it works in K64F, but I am waiting for the CI to complete to check whether any other memory issues are detected in the other targets. Regardless, the main structure of the change is in place and can be reviewed.","created_at":"2018-08-13T20:56:57Z","updated_at":"2018-09-05T06:58:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"212b7fbdd782bf3c6bc1485e79cf20cb417c3787","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":386183719,"node_id":"MDU6TGFiZWwzODYxODM3MTk=","url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":729182830,"node_id":"MDU6TGFiZWw3MjkxODI4MzA=","url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/labels/runCI","name":"runCI","color":"57db6d","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/pulls/194/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/pulls/194/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/issues/194/comments","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/statuses/764885a6e493ed7a49d94e4d84d92dc6991c366a","head":{"label":"andresag01:iotssl-2430-benchmark-refactor","ref":"iotssl-2430-benchmark-refactor","sha":"764885a6e493ed7a49d94e4d84d92dc6991c366a","user":{"login":"andresag01","id":3746901,"node_id":"MDQ6VXNlcjM3NDY5MDE=","avatar_url":"https://avatars3.githubusercontent.com/u/3746901?v=4","gravatar_id":"","url":"https://api.github.com/users/andresag01","html_url":"https://github.com/andresag01","followers_url":"https://api.github.com/users/andresag01/followers","following_url":"https://api.github.com/users/andresag01/following{/other_user}","gists_url":"https://api.github.com/users/andresag01/gists{/gist_id}","starred_url":"https://api.github.com/users/andresag01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresag01/subscriptions","organizations_url":"https://api.github.com/users/andresag01/orgs","repos_url":"https://api.github.com/users/andresag01/repos","events_url":"https://api.github.com/users/andresag01/events{/privacy}","received_events_url":"https://api.github.com/users/andresag01/received_events","type":"User","site_admin":false},"repo":{"id":69363703,"node_id":"MDEwOlJlcG9zaXRvcnk2OTM2MzcwMw==","name":"mbed-os-example-tls","full_name":"andresag01/mbed-os-example-tls","owner":{"login":"andresag01","id":3746901,"node_id":"MDQ6VXNlcjM3NDY5MDE=","avatar_url":"https://avatars3.githubusercontent.com/u/3746901?v=4","gravatar_id":"","url":"https://api.github.com/users/andresag01","html_url":"https://github.com/andresag01","followers_url":"https://api.github.com/users/andresag01/followers","following_url":"https://api.github.com/users/andresag01/following{/other_user}","gists_url":"https://api.github.com/users/andresag01/gists{/gist_id}","starred_url":"https://api.github.com/users/andresag01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresag01/subscriptions","organizations_url":"https://api.github.com/users/andresag01/orgs","repos_url":"https://api.github.com/users/andresag01/repos","events_url":"https://api.github.com/users/andresag01/events{/privacy}","received_events_url":"https://api.github.com/users/andresag01/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andresag01/mbed-os-example-tls","description":"mbed TLS Sample application","fork":true,"url":"https://api.github.com/repos/andresag01/mbed-os-example-tls","forks_url":"https://api.github.com/repos/andresag01/mbed-os-example-tls/forks","keys_url":"https://api.github.com/repos/andresag01/mbed-os-example-tls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andresag01/mbed-os-example-tls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andresag01/mbed-os-example-tls/teams","hooks_url":"https://api.github.com/repos/andresag01/mbed-os-example-tls/hooks","issue_events_url":"https://api.github.com/repos/andresag01/mbed-os-example-tls/issues/events{/number}","events_url":"https://api.github.com/repos/andresag01/mbed-os-example-tls/events","assignees_url":"https://api.github.com/repos/andresag01/mbed-os-example-tls/assignees{/user}","branches_url":"https://api.github.com/repos/andresag01/mbed-os-example-tls/branches{/branch}","tags_url":"https://api.github.com/repos/andresag01/mbed-os-example-tls/tags","blobs_url":"https://api.github.com/repos/andresag01/mbed-os-example-tls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andresag01/mbed-os-example-tls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andresag01/mbed-os-example-tls/git/refs{/sha}","trees_url":"https://api.github.com/repos/andresag01/mbed-os-example-tls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andresag01/mbed-os-example-tls/statuses/{sha}","languages_url":"https://api.github.com/repos/andresag01/mbed-os-example-tls/languages","stargazers_url":"https://api.github.com/repos/andresag01/mbed-os-example-tls/stargazers","contributors_url":"https://api.github.com/repos/andresag01/mbed-os-example-tls/contributors","subscribers_url":"https://api.github.com/repos/andresag01/mbed-os-example-tls/subscribers","subscription_url":"https://api.github.com/repos/andresag01/mbed-os-example-tls/subscription","commits_url":"https://api.github.com/repos/andresag01/mbed-os-example-tls/commits{/sha}","git_commits_url":"https://api.github.com/repos/andresag01/mbed-os-example-tls/git/commits{/sha}","comments_url":"https://api.github.com/repos/andresag01/mbed-os-example-tls/comments{/number}","issue_comment_url":"https://api.github.com/repos/andresag01/mbed-os-example-tls/issues/comments{/number}","contents_url":"https://api.github.com/repos/andresag01/mbed-os-example-tls/contents/{+path}","compare_url":"https://api.github.com/repos/andresag01/mbed-os-example-tls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andresag01/mbed-os-example-tls/merges","archive_url":"https://api.github.com/repos/andresag01/mbed-os-example-tls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andresag01/mbed-os-example-tls/downloads","issues_url":"https://api.github.com/repos/andresag01/mbed-os-example-tls/issues{/number}","pulls_url":"https://api.github.com/repos/andresag01/mbed-os-example-tls/pulls{/number}","milestones_url":"https://api.github.com/repos/andresag01/mbed-os-example-tls/milestones{/number}","notifications_url":"https://api.github.com/repos/andresag01/mbed-os-example-tls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andresag01/mbed-os-example-tls/labels{/name}","releases_url":"https://api.github.com/repos/andresag01/mbed-os-example-tls/releases{/id}","deployments_url":"https://api.github.com/repos/andresag01/mbed-os-example-tls/deployments","created_at":"2016-09-27T14:10:49Z","updated_at":"2016-09-27T14:10:50Z","pushed_at":"2018-09-04T19:23:39Z","git_url":"git://github.com/andresag01/mbed-os-example-tls.git","ssh_url":"git@github.com:andresag01/mbed-os-example-tls.git","clone_url":"https://github.com/andresag01/mbed-os-example-tls.git","svn_url":"https://github.com/andresag01/mbed-os-example-tls","homepage":null,"size":301,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ARMmbed:master","ref":"master","sha":"d99ad74b51d8f85c956b87e74811eebee65a116a","user":{"login":"ARMmbed","id":8916057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MTYwNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":60215416,"node_id":"MDEwOlJlcG9zaXRvcnk2MDIxNTQxNg==","name":"mbed-os-example-tls","full_name":"ARMmbed/mbed-os-example-tls","owner":{"login":"ARMmbed","id":8916057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MTYwNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/mbed-os-example-tls","description":"mbed TLS Sample application","fork":false,"url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls","forks_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/forks","keys_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/teams","hooks_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/events","assignees_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/tags","blobs_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/subscription","commits_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/merges","archive_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/downloads","issues_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/deployments","created_at":"2016-06-01T22:37:49Z","updated_at":"2018-08-27T12:49:16Z","pushed_at":"2018-09-04T19:23:41Z","git_url":"git://github.com/ARMmbed/mbed-os-example-tls.git","ssh_url":"git@github.com:ARMmbed/mbed-os-example-tls.git","clone_url":"https://github.com/ARMmbed/mbed-os-example-tls.git","svn_url":"https://github.com/ARMmbed/mbed-os-example-tls","homepage":null,"size":20571,"stargazers_count":7,"watchers_count":7,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":32,"license":null,"forks":28,"open_issues":32,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/pulls/194"},"html":{"href":"https://github.com/ARMmbed/mbed-os-example-tls/pull/194"},"issue":{"href":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/issues/194"},"comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/issues/194/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/pulls/194/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/pulls/194/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/statuses/764885a6e493ed7a49d94e4d84d92dc6991c366a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"RonEld"}}