{"action":"created","issue":{"url":"https://api.github.com/repos/Azure/acs-engine/issues/2903","repository_url":"https://api.github.com/repos/Azure/acs-engine","labels_url":"https://api.github.com/repos/Azure/acs-engine/issues/2903/labels{/name}","comments_url":"https://api.github.com/repos/Azure/acs-engine/issues/2903/comments","events_url":"https://api.github.com/repos/Azure/acs-engine/issues/2903/events","html_url":"https://github.com/Azure/acs-engine/pull/2903","id":321790389,"number":2903,"title":"Autofill ACI Connector credentials and enable logs","user":{"login":"sozercan","id":852750,"avatar_url":"https://avatars0.githubusercontent.com/u/852750?v=4","gravatar_id":"","url":"https://api.github.com/users/sozercan","html_url":"https://github.com/sozercan","followers_url":"https://api.github.com/users/sozercan/followers","following_url":"https://api.github.com/users/sozercan/following{/other_user}","gists_url":"https://api.github.com/users/sozercan/gists{/gist_id}","starred_url":"https://api.github.com/users/sozercan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sozercan/subscriptions","organizations_url":"https://api.github.com/users/sozercan/orgs","repos_url":"https://api.github.com/users/sozercan/repos","events_url":"https://api.github.com/users/sozercan/events{/privacy}","received_events_url":"https://api.github.com/users/sozercan/received_events","type":"User","site_admin":false},"labels":[{"id":616225832,"url":"https://api.github.com/repos/Azure/acs-engine/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"sozercan","id":852750,"avatar_url":"https://avatars0.githubusercontent.com/u/852750?v=4","gravatar_id":"","url":"https://api.github.com/users/sozercan","html_url":"https://github.com/sozercan","followers_url":"https://api.github.com/users/sozercan/followers","following_url":"https://api.github.com/users/sozercan/following{/other_user}","gists_url":"https://api.github.com/users/sozercan/gists{/gist_id}","starred_url":"https://api.github.com/users/sozercan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sozercan/subscriptions","organizations_url":"https://api.github.com/users/sozercan/orgs","repos_url":"https://api.github.com/users/sozercan/repos","events_url":"https://api.github.com/users/sozercan/events{/privacy}","received_events_url":"https://api.github.com/users/sozercan/received_events","type":"User","site_admin":false},"assignees":[{"login":"sozercan","id":852750,"avatar_url":"https://avatars0.githubusercontent.com/u/852750?v=4","gravatar_id":"","url":"https://api.github.com/users/sozercan","html_url":"https://github.com/sozercan","followers_url":"https://api.github.com/users/sozercan/followers","following_url":"https://api.github.com/users/sozercan/following{/other_user}","gists_url":"https://api.github.com/users/sozercan/gists{/gist_id}","starred_url":"https://api.github.com/users/sozercan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sozercan/subscriptions","organizations_url":"https://api.github.com/users/sozercan/orgs","repos_url":"https://api.github.com/users/sozercan/repos","events_url":"https://api.github.com/users/sozercan/events{/privacy}","received_events_url":"https://api.github.com/users/sozercan/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-05-10T02:43:49Z","updated_at":"2018-05-10T23:33:30Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Azure/acs-engine/pulls/2903","html_url":"https://github.com/Azure/acs-engine/pull/2903","diff_url":"https://github.com/Azure/acs-engine/pull/2903.diff","patch_url":"https://github.com/Azure/acs-engine/pull/2903.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If you want *faster* PR reviews, read how: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n* autofills required credentials for virtual-kubelet/aci-connector addon (clientId, clientSecret, resourceGroup, tenantId, subscriptionId)\r\n* generates certificates required to get logs.\r\n\r\nFixes #2793\r\nCloses #2574 (since this is no longer needed)\r\n \r\n@vglafirov @aku105"},"comment":{"url":"https://api.github.com/repos/Azure/acs-engine/issues/comments/388216629","html_url":"https://github.com/Azure/acs-engine/pull/2903#issuecomment-388216629","issue_url":"https://api.github.com/repos/Azure/acs-engine/issues/2903","id":388216629,"user":{"login":"sozercan","id":852750,"avatar_url":"https://avatars0.githubusercontent.com/u/852750?v=4","gravatar_id":"","url":"https://api.github.com/users/sozercan","html_url":"https://github.com/sozercan","followers_url":"https://api.github.com/users/sozercan/followers","following_url":"https://api.github.com/users/sozercan/following{/other_user}","gists_url":"https://api.github.com/users/sozercan/gists{/gist_id}","starred_url":"https://api.github.com/users/sozercan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sozercan/subscriptions","organizations_url":"https://api.github.com/users/sozercan/orgs","repos_url":"https://api.github.com/users/sozercan/repos","events_url":"https://api.github.com/users/sozercan/events{/privacy}","received_events_url":"https://api.github.com/users/sozercan/received_events","type":"User","site_admin":false},"created_at":"2018-05-10T23:33:30Z","updated_at":"2018-05-10T23:33:30Z","author_association":"CONTRIBUTOR","body":"@jackfrancis let me know if its preferred to reuse an existing cert from `/etc/kubernetes/cert` instead of generating new ones for VK."}}
{"actor":{"display_login":"sozercan"}}