{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/68017","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/68017/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/68017/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/68017/events","html_url":"https://github.com/kubernetes/kubernetes/pull/68017","id":355250480,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExODIyOTM1","number":68017,"title":"add test to verify vsphere cloud provider report node hostname","user":{"login":"figo","id":152194,"node_id":"MDQ6VXNlcjE1MjE5NA==","avatar_url":"https://avatars3.githubusercontent.com/u/152194?v=4","gravatar_id":"","url":"https://api.github.com/users/figo","html_url":"https://github.com/figo","followers_url":"https://api.github.com/users/figo/followers","following_url":"https://api.github.com/users/figo/following{/other_user}","gists_url":"https://api.github.com/users/figo/gists{/gist_id}","starred_url":"https://api.github.com/users/figo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/figo/subscriptions","organizations_url":"https://api.github.com/users/figo/orgs","repos_url":"https://api.github.com/users/figo/repos","events_url":"https://api.github.com/users/figo/events{/privacy}","received_events_url":"https://api.github.com/users/figo/received_events","type":"User","site_admin":false},"labels":[{"id":414883982,"node_id":"MDU6TGFiZWw0MTQ4ODM5ODI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":148225179,"node_id":"MDU6TGFiZWwxNDgyMjUxNzk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":349530249,"node_id":"MDU6TGFiZWwzNDk1MzAyNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":958178286,"node_id":"MDU6TGFiZWw5NTgxNzgyODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/cloud-provider","name":"sig/cloud-provider","color":"d2b48c","default":false},{"id":253450934,"node_id":"MDU6TGFiZWwyNTM0NTA5MzQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/M","name":"size/M","color":"eebb00","default":false}],"state":"open","locked":false,"assignee":{"login":"frapposelli","id":541832,"node_id":"MDQ6VXNlcjU0MTgzMg==","avatar_url":"https://avatars0.githubusercontent.com/u/541832?v=4","gravatar_id":"","url":"https://api.github.com/users/frapposelli","html_url":"https://github.com/frapposelli","followers_url":"https://api.github.com/users/frapposelli/followers","following_url":"https://api.github.com/users/frapposelli/following{/other_user}","gists_url":"https://api.github.com/users/frapposelli/gists{/gist_id}","starred_url":"https://api.github.com/users/frapposelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frapposelli/subscriptions","organizations_url":"https://api.github.com/users/frapposelli/orgs","repos_url":"https://api.github.com/users/frapposelli/repos","events_url":"https://api.github.com/users/frapposelli/events{/privacy}","received_events_url":"https://api.github.com/users/frapposelli/received_events","type":"User","site_admin":false},"assignees":[{"login":"frapposelli","id":541832,"node_id":"MDQ6VXNlcjU0MTgzMg==","avatar_url":"https://avatars0.githubusercontent.com/u/541832?v=4","gravatar_id":"","url":"https://api.github.com/users/frapposelli","html_url":"https://github.com/frapposelli","followers_url":"https://api.github.com/users/frapposelli/followers","following_url":"https://api.github.com/users/frapposelli/following{/other_user}","gists_url":"https://api.github.com/users/frapposelli/gists{/gist_id}","starred_url":"https://api.github.com/users/frapposelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frapposelli/subscriptions","organizations_url":"https://api.github.com/users/frapposelli/orgs","repos_url":"https://api.github.com/users/frapposelli/repos","events_url":"https://api.github.com/users/frapposelli/events{/privacy}","received_events_url":"https://api.github.com/users/frapposelli/received_events","type":"User","site_admin":false},{"login":"saad-ali","id":10052848,"node_id":"MDQ6VXNlcjEwMDUyODQ4","avatar_url":"https://avatars1.githubusercontent.com/u/10052848?v=4","gravatar_id":"","url":"https://api.github.com/users/saad-ali","html_url":"https://github.com/saad-ali","followers_url":"https://api.github.com/users/saad-ali/followers","following_url":"https://api.github.com/users/saad-ali/following{/other_user}","gists_url":"https://api.github.com/users/saad-ali/gists{/gist_id}","starred_url":"https://api.github.com/users/saad-ali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saad-ali/subscriptions","organizations_url":"https://api.github.com/users/saad-ali/orgs","repos_url":"https://api.github.com/users/saad-ali/repos","events_url":"https://api.github.com/users/saad-ali/events{/privacy}","received_events_url":"https://api.github.com/users/saad-ali/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/39","html_url":"https://github.com/kubernetes/kubernetes/milestone/39","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/39/labels","id":2913712,"node_id":"MDk6TWlsZXN0b25lMjkxMzcxMg==","number":39,"title":"v1.12","description":"","creator":{"login":"thockin","id":5595220,"node_id":"MDQ6VXNlcjU1OTUyMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/5595220?v=4","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"open_issues":83,"closed_issues":147,"state":"open","created_at":"2017-11-15T06:32:51Z","updated_at":"2018-09-02T17:28:19Z","due_on":null,"closed_at":null},"comments":9,"created_at":"2018-08-29T16:59:54Z","updated_at":"2018-09-02T18:34:09Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/68017","html_url":"https://github.com/kubernetes/kubernetes/pull/68017","diff_url":"https://github.com/kubernetes/kubernetes/pull/68017.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/68017.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n4. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\nas in pull #67922 has modify vsphere cloud provider to report\r\nnode hostname, this patch is to add the test for it.\r\n\r\nalso fix an issue at InstanceID(), it suppose to return\r\ncloudprovider.InstanceNotFound when vm not found,  \r\nbut it did double error type translation with a retry() logic,  \r\nafter removing the retry() (which is not necessary), the logic is simpler, and easier to understand how double translation happened, after the fix,\r\ntest TestInstance() can pass\r\n\r\n\r\n**Which issue(s) this PR fixes** :\r\nFixes #67714\r\n\r\n\r\n**Special notes for your reviewer**:\r\nas in the process of create pull to fix https://github.com/crosscloudci/crosscloudci/issues/65#,\r\ni saw #67922 already merged, so this pull is just to submit the test part.\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nnone\r\n```\r\n\r\n\r\n/cc @abrarshivani @BaluDontu @divyenpatel @imkin @kerneltime @luomiao @frapposelli @dougm @liggitt\r\n/sig cloudprovider"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/417950257","html_url":"https://github.com/kubernetes/kubernetes/pull/68017#issuecomment-417950257","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/68017","id":417950257,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNzk1MDI1Nw==","user":{"login":"k8s-merge-robot","id":13653959,"node_id":"MDQ6VXNlcjEzNjUzOTU5","avatar_url":"https://avatars0.githubusercontent.com/u/13653959?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-merge-robot","html_url":"https://github.com/k8s-merge-robot","followers_url":"https://api.github.com/users/k8s-merge-robot/followers","following_url":"https://api.github.com/users/k8s-merge-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-merge-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-merge-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-merge-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-merge-robot/orgs","repos_url":"https://api.github.com/users/k8s-merge-robot/repos","events_url":"https://api.github.com/users/k8s-merge-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-merge-robot/received_events","type":"User","site_admin":false},"created_at":"2018-09-02T18:34:09Z","updated_at":"2018-09-02T18:34:09Z","author_association":"CONTRIBUTOR","body":"/test all [submit-queue is verifying that this PR is safe to merge]"}}
{"actor":{"display_login":"k8s-merge-robot"}}