{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/66257","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/66257/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/66257/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/66257/events","html_url":"https://github.com/kubernetes/kubernetes/pull/66257","id":341713046,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNzg2NDk0","number":66257,"title":"Kubelet creates and manages node leases","user":{"login":"mtaufen","id":903617,"node_id":"MDQ6VXNlcjkwMzYxNw==","avatar_url":"https://avatars1.githubusercontent.com/u/903617?v=4","gravatar_id":"","url":"https://api.github.com/users/mtaufen","html_url":"https://github.com/mtaufen","followers_url":"https://api.github.com/users/mtaufen/followers","following_url":"https://api.github.com/users/mtaufen/following{/other_user}","gists_url":"https://api.github.com/users/mtaufen/gists{/gist_id}","starred_url":"https://api.github.com/users/mtaufen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtaufen/subscriptions","organizations_url":"https://api.github.com/users/mtaufen/orgs","repos_url":"https://api.github.com/users/mtaufen/repos","events_url":"https://api.github.com/users/mtaufen/events{/privacy}","received_events_url":"https://api.github.com/users/mtaufen/received_events","type":"User","site_admin":false},"labels":[{"id":116719829,"node_id":"MDU6TGFiZWwxMTY3MTk4Mjk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/kubelet","name":"area/kubelet","color":"0052cc","default":false},{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":261005360,"node_id":"MDU6TGFiZWwyNjEwMDUzNjA=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/api-change","name":"kind/api-change","color":"c7def8","default":false},{"id":267761362,"node_id":"MDU6TGFiZWwyNjc3NjEzNjI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/feature","name":"kind/feature","color":"c7def8","default":false},{"id":114528223,"node_id":"MDU6TGFiZWwxMTQ1MjgyMjM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/priority/important-soon","name":"priority/important-soon","color":"eb6420","default":false},{"id":200149833,"node_id":"MDU6TGFiZWwyMDAxNDk4MzM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":173493665,"node_id":"MDU6TGFiZWwxNzM0OTM2NjU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/node","name":"sig/node","color":"d2b48c","default":false},{"id":253451057,"node_id":"MDU6TGFiZWwyNTM0NTEwNTc=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XL","name":"size/XL","color":"ee5500","default":false},{"id":611767149,"node_id":"MDU6TGFiZWw2MTE3NjcxNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/status/approved-for-milestone","name":"status/approved-for-milestone","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":{"login":"yujuhong","id":10524058,"node_id":"MDQ6VXNlcjEwNTI0MDU4","avatar_url":"https://avatars1.githubusercontent.com/u/10524058?v=4","gravatar_id":"","url":"https://api.github.com/users/yujuhong","html_url":"https://github.com/yujuhong","followers_url":"https://api.github.com/users/yujuhong/followers","following_url":"https://api.github.com/users/yujuhong/following{/other_user}","gists_url":"https://api.github.com/users/yujuhong/gists{/gist_id}","starred_url":"https://api.github.com/users/yujuhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yujuhong/subscriptions","organizations_url":"https://api.github.com/users/yujuhong/orgs","repos_url":"https://api.github.com/users/yujuhong/repos","events_url":"https://api.github.com/users/yujuhong/events{/privacy}","received_events_url":"https://api.github.com/users/yujuhong/received_events","type":"User","site_admin":false},"assignees":[{"login":"yujuhong","id":10524058,"node_id":"MDQ6VXNlcjEwNTI0MDU4","avatar_url":"https://avatars1.githubusercontent.com/u/10524058?v=4","gravatar_id":"","url":"https://api.github.com/users/yujuhong","html_url":"https://github.com/yujuhong","followers_url":"https://api.github.com/users/yujuhong/followers","following_url":"https://api.github.com/users/yujuhong/following{/other_user}","gists_url":"https://api.github.com/users/yujuhong/gists{/gist_id}","starred_url":"https://api.github.com/users/yujuhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yujuhong/subscriptions","organizations_url":"https://api.github.com/users/yujuhong/orgs","repos_url":"https://api.github.com/users/yujuhong/repos","events_url":"https://api.github.com/users/yujuhong/events{/privacy}","received_events_url":"https://api.github.com/users/yujuhong/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/39","html_url":"https://github.com/kubernetes/kubernetes/milestone/39","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/39/labels","id":2913712,"node_id":"MDk6TWlsZXN0b25lMjkxMzcxMg==","number":39,"title":"v1.12","description":"","creator":{"login":"thockin","id":5595220,"node_id":"MDQ6VXNlcjU1OTUyMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/5595220?v=4","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"open_issues":32,"closed_issues":24,"state":"open","created_at":"2017-11-15T06:32:51Z","updated_at":"2018-07-25T23:19:01Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2018-07-16T23:25:42Z","updated_at":"2018-07-26T14:44:51Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/66257","html_url":"https://github.com/kubernetes/kubernetes/pull/66257","diff_url":"https://github.com/kubernetes/kubernetes/pull/66257.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/66257.patch"},"body":"This extends the Kubelet to create and periodically update leases in a\r\nnew kube-node-lease namespace. Based on [KEP-0009](https://github.com/kubernetes/community/blob/master/keps/sig-node/0009-node-heartbeat.md),\r\nthese leases can be used as a node health signal, and will allow us to\r\nreduce the load caused by over-frequent node status reporting.\r\n\r\n- add NodeLease feature gate\r\n- add kube-node-lease system namespace for node leases\r\n- add Kubelet option for lease duration\r\n- add Kubelet-internal lease controller to create and update lease\r\n- add e2e test for NodeLease feature\r\n\r\nI would like to determine a standard policy for lease renewal frequency, based on the configured lease duration, so that we don't need to expose frequency as an additional knob. The renew interval is currently calculated as 1/3 of the lease duration.\r\n\r\n```release-note\r\nkubelet: Users can now enable the NodeLease feature gate to have the Kubelet create and periodically renew a Lease in the kube-node-lease namespace. The lease duration defaults to 40s, and can be configured via the kubelet.config.k8s.io/v1beta1.KubeletConfiguration's NodeLeaseDurationSeconds field.\r\n```\r\n\r\n/cc @wojtek-t @liggitt "},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/408121907","html_url":"https://github.com/kubernetes/kubernetes/pull/66257#issuecomment-408121907","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/66257","id":408121907,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODEyMTkwNw==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-07-26T14:44:51Z","updated_at":"2018-07-26T14:44:51Z","author_association":"COLLABORATOR","body":"@mtaufen: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-typecheck | ecf14f5f15f109537c070ad089b194578b531009 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/66257/pull-kubernetes-typecheck/18197/) | `/test pull-kubernetes-typecheck`\npull-kubernetes-bazel-test | ecf14f5f15f109537c070ad089b194578b531009 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/66257/pull-kubernetes-bazel-test/53766/) | `/test pull-kubernetes-bazel-test`\npull-kubernetes-verify | ecf14f5f15f109537c070ad089b194578b531009 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/66257/pull-kubernetes-verify/99800/) | `/test pull-kubernetes-verify`\npull-kubernetes-e2e-gce | d148dc7716c3b6743f1af5fddfa9b95a79bed9df | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/66257/pull-kubernetes-e2e-gce/45739/) | `/test pull-kubernetes-e2e-gce`\npull-kubernetes-e2e-gce-device-plugin-gpu | d148dc7716c3b6743f1af5fddfa9b95a79bed9df | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/66257/pull-kubernetes-e2e-gce-device-plugin-gpu/41159/) | `/test pull-kubernetes-e2e-gce-device-plugin-gpu`\npull-kubernetes-e2e-kops-aws | d148dc7716c3b6743f1af5fddfa9b95a79bed9df | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/66257/pull-kubernetes-e2e-kops-aws/98653/) | `/test pull-kubernetes-e2e-kops-aws`\npull-kubernetes-kubemark-e2e-gce-big | d148dc7716c3b6743f1af5fddfa9b95a79bed9df | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/66257/pull-kubernetes-kubemark-e2e-gce-big/15662/) | `/test pull-kubernetes-kubemark-e2e-gce-big`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/66257). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/mtaufen). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}