{"action":"created","comment":{"url":"https://api.github.com/repos/owncloud/ios-app/pulls/comments/194779037","pull_request_review_id":128014400,"id":194779037,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDc3OTAzNw==","diff_hunk":"@@ -116,6 +117,16 @@ class ClientQueryViewController: UITableViewController, Themeable {\n \t\tsortBar?.updateSortMethod()\n \n         tableView.tableHeaderView = sortBar\n+\n+\t\tsearchController.searchResultsUpdater = self\n+\t\tsearchController.obscuresBackgroundDuringPresentation = false\n+\t\tsearchController.hidesNavigationBarDuringPresentation = true\n+\t\tsearchController.searchBar.placeholder = \"Search\".localized\n+\t\tnavigationItem.searchController = searchController\n+\t\tnavigationItem.hidesSearchBarWhenScrolling = false","path":"ownCloud/Client/ClientQueryViewController.swift","position":18,"original_position":18,"commit_id":"a0c21e77508ddce55c0f5343caf49f835f4bd257","original_commit_id":"a0c21e77508ddce55c0f5343caf49f835f4bd257","user":{"login":"pablocarmu","id":8929738,"node_id":"MDQ6VXNlcjg5Mjk3Mzg=","avatar_url":"https://avatars0.githubusercontent.com/u/8929738?v=4","gravatar_id":"","url":"https://api.github.com/users/pablocarmu","html_url":"https://github.com/pablocarmu","followers_url":"https://api.github.com/users/pablocarmu/followers","following_url":"https://api.github.com/users/pablocarmu/following{/other_user}","gists_url":"https://api.github.com/users/pablocarmu/gists{/gist_id}","starred_url":"https://api.github.com/users/pablocarmu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pablocarmu/subscriptions","organizations_url":"https://api.github.com/users/pablocarmu/orgs","repos_url":"https://api.github.com/users/pablocarmu/repos","events_url":"https://api.github.com/users/pablocarmu/events{/privacy}","received_events_url":"https://api.github.com/users/pablocarmu/received_events","type":"User","site_admin":false},"body":"I've just copied the Files app design. Yes, we could open an issue and talk about it.\r\n@michaelstingl  what do you think?","created_at":"2018-06-12T15:15:32Z","updated_at":"2018-06-12T15:15:32Z","html_url":"https://github.com/owncloud/ios-app/pull/64#discussion_r194779037","pull_request_url":"https://api.github.com/repos/owncloud/ios-app/pulls/64","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/owncloud/ios-app/pulls/comments/194779037"},"html":{"href":"https://github.com/owncloud/ios-app/pull/64#discussion_r194779037"},"pull_request":{"href":"https://api.github.com/repos/owncloud/ios-app/pulls/64"}},"in_reply_to_id":194656410},"pull_request":{"url":"https://api.github.com/repos/owncloud/ios-app/pulls/64","id":192690017,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyNjkwMDE3","html_url":"https://github.com/owncloud/ios-app/pull/64","diff_url":"https://github.com/owncloud/ios-app/pull/64.diff","patch_url":"https://github.com/owncloud/ios-app/pull/64.patch","issue_url":"https://api.github.com/repos/owncloud/ios-app/issues/64","number":64,"state":"open","locked":false,"title":"Local search","user":{"login":"pablocarmu","id":8929738,"node_id":"MDQ6VXNlcjg5Mjk3Mzg=","avatar_url":"https://avatars0.githubusercontent.com/u/8929738?v=4","gravatar_id":"","url":"https://api.github.com/users/pablocarmu","html_url":"https://github.com/pablocarmu","followers_url":"https://api.github.com/users/pablocarmu/followers","following_url":"https://api.github.com/users/pablocarmu/following{/other_user}","gists_url":"https://api.github.com/users/pablocarmu/gists{/gist_id}","starred_url":"https://api.github.com/users/pablocarmu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pablocarmu/subscriptions","organizations_url":"https://api.github.com/users/pablocarmu/orgs","repos_url":"https://api.github.com/users/pablocarmu/repos","events_url":"https://api.github.com/users/pablocarmu/events{/privacy}","received_events_url":"https://api.github.com/users/pablocarmu/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-05T12:29:49Z","updated_at":"2018-06-12T15:15:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a096cc371eb8b030c8788546e1deb259ace0a1a9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/owncloud/ios-app/pulls/64/commits","review_comments_url":"https://api.github.com/repos/owncloud/ios-app/pulls/64/comments","review_comment_url":"https://api.github.com/repos/owncloud/ios-app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/owncloud/ios-app/issues/64/comments","statuses_url":"https://api.github.com/repos/owncloud/ios-app/statuses/a0c21e77508ddce55c0f5343caf49f835f4bd257","head":{"label":"owncloud:feature/local_search","ref":"feature/local_search","sha":"a0c21e77508ddce55c0f5343caf49f835f4bd257","user":{"login":"owncloud","id":1645051,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDUwNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1645051?v=4","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":120430704,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA0MzA3MDQ=","name":"ios-app","full_name":"owncloud/ios-app","owner":{"login":"owncloud","id":1645051,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDUwNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1645051?v=4","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/ios-app","description":"📱iOS app for ownCloud, [WIP not available for production]","fork":false,"url":"https://api.github.com/repos/owncloud/ios-app","forks_url":"https://api.github.com/repos/owncloud/ios-app/forks","keys_url":"https://api.github.com/repos/owncloud/ios-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/ios-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/ios-app/teams","hooks_url":"https://api.github.com/repos/owncloud/ios-app/hooks","issue_events_url":"https://api.github.com/repos/owncloud/ios-app/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/ios-app/events","assignees_url":"https://api.github.com/repos/owncloud/ios-app/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/ios-app/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/ios-app/tags","blobs_url":"https://api.github.com/repos/owncloud/ios-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/ios-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/ios-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/ios-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/ios-app/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/ios-app/languages","stargazers_url":"https://api.github.com/repos/owncloud/ios-app/stargazers","contributors_url":"https://api.github.com/repos/owncloud/ios-app/contributors","subscribers_url":"https://api.github.com/repos/owncloud/ios-app/subscribers","subscription_url":"https://api.github.com/repos/owncloud/ios-app/subscription","commits_url":"https://api.github.com/repos/owncloud/ios-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/ios-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/ios-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/ios-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/ios-app/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/ios-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/ios-app/merges","archive_url":"https://api.github.com/repos/owncloud/ios-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/ios-app/downloads","issues_url":"https://api.github.com/repos/owncloud/ios-app/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/ios-app/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/ios-app/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/ios-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/ios-app/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/ios-app/releases{/id}","deployments_url":"https://api.github.com/repos/owncloud/ios-app/deployments","created_at":"2018-02-06T09:20:24Z","updated_at":"2018-06-11T13:49:50Z","pushed_at":"2018-06-12T14:03:03Z","git_url":"git://github.com/owncloud/ios-app.git","ssh_url":"git@github.com:owncloud/ios-app.git","clone_url":"https://github.com/owncloud/ios-app.git","svn_url":"https://github.com/owncloud/ios-app","homepage":"","size":4138,"stargazers_count":6,"watchers_count":6,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":5,"open_issues":36,"watchers":6,"default_branch":"master"}},"base":{"label":"owncloud:master","ref":"master","sha":"844091f5923d3b65b1aa837db2fea4cbcfc9c9ce","user":{"login":"owncloud","id":1645051,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDUwNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1645051?v=4","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":120430704,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA0MzA3MDQ=","name":"ios-app","full_name":"owncloud/ios-app","owner":{"login":"owncloud","id":1645051,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDUwNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1645051?v=4","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/ios-app","description":"📱iOS app for ownCloud, [WIP not available for production]","fork":false,"url":"https://api.github.com/repos/owncloud/ios-app","forks_url":"https://api.github.com/repos/owncloud/ios-app/forks","keys_url":"https://api.github.com/repos/owncloud/ios-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/ios-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/ios-app/teams","hooks_url":"https://api.github.com/repos/owncloud/ios-app/hooks","issue_events_url":"https://api.github.com/repos/owncloud/ios-app/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/ios-app/events","assignees_url":"https://api.github.com/repos/owncloud/ios-app/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/ios-app/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/ios-app/tags","blobs_url":"https://api.github.com/repos/owncloud/ios-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/ios-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/ios-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/ios-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/ios-app/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/ios-app/languages","stargazers_url":"https://api.github.com/repos/owncloud/ios-app/stargazers","contributors_url":"https://api.github.com/repos/owncloud/ios-app/contributors","subscribers_url":"https://api.github.com/repos/owncloud/ios-app/subscribers","subscription_url":"https://api.github.com/repos/owncloud/ios-app/subscription","commits_url":"https://api.github.com/repos/owncloud/ios-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/ios-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/ios-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/ios-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/ios-app/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/ios-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/ios-app/merges","archive_url":"https://api.github.com/repos/owncloud/ios-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/ios-app/downloads","issues_url":"https://api.github.com/repos/owncloud/ios-app/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/ios-app/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/ios-app/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/ios-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/ios-app/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/ios-app/releases{/id}","deployments_url":"https://api.github.com/repos/owncloud/ios-app/deployments","created_at":"2018-02-06T09:20:24Z","updated_at":"2018-06-11T13:49:50Z","pushed_at":"2018-06-12T14:03:03Z","git_url":"git://github.com/owncloud/ios-app.git","ssh_url":"git@github.com:owncloud/ios-app.git","clone_url":"https://github.com/owncloud/ios-app.git","svn_url":"https://github.com/owncloud/ios-app","homepage":"","size":4138,"stargazers_count":6,"watchers_count":6,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":5,"open_issues":36,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/owncloud/ios-app/pulls/64"},"html":{"href":"https://github.com/owncloud/ios-app/pull/64"},"issue":{"href":"https://api.github.com/repos/owncloud/ios-app/issues/64"},"comments":{"href":"https://api.github.com/repos/owncloud/ios-app/issues/64/comments"},"review_comments":{"href":"https://api.github.com/repos/owncloud/ios-app/pulls/64/comments"},"review_comment":{"href":"https://api.github.com/repos/owncloud/ios-app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/owncloud/ios-app/pulls/64/commits"},"statuses":{"href":"https://api.github.com/repos/owncloud/ios-app/statuses/a0c21e77508ddce55c0f5343caf49f835f4bd257"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"pablocarmu"}}