{"action":"created","issue":{"url":"https://api.github.com/repos/lingui/js-lingui/issues/289","repository_url":"https://api.github.com/repos/lingui/js-lingui","labels_url":"https://api.github.com/repos/lingui/js-lingui/issues/289/labels{/name}","comments_url":"https://api.github.com/repos/lingui/js-lingui/issues/289/comments","events_url":"https://api.github.com/repos/lingui/js-lingui/issues/289/events","html_url":"https://github.com/lingui/js-lingui/issues/289","id":354092880,"node_id":"MDU6SXNzdWUzNTQwOTI4ODA=","number":289,"title":"Wrong handling of custom comments in PO catalog while extracting","user":{"login":"FredyC","id":1096340,"node_id":"MDQ6VXNlcjEwOTYzNDA=","avatar_url":"https://avatars0.githubusercontent.com/u/1096340?v=4","gravatar_id":"","url":"https://api.github.com/users/FredyC","html_url":"https://github.com/FredyC","followers_url":"https://api.github.com/users/FredyC/followers","following_url":"https://api.github.com/users/FredyC/following{/other_user}","gists_url":"https://api.github.com/users/FredyC/gists{/gist_id}","starred_url":"https://api.github.com/users/FredyC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FredyC/subscriptions","organizations_url":"https://api.github.com/users/FredyC/orgs","repos_url":"https://api.github.com/users/FredyC/repos","events_url":"https://api.github.com/users/FredyC/events{/privacy}","received_events_url":"https://api.github.com/users/FredyC/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-26T12:56:46Z","updated_at":"2018-08-26T13:32:02Z","closed_at":"2018-08-26T13:32:02Z","author_association":"CONTRIBUTOR","body":"**Describe the bug**\r\nWhen editing PO catalog in some tool that adds it's own comments and then running `extract` again, these comments are lost and furthermore, some of them end up badly formatted and make an invalid PO file.\r\n\r\n```po\r\n#: src/segments/login/organisms/PasswordLoginForm.tsx:25\r\n#: loco:5b7d94e07ec8ae083b2dae02\r\nmsgid \"username\"\r\nmsgstr \"username\"\r\n```\r\n\r\nAfter extracting that comment is lost. Furthermore, for obsolete translation, it ends up like this.\r\n\r\n```po\r\n#: src/segments/login/organisms/PasswordLoginForm.tsx:24\r\nloco:5b7d94e07ec8ae083b2dae01\r\n#, obsolete\r\nmsgid \"login.validation.username-missing\"\r\nmsgstr \"\"\r\n```\r\n\r\n**Expected behavior**\r\nTo keep any custom comments intact and do not break when obsolete translation is encountered.\r\n\r\n**Additional context**\r\n- jsLingui version: 2.5.0\r\n"},"comment":{"url":"https://api.github.com/repos/lingui/js-lingui/issues/comments/416039203","html_url":"https://github.com/lingui/js-lingui/issues/289#issuecomment-416039203","issue_url":"https://api.github.com/repos/lingui/js-lingui/issues/289","id":416039203,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNjAzOTIwMw==","user":{"login":"FredyC","id":1096340,"node_id":"MDQ6VXNlcjEwOTYzNDA=","avatar_url":"https://avatars0.githubusercontent.com/u/1096340?v=4","gravatar_id":"","url":"https://api.github.com/users/FredyC","html_url":"https://github.com/FredyC","followers_url":"https://api.github.com/users/FredyC/followers","following_url":"https://api.github.com/users/FredyC/following{/other_user}","gists_url":"https://api.github.com/users/FredyC/gists{/gist_id}","starred_url":"https://api.github.com/users/FredyC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FredyC/subscriptions","organizations_url":"https://api.github.com/users/FredyC/orgs","repos_url":"https://api.github.com/users/FredyC/repos","events_url":"https://api.github.com/users/FredyC/events{/privacy}","received_events_url":"https://api.github.com/users/FredyC/received_events","type":"User","site_admin":false},"created_at":"2018-08-26T13:32:02Z","updated_at":"2018-08-26T13:32:02Z","author_association":"CONTRIBUTOR","body":"Ok, nevermind. This is actually an issue in the format produced by the service. I wasn't aware there is some difference in a notation of leading `#:` vs `#.` I suppose I will have to handle that as part of the workflow process when communicating with that service. I doubt they will change this."}}
{"actor":{"display_login":"FredyC"}}