{"action":"closed","number":85,"pull_request":{"url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/pulls/85","id":141672900,"node_id":"MDExOlB1bGxSZXF1ZXN0MTQxNjcyOTAw","html_url":"https://github.com/FriendsOfCake/cakephp-csvview/pull/85","diff_url":"https://github.com/FriendsOfCake/cakephp-csvview/pull/85.diff","patch_url":"https://github.com/FriendsOfCake/cakephp-csvview/pull/85.patch","issue_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/issues/85","number":85,"state":"closed","locked":false,"title":"Add BOM handling for all platforms","user":{"login":"DIDoS","id":5557268,"node_id":"MDQ6VXNlcjU1NTcyNjg=","avatar_url":"https://avatars2.githubusercontent.com/u/5557268?v=4","gravatar_id":"","url":"https://api.github.com/users/DIDoS","html_url":"https://github.com/DIDoS","followers_url":"https://api.github.com/users/DIDoS/followers","following_url":"https://api.github.com/users/DIDoS/following{/other_user}","gists_url":"https://api.github.com/users/DIDoS/gists{/gist_id}","starred_url":"https://api.github.com/users/DIDoS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DIDoS/subscriptions","organizations_url":"https://api.github.com/users/DIDoS/orgs","repos_url":"https://api.github.com/users/DIDoS/repos","events_url":"https://api.github.com/users/DIDoS/events{/privacy}","received_events_url":"https://api.github.com/users/DIDoS/received_events","type":"User","site_admin":false},"body":"iconv doesn't add a BOM in all cases (especially when endianess is given e.g. `iconv(\"UTF-8\",\"UTF-16LE\",\"a\")`). So I had to add a mapping (from http://unicode.org/faq/utf_bom.html#bom3) and prepend the BOM manually.\r\n\r\nAlso added a test that shows the behavior.","created_at":"2017-09-18T18:33:27Z","updated_at":"2018-08-15T12:35:43Z","closed_at":"2018-08-15T12:35:43Z","merged_at":"2018-08-15T12:35:43Z","merge_commit_sha":"d3aeb51d05c9f7869b9c9712aad2a1bc6bce3cad","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/pulls/85/commits","review_comments_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/pulls/85/comments","review_comment_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/issues/85/comments","statuses_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/statuses/8e3b67fa06688f8ba60efcfbddf5cb03554785f0","head":{"label":"otoso:master","ref":"master","sha":"8e3b67fa06688f8ba60efcfbddf5cb03554785f0","user":{"login":"otoso","id":14308386,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzA4Mzg2","avatar_url":"https://avatars3.githubusercontent.com/u/14308386?v=4","gravatar_id":"","url":"https://api.github.com/users/otoso","html_url":"https://github.com/otoso","followers_url":"https://api.github.com/users/otoso/followers","following_url":"https://api.github.com/users/otoso/following{/other_user}","gists_url":"https://api.github.com/users/otoso/gists{/gist_id}","starred_url":"https://api.github.com/users/otoso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otoso/subscriptions","organizations_url":"https://api.github.com/users/otoso/orgs","repos_url":"https://api.github.com/users/otoso/repos","events_url":"https://api.github.com/users/otoso/events{/privacy}","received_events_url":"https://api.github.com/users/otoso/received_events","type":"Organization","site_admin":false},"repo":{"id":103974965,"node_id":"MDEwOlJlcG9zaXRvcnkxMDM5NzQ5NjU=","name":"cakephp-csvview","full_name":"otoso/cakephp-csvview","owner":{"login":"otoso","id":14308386,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzA4Mzg2","avatar_url":"https://avatars3.githubusercontent.com/u/14308386?v=4","gravatar_id":"","url":"https://api.github.com/users/otoso","html_url":"https://github.com/otoso","followers_url":"https://api.github.com/users/otoso/followers","following_url":"https://api.github.com/users/otoso/following{/other_user}","gists_url":"https://api.github.com/users/otoso/gists{/gist_id}","starred_url":"https://api.github.com/users/otoso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otoso/subscriptions","organizations_url":"https://api.github.com/users/otoso/orgs","repos_url":"https://api.github.com/users/otoso/repos","events_url":"https://api.github.com/users/otoso/events{/privacy}","received_events_url":"https://api.github.com/users/otoso/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/otoso/cakephp-csvview","description":"CakePHP3: A view class for generating CSV","fork":true,"url":"https://api.github.com/repos/otoso/cakephp-csvview","forks_url":"https://api.github.com/repos/otoso/cakephp-csvview/forks","keys_url":"https://api.github.com/repos/otoso/cakephp-csvview/keys{/key_id}","collaborators_url":"https://api.github.com/repos/otoso/cakephp-csvview/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/otoso/cakephp-csvview/teams","hooks_url":"https://api.github.com/repos/otoso/cakephp-csvview/hooks","issue_events_url":"https://api.github.com/repos/otoso/cakephp-csvview/issues/events{/number}","events_url":"https://api.github.com/repos/otoso/cakephp-csvview/events","assignees_url":"https://api.github.com/repos/otoso/cakephp-csvview/assignees{/user}","branches_url":"https://api.github.com/repos/otoso/cakephp-csvview/branches{/branch}","tags_url":"https://api.github.com/repos/otoso/cakephp-csvview/tags","blobs_url":"https://api.github.com/repos/otoso/cakephp-csvview/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/otoso/cakephp-csvview/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/otoso/cakephp-csvview/git/refs{/sha}","trees_url":"https://api.github.com/repos/otoso/cakephp-csvview/git/trees{/sha}","statuses_url":"https://api.github.com/repos/otoso/cakephp-csvview/statuses/{sha}","languages_url":"https://api.github.com/repos/otoso/cakephp-csvview/languages","stargazers_url":"https://api.github.com/repos/otoso/cakephp-csvview/stargazers","contributors_url":"https://api.github.com/repos/otoso/cakephp-csvview/contributors","subscribers_url":"https://api.github.com/repos/otoso/cakephp-csvview/subscribers","subscription_url":"https://api.github.com/repos/otoso/cakephp-csvview/subscription","commits_url":"https://api.github.com/repos/otoso/cakephp-csvview/commits{/sha}","git_commits_url":"https://api.github.com/repos/otoso/cakephp-csvview/git/commits{/sha}","comments_url":"https://api.github.com/repos/otoso/cakephp-csvview/comments{/number}","issue_comment_url":"https://api.github.com/repos/otoso/cakephp-csvview/issues/comments{/number}","contents_url":"https://api.github.com/repos/otoso/cakephp-csvview/contents/{+path}","compare_url":"https://api.github.com/repos/otoso/cakephp-csvview/compare/{base}...{head}","merges_url":"https://api.github.com/repos/otoso/cakephp-csvview/merges","archive_url":"https://api.github.com/repos/otoso/cakephp-csvview/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/otoso/cakephp-csvview/downloads","issues_url":"https://api.github.com/repos/otoso/cakephp-csvview/issues{/number}","pulls_url":"https://api.github.com/repos/otoso/cakephp-csvview/pulls{/number}","milestones_url":"https://api.github.com/repos/otoso/cakephp-csvview/milestones{/number}","notifications_url":"https://api.github.com/repos/otoso/cakephp-csvview/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/otoso/cakephp-csvview/labels{/name}","releases_url":"https://api.github.com/repos/otoso/cakephp-csvview/releases{/id}","deployments_url":"https://api.github.com/repos/otoso/cakephp-csvview/deployments","created_at":"2017-09-18T18:16:10Z","updated_at":"2018-08-15T12:29:05Z","pushed_at":"2018-08-15T12:29:03Z","git_url":"git://github.com/otoso/cakephp-csvview.git","ssh_url":"git@github.com:otoso/cakephp-csvview.git","clone_url":"https://github.com/otoso/cakephp-csvview.git","svn_url":"https://github.com/otoso/cakephp-csvview","homepage":"","size":159,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FriendsOfCake:master","ref":"master","sha":"e86d9ddbfd382c19bfee679237a44611019afbcf","user":{"login":"FriendsOfCake","id":5203126,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyMDMxMjY=","avatar_url":"https://avatars0.githubusercontent.com/u/5203126?v=4","gravatar_id":"","url":"https://api.github.com/users/FriendsOfCake","html_url":"https://github.com/FriendsOfCake","followers_url":"https://api.github.com/users/FriendsOfCake/followers","following_url":"https://api.github.com/users/FriendsOfCake/following{/other_user}","gists_url":"https://api.github.com/users/FriendsOfCake/gists{/gist_id}","starred_url":"https://api.github.com/users/FriendsOfCake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FriendsOfCake/subscriptions","organizations_url":"https://api.github.com/users/FriendsOfCake/orgs","repos_url":"https://api.github.com/users/FriendsOfCake/repos","events_url":"https://api.github.com/users/FriendsOfCake/events{/privacy}","received_events_url":"https://api.github.com/users/FriendsOfCake/received_events","type":"Organization","site_admin":false},"repo":{"id":5823079,"node_id":"MDEwOlJlcG9zaXRvcnk1ODIzMDc5","name":"cakephp-csvview","full_name":"FriendsOfCake/cakephp-csvview","owner":{"login":"FriendsOfCake","id":5203126,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyMDMxMjY=","avatar_url":"https://avatars0.githubusercontent.com/u/5203126?v=4","gravatar_id":"","url":"https://api.github.com/users/FriendsOfCake","html_url":"https://github.com/FriendsOfCake","followers_url":"https://api.github.com/users/FriendsOfCake/followers","following_url":"https://api.github.com/users/FriendsOfCake/following{/other_user}","gists_url":"https://api.github.com/users/FriendsOfCake/gists{/gist_id}","starred_url":"https://api.github.com/users/FriendsOfCake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FriendsOfCake/subscriptions","organizations_url":"https://api.github.com/users/FriendsOfCake/orgs","repos_url":"https://api.github.com/users/FriendsOfCake/repos","events_url":"https://api.github.com/users/FriendsOfCake/events{/privacy}","received_events_url":"https://api.github.com/users/FriendsOfCake/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FriendsOfCake/cakephp-csvview","description":"CakePHP3: A view class for generating CSV","fork":false,"url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview","forks_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/forks","keys_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/teams","hooks_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/hooks","issue_events_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/issues/events{/number}","events_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/events","assignees_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/assignees{/user}","branches_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/branches{/branch}","tags_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/tags","blobs_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/git/refs{/sha}","trees_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/statuses/{sha}","languages_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/languages","stargazers_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/stargazers","contributors_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/contributors","subscribers_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/subscribers","subscription_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/subscription","commits_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/commits{/sha}","git_commits_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/git/commits{/sha}","comments_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/comments{/number}","issue_comment_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/issues/comments{/number}","contents_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/contents/{+path}","compare_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/merges","archive_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/downloads","issues_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/issues{/number}","pulls_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/pulls{/number}","milestones_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/milestones{/number}","notifications_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/labels{/name}","releases_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/releases{/id}","deployments_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/deployments","created_at":"2012-09-15T18:54:32Z","updated_at":"2018-08-15T12:15:45Z","pushed_at":"2018-08-15T12:35:43Z","git_url":"git://github.com/FriendsOfCake/cakephp-csvview.git","ssh_url":"git@github.com:FriendsOfCake/cakephp-csvview.git","clone_url":"https://github.com/FriendsOfCake/cakephp-csvview.git","svn_url":"https://github.com/FriendsOfCake/cakephp-csvview","homepage":"","size":189,"stargazers_count":137,"watchers_count":137,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":58,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":58,"open_issues":3,"watchers":137,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/pulls/85"},"html":{"href":"https://github.com/FriendsOfCake/cakephp-csvview/pull/85"},"issue":{"href":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/issues/85"},"comments":{"href":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/issues/85/comments"},"review_comments":{"href":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/pulls/85/comments"},"review_comment":{"href":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/pulls/85/commits"},"statuses":{"href":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/statuses/8e3b67fa06688f8ba60efcfbddf5cb03554785f0"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"dereuromark","id":39854,"node_id":"MDQ6VXNlcjM5ODU0","avatar_url":"https://avatars0.githubusercontent.com/u/39854?v=4","gravatar_id":"","url":"https://api.github.com/users/dereuromark","html_url":"https://github.com/dereuromark","followers_url":"https://api.github.com/users/dereuromark/followers","following_url":"https://api.github.com/users/dereuromark/following{/other_user}","gists_url":"https://api.github.com/users/dereuromark/gists{/gist_id}","starred_url":"https://api.github.com/users/dereuromark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dereuromark/subscriptions","organizations_url":"https://api.github.com/users/dereuromark/orgs","repos_url":"https://api.github.com/users/dereuromark/repos","events_url":"https://api.github.com/users/dereuromark/events{/privacy}","received_events_url":"https://api.github.com/users/dereuromark/received_events","type":"User","site_admin":false},"comments":7,"review_comments":7,"maintainer_can_modify":false,"commits":7,"additions":54,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"dereuromark"}}