{"action":"created","issue":{"url":"https://api.github.com/repos/supercollider/supercollider/issues/3985","repository_url":"https://api.github.com/repos/supercollider/supercollider","labels_url":"https://api.github.com/repos/supercollider/supercollider/issues/3985/labels{/name}","comments_url":"https://api.github.com/repos/supercollider/supercollider/issues/3985/comments","events_url":"https://api.github.com/repos/supercollider/supercollider/issues/3985/events","html_url":"https://github.com/supercollider/supercollider/pull/3985","id":350266131,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MTU4MDM4","number":3985,"title":"cmake: run macdeployqt on qtwebengineprocess binary as well","user":{"login":"brianlheim","id":15369640,"node_id":"MDQ6VXNlcjE1MzY5NjQw","avatar_url":"https://avatars3.githubusercontent.com/u/15369640?v=4","gravatar_id":"","url":"https://api.github.com/users/brianlheim","html_url":"https://github.com/brianlheim","followers_url":"https://api.github.com/users/brianlheim/followers","following_url":"https://api.github.com/users/brianlheim/following{/other_user}","gists_url":"https://api.github.com/users/brianlheim/gists{/gist_id}","starred_url":"https://api.github.com/users/brianlheim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianlheim/subscriptions","organizations_url":"https://api.github.com/users/brianlheim/orgs","repos_url":"https://api.github.com/users/brianlheim/repos","events_url":"https://api.github.com/users/brianlheim/events{/privacy}","received_events_url":"https://api.github.com/users/brianlheim/received_events","type":"User","site_admin":false},"labels":[{"id":187327633,"node_id":"MDU6TGFiZWwxODczMjc2MzM=","url":"https://api.github.com/repos/supercollider/supercollider/labels/comp:%20build","name":"comp: build","color":"CFFF7D","default":false},{"id":4477101,"node_id":"MDU6TGFiZWw0NDc3MTAx","url":"https://api.github.com/repos/supercollider/supercollider/labels/os:%20macOS","name":"os: macOS","color":"D8BAFF","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-08-14T03:14:08Z","updated_at":"2018-08-15T02:53:28Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/supercollider/supercollider/pulls/3985","html_url":"https://github.com/supercollider/supercollider/pull/3985","diff_url":"https://github.com/supercollider/supercollider/pull/3985.diff","patch_url":"https://github.com/supercollider/supercollider/pull/3985.patch"},"body":"Purpose and Motivation\r\n----------------------\r\n\r\nFixes #3971 by making sure macdeployqt is run on the QtWebEngineProcess binary.\r\n\r\nI am not sure if a similar change needs to be applied on Windows.\r\n\r\nFor the record, a way to reproduce #3971 is by simply renaming the directory containing the Qt libs found by CMake after the build is complete.\r\n\r\nTypes of changes\r\n----------------\r\n\r\n- Bug fix (non-breaking change which fixes an issue)\r\n\r\nChecklist\r\n---------\r\n\r\n- [x] This PR is ready for review\r\n\r\n<!--- Remaining Work -->\r\n<!--- ------------- -->\r\n\r\n<!--- If any work remains to be done, please give a brief description here. -->\r\n<!--- Consider providing a todo-list so we can easily track completion progress. -->\r\n\r\n<!--- Thanks again! -->\r\n"},"comment":{"url":"https://api.github.com/repos/supercollider/supercollider/issues/comments/413078828","html_url":"https://github.com/supercollider/supercollider/pull/3985#issuecomment-413078828","issue_url":"https://api.github.com/repos/supercollider/supercollider/issues/3985","id":413078828,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzA3ODgyOA==","user":{"login":"prko","id":416281,"node_id":"MDQ6VXNlcjQxNjI4MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/416281?v=4","gravatar_id":"","url":"https://api.github.com/users/prko","html_url":"https://github.com/prko","followers_url":"https://api.github.com/users/prko/followers","following_url":"https://api.github.com/users/prko/following{/other_user}","gists_url":"https://api.github.com/users/prko/gists{/gist_id}","starred_url":"https://api.github.com/users/prko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prko/subscriptions","organizations_url":"https://api.github.com/users/prko/orgs","repos_url":"https://api.github.com/users/prko/repos","events_url":"https://api.github.com/users/prko/events{/privacy}","received_events_url":"https://api.github.com/users/prko/received_events","type":"User","site_admin":false},"created_at":"2018-08-15T02:53:28Z","updated_at":"2018-08-15T02:53:28Z","author_association":"CONTRIBUTOR","body":"`prko-MBP:~ prko$ otool -L Install/Users/prko/Dropbox/supercollider/SuperCollider_/SuperCollider.app/Contents/Frameworks/QtWebEngineCore.framework/Helpers/QtWebEngineProcess.app/Contents/MacOS/QtWebEngineProcess`\r\n\r\nreturns\r\n\r\n> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/objdump: 'Install/Users/prko/Dropbox/supercollider/SuperCollider_/SuperCollider.app/Contents/Frameworks/QtWebEngineCore.framework/Helpers/QtWebEngineProcess.app/Contents/MacOS/QtWebEngineProcess': No such file or directory\r\n\r\n\r\nI tried to compile SC using git desktop under high sierra, but an error occurs:\r\n\r\n> prko-MBP:build prko$ cmake -G Xcode -DCMAKE_PREFIX_PATH=`brew --prefix qt5` -DSUPERNOVA=ON ..\r\n> CMake Warning (dev) at CMakeLists.txt:1 (project):\r\n>   Policy CMP0048 is not set: project() command manages VERSION variables.\r\n>   Run \"cmake --help-policy CMP0048\" for policy details.  Use the cmake_policy\r\n>   command to set the policy and suppress this warning.\r\n> \r\n>   The following variable(s) would be set to empty:\r\n> \r\n>     CMAKE_PROJECT_VERSION\r\n>     CMAKE_PROJECT_VERSION_MAJOR\r\n>     CMAKE_PROJECT_VERSION_MINOR\r\n>     CMAKE_PROJECT_VERSION_PATCH\r\n> This warning is for project developers.  Use -Wno-dev to suppress it.\r\n> \r\n> -- SuperCollider Version: 3.10.0-beta1\r\n> -- Building from branch develop, commit hash is 88621c5\r\n> -- Please specify the build configuration in the next step\r\n> -- Compiling with Qt GUI\r\n> -- building boost libraries manually\r\n> -- using bundled libyaml-cpp\r\n> -- HIDAPI components:\r\n> --     mac\r\n> --     hidapi_parser\r\n> -- Building with HID support\r\n> -- Audio API: coreaudio\r\n> -- Could NOT find PkgConfig (missing: PKG_CONFIG_EXECUTABLE) \r\n> CMake Error at server/supernova/CMakeLists.txt:110 (message):\r\n>   Portaudio missing\r\n> \r\n> \r\n> -- Configuring incomplete, errors occurred!\r\n> See also \"/Users/prko/SuperCollider/build/CMakeFiles/CMakeOutput.log\".\r\n"}}
{"actor":{"display_login":"prko"}}