{"action":"closed","number":252,"pull_request":{"url":"https://api.github.com/repos/w3c/web-roadmaps/pulls/252","id":185671299,"html_url":"https://github.com/w3c/web-roadmaps/pull/252","diff_url":"https://github.com/w3c/web-roadmaps/pull/252.diff","patch_url":"https://github.com/w3c/web-roadmaps/pull/252.patch","issue_url":"https://api.github.com/repos/w3c/web-roadmaps/issues/252","number":252,"state":"closed","locked":false,"title":"[Framework] Localize date strings in pages","user":{"login":"tidoust","id":1122927,"avatar_url":"https://avatars2.githubusercontent.com/u/1122927?v=4","gravatar_id":"","url":"https://api.github.com/users/tidoust","html_url":"https://github.com/tidoust","followers_url":"https://api.github.com/users/tidoust/followers","following_url":"https://api.github.com/users/tidoust/following{/other_user}","gists_url":"https://api.github.com/users/tidoust/gists{/gist_id}","starred_url":"https://api.github.com/users/tidoust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tidoust/subscriptions","organizations_url":"https://api.github.com/users/tidoust/orgs","repos_url":"https://api.github.com/users/tidoust/repos","events_url":"https://api.github.com/users/tidoust/events{/privacy}","received_events_url":"https://api.github.com/users/tidoust/received_events","type":"User","site_admin":false},"body":"Last modified dates and publication dates were always formatted in English. They should now be formatted according to the language of the page.\r\n\r\nUnder the hoods, the `toLocaleDateString` method gets used to format the date. Note browsers may only support a subset of locale settings in practice (and may for instance only support locale settings that are actually local to the user), so that mechanism may not always work.\r\n\r\nIn particular, JSDOM, used to generate all roadmap pages in batch, does not seem to support Chinese, so rules for Chinese are hardcoded if JSDOM is detected.\r\n\r\nThis commit is a fix for:\r\nhttps://github.com/w3c/web-roadmaps/issues/213#issuecomment-386197580","created_at":"2018-05-03T10:15:30Z","updated_at":"2018-05-03T11:54:37Z","closed_at":"2018-05-03T11:54:36Z","merged_at":"2018-05-03T11:54:36Z","merge_commit_sha":"a4609dacd2ad23f6fdeffa275b1276b747d306d0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"xfq","id":2863444,"avatar_url":"https://avatars2.githubusercontent.com/u/2863444?v=4","gravatar_id":"","url":"https://api.github.com/users/xfq","html_url":"https://github.com/xfq","followers_url":"https://api.github.com/users/xfq/followers","following_url":"https://api.github.com/users/xfq/following{/other_user}","gists_url":"https://api.github.com/users/xfq/gists{/gist_id}","starred_url":"https://api.github.com/users/xfq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xfq/subscriptions","organizations_url":"https://api.github.com/users/xfq/orgs","repos_url":"https://api.github.com/users/xfq/repos","events_url":"https://api.github.com/users/xfq/events{/privacy}","received_events_url":"https://api.github.com/users/xfq/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":736688697,"url":"https://api.github.com/repos/w3c/web-roadmaps/labels/framework","name":"framework","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/w3c/web-roadmaps/pulls/252/commits","review_comments_url":"https://api.github.com/repos/w3c/web-roadmaps/pulls/252/comments","review_comment_url":"https://api.github.com/repos/w3c/web-roadmaps/pulls/comments{/number}","comments_url":"https://api.github.com/repos/w3c/web-roadmaps/issues/252/comments","statuses_url":"https://api.github.com/repos/w3c/web-roadmaps/statuses/8ad3762c929b924c56f6f25c66f1d24db63c81fb","head":{"label":"tidoust:framework-localizedates","ref":"framework-localizedates","sha":"8ad3762c929b924c56f6f25c66f1d24db63c81fb","user":{"login":"tidoust","id":1122927,"avatar_url":"https://avatars2.githubusercontent.com/u/1122927?v=4","gravatar_id":"","url":"https://api.github.com/users/tidoust","html_url":"https://github.com/tidoust","followers_url":"https://api.github.com/users/tidoust/followers","following_url":"https://api.github.com/users/tidoust/following{/other_user}","gists_url":"https://api.github.com/users/tidoust/gists{/gist_id}","starred_url":"https://api.github.com/users/tidoust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tidoust/subscriptions","organizations_url":"https://api.github.com/users/tidoust/orgs","repos_url":"https://api.github.com/users/tidoust/repos","events_url":"https://api.github.com/users/tidoust/events{/privacy}","received_events_url":"https://api.github.com/users/tidoust/received_events","type":"User","site_admin":false},"repo":{"id":68184568,"name":"media-web-roadmap","full_name":"tidoust/media-web-roadmap","owner":{"login":"tidoust","id":1122927,"avatar_url":"https://avatars2.githubusercontent.com/u/1122927?v=4","gravatar_id":"","url":"https://api.github.com/users/tidoust","html_url":"https://github.com/tidoust","followers_url":"https://api.github.com/users/tidoust/followers","following_url":"https://api.github.com/users/tidoust/following{/other_user}","gists_url":"https://api.github.com/users/tidoust/gists{/gist_id}","starred_url":"https://api.github.com/users/tidoust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tidoust/subscriptions","organizations_url":"https://api.github.com/users/tidoust/orgs","repos_url":"https://api.github.com/users/tidoust/repos","events_url":"https://api.github.com/users/tidoust/events{/privacy}","received_events_url":"https://api.github.com/users/tidoust/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tidoust/media-web-roadmap","description":"Framework for Web technology roadmaps","fork":true,"url":"https://api.github.com/repos/tidoust/media-web-roadmap","forks_url":"https://api.github.com/repos/tidoust/media-web-roadmap/forks","keys_url":"https://api.github.com/repos/tidoust/media-web-roadmap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tidoust/media-web-roadmap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tidoust/media-web-roadmap/teams","hooks_url":"https://api.github.com/repos/tidoust/media-web-roadmap/hooks","issue_events_url":"https://api.github.com/repos/tidoust/media-web-roadmap/issues/events{/number}","events_url":"https://api.github.com/repos/tidoust/media-web-roadmap/events","assignees_url":"https://api.github.com/repos/tidoust/media-web-roadmap/assignees{/user}","branches_url":"https://api.github.com/repos/tidoust/media-web-roadmap/branches{/branch}","tags_url":"https://api.github.com/repos/tidoust/media-web-roadmap/tags","blobs_url":"https://api.github.com/repos/tidoust/media-web-roadmap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tidoust/media-web-roadmap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tidoust/media-web-roadmap/git/refs{/sha}","trees_url":"https://api.github.com/repos/tidoust/media-web-roadmap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tidoust/media-web-roadmap/statuses/{sha}","languages_url":"https://api.github.com/repos/tidoust/media-web-roadmap/languages","stargazers_url":"https://api.github.com/repos/tidoust/media-web-roadmap/stargazers","contributors_url":"https://api.github.com/repos/tidoust/media-web-roadmap/contributors","subscribers_url":"https://api.github.com/repos/tidoust/media-web-roadmap/subscribers","subscription_url":"https://api.github.com/repos/tidoust/media-web-roadmap/subscription","commits_url":"https://api.github.com/repos/tidoust/media-web-roadmap/commits{/sha}","git_commits_url":"https://api.github.com/repos/tidoust/media-web-roadmap/git/commits{/sha}","comments_url":"https://api.github.com/repos/tidoust/media-web-roadmap/comments{/number}","issue_comment_url":"https://api.github.com/repos/tidoust/media-web-roadmap/issues/comments{/number}","contents_url":"https://api.github.com/repos/tidoust/media-web-roadmap/contents/{+path}","compare_url":"https://api.github.com/repos/tidoust/media-web-roadmap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tidoust/media-web-roadmap/merges","archive_url":"https://api.github.com/repos/tidoust/media-web-roadmap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tidoust/media-web-roadmap/downloads","issues_url":"https://api.github.com/repos/tidoust/media-web-roadmap/issues{/number}","pulls_url":"https://api.github.com/repos/tidoust/media-web-roadmap/pulls{/number}","milestones_url":"https://api.github.com/repos/tidoust/media-web-roadmap/milestones{/number}","notifications_url":"https://api.github.com/repos/tidoust/media-web-roadmap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tidoust/media-web-roadmap/labels{/name}","releases_url":"https://api.github.com/repos/tidoust/media-web-roadmap/releases{/id}","deployments_url":"https://api.github.com/repos/tidoust/media-web-roadmap/deployments","created_at":"2016-09-14T07:38:12Z","updated_at":"2018-04-26T09:53:50Z","pushed_at":"2018-05-03T10:14:43Z","git_url":"git://github.com/tidoust/media-web-roadmap.git","ssh_url":"git@github.com:tidoust/media-web-roadmap.git","clone_url":"https://github.com/tidoust/media-web-roadmap.git","svn_url":"https://github.com/tidoust/media-web-roadmap","homepage":"https://w3c.github.io/media-web-roadmap/media/","size":1386,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"w3c:master","ref":"master","sha":"dabda71e63c133cf695ac0420628bdfdeda2ac3e","user":{"login":"w3c","id":379216,"avatar_url":"https://avatars2.githubusercontent.com/u/379216?v=4","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"repo":{"id":38767094,"name":"web-roadmaps","full_name":"w3c/web-roadmaps","owner":{"login":"w3c","id":379216,"avatar_url":"https://avatars2.githubusercontent.com/u/379216?v=4","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/w3c/web-roadmaps","description":"Framework for Web technology roadmaps","fork":false,"url":"https://api.github.com/repos/w3c/web-roadmaps","forks_url":"https://api.github.com/repos/w3c/web-roadmaps/forks","keys_url":"https://api.github.com/repos/w3c/web-roadmaps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w3c/web-roadmaps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w3c/web-roadmaps/teams","hooks_url":"https://api.github.com/repos/w3c/web-roadmaps/hooks","issue_events_url":"https://api.github.com/repos/w3c/web-roadmaps/issues/events{/number}","events_url":"https://api.github.com/repos/w3c/web-roadmaps/events","assignees_url":"https://api.github.com/repos/w3c/web-roadmaps/assignees{/user}","branches_url":"https://api.github.com/repos/w3c/web-roadmaps/branches{/branch}","tags_url":"https://api.github.com/repos/w3c/web-roadmaps/tags","blobs_url":"https://api.github.com/repos/w3c/web-roadmaps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w3c/web-roadmaps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w3c/web-roadmaps/git/refs{/sha}","trees_url":"https://api.github.com/repos/w3c/web-roadmaps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w3c/web-roadmaps/statuses/{sha}","languages_url":"https://api.github.com/repos/w3c/web-roadmaps/languages","stargazers_url":"https://api.github.com/repos/w3c/web-roadmaps/stargazers","contributors_url":"https://api.github.com/repos/w3c/web-roadmaps/contributors","subscribers_url":"https://api.github.com/repos/w3c/web-roadmaps/subscribers","subscription_url":"https://api.github.com/repos/w3c/web-roadmaps/subscription","commits_url":"https://api.github.com/repos/w3c/web-roadmaps/commits{/sha}","git_commits_url":"https://api.github.com/repos/w3c/web-roadmaps/git/commits{/sha}","comments_url":"https://api.github.com/repos/w3c/web-roadmaps/comments{/number}","issue_comment_url":"https://api.github.com/repos/w3c/web-roadmaps/issues/comments{/number}","contents_url":"https://api.github.com/repos/w3c/web-roadmaps/contents/{+path}","compare_url":"https://api.github.com/repos/w3c/web-roadmaps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w3c/web-roadmaps/merges","archive_url":"https://api.github.com/repos/w3c/web-roadmaps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w3c/web-roadmaps/downloads","issues_url":"https://api.github.com/repos/w3c/web-roadmaps/issues{/number}","pulls_url":"https://api.github.com/repos/w3c/web-roadmaps/pulls{/number}","milestones_url":"https://api.github.com/repos/w3c/web-roadmaps/milestones{/number}","notifications_url":"https://api.github.com/repos/w3c/web-roadmaps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w3c/web-roadmaps/labels{/name}","releases_url":"https://api.github.com/repos/w3c/web-roadmaps/releases{/id}","deployments_url":"https://api.github.com/repos/w3c/web-roadmaps/deployments","created_at":"2015-07-08T16:46:37Z","updated_at":"2018-05-03T08:52:13Z","pushed_at":"2018-05-03T11:54:36Z","git_url":"git://github.com/w3c/web-roadmaps.git","ssh_url":"git@github.com:w3c/web-roadmaps.git","clone_url":"https://github.com/w3c/web-roadmaps.git","svn_url":"https://github.com/w3c/web-roadmaps","homepage":"https://w3c.github.io/web-roadmaps/","size":2304,"stargazers_count":46,"watchers_count":46,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":26,"license":null,"forks":18,"open_issues":26,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/w3c/web-roadmaps/pulls/252"},"html":{"href":"https://github.com/w3c/web-roadmaps/pull/252"},"issue":{"href":"https://api.github.com/repos/w3c/web-roadmaps/issues/252"},"comments":{"href":"https://api.github.com/repos/w3c/web-roadmaps/issues/252/comments"},"review_comments":{"href":"https://api.github.com/repos/w3c/web-roadmaps/pulls/252/comments"},"review_comment":{"href":"https://api.github.com/repos/w3c/web-roadmaps/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/w3c/web-roadmaps/pulls/252/commits"},"statuses":{"href":"https://api.github.com/repos/w3c/web-roadmaps/statuses/8ad3762c929b924c56f6f25c66f1d24db63c81fb"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"xfq","id":2863444,"avatar_url":"https://avatars2.githubusercontent.com/u/2863444?v=4","gravatar_id":"","url":"https://api.github.com/users/xfq","html_url":"https://github.com/xfq","followers_url":"https://api.github.com/users/xfq/followers","following_url":"https://api.github.com/users/xfq/following{/other_user}","gists_url":"https://api.github.com/users/xfq/gists{/gist_id}","starred_url":"https://api.github.com/users/xfq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xfq/subscriptions","organizations_url":"https://api.github.com/users/xfq/orgs","repos_url":"https://api.github.com/users/xfq/repos","events_url":"https://api.github.com/users/xfq/events{/privacy}","received_events_url":"https://api.github.com/users/xfq/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":26,"deletions":6,"changed_files":1}}
{"actor":{"display_login":"xfq"}}