{"action":"created","comment":{"url":"https://api.github.com/repos/syscoin/syscoin-api/pulls/comments/178124507","pull_request_review_id":108132984,"id":178124507,"diff_hunk":"@@ -3561,108 +3557,50 @@ definitions:\n       message:\n         type: string\n   Alias:\n-    discriminator: name\n+    discriminator: _id\n     required:\n-      - name\n+      - _id\n     properties:\n-      name:\n+      _id:\n         type: string\n-      value:\n+      encryption_privatekey:\n         type: string\n-      privatevalue:\n+      encryption_publickey:\n         type: string\n-      password:\n+      publicvalue:\n         type: string\n       txid:\n         type: string\n-      address:\n-        type: string\n-      alias_peg:\n-        type: string\n-      balance:\n-        type: number\n-      ismine:","path":"swagger.yaml","position":52,"original_position":52,"commit_id":"fcf84605b05dd68dff4d214daa2e8435e9545e4d","original_commit_id":"fcf84605b05dd68dff4d214daa2e8435e9545e4d","user":{"login":"sidhujag","id":6238042,"avatar_url":"https://avatars3.githubusercontent.com/u/6238042?v=4","gravatar_id":"","url":"https://api.github.com/users/sidhujag","html_url":"https://github.com/sidhujag","followers_url":"https://api.github.com/users/sidhujag/followers","following_url":"https://api.github.com/users/sidhujag/following{/other_user}","gists_url":"https://api.github.com/users/sidhujag/gists{/gist_id}","starred_url":"https://api.github.com/users/sidhujag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sidhujag/subscriptions","organizations_url":"https://api.github.com/users/sidhujag/orgs","repos_url":"https://api.github.com/users/sidhujag/repos","events_url":"https://api.github.com/users/sidhujag/events{/privacy}","received_events_url":"https://api.github.com/users/sidhujag/received_events","type":"User","site_admin":false},"body":"is_mine is on the alias index table, we don't need that on the aliasinfo table","created_at":"2018-03-29T17:18:08Z","updated_at":"2018-03-29T17:18:08Z","html_url":"https://github.com/syscoin/syscoin-api/pull/18#discussion_r178124507","pull_request_url":"https://api.github.com/repos/syscoin/syscoin-api/pulls/18","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/syscoin/syscoin-api/pulls/comments/178124507"},"html":{"href":"https://github.com/syscoin/syscoin-api/pull/18#discussion_r178124507"},"pull_request":{"href":"https://api.github.com/repos/syscoin/syscoin-api/pulls/18"}},"in_reply_to_id":177924879},"pull_request":{"url":"https://api.github.com/repos/syscoin/syscoin-api/pulls/18","id":178133679,"html_url":"https://github.com/syscoin/syscoin-api/pull/18","diff_url":"https://github.com/syscoin/syscoin-api/pull/18.diff","patch_url":"https://github.com/syscoin/syscoin-api/pull/18.patch","issue_url":"https://api.github.com/repos/syscoin/syscoin-api/issues/18","number":18,"state":"open","locked":false,"title":"Update class sig","user":{"login":"quangogster","id":16714653,"avatar_url":"https://avatars1.githubusercontent.com/u/16714653?v=4","gravatar_id":"","url":"https://api.github.com/users/quangogster","html_url":"https://github.com/quangogster","followers_url":"https://api.github.com/users/quangogster/followers","following_url":"https://api.github.com/users/quangogster/following{/other_user}","gists_url":"https://api.github.com/users/quangogster/gists{/gist_id}","starred_url":"https://api.github.com/users/quangogster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quangogster/subscriptions","organizations_url":"https://api.github.com/users/quangogster/orgs","repos_url":"https://api.github.com/users/quangogster/repos","events_url":"https://api.github.com/users/quangogster/events{/privacy}","received_events_url":"https://api.github.com/users/quangogster/received_events","type":"User","site_admin":false},"body":"Updated Response Signature for:\r\n- Offer\r\n- Cert\r\n- Alias\r\n- Assets\r\n- AssetAllocation\r\n- EscrowBid\r\n- EscrowFeedback\r\n","created_at":"2018-03-28T19:05:39Z","updated_at":"2018-03-29T17:18:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ebfc0572dd5d694a6f4c0048611f49cb5f26c6a1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sidhujag","id":6238042,"avatar_url":"https://avatars3.githubusercontent.com/u/6238042?v=4","gravatar_id":"","url":"https://api.github.com/users/sidhujag","html_url":"https://github.com/sidhujag","followers_url":"https://api.github.com/users/sidhujag/followers","following_url":"https://api.github.com/users/sidhujag/following{/other_user}","gists_url":"https://api.github.com/users/sidhujag/gists{/gist_id}","starred_url":"https://api.github.com/users/sidhujag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sidhujag/subscriptions","organizations_url":"https://api.github.com/users/sidhujag/orgs","repos_url":"https://api.github.com/users/sidhujag/repos","events_url":"https://api.github.com/users/sidhujag/events{/privacy}","received_events_url":"https://api.github.com/users/sidhujag/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/syscoin/syscoin-api/pulls/18/commits","review_comments_url":"https://api.github.com/repos/syscoin/syscoin-api/pulls/18/comments","review_comment_url":"https://api.github.com/repos/syscoin/syscoin-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/syscoin/syscoin-api/issues/18/comments","statuses_url":"https://api.github.com/repos/syscoin/syscoin-api/statuses/fcf84605b05dd68dff4d214daa2e8435e9545e4d","head":{"label":"syscoin:update-class-sig","ref":"update-class-sig","sha":"fcf84605b05dd68dff4d214daa2e8435e9545e4d","user":{"login":"syscoin","id":6983571,"avatar_url":"https://avatars2.githubusercontent.com/u/6983571?v=4","gravatar_id":"","url":"https://api.github.com/users/syscoin","html_url":"https://github.com/syscoin","followers_url":"https://api.github.com/users/syscoin/followers","following_url":"https://api.github.com/users/syscoin/following{/other_user}","gists_url":"https://api.github.com/users/syscoin/gists{/gist_id}","starred_url":"https://api.github.com/users/syscoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syscoin/subscriptions","organizations_url":"https://api.github.com/users/syscoin/orgs","repos_url":"https://api.github.com/users/syscoin/repos","events_url":"https://api.github.com/users/syscoin/events{/privacy}","received_events_url":"https://api.github.com/users/syscoin/received_events","type":"Organization","site_admin":false},"repo":{"id":24008631,"name":"syscoin-api","full_name":"syscoin/syscoin-api","owner":{"login":"syscoin","id":6983571,"avatar_url":"https://avatars2.githubusercontent.com/u/6983571?v=4","gravatar_id":"","url":"https://api.github.com/users/syscoin","html_url":"https://github.com/syscoin","followers_url":"https://api.github.com/users/syscoin/followers","following_url":"https://api.github.com/users/syscoin/following{/other_user}","gists_url":"https://api.github.com/users/syscoin/gists{/gist_id}","starred_url":"https://api.github.com/users/syscoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syscoin/subscriptions","organizations_url":"https://api.github.com/users/syscoin/orgs","repos_url":"https://api.github.com/users/syscoin/repos","events_url":"https://api.github.com/users/syscoin/events{/privacy}","received_events_url":"https://api.github.com/users/syscoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/syscoin/syscoin-api","description":"Lightweight Syscoin API Server written in NodeJS.","fork":false,"url":"https://api.github.com/repos/syscoin/syscoin-api","forks_url":"https://api.github.com/repos/syscoin/syscoin-api/forks","keys_url":"https://api.github.com/repos/syscoin/syscoin-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/syscoin/syscoin-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/syscoin/syscoin-api/teams","hooks_url":"https://api.github.com/repos/syscoin/syscoin-api/hooks","issue_events_url":"https://api.github.com/repos/syscoin/syscoin-api/issues/events{/number}","events_url":"https://api.github.com/repos/syscoin/syscoin-api/events","assignees_url":"https://api.github.com/repos/syscoin/syscoin-api/assignees{/user}","branches_url":"https://api.github.com/repos/syscoin/syscoin-api/branches{/branch}","tags_url":"https://api.github.com/repos/syscoin/syscoin-api/tags","blobs_url":"https://api.github.com/repos/syscoin/syscoin-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/syscoin/syscoin-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/syscoin/syscoin-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/syscoin/syscoin-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/syscoin/syscoin-api/statuses/{sha}","languages_url":"https://api.github.com/repos/syscoin/syscoin-api/languages","stargazers_url":"https://api.github.com/repos/syscoin/syscoin-api/stargazers","contributors_url":"https://api.github.com/repos/syscoin/syscoin-api/contributors","subscribers_url":"https://api.github.com/repos/syscoin/syscoin-api/subscribers","subscription_url":"https://api.github.com/repos/syscoin/syscoin-api/subscription","commits_url":"https://api.github.com/repos/syscoin/syscoin-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/syscoin/syscoin-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/syscoin/syscoin-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/syscoin/syscoin-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/syscoin/syscoin-api/contents/{+path}","compare_url":"https://api.github.com/repos/syscoin/syscoin-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/syscoin/syscoin-api/merges","archive_url":"https://api.github.com/repos/syscoin/syscoin-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/syscoin/syscoin-api/downloads","issues_url":"https://api.github.com/repos/syscoin/syscoin-api/issues{/number}","pulls_url":"https://api.github.com/repos/syscoin/syscoin-api/pulls{/number}","milestones_url":"https://api.github.com/repos/syscoin/syscoin-api/milestones{/number}","notifications_url":"https://api.github.com/repos/syscoin/syscoin-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/syscoin/syscoin-api/labels{/name}","releases_url":"https://api.github.com/repos/syscoin/syscoin-api/releases{/id}","deployments_url":"https://api.github.com/repos/syscoin/syscoin-api/deployments","created_at":"2014-09-13T23:30:24Z","updated_at":"2018-02-09T22:31:02Z","pushed_at":"2018-03-28T19:05:40Z","git_url":"git://github.com/syscoin/syscoin-api.git","ssh_url":"git@github.com:syscoin/syscoin-api.git","clone_url":"https://github.com/syscoin/syscoin-api.git","svn_url":"https://github.com/syscoin/syscoin-api","homepage":null,"size":2285,"stargazers_count":12,"watchers_count":12,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":10,"open_issues":2,"watchers":12,"default_branch":"master"}},"base":{"label":"syscoin:dev-3.0","ref":"dev-3.0","sha":"2d574edace664b327feabbf30fcb105e3d24afee","user":{"login":"syscoin","id":6983571,"avatar_url":"https://avatars2.githubusercontent.com/u/6983571?v=4","gravatar_id":"","url":"https://api.github.com/users/syscoin","html_url":"https://github.com/syscoin","followers_url":"https://api.github.com/users/syscoin/followers","following_url":"https://api.github.com/users/syscoin/following{/other_user}","gists_url":"https://api.github.com/users/syscoin/gists{/gist_id}","starred_url":"https://api.github.com/users/syscoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syscoin/subscriptions","organizations_url":"https://api.github.com/users/syscoin/orgs","repos_url":"https://api.github.com/users/syscoin/repos","events_url":"https://api.github.com/users/syscoin/events{/privacy}","received_events_url":"https://api.github.com/users/syscoin/received_events","type":"Organization","site_admin":false},"repo":{"id":24008631,"name":"syscoin-api","full_name":"syscoin/syscoin-api","owner":{"login":"syscoin","id":6983571,"avatar_url":"https://avatars2.githubusercontent.com/u/6983571?v=4","gravatar_id":"","url":"https://api.github.com/users/syscoin","html_url":"https://github.com/syscoin","followers_url":"https://api.github.com/users/syscoin/followers","following_url":"https://api.github.com/users/syscoin/following{/other_user}","gists_url":"https://api.github.com/users/syscoin/gists{/gist_id}","starred_url":"https://api.github.com/users/syscoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syscoin/subscriptions","organizations_url":"https://api.github.com/users/syscoin/orgs","repos_url":"https://api.github.com/users/syscoin/repos","events_url":"https://api.github.com/users/syscoin/events{/privacy}","received_events_url":"https://api.github.com/users/syscoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/syscoin/syscoin-api","description":"Lightweight Syscoin API Server written in NodeJS.","fork":false,"url":"https://api.github.com/repos/syscoin/syscoin-api","forks_url":"https://api.github.com/repos/syscoin/syscoin-api/forks","keys_url":"https://api.github.com/repos/syscoin/syscoin-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/syscoin/syscoin-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/syscoin/syscoin-api/teams","hooks_url":"https://api.github.com/repos/syscoin/syscoin-api/hooks","issue_events_url":"https://api.github.com/repos/syscoin/syscoin-api/issues/events{/number}","events_url":"https://api.github.com/repos/syscoin/syscoin-api/events","assignees_url":"https://api.github.com/repos/syscoin/syscoin-api/assignees{/user}","branches_url":"https://api.github.com/repos/syscoin/syscoin-api/branches{/branch}","tags_url":"https://api.github.com/repos/syscoin/syscoin-api/tags","blobs_url":"https://api.github.com/repos/syscoin/syscoin-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/syscoin/syscoin-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/syscoin/syscoin-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/syscoin/syscoin-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/syscoin/syscoin-api/statuses/{sha}","languages_url":"https://api.github.com/repos/syscoin/syscoin-api/languages","stargazers_url":"https://api.github.com/repos/syscoin/syscoin-api/stargazers","contributors_url":"https://api.github.com/repos/syscoin/syscoin-api/contributors","subscribers_url":"https://api.github.com/repos/syscoin/syscoin-api/subscribers","subscription_url":"https://api.github.com/repos/syscoin/syscoin-api/subscription","commits_url":"https://api.github.com/repos/syscoin/syscoin-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/syscoin/syscoin-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/syscoin/syscoin-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/syscoin/syscoin-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/syscoin/syscoin-api/contents/{+path}","compare_url":"https://api.github.com/repos/syscoin/syscoin-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/syscoin/syscoin-api/merges","archive_url":"https://api.github.com/repos/syscoin/syscoin-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/syscoin/syscoin-api/downloads","issues_url":"https://api.github.com/repos/syscoin/syscoin-api/issues{/number}","pulls_url":"https://api.github.com/repos/syscoin/syscoin-api/pulls{/number}","milestones_url":"https://api.github.com/repos/syscoin/syscoin-api/milestones{/number}","notifications_url":"https://api.github.com/repos/syscoin/syscoin-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/syscoin/syscoin-api/labels{/name}","releases_url":"https://api.github.com/repos/syscoin/syscoin-api/releases{/id}","deployments_url":"https://api.github.com/repos/syscoin/syscoin-api/deployments","created_at":"2014-09-13T23:30:24Z","updated_at":"2018-02-09T22:31:02Z","pushed_at":"2018-03-28T19:05:40Z","git_url":"git://github.com/syscoin/syscoin-api.git","ssh_url":"git@github.com:syscoin/syscoin-api.git","clone_url":"https://github.com/syscoin/syscoin-api.git","svn_url":"https://github.com/syscoin/syscoin-api","homepage":null,"size":2285,"stargazers_count":12,"watchers_count":12,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":10,"open_issues":2,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/syscoin/syscoin-api/pulls/18"},"html":{"href":"https://github.com/syscoin/syscoin-api/pull/18"},"issue":{"href":"https://api.github.com/repos/syscoin/syscoin-api/issues/18"},"comments":{"href":"https://api.github.com/repos/syscoin/syscoin-api/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/syscoin/syscoin-api/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/syscoin/syscoin-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/syscoin/syscoin-api/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/syscoin/syscoin-api/statuses/fcf84605b05dd68dff4d214daa2e8435e9545e4d"}},"author_association":"NONE"}}
{"actor":{"display_login":"sidhujag"}}