{"action":"created","comment":{"url":"https://api.github.com/repos/dividat/driver/pulls/comments/200846510","pull_request_review_id":135238910,"id":200846510,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDg0NjUxMA==","diff_hunk":"@@ -197,8 +197,8 @@ func waitForCardActivity(haveBeenKilled *bool, log *logrus.Entry, scard_ctx *sca\n \t\t\t\tcontinue\n \t\t\t}\n \t\t\tuid := \"\"\n-\t\t\tfor i := 0; i < len(response)-2; i++ {\n-\t\t\t\tuid += fmt.Sprintf(\"%X\", response[i])\n+\t\t\tif len(response) > 2 {","path":"src/dividat-driver/rfid/pcsc.go","position":6,"original_position":6,"commit_id":"b224166dba0bc486ab4f3f78f94ea185601345f3","original_commit_id":"b224166dba0bc486ab4f3f78f94ea185601345f3","user":{"login":"knuton","id":47458,"node_id":"MDQ6VXNlcjQ3NDU4","avatar_url":"https://avatars2.githubusercontent.com/u/47458?v=4","gravatar_id":"","url":"https://api.github.com/users/knuton","html_url":"https://github.com/knuton","followers_url":"https://api.github.com/users/knuton/followers","following_url":"https://api.github.com/users/knuton/following{/other_user}","gists_url":"https://api.github.com/users/knuton/gists{/gist_id}","starred_url":"https://api.github.com/users/knuton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knuton/subscriptions","organizations_url":"https://api.github.com/users/knuton/orgs","repos_url":"https://api.github.com/users/knuton/repos","events_url":"https://api.github.com/users/knuton/events{/privacy}","received_events_url":"https://api.github.com/users/knuton/received_events","type":"User","site_admin":false},"body":"Use constant `ERROR_FLAG_LENGTH = 2` o.s. to explain dropping last two values. ","created_at":"2018-07-08T16:52:54Z","updated_at":"2018-07-08T16:52:54Z","html_url":"https://github.com/dividat/driver/pull/86#discussion_r200846510","pull_request_url":"https://api.github.com/repos/dividat/driver/pulls/86","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dividat/driver/pulls/comments/200846510"},"html":{"href":"https://github.com/dividat/driver/pull/86#discussion_r200846510"},"pull_request":{"href":"https://api.github.com/repos/dividat/driver/pulls/86"}}},"pull_request":{"url":"https://api.github.com/repos/dividat/driver/pulls/86","id":199283024,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MjgzMDI0","html_url":"https://github.com/dividat/driver/pull/86","diff_url":"https://github.com/dividat/driver/pull/86.diff","patch_url":"https://github.com/dividat/driver/pull/86.patch","issue_url":"https://api.github.com/repos/dividat/driver/issues/86","number":86,"state":"open","locked":false,"title":"Fix string representation of RFID UIDs","user":{"login":"knuton","id":47458,"node_id":"MDQ6VXNlcjQ3NDU4","avatar_url":"https://avatars2.githubusercontent.com/u/47458?v=4","gravatar_id":"","url":"https://api.github.com/users/knuton","html_url":"https://github.com/knuton","followers_url":"https://api.github.com/users/knuton/followers","following_url":"https://api.github.com/users/knuton/following{/other_user}","gists_url":"https://api.github.com/users/knuton/gists{/gist_id}","starred_url":"https://api.github.com/users/knuton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knuton/subscriptions","organizations_url":"https://api.github.com/users/knuton/orgs","repos_url":"https://api.github.com/users/knuton/repos","events_url":"https://api.github.com/users/knuton/events{/privacy}","received_events_url":"https://api.github.com/users/knuton/received_events","type":"User","site_admin":false},"body":"Small byte values were not zero-padded when printed individually.\r\n\r\nInstead, the whole byte array can be printed in hexadecimal.","created_at":"2018-07-04T15:37:37Z","updated_at":"2018-07-08T16:52:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d3fe9ee1b8a03723fd435bcb14e11dc32dd4a37","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dividat/driver/pulls/86/commits","review_comments_url":"https://api.github.com/repos/dividat/driver/pulls/86/comments","review_comment_url":"https://api.github.com/repos/dividat/driver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dividat/driver/issues/86/comments","statuses_url":"https://api.github.com/repos/dividat/driver/statuses/b224166dba0bc486ab4f3f78f94ea185601345f3","head":{"label":"knuton:fix-uid-formatting","ref":"fix-uid-formatting","sha":"b224166dba0bc486ab4f3f78f94ea185601345f3","user":{"login":"knuton","id":47458,"node_id":"MDQ6VXNlcjQ3NDU4","avatar_url":"https://avatars2.githubusercontent.com/u/47458?v=4","gravatar_id":"","url":"https://api.github.com/users/knuton","html_url":"https://github.com/knuton","followers_url":"https://api.github.com/users/knuton/followers","following_url":"https://api.github.com/users/knuton/following{/other_user}","gists_url":"https://api.github.com/users/knuton/gists{/gist_id}","starred_url":"https://api.github.com/users/knuton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knuton/subscriptions","organizations_url":"https://api.github.com/users/knuton/orgs","repos_url":"https://api.github.com/users/knuton/repos","events_url":"https://api.github.com/users/knuton/events{/privacy}","received_events_url":"https://api.github.com/users/knuton/received_events","type":"User","site_admin":false},"repo":{"id":82556006,"node_id":"MDEwOlJlcG9zaXRvcnk4MjU1NjAwNg==","name":"driver","full_name":"knuton/driver","owner":{"login":"knuton","id":47458,"node_id":"MDQ6VXNlcjQ3NDU4","avatar_url":"https://avatars2.githubusercontent.com/u/47458?v=4","gravatar_id":"","url":"https://api.github.com/users/knuton","html_url":"https://github.com/knuton","followers_url":"https://api.github.com/users/knuton/followers","following_url":"https://api.github.com/users/knuton/following{/other_user}","gists_url":"https://api.github.com/users/knuton/gists{/gist_id}","starred_url":"https://api.github.com/users/knuton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knuton/subscriptions","organizations_url":"https://api.github.com/users/knuton/orgs","repos_url":"https://api.github.com/users/knuton/repos","events_url":"https://api.github.com/users/knuton/events{/privacy}","received_events_url":"https://api.github.com/users/knuton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/knuton/driver","description":"Dividat drivers and hardware test suites","fork":true,"url":"https://api.github.com/repos/knuton/driver","forks_url":"https://api.github.com/repos/knuton/driver/forks","keys_url":"https://api.github.com/repos/knuton/driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/knuton/driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/knuton/driver/teams","hooks_url":"https://api.github.com/repos/knuton/driver/hooks","issue_events_url":"https://api.github.com/repos/knuton/driver/issues/events{/number}","events_url":"https://api.github.com/repos/knuton/driver/events","assignees_url":"https://api.github.com/repos/knuton/driver/assignees{/user}","branches_url":"https://api.github.com/repos/knuton/driver/branches{/branch}","tags_url":"https://api.github.com/repos/knuton/driver/tags","blobs_url":"https://api.github.com/repos/knuton/driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/knuton/driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/knuton/driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/knuton/driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/knuton/driver/statuses/{sha}","languages_url":"https://api.github.com/repos/knuton/driver/languages","stargazers_url":"https://api.github.com/repos/knuton/driver/stargazers","contributors_url":"https://api.github.com/repos/knuton/driver/contributors","subscribers_url":"https://api.github.com/repos/knuton/driver/subscribers","subscription_url":"https://api.github.com/repos/knuton/driver/subscription","commits_url":"https://api.github.com/repos/knuton/driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/knuton/driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/knuton/driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/knuton/driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/knuton/driver/contents/{+path}","compare_url":"https://api.github.com/repos/knuton/driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/knuton/driver/merges","archive_url":"https://api.github.com/repos/knuton/driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/knuton/driver/downloads","issues_url":"https://api.github.com/repos/knuton/driver/issues{/number}","pulls_url":"https://api.github.com/repos/knuton/driver/pulls{/number}","milestones_url":"https://api.github.com/repos/knuton/driver/milestones{/number}","notifications_url":"https://api.github.com/repos/knuton/driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/knuton/driver/labels{/name}","releases_url":"https://api.github.com/repos/knuton/driver/releases{/id}","deployments_url":"https://api.github.com/repos/knuton/driver/deployments","created_at":"2017-02-20T12:35:19Z","updated_at":"2017-02-20T12:35:21Z","pushed_at":"2018-07-04T15:34:07Z","git_url":"git://github.com/knuton/driver.git","ssh_url":"git@github.com:knuton/driver.git","clone_url":"https://github.com/knuton/driver.git","svn_url":"https://github.com/knuton/driver","homepage":"","size":3455,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"dividat:develop","ref":"develop","sha":"bf321f43f84160d2140052742db1e04bd22e515f","user":{"login":"dividat","id":17985246,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTg1MjQ2","avatar_url":"https://avatars1.githubusercontent.com/u/17985246?v=4","gravatar_id":"","url":"https://api.github.com/users/dividat","html_url":"https://github.com/dividat","followers_url":"https://api.github.com/users/dividat/followers","following_url":"https://api.github.com/users/dividat/following{/other_user}","gists_url":"https://api.github.com/users/dividat/gists{/gist_id}","starred_url":"https://api.github.com/users/dividat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dividat/subscriptions","organizations_url":"https://api.github.com/users/dividat/orgs","repos_url":"https://api.github.com/users/dividat/repos","events_url":"https://api.github.com/users/dividat/events{/privacy}","received_events_url":"https://api.github.com/users/dividat/received_events","type":"Organization","site_admin":false},"repo":{"id":66946468,"node_id":"MDEwOlJlcG9zaXRvcnk2Njk0NjQ2OA==","name":"driver","full_name":"dividat/driver","owner":{"login":"dividat","id":17985246,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTg1MjQ2","avatar_url":"https://avatars1.githubusercontent.com/u/17985246?v=4","gravatar_id":"","url":"https://api.github.com/users/dividat","html_url":"https://github.com/dividat","followers_url":"https://api.github.com/users/dividat/followers","following_url":"https://api.github.com/users/dividat/following{/other_user}","gists_url":"https://api.github.com/users/dividat/gists{/gist_id}","starred_url":"https://api.github.com/users/dividat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dividat/subscriptions","organizations_url":"https://api.github.com/users/dividat/orgs","repos_url":"https://api.github.com/users/dividat/repos","events_url":"https://api.github.com/users/dividat/events{/privacy}","received_events_url":"https://api.github.com/users/dividat/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dividat/driver","description":"Dividat drivers and hardware test suites","fork":false,"url":"https://api.github.com/repos/dividat/driver","forks_url":"https://api.github.com/repos/dividat/driver/forks","keys_url":"https://api.github.com/repos/dividat/driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dividat/driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dividat/driver/teams","hooks_url":"https://api.github.com/repos/dividat/driver/hooks","issue_events_url":"https://api.github.com/repos/dividat/driver/issues/events{/number}","events_url":"https://api.github.com/repos/dividat/driver/events","assignees_url":"https://api.github.com/repos/dividat/driver/assignees{/user}","branches_url":"https://api.github.com/repos/dividat/driver/branches{/branch}","tags_url":"https://api.github.com/repos/dividat/driver/tags","blobs_url":"https://api.github.com/repos/dividat/driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dividat/driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dividat/driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/dividat/driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dividat/driver/statuses/{sha}","languages_url":"https://api.github.com/repos/dividat/driver/languages","stargazers_url":"https://api.github.com/repos/dividat/driver/stargazers","contributors_url":"https://api.github.com/repos/dividat/driver/contributors","subscribers_url":"https://api.github.com/repos/dividat/driver/subscribers","subscription_url":"https://api.github.com/repos/dividat/driver/subscription","commits_url":"https://api.github.com/repos/dividat/driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/dividat/driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/dividat/driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/dividat/driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/dividat/driver/contents/{+path}","compare_url":"https://api.github.com/repos/dividat/driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dividat/driver/merges","archive_url":"https://api.github.com/repos/dividat/driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dividat/driver/downloads","issues_url":"https://api.github.com/repos/dividat/driver/issues{/number}","pulls_url":"https://api.github.com/repos/dividat/driver/pulls{/number}","milestones_url":"https://api.github.com/repos/dividat/driver/milestones{/number}","notifications_url":"https://api.github.com/repos/dividat/driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dividat/driver/labels{/name}","releases_url":"https://api.github.com/repos/dividat/driver/releases{/id}","deployments_url":"https://api.github.com/repos/dividat/driver/deployments","created_at":"2016-08-30T14:08:31Z","updated_at":"2018-06-26T11:08:14Z","pushed_at":"2018-07-04T15:37:37Z","git_url":"git://github.com/dividat/driver.git","ssh_url":"git@github.com:dividat/driver.git","clone_url":"https://github.com/dividat/driver.git","svn_url":"https://github.com/dividat/driver","homepage":"","size":3454,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":3,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/dividat/driver/pulls/86"},"html":{"href":"https://github.com/dividat/driver/pull/86"},"issue":{"href":"https://api.github.com/repos/dividat/driver/issues/86"},"comments":{"href":"https://api.github.com/repos/dividat/driver/issues/86/comments"},"review_comments":{"href":"https://api.github.com/repos/dividat/driver/pulls/86/comments"},"review_comment":{"href":"https://api.github.com/repos/dividat/driver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dividat/driver/pulls/86/commits"},"statuses":{"href":"https://api.github.com/repos/dividat/driver/statuses/b224166dba0bc486ab4f3f78f94ea185601345f3"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"knuton"}}