{"action":"created","issue":{"url":"https://api.github.com/repos/root-project/root/issues/2036","repository_url":"https://api.github.com/repos/root-project/root","labels_url":"https://api.github.com/repos/root-project/root/issues/2036/labels{/name}","comments_url":"https://api.github.com/repos/root-project/root/issues/2036/comments","events_url":"https://api.github.com/repos/root-project/root/issues/2036/events","html_url":"https://github.com/root-project/root/pull/2036","id":324232559,"number":2036,"title":"TTreeCache vs TTreeReader, TDF and TTree::Draw","user":{"login":"pcanal","id":5175087,"avatar_url":"https://avatars3.githubusercontent.com/u/5175087?v=4","gravatar_id":"","url":"https://api.github.com/users/pcanal","html_url":"https://github.com/pcanal","followers_url":"https://api.github.com/users/pcanal/followers","following_url":"https://api.github.com/users/pcanal/following{/other_user}","gists_url":"https://api.github.com/users/pcanal/gists{/gist_id}","starred_url":"https://api.github.com/users/pcanal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcanal/subscriptions","organizations_url":"https://api.github.com/users/pcanal/orgs","repos_url":"https://api.github.com/users/pcanal/repos","events_url":"https://api.github.com/users/pcanal/events{/privacy}","received_events_url":"https://api.github.com/users/pcanal/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-05-18T00:42:45Z","updated_at":"2018-05-18T02:09:40Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/root-project/root/pulls/2036","html_url":"https://github.com/root-project/root/pull/2036","diff_url":"https://github.com/root-project/root/pull/2036.diff","patch_url":"https://github.com/root-project/root/pull/2036.patch"},"body":"Previously it was only done in\r\n   TTree::GetClusterIterator\r\n   TTree::GetEntry\r\n   TTree::GetEntryWithIndex\r\n   TTree::GetMaximum\r\n   TTree::GetMinimum\r\n   TTree::GetReadCache\r\n   TTree::SetCacheSize\r\n\r\nIn particular it was not triggered by TTree::Draw, TDF nor TTreeReader,\r\nthey are using only:\r\n\r\n   TTree::LoadTree and TBranch::GetEntry\r\n\r\nThe one use case still not covered is\r\n\r\n   file->GetObject(treename, tree);\r\n   auto b = tree->GetBranch(branchname);\r\n   b->GetEntry(entryNumber)=;\r\n\r\nBut it would require to either enable it in the TTree constructor\r\n(too soon?) or TBranch::GetEntry (too often?)"},"comment":{"url":"https://api.github.com/repos/root-project/root/issues/comments/390072889","html_url":"https://github.com/root-project/root/pull/2036#issuecomment-390072889","issue_url":"https://api.github.com/repos/root-project/root/issues/2036","id":390072889,"user":{"login":"phsft-bot","id":25639015,"avatar_url":"https://avatars1.githubusercontent.com/u/25639015?v=4","gravatar_id":"","url":"https://api.github.com/users/phsft-bot","html_url":"https://github.com/phsft-bot","followers_url":"https://api.github.com/users/phsft-bot/followers","following_url":"https://api.github.com/users/phsft-bot/following{/other_user}","gists_url":"https://api.github.com/users/phsft-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/phsft-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phsft-bot/subscriptions","organizations_url":"https://api.github.com/users/phsft-bot/orgs","repos_url":"https://api.github.com/users/phsft-bot/repos","events_url":"https://api.github.com/users/phsft-bot/events{/privacy}","received_events_url":"https://api.github.com/users/phsft-bot/received_events","type":"User","site_admin":false},"created_at":"2018-05-18T02:09:40Z","updated_at":"2018-05-18T02:09:40Z","author_association":"COLLABORATOR","body":"Build failed on ubuntu16/native.\n[See console output](https://epsft-jenkins.cern.ch/job/root-pullrequests-build/26526/console).\n### Failing tests:\n- [projectroot.roottest.root.tree.cache.roottest_root_tree_cache_autocache](https://epsft-jenkins.cern.ch/job/root-pullrequests-build/26526/testReport/projectroot.roottest.root.tree/cache/roottest_root_tree_cache_autocache/)\n"}}
{"actor":{"display_login":"phsft-bot"}}