{"action":"created","comment":{"url":"https://api.github.com/repos/QCoDeS/broadbean/pulls/comments/195592818","pull_request_review_id":128994973,"id":195592818,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTU5MjgxOA==","diff_hunk":"@@ -2245,6 +2245,56 @@ def rescaler(val, ampl, off):\n \n         return output\n \n+def joinElements(elem1: Element,\n+                 elem2: Element,\n+                 zero_pad: bool=True,\n+                 overlap_time: float=0)->Element:\n+    \"\"\"\n+    joins two elements by appending elem2 to elem1\n+    and returns a new atomic element:\n+    |-~-| |~--| |-~-~--|\n+    |---|+|~--|=|---~--|\n+    |---| |~--| |---~--|\n+    If the channels specified in the two elements differ\n+    one can choose to do zero padding\n+    |-~-| |~--| |-~-~--|\n+         +|~--|=|---~--|\n+    |---|       |------|\n+    If the channels are disjunct an overlap can be introduced\n+    |-~-|       |-~--|\n+          |~--| |-~--|\n+         +|~--|=|-~--|\n+    |---|       |----|\n+    It should also be possible at some point to join elements","path":"broadbean/broadbean.py","position":24,"original_position":24,"commit_id":"d73e83d3e9b7e60f13dbd5232f2b325409b2e252","original_commit_id":"d73e83d3e9b7e60f13dbd5232f2b325409b2e252","user":{"login":"astafan8","id":15662810,"node_id":"MDQ6VXNlcjE1NjYyODEw","avatar_url":"https://avatars3.githubusercontent.com/u/15662810?v=4","gravatar_id":"","url":"https://api.github.com/users/astafan8","html_url":"https://github.com/astafan8","followers_url":"https://api.github.com/users/astafan8/followers","following_url":"https://api.github.com/users/astafan8/following{/other_user}","gists_url":"https://api.github.com/users/astafan8/gists{/gist_id}","starred_url":"https://api.github.com/users/astafan8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astafan8/subscriptions","organizations_url":"https://api.github.com/users/astafan8/orgs","repos_url":"https://api.github.com/users/astafan8/repos","events_url":"https://api.github.com/users/astafan8/events{/privacy}","received_events_url":"https://api.github.com/users/astafan8/received_events","type":"User","site_admin":false},"body":"please do not leave \"feature requests\" in code. we have GitHub issues for that, right?","created_at":"2018-06-14T22:41:44Z","updated_at":"2018-06-14T22:41:44Z","html_url":"https://github.com/QCoDeS/broadbean/pull/71#discussion_r195592818","pull_request_url":"https://api.github.com/repos/QCoDeS/broadbean/pulls/71","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/QCoDeS/broadbean/pulls/comments/195592818"},"html":{"href":"https://github.com/QCoDeS/broadbean/pull/71#discussion_r195592818"},"pull_request":{"href":"https://api.github.com/repos/QCoDeS/broadbean/pulls/71"}}},"pull_request":{"url":"https://api.github.com/repos/QCoDeS/broadbean/pulls/71","id":175260809,"node_id":"MDExOlB1bGxSZXF1ZXN0MTc1MjYwODA5","html_url":"https://github.com/QCoDeS/broadbean/pull/71","diff_url":"https://github.com/QCoDeS/broadbean/pull/71.diff","patch_url":"https://github.com/QCoDeS/broadbean/pull/71.patch","issue_url":"https://api.github.com/repos/QCoDeS/broadbean/issues/71","number":71,"state":"open","locked":false,"title":"feat/add function to fuse sequential elements into one ","user":{"login":"Dominik-Vogel","id":30660470,"node_id":"MDQ6VXNlcjMwNjYwNDcw","avatar_url":"https://avatars2.githubusercontent.com/u/30660470?v=4","gravatar_id":"","url":"https://api.github.com/users/Dominik-Vogel","html_url":"https://github.com/Dominik-Vogel","followers_url":"https://api.github.com/users/Dominik-Vogel/followers","following_url":"https://api.github.com/users/Dominik-Vogel/following{/other_user}","gists_url":"https://api.github.com/users/Dominik-Vogel/gists{/gist_id}","starred_url":"https://api.github.com/users/Dominik-Vogel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dominik-Vogel/subscriptions","organizations_url":"https://api.github.com/users/Dominik-Vogel/orgs","repos_url":"https://api.github.com/users/Dominik-Vogel/repos","events_url":"https://api.github.com/users/Dominik-Vogel/events{/privacy}","received_events_url":"https://api.github.com/users/Dominik-Vogel/received_events","type":"User","site_admin":false},"body":"Implemented as function and not as  operator, so that additional arguments are possible. Possibly add operator later for default args. Possible abiguity: does plus sequentially add elements or by channel?\r\n\r\nfunction like in doc string:\r\n```\r\njoins two elements by appending elem2 to elem1\r\nand returns a new atomic element:\r\n|-~-| |~--| |-~-~--|\r\n|---|+|~--|=|---~--|\r\n|---| |~--| |---~--|\r\nIf the channels specified in the two elements differ\r\none can choose to do zero padding\r\n|-~-| |~--| |-~-~--|\r\n     +|~--|=|---~--|\r\n|---|       |------|\r\nIf the channels are disjunct an overlap can be introduced\r\n|-~-|       |-~--|\r\n|~--|       |~---|\r\n     +|~--|=|-~--|\r\n|---|       |----|\r\n```","created_at":"2018-03-15T14:05:58Z","updated_at":"2018-06-14T22:41:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff59b72f624e077e4b3d3c8056151a715a5eef36","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/QCoDeS/broadbean/pulls/71/commits","review_comments_url":"https://api.github.com/repos/QCoDeS/broadbean/pulls/71/comments","review_comment_url":"https://api.github.com/repos/QCoDeS/broadbean/pulls/comments{/number}","comments_url":"https://api.github.com/repos/QCoDeS/broadbean/issues/71/comments","statuses_url":"https://api.github.com/repos/QCoDeS/broadbean/statuses/d73e83d3e9b7e60f13dbd5232f2b325409b2e252","head":{"label":"Dominik-Vogel:joinElements","ref":"joinElements","sha":"d73e83d3e9b7e60f13dbd5232f2b325409b2e252","user":{"login":"Dominik-Vogel","id":30660470,"node_id":"MDQ6VXNlcjMwNjYwNDcw","avatar_url":"https://avatars2.githubusercontent.com/u/30660470?v=4","gravatar_id":"","url":"https://api.github.com/users/Dominik-Vogel","html_url":"https://github.com/Dominik-Vogel","followers_url":"https://api.github.com/users/Dominik-Vogel/followers","following_url":"https://api.github.com/users/Dominik-Vogel/following{/other_user}","gists_url":"https://api.github.com/users/Dominik-Vogel/gists{/gist_id}","starred_url":"https://api.github.com/users/Dominik-Vogel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dominik-Vogel/subscriptions","organizations_url":"https://api.github.com/users/Dominik-Vogel/orgs","repos_url":"https://api.github.com/users/Dominik-Vogel/repos","events_url":"https://api.github.com/users/Dominik-Vogel/events{/privacy}","received_events_url":"https://api.github.com/users/Dominik-Vogel/received_events","type":"User","site_admin":false},"repo":{"id":125375973,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUzNzU5NzM=","name":"broadbean","full_name":"Dominik-Vogel/broadbean","owner":{"login":"Dominik-Vogel","id":30660470,"node_id":"MDQ6VXNlcjMwNjYwNDcw","avatar_url":"https://avatars2.githubusercontent.com/u/30660470?v=4","gravatar_id":"","url":"https://api.github.com/users/Dominik-Vogel","html_url":"https://github.com/Dominik-Vogel","followers_url":"https://api.github.com/users/Dominik-Vogel/followers","following_url":"https://api.github.com/users/Dominik-Vogel/following{/other_user}","gists_url":"https://api.github.com/users/Dominik-Vogel/gists{/gist_id}","starred_url":"https://api.github.com/users/Dominik-Vogel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dominik-Vogel/subscriptions","organizations_url":"https://api.github.com/users/Dominik-Vogel/orgs","repos_url":"https://api.github.com/users/Dominik-Vogel/repos","events_url":"https://api.github.com/users/Dominik-Vogel/events{/privacy}","received_events_url":"https://api.github.com/users/Dominik-Vogel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Dominik-Vogel/broadbean","description":"Pulse building library interfaceable with Tektronix AWG's 5014, 5208 and 70000A","fork":true,"url":"https://api.github.com/repos/Dominik-Vogel/broadbean","forks_url":"https://api.github.com/repos/Dominik-Vogel/broadbean/forks","keys_url":"https://api.github.com/repos/Dominik-Vogel/broadbean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Dominik-Vogel/broadbean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Dominik-Vogel/broadbean/teams","hooks_url":"https://api.github.com/repos/Dominik-Vogel/broadbean/hooks","issue_events_url":"https://api.github.com/repos/Dominik-Vogel/broadbean/issues/events{/number}","events_url":"https://api.github.com/repos/Dominik-Vogel/broadbean/events","assignees_url":"https://api.github.com/repos/Dominik-Vogel/broadbean/assignees{/user}","branches_url":"https://api.github.com/repos/Dominik-Vogel/broadbean/branches{/branch}","tags_url":"https://api.github.com/repos/Dominik-Vogel/broadbean/tags","blobs_url":"https://api.github.com/repos/Dominik-Vogel/broadbean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Dominik-Vogel/broadbean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Dominik-Vogel/broadbean/git/refs{/sha}","trees_url":"https://api.github.com/repos/Dominik-Vogel/broadbean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Dominik-Vogel/broadbean/statuses/{sha}","languages_url":"https://api.github.com/repos/Dominik-Vogel/broadbean/languages","stargazers_url":"https://api.github.com/repos/Dominik-Vogel/broadbean/stargazers","contributors_url":"https://api.github.com/repos/Dominik-Vogel/broadbean/contributors","subscribers_url":"https://api.github.com/repos/Dominik-Vogel/broadbean/subscribers","subscription_url":"https://api.github.com/repos/Dominik-Vogel/broadbean/subscription","commits_url":"https://api.github.com/repos/Dominik-Vogel/broadbean/commits{/sha}","git_commits_url":"https://api.github.com/repos/Dominik-Vogel/broadbean/git/commits{/sha}","comments_url":"https://api.github.com/repos/Dominik-Vogel/broadbean/comments{/number}","issue_comment_url":"https://api.github.com/repos/Dominik-Vogel/broadbean/issues/comments{/number}","contents_url":"https://api.github.com/repos/Dominik-Vogel/broadbean/contents/{+path}","compare_url":"https://api.github.com/repos/Dominik-Vogel/broadbean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Dominik-Vogel/broadbean/merges","archive_url":"https://api.github.com/repos/Dominik-Vogel/broadbean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Dominik-Vogel/broadbean/downloads","issues_url":"https://api.github.com/repos/Dominik-Vogel/broadbean/issues{/number}","pulls_url":"https://api.github.com/repos/Dominik-Vogel/broadbean/pulls{/number}","milestones_url":"https://api.github.com/repos/Dominik-Vogel/broadbean/milestones{/number}","notifications_url":"https://api.github.com/repos/Dominik-Vogel/broadbean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Dominik-Vogel/broadbean/labels{/name}","releases_url":"https://api.github.com/repos/Dominik-Vogel/broadbean/releases{/id}","deployments_url":"https://api.github.com/repos/Dominik-Vogel/broadbean/deployments","created_at":"2018-03-15T14:02:18Z","updated_at":"2018-03-15T14:02:19Z","pushed_at":"2018-06-08T14:11:50Z","git_url":"git://github.com/Dominik-Vogel/broadbean.git","ssh_url":"git@github.com:Dominik-Vogel/broadbean.git","clone_url":"https://github.com/Dominik-Vogel/broadbean.git","svn_url":"https://github.com/Dominik-Vogel/broadbean","homepage":"","size":5514,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"QCoDeS:master","ref":"master","sha":"537df230d3d84bb357de9307611e48fe2345bb4e","user":{"login":"QCoDeS","id":20478252,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDc4MjUy","avatar_url":"https://avatars3.githubusercontent.com/u/20478252?v=4","gravatar_id":"","url":"https://api.github.com/users/QCoDeS","html_url":"https://github.com/QCoDeS","followers_url":"https://api.github.com/users/QCoDeS/followers","following_url":"https://api.github.com/users/QCoDeS/following{/other_user}","gists_url":"https://api.github.com/users/QCoDeS/gists{/gist_id}","starred_url":"https://api.github.com/users/QCoDeS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QCoDeS/subscriptions","organizations_url":"https://api.github.com/users/QCoDeS/orgs","repos_url":"https://api.github.com/users/QCoDeS/repos","events_url":"https://api.github.com/users/QCoDeS/events{/privacy}","received_events_url":"https://api.github.com/users/QCoDeS/received_events","type":"Organization","site_admin":false},"repo":{"id":82679108,"node_id":"MDEwOlJlcG9zaXRvcnk4MjY3OTEwOA==","name":"broadbean","full_name":"QCoDeS/broadbean","owner":{"login":"QCoDeS","id":20478252,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDc4MjUy","avatar_url":"https://avatars3.githubusercontent.com/u/20478252?v=4","gravatar_id":"","url":"https://api.github.com/users/QCoDeS","html_url":"https://github.com/QCoDeS","followers_url":"https://api.github.com/users/QCoDeS/followers","following_url":"https://api.github.com/users/QCoDeS/following{/other_user}","gists_url":"https://api.github.com/users/QCoDeS/gists{/gist_id}","starred_url":"https://api.github.com/users/QCoDeS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QCoDeS/subscriptions","organizations_url":"https://api.github.com/users/QCoDeS/orgs","repos_url":"https://api.github.com/users/QCoDeS/repos","events_url":"https://api.github.com/users/QCoDeS/events{/privacy}","received_events_url":"https://api.github.com/users/QCoDeS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/QCoDeS/broadbean","description":"Pulse building library interfaceable with Tektronix AWG's 5014, 5208 and 70000A","fork":false,"url":"https://api.github.com/repos/QCoDeS/broadbean","forks_url":"https://api.github.com/repos/QCoDeS/broadbean/forks","keys_url":"https://api.github.com/repos/QCoDeS/broadbean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/QCoDeS/broadbean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/QCoDeS/broadbean/teams","hooks_url":"https://api.github.com/repos/QCoDeS/broadbean/hooks","issue_events_url":"https://api.github.com/repos/QCoDeS/broadbean/issues/events{/number}","events_url":"https://api.github.com/repos/QCoDeS/broadbean/events","assignees_url":"https://api.github.com/repos/QCoDeS/broadbean/assignees{/user}","branches_url":"https://api.github.com/repos/QCoDeS/broadbean/branches{/branch}","tags_url":"https://api.github.com/repos/QCoDeS/broadbean/tags","blobs_url":"https://api.github.com/repos/QCoDeS/broadbean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/QCoDeS/broadbean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/QCoDeS/broadbean/git/refs{/sha}","trees_url":"https://api.github.com/repos/QCoDeS/broadbean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/QCoDeS/broadbean/statuses/{sha}","languages_url":"https://api.github.com/repos/QCoDeS/broadbean/languages","stargazers_url":"https://api.github.com/repos/QCoDeS/broadbean/stargazers","contributors_url":"https://api.github.com/repos/QCoDeS/broadbean/contributors","subscribers_url":"https://api.github.com/repos/QCoDeS/broadbean/subscribers","subscription_url":"https://api.github.com/repos/QCoDeS/broadbean/subscription","commits_url":"https://api.github.com/repos/QCoDeS/broadbean/commits{/sha}","git_commits_url":"https://api.github.com/repos/QCoDeS/broadbean/git/commits{/sha}","comments_url":"https://api.github.com/repos/QCoDeS/broadbean/comments{/number}","issue_comment_url":"https://api.github.com/repos/QCoDeS/broadbean/issues/comments{/number}","contents_url":"https://api.github.com/repos/QCoDeS/broadbean/contents/{+path}","compare_url":"https://api.github.com/repos/QCoDeS/broadbean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/QCoDeS/broadbean/merges","archive_url":"https://api.github.com/repos/QCoDeS/broadbean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/QCoDeS/broadbean/downloads","issues_url":"https://api.github.com/repos/QCoDeS/broadbean/issues{/number}","pulls_url":"https://api.github.com/repos/QCoDeS/broadbean/pulls{/number}","milestones_url":"https://api.github.com/repos/QCoDeS/broadbean/milestones{/number}","notifications_url":"https://api.github.com/repos/QCoDeS/broadbean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/QCoDeS/broadbean/labels{/name}","releases_url":"https://api.github.com/repos/QCoDeS/broadbean/releases{/id}","deployments_url":"https://api.github.com/repos/QCoDeS/broadbean/deployments","created_at":"2017-02-21T12:48:28Z","updated_at":"2018-06-03T12:17:46Z","pushed_at":"2018-06-08T14:11:51Z","git_url":"git://github.com/QCoDeS/broadbean.git","ssh_url":"git@github.com:QCoDeS/broadbean.git","clone_url":"https://github.com/QCoDeS/broadbean.git","svn_url":"https://github.com/QCoDeS/broadbean","homepage":"","size":5259,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":7,"open_issues":15,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/QCoDeS/broadbean/pulls/71"},"html":{"href":"https://github.com/QCoDeS/broadbean/pull/71"},"issue":{"href":"https://api.github.com/repos/QCoDeS/broadbean/issues/71"},"comments":{"href":"https://api.github.com/repos/QCoDeS/broadbean/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/QCoDeS/broadbean/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/QCoDeS/broadbean/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/QCoDeS/broadbean/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/QCoDeS/broadbean/statuses/d73e83d3e9b7e60f13dbd5232f2b325409b2e252"}},"author_association":"NONE"}}
{"actor":{"display_login":"astafan8"}}