{"action":"created","issue":{"url":"https://api.github.com/repos/takeyuwebinc/sample-feedreader-rails/issues/14","repository_url":"https://api.github.com/repos/takeyuwebinc/sample-feedreader-rails","labels_url":"https://api.github.com/repos/takeyuwebinc/sample-feedreader-rails/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/takeyuwebinc/sample-feedreader-rails/issues/14/comments","events_url":"https://api.github.com/repos/takeyuwebinc/sample-feedreader-rails/issues/14/events","html_url":"https://github.com/takeyuwebinc/sample-feedreader-rails/pull/14","id":306392510,"number":14,"title":"[WIP] 『最新の情報を取得』","user":{"login":"shiraryu","id":26644768,"avatar_url":"https://avatars3.githubusercontent.com/u/26644768?v=4","gravatar_id":"","url":"https://api.github.com/users/shiraryu","html_url":"https://github.com/shiraryu","followers_url":"https://api.github.com/users/shiraryu/followers","following_url":"https://api.github.com/users/shiraryu/following{/other_user}","gists_url":"https://api.github.com/users/shiraryu/gists{/gist_id}","starred_url":"https://api.github.com/users/shiraryu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shiraryu/subscriptions","organizations_url":"https://api.github.com/users/shiraryu/orgs","repos_url":"https://api.github.com/users/shiraryu/repos","events_url":"https://api.github.com/users/shiraryu/events{/privacy}","received_events_url":"https://api.github.com/users/shiraryu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":19,"created_at":"2018-03-19T09:46:53Z","updated_at":"2018-03-23T01:25:36Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/takeyuwebinc/sample-feedreader-rails/pulls/14","html_url":"https://github.com/takeyuwebinc/sample-feedreader-rails/pull/14","diff_url":"https://github.com/takeyuwebinc/sample-feedreader-rails/pull/14.diff","patch_url":"https://github.com/takeyuwebinc/sample-feedreader-rails/pull/14.patch"},"body":"refs #4 \r\n\r\n[WIP]の使い方が間違っていたらすいません。アドバイスを頂いたにもかかわらずなかなか機能を追加することできないので、テーブル追加&アソシエーションの段階で一旦pushしました。\r\n（板倉さんアドバイスを更に細分化しなければ僕は頭の整理できないのではと思いつつ）\r\n\r\n（追加内容）　『最新の情報を取得』ボタン → 情報取得 → DBに保存 →  /feeds で保存した情報表示\r\n\r\n- [ ]  title/description/linkをDBに保存できるよう、テーブル（Model）を作成\r\n\r\n- [ ] RSSフィードを取ってきて、1で作ったDBに保存するactionを作成（『最新の情報を取得』ボタン）\r\n　　（この際、複数回actionを実行しても同じ記事が複数登録されないように注意）\r\n\r\n- [ ] 記事一覧をDBに保存しているものを表示するのに変更\r\n\r\n- [ ] RSSフィード登録時に、DBに最新記事を登録する処理を追加\r\n\r\n- [ ] 定期的にRSSフィードを更新する処理を追加（cron。HerokuだとSchedulerというaddonを使うことになる）\r\n\r\n現状特に、『最新の情報を取得するボタン』を作成するという部分を難しく感じています。\r\n（feedのidや処理の流れなど）"},"comment":{"url":"https://api.github.com/repos/takeyuwebinc/sample-feedreader-rails/issues/comments/375509639","html_url":"https://github.com/takeyuwebinc/sample-feedreader-rails/pull/14#issuecomment-375509639","issue_url":"https://api.github.com/repos/takeyuwebinc/sample-feedreader-rails/issues/14","id":375509639,"user":{"login":"itkrt2y","id":2343568,"avatar_url":"https://avatars1.githubusercontent.com/u/2343568?v=4","gravatar_id":"","url":"https://api.github.com/users/itkrt2y","html_url":"https://github.com/itkrt2y","followers_url":"https://api.github.com/users/itkrt2y/followers","following_url":"https://api.github.com/users/itkrt2y/following{/other_user}","gists_url":"https://api.github.com/users/itkrt2y/gists{/gist_id}","starred_url":"https://api.github.com/users/itkrt2y/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itkrt2y/subscriptions","organizations_url":"https://api.github.com/users/itkrt2y/orgs","repos_url":"https://api.github.com/users/itkrt2y/repos","events_url":"https://api.github.com/users/itkrt2y/events{/privacy}","received_events_url":"https://api.github.com/users/itkrt2y/received_events","type":"User","site_admin":false},"created_at":"2018-03-23T01:25:36Z","updated_at":"2018-03-23T01:25:36Z","author_association":"OWNER","body":"今回に限っては修正をしなくてもいいとは思いますが、意識してなかったらちゃんと意識しないといけないこととして **エラーハンドリング** があります。\r\n\r\n例えば、 `@channel.update` や`item.update` で今はvalidation errorは起きないとしても将来validationを足して `false` になりうるようになった場合、今は結果が `true` でも `false` でも関係なく `update` やりっぱなしで流してますけれども、果たしてそれでいいのか？ というところは常に意識する必要があります。\r\nケースバイケースになりますが、一つ失敗したら全部rollbackしなければならない時もありますし、失敗したのをあとで確認できるようにすべきかもしれませんし、無視して流していい場合もありますし。"}}
{"actor":{"display_login":"itkrt2y"}}