{"action":"created","comment":{"url":"https://api.github.com/repos/opencog/opencog/pulls/comments/211072205","pull_request_review_id":147427276,"id":211072205,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTA3MjIwNQ==","diff_hunk":"@@ -461,36 +464,19 @@\n  it parsed, and then updates the counts for the observed words and word\n  pairs.\n \"\n-\t; try-catch wrapper around the counters. Due to a buggy RelEx\n-\t; (see documentation for `word-inst-get-word`), the function\n-\t; `update-clique-pair-counts` might throw.  If it does throw,\n-\t; then avoid doing any counting at all for this sentence.\n-\t;\n-\t; Note: update-clique-pair-counts commented out. If you want this,\n-\t; then uncomment it, and adjust the length.\n-\t; Note: update-disjunct-counts commented out. It generates some\n-\t; data, but none of it will be interesting to most people.\n-\t(define (update-counts sent)\n-\t\t(catch 'wrong-type-arg\n-\t\t\t(lambda () (begin\n-\t\t\t\t; 6 == max distance between words to count.\n-\t\t\t\t; See docs above for explanation.\n-\t\t\t\t; (update-clique-pair-counts sent 6 #f)\n-\t\t\t\t(update-word-counts sent)\n-\t\t\t\t(update-lg-link-counts sent)\n-\t\t\t\t; If you uncomment this, be sure to also uncomment\n-\t\t\t\t; LgParseLink below, because LgParseMinimal is not enough.\n-\t\t\t\t; (update-disjunct-counts sent)\n-\t\t\t))\n-\t\t\t(lambda (key . args) #f)))\n-\n \t; Count the atoms in the sentence, according to the counting method\n \t; passed as argument, then delete the sentence.\n+\n+\t; Note: update-disjunct-counts commented out. It generates some\n+\t; data, but none of it will be interesting to most people.\n \t(define (process-sent SENT cnt-mode win-size)\n \t\t(update-word-counts SENT)\n \t\t(if (equal? cnt-mode \"any\")\n \t\t\t(update-lg-link-counts SENT)\n \t\t\t(update-clique-pair-counts SENT win-size #f))","path":"opencog/nlp/learn/scm/link-pipeline.scm","position":55,"original_position":55,"commit_id":"f6dc84932ce3e980e5749b6d4018f1f4413ef744","original_commit_id":"f6dc84932ce3e980e5749b6d4018f1f4413ef744","user":{"login":"linas","id":94368,"node_id":"MDQ6VXNlcjk0MzY4","avatar_url":"https://avatars2.githubusercontent.com/u/94368?v=4","gravatar_id":"","url":"https://api.github.com/users/linas","html_url":"https://github.com/linas","followers_url":"https://api.github.com/users/linas/followers","following_url":"https://api.github.com/users/linas/following{/other_user}","gists_url":"https://api.github.com/users/linas/gists{/gist_id}","starred_url":"https://api.github.com/users/linas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linas/subscriptions","organizations_url":"https://api.github.com/users/linas/orgs","repos_url":"https://api.github.com/users/linas/repos","events_url":"https://api.github.com/users/linas/events{/privacy}","received_events_url":"https://api.github.com/users/linas/received_events","type":"User","site_admin":false},"body":"Can you turn this into a case-statement? Currently, you wrote this so that if the mode is \"any\", then link-counting is used; otherwise, clique-pair counting is used as the default. It would be nicer to make this into an explicit case statement, with the two cases being \"any\" and \"clique\". \r\n\r\nAlso -- weren't you planning on having other modes besides just these two? Or was this all that was envisioned?","created_at":"2018-08-18T10:31:09Z","updated_at":"2018-08-18T10:31:09Z","html_url":"https://github.com/opencog/opencog/pull/3296#discussion_r211072205","pull_request_url":"https://api.github.com/repos/opencog/opencog/pulls/3296","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/opencog/opencog/pulls/comments/211072205"},"html":{"href":"https://github.com/opencog/opencog/pull/3296#discussion_r211072205"},"pull_request":{"href":"https://api.github.com/repos/opencog/opencog/pulls/3296"}}},"pull_request":{"url":"https://api.github.com/repos/opencog/opencog/pulls/3296","id":209174772,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MTc0Nzcy","html_url":"https://github.com/opencog/opencog/pull/3296","diff_url":"https://github.com/opencog/opencog/pull/3296.diff","patch_url":"https://github.com/opencog/opencog/pull/3296.patch","issue_url":"https://api.github.com/repos/opencog/opencog/issues/3296","number":3296,"state":"open","locked":false,"title":"Function description improvement","user":{"login":"glicerico","id":23503930,"node_id":"MDQ6VXNlcjIzNTAzOTMw","avatar_url":"https://avatars0.githubusercontent.com/u/23503930?v=4","gravatar_id":"","url":"https://api.github.com/users/glicerico","html_url":"https://github.com/glicerico","followers_url":"https://api.github.com/users/glicerico/followers","following_url":"https://api.github.com/users/glicerico/following{/other_user}","gists_url":"https://api.github.com/users/glicerico/gists{/gist_id}","starred_url":"https://api.github.com/users/glicerico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glicerico/subscriptions","organizations_url":"https://api.github.com/users/glicerico/orgs","repos_url":"https://api.github.com/users/glicerico/repos","events_url":"https://api.github.com/users/glicerico/events{/privacy}","received_events_url":"https://api.github.com/users/glicerico/received_events","type":"User","site_admin":false},"body":"- Corrected and added to documentation of observe-text-mode.\r\n- Removed try-catch wrapper. @linas , is it OK to remove this since relex is no longer used?","created_at":"2018-08-17T15:00:30Z","updated_at":"2018-08-18T10:31:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"965eca86215d4485f3c6b2011ea36a328e79c651","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/opencog/opencog/pulls/3296/commits","review_comments_url":"https://api.github.com/repos/opencog/opencog/pulls/3296/comments","review_comment_url":"https://api.github.com/repos/opencog/opencog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opencog/opencog/issues/3296/comments","statuses_url":"https://api.github.com/repos/opencog/opencog/statuses/f6dc84932ce3e980e5749b6d4018f1f4413ef744","head":{"label":"glicerico:missing_wrapper","ref":"missing_wrapper","sha":"f6dc84932ce3e980e5749b6d4018f1f4413ef744","user":{"login":"glicerico","id":23503930,"node_id":"MDQ6VXNlcjIzNTAzOTMw","avatar_url":"https://avatars0.githubusercontent.com/u/23503930?v=4","gravatar_id":"","url":"https://api.github.com/users/glicerico","html_url":"https://github.com/glicerico","followers_url":"https://api.github.com/users/glicerico/followers","following_url":"https://api.github.com/users/glicerico/following{/other_user}","gists_url":"https://api.github.com/users/glicerico/gists{/gist_id}","starred_url":"https://api.github.com/users/glicerico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glicerico/subscriptions","organizations_url":"https://api.github.com/users/glicerico/orgs","repos_url":"https://api.github.com/users/glicerico/repos","events_url":"https://api.github.com/users/glicerico/events{/privacy}","received_events_url":"https://api.github.com/users/glicerico/received_events","type":"User","site_admin":false},"repo":{"id":119954743,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk5NTQ3NDM=","name":"opencog","full_name":"glicerico/opencog","owner":{"login":"glicerico","id":23503930,"node_id":"MDQ6VXNlcjIzNTAzOTMw","avatar_url":"https://avatars0.githubusercontent.com/u/23503930?v=4","gravatar_id":"","url":"https://api.github.com/users/glicerico","html_url":"https://github.com/glicerico","followers_url":"https://api.github.com/users/glicerico/followers","following_url":"https://api.github.com/users/glicerico/following{/other_user}","gists_url":"https://api.github.com/users/glicerico/gists{/gist_id}","starred_url":"https://api.github.com/users/glicerico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glicerico/subscriptions","organizations_url":"https://api.github.com/users/glicerico/orgs","repos_url":"https://api.github.com/users/glicerico/repos","events_url":"https://api.github.com/users/glicerico/events{/privacy}","received_events_url":"https://api.github.com/users/glicerico/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/glicerico/opencog","description":"A framework for integrated Artificial Intelligence & Artificial General Intelligence (AGI)","fork":true,"url":"https://api.github.com/repos/glicerico/opencog","forks_url":"https://api.github.com/repos/glicerico/opencog/forks","keys_url":"https://api.github.com/repos/glicerico/opencog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/glicerico/opencog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/glicerico/opencog/teams","hooks_url":"https://api.github.com/repos/glicerico/opencog/hooks","issue_events_url":"https://api.github.com/repos/glicerico/opencog/issues/events{/number}","events_url":"https://api.github.com/repos/glicerico/opencog/events","assignees_url":"https://api.github.com/repos/glicerico/opencog/assignees{/user}","branches_url":"https://api.github.com/repos/glicerico/opencog/branches{/branch}","tags_url":"https://api.github.com/repos/glicerico/opencog/tags","blobs_url":"https://api.github.com/repos/glicerico/opencog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/glicerico/opencog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/glicerico/opencog/git/refs{/sha}","trees_url":"https://api.github.com/repos/glicerico/opencog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/glicerico/opencog/statuses/{sha}","languages_url":"https://api.github.com/repos/glicerico/opencog/languages","stargazers_url":"https://api.github.com/repos/glicerico/opencog/stargazers","contributors_url":"https://api.github.com/repos/glicerico/opencog/contributors","subscribers_url":"https://api.github.com/repos/glicerico/opencog/subscribers","subscription_url":"https://api.github.com/repos/glicerico/opencog/subscription","commits_url":"https://api.github.com/repos/glicerico/opencog/commits{/sha}","git_commits_url":"https://api.github.com/repos/glicerico/opencog/git/commits{/sha}","comments_url":"https://api.github.com/repos/glicerico/opencog/comments{/number}","issue_comment_url":"https://api.github.com/repos/glicerico/opencog/issues/comments{/number}","contents_url":"https://api.github.com/repos/glicerico/opencog/contents/{+path}","compare_url":"https://api.github.com/repos/glicerico/opencog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/glicerico/opencog/merges","archive_url":"https://api.github.com/repos/glicerico/opencog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/glicerico/opencog/downloads","issues_url":"https://api.github.com/repos/glicerico/opencog/issues{/number}","pulls_url":"https://api.github.com/repos/glicerico/opencog/pulls{/number}","milestones_url":"https://api.github.com/repos/glicerico/opencog/milestones{/number}","notifications_url":"https://api.github.com/repos/glicerico/opencog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/glicerico/opencog/labels{/name}","releases_url":"https://api.github.com/repos/glicerico/opencog/releases{/id}","deployments_url":"https://api.github.com/repos/glicerico/opencog/deployments","created_at":"2018-02-02T08:30:27Z","updated_at":"2018-06-19T05:56:23Z","pushed_at":"2018-08-17T15:01:09Z","git_url":"git://github.com/glicerico/opencog.git","ssh_url":"git@github.com:glicerico/opencog.git","clone_url":"https://github.com/glicerico/opencog.git","svn_url":"https://github.com/glicerico/opencog","homepage":"http://wiki.opencog.org/w/Development","size":181884,"stargazers_count":0,"watchers_count":0,"language":"Scheme","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opencog:master","ref":"master","sha":"07437419cd3651fa328c65465f985573c3e5c121","user":{"login":"opencog","id":2109913,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDk5MTM=","avatar_url":"https://avatars1.githubusercontent.com/u/2109913?v=4","gravatar_id":"","url":"https://api.github.com/users/opencog","html_url":"https://github.com/opencog","followers_url":"https://api.github.com/users/opencog/followers","following_url":"https://api.github.com/users/opencog/following{/other_user}","gists_url":"https://api.github.com/users/opencog/gists{/gist_id}","starred_url":"https://api.github.com/users/opencog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencog/subscriptions","organizations_url":"https://api.github.com/users/opencog/orgs","repos_url":"https://api.github.com/users/opencog/repos","events_url":"https://api.github.com/users/opencog/events{/privacy}","received_events_url":"https://api.github.com/users/opencog/received_events","type":"Organization","site_admin":false},"repo":{"id":6365343,"node_id":"MDEwOlJlcG9zaXRvcnk2MzY1MzQz","name":"opencog","full_name":"opencog/opencog","owner":{"login":"opencog","id":2109913,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDk5MTM=","avatar_url":"https://avatars1.githubusercontent.com/u/2109913?v=4","gravatar_id":"","url":"https://api.github.com/users/opencog","html_url":"https://github.com/opencog","followers_url":"https://api.github.com/users/opencog/followers","following_url":"https://api.github.com/users/opencog/following{/other_user}","gists_url":"https://api.github.com/users/opencog/gists{/gist_id}","starred_url":"https://api.github.com/users/opencog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencog/subscriptions","organizations_url":"https://api.github.com/users/opencog/orgs","repos_url":"https://api.github.com/users/opencog/repos","events_url":"https://api.github.com/users/opencog/events{/privacy}","received_events_url":"https://api.github.com/users/opencog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opencog/opencog","description":"A framework for integrated Artificial Intelligence & Artificial General Intelligence (AGI)","fork":false,"url":"https://api.github.com/repos/opencog/opencog","forks_url":"https://api.github.com/repos/opencog/opencog/forks","keys_url":"https://api.github.com/repos/opencog/opencog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opencog/opencog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opencog/opencog/teams","hooks_url":"https://api.github.com/repos/opencog/opencog/hooks","issue_events_url":"https://api.github.com/repos/opencog/opencog/issues/events{/number}","events_url":"https://api.github.com/repos/opencog/opencog/events","assignees_url":"https://api.github.com/repos/opencog/opencog/assignees{/user}","branches_url":"https://api.github.com/repos/opencog/opencog/branches{/branch}","tags_url":"https://api.github.com/repos/opencog/opencog/tags","blobs_url":"https://api.github.com/repos/opencog/opencog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opencog/opencog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opencog/opencog/git/refs{/sha}","trees_url":"https://api.github.com/repos/opencog/opencog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opencog/opencog/statuses/{sha}","languages_url":"https://api.github.com/repos/opencog/opencog/languages","stargazers_url":"https://api.github.com/repos/opencog/opencog/stargazers","contributors_url":"https://api.github.com/repos/opencog/opencog/contributors","subscribers_url":"https://api.github.com/repos/opencog/opencog/subscribers","subscription_url":"https://api.github.com/repos/opencog/opencog/subscription","commits_url":"https://api.github.com/repos/opencog/opencog/commits{/sha}","git_commits_url":"https://api.github.com/repos/opencog/opencog/git/commits{/sha}","comments_url":"https://api.github.com/repos/opencog/opencog/comments{/number}","issue_comment_url":"https://api.github.com/repos/opencog/opencog/issues/comments{/number}","contents_url":"https://api.github.com/repos/opencog/opencog/contents/{+path}","compare_url":"https://api.github.com/repos/opencog/opencog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opencog/opencog/merges","archive_url":"https://api.github.com/repos/opencog/opencog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opencog/opencog/downloads","issues_url":"https://api.github.com/repos/opencog/opencog/issues{/number}","pulls_url":"https://api.github.com/repos/opencog/opencog/pulls{/number}","milestones_url":"https://api.github.com/repos/opencog/opencog/milestones{/number}","notifications_url":"https://api.github.com/repos/opencog/opencog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opencog/opencog/labels{/name}","releases_url":"https://api.github.com/repos/opencog/opencog/releases{/id}","deployments_url":"https://api.github.com/repos/opencog/opencog/deployments","created_at":"2012-10-24T06:10:15Z","updated_at":"2018-08-18T09:47:16Z","pushed_at":"2018-08-18T09:47:11Z","git_url":"git://github.com/opencog/opencog.git","ssh_url":"git@github.com:opencog/opencog.git","clone_url":"https://github.com/opencog/opencog.git","svn_url":"https://github.com/opencog/opencog","homepage":"http://wiki.opencog.org/w/Development","size":181832,"stargazers_count":1544,"watchers_count":1544,"language":"Scheme","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":622,"mirror_url":null,"archived":false,"open_issues_count":86,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":622,"open_issues":86,"watchers":1544,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opencog/opencog/pulls/3296"},"html":{"href":"https://github.com/opencog/opencog/pull/3296"},"issue":{"href":"https://api.github.com/repos/opencog/opencog/issues/3296"},"comments":{"href":"https://api.github.com/repos/opencog/opencog/issues/3296/comments"},"review_comments":{"href":"https://api.github.com/repos/opencog/opencog/pulls/3296/comments"},"review_comment":{"href":"https://api.github.com/repos/opencog/opencog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opencog/opencog/pulls/3296/commits"},"statuses":{"href":"https://api.github.com/repos/opencog/opencog/statuses/f6dc84932ce3e980e5749b6d4018f1f4413ef744"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"linas"}}