{"action":"created","issue":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/14056","repository_url":"https://api.github.com/repos/xbmc/xbmc","labels_url":"https://api.github.com/repos/xbmc/xbmc/issues/14056/labels{/name}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/14056/comments","events_url":"https://api.github.com/repos/xbmc/xbmc/issues/14056/events","html_url":"https://github.com/xbmc/xbmc/pull/14056","id":332811397,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MjAzNDg3","number":14056,"title":"[Subtitles] Background color and background opacity settings","user":{"login":"enen92","id":7375276,"node_id":"MDQ6VXNlcjczNzUyNzY=","avatar_url":"https://avatars3.githubusercontent.com/u/7375276?v=4","gravatar_id":"","url":"https://api.github.com/users/enen92","html_url":"https://github.com/enen92","followers_url":"https://api.github.com/users/enen92/followers","following_url":"https://api.github.com/users/enen92/following{/other_user}","gists_url":"https://api.github.com/users/enen92/gists{/gist_id}","starred_url":"https://api.github.com/users/enen92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enen92/subscriptions","organizations_url":"https://api.github.com/users/enen92/orgs","repos_url":"https://api.github.com/users/enen92/repos","events_url":"https://api.github.com/users/enen92/events{/privacy}","received_events_url":"https://api.github.com/users/enen92/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-06-15T15:06:16Z","updated_at":"2018-06-26T18:38:43Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/14056","html_url":"https://github.com/xbmc/xbmc/pull/14056","diff_url":"https://github.com/xbmc/xbmc/pull/14056.diff","patch_url":"https://github.com/xbmc/xbmc/pull/14056.patch"},"body":"This pull requests adds two new settings in Player/Language settings. It enables Kodi to display subtitles with a background color (pre-defined list of colors) and an opacity percentage value.\r\n\r\n## Description\r\nThis is a feature present in major media players and have been requested in our forums several times. Requests for implementation date back to 2013 (e.g. https://forum.kodi.tv/showthread.php?tid=178478). Background is provided via an opaque texture drawn below the rendered glyphs. This is only enabled if the opacity of the background is not set to 0% otherwise behaviour stays exactly the same as before.\r\n\r\n## Motivation and Context\r\nSome media files have embed subtitles in the video stream - having subtitles with an opaque background makes the watching experience more pleasant. Furthermore a few users reported that even with the outline border in the subtitle font sometimes they can't read the subtitles correctly when the background is too bright. Furthermore, there are some addons in the forum that just re-write the original subtitle addons to convert the subtitles to ASS format so they can have a background.\r\n\r\n## How Has This Been Tested?\r\nRun time tested in OSX with 2 different subtitle fonts and multiple combinations of the settings.\r\n\r\n## Screenshots (if appropriate):\r\n- Before:\r\n\r\n![before](https://s33.postimg.cc/i729lxc1r/screenshot_before.png\r\n \"Before\")\r\n\r\n- After:\r\n![after1](https://s33.postimg.cc/t5dj4fdlb/screenshot000.png\r\n \"After 1\")\r\n![after2](https://s33.postimg.cc/a0a9uoecv/screenshot002.png\r\n \"After 3\")\r\n![after2](https://s33.postimg.cc/3ml6rf1r3/screenshot004.png\r\n \"After 3\")\r\n\r\nI am no C++ developer so let me know if anything can be improved. \r\n\r\n## Types of change\r\n<!--- What type of change does your code introduce? Put an `x` in all the boxes that apply like this: [X] -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] Improvement (non-breaking change which improves existing functionality)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply like this: [X] -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [ ] My code follows the [Code guidelines](https://codedocs.xyz/xbmc/xbmc/code_guidelines.html) of this project \r\n- [x] My change requires a change to the documentation, either Doxygen or wiki\r\n- [ ] I have updated the documentation accordingly\r\n- [x] I have read the [CONTRIBUTING](https://github.com/xbmc/xbmc/blob/master/CONTRIBUTING.md) document\r\n- [ ] I have added tests to cover my change\r\n- [ ] All new and existing tests passed\r\n"},"comment":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/comments/400419922","html_url":"https://github.com/xbmc/xbmc/pull/14056#issuecomment-400419922","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/14056","id":400419922,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDQxOTkyMg==","user":{"login":"FernetMenta","id":576009,"node_id":"MDQ6VXNlcjU3NjAwOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/576009?v=4","gravatar_id":"","url":"https://api.github.com/users/FernetMenta","html_url":"https://github.com/FernetMenta","followers_url":"https://api.github.com/users/FernetMenta/followers","following_url":"https://api.github.com/users/FernetMenta/following{/other_user}","gists_url":"https://api.github.com/users/FernetMenta/gists{/gist_id}","starred_url":"https://api.github.com/users/FernetMenta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FernetMenta/subscriptions","organizations_url":"https://api.github.com/users/FernetMenta/orgs","repos_url":"https://api.github.com/users/FernetMenta/repos","events_url":"https://api.github.com/users/FernetMenta/events{/privacy}","received_events_url":"https://api.github.com/users/FernetMenta/received_events","type":"User","site_admin":false},"created_at":"2018-06-26T18:38:43Z","updated_at":"2018-06-26T18:38:43Z","author_association":"MEMBER","body":"If you correct the other issue caused by reading the setting in ctor you solve this too."}}
{"actor":{"display_login":"FernetMenta"}}