{"action":"created","comment":{"url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/pulls/comments/221798721","pull_request_review_id":160535507,"id":221798721,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTc5ODcyMQ==","diff_hunk":"@@ -0,0 +1,49 @@\n+const {extname, basename, relative, sep} = require('path');\n+const resolve = require('eslint-module-utils/resolve').default;\n+\n+module.exports = {\n+  meta: {\n+    docs: {\n+      description:\n+        'Prefer imports from within a directory extend to the file from where they are importing without relying on an index file.',\n+      category: 'Best Practises',","path":"lib/rules/no-ancestor-directory-import.js","position":9,"original_position":9,"commit_id":"1723535d6b291c7c578eadde0c8869553e3c37ec","original_commit_id":"1723535d6b291c7c578eadde0c8869553e3c37ec","user":{"login":"lemonmade","id":3012583,"node_id":"MDQ6VXNlcjMwMTI1ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/3012583?v=4","gravatar_id":"","url":"https://api.github.com/users/lemonmade","html_url":"https://github.com/lemonmade","followers_url":"https://api.github.com/users/lemonmade/followers","following_url":"https://api.github.com/users/lemonmade/following{/other_user}","gists_url":"https://api.github.com/users/lemonmade/gists{/gist_id}","starred_url":"https://api.github.com/users/lemonmade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lemonmade/subscriptions","organizations_url":"https://api.github.com/users/lemonmade/orgs","repos_url":"https://api.github.com/users/lemonmade/repos","events_url":"https://api.github.com/users/lemonmade/events{/privacy}","received_events_url":"https://api.github.com/users/lemonmade/received_events","type":"User","site_admin":false},"body":"`Best practices`","created_at":"2018-10-02T00:44:34Z","updated_at":"2018-10-02T00:46:31Z","html_url":"https://github.com/Shopify/eslint-plugin-shopify/pull/149#discussion_r221798721","pull_request_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/pulls/149","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/pulls/comments/221798721"},"html":{"href":"https://github.com/Shopify/eslint-plugin-shopify/pull/149#discussion_r221798721"},"pull_request":{"href":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/pulls/149"}}},"pull_request":{"url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/pulls/149","id":211354835,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMzU0ODM1","html_url":"https://github.com/Shopify/eslint-plugin-shopify/pull/149","diff_url":"https://github.com/Shopify/eslint-plugin-shopify/pull/149.diff","patch_url":"https://github.com/Shopify/eslint-plugin-shopify/pull/149.patch","issue_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/issues/149","number":149,"state":"open","locked":false,"title":"Adds `no-ancestor-directory-import` rule","user":{"login":"cartogram","id":462077,"node_id":"MDQ6VXNlcjQ2MjA3Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/462077?v=4","gravatar_id":"","url":"https://api.github.com/users/cartogram","html_url":"https://github.com/cartogram","followers_url":"https://api.github.com/users/cartogram/followers","following_url":"https://api.github.com/users/cartogram/following{/other_user}","gists_url":"https://api.github.com/users/cartogram/gists{/gist_id}","starred_url":"https://api.github.com/users/cartogram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cartogram/subscriptions","organizations_url":"https://api.github.com/users/cartogram/orgs","repos_url":"https://api.github.com/users/cartogram/repos","events_url":"https://api.github.com/users/cartogram/events{/privacy}","received_events_url":"https://api.github.com/users/cartogram/received_events","type":"User","site_admin":false},"body":"Closes https://github.com/Shopify/eslint-plugin-shopify/issues/138\r\n\r\nIn addition to the code, feedback on the description and name of this rule would be really great. I found it to be a hard one to describe in words.\r\n\r\n","created_at":"2018-08-28T09:20:08Z","updated_at":"2018-10-02T00:46:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eecf1bfb27789d16915a0b46951bb7318e17d7e9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/pulls/149/commits","review_comments_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/pulls/149/comments","review_comment_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/issues/149/comments","statuses_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/statuses/1723535d6b291c7c578eadde0c8869553e3c37ec","head":{"label":"Shopify:prefer-explicit-relative-imports","ref":"prefer-explicit-relative-imports","sha":"1723535d6b291c7c578eadde0c8869553e3c37ec","user":{"login":"Shopify","id":8085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwODU=","avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":78081495,"node_id":"MDEwOlJlcG9zaXRvcnk3ODA4MTQ5NQ==","name":"eslint-plugin-shopify","full_name":"Shopify/eslint-plugin-shopify","private":false,"owner":{"login":"Shopify","id":8085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwODU=","avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Shopify/eslint-plugin-shopify","description":"Shopify’s ESLint rules and configs.","fork":false,"url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify","forks_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/forks","keys_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/teams","hooks_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/hooks","issue_events_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/events","assignees_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/tags","blobs_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/languages","stargazers_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/stargazers","contributors_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/contributors","subscribers_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/subscribers","subscription_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/subscription","commits_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/merges","archive_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/downloads","issues_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/deployments","created_at":"2017-01-05T05:11:19Z","updated_at":"2018-10-01T19:22:09Z","pushed_at":"2018-10-01T23:50:38Z","git_url":"git://github.com/Shopify/eslint-plugin-shopify.git","ssh_url":"git@github.com:Shopify/eslint-plugin-shopify.git","clone_url":"https://github.com/Shopify/eslint-plugin-shopify.git","svn_url":"https://github.com/Shopify/eslint-plugin-shopify","homepage":null,"size":923,"stargazers_count":31,"watchers_count":31,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":50,"license":null,"forks":8,"open_issues":50,"watchers":31,"default_branch":"master"}},"base":{"label":"Shopify:master","ref":"master","sha":"8586af3e38aa4fe8ef3af81b263bfac8f00a764b","user":{"login":"Shopify","id":8085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwODU=","avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":78081495,"node_id":"MDEwOlJlcG9zaXRvcnk3ODA4MTQ5NQ==","name":"eslint-plugin-shopify","full_name":"Shopify/eslint-plugin-shopify","private":false,"owner":{"login":"Shopify","id":8085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwODU=","avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Shopify/eslint-plugin-shopify","description":"Shopify’s ESLint rules and configs.","fork":false,"url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify","forks_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/forks","keys_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/teams","hooks_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/hooks","issue_events_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/events","assignees_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/tags","blobs_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/languages","stargazers_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/stargazers","contributors_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/contributors","subscribers_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/subscribers","subscription_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/subscription","commits_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/merges","archive_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/downloads","issues_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/deployments","created_at":"2017-01-05T05:11:19Z","updated_at":"2018-10-01T19:22:09Z","pushed_at":"2018-10-01T23:50:38Z","git_url":"git://github.com/Shopify/eslint-plugin-shopify.git","ssh_url":"git@github.com:Shopify/eslint-plugin-shopify.git","clone_url":"https://github.com/Shopify/eslint-plugin-shopify.git","svn_url":"https://github.com/Shopify/eslint-plugin-shopify","homepage":null,"size":923,"stargazers_count":31,"watchers_count":31,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":50,"license":null,"forks":8,"open_issues":50,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/pulls/149"},"html":{"href":"https://github.com/Shopify/eslint-plugin-shopify/pull/149"},"issue":{"href":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/issues/149"},"comments":{"href":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/issues/149/comments"},"review_comments":{"href":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/pulls/149/comments"},"review_comment":{"href":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/pulls/149/commits"},"statuses":{"href":"https://api.github.com/repos/Shopify/eslint-plugin-shopify/statuses/1723535d6b291c7c578eadde0c8869553e3c37ec"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lemonmade"}}