{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/comments/222105377","pull_request_review_id":160911412,"id":222105377,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjEwNTM3Nw==","diff_hunk":"@@ -230,4 +257,41 @@ MavenSettingsServerCredentials getMavenSettingsServerCredentials() {\n   boolean isBaseImageCredentialPresent() {\n     return isBaseImageCredentialPresent;\n   }\n+\n+  /**\n+   * Compute the container entrypoint, in this order :\n+   *\n+   * <ol>\n+   *   <li>the user specified one, if set\n+   *   <li>for a war project, the jetty default one\n+   *   <li>for a jar project, by resolving the main class\n+   * </ol>\n+   *\n+   * @param logger the logger used to display messages.\n+   * @param jibPluginConfiguration the {@link JibPluginConfiguration} providing the configuration\n+   *     data\n+   * @param projectProperties used for providing additional information\n+   * @return the entrypoint\n+   * @throws MojoExecutionException if the http timeout system property is misconfigured\n+   */\n+  static List<String> computeEntrypoint(\n+      Log logger,\n+      JibPluginConfiguration jibPluginConfiguration,\n+      MavenProjectProperties projectProperties)\n+      throws MojoExecutionException {\n+","path":"jib-maven-plugin/src/main/java/com/google/cloud/tools/jib/maven/PluginConfigurationProcessor.java","position":123,"original_position":123,"commit_id":"2090c099020b2b419dd5e230ed6dfb91d2958c60","original_commit_id":"2090c099020b2b419dd5e230ed6dfb91d2958c60","user":{"login":"coollog","id":4852522,"node_id":"MDQ6VXNlcjQ4NTI1MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/4852522?v=4","gravatar_id":"","url":"https://api.github.com/users/coollog","html_url":"https://github.com/coollog","followers_url":"https://api.github.com/users/coollog/followers","following_url":"https://api.github.com/users/coollog/following{/other_user}","gists_url":"https://api.github.com/users/coollog/gists{/gist_id}","starred_url":"https://api.github.com/users/coollog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coollog/subscriptions","organizations_url":"https://api.github.com/users/coollog/orgs","repos_url":"https://api.github.com/users/coollog/repos","events_url":"https://api.github.com/users/coollog/events{/privacy}","received_events_url":"https://api.github.com/users/coollog/received_events","type":"User","site_admin":false},"body":"style nit: no empty line at beginning of method","created_at":"2018-10-02T20:45:14Z","updated_at":"2018-10-02T20:47:00Z","html_url":"https://github.com/GoogleContainerTools/jib/pull/1068#discussion_r222105377","pull_request_url":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/1068","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/comments/222105377"},"html":{"href":"https://github.com/GoogleContainerTools/jib/pull/1068#discussion_r222105377"},"pull_request":{"href":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/1068"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/1068","id":219152616,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MTUyNjE2","html_url":"https://github.com/GoogleContainerTools/jib/pull/1068","diff_url":"https://github.com/GoogleContainerTools/jib/pull/1068.diff","patch_url":"https://github.com/GoogleContainerTools/jib/pull/1068.patch","issue_url":"https://api.github.com/repos/GoogleContainerTools/jib/issues/1068","number":1068,"state":"open","locked":false,"title":"Maven War support","user":{"login":"CyrilleH","id":4086479,"node_id":"MDQ6VXNlcjQwODY0Nzk=","avatar_url":"https://avatars0.githubusercontent.com/u/4086479?v=4","gravatar_id":"","url":"https://api.github.com/users/CyrilleH","html_url":"https://github.com/CyrilleH","followers_url":"https://api.github.com/users/CyrilleH/followers","following_url":"https://api.github.com/users/CyrilleH/following{/other_user}","gists_url":"https://api.github.com/users/CyrilleH/gists{/gist_id}","starred_url":"https://api.github.com/users/CyrilleH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CyrilleH/subscriptions","organizations_url":"https://api.github.com/users/CyrilleH/orgs","repos_url":"https://api.github.com/users/CyrilleH/repos","events_url":"https://api.github.com/users/CyrilleH/events{/privacy}","received_events_url":"https://api.github.com/users/CyrilleH/received_events","type":"User","site_admin":false},"body":"Towards #431, here's my proposal to support \"WAR\" project with Jib and Maven.\r\n\r\nThis PR is based from #923.\r\nOnce #923 is merged, I will rebase on master. So, please review only the last commit.","created_at":"2018-09-29T15:09:30Z","updated_at":"2018-10-02T20:47:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"826fae32d27894549d7cec7fdef19f84b45afc1e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1016518109,"node_id":"MDU6TGFiZWwxMDE2NTE4MTA5","url":"https://api.github.com/repos/GoogleContainerTools/jib/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/1068/commits","review_comments_url":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/1068/comments","review_comment_url":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleContainerTools/jib/issues/1068/comments","statuses_url":"https://api.github.com/repos/GoogleContainerTools/jib/statuses/2090c099020b2b419dd5e230ed6dfb91d2958c60","head":{"label":"CyrilleH:maven-war-support","ref":"maven-war-support","sha":"2090c099020b2b419dd5e230ed6dfb91d2958c60","user":{"login":"CyrilleH","id":4086479,"node_id":"MDQ6VXNlcjQwODY0Nzk=","avatar_url":"https://avatars0.githubusercontent.com/u/4086479?v=4","gravatar_id":"","url":"https://api.github.com/users/CyrilleH","html_url":"https://github.com/CyrilleH","followers_url":"https://api.github.com/users/CyrilleH/followers","following_url":"https://api.github.com/users/CyrilleH/following{/other_user}","gists_url":"https://api.github.com/users/CyrilleH/gists{/gist_id}","starred_url":"https://api.github.com/users/CyrilleH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CyrilleH/subscriptions","organizations_url":"https://api.github.com/users/CyrilleH/orgs","repos_url":"https://api.github.com/users/CyrilleH/repos","events_url":"https://api.github.com/users/CyrilleH/events{/privacy}","received_events_url":"https://api.github.com/users/CyrilleH/received_events","type":"User","site_admin":false},"repo":{"id":145115599,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUxMTU1OTk=","name":"jib","full_name":"CyrilleH/jib","private":false,"owner":{"login":"CyrilleH","id":4086479,"node_id":"MDQ6VXNlcjQwODY0Nzk=","avatar_url":"https://avatars0.githubusercontent.com/u/4086479?v=4","gravatar_id":"","url":"https://api.github.com/users/CyrilleH","html_url":"https://github.com/CyrilleH","followers_url":"https://api.github.com/users/CyrilleH/followers","following_url":"https://api.github.com/users/CyrilleH/following{/other_user}","gists_url":"https://api.github.com/users/CyrilleH/gists{/gist_id}","starred_url":"https://api.github.com/users/CyrilleH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CyrilleH/subscriptions","organizations_url":"https://api.github.com/users/CyrilleH/orgs","repos_url":"https://api.github.com/users/CyrilleH/repos","events_url":"https://api.github.com/users/CyrilleH/events{/privacy}","received_events_url":"https://api.github.com/users/CyrilleH/received_events","type":"User","site_admin":false},"html_url":"https://github.com/CyrilleH/jib","description":":sailboat: Build container images for your Java applications.","fork":true,"url":"https://api.github.com/repos/CyrilleH/jib","forks_url":"https://api.github.com/repos/CyrilleH/jib/forks","keys_url":"https://api.github.com/repos/CyrilleH/jib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CyrilleH/jib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CyrilleH/jib/teams","hooks_url":"https://api.github.com/repos/CyrilleH/jib/hooks","issue_events_url":"https://api.github.com/repos/CyrilleH/jib/issues/events{/number}","events_url":"https://api.github.com/repos/CyrilleH/jib/events","assignees_url":"https://api.github.com/repos/CyrilleH/jib/assignees{/user}","branches_url":"https://api.github.com/repos/CyrilleH/jib/branches{/branch}","tags_url":"https://api.github.com/repos/CyrilleH/jib/tags","blobs_url":"https://api.github.com/repos/CyrilleH/jib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CyrilleH/jib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CyrilleH/jib/git/refs{/sha}","trees_url":"https://api.github.com/repos/CyrilleH/jib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CyrilleH/jib/statuses/{sha}","languages_url":"https://api.github.com/repos/CyrilleH/jib/languages","stargazers_url":"https://api.github.com/repos/CyrilleH/jib/stargazers","contributors_url":"https://api.github.com/repos/CyrilleH/jib/contributors","subscribers_url":"https://api.github.com/repos/CyrilleH/jib/subscribers","subscription_url":"https://api.github.com/repos/CyrilleH/jib/subscription","commits_url":"https://api.github.com/repos/CyrilleH/jib/commits{/sha}","git_commits_url":"https://api.github.com/repos/CyrilleH/jib/git/commits{/sha}","comments_url":"https://api.github.com/repos/CyrilleH/jib/comments{/number}","issue_comment_url":"https://api.github.com/repos/CyrilleH/jib/issues/comments{/number}","contents_url":"https://api.github.com/repos/CyrilleH/jib/contents/{+path}","compare_url":"https://api.github.com/repos/CyrilleH/jib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CyrilleH/jib/merges","archive_url":"https://api.github.com/repos/CyrilleH/jib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CyrilleH/jib/downloads","issues_url":"https://api.github.com/repos/CyrilleH/jib/issues{/number}","pulls_url":"https://api.github.com/repos/CyrilleH/jib/pulls{/number}","milestones_url":"https://api.github.com/repos/CyrilleH/jib/milestones{/number}","notifications_url":"https://api.github.com/repos/CyrilleH/jib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CyrilleH/jib/labels{/name}","releases_url":"https://api.github.com/repos/CyrilleH/jib/releases{/id}","deployments_url":"https://api.github.com/repos/CyrilleH/jib/deployments","created_at":"2018-08-17T12:03:45Z","updated_at":"2018-09-02T05:51:38Z","pushed_at":"2018-10-01T23:05:30Z","git_url":"git://github.com/CyrilleH/jib.git","ssh_url":"git@github.com:CyrilleH/jib.git","clone_url":"https://github.com/CyrilleH/jib.git","svn_url":"https://github.com/CyrilleH/jib","homepage":"","size":5562,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"GoogleContainerTools:master","ref":"master","sha":"ffddc9f8899a17c5530e191ad939398856a7e7de","user":{"login":"GoogleContainerTools","id":38444003,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NDQ0MDAz","avatar_url":"https://avatars1.githubusercontent.com/u/38444003?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleContainerTools","html_url":"https://github.com/GoogleContainerTools","followers_url":"https://api.github.com/users/GoogleContainerTools/followers","following_url":"https://api.github.com/users/GoogleContainerTools/following{/other_user}","gists_url":"https://api.github.com/users/GoogleContainerTools/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleContainerTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleContainerTools/subscriptions","organizations_url":"https://api.github.com/users/GoogleContainerTools/orgs","repos_url":"https://api.github.com/users/GoogleContainerTools/repos","events_url":"https://api.github.com/users/GoogleContainerTools/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleContainerTools/received_events","type":"Organization","site_admin":false},"repo":{"id":118497841,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg0OTc4NDE=","name":"jib","full_name":"GoogleContainerTools/jib","private":false,"owner":{"login":"GoogleContainerTools","id":38444003,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NDQ0MDAz","avatar_url":"https://avatars1.githubusercontent.com/u/38444003?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleContainerTools","html_url":"https://github.com/GoogleContainerTools","followers_url":"https://api.github.com/users/GoogleContainerTools/followers","following_url":"https://api.github.com/users/GoogleContainerTools/following{/other_user}","gists_url":"https://api.github.com/users/GoogleContainerTools/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleContainerTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleContainerTools/subscriptions","organizations_url":"https://api.github.com/users/GoogleContainerTools/orgs","repos_url":"https://api.github.com/users/GoogleContainerTools/repos","events_url":"https://api.github.com/users/GoogleContainerTools/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleContainerTools/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GoogleContainerTools/jib","description":":sailboat: Build container images for your Java applications.","fork":false,"url":"https://api.github.com/repos/GoogleContainerTools/jib","forks_url":"https://api.github.com/repos/GoogleContainerTools/jib/forks","keys_url":"https://api.github.com/repos/GoogleContainerTools/jib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleContainerTools/jib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleContainerTools/jib/teams","hooks_url":"https://api.github.com/repos/GoogleContainerTools/jib/hooks","issue_events_url":"https://api.github.com/repos/GoogleContainerTools/jib/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleContainerTools/jib/events","assignees_url":"https://api.github.com/repos/GoogleContainerTools/jib/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleContainerTools/jib/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleContainerTools/jib/tags","blobs_url":"https://api.github.com/repos/GoogleContainerTools/jib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleContainerTools/jib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleContainerTools/jib/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleContainerTools/jib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleContainerTools/jib/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleContainerTools/jib/languages","stargazers_url":"https://api.github.com/repos/GoogleContainerTools/jib/stargazers","contributors_url":"https://api.github.com/repos/GoogleContainerTools/jib/contributors","subscribers_url":"https://api.github.com/repos/GoogleContainerTools/jib/subscribers","subscription_url":"https://api.github.com/repos/GoogleContainerTools/jib/subscription","commits_url":"https://api.github.com/repos/GoogleContainerTools/jib/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleContainerTools/jib/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleContainerTools/jib/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleContainerTools/jib/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleContainerTools/jib/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleContainerTools/jib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleContainerTools/jib/merges","archive_url":"https://api.github.com/repos/GoogleContainerTools/jib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleContainerTools/jib/downloads","issues_url":"https://api.github.com/repos/GoogleContainerTools/jib/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleContainerTools/jib/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleContainerTools/jib/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleContainerTools/jib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleContainerTools/jib/labels{/name}","releases_url":"https://api.github.com/repos/GoogleContainerTools/jib/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleContainerTools/jib/deployments","created_at":"2018-01-22T18:30:43Z","updated_at":"2018-10-02T20:08:43Z","pushed_at":"2018-10-02T20:46:32Z","git_url":"git://github.com/GoogleContainerTools/jib.git","ssh_url":"git@github.com:GoogleContainerTools/jib.git","clone_url":"https://github.com/GoogleContainerTools/jib.git","svn_url":"https://github.com/GoogleContainerTools/jib","homepage":"","size":5827,"stargazers_count":4617,"watchers_count":4617,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":330,"mirror_url":null,"archived":false,"open_issues_count":96,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":330,"open_issues":96,"watchers":4617,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/1068"},"html":{"href":"https://github.com/GoogleContainerTools/jib/pull/1068"},"issue":{"href":"https://api.github.com/repos/GoogleContainerTools/jib/issues/1068"},"comments":{"href":"https://api.github.com/repos/GoogleContainerTools/jib/issues/1068/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/1068/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/1068/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleContainerTools/jib/statuses/2090c099020b2b419dd5e230ed6dfb91d2958c60"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"coollog"}}