{"action":"created","issue":{"url":"https://api.github.com/repos/whiteoctober/BreadcrumbsBundle/issues/87","repository_url":"https://api.github.com/repos/whiteoctober/BreadcrumbsBundle","labels_url":"https://api.github.com/repos/whiteoctober/BreadcrumbsBundle/issues/87/labels{/name}","comments_url":"https://api.github.com/repos/whiteoctober/BreadcrumbsBundle/issues/87/comments","events_url":"https://api.github.com/repos/whiteoctober/BreadcrumbsBundle/issues/87/events","html_url":"https://github.com/whiteoctober/BreadcrumbsBundle/issues/87","id":291909965,"number":87,"title":"Support PHP-PM by resetting state","user":{"login":"Sander-Toonen","id":5106372,"avatar_url":"https://avatars1.githubusercontent.com/u/5106372?v=4","gravatar_id":"","url":"https://api.github.com/users/Sander-Toonen","html_url":"https://github.com/Sander-Toonen","followers_url":"https://api.github.com/users/Sander-Toonen/followers","following_url":"https://api.github.com/users/Sander-Toonen/following{/other_user}","gists_url":"https://api.github.com/users/Sander-Toonen/gists{/gist_id}","starred_url":"https://api.github.com/users/Sander-Toonen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sander-Toonen/subscriptions","organizations_url":"https://api.github.com/users/Sander-Toonen/orgs","repos_url":"https://api.github.com/users/Sander-Toonen/repos","events_url":"https://api.github.com/users/Sander-Toonen/events{/privacy}","received_events_url":"https://api.github.com/users/Sander-Toonen/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-01-26T14:01:47Z","updated_at":"2018-05-01T09:58:48Z","closed_at":"2018-05-01T09:42:00Z","author_association":"CONTRIBUTOR","body":"When using this bundle with [php-pm](https://github.com/php-pm/php-pm) the breadcrumbs show alls paths that all previous users have visited. E.g:\r\n\r\n> Home > Register > Home > Profile > Change Password > Home > Contact > Home > Contact, ... etc\r\n\r\nThis happens because `WhiteOctober\\BreadcrumbsBundle\\Model\\Breadcrumbs` is a service that keeps state. Symfony 3.3 [added](https://github.com/symfony/symfony/pull/24155) a dependency injection tag that allows Symfony to call a `reset()`-method on the service after a request has been processed. This way, services can clean up any state so that a next request can be processed.\r\n\r\nSymfony itself is already resetting certain services: https://github.com/symfony/symfony/issues/23984 \r\n\r\nSince the Breadcrumbs class already has a `clear()` method that does exactly what is needed, adding the DI-tag should be all that is needed. I'll add a PR soon.\r\n"},"comment":{"url":"https://api.github.com/repos/whiteoctober/BreadcrumbsBundle/issues/comments/385637842","html_url":"https://github.com/whiteoctober/BreadcrumbsBundle/issues/87#issuecomment-385637842","issue_url":"https://api.github.com/repos/whiteoctober/BreadcrumbsBundle/issues/87","id":385637842,"user":{"login":"sampart","id":1507328,"avatar_url":"https://avatars1.githubusercontent.com/u/1507328?v=4","gravatar_id":"","url":"https://api.github.com/users/sampart","html_url":"https://github.com/sampart","followers_url":"https://api.github.com/users/sampart/followers","following_url":"https://api.github.com/users/sampart/following{/other_user}","gists_url":"https://api.github.com/users/sampart/gists{/gist_id}","starred_url":"https://api.github.com/users/sampart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sampart/subscriptions","organizations_url":"https://api.github.com/users/sampart/orgs","repos_url":"https://api.github.com/users/sampart/repos","events_url":"https://api.github.com/users/sampart/events{/privacy}","received_events_url":"https://api.github.com/users/sampart/received_events","type":"User","site_admin":false},"created_at":"2018-05-01T09:58:48Z","updated_at":"2018-05-01T09:58:48Z","author_association":"OWNER","body":"Thanks all for your patience & contributions.  This is now in release https://github.com/whiteoctober/BreadcrumbsBundle/releases/tag/1.4.2."}}
{"actor":{"display_login":"sampart"}}