{"action":"created","issue":{"url":"https://api.github.com/repos/richclement/NLog.Redis/issues/7","repository_url":"https://api.github.com/repos/richclement/NLog.Redis","labels_url":"https://api.github.com/repos/richclement/NLog.Redis/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/richclement/NLog.Redis/issues/7/comments","events_url":"https://api.github.com/repos/richclement/NLog.Redis/issues/7/events","html_url":"https://github.com/richclement/NLog.Redis/pull/7","id":314438647,"node_id":"MDExOlB1bGxSZXF1ZXN0MTgxNzEyNjkw","number":7,"title":"Added support for NetStandard15 and changed to VS2017","user":{"login":"snakefoot","id":11509660,"node_id":"MDQ6VXNlcjExNTA5NjYw","avatar_url":"https://avatars3.githubusercontent.com/u/11509660?v=4","gravatar_id":"","url":"https://api.github.com/users/snakefoot","html_url":"https://github.com/snakefoot","followers_url":"https://api.github.com/users/snakefoot/followers","following_url":"https://api.github.com/users/snakefoot/following{/other_user}","gists_url":"https://api.github.com/users/snakefoot/gists{/gist_id}","starred_url":"https://api.github.com/users/snakefoot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snakefoot/subscriptions","organizations_url":"https://api.github.com/users/snakefoot/orgs","repos_url":"https://api.github.com/users/snakefoot/repos","events_url":"https://api.github.com/users/snakefoot/events{/privacy}","received_events_url":"https://api.github.com/users/snakefoot/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":22,"created_at":"2018-04-15T18:18:04Z","updated_at":"2018-10-08T22:41:24Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/richclement/NLog.Redis/pulls/7","html_url":"https://github.com/richclement/NLog.Redis/pull/7","diff_url":"https://github.com/richclement/NLog.Redis/pull/7.diff","patch_url":"https://github.com/richclement/NLog.Redis/pull/7.patch"},"body":"This will build the nuget-package:\r\n\r\n`dotnet pack .\\src\\NLog.Redis --configuration Release --include-symbols`\r\n\r\nHave to update appveyor to use VS2017-image."},"comment":{"url":"https://api.github.com/repos/richclement/NLog.Redis/issues/comments/428002127","html_url":"https://github.com/richclement/NLog.Redis/pull/7#issuecomment-428002127","issue_url":"https://api.github.com/repos/richclement/NLog.Redis/issues/7","id":428002127,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODAwMjEyNw==","user":{"login":"Silvenga","id":2753330,"node_id":"MDQ6VXNlcjI3NTMzMzA=","avatar_url":"https://avatars0.githubusercontent.com/u/2753330?v=4","gravatar_id":"","url":"https://api.github.com/users/Silvenga","html_url":"https://github.com/Silvenga","followers_url":"https://api.github.com/users/Silvenga/followers","following_url":"https://api.github.com/users/Silvenga/following{/other_user}","gists_url":"https://api.github.com/users/Silvenga/gists{/gist_id}","starred_url":"https://api.github.com/users/Silvenga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Silvenga/subscriptions","organizations_url":"https://api.github.com/users/Silvenga/orgs","repos_url":"https://api.github.com/users/Silvenga/repos","events_url":"https://api.github.com/users/Silvenga/events{/privacy}","received_events_url":"https://api.github.com/users/Silvenga/received_events","type":"User","site_admin":false},"created_at":"2018-10-08T22:41:24Z","updated_at":"2018-10-08T22:41:24Z","author_association":"NONE","body":"> I never have problems with forks in git/github. Could you please elaborate on that?\r\n\r\nJust an annoyance, a couple of things I've seen:  \r\n\r\n- Github likes to treat forks as a pre-pull request - so Github likes to constantly suggest to create a pull request to the root.\r\n- A weird metrics oddity (you can see with https://github.com/Silvenga/btsync-deb or ~Jenkins~), Github won't record commits on your account unless they are merged into the root (I'm assuming to prevent double commits).\r\n- Github tries to be helpful with the UI - autofilling with the root of the fork (sometimes a little annoying): \r\n![image](https://user-images.githubusercontent.com/2753330/46636251-fa14f380-cb1c-11e8-8bac-fb02c568fb0b.png)\r\n- Weird things that happen when the main repo is removed by the owner - experienced that with EdiWeave (https://github.com/Silvenga/EdiWeave). A random fork becomes the root.\r\n\r\nIt actually looks like Jenkins's root repo (https://github.com/jenkinsci/jenkins) was coverted to a root repo - the repo is no longer a fork (it used to be, and it was annoying).\r\n\r\n> What about NLog.Target.Redis?\r\n\r\nMy only worry is that the name is a single character off from `NLog.Targets.Redis`. I can see people mistyping that really easily (especially with the dotnet CLI) and getting confused with what the difference is.\r\n\r\nAlso, `NLog.Target.Redis` kind of exists too (https://github.com/mattgwagner/NLog.Targets.Redis) - via https://www.nuget.org/packages/renanmt_NLog.Target.Redis/. \r\n\r\nI wonder how hard it would be merging the API for `NLog.Targets.Redis` (https://www.nuget.org/packages/NLog.Targets.Redis) with `NLog.Redis` - then taking over that package. I think @diadistis is the owner of this nuget package."}}
{"actor":{"display_login":"Silvenga"}}