{"action":"created","comment":{"url":"https://api.github.com/repos/DataDog/integrations-core/pulls/comments/240598169","pull_request_review_id":183658504,"id":240598169,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDU5ODE2OQ==","diff_hunk":"@@ -82,8 +82,7 @@ instances:\n         domain:\n             id: <DOMAIN_ID>\n \n-\n-  ## @param collect_hypervisor_load - optional - boolean - default:false\n+  ## @param collect_hypervisor_metrics - optional - boolean - default:false","path":"openstack_controller/datadog_checks/openstack_controller/data/conf.yaml.example","position":6,"original_position":6,"commit_id":"890c0e67cc0bfd1cd46eba18f4fab398d3a85a8c","original_commit_id":"890c0e67cc0bfd1cd46eba18f4fab398d3a85a8c","user":{"login":"masci","id":7241,"node_id":"MDQ6VXNlcjcyNDE=","avatar_url":"https://avatars3.githubusercontent.com/u/7241?v=4","gravatar_id":"","url":"https://api.github.com/users/masci","html_url":"https://github.com/masci","followers_url":"https://api.github.com/users/masci/followers","following_url":"https://api.github.com/users/masci/following{/other_user}","gists_url":"https://api.github.com/users/masci/gists{/gist_id}","starred_url":"https://api.github.com/users/masci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masci/subscriptions","organizations_url":"https://api.github.com/users/masci/orgs","repos_url":"https://api.github.com/users/masci/repos","events_url":"https://api.github.com/users/masci/events{/privacy}","received_events_url":"https://api.github.com/users/masci/received_events","type":"User","site_admin":false},"body":"The option is still `collect_hypervisor_load` at line 91","created_at":"2018-12-11T12:55:51Z","updated_at":"2018-12-11T12:57:36Z","html_url":"https://github.com/DataDog/integrations-core/pull/2709#discussion_r240598169","pull_request_url":"https://api.github.com/repos/DataDog/integrations-core/pulls/2709","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/DataDog/integrations-core/pulls/comments/240598169"},"html":{"href":"https://github.com/DataDog/integrations-core/pull/2709#discussion_r240598169"},"pull_request":{"href":"https://api.github.com/repos/DataDog/integrations-core/pulls/2709"}}},"pull_request":{"url":"https://api.github.com/repos/DataDog/integrations-core/pulls/2709","id":237387743,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3Mzg3NzQz","html_url":"https://github.com/DataDog/integrations-core/pull/2709","diff_url":"https://github.com/DataDog/integrations-core/pull/2709.diff","patch_url":"https://github.com/DataDog/integrations-core/pull/2709.patch","issue_url":"https://api.github.com/repos/DataDog/integrations-core/issues/2709","number":2709,"state":"open","locked":false,"title":"[openstack_controller] Performance improvements","user":{"login":"gzussa","id":280942,"node_id":"MDQ6VXNlcjI4MDk0Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/280942?v=4","gravatar_id":"","url":"https://api.github.com/users/gzussa","html_url":"https://github.com/gzussa","followers_url":"https://api.github.com/users/gzussa/followers","following_url":"https://api.github.com/users/gzussa/following{/other_user}","gists_url":"https://api.github.com/users/gzussa/gists{/gist_id}","starred_url":"https://api.github.com/users/gzussa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gzussa/subscriptions","organizations_url":"https://api.github.com/users/gzussa/orgs","repos_url":"https://api.github.com/users/gzussa/repos","events_url":"https://api.github.com/users/gzussa/events{/privacy}","received_events_url":"https://api.github.com/users/gzussa/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\n\r\nPerformance improvements for Openstack controller integration.\r\n- Removed calls to `/v3/projects/<id>` in favor of the more generic `/v3/projects` API call.\r\n- Removes `filter_excluded_servers()` logic since we first filter projects and then get metrics for these servers\r\n- Removes calls to `/networks/id` endpoints in favor of the more generic `/networks` endpoint.\r\n- Added configs to enable/disable metrics collection (this is also to help mesure perf impact per collection types):\r\n  - `collect_project_metrics` => calls to `/limits` api\r\n  - `collect_hypervisor_metrics` => disable hypervisor metrics submission only and override `collect_hypervisor_load`\r\n  - `collect_network_metrics` => calls to `/networks` api\r\n  - `collect_server_metrics` => calls to `../diagnostics`, `servers/detail` apis\r\n\r\n### Motivation\r\n\r\nOpenstack_controller integration has been created based on the openstack integration. Initially a POC, this PR is part of the performance improvement work to make this integration more robust and fast.\r\n\r\n### Review checklist\r\n\r\n- [ ] PR has a [meaningful title](https://github.com/DataDog/integrations-core/blob/master/CONTRIBUTING.md#pull-request-title) or PR has the `no-changelog` label attached\r\n- [ ] Feature or bugfix has tests\r\n- [ ] Git history is clean\r\n- [ ] If PR impacts documentation, docs team has been notified or an issue has been opened on the [documentation repo](https://github.com/DataDog/documentation/issues/new)\r\n- [x] If PR adds a configuration option, it has been added to the configuration file.\r\n\r\n### Additional Notes\r\n\r\nAnything else we should know when reviewing?\r\n","created_at":"2018-12-10T16:40:31Z","updated_at":"2018-12-11T12:57:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3b8419ff84b829c544320ef869dab7be67a19104","assignee":null,"assignees":[],"requested_reviewers":[{"login":"nmuesch","id":8941884,"node_id":"MDQ6VXNlcjg5NDE4ODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/8941884?v=4","gravatar_id":"","url":"https://api.github.com/users/nmuesch","html_url":"https://github.com/nmuesch","followers_url":"https://api.github.com/users/nmuesch/followers","following_url":"https://api.github.com/users/nmuesch/following{/other_user}","gists_url":"https://api.github.com/users/nmuesch/gists{/gist_id}","starred_url":"https://api.github.com/users/nmuesch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmuesch/subscriptions","organizations_url":"https://api.github.com/users/nmuesch/orgs","repos_url":"https://api.github.com/users/nmuesch/repos","events_url":"https://api.github.com/users/nmuesch/events{/privacy}","received_events_url":"https://api.github.com/users/nmuesch/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":937215339,"node_id":"MDU6TGFiZWw5MzcyMTUzMzk=","url":"https://api.github.com/repos/DataDog/integrations-core/labels/changelog/Added","name":"changelog/Added","color":"f2983e","default":false},{"id":1111885352,"node_id":"MDU6TGFiZWwxMTExODg1MzUy","url":"https://api.github.com/repos/DataDog/integrations-core/labels/integration/openstack_controller","name":"integration/openstack_controller","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DataDog/integrations-core/pulls/2709/commits","review_comments_url":"https://api.github.com/repos/DataDog/integrations-core/pulls/2709/comments","review_comment_url":"https://api.github.com/repos/DataDog/integrations-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DataDog/integrations-core/issues/2709/comments","statuses_url":"https://api.github.com/repos/DataDog/integrations-core/statuses/890c0e67cc0bfd1cd46eba18f4fab398d3a85a8c","head":{"label":"DataDog:gzu/openstack_controller_perf","ref":"gzu/openstack_controller_perf","sha":"890c0e67cc0bfd1cd46eba18f4fab398d3a85a8c","user":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":47203045,"node_id":"MDEwOlJlcG9zaXRvcnk0NzIwMzA0NQ==","name":"integrations-core","full_name":"DataDog/integrations-core","private":false,"owner":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DataDog/integrations-core","description":"Core integrations of the Datadog Agent","fork":false,"url":"https://api.github.com/repos/DataDog/integrations-core","forks_url":"https://api.github.com/repos/DataDog/integrations-core/forks","keys_url":"https://api.github.com/repos/DataDog/integrations-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/integrations-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/integrations-core/teams","hooks_url":"https://api.github.com/repos/DataDog/integrations-core/hooks","issue_events_url":"https://api.github.com/repos/DataDog/integrations-core/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/integrations-core/events","assignees_url":"https://api.github.com/repos/DataDog/integrations-core/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/integrations-core/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/integrations-core/tags","blobs_url":"https://api.github.com/repos/DataDog/integrations-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/integrations-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/integrations-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/integrations-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/integrations-core/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/integrations-core/languages","stargazers_url":"https://api.github.com/repos/DataDog/integrations-core/stargazers","contributors_url":"https://api.github.com/repos/DataDog/integrations-core/contributors","subscribers_url":"https://api.github.com/repos/DataDog/integrations-core/subscribers","subscription_url":"https://api.github.com/repos/DataDog/integrations-core/subscription","commits_url":"https://api.github.com/repos/DataDog/integrations-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/integrations-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/integrations-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/integrations-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/integrations-core/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/integrations-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/integrations-core/merges","archive_url":"https://api.github.com/repos/DataDog/integrations-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/integrations-core/downloads","issues_url":"https://api.github.com/repos/DataDog/integrations-core/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/integrations-core/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/integrations-core/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/integrations-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/integrations-core/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/integrations-core/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/integrations-core/deployments","created_at":"2015-12-01T16:41:45Z","updated_at":"2018-12-11T08:07:41Z","pushed_at":"2018-12-11T09:23:24Z","git_url":"git://github.com/DataDog/integrations-core.git","ssh_url":"git@github.com:DataDog/integrations-core.git","clone_url":"https://github.com/DataDog/integrations-core.git","svn_url":"https://github.com/DataDog/integrations-core","homepage":"","size":31225,"stargazers_count":185,"watchers_count":185,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":360,"mirror_url":null,"archived":false,"open_issues_count":52,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":360,"open_issues":52,"watchers":185,"default_branch":"master"}},"base":{"label":"DataDog:master","ref":"master","sha":"69b6f2769cb1a84bbd3805557929d796353ba532","user":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":47203045,"node_id":"MDEwOlJlcG9zaXRvcnk0NzIwMzA0NQ==","name":"integrations-core","full_name":"DataDog/integrations-core","private":false,"owner":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DataDog/integrations-core","description":"Core integrations of the Datadog Agent","fork":false,"url":"https://api.github.com/repos/DataDog/integrations-core","forks_url":"https://api.github.com/repos/DataDog/integrations-core/forks","keys_url":"https://api.github.com/repos/DataDog/integrations-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/integrations-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/integrations-core/teams","hooks_url":"https://api.github.com/repos/DataDog/integrations-core/hooks","issue_events_url":"https://api.github.com/repos/DataDog/integrations-core/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/integrations-core/events","assignees_url":"https://api.github.com/repos/DataDog/integrations-core/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/integrations-core/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/integrations-core/tags","blobs_url":"https://api.github.com/repos/DataDog/integrations-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/integrations-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/integrations-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/integrations-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/integrations-core/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/integrations-core/languages","stargazers_url":"https://api.github.com/repos/DataDog/integrations-core/stargazers","contributors_url":"https://api.github.com/repos/DataDog/integrations-core/contributors","subscribers_url":"https://api.github.com/repos/DataDog/integrations-core/subscribers","subscription_url":"https://api.github.com/repos/DataDog/integrations-core/subscription","commits_url":"https://api.github.com/repos/DataDog/integrations-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/integrations-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/integrations-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/integrations-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/integrations-core/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/integrations-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/integrations-core/merges","archive_url":"https://api.github.com/repos/DataDog/integrations-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/integrations-core/downloads","issues_url":"https://api.github.com/repos/DataDog/integrations-core/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/integrations-core/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/integrations-core/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/integrations-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/integrations-core/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/integrations-core/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/integrations-core/deployments","created_at":"2015-12-01T16:41:45Z","updated_at":"2018-12-11T08:07:41Z","pushed_at":"2018-12-11T09:23:24Z","git_url":"git://github.com/DataDog/integrations-core.git","ssh_url":"git@github.com:DataDog/integrations-core.git","clone_url":"https://github.com/DataDog/integrations-core.git","svn_url":"https://github.com/DataDog/integrations-core","homepage":"","size":31225,"stargazers_count":185,"watchers_count":185,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":360,"mirror_url":null,"archived":false,"open_issues_count":52,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":360,"open_issues":52,"watchers":185,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DataDog/integrations-core/pulls/2709"},"html":{"href":"https://github.com/DataDog/integrations-core/pull/2709"},"issue":{"href":"https://api.github.com/repos/DataDog/integrations-core/issues/2709"},"comments":{"href":"https://api.github.com/repos/DataDog/integrations-core/issues/2709/comments"},"review_comments":{"href":"https://api.github.com/repos/DataDog/integrations-core/pulls/2709/comments"},"review_comment":{"href":"https://api.github.com/repos/DataDog/integrations-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DataDog/integrations-core/pulls/2709/commits"},"statuses":{"href":"https://api.github.com/repos/DataDog/integrations-core/statuses/890c0e67cc0bfd1cd46eba18f4fab398d3a85a8c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"masci"}}