{"action":"created","comment":{"url":"https://api.github.com/repos/OSGeo/proj.4/pulls/comments/237303987","pull_request_review_id":179569524,"id":237303987,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzMwMzk4Nw==","diff_hunk":"@@ -138,6 +137,18 @@ static PJ_COORD fwd_finalize (PJ *P, PJ_COORD coo) {\n \n     case PJ_IO_UNITS_ANGULAR:\n         coo.lpz.z = P->vfr_meter * (coo.lpz.z + P->z0);\n+\n+        if( P->is_long_wrap_set ) {\n+            if( coo.lpz.lam != HUGE_VAL ) {\n+                double val = fmod(coo.lpz.lam , M_TWOPI);","path":"src/pj_fwd.c","position":null,"original_position":15,"commit_id":"47cada7c3a0d55bcc071f124e3bc0ea403cfff64","original_commit_id":"888883797d6b8c9080d8549c3542735bbda5eaa5","user":{"login":"rouault","id":1192433,"node_id":"MDQ6VXNlcjExOTI0MzM=","avatar_url":"https://avatars2.githubusercontent.com/u/1192433?v=4","gravatar_id":"","url":"https://api.github.com/users/rouault","html_url":"https://github.com/rouault","followers_url":"https://api.github.com/users/rouault/followers","following_url":"https://api.github.com/users/rouault/following{/other_user}","gists_url":"https://api.github.com/users/rouault/gists{/gist_id}","starred_url":"https://api.github.com/users/rouault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rouault/subscriptions","organizations_url":"https://api.github.com/users/rouault/orgs","repos_url":"https://api.github.com/users/rouault/repos","events_url":"https://api.github.com/users/rouault/events{/privacy}","received_events_url":"https://api.github.com/users/rouault/received_events","type":"User","site_admin":false},"body":"Similar indeed. adjlon() reframe in [-PI,PI], whereas the long_wrap mechanism reframe in [long_wrap - PI, long_wrap + PI]. I just copied this snippet from pj_transform.c. I've modified this as P->long_wrap_center +  adjlon(coo.lpz.lam - P->long_wrap_center);","created_at":"2018-11-28T23:35:56Z","updated_at":"2018-11-28T23:35:56Z","html_url":"https://github.com/OSGeo/proj.4/pull/1182#discussion_r237303987","pull_request_url":"https://api.github.com/repos/OSGeo/proj.4/pulls/1182","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/OSGeo/proj.4/pulls/comments/237303987"},"html":{"href":"https://github.com/OSGeo/proj.4/pull/1182#discussion_r237303987"},"pull_request":{"href":"https://api.github.com/repos/OSGeo/proj.4/pulls/1182"}},"in_reply_to_id":237278233},"pull_request":{"url":"https://api.github.com/repos/OSGeo/proj.4/pulls/1182","id":233601187,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNjAxMTg3","html_url":"https://github.com/OSGeo/proj.4/pull/1182","diff_url":"https://github.com/OSGeo/proj.4/pull/1182.diff","patch_url":"https://github.com/OSGeo/proj.4/pull/1182.patch","issue_url":"https://api.github.com/repos/OSGeo/proj.4/issues/1182","number":1182,"state":"open","locked":false,"title":"Remove data/epsg, IGNF and esri.* files / support legacy +init=epsg:XXXX syntax","user":{"login":"rouault","id":1192433,"node_id":"MDQ6VXNlcjExOTI0MzM=","avatar_url":"https://avatars2.githubusercontent.com/u/1192433?v=4","gravatar_id":"","url":"https://api.github.com/users/rouault","html_url":"https://github.com/rouault","followers_url":"https://api.github.com/users/rouault/followers","following_url":"https://api.github.com/users/rouault/following{/other_user}","gists_url":"https://api.github.com/users/rouault/gists{/gist_id}","starred_url":"https://api.github.com/users/rouault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rouault/subscriptions","organizations_url":"https://api.github.com/users/rouault/orgs","repos_url":"https://api.github.com/users/rouault/repos","events_url":"https://api.github.com/users/rouault/events{/privacy}","received_events_url":"https://api.github.com/users/rouault/received_events","type":"User","site_admin":false},"body":"This is an attempt at resolving the issues raised in https://github.com/OSGeo/proj.4/issues/1178\r\n\r\n- compatibility emulation of +init=epsg:XXXX / +init=IGNF:XXXX syntax using the database to do the resolution, and with the assumptions we traditionnaly did on axis order and units. This emulation is enabled in the following cases:\r\n      - using cs2cs,\r\n      - using proj_api.h API: pj_init(), pj_init_ctx(), pj_init_plus(), pj_init_plux_ctx()\r\n      - or setting PROJ_USE_PROJ4_INIT_RULES to YES / proj_context_use_proj4_init_rules(ctx, TRUE)\r\n- cs2cs modified to use proj_create_crs_to_crs()\r\n- cs2cs now accepts syntax like \"cs2cs EPSG:4326 +to EPSG:32631\" in which case, it will assume EPSG axis order and unit. If using \"cs2cs +init=epsg:4326 ...\", it will assume traditional order.\r\n- proj_create_crs_to_crs() modified to use the C++ code to compute the best transformation pipeline.\r\n- proj_create_crs_to_crs() can accept as source and target values, and string accepted by the C++ createFromUserInput() API, that is a AUTH:CODE, a PROJ string or a WKT string.\r\n- note: so, as cs2cs is using proj_create_crs_to_crs(), one can use cs2cs with WKT strings as well: \"cs2cs 'PROJ_CS[....]' +to 'PROJ_CS[...]'\"\r\n- if using proj_create_crs_to_crs() with \"EPSG:XXXX\" values, it will assume EPSG axis order and unit (so typically lat-long degree for geodetic CRS): this is a breaking change. If using it with \"+init=epsg:XXXX\" values, it will assume traditional order and unit (long-lat radians for geodetic CRS)\r\n- and all needed changes to be able to remove the data/epsg, IGNF and esri.* legacy files","created_at":"2018-11-26T15:38:55Z","updated_at":"2018-11-28T23:35:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d9317e19376038ffbcca5029e7643efd1db28d2c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OSGeo/proj.4/pulls/1182/commits","review_comments_url":"https://api.github.com/repos/OSGeo/proj.4/pulls/1182/comments","review_comment_url":"https://api.github.com/repos/OSGeo/proj.4/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OSGeo/proj.4/issues/1182/comments","statuses_url":"https://api.github.com/repos/OSGeo/proj.4/statuses/47cada7c3a0d55bcc071f124e3bc0ea403cfff64","head":{"label":"rouault:plug_new_code","ref":"plug_new_code","sha":"47cada7c3a0d55bcc071f124e3bc0ea403cfff64","user":{"login":"rouault","id":1192433,"node_id":"MDQ6VXNlcjExOTI0MzM=","avatar_url":"https://avatars2.githubusercontent.com/u/1192433?v=4","gravatar_id":"","url":"https://api.github.com/users/rouault","html_url":"https://github.com/rouault","followers_url":"https://api.github.com/users/rouault/followers","following_url":"https://api.github.com/users/rouault/following{/other_user}","gists_url":"https://api.github.com/users/rouault/gists{/gist_id}","starred_url":"https://api.github.com/users/rouault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rouault/subscriptions","organizations_url":"https://api.github.com/users/rouault/orgs","repos_url":"https://api.github.com/users/rouault/repos","events_url":"https://api.github.com/users/rouault/events{/privacy}","received_events_url":"https://api.github.com/users/rouault/received_events","type":"User","site_admin":false},"repo":{"id":37786257,"node_id":"MDEwOlJlcG9zaXRvcnkzNzc4NjI1Nw==","name":"proj.4","full_name":"rouault/proj.4","private":false,"owner":{"login":"rouault","id":1192433,"node_id":"MDQ6VXNlcjExOTI0MzM=","avatar_url":"https://avatars2.githubusercontent.com/u/1192433?v=4","gravatar_id":"","url":"https://api.github.com/users/rouault","html_url":"https://github.com/rouault","followers_url":"https://api.github.com/users/rouault/followers","following_url":"https://api.github.com/users/rouault/following{/other_user}","gists_url":"https://api.github.com/users/rouault/gists{/gist_id}","starred_url":"https://api.github.com/users/rouault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rouault/subscriptions","organizations_url":"https://api.github.com/users/rouault/orgs","repos_url":"https://api.github.com/users/rouault/repos","events_url":"https://api.github.com/users/rouault/events{/privacy}","received_events_url":"https://api.github.com/users/rouault/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rouault/proj.4","description":"PROJ.4 - Cartographic Projections Library","fork":true,"url":"https://api.github.com/repos/rouault/proj.4","forks_url":"https://api.github.com/repos/rouault/proj.4/forks","keys_url":"https://api.github.com/repos/rouault/proj.4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rouault/proj.4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rouault/proj.4/teams","hooks_url":"https://api.github.com/repos/rouault/proj.4/hooks","issue_events_url":"https://api.github.com/repos/rouault/proj.4/issues/events{/number}","events_url":"https://api.github.com/repos/rouault/proj.4/events","assignees_url":"https://api.github.com/repos/rouault/proj.4/assignees{/user}","branches_url":"https://api.github.com/repos/rouault/proj.4/branches{/branch}","tags_url":"https://api.github.com/repos/rouault/proj.4/tags","blobs_url":"https://api.github.com/repos/rouault/proj.4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rouault/proj.4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rouault/proj.4/git/refs{/sha}","trees_url":"https://api.github.com/repos/rouault/proj.4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rouault/proj.4/statuses/{sha}","languages_url":"https://api.github.com/repos/rouault/proj.4/languages","stargazers_url":"https://api.github.com/repos/rouault/proj.4/stargazers","contributors_url":"https://api.github.com/repos/rouault/proj.4/contributors","subscribers_url":"https://api.github.com/repos/rouault/proj.4/subscribers","subscription_url":"https://api.github.com/repos/rouault/proj.4/subscription","commits_url":"https://api.github.com/repos/rouault/proj.4/commits{/sha}","git_commits_url":"https://api.github.com/repos/rouault/proj.4/git/commits{/sha}","comments_url":"https://api.github.com/repos/rouault/proj.4/comments{/number}","issue_comment_url":"https://api.github.com/repos/rouault/proj.4/issues/comments{/number}","contents_url":"https://api.github.com/repos/rouault/proj.4/contents/{+path}","compare_url":"https://api.github.com/repos/rouault/proj.4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rouault/proj.4/merges","archive_url":"https://api.github.com/repos/rouault/proj.4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rouault/proj.4/downloads","issues_url":"https://api.github.com/repos/rouault/proj.4/issues{/number}","pulls_url":"https://api.github.com/repos/rouault/proj.4/pulls{/number}","milestones_url":"https://api.github.com/repos/rouault/proj.4/milestones{/number}","notifications_url":"https://api.github.com/repos/rouault/proj.4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rouault/proj.4/labels{/name}","releases_url":"https://api.github.com/repos/rouault/proj.4/releases{/id}","deployments_url":"https://api.github.com/repos/rouault/proj.4/deployments","created_at":"2015-06-20T21:17:56Z","updated_at":"2015-06-20T21:17:57Z","pushed_at":"2018-11-28T23:35:35Z","git_url":"git://github.com/rouault/proj.4.git","ssh_url":"git@github.com:rouault/proj.4.git","clone_url":"https://github.com/rouault/proj.4.git","svn_url":"https://github.com/rouault/proj.4","homepage":"http://proj.osgeo.org","size":198014,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OSGeo:master","ref":"master","sha":"4794d755a8dea4f4501c61e896e1829bb720e69a","user":{"login":"OSGeo","id":1058467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTg0Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1058467?v=4","gravatar_id":"","url":"https://api.github.com/users/OSGeo","html_url":"https://github.com/OSGeo","followers_url":"https://api.github.com/users/OSGeo/followers","following_url":"https://api.github.com/users/OSGeo/following{/other_user}","gists_url":"https://api.github.com/users/OSGeo/gists{/gist_id}","starred_url":"https://api.github.com/users/OSGeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSGeo/subscriptions","organizations_url":"https://api.github.com/users/OSGeo/orgs","repos_url":"https://api.github.com/users/OSGeo/repos","events_url":"https://api.github.com/users/OSGeo/events{/privacy}","received_events_url":"https://api.github.com/users/OSGeo/received_events","type":"Organization","site_admin":false},"repo":{"id":36057261,"node_id":"MDEwOlJlcG9zaXRvcnkzNjA1NzI2MQ==","name":"proj.4","full_name":"OSGeo/proj.4","private":false,"owner":{"login":"OSGeo","id":1058467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTg0Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1058467?v=4","gravatar_id":"","url":"https://api.github.com/users/OSGeo","html_url":"https://github.com/OSGeo","followers_url":"https://api.github.com/users/OSGeo/followers","following_url":"https://api.github.com/users/OSGeo/following{/other_user}","gists_url":"https://api.github.com/users/OSGeo/gists{/gist_id}","starred_url":"https://api.github.com/users/OSGeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSGeo/subscriptions","organizations_url":"https://api.github.com/users/OSGeo/orgs","repos_url":"https://api.github.com/users/OSGeo/repos","events_url":"https://api.github.com/users/OSGeo/events{/privacy}","received_events_url":"https://api.github.com/users/OSGeo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OSGeo/proj.4","description":"PROJ.4 - Cartographic Projections Library","fork":false,"url":"https://api.github.com/repos/OSGeo/proj.4","forks_url":"https://api.github.com/repos/OSGeo/proj.4/forks","keys_url":"https://api.github.com/repos/OSGeo/proj.4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OSGeo/proj.4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OSGeo/proj.4/teams","hooks_url":"https://api.github.com/repos/OSGeo/proj.4/hooks","issue_events_url":"https://api.github.com/repos/OSGeo/proj.4/issues/events{/number}","events_url":"https://api.github.com/repos/OSGeo/proj.4/events","assignees_url":"https://api.github.com/repos/OSGeo/proj.4/assignees{/user}","branches_url":"https://api.github.com/repos/OSGeo/proj.4/branches{/branch}","tags_url":"https://api.github.com/repos/OSGeo/proj.4/tags","blobs_url":"https://api.github.com/repos/OSGeo/proj.4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OSGeo/proj.4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OSGeo/proj.4/git/refs{/sha}","trees_url":"https://api.github.com/repos/OSGeo/proj.4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OSGeo/proj.4/statuses/{sha}","languages_url":"https://api.github.com/repos/OSGeo/proj.4/languages","stargazers_url":"https://api.github.com/repos/OSGeo/proj.4/stargazers","contributors_url":"https://api.github.com/repos/OSGeo/proj.4/contributors","subscribers_url":"https://api.github.com/repos/OSGeo/proj.4/subscribers","subscription_url":"https://api.github.com/repos/OSGeo/proj.4/subscription","commits_url":"https://api.github.com/repos/OSGeo/proj.4/commits{/sha}","git_commits_url":"https://api.github.com/repos/OSGeo/proj.4/git/commits{/sha}","comments_url":"https://api.github.com/repos/OSGeo/proj.4/comments{/number}","issue_comment_url":"https://api.github.com/repos/OSGeo/proj.4/issues/comments{/number}","contents_url":"https://api.github.com/repos/OSGeo/proj.4/contents/{+path}","compare_url":"https://api.github.com/repos/OSGeo/proj.4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OSGeo/proj.4/merges","archive_url":"https://api.github.com/repos/OSGeo/proj.4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OSGeo/proj.4/downloads","issues_url":"https://api.github.com/repos/OSGeo/proj.4/issues{/number}","pulls_url":"https://api.github.com/repos/OSGeo/proj.4/pulls{/number}","milestones_url":"https://api.github.com/repos/OSGeo/proj.4/milestones{/number}","notifications_url":"https://api.github.com/repos/OSGeo/proj.4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OSGeo/proj.4/labels{/name}","releases_url":"https://api.github.com/repos/OSGeo/proj.4/releases{/id}","deployments_url":"https://api.github.com/repos/OSGeo/proj.4/deployments","created_at":"2015-05-22T07:00:08Z","updated_at":"2018-11-28T12:24:19Z","pushed_at":"2018-11-28T23:35:37Z","git_url":"git://github.com/OSGeo/proj.4.git","ssh_url":"git@github.com:OSGeo/proj.4.git","clone_url":"https://github.com/OSGeo/proj.4.git","svn_url":"https://github.com/OSGeo/proj.4","homepage":"https://proj4.org","size":221952,"stargazers_count":510,"watchers_count":510,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":232,"mirror_url":null,"archived":false,"open_issues_count":62,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":232,"open_issues":62,"watchers":510,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OSGeo/proj.4/pulls/1182"},"html":{"href":"https://github.com/OSGeo/proj.4/pull/1182"},"issue":{"href":"https://api.github.com/repos/OSGeo/proj.4/issues/1182"},"comments":{"href":"https://api.github.com/repos/OSGeo/proj.4/issues/1182/comments"},"review_comments":{"href":"https://api.github.com/repos/OSGeo/proj.4/pulls/1182/comments"},"review_comment":{"href":"https://api.github.com/repos/OSGeo/proj.4/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OSGeo/proj.4/pulls/1182/commits"},"statuses":{"href":"https://api.github.com/repos/OSGeo/proj.4/statuses/47cada7c3a0d55bcc071f124e3bc0ea403cfff64"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"rouault"}}