{"action":"closed","number":2,"pull_request":{"url":"https://api.github.com/repos/smartprix/js_conventions/pulls/2","id":230826896,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwODI2ODk2","html_url":"https://github.com/smartprix/js_conventions/pull/2","diff_url":"https://github.com/smartprix/js_conventions/pull/2.diff","patch_url":"https://github.com/smartprix/js_conventions/pull/2.patch","issue_url":"https://api.github.com/repos/smartprix/js_conventions/issues/2","number":2,"state":"closed","locked":false,"title":"Remove globals by default and only enable node env","user":{"login":"rohit-smpx","id":31949290,"node_id":"MDQ6VXNlcjMxOTQ5Mjkw","avatar_url":"https://avatars0.githubusercontent.com/u/31949290?v=4","gravatar_id":"","url":"https://api.github.com/users/rohit-smpx","html_url":"https://github.com/rohit-smpx","followers_url":"https://api.github.com/users/rohit-smpx/followers","following_url":"https://api.github.com/users/rohit-smpx/following{/other_user}","gists_url":"https://api.github.com/users/rohit-smpx/gists{/gist_id}","starred_url":"https://api.github.com/users/rohit-smpx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohit-smpx/subscriptions","organizations_url":"https://api.github.com/users/rohit-smpx/orgs","repos_url":"https://api.github.com/users/rohit-smpx/repos","events_url":"https://api.github.com/users/rohit-smpx/events{/privacy}","received_events_url":"https://api.github.com/users/rohit-smpx/received_events","type":"User","site_admin":false},"body":"Globals should be enabled on a per project basis.\r\nAnd environments might be different for different directories, so should ideally be in .eslintrc files\r\nCloses #1 ","created_at":"2018-11-14T13:01:41Z","updated_at":"2018-11-15T12:39:35Z","closed_at":"2018-11-15T12:39:35Z","merged_at":"2018-11-15T12:39:35Z","merge_commit_sha":"e7254282aaa8344efbb3f2b27572cd4113927f2d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/smartprix/js_conventions/pulls/2/commits","review_comments_url":"https://api.github.com/repos/smartprix/js_conventions/pulls/2/comments","review_comment_url":"https://api.github.com/repos/smartprix/js_conventions/pulls/comments{/number}","comments_url":"https://api.github.com/repos/smartprix/js_conventions/issues/2/comments","statuses_url":"https://api.github.com/repos/smartprix/js_conventions/statuses/24b4c0659a8a01d8c69a527247bc2054aa5efe0a","head":{"label":"rohit-smpx:globals-env-patch","ref":"globals-env-patch","sha":"24b4c0659a8a01d8c69a527247bc2054aa5efe0a","user":{"login":"rohit-smpx","id":31949290,"node_id":"MDQ6VXNlcjMxOTQ5Mjkw","avatar_url":"https://avatars0.githubusercontent.com/u/31949290?v=4","gravatar_id":"","url":"https://api.github.com/users/rohit-smpx","html_url":"https://github.com/rohit-smpx","followers_url":"https://api.github.com/users/rohit-smpx/followers","following_url":"https://api.github.com/users/rohit-smpx/following{/other_user}","gists_url":"https://api.github.com/users/rohit-smpx/gists{/gist_id}","starred_url":"https://api.github.com/users/rohit-smpx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohit-smpx/subscriptions","organizations_url":"https://api.github.com/users/rohit-smpx/orgs","repos_url":"https://api.github.com/users/rohit-smpx/repos","events_url":"https://api.github.com/users/rohit-smpx/events{/privacy}","received_events_url":"https://api.github.com/users/rohit-smpx/received_events","type":"User","site_admin":false},"repo":{"id":157548118,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc1NDgxMTg=","name":"js_conventions","full_name":"rohit-smpx/js_conventions","private":false,"owner":{"login":"rohit-smpx","id":31949290,"node_id":"MDQ6VXNlcjMxOTQ5Mjkw","avatar_url":"https://avatars0.githubusercontent.com/u/31949290?v=4","gravatar_id":"","url":"https://api.github.com/users/rohit-smpx","html_url":"https://github.com/rohit-smpx","followers_url":"https://api.github.com/users/rohit-smpx/followers","following_url":"https://api.github.com/users/rohit-smpx/following{/other_user}","gists_url":"https://api.github.com/users/rohit-smpx/gists{/gist_id}","starred_url":"https://api.github.com/users/rohit-smpx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohit-smpx/subscriptions","organizations_url":"https://api.github.com/users/rohit-smpx/orgs","repos_url":"https://api.github.com/users/rohit-smpx/repos","events_url":"https://api.github.com/users/rohit-smpx/events{/privacy}","received_events_url":"https://api.github.com/users/rohit-smpx/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rohit-smpx/js_conventions","description":"Smartprix Javascript Conventions","fork":true,"url":"https://api.github.com/repos/rohit-smpx/js_conventions","forks_url":"https://api.github.com/repos/rohit-smpx/js_conventions/forks","keys_url":"https://api.github.com/repos/rohit-smpx/js_conventions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rohit-smpx/js_conventions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rohit-smpx/js_conventions/teams","hooks_url":"https://api.github.com/repos/rohit-smpx/js_conventions/hooks","issue_events_url":"https://api.github.com/repos/rohit-smpx/js_conventions/issues/events{/number}","events_url":"https://api.github.com/repos/rohit-smpx/js_conventions/events","assignees_url":"https://api.github.com/repos/rohit-smpx/js_conventions/assignees{/user}","branches_url":"https://api.github.com/repos/rohit-smpx/js_conventions/branches{/branch}","tags_url":"https://api.github.com/repos/rohit-smpx/js_conventions/tags","blobs_url":"https://api.github.com/repos/rohit-smpx/js_conventions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rohit-smpx/js_conventions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rohit-smpx/js_conventions/git/refs{/sha}","trees_url":"https://api.github.com/repos/rohit-smpx/js_conventions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rohit-smpx/js_conventions/statuses/{sha}","languages_url":"https://api.github.com/repos/rohit-smpx/js_conventions/languages","stargazers_url":"https://api.github.com/repos/rohit-smpx/js_conventions/stargazers","contributors_url":"https://api.github.com/repos/rohit-smpx/js_conventions/contributors","subscribers_url":"https://api.github.com/repos/rohit-smpx/js_conventions/subscribers","subscription_url":"https://api.github.com/repos/rohit-smpx/js_conventions/subscription","commits_url":"https://api.github.com/repos/rohit-smpx/js_conventions/commits{/sha}","git_commits_url":"https://api.github.com/repos/rohit-smpx/js_conventions/git/commits{/sha}","comments_url":"https://api.github.com/repos/rohit-smpx/js_conventions/comments{/number}","issue_comment_url":"https://api.github.com/repos/rohit-smpx/js_conventions/issues/comments{/number}","contents_url":"https://api.github.com/repos/rohit-smpx/js_conventions/contents/{+path}","compare_url":"https://api.github.com/repos/rohit-smpx/js_conventions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rohit-smpx/js_conventions/merges","archive_url":"https://api.github.com/repos/rohit-smpx/js_conventions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rohit-smpx/js_conventions/downloads","issues_url":"https://api.github.com/repos/rohit-smpx/js_conventions/issues{/number}","pulls_url":"https://api.github.com/repos/rohit-smpx/js_conventions/pulls{/number}","milestones_url":"https://api.github.com/repos/rohit-smpx/js_conventions/milestones{/number}","notifications_url":"https://api.github.com/repos/rohit-smpx/js_conventions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rohit-smpx/js_conventions/labels{/name}","releases_url":"https://api.github.com/repos/rohit-smpx/js_conventions/releases{/id}","deployments_url":"https://api.github.com/repos/rohit-smpx/js_conventions/deployments","created_at":"2018-11-14T12:50:21Z","updated_at":"2018-11-14T12:50:23Z","pushed_at":"2018-11-15T12:28:37Z","git_url":"git://github.com/rohit-smpx/js_conventions.git","ssh_url":"git@github.com:rohit-smpx/js_conventions.git","clone_url":"https://github.com/rohit-smpx/js_conventions.git","svn_url":"https://github.com/rohit-smpx/js_conventions","homepage":"","size":100,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"smartprix:master","ref":"master","sha":"ca7909f846bb841f215feddf30864b0963a31b36","user":{"login":"smartprix","id":8553927,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1NTM5Mjc=","avatar_url":"https://avatars2.githubusercontent.com/u/8553927?v=4","gravatar_id":"","url":"https://api.github.com/users/smartprix","html_url":"https://github.com/smartprix","followers_url":"https://api.github.com/users/smartprix/followers","following_url":"https://api.github.com/users/smartprix/following{/other_user}","gists_url":"https://api.github.com/users/smartprix/gists{/gist_id}","starred_url":"https://api.github.com/users/smartprix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartprix/subscriptions","organizations_url":"https://api.github.com/users/smartprix/orgs","repos_url":"https://api.github.com/users/smartprix/repos","events_url":"https://api.github.com/users/smartprix/events{/privacy}","received_events_url":"https://api.github.com/users/smartprix/received_events","type":"Organization","site_admin":false},"repo":{"id":61368915,"node_id":"MDEwOlJlcG9zaXRvcnk2MTM2ODkxNQ==","name":"js_conventions","full_name":"smartprix/js_conventions","private":false,"owner":{"login":"smartprix","id":8553927,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1NTM5Mjc=","avatar_url":"https://avatars2.githubusercontent.com/u/8553927?v=4","gravatar_id":"","url":"https://api.github.com/users/smartprix","html_url":"https://github.com/smartprix","followers_url":"https://api.github.com/users/smartprix/followers","following_url":"https://api.github.com/users/smartprix/following{/other_user}","gists_url":"https://api.github.com/users/smartprix/gists{/gist_id}","starred_url":"https://api.github.com/users/smartprix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartprix/subscriptions","organizations_url":"https://api.github.com/users/smartprix/orgs","repos_url":"https://api.github.com/users/smartprix/repos","events_url":"https://api.github.com/users/smartprix/events{/privacy}","received_events_url":"https://api.github.com/users/smartprix/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/smartprix/js_conventions","description":"Smartprix Javascript Conventions","fork":false,"url":"https://api.github.com/repos/smartprix/js_conventions","forks_url":"https://api.github.com/repos/smartprix/js_conventions/forks","keys_url":"https://api.github.com/repos/smartprix/js_conventions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smartprix/js_conventions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smartprix/js_conventions/teams","hooks_url":"https://api.github.com/repos/smartprix/js_conventions/hooks","issue_events_url":"https://api.github.com/repos/smartprix/js_conventions/issues/events{/number}","events_url":"https://api.github.com/repos/smartprix/js_conventions/events","assignees_url":"https://api.github.com/repos/smartprix/js_conventions/assignees{/user}","branches_url":"https://api.github.com/repos/smartprix/js_conventions/branches{/branch}","tags_url":"https://api.github.com/repos/smartprix/js_conventions/tags","blobs_url":"https://api.github.com/repos/smartprix/js_conventions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smartprix/js_conventions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smartprix/js_conventions/git/refs{/sha}","trees_url":"https://api.github.com/repos/smartprix/js_conventions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smartprix/js_conventions/statuses/{sha}","languages_url":"https://api.github.com/repos/smartprix/js_conventions/languages","stargazers_url":"https://api.github.com/repos/smartprix/js_conventions/stargazers","contributors_url":"https://api.github.com/repos/smartprix/js_conventions/contributors","subscribers_url":"https://api.github.com/repos/smartprix/js_conventions/subscribers","subscription_url":"https://api.github.com/repos/smartprix/js_conventions/subscription","commits_url":"https://api.github.com/repos/smartprix/js_conventions/commits{/sha}","git_commits_url":"https://api.github.com/repos/smartprix/js_conventions/git/commits{/sha}","comments_url":"https://api.github.com/repos/smartprix/js_conventions/comments{/number}","issue_comment_url":"https://api.github.com/repos/smartprix/js_conventions/issues/comments{/number}","contents_url":"https://api.github.com/repos/smartprix/js_conventions/contents/{+path}","compare_url":"https://api.github.com/repos/smartprix/js_conventions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smartprix/js_conventions/merges","archive_url":"https://api.github.com/repos/smartprix/js_conventions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smartprix/js_conventions/downloads","issues_url":"https://api.github.com/repos/smartprix/js_conventions/issues{/number}","pulls_url":"https://api.github.com/repos/smartprix/js_conventions/pulls{/number}","milestones_url":"https://api.github.com/repos/smartprix/js_conventions/milestones{/number}","notifications_url":"https://api.github.com/repos/smartprix/js_conventions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smartprix/js_conventions/labels{/name}","releases_url":"https://api.github.com/repos/smartprix/js_conventions/releases{/id}","deployments_url":"https://api.github.com/repos/smartprix/js_conventions/deployments","created_at":"2016-06-17T11:26:35Z","updated_at":"2018-09-17T08:20:23Z","pushed_at":"2018-11-15T12:39:35Z","git_url":"git://github.com/smartprix/js_conventions.git","ssh_url":"git@github.com:smartprix/js_conventions.git","clone_url":"https://github.com/smartprix/js_conventions.git","svn_url":"https://github.com/smartprix/js_conventions","homepage":"","size":100,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":2,"open_issues":0,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/smartprix/js_conventions/pulls/2"},"html":{"href":"https://github.com/smartprix/js_conventions/pull/2"},"issue":{"href":"https://api.github.com/repos/smartprix/js_conventions/issues/2"},"comments":{"href":"https://api.github.com/repos/smartprix/js_conventions/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/smartprix/js_conventions/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/smartprix/js_conventions/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/smartprix/js_conventions/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/smartprix/js_conventions/statuses/24b4c0659a8a01d8c69a527247bc2054aa5efe0a"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"hit12369","id":8758361,"node_id":"MDQ6VXNlcjg3NTgzNjE=","avatar_url":"https://avatars1.githubusercontent.com/u/8758361?v=4","gravatar_id":"","url":"https://api.github.com/users/hit12369","html_url":"https://github.com/hit12369","followers_url":"https://api.github.com/users/hit12369/followers","following_url":"https://api.github.com/users/hit12369/following{/other_user}","gists_url":"https://api.github.com/users/hit12369/gists{/gist_id}","starred_url":"https://api.github.com/users/hit12369/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hit12369/subscriptions","organizations_url":"https://api.github.com/users/hit12369/orgs","repos_url":"https://api.github.com/users/hit12369/repos","events_url":"https://api.github.com/users/hit12369/events{/privacy}","received_events_url":"https://api.github.com/users/hit12369/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":719,"deletions":405,"changed_files":6}}
{"actor":{"display_login":"hit12369"}}