{"action":"created","comment":{"url":"https://api.github.com/repos/gradle/gradle/pulls/comments/171403561","pull_request_review_id":100250921,"id":171403561,"diff_hunk":"@@ -0,0 +1,293 @@\n+/*\n+ * Copyright 2018 the original author or authors.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *      http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package org.gradle.ide.visualstudio\n+\n+import org.gradle.ide.visualstudio.fixtures.AbstractVisualStudioIntegrationSpec\n+import org.gradle.integtests.fixtures.SourceFile\n+import org.gradle.nativeplatform.fixtures.app.CppHelloWorldApp\n+\n+import static org.apache.commons.io.FileUtils.copyFile\n+\n+class VisualStudioSoftwareModelIncrementalIntegrationTest extends AbstractVisualStudioIntegrationSpec {\n+    def app = new CppHelloWorldApp()\n+\n+    def setup() {\n+        settingsFile << \"\"\"\n+            rootProject.name = 'app'\n+        \"\"\"\n+        buildFile << \"\"\"\n+            apply plugin: 'cpp'\n+            apply plugin: 'visual-studio'\n+            \n+            model {\n+                components {\n+                    main(NativeExecutableSpec)\n+                }\n+                platforms {\n+                    win32 {\n+                        architecture \"i386\"\n+                    }\n+                    x64 {\n+                        architecture \"amd64\"\n+                    }\n+                }\n+                buildTypes {\n+                    debug\n+                    release\n+                }\n+                components {\n+                    all {\n+                        targetPlatform \"win32\"\n+                        targetPlatform \"x64\"\n+                    }\n+                }\n+            }\n+        \"\"\"\n+    }\n+\n+    def \"visual studio tasks re-execute when source files are added\"() {\n+        app.writeSources(file(\"src/main\"))\n+\n+        when:\n+        run \"visualStudio\"\n+\n+        then:\n+        executedAndNotSkipped \":appVisualStudioSolution\"\n+        executedAndNotSkipped getComponentTasks(\"main\")\n+\n+        when:\n+        copyFile(file(\"src/main/cpp/main.cpp\"), file(\"src/main/cpp/foo.cpp\"))","path":"subprojects/ide-native/src/integTest/groovy/org/gradle/ide/visualstudio/VisualStudioSoftwareModelIncrementalIntegrationTest.groovy","position":null,"original_position":73,"commit_id":"9aadc9e1ca998263e2da9c61d36ddb38ce78e2d0","original_commit_id":"e16961452bcf5da7f615766e8f6d02e547ed708d","user":{"login":"ghale","id":642656,"avatar_url":"https://avatars0.githubusercontent.com/u/642656?v=4","gravatar_id":"","url":"https://api.github.com/users/ghale","html_url":"https://github.com/ghale","followers_url":"https://api.github.com/users/ghale/followers","following_url":"https://api.github.com/users/ghale/following{/other_user}","gists_url":"https://api.github.com/users/ghale/gists{/gist_id}","starred_url":"https://api.github.com/users/ghale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghale/subscriptions","organizations_url":"https://api.github.com/users/ghale/orgs","repos_url":"https://api.github.com/users/ghale/repos","events_url":"https://api.github.com/users/ghale/events{/privacy}","received_events_url":"https://api.github.com/users/ghale/received_events","type":"User","site_admin":false},"body":"Fair enough - changed to assert that this file does not exist before copying.","created_at":"2018-02-28T22:16:34Z","updated_at":"2018-02-28T22:16:35Z","html_url":"https://github.com/gradle/gradle/pull/4531#discussion_r171403561","pull_request_url":"https://api.github.com/repos/gradle/gradle/pulls/4531","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/gradle/gradle/pulls/comments/171403561"},"html":{"href":"https://github.com/gradle/gradle/pull/4531#discussion_r171403561"},"pull_request":{"href":"https://api.github.com/repos/gradle/gradle/pulls/4531"}},"in_reply_to_id":171330354},"pull_request":{"url":"https://api.github.com/repos/gradle/gradle/pulls/4531","id":171706007,"html_url":"https://github.com/gradle/gradle/pull/4531","diff_url":"https://github.com/gradle/gradle/pull/4531.diff","patch_url":"https://github.com/gradle/gradle/pull/4531.patch","issue_url":"https://api.github.com/repos/gradle/gradle/issues/4531","number":4531,"state":"open","locked":false,"title":"Make Visual Studio metadata generation tasks incremental","user":{"login":"ghale","id":642656,"avatar_url":"https://avatars0.githubusercontent.com/u/642656?v=4","gravatar_id":"","url":"https://api.github.com/users/ghale","html_url":"https://github.com/ghale","followers_url":"https://api.github.com/users/ghale/followers","following_url":"https://api.github.com/users/ghale/following{/other_user}","gists_url":"https://api.github.com/users/ghale/gists{/gist_id}","starred_url":"https://api.github.com/users/ghale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghale/subscriptions","organizations_url":"https://api.github.com/users/ghale/orgs","repos_url":"https://api.github.com/users/ghale/repos","events_url":"https://api.github.com/users/ghale/events{/privacy}","received_events_url":"https://api.github.com/users/ghale/received_events","type":"User","site_admin":false},"body":"This adds incrementality to the Visual Studio IDE metadata generation tasks.","created_at":"2018-02-27T15:59:29Z","updated_at":"2018-02-28T22:16:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7faa1be7eeb5d98de71aaf22c91326255bd3f86c","assignee":{"login":"ghale","id":642656,"avatar_url":"https://avatars0.githubusercontent.com/u/642656?v=4","gravatar_id":"","url":"https://api.github.com/users/ghale","html_url":"https://github.com/ghale","followers_url":"https://api.github.com/users/ghale/followers","following_url":"https://api.github.com/users/ghale/following{/other_user}","gists_url":"https://api.github.com/users/ghale/gists{/gist_id}","starred_url":"https://api.github.com/users/ghale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghale/subscriptions","organizations_url":"https://api.github.com/users/ghale/orgs","repos_url":"https://api.github.com/users/ghale/repos","events_url":"https://api.github.com/users/ghale/events{/privacy}","received_events_url":"https://api.github.com/users/ghale/received_events","type":"User","site_admin":false},"assignees":[{"login":"ghale","id":642656,"avatar_url":"https://avatars0.githubusercontent.com/u/642656?v=4","gravatar_id":"","url":"https://api.github.com/users/ghale","html_url":"https://github.com/ghale","followers_url":"https://api.github.com/users/ghale/followers","following_url":"https://api.github.com/users/ghale/following{/other_user}","gists_url":"https://api.github.com/users/ghale/gists{/gist_id}","starred_url":"https://api.github.com/users/ghale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghale/subscriptions","organizations_url":"https://api.github.com/users/ghale/orgs","repos_url":"https://api.github.com/users/ghale/repos","events_url":"https://api.github.com/users/ghale/events{/privacy}","received_events_url":"https://api.github.com/users/ghale/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":460356753,"url":"https://api.github.com/repos/gradle/gradle/labels/a:feature","name":"a:feature","color":"0e8a16","default":false},{"id":289469033,"url":"https://api.github.com/repos/gradle/gradle/labels/from:member","name":"from:member","color":"0052cc","default":false}],"milestone":{"url":"https://api.github.com/repos/gradle/gradle/milestones/60","html_url":"https://github.com/gradle/gradle/milestone/60","labels_url":"https://api.github.com/repos/gradle/gradle/milestones/60/labels","id":3014896,"number":60,"title":"4.7 RC1","description":"","creator":{"login":"jjohannes","id":1963746,"avatar_url":"https://avatars0.githubusercontent.com/u/1963746?v=4","gravatar_id":"","url":"https://api.github.com/users/jjohannes","html_url":"https://github.com/jjohannes","followers_url":"https://api.github.com/users/jjohannes/followers","following_url":"https://api.github.com/users/jjohannes/following{/other_user}","gists_url":"https://api.github.com/users/jjohannes/gists{/gist_id}","starred_url":"https://api.github.com/users/jjohannes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjohannes/subscriptions","organizations_url":"https://api.github.com/users/jjohannes/orgs","repos_url":"https://api.github.com/users/jjohannes/repos","events_url":"https://api.github.com/users/jjohannes/events{/privacy}","received_events_url":"https://api.github.com/users/jjohannes/received_events","type":"User","site_admin":false},"open_issues":54,"closed_issues":37,"state":"open","created_at":"2018-01-05T10:44:13Z","updated_at":"2018-02-28T18:06:47Z","due_on":"2018-03-29T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/gradle/gradle/pulls/4531/commits","review_comments_url":"https://api.github.com/repos/gradle/gradle/pulls/4531/comments","review_comment_url":"https://api.github.com/repos/gradle/gradle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gradle/gradle/issues/4531/comments","statuses_url":"https://api.github.com/repos/gradle/gradle/statuses/9aadc9e1ca998263e2da9c61d36ddb38ce78e2d0","head":{"label":"gradle:gh/stable-native/vs-incremental","ref":"gh/stable-native/vs-incremental","sha":"9aadc9e1ca998263e2da9c61d36ddb38ce78e2d0","user":{"login":"gradle","id":124156,"avatar_url":"https://avatars2.githubusercontent.com/u/124156?v=4","gravatar_id":"","url":"https://api.github.com/users/gradle","html_url":"https://github.com/gradle","followers_url":"https://api.github.com/users/gradle/followers","following_url":"https://api.github.com/users/gradle/following{/other_user}","gists_url":"https://api.github.com/users/gradle/gists{/gist_id}","starred_url":"https://api.github.com/users/gradle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gradle/subscriptions","organizations_url":"https://api.github.com/users/gradle/orgs","repos_url":"https://api.github.com/users/gradle/repos","events_url":"https://api.github.com/users/gradle/events{/privacy}","received_events_url":"https://api.github.com/users/gradle/received_events","type":"Organization","site_admin":false},"repo":{"id":302322,"name":"gradle","full_name":"gradle/gradle","owner":{"login":"gradle","id":124156,"avatar_url":"https://avatars2.githubusercontent.com/u/124156?v=4","gravatar_id":"","url":"https://api.github.com/users/gradle","html_url":"https://github.com/gradle","followers_url":"https://api.github.com/users/gradle/followers","following_url":"https://api.github.com/users/gradle/following{/other_user}","gists_url":"https://api.github.com/users/gradle/gists{/gist_id}","starred_url":"https://api.github.com/users/gradle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gradle/subscriptions","organizations_url":"https://api.github.com/users/gradle/orgs","repos_url":"https://api.github.com/users/gradle/repos","events_url":"https://api.github.com/users/gradle/events{/privacy}","received_events_url":"https://api.github.com/users/gradle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gradle/gradle","description":"Adaptable, fast automation for all","fork":false,"url":"https://api.github.com/repos/gradle/gradle","forks_url":"https://api.github.com/repos/gradle/gradle/forks","keys_url":"https://api.github.com/repos/gradle/gradle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gradle/gradle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gradle/gradle/teams","hooks_url":"https://api.github.com/repos/gradle/gradle/hooks","issue_events_url":"https://api.github.com/repos/gradle/gradle/issues/events{/number}","events_url":"https://api.github.com/repos/gradle/gradle/events","assignees_url":"https://api.github.com/repos/gradle/gradle/assignees{/user}","branches_url":"https://api.github.com/repos/gradle/gradle/branches{/branch}","tags_url":"https://api.github.com/repos/gradle/gradle/tags","blobs_url":"https://api.github.com/repos/gradle/gradle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gradle/gradle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gradle/gradle/git/refs{/sha}","trees_url":"https://api.github.com/repos/gradle/gradle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gradle/gradle/statuses/{sha}","languages_url":"https://api.github.com/repos/gradle/gradle/languages","stargazers_url":"https://api.github.com/repos/gradle/gradle/stargazers","contributors_url":"https://api.github.com/repos/gradle/gradle/contributors","subscribers_url":"https://api.github.com/repos/gradle/gradle/subscribers","subscription_url":"https://api.github.com/repos/gradle/gradle/subscription","commits_url":"https://api.github.com/repos/gradle/gradle/commits{/sha}","git_commits_url":"https://api.github.com/repos/gradle/gradle/git/commits{/sha}","comments_url":"https://api.github.com/repos/gradle/gradle/comments{/number}","issue_comment_url":"https://api.github.com/repos/gradle/gradle/issues/comments{/number}","contents_url":"https://api.github.com/repos/gradle/gradle/contents/{+path}","compare_url":"https://api.github.com/repos/gradle/gradle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gradle/gradle/merges","archive_url":"https://api.github.com/repos/gradle/gradle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gradle/gradle/downloads","issues_url":"https://api.github.com/repos/gradle/gradle/issues{/number}","pulls_url":"https://api.github.com/repos/gradle/gradle/pulls{/number}","milestones_url":"https://api.github.com/repos/gradle/gradle/milestones{/number}","notifications_url":"https://api.github.com/repos/gradle/gradle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gradle/gradle/labels{/name}","releases_url":"https://api.github.com/repos/gradle/gradle/releases{/id}","deployments_url":"https://api.github.com/repos/gradle/gradle/deployments","created_at":"2009-09-09T18:27:19Z","updated_at":"2018-02-28T19:29:48Z","pushed_at":"2018-02-28T22:15:18Z","git_url":"git://github.com/gradle/gradle.git","ssh_url":"git@github.com:gradle/gradle.git","clone_url":"https://github.com/gradle/gradle.git","svn_url":"https://github.com/gradle/gradle","homepage":"https://gradle.org","size":202022,"stargazers_count":6343,"watchers_count":6343,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":2072,"mirror_url":null,"archived":false,"open_issues_count":950,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2072,"open_issues":950,"watchers":6343,"default_branch":"master"}},"base":{"label":"gradle:master","ref":"master","sha":"2df47b4cdbdf0a32fa3399c6b89b2cc8739bb6b0","user":{"login":"gradle","id":124156,"avatar_url":"https://avatars2.githubusercontent.com/u/124156?v=4","gravatar_id":"","url":"https://api.github.com/users/gradle","html_url":"https://github.com/gradle","followers_url":"https://api.github.com/users/gradle/followers","following_url":"https://api.github.com/users/gradle/following{/other_user}","gists_url":"https://api.github.com/users/gradle/gists{/gist_id}","starred_url":"https://api.github.com/users/gradle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gradle/subscriptions","organizations_url":"https://api.github.com/users/gradle/orgs","repos_url":"https://api.github.com/users/gradle/repos","events_url":"https://api.github.com/users/gradle/events{/privacy}","received_events_url":"https://api.github.com/users/gradle/received_events","type":"Organization","site_admin":false},"repo":{"id":302322,"name":"gradle","full_name":"gradle/gradle","owner":{"login":"gradle","id":124156,"avatar_url":"https://avatars2.githubusercontent.com/u/124156?v=4","gravatar_id":"","url":"https://api.github.com/users/gradle","html_url":"https://github.com/gradle","followers_url":"https://api.github.com/users/gradle/followers","following_url":"https://api.github.com/users/gradle/following{/other_user}","gists_url":"https://api.github.com/users/gradle/gists{/gist_id}","starred_url":"https://api.github.com/users/gradle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gradle/subscriptions","organizations_url":"https://api.github.com/users/gradle/orgs","repos_url":"https://api.github.com/users/gradle/repos","events_url":"https://api.github.com/users/gradle/events{/privacy}","received_events_url":"https://api.github.com/users/gradle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gradle/gradle","description":"Adaptable, fast automation for all","fork":false,"url":"https://api.github.com/repos/gradle/gradle","forks_url":"https://api.github.com/repos/gradle/gradle/forks","keys_url":"https://api.github.com/repos/gradle/gradle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gradle/gradle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gradle/gradle/teams","hooks_url":"https://api.github.com/repos/gradle/gradle/hooks","issue_events_url":"https://api.github.com/repos/gradle/gradle/issues/events{/number}","events_url":"https://api.github.com/repos/gradle/gradle/events","assignees_url":"https://api.github.com/repos/gradle/gradle/assignees{/user}","branches_url":"https://api.github.com/repos/gradle/gradle/branches{/branch}","tags_url":"https://api.github.com/repos/gradle/gradle/tags","blobs_url":"https://api.github.com/repos/gradle/gradle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gradle/gradle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gradle/gradle/git/refs{/sha}","trees_url":"https://api.github.com/repos/gradle/gradle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gradle/gradle/statuses/{sha}","languages_url":"https://api.github.com/repos/gradle/gradle/languages","stargazers_url":"https://api.github.com/repos/gradle/gradle/stargazers","contributors_url":"https://api.github.com/repos/gradle/gradle/contributors","subscribers_url":"https://api.github.com/repos/gradle/gradle/subscribers","subscription_url":"https://api.github.com/repos/gradle/gradle/subscription","commits_url":"https://api.github.com/repos/gradle/gradle/commits{/sha}","git_commits_url":"https://api.github.com/repos/gradle/gradle/git/commits{/sha}","comments_url":"https://api.github.com/repos/gradle/gradle/comments{/number}","issue_comment_url":"https://api.github.com/repos/gradle/gradle/issues/comments{/number}","contents_url":"https://api.github.com/repos/gradle/gradle/contents/{+path}","compare_url":"https://api.github.com/repos/gradle/gradle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gradle/gradle/merges","archive_url":"https://api.github.com/repos/gradle/gradle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gradle/gradle/downloads","issues_url":"https://api.github.com/repos/gradle/gradle/issues{/number}","pulls_url":"https://api.github.com/repos/gradle/gradle/pulls{/number}","milestones_url":"https://api.github.com/repos/gradle/gradle/milestones{/number}","notifications_url":"https://api.github.com/repos/gradle/gradle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gradle/gradle/labels{/name}","releases_url":"https://api.github.com/repos/gradle/gradle/releases{/id}","deployments_url":"https://api.github.com/repos/gradle/gradle/deployments","created_at":"2009-09-09T18:27:19Z","updated_at":"2018-02-28T19:29:48Z","pushed_at":"2018-02-28T22:15:18Z","git_url":"git://github.com/gradle/gradle.git","ssh_url":"git@github.com:gradle/gradle.git","clone_url":"https://github.com/gradle/gradle.git","svn_url":"https://github.com/gradle/gradle","homepage":"https://gradle.org","size":202022,"stargazers_count":6343,"watchers_count":6343,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":2072,"mirror_url":null,"archived":false,"open_issues_count":950,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2072,"open_issues":950,"watchers":6343,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gradle/gradle/pulls/4531"},"html":{"href":"https://github.com/gradle/gradle/pull/4531"},"issue":{"href":"https://api.github.com/repos/gradle/gradle/issues/4531"},"comments":{"href":"https://api.github.com/repos/gradle/gradle/issues/4531/comments"},"review_comments":{"href":"https://api.github.com/repos/gradle/gradle/pulls/4531/comments"},"review_comment":{"href":"https://api.github.com/repos/gradle/gradle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gradle/gradle/pulls/4531/commits"},"statuses":{"href":"https://api.github.com/repos/gradle/gradle/statuses/9aadc9e1ca998263e2da9c61d36ddb38ce78e2d0"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ghale"}}