{"action":"created","comment":{"url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/pulls/comments/224527779","pull_request_review_id":163918911,"id":224527779,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDUyNzc3OQ==","diff_hunk":"@@ -1,7 +1,7 @@\n-:: copied from rviz_yaml_cpp_vendor/env_hook/rviz_yaml_cpp_vendor_library_path.bat\n+:: copied from yaml_cpp_vendor/env_hook/yaml_cpp_vendor_library_path.bat\n @echo off\n \n-call:ament_prepend_unique_value PATH \"%AMENT_CURRENT_PREFIX%\\opt\\rviz_yaml_cpp_vendor\\bin\"\n+call:ament_prepend_unique_value PATH \"%AMENT_CURRENT_PREFIX%\\opt\\yaml_cpp_vendor\\bin\"","path":"env_hook/yaml_cpp_vendor_library_path.bat","position":6,"original_position":6,"commit_id":"83fc886bb9da9a583ae7675301c01fda731bf726","original_commit_id":"83fc886bb9da9a583ae7675301c01fda731bf726","user":{"login":"wjwwood","id":100427,"node_id":"MDQ6VXNlcjEwMDQyNw==","avatar_url":"https://avatars1.githubusercontent.com/u/100427?v=4","gravatar_id":"","url":"https://api.github.com/users/wjwwood","html_url":"https://github.com/wjwwood","followers_url":"https://api.github.com/users/wjwwood/followers","following_url":"https://api.github.com/users/wjwwood/following{/other_user}","gists_url":"https://api.github.com/users/wjwwood/gists{/gist_id}","starred_url":"https://api.github.com/users/wjwwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjwwood/subscriptions","organizations_url":"https://api.github.com/users/wjwwood/orgs","repos_url":"https://api.github.com/users/wjwwood/repos","events_url":"https://api.github.com/users/wjwwood/events{/privacy}","received_events_url":"https://api.github.com/users/wjwwood/received_events","type":"User","site_admin":false},"body":"One thing to point out is that I placed this in `<prefix>/opt/...` to avoid conflicting with the system yaml-cpp, but if other packages are going to start using it, then that might need to change. I don't think that needs to be done right now, but I just wanted to make you aware.","created_at":"2018-10-11T17:03:11Z","updated_at":"2018-10-11T17:05:10Z","html_url":"https://github.com/ros2/yaml_cpp_vendor/pull/1#discussion_r224527779","pull_request_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/pulls/1","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ros2/yaml_cpp_vendor/pulls/comments/224527779"},"html":{"href":"https://github.com/ros2/yaml_cpp_vendor/pull/1#discussion_r224527779"},"pull_request":{"href":"https://api.github.com/repos/ros2/yaml_cpp_vendor/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/pulls/1","id":222154800,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMTU0ODAw","html_url":"https://github.com/ros2/yaml_cpp_vendor/pull/1","diff_url":"https://github.com/ros2/yaml_cpp_vendor/pull/1.diff","patch_url":"https://github.com/ros2/yaml_cpp_vendor/pull/1.patch","issue_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/issues/1","number":1,"state":"open","locked":false,"title":"Renaming rviz_yaml_cpp_vendor to yaml_cpp_vendor","user":{"login":"mjcarroll","id":279701,"node_id":"MDQ6VXNlcjI3OTcwMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/279701?v=4","gravatar_id":"","url":"https://api.github.com/users/mjcarroll","html_url":"https://github.com/mjcarroll","followers_url":"https://api.github.com/users/mjcarroll/followers","following_url":"https://api.github.com/users/mjcarroll/following{/other_user}","gists_url":"https://api.github.com/users/mjcarroll/gists{/gist_id}","starred_url":"https://api.github.com/users/mjcarroll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjcarroll/subscriptions","organizations_url":"https://api.github.com/users/mjcarroll/orgs","repos_url":"https://api.github.com/users/mjcarroll/repos","events_url":"https://api.github.com/users/mjcarroll/events{/privacy}","received_events_url":"https://api.github.com/users/mjcarroll/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-11T14:14:08Z","updated_at":"2018-10-11T17:05:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dc0cbb7ca556bb325c68b1af29cd220e0ad68975","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/pulls/1/commits","review_comments_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/pulls/1/comments","review_comment_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/issues/1/comments","statuses_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/statuses/83fc886bb9da9a583ae7675301c01fda731bf726","head":{"label":"ros2:split_yaml_cpp","ref":"split_yaml_cpp","sha":"83fc886bb9da9a583ae7675301c01fda731bf726","user":{"login":"ros2","id":3979232,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzkyMzI=","avatar_url":"https://avatars1.githubusercontent.com/u/3979232?v=4","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"repo":{"id":152602714,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI2MDI3MTQ=","name":"yaml_cpp_vendor","full_name":"ros2/yaml_cpp_vendor","private":false,"owner":{"login":"ros2","id":3979232,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzkyMzI=","avatar_url":"https://avatars1.githubusercontent.com/u/3979232?v=4","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ros2/yaml_cpp_vendor","description":"Vendor package for providing yaml cpp within a cmake package","fork":false,"url":"https://api.github.com/repos/ros2/yaml_cpp_vendor","forks_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/forks","keys_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/teams","hooks_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/hooks","issue_events_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/issues/events{/number}","events_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/events","assignees_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/assignees{/user}","branches_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/branches{/branch}","tags_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/tags","blobs_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/statuses/{sha}","languages_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/languages","stargazers_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/stargazers","contributors_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/contributors","subscribers_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/subscribers","subscription_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/subscription","commits_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/contents/{+path}","compare_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/merges","archive_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/downloads","issues_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/issues{/number}","pulls_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/pulls{/number}","milestones_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/milestones{/number}","notifications_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/labels{/name}","releases_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/releases{/id}","deployments_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/deployments","created_at":"2018-10-11T14:12:38Z","updated_at":"2018-10-11T16:37:44Z","pushed_at":"2018-10-11T14:14:09Z","git_url":"git://github.com/ros2/yaml_cpp_vendor.git","ssh_url":"git@github.com:ros2/yaml_cpp_vendor.git","clone_url":"https://github.com/ros2/yaml_cpp_vendor.git","svn_url":"https://github.com/ros2/yaml_cpp_vendor","homepage":null,"size":13,"stargazers_count":0,"watchers_count":0,"language":"CMake","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ros2:master","ref":"master","sha":"d0df8118132d01cb1bce5a3ddc98f72b6fe78180","user":{"login":"ros2","id":3979232,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzkyMzI=","avatar_url":"https://avatars1.githubusercontent.com/u/3979232?v=4","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"repo":{"id":152602714,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI2MDI3MTQ=","name":"yaml_cpp_vendor","full_name":"ros2/yaml_cpp_vendor","private":false,"owner":{"login":"ros2","id":3979232,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzkyMzI=","avatar_url":"https://avatars1.githubusercontent.com/u/3979232?v=4","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ros2/yaml_cpp_vendor","description":"Vendor package for providing yaml cpp within a cmake package","fork":false,"url":"https://api.github.com/repos/ros2/yaml_cpp_vendor","forks_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/forks","keys_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/teams","hooks_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/hooks","issue_events_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/issues/events{/number}","events_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/events","assignees_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/assignees{/user}","branches_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/branches{/branch}","tags_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/tags","blobs_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/statuses/{sha}","languages_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/languages","stargazers_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/stargazers","contributors_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/contributors","subscribers_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/subscribers","subscription_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/subscription","commits_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/contents/{+path}","compare_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/merges","archive_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/downloads","issues_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/issues{/number}","pulls_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/pulls{/number}","milestones_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/milestones{/number}","notifications_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/labels{/name}","releases_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/releases{/id}","deployments_url":"https://api.github.com/repos/ros2/yaml_cpp_vendor/deployments","created_at":"2018-10-11T14:12:38Z","updated_at":"2018-10-11T16:37:44Z","pushed_at":"2018-10-11T14:14:09Z","git_url":"git://github.com/ros2/yaml_cpp_vendor.git","ssh_url":"git@github.com:ros2/yaml_cpp_vendor.git","clone_url":"https://github.com/ros2/yaml_cpp_vendor.git","svn_url":"https://github.com/ros2/yaml_cpp_vendor","homepage":null,"size":13,"stargazers_count":0,"watchers_count":0,"language":"CMake","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ros2/yaml_cpp_vendor/pulls/1"},"html":{"href":"https://github.com/ros2/yaml_cpp_vendor/pull/1"},"issue":{"href":"https://api.github.com/repos/ros2/yaml_cpp_vendor/issues/1"},"comments":{"href":"https://api.github.com/repos/ros2/yaml_cpp_vendor/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/ros2/yaml_cpp_vendor/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/ros2/yaml_cpp_vendor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros2/yaml_cpp_vendor/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/ros2/yaml_cpp_vendor/statuses/83fc886bb9da9a583ae7675301c01fda731bf726"}},"author_association":"NONE"}}
{"actor":{"display_login":"wjwwood"}}