{"action":"created","comment":{"url":"https://api.github.com/repos/IFL-CAMP/simple/pulls/comments/203070818","pull_request_review_id":137889095,"id":203070818,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzA3MDgxOA==","diff_hunk":"@@ -33,8 +33,12 @@ void example_callback(const simple_msgs::Image<uint8_t>& i) {\n \n   // Get the image dimensions, e.g. 512x512x1.\n   const auto dimensions = i.getImageDimensions();\n+\n   // Build an OpenCV Mat from those.\n-  cv::Mat received_img{dimensions[1], dimensions[0], CV_8UC(i.getNumChannels()), img};\n+  // We need to cast the image dimensions, since OpenCV takes signed ints :(\n+  cv::Mat received_img{static_cast<int>(dimensions[1]), static_cast<int>(dimensions[0]), CV_8UC(i.getNumChannels()),\n+                       img};\n+  cv::Mat();","path":"examples/src/example_image_subscriber.cpp","position":10,"original_position":10,"commit_id":"8bc8dc62055c61c17df8e601f9ff3c9a44fcf114","original_commit_id":"8bc8dc62055c61c17df8e601f9ff3c9a44fcf114","user":{"login":"SalvoVirga","id":2053024,"node_id":"MDQ6VXNlcjIwNTMwMjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2053024?v=4","gravatar_id":"","url":"https://api.github.com/users/SalvoVirga","html_url":"https://github.com/SalvoVirga","followers_url":"https://api.github.com/users/SalvoVirga/followers","following_url":"https://api.github.com/users/SalvoVirga/following{/other_user}","gists_url":"https://api.github.com/users/SalvoVirga/gists{/gist_id}","starred_url":"https://api.github.com/users/SalvoVirga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SalvoVirga/subscriptions","organizations_url":"https://api.github.com/users/SalvoVirga/orgs","repos_url":"https://api.github.com/users/SalvoVirga/repos","events_url":"https://api.github.com/users/SalvoVirga/events{/privacy}","received_events_url":"https://api.github.com/users/SalvoVirga/received_events","type":"User","site_admin":false},"body":"ups, a left over from debugging","created_at":"2018-07-17T15:33:26Z","updated_at":"2018-07-17T15:33:26Z","html_url":"https://github.com/IFL-CAMP/simple/pull/30#discussion_r203070818","pull_request_url":"https://api.github.com/repos/IFL-CAMP/simple/pulls/30","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/IFL-CAMP/simple/pulls/comments/203070818"},"html":{"href":"https://github.com/IFL-CAMP/simple/pull/30#discussion_r203070818"},"pull_request":{"href":"https://api.github.com/repos/IFL-CAMP/simple/pulls/30"}},"in_reply_to_id":203068877},"pull_request":{"url":"https://api.github.com/repos/IFL-CAMP/simple/pulls/30","id":201931463,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxOTMxNDYz","html_url":"https://github.com/IFL-CAMP/simple/pull/30","diff_url":"https://github.com/IFL-CAMP/simple/pull/30.diff","patch_url":"https://github.com/IFL-CAMP/simple/pull/30.patch","issue_url":"https://api.github.com/repos/IFL-CAMP/simple/issues/30","number":30,"state":"open","locked":false,"title":"simple_msgs::Image cleanup","user":{"login":"SalvoVirga","id":2053024,"node_id":"MDQ6VXNlcjIwNTMwMjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2053024?v=4","gravatar_id":"","url":"https://api.github.com/users/SalvoVirga","html_url":"https://github.com/SalvoVirga","followers_url":"https://api.github.com/users/SalvoVirga/followers","following_url":"https://api.github.com/users/SalvoVirga/following{/other_user}","gists_url":"https://api.github.com/users/SalvoVirga/gists{/gist_id}","starred_url":"https://api.github.com/users/SalvoVirga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SalvoVirga/subscriptions","organizations_url":"https://api.github.com/users/SalvoVirga/orgs","repos_url":"https://api.github.com/users/SalvoVirga/repos","events_url":"https://api.github.com/users/SalvoVirga/events{/privacy}","received_events_url":"https://api.github.com/users/SalvoVirga/received_events","type":"User","site_admin":false},"body":"Fixes #28 \r\n\r\nFields related to the distance between pixels in the image/volume (aka resolution or spacing) are not called spacing_x_, spacing_y_ and spacing_z_. Relative methods also changed their names.\r\n\r\nImage fields should now have the correct size:\r\nwidth, height and depth are now uint32\r\ndata_size is a uint64\r\nnum_channels is an ushort","created_at":"2018-07-17T12:54:07Z","updated_at":"2018-07-17T15:33:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d710a766678649bf31f1732f5eca5e2249b1a69","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/IFL-CAMP/simple/pulls/30/commits","review_comments_url":"https://api.github.com/repos/IFL-CAMP/simple/pulls/30/comments","review_comment_url":"https://api.github.com/repos/IFL-CAMP/simple/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IFL-CAMP/simple/issues/30/comments","statuses_url":"https://api.github.com/repos/IFL-CAMP/simple/statuses/8bc8dc62055c61c17df8e601f9ff3c9a44fcf114","head":{"label":"IFL-CAMP:fix/ImageMsg","ref":"fix/ImageMsg","sha":"8bc8dc62055c61c17df8e601f9ff3c9a44fcf114","user":{"login":"IFL-CAMP","id":32544626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNTQ0NjI2","avatar_url":"https://avatars2.githubusercontent.com/u/32544626?v=4","gravatar_id":"","url":"https://api.github.com/users/IFL-CAMP","html_url":"https://github.com/IFL-CAMP","followers_url":"https://api.github.com/users/IFL-CAMP/followers","following_url":"https://api.github.com/users/IFL-CAMP/following{/other_user}","gists_url":"https://api.github.com/users/IFL-CAMP/gists{/gist_id}","starred_url":"https://api.github.com/users/IFL-CAMP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IFL-CAMP/subscriptions","organizations_url":"https://api.github.com/users/IFL-CAMP/orgs","repos_url":"https://api.github.com/users/IFL-CAMP/repos","events_url":"https://api.github.com/users/IFL-CAMP/events{/privacy}","received_events_url":"https://api.github.com/users/IFL-CAMP/received_events","type":"Organization","site_admin":false},"repo":{"id":118499715,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg0OTk3MTU=","name":"simple","full_name":"IFL-CAMP/simple","owner":{"login":"IFL-CAMP","id":32544626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNTQ0NjI2","avatar_url":"https://avatars2.githubusercontent.com/u/32544626?v=4","gravatar_id":"","url":"https://api.github.com/users/IFL-CAMP","html_url":"https://github.com/IFL-CAMP","followers_url":"https://api.github.com/users/IFL-CAMP/followers","following_url":"https://api.github.com/users/IFL-CAMP/following{/other_user}","gists_url":"https://api.github.com/users/IFL-CAMP/gists{/gist_id}","starred_url":"https://api.github.com/users/IFL-CAMP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IFL-CAMP/subscriptions","organizations_url":"https://api.github.com/users/IFL-CAMP/orgs","repos_url":"https://api.github.com/users/IFL-CAMP/repos","events_url":"https://api.github.com/users/IFL-CAMP/events{/privacy}","received_events_url":"https://api.github.com/users/IFL-CAMP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IFL-CAMP/simple","description":"S.I.M.P.L.E. - Smart Intuitive Messaging Platform with Less Effort. A Cross-Platform C++ Library to Exchange Data Across Network.","fork":false,"url":"https://api.github.com/repos/IFL-CAMP/simple","forks_url":"https://api.github.com/repos/IFL-CAMP/simple/forks","keys_url":"https://api.github.com/repos/IFL-CAMP/simple/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IFL-CAMP/simple/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IFL-CAMP/simple/teams","hooks_url":"https://api.github.com/repos/IFL-CAMP/simple/hooks","issue_events_url":"https://api.github.com/repos/IFL-CAMP/simple/issues/events{/number}","events_url":"https://api.github.com/repos/IFL-CAMP/simple/events","assignees_url":"https://api.github.com/repos/IFL-CAMP/simple/assignees{/user}","branches_url":"https://api.github.com/repos/IFL-CAMP/simple/branches{/branch}","tags_url":"https://api.github.com/repos/IFL-CAMP/simple/tags","blobs_url":"https://api.github.com/repos/IFL-CAMP/simple/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IFL-CAMP/simple/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IFL-CAMP/simple/git/refs{/sha}","trees_url":"https://api.github.com/repos/IFL-CAMP/simple/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IFL-CAMP/simple/statuses/{sha}","languages_url":"https://api.github.com/repos/IFL-CAMP/simple/languages","stargazers_url":"https://api.github.com/repos/IFL-CAMP/simple/stargazers","contributors_url":"https://api.github.com/repos/IFL-CAMP/simple/contributors","subscribers_url":"https://api.github.com/repos/IFL-CAMP/simple/subscribers","subscription_url":"https://api.github.com/repos/IFL-CAMP/simple/subscription","commits_url":"https://api.github.com/repos/IFL-CAMP/simple/commits{/sha}","git_commits_url":"https://api.github.com/repos/IFL-CAMP/simple/git/commits{/sha}","comments_url":"https://api.github.com/repos/IFL-CAMP/simple/comments{/number}","issue_comment_url":"https://api.github.com/repos/IFL-CAMP/simple/issues/comments{/number}","contents_url":"https://api.github.com/repos/IFL-CAMP/simple/contents/{+path}","compare_url":"https://api.github.com/repos/IFL-CAMP/simple/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IFL-CAMP/simple/merges","archive_url":"https://api.github.com/repos/IFL-CAMP/simple/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IFL-CAMP/simple/downloads","issues_url":"https://api.github.com/repos/IFL-CAMP/simple/issues{/number}","pulls_url":"https://api.github.com/repos/IFL-CAMP/simple/pulls{/number}","milestones_url":"https://api.github.com/repos/IFL-CAMP/simple/milestones{/number}","notifications_url":"https://api.github.com/repos/IFL-CAMP/simple/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IFL-CAMP/simple/labels{/name}","releases_url":"https://api.github.com/repos/IFL-CAMP/simple/releases{/id}","deployments_url":"https://api.github.com/repos/IFL-CAMP/simple/deployments","created_at":"2018-01-22T18:47:06Z","updated_at":"2018-07-16T15:35:36Z","pushed_at":"2018-07-17T14:47:26Z","git_url":"git://github.com/IFL-CAMP/simple.git","ssh_url":"git@github.com:IFL-CAMP/simple.git","clone_url":"https://github.com/IFL-CAMP/simple.git","svn_url":"https://github.com/IFL-CAMP/simple","homepage":"","size":23991,"stargazers_count":6,"watchers_count":6,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":3,"open_issues":9,"watchers":6,"default_branch":"master"}},"base":{"label":"IFL-CAMP:master","ref":"master","sha":"99073539c004f2b2c874fd7e38105f23584544b8","user":{"login":"IFL-CAMP","id":32544626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNTQ0NjI2","avatar_url":"https://avatars2.githubusercontent.com/u/32544626?v=4","gravatar_id":"","url":"https://api.github.com/users/IFL-CAMP","html_url":"https://github.com/IFL-CAMP","followers_url":"https://api.github.com/users/IFL-CAMP/followers","following_url":"https://api.github.com/users/IFL-CAMP/following{/other_user}","gists_url":"https://api.github.com/users/IFL-CAMP/gists{/gist_id}","starred_url":"https://api.github.com/users/IFL-CAMP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IFL-CAMP/subscriptions","organizations_url":"https://api.github.com/users/IFL-CAMP/orgs","repos_url":"https://api.github.com/users/IFL-CAMP/repos","events_url":"https://api.github.com/users/IFL-CAMP/events{/privacy}","received_events_url":"https://api.github.com/users/IFL-CAMP/received_events","type":"Organization","site_admin":false},"repo":{"id":118499715,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg0OTk3MTU=","name":"simple","full_name":"IFL-CAMP/simple","owner":{"login":"IFL-CAMP","id":32544626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNTQ0NjI2","avatar_url":"https://avatars2.githubusercontent.com/u/32544626?v=4","gravatar_id":"","url":"https://api.github.com/users/IFL-CAMP","html_url":"https://github.com/IFL-CAMP","followers_url":"https://api.github.com/users/IFL-CAMP/followers","following_url":"https://api.github.com/users/IFL-CAMP/following{/other_user}","gists_url":"https://api.github.com/users/IFL-CAMP/gists{/gist_id}","starred_url":"https://api.github.com/users/IFL-CAMP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IFL-CAMP/subscriptions","organizations_url":"https://api.github.com/users/IFL-CAMP/orgs","repos_url":"https://api.github.com/users/IFL-CAMP/repos","events_url":"https://api.github.com/users/IFL-CAMP/events{/privacy}","received_events_url":"https://api.github.com/users/IFL-CAMP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IFL-CAMP/simple","description":"S.I.M.P.L.E. - Smart Intuitive Messaging Platform with Less Effort. A Cross-Platform C++ Library to Exchange Data Across Network.","fork":false,"url":"https://api.github.com/repos/IFL-CAMP/simple","forks_url":"https://api.github.com/repos/IFL-CAMP/simple/forks","keys_url":"https://api.github.com/repos/IFL-CAMP/simple/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IFL-CAMP/simple/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IFL-CAMP/simple/teams","hooks_url":"https://api.github.com/repos/IFL-CAMP/simple/hooks","issue_events_url":"https://api.github.com/repos/IFL-CAMP/simple/issues/events{/number}","events_url":"https://api.github.com/repos/IFL-CAMP/simple/events","assignees_url":"https://api.github.com/repos/IFL-CAMP/simple/assignees{/user}","branches_url":"https://api.github.com/repos/IFL-CAMP/simple/branches{/branch}","tags_url":"https://api.github.com/repos/IFL-CAMP/simple/tags","blobs_url":"https://api.github.com/repos/IFL-CAMP/simple/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IFL-CAMP/simple/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IFL-CAMP/simple/git/refs{/sha}","trees_url":"https://api.github.com/repos/IFL-CAMP/simple/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IFL-CAMP/simple/statuses/{sha}","languages_url":"https://api.github.com/repos/IFL-CAMP/simple/languages","stargazers_url":"https://api.github.com/repos/IFL-CAMP/simple/stargazers","contributors_url":"https://api.github.com/repos/IFL-CAMP/simple/contributors","subscribers_url":"https://api.github.com/repos/IFL-CAMP/simple/subscribers","subscription_url":"https://api.github.com/repos/IFL-CAMP/simple/subscription","commits_url":"https://api.github.com/repos/IFL-CAMP/simple/commits{/sha}","git_commits_url":"https://api.github.com/repos/IFL-CAMP/simple/git/commits{/sha}","comments_url":"https://api.github.com/repos/IFL-CAMP/simple/comments{/number}","issue_comment_url":"https://api.github.com/repos/IFL-CAMP/simple/issues/comments{/number}","contents_url":"https://api.github.com/repos/IFL-CAMP/simple/contents/{+path}","compare_url":"https://api.github.com/repos/IFL-CAMP/simple/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IFL-CAMP/simple/merges","archive_url":"https://api.github.com/repos/IFL-CAMP/simple/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IFL-CAMP/simple/downloads","issues_url":"https://api.github.com/repos/IFL-CAMP/simple/issues{/number}","pulls_url":"https://api.github.com/repos/IFL-CAMP/simple/pulls{/number}","milestones_url":"https://api.github.com/repos/IFL-CAMP/simple/milestones{/number}","notifications_url":"https://api.github.com/repos/IFL-CAMP/simple/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IFL-CAMP/simple/labels{/name}","releases_url":"https://api.github.com/repos/IFL-CAMP/simple/releases{/id}","deployments_url":"https://api.github.com/repos/IFL-CAMP/simple/deployments","created_at":"2018-01-22T18:47:06Z","updated_at":"2018-07-16T15:35:36Z","pushed_at":"2018-07-17T14:47:26Z","git_url":"git://github.com/IFL-CAMP/simple.git","ssh_url":"git@github.com:IFL-CAMP/simple.git","clone_url":"https://github.com/IFL-CAMP/simple.git","svn_url":"https://github.com/IFL-CAMP/simple","homepage":"","size":23991,"stargazers_count":6,"watchers_count":6,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":3,"open_issues":9,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/IFL-CAMP/simple/pulls/30"},"html":{"href":"https://github.com/IFL-CAMP/simple/pull/30"},"issue":{"href":"https://api.github.com/repos/IFL-CAMP/simple/issues/30"},"comments":{"href":"https://api.github.com/repos/IFL-CAMP/simple/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/IFL-CAMP/simple/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/IFL-CAMP/simple/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IFL-CAMP/simple/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/IFL-CAMP/simple/statuses/8bc8dc62055c61c17df8e601f9ff3c9a44fcf114"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"SalvoVirga"}}