{"action":"created","issue":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/7457","repository_url":"https://api.github.com/repos/ARMmbed/mbed-os","labels_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/7457/labels{/name}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/7457/comments","events_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/7457/events","html_url":"https://github.com/ARMmbed/mbed-os/issues/7457","id":339756430,"node_id":"MDU6SXNzdWUzMzk3NTY0MzA=","number":7457,"title":"Avoid compiling features/cellular files when not needed","user":{"login":"adustm","id":14051363,"node_id":"MDQ6VXNlcjE0MDUxMzYz","avatar_url":"https://avatars0.githubusercontent.com/u/14051363?v=4","gravatar_id":"","url":"https://api.github.com/users/adustm","html_url":"https://github.com/adustm","followers_url":"https://api.github.com/users/adustm/followers","following_url":"https://api.github.com/users/adustm/following{/other_user}","gists_url":"https://api.github.com/users/adustm/gists{/gist_id}","starred_url":"https://api.github.com/users/adustm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adustm/subscriptions","organizations_url":"https://api.github.com/users/adustm/orgs","repos_url":"https://api.github.com/users/adustm/repos","events_url":"https://api.github.com/users/adustm/events{/privacy}","received_events_url":"https://api.github.com/users/adustm/received_events","type":"User","site_admin":false},"labels":[{"id":1076635261,"node_id":"MDU6TGFiZWwxMDc2NjM1MjYx","url":"https://api.github.com/repos/ARMmbed/mbed-os/labels/Jira%20status:%20REOPENED","name":"Jira status: REOPENED","color":"f9d0c4","default":false},{"id":427713129,"node_id":"MDU6TGFiZWw0Mjc3MTMxMjk=","url":"https://api.github.com/repos/ARMmbed/mbed-os/labels/mirrored","name":"mirrored","color":"ededed","default":false},{"id":28847983,"node_id":"MDU6TGFiZWwyODg0Nzk4Mw==","url":"https://api.github.com/repos/ARMmbed/mbed-os/labels/type:%20question","name":"type: question","color":"cccccc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2018-07-10T09:11:03Z","updated_at":"2018-10-03T12:49:26Z","closed_at":null,"author_association":"MEMBER","body":"### Description\r\nI compile mbed-os for DISCO_L475VG_IOT01A \r\nI see undesired files, as this target is not concerned by cellular things\r\n```\r\nCompile [  3.8%]: AT_CellularBase.cpp\r\nCompile [  4.0%]: ATHandler.cpp\r\nCompile [  4.1%]: AT_CellularDevice.cpp\r\nCompile [  4.2%]: AT_CellularInformation.cpp\r\nCompile [  4.3%]: AT_CellularPower.cpp\r\nCompile [  4.4%]: AT_CellularNetwork.cpp\r\nCompile [  4.5%]: AT_CellularSIM.cpp\r\nCompile [  4.7%]: CellularLog.cpp\r\nCompile [  4.8%]: AT_CellularSMS.cpp\r\nCompile [  4.9%]: CellularUtil.cpp\r\nCompile [  5.0%]: AT_CellularStack.cpp\r\nCompile [  5.1%]: QUECTEL_BC95.cpp\r\nCompile [  5.2%]: QUECTEL_BC95_CellularPower.cpp\r\nCompile [  5.4%]: QUECTEL_BC95_CellularSIM.cpp\r\nCompile [  5.5%]: QUECTEL_BC95_CellularNetwork.cpp\r\nCompile [  5.6%]: QUECTEL_BC95_CellularStack.cpp\r\nCompile [  5.7%]: QUECTEL_BG96_CellularPower.cpp\r\nCompile [  5.8%]: QUECTEL_BG96_CellularNetwork.cpp\r\nCompile [  5.9%]: QUECTEL_BG96.cpp\r\nCompile [  6.1%]: QUECTEL_BG96_CellularSIM.cpp\r\nCompile [  6.2%]: QUECTEL_BG96_CellularStack.cpp\r\nCompile [  6.3%]: QUECTEL_UG96_CellularNetwork.cpp\r\nCompile [  6.4%]: QUECTEL_UG96.cpp\r\nCompile [  6.5%]: QUECTEL_UG96_CellularPower.cpp\r\nCompile [  6.6%]: TELIT_HE910_CellularNetwork.cpp\r\nCompile [  6.8%]: TELIT_HE910.cpp\r\nCompile [  6.9%]: TELIT_HE910_CellularPower.cpp\r\nCompile [  7.0%]: UBLOX_PPP.cpp\r\n```\r\nCould someone take the responsibility of checking completely the CELLULAR feature and add the correct `#ifdef `to avoid compiling those files when not needed ?\r\n\r\nI think it could be \r\n`#ifdef CELLULAR_DEVICE`\r\nor\r\n`#ifdef <TARGET_NAME>`\r\n\r\nThere are maybe other files in this feature\r\nThanks in advance\r\nArmelle\r\n\r\n### Issue request type\r\n    [] Question\r\n    [ ] Enhancement \r\n    [X] Bug \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/comments/426625244","html_url":"https://github.com/ARMmbed/mbed-os/issues/7457#issuecomment-426625244","issue_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/7457","id":426625244,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNjYyNTI0NA==","user":{"login":"AriParkkila","id":26764770,"node_id":"MDQ6VXNlcjI2NzY0Nzcw","avatar_url":"https://avatars3.githubusercontent.com/u/26764770?v=4","gravatar_id":"","url":"https://api.github.com/users/AriParkkila","html_url":"https://github.com/AriParkkila","followers_url":"https://api.github.com/users/AriParkkila/followers","following_url":"https://api.github.com/users/AriParkkila/following{/other_user}","gists_url":"https://api.github.com/users/AriParkkila/gists{/gist_id}","starred_url":"https://api.github.com/users/AriParkkila/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AriParkkila/subscriptions","organizations_url":"https://api.github.com/users/AriParkkila/orgs","repos_url":"https://api.github.com/users/AriParkkila/repos","events_url":"https://api.github.com/users/AriParkkila/events{/privacy}","received_events_url":"https://api.github.com/users/AriParkkila/received_events","type":"User","site_admin":false},"created_at":"2018-10-03T12:49:26Z","updated_at":"2018-10-03T12:49:26Z","author_association":"CONTRIBUTOR","body":"@sg- do you think cellular and lora should be component of feature?"}}
{"actor":{"display_login":"AriParkkila"}}