{"action":"created","issue":{"url":"https://api.github.com/repos/BBC-News/simorgh/issues/857","repository_url":"https://api.github.com/repos/BBC-News/simorgh","labels_url":"https://api.github.com/repos/BBC-News/simorgh/issues/857/labels{/name}","comments_url":"https://api.github.com/repos/BBC-News/simorgh/issues/857/comments","events_url":"https://api.github.com/repos/BBC-News/simorgh/issues/857/events","html_url":"https://github.com/BBC-News/simorgh/pull/857","id":374414195,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MTIyMjMz","number":857,"title":"Integrate timestamp component","user":{"login":"bcmn","id":11646957,"node_id":"MDQ6VXNlcjExNjQ2OTU3","avatar_url":"https://avatars3.githubusercontent.com/u/11646957?v=4","gravatar_id":"","url":"https://api.github.com/users/bcmn","html_url":"https://github.com/bcmn","followers_url":"https://api.github.com/users/bcmn/followers","following_url":"https://api.github.com/users/bcmn/following{/other_user}","gists_url":"https://api.github.com/users/bcmn/gists{/gist_id}","starred_url":"https://api.github.com/users/bcmn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcmn/subscriptions","organizations_url":"https://api.github.com/users/bcmn/orgs","repos_url":"https://api.github.com/users/bcmn/repos","events_url":"https://api.github.com/users/bcmn/events{/privacy}","received_events_url":"https://api.github.com/users/bcmn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-26T14:39:51Z","updated_at":"2018-10-29T11:46:10Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/BBC-News/simorgh/pulls/857","html_url":"https://github.com/BBC-News/simorgh/pull/857","diff_url":"https://github.com/BBC-News/simorgh/pull/857.diff","patch_url":"https://github.com/BBC-News/simorgh/pull/857.patch"},"body":"Resolves #826. Resolves #856.\r\n\r\nAdds the Timestamp component to articles, between the headline & the following block. Snapshot tests have been updated to expect this.\r\n\r\n**Additional changes**\r\n- I clarified that our data provider will return the timestamp in milliseconds -- the component no longer assumes the input was seconds & attempts to convert it, & the test data has been updated to reflect this.\r\n- Secondly, the `padding-bottom` wasn't appearing due to the implementation of the Timestamp component as a styled `span`. This is addressed by changing the implementation to a styled `div`.\r\n- Finally, a change was made to fix the issue with timestamp display format changing briefly on page load (#856). This also allows snapshots to accurately reflect the expected output, as intended by UX.\r\n\r\nAwaiting Cypress tests.\r\n\r\n- [ ] Tests added for new features\r\n- [ ] Test engineer approval"},"comment":{"url":"https://api.github.com/repos/BBC-News/simorgh/issues/comments/433881001","html_url":"https://github.com/BBC-News/simorgh/pull/857#issuecomment-433881001","issue_url":"https://api.github.com/repos/BBC-News/simorgh/issues/857","id":433881001,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzg4MTAwMQ==","user":{"login":"codeclimate[bot]","id":36754821,"node_id":"MDM6Qm90MzY3NTQ4MjE=","avatar_url":"https://avatars0.githubusercontent.com/in/9403?v=4","gravatar_id":"","url":"https://api.github.com/users/codeclimate%5Bbot%5D","html_url":"https://github.com/apps/codeclimate","followers_url":"https://api.github.com/users/codeclimate%5Bbot%5D/followers","following_url":"https://api.github.com/users/codeclimate%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codeclimate%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codeclimate%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeclimate%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codeclimate%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codeclimate%5Bbot%5D/repos","events_url":"https://api.github.com/users/codeclimate%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codeclimate%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-10-29T11:46:10Z","updated_at":"2018-10-29T11:46:10Z","author_association":"NONE","body":"Code Climate has analyzed commit 121029fe and detected **2 issues** on this pull request.\n\nHere's the issue category breakdown:\n\n| Category | Count |\n|:---:|:---:|\n| Duplication | 2 |\n\n\nThe test coverage on the diff in this pull request is **100.0%** (**90%** is the threshold).\n\nThis pull request will bring the total coverage in the repository to **96.7%** (**0.0%** change).\n\nView more on [Code Climate](https://codeclimate.com/github/BBC-News/simorgh/pull/857).\n"}}
{"actor":{"display_login":"codeclimate"}}