{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/176421974","pull_request_review_id":106119469,"id":176421974,"diff_hunk":"@@ -486,64 +441,44 @@ def get_tests(self):\n         yield TestInstance([[self.create_test_block([bip112tx_special_v2]), False]])\n \n         # If SEQUENCE_LOCKTIME_DISABLE_FLAG is set in argument to OP_CSV, version 2 txs should pass (all sequence locks are met)\n-        success_txs = []\n-        for b25 in range(2):\n-            for b22 in range(2):\n-                for b18 in range(2):\n-                    success_txs.append(bip112txs_vary_OP_CSV_v2[1][b25][b22][b18])  # 8/16 of vary_OP_CSV\n-                    success_txs.append(bip112txs_vary_OP_CSV_9_v2[1][b25][b22][b18])  # 8/16 of vary_OP_CSV_9\n+        success_txs = [tx['tx'] for tx in bip112txs_vary_OP_CSV_v2 if tx['sdf']]\n+        success_txs += [tx['tx'] for tx in bip112txs_vary_OP_CSV_9_v2 if tx['sdf']]\n \n         yield TestInstance([[self.create_test_block(success_txs), True]])\n         self.nodes[0].invalidateblock(self.nodes[0].getbestblockhash())\n \n         # SEQUENCE_LOCKTIME_DISABLE_FLAG is unset in argument to OP_CSV for all remaining txs ##\n \n         # All txs with nSequence 9 should fail either due to earlier mismatch or failing the CSV check\n-        fail_txs = []\n-        fail_txs.extend(all_rlt_txs(bip112txs_vary_nSequence_9_v2))  # 16/16 of vary_nSequence_9\n-        for b25 in range(2):\n-            for b22 in range(2):\n-                for b18 in range(2):\n-                    fail_txs.append(bip112txs_vary_OP_CSV_9_v2[0][b25][b22][b18])  # 16/16 of vary_OP_CSV_9\n-\n+        fail_txs = all_rlt_txs(bip112txs_vary_nSequence_9_v2)  # 16/16 of vary_nSequence_9","path":"test/functional/feature_csv_activation.py","position":null,"original_position":249,"commit_id":"12982682a602ee656ce74b5733747a05d70907f8","original_commit_id":"c5427d1f4e3652a1b55968c752fb362b31996186","user":{"login":"jnewbery","id":1063656,"avatar_url":"https://avatars3.githubusercontent.com/u/1063656?v=4","gravatar_id":"","url":"https://api.github.com/users/jnewbery","html_url":"https://github.com/jnewbery","followers_url":"https://api.github.com/users/jnewbery/followers","following_url":"https://api.github.com/users/jnewbery/following{/other_user}","gists_url":"https://api.github.com/users/jnewbery/gists{/gist_id}","starred_url":"https://api.github.com/users/jnewbery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnewbery/subscriptions","organizations_url":"https://api.github.com/users/jnewbery/orgs","repos_url":"https://api.github.com/users/jnewbery/repos","events_url":"https://api.github.com/users/jnewbery/events{/privacy}","received_events_url":"https://api.github.com/users/jnewbery/received_events","type":"User","site_admin":false},"body":"I missed this one. Now removed.","created_at":"2018-03-22T13:39:24Z","updated_at":"2018-03-22T13:39:24Z","html_url":"https://github.com/bitcoin/bitcoin/pull/11817#discussion_r176421974","pull_request_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/11817","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/176421974"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/11817#discussion_r176421974"},"pull_request":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/11817"}},"in_reply_to_id":176245410},"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/11817","id":156019910,"html_url":"https://github.com/bitcoin/bitcoin/pull/11817","diff_url":"https://github.com/bitcoin/bitcoin/pull/11817.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/11817.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/11817","number":11817,"state":"open","locked":false,"title":"[tests] Change feature_csv_activation.py to use BitcoinTestFramework","user":{"login":"jnewbery","id":1063656,"avatar_url":"https://avatars3.githubusercontent.com/u/1063656?v=4","gravatar_id":"","url":"https://api.github.com/users/jnewbery","html_url":"https://github.com/jnewbery","followers_url":"https://api.github.com/users/jnewbery/followers","following_url":"https://api.github.com/users/jnewbery/following{/other_user}","gists_url":"https://api.github.com/users/jnewbery/gists{/gist_id}","starred_url":"https://api.github.com/users/jnewbery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnewbery/subscriptions","organizations_url":"https://api.github.com/users/jnewbery/orgs","repos_url":"https://api.github.com/users/jnewbery/repos","events_url":"https://api.github.com/users/jnewbery/events{/privacy}","received_events_url":"https://api.github.com/users/jnewbery/received_events","type":"User","site_admin":false},"body":"Next step in #10603.\r\n\r\n- first four commits tidy up bip68-112-113-p2p.py\r\n- fifth commit removes usage of ComparisonTestFramework","created_at":"2017-12-02T16:26:58Z","updated_at":"2018-03-22T13:39:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b8b4d27c590d455830f59ea4db4549eab0579cf5","assignee":{"login":"MarcoFalke","id":6399679,"avatar_url":"https://avatars0.githubusercontent.com/u/6399679?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcoFalke","html_url":"https://github.com/MarcoFalke","followers_url":"https://api.github.com/users/MarcoFalke/followers","following_url":"https://api.github.com/users/MarcoFalke/following{/other_user}","gists_url":"https://api.github.com/users/MarcoFalke/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcoFalke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcoFalke/subscriptions","organizations_url":"https://api.github.com/users/MarcoFalke/orgs","repos_url":"https://api.github.com/users/MarcoFalke/repos","events_url":"https://api.github.com/users/MarcoFalke/events{/privacy}","received_events_url":"https://api.github.com/users/MarcoFalke/received_events","type":"User","site_admin":false},"assignees":[{"login":"MarcoFalke","id":6399679,"avatar_url":"https://avatars0.githubusercontent.com/u/6399679?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcoFalke","html_url":"https://github.com/MarcoFalke","followers_url":"https://api.github.com/users/MarcoFalke/followers","following_url":"https://api.github.com/users/MarcoFalke/following{/other_user}","gists_url":"https://api.github.com/users/MarcoFalke/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcoFalke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcoFalke/subscriptions","organizations_url":"https://api.github.com/users/MarcoFalke/orgs","repos_url":"https://api.github.com/users/MarcoFalke/repos","events_url":"https://api.github.com/users/MarcoFalke/events{/privacy}","received_events_url":"https://api.github.com/users/MarcoFalke/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":62963516,"url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Tests","name":"Tests","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/11817/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/11817/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/11817/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/12982682a602ee656ce74b5733747a05d70907f8","head":{"label":"jnewbery:refactor_bip68-112-113-p2p","ref":"refactor_bip68-112-113-p2p","sha":"12982682a602ee656ce74b5733747a05d70907f8","user":{"login":"jnewbery","id":1063656,"avatar_url":"https://avatars3.githubusercontent.com/u/1063656?v=4","gravatar_id":"","url":"https://api.github.com/users/jnewbery","html_url":"https://github.com/jnewbery","followers_url":"https://api.github.com/users/jnewbery/followers","following_url":"https://api.github.com/users/jnewbery/following{/other_user}","gists_url":"https://api.github.com/users/jnewbery/gists{/gist_id}","starred_url":"https://api.github.com/users/jnewbery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnewbery/subscriptions","organizations_url":"https://api.github.com/users/jnewbery/orgs","repos_url":"https://api.github.com/users/jnewbery/repos","events_url":"https://api.github.com/users/jnewbery/events{/privacy}","received_events_url":"https://api.github.com/users/jnewbery/received_events","type":"User","site_admin":false},"repo":{"id":68248485,"name":"bitcoin","full_name":"jnewbery/bitcoin","owner":{"login":"jnewbery","id":1063656,"avatar_url":"https://avatars3.githubusercontent.com/u/1063656?v=4","gravatar_id":"","url":"https://api.github.com/users/jnewbery","html_url":"https://github.com/jnewbery","followers_url":"https://api.github.com/users/jnewbery/followers","following_url":"https://api.github.com/users/jnewbery/following{/other_user}","gists_url":"https://api.github.com/users/jnewbery/gists{/gist_id}","starred_url":"https://api.github.com/users/jnewbery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnewbery/subscriptions","organizations_url":"https://api.github.com/users/jnewbery/orgs","repos_url":"https://api.github.com/users/jnewbery/repos","events_url":"https://api.github.com/users/jnewbery/events{/privacy}","received_events_url":"https://api.github.com/users/jnewbery/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jnewbery/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/jnewbery/bitcoin","forks_url":"https://api.github.com/repos/jnewbery/bitcoin/forks","keys_url":"https://api.github.com/repos/jnewbery/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jnewbery/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jnewbery/bitcoin/teams","hooks_url":"https://api.github.com/repos/jnewbery/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/jnewbery/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/jnewbery/bitcoin/events","assignees_url":"https://api.github.com/repos/jnewbery/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/jnewbery/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/jnewbery/bitcoin/tags","blobs_url":"https://api.github.com/repos/jnewbery/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jnewbery/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jnewbery/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jnewbery/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jnewbery/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/jnewbery/bitcoin/languages","stargazers_url":"https://api.github.com/repos/jnewbery/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/jnewbery/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/jnewbery/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/jnewbery/bitcoin/subscription","commits_url":"https://api.github.com/repos/jnewbery/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jnewbery/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jnewbery/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jnewbery/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jnewbery/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/jnewbery/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jnewbery/bitcoin/merges","archive_url":"https://api.github.com/repos/jnewbery/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jnewbery/bitcoin/downloads","issues_url":"https://api.github.com/repos/jnewbery/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/jnewbery/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/jnewbery/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/jnewbery/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jnewbery/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/jnewbery/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/jnewbery/bitcoin/deployments","created_at":"2016-09-14T22:29:05Z","updated_at":"2016-09-14T22:29:18Z","pushed_at":"2018-03-22T13:38:59Z","git_url":"git://github.com/jnewbery/bitcoin.git","ssh_url":"git@github.com:jnewbery/bitcoin.git","clone_url":"https://github.com/jnewbery/bitcoin.git","svn_url":"https://github.com/jnewbery/bitcoin","homepage":"https://bitcoin.org/en/download","size":107880,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"a6926b065d654a448937f9f1e2999ac48d50a984","user":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"name":"bitcoin","full_name":"bitcoin/bitcoin","owner":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2018-03-22T13:29:40Z","pushed_at":"2018-03-22T13:39:02Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoin.org/en/download","size":103018,"stargazers_count":29668,"watchers_count":29668,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":17740,"mirror_url":null,"archived":false,"open_issues_count":807,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":17740,"open_issues":807,"watchers":29668,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/11817"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/11817"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/11817"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/11817/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/11817/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/11817/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/12982682a602ee656ce74b5733747a05d70907f8"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jnewbery"}}