{"action":"created","comment":{"url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/comments/195725640","pull_request_review_id":129153328,"id":195725640,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTcyNTY0MA==","diff_hunk":"@@ -181,3 +182,7 @@ func plat_reset_handler\n \tstr\tw1, [x0, #RPI3_INTC_MBOX_CONTROL_OFFSET]\n \tret\n endfunc plat_reset_handler\n+\n+func plat_interrupt_type_to_line","path":"plat/rpi3/aarch64/plat_helpers.S","position":13,"original_position":13,"commit_id":"bd996dfafbcd49b9ff7b6d64647d0bf0e7dad65f","original_commit_id":"8cc6c1526c306c230d7f4e1f8d03c0997a0a9ba2","user":{"login":"soby-mathew","id":6860836,"node_id":"MDQ6VXNlcjY4NjA4MzY=","avatar_url":"https://avatars3.githubusercontent.com/u/6860836?v=4","gravatar_id":"","url":"https://api.github.com/users/soby-mathew","html_url":"https://github.com/soby-mathew","followers_url":"https://api.github.com/users/soby-mathew/followers","following_url":"https://api.github.com/users/soby-mathew/following{/other_user}","gists_url":"https://api.github.com/users/soby-mathew/gists{/gist_id}","starred_url":"https://api.github.com/users/soby-mathew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soby-mathew/subscriptions","organizations_url":"https://api.github.com/users/soby-mathew/orgs","repos_url":"https://api.github.com/users/soby-mathew/repos","events_url":"https://api.github.com/users/soby-mathew/events{/privacy}","received_events_url":"https://api.github.com/users/soby-mathew/received_events","type":"User","site_admin":false},"body":"This is not safe in case interrupt is triggered. Why can't any of the standard definitions in plat_gicv2.c be used for rpi3?","created_at":"2018-06-15T13:04:57Z","updated_at":"2018-06-15T13:05:13Z","html_url":"https://github.com/ARM-software/arm-trusted-firmware/pull/1413#discussion_r195725640","pull_request_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1413","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/comments/195725640"},"html":{"href":"https://github.com/ARM-software/arm-trusted-firmware/pull/1413#discussion_r195725640"},"pull_request":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1413"}}},"pull_request":{"url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1413","id":194563055,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NTYzMDU1","html_url":"https://github.com/ARM-software/arm-trusted-firmware/pull/1413","diff_url":"https://github.com/ARM-software/arm-trusted-firmware/pull/1413.diff","patch_url":"https://github.com/ARM-software/arm-trusted-firmware/pull/1413.patch","issue_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/1413","number":1413,"state":"open","locked":false,"title":"rpi3: BL32 optee support","user":{"login":"grandpaul","id":602995,"node_id":"MDQ6VXNlcjYwMjk5NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/602995?v=4","gravatar_id":"","url":"https://api.github.com/users/grandpaul","html_url":"https://github.com/grandpaul","followers_url":"https://api.github.com/users/grandpaul/followers","following_url":"https://api.github.com/users/grandpaul/following{/other_user}","gists_url":"https://api.github.com/users/grandpaul/gists{/gist_id}","starred_url":"https://api.github.com/users/grandpaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grandpaul/subscriptions","organizations_url":"https://api.github.com/users/grandpaul/orgs","repos_url":"https://api.github.com/users/grandpaul/repos","events_url":"https://api.github.com/users/grandpaul/events{/privacy}","received_events_url":"https://api.github.com/users/grandpaul/received_events","type":"User","site_admin":false},"body":"In order to load optee, we need to set SPD=opteed.\r\nplat_interrupt_type_to_line() is a needed function for SPD.\r\n\r\nSigned-off-by: Ying-Chun Liu (PaulLiu) <paulliu@debian.org>\r\n\r\n@igoropaniuk Please help reviewing this patch. Thanks.","created_at":"2018-06-13T12:03:16Z","updated_at":"2018-06-15T13:05:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d066d54daa9d11f0937f34a482c1c6f5a16e201","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1413/commits","review_comments_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1413/comments","review_comment_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/1413/comments","statuses_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/statuses/bd996dfafbcd49b9ff7b6d64647d0bf0e7dad65f","head":{"label":"grandpaul:paulliu-rpi3-0","ref":"paulliu-rpi3-0","sha":"bd996dfafbcd49b9ff7b6d64647d0bf0e7dad65f","user":{"login":"grandpaul","id":602995,"node_id":"MDQ6VXNlcjYwMjk5NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/602995?v=4","gravatar_id":"","url":"https://api.github.com/users/grandpaul","html_url":"https://github.com/grandpaul","followers_url":"https://api.github.com/users/grandpaul/followers","following_url":"https://api.github.com/users/grandpaul/following{/other_user}","gists_url":"https://api.github.com/users/grandpaul/gists{/gist_id}","starred_url":"https://api.github.com/users/grandpaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grandpaul/subscriptions","organizations_url":"https://api.github.com/users/grandpaul/orgs","repos_url":"https://api.github.com/users/grandpaul/repos","events_url":"https://api.github.com/users/grandpaul/events{/privacy}","received_events_url":"https://api.github.com/users/grandpaul/received_events","type":"User","site_admin":false},"repo":{"id":137209625,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcyMDk2MjU=","name":"arm-trusted-firmware","full_name":"grandpaul/arm-trusted-firmware","owner":{"login":"grandpaul","id":602995,"node_id":"MDQ6VXNlcjYwMjk5NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/602995?v=4","gravatar_id":"","url":"https://api.github.com/users/grandpaul","html_url":"https://github.com/grandpaul","followers_url":"https://api.github.com/users/grandpaul/followers","following_url":"https://api.github.com/users/grandpaul/following{/other_user}","gists_url":"https://api.github.com/users/grandpaul/gists{/gist_id}","starred_url":"https://api.github.com/users/grandpaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grandpaul/subscriptions","organizations_url":"https://api.github.com/users/grandpaul/orgs","repos_url":"https://api.github.com/users/grandpaul/repos","events_url":"https://api.github.com/users/grandpaul/events{/privacy}","received_events_url":"https://api.github.com/users/grandpaul/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grandpaul/arm-trusted-firmware","description":"Trusted Firmware-A","fork":true,"url":"https://api.github.com/repos/grandpaul/arm-trusted-firmware","forks_url":"https://api.github.com/repos/grandpaul/arm-trusted-firmware/forks","keys_url":"https://api.github.com/repos/grandpaul/arm-trusted-firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grandpaul/arm-trusted-firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grandpaul/arm-trusted-firmware/teams","hooks_url":"https://api.github.com/repos/grandpaul/arm-trusted-firmware/hooks","issue_events_url":"https://api.github.com/repos/grandpaul/arm-trusted-firmware/issues/events{/number}","events_url":"https://api.github.com/repos/grandpaul/arm-trusted-firmware/events","assignees_url":"https://api.github.com/repos/grandpaul/arm-trusted-firmware/assignees{/user}","branches_url":"https://api.github.com/repos/grandpaul/arm-trusted-firmware/branches{/branch}","tags_url":"https://api.github.com/repos/grandpaul/arm-trusted-firmware/tags","blobs_url":"https://api.github.com/repos/grandpaul/arm-trusted-firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grandpaul/arm-trusted-firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grandpaul/arm-trusted-firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/grandpaul/arm-trusted-firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grandpaul/arm-trusted-firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/grandpaul/arm-trusted-firmware/languages","stargazers_url":"https://api.github.com/repos/grandpaul/arm-trusted-firmware/stargazers","contributors_url":"https://api.github.com/repos/grandpaul/arm-trusted-firmware/contributors","subscribers_url":"https://api.github.com/repos/grandpaul/arm-trusted-firmware/subscribers","subscription_url":"https://api.github.com/repos/grandpaul/arm-trusted-firmware/subscription","commits_url":"https://api.github.com/repos/grandpaul/arm-trusted-firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/grandpaul/arm-trusted-firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/grandpaul/arm-trusted-firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/grandpaul/arm-trusted-firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/grandpaul/arm-trusted-firmware/contents/{+path}","compare_url":"https://api.github.com/repos/grandpaul/arm-trusted-firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grandpaul/arm-trusted-firmware/merges","archive_url":"https://api.github.com/repos/grandpaul/arm-trusted-firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grandpaul/arm-trusted-firmware/downloads","issues_url":"https://api.github.com/repos/grandpaul/arm-trusted-firmware/issues{/number}","pulls_url":"https://api.github.com/repos/grandpaul/arm-trusted-firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/grandpaul/arm-trusted-firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/grandpaul/arm-trusted-firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grandpaul/arm-trusted-firmware/labels{/name}","releases_url":"https://api.github.com/repos/grandpaul/arm-trusted-firmware/releases{/id}","deployments_url":"https://api.github.com/repos/grandpaul/arm-trusted-firmware/deployments","created_at":"2018-06-13T12:01:11Z","updated_at":"2018-06-13T12:01:17Z","pushed_at":"2018-06-14T06:19:07Z","git_url":"git://github.com/grandpaul/arm-trusted-firmware.git","ssh_url":"git@github.com:grandpaul/arm-trusted-firmware.git","clone_url":"https://github.com/grandpaul/arm-trusted-firmware.git","svn_url":"https://github.com/grandpaul/arm-trusted-firmware","homepage":"","size":13559,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ARM-software:master","ref":"master","sha":"74a44dca29be3e780ea50cf7a595883a399e7cfb","user":{"login":"ARM-software","id":5690313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTAzMTM=","avatar_url":"https://avatars1.githubusercontent.com/u/5690313?v=4","gravatar_id":"","url":"https://api.github.com/users/ARM-software","html_url":"https://github.com/ARM-software","followers_url":"https://api.github.com/users/ARM-software/followers","following_url":"https://api.github.com/users/ARM-software/following{/other_user}","gists_url":"https://api.github.com/users/ARM-software/gists{/gist_id}","starred_url":"https://api.github.com/users/ARM-software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARM-software/subscriptions","organizations_url":"https://api.github.com/users/ARM-software/orgs","repos_url":"https://api.github.com/users/ARM-software/repos","events_url":"https://api.github.com/users/ARM-software/events{/privacy}","received_events_url":"https://api.github.com/users/ARM-software/received_events","type":"Organization","site_admin":false},"repo":{"id":13740589,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc0MDU4OQ==","name":"arm-trusted-firmware","full_name":"ARM-software/arm-trusted-firmware","owner":{"login":"ARM-software","id":5690313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTAzMTM=","avatar_url":"https://avatars1.githubusercontent.com/u/5690313?v=4","gravatar_id":"","url":"https://api.github.com/users/ARM-software","html_url":"https://github.com/ARM-software","followers_url":"https://api.github.com/users/ARM-software/followers","following_url":"https://api.github.com/users/ARM-software/following{/other_user}","gists_url":"https://api.github.com/users/ARM-software/gists{/gist_id}","starred_url":"https://api.github.com/users/ARM-software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARM-software/subscriptions","organizations_url":"https://api.github.com/users/ARM-software/orgs","repos_url":"https://api.github.com/users/ARM-software/repos","events_url":"https://api.github.com/users/ARM-software/events{/privacy}","received_events_url":"https://api.github.com/users/ARM-software/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARM-software/arm-trusted-firmware","description":"Trusted Firmware-A","fork":false,"url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware","forks_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/forks","keys_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/teams","hooks_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/hooks","issue_events_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/events{/number}","events_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/events","assignees_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/assignees{/user}","branches_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/branches{/branch}","tags_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/tags","blobs_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/languages","stargazers_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/stargazers","contributors_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/contributors","subscribers_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/subscribers","subscription_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/subscription","commits_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/contents/{+path}","compare_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/merges","archive_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/downloads","issues_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues{/number}","pulls_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/labels{/name}","releases_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/releases{/id}","deployments_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/deployments","created_at":"2013-10-21T11:39:00Z","updated_at":"2018-06-14T17:26:16Z","pushed_at":"2018-06-15T10:50:59Z","git_url":"git://github.com/ARM-software/arm-trusted-firmware.git","ssh_url":"git@github.com:ARM-software/arm-trusted-firmware.git","clone_url":"https://github.com/ARM-software/arm-trusted-firmware.git","svn_url":"https://github.com/ARM-software/arm-trusted-firmware","homepage":"","size":13594,"stargazers_count":590,"watchers_count":590,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":497,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":497,"open_issues":17,"watchers":590,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1413"},"html":{"href":"https://github.com/ARM-software/arm-trusted-firmware/pull/1413"},"issue":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/1413"},"comments":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/1413/comments"},"review_comments":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1413/comments"},"review_comment":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1413/commits"},"statuses":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/statuses/bd996dfafbcd49b9ff7b6d64647d0bf0e7dad65f"}},"author_association":"NONE"}}
{"actor":{"display_login":"soby-mathew"}}