{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/pulls/comments/208345631","pull_request_review_id":144135959,"id":208345631,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODM0NTYzMQ==","diff_hunk":"@@ -17,12 +17,12 @@ namespace Microsoft.Azure.WebJobs.Extensions.Files.Bindings\n {\n     internal class FileTriggerAttributeBindingProvider : ITriggerBindingProvider\n     {\n-        private readonly FilesConfiguration _config;\n+        private readonly FilesOptions _options;\n         private readonly ILogger _logger;\n \n-        public FileTriggerAttributeBindingProvider(FilesConfiguration config, ILoggerFactory loggerFactory)","path":"src/WebJobs.Extensions/Extensions/Files/Bindings/FileTriggerAttributeBindingProvider.cs","position":8,"original_position":8,"commit_id":"dfc266cb6d38c39eeddfc1cf09476fc59661a3f9","original_commit_id":"482940042073fcf1fe629bf7be9b5b15812d0e93","user":{"login":"mathewc","id":1056548,"node_id":"MDQ6VXNlcjEwNTY1NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/1056548?v=4","gravatar_id":"","url":"https://api.github.com/users/mathewc","html_url":"https://github.com/mathewc","followers_url":"https://api.github.com/users/mathewc/followers","following_url":"https://api.github.com/users/mathewc/following{/other_user}","gists_url":"https://api.github.com/users/mathewc/gists{/gist_id}","starred_url":"https://api.github.com/users/mathewc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathewc/subscriptions","organizations_url":"https://api.github.com/users/mathewc/orgs","repos_url":"https://api.github.com/users/mathewc/repos","events_url":"https://api.github.com/users/mathewc/events{/privacy}","received_events_url":"https://api.github.com/users/mathewc/received_events","type":"User","site_admin":false},"body":"Fixed","created_at":"2018-08-07T18:51:08Z","updated_at":"2018-08-07T18:51:08Z","html_url":"https://github.com/Azure/azure-webjobs-sdk-extensions/pull/448#discussion_r208345631","pull_request_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/pulls/448","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/pulls/comments/208345631"},"html":{"href":"https://github.com/Azure/azure-webjobs-sdk-extensions/pull/448#discussion_r208345631"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/pulls/448"}},"in_reply_to_id":207440040},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/pulls/448","id":205905588,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1OTA1NTg4","html_url":"https://github.com/Azure/azure-webjobs-sdk-extensions/pull/448","diff_url":"https://github.com/Azure/azure-webjobs-sdk-extensions/pull/448.diff","patch_url":"https://github.com/Azure/azure-webjobs-sdk-extensions/pull/448.patch","issue_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/issues/448","number":448,"state":"open","locked":false,"title":"Migrating Extensions to new DI model","user":{"login":"mathewc","id":1056548,"node_id":"MDQ6VXNlcjEwNTY1NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/1056548?v=4","gravatar_id":"","url":"https://api.github.com/users/mathewc","html_url":"https://github.com/mathewc","followers_url":"https://api.github.com/users/mathewc/followers","following_url":"https://api.github.com/users/mathewc/following{/other_user}","gists_url":"https://api.github.com/users/mathewc/gists{/gist_id}","starred_url":"https://api.github.com/users/mathewc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathewc/subscriptions","organizations_url":"https://api.github.com/users/mathewc/orgs","repos_url":"https://api.github.com/users/mathewc/repos","events_url":"https://api.github.com/users/mathewc/events{/privacy}","received_events_url":"https://api.github.com/users/mathewc/received_events","type":"User","site_admin":false},"body":"I still haven't updated the tests. But the ExtensionsSample starts up and I've verified Timer/Files work.","created_at":"2018-08-03T01:56:28Z","updated_at":"2018-08-07T18:51:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a4a2b91b892a9da2a831a3f15b443377e807ed5e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"brettsam","id":1089915,"node_id":"MDQ6VXNlcjEwODk5MTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1089915?v=4","gravatar_id":"","url":"https://api.github.com/users/brettsam","html_url":"https://github.com/brettsam","followers_url":"https://api.github.com/users/brettsam/followers","following_url":"https://api.github.com/users/brettsam/following{/other_user}","gists_url":"https://api.github.com/users/brettsam/gists{/gist_id}","starred_url":"https://api.github.com/users/brettsam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brettsam/subscriptions","organizations_url":"https://api.github.com/users/brettsam/orgs","repos_url":"https://api.github.com/users/brettsam/repos","events_url":"https://api.github.com/users/brettsam/events{/privacy}","received_events_url":"https://api.github.com/users/brettsam/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/pulls/448/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/pulls/448/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/issues/448/comments","statuses_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/statuses/dfc266cb6d38c39eeddfc1cf09476fc59661a3f9","head":{"label":"Azure:extension-migrate","ref":"extension-migrate","sha":"dfc266cb6d38c39eeddfc1cf09476fc59661a3f9","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":36027231,"node_id":"MDEwOlJlcG9zaXRvcnkzNjAyNzIzMQ==","name":"azure-webjobs-sdk-extensions","full_name":"Azure/azure-webjobs-sdk-extensions","owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-webjobs-sdk-extensions","description":"Azure WebJobs SDK Extensions","fork":false,"url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions","forks_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/forks","keys_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/teams","hooks_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/events","assignees_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/tags","blobs_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/subscription","commits_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/merges","archive_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/downloads","issues_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/deployments","created_at":"2015-05-21T17:28:25Z","updated_at":"2018-08-03T20:48:24Z","pushed_at":"2018-08-07T18:39:23Z","git_url":"git://github.com/Azure/azure-webjobs-sdk-extensions.git","ssh_url":"git@github.com:Azure/azure-webjobs-sdk-extensions.git","clone_url":"https://github.com/Azure/azure-webjobs-sdk-extensions.git","svn_url":"https://github.com/Azure/azure-webjobs-sdk-extensions","homepage":"","size":3183,"stargazers_count":178,"watchers_count":178,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":113,"mirror_url":null,"archived":false,"open_issues_count":69,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":113,"open_issues":69,"watchers":178,"default_branch":"dev"}},"base":{"label":"Azure:dev","ref":"dev","sha":"12f060f59d210a4d4892fa85f1a63a645edeba18","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":36027231,"node_id":"MDEwOlJlcG9zaXRvcnkzNjAyNzIzMQ==","name":"azure-webjobs-sdk-extensions","full_name":"Azure/azure-webjobs-sdk-extensions","owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-webjobs-sdk-extensions","description":"Azure WebJobs SDK Extensions","fork":false,"url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions","forks_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/forks","keys_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/teams","hooks_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/events","assignees_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/tags","blobs_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/subscription","commits_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/merges","archive_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/downloads","issues_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/deployments","created_at":"2015-05-21T17:28:25Z","updated_at":"2018-08-03T20:48:24Z","pushed_at":"2018-08-07T18:39:23Z","git_url":"git://github.com/Azure/azure-webjobs-sdk-extensions.git","ssh_url":"git@github.com:Azure/azure-webjobs-sdk-extensions.git","clone_url":"https://github.com/Azure/azure-webjobs-sdk-extensions.git","svn_url":"https://github.com/Azure/azure-webjobs-sdk-extensions","homepage":"","size":3183,"stargazers_count":178,"watchers_count":178,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":113,"mirror_url":null,"archived":false,"open_issues_count":69,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":113,"open_issues":69,"watchers":178,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/pulls/448"},"html":{"href":"https://github.com/Azure/azure-webjobs-sdk-extensions/pull/448"},"issue":{"href":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/issues/448"},"comments":{"href":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/issues/448/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/pulls/448/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/pulls/448/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/statuses/dfc266cb6d38c39eeddfc1cf09476fc59661a3f9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mathewc"}}