{"action":"created","comment":{"url":"https://api.github.com/repos/Brewskey/spark-server/pulls/comments/234074182","pull_request_review_id":175637802,"id":234074182,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDA3NDE4Mg==","diff_hunk":"@@ -53,7 +53,8 @@ class MongoDb extends BaseMongoDb implements IBaseDatabase {\n         if (skip) {\n           result = result.skip(parseInt(skip, 10));\n         }\n-        if (take) {\n+\n+        if (take && parseInt(take, 10) !== 0) {","path":"src/repository/MongoDb.js","position":6,"original_position":6,"commit_id":"1cbed27906db5542f945e8737e7b9146bef3825f","original_commit_id":"1cbed27906db5542f945e8737e7b9146bef3825f","user":{"login":"jlkalberer","id":1107396,"node_id":"MDQ6VXNlcjExMDczOTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1107396?v=4","gravatar_id":"","url":"https://api.github.com/users/jlkalberer","html_url":"https://github.com/jlkalberer","followers_url":"https://api.github.com/users/jlkalberer/followers","following_url":"https://api.github.com/users/jlkalberer/following{/other_user}","gists_url":"https://api.github.com/users/jlkalberer/gists{/gist_id}","starred_url":"https://api.github.com/users/jlkalberer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlkalberer/subscriptions","organizations_url":"https://api.github.com/users/jlkalberer/orgs","repos_url":"https://api.github.com/users/jlkalberer/repos","events_url":"https://api.github.com/users/jlkalberer/events{/privacy}","received_events_url":"https://api.github.com/users/jlkalberer/received_events","type":"User","site_admin":false},"body":"We should have better checks here for both `skip` and `take`\r\n\r\n`null`/`undefined` should mean fetch all. Passing in `0` should be valid and get passed into the query.","created_at":"2018-11-16T02:29:50Z","updated_at":"2018-11-16T02:30:14Z","html_url":"https://github.com/Brewskey/spark-server/pull/280#discussion_r234074182","pull_request_url":"https://api.github.com/repos/Brewskey/spark-server/pulls/280","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Brewskey/spark-server/pulls/comments/234074182"},"html":{"href":"https://github.com/Brewskey/spark-server/pull/280#discussion_r234074182"},"pull_request":{"href":"https://api.github.com/repos/Brewskey/spark-server/pulls/280"}}},"pull_request":{"url":"https://api.github.com/repos/Brewskey/spark-server/pulls/280","id":231364766,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMzY0NzY2","html_url":"https://github.com/Brewskey/spark-server/pull/280","diff_url":"https://github.com/Brewskey/spark-server/pull/280.diff","patch_url":"https://github.com/Brewskey/spark-server/pull/280.patch","issue_url":"https://api.github.com/repos/Brewskey/spark-server/issues/280","number":280,"state":"open","locked":false,"title":"getFirmwares, countFirmwares and fix ids search","user":{"login":"AntonPuko","id":8849922,"node_id":"MDQ6VXNlcjg4NDk5MjI=","avatar_url":"https://avatars1.githubusercontent.com/u/8849922?v=4","gravatar_id":"","url":"https://api.github.com/users/AntonPuko","html_url":"https://github.com/AntonPuko","followers_url":"https://api.github.com/users/AntonPuko/followers","following_url":"https://api.github.com/users/AntonPuko/following{/other_user}","gists_url":"https://api.github.com/users/AntonPuko/gists{/gist_id}","starred_url":"https://api.github.com/users/AntonPuko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AntonPuko/subscriptions","organizations_url":"https://api.github.com/users/AntonPuko/orgs","repos_url":"https://api.github.com/users/AntonPuko/repos","events_url":"https://api.github.com/users/AntonPuko/events{/privacy}","received_events_url":"https://api.github.com/users/AntonPuko/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-15T23:07:04Z","updated_at":"2018-11-16T02:30:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97ccd9b90e8a8d1d23d2fd3bbd240c8a3115eddf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Brewskey/spark-server/pulls/280/commits","review_comments_url":"https://api.github.com/repos/Brewskey/spark-server/pulls/280/comments","review_comment_url":"https://api.github.com/repos/Brewskey/spark-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Brewskey/spark-server/issues/280/comments","statuses_url":"https://api.github.com/repos/Brewskey/spark-server/statuses/1cbed27906db5542f945e8737e7b9146bef3825f","head":{"label":"AntonPuko:dev","ref":"dev","sha":"1cbed27906db5542f945e8737e7b9146bef3825f","user":{"login":"AntonPuko","id":8849922,"node_id":"MDQ6VXNlcjg4NDk5MjI=","avatar_url":"https://avatars1.githubusercontent.com/u/8849922?v=4","gravatar_id":"","url":"https://api.github.com/users/AntonPuko","html_url":"https://github.com/AntonPuko","followers_url":"https://api.github.com/users/AntonPuko/followers","following_url":"https://api.github.com/users/AntonPuko/following{/other_user}","gists_url":"https://api.github.com/users/AntonPuko/gists{/gist_id}","starred_url":"https://api.github.com/users/AntonPuko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AntonPuko/subscriptions","organizations_url":"https://api.github.com/users/AntonPuko/orgs","repos_url":"https://api.github.com/users/AntonPuko/repos","events_url":"https://api.github.com/users/AntonPuko/events{/privacy}","received_events_url":"https://api.github.com/users/AntonPuko/received_events","type":"User","site_admin":false},"repo":{"id":74708700,"node_id":"MDEwOlJlcG9zaXRvcnk3NDcwODcwMA==","name":"spark-server","full_name":"AntonPuko/spark-server","private":false,"owner":{"login":"AntonPuko","id":8849922,"node_id":"MDQ6VXNlcjg4NDk5MjI=","avatar_url":"https://avatars1.githubusercontent.com/u/8849922?v=4","gravatar_id":"","url":"https://api.github.com/users/AntonPuko","html_url":"https://github.com/AntonPuko","followers_url":"https://api.github.com/users/AntonPuko/followers","following_url":"https://api.github.com/users/AntonPuko/following{/other_user}","gists_url":"https://api.github.com/users/AntonPuko/gists{/gist_id}","starred_url":"https://api.github.com/users/AntonPuko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AntonPuko/subscriptions","organizations_url":"https://api.github.com/users/AntonPuko/orgs","repos_url":"https://api.github.com/users/AntonPuko/repos","events_url":"https://api.github.com/users/AntonPuko/events{/privacy}","received_events_url":"https://api.github.com/users/AntonPuko/received_events","type":"User","site_admin":false},"html_url":"https://github.com/AntonPuko/spark-server","description":"An API compatible open source server for interacting with devices speaking the spark-protocol","fork":true,"url":"https://api.github.com/repos/AntonPuko/spark-server","forks_url":"https://api.github.com/repos/AntonPuko/spark-server/forks","keys_url":"https://api.github.com/repos/AntonPuko/spark-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AntonPuko/spark-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AntonPuko/spark-server/teams","hooks_url":"https://api.github.com/repos/AntonPuko/spark-server/hooks","issue_events_url":"https://api.github.com/repos/AntonPuko/spark-server/issues/events{/number}","events_url":"https://api.github.com/repos/AntonPuko/spark-server/events","assignees_url":"https://api.github.com/repos/AntonPuko/spark-server/assignees{/user}","branches_url":"https://api.github.com/repos/AntonPuko/spark-server/branches{/branch}","tags_url":"https://api.github.com/repos/AntonPuko/spark-server/tags","blobs_url":"https://api.github.com/repos/AntonPuko/spark-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AntonPuko/spark-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AntonPuko/spark-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/AntonPuko/spark-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AntonPuko/spark-server/statuses/{sha}","languages_url":"https://api.github.com/repos/AntonPuko/spark-server/languages","stargazers_url":"https://api.github.com/repos/AntonPuko/spark-server/stargazers","contributors_url":"https://api.github.com/repos/AntonPuko/spark-server/contributors","subscribers_url":"https://api.github.com/repos/AntonPuko/spark-server/subscribers","subscription_url":"https://api.github.com/repos/AntonPuko/spark-server/subscription","commits_url":"https://api.github.com/repos/AntonPuko/spark-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/AntonPuko/spark-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/AntonPuko/spark-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/AntonPuko/spark-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/AntonPuko/spark-server/contents/{+path}","compare_url":"https://api.github.com/repos/AntonPuko/spark-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AntonPuko/spark-server/merges","archive_url":"https://api.github.com/repos/AntonPuko/spark-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AntonPuko/spark-server/downloads","issues_url":"https://api.github.com/repos/AntonPuko/spark-server/issues{/number}","pulls_url":"https://api.github.com/repos/AntonPuko/spark-server/pulls{/number}","milestones_url":"https://api.github.com/repos/AntonPuko/spark-server/milestones{/number}","notifications_url":"https://api.github.com/repos/AntonPuko/spark-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AntonPuko/spark-server/labels{/name}","releases_url":"https://api.github.com/repos/AntonPuko/spark-server/releases{/id}","deployments_url":"https://api.github.com/repos/AntonPuko/spark-server/deployments","created_at":"2016-11-24T22:27:31Z","updated_at":"2018-11-15T23:10:05Z","pushed_at":"2018-11-15T23:10:03Z","git_url":"git://github.com/AntonPuko/spark-server.git","ssh_url":"git@github.com:AntonPuko/spark-server.git","clone_url":"https://github.com/AntonPuko/spark-server.git","svn_url":"https://github.com/AntonPuko/spark-server","homepage":"https://www.particle.io/","size":1417,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"Brewskey:dev","ref":"dev","sha":"d751a812898283643c015016a1a43fb701608581","user":{"login":"Brewskey","id":20875563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODc1NTYz","avatar_url":"https://avatars0.githubusercontent.com/u/20875563?v=4","gravatar_id":"","url":"https://api.github.com/users/Brewskey","html_url":"https://github.com/Brewskey","followers_url":"https://api.github.com/users/Brewskey/followers","following_url":"https://api.github.com/users/Brewskey/following{/other_user}","gists_url":"https://api.github.com/users/Brewskey/gists{/gist_id}","starred_url":"https://api.github.com/users/Brewskey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brewskey/subscriptions","organizations_url":"https://api.github.com/users/Brewskey/orgs","repos_url":"https://api.github.com/users/Brewskey/repos","events_url":"https://api.github.com/users/Brewskey/events{/privacy}","received_events_url":"https://api.github.com/users/Brewskey/received_events","type":"Organization","site_admin":false},"repo":{"id":74491590,"node_id":"MDEwOlJlcG9zaXRvcnk3NDQ5MTU5MA==","name":"spark-server","full_name":"Brewskey/spark-server","private":false,"owner":{"login":"Brewskey","id":20875563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODc1NTYz","avatar_url":"https://avatars0.githubusercontent.com/u/20875563?v=4","gravatar_id":"","url":"https://api.github.com/users/Brewskey","html_url":"https://github.com/Brewskey","followers_url":"https://api.github.com/users/Brewskey/followers","following_url":"https://api.github.com/users/Brewskey/following{/other_user}","gists_url":"https://api.github.com/users/Brewskey/gists{/gist_id}","starred_url":"https://api.github.com/users/Brewskey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brewskey/subscriptions","organizations_url":"https://api.github.com/users/Brewskey/orgs","repos_url":"https://api.github.com/users/Brewskey/repos","events_url":"https://api.github.com/users/Brewskey/events{/privacy}","received_events_url":"https://api.github.com/users/Brewskey/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Brewskey/spark-server","description":"An API compatible open source server for interacting with devices speaking the spark-protocol","fork":true,"url":"https://api.github.com/repos/Brewskey/spark-server","forks_url":"https://api.github.com/repos/Brewskey/spark-server/forks","keys_url":"https://api.github.com/repos/Brewskey/spark-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Brewskey/spark-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Brewskey/spark-server/teams","hooks_url":"https://api.github.com/repos/Brewskey/spark-server/hooks","issue_events_url":"https://api.github.com/repos/Brewskey/spark-server/issues/events{/number}","events_url":"https://api.github.com/repos/Brewskey/spark-server/events","assignees_url":"https://api.github.com/repos/Brewskey/spark-server/assignees{/user}","branches_url":"https://api.github.com/repos/Brewskey/spark-server/branches{/branch}","tags_url":"https://api.github.com/repos/Brewskey/spark-server/tags","blobs_url":"https://api.github.com/repos/Brewskey/spark-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Brewskey/spark-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Brewskey/spark-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/Brewskey/spark-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Brewskey/spark-server/statuses/{sha}","languages_url":"https://api.github.com/repos/Brewskey/spark-server/languages","stargazers_url":"https://api.github.com/repos/Brewskey/spark-server/stargazers","contributors_url":"https://api.github.com/repos/Brewskey/spark-server/contributors","subscribers_url":"https://api.github.com/repos/Brewskey/spark-server/subscribers","subscription_url":"https://api.github.com/repos/Brewskey/spark-server/subscription","commits_url":"https://api.github.com/repos/Brewskey/spark-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/Brewskey/spark-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/Brewskey/spark-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/Brewskey/spark-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/Brewskey/spark-server/contents/{+path}","compare_url":"https://api.github.com/repos/Brewskey/spark-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Brewskey/spark-server/merges","archive_url":"https://api.github.com/repos/Brewskey/spark-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Brewskey/spark-server/downloads","issues_url":"https://api.github.com/repos/Brewskey/spark-server/issues{/number}","pulls_url":"https://api.github.com/repos/Brewskey/spark-server/pulls{/number}","milestones_url":"https://api.github.com/repos/Brewskey/spark-server/milestones{/number}","notifications_url":"https://api.github.com/repos/Brewskey/spark-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Brewskey/spark-server/labels{/name}","releases_url":"https://api.github.com/repos/Brewskey/spark-server/releases{/id}","deployments_url":"https://api.github.com/repos/Brewskey/spark-server/deployments","created_at":"2016-11-22T16:26:52Z","updated_at":"2018-11-15T21:32:41Z","pushed_at":"2018-11-15T23:10:04Z","git_url":"git://github.com/Brewskey/spark-server.git","ssh_url":"git@github.com:Brewskey/spark-server.git","clone_url":"https://github.com/Brewskey/spark-server.git","svn_url":"https://github.com/Brewskey/spark-server","homepage":"https://www.particle.io/","size":1335,"stargazers_count":30,"watchers_count":30,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":18,"open_issues":20,"watchers":30,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Brewskey/spark-server/pulls/280"},"html":{"href":"https://github.com/Brewskey/spark-server/pull/280"},"issue":{"href":"https://api.github.com/repos/Brewskey/spark-server/issues/280"},"comments":{"href":"https://api.github.com/repos/Brewskey/spark-server/issues/280/comments"},"review_comments":{"href":"https://api.github.com/repos/Brewskey/spark-server/pulls/280/comments"},"review_comment":{"href":"https://api.github.com/repos/Brewskey/spark-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Brewskey/spark-server/pulls/280/commits"},"statuses":{"href":"https://api.github.com/repos/Brewskey/spark-server/statuses/1cbed27906db5542f945e8737e7b9146bef3825f"}},"author_association":"NONE"}}
{"actor":{"display_login":"jlkalberer"}}