{"action":"created","issue":{"url":"https://api.github.com/repos/kubeflow/kubeflow/issues/1308","repository_url":"https://api.github.com/repos/kubeflow/kubeflow","labels_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/1308/labels{/name}","comments_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/1308/comments","events_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/1308/events","html_url":"https://github.com/kubeflow/kubeflow/pull/1308","id":347549881,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MTQ5NjY1","number":1308,"title":"[wip] Turn deploy.sh into kfctl.sh","user":{"login":"jlewi","id":777219,"node_id":"MDQ6VXNlcjc3NzIxOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/777219?v=4","gravatar_id":"","url":"https://api.github.com/users/jlewi","html_url":"https://github.com/jlewi","followers_url":"https://api.github.com/users/jlewi/followers","following_url":"https://api.github.com/users/jlewi/following{/other_user}","gists_url":"https://api.github.com/users/jlewi/gists{/gist_id}","starred_url":"https://api.github.com/users/jlewi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlewi/subscriptions","organizations_url":"https://api.github.com/users/jlewi/orgs","repos_url":"https://api.github.com/users/jlewi/repos","events_url":"https://api.github.com/users/jlewi/events{/privacy}","received_events_url":"https://api.github.com/users/jlewi/received_events","type":"User","site_admin":false},"labels":[{"id":850698616,"node_id":"MDU6TGFiZWw4NTA2OTg2MTY=","url":"https://api.github.com/repos/kubeflow/kubeflow/labels/do-not-merge/work-in-progress","name":"do-not-merge/work-in-progress","color":"ffa500","default":false},{"id":796406381,"node_id":"MDU6TGFiZWw3OTY0MDYzODE=","url":"https://api.github.com/repos/kubeflow/kubeflow/labels/size/XXL","name":"size/XXL","color":"d93f0b","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-03T22:09:08Z","updated_at":"2018-08-05T01:28:56Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/1308","html_url":"https://github.com/kubeflow/kubeflow/pull/1308","diff_url":"https://github.com/kubeflow/kubeflow/pull/1308.diff","patch_url":"https://github.com/kubeflow/kubeflow/pull/1308.patch"},"body":"Simplify deployment script and make it more rentrant\r\n\r\n* The scripts are becoming more complicated because we are creating\r\n  more environment variables to control things like whether or not to use\r\n  GCFS.\r\n\r\n* Those environment variables are creating an unnecessary layer of indirection;\r\n  if users want to configure things like private cluster, or GCFS, they\r\n  should just edit the ksonnet or DM configs.\r\n\r\n* To support that we need to make the following flow easier\r\n\r\n  create DM and ksonnet configs\r\n  user manually edits configs\r\n  user deploys\r\n\r\n* Refactor the deploy.sh script to make the steps more easier and add a\r\n  command function so user can select which step they want to perform.\r\n\r\n* Only copy a subset of the files in the Kubeflow repo into the directory;\r\n  the repo is quite large and we expect user to check their directory into\r\n  source control and we don't want to bloat it.\r\n\r\n* Remove GCFS from the setup; I think it makes sense for GCFS setup to\r\n  a separate step. If users want to use GCFS they should\r\n\r\n  1. Create a GCFS instance if they don't have one\r\n  2. Update the ksonnet app to use GCFS\r\n  3. Redeploy the ksonnet app\r\n\r\n  * This removes the complexity caused by giving users options to skip to fix bugs in deploy.sh.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/kubeflow/kubeflow/1308)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/kubeflow/kubeflow/issues/comments/410488726","html_url":"https://github.com/kubeflow/kubeflow/pull/1308#issuecomment-410488726","issue_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/1308","id":410488726,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMDQ4ODcyNg==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-08-05T01:28:56Z","updated_at":"2018-08-05T01:28:56Z","author_association":"NONE","body":"@jlewi: The following test **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nkubeflow-presubmit | fb091894224bdf7a323feecd9fcbe5ec5eb59a6b | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/kubeflow_kubeflow/1308/kubeflow-presubmit/2809/) | `/test kubeflow-presubmit`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/kubeflow_kubeflow/1308). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/jlewi). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubeflow/kubeflow/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}