{"action":"created","comment":{"url":"https://api.github.com/repos/unicode-org/icu/pulls/comments/204930230","pull_request_review_id":140102039,"id":204930230,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDkzMDIzMA==","diff_hunk":"@@ -1166,8 +1175,17 @@ RuleBasedNumberFormat::format(const DecimalQuantity &number,\n \n             // TODO this section should probably be optimized. The DecimalFormat is shared in ICU4J.\n             NumberFormat *decimalFormat = NumberFormat::createInstance(locale, UNUM_DECIMAL, status);\n+            if (decimalFormat == nullptr) {","path":"icu4c/source/i18n/rbnf.cpp","position":4,"original_position":23,"commit_id":"4c9fce16400df965f85a73566f1fb9934d7927b9","original_commit_id":"4c9fce16400df965f85a73566f1fb9934d7927b9","user":{"login":"aheninger","id":22674053,"node_id":"MDQ6VXNlcjIyNjc0MDUz","avatar_url":"https://avatars1.githubusercontent.com/u/22674053?v=4","gravatar_id":"","url":"https://api.github.com/users/aheninger","html_url":"https://github.com/aheninger","followers_url":"https://api.github.com/users/aheninger/followers","following_url":"https://api.github.com/users/aheninger/following{/other_user}","gists_url":"https://api.github.com/users/aheninger/gists{/gist_id}","starred_url":"https://api.github.com/users/aheninger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aheninger/subscriptions","organizations_url":"https://api.github.com/users/aheninger/orgs","repos_url":"https://api.github.com/users/aheninger/repos","events_url":"https://api.github.com/users/aheninger/events{/privacy}","received_events_url":"https://api.github.com/users/aheninger/received_events","type":"User","site_admin":false},"body":"Again,` LocalPointer<NumberFormat>` would be simpler.","created_at":"2018-07-24T22:21:30Z","updated_at":"2018-07-24T22:21:30Z","html_url":"https://github.com/unicode-org/icu/pull/24#discussion_r204930230","pull_request_url":"https://api.github.com/repos/unicode-org/icu/pulls/24","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/unicode-org/icu/pulls/comments/204930230"},"html":{"href":"https://github.com/unicode-org/icu/pull/24#discussion_r204930230"},"pull_request":{"href":"https://api.github.com/repos/unicode-org/icu/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/unicode-org/icu/pulls/24","id":203665067,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNjY1MDY3","html_url":"https://github.com/unicode-org/icu/pull/24","diff_url":"https://github.com/unicode-org/icu/pull/24.diff","patch_url":"https://github.com/unicode-org/icu/pull/24.patch","issue_url":"https://api.github.com/repos/unicode-org/icu/issues/24","number":24,"state":"open","locked":false,"title":"ICU-20046 Fix some OOM issues in the RBNF class.","user":{"login":"jefgen","id":29107334,"node_id":"MDQ6VXNlcjI5MTA3MzM0","avatar_url":"https://avatars2.githubusercontent.com/u/29107334?v=4","gravatar_id":"","url":"https://api.github.com/users/jefgen","html_url":"https://github.com/jefgen","followers_url":"https://api.github.com/users/jefgen/followers","following_url":"https://api.github.com/users/jefgen/following{/other_user}","gists_url":"https://api.github.com/users/jefgen/gists{/gist_id}","starred_url":"https://api.github.com/users/jefgen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jefgen/subscriptions","organizations_url":"https://api.github.com/users/jefgen/orgs","repos_url":"https://api.github.com/users/jefgen/repos","events_url":"https://api.github.com/users/jefgen/events{/privacy}","received_events_url":"https://api.github.com/users/jefgen/received_events","type":"User","site_admin":false},"body":"There are a few locations in the RuleBasedNumberFormat class that don't check for out-of-memory (OOM) failures.\r\n","created_at":"2018-07-24T21:49:46Z","updated_at":"2018-07-24T22:21:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f2a1ad185f84ca1c3235ec8e0fddb5fe439334b4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"srl295","id":855219,"node_id":"MDQ6VXNlcjg1NTIxOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/855219?v=4","gravatar_id":"","url":"https://api.github.com/users/srl295","html_url":"https://github.com/srl295","followers_url":"https://api.github.com/users/srl295/followers","following_url":"https://api.github.com/users/srl295/following{/other_user}","gists_url":"https://api.github.com/users/srl295/gists{/gist_id}","starred_url":"https://api.github.com/users/srl295/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srl295/subscriptions","organizations_url":"https://api.github.com/users/srl295/orgs","repos_url":"https://api.github.com/users/srl295/repos","events_url":"https://api.github.com/users/srl295/events{/privacy}","received_events_url":"https://api.github.com/users/srl295/received_events","type":"User","site_admin":false},{"login":"sffc","id":1145762,"node_id":"MDQ6VXNlcjExNDU3NjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1145762?v=4","gravatar_id":"","url":"https://api.github.com/users/sffc","html_url":"https://github.com/sffc","followers_url":"https://api.github.com/users/sffc/followers","following_url":"https://api.github.com/users/sffc/following{/other_user}","gists_url":"https://api.github.com/users/sffc/gists{/gist_id}","starred_url":"https://api.github.com/users/sffc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sffc/subscriptions","organizations_url":"https://api.github.com/users/sffc/orgs","repos_url":"https://api.github.com/users/sffc/repos","events_url":"https://api.github.com/users/sffc/events{/privacy}","received_events_url":"https://api.github.com/users/sffc/received_events","type":"User","site_admin":false},{"login":"markusicu","id":12720407,"node_id":"MDQ6VXNlcjEyNzIwNDA3","avatar_url":"https://avatars2.githubusercontent.com/u/12720407?v=4","gravatar_id":"","url":"https://api.github.com/users/markusicu","html_url":"https://github.com/markusicu","followers_url":"https://api.github.com/users/markusicu/followers","following_url":"https://api.github.com/users/markusicu/following{/other_user}","gists_url":"https://api.github.com/users/markusicu/gists{/gist_id}","starred_url":"https://api.github.com/users/markusicu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markusicu/subscriptions","organizations_url":"https://api.github.com/users/markusicu/orgs","repos_url":"https://api.github.com/users/markusicu/repos","events_url":"https://api.github.com/users/markusicu/events{/privacy}","received_events_url":"https://api.github.com/users/markusicu/received_events","type":"User","site_admin":false},{"login":"axelandrejs","id":36940647,"node_id":"MDQ6VXNlcjM2OTQwNjQ3","avatar_url":"https://avatars1.githubusercontent.com/u/36940647?v=4","gravatar_id":"","url":"https://api.github.com/users/axelandrejs","html_url":"https://github.com/axelandrejs","followers_url":"https://api.github.com/users/axelandrejs/followers","following_url":"https://api.github.com/users/axelandrejs/following{/other_user}","gists_url":"https://api.github.com/users/axelandrejs/gists{/gist_id}","starred_url":"https://api.github.com/users/axelandrejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axelandrejs/subscriptions","organizations_url":"https://api.github.com/users/axelandrejs/orgs","repos_url":"https://api.github.com/users/axelandrejs/repos","events_url":"https://api.github.com/users/axelandrejs/events{/privacy}","received_events_url":"https://api.github.com/users/axelandrejs/received_events","type":"User","site_admin":false},{"login":"mingyzha","id":39807811,"node_id":"MDQ6VXNlcjM5ODA3ODEx","avatar_url":"https://avatars2.githubusercontent.com/u/39807811?v=4","gravatar_id":"","url":"https://api.github.com/users/mingyzha","html_url":"https://github.com/mingyzha","followers_url":"https://api.github.com/users/mingyzha/followers","following_url":"https://api.github.com/users/mingyzha/following{/other_user}","gists_url":"https://api.github.com/users/mingyzha/gists{/gist_id}","starred_url":"https://api.github.com/users/mingyzha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mingyzha/subscriptions","organizations_url":"https://api.github.com/users/mingyzha/orgs","repos_url":"https://api.github.com/users/mingyzha/repos","events_url":"https://api.github.com/users/mingyzha/events{/privacy}","received_events_url":"https://api.github.com/users/mingyzha/received_events","type":"User","site_admin":false},{"login":"daniel-ju","id":41210545,"node_id":"MDQ6VXNlcjQxMjEwNTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/41210545?v=4","gravatar_id":"","url":"https://api.github.com/users/daniel-ju","html_url":"https://github.com/daniel-ju","followers_url":"https://api.github.com/users/daniel-ju/followers","following_url":"https://api.github.com/users/daniel-ju/following{/other_user}","gists_url":"https://api.github.com/users/daniel-ju/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-ju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-ju/subscriptions","organizations_url":"https://api.github.com/users/daniel-ju/orgs","repos_url":"https://api.github.com/users/daniel-ju/repos","events_url":"https://api.github.com/users/daniel-ju/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-ju/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/unicode-org/icu/pulls/24/commits","review_comments_url":"https://api.github.com/repos/unicode-org/icu/pulls/24/comments","review_comment_url":"https://api.github.com/repos/unicode-org/icu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/unicode-org/icu/issues/24/comments","statuses_url":"https://api.github.com/repos/unicode-org/icu/statuses/4c9fce16400df965f85a73566f1fb9934d7927b9","head":{"label":"jefgen:jefgen/20046","ref":"jefgen/20046","sha":"4c9fce16400df965f85a73566f1fb9934d7927b9","user":{"login":"jefgen","id":29107334,"node_id":"MDQ6VXNlcjI5MTA3MzM0","avatar_url":"https://avatars2.githubusercontent.com/u/29107334?v=4","gravatar_id":"","url":"https://api.github.com/users/jefgen","html_url":"https://github.com/jefgen","followers_url":"https://api.github.com/users/jefgen/followers","following_url":"https://api.github.com/users/jefgen/following{/other_user}","gists_url":"https://api.github.com/users/jefgen/gists{/gist_id}","starred_url":"https://api.github.com/users/jefgen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jefgen/subscriptions","organizations_url":"https://api.github.com/users/jefgen/orgs","repos_url":"https://api.github.com/users/jefgen/repos","events_url":"https://api.github.com/users/jefgen/events{/privacy}","received_events_url":"https://api.github.com/users/jefgen/received_events","type":"User","site_admin":false},"repo":{"id":141333086,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEzMzMwODY=","name":"icu","full_name":"jefgen/icu","owner":{"login":"jefgen","id":29107334,"node_id":"MDQ6VXNlcjI5MTA3MzM0","avatar_url":"https://avatars2.githubusercontent.com/u/29107334?v=4","gravatar_id":"","url":"https://api.github.com/users/jefgen","html_url":"https://github.com/jefgen","followers_url":"https://api.github.com/users/jefgen/followers","following_url":"https://api.github.com/users/jefgen/following{/other_user}","gists_url":"https://api.github.com/users/jefgen/gists{/gist_id}","starred_url":"https://api.github.com/users/jefgen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jefgen/subscriptions","organizations_url":"https://api.github.com/users/jefgen/orgs","repos_url":"https://api.github.com/users/jefgen/repos","events_url":"https://api.github.com/users/jefgen/events{/privacy}","received_events_url":"https://api.github.com/users/jefgen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jefgen/icu","description":"jefgen's fork of ICU","fork":true,"url":"https://api.github.com/repos/jefgen/icu","forks_url":"https://api.github.com/repos/jefgen/icu/forks","keys_url":"https://api.github.com/repos/jefgen/icu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jefgen/icu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jefgen/icu/teams","hooks_url":"https://api.github.com/repos/jefgen/icu/hooks","issue_events_url":"https://api.github.com/repos/jefgen/icu/issues/events{/number}","events_url":"https://api.github.com/repos/jefgen/icu/events","assignees_url":"https://api.github.com/repos/jefgen/icu/assignees{/user}","branches_url":"https://api.github.com/repos/jefgen/icu/branches{/branch}","tags_url":"https://api.github.com/repos/jefgen/icu/tags","blobs_url":"https://api.github.com/repos/jefgen/icu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jefgen/icu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jefgen/icu/git/refs{/sha}","trees_url":"https://api.github.com/repos/jefgen/icu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jefgen/icu/statuses/{sha}","languages_url":"https://api.github.com/repos/jefgen/icu/languages","stargazers_url":"https://api.github.com/repos/jefgen/icu/stargazers","contributors_url":"https://api.github.com/repos/jefgen/icu/contributors","subscribers_url":"https://api.github.com/repos/jefgen/icu/subscribers","subscription_url":"https://api.github.com/repos/jefgen/icu/subscription","commits_url":"https://api.github.com/repos/jefgen/icu/commits{/sha}","git_commits_url":"https://api.github.com/repos/jefgen/icu/git/commits{/sha}","comments_url":"https://api.github.com/repos/jefgen/icu/comments{/number}","issue_comment_url":"https://api.github.com/repos/jefgen/icu/issues/comments{/number}","contents_url":"https://api.github.com/repos/jefgen/icu/contents/{+path}","compare_url":"https://api.github.com/repos/jefgen/icu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jefgen/icu/merges","archive_url":"https://api.github.com/repos/jefgen/icu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jefgen/icu/downloads","issues_url":"https://api.github.com/repos/jefgen/icu/issues{/number}","pulls_url":"https://api.github.com/repos/jefgen/icu/pulls{/number}","milestones_url":"https://api.github.com/repos/jefgen/icu/milestones{/number}","notifications_url":"https://api.github.com/repos/jefgen/icu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jefgen/icu/labels{/name}","releases_url":"https://api.github.com/repos/jefgen/icu/releases{/id}","deployments_url":"https://api.github.com/repos/jefgen/icu/deployments","created_at":"2018-07-17T19:17:08Z","updated_at":"2018-07-24T21:07:12Z","pushed_at":"2018-07-24T21:46:38Z","git_url":"git://github.com/jefgen/icu.git","ssh_url":"git@github.com:jefgen/icu.git","clone_url":"https://github.com/jefgen/icu.git","svn_url":"https://github.com/jefgen/icu","homepage":"http://icu-project.org","size":206512,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"unicode-org:master","ref":"master","sha":"472791d6eae7637186bd04485e748c5d68861117","user":{"login":"unicode-org","id":13873561,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODczNTYx","avatar_url":"https://avatars2.githubusercontent.com/u/13873561?v=4","gravatar_id":"","url":"https://api.github.com/users/unicode-org","html_url":"https://github.com/unicode-org","followers_url":"https://api.github.com/users/unicode-org/followers","following_url":"https://api.github.com/users/unicode-org/following{/other_user}","gists_url":"https://api.github.com/users/unicode-org/gists{/gist_id}","starred_url":"https://api.github.com/users/unicode-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unicode-org/subscriptions","organizations_url":"https://api.github.com/users/unicode-org/orgs","repos_url":"https://api.github.com/users/unicode-org/repos","events_url":"https://api.github.com/users/unicode-org/events{/privacy}","received_events_url":"https://api.github.com/users/unicode-org/received_events","type":"Organization","site_admin":false},"repo":{"id":49244766,"node_id":"MDEwOlJlcG9zaXRvcnk0OTI0NDc2Ng==","name":"icu","full_name":"unicode-org/icu","owner":{"login":"unicode-org","id":13873561,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODczNTYx","avatar_url":"https://avatars2.githubusercontent.com/u/13873561?v=4","gravatar_id":"","url":"https://api.github.com/users/unicode-org","html_url":"https://github.com/unicode-org","followers_url":"https://api.github.com/users/unicode-org/followers","following_url":"https://api.github.com/users/unicode-org/following{/other_user}","gists_url":"https://api.github.com/users/unicode-org/gists{/gist_id}","starred_url":"https://api.github.com/users/unicode-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unicode-org/subscriptions","organizations_url":"https://api.github.com/users/unicode-org/orgs","repos_url":"https://api.github.com/users/unicode-org/repos","events_url":"https://api.github.com/users/unicode-org/events{/privacy}","received_events_url":"https://api.github.com/users/unicode-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/unicode-org/icu","description":"The new home of the ICU project source code.","fork":false,"url":"https://api.github.com/repos/unicode-org/icu","forks_url":"https://api.github.com/repos/unicode-org/icu/forks","keys_url":"https://api.github.com/repos/unicode-org/icu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unicode-org/icu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unicode-org/icu/teams","hooks_url":"https://api.github.com/repos/unicode-org/icu/hooks","issue_events_url":"https://api.github.com/repos/unicode-org/icu/issues/events{/number}","events_url":"https://api.github.com/repos/unicode-org/icu/events","assignees_url":"https://api.github.com/repos/unicode-org/icu/assignees{/user}","branches_url":"https://api.github.com/repos/unicode-org/icu/branches{/branch}","tags_url":"https://api.github.com/repos/unicode-org/icu/tags","blobs_url":"https://api.github.com/repos/unicode-org/icu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unicode-org/icu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unicode-org/icu/git/refs{/sha}","trees_url":"https://api.github.com/repos/unicode-org/icu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unicode-org/icu/statuses/{sha}","languages_url":"https://api.github.com/repos/unicode-org/icu/languages","stargazers_url":"https://api.github.com/repos/unicode-org/icu/stargazers","contributors_url":"https://api.github.com/repos/unicode-org/icu/contributors","subscribers_url":"https://api.github.com/repos/unicode-org/icu/subscribers","subscription_url":"https://api.github.com/repos/unicode-org/icu/subscription","commits_url":"https://api.github.com/repos/unicode-org/icu/commits{/sha}","git_commits_url":"https://api.github.com/repos/unicode-org/icu/git/commits{/sha}","comments_url":"https://api.github.com/repos/unicode-org/icu/comments{/number}","issue_comment_url":"https://api.github.com/repos/unicode-org/icu/issues/comments{/number}","contents_url":"https://api.github.com/repos/unicode-org/icu/contents/{+path}","compare_url":"https://api.github.com/repos/unicode-org/icu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unicode-org/icu/merges","archive_url":"https://api.github.com/repos/unicode-org/icu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unicode-org/icu/downloads","issues_url":"https://api.github.com/repos/unicode-org/icu/issues{/number}","pulls_url":"https://api.github.com/repos/unicode-org/icu/pulls{/number}","milestones_url":"https://api.github.com/repos/unicode-org/icu/milestones{/number}","notifications_url":"https://api.github.com/repos/unicode-org/icu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unicode-org/icu/labels{/name}","releases_url":"https://api.github.com/repos/unicode-org/icu/releases{/id}","deployments_url":"https://api.github.com/repos/unicode-org/icu/deployments","created_at":"2016-01-08T02:42:32Z","updated_at":"2018-07-24T19:38:22Z","pushed_at":"2018-07-24T21:49:47Z","git_url":"git://github.com/unicode-org/icu.git","ssh_url":"git@github.com:unicode-org/icu.git","clone_url":"https://github.com/unicode-org/icu.git","svn_url":"https://github.com/unicode-org/icu","homepage":"http://icu-project.org","size":219327,"stargazers_count":87,"watchers_count":87,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":32,"mirror_url":null,"archived":false,"open_issues_count":16,"license":null,"forks":32,"open_issues":16,"watchers":87,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/unicode-org/icu/pulls/24"},"html":{"href":"https://github.com/unicode-org/icu/pull/24"},"issue":{"href":"https://api.github.com/repos/unicode-org/icu/issues/24"},"comments":{"href":"https://api.github.com/repos/unicode-org/icu/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/unicode-org/icu/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/unicode-org/icu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/unicode-org/icu/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/unicode-org/icu/statuses/4c9fce16400df965f85a73566f1fb9934d7927b9"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"aheninger"}}