{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/226458623","pull_request_review_id":166287194,"id":226458623,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjQ1ODYyMw==","diff_hunk":"@@ -370,9 +370,17 @@ public void DisconnectFromIntellisenseControllers()\n \n         public bool TryGetTextViewLineContainingBufferPosition(SnapshotPoint bufferPosition, out ITextViewLine textViewLine)\n         {\n-            // TODO can be changed to _inner.TryGetTextViewLineContainingBufferPosition(bufferPosition, out textViewLine); when TextViewExtensions would provide the correct signature for it.\n-            textViewLine = GetTextViewLineContainingBufferPosition(bufferPosition);\n-            return true;\n+            // This implementation confirms with the Editor implementation.\n+            try\n+            {\n+                textViewLine = this.GetTextViewLineContainingBufferPosition(bufferPosition);\n+                return textViewLine != null;\n+            }\n+            catch","path":"src/VisualStudio/Core/Def/Implementation/DebuggerIntelliSense/DebuggerTextView.cs","position":null,"original_position":13,"commit_id":"bec7bdb7514941b79d971d716b6dcc97600ea194","original_commit_id":"c83abc04fc36b2c351798b1d0b4f0a0614285ada","user":{"login":"grabalon","id":2760657,"node_id":"MDQ6VXNlcjI3NjA2NTc=","avatar_url":"https://avatars0.githubusercontent.com/u/2760657?v=4","gravatar_id":"","url":"https://api.github.com/users/grabalon","html_url":"https://github.com/grabalon","followers_url":"https://api.github.com/users/grabalon/followers","following_url":"https://api.github.com/users/grabalon/following{/other_user}","gists_url":"https://api.github.com/users/grabalon/gists{/gist_id}","starred_url":"https://api.github.com/users/grabalon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grabalon/subscriptions","organizations_url":"https://api.github.com/users/grabalon/orgs","repos_url":"https://api.github.com/users/grabalon/repos","events_url":"https://api.github.com/users/grabalon/events{/privacy}","received_events_url":"https://api.github.com/users/grabalon/received_events","type":"User","site_admin":false},"body":"Fix now in: https://devdiv.visualstudio.com/DevDiv/Editor/_git/VS-Platform/commit/25b7188c54f0cdf6a5be87eeb38e3c6046d5788e?refName=refs%2Fheads%2Fv16.0-preview.1","created_at":"2018-10-18T20:43:43Z","updated_at":"2018-10-18T20:43:43Z","html_url":"https://github.com/dotnet/roslyn/pull/29016#discussion_r226458623","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/29016","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/226458623"},"html":{"href":"https://github.com/dotnet/roslyn/pull/29016#discussion_r226458623"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/29016"}},"in_reply_to_id":226452989},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/29016","id":205575269,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NTc1MjY5","html_url":"https://github.com/dotnet/roslyn/pull/29016","diff_url":"https://github.com/dotnet/roslyn/pull/29016.diff","patch_url":"https://github.com/dotnet/roslyn/pull/29016.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/29016","number":29016,"state":"open","locked":false,"title":"Implementation of new editor completion API","user":{"login":"ivanbasov","id":5455484,"node_id":"MDQ6VXNlcjU0NTU0ODQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5455484?v=4","gravatar_id":"","url":"https://api.github.com/users/ivanbasov","html_url":"https://github.com/ivanbasov","followers_url":"https://api.github.com/users/ivanbasov/followers","following_url":"https://api.github.com/users/ivanbasov/following{/other_user}","gists_url":"https://api.github.com/users/ivanbasov/gists{/gist_id}","starred_url":"https://api.github.com/users/ivanbasov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivanbasov/subscriptions","organizations_url":"https://api.github.com/users/ivanbasov/orgs","repos_url":"https://api.github.com/users/ivanbasov/repos","events_url":"https://api.github.com/users/ivanbasov/events{/privacy}","received_events_url":"https://api.github.com/users/ivanbasov/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-01T22:51:57Z","updated_at":"2018-10-18T20:43:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7df9377ee4ee6a3fd3e2a0afb1bbac7e5f350ac6","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jinujoseph","id":12449387,"node_id":"MDQ6VXNlcjEyNDQ5Mzg3","avatar_url":"https://avatars3.githubusercontent.com/u/12449387?v=4","gravatar_id":"","url":"https://api.github.com/users/jinujoseph","html_url":"https://github.com/jinujoseph","followers_url":"https://api.github.com/users/jinujoseph/followers","following_url":"https://api.github.com/users/jinujoseph/following{/other_user}","gists_url":"https://api.github.com/users/jinujoseph/gists{/gist_id}","starred_url":"https://api.github.com/users/jinujoseph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jinujoseph/subscriptions","organizations_url":"https://api.github.com/users/jinujoseph/orgs","repos_url":"https://api.github.com/users/jinujoseph/repos","events_url":"https://api.github.com/users/jinujoseph/events{/privacy}","received_events_url":"https://api.github.com/users/jinujoseph/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":166377917,"node_id":"MDU6TGFiZWwxNjYzNzc5MTc=","url":"https://api.github.com/repos/dotnet/roslyn/labels/Area-IDE","name":"Area-IDE","color":"5319e7","default":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/roslyn/milestones/18","html_url":"https://github.com/dotnet/roslyn/milestone/18","labels_url":"https://api.github.com/repos/dotnet/roslyn/milestones/18/labels","id":1675130,"node_id":"MDk6TWlsZXN0b25lMTY3NTEzMA==","number":18,"title":"16.0","description":"The version *after* the next major version.","creator":{"login":"gafter","id":3804346,"node_id":"MDQ6VXNlcjM4MDQzNDY=","avatar_url":"https://avatars3.githubusercontent.com/u/3804346?v=4","gravatar_id":"","url":"https://api.github.com/users/gafter","html_url":"https://github.com/gafter","followers_url":"https://api.github.com/users/gafter/followers","following_url":"https://api.github.com/users/gafter/following{/other_user}","gists_url":"https://api.github.com/users/gafter/gists{/gist_id}","starred_url":"https://api.github.com/users/gafter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gafter/subscriptions","organizations_url":"https://api.github.com/users/gafter/orgs","repos_url":"https://api.github.com/users/gafter/repos","events_url":"https://api.github.com/users/gafter/events{/privacy}","received_events_url":"https://api.github.com/users/gafter/received_events","type":"User","site_admin":false},"open_issues":1363,"closed_issues":763,"state":"open","created_at":"2016-03-31T00:06:25Z","updated_at":"2018-10-18T20:08:43Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/29016/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/29016/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/29016/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/bec7bdb7514941b79d971d716b6dcc97600ea194","head":{"label":"ivanbasov:asynccompletion","ref":"asynccompletion","sha":"bec7bdb7514941b79d971d716b6dcc97600ea194","user":{"login":"ivanbasov","id":5455484,"node_id":"MDQ6VXNlcjU0NTU0ODQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5455484?v=4","gravatar_id":"","url":"https://api.github.com/users/ivanbasov","html_url":"https://github.com/ivanbasov","followers_url":"https://api.github.com/users/ivanbasov/followers","following_url":"https://api.github.com/users/ivanbasov/following{/other_user}","gists_url":"https://api.github.com/users/ivanbasov/gists{/gist_id}","starred_url":"https://api.github.com/users/ivanbasov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivanbasov/subscriptions","organizations_url":"https://api.github.com/users/ivanbasov/orgs","repos_url":"https://api.github.com/users/ivanbasov/repos","events_url":"https://api.github.com/users/ivanbasov/events{/privacy}","received_events_url":"https://api.github.com/users/ivanbasov/received_events","type":"User","site_admin":false},"repo":{"id":85608790,"node_id":"MDEwOlJlcG9zaXRvcnk4NTYwODc5MA==","name":"roslyn","full_name":"ivanbasov/roslyn","private":false,"owner":{"login":"ivanbasov","id":5455484,"node_id":"MDQ6VXNlcjU0NTU0ODQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5455484?v=4","gravatar_id":"","url":"https://api.github.com/users/ivanbasov","html_url":"https://github.com/ivanbasov","followers_url":"https://api.github.com/users/ivanbasov/followers","following_url":"https://api.github.com/users/ivanbasov/following{/other_user}","gists_url":"https://api.github.com/users/ivanbasov/gists{/gist_id}","starred_url":"https://api.github.com/users/ivanbasov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivanbasov/subscriptions","organizations_url":"https://api.github.com/users/ivanbasov/orgs","repos_url":"https://api.github.com/users/ivanbasov/repos","events_url":"https://api.github.com/users/ivanbasov/events{/privacy}","received_events_url":"https://api.github.com/users/ivanbasov/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ivanbasov/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/ivanbasov/roslyn","forks_url":"https://api.github.com/repos/ivanbasov/roslyn/forks","keys_url":"https://api.github.com/repos/ivanbasov/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ivanbasov/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ivanbasov/roslyn/teams","hooks_url":"https://api.github.com/repos/ivanbasov/roslyn/hooks","issue_events_url":"https://api.github.com/repos/ivanbasov/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/ivanbasov/roslyn/events","assignees_url":"https://api.github.com/repos/ivanbasov/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/ivanbasov/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/ivanbasov/roslyn/tags","blobs_url":"https://api.github.com/repos/ivanbasov/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ivanbasov/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ivanbasov/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/ivanbasov/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ivanbasov/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/ivanbasov/roslyn/languages","stargazers_url":"https://api.github.com/repos/ivanbasov/roslyn/stargazers","contributors_url":"https://api.github.com/repos/ivanbasov/roslyn/contributors","subscribers_url":"https://api.github.com/repos/ivanbasov/roslyn/subscribers","subscription_url":"https://api.github.com/repos/ivanbasov/roslyn/subscription","commits_url":"https://api.github.com/repos/ivanbasov/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/ivanbasov/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/ivanbasov/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/ivanbasov/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/ivanbasov/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/ivanbasov/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ivanbasov/roslyn/merges","archive_url":"https://api.github.com/repos/ivanbasov/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ivanbasov/roslyn/downloads","issues_url":"https://api.github.com/repos/ivanbasov/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/ivanbasov/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/ivanbasov/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/ivanbasov/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ivanbasov/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/ivanbasov/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/ivanbasov/roslyn/deployments","created_at":"2017-03-20T17:55:57Z","updated_at":"2017-03-20T17:56:36Z","pushed_at":"2018-10-18T02:29:46Z","git_url":"git://github.com/ivanbasov/roslyn.git","ssh_url":"git@github.com:ivanbasov/roslyn.git","clone_url":"https://github.com/ivanbasov/roslyn.git","svn_url":"https://github.com/ivanbasov/roslyn","homepage":"","size":419679,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:dev16.0.x-vs-deps","ref":"dev16.0.x-vs-deps","sha":"d0562fe816052844886f53ceaa63c74b566c6139","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"node_id":"MDEwOlJlcG9zaXRvcnkyOTA3ODk5Nw==","name":"roslyn","full_name":"dotnet/roslyn","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn/deployments","created_at":"2015-01-11T02:39:03Z","updated_at":"2018-10-18T20:36:26Z","pushed_at":"2018-10-18T20:39:50Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":469517,"stargazers_count":10204,"watchers_count":10204,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2426,"mirror_url":null,"archived":false,"open_issues_count":5342,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2426,"open_issues":5342,"watchers":10204,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/29016"},"html":{"href":"https://github.com/dotnet/roslyn/pull/29016"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/29016"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/29016/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/29016/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/29016/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/bec7bdb7514941b79d971d716b6dcc97600ea194"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"grabalon"}}