{"action":"opened","number":7530,"pull_request":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/7530","id":211661688,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNjYxNjg4","html_url":"https://github.com/pingcap/tidb/pull/7530","diff_url":"https://github.com/pingcap/tidb/pull/7530.diff","patch_url":"https://github.com/pingcap/tidb/pull/7530.patch","issue_url":"https://api.github.com/repos/pingcap/tidb/issues/7530","number":7530,"state":"open","locked":false,"title":"stats: fix zero column size update error","user":{"login":"lamxTyler","id":16222711,"node_id":"MDQ6VXNlcjE2MjIyNzEx","avatar_url":"https://avatars1.githubusercontent.com/u/16222711?v=4","gravatar_id":"","url":"https://api.github.com/users/lamxTyler","html_url":"https://github.com/lamxTyler","followers_url":"https://api.github.com/users/lamxTyler/followers","following_url":"https://api.github.com/users/lamxTyler/following{/other_user}","gists_url":"https://api.github.com/users/lamxTyler/gists{/gist_id}","starred_url":"https://api.github.com/users/lamxTyler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamxTyler/subscriptions","organizations_url":"https://api.github.com/users/lamxTyler/orgs","repos_url":"https://api.github.com/users/lamxTyler/repos","events_url":"https://api.github.com/users/lamxTyler/events{/privacy}","received_events_url":"https://api.github.com/users/lamxTyler/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for contributing to TiDB! Please read TiDB's [CONTRIBUTING](https://github.com/pingcap/tidb/blob/master/CONTRIBUTING.md) document **BEFORE** filing this PR.\r\n-->\r\n\r\n### What problem does this PR solve? <!--add issue link with summary if exists-->\r\n\r\nWhen all the column size delta is zero, there would be parse error for the insert statement.\r\n\r\n### What is changed and how it works?\r\n\r\nSkip the update when the column size delta is zero.\r\n\r\n### Check List <!--REMOVE the items that are not applicable-->\r\n\r\nTests <!-- At least one of them must be included. -->\r\n\r\n - Unit test\r\n\r\nCode changes\r\n\r\n - Has unexported function/method change\r\n\r\nSide effects\r\n\r\n - None\r\n\r\nRelated changes\r\n\r\n - None\r\n\r\nPTAL @coocood @zz-jason @winoros ","created_at":"2018-08-29T08:00:11Z","updated_at":"2018-08-29T08:00:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/tidb/pulls/7530/commits","review_comments_url":"https://api.github.com/repos/pingcap/tidb/pulls/7530/comments","review_comment_url":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/tidb/issues/7530/comments","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/3df48c995cba7cf1ada073f6c078312e5168742c","head":{"label":"lamxTyler:zero-colsize","ref":"zero-colsize","sha":"3df48c995cba7cf1ada073f6c078312e5168742c","user":{"login":"lamxTyler","id":16222711,"node_id":"MDQ6VXNlcjE2MjIyNzEx","avatar_url":"https://avatars1.githubusercontent.com/u/16222711?v=4","gravatar_id":"","url":"https://api.github.com/users/lamxTyler","html_url":"https://github.com/lamxTyler","followers_url":"https://api.github.com/users/lamxTyler/followers","following_url":"https://api.github.com/users/lamxTyler/following{/other_user}","gists_url":"https://api.github.com/users/lamxTyler/gists{/gist_id}","starred_url":"https://api.github.com/users/lamxTyler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamxTyler/subscriptions","organizations_url":"https://api.github.com/users/lamxTyler/orgs","repos_url":"https://api.github.com/users/lamxTyler/repos","events_url":"https://api.github.com/users/lamxTyler/events{/privacy}","received_events_url":"https://api.github.com/users/lamxTyler/received_events","type":"User","site_admin":false},"repo":{"id":107388999,"node_id":"MDEwOlJlcG9zaXRvcnkxMDczODg5OTk=","name":"tidb","full_name":"lamxTyler/tidb","owner":{"login":"lamxTyler","id":16222711,"node_id":"MDQ6VXNlcjE2MjIyNzEx","avatar_url":"https://avatars1.githubusercontent.com/u/16222711?v=4","gravatar_id":"","url":"https://api.github.com/users/lamxTyler","html_url":"https://github.com/lamxTyler","followers_url":"https://api.github.com/users/lamxTyler/followers","following_url":"https://api.github.com/users/lamxTyler/following{/other_user}","gists_url":"https://api.github.com/users/lamxTyler/gists{/gist_id}","starred_url":"https://api.github.com/users/lamxTyler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamxTyler/subscriptions","organizations_url":"https://api.github.com/users/lamxTyler/orgs","repos_url":"https://api.github.com/users/lamxTyler/repos","events_url":"https://api.github.com/users/lamxTyler/events{/privacy}","received_events_url":"https://api.github.com/users/lamxTyler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lamxTyler/tidb","description":"TiDB is a distributed NewSQL database compatible with MySQL protocol ","fork":true,"url":"https://api.github.com/repos/lamxTyler/tidb","forks_url":"https://api.github.com/repos/lamxTyler/tidb/forks","keys_url":"https://api.github.com/repos/lamxTyler/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lamxTyler/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lamxTyler/tidb/teams","hooks_url":"https://api.github.com/repos/lamxTyler/tidb/hooks","issue_events_url":"https://api.github.com/repos/lamxTyler/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/lamxTyler/tidb/events","assignees_url":"https://api.github.com/repos/lamxTyler/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/lamxTyler/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/lamxTyler/tidb/tags","blobs_url":"https://api.github.com/repos/lamxTyler/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lamxTyler/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lamxTyler/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/lamxTyler/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lamxTyler/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/lamxTyler/tidb/languages","stargazers_url":"https://api.github.com/repos/lamxTyler/tidb/stargazers","contributors_url":"https://api.github.com/repos/lamxTyler/tidb/contributors","subscribers_url":"https://api.github.com/repos/lamxTyler/tidb/subscribers","subscription_url":"https://api.github.com/repos/lamxTyler/tidb/subscription","commits_url":"https://api.github.com/repos/lamxTyler/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/lamxTyler/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/lamxTyler/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/lamxTyler/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/lamxTyler/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/lamxTyler/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lamxTyler/tidb/merges","archive_url":"https://api.github.com/repos/lamxTyler/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lamxTyler/tidb/downloads","issues_url":"https://api.github.com/repos/lamxTyler/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/lamxTyler/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/lamxTyler/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/lamxTyler/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lamxTyler/tidb/labels{/name}","releases_url":"https://api.github.com/repos/lamxTyler/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/lamxTyler/tidb/deployments","created_at":"2017-10-18T09:49:38Z","updated_at":"2018-08-24T11:03:49Z","pushed_at":"2018-08-29T07:56:04Z","git_url":"git://github.com/lamxTyler/tidb.git","ssh_url":"git@github.com:lamxTyler/tidb.git","clone_url":"https://github.com/lamxTyler/tidb.git","svn_url":"https://github.com/lamxTyler/tidb","homepage":"https://pingcap.com","size":53280,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pingcap:release-2.0","ref":"release-2.0","sha":"b3b844a5f50bb876e521b0a575dafa2d9c3af207","user":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":41986369,"node_id":"MDEwOlJlcG9zaXRvcnk0MTk4NjM2OQ==","name":"tidb","full_name":"pingcap/tidb","owner":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/tidb","description":"TiDB is a distributed HTAP database compatible with the MySQL protocol ","fork":false,"url":"https://api.github.com/repos/pingcap/tidb","forks_url":"https://api.github.com/repos/pingcap/tidb/forks","keys_url":"https://api.github.com/repos/pingcap/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tidb/teams","hooks_url":"https://api.github.com/repos/pingcap/tidb/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tidb/events","assignees_url":"https://api.github.com/repos/pingcap/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tidb/tags","blobs_url":"https://api.github.com/repos/pingcap/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tidb/languages","stargazers_url":"https://api.github.com/repos/pingcap/tidb/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tidb/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tidb/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tidb/subscription","commits_url":"https://api.github.com/repos/pingcap/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tidb/merges","archive_url":"https://api.github.com/repos/pingcap/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tidb/downloads","issues_url":"https://api.github.com/repos/pingcap/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tidb/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tidb/deployments","created_at":"2015-09-06T04:01:52Z","updated_at":"2018-08-29T07:57:53Z","pushed_at":"2018-08-29T07:57:46Z","git_url":"git://github.com/pingcap/tidb.git","ssh_url":"git@github.com:pingcap/tidb.git","clone_url":"https://github.com/pingcap/tidb.git","svn_url":"https://github.com/pingcap/tidb","homepage":"https://pingcap.com","size":80644,"stargazers_count":14600,"watchers_count":14600,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2037,"mirror_url":null,"archived":false,"open_issues_count":523,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2037,"open_issues":523,"watchers":14600,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/7530"},"html":{"href":"https://github.com/pingcap/tidb/pull/7530"},"issue":{"href":"https://api.github.com/repos/pingcap/tidb/issues/7530"},"comments":{"href":"https://api.github.com/repos/pingcap/tidb/issues/7530/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/7530/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/7530/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/tidb/statuses/3df48c995cba7cf1ada073f6c078312e5168742c"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":16,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"lamxTyler"}}