{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/177164287","pull_request_review_id":106990365,"id":177164287,"diff_hunk":"@@ -83,6 +83,11 @@ ERROR(error_unknown_arg,none,\n   \"unknown argument: '%0'\", (StringRef))\n ERROR(error_invalid_arg_value,none,\n   \"invalid value '%1' in '%0'\", (StringRef, StringRef))\n+NOTE(note_ignoring_earlier_mode_argument,none,\n+  \"ignoring earlier '%0' argument in favor of later '%1' argument\",\n+  (StringRef, StringRef))\n+NOTE(note_cannot_multithread_batch_mode,none,\n+  \"ignoring -num-threads argument, cannot multithread batch mode\", ())","path":"include/swift/AST/DiagnosticsFrontend.def","position":8,"original_position":8,"commit_id":"e01f6cb0f2f66feb768fe7138d8dceb5648108d4","original_commit_id":"e01f6cb0f2f66feb768fe7138d8dceb5648108d4","user":{"login":"jrose-apple","id":15097531,"avatar_url":"https://avatars2.githubusercontent.com/u/15097531?v=4","gravatar_id":"","url":"https://api.github.com/users/jrose-apple","html_url":"https://github.com/jrose-apple","followers_url":"https://api.github.com/users/jrose-apple/followers","following_url":"https://api.github.com/users/jrose-apple/following{/other_user}","gists_url":"https://api.github.com/users/jrose-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/jrose-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrose-apple/subscriptions","organizations_url":"https://api.github.com/users/jrose-apple/orgs","repos_url":"https://api.github.com/users/jrose-apple/repos","events_url":"https://api.github.com/users/jrose-apple/events{/privacy}","received_events_url":"https://api.github.com/users/jrose-apple/received_events","type":"User","site_admin":false},"body":"Notes must always be attached to other diagnostics. Please use warnings here.","created_at":"2018-03-26T17:01:50Z","updated_at":"2018-03-26T17:05:09Z","html_url":"https://github.com/apple/swift/pull/15504#discussion_r177164287","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/15504","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/177164287"},"html":{"href":"https://github.com/apple/swift/pull/15504#discussion_r177164287"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/15504"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/15504","id":177321657,"html_url":"https://github.com/apple/swift/pull/15504","diff_url":"https://github.com/apple/swift/pull/15504.diff","patch_url":"https://github.com/apple/swift/pull/15504.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/15504","number":15504,"state":"open","locked":false,"title":"[Batch mode] Harden driver against conflicting arguments","user":{"login":"davidungar","id":461264,"avatar_url":"https://avatars1.githubusercontent.com/u/461264?v=4","gravatar_id":"","url":"https://api.github.com/users/davidungar","html_url":"https://github.com/davidungar","followers_url":"https://api.github.com/users/davidungar/followers","following_url":"https://api.github.com/users/davidungar/following{/other_user}","gists_url":"https://api.github.com/users/davidungar/gists{/gist_id}","starred_url":"https://api.github.com/users/davidungar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidungar/subscriptions","organizations_url":"https://api.github.com/users/davidungar/orgs","repos_url":"https://api.github.com/users/davidungar/repos","events_url":"https://api.github.com/users/davidungar/events{/privacy}","received_events_url":"https://api.github.com/users/davidungar/received_events","type":"User","site_admin":false},"body":"<!-- What's in this pull request? -->\r\nWhat if the driver is invoked with both -enable-batch-mode and -whole-module-optimization?\r\nThis PR has the driver obey the last argument instead of -whole-module-optimization and issue a diagnostic.\r\nAlso if the driver is invoked with -enable-batch-mode and -num-threads the driver will trip an assertion that does not obviously indicate the problem. This PR adds an assertion with a clear message, and also causes the driver to ignore the -num-threads argument and issue a diagnostic, so that the assertion should never trip.\r\nFinally, handle indexing a bit more nicely.\r\n\r\n<!-- If this pull request resolves any bugs in the Swift bug tracker, provide a link: -->\r\n\r\n\r\n<!--\r\nBefore merging this pull request, you must run the Swift continuous integration tests.\r\nFor information about triggering CI builds via @swift-ci, see:\r\nhttps://github.com/apple/swift/blob/master/docs/ContinuousIntegration.md#swift-ci\r\n\r\nThank you for your contribution to Swift!\r\n-->","created_at":"2018-03-26T00:43:02Z","updated_at":"2018-03-26T17:05:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd4dced5f7181c78412dfc6b89f6811f1d6ea30c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"graydon","id":14097,"avatar_url":"https://avatars3.githubusercontent.com/u/14097?v=4","gravatar_id":"","url":"https://api.github.com/users/graydon","html_url":"https://github.com/graydon","followers_url":"https://api.github.com/users/graydon/followers","following_url":"https://api.github.com/users/graydon/following{/other_user}","gists_url":"https://api.github.com/users/graydon/gists{/gist_id}","starred_url":"https://api.github.com/users/graydon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graydon/subscriptions","organizations_url":"https://api.github.com/users/graydon/orgs","repos_url":"https://api.github.com/users/graydon/repos","events_url":"https://api.github.com/users/graydon/events{/privacy}","received_events_url":"https://api.github.com/users/graydon/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/15504/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/15504/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/15504/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/e01f6cb0f2f66feb768fe7138d8dceb5648108d4","head":{"label":"davidungar:PR-18-14-harden-driver-against-conflicting-arguments","ref":"PR-18-14-harden-driver-against-conflicting-arguments","sha":"e01f6cb0f2f66feb768fe7138d8dceb5648108d4","user":{"login":"davidungar","id":461264,"avatar_url":"https://avatars1.githubusercontent.com/u/461264?v=4","gravatar_id":"","url":"https://api.github.com/users/davidungar","html_url":"https://github.com/davidungar","followers_url":"https://api.github.com/users/davidungar/followers","following_url":"https://api.github.com/users/davidungar/following{/other_user}","gists_url":"https://api.github.com/users/davidungar/gists{/gist_id}","starred_url":"https://api.github.com/users/davidungar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidungar/subscriptions","organizations_url":"https://api.github.com/users/davidungar/orgs","repos_url":"https://api.github.com/users/davidungar/repos","events_url":"https://api.github.com/users/davidungar/events{/privacy}","received_events_url":"https://api.github.com/users/davidungar/received_events","type":"User","site_admin":false},"repo":{"id":100639829,"name":"swift","full_name":"davidungar/swift","owner":{"login":"davidungar","id":461264,"avatar_url":"https://avatars1.githubusercontent.com/u/461264?v=4","gravatar_id":"","url":"https://api.github.com/users/davidungar","html_url":"https://github.com/davidungar","followers_url":"https://api.github.com/users/davidungar/followers","following_url":"https://api.github.com/users/davidungar/following{/other_user}","gists_url":"https://api.github.com/users/davidungar/gists{/gist_id}","starred_url":"https://api.github.com/users/davidungar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidungar/subscriptions","organizations_url":"https://api.github.com/users/davidungar/orgs","repos_url":"https://api.github.com/users/davidungar/repos","events_url":"https://api.github.com/users/davidungar/events{/privacy}","received_events_url":"https://api.github.com/users/davidungar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davidungar/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/davidungar/swift","forks_url":"https://api.github.com/repos/davidungar/swift/forks","keys_url":"https://api.github.com/repos/davidungar/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidungar/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidungar/swift/teams","hooks_url":"https://api.github.com/repos/davidungar/swift/hooks","issue_events_url":"https://api.github.com/repos/davidungar/swift/issues/events{/number}","events_url":"https://api.github.com/repos/davidungar/swift/events","assignees_url":"https://api.github.com/repos/davidungar/swift/assignees{/user}","branches_url":"https://api.github.com/repos/davidungar/swift/branches{/branch}","tags_url":"https://api.github.com/repos/davidungar/swift/tags","blobs_url":"https://api.github.com/repos/davidungar/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidungar/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidungar/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidungar/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidungar/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/davidungar/swift/languages","stargazers_url":"https://api.github.com/repos/davidungar/swift/stargazers","contributors_url":"https://api.github.com/repos/davidungar/swift/contributors","subscribers_url":"https://api.github.com/repos/davidungar/swift/subscribers","subscription_url":"https://api.github.com/repos/davidungar/swift/subscription","commits_url":"https://api.github.com/repos/davidungar/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidungar/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidungar/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidungar/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidungar/swift/contents/{+path}","compare_url":"https://api.github.com/repos/davidungar/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidungar/swift/merges","archive_url":"https://api.github.com/repos/davidungar/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidungar/swift/downloads","issues_url":"https://api.github.com/repos/davidungar/swift/issues{/number}","pulls_url":"https://api.github.com/repos/davidungar/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/davidungar/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/davidungar/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidungar/swift/labels{/name}","releases_url":"https://api.github.com/repos/davidungar/swift/releases{/id}","deployments_url":"https://api.github.com/repos/davidungar/swift/deployments","created_at":"2017-08-17T19:50:47Z","updated_at":"2017-08-17T19:51:19Z","pushed_at":"2018-03-26T04:59:55Z","git_url":"git://github.com/davidungar/swift.git","ssh_url":"git@github.com:davidungar/swift.git","clone_url":"https://github.com/davidungar/swift.git","svn_url":"https://github.com/davidungar/swift","homepage":"https://swift.org/","size":269870,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"869b6bf7d80ae59f304b2ac8bc0bd1debe5200e5","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2018-03-26T16:47:24Z","pushed_at":"2018-03-26T17:01:15Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":274828,"stargazers_count":43098,"watchers_count":43098,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6775,"mirror_url":null,"archived":false,"open_issues_count":297,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":6775,"open_issues":297,"watchers":43098,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/15504"},"html":{"href":"https://github.com/apple/swift/pull/15504"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/15504"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/15504/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/15504/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/15504/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/e01f6cb0f2f66feb768fe7138d8dceb5648108d4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jrose-apple"}}