{"action":"created","issue":{"url":"https://api.github.com/repos/blackbaud/skyux2/issues/1783","repository_url":"https://api.github.com/repos/blackbaud/skyux2","labels_url":"https://api.github.com/repos/blackbaud/skyux2/issues/1783/labels{/name}","comments_url":"https://api.github.com/repos/blackbaud/skyux2/issues/1783/comments","events_url":"https://api.github.com/repos/blackbaud/skyux2/issues/1783/events","html_url":"https://github.com/blackbaud/skyux2/pull/1783","id":337101565,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4Mzk2NTYy","number":1783,"title":"[HOLD] added aria-haspopup to the confirm demo buttons","user":{"login":"blackbaud-conorwright","id":20093443,"node_id":"MDQ6VXNlcjIwMDkzNDQz","avatar_url":"https://avatars2.githubusercontent.com/u/20093443?v=4","gravatar_id":"","url":"https://api.github.com/users/blackbaud-conorwright","html_url":"https://github.com/blackbaud-conorwright","followers_url":"https://api.github.com/users/blackbaud-conorwright/followers","following_url":"https://api.github.com/users/blackbaud-conorwright/following{/other_user}","gists_url":"https://api.github.com/users/blackbaud-conorwright/gists{/gist_id}","starred_url":"https://api.github.com/users/blackbaud-conorwright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blackbaud-conorwright/subscriptions","organizations_url":"https://api.github.com/users/blackbaud-conorwright/orgs","repos_url":"https://api.github.com/users/blackbaud-conorwright/repos","events_url":"https://api.github.com/users/blackbaud-conorwright/events{/privacy}","received_events_url":"https://api.github.com/users/blackbaud-conorwright/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"Blackbaud-SteveBrush","id":12497062,"node_id":"MDQ6VXNlcjEyNDk3MDYy","avatar_url":"https://avatars3.githubusercontent.com/u/12497062?v=4","gravatar_id":"","url":"https://api.github.com/users/Blackbaud-SteveBrush","html_url":"https://github.com/Blackbaud-SteveBrush","followers_url":"https://api.github.com/users/Blackbaud-SteveBrush/followers","following_url":"https://api.github.com/users/Blackbaud-SteveBrush/following{/other_user}","gists_url":"https://api.github.com/users/Blackbaud-SteveBrush/gists{/gist_id}","starred_url":"https://api.github.com/users/Blackbaud-SteveBrush/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Blackbaud-SteveBrush/subscriptions","organizations_url":"https://api.github.com/users/Blackbaud-SteveBrush/orgs","repos_url":"https://api.github.com/users/Blackbaud-SteveBrush/repos","events_url":"https://api.github.com/users/Blackbaud-SteveBrush/events{/privacy}","received_events_url":"https://api.github.com/users/Blackbaud-SteveBrush/received_events","type":"User","site_admin":false},"assignees":[{"login":"Blackbaud-SteveBrush","id":12497062,"node_id":"MDQ6VXNlcjEyNDk3MDYy","avatar_url":"https://avatars3.githubusercontent.com/u/12497062?v=4","gravatar_id":"","url":"https://api.github.com/users/Blackbaud-SteveBrush","html_url":"https://github.com/Blackbaud-SteveBrush","followers_url":"https://api.github.com/users/Blackbaud-SteveBrush/followers","following_url":"https://api.github.com/users/Blackbaud-SteveBrush/following{/other_user}","gists_url":"https://api.github.com/users/Blackbaud-SteveBrush/gists{/gist_id}","starred_url":"https://api.github.com/users/Blackbaud-SteveBrush/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Blackbaud-SteveBrush/subscriptions","organizations_url":"https://api.github.com/users/Blackbaud-SteveBrush/orgs","repos_url":"https://api.github.com/users/Blackbaud-SteveBrush/repos","events_url":"https://api.github.com/users/Blackbaud-SteveBrush/events{/privacy}","received_events_url":"https://api.github.com/users/Blackbaud-SteveBrush/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-06-29T18:51:06Z","updated_at":"2018-07-06T17:21:13Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/blackbaud/skyux2/pulls/1783","html_url":"https://github.com/blackbaud/skyux2/pull/1783","diff_url":"https://github.com/blackbaud/skyux2/pull/1783.diff","patch_url":"https://github.com/blackbaud/skyux2/pull/1783.patch"},"body":"Added aria-haspopup to the buttons in the confirm demo.\r\n\r\nThis issue mentions icons, but I don't currently see any icons in the confirm demo. @Blackbaud-ToddRoberts can you confirm that that part of the issue is no longer present?\r\n\r\nResolves: #1405 "},"comment":{"url":"https://api.github.com/repos/blackbaud/skyux2/issues/comments/403096618","html_url":"https://github.com/blackbaud/skyux2/pull/1783#issuecomment-403096618","issue_url":"https://api.github.com/repos/blackbaud/skyux2/issues/1783","id":403096618,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMzA5NjYxOA==","user":{"login":"Blackbaud-ToddRoberts","id":13765813,"node_id":"MDQ6VXNlcjEzNzY1ODEz","avatar_url":"https://avatars3.githubusercontent.com/u/13765813?v=4","gravatar_id":"","url":"https://api.github.com/users/Blackbaud-ToddRoberts","html_url":"https://github.com/Blackbaud-ToddRoberts","followers_url":"https://api.github.com/users/Blackbaud-ToddRoberts/followers","following_url":"https://api.github.com/users/Blackbaud-ToddRoberts/following{/other_user}","gists_url":"https://api.github.com/users/Blackbaud-ToddRoberts/gists{/gist_id}","starred_url":"https://api.github.com/users/Blackbaud-ToddRoberts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Blackbaud-ToddRoberts/subscriptions","organizations_url":"https://api.github.com/users/Blackbaud-ToddRoberts/orgs","repos_url":"https://api.github.com/users/Blackbaud-ToddRoberts/repos","events_url":"https://api.github.com/users/Blackbaud-ToddRoberts/events{/privacy}","received_events_url":"https://api.github.com/users/Blackbaud-ToddRoberts/received_events","type":"User","site_admin":false},"created_at":"2018-07-06T17:21:13Z","updated_at":"2018-07-06T17:21:13Z","author_association":"CONTRIBUTOR","body":"I think we removed the icons a while ago.\r\n\r\nYou can specify aria-haspopup=\"dialog\" in ARIA 1.1 but apparently it is not fully supported in assistive technology yet. The short term solution seems to be to use aria-haspopup=\"true\" until that catches up. \r\n\r\nhttps://www.w3.org/TR/wai-aria-1.1/#aria-haspopup\r\n"}}
{"actor":{"display_login":"Blackbaud-ToddRoberts"}}