{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/content-data-admin/pulls/comments/226255648","pull_request_review_id":166030412,"id":226255648,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjI1NTY0OA==","diff_hunk":"@@ -13,6 +13,8 @@\n .app-c-glance-metric__heading {\n   @include govuk-responsive-margin(3, \"top\");\n   @include govuk-responsive-margin(2, \"bottom\");\n+  min-height: 2.6em;\n+\n \n   @include media-down(tablet) {","path":"app/assets/stylesheets/components/_glance-metric.scss","position":7,"original_position":7,"commit_id":"194e295a9d843ba7996a1d9cc4a15b261b38ed0a","original_commit_id":"194e295a9d843ba7996a1d9cc4a15b261b38ed0a","user":{"login":"alex-ju","id":788096,"node_id":"MDQ6VXNlcjc4ODA5Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/788096?v=4","gravatar_id":"","url":"https://api.github.com/users/alex-ju","html_url":"https://github.com/alex-ju","followers_url":"https://api.github.com/users/alex-ju/followers","following_url":"https://api.github.com/users/alex-ju/following{/other_user}","gists_url":"https://api.github.com/users/alex-ju/gists{/gist_id}","starred_url":"https://api.github.com/users/alex-ju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex-ju/subscriptions","organizations_url":"https://api.github.com/users/alex-ju/orgs","repos_url":"https://api.github.com/users/alex-ju/repos","events_url":"https://api.github.com/users/alex-ju/events{/privacy}","received_events_url":"https://api.github.com/users/alex-ju/received_events","type":"User","site_admin":false},"body":"Non-blocker: instead of `media-down(tablet)` — which is a mixin that we will deprecate — you can use the govuk-frontend version of it, which is `@include govuk-media-query($from: tablet)`; `mobile`, `tablet` and `desktop`) being the breaking points, always going up as the intended approach is to go mobile first. This need quite a bit of refactoring, so it's not a blocking comment, but more for awareness.","created_at":"2018-10-18T10:42:02Z","updated_at":"2018-10-18T10:49:17Z","html_url":"https://github.com/alphagov/content-data-admin/pull/127#discussion_r226255648","pull_request_url":"https://api.github.com/repos/alphagov/content-data-admin/pulls/127","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/alphagov/content-data-admin/pulls/comments/226255648"},"html":{"href":"https://github.com/alphagov/content-data-admin/pull/127#discussion_r226255648"},"pull_request":{"href":"https://api.github.com/repos/alphagov/content-data-admin/pulls/127"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/content-data-admin/pulls/127","id":223628389,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNjI4Mzg5","html_url":"https://github.com/alphagov/content-data-admin/pull/127","diff_url":"https://github.com/alphagov/content-data-admin/pull/127.diff","patch_url":"https://github.com/alphagov/content-data-admin/pull/127.patch","issue_url":"https://api.github.com/repos/alphagov/content-data-admin/issues/127","number":127,"state":"open","locked":false,"title":"Add styling for mobile views, tweak desktop view to match design.","user":{"login":"maxgds","id":31649453,"node_id":"MDQ6VXNlcjMxNjQ5NDUz","avatar_url":"https://avatars0.githubusercontent.com/u/31649453?v=4","gravatar_id":"","url":"https://api.github.com/users/maxgds","html_url":"https://github.com/maxgds","followers_url":"https://api.github.com/users/maxgds/followers","following_url":"https://api.github.com/users/maxgds/following{/other_user}","gists_url":"https://api.github.com/users/maxgds/gists{/gist_id}","starred_url":"https://api.github.com/users/maxgds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxgds/subscriptions","organizations_url":"https://api.github.com/users/maxgds/orgs","repos_url":"https://api.github.com/users/maxgds/repos","events_url":"https://api.github.com/users/maxgds/events{/privacy}","received_events_url":"https://api.github.com/users/maxgds/received_events","type":"User","site_admin":false},"body":"https://trello.com/c/csZsWZNy/736-3-page-data-make-layout-work-at-mobile-and-tablet-breakpoints\r\n\r\nMatching styles against designs for desktop and mobile:\r\n\r\nhttps://drive.google.com/open?id=194icCuUprUsYYtakbUHGZbDQySoLnCSe\r\nhttps://drive.google.com/open?id=1IHYvkjQm_ZAU9Er-cIdAapNLZ7qEDOns\r\n\r\nSome changes to CSS classes, building on top of recent changes in the gem.","created_at":"2018-10-17T14:32:00Z","updated_at":"2018-10-18T10:49:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ef80f6d0ee09e382c5bc1cfdb70cf4ac340ea57","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/content-data-admin/pulls/127/commits","review_comments_url":"https://api.github.com/repos/alphagov/content-data-admin/pulls/127/comments","review_comment_url":"https://api.github.com/repos/alphagov/content-data-admin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/content-data-admin/issues/127/comments","statuses_url":"https://api.github.com/repos/alphagov/content-data-admin/statuses/194e295a9d843ba7996a1d9cc4a15b261b38ed0a","head":{"label":"alphagov:mobile","ref":"mobile","sha":"194e295a9d843ba7996a1d9cc4a15b261b38ed0a","user":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":142429907,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI0Mjk5MDc=","name":"content-data-admin","full_name":"alphagov/content-data-admin","private":false,"owner":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/alphagov/content-data-admin","description":"A front end for the data warehouse","fork":false,"url":"https://api.github.com/repos/alphagov/content-data-admin","forks_url":"https://api.github.com/repos/alphagov/content-data-admin/forks","keys_url":"https://api.github.com/repos/alphagov/content-data-admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/content-data-admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/content-data-admin/teams","hooks_url":"https://api.github.com/repos/alphagov/content-data-admin/hooks","issue_events_url":"https://api.github.com/repos/alphagov/content-data-admin/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/content-data-admin/events","assignees_url":"https://api.github.com/repos/alphagov/content-data-admin/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/content-data-admin/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/content-data-admin/tags","blobs_url":"https://api.github.com/repos/alphagov/content-data-admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/content-data-admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/content-data-admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/content-data-admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/content-data-admin/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/content-data-admin/languages","stargazers_url":"https://api.github.com/repos/alphagov/content-data-admin/stargazers","contributors_url":"https://api.github.com/repos/alphagov/content-data-admin/contributors","subscribers_url":"https://api.github.com/repos/alphagov/content-data-admin/subscribers","subscription_url":"https://api.github.com/repos/alphagov/content-data-admin/subscription","commits_url":"https://api.github.com/repos/alphagov/content-data-admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/content-data-admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/content-data-admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/content-data-admin/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/content-data-admin/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/content-data-admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/content-data-admin/merges","archive_url":"https://api.github.com/repos/alphagov/content-data-admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/content-data-admin/downloads","issues_url":"https://api.github.com/repos/alphagov/content-data-admin/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/content-data-admin/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/content-data-admin/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/content-data-admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/content-data-admin/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/content-data-admin/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/content-data-admin/deployments","created_at":"2018-07-26T11:09:09Z","updated_at":"2018-10-17T12:53:32Z","pushed_at":"2018-10-18T10:26:26Z","git_url":"git://github.com/alphagov/content-data-admin.git","ssh_url":"git@github.com:alphagov/content-data-admin.git","clone_url":"https://github.com/alphagov/content-data-admin.git","svn_url":"https://github.com/alphagov/content-data-admin","homepage":"https://docs.publishing.service.gov.uk/apps/content-data-admin.html","size":481,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"6b9b989d0ad7cb51fc38a4b3e0c7ba11878cc6b8","user":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":142429907,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI0Mjk5MDc=","name":"content-data-admin","full_name":"alphagov/content-data-admin","private":false,"owner":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/alphagov/content-data-admin","description":"A front end for the data warehouse","fork":false,"url":"https://api.github.com/repos/alphagov/content-data-admin","forks_url":"https://api.github.com/repos/alphagov/content-data-admin/forks","keys_url":"https://api.github.com/repos/alphagov/content-data-admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/content-data-admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/content-data-admin/teams","hooks_url":"https://api.github.com/repos/alphagov/content-data-admin/hooks","issue_events_url":"https://api.github.com/repos/alphagov/content-data-admin/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/content-data-admin/events","assignees_url":"https://api.github.com/repos/alphagov/content-data-admin/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/content-data-admin/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/content-data-admin/tags","blobs_url":"https://api.github.com/repos/alphagov/content-data-admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/content-data-admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/content-data-admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/content-data-admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/content-data-admin/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/content-data-admin/languages","stargazers_url":"https://api.github.com/repos/alphagov/content-data-admin/stargazers","contributors_url":"https://api.github.com/repos/alphagov/content-data-admin/contributors","subscribers_url":"https://api.github.com/repos/alphagov/content-data-admin/subscribers","subscription_url":"https://api.github.com/repos/alphagov/content-data-admin/subscription","commits_url":"https://api.github.com/repos/alphagov/content-data-admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/content-data-admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/content-data-admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/content-data-admin/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/content-data-admin/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/content-data-admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/content-data-admin/merges","archive_url":"https://api.github.com/repos/alphagov/content-data-admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/content-data-admin/downloads","issues_url":"https://api.github.com/repos/alphagov/content-data-admin/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/content-data-admin/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/content-data-admin/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/content-data-admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/content-data-admin/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/content-data-admin/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/content-data-admin/deployments","created_at":"2018-07-26T11:09:09Z","updated_at":"2018-10-17T12:53:32Z","pushed_at":"2018-10-18T10:26:26Z","git_url":"git://github.com/alphagov/content-data-admin.git","ssh_url":"git@github.com:alphagov/content-data-admin.git","clone_url":"https://github.com/alphagov/content-data-admin.git","svn_url":"https://github.com/alphagov/content-data-admin","homepage":"https://docs.publishing.service.gov.uk/apps/content-data-admin.html","size":481,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/content-data-admin/pulls/127"},"html":{"href":"https://github.com/alphagov/content-data-admin/pull/127"},"issue":{"href":"https://api.github.com/repos/alphagov/content-data-admin/issues/127"},"comments":{"href":"https://api.github.com/repos/alphagov/content-data-admin/issues/127/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/content-data-admin/pulls/127/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/content-data-admin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/content-data-admin/pulls/127/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/content-data-admin/statuses/194e295a9d843ba7996a1d9cc4a15b261b38ed0a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"alex-ju"}}