{"action":"created","issue":{"url":"https://api.github.com/repos/vufind-org/vufind/issues/1137","repository_url":"https://api.github.com/repos/vufind-org/vufind","labels_url":"https://api.github.com/repos/vufind-org/vufind/issues/1137/labels{/name}","comments_url":"https://api.github.com/repos/vufind-org/vufind/issues/1137/comments","events_url":"https://api.github.com/repos/vufind-org/vufind/issues/1137/events","html_url":"https://github.com/vufind-org/vufind/pull/1137","id":303854984,"number":1137,"title":"RELAIS / E-ZBorrow integration","user":{"login":"demiankatz","id":309069,"avatar_url":"https://avatars3.githubusercontent.com/u/309069?v=4","gravatar_id":"","url":"https://api.github.com/users/demiankatz","html_url":"https://github.com/demiankatz","followers_url":"https://api.github.com/users/demiankatz/followers","following_url":"https://api.github.com/users/demiankatz/following{/other_user}","gists_url":"https://api.github.com/users/demiankatz/gists{/gist_id}","starred_url":"https://api.github.com/users/demiankatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/demiankatz/subscriptions","organizations_url":"https://api.github.com/users/demiankatz/orgs","repos_url":"https://api.github.com/users/demiankatz/repos","events_url":"https://api.github.com/users/demiankatz/events{/privacy}","received_events_url":"https://api.github.com/users/demiankatz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-03-09T14:16:26Z","updated_at":"2018-05-15T19:57:02Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/vufind-org/vufind/pulls/1137","html_url":"https://github.com/vufind-org/vufind/pull/1137","diff_url":"https://github.com/vufind-org/vufind/pull/1137.diff","patch_url":"https://github.com/vufind-org/vufind/pull/1137.patch"},"body":"This is a proof-of-concept RELAIS integration for VuFind shared by @mis306lu. See [this document](https://docs.google.com/document/d/1yj2GoKCxjzLE3NGPwh0Eya1DQ5-XcbKqXaHOCdhZaAk/edit) for more details.\r\n\r\nTODO:\r\n- [x] Update Javascript to match current standards (currently not working, as it comes from an earlier version of VuFind with different lightbox functionality)\r\n- [x] Make sure appropriate translation is applied\r\n- [x] Make template changes more conditional (only display when appropriate)\r\n- [x] Refactor code to keep RELAIS-specific logic in a more self-contained place\r\n- [x] Make use of the VuFindHttp\\HttpService\r\n- [x] Make pickup location configurable"},"comment":{"url":"https://api.github.com/repos/vufind-org/vufind/issues/comments/389293524","html_url":"https://github.com/vufind-org/vufind/pull/1137#issuecomment-389293524","issue_url":"https://api.github.com/repos/vufind-org/vufind/issues/1137","id":389293524,"user":{"login":"demiankatz","id":309069,"avatar_url":"https://avatars3.githubusercontent.com/u/309069?v=4","gravatar_id":"","url":"https://api.github.com/users/demiankatz","html_url":"https://github.com/demiankatz","followers_url":"https://api.github.com/users/demiankatz/followers","following_url":"https://api.github.com/users/demiankatz/following{/other_user}","gists_url":"https://api.github.com/users/demiankatz/gists{/gist_id}","starred_url":"https://api.github.com/users/demiankatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/demiankatz/subscriptions","organizations_url":"https://api.github.com/users/demiankatz/orgs","repos_url":"https://api.github.com/users/demiankatz/repos","events_url":"https://api.github.com/users/demiankatz/events{/privacy}","received_events_url":"https://api.github.com/users/demiankatz/received_events","type":"User","site_admin":false},"created_at":"2018-05-15T19:57:02Z","updated_at":"2018-05-15T19:57:02Z","author_association":"MEMBER","body":"@mis306lu, I gave this some more thought and incorporated more of the logic from Villanova's implementation, offering what I think is a best of both worlds approach. Some new changes:\r\n\r\n1.) There is now a Relais/Login action which will redirect a logged in user to Relais using their ILS username. This makes it significantly more convenient to access the service.\r\n\r\n2.) When the initial availability check fails, a Relais search link is now displayed, since I've found that sometimes sending the user to a search link will help get them what they need even if the API fails on its own (this is particularly true when there are multiple hits in the search).\r\n\r\n3.) If you do not provide an API key but you do fill in a symbol and loginUrl, the API code will be ignored but search links will still be displayed -- this offers the existing Villanova solution as an option, in case the slowness of the API is too annoying for people to deal with.\r\n\r\nI think I should be able to merge this very soon, but if you have any thoughts, please let me know!"}}
{"actor":{"display_login":"demiankatz"}}