{"action":"created","comment":{"url":"https://api.github.com/repos/advancedtelematic/ota-tuf/pulls/comments/191414561","pull_request_review_id":123980905,"id":191414561,"diff_hunk":"@@ -82,8 +82,17 @@ class S3TargetStoreEngine(credentials: S3Credentials)(implicit val system: Actor\n       TargetRedirect(Uri(signedUri.toURI.toString))\n     }\n   }\n-}\n \n+  override def delete(repoId: RepoId, filename: TargetFilename): Future[Unit] = {\n+    val storagePath = storageFilename(repoId, filename)","path":"reposerver/src/main/scala/com/advancedtelematic/tuf/reposerver/target_store/S3TargetStoreEngine.scala","position":7,"original_position":7,"commit_id":"99ae290000c9f51b76bd2370bb7d58cf5dafb1a1","original_commit_id":"99ae290000c9f51b76bd2370bb7d58cf5dafb1a1","user":{"login":"jochenschneider","id":4902826,"avatar_url":"https://avatars2.githubusercontent.com/u/4902826?v=4","gravatar_id":"","url":"https://api.github.com/users/jochenschneider","html_url":"https://github.com/jochenschneider","followers_url":"https://api.github.com/users/jochenschneider/followers","following_url":"https://api.github.com/users/jochenschneider/following{/other_user}","gists_url":"https://api.github.com/users/jochenschneider/gists{/gist_id}","starred_url":"https://api.github.com/users/jochenschneider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jochenschneider/subscriptions","organizations_url":"https://api.github.com/users/jochenschneider/orgs","repos_url":"https://api.github.com/users/jochenschneider/repos","events_url":"https://api.github.com/users/jochenschneider/events{/privacy}","received_events_url":"https://api.github.com/users/jochenschneider/received_events","type":"User","site_admin":false},"body":"Would be better for it to return the exception inside the Future, not outside.","created_at":"2018-05-29T13:04:05Z","updated_at":"2018-05-29T13:04:05Z","html_url":"https://github.com/advancedtelematic/ota-tuf/pull/183#discussion_r191414561","pull_request_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/pulls/183","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/advancedtelematic/ota-tuf/pulls/comments/191414561"},"html":{"href":"https://github.com/advancedtelematic/ota-tuf/pull/183#discussion_r191414561"},"pull_request":{"href":"https://api.github.com/repos/advancedtelematic/ota-tuf/pulls/183"}},"in_reply_to_id":191408878},"pull_request":{"url":"https://api.github.com/repos/advancedtelematic/ota-tuf/pulls/183","id":191090531,"html_url":"https://github.com/advancedtelematic/ota-tuf/pull/183","diff_url":"https://github.com/advancedtelematic/ota-tuf/pull/183.diff","patch_url":"https://github.com/advancedtelematic/ota-tuf/pull/183.patch","issue_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/issues/183","number":183,"state":"open","locked":false,"title":"Allow package deletion from online targets","user":{"login":"simao","id":203575,"avatar_url":"https://avatars2.githubusercontent.com/u/203575?v=4","gravatar_id":"","url":"https://api.github.com/users/simao","html_url":"https://github.com/simao","followers_url":"https://api.github.com/users/simao/followers","following_url":"https://api.github.com/users/simao/following{/other_user}","gists_url":"https://api.github.com/users/simao/gists{/gist_id}","starred_url":"https://api.github.com/users/simao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simao/subscriptions","organizations_url":"https://api.github.com/users/simao/orgs","repos_url":"https://api.github.com/users/simao/repos","events_url":"https://api.github.com/users/simao/events{/privacy}","received_events_url":"https://api.github.com/users/simao/received_events","type":"User","site_admin":false},"body":"Fix bug when unmanaged targets were added as managed","created_at":"2018-05-29T09:51:26Z","updated_at":"2018-05-29T13:04:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"59ad3587c4532977241c884a973aca7308fde2be","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/pulls/183/commits","review_comments_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/pulls/183/comments","review_comment_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/issues/183/comments","statuses_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/statuses/99ae290000c9f51b76bd2370bb7d58cf5dafb1a1","head":{"label":"advancedtelematic:feat/PRO-5258/delete_packages","ref":"feat/PRO-5258/delete_packages","sha":"99ae290000c9f51b76bd2370bb7d58cf5dafb1a1","user":{"login":"advancedtelematic","id":7944633,"avatar_url":"https://avatars0.githubusercontent.com/u/7944633?v=4","gravatar_id":"","url":"https://api.github.com/users/advancedtelematic","html_url":"https://github.com/advancedtelematic","followers_url":"https://api.github.com/users/advancedtelematic/followers","following_url":"https://api.github.com/users/advancedtelematic/following{/other_user}","gists_url":"https://api.github.com/users/advancedtelematic/gists{/gist_id}","starred_url":"https://api.github.com/users/advancedtelematic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/advancedtelematic/subscriptions","organizations_url":"https://api.github.com/users/advancedtelematic/orgs","repos_url":"https://api.github.com/users/advancedtelematic/repos","events_url":"https://api.github.com/users/advancedtelematic/events{/privacy}","received_events_url":"https://api.github.com/users/advancedtelematic/received_events","type":"Organization","site_admin":false},"repo":{"id":80709441,"name":"ota-tuf","full_name":"advancedtelematic/ota-tuf","owner":{"login":"advancedtelematic","id":7944633,"avatar_url":"https://avatars0.githubusercontent.com/u/7944633?v=4","gravatar_id":"","url":"https://api.github.com/users/advancedtelematic","html_url":"https://github.com/advancedtelematic","followers_url":"https://api.github.com/users/advancedtelematic/followers","following_url":"https://api.github.com/users/advancedtelematic/following{/other_user}","gists_url":"https://api.github.com/users/advancedtelematic/gists{/gist_id}","starred_url":"https://api.github.com/users/advancedtelematic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/advancedtelematic/subscriptions","organizations_url":"https://api.github.com/users/advancedtelematic/orgs","repos_url":"https://api.github.com/users/advancedtelematic/repos","events_url":"https://api.github.com/users/advancedtelematic/events{/privacy}","received_events_url":"https://api.github.com/users/advancedtelematic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/advancedtelematic/ota-tuf","description":"Scala implementation of TUF repo and tools","fork":false,"url":"https://api.github.com/repos/advancedtelematic/ota-tuf","forks_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/forks","keys_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/teams","hooks_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/hooks","issue_events_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/issues/events{/number}","events_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/events","assignees_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/assignees{/user}","branches_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/branches{/branch}","tags_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/tags","blobs_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/statuses/{sha}","languages_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/languages","stargazers_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/stargazers","contributors_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/contributors","subscribers_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/subscribers","subscription_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/subscription","commits_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/issues/comments{/number}","contents_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/contents/{+path}","compare_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/merges","archive_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/downloads","issues_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/issues{/number}","pulls_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/pulls{/number}","milestones_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/milestones{/number}","notifications_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/labels{/name}","releases_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/releases{/id}","deployments_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/deployments","created_at":"2017-02-02T09:12:40Z","updated_at":"2018-05-29T09:59:16Z","pushed_at":"2018-05-29T12:43:46Z","git_url":"git://github.com/advancedtelematic/ota-tuf.git","ssh_url":"git@github.com:advancedtelematic/ota-tuf.git","clone_url":"https://github.com/advancedtelematic/ota-tuf.git","svn_url":"https://github.com/advancedtelematic/ota-tuf","homepage":"","size":1067,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"advancedtelematic:master","ref":"master","sha":"bd9fd3ce2367c045d7f42d02f249525975fc91a6","user":{"login":"advancedtelematic","id":7944633,"avatar_url":"https://avatars0.githubusercontent.com/u/7944633?v=4","gravatar_id":"","url":"https://api.github.com/users/advancedtelematic","html_url":"https://github.com/advancedtelematic","followers_url":"https://api.github.com/users/advancedtelematic/followers","following_url":"https://api.github.com/users/advancedtelematic/following{/other_user}","gists_url":"https://api.github.com/users/advancedtelematic/gists{/gist_id}","starred_url":"https://api.github.com/users/advancedtelematic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/advancedtelematic/subscriptions","organizations_url":"https://api.github.com/users/advancedtelematic/orgs","repos_url":"https://api.github.com/users/advancedtelematic/repos","events_url":"https://api.github.com/users/advancedtelematic/events{/privacy}","received_events_url":"https://api.github.com/users/advancedtelematic/received_events","type":"Organization","site_admin":false},"repo":{"id":80709441,"name":"ota-tuf","full_name":"advancedtelematic/ota-tuf","owner":{"login":"advancedtelematic","id":7944633,"avatar_url":"https://avatars0.githubusercontent.com/u/7944633?v=4","gravatar_id":"","url":"https://api.github.com/users/advancedtelematic","html_url":"https://github.com/advancedtelematic","followers_url":"https://api.github.com/users/advancedtelematic/followers","following_url":"https://api.github.com/users/advancedtelematic/following{/other_user}","gists_url":"https://api.github.com/users/advancedtelematic/gists{/gist_id}","starred_url":"https://api.github.com/users/advancedtelematic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/advancedtelematic/subscriptions","organizations_url":"https://api.github.com/users/advancedtelematic/orgs","repos_url":"https://api.github.com/users/advancedtelematic/repos","events_url":"https://api.github.com/users/advancedtelematic/events{/privacy}","received_events_url":"https://api.github.com/users/advancedtelematic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/advancedtelematic/ota-tuf","description":"Scala implementation of TUF repo and tools","fork":false,"url":"https://api.github.com/repos/advancedtelematic/ota-tuf","forks_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/forks","keys_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/teams","hooks_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/hooks","issue_events_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/issues/events{/number}","events_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/events","assignees_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/assignees{/user}","branches_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/branches{/branch}","tags_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/tags","blobs_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/statuses/{sha}","languages_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/languages","stargazers_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/stargazers","contributors_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/contributors","subscribers_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/subscribers","subscription_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/subscription","commits_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/issues/comments{/number}","contents_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/contents/{+path}","compare_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/merges","archive_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/downloads","issues_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/issues{/number}","pulls_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/pulls{/number}","milestones_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/milestones{/number}","notifications_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/labels{/name}","releases_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/releases{/id}","deployments_url":"https://api.github.com/repos/advancedtelematic/ota-tuf/deployments","created_at":"2017-02-02T09:12:40Z","updated_at":"2018-05-29T09:59:16Z","pushed_at":"2018-05-29T12:43:46Z","git_url":"git://github.com/advancedtelematic/ota-tuf.git","ssh_url":"git@github.com:advancedtelematic/ota-tuf.git","clone_url":"https://github.com/advancedtelematic/ota-tuf.git","svn_url":"https://github.com/advancedtelematic/ota-tuf","homepage":"","size":1067,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/advancedtelematic/ota-tuf/pulls/183"},"html":{"href":"https://github.com/advancedtelematic/ota-tuf/pull/183"},"issue":{"href":"https://api.github.com/repos/advancedtelematic/ota-tuf/issues/183"},"comments":{"href":"https://api.github.com/repos/advancedtelematic/ota-tuf/issues/183/comments"},"review_comments":{"href":"https://api.github.com/repos/advancedtelematic/ota-tuf/pulls/183/comments"},"review_comment":{"href":"https://api.github.com/repos/advancedtelematic/ota-tuf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/advancedtelematic/ota-tuf/pulls/183/commits"},"statuses":{"href":"https://api.github.com/repos/advancedtelematic/ota-tuf/statuses/99ae290000c9f51b76bd2370bb7d58cf5dafb1a1"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jochenschneider"}}