{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/46917","repository_url":"https://api.github.com/repos/Microsoft/vscode","labels_url":"https://api.github.com/repos/Microsoft/vscode/issues/46917/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/vscode/issues/46917/comments","events_url":"https://api.github.com/repos/Microsoft/vscode/issues/46917/events","html_url":"https://github.com/Microsoft/vscode/issues/46917","id":309683074,"number":46917,"title":"Surveys: listen to model save events instead of generic file events","user":{"login":"bpasero","id":900690,"avatar_url":"https://avatars3.githubusercontent.com/u/900690?v=4","gravatar_id":"","url":"https://api.github.com/users/bpasero","html_url":"https://github.com/bpasero","followers_url":"https://api.github.com/users/bpasero/followers","following_url":"https://api.github.com/users/bpasero/following{/other_user}","gists_url":"https://api.github.com/users/bpasero/gists{/gist_id}","starred_url":"https://api.github.com/users/bpasero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bpasero/subscriptions","organizations_url":"https://api.github.com/users/bpasero/orgs","repos_url":"https://api.github.com/users/bpasero/repos","events_url":"https://api.github.com/users/bpasero/events{/privacy}","received_events_url":"https://api.github.com/users/bpasero/received_events","type":"User","site_admin":false},"labels":[{"id":296418715,"url":"https://api.github.com/repos/Microsoft/vscode/labels/debt","name":"debt","color":"dcdcdc","default":false}],"state":"open","locked":false,"assignee":{"login":"isidorn","id":1926584,"avatar_url":"https://avatars2.githubusercontent.com/u/1926584?v=4","gravatar_id":"","url":"https://api.github.com/users/isidorn","html_url":"https://github.com/isidorn","followers_url":"https://api.github.com/users/isidorn/followers","following_url":"https://api.github.com/users/isidorn/following{/other_user}","gists_url":"https://api.github.com/users/isidorn/gists{/gist_id}","starred_url":"https://api.github.com/users/isidorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isidorn/subscriptions","organizations_url":"https://api.github.com/users/isidorn/orgs","repos_url":"https://api.github.com/users/isidorn/repos","events_url":"https://api.github.com/users/isidorn/events{/privacy}","received_events_url":"https://api.github.com/users/isidorn/received_events","type":"User","site_admin":false},"assignees":[{"login":"isidorn","id":1926584,"avatar_url":"https://avatars2.githubusercontent.com/u/1926584?v=4","gravatar_id":"","url":"https://api.github.com/users/isidorn","html_url":"https://github.com/isidorn","followers_url":"https://api.github.com/users/isidorn/followers","following_url":"https://api.github.com/users/isidorn/following{/other_user}","gists_url":"https://api.github.com/users/isidorn/gists{/gist_id}","starred_url":"https://api.github.com/users/isidorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isidorn/subscriptions","organizations_url":"https://api.github.com/users/isidorn/orgs","repos_url":"https://api.github.com/users/isidorn/repos","events_url":"https://api.github.com/users/isidorn/events{/privacy}","received_events_url":"https://api.github.com/users/isidorn/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-03-29T09:29:19Z","updated_at":"2018-04-13T14:15:31Z","closed_at":null,"author_association":"MEMBER","body":"I would like to reduce our dependency to file events as much as possible and one client seems to be [`languageSurveys.contribution.ts`](https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/surveys/electron-browser/languageSurveys.contribution.ts#L47). Instead of listening for each updated file I suggest to listen to model save events from the [`ITextFileEditorModelManager`](https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/services/textfile/common/textfiles.ts#L155)."},"comment":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/comments/381148986","html_url":"https://github.com/Microsoft/vscode/issues/46917#issuecomment-381148986","issue_url":"https://api.github.com/repos/Microsoft/vscode/issues/46917","id":381148986,"user":{"login":"isidorn","id":1926584,"avatar_url":"https://avatars2.githubusercontent.com/u/1926584?v=4","gravatar_id":"","url":"https://api.github.com/users/isidorn","html_url":"https://github.com/isidorn","followers_url":"https://api.github.com/users/isidorn/followers","following_url":"https://api.github.com/users/isidorn/following{/other_user}","gists_url":"https://api.github.com/users/isidorn/gists{/gist_id}","starred_url":"https://api.github.com/users/isidorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isidorn/subscriptions","organizations_url":"https://api.github.com/users/isidorn/orgs","repos_url":"https://api.github.com/users/isidorn/repos","events_url":"https://api.github.com/users/isidorn/events{/privacy}","received_events_url":"https://api.github.com/users/isidorn/received_events","type":"User","site_admin":false},"created_at":"2018-04-13T14:15:31Z","updated_at":"2018-04-13T14:15:31Z","author_association":"CONTRIBUTOR","body":"@bpasero can you please review my change\r\nfyi @joaomoreno "}}
{"actor":{"display_login":"isidorn"}}