{"action":"closed","number":4093,"pull_request":{"url":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/pulls/4093","id":218705055,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NzA1MDU1","html_url":"https://github.com/canonical-websites/www.ubuntu.com/pull/4093","diff_url":"https://github.com/canonical-websites/www.ubuntu.com/pull/4093.diff","patch_url":"https://github.com/canonical-websites/www.ubuntu.com/pull/4093.patch","issue_url":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/issues/4093","number":4093,"state":"closed","locked":false,"title":"Detect language","user":{"login":"inuwa","id":43535482,"node_id":"MDQ6VXNlcjQzNTM1NDgy","avatar_url":"https://avatars1.githubusercontent.com/u/43535482?v=4","gravatar_id":"","url":"https://api.github.com/users/inuwa","html_url":"https://github.com/inuwa","followers_url":"https://api.github.com/users/inuwa/followers","following_url":"https://api.github.com/users/inuwa/following{/other_user}","gists_url":"https://api.github.com/users/inuwa/gists{/gist_id}","starred_url":"https://api.github.com/users/inuwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inuwa/subscriptions","organizations_url":"https://api.github.com/users/inuwa/orgs","repos_url":"https://api.github.com/users/inuwa/repos","events_url":"https://api.github.com/users/inuwa/events{/privacy}","received_events_url":"https://api.github.com/users/inuwa/received_events","type":"User","site_admin":false},"body":"## Done\r\nTakeovers now change based on the users browser default language. Takeovers are now only display for a particular region based on the language detected on the browser.\r\n## QA\r\n\r\n- Check out this feature branch\r\n- Run the site using the command `./run serve`\r\n- View the site locally in your web browser at: [http://0.0.0.0:8001/](http://0.0.0.0:8001/)\r\n- Run through the following [QA steps](https://github.com/canonical-webteam/practices/blob/master/workflow/qa-steps.md)\r\n- Changed the default browser language to German (Deustche) or German\r\n- Refresh the multiple times to German Takeover\r\n\r\n\r\n## Issue / Card\r\nFixes #4081 \r\n\r\n## Screenshots","created_at":"2018-09-27T15:55:12Z","updated_at":"2018-10-01T10:32:36Z","closed_at":"2018-10-01T10:32:36Z","merged_at":"2018-10-01T10:32:35Z","merge_commit_sha":"180630cf419062eddffb361f07d6e7e1b359a954","assignee":{"login":"anthonydillon","id":1413534,"node_id":"MDQ6VXNlcjE0MTM1MzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1413534?v=4","gravatar_id":"","url":"https://api.github.com/users/anthonydillon","html_url":"https://github.com/anthonydillon","followers_url":"https://api.github.com/users/anthonydillon/followers","following_url":"https://api.github.com/users/anthonydillon/following{/other_user}","gists_url":"https://api.github.com/users/anthonydillon/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonydillon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonydillon/subscriptions","organizations_url":"https://api.github.com/users/anthonydillon/orgs","repos_url":"https://api.github.com/users/anthonydillon/repos","events_url":"https://api.github.com/users/anthonydillon/events{/privacy}","received_events_url":"https://api.github.com/users/anthonydillon/received_events","type":"User","site_admin":false},"assignees":[{"login":"anthonydillon","id":1413534,"node_id":"MDQ6VXNlcjE0MTM1MzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1413534?v=4","gravatar_id":"","url":"https://api.github.com/users/anthonydillon","html_url":"https://github.com/anthonydillon","followers_url":"https://api.github.com/users/anthonydillon/followers","following_url":"https://api.github.com/users/anthonydillon/following{/other_user}","gists_url":"https://api.github.com/users/anthonydillon/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonydillon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonydillon/subscriptions","organizations_url":"https://api.github.com/users/anthonydillon/orgs","repos_url":"https://api.github.com/users/anthonydillon/repos","events_url":"https://api.github.com/users/anthonydillon/events{/privacy}","received_events_url":"https://api.github.com/users/anthonydillon/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":382162956,"node_id":"MDU6TGFiZWwzODIxNjI5NTY=","url":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/labels/Review:%20Code%20+1","name":"Review: Code +1","color":"38b44a","default":false},{"id":382162943,"node_id":"MDU6TGFiZWwzODIxNjI5NDM=","url":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/labels/Review:%20QA%20+1","name":"Review: QA +1","color":"38b44a","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/pulls/4093/commits","review_comments_url":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/pulls/4093/comments","review_comment_url":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/pulls/comments{/number}","comments_url":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/issues/4093/comments","statuses_url":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/statuses/3b46daf759d98c03ca23215bd02956b84e77c41b","head":{"label":"inuwa:detect-language","ref":"detect-language","sha":"3b46daf759d98c03ca23215bd02956b84e77c41b","user":{"login":"inuwa","id":43535482,"node_id":"MDQ6VXNlcjQzNTM1NDgy","avatar_url":"https://avatars1.githubusercontent.com/u/43535482?v=4","gravatar_id":"","url":"https://api.github.com/users/inuwa","html_url":"https://github.com/inuwa","followers_url":"https://api.github.com/users/inuwa/followers","following_url":"https://api.github.com/users/inuwa/following{/other_user}","gists_url":"https://api.github.com/users/inuwa/gists{/gist_id}","starred_url":"https://api.github.com/users/inuwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inuwa/subscriptions","organizations_url":"https://api.github.com/users/inuwa/orgs","repos_url":"https://api.github.com/users/inuwa/repos","events_url":"https://api.github.com/users/inuwa/events{/privacy}","received_events_url":"https://api.github.com/users/inuwa/received_events","type":"User","site_admin":false},"repo":{"id":150224921,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAyMjQ5MjE=","name":"www.ubuntu.com","full_name":"inuwa/www.ubuntu.com","private":false,"owner":{"login":"inuwa","id":43535482,"node_id":"MDQ6VXNlcjQzNTM1NDgy","avatar_url":"https://avatars1.githubusercontent.com/u/43535482?v=4","gravatar_id":"","url":"https://api.github.com/users/inuwa","html_url":"https://github.com/inuwa","followers_url":"https://api.github.com/users/inuwa/followers","following_url":"https://api.github.com/users/inuwa/following{/other_user}","gists_url":"https://api.github.com/users/inuwa/gists{/gist_id}","starred_url":"https://api.github.com/users/inuwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inuwa/subscriptions","organizations_url":"https://api.github.com/users/inuwa/orgs","repos_url":"https://api.github.com/users/inuwa/repos","events_url":"https://api.github.com/users/inuwa/events{/privacy}","received_events_url":"https://api.github.com/users/inuwa/received_events","type":"User","site_admin":false},"html_url":"https://github.com/inuwa/www.ubuntu.com","description":"Ubuntu website project using Vanilla Framework","fork":true,"url":"https://api.github.com/repos/inuwa/www.ubuntu.com","forks_url":"https://api.github.com/repos/inuwa/www.ubuntu.com/forks","keys_url":"https://api.github.com/repos/inuwa/www.ubuntu.com/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inuwa/www.ubuntu.com/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inuwa/www.ubuntu.com/teams","hooks_url":"https://api.github.com/repos/inuwa/www.ubuntu.com/hooks","issue_events_url":"https://api.github.com/repos/inuwa/www.ubuntu.com/issues/events{/number}","events_url":"https://api.github.com/repos/inuwa/www.ubuntu.com/events","assignees_url":"https://api.github.com/repos/inuwa/www.ubuntu.com/assignees{/user}","branches_url":"https://api.github.com/repos/inuwa/www.ubuntu.com/branches{/branch}","tags_url":"https://api.github.com/repos/inuwa/www.ubuntu.com/tags","blobs_url":"https://api.github.com/repos/inuwa/www.ubuntu.com/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inuwa/www.ubuntu.com/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inuwa/www.ubuntu.com/git/refs{/sha}","trees_url":"https://api.github.com/repos/inuwa/www.ubuntu.com/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inuwa/www.ubuntu.com/statuses/{sha}","languages_url":"https://api.github.com/repos/inuwa/www.ubuntu.com/languages","stargazers_url":"https://api.github.com/repos/inuwa/www.ubuntu.com/stargazers","contributors_url":"https://api.github.com/repos/inuwa/www.ubuntu.com/contributors","subscribers_url":"https://api.github.com/repos/inuwa/www.ubuntu.com/subscribers","subscription_url":"https://api.github.com/repos/inuwa/www.ubuntu.com/subscription","commits_url":"https://api.github.com/repos/inuwa/www.ubuntu.com/commits{/sha}","git_commits_url":"https://api.github.com/repos/inuwa/www.ubuntu.com/git/commits{/sha}","comments_url":"https://api.github.com/repos/inuwa/www.ubuntu.com/comments{/number}","issue_comment_url":"https://api.github.com/repos/inuwa/www.ubuntu.com/issues/comments{/number}","contents_url":"https://api.github.com/repos/inuwa/www.ubuntu.com/contents/{+path}","compare_url":"https://api.github.com/repos/inuwa/www.ubuntu.com/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inuwa/www.ubuntu.com/merges","archive_url":"https://api.github.com/repos/inuwa/www.ubuntu.com/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inuwa/www.ubuntu.com/downloads","issues_url":"https://api.github.com/repos/inuwa/www.ubuntu.com/issues{/number}","pulls_url":"https://api.github.com/repos/inuwa/www.ubuntu.com/pulls{/number}","milestones_url":"https://api.github.com/repos/inuwa/www.ubuntu.com/milestones{/number}","notifications_url":"https://api.github.com/repos/inuwa/www.ubuntu.com/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inuwa/www.ubuntu.com/labels{/name}","releases_url":"https://api.github.com/repos/inuwa/www.ubuntu.com/releases{/id}","deployments_url":"https://api.github.com/repos/inuwa/www.ubuntu.com/deployments","created_at":"2018-09-25T07:30:35Z","updated_at":"2018-09-27T12:29:12Z","pushed_at":"2018-10-01T10:19:33Z","git_url":"git://github.com/inuwa/www.ubuntu.com.git","ssh_url":"git@github.com:inuwa/www.ubuntu.com.git","clone_url":"https://github.com/inuwa/www.ubuntu.com.git","svn_url":"https://github.com/inuwa/www.ubuntu.com","homepage":"http://www.ubuntu.com","size":10072,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"canonical-websites:master","ref":"master","sha":"54b0911780ab0ba86d7064ccc0c3eab471957f63","user":{"login":"canonical-websites","id":26072773,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MDcyNzcz","avatar_url":"https://avatars2.githubusercontent.com/u/26072773?v=4","gravatar_id":"","url":"https://api.github.com/users/canonical-websites","html_url":"https://github.com/canonical-websites","followers_url":"https://api.github.com/users/canonical-websites/followers","following_url":"https://api.github.com/users/canonical-websites/following{/other_user}","gists_url":"https://api.github.com/users/canonical-websites/gists{/gist_id}","starred_url":"https://api.github.com/users/canonical-websites/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canonical-websites/subscriptions","organizations_url":"https://api.github.com/users/canonical-websites/orgs","repos_url":"https://api.github.com/users/canonical-websites/repos","events_url":"https://api.github.com/users/canonical-websites/events{/privacy}","received_events_url":"https://api.github.com/users/canonical-websites/received_events","type":"Organization","site_admin":false},"repo":{"id":23468646,"node_id":"MDEwOlJlcG9zaXRvcnkyMzQ2ODY0Ng==","name":"www.ubuntu.com","full_name":"canonical-websites/www.ubuntu.com","private":false,"owner":{"login":"canonical-websites","id":26072773,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MDcyNzcz","avatar_url":"https://avatars2.githubusercontent.com/u/26072773?v=4","gravatar_id":"","url":"https://api.github.com/users/canonical-websites","html_url":"https://github.com/canonical-websites","followers_url":"https://api.github.com/users/canonical-websites/followers","following_url":"https://api.github.com/users/canonical-websites/following{/other_user}","gists_url":"https://api.github.com/users/canonical-websites/gists{/gist_id}","starred_url":"https://api.github.com/users/canonical-websites/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canonical-websites/subscriptions","organizations_url":"https://api.github.com/users/canonical-websites/orgs","repos_url":"https://api.github.com/users/canonical-websites/repos","events_url":"https://api.github.com/users/canonical-websites/events{/privacy}","received_events_url":"https://api.github.com/users/canonical-websites/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/canonical-websites/www.ubuntu.com","description":"Ubuntu website project using Vanilla Framework","fork":false,"url":"https://api.github.com/repos/canonical-websites/www.ubuntu.com","forks_url":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/forks","keys_url":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/keys{/key_id}","collaborators_url":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/teams","hooks_url":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/hooks","issue_events_url":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/issues/events{/number}","events_url":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/events","assignees_url":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/assignees{/user}","branches_url":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/branches{/branch}","tags_url":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/tags","blobs_url":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/git/refs{/sha}","trees_url":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/git/trees{/sha}","statuses_url":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/statuses/{sha}","languages_url":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/languages","stargazers_url":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/stargazers","contributors_url":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/contributors","subscribers_url":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/subscribers","subscription_url":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/subscription","commits_url":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/commits{/sha}","git_commits_url":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/git/commits{/sha}","comments_url":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/comments{/number}","issue_comment_url":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/issues/comments{/number}","contents_url":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/contents/{+path}","compare_url":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/compare/{base}...{head}","merges_url":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/merges","archive_url":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/downloads","issues_url":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/issues{/number}","pulls_url":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/pulls{/number}","milestones_url":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/milestones{/number}","notifications_url":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/labels{/name}","releases_url":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/releases{/id}","deployments_url":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/deployments","created_at":"2014-08-29T15:34:24Z","updated_at":"2018-09-27T13:52:51Z","pushed_at":"2018-10-01T10:32:35Z","git_url":"git://github.com/canonical-websites/www.ubuntu.com.git","ssh_url":"git@github.com:canonical-websites/www.ubuntu.com.git","clone_url":"https://github.com/canonical-websites/www.ubuntu.com.git","svn_url":"https://github.com/canonical-websites/www.ubuntu.com","homepage":"http://www.ubuntu.com","size":10056,"stargazers_count":34,"watchers_count":34,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":104,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":39,"open_issues":104,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/pulls/4093"},"html":{"href":"https://github.com/canonical-websites/www.ubuntu.com/pull/4093"},"issue":{"href":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/issues/4093"},"comments":{"href":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/issues/4093/comments"},"review_comments":{"href":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/pulls/4093/comments"},"review_comment":{"href":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/pulls/4093/commits"},"statuses":{"href":"https://api.github.com/repos/canonical-websites/www.ubuntu.com/statuses/3b46daf759d98c03ca23215bd02956b84e77c41b"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"anthonydillon","id":1413534,"node_id":"MDQ6VXNlcjE0MTM1MzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1413534?v=4","gravatar_id":"","url":"https://api.github.com/users/anthonydillon","html_url":"https://github.com/anthonydillon","followers_url":"https://api.github.com/users/anthonydillon/followers","following_url":"https://api.github.com/users/anthonydillon/following{/other_user}","gists_url":"https://api.github.com/users/anthonydillon/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonydillon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonydillon/subscriptions","organizations_url":"https://api.github.com/users/anthonydillon/orgs","repos_url":"https://api.github.com/users/anthonydillon/repos","events_url":"https://api.github.com/users/anthonydillon/events{/privacy}","received_events_url":"https://api.github.com/users/anthonydillon/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":6,"additions":102,"deletions":46,"changed_files":12}}
{"actor":{"display_login":"anthonydillon"}}