{"action":"opened","number":7648,"pull_request":{"url":"https://api.github.com/repos/elastic/beats/pulls/7648","id":202717514,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNzE3NTE0","html_url":"https://github.com/elastic/beats/pull/7648","diff_url":"https://github.com/elastic/beats/pull/7648.diff","patch_url":"https://github.com/elastic/beats/pull/7648.patch","issue_url":"https://api.github.com/repos/elastic/beats/issues/7648","number":7648,"state":"open","locked":false,"title":"Additional HB Tests + Improved mapval","user":{"login":"andrewvc","id":131427,"node_id":"MDQ6VXNlcjEzMTQyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/131427?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false},"body":"This adds a number of new tests to heartbeat\r\n\r\n1. Testing the full range of HTTP codes\r\n2. Testing both connection refused *and* unroutable endpoints for both TCP and HTTP\r\n3. Makes various ergonomic and functional improvements to mapval discovered in the course of writing the above tests.\r\n4. Adds the `freeport` dep via govendor. This nifty little lib will spit out a free local port you can use for testing.\r\n\r\nI attempted to add some ICMP tests, but that will be a little tricky since you need escalated privileges. There's certainly a good way to add those, but I think that's deserving of its own PR. ","created_at":"2018-07-20T00:28:33Z","updated_at":"2018-07-20T00:28:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":364269915,"node_id":"MDU6TGFiZWwzNjQyNjk5MTU=","url":"https://api.github.com/repos/elastic/beats/labels/:Testing","name":":Testing","color":"ffffff","default":false},{"id":459123149,"node_id":"MDU6TGFiZWw0NTkxMjMxNDk=","url":"https://api.github.com/repos/elastic/beats/labels/Heartbeat","name":"Heartbeat","color":"008000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/beats/pulls/7648/commits","review_comments_url":"https://api.github.com/repos/elastic/beats/pulls/7648/comments","review_comment_url":"https://api.github.com/repos/elastic/beats/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/beats/issues/7648/comments","statuses_url":"https://api.github.com/repos/elastic/beats/statuses/351cf53fbb859ae5a80f9597287ee932df0f9bc3","head":{"label":"andrewvc:additional-hb-tests","ref":"additional-hb-tests","sha":"351cf53fbb859ae5a80f9597287ee932df0f9bc3","user":{"login":"andrewvc","id":131427,"node_id":"MDQ6VXNlcjEzMTQyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/131427?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false},"repo":{"id":119769836,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk3Njk4MzY=","name":"beats","full_name":"andrewvc/beats","owner":{"login":"andrewvc","id":131427,"node_id":"MDQ6VXNlcjEzMTQyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/131427?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrewvc/beats","description":":tropical_fish: Beats - Lightweight shippers for Elasticsearch & Logstash ","fork":true,"url":"https://api.github.com/repos/andrewvc/beats","forks_url":"https://api.github.com/repos/andrewvc/beats/forks","keys_url":"https://api.github.com/repos/andrewvc/beats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrewvc/beats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrewvc/beats/teams","hooks_url":"https://api.github.com/repos/andrewvc/beats/hooks","issue_events_url":"https://api.github.com/repos/andrewvc/beats/issues/events{/number}","events_url":"https://api.github.com/repos/andrewvc/beats/events","assignees_url":"https://api.github.com/repos/andrewvc/beats/assignees{/user}","branches_url":"https://api.github.com/repos/andrewvc/beats/branches{/branch}","tags_url":"https://api.github.com/repos/andrewvc/beats/tags","blobs_url":"https://api.github.com/repos/andrewvc/beats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrewvc/beats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrewvc/beats/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrewvc/beats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrewvc/beats/statuses/{sha}","languages_url":"https://api.github.com/repos/andrewvc/beats/languages","stargazers_url":"https://api.github.com/repos/andrewvc/beats/stargazers","contributors_url":"https://api.github.com/repos/andrewvc/beats/contributors","subscribers_url":"https://api.github.com/repos/andrewvc/beats/subscribers","subscription_url":"https://api.github.com/repos/andrewvc/beats/subscription","commits_url":"https://api.github.com/repos/andrewvc/beats/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrewvc/beats/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrewvc/beats/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrewvc/beats/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrewvc/beats/contents/{+path}","compare_url":"https://api.github.com/repos/andrewvc/beats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrewvc/beats/merges","archive_url":"https://api.github.com/repos/andrewvc/beats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrewvc/beats/downloads","issues_url":"https://api.github.com/repos/andrewvc/beats/issues{/number}","pulls_url":"https://api.github.com/repos/andrewvc/beats/pulls{/number}","milestones_url":"https://api.github.com/repos/andrewvc/beats/milestones{/number}","notifications_url":"https://api.github.com/repos/andrewvc/beats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrewvc/beats/labels{/name}","releases_url":"https://api.github.com/repos/andrewvc/beats/releases{/id}","deployments_url":"https://api.github.com/repos/andrewvc/beats/deployments","created_at":"2018-02-01T02:11:47Z","updated_at":"2018-02-01T02:11:55Z","pushed_at":"2018-07-20T00:25:45Z","git_url":"git://github.com/andrewvc/beats.git","ssh_url":"git@github.com:andrewvc/beats.git","clone_url":"https://github.com/andrewvc/beats.git","svn_url":"https://github.com/andrewvc/beats","homepage":"https://www.elastic.co/products/beats","size":83862,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"e5791d2b6f715c9eaa32581f28b5fa6406bb727e","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":16554739,"node_id":"MDEwOlJlcG9zaXRvcnkxNjU1NDczOQ==","name":"beats","full_name":"elastic/beats","owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/beats","description":":tropical_fish: Beats - Lightweight shippers for Elasticsearch & Logstash ","fork":false,"url":"https://api.github.com/repos/elastic/beats","forks_url":"https://api.github.com/repos/elastic/beats/forks","keys_url":"https://api.github.com/repos/elastic/beats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/beats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/beats/teams","hooks_url":"https://api.github.com/repos/elastic/beats/hooks","issue_events_url":"https://api.github.com/repos/elastic/beats/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/beats/events","assignees_url":"https://api.github.com/repos/elastic/beats/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/beats/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/beats/tags","blobs_url":"https://api.github.com/repos/elastic/beats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/beats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/beats/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/beats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/beats/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/beats/languages","stargazers_url":"https://api.github.com/repos/elastic/beats/stargazers","contributors_url":"https://api.github.com/repos/elastic/beats/contributors","subscribers_url":"https://api.github.com/repos/elastic/beats/subscribers","subscription_url":"https://api.github.com/repos/elastic/beats/subscription","commits_url":"https://api.github.com/repos/elastic/beats/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/beats/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/beats/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/beats/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/beats/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/beats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/beats/merges","archive_url":"https://api.github.com/repos/elastic/beats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/beats/downloads","issues_url":"https://api.github.com/repos/elastic/beats/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/beats/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/beats/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/beats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/beats/labels{/name}","releases_url":"https://api.github.com/repos/elastic/beats/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/beats/deployments","created_at":"2014-02-05T19:01:02Z","updated_at":"2018-07-19T19:43:57Z","pushed_at":"2018-07-19T22:43:12Z","git_url":"git://github.com/elastic/beats.git","ssh_url":"git@github.com:elastic/beats.git","clone_url":"https://github.com/elastic/beats.git","svn_url":"https://github.com/elastic/beats","homepage":"https://www.elastic.co/products/beats","size":84490,"stargazers_count":5837,"watchers_count":5837,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1799,"mirror_url":null,"archived":false,"open_issues_count":837,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1799,"open_issues":837,"watchers":5837,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/beats/pulls/7648"},"html":{"href":"https://github.com/elastic/beats/pull/7648"},"issue":{"href":"https://api.github.com/repos/elastic/beats/issues/7648"},"comments":{"href":"https://api.github.com/repos/elastic/beats/issues/7648/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/beats/pulls/7648/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/beats/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/beats/pulls/7648/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/beats/statuses/351cf53fbb859ae5a80f9597287ee932df0f9bc3"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":5,"additions":476,"deletions":108,"changed_files":14}}
{"actor":{"display_login":"andrewvc"}}