{"action":"created","issue":{"url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/9044","repository_url":"https://api.github.com/repos/ParadiseSS13/Paradise","labels_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/9044/labels{/name}","comments_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/9044/comments","events_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/9044/events","html_url":"https://github.com/ParadiseSS13/Paradise/pull/9044","id":324696849,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg5MjI2Nzgx","number":9044,"title":"Refactors Camera Damage and Disabling","user":{"login":"Fox-McCloud","id":5785200,"node_id":"MDQ6VXNlcjU3ODUyMDA=","avatar_url":"https://avatars1.githubusercontent.com/u/5785200?v=4","gravatar_id":"","url":"https://api.github.com/users/Fox-McCloud","html_url":"https://github.com/Fox-McCloud","followers_url":"https://api.github.com/users/Fox-McCloud/followers","following_url":"https://api.github.com/users/Fox-McCloud/following{/other_user}","gists_url":"https://api.github.com/users/Fox-McCloud/gists{/gist_id}","starred_url":"https://api.github.com/users/Fox-McCloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fox-McCloud/subscriptions","organizations_url":"https://api.github.com/users/Fox-McCloud/orgs","repos_url":"https://api.github.com/users/Fox-McCloud/repos","events_url":"https://api.github.com/users/Fox-McCloud/events{/privacy}","received_events_url":"https://api.github.com/users/Fox-McCloud/received_events","type":"User","site_admin":false},"labels":[{"id":176235538,"node_id":"MDU6TGFiZWwxNzYyMzU1Mzg=","url":"https://api.github.com/repos/ParadiseSS13/Paradise/labels/Fix","name":"Fix","color":"26C5E2","default":false},{"id":176235945,"node_id":"MDU6TGFiZWwxNzYyMzU5NDU=","url":"https://api.github.com/repos/ParadiseSS13/Paradise/labels/Refactor","name":"Refactor","color":"FFB626","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":24,"created_at":"2018-05-20T09:48:30Z","updated_at":"2018-06-04T00:00:57Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/9044","html_url":"https://github.com/ParadiseSS13/Paradise/pull/9044","diff_url":"https://github.com/ParadiseSS13/Paradise/pull/9044.diff","patch_url":"https://github.com/ParadiseSS13/Paradise/pull/9044.patch"},"body":"This was supposed to be a simple PR, but no, nothing is ever easy.\r\n\r\nPorts over cameras to the object damage system and alters how you enable/disable them.\r\n\r\nActual changes\r\n- Can deactivate and destroy cameras with objects that have a force of above 12\r\n- Instead of utilizing wires to enable/disable cameras, it's merely screwing the panel open/closed and using wirecutters on them or a multitool to change focus. \r\n- Removes arbitrary limit on not being able to use hand labelers on reagent containers\r\n\r\n:cl: Fox McCloud\r\nfix: Fixes hand labelers not being able to label storage objects\r\nadd: Cameras can now be destroyed with weapons that have a force of 12 or greater\r\ntweak: Cameras no longer have wires; merely screw the panel open, then use wirecutters to enable/disable them or use a multitool to alter focus\r\ntweak: You can use hand labelers on reagent containers now\r\n/:cl:\r\n"},"comment":{"url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/comments/394202790","html_url":"https://github.com/ParadiseSS13/Paradise/pull/9044#issuecomment-394202790","issue_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/9044","id":394202790,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDIwMjc5MA==","user":{"login":"Fox-McCloud","id":5785200,"node_id":"MDQ6VXNlcjU3ODUyMDA=","avatar_url":"https://avatars1.githubusercontent.com/u/5785200?v=4","gravatar_id":"","url":"https://api.github.com/users/Fox-McCloud","html_url":"https://github.com/Fox-McCloud","followers_url":"https://api.github.com/users/Fox-McCloud/followers","following_url":"https://api.github.com/users/Fox-McCloud/following{/other_user}","gists_url":"https://api.github.com/users/Fox-McCloud/gists{/gist_id}","starred_url":"https://api.github.com/users/Fox-McCloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fox-McCloud/subscriptions","organizations_url":"https://api.github.com/users/Fox-McCloud/orgs","repos_url":"https://api.github.com/users/Fox-McCloud/repos","events_url":"https://api.github.com/users/Fox-McCloud/events{/privacy}","received_events_url":"https://api.github.com/users/Fox-McCloud/received_events","type":"User","site_admin":false},"created_at":"2018-06-04T00:00:57Z","updated_at":"2018-06-04T00:00:57Z","author_association":"MEMBER","body":">You can already label them with a pen, and that seems like such a random change to bundle into this PR. Mind explaining the reasoning on why that was included here?\r\n\r\nYeah, it's actually rather silly. In order to get sections of this code working, I had to pretty much ensure a lot of things returned the value of `attackby` to parent. This naturally meant that I had to touch `/obj/item/storage`, which made some problems obvious, like the hand labeler, which necessitated me changing the hand labeler's code, directly too--upon which I noticed some bad bode and inconsistencies...then I noticed, that for whatever reason, explicitly, reagent containers were snowflake exempted, soooo just went ahead and removed that in the cleanup."}}
{"actor":{"display_login":"Fox-McCloud"}}