{"action":"created","issue":{"url":"https://api.github.com/repos/mercadolibre/fury_mobile-ios-ui/issues/21","repository_url":"https://api.github.com/repos/mercadolibre/fury_mobile-ios-ui","labels_url":"https://api.github.com/repos/mercadolibre/fury_mobile-ios-ui/issues/21/labels{/name}","comments_url":"https://api.github.com/repos/mercadolibre/fury_mobile-ios-ui/issues/21/comments","events_url":"https://api.github.com/repos/mercadolibre/fury_mobile-ios-ui/issues/21/events","html_url":"https://github.com/mercadolibre/fury_mobile-ios-ui/pull/21","id":382477241,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMTc1ODU0","number":21,"title":"[WIP] 🛠  Fix `MLTitledMultiLineTextField` ignores delegate","user":{"login":"x0000ff","id":1062240,"node_id":"MDQ6VXNlcjEwNjIyNDA=","avatar_url":"https://avatars3.githubusercontent.com/u/1062240?v=4","gravatar_id":"","url":"https://api.github.com/users/x0000ff","html_url":"https://github.com/x0000ff","followers_url":"https://api.github.com/users/x0000ff/followers","following_url":"https://api.github.com/users/x0000ff/following{/other_user}","gists_url":"https://api.github.com/users/x0000ff/gists{/gist_id}","starred_url":"https://api.github.com/users/x0000ff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/x0000ff/subscriptions","organizations_url":"https://api.github.com/users/x0000ff/orgs","repos_url":"https://api.github.com/users/x0000ff/repos","events_url":"https://api.github.com/users/x0000ff/events{/privacy}","received_events_url":"https://api.github.com/users/x0000ff/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-20T02:49:58Z","updated_at":"2018-12-11T19:21:59Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/mercadolibre/fury_mobile-ios-ui/pulls/21","html_url":"https://github.com/mercadolibre/fury_mobile-ios-ui/pull/21","diff_url":"https://github.com/mercadolibre/fury_mobile-ios-ui/pull/21.diff","patch_url":"https://github.com/mercadolibre/fury_mobile-ios-ui/pull/21.patch"},"body":"This PR fixes bug when delegate of `MLTitledMultiLineTextField` returns `NO` in method `textField: shouldChangeCharactersInRange: replacementString:`.\r\n\r\n`MLTitledMultiLineTextField` just ignores its result:\r\n\r\n```obj-c\r\nif ([self.delegate respondsToSelector:@selector(textField:shouldChangeCharactersInRange:replacementString:)]) {\r\n   [self.delegate textField:self shouldChangeCharactersInRange:range replacementString:text];\r\n}\r\n```\r\n\r\n| Before | After |\r\n|---|---|\r\n| ![before](https://user-images.githubusercontent.com/1062240/48750578-8a873d80-ec5e-11e8-94ad-8d516f749eaf.gif) | ![after](https://user-images.githubusercontent.com/1062240/48750579-8a873d80-ec5e-11e8-8c64-a4affa4fb625.gif) |\r\n\r\n## How to test?\r\n\r\nApply this [patch.diff.txt](https://github.com/mercadolibre/fury_mobile-ios-ui/files/2598008/patch.diff.txt) and repeat steps from gifs above"},"comment":{"url":"https://api.github.com/repos/mercadolibre/fury_mobile-ios-ui/issues/comments/446327999","html_url":"https://github.com/mercadolibre/fury_mobile-ios-ui/pull/21#issuecomment-446327999","issue_url":"https://api.github.com/repos/mercadolibre/fury_mobile-ios-ui/issues/21","id":446327999,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjMyNzk5OQ==","user":{"login":"x0000ff","id":1062240,"node_id":"MDQ6VXNlcjEwNjIyNDA=","avatar_url":"https://avatars3.githubusercontent.com/u/1062240?v=4","gravatar_id":"","url":"https://api.github.com/users/x0000ff","html_url":"https://github.com/x0000ff","followers_url":"https://api.github.com/users/x0000ff/followers","following_url":"https://api.github.com/users/x0000ff/following{/other_user}","gists_url":"https://api.github.com/users/x0000ff/gists{/gist_id}","starred_url":"https://api.github.com/users/x0000ff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/x0000ff/subscriptions","organizations_url":"https://api.github.com/users/x0000ff/orgs","repos_url":"https://api.github.com/users/x0000ff/repos","events_url":"https://api.github.com/users/x0000ff/events{/privacy}","received_events_url":"https://api.github.com/users/x0000ff/received_events","type":"User","site_admin":false},"created_at":"2018-12-11T19:21:59Z","updated_at":"2018-12-11T19:21:59Z","author_association":"CONTRIBUTOR","body":"@nsuarezmeli, Nico, lint fallo por archivos que no he tocado. ¿Podrías darle `Rerun`? 🙏 No tengo permiso ;)\r\n\r\nhttps://circleci.com/gh/mercadolibre/fury_mobile-ios-ui/134?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link\r\n\r\n<img width=\"1552\" alt=\"screen shot 2018-12-11 at 16 19 21\" src=\"https://user-images.githubusercontent.com/1062240/49824293-8bdcef00-fd60-11e8-97a7-a96bc4a92f75.png\">\r\n"}}
{"actor":{"display_login":"x0000ff"}}