{"action":"created","comment":{"url":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/pulls/comments/225531901","pull_request_review_id":165149697,"id":225531901,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTUzMTkwMQ==","diff_hunk":"@@ -160,45 +145,38 @@ Initialise the marginal log-likelihood of Gaussian process `gp`.\n function initialise_mll!(gp::GPE{X,Y,M,K,P,D}) where {X,Y,M,K,P,D}\n     μ = mean(gp.mean,gp.x)\n     Σ = cov(gp.kernel, gp.x, gp.data)\n-    gp.cK = P.name.wrapper(Σ + (exp(2*gp.logNoise) + 1e-5)*I)\n+    gp.cK = init_cK(P, Σ + (exp(2*gp.logNoise) + 1e-5)*I)","path":"src/GPE.jl","position":74,"original_position":27,"commit_id":"e8e57a452ddb354147e240dd080aaef4b9130e31","original_commit_id":"e8e57a452ddb354147e240dd080aaef4b9130e31","user":{"login":"maximerischard","id":328831,"node_id":"MDQ6VXNlcjMyODgzMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/328831?v=4","gravatar_id":"","url":"https://api.github.com/users/maximerischard","html_url":"https://github.com/maximerischard","followers_url":"https://api.github.com/users/maximerischard/followers","following_url":"https://api.github.com/users/maximerischard/following{/other_user}","gists_url":"https://api.github.com/users/maximerischard/gists{/gist_id}","starred_url":"https://api.github.com/users/maximerischard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximerischard/subscriptions","organizations_url":"https://api.github.com/users/maximerischard/orgs","repos_url":"https://api.github.com/users/maximerischard/repos","events_url":"https://api.github.com/users/maximerischard/events{/privacy}","received_events_url":"https://api.github.com/users/maximerischard/received_events","type":"User","site_admin":false},"body":"Yes, that's pretty much what I meant. I would have liked there to be a sensible default for `AbstractPDMat`, but it doesn't seem easy to do so elegantly.\r\n\r\nI think your dislike of the `1e-5` default is widely shared. See #86.","created_at":"2018-10-16T13:11:42Z","updated_at":"2018-10-16T13:11:42Z","html_url":"https://github.com/STOR-i/GaussianProcesses.jl/pull/93#discussion_r225531901","pull_request_url":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/pulls/93","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/pulls/comments/225531901"},"html":{"href":"https://github.com/STOR-i/GaussianProcesses.jl/pull/93#discussion_r225531901"},"pull_request":{"href":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/pulls/93"}},"in_reply_to_id":224608782},"pull_request":{"url":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/pulls/93","id":221497941,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNDk3OTQx","html_url":"https://github.com/STOR-i/GaussianProcesses.jl/pull/93","diff_url":"https://github.com/STOR-i/GaussianProcesses.jl/pull/93.diff","patch_url":"https://github.com/STOR-i/GaussianProcesses.jl/pull/93.patch","issue_url":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/issues/93","number":93,"state":"open","locked":false,"title":"WIP: elastic GPE","user":{"login":"jbrea","id":12857162,"node_id":"MDQ6VXNlcjEyODU3MTYy","avatar_url":"https://avatars1.githubusercontent.com/u/12857162?v=4","gravatar_id":"","url":"https://api.github.com/users/jbrea","html_url":"https://github.com/jbrea","followers_url":"https://api.github.com/users/jbrea/followers","following_url":"https://api.github.com/users/jbrea/following{/other_user}","gists_url":"https://api.github.com/users/jbrea/gists{/gist_id}","starred_url":"https://api.github.com/users/jbrea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbrea/subscriptions","organizations_url":"https://api.github.com/users/jbrea/orgs","repos_url":"https://api.github.com/users/jbrea/repos","events_url":"https://api.github.com/users/jbrea/events{/privacy}","received_events_url":"https://api.github.com/users/jbrea/received_events","type":"User","site_admin":false},"body":"Here is a first attempt of elastic GPE's.","created_at":"2018-10-09T16:03:46Z","updated_at":"2018-10-16T13:11:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e30bb8bfa2977a7a21d2820fb1aebe6bde9d702f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/pulls/93/commits","review_comments_url":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/pulls/93/comments","review_comment_url":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/issues/93/comments","statuses_url":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/statuses/e8e57a452ddb354147e240dd080aaef4b9130e31","head":{"label":"jbrea:master","ref":"master","sha":"e8e57a452ddb354147e240dd080aaef4b9130e31","user":{"login":"jbrea","id":12857162,"node_id":"MDQ6VXNlcjEyODU3MTYy","avatar_url":"https://avatars1.githubusercontent.com/u/12857162?v=4","gravatar_id":"","url":"https://api.github.com/users/jbrea","html_url":"https://github.com/jbrea","followers_url":"https://api.github.com/users/jbrea/followers","following_url":"https://api.github.com/users/jbrea/following{/other_user}","gists_url":"https://api.github.com/users/jbrea/gists{/gist_id}","starred_url":"https://api.github.com/users/jbrea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbrea/subscriptions","organizations_url":"https://api.github.com/users/jbrea/orgs","repos_url":"https://api.github.com/users/jbrea/repos","events_url":"https://api.github.com/users/jbrea/events{/privacy}","received_events_url":"https://api.github.com/users/jbrea/received_events","type":"User","site_admin":false},"repo":{"id":152079173,"node_id":"MDEwOlJlcG9zaXRvcnkxNTIwNzkxNzM=","name":"GaussianProcesses.jl","full_name":"jbrea/GaussianProcesses.jl","private":false,"owner":{"login":"jbrea","id":12857162,"node_id":"MDQ6VXNlcjEyODU3MTYy","avatar_url":"https://avatars1.githubusercontent.com/u/12857162?v=4","gravatar_id":"","url":"https://api.github.com/users/jbrea","html_url":"https://github.com/jbrea","followers_url":"https://api.github.com/users/jbrea/followers","following_url":"https://api.github.com/users/jbrea/following{/other_user}","gists_url":"https://api.github.com/users/jbrea/gists{/gist_id}","starred_url":"https://api.github.com/users/jbrea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbrea/subscriptions","organizations_url":"https://api.github.com/users/jbrea/orgs","repos_url":"https://api.github.com/users/jbrea/repos","events_url":"https://api.github.com/users/jbrea/events{/privacy}","received_events_url":"https://api.github.com/users/jbrea/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jbrea/GaussianProcesses.jl","description":"A Julia package for Gaussian Processes","fork":true,"url":"https://api.github.com/repos/jbrea/GaussianProcesses.jl","forks_url":"https://api.github.com/repos/jbrea/GaussianProcesses.jl/forks","keys_url":"https://api.github.com/repos/jbrea/GaussianProcesses.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbrea/GaussianProcesses.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbrea/GaussianProcesses.jl/teams","hooks_url":"https://api.github.com/repos/jbrea/GaussianProcesses.jl/hooks","issue_events_url":"https://api.github.com/repos/jbrea/GaussianProcesses.jl/issues/events{/number}","events_url":"https://api.github.com/repos/jbrea/GaussianProcesses.jl/events","assignees_url":"https://api.github.com/repos/jbrea/GaussianProcesses.jl/assignees{/user}","branches_url":"https://api.github.com/repos/jbrea/GaussianProcesses.jl/branches{/branch}","tags_url":"https://api.github.com/repos/jbrea/GaussianProcesses.jl/tags","blobs_url":"https://api.github.com/repos/jbrea/GaussianProcesses.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbrea/GaussianProcesses.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbrea/GaussianProcesses.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbrea/GaussianProcesses.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbrea/GaussianProcesses.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/jbrea/GaussianProcesses.jl/languages","stargazers_url":"https://api.github.com/repos/jbrea/GaussianProcesses.jl/stargazers","contributors_url":"https://api.github.com/repos/jbrea/GaussianProcesses.jl/contributors","subscribers_url":"https://api.github.com/repos/jbrea/GaussianProcesses.jl/subscribers","subscription_url":"https://api.github.com/repos/jbrea/GaussianProcesses.jl/subscription","commits_url":"https://api.github.com/repos/jbrea/GaussianProcesses.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbrea/GaussianProcesses.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbrea/GaussianProcesses.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbrea/GaussianProcesses.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/jbrea/GaussianProcesses.jl/contents/{+path}","compare_url":"https://api.github.com/repos/jbrea/GaussianProcesses.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbrea/GaussianProcesses.jl/merges","archive_url":"https://api.github.com/repos/jbrea/GaussianProcesses.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbrea/GaussianProcesses.jl/downloads","issues_url":"https://api.github.com/repos/jbrea/GaussianProcesses.jl/issues{/number}","pulls_url":"https://api.github.com/repos/jbrea/GaussianProcesses.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/jbrea/GaussianProcesses.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/jbrea/GaussianProcesses.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbrea/GaussianProcesses.jl/labels{/name}","releases_url":"https://api.github.com/repos/jbrea/GaussianProcesses.jl/releases{/id}","deployments_url":"https://api.github.com/repos/jbrea/GaussianProcesses.jl/deployments","created_at":"2018-10-08T12:50:29Z","updated_at":"2018-10-11T20:20:55Z","pushed_at":"2018-10-11T20:20:53Z","git_url":"git://github.com/jbrea/GaussianProcesses.jl.git","ssh_url":"git@github.com:jbrea/GaussianProcesses.jl.git","clone_url":"https://github.com/jbrea/GaussianProcesses.jl.git","svn_url":"https://github.com/jbrea/GaussianProcesses.jl","homepage":"","size":19840,"stargazers_count":0,"watchers_count":0,"language":"Jupyter Notebook","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"STOR-i:master","ref":"master","sha":"af1f785e42273c356f15f38a7def4e4161bcd3bc","user":{"login":"STOR-i","id":10882735,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODgyNzM1","avatar_url":"https://avatars2.githubusercontent.com/u/10882735?v=4","gravatar_id":"","url":"https://api.github.com/users/STOR-i","html_url":"https://github.com/STOR-i","followers_url":"https://api.github.com/users/STOR-i/followers","following_url":"https://api.github.com/users/STOR-i/following{/other_user}","gists_url":"https://api.github.com/users/STOR-i/gists{/gist_id}","starred_url":"https://api.github.com/users/STOR-i/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/STOR-i/subscriptions","organizations_url":"https://api.github.com/users/STOR-i/orgs","repos_url":"https://api.github.com/users/STOR-i/repos","events_url":"https://api.github.com/users/STOR-i/events{/privacy}","received_events_url":"https://api.github.com/users/STOR-i/received_events","type":"Organization","site_admin":false},"repo":{"id":34859730,"node_id":"MDEwOlJlcG9zaXRvcnkzNDg1OTczMA==","name":"GaussianProcesses.jl","full_name":"STOR-i/GaussianProcesses.jl","private":false,"owner":{"login":"STOR-i","id":10882735,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODgyNzM1","avatar_url":"https://avatars2.githubusercontent.com/u/10882735?v=4","gravatar_id":"","url":"https://api.github.com/users/STOR-i","html_url":"https://github.com/STOR-i","followers_url":"https://api.github.com/users/STOR-i/followers","following_url":"https://api.github.com/users/STOR-i/following{/other_user}","gists_url":"https://api.github.com/users/STOR-i/gists{/gist_id}","starred_url":"https://api.github.com/users/STOR-i/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/STOR-i/subscriptions","organizations_url":"https://api.github.com/users/STOR-i/orgs","repos_url":"https://api.github.com/users/STOR-i/repos","events_url":"https://api.github.com/users/STOR-i/events{/privacy}","received_events_url":"https://api.github.com/users/STOR-i/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/STOR-i/GaussianProcesses.jl","description":"A Julia package for Gaussian Processes","fork":false,"url":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl","forks_url":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/forks","keys_url":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/teams","hooks_url":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/hooks","issue_events_url":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/issues/events{/number}","events_url":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/events","assignees_url":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/assignees{/user}","branches_url":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/branches{/branch}","tags_url":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/tags","blobs_url":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/languages","stargazers_url":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/stargazers","contributors_url":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/contributors","subscribers_url":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/subscribers","subscription_url":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/subscription","commits_url":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/contents/{+path}","compare_url":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/merges","archive_url":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/downloads","issues_url":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/issues{/number}","pulls_url":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/labels{/name}","releases_url":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/releases{/id}","deployments_url":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/deployments","created_at":"2015-04-30T14:46:12Z","updated_at":"2018-10-16T04:24:49Z","pushed_at":"2018-10-11T20:20:54Z","git_url":"git://github.com/STOR-i/GaussianProcesses.jl.git","ssh_url":"git@github.com:STOR-i/GaussianProcesses.jl.git","clone_url":"https://github.com/STOR-i/GaussianProcesses.jl.git","svn_url":"https://github.com/STOR-i/GaussianProcesses.jl","homepage":"","size":19828,"stargazers_count":73,"watchers_count":73,"language":"Jupyter Notebook","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":22,"open_issues":19,"watchers":73,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/pulls/93"},"html":{"href":"https://github.com/STOR-i/GaussianProcesses.jl/pull/93"},"issue":{"href":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/issues/93"},"comments":{"href":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/issues/93/comments"},"review_comments":{"href":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/pulls/93/comments"},"review_comment":{"href":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/pulls/93/commits"},"statuses":{"href":"https://api.github.com/repos/STOR-i/GaussianProcesses.jl/statuses/e8e57a452ddb354147e240dd080aaef4b9130e31"}},"author_association":"NONE"}}
{"actor":{"display_login":"maximerischard"}}