{"action":"created","comment":{"url":"https://api.github.com/repos/JetBrains/kotlin/pulls/comments/182760702","pull_request_review_id":113623632,"id":182760702,"diff_hunk":"@@ -50,13 +50,15 @@ class SyntheticClassOrObjectDescriptor(\n     val syntheticDeclaration: KtPureClassOrObject = SyntheticDeclaration(parentClassOrObject, name.asString())\n \n     private val thisDescriptor: SyntheticClassOrObjectDescriptor get() = this // code readability\n+    var typeParameters: List<TypeParameterDescriptor> = emptyList()\n+\n     private val typeConstructor = SyntheticTypeConstructor(c.storageManager)\n     private val resolutionScopesSupport = ClassResolutionScopesSupport(thisDescriptor, c.storageManager, c.languageVersionSettings, { outerScope })\n     private val syntheticSupertypes =\n         mutableListOf<KotlinType>().apply { c.syntheticResolveExtension.addSyntheticSupertypes(thisDescriptor, this) }\n     private val unsubstitutedMemberScope =\n         LazyClassMemberScope(c, SyntheticClassMemberDeclarationProvider(syntheticDeclaration), this, c.trace)\n-    private val unsubstitutedPrimaryConstructor = createUnsubstitutedPrimaryConstructor(constructorVisibility)\n+    private val _unsubstitutedPrimaryConstructor by lazy { createUnsubstitutedPrimaryConstructor(constructorVisibility) }","path":"compiler/frontend/src/org/jetbrains/kotlin/psi/synthetics/SyntheticClassOrObjectDescriptor.kt","position":13,"original_position":13,"commit_id":"4037694342b6298f3e42fa54163f518f36799f1a","original_commit_id":"4037694342b6298f3e42fa54163f518f36799f1a","user":{"login":"udalov","id":292714,"avatar_url":"https://avatars3.githubusercontent.com/u/292714?v=4","gravatar_id":"","url":"https://api.github.com/users/udalov","html_url":"https://github.com/udalov","followers_url":"https://api.github.com/users/udalov/followers","following_url":"https://api.github.com/users/udalov/following{/other_user}","gists_url":"https://api.github.com/users/udalov/gists{/gist_id}","starred_url":"https://api.github.com/users/udalov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/udalov/subscriptions","organizations_url":"https://api.github.com/users/udalov/orgs","repos_url":"https://api.github.com/users/udalov/repos","events_url":"https://api.github.com/users/udalov/events{/privacy}","received_events_url":"https://api.github.com/users/udalov/received_events","type":"User","site_admin":false},"body":"Please use `c.storageManager.createLazyValue` instead of `lazy` in compiler code to prevent possible deadlocks in case this code becomes less trivial","created_at":"2018-04-19T14:14:25Z","updated_at":"2018-04-19T14:14:25Z","html_url":"https://github.com/JetBrains/kotlin/pull/1636#discussion_r182760702","pull_request_url":"https://api.github.com/repos/JetBrains/kotlin/pulls/1636","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/JetBrains/kotlin/pulls/comments/182760702"},"html":{"href":"https://github.com/JetBrains/kotlin/pull/1636#discussion_r182760702"},"pull_request":{"href":"https://api.github.com/repos/JetBrains/kotlin/pulls/1636"}}},"pull_request":{"url":"https://api.github.com/repos/JetBrains/kotlin/pulls/1636","id":182748137,"html_url":"https://github.com/JetBrains/kotlin/pull/1636","diff_url":"https://github.com/JetBrains/kotlin/pull/1636.diff","patch_url":"https://github.com/JetBrains/kotlin/pull/1636.patch","issue_url":"https://api.github.com/repos/JetBrains/kotlin/issues/1636","number":1636,"state":"open","locked":false,"title":"Add correct type parameter information to synthetic declarations","user":{"login":"sandwwraith","id":11777575,"avatar_url":"https://avatars1.githubusercontent.com/u/11777575?v=4","gravatar_id":"","url":"https://api.github.com/users/sandwwraith","html_url":"https://github.com/sandwwraith","followers_url":"https://api.github.com/users/sandwwraith/followers","following_url":"https://api.github.com/users/sandwwraith/following{/other_user}","gists_url":"https://api.github.com/users/sandwwraith/gists{/gist_id}","starred_url":"https://api.github.com/users/sandwwraith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandwwraith/subscriptions","organizations_url":"https://api.github.com/users/sandwwraith/orgs","repos_url":"https://api.github.com/users/sandwwraith/repos","events_url":"https://api.github.com/users/sandwwraith/events{/privacy}","received_events_url":"https://api.github.com/users/sandwwraith/received_events","type":"User","site_admin":false},"body":"Needed by kapt due to https://github.com/Kotlin/kotlinx.serialization/issues/76","created_at":"2018-04-19T11:36:33Z","updated_at":"2018-04-19T14:14:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a19be53e0603e19d90eaded9384da3369d0f0a43","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JetBrains/kotlin/pulls/1636/commits","review_comments_url":"https://api.github.com/repos/JetBrains/kotlin/pulls/1636/comments","review_comment_url":"https://api.github.com/repos/JetBrains/kotlin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JetBrains/kotlin/issues/1636/comments","statuses_url":"https://api.github.com/repos/JetBrains/kotlin/statuses/4037694342b6298f3e42fa54163f518f36799f1a","head":{"label":"JetBrains:rr/kotlinx.serialization.patches/synthetic-typeargs","ref":"rr/kotlinx.serialization.patches/synthetic-typeargs","sha":"4037694342b6298f3e42fa54163f518f36799f1a","user":{"login":"JetBrains","id":878437,"avatar_url":"https://avatars2.githubusercontent.com/u/878437?v=4","gravatar_id":"","url":"https://api.github.com/users/JetBrains","html_url":"https://github.com/JetBrains","followers_url":"https://api.github.com/users/JetBrains/followers","following_url":"https://api.github.com/users/JetBrains/following{/other_user}","gists_url":"https://api.github.com/users/JetBrains/gists{/gist_id}","starred_url":"https://api.github.com/users/JetBrains/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JetBrains/subscriptions","organizations_url":"https://api.github.com/users/JetBrains/orgs","repos_url":"https://api.github.com/users/JetBrains/repos","events_url":"https://api.github.com/users/JetBrains/events{/privacy}","received_events_url":"https://api.github.com/users/JetBrains/received_events","type":"Organization","site_admin":false},"repo":{"id":3432266,"name":"kotlin","full_name":"JetBrains/kotlin","owner":{"login":"JetBrains","id":878437,"avatar_url":"https://avatars2.githubusercontent.com/u/878437?v=4","gravatar_id":"","url":"https://api.github.com/users/JetBrains","html_url":"https://github.com/JetBrains","followers_url":"https://api.github.com/users/JetBrains/followers","following_url":"https://api.github.com/users/JetBrains/following{/other_user}","gists_url":"https://api.github.com/users/JetBrains/gists{/gist_id}","starred_url":"https://api.github.com/users/JetBrains/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JetBrains/subscriptions","organizations_url":"https://api.github.com/users/JetBrains/orgs","repos_url":"https://api.github.com/users/JetBrains/repos","events_url":"https://api.github.com/users/JetBrains/events{/privacy}","received_events_url":"https://api.github.com/users/JetBrains/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JetBrains/kotlin","description":"The Kotlin Programming Language","fork":false,"url":"https://api.github.com/repos/JetBrains/kotlin","forks_url":"https://api.github.com/repos/JetBrains/kotlin/forks","keys_url":"https://api.github.com/repos/JetBrains/kotlin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JetBrains/kotlin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JetBrains/kotlin/teams","hooks_url":"https://api.github.com/repos/JetBrains/kotlin/hooks","issue_events_url":"https://api.github.com/repos/JetBrains/kotlin/issues/events{/number}","events_url":"https://api.github.com/repos/JetBrains/kotlin/events","assignees_url":"https://api.github.com/repos/JetBrains/kotlin/assignees{/user}","branches_url":"https://api.github.com/repos/JetBrains/kotlin/branches{/branch}","tags_url":"https://api.github.com/repos/JetBrains/kotlin/tags","blobs_url":"https://api.github.com/repos/JetBrains/kotlin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JetBrains/kotlin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JetBrains/kotlin/git/refs{/sha}","trees_url":"https://api.github.com/repos/JetBrains/kotlin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JetBrains/kotlin/statuses/{sha}","languages_url":"https://api.github.com/repos/JetBrains/kotlin/languages","stargazers_url":"https://api.github.com/repos/JetBrains/kotlin/stargazers","contributors_url":"https://api.github.com/repos/JetBrains/kotlin/contributors","subscribers_url":"https://api.github.com/repos/JetBrains/kotlin/subscribers","subscription_url":"https://api.github.com/repos/JetBrains/kotlin/subscription","commits_url":"https://api.github.com/repos/JetBrains/kotlin/commits{/sha}","git_commits_url":"https://api.github.com/repos/JetBrains/kotlin/git/commits{/sha}","comments_url":"https://api.github.com/repos/JetBrains/kotlin/comments{/number}","issue_comment_url":"https://api.github.com/repos/JetBrains/kotlin/issues/comments{/number}","contents_url":"https://api.github.com/repos/JetBrains/kotlin/contents/{+path}","compare_url":"https://api.github.com/repos/JetBrains/kotlin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JetBrains/kotlin/merges","archive_url":"https://api.github.com/repos/JetBrains/kotlin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JetBrains/kotlin/downloads","issues_url":"https://api.github.com/repos/JetBrains/kotlin/issues{/number}","pulls_url":"https://api.github.com/repos/JetBrains/kotlin/pulls{/number}","milestones_url":"https://api.github.com/repos/JetBrains/kotlin/milestones{/number}","notifications_url":"https://api.github.com/repos/JetBrains/kotlin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JetBrains/kotlin/labels{/name}","releases_url":"https://api.github.com/repos/JetBrains/kotlin/releases{/id}","deployments_url":"https://api.github.com/repos/JetBrains/kotlin/deployments","created_at":"2012-02-13T17:29:58Z","updated_at":"2018-04-19T14:05:01Z","pushed_at":"2018-04-19T14:01:18Z","git_url":"git://github.com/JetBrains/kotlin.git","ssh_url":"git@github.com:JetBrains/kotlin.git","clone_url":"https://github.com/JetBrains/kotlin.git","svn_url":"https://github.com/JetBrains/kotlin","homepage":"http://kotlinlang.org/","size":453236,"stargazers_count":21926,"watchers_count":21926,"language":"Kotlin","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2435,"mirror_url":null,"archived":false,"open_issues_count":94,"license":null,"forks":2435,"open_issues":94,"watchers":21926,"default_branch":"master"}},"base":{"label":"JetBrains:master","ref":"master","sha":"9c5e3ac629aa1f7f6483d455624a90c3a8277e9e","user":{"login":"JetBrains","id":878437,"avatar_url":"https://avatars2.githubusercontent.com/u/878437?v=4","gravatar_id":"","url":"https://api.github.com/users/JetBrains","html_url":"https://github.com/JetBrains","followers_url":"https://api.github.com/users/JetBrains/followers","following_url":"https://api.github.com/users/JetBrains/following{/other_user}","gists_url":"https://api.github.com/users/JetBrains/gists{/gist_id}","starred_url":"https://api.github.com/users/JetBrains/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JetBrains/subscriptions","organizations_url":"https://api.github.com/users/JetBrains/orgs","repos_url":"https://api.github.com/users/JetBrains/repos","events_url":"https://api.github.com/users/JetBrains/events{/privacy}","received_events_url":"https://api.github.com/users/JetBrains/received_events","type":"Organization","site_admin":false},"repo":{"id":3432266,"name":"kotlin","full_name":"JetBrains/kotlin","owner":{"login":"JetBrains","id":878437,"avatar_url":"https://avatars2.githubusercontent.com/u/878437?v=4","gravatar_id":"","url":"https://api.github.com/users/JetBrains","html_url":"https://github.com/JetBrains","followers_url":"https://api.github.com/users/JetBrains/followers","following_url":"https://api.github.com/users/JetBrains/following{/other_user}","gists_url":"https://api.github.com/users/JetBrains/gists{/gist_id}","starred_url":"https://api.github.com/users/JetBrains/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JetBrains/subscriptions","organizations_url":"https://api.github.com/users/JetBrains/orgs","repos_url":"https://api.github.com/users/JetBrains/repos","events_url":"https://api.github.com/users/JetBrains/events{/privacy}","received_events_url":"https://api.github.com/users/JetBrains/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JetBrains/kotlin","description":"The Kotlin Programming Language","fork":false,"url":"https://api.github.com/repos/JetBrains/kotlin","forks_url":"https://api.github.com/repos/JetBrains/kotlin/forks","keys_url":"https://api.github.com/repos/JetBrains/kotlin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JetBrains/kotlin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JetBrains/kotlin/teams","hooks_url":"https://api.github.com/repos/JetBrains/kotlin/hooks","issue_events_url":"https://api.github.com/repos/JetBrains/kotlin/issues/events{/number}","events_url":"https://api.github.com/repos/JetBrains/kotlin/events","assignees_url":"https://api.github.com/repos/JetBrains/kotlin/assignees{/user}","branches_url":"https://api.github.com/repos/JetBrains/kotlin/branches{/branch}","tags_url":"https://api.github.com/repos/JetBrains/kotlin/tags","blobs_url":"https://api.github.com/repos/JetBrains/kotlin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JetBrains/kotlin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JetBrains/kotlin/git/refs{/sha}","trees_url":"https://api.github.com/repos/JetBrains/kotlin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JetBrains/kotlin/statuses/{sha}","languages_url":"https://api.github.com/repos/JetBrains/kotlin/languages","stargazers_url":"https://api.github.com/repos/JetBrains/kotlin/stargazers","contributors_url":"https://api.github.com/repos/JetBrains/kotlin/contributors","subscribers_url":"https://api.github.com/repos/JetBrains/kotlin/subscribers","subscription_url":"https://api.github.com/repos/JetBrains/kotlin/subscription","commits_url":"https://api.github.com/repos/JetBrains/kotlin/commits{/sha}","git_commits_url":"https://api.github.com/repos/JetBrains/kotlin/git/commits{/sha}","comments_url":"https://api.github.com/repos/JetBrains/kotlin/comments{/number}","issue_comment_url":"https://api.github.com/repos/JetBrains/kotlin/issues/comments{/number}","contents_url":"https://api.github.com/repos/JetBrains/kotlin/contents/{+path}","compare_url":"https://api.github.com/repos/JetBrains/kotlin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JetBrains/kotlin/merges","archive_url":"https://api.github.com/repos/JetBrains/kotlin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JetBrains/kotlin/downloads","issues_url":"https://api.github.com/repos/JetBrains/kotlin/issues{/number}","pulls_url":"https://api.github.com/repos/JetBrains/kotlin/pulls{/number}","milestones_url":"https://api.github.com/repos/JetBrains/kotlin/milestones{/number}","notifications_url":"https://api.github.com/repos/JetBrains/kotlin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JetBrains/kotlin/labels{/name}","releases_url":"https://api.github.com/repos/JetBrains/kotlin/releases{/id}","deployments_url":"https://api.github.com/repos/JetBrains/kotlin/deployments","created_at":"2012-02-13T17:29:58Z","updated_at":"2018-04-19T14:05:01Z","pushed_at":"2018-04-19T14:01:18Z","git_url":"git://github.com/JetBrains/kotlin.git","ssh_url":"git@github.com:JetBrains/kotlin.git","clone_url":"https://github.com/JetBrains/kotlin.git","svn_url":"https://github.com/JetBrains/kotlin","homepage":"http://kotlinlang.org/","size":453236,"stargazers_count":21926,"watchers_count":21926,"language":"Kotlin","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2435,"mirror_url":null,"archived":false,"open_issues_count":94,"license":null,"forks":2435,"open_issues":94,"watchers":21926,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JetBrains/kotlin/pulls/1636"},"html":{"href":"https://github.com/JetBrains/kotlin/pull/1636"},"issue":{"href":"https://api.github.com/repos/JetBrains/kotlin/issues/1636"},"comments":{"href":"https://api.github.com/repos/JetBrains/kotlin/issues/1636/comments"},"review_comments":{"href":"https://api.github.com/repos/JetBrains/kotlin/pulls/1636/comments"},"review_comment":{"href":"https://api.github.com/repos/JetBrains/kotlin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JetBrains/kotlin/pulls/1636/commits"},"statuses":{"href":"https://api.github.com/repos/JetBrains/kotlin/statuses/4037694342b6298f3e42fa54163f518f36799f1a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"udalov"}}