{"action":"created","issue":{"url":"https://api.github.com/repos/python/mypy/issues/5782","repository_url":"https://api.github.com/repos/python/mypy","labels_url":"https://api.github.com/repos/python/mypy/issues/5782/labels{/name}","comments_url":"https://api.github.com/repos/python/mypy/issues/5782/comments","events_url":"https://api.github.com/repos/python/mypy/issues/5782/events","html_url":"https://github.com/python/mypy/pull/5782","id":369707845,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNTg0Mzgz","number":5782,"title":"Refactor testpep561 and add test to address #5767","user":{"login":"macbeth322","id":4066500,"node_id":"MDQ6VXNlcjQwNjY1MDA=","avatar_url":"https://avatars3.githubusercontent.com/u/4066500?v=4","gravatar_id":"","url":"https://api.github.com/users/macbeth322","html_url":"https://github.com/macbeth322","followers_url":"https://api.github.com/users/macbeth322/followers","following_url":"https://api.github.com/users/macbeth322/following{/other_user}","gists_url":"https://api.github.com/users/macbeth322/gists{/gist_id}","starred_url":"https://api.github.com/users/macbeth322/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macbeth322/subscriptions","organizations_url":"https://api.github.com/users/macbeth322/orgs","repos_url":"https://api.github.com/users/macbeth322/repos","events_url":"https://api.github.com/users/macbeth322/events{/privacy}","received_events_url":"https://api.github.com/users/macbeth322/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-10-12T20:57:03Z","updated_at":"2018-10-14T04:50:05Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/python/mypy/pulls/5782","html_url":"https://github.com/python/mypy/pull/5782","diff_url":"https://github.com/python/mypy/pull/5782.diff","patch_url":"https://github.com/python/mypy/pull/5782.patch"},"body":"I took some liberties while refactoring this to more fit my personal style and hopefully make more readable/extensible. I also added test cases for all the edge cases I found and filed in #5758; including a test case for which #5767 was filed.\r\n\r\nI understand this is a pretty big change to this file and I am open to redoing it if its not popular."},"comment":{"url":"https://api.github.com/repos/python/mypy/issues/comments/429596489","html_url":"https://github.com/python/mypy/pull/5782#issuecomment-429596489","issue_url":"https://api.github.com/repos/python/mypy/issues/5782","id":429596489,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTU5NjQ4OQ==","user":{"login":"gvanrossum","id":2894642,"node_id":"MDQ6VXNlcjI4OTQ2NDI=","avatar_url":"https://avatars3.githubusercontent.com/u/2894642?v=4","gravatar_id":"","url":"https://api.github.com/users/gvanrossum","html_url":"https://github.com/gvanrossum","followers_url":"https://api.github.com/users/gvanrossum/followers","following_url":"https://api.github.com/users/gvanrossum/following{/other_user}","gists_url":"https://api.github.com/users/gvanrossum/gists{/gist_id}","starred_url":"https://api.github.com/users/gvanrossum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gvanrossum/subscriptions","organizations_url":"https://api.github.com/users/gvanrossum/orgs","repos_url":"https://api.github.com/users/gvanrossum/repos","events_url":"https://api.github.com/users/gvanrossum/events{/privacy}","received_events_url":"https://api.github.com/users/gvanrossum/received_events","type":"User","site_admin":false},"created_at":"2018-10-14T04:50:05Z","updated_at":"2018-10-14T04:50:05Z","author_association":"MEMBER","body":"There's something else missing. I patched this in, and then put an early `return` in `_update_ns_ancestors()` in modulefinder.py. This should simulate *not* fixing part two of #5758, notably https://github.com/python/mypy/pull/5762/commits (with an insightful [review comment](https://github.com/python/mypy/pull/5762/commits/809083878f5678bf114f0c319020729a9076e1d9#r224251059) that I ignored).\r\n\r\nBut all pep561 tests still pass with that change (except `test_typedpkg_editable()` still fails). So it looks like the requested test still doesn't exist..."}}
{"actor":{"display_login":"gvanrossum"}}