{"action":"created","comment":{"url":"https://api.github.com/repos/hyperledger/iroha/pulls/comments/204383707","pull_request_review_id":139451863,"id":204383707,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDM4MzcwNw==","diff_hunk":"@@ -29,24 +29,23 @@ grpc::Status OrderingGateTransportGrpc::onProposal(\n     ::google::protobuf::Empty *response) {\n   log_->info(\"receive proposal\");\n \n-  std::vector<shared_model::proto::Transaction> transactions;\n-  for (const auto &tx : request->transactions()) {\n-    transactions.emplace_back(tx);\n-  }\n-  log_->info(\"transactions in proposal: {}\", transactions.size());\n+  auto proposal_res = factory_->createProposal(*request);\n+  proposal_res.match(\n+      [this](\n+          iroha::expected::Value<std::unique_ptr<shared_model::interface::Proposal>>","path":"irohad/ordering/impl/ordering_gate_transport_grpc.cpp","position":12,"original_position":12,"commit_id":"9056f3fc21c22770fe4a9aca0281ea00107f8351","original_commit_id":"9056f3fc21c22770fe4a9aca0281ea00107f8351","user":{"login":"Akvinikym","id":16174976,"node_id":"MDQ6VXNlcjE2MTc0OTc2","avatar_url":"https://avatars2.githubusercontent.com/u/16174976?v=4","gravatar_id":"","url":"https://api.github.com/users/Akvinikym","html_url":"https://github.com/Akvinikym","followers_url":"https://api.github.com/users/Akvinikym/followers","following_url":"https://api.github.com/users/Akvinikym/following{/other_user}","gists_url":"https://api.github.com/users/Akvinikym/gists{/gist_id}","starred_url":"https://api.github.com/users/Akvinikym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Akvinikym/subscriptions","organizations_url":"https://api.github.com/users/Akvinikym/orgs","repos_url":"https://api.github.com/users/Akvinikym/repos","events_url":"https://api.github.com/users/Akvinikym/events{/privacy}","received_events_url":"https://api.github.com/users/Akvinikym/received_events","type":"User","site_admin":false},"body":"Can be ```auto &v```, I assume","created_at":"2018-07-23T12:34:52Z","updated_at":"2018-07-23T13:01:15Z","html_url":"https://github.com/hyperledger/iroha/pull/1587#discussion_r204383707","pull_request_url":"https://api.github.com/repos/hyperledger/iroha/pulls/1587","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/comments/204383707"},"html":{"href":"https://github.com/hyperledger/iroha/pull/1587#discussion_r204383707"},"pull_request":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/1587"}}},"pull_request":{"url":"https://api.github.com/repos/hyperledger/iroha/pulls/1587","id":203179531,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMTc5NTMx","html_url":"https://github.com/hyperledger/iroha/pull/1587","diff_url":"https://github.com/hyperledger/iroha/pull/1587.diff","patch_url":"https://github.com/hyperledger/iroha/pull/1587.patch","issue_url":"https://api.github.com/repos/hyperledger/iroha/issues/1587","number":1587,"state":"open","locked":false,"title":"Proposal factory","user":{"login":"nickaleks","id":14168731,"node_id":"MDQ6VXNlcjE0MTY4NzMx","avatar_url":"https://avatars0.githubusercontent.com/u/14168731?v=4","gravatar_id":"","url":"https://api.github.com/users/nickaleks","html_url":"https://github.com/nickaleks","followers_url":"https://api.github.com/users/nickaleks/followers","following_url":"https://api.github.com/users/nickaleks/following{/other_user}","gists_url":"https://api.github.com/users/nickaleks/gists{/gist_id}","starred_url":"https://api.github.com/users/nickaleks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickaleks/subscriptions","organizations_url":"https://api.github.com/users/nickaleks/orgs","repos_url":"https://api.github.com/users/nickaleks/repos","events_url":"https://api.github.com/users/nickaleks/events{/privacy}","received_events_url":"https://api.github.com/users/nickaleks/received_events","type":"User","site_admin":false},"body":"<!-- You will not see HTML commented line in Pull Request body -->\r\n<!-- Optional sections may be omitted. Just remove them or write None -->\r\n\r\n<!-- ### Requirements -->\r\n<!-- * Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion. -->\r\n<!-- * All new code must have code coverage above 70% (https://docs.codecov.io/docs/about-code-coverage). -->\r\n<!-- * CircleCI builds must be passed. -->\r\n<!-- * Critical and blocker issues reported by Sorabot must be fixed. -->\r\n<!-- * Branch must be rebased onto base branch (https://soramitsu.atlassian.net/wiki/spaces/IS/pages/11173889/Rebase+and+merge+guide). -->\r\n\r\n\r\n### Description of the Change\r\n\r\nTo get rid of builders and abstract away implementation details proposal factory is created. It is used in every place in irohad where a proposal is constructed.\r\n\r\n### Benefits\r\n\r\nNo more builders, and no ugly casts\r\n\r\n### Possible Drawbacks \r\n\r\nNo","created_at":"2018-07-23T10:46:11Z","updated_at":"2018-07-23T13:01:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[{"login":"victordrobny","id":9118241,"node_id":"MDQ6VXNlcjkxMTgyNDE=","avatar_url":"https://avatars1.githubusercontent.com/u/9118241?v=4","gravatar_id":"","url":"https://api.github.com/users/victordrobny","html_url":"https://github.com/victordrobny","followers_url":"https://api.github.com/users/victordrobny/followers","following_url":"https://api.github.com/users/victordrobny/following{/other_user}","gists_url":"https://api.github.com/users/victordrobny/gists{/gist_id}","starred_url":"https://api.github.com/users/victordrobny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/victordrobny/subscriptions","organizations_url":"https://api.github.com/users/victordrobny/orgs","repos_url":"https://api.github.com/users/victordrobny/repos","events_url":"https://api.github.com/users/victordrobny/events{/privacy}","received_events_url":"https://api.github.com/users/victordrobny/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hyperledger/iroha/pulls/1587/commits","review_comments_url":"https://api.github.com/repos/hyperledger/iroha/pulls/1587/comments","review_comment_url":"https://api.github.com/repos/hyperledger/iroha/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperledger/iroha/issues/1587/comments","statuses_url":"https://api.github.com/repos/hyperledger/iroha/statuses/9056f3fc21c22770fe4a9aca0281ea00107f8351","head":{"label":"hyperledger:feature/proposal_factory","ref":"feature/proposal_factory","sha":"9056f3fc21c22770fe4a9aca0281ea00107f8351","user":{"login":"hyperledger","id":7657900,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2NTc5MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"repo":{"id":67340575,"node_id":"MDEwOlJlcG9zaXRvcnk2NzM0MDU3NQ==","name":"iroha","full_name":"hyperledger/iroha","owner":{"login":"hyperledger","id":7657900,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2NTc5MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperledger/iroha","description":"Iroha - A simple, decentralized ledger","fork":false,"url":"https://api.github.com/repos/hyperledger/iroha","forks_url":"https://api.github.com/repos/hyperledger/iroha/forks","keys_url":"https://api.github.com/repos/hyperledger/iroha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperledger/iroha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperledger/iroha/teams","hooks_url":"https://api.github.com/repos/hyperledger/iroha/hooks","issue_events_url":"https://api.github.com/repos/hyperledger/iroha/issues/events{/number}","events_url":"https://api.github.com/repos/hyperledger/iroha/events","assignees_url":"https://api.github.com/repos/hyperledger/iroha/assignees{/user}","branches_url":"https://api.github.com/repos/hyperledger/iroha/branches{/branch}","tags_url":"https://api.github.com/repos/hyperledger/iroha/tags","blobs_url":"https://api.github.com/repos/hyperledger/iroha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperledger/iroha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperledger/iroha/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperledger/iroha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperledger/iroha/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperledger/iroha/languages","stargazers_url":"https://api.github.com/repos/hyperledger/iroha/stargazers","contributors_url":"https://api.github.com/repos/hyperledger/iroha/contributors","subscribers_url":"https://api.github.com/repos/hyperledger/iroha/subscribers","subscription_url":"https://api.github.com/repos/hyperledger/iroha/subscription","commits_url":"https://api.github.com/repos/hyperledger/iroha/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperledger/iroha/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperledger/iroha/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperledger/iroha/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperledger/iroha/contents/{+path}","compare_url":"https://api.github.com/repos/hyperledger/iroha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperledger/iroha/merges","archive_url":"https://api.github.com/repos/hyperledger/iroha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperledger/iroha/downloads","issues_url":"https://api.github.com/repos/hyperledger/iroha/issues{/number}","pulls_url":"https://api.github.com/repos/hyperledger/iroha/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperledger/iroha/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperledger/iroha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperledger/iroha/labels{/name}","releases_url":"https://api.github.com/repos/hyperledger/iroha/releases{/id}","deployments_url":"https://api.github.com/repos/hyperledger/iroha/deployments","created_at":"2016-09-04T11:17:53Z","updated_at":"2018-07-22T23:24:35Z","pushed_at":"2018-07-23T12:06:38Z","git_url":"git://github.com/hyperledger/iroha.git","ssh_url":"git@github.com:hyperledger/iroha.git","clone_url":"https://github.com/hyperledger/iroha.git","svn_url":"https://github.com/hyperledger/iroha","homepage":"http://iroha.tech","size":49599,"stargazers_count":866,"watchers_count":866,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":276,"mirror_url":null,"archived":false,"open_issues_count":52,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":276,"open_issues":52,"watchers":866,"default_branch":"master"}},"base":{"label":"hyperledger:develop","ref":"develop","sha":"41b66c90786bdf8e980f2a6cf3c1f499a7a9203a","user":{"login":"hyperledger","id":7657900,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2NTc5MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"repo":{"id":67340575,"node_id":"MDEwOlJlcG9zaXRvcnk2NzM0MDU3NQ==","name":"iroha","full_name":"hyperledger/iroha","owner":{"login":"hyperledger","id":7657900,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2NTc5MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperledger/iroha","description":"Iroha - A simple, decentralized ledger","fork":false,"url":"https://api.github.com/repos/hyperledger/iroha","forks_url":"https://api.github.com/repos/hyperledger/iroha/forks","keys_url":"https://api.github.com/repos/hyperledger/iroha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperledger/iroha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperledger/iroha/teams","hooks_url":"https://api.github.com/repos/hyperledger/iroha/hooks","issue_events_url":"https://api.github.com/repos/hyperledger/iroha/issues/events{/number}","events_url":"https://api.github.com/repos/hyperledger/iroha/events","assignees_url":"https://api.github.com/repos/hyperledger/iroha/assignees{/user}","branches_url":"https://api.github.com/repos/hyperledger/iroha/branches{/branch}","tags_url":"https://api.github.com/repos/hyperledger/iroha/tags","blobs_url":"https://api.github.com/repos/hyperledger/iroha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperledger/iroha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperledger/iroha/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperledger/iroha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperledger/iroha/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperledger/iroha/languages","stargazers_url":"https://api.github.com/repos/hyperledger/iroha/stargazers","contributors_url":"https://api.github.com/repos/hyperledger/iroha/contributors","subscribers_url":"https://api.github.com/repos/hyperledger/iroha/subscribers","subscription_url":"https://api.github.com/repos/hyperledger/iroha/subscription","commits_url":"https://api.github.com/repos/hyperledger/iroha/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperledger/iroha/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperledger/iroha/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperledger/iroha/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperledger/iroha/contents/{+path}","compare_url":"https://api.github.com/repos/hyperledger/iroha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperledger/iroha/merges","archive_url":"https://api.github.com/repos/hyperledger/iroha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperledger/iroha/downloads","issues_url":"https://api.github.com/repos/hyperledger/iroha/issues{/number}","pulls_url":"https://api.github.com/repos/hyperledger/iroha/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperledger/iroha/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperledger/iroha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperledger/iroha/labels{/name}","releases_url":"https://api.github.com/repos/hyperledger/iroha/releases{/id}","deployments_url":"https://api.github.com/repos/hyperledger/iroha/deployments","created_at":"2016-09-04T11:17:53Z","updated_at":"2018-07-22T23:24:35Z","pushed_at":"2018-07-23T12:06:38Z","git_url":"git://github.com/hyperledger/iroha.git","ssh_url":"git@github.com:hyperledger/iroha.git","clone_url":"https://github.com/hyperledger/iroha.git","svn_url":"https://github.com/hyperledger/iroha","homepage":"http://iroha.tech","size":49599,"stargazers_count":866,"watchers_count":866,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":276,"mirror_url":null,"archived":false,"open_issues_count":52,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":276,"open_issues":52,"watchers":866,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/1587"},"html":{"href":"https://github.com/hyperledger/iroha/pull/1587"},"issue":{"href":"https://api.github.com/repos/hyperledger/iroha/issues/1587"},"comments":{"href":"https://api.github.com/repos/hyperledger/iroha/issues/1587/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/1587/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/1587/commits"},"statuses":{"href":"https://api.github.com/repos/hyperledger/iroha/statuses/9056f3fc21c22770fe4a9aca0281ea00107f8351"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Akvinikym"}}