{"action":"created","issue":{"url":"https://api.github.com/repos/ember-animation/liquid-fire/issues/610","repository_url":"https://api.github.com/repos/ember-animation/liquid-fire","labels_url":"https://api.github.com/repos/ember-animation/liquid-fire/issues/610/labels{/name}","comments_url":"https://api.github.com/repos/ember-animation/liquid-fire/issues/610/comments","events_url":"https://api.github.com/repos/ember-animation/liquid-fire/issues/610/events","html_url":"https://github.com/ember-animation/liquid-fire/issues/610","id":330805221,"node_id":"MDU6SXNzdWUzMzA4MDUyMjE=","number":610,"title":"Visibility regression on latest v0.29.3 release with `ember-modal-dialog`","user":{"login":"alexdiliberto","id":666459,"node_id":"MDQ6VXNlcjY2NjQ1OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/666459?v=4","gravatar_id":"","url":"https://api.github.com/users/alexdiliberto","html_url":"https://github.com/alexdiliberto","followers_url":"https://api.github.com/users/alexdiliberto/followers","following_url":"https://api.github.com/users/alexdiliberto/following{/other_user}","gists_url":"https://api.github.com/users/alexdiliberto/gists{/gist_id}","starred_url":"https://api.github.com/users/alexdiliberto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexdiliberto/subscriptions","organizations_url":"https://api.github.com/users/alexdiliberto/orgs","repos_url":"https://api.github.com/users/alexdiliberto/repos","events_url":"https://api.github.com/users/alexdiliberto/events{/privacy}","received_events_url":"https://api.github.com/users/alexdiliberto/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-08T21:15:37Z","updated_at":"2018-06-11T02:32:43Z","closed_at":null,"author_association":"NONE","body":"Seeing a regression when using with an `ember-modal-dialog` animated `explode` modal type. Here is a reproduction repository with steps to show the bug:\r\n\r\nhttps://github.com/alexdiliberto/liquid-fire-0.29.3-regression-using-ember-modal-dialog\r\n\r\nThis is the specific line change that introduces the regression: https://github.com/ember-animation/liquid-fire/pull/607/files#diff-5856713c422e7fbf65d5870770d00ddcL43"},"comment":{"url":"https://api.github.com/repos/ember-animation/liquid-fire/issues/comments/396106430","html_url":"https://github.com/ember-animation/liquid-fire/issues/610#issuecomment-396106430","issue_url":"https://api.github.com/repos/ember-animation/liquid-fire/issues/610","id":396106430,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NjEwNjQzMA==","user":{"login":"brettburley","id":8064362,"node_id":"MDQ6VXNlcjgwNjQzNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/8064362?v=4","gravatar_id":"","url":"https://api.github.com/users/brettburley","html_url":"https://github.com/brettburley","followers_url":"https://api.github.com/users/brettburley/followers","following_url":"https://api.github.com/users/brettburley/following{/other_user}","gists_url":"https://api.github.com/users/brettburley/gists{/gist_id}","starred_url":"https://api.github.com/users/brettburley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brettburley/subscriptions","organizations_url":"https://api.github.com/users/brettburley/orgs","repos_url":"https://api.github.com/users/brettburley/repos","events_url":"https://api.github.com/users/brettburley/events{/privacy}","received_events_url":"https://api.github.com/users/brettburley/received_events","type":"User","site_admin":false},"created_at":"2018-06-11T02:32:43Z","updated_at":"2018-06-11T02:32:43Z","author_association":"CONTRIBUTOR","body":"It looks like it's an interaction between the new visibility settings and `liquid-wormhole`. It seems `liquid-wormhole` was relying on the behavior of `liquid-fire` applying `visibility: visible` to elements when they were animated. `liquid-wormhole` adds `visibility: hidden` to a few of the parents -- I assume so that the parent containers which it makes `100%` width and `100vh` height are not clickable.\r\n\r\nHere's a patch for `liquid-wormhole` that appears to make the example provided by @alexdiliberto work: https://github.com/brettburley/liquid-wormhole/commit/7a9cd47a74fbfcb31ac5e551dd610f0fc5fcb271\r\n\r\nNot sure the best path forward,\r\n1. Fix `liquid-wormhole` so that it doesn't assume that elements get `visibility: visible` when they animate.\r\n2. Lock `liquid-wormhole` to an earlier version of `liquid-fire`.\r\n3. Revert the change in `liquid-fire`.\r\n\r\nI _think_ the last is the least desirable, since it fixes a bug in core `liquid-fire` with nested transitions, but I'm not familiar enough with `liquid-wormhole` to know how it should be considered there."}}
{"actor":{"display_login":"brettburley"}}