{"action":"opened","issue":{"url":"https://api.github.com/repos/google/xi-editor/issues/650","repository_url":"https://api.github.com/repos/google/xi-editor","labels_url":"https://api.github.com/repos/google/xi-editor/issues/650/labels{/name}","comments_url":"https://api.github.com/repos/google/xi-editor/issues/650/comments","events_url":"https://api.github.com/repos/google/xi-editor/issues/650/events","html_url":"https://github.com/google/xi-editor/issues/650","id":321759453,"number":650,"title":"Missing Search Highlights","user":{"login":"scholtzan","id":1239705,"avatar_url":"https://avatars2.githubusercontent.com/u/1239705?v=4","gravatar_id":"","url":"https://api.github.com/users/scholtzan","html_url":"https://github.com/scholtzan","followers_url":"https://api.github.com/users/scholtzan/followers","following_url":"https://api.github.com/users/scholtzan/following{/other_user}","gists_url":"https://api.github.com/users/scholtzan/gists{/gist_id}","starred_url":"https://api.github.com/users/scholtzan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scholtzan/subscriptions","organizations_url":"https://api.github.com/users/scholtzan/orgs","repos_url":"https://api.github.com/users/scholtzan/repos","events_url":"https://api.github.com/users/scholtzan/events{/privacy}","received_events_url":"https://api.github.com/users/scholtzan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-09T23:26:55Z","updated_at":"2018-05-09T23:26:55Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"I wrote a simplified WIP version (https://github.com/google/xi-editor/pull/649) of find that, for now, searches the entire text and all search occurrences (it is not much different from the old find functionality). However, only the first one is highlighted (tested in xi-mac). I tried to find out the reason for this and narrowed it down to `send_update_for_plan`. It seems that only the line with the current cursor is rendered/updated, after xi receives a `Find` event and performs the search. I suspect it has something to do with the line cache shadow of the view. \r\n\r\nI am currently trying to find out how rendering in `View` and the line cache shadow should behave during find. Or if this should all be done in a completely different way. Any thoughts on this are appreciated!\r\n\r\nhttps://github.com/google/xi-editor/issues/634"}}
{"actor":{"display_login":"scholtzan"}}