{"action":"created","issue":{"url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/issues/4707","repository_url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End","labels_url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/issues/4707/labels{/name}","comments_url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/issues/4707/comments","events_url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/issues/4707/events","html_url":"https://github.com/zooniverse/Panoptes-Front-End/pull/4707","id":333679741,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1ODMzODA1","number":4707,"title":"Rewrite drawing summary in ES6","user":{"login":"eatyourgreens","id":59547,"node_id":"MDQ6VXNlcjU5NTQ3","avatar_url":"https://avatars3.githubusercontent.com/u/59547?v=4","gravatar_id":"","url":"https://api.github.com/users/eatyourgreens","html_url":"https://github.com/eatyourgreens","followers_url":"https://api.github.com/users/eatyourgreens/followers","following_url":"https://api.github.com/users/eatyourgreens/following{/other_user}","gists_url":"https://api.github.com/users/eatyourgreens/gists{/gist_id}","starred_url":"https://api.github.com/users/eatyourgreens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eatyourgreens/subscriptions","organizations_url":"https://api.github.com/users/eatyourgreens/orgs","repos_url":"https://api.github.com/users/eatyourgreens/repos","events_url":"https://api.github.com/users/eatyourgreens/events{/privacy}","received_events_url":"https://api.github.com/users/eatyourgreens/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-19T13:47:29Z","updated_at":"2018-06-19T15:37:31Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/pulls/4707","html_url":"https://github.com/zooniverse/Panoptes-Front-End/pull/4707","diff_url":"https://github.com/zooniverse/Panoptes-Front-End/pull/4707.diff","patch_url":"https://github.com/zooniverse/Panoptes-Front-End/pull/4707.patch"},"body":"Extract the rendering of individual tool annotations into their own components, for clarity.\r\nRender details subtasks using the summary component for the matching task.\r\nRemove the Less/More toggle (I didn't think it added much, but I can add it back in if it's needed.)\r\n\r\nStaging branch URL: https://drawing-summary.pfe-preview.zooniverse.org\r\n\r\nFixes #1224.\r\n\r\n![Screenshot of the summary for I Fancy Cats, showing the cuteness rating in the drawing summary.](https://user-images.githubusercontent.com/59547/41602223-369dec14-73d2-11e8-88db-e491e373b496.png)\r\n\r\n\r\n# Required Manual Testing\r\n\r\n- [ ] Does the non-logged in home page render correctly?\r\n- [ ] Does the logged in home page render correctly?\r\n- [ ] Does the projects page render correctly?\r\n- [ ] Can you load project home pages?\r\n- [ ] Can you load the classification page?\r\n- [ ] Can you submit a classification?\r\n- [ ] Does talk load correctly?\r\n- [ ] Can you post a talk comment?\r\n\r\n# Review Checklist\r\n\r\n- [ ] Does it work in all major browsers: Firefox, Chrome, Edge, Safari?\r\n- [ ] Does it work on mobile?\r\n- [ ] Can you `rm -rf node_modules/ && npm install` and app works as expected?\r\n- [ ] If the component is in coffeescript, is it converted to ES6? Is it free of eslint errors? Is the conversion its own commit?\r\n- [ ] Are the tests passing locally and on Travis?\r\n\r\n# Optional\r\n\r\n- [ ] Have you replaced any `ChangeListener` or `PromiseRenderer` components with code that updates component state?\r\n- [ ] If changes are made to the classifier, does the dev classifier still work?\r\n- [ ] Have you [resized and compressed](https://developers.google.com/web/fundamentals/performance/optimizing-content-efficiency/image-optimization) any image you've added?\r\n- [ ] Have you added in [flow type annotations](https://flowtype.org/docs/type-annotations.html)?\r\n- [ ] Have you followed the [Springer guidelines for commit messages](https://github.com/springernature/frontend-playbook/blob/master/git/git.md#commit-messages)?\r\n"},"comment":{"url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/issues/comments/398444296","html_url":"https://github.com/zooniverse/Panoptes-Front-End/pull/4707#issuecomment-398444296","issue_url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/issues/4707","id":398444296,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODQ0NDI5Ng==","user":{"login":"eatyourgreens","id":59547,"node_id":"MDQ6VXNlcjU5NTQ3","avatar_url":"https://avatars3.githubusercontent.com/u/59547?v=4","gravatar_id":"","url":"https://api.github.com/users/eatyourgreens","html_url":"https://github.com/eatyourgreens","followers_url":"https://api.github.com/users/eatyourgreens/followers","following_url":"https://api.github.com/users/eatyourgreens/following{/other_user}","gists_url":"https://api.github.com/users/eatyourgreens/gists{/gist_id}","starred_url":"https://api.github.com/users/eatyourgreens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eatyourgreens/subscriptions","organizations_url":"https://api.github.com/users/eatyourgreens/orgs","repos_url":"https://api.github.com/users/eatyourgreens/repos","events_url":"https://api.github.com/users/eatyourgreens/events{/privacy}","received_events_url":"https://api.github.com/users/eatyourgreens/received_events","type":"User","site_admin":false},"created_at":"2018-06-19T15:37:31Z","updated_at":"2018-06-19T15:37:31Z","author_association":"MEMBER","body":"Here's what this summary looks like on the dev classifier, where there are a mixture of different drawing tasks.\r\n\r\n![Screenshot showing subtask summaries for multiple choice questions, text inputs and the slider task.](https://user-images.githubusercontent.com/59547/41607881-fd3bea5e-73de-11e8-8d2d-0b08001955bf.png)\r\n"}}
{"actor":{"display_login":"eatyourgreens"}}