{"action":"opened","number":1,"pull_request":{"url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/pulls/1","id":190579401,"html_url":"https://github.com/dexmac/api-validation-with-nightwatch/pull/1","diff_url":"https://github.com/dexmac/api-validation-with-nightwatch/pull/1.diff","patch_url":"https://github.com/dexmac/api-validation-with-nightwatch/pull/1.patch","issue_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/issues/1","number":1,"state":"open","locked":false,"title":"Create CODE_OF_CONDUCT.md","user":{"login":"dexmac","id":3006158,"avatar_url":"https://avatars3.githubusercontent.com/u/3006158?v=4","gravatar_id":"","url":"https://api.github.com/users/dexmac","html_url":"https://github.com/dexmac","followers_url":"https://api.github.com/users/dexmac/followers","following_url":"https://api.github.com/users/dexmac/following{/other_user}","gists_url":"https://api.github.com/users/dexmac/gists{/gist_id}","starred_url":"https://api.github.com/users/dexmac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dexmac/subscriptions","organizations_url":"https://api.github.com/users/dexmac/orgs","repos_url":"https://api.github.com/users/dexmac/repos","events_url":"https://api.github.com/users/dexmac/events{/privacy}","received_events_url":"https://api.github.com/users/dexmac/received_events","type":"User","site_admin":false},"body":"## Pull Request Code Review\r\n\r\nEvery piece of code that’s committed to the `master` branch of the repo is reviewed. \r\nThe first step is pushing your branch to origin and opening a pull request on master.\r\n\r\n### General PR review Process\r\n- Checkout the branch.\r\n- Verify PR is a single change type. Example, 'refactor' OR 'bugfix'. If it is more than 1 type, ask submitter to break out requests.\r\n- Verify code under review has at least 80% unit test coverage.\r\n- Verify tests are green in CI + run tests in local build by running `yarn / npm test`\r\n- Verify no code quality violations are present from linting (should be reported in terminal)\r\n- Review for obvious errors or bad coding practice. Use best judgement here.\r\n- If the change results in needing updates to docs (such as public API change, module interface etc), add a label for \"needs docs\" and inform the submitter they must submit a docs PR to update the appropriate area of the external documentation **before the PR can merge**. Help them with finding where the docs are located if needed. \r\n- Once there is a +1 on the PR, merge to master\r\n- Add notes for this submission to the project's [changelog](./CHANGELOG).\r\n\r\nHow to perform reviews?\r\n- Please make sure you understand exactly what the submitter's intent is. \r\n- Look for improvements in code style (- please try to prevent \"tabs vs. 4 spaces\" opinions (smile))\r\n- Look for improvements in design. (keep your code simple, maintainable and upgradable)\r\n- Look for proper separation of concerns: views shouldn't usually talk to models, controllers shouldn't interact with views directly, etc.\r\n- Point out refactorings to reuse code (i.e., keep your code D.R.Y)\r\n- Evaluate if the main goal has reasonable test coverage and these don't assert on false positives\r\n\r\n- Please also read the following important resources on performing code reviews:\r\n    https://medium.com/@mrjoelkemp/giving-better-code-reviews-16109e0fdd36\r\n    https://smartbear.com/learn/code-review/best-practices-for-peer-code-review/\r\n    https://blog.asana.com/2016/12/7-ways-to-uplevel-your-code-review-skills/\r\n    https://www.planetgeek.ch/wp-content/uploads/2013/06/Clean-Code-V2.2.pdf\r\n    \r\nTips for submitters:\r\n- Please keep the code short: Beyond 200 lines and the effectiveness of a review drops significantly. By the time you’re at more than 400 they become almost pointless.\r\n  Provide context: Link to any related tickets, or the spec. Provide short, but useful commit messages and plenty of comments throughout your code. It’ll help the reviewer and you’ll get fewer issues coming back.\r\n","created_at":"2018-05-25T12:53:39Z","updated_at":"2018-05-25T12:53:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/pulls/1/commits","review_comments_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/pulls/1/comments","review_comment_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/issues/1/comments","statuses_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/statuses/38839c41625b1a14fff4a5fcbf5f78edc0b77298","head":{"label":"dexmac:add-code-of-conduct-1","ref":"add-code-of-conduct-1","sha":"38839c41625b1a14fff4a5fcbf5f78edc0b77298","user":{"login":"dexmac","id":3006158,"avatar_url":"https://avatars3.githubusercontent.com/u/3006158?v=4","gravatar_id":"","url":"https://api.github.com/users/dexmac","html_url":"https://github.com/dexmac","followers_url":"https://api.github.com/users/dexmac/followers","following_url":"https://api.github.com/users/dexmac/following{/other_user}","gists_url":"https://api.github.com/users/dexmac/gists{/gist_id}","starred_url":"https://api.github.com/users/dexmac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dexmac/subscriptions","organizations_url":"https://api.github.com/users/dexmac/orgs","repos_url":"https://api.github.com/users/dexmac/repos","events_url":"https://api.github.com/users/dexmac/events{/privacy}","received_events_url":"https://api.github.com/users/dexmac/received_events","type":"User","site_admin":false},"repo":{"id":127862712,"name":"api-validation-with-nightwatch","full_name":"dexmac/api-validation-with-nightwatch","owner":{"login":"dexmac","id":3006158,"avatar_url":"https://avatars3.githubusercontent.com/u/3006158?v=4","gravatar_id":"","url":"https://api.github.com/users/dexmac","html_url":"https://github.com/dexmac","followers_url":"https://api.github.com/users/dexmac/followers","following_url":"https://api.github.com/users/dexmac/following{/other_user}","gists_url":"https://api.github.com/users/dexmac/gists{/gist_id}","starred_url":"https://api.github.com/users/dexmac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dexmac/subscriptions","organizations_url":"https://api.github.com/users/dexmac/orgs","repos_url":"https://api.github.com/users/dexmac/repos","events_url":"https://api.github.com/users/dexmac/events{/privacy}","received_events_url":"https://api.github.com/users/dexmac/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dexmac/api-validation-with-nightwatch","description":"NightwatchJS assertion for validating outgoing requests + Nightwatch & Travis.CI Integration","fork":false,"url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch","forks_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/forks","keys_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/teams","hooks_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/hooks","issue_events_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/issues/events{/number}","events_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/events","assignees_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/assignees{/user}","branches_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/branches{/branch}","tags_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/tags","blobs_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/git/refs{/sha}","trees_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/statuses/{sha}","languages_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/languages","stargazers_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/stargazers","contributors_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/contributors","subscribers_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/subscribers","subscription_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/subscription","commits_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/commits{/sha}","git_commits_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/git/commits{/sha}","comments_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/comments{/number}","issue_comment_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/issues/comments{/number}","contents_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/contents/{+path}","compare_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/merges","archive_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/downloads","issues_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/issues{/number}","pulls_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/pulls{/number}","milestones_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/milestones{/number}","notifications_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/labels{/name}","releases_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/releases{/id}","deployments_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/deployments","created_at":"2018-04-03T06:38:44Z","updated_at":"2018-05-25T12:47:56Z","pushed_at":"2018-05-25T12:53:19Z","git_url":"git://github.com/dexmac/api-validation-with-nightwatch.git","ssh_url":"git@github.com:dexmac/api-validation-with-nightwatch.git","clone_url":"https://github.com/dexmac/api-validation-with-nightwatch.git","svn_url":"https://github.com/dexmac/api-validation-with-nightwatch","homepage":"","size":606,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"dexmac:master","ref":"master","sha":"cef9a6bee34c853fbffbfc916d882eaa26766690","user":{"login":"dexmac","id":3006158,"avatar_url":"https://avatars3.githubusercontent.com/u/3006158?v=4","gravatar_id":"","url":"https://api.github.com/users/dexmac","html_url":"https://github.com/dexmac","followers_url":"https://api.github.com/users/dexmac/followers","following_url":"https://api.github.com/users/dexmac/following{/other_user}","gists_url":"https://api.github.com/users/dexmac/gists{/gist_id}","starred_url":"https://api.github.com/users/dexmac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dexmac/subscriptions","organizations_url":"https://api.github.com/users/dexmac/orgs","repos_url":"https://api.github.com/users/dexmac/repos","events_url":"https://api.github.com/users/dexmac/events{/privacy}","received_events_url":"https://api.github.com/users/dexmac/received_events","type":"User","site_admin":false},"repo":{"id":127862712,"name":"api-validation-with-nightwatch","full_name":"dexmac/api-validation-with-nightwatch","owner":{"login":"dexmac","id":3006158,"avatar_url":"https://avatars3.githubusercontent.com/u/3006158?v=4","gravatar_id":"","url":"https://api.github.com/users/dexmac","html_url":"https://github.com/dexmac","followers_url":"https://api.github.com/users/dexmac/followers","following_url":"https://api.github.com/users/dexmac/following{/other_user}","gists_url":"https://api.github.com/users/dexmac/gists{/gist_id}","starred_url":"https://api.github.com/users/dexmac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dexmac/subscriptions","organizations_url":"https://api.github.com/users/dexmac/orgs","repos_url":"https://api.github.com/users/dexmac/repos","events_url":"https://api.github.com/users/dexmac/events{/privacy}","received_events_url":"https://api.github.com/users/dexmac/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dexmac/api-validation-with-nightwatch","description":"NightwatchJS assertion for validating outgoing requests + Nightwatch & Travis.CI Integration","fork":false,"url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch","forks_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/forks","keys_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/teams","hooks_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/hooks","issue_events_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/issues/events{/number}","events_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/events","assignees_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/assignees{/user}","branches_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/branches{/branch}","tags_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/tags","blobs_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/git/refs{/sha}","trees_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/statuses/{sha}","languages_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/languages","stargazers_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/stargazers","contributors_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/contributors","subscribers_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/subscribers","subscription_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/subscription","commits_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/commits{/sha}","git_commits_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/git/commits{/sha}","comments_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/comments{/number}","issue_comment_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/issues/comments{/number}","contents_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/contents/{+path}","compare_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/merges","archive_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/downloads","issues_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/issues{/number}","pulls_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/pulls{/number}","milestones_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/milestones{/number}","notifications_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/labels{/name}","releases_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/releases{/id}","deployments_url":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/deployments","created_at":"2018-04-03T06:38:44Z","updated_at":"2018-05-25T12:47:56Z","pushed_at":"2018-05-25T12:53:19Z","git_url":"git://github.com/dexmac/api-validation-with-nightwatch.git","ssh_url":"git@github.com:dexmac/api-validation-with-nightwatch.git","clone_url":"https://github.com/dexmac/api-validation-with-nightwatch.git","svn_url":"https://github.com/dexmac/api-validation-with-nightwatch","homepage":"","size":606,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/pulls/1"},"html":{"href":"https://github.com/dexmac/api-validation-with-nightwatch/pull/1"},"issue":{"href":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/issues/1"},"comments":{"href":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/dexmac/api-validation-with-nightwatch/statuses/38839c41625b1a14fff4a5fcbf5f78edc0b77298"}},"author_association":"OWNER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":46,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"dexmac"}}