{"action":"created","comment":{"url":"https://api.github.com/repos/folio-org/mod-source-record-manager/pulls/comments/236643354","pull_request_review_id":178756811,"id":236643354,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjY0MzM1NA==","diff_hunk":"@@ -31,4 +51,145 @@ public JobExecutionServiceImpl(Vertx vertx, String tenantId) {\n         .withTotalRecords(jobExecutionCollection.getTotalRecords()));\n   }\n \n+  public Future<InitJobExecutionsRsDto> initializeJobExecutions(InitJobExecutionsRqDto jobExecutionsRqDto, OkapiConnectionParams params) {\n+    if (jobExecutionsRqDto.getFiles().isEmpty()) {\n+      logger.error(\"Received files must not be empty\");\n+      return Future.failedFuture(new BadRequestException());","path":"src/main/java/org/folio/services/JobExecutionServiceImpl.java","position":49,"original_position":49,"commit_id":"b0f0da71d065007d4110ec6e00f1024bbdc674ac","original_commit_id":"b0f0da71d065007d4110ec6e00f1024bbdc674ac","user":{"login":"KaterynaSenchenko","id":42532596,"node_id":"MDQ6VXNlcjQyNTMyNTk2","avatar_url":"https://avatars1.githubusercontent.com/u/42532596?v=4","gravatar_id":"","url":"https://api.github.com/users/KaterynaSenchenko","html_url":"https://github.com/KaterynaSenchenko","followers_url":"https://api.github.com/users/KaterynaSenchenko/followers","following_url":"https://api.github.com/users/KaterynaSenchenko/following{/other_user}","gists_url":"https://api.github.com/users/KaterynaSenchenko/gists{/gist_id}","starred_url":"https://api.github.com/users/KaterynaSenchenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KaterynaSenchenko/subscriptions","organizations_url":"https://api.github.com/users/KaterynaSenchenko/orgs","repos_url":"https://api.github.com/users/KaterynaSenchenko/repos","events_url":"https://api.github.com/users/KaterynaSenchenko/events{/privacy}","received_events_url":"https://api.github.com/users/KaterynaSenchenko/received_events","type":"User","site_admin":false},"body":"Please add a message to the exception","created_at":"2018-11-27T12:35:41Z","updated_at":"2018-11-27T12:45:18Z","html_url":"https://github.com/folio-org/mod-source-record-manager/pull/14#discussion_r236643354","pull_request_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/pulls/14","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/folio-org/mod-source-record-manager/pulls/comments/236643354"},"html":{"href":"https://github.com/folio-org/mod-source-record-manager/pull/14#discussion_r236643354"},"pull_request":{"href":"https://api.github.com/repos/folio-org/mod-source-record-manager/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/folio-org/mod-source-record-manager/pulls/14","id":233536646,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNTM2NjQ2","html_url":"https://github.com/folio-org/mod-source-record-manager/pull/14","diff_url":"https://github.com/folio-org/mod-source-record-manager/pull/14.diff","patch_url":"https://github.com/folio-org/mod-source-record-manager/pull/14.patch","issue_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/issues/14","number":14,"state":"open","locked":false,"title":"Modsourman 9 Initializing job executions","user":{"login":"Igor-Gorchakov","id":40858461,"node_id":"MDQ6VXNlcjQwODU4NDYx","avatar_url":"https://avatars3.githubusercontent.com/u/40858461?v=4","gravatar_id":"","url":"https://api.github.com/users/Igor-Gorchakov","html_url":"https://github.com/Igor-Gorchakov","followers_url":"https://api.github.com/users/Igor-Gorchakov/followers","following_url":"https://api.github.com/users/Igor-Gorchakov/following{/other_user}","gists_url":"https://api.github.com/users/Igor-Gorchakov/gists{/gist_id}","starred_url":"https://api.github.com/users/Igor-Gorchakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Igor-Gorchakov/subscriptions","organizations_url":"https://api.github.com/users/Igor-Gorchakov/orgs","repos_url":"https://api.github.com/users/Igor-Gorchakov/repos","events_url":"https://api.github.com/users/Igor-Gorchakov/events{/privacy}","received_events_url":"https://api.github.com/users/Igor-Gorchakov/received_events","type":"User","site_admin":false},"body":"- REST method receives InitJobExecutionsRqDto with files,\r\n- Service method does parentJobExecutionId generation,\r\n- Service method prepares a necessary amount of JobExecution entities,\r\n- Service method prepares a necessary amount Snapshot json entities,\r\n- Service method does save prepared JobExecution entities using DAO,\r\n- Service method calls mod-source-record-storage to save prepared Snapshots,\r\n- Service method completes future and returns InitJobExecutionsRsDto with parentJobExecutionId and prepared JobExecution entities,\r\n- REST method returns response containing InitJobExecutionsRsDto","created_at":"2018-11-26T12:13:56Z","updated_at":"2018-11-27T12:45:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"29d0b999a1b3e1c202aa0d58f3d0150e0fb2eba2","assignee":null,"assignees":[],"requested_reviewers":[{"login":"VictorSoroka1","id":40821852,"node_id":"MDQ6VXNlcjQwODIxODUy","avatar_url":"https://avatars3.githubusercontent.com/u/40821852?v=4","gravatar_id":"","url":"https://api.github.com/users/VictorSoroka1","html_url":"https://github.com/VictorSoroka1","followers_url":"https://api.github.com/users/VictorSoroka1/followers","following_url":"https://api.github.com/users/VictorSoroka1/following{/other_user}","gists_url":"https://api.github.com/users/VictorSoroka1/gists{/gist_id}","starred_url":"https://api.github.com/users/VictorSoroka1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VictorSoroka1/subscriptions","organizations_url":"https://api.github.com/users/VictorSoroka1/orgs","repos_url":"https://api.github.com/users/VictorSoroka1/repos","events_url":"https://api.github.com/users/VictorSoroka1/events{/privacy}","received_events_url":"https://api.github.com/users/VictorSoroka1/received_events","type":"User","site_admin":false},{"login":"TarasSpashchenko","id":41001394,"node_id":"MDQ6VXNlcjQxMDAxMzk0","avatar_url":"https://avatars0.githubusercontent.com/u/41001394?v=4","gravatar_id":"","url":"https://api.github.com/users/TarasSpashchenko","html_url":"https://github.com/TarasSpashchenko","followers_url":"https://api.github.com/users/TarasSpashchenko/followers","following_url":"https://api.github.com/users/TarasSpashchenko/following{/other_user}","gists_url":"https://api.github.com/users/TarasSpashchenko/gists{/gist_id}","starred_url":"https://api.github.com/users/TarasSpashchenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TarasSpashchenko/subscriptions","organizations_url":"https://api.github.com/users/TarasSpashchenko/orgs","repos_url":"https://api.github.com/users/TarasSpashchenko/repos","events_url":"https://api.github.com/users/TarasSpashchenko/events{/privacy}","received_events_url":"https://api.github.com/users/TarasSpashchenko/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/pulls/14/commits","review_comments_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/pulls/14/comments","review_comment_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/issues/14/comments","statuses_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/statuses/b0f0da71d065007d4110ec6e00f1024bbdc674ac","head":{"label":"folio-org:MODSOURMAN-9_jobExec_init_impl","ref":"MODSOURMAN-9_jobExec_init_impl","sha":"b0f0da71d065007d4110ec6e00f1024bbdc674ac","user":{"login":"folio-org","id":16495055,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDk1MDU1","avatar_url":"https://avatars2.githubusercontent.com/u/16495055?v=4","gravatar_id":"","url":"https://api.github.com/users/folio-org","html_url":"https://github.com/folio-org","followers_url":"https://api.github.com/users/folio-org/followers","following_url":"https://api.github.com/users/folio-org/following{/other_user}","gists_url":"https://api.github.com/users/folio-org/gists{/gist_id}","starred_url":"https://api.github.com/users/folio-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/folio-org/subscriptions","organizations_url":"https://api.github.com/users/folio-org/orgs","repos_url":"https://api.github.com/users/folio-org/repos","events_url":"https://api.github.com/users/folio-org/events{/privacy}","received_events_url":"https://api.github.com/users/folio-org/received_events","type":"Organization","site_admin":false},"repo":{"id":151219023,"node_id":"MDEwOlJlcG9zaXRvcnkxNTEyMTkwMjM=","name":"mod-source-record-manager","full_name":"folio-org/mod-source-record-manager","private":false,"owner":{"login":"folio-org","id":16495055,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDk1MDU1","avatar_url":"https://avatars2.githubusercontent.com/u/16495055?v=4","gravatar_id":"","url":"https://api.github.com/users/folio-org","html_url":"https://github.com/folio-org","followers_url":"https://api.github.com/users/folio-org/followers","following_url":"https://api.github.com/users/folio-org/following{/other_user}","gists_url":"https://api.github.com/users/folio-org/gists{/gist_id}","starred_url":"https://api.github.com/users/folio-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/folio-org/subscriptions","organizations_url":"https://api.github.com/users/folio-org/orgs","repos_url":"https://api.github.com/users/folio-org/repos","events_url":"https://api.github.com/users/folio-org/events{/privacy}","received_events_url":"https://api.github.com/users/folio-org/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/folio-org/mod-source-record-manager","description":null,"fork":false,"url":"https://api.github.com/repos/folio-org/mod-source-record-manager","forks_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/forks","keys_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/teams","hooks_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/hooks","issue_events_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/issues/events{/number}","events_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/events","assignees_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/assignees{/user}","branches_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/branches{/branch}","tags_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/tags","blobs_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/languages","stargazers_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/stargazers","contributors_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/contributors","subscribers_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/subscribers","subscription_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/subscription","commits_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/contents/{+path}","compare_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/merges","archive_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/downloads","issues_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/issues{/number}","pulls_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/labels{/name}","releases_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/releases{/id}","deployments_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/deployments","created_at":"2018-10-02T07:48:36Z","updated_at":"2018-11-22T15:19:43Z","pushed_at":"2018-11-27T10:54:26Z","git_url":"git://github.com/folio-org/mod-source-record-manager.git","ssh_url":"git@github.com:folio-org/mod-source-record-manager.git","clone_url":"https://github.com/folio-org/mod-source-record-manager.git","svn_url":"https://github.com/folio-org/mod-source-record-manager","homepage":null,"size":106,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"folio-org:master","ref":"master","sha":"689359d80277c2d211248f318d7ace417bd348cb","user":{"login":"folio-org","id":16495055,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDk1MDU1","avatar_url":"https://avatars2.githubusercontent.com/u/16495055?v=4","gravatar_id":"","url":"https://api.github.com/users/folio-org","html_url":"https://github.com/folio-org","followers_url":"https://api.github.com/users/folio-org/followers","following_url":"https://api.github.com/users/folio-org/following{/other_user}","gists_url":"https://api.github.com/users/folio-org/gists{/gist_id}","starred_url":"https://api.github.com/users/folio-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/folio-org/subscriptions","organizations_url":"https://api.github.com/users/folio-org/orgs","repos_url":"https://api.github.com/users/folio-org/repos","events_url":"https://api.github.com/users/folio-org/events{/privacy}","received_events_url":"https://api.github.com/users/folio-org/received_events","type":"Organization","site_admin":false},"repo":{"id":151219023,"node_id":"MDEwOlJlcG9zaXRvcnkxNTEyMTkwMjM=","name":"mod-source-record-manager","full_name":"folio-org/mod-source-record-manager","private":false,"owner":{"login":"folio-org","id":16495055,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDk1MDU1","avatar_url":"https://avatars2.githubusercontent.com/u/16495055?v=4","gravatar_id":"","url":"https://api.github.com/users/folio-org","html_url":"https://github.com/folio-org","followers_url":"https://api.github.com/users/folio-org/followers","following_url":"https://api.github.com/users/folio-org/following{/other_user}","gists_url":"https://api.github.com/users/folio-org/gists{/gist_id}","starred_url":"https://api.github.com/users/folio-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/folio-org/subscriptions","organizations_url":"https://api.github.com/users/folio-org/orgs","repos_url":"https://api.github.com/users/folio-org/repos","events_url":"https://api.github.com/users/folio-org/events{/privacy}","received_events_url":"https://api.github.com/users/folio-org/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/folio-org/mod-source-record-manager","description":null,"fork":false,"url":"https://api.github.com/repos/folio-org/mod-source-record-manager","forks_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/forks","keys_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/teams","hooks_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/hooks","issue_events_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/issues/events{/number}","events_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/events","assignees_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/assignees{/user}","branches_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/branches{/branch}","tags_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/tags","blobs_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/languages","stargazers_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/stargazers","contributors_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/contributors","subscribers_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/subscribers","subscription_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/subscription","commits_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/contents/{+path}","compare_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/merges","archive_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/downloads","issues_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/issues{/number}","pulls_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/labels{/name}","releases_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/releases{/id}","deployments_url":"https://api.github.com/repos/folio-org/mod-source-record-manager/deployments","created_at":"2018-10-02T07:48:36Z","updated_at":"2018-11-22T15:19:43Z","pushed_at":"2018-11-27T10:54:26Z","git_url":"git://github.com/folio-org/mod-source-record-manager.git","ssh_url":"git@github.com:folio-org/mod-source-record-manager.git","clone_url":"https://github.com/folio-org/mod-source-record-manager.git","svn_url":"https://github.com/folio-org/mod-source-record-manager","homepage":null,"size":106,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/folio-org/mod-source-record-manager/pulls/14"},"html":{"href":"https://github.com/folio-org/mod-source-record-manager/pull/14"},"issue":{"href":"https://api.github.com/repos/folio-org/mod-source-record-manager/issues/14"},"comments":{"href":"https://api.github.com/repos/folio-org/mod-source-record-manager/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/folio-org/mod-source-record-manager/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/folio-org/mod-source-record-manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/folio-org/mod-source-record-manager/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/folio-org/mod-source-record-manager/statuses/b0f0da71d065007d4110ec6e00f1024bbdc674ac"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"KaterynaSenchenko"}}