{"action":"created","issue":{"url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/issues/1260","repository_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios","labels_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/issues/1260/labels{/name}","comments_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/issues/1260/comments","events_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/issues/1260/events","html_url":"https://github.com/mapbox/mapbox-navigation-ios/pull/1260","id":308695150,"number":1260,"title":"Improve snapping at maneuvers","user":{"login":"bsudekum","id":1058624,"avatar_url":"https://avatars0.githubusercontent.com/u/1058624?v=4","gravatar_id":"","url":"https://api.github.com/users/bsudekum","html_url":"https://github.com/bsudekum","followers_url":"https://api.github.com/users/bsudekum/followers","following_url":"https://api.github.com/users/bsudekum/following{/other_user}","gists_url":"https://api.github.com/users/bsudekum/gists{/gist_id}","starred_url":"https://api.github.com/users/bsudekum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsudekum/subscriptions","organizations_url":"https://api.github.com/users/bsudekum/orgs","repos_url":"https://api.github.com/users/bsudekum/repos","events_url":"https://api.github.com/users/bsudekum/events{/privacy}","received_events_url":"https://api.github.com/users/bsudekum/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/milestones/17","html_url":"https://github.com/mapbox/mapbox-navigation-ios/milestone/17","labels_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/milestones/17/labels","id":3210394,"number":17,"title":"v0.17.0","description":"","creator":{"login":"bsudekum","id":1058624,"avatar_url":"https://avatars0.githubusercontent.com/u/1058624?v=4","gravatar_id":"","url":"https://api.github.com/users/bsudekum","html_url":"https://github.com/bsudekum","followers_url":"https://api.github.com/users/bsudekum/followers","following_url":"https://api.github.com/users/bsudekum/following{/other_user}","gists_url":"https://api.github.com/users/bsudekum/gists{/gist_id}","starred_url":"https://api.github.com/users/bsudekum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsudekum/subscriptions","organizations_url":"https://api.github.com/users/bsudekum/orgs","repos_url":"https://api.github.com/users/bsudekum/repos","events_url":"https://api.github.com/users/bsudekum/events{/privacy}","received_events_url":"https://api.github.com/users/bsudekum/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":0,"state":"open","created_at":"2018-03-22T20:01:11Z","updated_at":"2018-03-26T19:40:24Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2018-03-26T18:59:16Z","updated_at":"2018-03-26T20:01:01Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/1260","html_url":"https://github.com/mapbox/mapbox-navigation-ios/pull/1260","diff_url":"https://github.com/mapbox/mapbox-navigation-ios/pull/1260.diff","patch_url":"https://github.com/mapbox/mapbox-navigation-ios/pull/1260.patch"},"body":"Closes: https://github.com/mapbox/mapbox-navigation-ios/issues/1078 & https://github.com/mapbox/mapbox-navigation-ios/issues/939\r\n\r\nI did some tests this weekend and logged each time the puck becomes unsnapped while on a route. Basically, on any 90 degree turn, the puck always becomes unsnapped momentarily. To counteract this, I increased `RouteSnappingMaxManipulatedCourseAngle` to 36 in https://github.com/mapbox/mapbox-navigation-ios/commit/5b84e08a1547adb2e886ab74c19ea668a7dd565e. This was a value I found that worked well from many tests I did.\r\n\r\nAlso, to reduce the amount of back and forth shuffling the puck does when at a maneuver location, I changed a new property on RouteProgress `currentAndUpcomingCoordinates`, which is similar to `nearbyCoordinates` but only looks at the current and upcoming step coordinates. This way when you are at the start of a new step, the snapped location can not move backwards onto the previous step.\r\n\r\n/cc @mapbox/navigation-ios "},"comment":{"url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/issues/comments/376292849","html_url":"https://github.com/mapbox/mapbox-navigation-ios/pull/1260#issuecomment-376292849","issue_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/issues/1260","id":376292849,"user":{"login":"bsudekum","id":1058624,"avatar_url":"https://avatars0.githubusercontent.com/u/1058624?v=4","gravatar_id":"","url":"https://api.github.com/users/bsudekum","html_url":"https://github.com/bsudekum","followers_url":"https://api.github.com/users/bsudekum/followers","following_url":"https://api.github.com/users/bsudekum/following{/other_user}","gists_url":"https://api.github.com/users/bsudekum/gists{/gist_id}","starred_url":"https://api.github.com/users/bsudekum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsudekum/subscriptions","organizations_url":"https://api.github.com/users/bsudekum/orgs","repos_url":"https://api.github.com/users/bsudekum/repos","events_url":"https://api.github.com/users/bsudekum/events{/privacy}","received_events_url":"https://api.github.com/users/bsudekum/received_events","type":"User","site_admin":false},"created_at":"2018-03-26T20:01:01Z","updated_at":"2018-03-26T20:01:01Z","author_association":"COLLABORATOR","body":"Noting, this should be extensively tested on device."}}
{"actor":{"display_login":"bsudekum"}}