{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/etcd/pulls/comments/197557578","pull_request_review_id":131333112,"id":197557578,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzU1NzU3OA==","diff_hunk":"@@ -72,6 +72,9 @@ type Watcher interface {\n \n \t// Close closes the watcher and cancels all watch requests.\n \tClose() error\n+\n+\t// RequestProgress requests a progress notify response be sent in all watch channels.\n+\tRequestProgress(ctx context.Context) error","path":"clientv3/watch.go","position":null,"original_position":6,"commit_id":"eb541e7adad2f57f442baad74d3401bc0d82b7df","original_commit_id":"fb75b831ed9fe9c3d6c0faaf8d3f0a1808492206","user":{"login":"jpbetz","id":523590,"node_id":"MDQ6VXNlcjUyMzU5MA==","avatar_url":"https://avatars1.githubusercontent.com/u/523590?v=4","gravatar_id":"","url":"https://api.github.com/users/jpbetz","html_url":"https://github.com/jpbetz","followers_url":"https://api.github.com/users/jpbetz/followers","following_url":"https://api.github.com/users/jpbetz/following{/other_user}","gists_url":"https://api.github.com/users/jpbetz/gists{/gist_id}","starred_url":"https://api.github.com/users/jpbetz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpbetz/subscriptions","organizations_url":"https://api.github.com/users/jpbetz/orgs","repos_url":"https://api.github.com/users/jpbetz/repos","events_url":"https://api.github.com/users/jpbetz/events{/privacy}","received_events_url":"https://api.github.com/users/jpbetz/received_events","type":"User","site_admin":false},"body":"Thanks @xiang90, I've moved above `Close()`.","created_at":"2018-06-22T20:14:27Z","updated_at":"2018-06-22T20:14:28Z","html_url":"https://github.com/coreos/etcd/pull/9869#discussion_r197557578","pull_request_url":"https://api.github.com/repos/coreos/etcd/pulls/9869","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/coreos/etcd/pulls/comments/197557578"},"html":{"href":"https://github.com/coreos/etcd/pull/9869#discussion_r197557578"},"pull_request":{"href":"https://api.github.com/repos/coreos/etcd/pulls/9869"}},"in_reply_to_id":197556723},"pull_request":{"url":"https://api.github.com/repos/coreos/etcd/pulls/9869","id":195993397,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1OTkzMzk3","html_url":"https://github.com/coreos/etcd/pull/9869","diff_url":"https://github.com/coreos/etcd/pull/9869.diff","patch_url":"https://github.com/coreos/etcd/pull/9869.patch","issue_url":"https://api.github.com/repos/coreos/etcd/issues/9869","number":9869,"state":"open","locked":false,"title":"*: Add progress notify request watch request","user":{"login":"jpbetz","id":523590,"node_id":"MDQ6VXNlcjUyMzU5MA==","avatar_url":"https://avatars1.githubusercontent.com/u/523590?v=4","gravatar_id":"","url":"https://api.github.com/users/jpbetz","html_url":"https://github.com/jpbetz","followers_url":"https://api.github.com/users/jpbetz/followers","following_url":"https://api.github.com/users/jpbetz/following{/other_user}","gists_url":"https://api.github.com/users/jpbetz/gists{/gist_id}","starred_url":"https://api.github.com/users/jpbetz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpbetz/subscriptions","organizations_url":"https://api.github.com/users/jpbetz/orgs","repos_url":"https://api.github.com/users/jpbetz/repos","events_url":"https://api.github.com/users/jpbetz/events{/privacy}","received_events_url":"https://api.github.com/users/jpbetz/received_events","type":"User","site_admin":false},"body":"Add `RequestProgress` function to `Watcher` interface to request a progress notify response in all watch channels.\r\n\r\nThat can be used to check if a watcher is \"caught up\" to a particular revision, which is useful when determining if a watch cache is stale by comparing the progress revision to the revision returned in a quorum read.\r\n\r\nNote that this also changes how progress notify events are communicated. They are now broadcast to all watch channels.\r\n\r\nFixes https://github.com/coreos/etcd/issues/9855\r\n\r\nExample etcdctl usage:\r\n\r\n```\r\nETCDCTL_API=3 bin/etcdctl watch --interactive\r\nwatch a\r\nprogress\r\nprogress notify: 14\r\nwatch b\r\nprogress\r\nprogress notify: 14\r\nprogress notify: 14 # since progress notify is broadcast to both watch channels\r\n# In a separate terminal: ETCDCTL_API=3 bin/etcdctl put c 2\r\nprogress\r\nprogress notify: 15\r\n...\r\n```","created_at":"2018-06-20T00:32:37Z","updated_at":"2018-06-22T20:14:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27d9ea241d64adc1767c9c5e01b159ffe56c9d51","assignee":{"login":"jpbetz","id":523590,"node_id":"MDQ6VXNlcjUyMzU5MA==","avatar_url":"https://avatars1.githubusercontent.com/u/523590?v=4","gravatar_id":"","url":"https://api.github.com/users/jpbetz","html_url":"https://github.com/jpbetz","followers_url":"https://api.github.com/users/jpbetz/followers","following_url":"https://api.github.com/users/jpbetz/following{/other_user}","gists_url":"https://api.github.com/users/jpbetz/gists{/gist_id}","starred_url":"https://api.github.com/users/jpbetz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpbetz/subscriptions","organizations_url":"https://api.github.com/users/jpbetz/orgs","repos_url":"https://api.github.com/users/jpbetz/repos","events_url":"https://api.github.com/users/jpbetz/events{/privacy}","received_events_url":"https://api.github.com/users/jpbetz/received_events","type":"User","site_admin":false},"assignees":[{"login":"jpbetz","id":523590,"node_id":"MDQ6VXNlcjUyMzU5MA==","avatar_url":"https://avatars1.githubusercontent.com/u/523590?v=4","gravatar_id":"","url":"https://api.github.com/users/jpbetz","html_url":"https://github.com/jpbetz","followers_url":"https://api.github.com/users/jpbetz/followers","following_url":"https://api.github.com/users/jpbetz/following{/other_user}","gists_url":"https://api.github.com/users/jpbetz/gists{/gist_id}","starred_url":"https://api.github.com/users/jpbetz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpbetz/subscriptions","organizations_url":"https://api.github.com/users/jpbetz/orgs","repos_url":"https://api.github.com/users/jpbetz/repos","events_url":"https://api.github.com/users/jpbetz/events{/privacy}","received_events_url":"https://api.github.com/users/jpbetz/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":848119238,"node_id":"MDU6TGFiZWw4NDgxMTkyMzg=","url":"https://api.github.com/repos/coreos/etcd/labels/Feature","name":"Feature","color":"bafcff","default":false},{"id":779075709,"node_id":"MDU6TGFiZWw3NzkwNzU3MDk=","url":"https://api.github.com/repos/coreos/etcd/labels/Release-Note","name":"Release-Note","color":"40C4FF","default":false},{"id":175394513,"node_id":"MDU6TGFiZWwxNzUzOTQ1MTM=","url":"https://api.github.com/repos/coreos/etcd/labels/clientv3","name":"clientv3","color":"FFEB3B","default":false}],"milestone":{"url":"https://api.github.com/repos/coreos/etcd/milestones/36","html_url":"https://github.com/coreos/etcd/milestone/36","labels_url":"https://api.github.com/repos/coreos/etcd/milestones/36/labels","id":2696891,"node_id":"MDk6TWlsZXN0b25lMjY5Njg5MQ==","number":36,"title":"etcd-v3.4","description":"","creator":{"login":"gyuho","id":6799218,"node_id":"MDQ6VXNlcjY3OTkyMTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6799218?v=4","gravatar_id":"","url":"https://api.github.com/users/gyuho","html_url":"https://github.com/gyuho","followers_url":"https://api.github.com/users/gyuho/followers","following_url":"https://api.github.com/users/gyuho/following{/other_user}","gists_url":"https://api.github.com/users/gyuho/gists{/gist_id}","starred_url":"https://api.github.com/users/gyuho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gyuho/subscriptions","organizations_url":"https://api.github.com/users/gyuho/orgs","repos_url":"https://api.github.com/users/gyuho/repos","events_url":"https://api.github.com/users/gyuho/events{/privacy}","received_events_url":"https://api.github.com/users/gyuho/received_events","type":"User","site_admin":false},"open_issues":50,"closed_issues":48,"state":"open","created_at":"2017-08-11T17:16:06Z","updated_at":"2018-06-20T00:32:38Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/coreos/etcd/pulls/9869/commits","review_comments_url":"https://api.github.com/repos/coreos/etcd/pulls/9869/comments","review_comment_url":"https://api.github.com/repos/coreos/etcd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/etcd/issues/9869/comments","statuses_url":"https://api.github.com/repos/coreos/etcd/statuses/eb541e7adad2f57f442baad74d3401bc0d82b7df","head":{"label":"jpbetz:progress","ref":"progress","sha":"eb541e7adad2f57f442baad74d3401bc0d82b7df","user":{"login":"jpbetz","id":523590,"node_id":"MDQ6VXNlcjUyMzU5MA==","avatar_url":"https://avatars1.githubusercontent.com/u/523590?v=4","gravatar_id":"","url":"https://api.github.com/users/jpbetz","html_url":"https://github.com/jpbetz","followers_url":"https://api.github.com/users/jpbetz/followers","following_url":"https://api.github.com/users/jpbetz/following{/other_user}","gists_url":"https://api.github.com/users/jpbetz/gists{/gist_id}","starred_url":"https://api.github.com/users/jpbetz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpbetz/subscriptions","organizations_url":"https://api.github.com/users/jpbetz/orgs","repos_url":"https://api.github.com/users/jpbetz/repos","events_url":"https://api.github.com/users/jpbetz/events{/privacy}","received_events_url":"https://api.github.com/users/jpbetz/received_events","type":"User","site_admin":false},"repo":{"id":97672540,"node_id":"MDEwOlJlcG9zaXRvcnk5NzY3MjU0MA==","name":"etcd","full_name":"jpbetz/etcd","owner":{"login":"jpbetz","id":523590,"node_id":"MDQ6VXNlcjUyMzU5MA==","avatar_url":"https://avatars1.githubusercontent.com/u/523590?v=4","gravatar_id":"","url":"https://api.github.com/users/jpbetz","html_url":"https://github.com/jpbetz","followers_url":"https://api.github.com/users/jpbetz/followers","following_url":"https://api.github.com/users/jpbetz/following{/other_user}","gists_url":"https://api.github.com/users/jpbetz/gists{/gist_id}","starred_url":"https://api.github.com/users/jpbetz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpbetz/subscriptions","organizations_url":"https://api.github.com/users/jpbetz/orgs","repos_url":"https://api.github.com/users/jpbetz/repos","events_url":"https://api.github.com/users/jpbetz/events{/privacy}","received_events_url":"https://api.github.com/users/jpbetz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jpbetz/etcd","description":"Distributed reliable key-value store for the most critical data of a distributed system","fork":true,"url":"https://api.github.com/repos/jpbetz/etcd","forks_url":"https://api.github.com/repos/jpbetz/etcd/forks","keys_url":"https://api.github.com/repos/jpbetz/etcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jpbetz/etcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jpbetz/etcd/teams","hooks_url":"https://api.github.com/repos/jpbetz/etcd/hooks","issue_events_url":"https://api.github.com/repos/jpbetz/etcd/issues/events{/number}","events_url":"https://api.github.com/repos/jpbetz/etcd/events","assignees_url":"https://api.github.com/repos/jpbetz/etcd/assignees{/user}","branches_url":"https://api.github.com/repos/jpbetz/etcd/branches{/branch}","tags_url":"https://api.github.com/repos/jpbetz/etcd/tags","blobs_url":"https://api.github.com/repos/jpbetz/etcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jpbetz/etcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jpbetz/etcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/jpbetz/etcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jpbetz/etcd/statuses/{sha}","languages_url":"https://api.github.com/repos/jpbetz/etcd/languages","stargazers_url":"https://api.github.com/repos/jpbetz/etcd/stargazers","contributors_url":"https://api.github.com/repos/jpbetz/etcd/contributors","subscribers_url":"https://api.github.com/repos/jpbetz/etcd/subscribers","subscription_url":"https://api.github.com/repos/jpbetz/etcd/subscription","commits_url":"https://api.github.com/repos/jpbetz/etcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/jpbetz/etcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/jpbetz/etcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/jpbetz/etcd/issues/comments{/number}","contents_url":"https://api.github.com/repos/jpbetz/etcd/contents/{+path}","compare_url":"https://api.github.com/repos/jpbetz/etcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jpbetz/etcd/merges","archive_url":"https://api.github.com/repos/jpbetz/etcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jpbetz/etcd/downloads","issues_url":"https://api.github.com/repos/jpbetz/etcd/issues{/number}","pulls_url":"https://api.github.com/repos/jpbetz/etcd/pulls{/number}","milestones_url":"https://api.github.com/repos/jpbetz/etcd/milestones{/number}","notifications_url":"https://api.github.com/repos/jpbetz/etcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jpbetz/etcd/labels{/name}","releases_url":"https://api.github.com/repos/jpbetz/etcd/releases{/id}","deployments_url":"https://api.github.com/repos/jpbetz/etcd/deployments","created_at":"2017-07-19T04:23:21Z","updated_at":"2017-07-19T04:23:26Z","pushed_at":"2018-06-22T20:14:23Z","git_url":"git://github.com/jpbetz/etcd.git","ssh_url":"git@github.com:jpbetz/etcd.git","clone_url":"https://github.com/jpbetz/etcd.git","svn_url":"https://github.com/jpbetz/etcd","homepage":"https://coreos.com/etcd/docs/latest/","size":42824,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"8f6348a97d483316c5039d6bbc2f66ba2c00e1d0","user":{"login":"coreos","id":3730757,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MzA3NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/3730757?v=4","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":11225014,"node_id":"MDEwOlJlcG9zaXRvcnkxMTIyNTAxNA==","name":"etcd","full_name":"coreos/etcd","owner":{"login":"coreos","id":3730757,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MzA3NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/3730757?v=4","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/etcd","description":"Distributed reliable key-value store for the most critical data of a distributed system","fork":false,"url":"https://api.github.com/repos/coreos/etcd","forks_url":"https://api.github.com/repos/coreos/etcd/forks","keys_url":"https://api.github.com/repos/coreos/etcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/etcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/etcd/teams","hooks_url":"https://api.github.com/repos/coreos/etcd/hooks","issue_events_url":"https://api.github.com/repos/coreos/etcd/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/etcd/events","assignees_url":"https://api.github.com/repos/coreos/etcd/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/etcd/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/etcd/tags","blobs_url":"https://api.github.com/repos/coreos/etcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/etcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/etcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/etcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/etcd/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/etcd/languages","stargazers_url":"https://api.github.com/repos/coreos/etcd/stargazers","contributors_url":"https://api.github.com/repos/coreos/etcd/contributors","subscribers_url":"https://api.github.com/repos/coreos/etcd/subscribers","subscription_url":"https://api.github.com/repos/coreos/etcd/subscription","commits_url":"https://api.github.com/repos/coreos/etcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/etcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/etcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/etcd/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/etcd/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/etcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/etcd/merges","archive_url":"https://api.github.com/repos/coreos/etcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/etcd/downloads","issues_url":"https://api.github.com/repos/coreos/etcd/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/etcd/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/etcd/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/etcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/etcd/labels{/name}","releases_url":"https://api.github.com/repos/coreos/etcd/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/etcd/deployments","created_at":"2013-07-06T21:57:21Z","updated_at":"2018-06-22T17:58:35Z","pushed_at":"2018-06-22T20:14:26Z","git_url":"git://github.com/coreos/etcd.git","ssh_url":"git@github.com:coreos/etcd.git","clone_url":"https://github.com/coreos/etcd.git","svn_url":"https://github.com/coreos/etcd","homepage":"https://coreos.com/etcd/docs/latest","size":42821,"stargazers_count":18868,"watchers_count":18868,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3759,"mirror_url":null,"archived":false,"open_issues_count":258,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3759,"open_issues":258,"watchers":18868,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/etcd/pulls/9869"},"html":{"href":"https://github.com/coreos/etcd/pull/9869"},"issue":{"href":"https://api.github.com/repos/coreos/etcd/issues/9869"},"comments":{"href":"https://api.github.com/repos/coreos/etcd/issues/9869/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/etcd/pulls/9869/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/etcd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/etcd/pulls/9869/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/etcd/statuses/eb541e7adad2f57f442baad74d3401bc0d82b7df"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jpbetz"}}