{"action":"created","issue":{"url":"https://api.github.com/repos/mapsme/omim/issues/8771","repository_url":"https://api.github.com/repos/mapsme/omim","labels_url":"https://api.github.com/repos/mapsme/omim/issues/8771/labels{/name}","comments_url":"https://api.github.com/repos/mapsme/omim/issues/8771/comments","events_url":"https://api.github.com/repos/mapsme/omim/issues/8771/events","html_url":"https://github.com/mapsme/omim/pull/8771","id":326943220,"number":8771,"title":"[desktop] Fix numeric locale for desktop tests","user":{"login":"greshilov","id":814614,"avatar_url":"https://avatars1.githubusercontent.com/u/814614?v=4","gravatar_id":"","url":"https://api.github.com/users/greshilov","html_url":"https://github.com/greshilov","followers_url":"https://api.github.com/users/greshilov/followers","following_url":"https://api.github.com/users/greshilov/following{/other_user}","gists_url":"https://api.github.com/users/greshilov/gists{/gist_id}","starred_url":"https://api.github.com/users/greshilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greshilov/subscriptions","organizations_url":"https://api.github.com/users/greshilov/orgs","repos_url":"https://api.github.com/users/greshilov/repos","events_url":"https://api.github.com/users/greshilov/events{/privacy}","received_events_url":"https://api.github.com/users/greshilov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-28T08:33:06Z","updated_at":"2018-05-28T09:36:49Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/mapsme/omim/pulls/8771","html_url":"https://github.com/mapsme/omim/pull/8771","diff_url":"https://github.com/mapsme/omim/pull/8771.diff","patch_url":"https://github.com/mapsme/omim/pull/8771.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/mapsme/omim/issues/comments/392475514","html_url":"https://github.com/mapsme/omim/pull/8771#issuecomment-392475514","issue_url":"https://api.github.com/repos/mapsme/omim/issues/8771","id":392475514,"user":{"login":"mpimenov","id":10366009,"avatar_url":"https://avatars0.githubusercontent.com/u/10366009?v=4","gravatar_id":"","url":"https://api.github.com/users/mpimenov","html_url":"https://github.com/mpimenov","followers_url":"https://api.github.com/users/mpimenov/followers","following_url":"https://api.github.com/users/mpimenov/following{/other_user}","gists_url":"https://api.github.com/users/mpimenov/gists{/gist_id}","starred_url":"https://api.github.com/users/mpimenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpimenov/subscriptions","organizations_url":"https://api.github.com/users/mpimenov/orgs","repos_url":"https://api.github.com/users/mpimenov/repos","events_url":"https://api.github.com/users/mpimenov/events{/privacy}","received_events_url":"https://api.github.com/users/mpimenov/received_events","type":"User","site_admin":false},"created_at":"2018-05-28T09:36:49Z","updated_at":"2018-05-28T09:36:49Z","author_association":"CONTRIBUTOR","body":"Previous PR here: https://github.com/mapsme/omim/pull/996\r\n\r\n1. I don't really like the idea of changing env from within the test code. Why not pass when running the tests?\r\n2. One possible problem is that we are going to have all tests passing and the app will still crash. This PR will only make things worse: the code working with floating point textual representations should be as robust as possible.\r\n3. The common code from qt/main.cpp and this PR should be factored out, all comments and todos included. Consider adding https://github.com/google/double-conversion to the list of suggestions.\r\n"}}
{"actor":{"display_login":"mpimenov"}}