{"action":"created","issue":{"url":"https://api.github.com/repos/backdrop-contrib/xmlsitemap/issues/42","repository_url":"https://api.github.com/repos/backdrop-contrib/xmlsitemap","labels_url":"https://api.github.com/repos/backdrop-contrib/xmlsitemap/issues/42/labels{/name}","comments_url":"https://api.github.com/repos/backdrop-contrib/xmlsitemap/issues/42/comments","events_url":"https://api.github.com/repos/backdrop-contrib/xmlsitemap/issues/42/events","html_url":"https://github.com/backdrop-contrib/xmlsitemap/issues/42","id":255121000,"node_id":"MDU6SXNzdWUyNTUxMjEwMDA=","number":42,"title":"Arbitrary entities can break the settings form for XMLsitemap module","user":{"login":"jenlampton","id":397895,"node_id":"MDQ6VXNlcjM5Nzg5NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/397895?v=4","gravatar_id":"","url":"https://api.github.com/users/jenlampton","html_url":"https://github.com/jenlampton","followers_url":"https://api.github.com/users/jenlampton/followers","following_url":"https://api.github.com/users/jenlampton/following{/other_user}","gists_url":"https://api.github.com/users/jenlampton/gists{/gist_id}","starred_url":"https://api.github.com/users/jenlampton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenlampton/subscriptions","organizations_url":"https://api.github.com/users/jenlampton/orgs","repos_url":"https://api.github.com/users/jenlampton/repos","events_url":"https://api.github.com/users/jenlampton/events{/privacy}","received_events_url":"https://api.github.com/users/jenlampton/received_events","type":"User","site_admin":false},"labels":[{"id":239222769,"node_id":"MDU6TGFiZWwyMzkyMjI3Njk=","url":"https://api.github.com/repos/backdrop-contrib/xmlsitemap/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-09-04T21:48:52Z","updated_at":"2018-06-14T15:46:24Z","closed_at":null,"author_association":"MEMBER","body":"I know it seems unlikely, but I'm getting a multifield related db error on the xmlsitemap settings form:\r\n```\r\nPDOException: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'multifield.id' in 'where clause': SELECT COUNT(*) AS expression FROM (SELECT 1 AS expression FROM {multifield} multifield WHERE (multifield.id > :db_condition_placeholder_0) AND (multifield.type = :db_condition_placeholder_1) ) subquery; Array ( [:db_condition_placeholder_0] => 0 [:db_condition_placeholder_1] => field_list_items ) in xmlsitemap_get_link_type_indexed_status() (line 962 of backdrop/modules/contrib/xmlsitemap/xmlsitemap.module).\r\n```\r\nHowever, disabling the multifield module brought the XMLsitemap admin form back to life.\r\n\r\nSee related: https://github.com/backdrop-contrib/multifield/issues/12"},"comment":{"url":"https://api.github.com/repos/backdrop-contrib/xmlsitemap/issues/comments/397343135","html_url":"https://github.com/backdrop-contrib/xmlsitemap/issues/42#issuecomment-397343135","issue_url":"https://api.github.com/repos/backdrop-contrib/xmlsitemap/issues/42","id":397343135,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NzM0MzEzNQ==","user":{"login":"alexfinnarn","id":3640707,"node_id":"MDQ6VXNlcjM2NDA3MDc=","avatar_url":"https://avatars3.githubusercontent.com/u/3640707?v=4","gravatar_id":"","url":"https://api.github.com/users/alexfinnarn","html_url":"https://github.com/alexfinnarn","followers_url":"https://api.github.com/users/alexfinnarn/followers","following_url":"https://api.github.com/users/alexfinnarn/following{/other_user}","gists_url":"https://api.github.com/users/alexfinnarn/gists{/gist_id}","starred_url":"https://api.github.com/users/alexfinnarn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexfinnarn/subscriptions","organizations_url":"https://api.github.com/users/alexfinnarn/orgs","repos_url":"https://api.github.com/users/alexfinnarn/repos","events_url":"https://api.github.com/users/alexfinnarn/events{/privacy}","received_events_url":"https://api.github.com/users/alexfinnarn/received_events","type":"User","site_admin":false},"created_at":"2018-06-14T15:46:24Z","updated_at":"2018-06-14T15:46:24Z","author_association":"MEMBER","body":"@jenlampton I took a look at this, and it makes sense and seems to function the same as the 1.x branch. \r\n\r\nThe only question I have is about `hook_xmlsitemap_link_info()`. In the API file, it lists a lot of keys in the returned array when the PR only has whatever `entity_get_info()` returns. That might be enough information, but I doubt it has the XMLSitemap specific parts...not sure.\r\n\r\nIt looks like `xmlsitemap_get_link_info()` is the only function that calls `hook_xmlsitemap_link_info()` and it adds defaults for the link types if they don't exist. Right?\r\n\r\nI don't use this module currently, so I thought you might know more...thoughts?"}}
{"actor":{"display_login":"alexfinnarn"}}