{"action":"opened","number":397,"pull_request":{"url":"https://api.github.com/repos/kohler/click/pulls/397","id":185588599,"html_url":"https://github.com/kohler/click/pull/397","diff_url":"https://github.com/kohler/click/pull/397.diff","patch_url":"https://github.com/kohler/click/pull/397.patch","issue_url":"https://api.github.com/repos/kohler/click/issues/397","number":397,"state":"open","locked":false,"title":"KernelTun: Use IFF_NO_PI on Linux, remove LINUX_ETHERTAP mode","user":{"login":"piotrjurkiewicz","id":2237894,"avatar_url":"https://avatars0.githubusercontent.com/u/2237894?v=4","gravatar_id":"","url":"https://api.github.com/users/piotrjurkiewicz","html_url":"https://github.com/piotrjurkiewicz","followers_url":"https://api.github.com/users/piotrjurkiewicz/followers","following_url":"https://api.github.com/users/piotrjurkiewicz/following{/other_user}","gists_url":"https://api.github.com/users/piotrjurkiewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/piotrjurkiewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piotrjurkiewicz/subscriptions","organizations_url":"https://api.github.com/users/piotrjurkiewicz/orgs","repos_url":"https://api.github.com/users/piotrjurkiewicz/repos","events_url":"https://api.github.com/users/piotrjurkiewicz/events{/privacy}","received_events_url":"https://api.github.com/users/piotrjurkiewicz/received_events","type":"User","site_admin":false},"body":"This commit adds flag IFF_NO_PI to tun/tap interface settings on Linux. It flag changes frame format in order not to include protocol information header. That is, with this flag, frames received/send from tun/tap fd consist solely of raw underlying protocol (Ethernet/IP) frames.\r\n\r\nProtocol information header is not used by the element in any way, but its presence adds a requirement for pulling packet data on receive and pushing it before writing packet to the fd. Such a push becomes an expensive push when there is is no enough headroom in packet, for example when using native netmap buffers which do not have headroom.\r\n\r\nAdding IFF_NO_PI flag eliminates the need for pulling and pushing packet data completely.\r\n\r\nMoreover, this commit removes support for LINUX_ETHERTAP mode. Ethertap driver was removed from the kernel more than 15 years ago. Removal of this mode significantly simplifies the logic within the element.","created_at":"2018-05-02T23:44:19Z","updated_at":"2018-05-02T23:44:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kohler/click/pulls/397/commits","review_comments_url":"https://api.github.com/repos/kohler/click/pulls/397/comments","review_comment_url":"https://api.github.com/repos/kohler/click/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kohler/click/issues/397/comments","statuses_url":"https://api.github.com/repos/kohler/click/statuses/62432ff3511010c2f401a885c8a35a80c74ce529","head":{"label":"piotrjurkiewicz:master","ref":"master","sha":"62432ff3511010c2f401a885c8a35a80c74ce529","user":{"login":"piotrjurkiewicz","id":2237894,"avatar_url":"https://avatars0.githubusercontent.com/u/2237894?v=4","gravatar_id":"","url":"https://api.github.com/users/piotrjurkiewicz","html_url":"https://github.com/piotrjurkiewicz","followers_url":"https://api.github.com/users/piotrjurkiewicz/followers","following_url":"https://api.github.com/users/piotrjurkiewicz/following{/other_user}","gists_url":"https://api.github.com/users/piotrjurkiewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/piotrjurkiewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piotrjurkiewicz/subscriptions","organizations_url":"https://api.github.com/users/piotrjurkiewicz/orgs","repos_url":"https://api.github.com/users/piotrjurkiewicz/repos","events_url":"https://api.github.com/users/piotrjurkiewicz/events{/privacy}","received_events_url":"https://api.github.com/users/piotrjurkiewicz/received_events","type":"User","site_admin":false},"repo":{"id":131916383,"name":"click","full_name":"piotrjurkiewicz/click","owner":{"login":"piotrjurkiewicz","id":2237894,"avatar_url":"https://avatars0.githubusercontent.com/u/2237894?v=4","gravatar_id":"","url":"https://api.github.com/users/piotrjurkiewicz","html_url":"https://github.com/piotrjurkiewicz","followers_url":"https://api.github.com/users/piotrjurkiewicz/followers","following_url":"https://api.github.com/users/piotrjurkiewicz/following{/other_user}","gists_url":"https://api.github.com/users/piotrjurkiewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/piotrjurkiewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piotrjurkiewicz/subscriptions","organizations_url":"https://api.github.com/users/piotrjurkiewicz/orgs","repos_url":"https://api.github.com/users/piotrjurkiewicz/repos","events_url":"https://api.github.com/users/piotrjurkiewicz/events{/privacy}","received_events_url":"https://api.github.com/users/piotrjurkiewicz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/piotrjurkiewicz/click","description":"The Click modular router: fast modular packet processing and analysis","fork":true,"url":"https://api.github.com/repos/piotrjurkiewicz/click","forks_url":"https://api.github.com/repos/piotrjurkiewicz/click/forks","keys_url":"https://api.github.com/repos/piotrjurkiewicz/click/keys{/key_id}","collaborators_url":"https://api.github.com/repos/piotrjurkiewicz/click/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/piotrjurkiewicz/click/teams","hooks_url":"https://api.github.com/repos/piotrjurkiewicz/click/hooks","issue_events_url":"https://api.github.com/repos/piotrjurkiewicz/click/issues/events{/number}","events_url":"https://api.github.com/repos/piotrjurkiewicz/click/events","assignees_url":"https://api.github.com/repos/piotrjurkiewicz/click/assignees{/user}","branches_url":"https://api.github.com/repos/piotrjurkiewicz/click/branches{/branch}","tags_url":"https://api.github.com/repos/piotrjurkiewicz/click/tags","blobs_url":"https://api.github.com/repos/piotrjurkiewicz/click/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/piotrjurkiewicz/click/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/piotrjurkiewicz/click/git/refs{/sha}","trees_url":"https://api.github.com/repos/piotrjurkiewicz/click/git/trees{/sha}","statuses_url":"https://api.github.com/repos/piotrjurkiewicz/click/statuses/{sha}","languages_url":"https://api.github.com/repos/piotrjurkiewicz/click/languages","stargazers_url":"https://api.github.com/repos/piotrjurkiewicz/click/stargazers","contributors_url":"https://api.github.com/repos/piotrjurkiewicz/click/contributors","subscribers_url":"https://api.github.com/repos/piotrjurkiewicz/click/subscribers","subscription_url":"https://api.github.com/repos/piotrjurkiewicz/click/subscription","commits_url":"https://api.github.com/repos/piotrjurkiewicz/click/commits{/sha}","git_commits_url":"https://api.github.com/repos/piotrjurkiewicz/click/git/commits{/sha}","comments_url":"https://api.github.com/repos/piotrjurkiewicz/click/comments{/number}","issue_comment_url":"https://api.github.com/repos/piotrjurkiewicz/click/issues/comments{/number}","contents_url":"https://api.github.com/repos/piotrjurkiewicz/click/contents/{+path}","compare_url":"https://api.github.com/repos/piotrjurkiewicz/click/compare/{base}...{head}","merges_url":"https://api.github.com/repos/piotrjurkiewicz/click/merges","archive_url":"https://api.github.com/repos/piotrjurkiewicz/click/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/piotrjurkiewicz/click/downloads","issues_url":"https://api.github.com/repos/piotrjurkiewicz/click/issues{/number}","pulls_url":"https://api.github.com/repos/piotrjurkiewicz/click/pulls{/number}","milestones_url":"https://api.github.com/repos/piotrjurkiewicz/click/milestones{/number}","notifications_url":"https://api.github.com/repos/piotrjurkiewicz/click/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/piotrjurkiewicz/click/labels{/name}","releases_url":"https://api.github.com/repos/piotrjurkiewicz/click/releases{/id}","deployments_url":"https://api.github.com/repos/piotrjurkiewicz/click/deployments","created_at":"2018-05-02T23:29:40Z","updated_at":"2018-05-02T23:40:16Z","pushed_at":"2018-05-02T23:40:14Z","git_url":"git://github.com/piotrjurkiewicz/click.git","ssh_url":"git@github.com:piotrjurkiewicz/click.git","clone_url":"https://github.com/piotrjurkiewicz/click.git","svn_url":"https://github.com/piotrjurkiewicz/click","homepage":"","size":23882,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kohler:master","ref":"master","sha":"a46041412238420b26ca11ec88c7981942fb8b45","user":{"login":"kohler","id":410647,"avatar_url":"https://avatars2.githubusercontent.com/u/410647?v=4","gravatar_id":"","url":"https://api.github.com/users/kohler","html_url":"https://github.com/kohler","followers_url":"https://api.github.com/users/kohler/followers","following_url":"https://api.github.com/users/kohler/following{/other_user}","gists_url":"https://api.github.com/users/kohler/gists{/gist_id}","starred_url":"https://api.github.com/users/kohler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kohler/subscriptions","organizations_url":"https://api.github.com/users/kohler/orgs","repos_url":"https://api.github.com/users/kohler/repos","events_url":"https://api.github.com/users/kohler/events{/privacy}","received_events_url":"https://api.github.com/users/kohler/received_events","type":"User","site_admin":false},"repo":{"id":929129,"name":"click","full_name":"kohler/click","owner":{"login":"kohler","id":410647,"avatar_url":"https://avatars2.githubusercontent.com/u/410647?v=4","gravatar_id":"","url":"https://api.github.com/users/kohler","html_url":"https://github.com/kohler","followers_url":"https://api.github.com/users/kohler/followers","following_url":"https://api.github.com/users/kohler/following{/other_user}","gists_url":"https://api.github.com/users/kohler/gists{/gist_id}","starred_url":"https://api.github.com/users/kohler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kohler/subscriptions","organizations_url":"https://api.github.com/users/kohler/orgs","repos_url":"https://api.github.com/users/kohler/repos","events_url":"https://api.github.com/users/kohler/events{/privacy}","received_events_url":"https://api.github.com/users/kohler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kohler/click","description":"The Click modular router: fast modular packet processing and analysis","fork":false,"url":"https://api.github.com/repos/kohler/click","forks_url":"https://api.github.com/repos/kohler/click/forks","keys_url":"https://api.github.com/repos/kohler/click/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kohler/click/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kohler/click/teams","hooks_url":"https://api.github.com/repos/kohler/click/hooks","issue_events_url":"https://api.github.com/repos/kohler/click/issues/events{/number}","events_url":"https://api.github.com/repos/kohler/click/events","assignees_url":"https://api.github.com/repos/kohler/click/assignees{/user}","branches_url":"https://api.github.com/repos/kohler/click/branches{/branch}","tags_url":"https://api.github.com/repos/kohler/click/tags","blobs_url":"https://api.github.com/repos/kohler/click/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kohler/click/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kohler/click/git/refs{/sha}","trees_url":"https://api.github.com/repos/kohler/click/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kohler/click/statuses/{sha}","languages_url":"https://api.github.com/repos/kohler/click/languages","stargazers_url":"https://api.github.com/repos/kohler/click/stargazers","contributors_url":"https://api.github.com/repos/kohler/click/contributors","subscribers_url":"https://api.github.com/repos/kohler/click/subscribers","subscription_url":"https://api.github.com/repos/kohler/click/subscription","commits_url":"https://api.github.com/repos/kohler/click/commits{/sha}","git_commits_url":"https://api.github.com/repos/kohler/click/git/commits{/sha}","comments_url":"https://api.github.com/repos/kohler/click/comments{/number}","issue_comment_url":"https://api.github.com/repos/kohler/click/issues/comments{/number}","contents_url":"https://api.github.com/repos/kohler/click/contents/{+path}","compare_url":"https://api.github.com/repos/kohler/click/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kohler/click/merges","archive_url":"https://api.github.com/repos/kohler/click/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kohler/click/downloads","issues_url":"https://api.github.com/repos/kohler/click/issues{/number}","pulls_url":"https://api.github.com/repos/kohler/click/pulls{/number}","milestones_url":"https://api.github.com/repos/kohler/click/milestones{/number}","notifications_url":"https://api.github.com/repos/kohler/click/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kohler/click/labels{/name}","releases_url":"https://api.github.com/repos/kohler/click/releases{/id}","deployments_url":"https://api.github.com/repos/kohler/click/deployments","created_at":"2010-09-21T22:45:25Z","updated_at":"2018-05-02T16:23:15Z","pushed_at":"2018-03-04T22:38:48Z","git_url":"git://github.com/kohler/click.git","ssh_url":"git@github.com:kohler/click.git","clone_url":"https://github.com/kohler/click.git","svn_url":"https://github.com/kohler/click","homepage":"","size":23882,"stargazers_count":391,"watchers_count":391,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":222,"mirror_url":null,"archived":false,"open_issues_count":86,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":222,"open_issues":86,"watchers":391,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kohler/click/pulls/397"},"html":{"href":"https://github.com/kohler/click/pull/397"},"issue":{"href":"https://api.github.com/repos/kohler/click/issues/397"},"comments":{"href":"https://api.github.com/repos/kohler/click/issues/397/comments"},"review_comments":{"href":"https://api.github.com/repos/kohler/click/pulls/397/comments"},"review_comment":{"href":"https://api.github.com/repos/kohler/click/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kohler/click/pulls/397/commits"},"statuses":{"href":"https://api.github.com/repos/kohler/click/statuses/62432ff3511010c2f401a885c8a35a80c74ce529"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":17,"deletions":83,"changed_files":1}}
{"actor":{"display_login":"piotrjurkiewicz"}}