{"action":"created","comment":{"url":"https://api.github.com/repos/FairRootGroup/FairMQ/pulls/comments/228128729","pull_request_review_id":168324135,"id":228128729,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODEyODcyOQ==","diff_hunk":"@@ -14,9 +14,9 @@ set(@PROJECT_NAME@_GIT_VERSION @PROJECT_GIT_VERSION@)\n set(@PROJECT_NAME@_GIT_DATE @PROJECT_GIT_DATE@)\n \n set_and_check(@PROJECT_NAME@_ROOT @PACKAGE_CMAKE_INSTALL_PREFIX@)\n-set_and_check(@PROJECT_NAME@_BINDIR @PACKAGE_CMAKE_INSTALL_PREFIX@/@PROJECT_INSTALL_BINDIR@)\n-set_and_check(@PROJECT_NAME@_INCDIR @PACKAGE_CMAKE_INSTALL_PREFIX@/@CMAKE_INSTALL_INCLUDEDIR@)\n-set_and_check(@PROJECT_NAME@_LIBDIR @PACKAGE_CMAKE_INSTALL_PREFIX@/@PROJECT_INSTALL_LIBDIR@)\n+set_and_check(@PROJECT_NAME@_BINARY_DIR @PACKAGE_CMAKE_INSTALL_PREFIX@/@PROJECT_INSTALL_BINDIR@)\n+set_and_check(@PROJECT_NAME@_INCLUDE_DIRS @PACKAGE_CMAKE_INSTALL_PREFIX@/@CMAKE_INSTALL_INCLUDEDIR@)\n+set_and_check(@PROJECT_NAME@_LIBRARIES @PACKAGE_CMAKE_INSTALL_PREFIX@/@PROJECT_INSTALL_LIBDIR@)","path":"cmake/FairMQConfig.cmake.in","position":9,"original_position":9,"commit_id":"5c0b319275d254ed610216037122d86d5b84b1fa","original_commit_id":"5c0b319275d254ed610216037122d86d5b84b1fa","user":{"login":"geoffreyvd","id":9165933,"node_id":"MDQ6VXNlcjkxNjU5MzM=","avatar_url":"https://avatars3.githubusercontent.com/u/9165933?v=4","gravatar_id":"","url":"https://api.github.com/users/geoffreyvd","html_url":"https://github.com/geoffreyvd","followers_url":"https://api.github.com/users/geoffreyvd/followers","following_url":"https://api.github.com/users/geoffreyvd/following{/other_user}","gists_url":"https://api.github.com/users/geoffreyvd/gists{/gist_id}","starred_url":"https://api.github.com/users/geoffreyvd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoffreyvd/subscriptions","organizations_url":"https://api.github.com/users/geoffreyvd/orgs","repos_url":"https://api.github.com/users/geoffreyvd/repos","events_url":"https://api.github.com/users/geoffreyvd/events{/privacy}","received_events_url":"https://api.github.com/users/geoffreyvd/received_events","type":"User","site_admin":false},"body":"Also thank you for your response! \r\nI will indeed process your bulletpoints","created_at":"2018-10-25T11:02:36Z","updated_at":"2018-10-25T11:02:36Z","html_url":"https://github.com/FairRootGroup/FairMQ/pull/106#discussion_r228128729","pull_request_url":"https://api.github.com/repos/FairRootGroup/FairMQ/pulls/106","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/FairRootGroup/FairMQ/pulls/comments/228128729"},"html":{"href":"https://github.com/FairRootGroup/FairMQ/pull/106#discussion_r228128729"},"pull_request":{"href":"https://api.github.com/repos/FairRootGroup/FairMQ/pulls/106"}},"in_reply_to_id":226525715},"pull_request":{"url":"https://api.github.com/repos/FairRootGroup/FairMQ/pulls/106","id":224072912,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MDcyOTEy","html_url":"https://github.com/FairRootGroup/FairMQ/pull/106","diff_url":"https://github.com/FairRootGroup/FairMQ/pull/106.diff","patch_url":"https://github.com/FairRootGroup/FairMQ/pull/106.patch","issue_url":"https://api.github.com/repos/FairRootGroup/FairMQ/issues/106","number":106,"state":"open","locked":false,"title":"Use the cmake conventions in config.cmake","user":{"login":"geoffreyvd","id":9165933,"node_id":"MDQ6VXNlcjkxNjU5MzM=","avatar_url":"https://avatars3.githubusercontent.com/u/9165933?v=4","gravatar_id":"","url":"https://api.github.com/users/geoffreyvd","html_url":"https://github.com/geoffreyvd","followers_url":"https://api.github.com/users/geoffreyvd/followers","following_url":"https://api.github.com/users/geoffreyvd/following{/other_user}","gists_url":"https://api.github.com/users/geoffreyvd/gists{/gist_id}","starred_url":"https://api.github.com/users/geoffreyvd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoffreyvd/subscriptions","organizations_url":"https://api.github.com/users/geoffreyvd/orgs","repos_url":"https://api.github.com/users/geoffreyvd/repos","events_url":"https://api.github.com/users/geoffreyvd/events{/privacy}","received_events_url":"https://api.github.com/users/geoffreyvd/received_events","type":"User","site_admin":false},"body":"Reflecting the cmake config name conventions: \r\nhttps://cmake.org/cmake/help/v3.1/manual/cmake-developer.7.html#standard-variable-names\r\nInstead of each user having to find out the variable names by himself (by reading the config file), conventions should be used.\r\n\r\n---\r\n\r\nChecklist:\r\n\r\n* [x] Rebased against `dev` branch\r\n* [x] My name is in the resp. CONTRIBUTORS/AUTHORS file\r\n* [x] Followed [the seven rules of great commit messages](https://chris.beams.io/posts/git-commit/#seven-rules)\r\n","created_at":"2018-10-18T19:32:16Z","updated_at":"2018-10-25T11:02:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4cd4f8603a2221239bff257406ebd96b25e2dda9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/FairRootGroup/FairMQ/pulls/106/commits","review_comments_url":"https://api.github.com/repos/FairRootGroup/FairMQ/pulls/106/comments","review_comment_url":"https://api.github.com/repos/FairRootGroup/FairMQ/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FairRootGroup/FairMQ/issues/106/comments","statuses_url":"https://api.github.com/repos/FairRootGroup/FairMQ/statuses/5c0b319275d254ed610216037122d86d5b84b1fa","head":{"label":"geoffreyvd:dev","ref":"dev","sha":"5c0b319275d254ed610216037122d86d5b84b1fa","user":{"login":"geoffreyvd","id":9165933,"node_id":"MDQ6VXNlcjkxNjU5MzM=","avatar_url":"https://avatars3.githubusercontent.com/u/9165933?v=4","gravatar_id":"","url":"https://api.github.com/users/geoffreyvd","html_url":"https://github.com/geoffreyvd","followers_url":"https://api.github.com/users/geoffreyvd/followers","following_url":"https://api.github.com/users/geoffreyvd/following{/other_user}","gists_url":"https://api.github.com/users/geoffreyvd/gists{/gist_id}","starred_url":"https://api.github.com/users/geoffreyvd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoffreyvd/subscriptions","organizations_url":"https://api.github.com/users/geoffreyvd/orgs","repos_url":"https://api.github.com/users/geoffreyvd/repos","events_url":"https://api.github.com/users/geoffreyvd/events{/privacy}","received_events_url":"https://api.github.com/users/geoffreyvd/received_events","type":"User","site_admin":false},"repo":{"id":153668675,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM2Njg2NzU=","name":"FairMQ","full_name":"geoffreyvd/FairMQ","private":false,"owner":{"login":"geoffreyvd","id":9165933,"node_id":"MDQ6VXNlcjkxNjU5MzM=","avatar_url":"https://avatars3.githubusercontent.com/u/9165933?v=4","gravatar_id":"","url":"https://api.github.com/users/geoffreyvd","html_url":"https://github.com/geoffreyvd","followers_url":"https://api.github.com/users/geoffreyvd/followers","following_url":"https://api.github.com/users/geoffreyvd/following{/other_user}","gists_url":"https://api.github.com/users/geoffreyvd/gists{/gist_id}","starred_url":"https://api.github.com/users/geoffreyvd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoffreyvd/subscriptions","organizations_url":"https://api.github.com/users/geoffreyvd/orgs","repos_url":"https://api.github.com/users/geoffreyvd/repos","events_url":"https://api.github.com/users/geoffreyvd/events{/privacy}","received_events_url":"https://api.github.com/users/geoffreyvd/received_events","type":"User","site_admin":false},"html_url":"https://github.com/geoffreyvd/FairMQ","description":"C++ Message Queuing Library and Framework","fork":true,"url":"https://api.github.com/repos/geoffreyvd/FairMQ","forks_url":"https://api.github.com/repos/geoffreyvd/FairMQ/forks","keys_url":"https://api.github.com/repos/geoffreyvd/FairMQ/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geoffreyvd/FairMQ/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geoffreyvd/FairMQ/teams","hooks_url":"https://api.github.com/repos/geoffreyvd/FairMQ/hooks","issue_events_url":"https://api.github.com/repos/geoffreyvd/FairMQ/issues/events{/number}","events_url":"https://api.github.com/repos/geoffreyvd/FairMQ/events","assignees_url":"https://api.github.com/repos/geoffreyvd/FairMQ/assignees{/user}","branches_url":"https://api.github.com/repos/geoffreyvd/FairMQ/branches{/branch}","tags_url":"https://api.github.com/repos/geoffreyvd/FairMQ/tags","blobs_url":"https://api.github.com/repos/geoffreyvd/FairMQ/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geoffreyvd/FairMQ/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geoffreyvd/FairMQ/git/refs{/sha}","trees_url":"https://api.github.com/repos/geoffreyvd/FairMQ/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geoffreyvd/FairMQ/statuses/{sha}","languages_url":"https://api.github.com/repos/geoffreyvd/FairMQ/languages","stargazers_url":"https://api.github.com/repos/geoffreyvd/FairMQ/stargazers","contributors_url":"https://api.github.com/repos/geoffreyvd/FairMQ/contributors","subscribers_url":"https://api.github.com/repos/geoffreyvd/FairMQ/subscribers","subscription_url":"https://api.github.com/repos/geoffreyvd/FairMQ/subscription","commits_url":"https://api.github.com/repos/geoffreyvd/FairMQ/commits{/sha}","git_commits_url":"https://api.github.com/repos/geoffreyvd/FairMQ/git/commits{/sha}","comments_url":"https://api.github.com/repos/geoffreyvd/FairMQ/comments{/number}","issue_comment_url":"https://api.github.com/repos/geoffreyvd/FairMQ/issues/comments{/number}","contents_url":"https://api.github.com/repos/geoffreyvd/FairMQ/contents/{+path}","compare_url":"https://api.github.com/repos/geoffreyvd/FairMQ/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geoffreyvd/FairMQ/merges","archive_url":"https://api.github.com/repos/geoffreyvd/FairMQ/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geoffreyvd/FairMQ/downloads","issues_url":"https://api.github.com/repos/geoffreyvd/FairMQ/issues{/number}","pulls_url":"https://api.github.com/repos/geoffreyvd/FairMQ/pulls{/number}","milestones_url":"https://api.github.com/repos/geoffreyvd/FairMQ/milestones{/number}","notifications_url":"https://api.github.com/repos/geoffreyvd/FairMQ/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geoffreyvd/FairMQ/labels{/name}","releases_url":"https://api.github.com/repos/geoffreyvd/FairMQ/releases{/id}","deployments_url":"https://api.github.com/repos/geoffreyvd/FairMQ/deployments","created_at":"2018-10-18T18:22:43Z","updated_at":"2018-10-18T18:22:45Z","pushed_at":"2018-10-18T19:34:07Z","git_url":"git://github.com/geoffreyvd/FairMQ.git","ssh_url":"git@github.com:geoffreyvd/FairMQ.git","clone_url":"https://github.com/geoffreyvd/FairMQ.git","svn_url":"https://github.com/geoffreyvd/FairMQ","homepage":"","size":6967,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FairRootGroup:dev","ref":"dev","sha":"1b53538d8c1c1dc31667cb8e7452a752d267c7c6","user":{"login":"FairRootGroup","id":6390728,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzOTA3Mjg=","avatar_url":"https://avatars0.githubusercontent.com/u/6390728?v=4","gravatar_id":"","url":"https://api.github.com/users/FairRootGroup","html_url":"https://github.com/FairRootGroup","followers_url":"https://api.github.com/users/FairRootGroup/followers","following_url":"https://api.github.com/users/FairRootGroup/following{/other_user}","gists_url":"https://api.github.com/users/FairRootGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/FairRootGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FairRootGroup/subscriptions","organizations_url":"https://api.github.com/users/FairRootGroup/orgs","repos_url":"https://api.github.com/users/FairRootGroup/repos","events_url":"https://api.github.com/users/FairRootGroup/events{/privacy}","received_events_url":"https://api.github.com/users/FairRootGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":128961939,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg5NjE5Mzk=","name":"FairMQ","full_name":"FairRootGroup/FairMQ","private":false,"owner":{"login":"FairRootGroup","id":6390728,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzOTA3Mjg=","avatar_url":"https://avatars0.githubusercontent.com/u/6390728?v=4","gravatar_id":"","url":"https://api.github.com/users/FairRootGroup","html_url":"https://github.com/FairRootGroup","followers_url":"https://api.github.com/users/FairRootGroup/followers","following_url":"https://api.github.com/users/FairRootGroup/following{/other_user}","gists_url":"https://api.github.com/users/FairRootGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/FairRootGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FairRootGroup/subscriptions","organizations_url":"https://api.github.com/users/FairRootGroup/orgs","repos_url":"https://api.github.com/users/FairRootGroup/repos","events_url":"https://api.github.com/users/FairRootGroup/events{/privacy}","received_events_url":"https://api.github.com/users/FairRootGroup/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/FairRootGroup/FairMQ","description":"C++ Message Queuing Library and Framework","fork":false,"url":"https://api.github.com/repos/FairRootGroup/FairMQ","forks_url":"https://api.github.com/repos/FairRootGroup/FairMQ/forks","keys_url":"https://api.github.com/repos/FairRootGroup/FairMQ/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FairRootGroup/FairMQ/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FairRootGroup/FairMQ/teams","hooks_url":"https://api.github.com/repos/FairRootGroup/FairMQ/hooks","issue_events_url":"https://api.github.com/repos/FairRootGroup/FairMQ/issues/events{/number}","events_url":"https://api.github.com/repos/FairRootGroup/FairMQ/events","assignees_url":"https://api.github.com/repos/FairRootGroup/FairMQ/assignees{/user}","branches_url":"https://api.github.com/repos/FairRootGroup/FairMQ/branches{/branch}","tags_url":"https://api.github.com/repos/FairRootGroup/FairMQ/tags","blobs_url":"https://api.github.com/repos/FairRootGroup/FairMQ/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FairRootGroup/FairMQ/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FairRootGroup/FairMQ/git/refs{/sha}","trees_url":"https://api.github.com/repos/FairRootGroup/FairMQ/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FairRootGroup/FairMQ/statuses/{sha}","languages_url":"https://api.github.com/repos/FairRootGroup/FairMQ/languages","stargazers_url":"https://api.github.com/repos/FairRootGroup/FairMQ/stargazers","contributors_url":"https://api.github.com/repos/FairRootGroup/FairMQ/contributors","subscribers_url":"https://api.github.com/repos/FairRootGroup/FairMQ/subscribers","subscription_url":"https://api.github.com/repos/FairRootGroup/FairMQ/subscription","commits_url":"https://api.github.com/repos/FairRootGroup/FairMQ/commits{/sha}","git_commits_url":"https://api.github.com/repos/FairRootGroup/FairMQ/git/commits{/sha}","comments_url":"https://api.github.com/repos/FairRootGroup/FairMQ/comments{/number}","issue_comment_url":"https://api.github.com/repos/FairRootGroup/FairMQ/issues/comments{/number}","contents_url":"https://api.github.com/repos/FairRootGroup/FairMQ/contents/{+path}","compare_url":"https://api.github.com/repos/FairRootGroup/FairMQ/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FairRootGroup/FairMQ/merges","archive_url":"https://api.github.com/repos/FairRootGroup/FairMQ/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FairRootGroup/FairMQ/downloads","issues_url":"https://api.github.com/repos/FairRootGroup/FairMQ/issues{/number}","pulls_url":"https://api.github.com/repos/FairRootGroup/FairMQ/pulls{/number}","milestones_url":"https://api.github.com/repos/FairRootGroup/FairMQ/milestones{/number}","notifications_url":"https://api.github.com/repos/FairRootGroup/FairMQ/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FairRootGroup/FairMQ/labels{/name}","releases_url":"https://api.github.com/repos/FairRootGroup/FairMQ/releases{/id}","deployments_url":"https://api.github.com/repos/FairRootGroup/FairMQ/deployments","created_at":"2018-04-10T16:14:55Z","updated_at":"2018-10-11T15:16:02Z","pushed_at":"2018-10-18T19:34:08Z","git_url":"git://github.com/FairRootGroup/FairMQ.git","ssh_url":"git@github.com:FairRootGroup/FairMQ.git","clone_url":"https://github.com/FairRootGroup/FairMQ.git","svn_url":"https://github.com/FairRootGroup/FairMQ","homepage":"","size":6962,"stargazers_count":8,"watchers_count":8,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":9,"open_issues":18,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FairRootGroup/FairMQ/pulls/106"},"html":{"href":"https://github.com/FairRootGroup/FairMQ/pull/106"},"issue":{"href":"https://api.github.com/repos/FairRootGroup/FairMQ/issues/106"},"comments":{"href":"https://api.github.com/repos/FairRootGroup/FairMQ/issues/106/comments"},"review_comments":{"href":"https://api.github.com/repos/FairRootGroup/FairMQ/pulls/106/comments"},"review_comment":{"href":"https://api.github.com/repos/FairRootGroup/FairMQ/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FairRootGroup/FairMQ/pulls/106/commits"},"statuses":{"href":"https://api.github.com/repos/FairRootGroup/FairMQ/statuses/5c0b319275d254ed610216037122d86d5b84b1fa"}},"author_association":"NONE"}}
{"actor":{"display_login":"geoffreyvd"}}