{"action":"created","issue":{"url":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues/2360","repository_url":"https://api.github.com/repos/Azure/azure-rest-api-specs","labels_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues/2360/labels{/name}","comments_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues/2360/comments","events_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues/2360/events","html_url":"https://github.com/Azure/azure-rest-api-specs/pull/2360","id":292615500,"number":2360,"title":"Fix Automation swagger spec errors in the AutomationAccount and Webhook areas","user":{"login":"AnatoliB","id":11563624,"avatar_url":"https://avatars3.githubusercontent.com/u/11563624?v=4","gravatar_id":"","url":"https://api.github.com/users/AnatoliB","html_url":"https://github.com/AnatoliB","followers_url":"https://api.github.com/users/AnatoliB/followers","following_url":"https://api.github.com/users/AnatoliB/following{/other_user}","gists_url":"https://api.github.com/users/AnatoliB/gists{/gist_id}","starred_url":"https://api.github.com/users/AnatoliB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnatoliB/subscriptions","organizations_url":"https://api.github.com/users/AnatoliB/orgs","repos_url":"https://api.github.com/users/AnatoliB/repos","events_url":"https://api.github.com/users/AnatoliB/events{/privacy}","received_events_url":"https://api.github.com/users/AnatoliB/received_events","type":"User","site_admin":false},"labels":[{"id":474072507,"url":"https://api.github.com/repos/Azure/azure-rest-api-specs/labels/potential-sdk-breaking-change","name":"potential-sdk-breaking-change","color":"b60205","default":false}],"state":"open","locked":false,"assignee":{"login":"sergey-shandar","id":902339,"avatar_url":"https://avatars2.githubusercontent.com/u/902339?v=4","gravatar_id":"","url":"https://api.github.com/users/sergey-shandar","html_url":"https://github.com/sergey-shandar","followers_url":"https://api.github.com/users/sergey-shandar/followers","following_url":"https://api.github.com/users/sergey-shandar/following{/other_user}","gists_url":"https://api.github.com/users/sergey-shandar/gists{/gist_id}","starred_url":"https://api.github.com/users/sergey-shandar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergey-shandar/subscriptions","organizations_url":"https://api.github.com/users/sergey-shandar/orgs","repos_url":"https://api.github.com/users/sergey-shandar/repos","events_url":"https://api.github.com/users/sergey-shandar/events{/privacy}","received_events_url":"https://api.github.com/users/sergey-shandar/received_events","type":"User","site_admin":false},"assignees":[{"login":"sergey-shandar","id":902339,"avatar_url":"https://avatars2.githubusercontent.com/u/902339?v=4","gravatar_id":"","url":"https://api.github.com/users/sergey-shandar","html_url":"https://github.com/sergey-shandar","followers_url":"https://api.github.com/users/sergey-shandar/followers","following_url":"https://api.github.com/users/sergey-shandar/following{/other_user}","gists_url":"https://api.github.com/users/sergey-shandar/gists{/gist_id}","starred_url":"https://api.github.com/users/sergey-shandar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergey-shandar/subscriptions","organizations_url":"https://api.github.com/users/sergey-shandar/orgs","repos_url":"https://api.github.com/users/sergey-shandar/repos","events_url":"https://api.github.com/users/sergey-shandar/events{/privacy}","received_events_url":"https://api.github.com/users/sergey-shandar/received_events","type":"User","site_admin":false}],"milestone":null,"comments":9,"created_at":"2018-01-30T00:53:20Z","updated_at":"2018-02-05T18:28:33Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/2360","html_url":"https://github.com/Azure/azure-rest-api-specs/pull/2360","diff_url":"https://github.com/Azure/azure-rest-api-specs/pull/2360.diff","patch_url":"https://github.com/Azure/azure-rest-api-specs/pull/2360.patch"},"body":"Fixing the following errors in the Automation swagger spec:\r\n\r\n- (PatchBodyParametersSchema/R2016/RPCViolation): Properties of a PATCH request body must not be required. PATCH operation: 'AutomationAccount_Update' Model Definition: 'AutomationAccountUpdateParameters' Property: 'properties'\r\n- (PatchBodyParametersSchema/R2016/RPCViolation): Properties of a PATCH request body must not be required. PATCH operation: 'Webhook_Update' Model Definition: 'WebhookUpdateParameters' Property: 'name'\r\n- (XmsResourceInPutResponse/R2062/RPCViolation): The 200 response model for an ARM PUT operation must have x-ms-azure-resource extension set to true in its hierarchy. Operation: 'Webhook_CreateOrUpdate' Model: 'Webhook'\r\n\r\nThe intent of this PR is to address these errors only. The entire Automation swagger spec contains other errors, and they will be addressed by separate PRs.\r\n\r\n---\r\n\r\nThis checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process. \r\n\r\n### PR information\r\n- [X] The title of the PR is clear and informative.\r\n- [X] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, [see this page](https://github.com/Azure/azure-powershell/blob/dev/documentation/cleaning-up-commits.md).\r\n- [X] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.\r\n- [X] If applicable, the PR references the bug/issue that it fixes.\r\n- [X] Swagger files are correctly named (e.g. the `api-version` in the path should match the `api-version` in the spec).\r\n\r\n### Quality of Swagger\r\n- [X] I have read the [contribution guidelines](https://github.com/Azure/azure-rest-api-specs/blob/master/.github/CONTRIBUTING.md).\r\n- [X] My spec meets the review criteria:\r\n  - [X] The spec conforms to the [Swagger 2.0 specification](https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md).\r\n  - [X] The spec follows the guidelines described in the [Swagger checklist](../documentation/swagger-checklist.md) document.\r\n  - [ ] [Validation tools](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/swagger-checklist.md#validation-tools-for-swagger-checklist) were run on swagger spec(s) and have all been fixed in this PR. \r\n"},"comment":{"url":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues/comments/363175820","html_url":"https://github.com/Azure/azure-rest-api-specs/pull/2360#issuecomment-363175820","issue_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues/2360","id":363175820,"user":{"login":"vrdmr","id":1047040,"avatar_url":"https://avatars0.githubusercontent.com/u/1047040?v=4","gravatar_id":"","url":"https://api.github.com/users/vrdmr","html_url":"https://github.com/vrdmr","followers_url":"https://api.github.com/users/vrdmr/followers","following_url":"https://api.github.com/users/vrdmr/following{/other_user}","gists_url":"https://api.github.com/users/vrdmr/gists{/gist_id}","starred_url":"https://api.github.com/users/vrdmr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrdmr/subscriptions","organizations_url":"https://api.github.com/users/vrdmr/orgs","repos_url":"https://api.github.com/users/vrdmr/repos","events_url":"https://api.github.com/users/vrdmr/events{/privacy}","received_events_url":"https://api.github.com/users/vrdmr/received_events","type":"User","site_admin":false},"created_at":"2018-02-05T18:28:33Z","updated_at":"2018-02-05T18:28:33Z","author_association":"CONTRIBUTOR","body":"Hey @sergey-shandar,\r\n\r\n> Definetly this changes should be in the new API version but it doesn't make much sense to introduce SDK breaking changes for your customers.\r\nOur swagger-based SDK is still in [preview stage](https://www.nuget.org/packages/Microsoft.Azure.Management.Automation/3.0.0-preview) and contains many breaking changes. We released the preview SDK last month and are cleaning up the Specs before we can promote the SDK to a stable version.\r\n\r\nPlease let me know if you have any other questions.\r\n\r\ncc: @marstr, @AnatoliB, @D1v38om83r "}}
{"actor":{"display_login":"vrdmr"}}