{"action":"closed","issue":{"url":"https://api.github.com/repos/Tencent/rapidjson/issues/1156","repository_url":"https://api.github.com/repos/Tencent/rapidjson","labels_url":"https://api.github.com/repos/Tencent/rapidjson/issues/1156/labels{/name}","comments_url":"https://api.github.com/repos/Tencent/rapidjson/issues/1156/comments","events_url":"https://api.github.com/repos/Tencent/rapidjson/issues/1156/events","html_url":"https://github.com/Tencent/rapidjson/issues/1156","id":287151243,"number":1156,"title":"VS2008: warning C4003 - min/max problem","user":{"login":"escherstair","id":22594460,"avatar_url":"https://avatars1.githubusercontent.com/u/22594460?v=4","gravatar_id":"","url":"https://api.github.com/users/escherstair","html_url":"https://github.com/escherstair","followers_url":"https://api.github.com/users/escherstair/followers","following_url":"https://api.github.com/users/escherstair/following{/other_user}","gists_url":"https://api.github.com/users/escherstair/gists{/gist_id}","starred_url":"https://api.github.com/users/escherstair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/escherstair/subscriptions","organizations_url":"https://api.github.com/users/escherstair/orgs","repos_url":"https://api.github.com/users/escherstair/repos","events_url":"https://api.github.com/users/escherstair/events{/privacy}","received_events_url":"https://api.github.com/users/escherstair/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-01-09T16:33:22Z","updated_at":"2018-02-12T06:58:15Z","closed_at":"2018-02-12T06:58:15Z","author_association":"NONE","body":"The issue is exactly what is described [here](https://stackoverflow.com/questions/27442885/syntax-error-with-stdnumeric-limitsmax/27443191#27443191) and [here](https://github.com/nlohmann/json/issues/506).\r\nIt seems that if I compile with VS2008 and <Windows.h> is included before <document.h>, a conflict between min and max macros arises.\r\nThe issue happens at lines 1008, 1014, 1015, 1032 and 1033 of <document.h> and can be fixed adding parentheses around the calls to `std::numeric_limits<float>::max` and `std::numeric_limits<float>::min`\r\nI mean that line 1008 should be changed from\r\n`&& (d < static_cast<double>(std::numeric_limits<uint64_t>::max()))`\r\nto\r\n`&& (d < static_cast<double>((std::numeric_limits<uint64_t>::max)()))`\r\nand so on....\r\n\r\nCould you implement this fix, please?"}}
{"actor":{"display_login":"miloyip"}}