{"action":"created","issue":{"url":"https://api.github.com/repos/pymedusa/Medusa/issues/5829","repository_url":"https://api.github.com/repos/pymedusa/Medusa","labels_url":"https://api.github.com/repos/pymedusa/Medusa/issues/5829/labels{/name}","comments_url":"https://api.github.com/repos/pymedusa/Medusa/issues/5829/comments","events_url":"https://api.github.com/repos/pymedusa/Medusa/issues/5829/events","html_url":"https://github.com/pymedusa/Medusa/pull/5829","id":387751879,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MTcwMDM4","number":5829,"title":"Begin fixes for storing commit hash dynamically","user":{"login":"a10kiloham","id":295361,"node_id":"MDQ6VXNlcjI5NTM2MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/295361?v=4","gravatar_id":"","url":"https://api.github.com/users/a10kiloham","html_url":"https://github.com/a10kiloham","followers_url":"https://api.github.com/users/a10kiloham/followers","following_url":"https://api.github.com/users/a10kiloham/following{/other_user}","gists_url":"https://api.github.com/users/a10kiloham/gists{/gist_id}","starred_url":"https://api.github.com/users/a10kiloham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a10kiloham/subscriptions","organizations_url":"https://api.github.com/users/a10kiloham/orgs","repos_url":"https://api.github.com/users/a10kiloham/repos","events_url":"https://api.github.com/users/a10kiloham/events{/privacy}","received_events_url":"https://api.github.com/users/a10kiloham/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-12-05T13:15:42Z","updated_at":"2018-12-08T10:08:23Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/pymedusa/Medusa/pulls/5829","html_url":"https://github.com/pymedusa/Medusa/pull/5829","diff_url":"https://github.com/pymedusa/Medusa/pull/5829.diff","patch_url":"https://github.com/pymedusa/Medusa/pull/5829.patch"},"body":"- [ ] PR is based on the DEVELOP branch\r\n- [ ] Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review\r\n- [ ] Read the [contribution guide](https://github.com/pymedusa/Medusa/blob/master/.github/CONTRIBUTING.md)\r\n"},"comment":{"url":"https://api.github.com/repos/pymedusa/Medusa/issues/comments/445447872","html_url":"https://github.com/pymedusa/Medusa/pull/5829#issuecomment-445447872","issue_url":"https://api.github.com/repos/pymedusa/Medusa/issues/5829","id":445447872,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTQ0Nzg3Mg==","user":{"login":"p0psicles","id":1331394,"node_id":"MDQ6VXNlcjEzMzEzOTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1331394?v=4","gravatar_id":"","url":"https://api.github.com/users/p0psicles","html_url":"https://github.com/p0psicles","followers_url":"https://api.github.com/users/p0psicles/followers","following_url":"https://api.github.com/users/p0psicles/following{/other_user}","gists_url":"https://api.github.com/users/p0psicles/gists{/gist_id}","starred_url":"https://api.github.com/users/p0psicles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p0psicles/subscriptions","organizations_url":"https://api.github.com/users/p0psicles/orgs","repos_url":"https://api.github.com/users/p0psicles/repos","events_url":"https://api.github.com/users/p0psicles/events{/privacy}","received_events_url":"https://api.github.com/users/p0psicles/received_events","type":"User","site_admin":false},"created_at":"2018-12-08T10:08:23Z","updated_at":"2018-12-08T10:08:23Z","author_association":"CONTRIBUTOR","body":"@a10kiloham you have to explain me. Are we or are we not including the .git folder?\r\nAs when we add the .git folder, medusa will be able to determine the cur commit hash just fine. So no further changes required.\r\n\r\nFor example the image https://github.com/linuxserver/docker-medusa already adds the .git folder.\r\nThat image doesn't have the issue we're trying to solve.\r\n\r\nBut, i'm no docker expert here. So I don't know what's best practice here.\r\n\r\nSo we first need to decide what we want. Do we add the .git folder or not?\r\nPersonally, I don't think we should want that. And just add the source, as we don't want users to provide the option of running commands like `git pull`."}}
{"actor":{"display_login":"p0psicles"}}