{"action":"created","issue":{"url":"https://api.github.com/repos/SAFE-Stack/SAFE-template/issues/118","repository_url":"https://api.github.com/repos/SAFE-Stack/SAFE-template","labels_url":"https://api.github.com/repos/SAFE-Stack/SAFE-template/issues/118/labels{/name}","comments_url":"https://api.github.com/repos/SAFE-Stack/SAFE-template/issues/118/comments","events_url":"https://api.github.com/repos/SAFE-Stack/SAFE-template/issues/118/events","html_url":"https://github.com/SAFE-Stack/SAFE-template/pull/118","id":341356392,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNTE4MjI3","number":118,"title":"Update remoting to latest, docs for client","user":{"login":"Zaid-Ajaj","id":13316248,"node_id":"MDQ6VXNlcjEzMzE2MjQ4","avatar_url":"https://avatars3.githubusercontent.com/u/13316248?v=4","gravatar_id":"","url":"https://api.github.com/users/Zaid-Ajaj","html_url":"https://github.com/Zaid-Ajaj","followers_url":"https://api.github.com/users/Zaid-Ajaj/followers","following_url":"https://api.github.com/users/Zaid-Ajaj/following{/other_user}","gists_url":"https://api.github.com/users/Zaid-Ajaj/gists{/gist_id}","starred_url":"https://api.github.com/users/Zaid-Ajaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zaid-Ajaj/subscriptions","organizations_url":"https://api.github.com/users/Zaid-Ajaj/orgs","repos_url":"https://api.github.com/users/Zaid-Ajaj/repos","events_url":"https://api.github.com/users/Zaid-Ajaj/events{/privacy}","received_events_url":"https://api.github.com/users/Zaid-Ajaj/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-07-15T22:08:58Z","updated_at":"2018-07-16T11:32:29Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/SAFE-Stack/SAFE-template/pulls/118","html_url":"https://github.com/SAFE-Stack/SAFE-template/pull/118","diff_url":"https://github.com/SAFE-Stack/SAFE-template/pull/118.diff","patch_url":"https://github.com/SAFE-Stack/SAFE-template/pull/118.patch"},"body":"This PR updates remoting to latest version and api, I also took the liberty and updated a couple of things along the way, PLEASE REVIEW (I haven't tested every possible combination): \r\n\r\n## Client\r\nAdded docs to model, msg, init and update \r\n\r\n`type Model = Counter option` became `type Model = { Counter: Counter option }`  \r\n\r\nThe messages now became:\r\n```fs\r\ntype Msg =\r\n| Increment\r\n| Decrement\r\n| LoadInitialCount \r\n| InitialCountLoaded of Result<Counter, exn>\r\n```\r\nwhere `LoadInitialCount` is a message the initiates the request and `InitialCountLoaded` is the one that results from the (http) request, and `init()` becomes:\r\n```fs\r\n// defines the initial state and initial command (= side-effect) of the application\r\nlet init () : Model * Cmd<Msg> =\r\n    let initialModel = { Counter = None }\r\n    let initialCmd = Cmd.ofMsg LoadInitialCount\r\n    initialModel, initialCmd\r\n```\r\n## Saturn\r\n`use_router` instead of `router` as per the depreciation message \r\n`disable_diagnostics` doesn't seem necessary anymore with remoting enabled (probably because the [routing with remoting](https://github.com/Zaid-Ajaj/Fable.Remoting/blob/master/Fable.Remoting.Giraffe/FableGiraffeAdapter.fs#L73) doesn't rely on existing combinators any more) \r\n## Suave\r\nopening `Suave.Filters` and `Suave.Successful` instead of fully qualifying them with the `OK` and `path` web parts (it is common that they are fully qualified?) \r\n\r\n## build.fsx\r\n`DotNet.Release_2_1_300` => `DotNet.Versions.Release_2_1_300` as per the depreciation message \r\n`Run` target is `Clean`-ed before running"},"comment":{"url":"https://api.github.com/repos/SAFE-Stack/SAFE-template/issues/comments/405218712","html_url":"https://github.com/SAFE-Stack/SAFE-template/pull/118#issuecomment-405218712","issue_url":"https://api.github.com/repos/SAFE-Stack/SAFE-template/issues/118","id":405218712,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTIxODcxMg==","user":{"login":"theimowski","id":5909015,"node_id":"MDQ6VXNlcjU5MDkwMTU=","avatar_url":"https://avatars1.githubusercontent.com/u/5909015?v=4","gravatar_id":"","url":"https://api.github.com/users/theimowski","html_url":"https://github.com/theimowski","followers_url":"https://api.github.com/users/theimowski/followers","following_url":"https://api.github.com/users/theimowski/following{/other_user}","gists_url":"https://api.github.com/users/theimowski/gists{/gist_id}","starred_url":"https://api.github.com/users/theimowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theimowski/subscriptions","organizations_url":"https://api.github.com/users/theimowski/orgs","repos_url":"https://api.github.com/users/theimowski/repos","events_url":"https://api.github.com/users/theimowski/events{/privacy}","received_events_url":"https://api.github.com/users/theimowski/received_events","type":"User","site_admin":false},"created_at":"2018-07-16T11:32:29Z","updated_at":"2018-07-16T11:32:29Z","author_association":"MEMBER","body":"@Zaid-Ajaj see https://github.com/SAFE-Stack/SAFE-template/commit/ad8bcbe44b36dd419a7835193a2c8e60af2d477d - I've added a FAKE target to help with the test workflow.\r\nNot very much, but now you can `fake build -t install` and have the updated template already available in `dotnet`"}}
{"actor":{"display_login":"theimowski"}}