{"action":"created","comment":{"url":"https://api.github.com/repos/cssinjs/jss/pulls/comments/244004670","pull_request_review_id":187906992,"id":244004670,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDAwNDY3MA==","diff_hunk":"@@ -0,0 +1,18 @@\n+# Migration guides\n+\n+## From v9 to v10\n+\n+1. New dynamic values support.\n+   In v9, observables and function values have been part of JSS core. In v10 they are standalone plugins. If you are using the default preset you don't need to do anything else than upgrading the default preset and JSS. If you are using a custom setup and you use function values or observables, you will have to add 2 additional plugins. See [plugins.md](./plugins.md).\n+\n+1. Full syntax support in dynamic values.\n+   Return values from observables and functions are now processed by the JSS plugins. This means you can return full JSS syntax from dynamic values. This also means it can be a bit slower, but you can opt-out from processing by using `sheet.update(data, {process: false})` when using JSS core directly. Also you can opt-out when setting up the observable plugin `jss.use(pluginObservable({process: false}))`.\n+\n+1. Scoped @keyframes.\n+   In v9, when you declare keyframes `@keyframes my-animation` the `my-animation` ID was global, as it is by default in CSS. This could lead to problems since you could override them nondeterministically. In v10, ID is scoped by default, same as we do with class names. Check out the full syntax [here](./jss-syntax.md/#keyframes-animation).\n+\n+1. Renamed ID generator function.","path":"docs/migrations.md","position":14,"original_position":14,"commit_id":"c4434ff81cb8a240a1b13319fb71a9ad1153b349","original_commit_id":"c4434ff81cb8a240a1b13319fb71a9ad1153b349","user":{"login":"HenriBeck","id":8514706,"node_id":"MDQ6VXNlcjg1MTQ3MDY=","avatar_url":"https://avatars1.githubusercontent.com/u/8514706?v=4","gravatar_id":"","url":"https://api.github.com/users/HenriBeck","html_url":"https://github.com/HenriBeck","followers_url":"https://api.github.com/users/HenriBeck/followers","following_url":"https://api.github.com/users/HenriBeck/following{/other_user}","gists_url":"https://api.github.com/users/HenriBeck/gists{/gist_id}","starred_url":"https://api.github.com/users/HenriBeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HenriBeck/subscriptions","organizations_url":"https://api.github.com/users/HenriBeck/orgs","repos_url":"https://api.github.com/users/HenriBeck/repos","events_url":"https://api.github.com/users/HenriBeck/events{/privacy}","received_events_url":"https://api.github.com/users/HenriBeck/received_events","type":"User","site_admin":false},"body":"4.","created_at":"2018-12-26T14:44:55Z","updated_at":"2018-12-26T14:45:24Z","html_url":"https://github.com/cssinjs/jss/pull/947#discussion_r244004670","pull_request_url":"https://api.github.com/repos/cssinjs/jss/pulls/947","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/cssinjs/jss/pulls/comments/244004670"},"html":{"href":"https://github.com/cssinjs/jss/pull/947#discussion_r244004670"},"pull_request":{"href":"https://api.github.com/repos/cssinjs/jss/pulls/947"}}},"pull_request":{"url":"https://api.github.com/repos/cssinjs/jss/pulls/947","id":240987589,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwOTg3NTg5","html_url":"https://github.com/cssinjs/jss/pull/947","diff_url":"https://github.com/cssinjs/jss/pull/947.diff","patch_url":"https://github.com/cssinjs/jss/pull/947.patch","issue_url":"https://api.github.com/repos/cssinjs/jss/issues/947","number":947,"state":"open","locked":false,"title":"Add migrations.md","user":{"login":"kof","id":52824,"node_id":"MDQ6VXNlcjUyODI0","avatar_url":"https://avatars0.githubusercontent.com/u/52824?v=4","gravatar_id":"","url":"https://api.github.com/users/kof","html_url":"https://github.com/kof","followers_url":"https://api.github.com/users/kof/followers","following_url":"https://api.github.com/users/kof/following{/other_user}","gists_url":"https://api.github.com/users/kof/gists{/gist_id}","starred_url":"https://api.github.com/users/kof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kof/subscriptions","organizations_url":"https://api.github.com/users/kof/orgs","repos_url":"https://api.github.com/users/kof/repos","events_url":"https://api.github.com/users/kof/events{/privacy}","received_events_url":"https://api.github.com/users/kof/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-12-26T14:16:03Z","updated_at":"2018-12-26T14:45:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65a46695c717e22eb3daa5d2ac54f7be87ec6e7c","assignee":{"login":"kof","id":52824,"node_id":"MDQ6VXNlcjUyODI0","avatar_url":"https://avatars0.githubusercontent.com/u/52824?v=4","gravatar_id":"","url":"https://api.github.com/users/kof","html_url":"https://github.com/kof","followers_url":"https://api.github.com/users/kof/followers","following_url":"https://api.github.com/users/kof/following{/other_user}","gists_url":"https://api.github.com/users/kof/gists{/gist_id}","starred_url":"https://api.github.com/users/kof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kof/subscriptions","organizations_url":"https://api.github.com/users/kof/orgs","repos_url":"https://api.github.com/users/kof/repos","events_url":"https://api.github.com/users/kof/events{/privacy}","received_events_url":"https://api.github.com/users/kof/received_events","type":"User","site_admin":false},"assignees":[{"login":"kof","id":52824,"node_id":"MDQ6VXNlcjUyODI0","avatar_url":"https://avatars0.githubusercontent.com/u/52824?v=4","gravatar_id":"","url":"https://api.github.com/users/kof","html_url":"https://github.com/kof","followers_url":"https://api.github.com/users/kof/followers","following_url":"https://api.github.com/users/kof/following{/other_user}","gists_url":"https://api.github.com/users/kof/gists{/gist_id}","starred_url":"https://api.github.com/users/kof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kof/subscriptions","organizations_url":"https://api.github.com/users/kof/orgs","repos_url":"https://api.github.com/users/kof/repos","events_url":"https://api.github.com/users/kof/events{/privacy}","received_events_url":"https://api.github.com/users/kof/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cssinjs/jss/pulls/947/commits","review_comments_url":"https://api.github.com/repos/cssinjs/jss/pulls/947/comments","review_comment_url":"https://api.github.com/repos/cssinjs/jss/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cssinjs/jss/issues/947/comments","statuses_url":"https://api.github.com/repos/cssinjs/jss/statuses/c4434ff81cb8a240a1b13319fb71a9ad1153b349","head":{"label":"cssinjs:docs","ref":"docs","sha":"c4434ff81cb8a240a1b13319fb71a9ad1153b349","user":{"login":"cssinjs","id":9503099,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk1MDMwOTk=","avatar_url":"https://avatars0.githubusercontent.com/u/9503099?v=4","gravatar_id":"","url":"https://api.github.com/users/cssinjs","html_url":"https://github.com/cssinjs","followers_url":"https://api.github.com/users/cssinjs/followers","following_url":"https://api.github.com/users/cssinjs/following{/other_user}","gists_url":"https://api.github.com/users/cssinjs/gists{/gist_id}","starred_url":"https://api.github.com/users/cssinjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cssinjs/subscriptions","organizations_url":"https://api.github.com/users/cssinjs/orgs","repos_url":"https://api.github.com/users/cssinjs/repos","events_url":"https://api.github.com/users/cssinjs/events{/privacy}","received_events_url":"https://api.github.com/users/cssinjs/received_events","type":"Organization","site_admin":false},"repo":{"id":25131304,"node_id":"MDEwOlJlcG9zaXRvcnkyNTEzMTMwNA==","name":"jss","full_name":"cssinjs/jss","private":false,"owner":{"login":"cssinjs","id":9503099,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk1MDMwOTk=","avatar_url":"https://avatars0.githubusercontent.com/u/9503099?v=4","gravatar_id":"","url":"https://api.github.com/users/cssinjs","html_url":"https://github.com/cssinjs","followers_url":"https://api.github.com/users/cssinjs/followers","following_url":"https://api.github.com/users/cssinjs/following{/other_user}","gists_url":"https://api.github.com/users/cssinjs/gists{/gist_id}","starred_url":"https://api.github.com/users/cssinjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cssinjs/subscriptions","organizations_url":"https://api.github.com/users/cssinjs/orgs","repos_url":"https://api.github.com/users/cssinjs/repos","events_url":"https://api.github.com/users/cssinjs/events{/privacy}","received_events_url":"https://api.github.com/users/cssinjs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cssinjs/jss","description":"JSS is an authoring tool for CSS which uses JavaScript as a host language.","fork":false,"url":"https://api.github.com/repos/cssinjs/jss","forks_url":"https://api.github.com/repos/cssinjs/jss/forks","keys_url":"https://api.github.com/repos/cssinjs/jss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cssinjs/jss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cssinjs/jss/teams","hooks_url":"https://api.github.com/repos/cssinjs/jss/hooks","issue_events_url":"https://api.github.com/repos/cssinjs/jss/issues/events{/number}","events_url":"https://api.github.com/repos/cssinjs/jss/events","assignees_url":"https://api.github.com/repos/cssinjs/jss/assignees{/user}","branches_url":"https://api.github.com/repos/cssinjs/jss/branches{/branch}","tags_url":"https://api.github.com/repos/cssinjs/jss/tags","blobs_url":"https://api.github.com/repos/cssinjs/jss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cssinjs/jss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cssinjs/jss/git/refs{/sha}","trees_url":"https://api.github.com/repos/cssinjs/jss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cssinjs/jss/statuses/{sha}","languages_url":"https://api.github.com/repos/cssinjs/jss/languages","stargazers_url":"https://api.github.com/repos/cssinjs/jss/stargazers","contributors_url":"https://api.github.com/repos/cssinjs/jss/contributors","subscribers_url":"https://api.github.com/repos/cssinjs/jss/subscribers","subscription_url":"https://api.github.com/repos/cssinjs/jss/subscription","commits_url":"https://api.github.com/repos/cssinjs/jss/commits{/sha}","git_commits_url":"https://api.github.com/repos/cssinjs/jss/git/commits{/sha}","comments_url":"https://api.github.com/repos/cssinjs/jss/comments{/number}","issue_comment_url":"https://api.github.com/repos/cssinjs/jss/issues/comments{/number}","contents_url":"https://api.github.com/repos/cssinjs/jss/contents/{+path}","compare_url":"https://api.github.com/repos/cssinjs/jss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cssinjs/jss/merges","archive_url":"https://api.github.com/repos/cssinjs/jss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cssinjs/jss/downloads","issues_url":"https://api.github.com/repos/cssinjs/jss/issues{/number}","pulls_url":"https://api.github.com/repos/cssinjs/jss/pulls{/number}","milestones_url":"https://api.github.com/repos/cssinjs/jss/milestones{/number}","notifications_url":"https://api.github.com/repos/cssinjs/jss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cssinjs/jss/labels{/name}","releases_url":"https://api.github.com/repos/cssinjs/jss/releases{/id}","deployments_url":"https://api.github.com/repos/cssinjs/jss/deployments","created_at":"2014-10-12T20:33:53Z","updated_at":"2018-12-26T12:24:12Z","pushed_at":"2018-12-26T14:40:24Z","git_url":"git://github.com/cssinjs/jss.git","ssh_url":"git@github.com:cssinjs/jss.git","clone_url":"https://github.com/cssinjs/jss.git","svn_url":"https://github.com/cssinjs/jss","homepage":"http://cssinjs.org","size":3659,"stargazers_count":4422,"watchers_count":4422,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":244,"mirror_url":null,"archived":false,"open_issues_count":92,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":244,"open_issues":92,"watchers":4422,"default_branch":"master"}},"base":{"label":"cssinjs:master","ref":"master","sha":"a78df5ec8e8c1f8f8d4ab0ec041f1dbea1b6075e","user":{"login":"cssinjs","id":9503099,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk1MDMwOTk=","avatar_url":"https://avatars0.githubusercontent.com/u/9503099?v=4","gravatar_id":"","url":"https://api.github.com/users/cssinjs","html_url":"https://github.com/cssinjs","followers_url":"https://api.github.com/users/cssinjs/followers","following_url":"https://api.github.com/users/cssinjs/following{/other_user}","gists_url":"https://api.github.com/users/cssinjs/gists{/gist_id}","starred_url":"https://api.github.com/users/cssinjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cssinjs/subscriptions","organizations_url":"https://api.github.com/users/cssinjs/orgs","repos_url":"https://api.github.com/users/cssinjs/repos","events_url":"https://api.github.com/users/cssinjs/events{/privacy}","received_events_url":"https://api.github.com/users/cssinjs/received_events","type":"Organization","site_admin":false},"repo":{"id":25131304,"node_id":"MDEwOlJlcG9zaXRvcnkyNTEzMTMwNA==","name":"jss","full_name":"cssinjs/jss","private":false,"owner":{"login":"cssinjs","id":9503099,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk1MDMwOTk=","avatar_url":"https://avatars0.githubusercontent.com/u/9503099?v=4","gravatar_id":"","url":"https://api.github.com/users/cssinjs","html_url":"https://github.com/cssinjs","followers_url":"https://api.github.com/users/cssinjs/followers","following_url":"https://api.github.com/users/cssinjs/following{/other_user}","gists_url":"https://api.github.com/users/cssinjs/gists{/gist_id}","starred_url":"https://api.github.com/users/cssinjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cssinjs/subscriptions","organizations_url":"https://api.github.com/users/cssinjs/orgs","repos_url":"https://api.github.com/users/cssinjs/repos","events_url":"https://api.github.com/users/cssinjs/events{/privacy}","received_events_url":"https://api.github.com/users/cssinjs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cssinjs/jss","description":"JSS is an authoring tool for CSS which uses JavaScript as a host language.","fork":false,"url":"https://api.github.com/repos/cssinjs/jss","forks_url":"https://api.github.com/repos/cssinjs/jss/forks","keys_url":"https://api.github.com/repos/cssinjs/jss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cssinjs/jss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cssinjs/jss/teams","hooks_url":"https://api.github.com/repos/cssinjs/jss/hooks","issue_events_url":"https://api.github.com/repos/cssinjs/jss/issues/events{/number}","events_url":"https://api.github.com/repos/cssinjs/jss/events","assignees_url":"https://api.github.com/repos/cssinjs/jss/assignees{/user}","branches_url":"https://api.github.com/repos/cssinjs/jss/branches{/branch}","tags_url":"https://api.github.com/repos/cssinjs/jss/tags","blobs_url":"https://api.github.com/repos/cssinjs/jss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cssinjs/jss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cssinjs/jss/git/refs{/sha}","trees_url":"https://api.github.com/repos/cssinjs/jss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cssinjs/jss/statuses/{sha}","languages_url":"https://api.github.com/repos/cssinjs/jss/languages","stargazers_url":"https://api.github.com/repos/cssinjs/jss/stargazers","contributors_url":"https://api.github.com/repos/cssinjs/jss/contributors","subscribers_url":"https://api.github.com/repos/cssinjs/jss/subscribers","subscription_url":"https://api.github.com/repos/cssinjs/jss/subscription","commits_url":"https://api.github.com/repos/cssinjs/jss/commits{/sha}","git_commits_url":"https://api.github.com/repos/cssinjs/jss/git/commits{/sha}","comments_url":"https://api.github.com/repos/cssinjs/jss/comments{/number}","issue_comment_url":"https://api.github.com/repos/cssinjs/jss/issues/comments{/number}","contents_url":"https://api.github.com/repos/cssinjs/jss/contents/{+path}","compare_url":"https://api.github.com/repos/cssinjs/jss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cssinjs/jss/merges","archive_url":"https://api.github.com/repos/cssinjs/jss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cssinjs/jss/downloads","issues_url":"https://api.github.com/repos/cssinjs/jss/issues{/number}","pulls_url":"https://api.github.com/repos/cssinjs/jss/pulls{/number}","milestones_url":"https://api.github.com/repos/cssinjs/jss/milestones{/number}","notifications_url":"https://api.github.com/repos/cssinjs/jss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cssinjs/jss/labels{/name}","releases_url":"https://api.github.com/repos/cssinjs/jss/releases{/id}","deployments_url":"https://api.github.com/repos/cssinjs/jss/deployments","created_at":"2014-10-12T20:33:53Z","updated_at":"2018-12-26T12:24:12Z","pushed_at":"2018-12-26T14:40:24Z","git_url":"git://github.com/cssinjs/jss.git","ssh_url":"git@github.com:cssinjs/jss.git","clone_url":"https://github.com/cssinjs/jss.git","svn_url":"https://github.com/cssinjs/jss","homepage":"http://cssinjs.org","size":3659,"stargazers_count":4422,"watchers_count":4422,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":244,"mirror_url":null,"archived":false,"open_issues_count":92,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":244,"open_issues":92,"watchers":4422,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cssinjs/jss/pulls/947"},"html":{"href":"https://github.com/cssinjs/jss/pull/947"},"issue":{"href":"https://api.github.com/repos/cssinjs/jss/issues/947"},"comments":{"href":"https://api.github.com/repos/cssinjs/jss/issues/947/comments"},"review_comments":{"href":"https://api.github.com/repos/cssinjs/jss/pulls/947/comments"},"review_comment":{"href":"https://api.github.com/repos/cssinjs/jss/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cssinjs/jss/pulls/947/commits"},"statuses":{"href":"https://api.github.com/repos/cssinjs/jss/statuses/c4434ff81cb8a240a1b13319fb71a9ad1153b349"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"HenriBeck"}}