{"action":"created","comment":{"url":"https://api.github.com/repos/goharbor/harbor/pulls/comments/236504617","pull_request_review_id":178592614,"id":236504617,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjUwNDYxNw==","diff_hunk":"@@ -0,0 +1,106 @@\n+package config\n+\n+import \"github.com/goharbor/harbor/src/common\"\n+\n+// Item - Configure item include default value, type, env name\n+type Item struct {\n+\t// The Scope of this configuration item: eg: SystemScope, UserScope\n+\tScope string `json:\"scope,omitempty\"`\n+\t// email, ldapbasic, ldapgroup, uaa settings, used to retieve configure items by group, for example GetLDAPBasicSetting, GetLDAPGroupSetting settings\n+\tGroup string `json:\"group,omitempty\"`\n+\t// environment key to retrieves this value when initialize, for example: POSTGRESQL_HOST, only used for system settings, for user settings no EnvironmentKey\n+\tEnvironmentKey string `json:\"environment_key,omitempty\"`\n+\t// The default string value for this key\n+\tDefaultValue string `json:\"default_value,omitempty\"`\n+\t// The key for current configure settings in database and rerest api\n+\tName string `json:\"name,omitempty\"`\n+\t// It can be integer, string, bool, password, map\n+\tType string `json:\"type,omitempty\"`\n+\t// The validation function for this field.\n+\tValidator ValidateFunc `json:\"validator,omitempty\"`\n+\t// Is this settign can be modified after configure\n+\tEditable bool `json:\"editable,omitempty\"`\n+\t// Reloadable - reload config from env after restart, if it is true, the setting is only reload from env\n+\tReloadable bool `json:\"reloadable,omitempty\"`\n+}\n+\n+var (\n+\t// ConfigList - All configure items used in harbor\n+\t// Steps to onboard a new setting\n+\t// 1. Add configure item in configlist.go\n+\t// 2. Get settings by config.Client\n+\tConfigList = []Item{\n+\t\t{Scope: SystemScope, Group: BasicGroup, EnvironmentKey: \"HARBOR_ADMIN_PASSWORD\", DefaultValue: \"\", Name: \"admin_initial_password\", Type: PasswordType, Editable: true, Reloadable: false},\n+\t\t{Scope: SystemScope, Group: BasicGroup, EnvironmentKey: \"ADMIRAL_URL\", DefaultValue: \"NA\", Name: \"admiral_url\", Type: StringType, Editable: false, Reloadable: true},\n+\t\t{Scope: UserScope, Group: BasicGroup, EnvironmentKey: \"AUTH_MODE\", DefaultValue: \"db_auth\", Name: \"auth_mode\", Type: StringType, Editable: false},\n+\t\t{Scope: SystemScope, Group: BasicGroup, EnvironmentKey: \"CFG_EXPIRATION\", DefaultValue: \"5\", Name: \"cfg_expiration\", Type: StringType, Editable: false, Reloadable: true},\n+\t\t{Scope: SystemScope, Group: BasicGroup, EnvironmentKey: \"CHART_REPOSITORY_URL\", DefaultValue: \"http://chartmuseum:9999\", Name: \"chart_repository_url\", Type: StringType, Editable: false, Reloadable: true},\n+\n+\t\t{Scope: SystemScope, Group: ClairGroup, EnvironmentKey: \"CLAIR_DB\", DefaultValue: \"postgres\", Name: \"clair_db\", Type: StringType, Editable: false, Reloadable: true},","path":"src/common/config/configlist.go","position":39,"original_position":39,"commit_id":"fbcb1828ed9ac6bdc0f4db0ebd601b44396d123e","original_commit_id":"fbcb1828ed9ac6bdc0f4db0ebd601b44396d123e","user":{"login":"wy65701436","id":2841473,"node_id":"MDQ6VXNlcjI4NDE0NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/2841473?v=4","gravatar_id":"","url":"https://api.github.com/users/wy65701436","html_url":"https://github.com/wy65701436","followers_url":"https://api.github.com/users/wy65701436/followers","following_url":"https://api.github.com/users/wy65701436/following{/other_user}","gists_url":"https://api.github.com/users/wy65701436/gists{/gist_id}","starred_url":"https://api.github.com/users/wy65701436/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wy65701436/subscriptions","organizations_url":"https://api.github.com/users/wy65701436/orgs","repos_url":"https://api.github.com/users/wy65701436/repos","events_url":"https://api.github.com/users/wy65701436/events{/privacy}","received_events_url":"https://api.github.com/users/wy65701436/received_events","type":"User","site_admin":false},"body":"editable should be false for systemscope item?","created_at":"2018-11-27T02:57:34Z","updated_at":"2018-11-27T02:57:39Z","html_url":"https://github.com/goharbor/harbor/pull/6231#discussion_r236504617","pull_request_url":"https://api.github.com/repos/goharbor/harbor/pulls/6231","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/goharbor/harbor/pulls/comments/236504617"},"html":{"href":"https://github.com/goharbor/harbor/pull/6231#discussion_r236504617"},"pull_request":{"href":"https://api.github.com/repos/goharbor/harbor/pulls/6231"}}},"pull_request":{"url":"https://api.github.com/repos/goharbor/harbor/pulls/6231","id":228951901,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4OTUxOTAx","html_url":"https://github.com/goharbor/harbor/pull/6231","diff_url":"https://github.com/goharbor/harbor/pull/6231.diff","patch_url":"https://github.com/goharbor/harbor/pull/6231.patch","issue_url":"https://api.github.com/repos/goharbor/harbor/issues/6231","number":6231,"state":"open","locked":false,"title":"[Reviewing]Remove adminserver","user":{"login":"stonezdj","id":2696760,"node_id":"MDQ6VXNlcjI2OTY3NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/2696760?v=4","gravatar_id":"","url":"https://api.github.com/users/stonezdj","html_url":"https://github.com/stonezdj","followers_url":"https://api.github.com/users/stonezdj/followers","following_url":"https://api.github.com/users/stonezdj/following{/other_user}","gists_url":"https://api.github.com/users/stonezdj/gists{/gist_id}","starred_url":"https://api.github.com/users/stonezdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stonezdj/subscriptions","organizations_url":"https://api.github.com/users/stonezdj/orgs","repos_url":"https://api.github.com/users/stonezdj/repos","events_url":"https://api.github.com/users/stonezdj/events{/privacy}","received_events_url":"https://api.github.com/users/stonezdj/received_events","type":"User","site_admin":false},"body":"Remove adminserver","created_at":"2018-11-07T08:35:45Z","updated_at":"2018-11-27T02:57:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"242f804d8fec62daf5dd1dc6e37beba11994934e","assignee":{"login":"wy65701436","id":2841473,"node_id":"MDQ6VXNlcjI4NDE0NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/2841473?v=4","gravatar_id":"","url":"https://api.github.com/users/wy65701436","html_url":"https://github.com/wy65701436","followers_url":"https://api.github.com/users/wy65701436/followers","following_url":"https://api.github.com/users/wy65701436/following{/other_user}","gists_url":"https://api.github.com/users/wy65701436/gists{/gist_id}","starred_url":"https://api.github.com/users/wy65701436/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wy65701436/subscriptions","organizations_url":"https://api.github.com/users/wy65701436/orgs","repos_url":"https://api.github.com/users/wy65701436/repos","events_url":"https://api.github.com/users/wy65701436/events{/privacy}","received_events_url":"https://api.github.com/users/wy65701436/received_events","type":"User","site_admin":false},"assignees":[{"login":"wy65701436","id":2841473,"node_id":"MDQ6VXNlcjI4NDE0NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/2841473?v=4","gravatar_id":"","url":"https://api.github.com/users/wy65701436","html_url":"https://github.com/wy65701436","followers_url":"https://api.github.com/users/wy65701436/followers","following_url":"https://api.github.com/users/wy65701436/following{/other_user}","gists_url":"https://api.github.com/users/wy65701436/gists{/gist_id}","starred_url":"https://api.github.com/users/wy65701436/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wy65701436/subscriptions","organizations_url":"https://api.github.com/users/wy65701436/orgs","repos_url":"https://api.github.com/users/wy65701436/repos","events_url":"https://api.github.com/users/wy65701436/events{/privacy}","received_events_url":"https://api.github.com/users/wy65701436/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/goharbor/harbor/pulls/6231/commits","review_comments_url":"https://api.github.com/repos/goharbor/harbor/pulls/6231/comments","review_comment_url":"https://api.github.com/repos/goharbor/harbor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/goharbor/harbor/issues/6231/comments","statuses_url":"https://api.github.com/repos/goharbor/harbor/statuses/fbcb1828ed9ac6bdc0f4db0ebd601b44396d123e","head":{"label":"stonezdj:remove_adminserver","ref":"remove_adminserver","sha":"fbcb1828ed9ac6bdc0f4db0ebd601b44396d123e","user":{"login":"stonezdj","id":2696760,"node_id":"MDQ6VXNlcjI2OTY3NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/2696760?v=4","gravatar_id":"","url":"https://api.github.com/users/stonezdj","html_url":"https://github.com/stonezdj","followers_url":"https://api.github.com/users/stonezdj/followers","following_url":"https://api.github.com/users/stonezdj/following{/other_user}","gists_url":"https://api.github.com/users/stonezdj/gists{/gist_id}","starred_url":"https://api.github.com/users/stonezdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stonezdj/subscriptions","organizations_url":"https://api.github.com/users/stonezdj/orgs","repos_url":"https://api.github.com/users/stonezdj/repos","events_url":"https://api.github.com/users/stonezdj/events{/privacy}","received_events_url":"https://api.github.com/users/stonezdj/received_events","type":"User","site_admin":false},"repo":{"id":102460256,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI0NjAyNTY=","name":"harbor","full_name":"stonezdj/harbor","private":false,"owner":{"login":"stonezdj","id":2696760,"node_id":"MDQ6VXNlcjI2OTY3NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/2696760?v=4","gravatar_id":"","url":"https://api.github.com/users/stonezdj","html_url":"https://github.com/stonezdj","followers_url":"https://api.github.com/users/stonezdj/followers","following_url":"https://api.github.com/users/stonezdj/following{/other_user}","gists_url":"https://api.github.com/users/stonezdj/gists{/gist_id}","starred_url":"https://api.github.com/users/stonezdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stonezdj/subscriptions","organizations_url":"https://api.github.com/users/stonezdj/orgs","repos_url":"https://api.github.com/users/stonezdj/repos","events_url":"https://api.github.com/users/stonezdj/events{/privacy}","received_events_url":"https://api.github.com/users/stonezdj/received_events","type":"User","site_admin":false},"html_url":"https://github.com/stonezdj/harbor","description":"An enterprise-class container registry server based on Docker Distribution","fork":true,"url":"https://api.github.com/repos/stonezdj/harbor","forks_url":"https://api.github.com/repos/stonezdj/harbor/forks","keys_url":"https://api.github.com/repos/stonezdj/harbor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stonezdj/harbor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stonezdj/harbor/teams","hooks_url":"https://api.github.com/repos/stonezdj/harbor/hooks","issue_events_url":"https://api.github.com/repos/stonezdj/harbor/issues/events{/number}","events_url":"https://api.github.com/repos/stonezdj/harbor/events","assignees_url":"https://api.github.com/repos/stonezdj/harbor/assignees{/user}","branches_url":"https://api.github.com/repos/stonezdj/harbor/branches{/branch}","tags_url":"https://api.github.com/repos/stonezdj/harbor/tags","blobs_url":"https://api.github.com/repos/stonezdj/harbor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stonezdj/harbor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stonezdj/harbor/git/refs{/sha}","trees_url":"https://api.github.com/repos/stonezdj/harbor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stonezdj/harbor/statuses/{sha}","languages_url":"https://api.github.com/repos/stonezdj/harbor/languages","stargazers_url":"https://api.github.com/repos/stonezdj/harbor/stargazers","contributors_url":"https://api.github.com/repos/stonezdj/harbor/contributors","subscribers_url":"https://api.github.com/repos/stonezdj/harbor/subscribers","subscription_url":"https://api.github.com/repos/stonezdj/harbor/subscription","commits_url":"https://api.github.com/repos/stonezdj/harbor/commits{/sha}","git_commits_url":"https://api.github.com/repos/stonezdj/harbor/git/commits{/sha}","comments_url":"https://api.github.com/repos/stonezdj/harbor/comments{/number}","issue_comment_url":"https://api.github.com/repos/stonezdj/harbor/issues/comments{/number}","contents_url":"https://api.github.com/repos/stonezdj/harbor/contents/{+path}","compare_url":"https://api.github.com/repos/stonezdj/harbor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stonezdj/harbor/merges","archive_url":"https://api.github.com/repos/stonezdj/harbor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stonezdj/harbor/downloads","issues_url":"https://api.github.com/repos/stonezdj/harbor/issues{/number}","pulls_url":"https://api.github.com/repos/stonezdj/harbor/pulls{/number}","milestones_url":"https://api.github.com/repos/stonezdj/harbor/milestones{/number}","notifications_url":"https://api.github.com/repos/stonezdj/harbor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stonezdj/harbor/labels{/name}","releases_url":"https://api.github.com/repos/stonezdj/harbor/releases{/id}","deployments_url":"https://api.github.com/repos/stonezdj/harbor/deployments","created_at":"2017-09-05T09:12:25Z","updated_at":"2018-11-26T08:45:54Z","pushed_at":"2018-11-26T10:49:02Z","git_url":"git://github.com/stonezdj/harbor.git","ssh_url":"git@github.com:stonezdj/harbor.git","clone_url":"https://github.com/stonezdj/harbor.git","svn_url":"https://github.com/stonezdj/harbor","homepage":"http://vmware.github.io/harbor/","size":114661,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"goharbor:master","ref":"master","sha":"b59a06aa5baa7ffb910176797d9209e4116d9606","user":{"login":"goharbor","id":40275816,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMjc1ODE2","avatar_url":"https://avatars1.githubusercontent.com/u/40275816?v=4","gravatar_id":"","url":"https://api.github.com/users/goharbor","html_url":"https://github.com/goharbor","followers_url":"https://api.github.com/users/goharbor/followers","following_url":"https://api.github.com/users/goharbor/following{/other_user}","gists_url":"https://api.github.com/users/goharbor/gists{/gist_id}","starred_url":"https://api.github.com/users/goharbor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goharbor/subscriptions","organizations_url":"https://api.github.com/users/goharbor/orgs","repos_url":"https://api.github.com/users/goharbor/repos","events_url":"https://api.github.com/users/goharbor/events{/privacy}","received_events_url":"https://api.github.com/users/goharbor/received_events","type":"Organization","site_admin":false},"repo":{"id":50613991,"node_id":"MDEwOlJlcG9zaXRvcnk1MDYxMzk5MQ==","name":"harbor","full_name":"goharbor/harbor","private":false,"owner":{"login":"goharbor","id":40275816,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMjc1ODE2","avatar_url":"https://avatars1.githubusercontent.com/u/40275816?v=4","gravatar_id":"","url":"https://api.github.com/users/goharbor","html_url":"https://github.com/goharbor","followers_url":"https://api.github.com/users/goharbor/followers","following_url":"https://api.github.com/users/goharbor/following{/other_user}","gists_url":"https://api.github.com/users/goharbor/gists{/gist_id}","starred_url":"https://api.github.com/users/goharbor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goharbor/subscriptions","organizations_url":"https://api.github.com/users/goharbor/orgs","repos_url":"https://api.github.com/users/goharbor/repos","events_url":"https://api.github.com/users/goharbor/events{/privacy}","received_events_url":"https://api.github.com/users/goharbor/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/goharbor/harbor","description":"An open source trusted cloud native registry project that stores, signs, and scans content.","fork":false,"url":"https://api.github.com/repos/goharbor/harbor","forks_url":"https://api.github.com/repos/goharbor/harbor/forks","keys_url":"https://api.github.com/repos/goharbor/harbor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/goharbor/harbor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/goharbor/harbor/teams","hooks_url":"https://api.github.com/repos/goharbor/harbor/hooks","issue_events_url":"https://api.github.com/repos/goharbor/harbor/issues/events{/number}","events_url":"https://api.github.com/repos/goharbor/harbor/events","assignees_url":"https://api.github.com/repos/goharbor/harbor/assignees{/user}","branches_url":"https://api.github.com/repos/goharbor/harbor/branches{/branch}","tags_url":"https://api.github.com/repos/goharbor/harbor/tags","blobs_url":"https://api.github.com/repos/goharbor/harbor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/goharbor/harbor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/goharbor/harbor/git/refs{/sha}","trees_url":"https://api.github.com/repos/goharbor/harbor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/goharbor/harbor/statuses/{sha}","languages_url":"https://api.github.com/repos/goharbor/harbor/languages","stargazers_url":"https://api.github.com/repos/goharbor/harbor/stargazers","contributors_url":"https://api.github.com/repos/goharbor/harbor/contributors","subscribers_url":"https://api.github.com/repos/goharbor/harbor/subscribers","subscription_url":"https://api.github.com/repos/goharbor/harbor/subscription","commits_url":"https://api.github.com/repos/goharbor/harbor/commits{/sha}","git_commits_url":"https://api.github.com/repos/goharbor/harbor/git/commits{/sha}","comments_url":"https://api.github.com/repos/goharbor/harbor/comments{/number}","issue_comment_url":"https://api.github.com/repos/goharbor/harbor/issues/comments{/number}","contents_url":"https://api.github.com/repos/goharbor/harbor/contents/{+path}","compare_url":"https://api.github.com/repos/goharbor/harbor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/goharbor/harbor/merges","archive_url":"https://api.github.com/repos/goharbor/harbor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/goharbor/harbor/downloads","issues_url":"https://api.github.com/repos/goharbor/harbor/issues{/number}","pulls_url":"https://api.github.com/repos/goharbor/harbor/pulls{/number}","milestones_url":"https://api.github.com/repos/goharbor/harbor/milestones{/number}","notifications_url":"https://api.github.com/repos/goharbor/harbor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/goharbor/harbor/labels{/name}","releases_url":"https://api.github.com/repos/goharbor/harbor/releases{/id}","deployments_url":"https://api.github.com/repos/goharbor/harbor/deployments","created_at":"2016-01-28T21:10:28Z","updated_at":"2018-11-27T02:53:35Z","pushed_at":"2018-11-27T02:16:14Z","git_url":"git://github.com/goharbor/harbor.git","ssh_url":"git@github.com:goharbor/harbor.git","clone_url":"https://github.com/goharbor/harbor.git","svn_url":"https://github.com/goharbor/harbor","homepage":"https://goharbor.io/","size":109130,"stargazers_count":6119,"watchers_count":6119,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1694,"mirror_url":null,"archived":false,"open_issues_count":403,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1694,"open_issues":403,"watchers":6119,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/goharbor/harbor/pulls/6231"},"html":{"href":"https://github.com/goharbor/harbor/pull/6231"},"issue":{"href":"https://api.github.com/repos/goharbor/harbor/issues/6231"},"comments":{"href":"https://api.github.com/repos/goharbor/harbor/issues/6231/comments"},"review_comments":{"href":"https://api.github.com/repos/goharbor/harbor/pulls/6231/comments"},"review_comment":{"href":"https://api.github.com/repos/goharbor/harbor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/goharbor/harbor/pulls/6231/commits"},"statuses":{"href":"https://api.github.com/repos/goharbor/harbor/statuses/fbcb1828ed9ac6bdc0f4db0ebd601b44396d123e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"wy65701436"}}