{"action":"closed","number":212,"pull_request":{"url":"https://api.github.com/repos/usgs/geomag-algorithms/pulls/212","id":204219426,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MjE5NDI2","html_url":"https://github.com/usgs/geomag-algorithms/pull/212","diff_url":"https://github.com/usgs/geomag-algorithms/pull/212.diff","patch_url":"https://github.com/usgs/geomag-algorithms/pull/212.patch","issue_url":"https://api.github.com/repos/usgs/geomag-algorithms/issues/212","number":212,"state":"closed","locked":false,"title":"Clean timeseries: fixes issues #210 and #211","user":{"login":"arigdon-usgs","id":28928784,"node_id":"MDQ6VXNlcjI4OTI4Nzg0","avatar_url":"https://avatars0.githubusercontent.com/u/28928784?v=4","gravatar_id":"","url":"https://api.github.com/users/arigdon-usgs","html_url":"https://github.com/arigdon-usgs","followers_url":"https://api.github.com/users/arigdon-usgs/followers","following_url":"https://api.github.com/users/arigdon-usgs/following{/other_user}","gists_url":"https://api.github.com/users/arigdon-usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/arigdon-usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arigdon-usgs/subscriptions","organizations_url":"https://api.github.com/users/arigdon-usgs/orgs","repos_url":"https://api.github.com/users/arigdon-usgs/repos","events_url":"https://api.github.com/users/arigdon-usgs/events{/privacy}","received_events_url":"https://api.github.com/users/arigdon-usgs/received_events","type":"User","site_admin":false},"body":"The create missing channel was adding the wrong number of data points at the end by using the length parameter and not the stats.npts. This created issues when cleaning the timeseries. Also re wrote to use delta instead of sampling_rate to make the code clearer and forced the starttime and endtime to be either on the second or minute for their respective intervals.  In the clean timeseries, made sure the start and endtime changes only occurred when the change in time was greater than the delta. Unit tests were written for both of these issues that recreated the problem and then ensured that problem was fixed.","created_at":"2018-07-26T17:53:33Z","updated_at":"2018-07-27T16:47:45Z","closed_at":"2018-07-27T16:47:45Z","merged_at":"2018-07-27T16:47:45Z","merge_commit_sha":"19d97196c5f274fed86749cd206e5f00a177955a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/usgs/geomag-algorithms/pulls/212/commits","review_comments_url":"https://api.github.com/repos/usgs/geomag-algorithms/pulls/212/comments","review_comment_url":"https://api.github.com/repos/usgs/geomag-algorithms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/usgs/geomag-algorithms/issues/212/comments","statuses_url":"https://api.github.com/repos/usgs/geomag-algorithms/statuses/19d97196c5f274fed86749cd206e5f00a177955a","head":{"label":"arigdon-usgs:CleanTimeseries","ref":"CleanTimeseries","sha":"19d97196c5f274fed86749cd206e5f00a177955a","user":{"login":"arigdon-usgs","id":28928784,"node_id":"MDQ6VXNlcjI4OTI4Nzg0","avatar_url":"https://avatars0.githubusercontent.com/u/28928784?v=4","gravatar_id":"","url":"https://api.github.com/users/arigdon-usgs","html_url":"https://github.com/arigdon-usgs","followers_url":"https://api.github.com/users/arigdon-usgs/followers","following_url":"https://api.github.com/users/arigdon-usgs/following{/other_user}","gists_url":"https://api.github.com/users/arigdon-usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/arigdon-usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arigdon-usgs/subscriptions","organizations_url":"https://api.github.com/users/arigdon-usgs/orgs","repos_url":"https://api.github.com/users/arigdon-usgs/repos","events_url":"https://api.github.com/users/arigdon-usgs/events{/privacy}","received_events_url":"https://api.github.com/users/arigdon-usgs/received_events","type":"User","site_admin":false},"repo":{"id":92422434,"node_id":"MDEwOlJlcG9zaXRvcnk5MjQyMjQzNA==","name":"geomag-algorithms","full_name":"arigdon-usgs/geomag-algorithms","owner":{"login":"arigdon-usgs","id":28928784,"node_id":"MDQ6VXNlcjI4OTI4Nzg0","avatar_url":"https://avatars0.githubusercontent.com/u/28928784?v=4","gravatar_id":"","url":"https://api.github.com/users/arigdon-usgs","html_url":"https://github.com/arigdon-usgs","followers_url":"https://api.github.com/users/arigdon-usgs/followers","following_url":"https://api.github.com/users/arigdon-usgs/following{/other_user}","gists_url":"https://api.github.com/users/arigdon-usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/arigdon-usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arigdon-usgs/subscriptions","organizations_url":"https://api.github.com/users/arigdon-usgs/orgs","repos_url":"https://api.github.com/users/arigdon-usgs/repos","events_url":"https://api.github.com/users/arigdon-usgs/events{/privacy}","received_events_url":"https://api.github.com/users/arigdon-usgs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arigdon-usgs/geomag-algorithms","description":null,"fork":true,"url":"https://api.github.com/repos/arigdon-usgs/geomag-algorithms","forks_url":"https://api.github.com/repos/arigdon-usgs/geomag-algorithms/forks","keys_url":"https://api.github.com/repos/arigdon-usgs/geomag-algorithms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arigdon-usgs/geomag-algorithms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arigdon-usgs/geomag-algorithms/teams","hooks_url":"https://api.github.com/repos/arigdon-usgs/geomag-algorithms/hooks","issue_events_url":"https://api.github.com/repos/arigdon-usgs/geomag-algorithms/issues/events{/number}","events_url":"https://api.github.com/repos/arigdon-usgs/geomag-algorithms/events","assignees_url":"https://api.github.com/repos/arigdon-usgs/geomag-algorithms/assignees{/user}","branches_url":"https://api.github.com/repos/arigdon-usgs/geomag-algorithms/branches{/branch}","tags_url":"https://api.github.com/repos/arigdon-usgs/geomag-algorithms/tags","blobs_url":"https://api.github.com/repos/arigdon-usgs/geomag-algorithms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arigdon-usgs/geomag-algorithms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arigdon-usgs/geomag-algorithms/git/refs{/sha}","trees_url":"https://api.github.com/repos/arigdon-usgs/geomag-algorithms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arigdon-usgs/geomag-algorithms/statuses/{sha}","languages_url":"https://api.github.com/repos/arigdon-usgs/geomag-algorithms/languages","stargazers_url":"https://api.github.com/repos/arigdon-usgs/geomag-algorithms/stargazers","contributors_url":"https://api.github.com/repos/arigdon-usgs/geomag-algorithms/contributors","subscribers_url":"https://api.github.com/repos/arigdon-usgs/geomag-algorithms/subscribers","subscription_url":"https://api.github.com/repos/arigdon-usgs/geomag-algorithms/subscription","commits_url":"https://api.github.com/repos/arigdon-usgs/geomag-algorithms/commits{/sha}","git_commits_url":"https://api.github.com/repos/arigdon-usgs/geomag-algorithms/git/commits{/sha}","comments_url":"https://api.github.com/repos/arigdon-usgs/geomag-algorithms/comments{/number}","issue_comment_url":"https://api.github.com/repos/arigdon-usgs/geomag-algorithms/issues/comments{/number}","contents_url":"https://api.github.com/repos/arigdon-usgs/geomag-algorithms/contents/{+path}","compare_url":"https://api.github.com/repos/arigdon-usgs/geomag-algorithms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arigdon-usgs/geomag-algorithms/merges","archive_url":"https://api.github.com/repos/arigdon-usgs/geomag-algorithms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arigdon-usgs/geomag-algorithms/downloads","issues_url":"https://api.github.com/repos/arigdon-usgs/geomag-algorithms/issues{/number}","pulls_url":"https://api.github.com/repos/arigdon-usgs/geomag-algorithms/pulls{/number}","milestones_url":"https://api.github.com/repos/arigdon-usgs/geomag-algorithms/milestones{/number}","notifications_url":"https://api.github.com/repos/arigdon-usgs/geomag-algorithms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arigdon-usgs/geomag-algorithms/labels{/name}","releases_url":"https://api.github.com/repos/arigdon-usgs/geomag-algorithms/releases{/id}","deployments_url":"https://api.github.com/repos/arigdon-usgs/geomag-algorithms/deployments","created_at":"2017-05-25T16:25:06Z","updated_at":"2018-07-23T15:15:55Z","pushed_at":"2018-07-27T15:09:21Z","git_url":"git://github.com/arigdon-usgs/geomag-algorithms.git","ssh_url":"git@github.com:arigdon-usgs/geomag-algorithms.git","clone_url":"https://github.com/arigdon-usgs/geomag-algorithms.git","svn_url":"https://github.com/arigdon-usgs/geomag-algorithms","homepage":null,"size":8835,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"usgs:master","ref":"master","sha":"99f286860ab1be46bbdd65ee03a01b04bec552cd","user":{"login":"usgs","id":1091434,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwOTE0MzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1091434?v=4","gravatar_id":"","url":"https://api.github.com/users/usgs","html_url":"https://github.com/usgs","followers_url":"https://api.github.com/users/usgs/followers","following_url":"https://api.github.com/users/usgs/following{/other_user}","gists_url":"https://api.github.com/users/usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usgs/subscriptions","organizations_url":"https://api.github.com/users/usgs/orgs","repos_url":"https://api.github.com/users/usgs/repos","events_url":"https://api.github.com/users/usgs/events{/privacy}","received_events_url":"https://api.github.com/users/usgs/received_events","type":"Organization","site_admin":false},"repo":{"id":24066826,"node_id":"MDEwOlJlcG9zaXRvcnkyNDA2NjgyNg==","name":"geomag-algorithms","full_name":"usgs/geomag-algorithms","owner":{"login":"usgs","id":1091434,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwOTE0MzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1091434?v=4","gravatar_id":"","url":"https://api.github.com/users/usgs","html_url":"https://github.com/usgs","followers_url":"https://api.github.com/users/usgs/followers","following_url":"https://api.github.com/users/usgs/following{/other_user}","gists_url":"https://api.github.com/users/usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usgs/subscriptions","organizations_url":"https://api.github.com/users/usgs/orgs","repos_url":"https://api.github.com/users/usgs/repos","events_url":"https://api.github.com/users/usgs/events{/privacy}","received_events_url":"https://api.github.com/users/usgs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/usgs/geomag-algorithms","description":"Library for processing Geomagnetic timeseries data.","fork":false,"url":"https://api.github.com/repos/usgs/geomag-algorithms","forks_url":"https://api.github.com/repos/usgs/geomag-algorithms/forks","keys_url":"https://api.github.com/repos/usgs/geomag-algorithms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/usgs/geomag-algorithms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/usgs/geomag-algorithms/teams","hooks_url":"https://api.github.com/repos/usgs/geomag-algorithms/hooks","issue_events_url":"https://api.github.com/repos/usgs/geomag-algorithms/issues/events{/number}","events_url":"https://api.github.com/repos/usgs/geomag-algorithms/events","assignees_url":"https://api.github.com/repos/usgs/geomag-algorithms/assignees{/user}","branches_url":"https://api.github.com/repos/usgs/geomag-algorithms/branches{/branch}","tags_url":"https://api.github.com/repos/usgs/geomag-algorithms/tags","blobs_url":"https://api.github.com/repos/usgs/geomag-algorithms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/usgs/geomag-algorithms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/usgs/geomag-algorithms/git/refs{/sha}","trees_url":"https://api.github.com/repos/usgs/geomag-algorithms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/usgs/geomag-algorithms/statuses/{sha}","languages_url":"https://api.github.com/repos/usgs/geomag-algorithms/languages","stargazers_url":"https://api.github.com/repos/usgs/geomag-algorithms/stargazers","contributors_url":"https://api.github.com/repos/usgs/geomag-algorithms/contributors","subscribers_url":"https://api.github.com/repos/usgs/geomag-algorithms/subscribers","subscription_url":"https://api.github.com/repos/usgs/geomag-algorithms/subscription","commits_url":"https://api.github.com/repos/usgs/geomag-algorithms/commits{/sha}","git_commits_url":"https://api.github.com/repos/usgs/geomag-algorithms/git/commits{/sha}","comments_url":"https://api.github.com/repos/usgs/geomag-algorithms/comments{/number}","issue_comment_url":"https://api.github.com/repos/usgs/geomag-algorithms/issues/comments{/number}","contents_url":"https://api.github.com/repos/usgs/geomag-algorithms/contents/{+path}","compare_url":"https://api.github.com/repos/usgs/geomag-algorithms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/usgs/geomag-algorithms/merges","archive_url":"https://api.github.com/repos/usgs/geomag-algorithms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/usgs/geomag-algorithms/downloads","issues_url":"https://api.github.com/repos/usgs/geomag-algorithms/issues{/number}","pulls_url":"https://api.github.com/repos/usgs/geomag-algorithms/pulls{/number}","milestones_url":"https://api.github.com/repos/usgs/geomag-algorithms/milestones{/number}","notifications_url":"https://api.github.com/repos/usgs/geomag-algorithms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/usgs/geomag-algorithms/labels{/name}","releases_url":"https://api.github.com/repos/usgs/geomag-algorithms/releases{/id}","deployments_url":"https://api.github.com/repos/usgs/geomag-algorithms/deployments","created_at":"2014-09-15T17:53:56Z","updated_at":"2018-07-26T21:06:41Z","pushed_at":"2018-07-27T16:47:44Z","git_url":"git://github.com/usgs/geomag-algorithms.git","ssh_url":"git@github.com:usgs/geomag-algorithms.git","clone_url":"https://github.com/usgs/geomag-algorithms.git","svn_url":"https://github.com/usgs/geomag-algorithms","homepage":"","size":8822,"stargazers_count":20,"watchers_count":20,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":41,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":25,"open_issues":41,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/usgs/geomag-algorithms/pulls/212"},"html":{"href":"https://github.com/usgs/geomag-algorithms/pull/212"},"issue":{"href":"https://api.github.com/repos/usgs/geomag-algorithms/issues/212"},"comments":{"href":"https://api.github.com/repos/usgs/geomag-algorithms/issues/212/comments"},"review_comments":{"href":"https://api.github.com/repos/usgs/geomag-algorithms/pulls/212/comments"},"review_comment":{"href":"https://api.github.com/repos/usgs/geomag-algorithms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/usgs/geomag-algorithms/pulls/212/commits"},"statuses":{"href":"https://api.github.com/repos/usgs/geomag-algorithms/statuses/19d97196c5f274fed86749cd206e5f00a177955a"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jmfee-usgs","id":1717896,"node_id":"MDQ6VXNlcjE3MTc4OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/1717896?v=4","gravatar_id":"","url":"https://api.github.com/users/jmfee-usgs","html_url":"https://github.com/jmfee-usgs","followers_url":"https://api.github.com/users/jmfee-usgs/followers","following_url":"https://api.github.com/users/jmfee-usgs/following{/other_user}","gists_url":"https://api.github.com/users/jmfee-usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/jmfee-usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmfee-usgs/subscriptions","organizations_url":"https://api.github.com/users/jmfee-usgs/orgs","repos_url":"https://api.github.com/users/jmfee-usgs/repos","events_url":"https://api.github.com/users/jmfee-usgs/events{/privacy}","received_events_url":"https://api.github.com/users/jmfee-usgs/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":5,"additions":113,"deletions":27,"changed_files":2}}
{"actor":{"display_login":"jmfee-usgs"}}