{"action":"created","comment":{"url":"https://api.github.com/repos/openucx/ucx/pulls/comments/239997999","pull_request_review_id":182936879,"id":239997999,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTk5Nzk5OQ==","diff_hunk":"@@ -1247,12 +1242,16 @@ void ucp_ep_config_init(ucp_worker_h worker, ucp_ep_config_t *config)\n                 rma_config->put_zcopy_thresh = ucs_max(rma_config->put_zcopy_thresh,\n                                                        iface_attr->cap.put.min_zcopy);\n             }\n-            if (iface_attr->cap.flags & UCT_IFACE_FLAG_GET_SHORT) {\n-                rma_config->max_get_short = iface_attr->cap.get.max_short;\n+            if (iface_attr->cap.flags & UCT_IFACE_FLAG_PUT_BCOPY) {\n+                rma_config->max_put_bcopy = ucs_min(iface_attr->cap.put.max_bcopy,\n+                                                    rma_config->put_zcopy_thresh);\n             }\n-            if (iface_attr->cap.flags & UCT_IFACE_FLAG_GET_BCOPY) {\n-                rma_config->max_get_bcopy = iface_attr->cap.get.max_bcopy;\n+            if (iface_attr->cap.flags & UCT_IFACE_FLAG_PUT_SHORT) {\n+                rma_config->max_put_short = ucs_min(iface_attr->cap.put.max_short,","path":"src/ucp/core/ucp_ep.c","position":38,"original_position":27,"commit_id":"f64afc440c6f2cfffd7f1e1029efa19257403776","original_commit_id":"94ad8a274040c95646577989a53d3ff08fd11bfa","user":{"login":"evgeny-leksikov","id":15216359,"node_id":"MDQ6VXNlcjE1MjE2MzU5","avatar_url":"https://avatars3.githubusercontent.com/u/15216359?v=4","gravatar_id":"","url":"https://api.github.com/users/evgeny-leksikov","html_url":"https://github.com/evgeny-leksikov","followers_url":"https://api.github.com/users/evgeny-leksikov/followers","following_url":"https://api.github.com/users/evgeny-leksikov/following{/other_user}","gists_url":"https://api.github.com/users/evgeny-leksikov/gists{/gist_id}","starred_url":"https://api.github.com/users/evgeny-leksikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evgeny-leksikov/subscriptions","organizations_url":"https://api.github.com/users/evgeny-leksikov/orgs","repos_url":"https://api.github.com/users/evgeny-leksikov/repos","events_url":"https://api.github.com/users/evgeny-leksikov/events{/privacy}","received_events_url":"https://api.github.com/users/evgeny-leksikov/received_events","type":"User","site_admin":false},"body":"it's initialized above with `SIZE_MAX`, should work as expected.","created_at":"2018-12-08T08:19:44Z","updated_at":"2018-12-08T08:19:44Z","html_url":"https://github.com/openucx/ucx/pull/3085#discussion_r239997999","pull_request_url":"https://api.github.com/repos/openucx/ucx/pulls/3085","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openucx/ucx/pulls/comments/239997999"},"html":{"href":"https://github.com/openucx/ucx/pull/3085#discussion_r239997999"},"pull_request":{"href":"https://api.github.com/repos/openucx/ucx/pulls/3085"}},"in_reply_to_id":239824106},"pull_request":{"url":"https://api.github.com/repos/openucx/ucx/pulls/3085","id":236571438,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2NTcxNDM4","html_url":"https://github.com/openucx/ucx/pull/3085","diff_url":"https://github.com/openucx/ucx/pull/3085.diff","patch_url":"https://github.com/openucx/ucx/pull/3085.patch","issue_url":"https://api.github.com/repos/openucx/ucx/issues/3085","number":3085,"state":"open","locked":false,"title":"UCP/EP: fix rma config thresholds","user":{"login":"evgeny-leksikov","id":15216359,"node_id":"MDQ6VXNlcjE1MjE2MzU5","avatar_url":"https://avatars3.githubusercontent.com/u/15216359?v=4","gravatar_id":"","url":"https://api.github.com/users/evgeny-leksikov","html_url":"https://github.com/evgeny-leksikov","followers_url":"https://api.github.com/users/evgeny-leksikov/followers","following_url":"https://api.github.com/users/evgeny-leksikov/following{/other_user}","gists_url":"https://api.github.com/users/evgeny-leksikov/gists{/gist_id}","starred_url":"https://api.github.com/users/evgeny-leksikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evgeny-leksikov/subscriptions","organizations_url":"https://api.github.com/users/evgeny-leksikov/orgs","repos_url":"https://api.github.com/users/evgeny-leksikov/repos","events_url":"https://api.github.com/users/evgeny-leksikov/events{/privacy}","received_events_url":"https://api.github.com/users/evgeny-leksikov/received_events","type":"User","site_admin":false},"body":"## What\r\nFixes RMA short/bcopy/zcopy thresholds\r\n\r\n## Why ?\r\nFixes https://github.com/openucx/ucx/issues/3081\r\nUCX_ZCOPY_THRESH was not applied to ucp_<put|get>*\r\n","created_at":"2018-12-06T15:32:58Z","updated_at":"2018-12-08T08:19:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d26ec5eb9c6b13b9d89f8d7a274b4ca11a8e5ef0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openucx/ucx/pulls/3085/commits","review_comments_url":"https://api.github.com/repos/openucx/ucx/pulls/3085/comments","review_comment_url":"https://api.github.com/repos/openucx/ucx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openucx/ucx/issues/3085/comments","statuses_url":"https://api.github.com/repos/openucx/ucx/statuses/f64afc440c6f2cfffd7f1e1029efa19257403776","head":{"label":"evgeny-leksikov:ucp_ep_rma_config_thresh","ref":"ucp_ep_rma_config_thresh","sha":"f64afc440c6f2cfffd7f1e1029efa19257403776","user":{"login":"evgeny-leksikov","id":15216359,"node_id":"MDQ6VXNlcjE1MjE2MzU5","avatar_url":"https://avatars3.githubusercontent.com/u/15216359?v=4","gravatar_id":"","url":"https://api.github.com/users/evgeny-leksikov","html_url":"https://github.com/evgeny-leksikov","followers_url":"https://api.github.com/users/evgeny-leksikov/followers","following_url":"https://api.github.com/users/evgeny-leksikov/following{/other_user}","gists_url":"https://api.github.com/users/evgeny-leksikov/gists{/gist_id}","starred_url":"https://api.github.com/users/evgeny-leksikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evgeny-leksikov/subscriptions","organizations_url":"https://api.github.com/users/evgeny-leksikov/orgs","repos_url":"https://api.github.com/users/evgeny-leksikov/repos","events_url":"https://api.github.com/users/evgeny-leksikov/events{/privacy}","received_events_url":"https://api.github.com/users/evgeny-leksikov/received_events","type":"User","site_admin":false},"repo":{"id":77319416,"node_id":"MDEwOlJlcG9zaXRvcnk3NzMxOTQxNg==","name":"ucx","full_name":"evgeny-leksikov/ucx","private":false,"owner":{"login":"evgeny-leksikov","id":15216359,"node_id":"MDQ6VXNlcjE1MjE2MzU5","avatar_url":"https://avatars3.githubusercontent.com/u/15216359?v=4","gravatar_id":"","url":"https://api.github.com/users/evgeny-leksikov","html_url":"https://github.com/evgeny-leksikov","followers_url":"https://api.github.com/users/evgeny-leksikov/followers","following_url":"https://api.github.com/users/evgeny-leksikov/following{/other_user}","gists_url":"https://api.github.com/users/evgeny-leksikov/gists{/gist_id}","starred_url":"https://api.github.com/users/evgeny-leksikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evgeny-leksikov/subscriptions","organizations_url":"https://api.github.com/users/evgeny-leksikov/orgs","repos_url":"https://api.github.com/users/evgeny-leksikov/repos","events_url":"https://api.github.com/users/evgeny-leksikov/events{/privacy}","received_events_url":"https://api.github.com/users/evgeny-leksikov/received_events","type":"User","site_admin":false},"html_url":"https://github.com/evgeny-leksikov/ucx","description":"Unified Communication X  (mailing list - https://elist.ornl.gov/mailman/listinfo/ucx-group): ","fork":true,"url":"https://api.github.com/repos/evgeny-leksikov/ucx","forks_url":"https://api.github.com/repos/evgeny-leksikov/ucx/forks","keys_url":"https://api.github.com/repos/evgeny-leksikov/ucx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/evgeny-leksikov/ucx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/evgeny-leksikov/ucx/teams","hooks_url":"https://api.github.com/repos/evgeny-leksikov/ucx/hooks","issue_events_url":"https://api.github.com/repos/evgeny-leksikov/ucx/issues/events{/number}","events_url":"https://api.github.com/repos/evgeny-leksikov/ucx/events","assignees_url":"https://api.github.com/repos/evgeny-leksikov/ucx/assignees{/user}","branches_url":"https://api.github.com/repos/evgeny-leksikov/ucx/branches{/branch}","tags_url":"https://api.github.com/repos/evgeny-leksikov/ucx/tags","blobs_url":"https://api.github.com/repos/evgeny-leksikov/ucx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/evgeny-leksikov/ucx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/evgeny-leksikov/ucx/git/refs{/sha}","trees_url":"https://api.github.com/repos/evgeny-leksikov/ucx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/evgeny-leksikov/ucx/statuses/{sha}","languages_url":"https://api.github.com/repos/evgeny-leksikov/ucx/languages","stargazers_url":"https://api.github.com/repos/evgeny-leksikov/ucx/stargazers","contributors_url":"https://api.github.com/repos/evgeny-leksikov/ucx/contributors","subscribers_url":"https://api.github.com/repos/evgeny-leksikov/ucx/subscribers","subscription_url":"https://api.github.com/repos/evgeny-leksikov/ucx/subscription","commits_url":"https://api.github.com/repos/evgeny-leksikov/ucx/commits{/sha}","git_commits_url":"https://api.github.com/repos/evgeny-leksikov/ucx/git/commits{/sha}","comments_url":"https://api.github.com/repos/evgeny-leksikov/ucx/comments{/number}","issue_comment_url":"https://api.github.com/repos/evgeny-leksikov/ucx/issues/comments{/number}","contents_url":"https://api.github.com/repos/evgeny-leksikov/ucx/contents/{+path}","compare_url":"https://api.github.com/repos/evgeny-leksikov/ucx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/evgeny-leksikov/ucx/merges","archive_url":"https://api.github.com/repos/evgeny-leksikov/ucx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/evgeny-leksikov/ucx/downloads","issues_url":"https://api.github.com/repos/evgeny-leksikov/ucx/issues{/number}","pulls_url":"https://api.github.com/repos/evgeny-leksikov/ucx/pulls{/number}","milestones_url":"https://api.github.com/repos/evgeny-leksikov/ucx/milestones{/number}","notifications_url":"https://api.github.com/repos/evgeny-leksikov/ucx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/evgeny-leksikov/ucx/labels{/name}","releases_url":"https://api.github.com/repos/evgeny-leksikov/ucx/releases{/id}","deployments_url":"https://api.github.com/repos/evgeny-leksikov/ucx/deployments","created_at":"2016-12-25T09:34:08Z","updated_at":"2018-12-05T10:27:49Z","pushed_at":"2018-12-08T08:18:55Z","git_url":"git://github.com/evgeny-leksikov/ucx.git","ssh_url":"git@github.com:evgeny-leksikov/ucx.git","clone_url":"https://github.com/evgeny-leksikov/ucx.git","svn_url":"https://github.com/evgeny-leksikov/ucx","homepage":"http://www.openucx.org","size":14663,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openucx:master","ref":"master","sha":"ac1da8ba4466bb6f2f80eb18d973d41154452056","user":{"login":"openucx","id":13118737,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTE4NzM3","avatar_url":"https://avatars2.githubusercontent.com/u/13118737?v=4","gravatar_id":"","url":"https://api.github.com/users/openucx","html_url":"https://github.com/openucx","followers_url":"https://api.github.com/users/openucx/followers","following_url":"https://api.github.com/users/openucx/following{/other_user}","gists_url":"https://api.github.com/users/openucx/gists{/gist_id}","starred_url":"https://api.github.com/users/openucx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openucx/subscriptions","organizations_url":"https://api.github.com/users/openucx/orgs","repos_url":"https://api.github.com/users/openucx/repos","events_url":"https://api.github.com/users/openucx/events{/privacy}","received_events_url":"https://api.github.com/users/openucx/received_events","type":"Organization","site_admin":false},"repo":{"id":25379390,"node_id":"MDEwOlJlcG9zaXRvcnkyNTM3OTM5MA==","name":"ucx","full_name":"openucx/ucx","private":false,"owner":{"login":"openucx","id":13118737,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTE4NzM3","avatar_url":"https://avatars2.githubusercontent.com/u/13118737?v=4","gravatar_id":"","url":"https://api.github.com/users/openucx","html_url":"https://github.com/openucx","followers_url":"https://api.github.com/users/openucx/followers","following_url":"https://api.github.com/users/openucx/following{/other_user}","gists_url":"https://api.github.com/users/openucx/gists{/gist_id}","starred_url":"https://api.github.com/users/openucx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openucx/subscriptions","organizations_url":"https://api.github.com/users/openucx/orgs","repos_url":"https://api.github.com/users/openucx/repos","events_url":"https://api.github.com/users/openucx/events{/privacy}","received_events_url":"https://api.github.com/users/openucx/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openucx/ucx","description":"Unified Communication X  (mailing list - https://elist.ornl.gov/mailman/listinfo/ucx-group): ","fork":false,"url":"https://api.github.com/repos/openucx/ucx","forks_url":"https://api.github.com/repos/openucx/ucx/forks","keys_url":"https://api.github.com/repos/openucx/ucx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openucx/ucx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openucx/ucx/teams","hooks_url":"https://api.github.com/repos/openucx/ucx/hooks","issue_events_url":"https://api.github.com/repos/openucx/ucx/issues/events{/number}","events_url":"https://api.github.com/repos/openucx/ucx/events","assignees_url":"https://api.github.com/repos/openucx/ucx/assignees{/user}","branches_url":"https://api.github.com/repos/openucx/ucx/branches{/branch}","tags_url":"https://api.github.com/repos/openucx/ucx/tags","blobs_url":"https://api.github.com/repos/openucx/ucx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openucx/ucx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openucx/ucx/git/refs{/sha}","trees_url":"https://api.github.com/repos/openucx/ucx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openucx/ucx/statuses/{sha}","languages_url":"https://api.github.com/repos/openucx/ucx/languages","stargazers_url":"https://api.github.com/repos/openucx/ucx/stargazers","contributors_url":"https://api.github.com/repos/openucx/ucx/contributors","subscribers_url":"https://api.github.com/repos/openucx/ucx/subscribers","subscription_url":"https://api.github.com/repos/openucx/ucx/subscription","commits_url":"https://api.github.com/repos/openucx/ucx/commits{/sha}","git_commits_url":"https://api.github.com/repos/openucx/ucx/git/commits{/sha}","comments_url":"https://api.github.com/repos/openucx/ucx/comments{/number}","issue_comment_url":"https://api.github.com/repos/openucx/ucx/issues/comments{/number}","contents_url":"https://api.github.com/repos/openucx/ucx/contents/{+path}","compare_url":"https://api.github.com/repos/openucx/ucx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openucx/ucx/merges","archive_url":"https://api.github.com/repos/openucx/ucx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openucx/ucx/downloads","issues_url":"https://api.github.com/repos/openucx/ucx/issues{/number}","pulls_url":"https://api.github.com/repos/openucx/ucx/pulls{/number}","milestones_url":"https://api.github.com/repos/openucx/ucx/milestones{/number}","notifications_url":"https://api.github.com/repos/openucx/ucx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openucx/ucx/labels{/name}","releases_url":"https://api.github.com/repos/openucx/ucx/releases{/id}","deployments_url":"https://api.github.com/repos/openucx/ucx/deployments","created_at":"2014-10-17T22:17:24Z","updated_at":"2018-12-07T14:19:13Z","pushed_at":"2018-12-08T08:18:56Z","git_url":"git://github.com/openucx/ucx.git","ssh_url":"git@github.com:openucx/ucx.git","clone_url":"https://github.com/openucx/ucx.git","svn_url":"https://github.com/openucx/ucx","homepage":"http://www.openucx.org","size":14697,"stargazers_count":146,"watchers_count":146,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":80,"mirror_url":null,"archived":false,"open_issues_count":166,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":80,"open_issues":166,"watchers":146,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openucx/ucx/pulls/3085"},"html":{"href":"https://github.com/openucx/ucx/pull/3085"},"issue":{"href":"https://api.github.com/repos/openucx/ucx/issues/3085"},"comments":{"href":"https://api.github.com/repos/openucx/ucx/issues/3085/comments"},"review_comments":{"href":"https://api.github.com/repos/openucx/ucx/pulls/3085/comments"},"review_comment":{"href":"https://api.github.com/repos/openucx/ucx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openucx/ucx/pulls/3085/commits"},"statuses":{"href":"https://api.github.com/repos/openucx/ucx/statuses/f64afc440c6f2cfffd7f1e1029efa19257403776"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"evgeny-leksikov"}}