{"action":"closed","number":7265,"pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/7265","id":202724227,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNzI0MjI3","html_url":"https://github.com/istio/istio/pull/7265","diff_url":"https://github.com/istio/istio/pull/7265.diff","patch_url":"https://github.com/istio/istio/pull/7265.patch","issue_url":"https://api.github.com/repos/istio/istio/issues/7265","number":7265,"state":"closed","locked":false,"title":"Mixer Conditional Quota","user":{"login":"mandarjog","id":800375,"node_id":"MDQ6VXNlcjgwMDM3NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/800375?v=4","gravatar_id":"","url":"https://api.github.com/users/mandarjog","html_url":"https://github.com/mandarjog","followers_url":"https://api.github.com/users/mandarjog/followers","following_url":"https://api.github.com/users/mandarjog/following{/other_user}","gists_url":"https://api.github.com/users/mandarjog/gists{/gist_id}","starred_url":"https://api.github.com/users/mandarjog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandarjog/subscriptions","organizations_url":"https://api.github.com/users/mandarjog/orgs","repos_url":"https://api.github.com/users/mandarjog/repos","events_url":"https://api.github.com/users/mandarjog/events{/privacy}","received_events_url":"https://api.github.com/users/mandarjog/received_events","type":"User","site_admin":false},"body":"This PR implements conditional quota in the new dispatcher.\r\nThis fixes a regression caused when quota moved to the new dispatcher.\r\n\r\n1. If a conditional quota does not apply to the request, Mixer returns what was requested.\r\n2. If a quota is not found on Mixer, mixer still returns what was requested but logs a warning.\r\n    It is expected that quotaSpec, quotaSpecBindings and Mixer rules are applied in various order. We should not deny traffic in the interim.","created_at":"2018-07-20T01:30:44Z","updated_at":"2018-07-20T19:09:48Z","closed_at":"2018-07-20T19:09:48Z","merged_at":"2018-07-20T19:09:48Z","merge_commit_sha":"0b71b826cf2b0b803aa5019f57bbfd2c71e1a511","assignee":{"login":"geeknoid","id":22780957,"node_id":"MDQ6VXNlcjIyNzgwOTU3","avatar_url":"https://avatars3.githubusercontent.com/u/22780957?v=4","gravatar_id":"","url":"https://api.github.com/users/geeknoid","html_url":"https://github.com/geeknoid","followers_url":"https://api.github.com/users/geeknoid/followers","following_url":"https://api.github.com/users/geeknoid/following{/other_user}","gists_url":"https://api.github.com/users/geeknoid/gists{/gist_id}","starred_url":"https://api.github.com/users/geeknoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geeknoid/subscriptions","organizations_url":"https://api.github.com/users/geeknoid/orgs","repos_url":"https://api.github.com/users/geeknoid/repos","events_url":"https://api.github.com/users/geeknoid/events{/privacy}","received_events_url":"https://api.github.com/users/geeknoid/received_events","type":"User","site_admin":false},"assignees":[{"login":"geeknoid","id":22780957,"node_id":"MDQ6VXNlcjIyNzgwOTU3","avatar_url":"https://avatars3.githubusercontent.com/u/22780957?v=4","gravatar_id":"","url":"https://api.github.com/users/geeknoid","html_url":"https://github.com/geeknoid","followers_url":"https://api.github.com/users/geeknoid/followers","following_url":"https://api.github.com/users/geeknoid/following{/other_user}","gists_url":"https://api.github.com/users/geeknoid/gists{/gist_id}","starred_url":"https://api.github.com/users/geeknoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geeknoid/subscriptions","organizations_url":"https://api.github.com/users/geeknoid/orgs","repos_url":"https://api.github.com/users/geeknoid/repos","events_url":"https://api.github.com/users/geeknoid/events{/privacy}","received_events_url":"https://api.github.com/users/geeknoid/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"douglas-reid","id":21148125,"node_id":"MDQ6VXNlcjIxMTQ4MTI1","avatar_url":"https://avatars3.githubusercontent.com/u/21148125?v=4","gravatar_id":"","url":"https://api.github.com/users/douglas-reid","html_url":"https://github.com/douglas-reid","followers_url":"https://api.github.com/users/douglas-reid/followers","following_url":"https://api.github.com/users/douglas-reid/following{/other_user}","gists_url":"https://api.github.com/users/douglas-reid/gists{/gist_id}","starred_url":"https://api.github.com/users/douglas-reid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/douglas-reid/subscriptions","organizations_url":"https://api.github.com/users/douglas-reid/orgs","repos_url":"https://api.github.com/users/douglas-reid/repos","events_url":"https://api.github.com/users/douglas-reid/events{/privacy}","received_events_url":"https://api.github.com/users/douglas-reid/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":659652351,"node_id":"MDU6TGFiZWw2NTk2NTIzNTE=","url":"https://api.github.com/repos/istio/istio/labels/approved","name":"approved","color":"bfdadc","default":false},{"id":491318011,"node_id":"MDU6TGFiZWw0OTEzMTgwMTE=","url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false},{"id":660556986,"node_id":"MDU6TGFiZWw2NjA1NTY5ODY=","url":"https://api.github.com/repos/istio/istio/labels/lgtm","name":"lgtm","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/istio/pulls/7265/commits","review_comments_url":"https://api.github.com/repos/istio/istio/pulls/7265/comments","review_comment_url":"https://api.github.com/repos/istio/istio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/istio/issues/7265/comments","statuses_url":"https://api.github.com/repos/istio/istio/statuses/1633b9e7f0195eef5bc85374f666e1f52ab87135","head":{"label":"mandarjog:conditional_quota","ref":"conditional_quota","sha":"1633b9e7f0195eef5bc85374f666e1f52ab87135","user":{"login":"mandarjog","id":800375,"node_id":"MDQ6VXNlcjgwMDM3NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/800375?v=4","gravatar_id":"","url":"https://api.github.com/users/mandarjog","html_url":"https://github.com/mandarjog","followers_url":"https://api.github.com/users/mandarjog/followers","following_url":"https://api.github.com/users/mandarjog/following{/other_user}","gists_url":"https://api.github.com/users/mandarjog/gists{/gist_id}","starred_url":"https://api.github.com/users/mandarjog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandarjog/subscriptions","organizations_url":"https://api.github.com/users/mandarjog/orgs","repos_url":"https://api.github.com/users/mandarjog/repos","events_url":"https://api.github.com/users/mandarjog/events{/privacy}","received_events_url":"https://api.github.com/users/mandarjog/received_events","type":"User","site_admin":false},"repo":{"id":76583321,"node_id":"MDEwOlJlcG9zaXRvcnk3NjU4MzMyMQ==","name":"istio","full_name":"mandarjog/istio","owner":{"login":"mandarjog","id":800375,"node_id":"MDQ6VXNlcjgwMDM3NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/800375?v=4","gravatar_id":"","url":"https://api.github.com/users/mandarjog","html_url":"https://github.com/mandarjog","followers_url":"https://api.github.com/users/mandarjog/followers","following_url":"https://api.github.com/users/mandarjog/following{/other_user}","gists_url":"https://api.github.com/users/mandarjog/gists{/gist_id}","starred_url":"https://api.github.com/users/mandarjog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandarjog/subscriptions","organizations_url":"https://api.github.com/users/mandarjog/orgs","repos_url":"https://api.github.com/users/mandarjog/repos","events_url":"https://api.github.com/users/mandarjog/events{/privacy}","received_events_url":"https://api.github.com/users/mandarjog/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mandarjog/istio","description":"A Service Fabric for Polyglot Microservices","fork":true,"url":"https://api.github.com/repos/mandarjog/istio","forks_url":"https://api.github.com/repos/mandarjog/istio/forks","keys_url":"https://api.github.com/repos/mandarjog/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mandarjog/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mandarjog/istio/teams","hooks_url":"https://api.github.com/repos/mandarjog/istio/hooks","issue_events_url":"https://api.github.com/repos/mandarjog/istio/issues/events{/number}","events_url":"https://api.github.com/repos/mandarjog/istio/events","assignees_url":"https://api.github.com/repos/mandarjog/istio/assignees{/user}","branches_url":"https://api.github.com/repos/mandarjog/istio/branches{/branch}","tags_url":"https://api.github.com/repos/mandarjog/istio/tags","blobs_url":"https://api.github.com/repos/mandarjog/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mandarjog/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mandarjog/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/mandarjog/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mandarjog/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/mandarjog/istio/languages","stargazers_url":"https://api.github.com/repos/mandarjog/istio/stargazers","contributors_url":"https://api.github.com/repos/mandarjog/istio/contributors","subscribers_url":"https://api.github.com/repos/mandarjog/istio/subscribers","subscription_url":"https://api.github.com/repos/mandarjog/istio/subscription","commits_url":"https://api.github.com/repos/mandarjog/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/mandarjog/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/mandarjog/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/mandarjog/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/mandarjog/istio/contents/{+path}","compare_url":"https://api.github.com/repos/mandarjog/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mandarjog/istio/merges","archive_url":"https://api.github.com/repos/mandarjog/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mandarjog/istio/downloads","issues_url":"https://api.github.com/repos/mandarjog/istio/issues{/number}","pulls_url":"https://api.github.com/repos/mandarjog/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/mandarjog/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/mandarjog/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mandarjog/istio/labels{/name}","releases_url":"https://api.github.com/repos/mandarjog/istio/releases{/id}","deployments_url":"https://api.github.com/repos/mandarjog/istio/deployments","created_at":"2016-12-15T18:01:34Z","updated_at":"2017-10-30T13:15:26Z","pushed_at":"2018-07-20T01:22:39Z","git_url":"git://github.com/mandarjog/istio.git","ssh_url":"git@github.com:mandarjog/istio.git","clone_url":"https://github.com/mandarjog/istio.git","svn_url":"https://github.com/mandarjog/istio","homepage":null,"size":142421,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:release-1.0","ref":"release-1.0","sha":"9cc03e6eaa4c2f5f5238095463fc33f1f148aba5","user":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":74175805,"node_id":"MDEwOlJlcG9zaXRvcnk3NDE3NTgwNQ==","name":"istio","full_name":"istio/istio","owner":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/istio","description":"An open platform to connect, manage, and secure microservices.","fork":false,"url":"https://api.github.com/repos/istio/istio","forks_url":"https://api.github.com/repos/istio/istio/forks","keys_url":"https://api.github.com/repos/istio/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio/teams","hooks_url":"https://api.github.com/repos/istio/istio/hooks","issue_events_url":"https://api.github.com/repos/istio/istio/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio/events","assignees_url":"https://api.github.com/repos/istio/istio/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio/tags","blobs_url":"https://api.github.com/repos/istio/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio/languages","stargazers_url":"https://api.github.com/repos/istio/istio/stargazers","contributors_url":"https://api.github.com/repos/istio/istio/contributors","subscribers_url":"https://api.github.com/repos/istio/istio/subscribers","subscription_url":"https://api.github.com/repos/istio/istio/subscription","commits_url":"https://api.github.com/repos/istio/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio/merges","archive_url":"https://api.github.com/repos/istio/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio/downloads","issues_url":"https://api.github.com/repos/istio/istio/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio/deployments","created_at":"2016-11-18T23:57:21Z","updated_at":"2018-07-20T18:24:32Z","pushed_at":"2018-07-20T19:09:48Z","git_url":"git://github.com/istio/istio.git","ssh_url":"git@github.com:istio/istio.git","clone_url":"https://github.com/istio/istio.git","svn_url":"https://github.com/istio/istio","homepage":"https://istio.io","size":41760,"stargazers_count":9441,"watchers_count":9441,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1349,"mirror_url":null,"archived":false,"open_issues_count":814,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1349,"open_issues":814,"watchers":9441,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/7265"},"html":{"href":"https://github.com/istio/istio/pull/7265"},"issue":{"href":"https://api.github.com/repos/istio/istio/issues/7265"},"comments":{"href":"https://api.github.com/repos/istio/istio/issues/7265/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/istio/pulls/7265/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/istio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/istio/pulls/7265/commits"},"statuses":{"href":"https://api.github.com/repos/istio/istio/statuses/1633b9e7f0195eef5bc85374f666e1f52ab87135"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mandarjog","id":800375,"node_id":"MDQ6VXNlcjgwMDM3NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/800375?v=4","gravatar_id":"","url":"https://api.github.com/users/mandarjog","html_url":"https://github.com/mandarjog","followers_url":"https://api.github.com/users/mandarjog/followers","following_url":"https://api.github.com/users/mandarjog/following{/other_user}","gists_url":"https://api.github.com/users/mandarjog/gists{/gist_id}","starred_url":"https://api.github.com/users/mandarjog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandarjog/subscriptions","organizations_url":"https://api.github.com/users/mandarjog/orgs","repos_url":"https://api.github.com/users/mandarjog/repos","events_url":"https://api.github.com/users/mandarjog/events{/privacy}","received_events_url":"https://api.github.com/users/mandarjog/received_events","type":"User","site_admin":false},"comments":9,"review_comments":4,"maintainer_can_modify":false,"commits":2,"additions":65,"deletions":12,"changed_files":3}}
{"actor":{"display_login":"mandarjog"}}