{"action":"created","issue":{"url":"https://api.github.com/repos/statsmodels/statsmodels/issues/3611","repository_url":"https://api.github.com/repos/statsmodels/statsmodels","labels_url":"https://api.github.com/repos/statsmodels/statsmodels/issues/3611/labels{/name}","comments_url":"https://api.github.com/repos/statsmodels/statsmodels/issues/3611/comments","events_url":"https://api.github.com/repos/statsmodels/statsmodels/issues/3611/events","html_url":"https://github.com/statsmodels/statsmodels/pull/3611","id":222027207,"number":3611,"title":"Re-enable LazyDicts in predict","user":{"login":"thequackdaddy","id":8186432,"avatar_url":"https://avatars2.githubusercontent.com/u/8186432?v=4","gravatar_id":"","url":"https://api.github.com/users/thequackdaddy","html_url":"https://github.com/thequackdaddy","followers_url":"https://api.github.com/users/thequackdaddy/followers","following_url":"https://api.github.com/users/thequackdaddy/following{/other_user}","gists_url":"https://api.github.com/users/thequackdaddy/gists{/gist_id}","starred_url":"https://api.github.com/users/thequackdaddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thequackdaddy/subscriptions","organizations_url":"https://api.github.com/users/thequackdaddy/orgs","repos_url":"https://api.github.com/users/thequackdaddy/repos","events_url":"https://api.github.com/users/thequackdaddy/events{/privacy}","received_events_url":"https://api.github.com/users/thequackdaddy/received_events","type":"User","site_admin":false},"labels":[{"id":142970,"url":"https://api.github.com/repos/statsmodels/statsmodels/labels/comp-base","name":"comp-base","color":"ededed","default":false},{"id":142961,"url":"https://api.github.com/repos/statsmodels/statsmodels/labels/type-enh","name":"type-enh","color":"99ffff","default":false},{"id":101509572,"url":"https://api.github.com/repos/statsmodels/statsmodels/labels/type-refactor","name":"type-refactor","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/statsmodels/statsmodels/milestones/10","html_url":"https://github.com/statsmodels/statsmodels/milestone/10","labels_url":"https://api.github.com/repos/statsmodels/statsmodels/milestones/10/labels","id":1362664,"number":10,"title":"0.9","description":"The milestone is currently for a rough roadmap","creator":{"login":"josef-pkt","id":440735,"avatar_url":"https://avatars1.githubusercontent.com/u/440735?v=4","gravatar_id":"","url":"https://api.github.com/users/josef-pkt","html_url":"https://github.com/josef-pkt","followers_url":"https://api.github.com/users/josef-pkt/followers","following_url":"https://api.github.com/users/josef-pkt/following{/other_user}","gists_url":"https://api.github.com/users/josef-pkt/gists{/gist_id}","starred_url":"https://api.github.com/users/josef-pkt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josef-pkt/subscriptions","organizations_url":"https://api.github.com/users/josef-pkt/orgs","repos_url":"https://api.github.com/users/josef-pkt/repos","events_url":"https://api.github.com/users/josef-pkt/events{/privacy}","received_events_url":"https://api.github.com/users/josef-pkt/received_events","type":"User","site_admin":false},"open_issues":92,"closed_issues":314,"state":"open","created_at":"2015-10-18T23:31:11Z","updated_at":"2018-04-19T02:12:56Z","due_on":null,"closed_at":null},"comments":17,"created_at":"2017-04-16T19:12:58Z","updated_at":"2018-04-19T03:30:52Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/statsmodels/statsmodels/pulls/3611","html_url":"https://github.com/statsmodels/statsmodels/pull/3611","diff_url":"https://github.com/statsmodels/statsmodels/pull/3611.diff","patch_url":"https://github.com/statsmodels/statsmodels/pull/3611.patch"},"body":"Hello,\r\n\r\nI wrote  a quick PR here to close #3609.\r\n\r\nI think this keeps all the current functionality, but allows `predict` to use the \"lazy\" dict concept \r\n\r\nHappy to hear comments. \r\n\r\nI've also removed a few lines from the `predict` method that, as far as I could tell, was unreachable. So that explains why the `warning` bit goes away. "},"comment":{"url":"https://api.github.com/repos/statsmodels/statsmodels/issues/comments/382599113","html_url":"https://github.com/statsmodels/statsmodels/pull/3611#issuecomment-382599113","issue_url":"https://api.github.com/repos/statsmodels/statsmodels/issues/3611","id":382599113,"user":{"login":"josef-pkt","id":440735,"avatar_url":"https://avatars1.githubusercontent.com/u/440735?v=4","gravatar_id":"","url":"https://api.github.com/users/josef-pkt","html_url":"https://github.com/josef-pkt","followers_url":"https://api.github.com/users/josef-pkt/followers","following_url":"https://api.github.com/users/josef-pkt/following{/other_user}","gists_url":"https://api.github.com/users/josef-pkt/gists{/gist_id}","starred_url":"https://api.github.com/users/josef-pkt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josef-pkt/subscriptions","organizations_url":"https://api.github.com/users/josef-pkt/orgs","repos_url":"https://api.github.com/users/josef-pkt/repos","events_url":"https://api.github.com/users/josef-pkt/events{/privacy}","received_events_url":"https://api.github.com/users/josef-pkt/received_events","type":"User","site_admin":false},"created_at":"2018-04-19T03:30:52Z","updated_at":"2018-04-19T03:30:52Z","author_association":"OWNER","body":"Something like this should be nicer, easier to understand and have the same result\r\norig_exog_len should be available independednt of whether there is and index or not\r\n\r\n```\r\n            if len(exog) < orig_exog_len:\r\n                # missing values, rows have been dropped\r\n                import warnings\r\n                if exog_index is None\r\n                   warnings.warn('observations with nan values have been dropped', ValueWarning)\r\n                else:\r\n                    exog = exog.reindex(exog_index)\r\n                    warnings.warn('nan values have been preserved and reindex',\r\n                                              ValueWarning)\r\n```\r\n\r\nI'm indifferent whether we also warn when we reindex"}}
{"actor":{"display_login":"josef-pkt"}}