{"action":"created","comment":{"url":"https://api.github.com/repos/enactjs/enact/pulls/comments/190118918","pull_request_review_id":122428443,"id":190118918,"diff_hunk":"@@ -9,11 +10,11 @@ import {withInfo} from '@storybook/addon-info';\n import {mergeComponentMetadata} from '../../src/utils/propTables';\n import nullify from '../../src/utils/nullify.js';\n \n-const Config = mergeComponentMetadata('Button', ButtonBase, Button);\n+const Config = mergeComponentMetadata('Button', ButtonBase, Button, UIButton, UIButtonBase);\n \n // Set up some defaults for info and knobs\n const prop = {\n-\tbackgroundOpacity: ['', 'translucent', 'lightTranslucent', 'transparent'],\n+\tbackgroundOpacity: ['opaque', 'translucent', 'lightTranslucent', 'transparent'],","path":"packages/sampler/stories/moonstone-stories/Button.js","position":16,"original_position":16,"commit_id":"753e9deadbe132ea1a96ebeee22bd4947fa56e56","original_commit_id":"753e9deadbe132ea1a96ebeee22bd4947fa56e56","user":{"login":"viodragon2","id":3284947,"avatar_url":"https://avatars0.githubusercontent.com/u/3284947?v=4","gravatar_id":"","url":"https://api.github.com/users/viodragon2","html_url":"https://github.com/viodragon2","followers_url":"https://api.github.com/users/viodragon2/followers","following_url":"https://api.github.com/users/viodragon2/following{/other_user}","gists_url":"https://api.github.com/users/viodragon2/gists{/gist_id}","starred_url":"https://api.github.com/users/viodragon2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viodragon2/subscriptions","organizations_url":"https://api.github.com/users/viodragon2/orgs","repos_url":"https://api.github.com/users/viodragon2/repos","events_url":"https://api.github.com/users/viodragon2/events{/privacy}","received_events_url":"https://api.github.com/users/viodragon2/received_events","type":"User","site_admin":false},"body":"Similar to the comment below, it seemed awkward to me when Button's `backgroundOpacity` has `@default 'opaque` in the documentation, but not set anything in the sampler. Plus, it is documented as one of the options but the user cannot select it in the sampler. I thought that was inconsistent. Thoughts?","created_at":"2018-05-23T04:19:13Z","updated_at":"2018-05-23T04:19:14Z","html_url":"https://github.com/enactjs/enact/pull/1672#discussion_r190118918","pull_request_url":"https://api.github.com/repos/enactjs/enact/pulls/1672","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/enactjs/enact/pulls/comments/190118918"},"html":{"href":"https://github.com/enactjs/enact/pull/1672#discussion_r190118918"},"pull_request":{"href":"https://api.github.com/repos/enactjs/enact/pulls/1672"}},"in_reply_to_id":190103580},"pull_request":{"url":"https://api.github.com/repos/enactjs/enact/pulls/1672","id":189833098,"html_url":"https://github.com/enactjs/enact/pull/1672","diff_url":"https://github.com/enactjs/enact/pull/1672.diff","patch_url":"https://github.com/enactjs/enact/pull/1672.patch","issue_url":"https://api.github.com/repos/enactjs/enact/issues/1672","number":1672,"state":"open","locked":false,"title":"ENYO-5153: Fix Button's sampler to toggle minWidth correctly","user":{"login":"viodragon2","id":3284947,"avatar_url":"https://avatars0.githubusercontent.com/u/3284947?v=4","gravatar_id":"","url":"https://api.github.com/users/viodragon2","html_url":"https://github.com/viodragon2","followers_url":"https://api.github.com/users/viodragon2/followers","following_url":"https://api.github.com/users/viodragon2/following{/other_user}","gists_url":"https://api.github.com/users/viodragon2/gists{/gist_id}","starred_url":"https://api.github.com/users/viodragon2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viodragon2/subscriptions","organizations_url":"https://api.github.com/users/viodragon2/orgs","repos_url":"https://api.github.com/users/viodragon2/repos","events_url":"https://api.github.com/users/viodragon2/events{/privacy}","received_events_url":"https://api.github.com/users/viodragon2/received_events","type":"User","site_admin":false},"body":"### Issue Resolved / Feature Added\r\n[//]: # (Describe the issue resolved or feature added by this pull request)\r\n`minWidth` prop's default value is set to `true`, and by `nullifying` the boolean value, it will always set to `true` even if the knob is set to `false`. Fixed by removing `nullifying` in the select knob.\r\n\r\n### Additional Considerations\r\n[//]: # (How should the change be tested?)\r\n[//]: # (Are there any outstanding questions?)\r\n[//]: # (Were any side-effects caused by the change?)\r\n- Button's props weren't being properly merged in the info section and made an update to it. It seems like other components that uses `ui` as a base component show similar pattern and we need to update them all.\r\n- Any props that were added by HOCs (e.g. `casing` prop from `i18n/Uppercase`) will not be fetched and need to be set with constants. Should we declare those `propTypes` in the base component or is there a way to fetch them and feed it to `propTables` in the story?\r\n\r\nEnact-DCO-1.0-Signed-off-by: Stephen Choi <stephen.choi@lge.com>\r\n","created_at":"2018-05-23T01:21:56Z","updated_at":"2018-05-23T04:19:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ac20ca100016874ae80eeba86bba5603c00c1f7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/enactjs/enact/pulls/1672/commits","review_comments_url":"https://api.github.com/repos/enactjs/enact/pulls/1672/comments","review_comment_url":"https://api.github.com/repos/enactjs/enact/pulls/comments{/number}","comments_url":"https://api.github.com/repos/enactjs/enact/issues/1672/comments","statuses_url":"https://api.github.com/repos/enactjs/enact/statuses/753e9deadbe132ea1a96ebeee22bd4947fa56e56","head":{"label":"enactjs:feature/ENYO-5153-stephen","ref":"feature/ENYO-5153-stephen","sha":"753e9deadbe132ea1a96ebeee22bd4947fa56e56","user":{"login":"enactjs","id":22086053,"avatar_url":"https://avatars2.githubusercontent.com/u/22086053?v=4","gravatar_id":"","url":"https://api.github.com/users/enactjs","html_url":"https://github.com/enactjs","followers_url":"https://api.github.com/users/enactjs/followers","following_url":"https://api.github.com/users/enactjs/following{/other_user}","gists_url":"https://api.github.com/users/enactjs/gists{/gist_id}","starred_url":"https://api.github.com/users/enactjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enactjs/subscriptions","organizations_url":"https://api.github.com/users/enactjs/orgs","repos_url":"https://api.github.com/users/enactjs/repos","events_url":"https://api.github.com/users/enactjs/events{/privacy}","received_events_url":"https://api.github.com/users/enactjs/received_events","type":"Organization","site_admin":false},"repo":{"id":67653065,"name":"enact","full_name":"enactjs/enact","owner":{"login":"enactjs","id":22086053,"avatar_url":"https://avatars2.githubusercontent.com/u/22086053?v=4","gravatar_id":"","url":"https://api.github.com/users/enactjs","html_url":"https://github.com/enactjs","followers_url":"https://api.github.com/users/enactjs/followers","following_url":"https://api.github.com/users/enactjs/following{/other_user}","gists_url":"https://api.github.com/users/enactjs/gists{/gist_id}","starred_url":"https://api.github.com/users/enactjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enactjs/subscriptions","organizations_url":"https://api.github.com/users/enactjs/orgs","repos_url":"https://api.github.com/users/enactjs/repos","events_url":"https://api.github.com/users/enactjs/events{/privacy}","received_events_url":"https://api.github.com/users/enactjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enactjs/enact","description":"An app development framework built atop React that’s easy to use, performant and customizable.","fork":false,"url":"https://api.github.com/repos/enactjs/enact","forks_url":"https://api.github.com/repos/enactjs/enact/forks","keys_url":"https://api.github.com/repos/enactjs/enact/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enactjs/enact/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enactjs/enact/teams","hooks_url":"https://api.github.com/repos/enactjs/enact/hooks","issue_events_url":"https://api.github.com/repos/enactjs/enact/issues/events{/number}","events_url":"https://api.github.com/repos/enactjs/enact/events","assignees_url":"https://api.github.com/repos/enactjs/enact/assignees{/user}","branches_url":"https://api.github.com/repos/enactjs/enact/branches{/branch}","tags_url":"https://api.github.com/repos/enactjs/enact/tags","blobs_url":"https://api.github.com/repos/enactjs/enact/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enactjs/enact/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enactjs/enact/git/refs{/sha}","trees_url":"https://api.github.com/repos/enactjs/enact/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enactjs/enact/statuses/{sha}","languages_url":"https://api.github.com/repos/enactjs/enact/languages","stargazers_url":"https://api.github.com/repos/enactjs/enact/stargazers","contributors_url":"https://api.github.com/repos/enactjs/enact/contributors","subscribers_url":"https://api.github.com/repos/enactjs/enact/subscribers","subscription_url":"https://api.github.com/repos/enactjs/enact/subscription","commits_url":"https://api.github.com/repos/enactjs/enact/commits{/sha}","git_commits_url":"https://api.github.com/repos/enactjs/enact/git/commits{/sha}","comments_url":"https://api.github.com/repos/enactjs/enact/comments{/number}","issue_comment_url":"https://api.github.com/repos/enactjs/enact/issues/comments{/number}","contents_url":"https://api.github.com/repos/enactjs/enact/contents/{+path}","compare_url":"https://api.github.com/repos/enactjs/enact/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enactjs/enact/merges","archive_url":"https://api.github.com/repos/enactjs/enact/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enactjs/enact/downloads","issues_url":"https://api.github.com/repos/enactjs/enact/issues{/number}","pulls_url":"https://api.github.com/repos/enactjs/enact/pulls{/number}","milestones_url":"https://api.github.com/repos/enactjs/enact/milestones{/number}","notifications_url":"https://api.github.com/repos/enactjs/enact/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enactjs/enact/labels{/name}","releases_url":"https://api.github.com/repos/enactjs/enact/releases{/id}","deployments_url":"https://api.github.com/repos/enactjs/enact/deployments","created_at":"2016-09-08T00:14:51Z","updated_at":"2018-05-17T05:52:54Z","pushed_at":"2018-05-23T01:41:09Z","git_url":"git://github.com/enactjs/enact.git","ssh_url":"git@github.com:enactjs/enact.git","clone_url":"https://github.com/enactjs/enact.git","svn_url":"https://github.com/enactjs/enact","homepage":"http://enactjs.com","size":14871,"stargazers_count":62,"watchers_count":62,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":62,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":3,"open_issues":62,"watchers":62,"default_branch":"master"}},"base":{"label":"enactjs:develop","ref":"develop","sha":"0a92e008b4161bc506bd29bfdb4d960ef4f57b27","user":{"login":"enactjs","id":22086053,"avatar_url":"https://avatars2.githubusercontent.com/u/22086053?v=4","gravatar_id":"","url":"https://api.github.com/users/enactjs","html_url":"https://github.com/enactjs","followers_url":"https://api.github.com/users/enactjs/followers","following_url":"https://api.github.com/users/enactjs/following{/other_user}","gists_url":"https://api.github.com/users/enactjs/gists{/gist_id}","starred_url":"https://api.github.com/users/enactjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enactjs/subscriptions","organizations_url":"https://api.github.com/users/enactjs/orgs","repos_url":"https://api.github.com/users/enactjs/repos","events_url":"https://api.github.com/users/enactjs/events{/privacy}","received_events_url":"https://api.github.com/users/enactjs/received_events","type":"Organization","site_admin":false},"repo":{"id":67653065,"name":"enact","full_name":"enactjs/enact","owner":{"login":"enactjs","id":22086053,"avatar_url":"https://avatars2.githubusercontent.com/u/22086053?v=4","gravatar_id":"","url":"https://api.github.com/users/enactjs","html_url":"https://github.com/enactjs","followers_url":"https://api.github.com/users/enactjs/followers","following_url":"https://api.github.com/users/enactjs/following{/other_user}","gists_url":"https://api.github.com/users/enactjs/gists{/gist_id}","starred_url":"https://api.github.com/users/enactjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enactjs/subscriptions","organizations_url":"https://api.github.com/users/enactjs/orgs","repos_url":"https://api.github.com/users/enactjs/repos","events_url":"https://api.github.com/users/enactjs/events{/privacy}","received_events_url":"https://api.github.com/users/enactjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enactjs/enact","description":"An app development framework built atop React that’s easy to use, performant and customizable.","fork":false,"url":"https://api.github.com/repos/enactjs/enact","forks_url":"https://api.github.com/repos/enactjs/enact/forks","keys_url":"https://api.github.com/repos/enactjs/enact/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enactjs/enact/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enactjs/enact/teams","hooks_url":"https://api.github.com/repos/enactjs/enact/hooks","issue_events_url":"https://api.github.com/repos/enactjs/enact/issues/events{/number}","events_url":"https://api.github.com/repos/enactjs/enact/events","assignees_url":"https://api.github.com/repos/enactjs/enact/assignees{/user}","branches_url":"https://api.github.com/repos/enactjs/enact/branches{/branch}","tags_url":"https://api.github.com/repos/enactjs/enact/tags","blobs_url":"https://api.github.com/repos/enactjs/enact/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enactjs/enact/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enactjs/enact/git/refs{/sha}","trees_url":"https://api.github.com/repos/enactjs/enact/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enactjs/enact/statuses/{sha}","languages_url":"https://api.github.com/repos/enactjs/enact/languages","stargazers_url":"https://api.github.com/repos/enactjs/enact/stargazers","contributors_url":"https://api.github.com/repos/enactjs/enact/contributors","subscribers_url":"https://api.github.com/repos/enactjs/enact/subscribers","subscription_url":"https://api.github.com/repos/enactjs/enact/subscription","commits_url":"https://api.github.com/repos/enactjs/enact/commits{/sha}","git_commits_url":"https://api.github.com/repos/enactjs/enact/git/commits{/sha}","comments_url":"https://api.github.com/repos/enactjs/enact/comments{/number}","issue_comment_url":"https://api.github.com/repos/enactjs/enact/issues/comments{/number}","contents_url":"https://api.github.com/repos/enactjs/enact/contents/{+path}","compare_url":"https://api.github.com/repos/enactjs/enact/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enactjs/enact/merges","archive_url":"https://api.github.com/repos/enactjs/enact/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enactjs/enact/downloads","issues_url":"https://api.github.com/repos/enactjs/enact/issues{/number}","pulls_url":"https://api.github.com/repos/enactjs/enact/pulls{/number}","milestones_url":"https://api.github.com/repos/enactjs/enact/milestones{/number}","notifications_url":"https://api.github.com/repos/enactjs/enact/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enactjs/enact/labels{/name}","releases_url":"https://api.github.com/repos/enactjs/enact/releases{/id}","deployments_url":"https://api.github.com/repos/enactjs/enact/deployments","created_at":"2016-09-08T00:14:51Z","updated_at":"2018-05-17T05:52:54Z","pushed_at":"2018-05-23T01:41:09Z","git_url":"git://github.com/enactjs/enact.git","ssh_url":"git@github.com:enactjs/enact.git","clone_url":"https://github.com/enactjs/enact.git","svn_url":"https://github.com/enactjs/enact","homepage":"http://enactjs.com","size":14871,"stargazers_count":62,"watchers_count":62,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":62,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":3,"open_issues":62,"watchers":62,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/enactjs/enact/pulls/1672"},"html":{"href":"https://github.com/enactjs/enact/pull/1672"},"issue":{"href":"https://api.github.com/repos/enactjs/enact/issues/1672"},"comments":{"href":"https://api.github.com/repos/enactjs/enact/issues/1672/comments"},"review_comments":{"href":"https://api.github.com/repos/enactjs/enact/pulls/1672/comments"},"review_comment":{"href":"https://api.github.com/repos/enactjs/enact/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/enactjs/enact/pulls/1672/commits"},"statuses":{"href":"https://api.github.com/repos/enactjs/enact/statuses/753e9deadbe132ea1a96ebeee22bd4947fa56e56"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"viodragon2"}}