{"action":"created","issue":{"url":"https://api.github.com/repos/expo/expo/issues/735","repository_url":"https://api.github.com/repos/expo/expo","labels_url":"https://api.github.com/repos/expo/expo/issues/735/labels{/name}","comments_url":"https://api.github.com/repos/expo/expo/issues/735/comments","events_url":"https://api.github.com/repos/expo/expo/issues/735/events","html_url":"https://github.com/expo/expo/issues/735","id":263279066,"number":735,"title":"Camera.recordAsync quality - iOS","user":{"login":"MylesCaley","id":5648220,"avatar_url":"https://avatars1.githubusercontent.com/u/5648220?v=4","gravatar_id":"","url":"https://api.github.com/users/MylesCaley","html_url":"https://github.com/MylesCaley","followers_url":"https://api.github.com/users/MylesCaley/followers","following_url":"https://api.github.com/users/MylesCaley/following{/other_user}","gists_url":"https://api.github.com/users/MylesCaley/gists{/gist_id}","starred_url":"https://api.github.com/users/MylesCaley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MylesCaley/subscriptions","organizations_url":"https://api.github.com/users/MylesCaley/orgs","repos_url":"https://api.github.com/users/MylesCaley/repos","events_url":"https://api.github.com/users/MylesCaley/events{/privacy}","received_events_url":"https://api.github.com/users/MylesCaley/received_events","type":"User","site_admin":false},"labels":[{"id":598255371,"url":"https://api.github.com/repos/expo/expo/labels/project:%20sdk","name":"project: sdk","color":"d4c5f9","default":false}],"state":"closed","locked":false,"assignee":{"login":"aalices","id":8770183,"avatar_url":"https://avatars3.githubusercontent.com/u/8770183?v=4","gravatar_id":"","url":"https://api.github.com/users/aalices","html_url":"https://github.com/aalices","followers_url":"https://api.github.com/users/aalices/followers","following_url":"https://api.github.com/users/aalices/following{/other_user}","gists_url":"https://api.github.com/users/aalices/gists{/gist_id}","starred_url":"https://api.github.com/users/aalices/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aalices/subscriptions","organizations_url":"https://api.github.com/users/aalices/orgs","repos_url":"https://api.github.com/users/aalices/repos","events_url":"https://api.github.com/users/aalices/events{/privacy}","received_events_url":"https://api.github.com/users/aalices/received_events","type":"User","site_admin":false},"assignees":[{"login":"aalices","id":8770183,"avatar_url":"https://avatars3.githubusercontent.com/u/8770183?v=4","gravatar_id":"","url":"https://api.github.com/users/aalices","html_url":"https://github.com/aalices","followers_url":"https://api.github.com/users/aalices/followers","following_url":"https://api.github.com/users/aalices/following{/other_user}","gists_url":"https://api.github.com/users/aalices/gists{/gist_id}","starred_url":"https://api.github.com/users/aalices/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aalices/subscriptions","organizations_url":"https://api.github.com/users/aalices/orgs","repos_url":"https://api.github.com/users/aalices/repos","events_url":"https://api.github.com/users/aalices/events{/privacy}","received_events_url":"https://api.github.com/users/aalices/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/expo/expo/milestones/6","html_url":"https://github.com/expo/expo/milestone/6","labels_url":"https://api.github.com/repos/expo/expo/milestones/6/labels","id":2801214,"number":6,"title":"M11 (SDK 22)","description":"","creator":{"login":"terribleben","id":1316332,"avatar_url":"https://avatars3.githubusercontent.com/u/1316332?v=4","gravatar_id":"","url":"https://api.github.com/users/terribleben","html_url":"https://github.com/terribleben","followers_url":"https://api.github.com/users/terribleben/followers","following_url":"https://api.github.com/users/terribleben/following{/other_user}","gists_url":"https://api.github.com/users/terribleben/gists{/gist_id}","starred_url":"https://api.github.com/users/terribleben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terribleben/subscriptions","organizations_url":"https://api.github.com/users/terribleben/orgs","repos_url":"https://api.github.com/users/terribleben/repos","events_url":"https://api.github.com/users/terribleben/events{/privacy}","received_events_url":"https://api.github.com/users/terribleben/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":5,"state":"closed","created_at":"2017-09-28T19:22:26Z","updated_at":"2017-10-19T23:16:55Z","due_on":"2017-10-13T07:00:00Z","closed_at":"2017-10-19T23:16:55Z"},"comments":6,"created_at":"2017-10-05T21:56:41Z","updated_at":"2018-05-30T07:52:10Z","closed_at":"2017-10-10T17:31:57Z","author_association":"NONE","body":"Ironically, the quality property is also not working on `recordAsync()` for iOS. Thanks for getting the fix in on `takePictureAsync()` btw.\r\n\r\nI believe the issue is the following when using `Camera.Constants.VideoQuality['4:3']` for example, it hits objc land, `EXCameraManager.m`... \r\n\r\n`if (options[@\"quality\"]) {\r\n      [self updateSessionPreset:[[self class] captureSessionPresetForVideoResolution:(EXCameraVideoResolution)options[@\"quality\"]]];\r\n    }`\r\n\r\nIn this case `options[@\"quality\"]`, which I believe is an NSNumber, can't be cast to `EXCameraVideoResolution`. It will return some arbitrary invalid value and `captureSessionPresetForVideoResolution` will always return the default of `AVCaptureSessionPresetHigh`\r\n\r\nSome quick tests locally and a simple integerValue conversion and all seems happy.\r\n\r\n`[self updateSessionPreset:[[self class] captureSessionPresetForVideoResolution:(EXCameraVideoResolution)[options[@\"quality\"] integerValue]]];`\r\n\r\nWe are real close to shipping our first Expo app, which is a rewrite of a swift app. Is it possible for you all to do an incremental update on the SDKv21? (we are not ejected). Or will need to wait for SDKv22 ? We have no ability to workaround that I could come up with. \r\n\r\nThanks."},"comment":{"url":"https://api.github.com/repos/expo/expo/issues/comments/393065144","html_url":"https://github.com/expo/expo/issues/735#issuecomment-393065144","issue_url":"https://api.github.com/repos/expo/expo/issues/735","id":393065144,"user":{"login":"aalices","id":8770183,"avatar_url":"https://avatars3.githubusercontent.com/u/8770183?v=4","gravatar_id":"","url":"https://api.github.com/users/aalices","html_url":"https://github.com/aalices","followers_url":"https://api.github.com/users/aalices/followers","following_url":"https://api.github.com/users/aalices/following{/other_user}","gists_url":"https://api.github.com/users/aalices/gists{/gist_id}","starred_url":"https://api.github.com/users/aalices/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aalices/subscriptions","organizations_url":"https://api.github.com/users/aalices/orgs","repos_url":"https://api.github.com/users/aalices/repos","events_url":"https://api.github.com/users/aalices/events{/privacy}","received_events_url":"https://api.github.com/users/aalices/received_events","type":"User","site_admin":false},"created_at":"2018-05-30T07:52:10Z","updated_at":"2018-05-30T07:52:10Z","author_association":"MEMBER","body":"@harrymelka you cannot use numbers for setting video quality. I think the size is just okay. I recorded a 720p video using the built-in Camera app and a ~4sec video is 4,4MB. I also used iPhone 8."}}
{"actor":{"display_login":"aalices"}}