{"action":"created","comment":{"url":"https://api.github.com/repos/astropy/specutils/pulls/comments/231213720","pull_request_review_id":172133821,"id":231213720,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTIxMzcyMA==","diff_hunk":"@@ -34,6 +34,16 @@ def decorator(func):\n \n         logging.debug(\"Successfully loaded reader \\\"{}\\\".\".format(label))\n \n+        # Automatically register a SpectrumList reader for any data_loader that\n+        # reads Spectrum1D objects. TODO: it's possible that this\n+        # functionality should be opt-in rather than automatic.\n+        if dtype == Spectrum1D:","path":"specutils/io/registers.py","position":16,"original_position":16,"commit_id":"9f20f85964b37115e7a12e5998ec645fde4d6499","original_commit_id":"9f20f85964b37115e7a12e5998ec645fde4d6499","user":{"login":"nmearl","id":4141126,"node_id":"MDQ6VXNlcjQxNDExMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/4141126?v=4","gravatar_id":"","url":"https://api.github.com/users/nmearl","html_url":"https://github.com/nmearl","followers_url":"https://api.github.com/users/nmearl/followers","following_url":"https://api.github.com/users/nmearl/following{/other_user}","gists_url":"https://api.github.com/users/nmearl/gists{/gist_id}","starred_url":"https://api.github.com/users/nmearl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmearl/subscriptions","organizations_url":"https://api.github.com/users/nmearl/orgs","repos_url":"https://api.github.com/users/nmearl/repos","events_url":"https://api.github.com/users/nmearl/events{/privacy}","received_events_url":"https://api.github.com/users/nmearl/received_events","type":"User","site_admin":false},"body":"This should probably be an `isinstance` call, not a value equivalency check.","created_at":"2018-11-06T17:16:02Z","updated_at":"2018-11-06T17:17:03Z","html_url":"https://github.com/astropy/specutils/pull/381#discussion_r231213720","pull_request_url":"https://api.github.com/repos/astropy/specutils/pulls/381","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/astropy/specutils/pulls/comments/231213720"},"html":{"href":"https://github.com/astropy/specutils/pull/381#discussion_r231213720"},"pull_request":{"href":"https://api.github.com/repos/astropy/specutils/pulls/381"}}},"pull_request":{"url":"https://api.github.com/repos/astropy/specutils/pulls/381","id":228028219,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MDI4MjE5","html_url":"https://github.com/astropy/specutils/pull/381","diff_url":"https://github.com/astropy/specutils/pull/381.diff","patch_url":"https://github.com/astropy/specutils/pull/381.patch","issue_url":"https://api.github.com/repos/astropy/specutils/issues/381","number":381,"state":"open","locked":false,"title":"Add data loader for JWST spectra","user":{"login":"drdavella","id":2458487,"node_id":"MDQ6VXNlcjI0NTg0ODc=","avatar_url":"https://avatars0.githubusercontent.com/u/2458487?v=4","gravatar_id":"","url":"https://api.github.com/users/drdavella","html_url":"https://github.com/drdavella","followers_url":"https://api.github.com/users/drdavella/followers","following_url":"https://api.github.com/users/drdavella/following{/other_user}","gists_url":"https://api.github.com/users/drdavella/gists{/gist_id}","starred_url":"https://api.github.com/users/drdavella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drdavella/subscriptions","organizations_url":"https://api.github.com/users/drdavella/orgs","repos_url":"https://api.github.com/users/drdavella/repos","events_url":"https://api.github.com/users/drdavella/events{/privacy}","received_events_url":"https://api.github.com/users/drdavella/received_events","type":"User","site_admin":false},"body":"This PR adds a new loader for JWST spectral data products.\r\n\r\nIt also adds a new lightweight container class called `SpectrumList`.\r\n\r\nThe essential problem is this: we need the JWST data loader to be able to return multiple spectra since any given JWST data product will contain an arbitrary number of spectra.\r\n\r\nHowever, `SpectrumCollection` is not sufficient since it expects all spectra to have axes of the same length. This is not true for JWST data products since different slits may have slightly different dispersions.\r\n\r\nI don't think that `SpectrumList` needs to be any more than a dumb container for `Spectrum1D` objects. It also plugs in to Astropy's IO machinery, which makes using the loader even more convenient.","created_at":"2018-11-02T18:49:36Z","updated_at":"2018-11-06T17:17:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"00b21a60941bea46be67265c76a9fb550aa2befe","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/astropy/specutils/pulls/381/commits","review_comments_url":"https://api.github.com/repos/astropy/specutils/pulls/381/comments","review_comment_url":"https://api.github.com/repos/astropy/specutils/pulls/comments{/number}","comments_url":"https://api.github.com/repos/astropy/specutils/issues/381/comments","statuses_url":"https://api.github.com/repos/astropy/specutils/statuses/9f20f85964b37115e7a12e5998ec645fde4d6499","head":{"label":"drdavella:jwst-data-loader","ref":"jwst-data-loader","sha":"9f20f85964b37115e7a12e5998ec645fde4d6499","user":{"login":"drdavella","id":2458487,"node_id":"MDQ6VXNlcjI0NTg0ODc=","avatar_url":"https://avatars0.githubusercontent.com/u/2458487?v=4","gravatar_id":"","url":"https://api.github.com/users/drdavella","html_url":"https://github.com/drdavella","followers_url":"https://api.github.com/users/drdavella/followers","following_url":"https://api.github.com/users/drdavella/following{/other_user}","gists_url":"https://api.github.com/users/drdavella/gists{/gist_id}","starred_url":"https://api.github.com/users/drdavella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drdavella/subscriptions","organizations_url":"https://api.github.com/users/drdavella/orgs","repos_url":"https://api.github.com/users/drdavella/repos","events_url":"https://api.github.com/users/drdavella/events{/privacy}","received_events_url":"https://api.github.com/users/drdavella/received_events","type":"User","site_admin":false},"repo":{"id":145158818,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUxNTg4MTg=","name":"specutils","full_name":"drdavella/specutils","private":false,"owner":{"login":"drdavella","id":2458487,"node_id":"MDQ6VXNlcjI0NTg0ODc=","avatar_url":"https://avatars0.githubusercontent.com/u/2458487?v=4","gravatar_id":"","url":"https://api.github.com/users/drdavella","html_url":"https://github.com/drdavella","followers_url":"https://api.github.com/users/drdavella/followers","following_url":"https://api.github.com/users/drdavella/following{/other_user}","gists_url":"https://api.github.com/users/drdavella/gists{/gist_id}","starred_url":"https://api.github.com/users/drdavella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drdavella/subscriptions","organizations_url":"https://api.github.com/users/drdavella/orgs","repos_url":"https://api.github.com/users/drdavella/repos","events_url":"https://api.github.com/users/drdavella/events{/privacy}","received_events_url":"https://api.github.com/users/drdavella/received_events","type":"User","site_admin":false},"html_url":"https://github.com/drdavella/specutils","description":"Affiliated package for 1D spectral operations. Maintainers: @nmearl @crawfordsm @keflavich @eteq","fork":true,"url":"https://api.github.com/repos/drdavella/specutils","forks_url":"https://api.github.com/repos/drdavella/specutils/forks","keys_url":"https://api.github.com/repos/drdavella/specutils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drdavella/specutils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drdavella/specutils/teams","hooks_url":"https://api.github.com/repos/drdavella/specutils/hooks","issue_events_url":"https://api.github.com/repos/drdavella/specutils/issues/events{/number}","events_url":"https://api.github.com/repos/drdavella/specutils/events","assignees_url":"https://api.github.com/repos/drdavella/specutils/assignees{/user}","branches_url":"https://api.github.com/repos/drdavella/specutils/branches{/branch}","tags_url":"https://api.github.com/repos/drdavella/specutils/tags","blobs_url":"https://api.github.com/repos/drdavella/specutils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drdavella/specutils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drdavella/specutils/git/refs{/sha}","trees_url":"https://api.github.com/repos/drdavella/specutils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drdavella/specutils/statuses/{sha}","languages_url":"https://api.github.com/repos/drdavella/specutils/languages","stargazers_url":"https://api.github.com/repos/drdavella/specutils/stargazers","contributors_url":"https://api.github.com/repos/drdavella/specutils/contributors","subscribers_url":"https://api.github.com/repos/drdavella/specutils/subscribers","subscription_url":"https://api.github.com/repos/drdavella/specutils/subscription","commits_url":"https://api.github.com/repos/drdavella/specutils/commits{/sha}","git_commits_url":"https://api.github.com/repos/drdavella/specutils/git/commits{/sha}","comments_url":"https://api.github.com/repos/drdavella/specutils/comments{/number}","issue_comment_url":"https://api.github.com/repos/drdavella/specutils/issues/comments{/number}","contents_url":"https://api.github.com/repos/drdavella/specutils/contents/{+path}","compare_url":"https://api.github.com/repos/drdavella/specutils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drdavella/specutils/merges","archive_url":"https://api.github.com/repos/drdavella/specutils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drdavella/specutils/downloads","issues_url":"https://api.github.com/repos/drdavella/specutils/issues{/number}","pulls_url":"https://api.github.com/repos/drdavella/specutils/pulls{/number}","milestones_url":"https://api.github.com/repos/drdavella/specutils/milestones{/number}","notifications_url":"https://api.github.com/repos/drdavella/specutils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drdavella/specutils/labels{/name}","releases_url":"https://api.github.com/repos/drdavella/specutils/releases{/id}","deployments_url":"https://api.github.com/repos/drdavella/specutils/deployments","created_at":"2018-08-17T19:27:20Z","updated_at":"2018-08-17T19:27:22Z","pushed_at":"2018-11-06T15:18:11Z","git_url":"git://github.com/drdavella/specutils.git","ssh_url":"git@github.com:drdavella/specutils.git","clone_url":"https://github.com/drdavella/specutils.git","svn_url":"https://github.com/drdavella/specutils","homepage":"http://specutils.readthedocs.io/en/latest/","size":6653,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"astropy:master","ref":"master","sha":"0fbcb211d1ddbcb774f6cd7ba9ef931df73b593a","user":{"login":"astropy","id":847984,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0Nzk4NA==","avatar_url":"https://avatars0.githubusercontent.com/u/847984?v=4","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"repo":{"id":2577269,"node_id":"MDEwOlJlcG9zaXRvcnkyNTc3MjY5","name":"specutils","full_name":"astropy/specutils","private":false,"owner":{"login":"astropy","id":847984,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0Nzk4NA==","avatar_url":"https://avatars0.githubusercontent.com/u/847984?v=4","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/astropy/specutils","description":"An Astropy coordinated package for astronomical spectroscopy.  Maintainers: @nmearl @crawfordsm @keflavich @eteq","fork":false,"url":"https://api.github.com/repos/astropy/specutils","forks_url":"https://api.github.com/repos/astropy/specutils/forks","keys_url":"https://api.github.com/repos/astropy/specutils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astropy/specutils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astropy/specutils/teams","hooks_url":"https://api.github.com/repos/astropy/specutils/hooks","issue_events_url":"https://api.github.com/repos/astropy/specutils/issues/events{/number}","events_url":"https://api.github.com/repos/astropy/specutils/events","assignees_url":"https://api.github.com/repos/astropy/specutils/assignees{/user}","branches_url":"https://api.github.com/repos/astropy/specutils/branches{/branch}","tags_url":"https://api.github.com/repos/astropy/specutils/tags","blobs_url":"https://api.github.com/repos/astropy/specutils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astropy/specutils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astropy/specutils/git/refs{/sha}","trees_url":"https://api.github.com/repos/astropy/specutils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astropy/specutils/statuses/{sha}","languages_url":"https://api.github.com/repos/astropy/specutils/languages","stargazers_url":"https://api.github.com/repos/astropy/specutils/stargazers","contributors_url":"https://api.github.com/repos/astropy/specutils/contributors","subscribers_url":"https://api.github.com/repos/astropy/specutils/subscribers","subscription_url":"https://api.github.com/repos/astropy/specutils/subscription","commits_url":"https://api.github.com/repos/astropy/specutils/commits{/sha}","git_commits_url":"https://api.github.com/repos/astropy/specutils/git/commits{/sha}","comments_url":"https://api.github.com/repos/astropy/specutils/comments{/number}","issue_comment_url":"https://api.github.com/repos/astropy/specutils/issues/comments{/number}","contents_url":"https://api.github.com/repos/astropy/specutils/contents/{+path}","compare_url":"https://api.github.com/repos/astropy/specutils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astropy/specutils/merges","archive_url":"https://api.github.com/repos/astropy/specutils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astropy/specutils/downloads","issues_url":"https://api.github.com/repos/astropy/specutils/issues{/number}","pulls_url":"https://api.github.com/repos/astropy/specutils/pulls{/number}","milestones_url":"https://api.github.com/repos/astropy/specutils/milestones{/number}","notifications_url":"https://api.github.com/repos/astropy/specutils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astropy/specutils/labels{/name}","releases_url":"https://api.github.com/repos/astropy/specutils/releases{/id}","deployments_url":"https://api.github.com/repos/astropy/specutils/deployments","created_at":"2011-10-14T16:11:38Z","updated_at":"2018-11-06T15:22:21Z","pushed_at":"2018-11-06T16:06:52Z","git_url":"git://github.com/astropy/specutils.git","ssh_url":"git@github.com:astropy/specutils.git","clone_url":"https://github.com/astropy/specutils.git","svn_url":"https://github.com/astropy/specutils","homepage":"http://specutils.readthedocs.io/en/latest/","size":8993,"stargazers_count":58,"watchers_count":58,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":66,"mirror_url":null,"archived":false,"open_issues_count":92,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":66,"open_issues":92,"watchers":58,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/astropy/specutils/pulls/381"},"html":{"href":"https://github.com/astropy/specutils/pull/381"},"issue":{"href":"https://api.github.com/repos/astropy/specutils/issues/381"},"comments":{"href":"https://api.github.com/repos/astropy/specutils/issues/381/comments"},"review_comments":{"href":"https://api.github.com/repos/astropy/specutils/pulls/381/comments"},"review_comment":{"href":"https://api.github.com/repos/astropy/specutils/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/astropy/specutils/pulls/381/commits"},"statuses":{"href":"https://api.github.com/repos/astropy/specutils/statuses/9f20f85964b37115e7a12e5998ec645fde4d6499"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nmearl"}}