{"action":"created","comment":{"url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments/186077793","pull_request_review_id":117598887,"id":186077793,"diff_hunk":"@@ -0,0 +1,17 @@\n+/* SPDX-License-Identifier: BSD-2-Clause */","path":"core/lib/libmbedtls/include/mbedtls.h","position":1,"original_position":1,"commit_id":"25dd80805cf09890fcc31363e3b7275e6b53078d","original_commit_id":"bd16957c8d78c8a3b65c999a7cafaedaaf756aea","user":{"login":"jenswi-linaro","id":6150306,"avatar_url":"https://avatars0.githubusercontent.com/u/6150306?v=4","gravatar_id":"","url":"https://api.github.com/users/jenswi-linaro","html_url":"https://github.com/jenswi-linaro","followers_url":"https://api.github.com/users/jenswi-linaro/followers","following_url":"https://api.github.com/users/jenswi-linaro/following{/other_user}","gists_url":"https://api.github.com/users/jenswi-linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/jenswi-linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenswi-linaro/subscriptions","organizations_url":"https://api.github.com/users/jenswi-linaro/orgs","repos_url":"https://api.github.com/users/jenswi-linaro/repos","events_url":"https://api.github.com/users/jenswi-linaro/events{/privacy}","received_events_url":"https://api.github.com/users/jenswi-linaro/received_events","type":"User","site_admin":false},"body":"It seems the sole purpose of this file is to be included by `tee_lmd_provider.c` later in this PR.\r\nAny particular reason for that instead of just including the files needed from `tee_lmd_provider.c`?","created_at":"2018-05-04T13:14:30Z","updated_at":"2018-05-04T13:26:24Z","html_url":"https://github.com/OP-TEE/optee_os/pull/1885#discussion_r186077793","pull_request_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/1885","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments/186077793"},"html":{"href":"https://github.com/OP-TEE/optee_os/pull/1885#discussion_r186077793"},"pull_request":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/1885"}}},"pull_request":{"url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/1885","id":146929745,"html_url":"https://github.com/OP-TEE/optee_os/pull/1885","diff_url":"https://github.com/OP-TEE/optee_os/pull/1885.diff","patch_url":"https://github.com/OP-TEE/optee_os/pull/1885.patch","issue_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/1885","number":1885,"state":"open","locked":false,"title":"[RFC] Support mbedTLS crypto library","user":{"login":"edison-ai","id":27393575,"avatar_url":"https://avatars0.githubusercontent.com/u/27393575?v=4","gravatar_id":"","url":"https://api.github.com/users/edison-ai","html_url":"https://github.com/edison-ai","followers_url":"https://api.github.com/users/edison-ai/followers","following_url":"https://api.github.com/users/edison-ai/following{/other_user}","gists_url":"https://api.github.com/users/edison-ai/gists{/gist_id}","starred_url":"https://api.github.com/users/edison-ai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edison-ai/subscriptions","organizations_url":"https://api.github.com/users/edison-ai/orgs","repos_url":"https://api.github.com/users/edison-ai/repos","events_url":"https://api.github.com/users/edison-ai/events{/privacy}","received_events_url":"https://api.github.com/users/edison-ai/received_events","type":"User","site_admin":false},"body":"Support mbedTLS crypto library:\r\n1. Add new flag to support multiple cryptolibs.\r\n2. Support mbedTLS hash algo.\r\n\r\nFor all algos except for hash are set to NULL, so optee cannot bring up until the MAC is implemented. ","created_at":"2017-10-17T02:25:43Z","updated_at":"2018-05-04T13:26:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa67fd4ccd26c4e1ab022ee727c69c695abf3f62","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/1885/commits","review_comments_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/1885/comments","review_comment_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/1885/comments","statuses_url":"https://api.github.com/repos/OP-TEE/optee_os/statuses/25dd80805cf09890fcc31363e3b7275e6b53078d","head":{"label":"edison-ai:support-mbedtls","ref":"support-mbedtls","sha":"25dd80805cf09890fcc31363e3b7275e6b53078d","user":{"login":"edison-ai","id":27393575,"avatar_url":"https://avatars0.githubusercontent.com/u/27393575?v=4","gravatar_id":"","url":"https://api.github.com/users/edison-ai","html_url":"https://github.com/edison-ai","followers_url":"https://api.github.com/users/edison-ai/followers","following_url":"https://api.github.com/users/edison-ai/following{/other_user}","gists_url":"https://api.github.com/users/edison-ai/gists{/gist_id}","starred_url":"https://api.github.com/users/edison-ai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edison-ai/subscriptions","organizations_url":"https://api.github.com/users/edison-ai/orgs","repos_url":"https://api.github.com/users/edison-ai/repos","events_url":"https://api.github.com/users/edison-ai/events{/privacy}","received_events_url":"https://api.github.com/users/edison-ai/received_events","type":"User","site_admin":false},"repo":{"id":107204158,"name":"optee_os","full_name":"edison-ai/optee_os","owner":{"login":"edison-ai","id":27393575,"avatar_url":"https://avatars0.githubusercontent.com/u/27393575?v=4","gravatar_id":"","url":"https://api.github.com/users/edison-ai","html_url":"https://github.com/edison-ai","followers_url":"https://api.github.com/users/edison-ai/followers","following_url":"https://api.github.com/users/edison-ai/following{/other_user}","gists_url":"https://api.github.com/users/edison-ai/gists{/gist_id}","starred_url":"https://api.github.com/users/edison-ai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edison-ai/subscriptions","organizations_url":"https://api.github.com/users/edison-ai/orgs","repos_url":"https://api.github.com/users/edison-ai/repos","events_url":"https://api.github.com/users/edison-ai/events{/privacy}","received_events_url":"https://api.github.com/users/edison-ai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/edison-ai/optee_os","description":"Trusted side of the TEE","fork":true,"url":"https://api.github.com/repos/edison-ai/optee_os","forks_url":"https://api.github.com/repos/edison-ai/optee_os/forks","keys_url":"https://api.github.com/repos/edison-ai/optee_os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edison-ai/optee_os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edison-ai/optee_os/teams","hooks_url":"https://api.github.com/repos/edison-ai/optee_os/hooks","issue_events_url":"https://api.github.com/repos/edison-ai/optee_os/issues/events{/number}","events_url":"https://api.github.com/repos/edison-ai/optee_os/events","assignees_url":"https://api.github.com/repos/edison-ai/optee_os/assignees{/user}","branches_url":"https://api.github.com/repos/edison-ai/optee_os/branches{/branch}","tags_url":"https://api.github.com/repos/edison-ai/optee_os/tags","blobs_url":"https://api.github.com/repos/edison-ai/optee_os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edison-ai/optee_os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edison-ai/optee_os/git/refs{/sha}","trees_url":"https://api.github.com/repos/edison-ai/optee_os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edison-ai/optee_os/statuses/{sha}","languages_url":"https://api.github.com/repos/edison-ai/optee_os/languages","stargazers_url":"https://api.github.com/repos/edison-ai/optee_os/stargazers","contributors_url":"https://api.github.com/repos/edison-ai/optee_os/contributors","subscribers_url":"https://api.github.com/repos/edison-ai/optee_os/subscribers","subscription_url":"https://api.github.com/repos/edison-ai/optee_os/subscription","commits_url":"https://api.github.com/repos/edison-ai/optee_os/commits{/sha}","git_commits_url":"https://api.github.com/repos/edison-ai/optee_os/git/commits{/sha}","comments_url":"https://api.github.com/repos/edison-ai/optee_os/comments{/number}","issue_comment_url":"https://api.github.com/repos/edison-ai/optee_os/issues/comments{/number}","contents_url":"https://api.github.com/repos/edison-ai/optee_os/contents/{+path}","compare_url":"https://api.github.com/repos/edison-ai/optee_os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edison-ai/optee_os/merges","archive_url":"https://api.github.com/repos/edison-ai/optee_os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edison-ai/optee_os/downloads","issues_url":"https://api.github.com/repos/edison-ai/optee_os/issues{/number}","pulls_url":"https://api.github.com/repos/edison-ai/optee_os/pulls{/number}","milestones_url":"https://api.github.com/repos/edison-ai/optee_os/milestones{/number}","notifications_url":"https://api.github.com/repos/edison-ai/optee_os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edison-ai/optee_os/labels{/name}","releases_url":"https://api.github.com/repos/edison-ai/optee_os/releases{/id}","deployments_url":"https://api.github.com/repos/edison-ai/optee_os/deployments","created_at":"2017-10-17T01:49:41Z","updated_at":"2018-04-27T06:26:33Z","pushed_at":"2018-05-04T06:25:44Z","git_url":"git://github.com/edison-ai/optee_os.git","ssh_url":"git@github.com:edison-ai/optee_os.git","clone_url":"https://github.com/edison-ai/optee_os.git","svn_url":"https://github.com/edison-ai/optee_os","homepage":null,"size":15234,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OP-TEE:master","ref":"master","sha":"ded07d047bcb9f0efc4942183eb6733ff767dde0","user":{"login":"OP-TEE","id":7488961,"avatar_url":"https://avatars1.githubusercontent.com/u/7488961?v=4","gravatar_id":"","url":"https://api.github.com/users/OP-TEE","html_url":"https://github.com/OP-TEE","followers_url":"https://api.github.com/users/OP-TEE/followers","following_url":"https://api.github.com/users/OP-TEE/following{/other_user}","gists_url":"https://api.github.com/users/OP-TEE/gists{/gist_id}","starred_url":"https://api.github.com/users/OP-TEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP-TEE/subscriptions","organizations_url":"https://api.github.com/users/OP-TEE/orgs","repos_url":"https://api.github.com/users/OP-TEE/repos","events_url":"https://api.github.com/users/OP-TEE/events{/privacy}","received_events_url":"https://api.github.com/users/OP-TEE/received_events","type":"Organization","site_admin":false},"repo":{"id":20193261,"name":"optee_os","full_name":"OP-TEE/optee_os","owner":{"login":"OP-TEE","id":7488961,"avatar_url":"https://avatars1.githubusercontent.com/u/7488961?v=4","gravatar_id":"","url":"https://api.github.com/users/OP-TEE","html_url":"https://github.com/OP-TEE","followers_url":"https://api.github.com/users/OP-TEE/followers","following_url":"https://api.github.com/users/OP-TEE/following{/other_user}","gists_url":"https://api.github.com/users/OP-TEE/gists{/gist_id}","starred_url":"https://api.github.com/users/OP-TEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP-TEE/subscriptions","organizations_url":"https://api.github.com/users/OP-TEE/orgs","repos_url":"https://api.github.com/users/OP-TEE/repos","events_url":"https://api.github.com/users/OP-TEE/events{/privacy}","received_events_url":"https://api.github.com/users/OP-TEE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OP-TEE/optee_os","description":"Trusted side of the TEE","fork":false,"url":"https://api.github.com/repos/OP-TEE/optee_os","forks_url":"https://api.github.com/repos/OP-TEE/optee_os/forks","keys_url":"https://api.github.com/repos/OP-TEE/optee_os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OP-TEE/optee_os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OP-TEE/optee_os/teams","hooks_url":"https://api.github.com/repos/OP-TEE/optee_os/hooks","issue_events_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/events{/number}","events_url":"https://api.github.com/repos/OP-TEE/optee_os/events","assignees_url":"https://api.github.com/repos/OP-TEE/optee_os/assignees{/user}","branches_url":"https://api.github.com/repos/OP-TEE/optee_os/branches{/branch}","tags_url":"https://api.github.com/repos/OP-TEE/optee_os/tags","blobs_url":"https://api.github.com/repos/OP-TEE/optee_os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OP-TEE/optee_os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OP-TEE/optee_os/git/refs{/sha}","trees_url":"https://api.github.com/repos/OP-TEE/optee_os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OP-TEE/optee_os/statuses/{sha}","languages_url":"https://api.github.com/repos/OP-TEE/optee_os/languages","stargazers_url":"https://api.github.com/repos/OP-TEE/optee_os/stargazers","contributors_url":"https://api.github.com/repos/OP-TEE/optee_os/contributors","subscribers_url":"https://api.github.com/repos/OP-TEE/optee_os/subscribers","subscription_url":"https://api.github.com/repos/OP-TEE/optee_os/subscription","commits_url":"https://api.github.com/repos/OP-TEE/optee_os/commits{/sha}","git_commits_url":"https://api.github.com/repos/OP-TEE/optee_os/git/commits{/sha}","comments_url":"https://api.github.com/repos/OP-TEE/optee_os/comments{/number}","issue_comment_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/comments{/number}","contents_url":"https://api.github.com/repos/OP-TEE/optee_os/contents/{+path}","compare_url":"https://api.github.com/repos/OP-TEE/optee_os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OP-TEE/optee_os/merges","archive_url":"https://api.github.com/repos/OP-TEE/optee_os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OP-TEE/optee_os/downloads","issues_url":"https://api.github.com/repos/OP-TEE/optee_os/issues{/number}","pulls_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls{/number}","milestones_url":"https://api.github.com/repos/OP-TEE/optee_os/milestones{/number}","notifications_url":"https://api.github.com/repos/OP-TEE/optee_os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OP-TEE/optee_os/labels{/name}","releases_url":"https://api.github.com/repos/OP-TEE/optee_os/releases{/id}","deployments_url":"https://api.github.com/repos/OP-TEE/optee_os/deployments","created_at":"2014-05-26T17:18:57Z","updated_at":"2018-05-04T06:01:53Z","pushed_at":"2018-05-04T12:05:37Z","git_url":"git://github.com/OP-TEE/optee_os.git","ssh_url":"git@github.com:OP-TEE/optee_os.git","clone_url":"https://github.com/OP-TEE/optee_os.git","svn_url":"https://github.com/OP-TEE/optee_os","homepage":null,"size":12987,"stargazers_count":385,"watchers_count":385,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":336,"mirror_url":null,"archived":false,"open_issues_count":180,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":336,"open_issues":180,"watchers":385,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/1885"},"html":{"href":"https://github.com/OP-TEE/optee_os/pull/1885"},"issue":{"href":"https://api.github.com/repos/OP-TEE/optee_os/issues/1885"},"comments":{"href":"https://api.github.com/repos/OP-TEE/optee_os/issues/1885/comments"},"review_comments":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/1885/comments"},"review_comment":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/1885/commits"},"statuses":{"href":"https://api.github.com/repos/OP-TEE/optee_os/statuses/25dd80805cf09890fcc31363e3b7275e6b53078d"}},"author_association":"NONE"}}
{"actor":{"display_login":"jenswi-linaro"}}