{"action":"created","issue":{"url":"https://api.github.com/repos/opentracing-contrib/java-spring-cloud/issues/113","repository_url":"https://api.github.com/repos/opentracing-contrib/java-spring-cloud","labels_url":"https://api.github.com/repos/opentracing-contrib/java-spring-cloud/issues/113/labels{/name}","comments_url":"https://api.github.com/repos/opentracing-contrib/java-spring-cloud/issues/113/comments","events_url":"https://api.github.com/repos/opentracing-contrib/java-spring-cloud/issues/113/events","html_url":"https://github.com/opentracing-contrib/java-spring-cloud/pull/113","id":308942524,"number":113,"title":"Add first commit for Jaeger auto-configuration module","user":{"login":"geoand","id":4374975,"avatar_url":"https://avatars2.githubusercontent.com/u/4374975?v=4","gravatar_id":"","url":"https://api.github.com/users/geoand","html_url":"https://github.com/geoand","followers_url":"https://api.github.com/users/geoand/followers","following_url":"https://api.github.com/users/geoand/following{/other_user}","gists_url":"https://api.github.com/users/geoand/gists{/gist_id}","starred_url":"https://api.github.com/users/geoand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoand/subscriptions","organizations_url":"https://api.github.com/users/geoand/orgs","repos_url":"https://api.github.com/users/geoand/repos","events_url":"https://api.github.com/users/geoand/events{/privacy}","received_events_url":"https://api.github.com/users/geoand/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-03-27T12:12:42Z","updated_at":"2018-03-27T15:26:28Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/opentracing-contrib/java-spring-cloud/pulls/113","html_url":"https://github.com/opentracing-contrib/java-spring-cloud/pull/113","diff_url":"https://github.com/opentracing-contrib/java-spring-cloud/pull/113.diff","patch_url":"https://github.com/opentracing-contrib/java-spring-cloud/pull/113.patch"},"body":"This is the first attempt to move the code from https://github.com/snowdrop/opentracing-tracer to this repo.\r\nI have various questions about this:\r\n\r\n* What should the module be named? \r\n\r\nI have currently chosen `opentracing-spring-cloud-starter-jaeger`\r\n\r\n* What should the module dependencies be? \r\n\r\nCurrently I only added a single module that depends on `opentracing-spring-cloud`. \r\nAlthough this is sensible, it might be overkill for users that just want to introduce instrumentation into plain old Spring MVC apps (with no dependencies on Spring Cloud).\r\nThe original code contained separate starter modules, one that depended on `opentracing-spring-web-autoconfigure` and one that depended on `java-spring-cloud`.\r\n\r\n* What is the approach we should follow for \"integration\" tests?\r\n\r\nI have only added Spring tests in the commit, but the original code contained higher level tests in separate Maven modules.\r\n\r\nI am looking forward to hearing your input :)\r\n\r\nRegards\r\n\r\nFixes: #110"},"comment":{"url":"https://api.github.com/repos/opentracing-contrib/java-spring-cloud/issues/comments/376567348","html_url":"https://github.com/opentracing-contrib/java-spring-cloud/pull/113#issuecomment-376567348","issue_url":"https://api.github.com/repos/opentracing-contrib/java-spring-cloud/issues/113","id":376567348,"user":{"login":"pavolloffay","id":5618424,"avatar_url":"https://avatars0.githubusercontent.com/u/5618424?v=4","gravatar_id":"","url":"https://api.github.com/users/pavolloffay","html_url":"https://github.com/pavolloffay","followers_url":"https://api.github.com/users/pavolloffay/followers","following_url":"https://api.github.com/users/pavolloffay/following{/other_user}","gists_url":"https://api.github.com/users/pavolloffay/gists{/gist_id}","starred_url":"https://api.github.com/users/pavolloffay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavolloffay/subscriptions","organizations_url":"https://api.github.com/users/pavolloffay/orgs","repos_url":"https://api.github.com/users/pavolloffay/repos","events_url":"https://api.github.com/users/pavolloffay/events{/privacy}","received_events_url":"https://api.github.com/users/pavolloffay/received_events","type":"User","site_admin":false},"created_at":"2018-03-27T15:26:27Z","updated_at":"2018-03-27T15:26:27Z","author_association":"CONTRIBUTOR","body":">  In that case it wouldn't make sense to force those users to pull\r\ndown all the Spring Cloud dependencies just to get instrumentation of web\r\nrequests working.\r\n\r\nThis project should not pull any additional dependencies. But I see your point. Jaeger auto-config does not have to depend on ot-cloud and it should still work, however users have to add both dependencies to  the classpath."}}
{"actor":{"display_login":"pavolloffay"}}