{"action":"created","comment":{"url":"https://api.github.com/repos/emberjs/ember-test-helpers/pulls/comments/175576621","pull_request_review_id":105129087,"id":175576621,"diff_hunk":"@@ -18,9 +18,10 @@ const MAX_TIMEOUT = 10;\n */\n export default function waitUntil(callback, options = {}) {\n   let timeout = 'timeout' in options ? options.timeout : 1000;\n+  let errorMsg = 'errorMessage' in options ? options.errorMessage : 'waitUntil timed out';","path":"addon-test-support/@ember/test-helpers/wait-until.js","position":4,"original_position":4,"commit_id":"f8db6a3139fd2625c273b5de99f19e0390f1d877","original_commit_id":"f8db6a3139fd2625c273b5de99f19e0390f1d877","user":{"login":"rwjblue","id":12637,"avatar_url":"https://avatars0.githubusercontent.com/u/12637?v=4","gravatar_id":"","url":"https://api.github.com/users/rwjblue","html_url":"https://github.com/rwjblue","followers_url":"https://api.github.com/users/rwjblue/followers","following_url":"https://api.github.com/users/rwjblue/following{/other_user}","gists_url":"https://api.github.com/users/rwjblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rwjblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwjblue/subscriptions","organizations_url":"https://api.github.com/users/rwjblue/orgs","repos_url":"https://api.github.com/users/rwjblue/repos","events_url":"https://api.github.com/users/rwjblue/events{/privacy}","received_events_url":"https://api.github.com/users/rwjblue/received_events","type":"User","site_admin":false},"body":"lets call this explicitly `timeoutMessage` (we may have other types of errors in the future, so I'd like to avoid using the more generic name for now)","created_at":"2018-03-19T20:36:50Z","updated_at":"2018-03-19T20:38:02Z","html_url":"https://github.com/emberjs/ember-test-helpers/pull/346#discussion_r175576621","pull_request_url":"https://api.github.com/repos/emberjs/ember-test-helpers/pulls/346","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember-test-helpers/pulls/comments/175576621"},"html":{"href":"https://github.com/emberjs/ember-test-helpers/pull/346#discussion_r175576621"},"pull_request":{"href":"https://api.github.com/repos/emberjs/ember-test-helpers/pulls/346"}}},"pull_request":{"url":"https://api.github.com/repos/emberjs/ember-test-helpers/pulls/346","id":176015895,"html_url":"https://github.com/emberjs/ember-test-helpers/pull/346","diff_url":"https://github.com/emberjs/ember-test-helpers/pull/346.diff","patch_url":"https://github.com/emberjs/ember-test-helpers/pull/346.patch","issue_url":"https://api.github.com/repos/emberjs/ember-test-helpers/issues/346","number":346,"state":"open","locked":false,"title":"Allow for custom error message in waitUntil helper","user":{"login":"BitBrit","id":1338054,"avatar_url":"https://avatars3.githubusercontent.com/u/1338054?v=4","gravatar_id":"","url":"https://api.github.com/users/BitBrit","html_url":"https://github.com/BitBrit","followers_url":"https://api.github.com/users/BitBrit/followers","following_url":"https://api.github.com/users/BitBrit/following{/other_user}","gists_url":"https://api.github.com/users/BitBrit/gists{/gist_id}","starred_url":"https://api.github.com/users/BitBrit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BitBrit/subscriptions","organizations_url":"https://api.github.com/users/BitBrit/orgs","repos_url":"https://api.github.com/users/BitBrit/repos","events_url":"https://api.github.com/users/BitBrit/events{/privacy}","received_events_url":"https://api.github.com/users/BitBrit/received_events","type":"User","site_admin":false},"body":"We have need to distinguish between different waitUntil timeouts. To do this, it would be nice to be able to pass a custom error message to waitUntil which it will use upon promise reject. This small PR does that. ","created_at":"2018-03-19T20:26:44Z","updated_at":"2018-03-19T20:38:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"01c22e5d676e6cda9504c654ae270a235ed2deed","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/ember-test-helpers/pulls/346/commits","review_comments_url":"https://api.github.com/repos/emberjs/ember-test-helpers/pulls/346/comments","review_comment_url":"https://api.github.com/repos/emberjs/ember-test-helpers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/ember-test-helpers/issues/346/comments","statuses_url":"https://api.github.com/repos/emberjs/ember-test-helpers/statuses/f8db6a3139fd2625c273b5de99f19e0390f1d877","head":{"label":"BitBrit:master","ref":"master","sha":"f8db6a3139fd2625c273b5de99f19e0390f1d877","user":{"login":"BitBrit","id":1338054,"avatar_url":"https://avatars3.githubusercontent.com/u/1338054?v=4","gravatar_id":"","url":"https://api.github.com/users/BitBrit","html_url":"https://github.com/BitBrit","followers_url":"https://api.github.com/users/BitBrit/followers","following_url":"https://api.github.com/users/BitBrit/following{/other_user}","gists_url":"https://api.github.com/users/BitBrit/gists{/gist_id}","starred_url":"https://api.github.com/users/BitBrit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BitBrit/subscriptions","organizations_url":"https://api.github.com/users/BitBrit/orgs","repos_url":"https://api.github.com/users/BitBrit/repos","events_url":"https://api.github.com/users/BitBrit/events{/privacy}","received_events_url":"https://api.github.com/users/BitBrit/received_events","type":"User","site_admin":false},"repo":{"id":125904861,"name":"ember-test-helpers","full_name":"BitBrit/ember-test-helpers","owner":{"login":"BitBrit","id":1338054,"avatar_url":"https://avatars3.githubusercontent.com/u/1338054?v=4","gravatar_id":"","url":"https://api.github.com/users/BitBrit","html_url":"https://github.com/BitBrit","followers_url":"https://api.github.com/users/BitBrit/followers","following_url":"https://api.github.com/users/BitBrit/following{/other_user}","gists_url":"https://api.github.com/users/BitBrit/gists{/gist_id}","starred_url":"https://api.github.com/users/BitBrit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BitBrit/subscriptions","organizations_url":"https://api.github.com/users/BitBrit/orgs","repos_url":"https://api.github.com/users/BitBrit/repos","events_url":"https://api.github.com/users/BitBrit/events{/privacy}","received_events_url":"https://api.github.com/users/BitBrit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BitBrit/ember-test-helpers","description":"Test-framework-agnostic helpers for testing Ember.js applications","fork":true,"url":"https://api.github.com/repos/BitBrit/ember-test-helpers","forks_url":"https://api.github.com/repos/BitBrit/ember-test-helpers/forks","keys_url":"https://api.github.com/repos/BitBrit/ember-test-helpers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BitBrit/ember-test-helpers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BitBrit/ember-test-helpers/teams","hooks_url":"https://api.github.com/repos/BitBrit/ember-test-helpers/hooks","issue_events_url":"https://api.github.com/repos/BitBrit/ember-test-helpers/issues/events{/number}","events_url":"https://api.github.com/repos/BitBrit/ember-test-helpers/events","assignees_url":"https://api.github.com/repos/BitBrit/ember-test-helpers/assignees{/user}","branches_url":"https://api.github.com/repos/BitBrit/ember-test-helpers/branches{/branch}","tags_url":"https://api.github.com/repos/BitBrit/ember-test-helpers/tags","blobs_url":"https://api.github.com/repos/BitBrit/ember-test-helpers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BitBrit/ember-test-helpers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BitBrit/ember-test-helpers/git/refs{/sha}","trees_url":"https://api.github.com/repos/BitBrit/ember-test-helpers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BitBrit/ember-test-helpers/statuses/{sha}","languages_url":"https://api.github.com/repos/BitBrit/ember-test-helpers/languages","stargazers_url":"https://api.github.com/repos/BitBrit/ember-test-helpers/stargazers","contributors_url":"https://api.github.com/repos/BitBrit/ember-test-helpers/contributors","subscribers_url":"https://api.github.com/repos/BitBrit/ember-test-helpers/subscribers","subscription_url":"https://api.github.com/repos/BitBrit/ember-test-helpers/subscription","commits_url":"https://api.github.com/repos/BitBrit/ember-test-helpers/commits{/sha}","git_commits_url":"https://api.github.com/repos/BitBrit/ember-test-helpers/git/commits{/sha}","comments_url":"https://api.github.com/repos/BitBrit/ember-test-helpers/comments{/number}","issue_comment_url":"https://api.github.com/repos/BitBrit/ember-test-helpers/issues/comments{/number}","contents_url":"https://api.github.com/repos/BitBrit/ember-test-helpers/contents/{+path}","compare_url":"https://api.github.com/repos/BitBrit/ember-test-helpers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BitBrit/ember-test-helpers/merges","archive_url":"https://api.github.com/repos/BitBrit/ember-test-helpers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BitBrit/ember-test-helpers/downloads","issues_url":"https://api.github.com/repos/BitBrit/ember-test-helpers/issues{/number}","pulls_url":"https://api.github.com/repos/BitBrit/ember-test-helpers/pulls{/number}","milestones_url":"https://api.github.com/repos/BitBrit/ember-test-helpers/milestones{/number}","notifications_url":"https://api.github.com/repos/BitBrit/ember-test-helpers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BitBrit/ember-test-helpers/labels{/name}","releases_url":"https://api.github.com/repos/BitBrit/ember-test-helpers/releases{/id}","deployments_url":"https://api.github.com/repos/BitBrit/ember-test-helpers/deployments","created_at":"2018-03-19T18:45:49Z","updated_at":"2018-03-19T20:24:18Z","pushed_at":"2018-03-19T20:24:17Z","git_url":"git://github.com/BitBrit/ember-test-helpers.git","ssh_url":"git@github.com:BitBrit/ember-test-helpers.git","clone_url":"https://github.com/BitBrit/ember-test-helpers.git","svn_url":"https://github.com/BitBrit/ember-test-helpers","homepage":"","size":2370,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"3bfae849afead43615dce3ccc3fdccbfa673d4dc","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars2.githubusercontent.com/u/1253363?v=4","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":19406251,"name":"ember-test-helpers","full_name":"emberjs/ember-test-helpers","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars2.githubusercontent.com/u/1253363?v=4","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/ember-test-helpers","description":"Test-framework-agnostic helpers for testing Ember.js applications","fork":false,"url":"https://api.github.com/repos/emberjs/ember-test-helpers","forks_url":"https://api.github.com/repos/emberjs/ember-test-helpers/forks","keys_url":"https://api.github.com/repos/emberjs/ember-test-helpers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/ember-test-helpers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/ember-test-helpers/teams","hooks_url":"https://api.github.com/repos/emberjs/ember-test-helpers/hooks","issue_events_url":"https://api.github.com/repos/emberjs/ember-test-helpers/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/ember-test-helpers/events","assignees_url":"https://api.github.com/repos/emberjs/ember-test-helpers/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/ember-test-helpers/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/ember-test-helpers/tags","blobs_url":"https://api.github.com/repos/emberjs/ember-test-helpers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/ember-test-helpers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/ember-test-helpers/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/ember-test-helpers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/ember-test-helpers/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/ember-test-helpers/languages","stargazers_url":"https://api.github.com/repos/emberjs/ember-test-helpers/stargazers","contributors_url":"https://api.github.com/repos/emberjs/ember-test-helpers/contributors","subscribers_url":"https://api.github.com/repos/emberjs/ember-test-helpers/subscribers","subscription_url":"https://api.github.com/repos/emberjs/ember-test-helpers/subscription","commits_url":"https://api.github.com/repos/emberjs/ember-test-helpers/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/ember-test-helpers/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/ember-test-helpers/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/ember-test-helpers/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/ember-test-helpers/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/ember-test-helpers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/ember-test-helpers/merges","archive_url":"https://api.github.com/repos/emberjs/ember-test-helpers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/ember-test-helpers/downloads","issues_url":"https://api.github.com/repos/emberjs/ember-test-helpers/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/ember-test-helpers/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/ember-test-helpers/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/ember-test-helpers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/ember-test-helpers/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/ember-test-helpers/releases{/id}","deployments_url":"https://api.github.com/repos/emberjs/ember-test-helpers/deployments","created_at":"2014-05-03T15:44:27Z","updated_at":"2018-03-19T14:22:05Z","pushed_at":"2018-03-19T20:26:45Z","git_url":"git://github.com/emberjs/ember-test-helpers.git","ssh_url":"git@github.com:emberjs/ember-test-helpers.git","clone_url":"https://github.com/emberjs/ember-test-helpers.git","svn_url":"https://github.com/emberjs/ember-test-helpers","homepage":"","size":2370,"stargazers_count":82,"watchers_count":82,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":81,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":81,"open_issues":24,"watchers":82,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember-test-helpers/pulls/346"},"html":{"href":"https://github.com/emberjs/ember-test-helpers/pull/346"},"issue":{"href":"https://api.github.com/repos/emberjs/ember-test-helpers/issues/346"},"comments":{"href":"https://api.github.com/repos/emberjs/ember-test-helpers/issues/346/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/ember-test-helpers/pulls/346/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/ember-test-helpers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/ember-test-helpers/pulls/346/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/ember-test-helpers/statuses/f8db6a3139fd2625c273b5de99f19e0390f1d877"}},"author_association":"NONE"}}
{"actor":{"display_login":"rwjblue"}}