{"action":"created","issue":{"url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/1952","repository_url":"https://api.github.com/repos/xamarin/Xamarin.Forms","labels_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/1952/labels{/name}","comments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/1952/comments","events_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/1952/events","html_url":"https://github.com/xamarin/Xamarin.Forms/pull/1952","id":299356690,"number":1952,"title":"[UWP] Icon on TabbedPage","user":{"login":"lateralusX","id":11529140,"avatar_url":"https://avatars0.githubusercontent.com/u/11529140?v=4","gravatar_id":"","url":"https://api.github.com/users/lateralusX","html_url":"https://github.com/lateralusX","followers_url":"https://api.github.com/users/lateralusX/followers","following_url":"https://api.github.com/users/lateralusX/following{/other_user}","gists_url":"https://api.github.com/users/lateralusX/gists{/gist_id}","starred_url":"https://api.github.com/users/lateralusX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lateralusX/subscriptions","organizations_url":"https://api.github.com/users/lateralusX/orgs","repos_url":"https://api.github.com/users/lateralusX/repos","events_url":"https://api.github.com/users/lateralusX/events{/privacy}","received_events_url":"https://api.github.com/users/lateralusX/received_events","type":"User","site_admin":false},"labels":[{"id":816672203,"url":"https://api.github.com/repos/xamarin/Xamarin.Forms/labels/F100","name":"F100","color":"e65bff","default":false},{"id":820749684,"url":"https://api.github.com/repos/xamarin/Xamarin.Forms/labels/community-sprint","name":"community-sprint","color":"3455af","default":false},{"id":770580102,"url":"https://api.github.com/repos/xamarin/Xamarin.Forms/labels/p/UWP","name":"p/UWP","color":"a3241d","default":false},{"id":343860853,"url":"https://api.github.com/repos/xamarin/Xamarin.Forms/labels/t/enhancement","name":"t/enhancement","color":"84b6eb","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-02-22T13:37:09Z","updated_at":"2018-03-07T08:11:04Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/1952","html_url":"https://github.com/xamarin/Xamarin.Forms/pull/1952","diff_url":"https://github.com/xamarin/Xamarin.Forms/pull/1952.diff","patch_url":"https://github.com/xamarin/Xamarin.Forms/pull/1952.patch"},"body":"### Description of Change ###\r\n\r\nImplement icon support for TabbedPage on UWP.\r\n\r\nFixes #1705.\r\n\r\n### API Changes ###\r\n\r\nAdded new Windows platform specific properties to enable/disable icons on tabbed page control as well as possibility to control icon size. \r\n\r\nAdded:\r\n- New bindable properties on Xamarin.Forms.PlatformConfiguration.WindowsSpecific.TabbedPage, \"HeaderIconsEnabledProperty\" and \"HeaderIconsSizeProperty\"\r\n- TabbedPage.On<Windows>().IsHeaderIconsEnabled();\r\n- TabbedPage.On<Windows>().SetHeaderIconsEnabled(true/false);\r\n- TabbedPage.On<Windows>().GetHeaderIconsEnabled();\r\n- TabbedPage.On<Windows>().EnableHeaderIcons();\r\n- TabbedPage.On<Windows>().DisableHeaderIcons();\r\n- TabbedPage.On<Windows>().SetHeaderIconsSize(true/false);\r\n- TabbedPage.On<Windows>().GetHeaderIconsSize();\r\n\r\n### Behavioral Changes ###\r\n\r\nBy default icons will remain disabled on tabbed page controls so current users shouldn't notice this change unless they explicitly enable it. One thing that does change for all users in TabbedPageStyle.xaml is the change from fixed PivotHeaderItem height to auto. This is needed in order to support different icon sizes without clipping. This shouldn't affect current users since they should already handled the case when headers get clipped, reducing the height to a value below old fixed header item size. If however a user relied on clipping behavior, this change will then affect their use of tabbed page control.\r\n\r\n### PR Checklist ###\r\n\r\n- [X] Has tests (if omitted, state reason in description)\r\n- [X] Rebased on top of master at time of PR\r\n- [X] Changes adhere to coding standard\r\n- [X] Consolidate commits as makes sense\r\n"},"comment":{"url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/comments/371057602","html_url":"https://github.com/xamarin/Xamarin.Forms/pull/1952#issuecomment-371057602","issue_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/1952","id":371057602,"user":{"login":"lateralusX","id":11529140,"avatar_url":"https://avatars0.githubusercontent.com/u/11529140?v=4","gravatar_id":"","url":"https://api.github.com/users/lateralusX","html_url":"https://github.com/lateralusX","followers_url":"https://api.github.com/users/lateralusX/followers","following_url":"https://api.github.com/users/lateralusX/following{/other_user}","gists_url":"https://api.github.com/users/lateralusX/gists{/gist_id}","starred_url":"https://api.github.com/users/lateralusX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lateralusX/subscriptions","organizations_url":"https://api.github.com/users/lateralusX/orgs","repos_url":"https://api.github.com/users/lateralusX/repos","events_url":"https://api.github.com/users/lateralusX/events{/privacy}","received_events_url":"https://api.github.com/users/lateralusX/received_events","type":"User","site_admin":false},"created_at":"2018-03-07T08:11:03Z","updated_at":"2018-03-07T08:11:03Z","author_association":"MEMBER","body":"@PureWeen Good to go?"}}
{"actor":{"display_login":"lateralusX"}}