{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/228283611","pull_request_review_id":168521973,"id":228283611,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODI4MzYxMQ==","diff_hunk":"@@ -26,160 +26,151 @@\n #include \"rtos/EventFlags.h\"\n \n \n-/** UDP socket\n+/** UDP socket implementation.\n  */\n class UDPSocket : public InternetSocket {\n public:\n-    /** Create an uninitialized socket\n+    /** Create an uninitialized socket.\n      *\n-     *  Must call open to initialize the socket on a network stack.\n+     *  @note Must call open to initialize the socket on a network stack.\n      */\n     UDPSocket();\n \n-    /** Create a socket on a network interface\n-     *\n-     *  Creates and opens a socket on the network stack of the given\n+    /** Create and open a socket on the network stack of the given\n      *  network interface.\n      *\n-     *  @param stack    Network stack as target for socket\n+     *  @tparam S    Type of the Network stack.","path":"features/netsocket/UDPSocket.h","position":24,"original_position":24,"commit_id":"c02f2164d516a4f3d54ef36861f227e017d8f5ad","original_commit_id":"c02f2164d516a4f3d54ef36861f227e017d8f5ad","user":{"login":"cmonr","id":260086,"node_id":"MDQ6VXNlcjI2MDA4Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/260086?v=4","gravatar_id":"","url":"https://api.github.com/users/cmonr","html_url":"https://github.com/cmonr","followers_url":"https://api.github.com/users/cmonr/followers","following_url":"https://api.github.com/users/cmonr/following{/other_user}","gists_url":"https://api.github.com/users/cmonr/gists{/gist_id}","starred_url":"https://api.github.com/users/cmonr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmonr/subscriptions","organizations_url":"https://api.github.com/users/cmonr/orgs","repos_url":"https://api.github.com/users/cmonr/repos","events_url":"https://api.github.com/users/cmonr/events{/privacy}","received_events_url":"https://api.github.com/users/cmonr/received_events","type":"User","site_admin":false},"body":"Ooh! Didn't know this was a thing.\r\n\r\nNeat!","created_at":"2018-10-25T18:22:20Z","updated_at":"2018-10-25T18:22:20Z","html_url":"https://github.com/ARMmbed/mbed-os/pull/8539#discussion_r228283611","pull_request_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8539","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/228283611"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/8539#discussion_r228283611"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8539"}}},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8539","id":225476186,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NDc2MTg2","html_url":"https://github.com/ARMmbed/mbed-os/pull/8539","diff_url":"https://github.com/ARMmbed/mbed-os/pull/8539.diff","patch_url":"https://github.com/ARMmbed/mbed-os/pull/8539.patch","issue_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/8539","number":8539,"state":"open","locked":false,"title":"Docs: UDPSocket doxygen cleanup","user":{"login":"paul-szczepanek-arm","id":33840200,"node_id":"MDQ6VXNlcjMzODQwMjAw","avatar_url":"https://avatars0.githubusercontent.com/u/33840200?v=4","gravatar_id":"","url":"https://api.github.com/users/paul-szczepanek-arm","html_url":"https://github.com/paul-szczepanek-arm","followers_url":"https://api.github.com/users/paul-szczepanek-arm/followers","following_url":"https://api.github.com/users/paul-szczepanek-arm/following{/other_user}","gists_url":"https://api.github.com/users/paul-szczepanek-arm/gists{/gist_id}","starred_url":"https://api.github.com/users/paul-szczepanek-arm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paul-szczepanek-arm/subscriptions","organizations_url":"https://api.github.com/users/paul-szczepanek-arm/orgs","repos_url":"https://api.github.com/users/paul-szczepanek-arm/repos","events_url":"https://api.github.com/users/paul-szczepanek-arm/events{/privacy}","received_events_url":"https://api.github.com/users/paul-szczepanek-arm/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\nThis is mostly edited for brevity and accuracy.\r\n<!-- \r\n    Required\r\n    Add here detailed changes summary, testing results, dependencies \r\n    Good example: https://os.mbed.com/docs/latest/reference/workflow.html (Pull request template)\r\n-->\r\n\r\n\r\n### Pull request type\r\n\r\n<!-- \r\n    Required\r\n    Please add only one X to one of the following types. Do not fill multiple types (split the pull request otherwise).\r\n    Please note this is not a GitHub task list, indenting the boxes or changing the format to add a '.' or '*' in front\r\n    of them would change the meaning incorrectly. The only changes to be made are to add a description text under the\r\n    description heading and to add a 'x' to the correct box.\r\n-->\r\n    [ ] Fix\r\n    [ ] Refactor\r\n    [ ] Target update\r\n    [ ] Functionality change\r\n    [x] Docs update\r\n    [ ] Test update\r\n    [ ] Breaking change\r\n\r\n","created_at":"2018-10-24T16:47:33Z","updated_at":"2018-10-25T18:22:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2a411173cc1268748a02b2be84471bb021199c3d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"AnotherButler","id":23487484,"node_id":"MDQ6VXNlcjIzNDg3NDg0","avatar_url":"https://avatars3.githubusercontent.com/u/23487484?v=4","gravatar_id":"","url":"https://api.github.com/users/AnotherButler","html_url":"https://github.com/AnotherButler","followers_url":"https://api.github.com/users/AnotherButler/followers","following_url":"https://api.github.com/users/AnotherButler/following{/other_user}","gists_url":"https://api.github.com/users/AnotherButler/gists{/gist_id}","starred_url":"https://api.github.com/users/AnotherButler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnotherButler/subscriptions","organizations_url":"https://api.github.com/users/AnotherButler/orgs","repos_url":"https://api.github.com/users/AnotherButler/repos","events_url":"https://api.github.com/users/AnotherButler/events{/privacy}","received_events_url":"https://api.github.com/users/AnotherButler/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":147112891,"node_id":"MDU6TGFiZWwxNDcxMTI4OTE=","url":"https://api.github.com/repos/ARMmbed/mbed-os/labels/needs:%20review","name":"needs: review","color":"fbca04","default":false},{"id":1095182454,"node_id":"MDU6TGFiZWwxMDk1MTgyNDU0","url":"https://api.github.com/repos/ARMmbed/mbed-os/labels/release-version:%205.10.3","name":"release-version: 5.10.3","color":"fef2c0","default":false},{"id":1088998960,"node_id":"MDU6TGFiZWwxMDg4OTk4OTYw","url":"https://api.github.com/repos/ARMmbed/mbed-os/labels/rollup%20PR","name":"rollup PR","color":"63b0cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8539/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8539/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/8539/comments","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/c02f2164d516a4f3d54ef36861f227e017d8f5ad","head":{"label":"paul-szczepanek-arm:docs-fix-udpsocket","ref":"docs-fix-udpsocket","sha":"c02f2164d516a4f3d54ef36861f227e017d8f5ad","user":{"login":"paul-szczepanek-arm","id":33840200,"node_id":"MDQ6VXNlcjMzODQwMjAw","avatar_url":"https://avatars0.githubusercontent.com/u/33840200?v=4","gravatar_id":"","url":"https://api.github.com/users/paul-szczepanek-arm","html_url":"https://github.com/paul-szczepanek-arm","followers_url":"https://api.github.com/users/paul-szczepanek-arm/followers","following_url":"https://api.github.com/users/paul-szczepanek-arm/following{/other_user}","gists_url":"https://api.github.com/users/paul-szczepanek-arm/gists{/gist_id}","starred_url":"https://api.github.com/users/paul-szczepanek-arm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paul-szczepanek-arm/subscriptions","organizations_url":"https://api.github.com/users/paul-szczepanek-arm/orgs","repos_url":"https://api.github.com/users/paul-szczepanek-arm/repos","events_url":"https://api.github.com/users/paul-szczepanek-arm/events{/privacy}","received_events_url":"https://api.github.com/users/paul-szczepanek-arm/received_events","type":"User","site_admin":false},"repo":{"id":112753124,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI3NTMxMjQ=","name":"mbed-os","full_name":"paul-szczepanek-arm/mbed-os","private":false,"owner":{"login":"paul-szczepanek-arm","id":33840200,"node_id":"MDQ6VXNlcjMzODQwMjAw","avatar_url":"https://avatars0.githubusercontent.com/u/33840200?v=4","gravatar_id":"","url":"https://api.github.com/users/paul-szczepanek-arm","html_url":"https://github.com/paul-szczepanek-arm","followers_url":"https://api.github.com/users/paul-szczepanek-arm/followers","following_url":"https://api.github.com/users/paul-szczepanek-arm/following{/other_user}","gists_url":"https://api.github.com/users/paul-szczepanek-arm/gists{/gist_id}","starred_url":"https://api.github.com/users/paul-szczepanek-arm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paul-szczepanek-arm/subscriptions","organizations_url":"https://api.github.com/users/paul-szczepanek-arm/orgs","repos_url":"https://api.github.com/users/paul-szczepanek-arm/repos","events_url":"https://api.github.com/users/paul-szczepanek-arm/events{/privacy}","received_events_url":"https://api.github.com/users/paul-szczepanek-arm/received_events","type":"User","site_admin":false},"html_url":"https://github.com/paul-szczepanek-arm/mbed-os","description":"ARM mbed OS is a platform operating system designed for the internet of things","fork":true,"url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os","forks_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/forks","keys_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/teams","hooks_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/hooks","issue_events_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/issues/events{/number}","events_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/events","assignees_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/assignees{/user}","branches_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/branches{/branch}","tags_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/tags","blobs_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/statuses/{sha}","languages_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/languages","stargazers_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/stargazers","contributors_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/contributors","subscribers_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/subscribers","subscription_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/subscription","commits_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/contents/{+path}","compare_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/merges","archive_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/downloads","issues_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/issues{/number}","pulls_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/pulls{/number}","milestones_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/milestones{/number}","notifications_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/labels{/name}","releases_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/releases{/id}","deployments_url":"https://api.github.com/repos/paul-szczepanek-arm/mbed-os/deployments","created_at":"2017-12-01T15:07:30Z","updated_at":"2018-10-23T09:13:01Z","pushed_at":"2018-10-25T16:34:01Z","git_url":"git://github.com/paul-szczepanek-arm/mbed-os.git","ssh_url":"git@github.com:paul-szczepanek-arm/mbed-os.git","clone_url":"https://github.com/paul-szczepanek-arm/mbed-os.git","svn_url":"https://github.com/paul-szczepanek-arm/mbed-os","homepage":"https://mbed.com","size":232984,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"ARMmbed:master","ref":"master","sha":"b18c819837e84ae7fcf4ed05e0f369ac9ba26484","user":{"login":"ARMmbed","id":8916057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MTYwNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":8270972,"node_id":"MDEwOlJlcG9zaXRvcnk4MjcwOTcy","name":"mbed-os","full_name":"ARMmbed/mbed-os","private":false,"owner":{"login":"ARMmbed","id":8916057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MTYwNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ARMmbed/mbed-os","description":"Arm Mbed OS is a platform operating system designed for the internet of things","fork":false,"url":"https://api.github.com/repos/ARMmbed/mbed-os","forks_url":"https://api.github.com/repos/ARMmbed/mbed-os/forks","keys_url":"https://api.github.com/repos/ARMmbed/mbed-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/mbed-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/mbed-os/teams","hooks_url":"https://api.github.com/repos/ARMmbed/mbed-os/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/mbed-os/events","assignees_url":"https://api.github.com/repos/ARMmbed/mbed-os/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/mbed-os/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/tags","blobs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/mbed-os/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/mbed-os/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/mbed-os/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscription","commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/mbed-os/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/mbed-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/mbed-os/merges","archive_url":"https://api.github.com/repos/ARMmbed/mbed-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/mbed-os/downloads","issues_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/mbed-os/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/mbed-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/mbed-os/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/mbed-os/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/mbed-os/deployments","created_at":"2013-02-18T15:23:11Z","updated_at":"2018-10-25T17:57:48Z","pushed_at":"2018-10-25T18:11:41Z","git_url":"git://github.com/ARMmbed/mbed-os.git","ssh_url":"git@github.com:ARMmbed/mbed-os.git","clone_url":"https://github.com/ARMmbed/mbed-os.git","svn_url":"https://github.com/ARMmbed/mbed-os","homepage":"https://mbed.com","size":232996,"stargazers_count":2015,"watchers_count":2015,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1647,"mirror_url":null,"archived":false,"open_issues_count":409,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1647,"open_issues":409,"watchers":2015,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8539"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/8539"},"issue":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/8539"},"comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/8539/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8539/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8539/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/c02f2164d516a4f3d54ef36861f227e017d8f5ad"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"cmonr"}}