{"action":"created","comment":{"url":"https://api.github.com/repos/gluster/glusterd2/pulls/comments/223961341","pull_request_review_id":163213688,"id":223961341,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzk2MTM0MQ==","diff_hunk":"@@ -188,3 +188,148 @@ func testGranularEntryHeal(t *testing.T, tc *testCluster) {\n \t// delete volume\n \tr.Nil(client.VolumeDelete(volname))\n }\n+\n+func testSplitBrainOperation(t *testing.T, tc *testCluster) {\n+\tr := require.New(t)\n+\n+\tvar brickPaths []string\n+\tfor i := 1; i <= 2; i++ {\n+\t\tbrickPath := testTempDir(t, \"brick\")\n+\t\tbrickPaths = append(brickPaths, brickPath)\n+\t}\n+\n+\tvolname := formatVolName(t.Name())\n+\n+\t// create 2x2 dist-rep volume\n+\tcreateReq := api.VolCreateReq{\n+\t\tName: volname,\n+\t\tSubvols: []api.SubvolReq{\n+\t\t\t{\n+\t\t\t\tReplicaCount: 2,\n+\t\t\t\tType:         \"replicate\",\n+\t\t\t\tBricks: []api.BrickReq{\n+\t\t\t\t\t{PeerID: tc.gds[0].PeerID(), Path: brickPaths[0]},\n+\t\t\t\t\t{PeerID: tc.gds[0].PeerID(), Path: brickPaths[1]},\n+\t\t\t\t},\n+\t\t\t},\n+\t\t},\n+\t\tForce: true,\n+\t}\n+\t_, err := client.VolumeCreate(createReq)\n+\tr.Nil(err)\n+\n+\tr.Nil(client.VolumeStart(volname, false), \"volume start failed\")\n+\n+\tvar optionReq api.VolOptionReq\n+\tpidpath := path.Join(tc.gds[0].Rundir, \"glustershd.pid\")\n+\toptionReq.Options = map[string]string{\"replicate.self-heal-daemon\": \"off\"}\n+\toptionReq.Advanced = true\n+\tr.Nil(client.VolumeSet(volname, optionReq))\n+\tr.False(isProcessRunning(pidpath), \"glustershd is still running\")\n+\n+\tif _, err := os.Lstat(\"/dev/fuse\"); os.IsNotExist(err) {\n+\t\tt.Skip(\"skipping mount /dev/fuse unavailable\")\n+\t}\n+\n+\tmntPath := testTempDir(t, \"mnt\")\n+\tdefer os.RemoveAll(mntPath)\n+\n+\thost, _, _ := net.SplitHostPort(tc.gds[0].ClientAddress)\n+\terr = mountVolume(host, volname, mntPath)\n+\tr.Nil(err, fmt.Sprintf(\"mount failed: %s\", err))\n+\tdefer syscall.Unmount(mntPath, syscall.MNT_FORCE|syscall.MNT_DETACH)\n+\n+\tf, err := os.Create(mntPath + \"/file1.txt\")\n+\tr.Nil(err, fmt.Sprintf(\"file creation failed: %s\", err))\n+\tf.Close()\n+\n+\tvar prevKilledBrick string\n+\tgetBricksStatus, err := client.BricksStatus(volname)\n+\tr.Nil(err, fmt.Sprintf(\"brick status operation failed: %s\", err))\n+\n+\tfor brick := range getBricksStatus {","path":"e2e/glustershd_test.go","position":63,"original_position":63,"commit_id":"f64d8b96c2428d2c357a46438c10c1dd94967e71","original_commit_id":"f64d8b96c2428d2c357a46438c10c1dd94967e71","user":{"login":"vpandey-RH","id":33927873,"node_id":"MDQ6VXNlcjMzOTI3ODcz","avatar_url":"https://avatars3.githubusercontent.com/u/33927873?v=4","gravatar_id":"","url":"https://api.github.com/users/vpandey-RH","html_url":"https://github.com/vpandey-RH","followers_url":"https://api.github.com/users/vpandey-RH/followers","following_url":"https://api.github.com/users/vpandey-RH/following{/other_user}","gists_url":"https://api.github.com/users/vpandey-RH/gists{/gist_id}","starred_url":"https://api.github.com/users/vpandey-RH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vpandey-RH/subscriptions","organizations_url":"https://api.github.com/users/vpandey-RH/orgs","repos_url":"https://api.github.com/users/vpandey-RH/repos","events_url":"https://api.github.com/users/vpandey-RH/events{/privacy}","received_events_url":"https://api.github.com/users/vpandey-RH/received_events","type":"User","site_admin":false},"body":"It won't iterate through both bricks as `break` will force to end the loop as soon as it finds one brick PeerID  matching.","created_at":"2018-10-10T07:21:30Z","updated_at":"2018-10-10T07:21:30Z","html_url":"https://github.com/gluster/glusterd2/pull/1173#discussion_r223961341","pull_request_url":"https://api.github.com/repos/gluster/glusterd2/pulls/1173","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/gluster/glusterd2/pulls/comments/223961341"},"html":{"href":"https://github.com/gluster/glusterd2/pull/1173#discussion_r223961341"},"pull_request":{"href":"https://api.github.com/repos/gluster/glusterd2/pulls/1173"}},"in_reply_to_id":223614654},"pull_request":{"url":"https://api.github.com/repos/gluster/glusterd2/pulls/1173","id":208492851,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NDkyODUx","html_url":"https://github.com/gluster/glusterd2/pull/1173","diff_url":"https://github.com/gluster/glusterd2/pull/1173.diff","patch_url":"https://github.com/gluster/glusterd2/pull/1173.patch","issue_url":"https://api.github.com/repos/gluster/glusterd2/issues/1173","number":1173,"state":"open","locked":false,"title":"Split brain operations API and CLI","user":{"login":"vpandey-RH","id":33927873,"node_id":"MDQ6VXNlcjMzOTI3ODcz","avatar_url":"https://avatars3.githubusercontent.com/u/33927873?v=4","gravatar_id":"","url":"https://api.github.com/users/vpandey-RH","html_url":"https://github.com/vpandey-RH","followers_url":"https://api.github.com/users/vpandey-RH/followers","following_url":"https://api.github.com/users/vpandey-RH/following{/other_user}","gists_url":"https://api.github.com/users/vpandey-RH/gists{/gist_id}","starred_url":"https://api.github.com/users/vpandey-RH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vpandey-RH/subscriptions","organizations_url":"https://api.github.com/users/vpandey-RH/orgs","repos_url":"https://api.github.com/users/vpandey-RH/repos","events_url":"https://api.github.com/users/vpandey-RH/events{/privacy}","received_events_url":"https://api.github.com/users/vpandey-RH/received_events","type":"User","site_admin":false},"body":"Fixes [#1086](https://github.com/gluster/glusterd2/issues/1086)\r\nUpdates [#427](https://github.com/gluster/glusterd2/issues/427)\r\n\r\nImplements Split Brain Operation API and CLI.","created_at":"2018-08-15T07:38:31Z","updated_at":"2018-10-10T07:21:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"771e6b6fe474c5cc361e405e85c949956ef70550","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gluster/glusterd2/pulls/1173/commits","review_comments_url":"https://api.github.com/repos/gluster/glusterd2/pulls/1173/comments","review_comment_url":"https://api.github.com/repos/gluster/glusterd2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gluster/glusterd2/issues/1173/comments","statuses_url":"https://api.github.com/repos/gluster/glusterd2/statuses/f64d8b96c2428d2c357a46438c10c1dd94967e71","head":{"label":"vpandey-RH:self-heal-split-brain-operations","ref":"self-heal-split-brain-operations","sha":"f64d8b96c2428d2c357a46438c10c1dd94967e71","user":{"login":"vpandey-RH","id":33927873,"node_id":"MDQ6VXNlcjMzOTI3ODcz","avatar_url":"https://avatars3.githubusercontent.com/u/33927873?v=4","gravatar_id":"","url":"https://api.github.com/users/vpandey-RH","html_url":"https://github.com/vpandey-RH","followers_url":"https://api.github.com/users/vpandey-RH/followers","following_url":"https://api.github.com/users/vpandey-RH/following{/other_user}","gists_url":"https://api.github.com/users/vpandey-RH/gists{/gist_id}","starred_url":"https://api.github.com/users/vpandey-RH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vpandey-RH/subscriptions","organizations_url":"https://api.github.com/users/vpandey-RH/orgs","repos_url":"https://api.github.com/users/vpandey-RH/repos","events_url":"https://api.github.com/users/vpandey-RH/events{/privacy}","received_events_url":"https://api.github.com/users/vpandey-RH/received_events","type":"User","site_admin":false},"repo":{"id":111794718,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE3OTQ3MTg=","name":"glusterd2","full_name":"vpandey-RH/glusterd2","private":false,"owner":{"login":"vpandey-RH","id":33927873,"node_id":"MDQ6VXNlcjMzOTI3ODcz","avatar_url":"https://avatars3.githubusercontent.com/u/33927873?v=4","gravatar_id":"","url":"https://api.github.com/users/vpandey-RH","html_url":"https://github.com/vpandey-RH","followers_url":"https://api.github.com/users/vpandey-RH/followers","following_url":"https://api.github.com/users/vpandey-RH/following{/other_user}","gists_url":"https://api.github.com/users/vpandey-RH/gists{/gist_id}","starred_url":"https://api.github.com/users/vpandey-RH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vpandey-RH/subscriptions","organizations_url":"https://api.github.com/users/vpandey-RH/orgs","repos_url":"https://api.github.com/users/vpandey-RH/repos","events_url":"https://api.github.com/users/vpandey-RH/events{/privacy}","received_events_url":"https://api.github.com/users/vpandey-RH/received_events","type":"User","site_admin":false},"html_url":"https://github.com/vpandey-RH/glusterd2","description":"GlusterD-2.0 is the distributed management framework to be used for GlusterFS-4.0","fork":true,"url":"https://api.github.com/repos/vpandey-RH/glusterd2","forks_url":"https://api.github.com/repos/vpandey-RH/glusterd2/forks","keys_url":"https://api.github.com/repos/vpandey-RH/glusterd2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vpandey-RH/glusterd2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vpandey-RH/glusterd2/teams","hooks_url":"https://api.github.com/repos/vpandey-RH/glusterd2/hooks","issue_events_url":"https://api.github.com/repos/vpandey-RH/glusterd2/issues/events{/number}","events_url":"https://api.github.com/repos/vpandey-RH/glusterd2/events","assignees_url":"https://api.github.com/repos/vpandey-RH/glusterd2/assignees{/user}","branches_url":"https://api.github.com/repos/vpandey-RH/glusterd2/branches{/branch}","tags_url":"https://api.github.com/repos/vpandey-RH/glusterd2/tags","blobs_url":"https://api.github.com/repos/vpandey-RH/glusterd2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vpandey-RH/glusterd2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vpandey-RH/glusterd2/git/refs{/sha}","trees_url":"https://api.github.com/repos/vpandey-RH/glusterd2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vpandey-RH/glusterd2/statuses/{sha}","languages_url":"https://api.github.com/repos/vpandey-RH/glusterd2/languages","stargazers_url":"https://api.github.com/repos/vpandey-RH/glusterd2/stargazers","contributors_url":"https://api.github.com/repos/vpandey-RH/glusterd2/contributors","subscribers_url":"https://api.github.com/repos/vpandey-RH/glusterd2/subscribers","subscription_url":"https://api.github.com/repos/vpandey-RH/glusterd2/subscription","commits_url":"https://api.github.com/repos/vpandey-RH/glusterd2/commits{/sha}","git_commits_url":"https://api.github.com/repos/vpandey-RH/glusterd2/git/commits{/sha}","comments_url":"https://api.github.com/repos/vpandey-RH/glusterd2/comments{/number}","issue_comment_url":"https://api.github.com/repos/vpandey-RH/glusterd2/issues/comments{/number}","contents_url":"https://api.github.com/repos/vpandey-RH/glusterd2/contents/{+path}","compare_url":"https://api.github.com/repos/vpandey-RH/glusterd2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vpandey-RH/glusterd2/merges","archive_url":"https://api.github.com/repos/vpandey-RH/glusterd2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vpandey-RH/glusterd2/downloads","issues_url":"https://api.github.com/repos/vpandey-RH/glusterd2/issues{/number}","pulls_url":"https://api.github.com/repos/vpandey-RH/glusterd2/pulls{/number}","milestones_url":"https://api.github.com/repos/vpandey-RH/glusterd2/milestones{/number}","notifications_url":"https://api.github.com/repos/vpandey-RH/glusterd2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vpandey-RH/glusterd2/labels{/name}","releases_url":"https://api.github.com/repos/vpandey-RH/glusterd2/releases{/id}","deployments_url":"https://api.github.com/repos/vpandey-RH/glusterd2/deployments","created_at":"2017-11-23T10:16:50Z","updated_at":"2017-11-23T10:16:52Z","pushed_at":"2018-10-09T13:24:09Z","git_url":"git://github.com/vpandey-RH/glusterd2.git","ssh_url":"git@github.com:vpandey-RH/glusterd2.git","clone_url":"https://github.com/vpandey-RH/glusterd2.git","svn_url":"https://github.com/vpandey-RH/glusterd2","homepage":"","size":13117,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gluster:master","ref":"master","sha":"e25afce58985f4da236b0070abc74d939e518a94","user":{"login":"gluster","id":622644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMjY0NA==","avatar_url":"https://avatars3.githubusercontent.com/u/622644?v=4","gravatar_id":"","url":"https://api.github.com/users/gluster","html_url":"https://github.com/gluster","followers_url":"https://api.github.com/users/gluster/followers","following_url":"https://api.github.com/users/gluster/following{/other_user}","gists_url":"https://api.github.com/users/gluster/gists{/gist_id}","starred_url":"https://api.github.com/users/gluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gluster/subscriptions","organizations_url":"https://api.github.com/users/gluster/orgs","repos_url":"https://api.github.com/users/gluster/repos","events_url":"https://api.github.com/users/gluster/events{/privacy}","received_events_url":"https://api.github.com/users/gluster/received_events","type":"Organization","site_admin":false},"repo":{"id":24369600,"node_id":"MDEwOlJlcG9zaXRvcnkyNDM2OTYwMA==","name":"glusterd2","full_name":"gluster/glusterd2","private":false,"owner":{"login":"gluster","id":622644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMjY0NA==","avatar_url":"https://avatars3.githubusercontent.com/u/622644?v=4","gravatar_id":"","url":"https://api.github.com/users/gluster","html_url":"https://github.com/gluster","followers_url":"https://api.github.com/users/gluster/followers","following_url":"https://api.github.com/users/gluster/following{/other_user}","gists_url":"https://api.github.com/users/gluster/gists{/gist_id}","starred_url":"https://api.github.com/users/gluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gluster/subscriptions","organizations_url":"https://api.github.com/users/gluster/orgs","repos_url":"https://api.github.com/users/gluster/repos","events_url":"https://api.github.com/users/gluster/events{/privacy}","received_events_url":"https://api.github.com/users/gluster/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gluster/glusterd2","description":"Glusterd2 is the distributed management framework to be used for GlusterFS","fork":false,"url":"https://api.github.com/repos/gluster/glusterd2","forks_url":"https://api.github.com/repos/gluster/glusterd2/forks","keys_url":"https://api.github.com/repos/gluster/glusterd2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gluster/glusterd2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gluster/glusterd2/teams","hooks_url":"https://api.github.com/repos/gluster/glusterd2/hooks","issue_events_url":"https://api.github.com/repos/gluster/glusterd2/issues/events{/number}","events_url":"https://api.github.com/repos/gluster/glusterd2/events","assignees_url":"https://api.github.com/repos/gluster/glusterd2/assignees{/user}","branches_url":"https://api.github.com/repos/gluster/glusterd2/branches{/branch}","tags_url":"https://api.github.com/repos/gluster/glusterd2/tags","blobs_url":"https://api.github.com/repos/gluster/glusterd2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gluster/glusterd2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gluster/glusterd2/git/refs{/sha}","trees_url":"https://api.github.com/repos/gluster/glusterd2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gluster/glusterd2/statuses/{sha}","languages_url":"https://api.github.com/repos/gluster/glusterd2/languages","stargazers_url":"https://api.github.com/repos/gluster/glusterd2/stargazers","contributors_url":"https://api.github.com/repos/gluster/glusterd2/contributors","subscribers_url":"https://api.github.com/repos/gluster/glusterd2/subscribers","subscription_url":"https://api.github.com/repos/gluster/glusterd2/subscription","commits_url":"https://api.github.com/repos/gluster/glusterd2/commits{/sha}","git_commits_url":"https://api.github.com/repos/gluster/glusterd2/git/commits{/sha}","comments_url":"https://api.github.com/repos/gluster/glusterd2/comments{/number}","issue_comment_url":"https://api.github.com/repos/gluster/glusterd2/issues/comments{/number}","contents_url":"https://api.github.com/repos/gluster/glusterd2/contents/{+path}","compare_url":"https://api.github.com/repos/gluster/glusterd2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gluster/glusterd2/merges","archive_url":"https://api.github.com/repos/gluster/glusterd2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gluster/glusterd2/downloads","issues_url":"https://api.github.com/repos/gluster/glusterd2/issues{/number}","pulls_url":"https://api.github.com/repos/gluster/glusterd2/pulls{/number}","milestones_url":"https://api.github.com/repos/gluster/glusterd2/milestones{/number}","notifications_url":"https://api.github.com/repos/gluster/glusterd2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gluster/glusterd2/labels{/name}","releases_url":"https://api.github.com/repos/gluster/glusterd2/releases{/id}","deployments_url":"https://api.github.com/repos/gluster/glusterd2/deployments","created_at":"2014-09-23T12:02:13Z","updated_at":"2018-10-10T06:29:29Z","pushed_at":"2018-10-10T07:13:53Z","git_url":"git://github.com/gluster/glusterd2.git","ssh_url":"git@github.com:gluster/glusterd2.git","clone_url":"https://github.com/gluster/glusterd2.git","svn_url":"https://github.com/gluster/glusterd2","homepage":"","size":13084,"stargazers_count":118,"watchers_count":118,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":71,"mirror_url":null,"archived":false,"open_issues_count":223,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":71,"open_issues":223,"watchers":118,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gluster/glusterd2/pulls/1173"},"html":{"href":"https://github.com/gluster/glusterd2/pull/1173"},"issue":{"href":"https://api.github.com/repos/gluster/glusterd2/issues/1173"},"comments":{"href":"https://api.github.com/repos/gluster/glusterd2/issues/1173/comments"},"review_comments":{"href":"https://api.github.com/repos/gluster/glusterd2/pulls/1173/comments"},"review_comment":{"href":"https://api.github.com/repos/gluster/glusterd2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gluster/glusterd2/pulls/1173/commits"},"statuses":{"href":"https://api.github.com/repos/gluster/glusterd2/statuses/f64d8b96c2428d2c357a46438c10c1dd94967e71"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vpandey-RH"}}