{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/pulls/comments/229770428","pull_request_review_id":170349326,"id":229770428,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTc3MDQyOA==","diff_hunk":"@@ -752,10 +752,10 @@ ErrorReport buildErrorReport(ManagedErrorLog log) {\n                     ErrorReport report = ErrorLogHelper.getErrorReportFromErrorLog(log, throwable);\n                     mErrorReportCache.put(id, new ErrorLogReport(log, report));\n                     return report;\n-                } catch (ClassNotFoundException ignored) {\n-                    AppCenterLog.error(LOG_TAG, \"Cannot read throwable file \" + file.getName(), ignored);\n-                } catch (IOException ignored) {\n-                    AppCenterLog.error(LOG_TAG, \"Cannot access serialized throwable file \" + file.getName(), ignored);\n+                } catch (ClassNotFoundException | StackOverflowError e) {","path":"sdk/appcenter-crashes/src/main/java/com/microsoft/appcenter/crashes/Crashes.java","position":8,"original_position":8,"commit_id":"bc7c1c6f00e6dd71db3d4eeac5f9dc62aec46413","original_commit_id":"bc7c1c6f00e6dd71db3d4eeac5f9dc62aec46413","user":{"login":"jwallra","id":13154238,"node_id":"MDQ6VXNlcjEzMTU0MjM4","avatar_url":"https://avatars3.githubusercontent.com/u/13154238?v=4","gravatar_id":"","url":"https://api.github.com/users/jwallra","html_url":"https://github.com/jwallra","followers_url":"https://api.github.com/users/jwallra/followers","following_url":"https://api.github.com/users/jwallra/following{/other_user}","gists_url":"https://api.github.com/users/jwallra/gists{/gist_id}","starred_url":"https://api.github.com/users/jwallra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwallra/subscriptions","organizations_url":"https://api.github.com/users/jwallra/orgs","repos_url":"https://api.github.com/users/jwallra/repos","events_url":"https://api.github.com/users/jwallra/events{/privacy}","received_events_url":"https://api.github.com/users/jwallra/received_events","type":"User","site_admin":false},"body":"Should these exceptions really have the same message?  I think we can be more explicit here so we can investigate more precisely when for support issues.","created_at":"2018-10-31T16:27:37Z","updated_at":"2018-10-31T16:33:12Z","html_url":"https://github.com/Microsoft/AppCenter-SDK-Android/pull/859#discussion_r229770428","pull_request_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/pulls/859","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/pulls/comments/229770428"},"html":{"href":"https://github.com/Microsoft/AppCenter-SDK-Android/pull/859#discussion_r229770428"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/pulls/859"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/pulls/859","id":227284576,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3Mjg0NTc2","html_url":"https://github.com/Microsoft/AppCenter-SDK-Android/pull/859","diff_url":"https://github.com/Microsoft/AppCenter-SDK-Android/pull/859.diff","patch_url":"https://github.com/Microsoft/AppCenter-SDK-Android/pull/859.patch","issue_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/issues/859","number":859,"state":"open","locked":false,"title":"Preventing stack overflow crash while reading a huge throwable file","user":{"login":"MatkovIvan","id":1836384,"node_id":"MDQ6VXNlcjE4MzYzODQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1836384?v=4","gravatar_id":"","url":"https://api.github.com/users/MatkovIvan","html_url":"https://github.com/MatkovIvan","followers_url":"https://api.github.com/users/MatkovIvan/followers","following_url":"https://api.github.com/users/MatkovIvan/following{/other_user}","gists_url":"https://api.github.com/users/MatkovIvan/gists{/gist_id}","starred_url":"https://api.github.com/users/MatkovIvan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatkovIvan/subscriptions","organizations_url":"https://api.github.com/users/MatkovIvan/orgs","repos_url":"https://api.github.com/users/MatkovIvan/repos","events_url":"https://api.github.com/users/MatkovIvan/events{/privacy}","received_events_url":"https://api.github.com/users/MatkovIvan/received_events","type":"User","site_admin":false},"body":"* [x] Has `CHANGELOG.md` been updated?\r\n* [x] Are tests passing locally?\r\n* [x] Are the files formatted correctly?\r\n* [x] Did you add unit tests?\r\n* [x] Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?\r\n\r\n## Description\r\n\r\nPreventing stack overflow crash while reading a huge throwable file.\r\n\r\n## Related PRs or issues\r\n\r\n#855\r\n","created_at":"2018-10-31T13:25:59Z","updated_at":"2018-10-31T16:33:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f50c064e3c3b9a5d6cec69c1e6974b7cc410b6e7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"guperrot","id":623672,"node_id":"MDQ6VXNlcjYyMzY3Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/623672?v=4","gravatar_id":"","url":"https://api.github.com/users/guperrot","html_url":"https://github.com/guperrot","followers_url":"https://api.github.com/users/guperrot/followers","following_url":"https://api.github.com/users/guperrot/following{/other_user}","gists_url":"https://api.github.com/users/guperrot/gists{/gist_id}","starred_url":"https://api.github.com/users/guperrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guperrot/subscriptions","organizations_url":"https://api.github.com/users/guperrot/orgs","repos_url":"https://api.github.com/users/guperrot/repos","events_url":"https://api.github.com/users/guperrot/events{/privacy}","received_events_url":"https://api.github.com/users/guperrot/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/pulls/859/commits","review_comments_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/pulls/859/comments","review_comment_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/issues/859/comments","statuses_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/statuses/bc7c1c6f00e6dd71db3d4eeac5f9dc62aec46413","head":{"label":"Microsoft:fix/catch-stackoverflow","ref":"fix/catch-stackoverflow","sha":"bc7c1c6f00e6dd71db3d4eeac5f9dc62aec46413","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":60783603,"node_id":"MDEwOlJlcG9zaXRvcnk2MDc4MzYwMw==","name":"AppCenter-SDK-Android","full_name":"Microsoft/AppCenter-SDK-Android","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/AppCenter-SDK-Android","description":"Development repository for the App Center SDK for Android","fork":false,"url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android","forks_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/forks","keys_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/teams","hooks_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/events","assignees_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/tags","blobs_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/languages","stargazers_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/subscription","commits_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/merges","archive_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/downloads","issues_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/deployments","created_at":"2016-06-09T15:03:59Z","updated_at":"2018-10-26T12:32:58Z","pushed_at":"2018-10-31T13:26:00Z","git_url":"git://github.com/Microsoft/AppCenter-SDK-Android.git","ssh_url":"git@github.com:Microsoft/AppCenter-SDK-Android.git","clone_url":"https://github.com/Microsoft/AppCenter-SDK-Android.git","svn_url":"https://github.com/Microsoft/AppCenter-SDK-Android","homepage":"","size":10057,"stargazers_count":49,"watchers_count":49,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":53,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":53,"open_issues":7,"watchers":49,"default_branch":"develop"}},"base":{"label":"Microsoft:develop","ref":"develop","sha":"81aed43c8ce220f1494f61e022a4028f0ae461e7","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":60783603,"node_id":"MDEwOlJlcG9zaXRvcnk2MDc4MzYwMw==","name":"AppCenter-SDK-Android","full_name":"Microsoft/AppCenter-SDK-Android","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/AppCenter-SDK-Android","description":"Development repository for the App Center SDK for Android","fork":false,"url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android","forks_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/forks","keys_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/teams","hooks_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/events","assignees_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/tags","blobs_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/languages","stargazers_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/subscription","commits_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/merges","archive_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/downloads","issues_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/deployments","created_at":"2016-06-09T15:03:59Z","updated_at":"2018-10-26T12:32:58Z","pushed_at":"2018-10-31T13:26:00Z","git_url":"git://github.com/Microsoft/AppCenter-SDK-Android.git","ssh_url":"git@github.com:Microsoft/AppCenter-SDK-Android.git","clone_url":"https://github.com/Microsoft/AppCenter-SDK-Android.git","svn_url":"https://github.com/Microsoft/AppCenter-SDK-Android","homepage":"","size":10057,"stargazers_count":49,"watchers_count":49,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":53,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":53,"open_issues":7,"watchers":49,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/pulls/859"},"html":{"href":"https://github.com/Microsoft/AppCenter-SDK-Android/pull/859"},"issue":{"href":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/issues/859"},"comments":{"href":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/issues/859/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/pulls/859/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/pulls/859/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/AppCenter-SDK-Android/statuses/bc7c1c6f00e6dd71db3d4eeac5f9dc62aec46413"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jwallra"}}