{"action":"closed","number":266,"pull_request":{"url":"https://api.github.com/repos/Tribler/py-ipv8/pulls/266","id":215354490,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MzU0NDkw","html_url":"https://github.com/Tribler/py-ipv8/pull/266","diff_url":"https://github.com/Tribler/py-ipv8/pull/266.diff","patch_url":"https://github.com/Tribler/py-ipv8/pull/266.patch","issue_url":"https://api.github.com/repos/Tribler/py-ipv8/issues/266","number":266,"state":"closed","locked":false,"title":"ON HOLD: Trial testing system: take 2","user":{"login":"ichorid","id":2509103,"node_id":"MDQ6VXNlcjI1MDkxMDM=","avatar_url":"https://avatars1.githubusercontent.com/u/2509103?v=4","gravatar_id":"","url":"https://api.github.com/users/ichorid","html_url":"https://github.com/ichorid","followers_url":"https://api.github.com/users/ichorid/followers","following_url":"https://api.github.com/users/ichorid/following{/other_user}","gists_url":"https://api.github.com/users/ichorid/gists{/gist_id}","starred_url":"https://api.github.com/users/ichorid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ichorid/subscriptions","organizations_url":"https://api.github.com/users/ichorid/orgs","repos_url":"https://api.github.com/users/ichorid/repos","events_url":"https://api.github.com/users/ichorid/events{/privacy}","received_events_url":"https://api.github.com/users/ichorid/received_events","type":"User","site_admin":false},"body":"It is all cleaned up now (continued from https://github.com/Tribler/py-ipv8/pull/245). Only commits relevant to Trial migration here.\r\n\r\n### Test output\r\nBasically nose still run the tests, nothing changed on the outside. However, inside the `unittest` object is provided by `twisted.trial` module. \r\n\r\n### Alternative reactor Nose runner\r\nTo ensure that the runtime is not increased due to https://github.com/Tribler/py-ipv8/pull/245#issuecomment-418434274 we have to use our own runner for `nosetest` utility to be able to select an alternative reactor. We only do this on Unix systems, though. By default we try to use `glib2reactor` that is stable, does not produce any spurious messages and does not hit https://github.com/Tribler/py-ipv8/pull/245#issuecomment-418434274 problem. If it not available, we fall back to `selectreactor` that is available for all platforms.\r\n\r\n### Trial-based runner\r\nIn addition, we now have the option to use Trial-based runner, that automatically scans the dirs for tests. It does not collect the logs, though. However, in parallel mode, it runs the whole suite in under 1 second, so it is useful for doing quick checks (only on Unix platforms).\r\nTo use it, one must first regenerate the Twisted plugins cache with provided utility (or just run it more than one time).","created_at":"2018-09-13T17:17:41Z","updated_at":"2018-09-16T13:48:27Z","closed_at":"2018-09-16T13:48:27Z","merged_at":"2018-09-16T13:48:27Z","merge_commit_sha":"70f6e8c80e55aa587ddc804fa1e66c3c16a8da38","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Tribler/py-ipv8/pulls/266/commits","review_comments_url":"https://api.github.com/repos/Tribler/py-ipv8/pulls/266/comments","review_comment_url":"https://api.github.com/repos/Tribler/py-ipv8/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Tribler/py-ipv8/issues/266/comments","statuses_url":"https://api.github.com/repos/Tribler/py-ipv8/statuses/f3184bcce2e31ecf4d010a64ad5ade21cce05a71","head":{"label":"ichorid:f_trial_compatible","ref":"f_trial_compatible","sha":"f3184bcce2e31ecf4d010a64ad5ade21cce05a71","user":{"login":"ichorid","id":2509103,"node_id":"MDQ6VXNlcjI1MDkxMDM=","avatar_url":"https://avatars1.githubusercontent.com/u/2509103?v=4","gravatar_id":"","url":"https://api.github.com/users/ichorid","html_url":"https://github.com/ichorid","followers_url":"https://api.github.com/users/ichorid/followers","following_url":"https://api.github.com/users/ichorid/following{/other_user}","gists_url":"https://api.github.com/users/ichorid/gists{/gist_id}","starred_url":"https://api.github.com/users/ichorid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ichorid/subscriptions","organizations_url":"https://api.github.com/users/ichorid/orgs","repos_url":"https://api.github.com/users/ichorid/repos","events_url":"https://api.github.com/users/ichorid/events{/privacy}","received_events_url":"https://api.github.com/users/ichorid/received_events","type":"User","site_admin":false},"repo":{"id":130348146,"node_id":"MDEwOlJlcG9zaXRvcnkxMzAzNDgxNDY=","name":"py-ipv8","full_name":"ichorid/py-ipv8","private":false,"owner":{"login":"ichorid","id":2509103,"node_id":"MDQ6VXNlcjI1MDkxMDM=","avatar_url":"https://avatars1.githubusercontent.com/u/2509103?v=4","gravatar_id":"","url":"https://api.github.com/users/ichorid","html_url":"https://github.com/ichorid","followers_url":"https://api.github.com/users/ichorid/followers","following_url":"https://api.github.com/users/ichorid/following{/other_user}","gists_url":"https://api.github.com/users/ichorid/gists{/gist_id}","starred_url":"https://api.github.com/users/ichorid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ichorid/subscriptions","organizations_url":"https://api.github.com/users/ichorid/orgs","repos_url":"https://api.github.com/users/ichorid/repos","events_url":"https://api.github.com/users/ichorid/events{/privacy}","received_events_url":"https://api.github.com/users/ichorid/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ichorid/py-ipv8","description":"Python implementation of the IPv8 layer","fork":true,"url":"https://api.github.com/repos/ichorid/py-ipv8","forks_url":"https://api.github.com/repos/ichorid/py-ipv8/forks","keys_url":"https://api.github.com/repos/ichorid/py-ipv8/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ichorid/py-ipv8/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ichorid/py-ipv8/teams","hooks_url":"https://api.github.com/repos/ichorid/py-ipv8/hooks","issue_events_url":"https://api.github.com/repos/ichorid/py-ipv8/issues/events{/number}","events_url":"https://api.github.com/repos/ichorid/py-ipv8/events","assignees_url":"https://api.github.com/repos/ichorid/py-ipv8/assignees{/user}","branches_url":"https://api.github.com/repos/ichorid/py-ipv8/branches{/branch}","tags_url":"https://api.github.com/repos/ichorid/py-ipv8/tags","blobs_url":"https://api.github.com/repos/ichorid/py-ipv8/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ichorid/py-ipv8/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ichorid/py-ipv8/git/refs{/sha}","trees_url":"https://api.github.com/repos/ichorid/py-ipv8/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ichorid/py-ipv8/statuses/{sha}","languages_url":"https://api.github.com/repos/ichorid/py-ipv8/languages","stargazers_url":"https://api.github.com/repos/ichorid/py-ipv8/stargazers","contributors_url":"https://api.github.com/repos/ichorid/py-ipv8/contributors","subscribers_url":"https://api.github.com/repos/ichorid/py-ipv8/subscribers","subscription_url":"https://api.github.com/repos/ichorid/py-ipv8/subscription","commits_url":"https://api.github.com/repos/ichorid/py-ipv8/commits{/sha}","git_commits_url":"https://api.github.com/repos/ichorid/py-ipv8/git/commits{/sha}","comments_url":"https://api.github.com/repos/ichorid/py-ipv8/comments{/number}","issue_comment_url":"https://api.github.com/repos/ichorid/py-ipv8/issues/comments{/number}","contents_url":"https://api.github.com/repos/ichorid/py-ipv8/contents/{+path}","compare_url":"https://api.github.com/repos/ichorid/py-ipv8/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ichorid/py-ipv8/merges","archive_url":"https://api.github.com/repos/ichorid/py-ipv8/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ichorid/py-ipv8/downloads","issues_url":"https://api.github.com/repos/ichorid/py-ipv8/issues{/number}","pulls_url":"https://api.github.com/repos/ichorid/py-ipv8/pulls{/number}","milestones_url":"https://api.github.com/repos/ichorid/py-ipv8/milestones{/number}","notifications_url":"https://api.github.com/repos/ichorid/py-ipv8/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ichorid/py-ipv8/labels{/name}","releases_url":"https://api.github.com/repos/ichorid/py-ipv8/releases{/id}","deployments_url":"https://api.github.com/repos/ichorid/py-ipv8/deployments","created_at":"2018-04-20T10:35:00Z","updated_at":"2018-09-13T15:10:28Z","pushed_at":"2018-09-16T13:33:26Z","git_url":"git://github.com/ichorid/py-ipv8.git","ssh_url":"git@github.com:ichorid/py-ipv8.git","clone_url":"https://github.com/ichorid/py-ipv8.git","svn_url":"https://github.com/ichorid/py-ipv8","homepage":"","size":743,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Tribler:master","ref":"master","sha":"61ebed8a84a64ab04476076813f3cf389d9c2590","user":{"login":"Tribler","id":2913489,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTM0ODk=","avatar_url":"https://avatars3.githubusercontent.com/u/2913489?v=4","gravatar_id":"","url":"https://api.github.com/users/Tribler","html_url":"https://github.com/Tribler","followers_url":"https://api.github.com/users/Tribler/followers","following_url":"https://api.github.com/users/Tribler/following{/other_user}","gists_url":"https://api.github.com/users/Tribler/gists{/gist_id}","starred_url":"https://api.github.com/users/Tribler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tribler/subscriptions","organizations_url":"https://api.github.com/users/Tribler/orgs","repos_url":"https://api.github.com/users/Tribler/repos","events_url":"https://api.github.com/users/Tribler/events{/privacy}","received_events_url":"https://api.github.com/users/Tribler/received_events","type":"Organization","site_admin":false},"repo":{"id":95567452,"node_id":"MDEwOlJlcG9zaXRvcnk5NTU2NzQ1Mg==","name":"py-ipv8","full_name":"Tribler/py-ipv8","private":false,"owner":{"login":"Tribler","id":2913489,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTM0ODk=","avatar_url":"https://avatars3.githubusercontent.com/u/2913489?v=4","gravatar_id":"","url":"https://api.github.com/users/Tribler","html_url":"https://github.com/Tribler","followers_url":"https://api.github.com/users/Tribler/followers","following_url":"https://api.github.com/users/Tribler/following{/other_user}","gists_url":"https://api.github.com/users/Tribler/gists{/gist_id}","starred_url":"https://api.github.com/users/Tribler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tribler/subscriptions","organizations_url":"https://api.github.com/users/Tribler/orgs","repos_url":"https://api.github.com/users/Tribler/repos","events_url":"https://api.github.com/users/Tribler/events{/privacy}","received_events_url":"https://api.github.com/users/Tribler/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Tribler/py-ipv8","description":"Python implementation of the IPv8 layer","fork":false,"url":"https://api.github.com/repos/Tribler/py-ipv8","forks_url":"https://api.github.com/repos/Tribler/py-ipv8/forks","keys_url":"https://api.github.com/repos/Tribler/py-ipv8/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tribler/py-ipv8/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tribler/py-ipv8/teams","hooks_url":"https://api.github.com/repos/Tribler/py-ipv8/hooks","issue_events_url":"https://api.github.com/repos/Tribler/py-ipv8/issues/events{/number}","events_url":"https://api.github.com/repos/Tribler/py-ipv8/events","assignees_url":"https://api.github.com/repos/Tribler/py-ipv8/assignees{/user}","branches_url":"https://api.github.com/repos/Tribler/py-ipv8/branches{/branch}","tags_url":"https://api.github.com/repos/Tribler/py-ipv8/tags","blobs_url":"https://api.github.com/repos/Tribler/py-ipv8/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tribler/py-ipv8/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tribler/py-ipv8/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tribler/py-ipv8/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tribler/py-ipv8/statuses/{sha}","languages_url":"https://api.github.com/repos/Tribler/py-ipv8/languages","stargazers_url":"https://api.github.com/repos/Tribler/py-ipv8/stargazers","contributors_url":"https://api.github.com/repos/Tribler/py-ipv8/contributors","subscribers_url":"https://api.github.com/repos/Tribler/py-ipv8/subscribers","subscription_url":"https://api.github.com/repos/Tribler/py-ipv8/subscription","commits_url":"https://api.github.com/repos/Tribler/py-ipv8/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tribler/py-ipv8/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tribler/py-ipv8/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tribler/py-ipv8/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tribler/py-ipv8/contents/{+path}","compare_url":"https://api.github.com/repos/Tribler/py-ipv8/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tribler/py-ipv8/merges","archive_url":"https://api.github.com/repos/Tribler/py-ipv8/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tribler/py-ipv8/downloads","issues_url":"https://api.github.com/repos/Tribler/py-ipv8/issues{/number}","pulls_url":"https://api.github.com/repos/Tribler/py-ipv8/pulls{/number}","milestones_url":"https://api.github.com/repos/Tribler/py-ipv8/milestones{/number}","notifications_url":"https://api.github.com/repos/Tribler/py-ipv8/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tribler/py-ipv8/labels{/name}","releases_url":"https://api.github.com/repos/Tribler/py-ipv8/releases{/id}","deployments_url":"https://api.github.com/repos/Tribler/py-ipv8/deployments","created_at":"2017-06-27T14:30:23Z","updated_at":"2018-09-15T12:53:01Z","pushed_at":"2018-09-16T13:48:27Z","git_url":"git://github.com/Tribler/py-ipv8.git","ssh_url":"git@github.com:Tribler/py-ipv8.git","clone_url":"https://github.com/Tribler/py-ipv8.git","svn_url":"https://github.com/Tribler/py-ipv8","homepage":"","size":737,"stargazers_count":13,"watchers_count":13,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":10,"open_issues":20,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Tribler/py-ipv8/pulls/266"},"html":{"href":"https://github.com/Tribler/py-ipv8/pull/266"},"issue":{"href":"https://api.github.com/repos/Tribler/py-ipv8/issues/266"},"comments":{"href":"https://api.github.com/repos/Tribler/py-ipv8/issues/266/comments"},"review_comments":{"href":"https://api.github.com/repos/Tribler/py-ipv8/pulls/266/comments"},"review_comment":{"href":"https://api.github.com/repos/Tribler/py-ipv8/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Tribler/py-ipv8/pulls/266/commits"},"statuses":{"href":"https://api.github.com/repos/Tribler/py-ipv8/statuses/f3184bcce2e31ecf4d010a64ad5ade21cce05a71"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ichorid","id":2509103,"node_id":"MDQ6VXNlcjI1MDkxMDM=","avatar_url":"https://avatars1.githubusercontent.com/u/2509103?v=4","gravatar_id":"","url":"https://api.github.com/users/ichorid","html_url":"https://github.com/ichorid","followers_url":"https://api.github.com/users/ichorid/followers","following_url":"https://api.github.com/users/ichorid/following{/other_user}","gists_url":"https://api.github.com/users/ichorid/gists{/gist_id}","starred_url":"https://api.github.com/users/ichorid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ichorid/subscriptions","organizations_url":"https://api.github.com/users/ichorid/orgs","repos_url":"https://api.github.com/users/ichorid/repos","events_url":"https://api.github.com/users/ichorid/events{/privacy}","received_events_url":"https://api.github.com/users/ichorid/received_events","type":"User","site_admin":false},"comments":8,"review_comments":18,"maintainer_can_modify":false,"commits":6,"additions":214,"deletions":319,"changed_files":36}}
{"actor":{"display_login":"ichorid"}}