{"action":"created","comment":{"url":"https://api.github.com/repos/monero-project/monero/pulls/comments/217304892","pull_request_review_id":154982494,"id":217304892,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzMwNDg5Mg==","diff_hunk":"@@ -1353,7 +1353,7 @@ namespace hw {\n         this->exchange();\n \n         //pseudoOuts\n-        if ((type == rct::RCTTypeSimple) || (type == rct::RCTTypeSimpleBulletproof)) {\n+        if (type == rct::RCTTypeSimple) {","path":"src/device/device_ledger.cpp","position":null,"original_position":5,"commit_id":"cd236aebca4251ef46cb0920e1f96ff018267829","original_commit_id":"cc3d3844870e8693950ecfd403a270af227a03ca","user":{"login":"moneromooo-monero","id":8851073,"node_id":"MDQ6VXNlcjg4NTEwNzM=","avatar_url":"https://avatars3.githubusercontent.com/u/8851073?v=4","gravatar_id":"","url":"https://api.github.com/users/moneromooo-monero","html_url":"https://github.com/moneromooo-monero","followers_url":"https://api.github.com/users/moneromooo-monero/followers","following_url":"https://api.github.com/users/moneromooo-monero/following{/other_user}","gists_url":"https://api.github.com/users/moneromooo-monero/gists{/gist_id}","starred_url":"https://api.github.com/users/moneromooo-monero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneromooo-monero/subscriptions","organizations_url":"https://api.github.com/users/moneromooo-monero/orgs","repos_url":"https://api.github.com/users/moneromooo-monero/repos","events_url":"https://api.github.com/users/moneromooo-monero/events{/privacy}","received_events_url":"https://api.github.com/users/moneromooo-monero/received_events","type":"User","site_admin":false},"body":"There are pseudoOuts. They're moved to the prunable part though.","created_at":"2018-09-13T08:42:46Z","updated_at":"2018-09-13T08:42:46Z","html_url":"https://github.com/monero-project/monero/pull/4251#discussion_r217304892","pull_request_url":"https://api.github.com/repos/monero-project/monero/pulls/4251","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/monero-project/monero/pulls/comments/217304892"},"html":{"href":"https://github.com/monero-project/monero/pull/4251#discussion_r217304892"},"pull_request":{"href":"https://api.github.com/repos/monero-project/monero/pulls/4251"}},"in_reply_to_id":216956273},"pull_request":{"url":"https://api.github.com/repos/monero-project/monero/pulls/4251","id":207896193,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3ODk2MTkz","html_url":"https://github.com/monero-project/monero/pull/4251","diff_url":"https://github.com/monero-project/monero/pull/4251.diff","patch_url":"https://github.com/monero-project/monero/pull/4251.patch","issue_url":"https://api.github.com/repos/monero-project/monero/issues/4251","number":4251,"state":"open","locked":false,"title":"Add bulletproof support","user":{"login":"cslashm","id":5478387,"node_id":"MDQ6VXNlcjU0NzgzODc=","avatar_url":"https://avatars3.githubusercontent.com/u/5478387?v=4","gravatar_id":"","url":"https://api.github.com/users/cslashm","html_url":"https://github.com/cslashm","followers_url":"https://api.github.com/users/cslashm/followers","following_url":"https://api.github.com/users/cslashm/following{/other_user}","gists_url":"https://api.github.com/users/cslashm/gists{/gist_id}","starred_url":"https://api.github.com/users/cslashm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cslashm/subscriptions","organizations_url":"https://api.github.com/users/cslashm/orgs","repos_url":"https://api.github.com/users/cslashm/repos","events_url":"https://api.github.com/users/cslashm/events{/privacy}","received_events_url":"https://api.github.com/users/cslashm/received_events","type":"User","site_admin":false},"body":"Transaction on testnet with V8.8 blocks seems to work.","created_at":"2018-08-13T07:54:28Z","updated_at":"2018-09-13T08:42:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"393a70dbae3e6b3e6f2cb39270bdf5d3fd08f8ed","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/monero-project/monero/pulls/4251/commits","review_comments_url":"https://api.github.com/repos/monero-project/monero/pulls/4251/comments","review_comment_url":"https://api.github.com/repos/monero-project/monero/pulls/comments{/number}","comments_url":"https://api.github.com/repos/monero-project/monero/issues/4251/comments","statuses_url":"https://api.github.com/repos/monero-project/monero/statuses/cd236aebca4251ef46cb0920e1f96ff018267829","head":{"label":"cslashm:NanoS-bulletproof","ref":"NanoS-bulletproof","sha":"cd236aebca4251ef46cb0920e1f96ff018267829","user":{"login":"cslashm","id":5478387,"node_id":"MDQ6VXNlcjU0NzgzODc=","avatar_url":"https://avatars3.githubusercontent.com/u/5478387?v=4","gravatar_id":"","url":"https://api.github.com/users/cslashm","html_url":"https://github.com/cslashm","followers_url":"https://api.github.com/users/cslashm/followers","following_url":"https://api.github.com/users/cslashm/following{/other_user}","gists_url":"https://api.github.com/users/cslashm/gists{/gist_id}","starred_url":"https://api.github.com/users/cslashm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cslashm/subscriptions","organizations_url":"https://api.github.com/users/cslashm/orgs","repos_url":"https://api.github.com/users/cslashm/repos","events_url":"https://api.github.com/users/cslashm/events{/privacy}","received_events_url":"https://api.github.com/users/cslashm/received_events","type":"User","site_admin":false},"repo":{"id":100196130,"node_id":"MDEwOlJlcG9zaXRvcnkxMDAxOTYxMzA=","name":"monero","full_name":"cslashm/monero","owner":{"login":"cslashm","id":5478387,"node_id":"MDQ6VXNlcjU0NzgzODc=","avatar_url":"https://avatars3.githubusercontent.com/u/5478387?v=4","gravatar_id":"","url":"https://api.github.com/users/cslashm","html_url":"https://github.com/cslashm","followers_url":"https://api.github.com/users/cslashm/followers","following_url":"https://api.github.com/users/cslashm/following{/other_user}","gists_url":"https://api.github.com/users/cslashm/gists{/gist_id}","starred_url":"https://api.github.com/users/cslashm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cslashm/subscriptions","organizations_url":"https://api.github.com/users/cslashm/orgs","repos_url":"https://api.github.com/users/cslashm/repos","events_url":"https://api.github.com/users/cslashm/events{/privacy}","received_events_url":"https://api.github.com/users/cslashm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cslashm/monero","description":"Monero: the secure, private, untraceable cryptocurrency","fork":true,"url":"https://api.github.com/repos/cslashm/monero","forks_url":"https://api.github.com/repos/cslashm/monero/forks","keys_url":"https://api.github.com/repos/cslashm/monero/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cslashm/monero/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cslashm/monero/teams","hooks_url":"https://api.github.com/repos/cslashm/monero/hooks","issue_events_url":"https://api.github.com/repos/cslashm/monero/issues/events{/number}","events_url":"https://api.github.com/repos/cslashm/monero/events","assignees_url":"https://api.github.com/repos/cslashm/monero/assignees{/user}","branches_url":"https://api.github.com/repos/cslashm/monero/branches{/branch}","tags_url":"https://api.github.com/repos/cslashm/monero/tags","blobs_url":"https://api.github.com/repos/cslashm/monero/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cslashm/monero/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cslashm/monero/git/refs{/sha}","trees_url":"https://api.github.com/repos/cslashm/monero/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cslashm/monero/statuses/{sha}","languages_url":"https://api.github.com/repos/cslashm/monero/languages","stargazers_url":"https://api.github.com/repos/cslashm/monero/stargazers","contributors_url":"https://api.github.com/repos/cslashm/monero/contributors","subscribers_url":"https://api.github.com/repos/cslashm/monero/subscribers","subscription_url":"https://api.github.com/repos/cslashm/monero/subscription","commits_url":"https://api.github.com/repos/cslashm/monero/commits{/sha}","git_commits_url":"https://api.github.com/repos/cslashm/monero/git/commits{/sha}","comments_url":"https://api.github.com/repos/cslashm/monero/comments{/number}","issue_comment_url":"https://api.github.com/repos/cslashm/monero/issues/comments{/number}","contents_url":"https://api.github.com/repos/cslashm/monero/contents/{+path}","compare_url":"https://api.github.com/repos/cslashm/monero/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cslashm/monero/merges","archive_url":"https://api.github.com/repos/cslashm/monero/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cslashm/monero/downloads","issues_url":"https://api.github.com/repos/cslashm/monero/issues{/number}","pulls_url":"https://api.github.com/repos/cslashm/monero/pulls{/number}","milestones_url":"https://api.github.com/repos/cslashm/monero/milestones{/number}","notifications_url":"https://api.github.com/repos/cslashm/monero/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cslashm/monero/labels{/name}","releases_url":"https://api.github.com/repos/cslashm/monero/releases{/id}","deployments_url":"https://api.github.com/repos/cslashm/monero/deployments","created_at":"2017-08-13T18:21:32Z","updated_at":"2018-09-12T08:51:19Z","pushed_at":"2018-09-13T07:55:26Z","git_url":"git://github.com/cslashm/monero.git","ssh_url":"git@github.com:cslashm/monero.git","clone_url":"https://github.com/cslashm/monero.git","svn_url":"https://github.com/cslashm/monero","homepage":"https://getmonero.org","size":143453,"stargazers_count":8,"watchers_count":8,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":8,"default_branch":"master"}},"base":{"label":"monero-project:master","ref":"master","sha":"11dbfbc5b3da6a0ca0c969c8aa6a30fafb04b819","user":{"login":"monero-project","id":7450663,"node_id":"MDQ6VXNlcjc0NTA2NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/7450663?v=4","gravatar_id":"","url":"https://api.github.com/users/monero-project","html_url":"https://github.com/monero-project","followers_url":"https://api.github.com/users/monero-project/followers","following_url":"https://api.github.com/users/monero-project/following{/other_user}","gists_url":"https://api.github.com/users/monero-project/gists{/gist_id}","starred_url":"https://api.github.com/users/monero-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monero-project/subscriptions","organizations_url":"https://api.github.com/users/monero-project/orgs","repos_url":"https://api.github.com/users/monero-project/repos","events_url":"https://api.github.com/users/monero-project/events{/privacy}","received_events_url":"https://api.github.com/users/monero-project/received_events","type":"User","site_admin":false},"repo":{"id":19316619,"node_id":"MDEwOlJlcG9zaXRvcnkxOTMxNjYxOQ==","name":"monero","full_name":"monero-project/monero","owner":{"login":"monero-project","id":7450663,"node_id":"MDQ6VXNlcjc0NTA2NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/7450663?v=4","gravatar_id":"","url":"https://api.github.com/users/monero-project","html_url":"https://github.com/monero-project","followers_url":"https://api.github.com/users/monero-project/followers","following_url":"https://api.github.com/users/monero-project/following{/other_user}","gists_url":"https://api.github.com/users/monero-project/gists{/gist_id}","starred_url":"https://api.github.com/users/monero-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monero-project/subscriptions","organizations_url":"https://api.github.com/users/monero-project/orgs","repos_url":"https://api.github.com/users/monero-project/repos","events_url":"https://api.github.com/users/monero-project/events{/privacy}","received_events_url":"https://api.github.com/users/monero-project/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/monero-project/monero","description":"Monero: the secure, private, untraceable cryptocurrency","fork":false,"url":"https://api.github.com/repos/monero-project/monero","forks_url":"https://api.github.com/repos/monero-project/monero/forks","keys_url":"https://api.github.com/repos/monero-project/monero/keys{/key_id}","collaborators_url":"https://api.github.com/repos/monero-project/monero/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/monero-project/monero/teams","hooks_url":"https://api.github.com/repos/monero-project/monero/hooks","issue_events_url":"https://api.github.com/repos/monero-project/monero/issues/events{/number}","events_url":"https://api.github.com/repos/monero-project/monero/events","assignees_url":"https://api.github.com/repos/monero-project/monero/assignees{/user}","branches_url":"https://api.github.com/repos/monero-project/monero/branches{/branch}","tags_url":"https://api.github.com/repos/monero-project/monero/tags","blobs_url":"https://api.github.com/repos/monero-project/monero/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/monero-project/monero/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/monero-project/monero/git/refs{/sha}","trees_url":"https://api.github.com/repos/monero-project/monero/git/trees{/sha}","statuses_url":"https://api.github.com/repos/monero-project/monero/statuses/{sha}","languages_url":"https://api.github.com/repos/monero-project/monero/languages","stargazers_url":"https://api.github.com/repos/monero-project/monero/stargazers","contributors_url":"https://api.github.com/repos/monero-project/monero/contributors","subscribers_url":"https://api.github.com/repos/monero-project/monero/subscribers","subscription_url":"https://api.github.com/repos/monero-project/monero/subscription","commits_url":"https://api.github.com/repos/monero-project/monero/commits{/sha}","git_commits_url":"https://api.github.com/repos/monero-project/monero/git/commits{/sha}","comments_url":"https://api.github.com/repos/monero-project/monero/comments{/number}","issue_comment_url":"https://api.github.com/repos/monero-project/monero/issues/comments{/number}","contents_url":"https://api.github.com/repos/monero-project/monero/contents/{+path}","compare_url":"https://api.github.com/repos/monero-project/monero/compare/{base}...{head}","merges_url":"https://api.github.com/repos/monero-project/monero/merges","archive_url":"https://api.github.com/repos/monero-project/monero/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/monero-project/monero/downloads","issues_url":"https://api.github.com/repos/monero-project/monero/issues{/number}","pulls_url":"https://api.github.com/repos/monero-project/monero/pulls{/number}","milestones_url":"https://api.github.com/repos/monero-project/monero/milestones{/number}","notifications_url":"https://api.github.com/repos/monero-project/monero/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/monero-project/monero/labels{/name}","releases_url":"https://api.github.com/repos/monero-project/monero/releases{/id}","deployments_url":"https://api.github.com/repos/monero-project/monero/deployments","created_at":"2014-04-30T14:38:28Z","updated_at":"2018-09-13T07:09:55Z","pushed_at":"2018-09-13T07:55:29Z","git_url":"git://github.com/monero-project/monero.git","ssh_url":"git@github.com:monero-project/monero.git","clone_url":"https://github.com/monero-project/monero.git","svn_url":"https://github.com/monero-project/monero","homepage":"https://getmonero.org","size":143238,"stargazers_count":3256,"watchers_count":3256,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1655,"mirror_url":null,"archived":false,"open_issues_count":311,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1655,"open_issues":311,"watchers":3256,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/monero-project/monero/pulls/4251"},"html":{"href":"https://github.com/monero-project/monero/pull/4251"},"issue":{"href":"https://api.github.com/repos/monero-project/monero/issues/4251"},"comments":{"href":"https://api.github.com/repos/monero-project/monero/issues/4251/comments"},"review_comments":{"href":"https://api.github.com/repos/monero-project/monero/pulls/4251/comments"},"review_comment":{"href":"https://api.github.com/repos/monero-project/monero/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/monero-project/monero/pulls/4251/commits"},"statuses":{"href":"https://api.github.com/repos/monero-project/monero/statuses/cd236aebca4251ef46cb0920e1f96ff018267829"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"moneromooo-monero"}}