{"action":"closed","number":1019,"pull_request":{"url":"https://api.github.com/repos/twisted/twisted/pulls/1019","id":192179894,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMTc5ODk0","html_url":"https://github.com/twisted/twisted/pull/1019","diff_url":"https://github.com/twisted/twisted/pull/1019.diff","patch_url":"https://github.com/twisted/twisted/pull/1019.patch","issue_url":"https://api.github.com/repos/twisted/twisted/issues/1019","number":1019,"state":"closed","locked":false,"title":"7927 unhandled error tb","user":{"login":"jlitzingerdev","id":1496650,"node_id":"MDQ6VXNlcjE0OTY2NTA=","avatar_url":"https://avatars0.githubusercontent.com/u/1496650?v=4","gravatar_id":"","url":"https://api.github.com/users/jlitzingerdev","html_url":"https://github.com/jlitzingerdev","followers_url":"https://api.github.com/users/jlitzingerdev/followers","following_url":"https://api.github.com/users/jlitzingerdev/following{/other_user}","gists_url":"https://api.github.com/users/jlitzingerdev/gists{/gist_id}","starred_url":"https://api.github.com/users/jlitzingerdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlitzingerdev/subscriptions","organizations_url":"https://api.github.com/users/jlitzingerdev/orgs","repos_url":"https://api.github.com/users/jlitzingerdev/repos","events_url":"https://api.github.com/users/jlitzingerdev/events{/privacy}","received_events_url":"https://api.github.com/users/jlitzingerdev/received_events","type":"User","site_admin":false},"body":"This changeset addresses ticket 7927 [1].  Much of this code started with a PR for ticket 9333 [2], now closed as a duplicate.  In the interest of preserving the review comments and feedback, the original commit changes and messages are preserved, while the content has been rebased onto trunk.  I'm happy to clean the history up as needed.\r\n\r\nAnother key part of this is the creation of a new API instead of modifying formatEvent() directly.  The rationale is that modifying formatEvent will likely result in duplicate tracebacks for any users who have made changes to append tracebacks to the exising result of formatEvent.\r\n\r\n[1] https://twistedmatrix.com/trac/ticket/7927\r\n[2] https://github.com/twisted/twisted/pull/939","created_at":"2018-06-02T04:58:01Z","updated_at":"2018-06-03T21:27:07Z","closed_at":"2018-06-03T21:27:07Z","merged_at":null,"merge_commit_sha":"deca53ed8db9142b497ba9e26911ba7d1a7f6ad3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/twisted/twisted/pulls/1019/commits","review_comments_url":"https://api.github.com/repos/twisted/twisted/pulls/1019/comments","review_comment_url":"https://api.github.com/repos/twisted/twisted/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twisted/twisted/issues/1019/comments","statuses_url":"https://api.github.com/repos/twisted/twisted/statuses/14cb05d7e8c59e769b3924f36bc4bcb0d9917240","head":{"label":"jlitzingerdev:7927-unhandled-error-tb","ref":"7927-unhandled-error-tb","sha":"14cb05d7e8c59e769b3924f36bc4bcb0d9917240","user":{"login":"jlitzingerdev","id":1496650,"node_id":"MDQ6VXNlcjE0OTY2NTA=","avatar_url":"https://avatars0.githubusercontent.com/u/1496650?v=4","gravatar_id":"","url":"https://api.github.com/users/jlitzingerdev","html_url":"https://github.com/jlitzingerdev","followers_url":"https://api.github.com/users/jlitzingerdev/followers","following_url":"https://api.github.com/users/jlitzingerdev/following{/other_user}","gists_url":"https://api.github.com/users/jlitzingerdev/gists{/gist_id}","starred_url":"https://api.github.com/users/jlitzingerdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlitzingerdev/subscriptions","organizations_url":"https://api.github.com/users/jlitzingerdev/orgs","repos_url":"https://api.github.com/users/jlitzingerdev/repos","events_url":"https://api.github.com/users/jlitzingerdev/events{/privacy}","received_events_url":"https://api.github.com/users/jlitzingerdev/received_events","type":"User","site_admin":false},"repo":{"id":91534675,"node_id":"MDEwOlJlcG9zaXRvcnk5MTUzNDY3NQ==","name":"twisted","full_name":"jlitzingerdev/twisted","owner":{"login":"jlitzingerdev","id":1496650,"node_id":"MDQ6VXNlcjE0OTY2NTA=","avatar_url":"https://avatars0.githubusercontent.com/u/1496650?v=4","gravatar_id":"","url":"https://api.github.com/users/jlitzingerdev","html_url":"https://github.com/jlitzingerdev","followers_url":"https://api.github.com/users/jlitzingerdev/followers","following_url":"https://api.github.com/users/jlitzingerdev/following{/other_user}","gists_url":"https://api.github.com/users/jlitzingerdev/gists{/gist_id}","starred_url":"https://api.github.com/users/jlitzingerdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlitzingerdev/subscriptions","organizations_url":"https://api.github.com/users/jlitzingerdev/orgs","repos_url":"https://api.github.com/users/jlitzingerdev/repos","events_url":"https://api.github.com/users/jlitzingerdev/events{/privacy}","received_events_url":"https://api.github.com/users/jlitzingerdev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jlitzingerdev/twisted","description":"Event-driven networking engine written in Python.","fork":true,"url":"https://api.github.com/repos/jlitzingerdev/twisted","forks_url":"https://api.github.com/repos/jlitzingerdev/twisted/forks","keys_url":"https://api.github.com/repos/jlitzingerdev/twisted/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jlitzingerdev/twisted/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jlitzingerdev/twisted/teams","hooks_url":"https://api.github.com/repos/jlitzingerdev/twisted/hooks","issue_events_url":"https://api.github.com/repos/jlitzingerdev/twisted/issues/events{/number}","events_url":"https://api.github.com/repos/jlitzingerdev/twisted/events","assignees_url":"https://api.github.com/repos/jlitzingerdev/twisted/assignees{/user}","branches_url":"https://api.github.com/repos/jlitzingerdev/twisted/branches{/branch}","tags_url":"https://api.github.com/repos/jlitzingerdev/twisted/tags","blobs_url":"https://api.github.com/repos/jlitzingerdev/twisted/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jlitzingerdev/twisted/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jlitzingerdev/twisted/git/refs{/sha}","trees_url":"https://api.github.com/repos/jlitzingerdev/twisted/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jlitzingerdev/twisted/statuses/{sha}","languages_url":"https://api.github.com/repos/jlitzingerdev/twisted/languages","stargazers_url":"https://api.github.com/repos/jlitzingerdev/twisted/stargazers","contributors_url":"https://api.github.com/repos/jlitzingerdev/twisted/contributors","subscribers_url":"https://api.github.com/repos/jlitzingerdev/twisted/subscribers","subscription_url":"https://api.github.com/repos/jlitzingerdev/twisted/subscription","commits_url":"https://api.github.com/repos/jlitzingerdev/twisted/commits{/sha}","git_commits_url":"https://api.github.com/repos/jlitzingerdev/twisted/git/commits{/sha}","comments_url":"https://api.github.com/repos/jlitzingerdev/twisted/comments{/number}","issue_comment_url":"https://api.github.com/repos/jlitzingerdev/twisted/issues/comments{/number}","contents_url":"https://api.github.com/repos/jlitzingerdev/twisted/contents/{+path}","compare_url":"https://api.github.com/repos/jlitzingerdev/twisted/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jlitzingerdev/twisted/merges","archive_url":"https://api.github.com/repos/jlitzingerdev/twisted/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jlitzingerdev/twisted/downloads","issues_url":"https://api.github.com/repos/jlitzingerdev/twisted/issues{/number}","pulls_url":"https://api.github.com/repos/jlitzingerdev/twisted/pulls{/number}","milestones_url":"https://api.github.com/repos/jlitzingerdev/twisted/milestones{/number}","notifications_url":"https://api.github.com/repos/jlitzingerdev/twisted/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jlitzingerdev/twisted/labels{/name}","releases_url":"https://api.github.com/repos/jlitzingerdev/twisted/releases{/id}","deployments_url":"https://api.github.com/repos/jlitzingerdev/twisted/deployments","created_at":"2017-05-17T04:50:17Z","updated_at":"2018-06-03T21:11:25Z","pushed_at":"2018-06-03T21:23:54Z","git_url":"git://github.com/jlitzingerdev/twisted.git","ssh_url":"git@github.com:jlitzingerdev/twisted.git","clone_url":"https://github.com/jlitzingerdev/twisted.git","svn_url":"https://github.com/jlitzingerdev/twisted","homepage":"https://www.twistedmatrix.com","size":57304,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"twisted:trunk","ref":"trunk","sha":"2e7b403c03e9b9b891a5eb36297e494f541d5d6a","user":{"login":"twisted","id":716546,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcxNjU0Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/716546?v=4","gravatar_id":"","url":"https://api.github.com/users/twisted","html_url":"https://github.com/twisted","followers_url":"https://api.github.com/users/twisted/followers","following_url":"https://api.github.com/users/twisted/following{/other_user}","gists_url":"https://api.github.com/users/twisted/gists{/gist_id}","starred_url":"https://api.github.com/users/twisted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twisted/subscriptions","organizations_url":"https://api.github.com/users/twisted/orgs","repos_url":"https://api.github.com/users/twisted/repos","events_url":"https://api.github.com/users/twisted/events{/privacy}","received_events_url":"https://api.github.com/users/twisted/received_events","type":"Organization","site_admin":false},"repo":{"id":1985358,"node_id":"MDEwOlJlcG9zaXRvcnkxOTg1MzU4","name":"twisted","full_name":"twisted/twisted","owner":{"login":"twisted","id":716546,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcxNjU0Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/716546?v=4","gravatar_id":"","url":"https://api.github.com/users/twisted","html_url":"https://github.com/twisted","followers_url":"https://api.github.com/users/twisted/followers","following_url":"https://api.github.com/users/twisted/following{/other_user}","gists_url":"https://api.github.com/users/twisted/gists{/gist_id}","starred_url":"https://api.github.com/users/twisted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twisted/subscriptions","organizations_url":"https://api.github.com/users/twisted/orgs","repos_url":"https://api.github.com/users/twisted/repos","events_url":"https://api.github.com/users/twisted/events{/privacy}","received_events_url":"https://api.github.com/users/twisted/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twisted/twisted","description":"Event-driven networking engine written in Python.","fork":false,"url":"https://api.github.com/repos/twisted/twisted","forks_url":"https://api.github.com/repos/twisted/twisted/forks","keys_url":"https://api.github.com/repos/twisted/twisted/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twisted/twisted/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twisted/twisted/teams","hooks_url":"https://api.github.com/repos/twisted/twisted/hooks","issue_events_url":"https://api.github.com/repos/twisted/twisted/issues/events{/number}","events_url":"https://api.github.com/repos/twisted/twisted/events","assignees_url":"https://api.github.com/repos/twisted/twisted/assignees{/user}","branches_url":"https://api.github.com/repos/twisted/twisted/branches{/branch}","tags_url":"https://api.github.com/repos/twisted/twisted/tags","blobs_url":"https://api.github.com/repos/twisted/twisted/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twisted/twisted/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twisted/twisted/git/refs{/sha}","trees_url":"https://api.github.com/repos/twisted/twisted/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twisted/twisted/statuses/{sha}","languages_url":"https://api.github.com/repos/twisted/twisted/languages","stargazers_url":"https://api.github.com/repos/twisted/twisted/stargazers","contributors_url":"https://api.github.com/repos/twisted/twisted/contributors","subscribers_url":"https://api.github.com/repos/twisted/twisted/subscribers","subscription_url":"https://api.github.com/repos/twisted/twisted/subscription","commits_url":"https://api.github.com/repos/twisted/twisted/commits{/sha}","git_commits_url":"https://api.github.com/repos/twisted/twisted/git/commits{/sha}","comments_url":"https://api.github.com/repos/twisted/twisted/comments{/number}","issue_comment_url":"https://api.github.com/repos/twisted/twisted/issues/comments{/number}","contents_url":"https://api.github.com/repos/twisted/twisted/contents/{+path}","compare_url":"https://api.github.com/repos/twisted/twisted/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twisted/twisted/merges","archive_url":"https://api.github.com/repos/twisted/twisted/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twisted/twisted/downloads","issues_url":"https://api.github.com/repos/twisted/twisted/issues{/number}","pulls_url":"https://api.github.com/repos/twisted/twisted/pulls{/number}","milestones_url":"https://api.github.com/repos/twisted/twisted/milestones{/number}","notifications_url":"https://api.github.com/repos/twisted/twisted/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twisted/twisted/labels{/name}","releases_url":"https://api.github.com/repos/twisted/twisted/releases{/id}","deployments_url":"https://api.github.com/repos/twisted/twisted/deployments","created_at":"2011-07-01T20:40:42Z","updated_at":"2018-06-03T17:05:04Z","pushed_at":"2018-06-03T21:26:56Z","git_url":"git://github.com/twisted/twisted.git","ssh_url":"git@github.com:twisted/twisted.git","clone_url":"https://github.com/twisted/twisted.git","svn_url":"https://github.com/twisted/twisted","homepage":"https://www.twistedmatrix.com","size":57998,"stargazers_count":2689,"watchers_count":2689,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":751,"mirror_url":null,"archived":false,"open_issues_count":85,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":751,"open_issues":85,"watchers":2689,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/twisted/twisted/pulls/1019"},"html":{"href":"https://github.com/twisted/twisted/pull/1019"},"issue":{"href":"https://api.github.com/repos/twisted/twisted/issues/1019"},"comments":{"href":"https://api.github.com/repos/twisted/twisted/issues/1019/comments"},"review_comments":{"href":"https://api.github.com/repos/twisted/twisted/pulls/1019/comments"},"review_comment":{"href":"https://api.github.com/repos/twisted/twisted/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twisted/twisted/pulls/1019/commits"},"statuses":{"href":"https://api.github.com/repos/twisted/twisted/statuses/14cb05d7e8c59e769b3924f36bc4bcb0d9917240"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":14,"additions":235,"deletions":3,"changed_files":6}}
{"actor":{"display_login":"jlitzingerdev"}}