{"action":"created","issue":{"url":"https://api.github.com/repos/supercollider/supercollider/issues/4075","repository_url":"https://api.github.com/repos/supercollider/supercollider","labels_url":"https://api.github.com/repos/supercollider/supercollider/issues/4075/labels{/name}","comments_url":"https://api.github.com/repos/supercollider/supercollider/issues/4075/comments","events_url":"https://api.github.com/repos/supercollider/supercollider/issues/4075/events","html_url":"https://github.com/supercollider/supercollider/issues/4075","id":362583207,"node_id":"MDU6SXNzdWUzNjI1ODMyMDc=","number":4075,"title":"Impulse UGEN sets the presample to the wrong value when frequency equals zero","user":{"login":"cianoc","id":355604,"node_id":"MDQ6VXNlcjM1NTYwNA==","avatar_url":"https://avatars1.githubusercontent.com/u/355604?v=4","gravatar_id":"","url":"https://api.github.com/users/cianoc","html_url":"https://github.com/cianoc","followers_url":"https://api.github.com/users/cianoc/followers","following_url":"https://api.github.com/users/cianoc/following{/other_user}","gists_url":"https://api.github.com/users/cianoc/gists{/gist_id}","starred_url":"https://api.github.com/users/cianoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cianoc/subscriptions","organizations_url":"https://api.github.com/users/cianoc/orgs","repos_url":"https://api.github.com/users/cianoc/repos","events_url":"https://api.github.com/users/cianoc/events{/privacy}","received_events_url":"https://api.github.com/users/cianoc/received_events","type":"User","site_admin":false},"labels":[{"id":4413795,"node_id":"MDU6TGFiZWw0NDEzNzk1","url":"https://api.github.com/repos/supercollider/supercollider/labels/bug","name":"bug","color":"fc2929","default":true},{"id":11974270,"node_id":"MDU6TGFiZWwxMTk3NDI3MA==","url":"https://api.github.com/repos/supercollider/supercollider/labels/comp:%20server%20plugins","name":"comp: server plugins","color":"F4FF75","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-09-21T11:56:52Z","updated_at":"2018-09-25T18:14:46Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"<!--- Hi, and thanks for contributing! -->\r\n\r\n<!--- Before opening a new issue, please search our existing issues to see if anyone else has had the-->\r\n<!--- same issue as you. Make sure to provide a general summary of the issue in the Title above! -->\r\n\r\nEnvironment\r\n-----------\r\n\r\n* SuperCollider 3.93\r\n* OSX 10.13.6\r\n\r\nSteps to reproduce (for bugs)\r\n-----------------------------\r\n\r\n\r\n\r\n```supercollider\r\n(\r\n{\r\n  var sig1 = EnvGen.kr(Env.perc(0.01, 0.04), 1) * SinOsc.ar(440);\r\n  var sig2 = EnvGen.kr(Env.perc(0.01, 0.04), Impulse.kr(0)) * SinOsc.ar(440);\r\n  [sig1,sig2]\r\n}.plot)\r\n```\r\n\r\n**Graph:**\r\n![screen shot 2018-09-21 at 7 54 12 am](https://user-images.githubusercontent.com/355604/45879761-aca23380-bd73-11e8-9efb-dc6e15cfdc2c.png)\r\n\r\n------------------------\r\n\r\n\r\nExpected Behavior\r\n-----------------\r\nThe two audio signals should be identical.\r\n\r\nCurrent Behavior\r\n----------------\r\nCurrently the envelope triggered by Impulse.kr is a control period later.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/supercollider/supercollider/issues/comments/424447265","html_url":"https://github.com/supercollider/supercollider/issues/4075#issuecomment-424447265","issue_url":"https://api.github.com/repos/supercollider/supercollider/issues/4075","id":424447265,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNDQ0NzI2NQ==","user":{"login":"telephon","id":1810559,"node_id":"MDQ6VXNlcjE4MTA1NTk=","avatar_url":"https://avatars1.githubusercontent.com/u/1810559?v=4","gravatar_id":"","url":"https://api.github.com/users/telephon","html_url":"https://github.com/telephon","followers_url":"https://api.github.com/users/telephon/followers","following_url":"https://api.github.com/users/telephon/following{/other_user}","gists_url":"https://api.github.com/users/telephon/gists{/gist_id}","starred_url":"https://api.github.com/users/telephon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telephon/subscriptions","organizations_url":"https://api.github.com/users/telephon/orgs","repos_url":"https://api.github.com/users/telephon/repos","events_url":"https://api.github.com/users/telephon/events{/privacy}","received_events_url":"https://api.github.com/users/telephon/received_events","type":"User","site_admin":false},"created_at":"2018-09-25T18:14:46Z","updated_at":"2018-09-25T18:14:46Z","author_association":"MEMBER","body":"It is a complicated discussion and I am not sure I can make up my mind easily.  Closest to a conclusion seemed:\r\n\r\n>The simplest solution is that the UGen expecting triggers inits prevTrig to 0 in the Ctor.\r\n\r\nIf I understand correctly, the problem *should* be that `EnvGen` doesn't initialize its previous gate value to zero? If you could check this, that would be great. If it turns out not to be the case, then we have to rethink the trigger semantics.\r\n\r\n\r\n"}}
{"actor":{"display_login":"telephon"}}