{"action":"created","comment":{"url":"https://api.github.com/repos/coq/coq/pulls/comments/200104382","pull_request_review_id":134352602,"id":200104382,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDEwNDM4Mg==","diff_hunk":"@@ -156,7 +156,10 @@ endif\n \n MAKE_OPTS := --warn-undefined-variable --no-builtin-rules\n \n-submake: alienclean\n+bin:\n+\tmkdir bin\n+\n+submake: alienclean | bin","path":"Makefile","position":8,"original_position":8,"commit_id":"cd45eda96c0026fc8962ba51b3e3750be946b96f","original_commit_id":"cd45eda96c0026fc8962ba51b3e3750be946b96f","user":{"login":"ejgallego","id":7192257,"node_id":"MDQ6VXNlcjcxOTIyNTc=","avatar_url":"https://avatars2.githubusercontent.com/u/7192257?v=4","gravatar_id":"","url":"https://api.github.com/users/ejgallego","html_url":"https://github.com/ejgallego","followers_url":"https://api.github.com/users/ejgallego/followers","following_url":"https://api.github.com/users/ejgallego/following{/other_user}","gists_url":"https://api.github.com/users/ejgallego/gists{/gist_id}","starred_url":"https://api.github.com/users/ejgallego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejgallego/subscriptions","organizations_url":"https://api.github.com/users/ejgallego/orgs","repos_url":"https://api.github.com/users/ejgallego/repos","events_url":"https://api.github.com/users/ejgallego/events{/privacy}","received_events_url":"https://api.github.com/users/ejgallego/received_events","type":"User","site_admin":false},"body":"Umm, I guess the rules generating the binaries should depend on the `bin` target? Anyways I am not an expert in `Makefile`.\r\n\r\nAlso, shouldn't this use `mkdir -p bin`?","created_at":"2018-07-04T12:00:27Z","updated_at":"2018-07-04T12:00:28Z","html_url":"https://github.com/coq/coq/pull/7994#discussion_r200104382","pull_request_url":"https://api.github.com/repos/coq/coq/pulls/7994","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/coq/coq/pulls/comments/200104382"},"html":{"href":"https://github.com/coq/coq/pull/7994#discussion_r200104382"},"pull_request":{"href":"https://api.github.com/repos/coq/coq/pulls/7994"}}},"pull_request":{"url":"https://api.github.com/repos/coq/coq/pulls/7994","id":199223861,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MjIzODYx","html_url":"https://github.com/coq/coq/pull/7994","diff_url":"https://github.com/coq/coq/pull/7994.diff","patch_url":"https://github.com/coq/coq/pull/7994.patch","issue_url":"https://api.github.com/repos/coq/coq/issues/7994","number":7994,"state":"open","locked":false,"title":"Make bin/ in makefile, not configure.","user":{"login":"SkySkimmer","id":2461932,"node_id":"MDQ6VXNlcjI0NjE5MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/2461932?v=4","gravatar_id":"","url":"https://api.github.com/users/SkySkimmer","html_url":"https://github.com/SkySkimmer","followers_url":"https://api.github.com/users/SkySkimmer/followers","following_url":"https://api.github.com/users/SkySkimmer/following{/other_user}","gists_url":"https://api.github.com/users/SkySkimmer/gists{/gist_id}","starred_url":"https://api.github.com/users/SkySkimmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkySkimmer/subscriptions","organizations_url":"https://api.github.com/users/SkySkimmer/orgs","repos_url":"https://api.github.com/users/SkySkimmer/repos","events_url":"https://api.github.com/users/SkySkimmer/events{/privacy}","received_events_url":"https://api.github.com/users/SkySkimmer/received_events","type":"User","site_admin":false},"body":"See https://github.com/coq/coq/pull/7984#issuecomment-402315772 for context.","created_at":"2018-07-04T11:42:18Z","updated_at":"2018-07-04T12:00:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8f2fb91abddf77b633e5124074e40134f94b370c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"gares","id":1013846,"node_id":"MDQ6VXNlcjEwMTM4NDY=","avatar_url":"https://avatars2.githubusercontent.com/u/1013846?v=4","gravatar_id":"","url":"https://api.github.com/users/gares","html_url":"https://github.com/gares","followers_url":"https://api.github.com/users/gares/followers","following_url":"https://api.github.com/users/gares/following{/other_user}","gists_url":"https://api.github.com/users/gares/gists{/gist_id}","starred_url":"https://api.github.com/users/gares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gares/subscriptions","organizations_url":"https://api.github.com/users/gares/orgs","repos_url":"https://api.github.com/users/gares/repos","events_url":"https://api.github.com/users/gares/events{/privacy}","received_events_url":"https://api.github.com/users/gares/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":649047024,"node_id":"MDU6TGFiZWw2NDkwNDcwMjQ=","url":"https://api.github.com/repos/coq/coq/labels/kind:%20infrastructure","name":"kind: infrastructure","color":"006b75","default":false},{"id":941165222,"node_id":"MDU6TGFiZWw5NDExNjUyMjI=","url":"https://api.github.com/repos/coq/coq/labels/part:%20build","name":"part: build","color":"dddddd","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/coq/coq/pulls/7994/commits","review_comments_url":"https://api.github.com/repos/coq/coq/pulls/7994/comments","review_comment_url":"https://api.github.com/repos/coq/coq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coq/coq/issues/7994/comments","statuses_url":"https://api.github.com/repos/coq/coq/statuses/cd45eda96c0026fc8962ba51b3e3750be946b96f","head":{"label":"SkySkimmer:configure-nobin","ref":"configure-nobin","sha":"cd45eda96c0026fc8962ba51b3e3750be946b96f","user":{"login":"SkySkimmer","id":2461932,"node_id":"MDQ6VXNlcjI0NjE5MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/2461932?v=4","gravatar_id":"","url":"https://api.github.com/users/SkySkimmer","html_url":"https://github.com/SkySkimmer","followers_url":"https://api.github.com/users/SkySkimmer/followers","following_url":"https://api.github.com/users/SkySkimmer/following{/other_user}","gists_url":"https://api.github.com/users/SkySkimmer/gists{/gist_id}","starred_url":"https://api.github.com/users/SkySkimmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkySkimmer/subscriptions","organizations_url":"https://api.github.com/users/SkySkimmer/orgs","repos_url":"https://api.github.com/users/SkySkimmer/repos","events_url":"https://api.github.com/users/SkySkimmer/events{/privacy}","received_events_url":"https://api.github.com/users/SkySkimmer/received_events","type":"User","site_admin":false},"repo":{"id":76260922,"node_id":"MDEwOlJlcG9zaXRvcnk3NjI2MDkyMg==","name":"coq","full_name":"SkySkimmer/coq","owner":{"login":"SkySkimmer","id":2461932,"node_id":"MDQ6VXNlcjI0NjE5MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/2461932?v=4","gravatar_id":"","url":"https://api.github.com/users/SkySkimmer","html_url":"https://github.com/SkySkimmer","followers_url":"https://api.github.com/users/SkySkimmer/followers","following_url":"https://api.github.com/users/SkySkimmer/following{/other_user}","gists_url":"https://api.github.com/users/SkySkimmer/gists{/gist_id}","starred_url":"https://api.github.com/users/SkySkimmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkySkimmer/subscriptions","organizations_url":"https://api.github.com/users/SkySkimmer/orgs","repos_url":"https://api.github.com/users/SkySkimmer/repos","events_url":"https://api.github.com/users/SkySkimmer/events{/privacy}","received_events_url":"https://api.github.com/users/SkySkimmer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SkySkimmer/coq","description":"Coq is a formal proof management system. It provides a formal language to write mathematical definitions, executable algorithms and theorems together with an environment for semi-interactive development of machine-checked proofs. ","fork":true,"url":"https://api.github.com/repos/SkySkimmer/coq","forks_url":"https://api.github.com/repos/SkySkimmer/coq/forks","keys_url":"https://api.github.com/repos/SkySkimmer/coq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SkySkimmer/coq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SkySkimmer/coq/teams","hooks_url":"https://api.github.com/repos/SkySkimmer/coq/hooks","issue_events_url":"https://api.github.com/repos/SkySkimmer/coq/issues/events{/number}","events_url":"https://api.github.com/repos/SkySkimmer/coq/events","assignees_url":"https://api.github.com/repos/SkySkimmer/coq/assignees{/user}","branches_url":"https://api.github.com/repos/SkySkimmer/coq/branches{/branch}","tags_url":"https://api.github.com/repos/SkySkimmer/coq/tags","blobs_url":"https://api.github.com/repos/SkySkimmer/coq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SkySkimmer/coq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SkySkimmer/coq/git/refs{/sha}","trees_url":"https://api.github.com/repos/SkySkimmer/coq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SkySkimmer/coq/statuses/{sha}","languages_url":"https://api.github.com/repos/SkySkimmer/coq/languages","stargazers_url":"https://api.github.com/repos/SkySkimmer/coq/stargazers","contributors_url":"https://api.github.com/repos/SkySkimmer/coq/contributors","subscribers_url":"https://api.github.com/repos/SkySkimmer/coq/subscribers","subscription_url":"https://api.github.com/repos/SkySkimmer/coq/subscription","commits_url":"https://api.github.com/repos/SkySkimmer/coq/commits{/sha}","git_commits_url":"https://api.github.com/repos/SkySkimmer/coq/git/commits{/sha}","comments_url":"https://api.github.com/repos/SkySkimmer/coq/comments{/number}","issue_comment_url":"https://api.github.com/repos/SkySkimmer/coq/issues/comments{/number}","contents_url":"https://api.github.com/repos/SkySkimmer/coq/contents/{+path}","compare_url":"https://api.github.com/repos/SkySkimmer/coq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SkySkimmer/coq/merges","archive_url":"https://api.github.com/repos/SkySkimmer/coq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SkySkimmer/coq/downloads","issues_url":"https://api.github.com/repos/SkySkimmer/coq/issues{/number}","pulls_url":"https://api.github.com/repos/SkySkimmer/coq/pulls{/number}","milestones_url":"https://api.github.com/repos/SkySkimmer/coq/milestones{/number}","notifications_url":"https://api.github.com/repos/SkySkimmer/coq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SkySkimmer/coq/labels{/name}","releases_url":"https://api.github.com/repos/SkySkimmer/coq/releases{/id}","deployments_url":"https://api.github.com/repos/SkySkimmer/coq/deployments","created_at":"2016-12-12T13:56:45Z","updated_at":"2018-07-04T11:36:29Z","pushed_at":"2018-07-04T11:40:24Z","git_url":"git://github.com/SkySkimmer/coq.git","ssh_url":"git@github.com:SkySkimmer/coq.git","clone_url":"https://github.com/SkySkimmer/coq.git","svn_url":"https://github.com/SkySkimmer/coq","homepage":"http://coq.inria.fr/","size":101765,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coq:master","ref":"master","sha":"2a8243338d3d1cc6163cd0d49880cfacb40bc229","user":{"login":"coq","id":621198,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMTE5OA==","avatar_url":"https://avatars1.githubusercontent.com/u/621198?v=4","gravatar_id":"","url":"https://api.github.com/users/coq","html_url":"https://github.com/coq","followers_url":"https://api.github.com/users/coq/followers","following_url":"https://api.github.com/users/coq/following{/other_user}","gists_url":"https://api.github.com/users/coq/gists{/gist_id}","starred_url":"https://api.github.com/users/coq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coq/subscriptions","organizations_url":"https://api.github.com/users/coq/orgs","repos_url":"https://api.github.com/users/coq/repos","events_url":"https://api.github.com/users/coq/events{/privacy}","received_events_url":"https://api.github.com/users/coq/received_events","type":"Organization","site_admin":false},"repo":{"id":1377159,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc3MTU5","name":"coq","full_name":"coq/coq","owner":{"login":"coq","id":621198,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMTE5OA==","avatar_url":"https://avatars1.githubusercontent.com/u/621198?v=4","gravatar_id":"","url":"https://api.github.com/users/coq","html_url":"https://github.com/coq","followers_url":"https://api.github.com/users/coq/followers","following_url":"https://api.github.com/users/coq/following{/other_user}","gists_url":"https://api.github.com/users/coq/gists{/gist_id}","starred_url":"https://api.github.com/users/coq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coq/subscriptions","organizations_url":"https://api.github.com/users/coq/orgs","repos_url":"https://api.github.com/users/coq/repos","events_url":"https://api.github.com/users/coq/events{/privacy}","received_events_url":"https://api.github.com/users/coq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coq/coq","description":"Coq is a formal proof management system. It provides a formal language to write mathematical definitions, executable algorithms and theorems together with an environment for semi-interactive development of machine-checked proofs. ","fork":false,"url":"https://api.github.com/repos/coq/coq","forks_url":"https://api.github.com/repos/coq/coq/forks","keys_url":"https://api.github.com/repos/coq/coq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coq/coq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coq/coq/teams","hooks_url":"https://api.github.com/repos/coq/coq/hooks","issue_events_url":"https://api.github.com/repos/coq/coq/issues/events{/number}","events_url":"https://api.github.com/repos/coq/coq/events","assignees_url":"https://api.github.com/repos/coq/coq/assignees{/user}","branches_url":"https://api.github.com/repos/coq/coq/branches{/branch}","tags_url":"https://api.github.com/repos/coq/coq/tags","blobs_url":"https://api.github.com/repos/coq/coq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coq/coq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coq/coq/git/refs{/sha}","trees_url":"https://api.github.com/repos/coq/coq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coq/coq/statuses/{sha}","languages_url":"https://api.github.com/repos/coq/coq/languages","stargazers_url":"https://api.github.com/repos/coq/coq/stargazers","contributors_url":"https://api.github.com/repos/coq/coq/contributors","subscribers_url":"https://api.github.com/repos/coq/coq/subscribers","subscription_url":"https://api.github.com/repos/coq/coq/subscription","commits_url":"https://api.github.com/repos/coq/coq/commits{/sha}","git_commits_url":"https://api.github.com/repos/coq/coq/git/commits{/sha}","comments_url":"https://api.github.com/repos/coq/coq/comments{/number}","issue_comment_url":"https://api.github.com/repos/coq/coq/issues/comments{/number}","contents_url":"https://api.github.com/repos/coq/coq/contents/{+path}","compare_url":"https://api.github.com/repos/coq/coq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coq/coq/merges","archive_url":"https://api.github.com/repos/coq/coq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coq/coq/downloads","issues_url":"https://api.github.com/repos/coq/coq/issues{/number}","pulls_url":"https://api.github.com/repos/coq/coq/pulls{/number}","milestones_url":"https://api.github.com/repos/coq/coq/milestones{/number}","notifications_url":"https://api.github.com/repos/coq/coq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coq/coq/labels{/name}","releases_url":"https://api.github.com/repos/coq/coq/releases{/id}","deployments_url":"https://api.github.com/repos/coq/coq/deployments","created_at":"2011-02-17T05:49:37Z","updated_at":"2018-07-04T11:36:59Z","pushed_at":"2018-07-04T11:42:19Z","git_url":"git://github.com/coq/coq.git","ssh_url":"git@github.com:coq/coq.git","clone_url":"https://github.com/coq/coq.git","svn_url":"https://github.com/coq/coq","homepage":"https://coq.inria.fr/","size":112740,"stargazers_count":1312,"watchers_count":1312,"language":"OCaml","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":262,"mirror_url":null,"archived":false,"open_issues_count":1668,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":262,"open_issues":1668,"watchers":1312,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coq/coq/pulls/7994"},"html":{"href":"https://github.com/coq/coq/pull/7994"},"issue":{"href":"https://api.github.com/repos/coq/coq/issues/7994"},"comments":{"href":"https://api.github.com/repos/coq/coq/issues/7994/comments"},"review_comments":{"href":"https://api.github.com/repos/coq/coq/pulls/7994/comments"},"review_comment":{"href":"https://api.github.com/repos/coq/coq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coq/coq/pulls/7994/commits"},"statuses":{"href":"https://api.github.com/repos/coq/coq/statuses/cd45eda96c0026fc8962ba51b3e3750be946b96f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ejgallego"}}