{"action":"created","comment":{"url":"https://api.github.com/repos/zold-io/java-api/pulls/comments/207327961","pull_request_review_id":142919212,"id":207327961,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzMyNzk2MQ==","diff_hunk":"@@ -50,6 +52,11 @@\n         \"^([A-Za-z0-9+\\\\/]{4})*([A-Za-z0-9+\\\\/]{4}|[A-Za-z0-9+\\\\/]{3}=|[A-Za-z0-9+\\\\/]{2}==)$\"\n     );\n \n+    /**\n+     * Pattern for parsing Signature.\n+     */\n+    private static final Pattern SIGN = Pattern.compile(\"[A-Za-z0-9+/]+={0,3}\");","path":"src/main/java/io/zold/api/RtTransaction.java","position":7,"original_position":23,"commit_id":"973eda10a12c3bb082b2c07817d46593635f25fe","original_commit_id":"561c1e7eceb1071e2f10f71e213be573d5ee81be","user":{"login":"llorllale","id":2019896,"node_id":"MDQ6VXNlcjIwMTk4OTY=","avatar_url":"https://avatars1.githubusercontent.com/u/2019896?v=4","gravatar_id":"","url":"https://api.github.com/users/llorllale","html_url":"https://github.com/llorllale","followers_url":"https://api.github.com/users/llorllale/followers","following_url":"https://api.github.com/users/llorllale/following{/other_user}","gists_url":"https://api.github.com/users/llorllale/gists{/gist_id}","starred_url":"https://api.github.com/users/llorllale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/llorllale/subscriptions","organizations_url":"https://api.github.com/users/llorllale/orgs","repos_url":"https://api.github.com/users/llorllale/repos","events_url":"https://api.github.com/users/llorllale/events{/privacy}","received_events_url":"https://api.github.com/users/llorllale/received_events","type":"User","site_admin":false},"body":"@victornoel I don't see anything in `java.security` that we could use for what you're proposing","created_at":"2018-08-02T18:25:45Z","updated_at":"2018-08-02T18:25:45Z","html_url":"https://github.com/zold-io/java-api/pull/57#discussion_r207327961","pull_request_url":"https://api.github.com/repos/zold-io/java-api/pulls/57","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/zold-io/java-api/pulls/comments/207327961"},"html":{"href":"https://github.com/zold-io/java-api/pull/57#discussion_r207327961"},"pull_request":{"href":"https://api.github.com/repos/zold-io/java-api/pulls/57"}},"in_reply_to_id":206627282},"pull_request":{"url":"https://api.github.com/repos/zold-io/java-api/pulls/57","id":205029360,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MDI5MzYw","html_url":"https://github.com/zold-io/java-api/pull/57","diff_url":"https://github.com/zold-io/java-api/pull/57.diff","patch_url":"https://github.com/zold-io/java-api/pull/57.patch","issue_url":"https://api.github.com/repos/zold-io/java-api/issues/57","number":57,"state":"open","locked":false,"title":"#28 Implement RtTransaction.signature()","user":{"login":"carlosmiranda","id":1917892,"node_id":"MDQ6VXNlcjE5MTc4OTI=","avatar_url":"https://avatars0.githubusercontent.com/u/1917892?v=4","gravatar_id":"","url":"https://api.github.com/users/carlosmiranda","html_url":"https://github.com/carlosmiranda","followers_url":"https://api.github.com/users/carlosmiranda/followers","following_url":"https://api.github.com/users/carlosmiranda/following{/other_user}","gists_url":"https://api.github.com/users/carlosmiranda/gists{/gist_id}","starred_url":"https://api.github.com/users/carlosmiranda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlosmiranda/subscriptions","organizations_url":"https://api.github.com/users/carlosmiranda/orgs","repos_url":"https://api.github.com/users/carlosmiranda/repos","events_url":"https://api.github.com/users/carlosmiranda/events{/privacy}","received_events_url":"https://api.github.com/users/carlosmiranda/received_events","type":"User","site_admin":false},"body":"#28 Implement `RtTransaction.signature()`.\r\n\r\nNote: I am aware that the white paper says the signature is 684 symbols; I used a simpler and less strict pattern following the Ruby API. See https://github.com/zold-io/zold/blob/master/lib/zold/txn.rb#L119","created_at":"2018-07-31T08:10:16Z","updated_at":"2018-08-02T18:25:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3dc8285ae7721d7bf576b9c141c50a6a671e0164","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":975102032,"node_id":"MDU6TGFiZWw5NzUxMDIwMzI=","url":"https://api.github.com/repos/zold-io/java-api/labels/scope","name":"scope","color":"3a6622","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/zold-io/java-api/pulls/57/commits","review_comments_url":"https://api.github.com/repos/zold-io/java-api/pulls/57/comments","review_comment_url":"https://api.github.com/repos/zold-io/java-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zold-io/java-api/issues/57/comments","statuses_url":"https://api.github.com/repos/zold-io/java-api/statuses/973eda10a12c3bb082b2c07817d46593635f25fe","head":{"label":"carlosmiranda:28","ref":"28","sha":"973eda10a12c3bb082b2c07817d46593635f25fe","user":{"login":"carlosmiranda","id":1917892,"node_id":"MDQ6VXNlcjE5MTc4OTI=","avatar_url":"https://avatars0.githubusercontent.com/u/1917892?v=4","gravatar_id":"","url":"https://api.github.com/users/carlosmiranda","html_url":"https://github.com/carlosmiranda","followers_url":"https://api.github.com/users/carlosmiranda/followers","following_url":"https://api.github.com/users/carlosmiranda/following{/other_user}","gists_url":"https://api.github.com/users/carlosmiranda/gists{/gist_id}","starred_url":"https://api.github.com/users/carlosmiranda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlosmiranda/subscriptions","organizations_url":"https://api.github.com/users/carlosmiranda/orgs","repos_url":"https://api.github.com/users/carlosmiranda/repos","events_url":"https://api.github.com/users/carlosmiranda/events{/privacy}","received_events_url":"https://api.github.com/users/carlosmiranda/received_events","type":"User","site_admin":false},"repo":{"id":139655323,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk2NTUzMjM=","name":"java-api","full_name":"carlosmiranda/java-api","owner":{"login":"carlosmiranda","id":1917892,"node_id":"MDQ6VXNlcjE5MTc4OTI=","avatar_url":"https://avatars0.githubusercontent.com/u/1917892?v=4","gravatar_id":"","url":"https://api.github.com/users/carlosmiranda","html_url":"https://github.com/carlosmiranda","followers_url":"https://api.github.com/users/carlosmiranda/followers","following_url":"https://api.github.com/users/carlosmiranda/following{/other_user}","gists_url":"https://api.github.com/users/carlosmiranda/gists{/gist_id}","starred_url":"https://api.github.com/users/carlosmiranda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlosmiranda/subscriptions","organizations_url":"https://api.github.com/users/carlosmiranda/orgs","repos_url":"https://api.github.com/users/carlosmiranda/repos","events_url":"https://api.github.com/users/carlosmiranda/events{/privacy}","received_events_url":"https://api.github.com/users/carlosmiranda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/carlosmiranda/java-api","description":"Zold Java API","fork":true,"url":"https://api.github.com/repos/carlosmiranda/java-api","forks_url":"https://api.github.com/repos/carlosmiranda/java-api/forks","keys_url":"https://api.github.com/repos/carlosmiranda/java-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carlosmiranda/java-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carlosmiranda/java-api/teams","hooks_url":"https://api.github.com/repos/carlosmiranda/java-api/hooks","issue_events_url":"https://api.github.com/repos/carlosmiranda/java-api/issues/events{/number}","events_url":"https://api.github.com/repos/carlosmiranda/java-api/events","assignees_url":"https://api.github.com/repos/carlosmiranda/java-api/assignees{/user}","branches_url":"https://api.github.com/repos/carlosmiranda/java-api/branches{/branch}","tags_url":"https://api.github.com/repos/carlosmiranda/java-api/tags","blobs_url":"https://api.github.com/repos/carlosmiranda/java-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carlosmiranda/java-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carlosmiranda/java-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/carlosmiranda/java-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carlosmiranda/java-api/statuses/{sha}","languages_url":"https://api.github.com/repos/carlosmiranda/java-api/languages","stargazers_url":"https://api.github.com/repos/carlosmiranda/java-api/stargazers","contributors_url":"https://api.github.com/repos/carlosmiranda/java-api/contributors","subscribers_url":"https://api.github.com/repos/carlosmiranda/java-api/subscribers","subscription_url":"https://api.github.com/repos/carlosmiranda/java-api/subscription","commits_url":"https://api.github.com/repos/carlosmiranda/java-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/carlosmiranda/java-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/carlosmiranda/java-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/carlosmiranda/java-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/carlosmiranda/java-api/contents/{+path}","compare_url":"https://api.github.com/repos/carlosmiranda/java-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carlosmiranda/java-api/merges","archive_url":"https://api.github.com/repos/carlosmiranda/java-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carlosmiranda/java-api/downloads","issues_url":"https://api.github.com/repos/carlosmiranda/java-api/issues{/number}","pulls_url":"https://api.github.com/repos/carlosmiranda/java-api/pulls{/number}","milestones_url":"https://api.github.com/repos/carlosmiranda/java-api/milestones{/number}","notifications_url":"https://api.github.com/repos/carlosmiranda/java-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carlosmiranda/java-api/labels{/name}","releases_url":"https://api.github.com/repos/carlosmiranda/java-api/releases{/id}","deployments_url":"https://api.github.com/repos/carlosmiranda/java-api/deployments","created_at":"2018-07-04T01:51:53Z","updated_at":"2018-07-31T07:36:11Z","pushed_at":"2018-08-02T07:36:47Z","git_url":"git://github.com/carlosmiranda/java-api.git","ssh_url":"git@github.com:carlosmiranda/java-api.git","clone_url":"https://github.com/carlosmiranda/java-api.git","svn_url":"https://github.com/carlosmiranda/java-api","homepage":"https://www.zold.io","size":151,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zold-io:master","ref":"master","sha":"2a2d23aa65e4b9ad43b400ca2a8bfa70e46e0dbe","user":{"login":"zold-io","id":39849919,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5ODQ5OTE5","avatar_url":"https://avatars1.githubusercontent.com/u/39849919?v=4","gravatar_id":"","url":"https://api.github.com/users/zold-io","html_url":"https://github.com/zold-io","followers_url":"https://api.github.com/users/zold-io/followers","following_url":"https://api.github.com/users/zold-io/following{/other_user}","gists_url":"https://api.github.com/users/zold-io/gists{/gist_id}","starred_url":"https://api.github.com/users/zold-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zold-io/subscriptions","organizations_url":"https://api.github.com/users/zold-io/orgs","repos_url":"https://api.github.com/users/zold-io/repos","events_url":"https://api.github.com/users/zold-io/events{/privacy}","received_events_url":"https://api.github.com/users/zold-io/received_events","type":"Organization","site_admin":false},"repo":{"id":135799460,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU3OTk0NjA=","name":"java-api","full_name":"zold-io/java-api","owner":{"login":"zold-io","id":39849919,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5ODQ5OTE5","avatar_url":"https://avatars1.githubusercontent.com/u/39849919?v=4","gravatar_id":"","url":"https://api.github.com/users/zold-io","html_url":"https://github.com/zold-io","followers_url":"https://api.github.com/users/zold-io/followers","following_url":"https://api.github.com/users/zold-io/following{/other_user}","gists_url":"https://api.github.com/users/zold-io/gists{/gist_id}","starred_url":"https://api.github.com/users/zold-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zold-io/subscriptions","organizations_url":"https://api.github.com/users/zold-io/orgs","repos_url":"https://api.github.com/users/zold-io/repos","events_url":"https://api.github.com/users/zold-io/events{/privacy}","received_events_url":"https://api.github.com/users/zold-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zold-io/java-api","description":"Zold Java API","fork":false,"url":"https://api.github.com/repos/zold-io/java-api","forks_url":"https://api.github.com/repos/zold-io/java-api/forks","keys_url":"https://api.github.com/repos/zold-io/java-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zold-io/java-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zold-io/java-api/teams","hooks_url":"https://api.github.com/repos/zold-io/java-api/hooks","issue_events_url":"https://api.github.com/repos/zold-io/java-api/issues/events{/number}","events_url":"https://api.github.com/repos/zold-io/java-api/events","assignees_url":"https://api.github.com/repos/zold-io/java-api/assignees{/user}","branches_url":"https://api.github.com/repos/zold-io/java-api/branches{/branch}","tags_url":"https://api.github.com/repos/zold-io/java-api/tags","blobs_url":"https://api.github.com/repos/zold-io/java-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zold-io/java-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zold-io/java-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/zold-io/java-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zold-io/java-api/statuses/{sha}","languages_url":"https://api.github.com/repos/zold-io/java-api/languages","stargazers_url":"https://api.github.com/repos/zold-io/java-api/stargazers","contributors_url":"https://api.github.com/repos/zold-io/java-api/contributors","subscribers_url":"https://api.github.com/repos/zold-io/java-api/subscribers","subscription_url":"https://api.github.com/repos/zold-io/java-api/subscription","commits_url":"https://api.github.com/repos/zold-io/java-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/zold-io/java-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/zold-io/java-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/zold-io/java-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/zold-io/java-api/contents/{+path}","compare_url":"https://api.github.com/repos/zold-io/java-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zold-io/java-api/merges","archive_url":"https://api.github.com/repos/zold-io/java-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zold-io/java-api/downloads","issues_url":"https://api.github.com/repos/zold-io/java-api/issues{/number}","pulls_url":"https://api.github.com/repos/zold-io/java-api/pulls{/number}","milestones_url":"https://api.github.com/repos/zold-io/java-api/milestones{/number}","notifications_url":"https://api.github.com/repos/zold-io/java-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zold-io/java-api/labels{/name}","releases_url":"https://api.github.com/repos/zold-io/java-api/releases{/id}","deployments_url":"https://api.github.com/repos/zold-io/java-api/deployments","created_at":"2018-06-02T08:05:13Z","updated_at":"2018-08-02T14:33:55Z","pushed_at":"2018-08-02T14:33:52Z","git_url":"git://github.com/zold-io/java-api.git","ssh_url":"git@github.com:zold-io/java-api.git","clone_url":"https://github.com/zold-io/java-api.git","svn_url":"https://github.com/zold-io/java-api","homepage":"https://www.zold.io","size":140,"stargazers_count":17,"watchers_count":17,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":8,"open_issues":15,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zold-io/java-api/pulls/57"},"html":{"href":"https://github.com/zold-io/java-api/pull/57"},"issue":{"href":"https://api.github.com/repos/zold-io/java-api/issues/57"},"comments":{"href":"https://api.github.com/repos/zold-io/java-api/issues/57/comments"},"review_comments":{"href":"https://api.github.com/repos/zold-io/java-api/pulls/57/comments"},"review_comment":{"href":"https://api.github.com/repos/zold-io/java-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zold-io/java-api/pulls/57/commits"},"statuses":{"href":"https://api.github.com/repos/zold-io/java-api/statuses/973eda10a12c3bb082b2c07817d46593635f25fe"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"llorllale"}}