{"action":"created","issue":{"url":"https://api.github.com/repos/open-source-economics/taxdata/issues/183","repository_url":"https://api.github.com/repos/open-source-economics/taxdata","labels_url":"https://api.github.com/repos/open-source-economics/taxdata/issues/183/labels{/name}","comments_url":"https://api.github.com/repos/open-source-economics/taxdata/issues/183/comments","events_url":"https://api.github.com/repos/open-source-economics/taxdata/issues/183/events","html_url":"https://github.com/open-source-economics/taxdata/pull/183","id":317253229,"number":183,"title":"Move Age Variable Counts to SAS Scripts","user":{"login":"andersonfrailey","id":20684675,"avatar_url":"https://avatars0.githubusercontent.com/u/20684675?v=4","gravatar_id":"","url":"https://api.github.com/users/andersonfrailey","html_url":"https://github.com/andersonfrailey","followers_url":"https://api.github.com/users/andersonfrailey/followers","following_url":"https://api.github.com/users/andersonfrailey/following{/other_user}","gists_url":"https://api.github.com/users/andersonfrailey/gists{/gist_id}","starred_url":"https://api.github.com/users/andersonfrailey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andersonfrailey/subscriptions","organizations_url":"https://api.github.com/users/andersonfrailey/orgs","repos_url":"https://api.github.com/users/andersonfrailey/repos","events_url":"https://api.github.com/users/andersonfrailey/events{/privacy}","received_events_url":"https://api.github.com/users/andersonfrailey/received_events","type":"User","site_admin":false},"labels":[{"id":839272183,"url":"https://api.github.com/repos/open-source-economics/taxdata/labels/ready","name":"ready","color":"5ce843","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-04-24T14:29:41Z","updated_at":"2018-04-26T14:08:28Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/open-source-economics/taxdata/pulls/183","html_url":"https://github.com/open-source-economics/taxdata/pull/183","diff_url":"https://github.com/open-source-economics/taxdata/pull/183.diff","patch_url":"https://github.com/open-source-economics/taxdata/pull/183.patch"},"body":"This PR moves the creation of `nu13`, `nu05`, `n24`, `elderly_dependent`, `f2441`, and `EIC` for the CPS file from `finalprep.py` to the SAS scripts. I'm doing this because final prep was only able to count up to five dependents for each of these variables, while in the SAS scripts we should be able to catch all of them.\r\n\r\nIt is labeled WIP because `n24` exceeds `nu18` in about 7% of the records still. I'll remove the label when I figure out why this is the case. I also incremented `EIC` incorrectly for 2013 and 2014, which I'll fix in my next commit."},"comment":{"url":"https://api.github.com/repos/open-source-economics/taxdata/issues/comments/384654210","html_url":"https://github.com/open-source-economics/taxdata/pull/183#issuecomment-384654210","issue_url":"https://api.github.com/repos/open-source-economics/taxdata/issues/183","id":384654210,"user":{"login":"martinholmer","id":12170745,"avatar_url":"https://avatars1.githubusercontent.com/u/12170745?v=4","gravatar_id":"","url":"https://api.github.com/users/martinholmer","html_url":"https://github.com/martinholmer","followers_url":"https://api.github.com/users/martinholmer/followers","following_url":"https://api.github.com/users/martinholmer/following{/other_user}","gists_url":"https://api.github.com/users/martinholmer/gists{/gist_id}","starred_url":"https://api.github.com/users/martinholmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinholmer/subscriptions","organizations_url":"https://api.github.com/users/martinholmer/orgs","repos_url":"https://api.github.com/users/martinholmer/repos","events_url":"https://api.github.com/users/martinholmer/events{/privacy}","received_events_url":"https://api.github.com/users/martinholmer/received_events","type":"User","site_admin":false},"created_at":"2018-04-26T14:08:28Z","updated_at":"2018-04-26T14:08:28Z","author_association":"CONTRIBUTOR","body":"@andersonfrailey said:\r\n> The issue in #149 was resolved in PR #151 for the CPS file. I'm still working on a fix for the PUF. This PR #183 was aimed at resolving just #157.\r\n\r\nOK.  Thanks for the clarification."}}
{"actor":{"display_login":"martinholmer"}}