{"action":"created","comment":{"url":"https://api.github.com/repos/opnsense/core/pulls/comments/217903359","pull_request_review_id":155733225,"id":217903359,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzkwMzM1OQ==","diff_hunk":"@@ -138,12 +128,8 @@ function gateways_widget_update(sender, data)\n     <th><?=gettext('Loss')?></th>\n     <th><?=gettext('Status')?></th>\n   </tr>\n-<?php foreach ($gateways as $gwname => $unused):\n-      $listed = in_array($gwname, $pconfig['gatewaysfilter']);\n-      $listed = !empty($pconfig['gatewaysinvert']) ? $listed : !$listed;\n-      if (!$listed) {\n-        continue;\n-      } ?>\n+<?php foreach ($gateways as $gwname => $unused): ?>\n+<? if (!count($pconfig['gatewaysfilter']) || in_array($gwname, $pconfig['gatewaysfilter'])): ?>","path":"src/www/widgets/widgets/gateways.widget.php","position":null,"original_position":50,"commit_id":"a2be62538d81ca3eaa97df656d11711fbdee1fde","original_commit_id":"ea7356c9f2a9bb31b03a6df8a1c67b7ee3525384","user":{"login":"fabianfrz","id":3713914,"node_id":"MDQ6VXNlcjM3MTM5MTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3713914?v=4","gravatar_id":"","url":"https://api.github.com/users/fabianfrz","html_url":"https://github.com/fabianfrz","followers_url":"https://api.github.com/users/fabianfrz/followers","following_url":"https://api.github.com/users/fabianfrz/following{/other_user}","gists_url":"https://api.github.com/users/fabianfrz/gists{/gist_id}","starred_url":"https://api.github.com/users/fabianfrz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabianfrz/subscriptions","organizations_url":"https://api.github.com/users/fabianfrz/orgs","repos_url":"https://api.github.com/users/fabianfrz/repos","events_url":"https://api.github.com/users/fabianfrz/events{/privacy}","received_events_url":"https://api.github.com/users/fabianfrz/received_events","type":"User","site_admin":false},"body":"never use short open tag","created_at":"2018-09-16T06:10:39Z","updated_at":"2018-09-16T06:10:39Z","html_url":"https://github.com/opnsense/core/pull/2711#discussion_r217903359","pull_request_url":"https://api.github.com/repos/opnsense/core/pulls/2711","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/opnsense/core/pulls/comments/217903359"},"html":{"href":"https://github.com/opnsense/core/pull/2711#discussion_r217903359"},"pull_request":{"href":"https://api.github.com/repos/opnsense/core/pulls/2711"}}},"pull_request":{"url":"https://api.github.com/repos/opnsense/core/pulls/2711","id":214313878,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MzEzODc4","html_url":"https://github.com/opnsense/core/pull/2711","diff_url":"https://github.com/opnsense/core/pull/2711.diff","patch_url":"https://github.com/opnsense/core/pull/2711.patch","issue_url":"https://api.github.com/repos/opnsense/core/issues/2711","number":2711,"state":"open","locked":false,"title":"Sidebar hover modification - opnsense_theme.js","user":{"login":"opnsenseuser","id":34602360,"node_id":"MDQ6VXNlcjM0NjAyMzYw","avatar_url":"https://avatars0.githubusercontent.com/u/34602360?v=4","gravatar_id":"","url":"https://api.github.com/users/opnsenseuser","html_url":"https://github.com/opnsenseuser","followers_url":"https://api.github.com/users/opnsenseuser/followers","following_url":"https://api.github.com/users/opnsenseuser/following{/other_user}","gists_url":"https://api.github.com/users/opnsenseuser/gists{/gist_id}","starred_url":"https://api.github.com/users/opnsenseuser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opnsenseuser/subscriptions","organizations_url":"https://api.github.com/users/opnsenseuser/orgs","repos_url":"https://api.github.com/users/opnsenseuser/repos","events_url":"https://api.github.com/users/opnsenseuser/events{/privacy}","received_events_url":"https://api.github.com/users/opnsenseuser/received_events","type":"User","site_admin":false},"body":"Sidebar hover modification - opnsense_theme.js\r\n\r\nSidebar - hover - modification\r\n\r\n@fabianfrz\r\n@fichtner\r\n\r\nnow spaces, tabs and brackets should also be fine!","created_at":"2018-09-10T13:27:38Z","updated_at":"2018-09-16T06:10:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1847f6e3a908d571bbac70c9cdb137e6413ffa5e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/opnsense/core/pulls/2711/commits","review_comments_url":"https://api.github.com/repos/opnsense/core/pulls/2711/comments","review_comment_url":"https://api.github.com/repos/opnsense/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opnsense/core/issues/2711/comments","statuses_url":"https://api.github.com/repos/opnsense/core/statuses/a2be62538d81ca3eaa97df656d11711fbdee1fde","head":{"label":"opnsenseuser:Sidebar-hover-modification---opnsense_theme.js","ref":"Sidebar-hover-modification---opnsense_theme.js","sha":"a2be62538d81ca3eaa97df656d11711fbdee1fde","user":{"login":"opnsenseuser","id":34602360,"node_id":"MDQ6VXNlcjM0NjAyMzYw","avatar_url":"https://avatars0.githubusercontent.com/u/34602360?v=4","gravatar_id":"","url":"https://api.github.com/users/opnsenseuser","html_url":"https://github.com/opnsenseuser","followers_url":"https://api.github.com/users/opnsenseuser/followers","following_url":"https://api.github.com/users/opnsenseuser/following{/other_user}","gists_url":"https://api.github.com/users/opnsenseuser/gists{/gist_id}","starred_url":"https://api.github.com/users/opnsenseuser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opnsenseuser/subscriptions","organizations_url":"https://api.github.com/users/opnsenseuser/orgs","repos_url":"https://api.github.com/users/opnsenseuser/repos","events_url":"https://api.github.com/users/opnsenseuser/events{/privacy}","received_events_url":"https://api.github.com/users/opnsenseuser/received_events","type":"User","site_admin":false},"repo":{"id":142790238,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI3OTAyMzg=","name":"core","full_name":"opnsenseuser/core","private":false,"owner":{"login":"opnsenseuser","id":34602360,"node_id":"MDQ6VXNlcjM0NjAyMzYw","avatar_url":"https://avatars0.githubusercontent.com/u/34602360?v=4","gravatar_id":"","url":"https://api.github.com/users/opnsenseuser","html_url":"https://github.com/opnsenseuser","followers_url":"https://api.github.com/users/opnsenseuser/followers","following_url":"https://api.github.com/users/opnsenseuser/following{/other_user}","gists_url":"https://api.github.com/users/opnsenseuser/gists{/gist_id}","starred_url":"https://api.github.com/users/opnsenseuser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opnsenseuser/subscriptions","organizations_url":"https://api.github.com/users/opnsenseuser/orgs","repos_url":"https://api.github.com/users/opnsenseuser/repos","events_url":"https://api.github.com/users/opnsenseuser/events{/privacy}","received_events_url":"https://api.github.com/users/opnsenseuser/received_events","type":"User","site_admin":false},"html_url":"https://github.com/opnsenseuser/core","description":"OPNsense GUI, API and systems backend","fork":true,"url":"https://api.github.com/repos/opnsenseuser/core","forks_url":"https://api.github.com/repos/opnsenseuser/core/forks","keys_url":"https://api.github.com/repos/opnsenseuser/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opnsenseuser/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opnsenseuser/core/teams","hooks_url":"https://api.github.com/repos/opnsenseuser/core/hooks","issue_events_url":"https://api.github.com/repos/opnsenseuser/core/issues/events{/number}","events_url":"https://api.github.com/repos/opnsenseuser/core/events","assignees_url":"https://api.github.com/repos/opnsenseuser/core/assignees{/user}","branches_url":"https://api.github.com/repos/opnsenseuser/core/branches{/branch}","tags_url":"https://api.github.com/repos/opnsenseuser/core/tags","blobs_url":"https://api.github.com/repos/opnsenseuser/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opnsenseuser/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opnsenseuser/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/opnsenseuser/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opnsenseuser/core/statuses/{sha}","languages_url":"https://api.github.com/repos/opnsenseuser/core/languages","stargazers_url":"https://api.github.com/repos/opnsenseuser/core/stargazers","contributors_url":"https://api.github.com/repos/opnsenseuser/core/contributors","subscribers_url":"https://api.github.com/repos/opnsenseuser/core/subscribers","subscription_url":"https://api.github.com/repos/opnsenseuser/core/subscription","commits_url":"https://api.github.com/repos/opnsenseuser/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/opnsenseuser/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/opnsenseuser/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/opnsenseuser/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/opnsenseuser/core/contents/{+path}","compare_url":"https://api.github.com/repos/opnsenseuser/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opnsenseuser/core/merges","archive_url":"https://api.github.com/repos/opnsenseuser/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opnsenseuser/core/downloads","issues_url":"https://api.github.com/repos/opnsenseuser/core/issues{/number}","pulls_url":"https://api.github.com/repos/opnsenseuser/core/pulls{/number}","milestones_url":"https://api.github.com/repos/opnsenseuser/core/milestones{/number}","notifications_url":"https://api.github.com/repos/opnsenseuser/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opnsenseuser/core/labels{/name}","releases_url":"https://api.github.com/repos/opnsenseuser/core/releases{/id}","deployments_url":"https://api.github.com/repos/opnsenseuser/core/deployments","created_at":"2018-07-29T19:38:00Z","updated_at":"2018-09-15T19:57:31Z","pushed_at":"2018-09-16T06:02:16Z","git_url":"git://github.com/opnsenseuser/core.git","ssh_url":"git@github.com:opnsenseuser/core.git","clone_url":"https://github.com/opnsenseuser/core.git","svn_url":"https://github.com/opnsenseuser/core","homepage":"https://opnsense.org/","size":62629,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opnsense:master","ref":"master","sha":"3972bedbdf214231552c851183a6fee9f68e0207","user":{"login":"opnsense","id":9979117,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NzkxMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/9979117?v=4","gravatar_id":"","url":"https://api.github.com/users/opnsense","html_url":"https://github.com/opnsense","followers_url":"https://api.github.com/users/opnsense/followers","following_url":"https://api.github.com/users/opnsense/following{/other_user}","gists_url":"https://api.github.com/users/opnsense/gists{/gist_id}","starred_url":"https://api.github.com/users/opnsense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opnsense/subscriptions","organizations_url":"https://api.github.com/users/opnsense/orgs","repos_url":"https://api.github.com/users/opnsense/repos","events_url":"https://api.github.com/users/opnsense/events{/privacy}","received_events_url":"https://api.github.com/users/opnsense/received_events","type":"Organization","site_admin":false},"repo":{"id":27965134,"node_id":"MDEwOlJlcG9zaXRvcnkyNzk2NTEzNA==","name":"core","full_name":"opnsense/core","private":false,"owner":{"login":"opnsense","id":9979117,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NzkxMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/9979117?v=4","gravatar_id":"","url":"https://api.github.com/users/opnsense","html_url":"https://github.com/opnsense","followers_url":"https://api.github.com/users/opnsense/followers","following_url":"https://api.github.com/users/opnsense/following{/other_user}","gists_url":"https://api.github.com/users/opnsense/gists{/gist_id}","starred_url":"https://api.github.com/users/opnsense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opnsense/subscriptions","organizations_url":"https://api.github.com/users/opnsense/orgs","repos_url":"https://api.github.com/users/opnsense/repos","events_url":"https://api.github.com/users/opnsense/events{/privacy}","received_events_url":"https://api.github.com/users/opnsense/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/opnsense/core","description":"OPNsense GUI, API and systems backend","fork":false,"url":"https://api.github.com/repos/opnsense/core","forks_url":"https://api.github.com/repos/opnsense/core/forks","keys_url":"https://api.github.com/repos/opnsense/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opnsense/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opnsense/core/teams","hooks_url":"https://api.github.com/repos/opnsense/core/hooks","issue_events_url":"https://api.github.com/repos/opnsense/core/issues/events{/number}","events_url":"https://api.github.com/repos/opnsense/core/events","assignees_url":"https://api.github.com/repos/opnsense/core/assignees{/user}","branches_url":"https://api.github.com/repos/opnsense/core/branches{/branch}","tags_url":"https://api.github.com/repos/opnsense/core/tags","blobs_url":"https://api.github.com/repos/opnsense/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opnsense/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opnsense/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/opnsense/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opnsense/core/statuses/{sha}","languages_url":"https://api.github.com/repos/opnsense/core/languages","stargazers_url":"https://api.github.com/repos/opnsense/core/stargazers","contributors_url":"https://api.github.com/repos/opnsense/core/contributors","subscribers_url":"https://api.github.com/repos/opnsense/core/subscribers","subscription_url":"https://api.github.com/repos/opnsense/core/subscription","commits_url":"https://api.github.com/repos/opnsense/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/opnsense/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/opnsense/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/opnsense/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/opnsense/core/contents/{+path}","compare_url":"https://api.github.com/repos/opnsense/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opnsense/core/merges","archive_url":"https://api.github.com/repos/opnsense/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opnsense/core/downloads","issues_url":"https://api.github.com/repos/opnsense/core/issues{/number}","pulls_url":"https://api.github.com/repos/opnsense/core/pulls{/number}","milestones_url":"https://api.github.com/repos/opnsense/core/milestones{/number}","notifications_url":"https://api.github.com/repos/opnsense/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opnsense/core/labels{/name}","releases_url":"https://api.github.com/repos/opnsense/core/releases{/id}","deployments_url":"https://api.github.com/repos/opnsense/core/deployments","created_at":"2014-12-13T15:43:50Z","updated_at":"2018-09-16T03:19:21Z","pushed_at":"2018-09-16T06:06:00Z","git_url":"git://github.com/opnsense/core.git","ssh_url":"git@github.com:opnsense/core.git","clone_url":"https://github.com/opnsense/core.git","svn_url":"https://github.com/opnsense/core","homepage":"https://opnsense.org/","size":62763,"stargazers_count":662,"watchers_count":662,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":228,"mirror_url":null,"archived":false,"open_issues_count":202,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":228,"open_issues":202,"watchers":662,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opnsense/core/pulls/2711"},"html":{"href":"https://github.com/opnsense/core/pull/2711"},"issue":{"href":"https://api.github.com/repos/opnsense/core/issues/2711"},"comments":{"href":"https://api.github.com/repos/opnsense/core/issues/2711/comments"},"review_comments":{"href":"https://api.github.com/repos/opnsense/core/pulls/2711/comments"},"review_comment":{"href":"https://api.github.com/repos/opnsense/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opnsense/core/pulls/2711/commits"},"statuses":{"href":"https://api.github.com/repos/opnsense/core/statuses/a2be62538d81ca3eaa97df656d11711fbdee1fde"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"fabianfrz"}}