{"action":"created","issue":{"url":"https://api.github.com/repos/MithrilJS/mithril.js/issues/2137","repository_url":"https://api.github.com/repos/MithrilJS/mithril.js","labels_url":"https://api.github.com/repos/MithrilJS/mithril.js/issues/2137/labels{/name}","comments_url":"https://api.github.com/repos/MithrilJS/mithril.js/issues/2137/comments","events_url":"https://api.github.com/repos/MithrilJS/mithril.js/issues/2137/events","html_url":"https://github.com/MithrilJS/mithril.js/pull/2137","id":318710949,"number":2137,"title":"feat(ospec): Accept list of filenames through stdin","user":{"login":"maranomynet","id":86827,"avatar_url":"https://avatars1.githubusercontent.com/u/86827?v=4","gravatar_id":"","url":"https://api.github.com/users/maranomynet","html_url":"https://github.com/maranomynet","followers_url":"https://api.github.com/users/maranomynet/followers","following_url":"https://api.github.com/users/maranomynet/following{/other_user}","gists_url":"https://api.github.com/users/maranomynet/gists{/gist_id}","starred_url":"https://api.github.com/users/maranomynet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maranomynet/subscriptions","organizations_url":"https://api.github.com/users/maranomynet/orgs","repos_url":"https://api.github.com/users/maranomynet/repos","events_url":"https://api.github.com/users/maranomynet/events{/privacy}","received_events_url":"https://api.github.com/users/maranomynet/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2018-04-29T11:51:46Z","updated_at":"2018-05-05T12:29:38Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/MithrilJS/mithril.js/pulls/2137","html_url":"https://github.com/MithrilJS/mithril.js/pull/2137","diff_url":"https://github.com/MithrilJS/mithril.js/pull/2137.diff","patch_url":"https://github.com/MithrilJS/mithril.js/pull/2137.patch"},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\nIn response to suggestions made in #2133 \r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n\r\nSee rationale in #2133 ...plus add support for custom file-name and folder patterns.\r\n\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n\r\n(Same as #2133 except with piping)\r\nTested on the command line within the mithril repo itself.\r\n\r\n```\r\n> cd mithril.js\r\n> find {stream,ospec}/**/tests/**/*.js | node ospec/bin/ospec\r\n1 assertions completed in 13ms, of which 0 failed\r\n377 assertions completed in 19ms, of which 0 failed\r\n> cd docs\r\n> find ../stream/**/tests/**/*.js | node ../ospec/bin/ospec\r\n95 assertions completed in 11ms, of which 0 failed\r\n```\r\netc. etc...\r\n\r\nIt should be safe to pass multiple instances of the same file as multiple `require()` calls to the same file only result in a single invocation of their side-effects.\r\n\r\n```\r\n> cd mithril.js\r\n> find stream/tests/*.js stream/**/tests/*.js | node ospec/bin/ospec\r\n95 assertions completed in 11ms, of which 0 failed\r\n```\r\n\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n- [ ] Documentation change\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [x] My change requires a change to the documentation.\r\n- [x] I have updated the documentation accordingly.\r\n- [x] I have read the **CONTRIBUTING** document.\r\n- [ ] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed.\r\n- [ ] I have updated `docs/change-log.md`\r\n"},"comment":{"url":"https://api.github.com/repos/MithrilJS/mithril.js/issues/comments/386802179","html_url":"https://github.com/MithrilJS/mithril.js/pull/2137#issuecomment-386802179","issue_url":"https://api.github.com/repos/MithrilJS/mithril.js/issues/2137","id":386802179,"user":{"login":"maranomynet","id":86827,"avatar_url":"https://avatars1.githubusercontent.com/u/86827?v=4","gravatar_id":"","url":"https://api.github.com/users/maranomynet","html_url":"https://github.com/maranomynet","followers_url":"https://api.github.com/users/maranomynet/followers","following_url":"https://api.github.com/users/maranomynet/following{/other_user}","gists_url":"https://api.github.com/users/maranomynet/gists{/gist_id}","starred_url":"https://api.github.com/users/maranomynet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maranomynet/subscriptions","organizations_url":"https://api.github.com/users/maranomynet/orgs","repos_url":"https://api.github.com/users/maranomynet/repos","events_url":"https://api.github.com/users/maranomynet/events{/privacy}","received_events_url":"https://api.github.com/users/maranomynet/received_events","type":"User","site_admin":false},"created_at":"2018-05-05T12:29:38Z","updated_at":"2018-05-05T12:29:38Z","author_association":"CONTRIBUTOR","body":"Hmm.. really?\r\nI'm on OSX running all of the above `find` commands, and they work fine.\r\n"}}
{"actor":{"display_login":"maranomynet"}}