{"action":"created","issue":{"url":"https://api.github.com/repos/quodlibet/quodlibet/issues/2567","repository_url":"https://api.github.com/repos/quodlibet/quodlibet","labels_url":"https://api.github.com/repos/quodlibet/quodlibet/issues/2567/labels{/name}","comments_url":"https://api.github.com/repos/quodlibet/quodlibet/issues/2567/comments","events_url":"https://api.github.com/repos/quodlibet/quodlibet/issues/2567/events","html_url":"https://github.com/quodlibet/quodlibet/pull/2567","id":258314357,"number":2567,"title":"make 'lyric_filename()' search harder","user":{"login":"elbeardmorez","id":2130062,"avatar_url":"https://avatars0.githubusercontent.com/u/2130062?v=4","gravatar_id":"","url":"https://api.github.com/users/elbeardmorez","html_url":"https://github.com/elbeardmorez","followers_url":"https://api.github.com/users/elbeardmorez/followers","following_url":"https://api.github.com/users/elbeardmorez/following{/other_user}","gists_url":"https://api.github.com/users/elbeardmorez/gists{/gist_id}","starred_url":"https://api.github.com/users/elbeardmorez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elbeardmorez/subscriptions","organizations_url":"https://api.github.com/users/elbeardmorez/orgs","repos_url":"https://api.github.com/users/elbeardmorez/repos","events_url":"https://api.github.com/users/elbeardmorez/events{/privacy}","received_events_url":"https://api.github.com/users/elbeardmorez/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-09-17T16:16:14Z","updated_at":"2018-03-18T07:16:59Z","closed_at":"2018-03-18T07:16:47Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/quodlibet/quodlibet/pulls/2567","html_url":"https://github.com/quodlibet/quodlibet/pull/2567","diff_url":"https://github.com/quodlibet/quodlibet/pull/2567.diff","patch_url":"https://github.com/quodlibet/quodlibet/pull/2567.patch"},"body":"Hi,\r\n\r\n**Here I wanted lyric files sourced via other programs to be visible in the View Lyrics pane**\r\n\r\nSo specifically, before this commit I'd have to manually rename any lyric file I wanted to see in the ViewLyrics pane to the bespoke ViewLyrics format of '_~/.lyrics/<artist/lyricartist>/<title>.lyric_', and now I don't have to, and that convenience is why I would like this patch to go into Quod Libet.\r\n\r\nTo facilitate this the changes added are:.\r\n\r\n> -search alternate extensions: 'lyrics', '', 'txt'\r\n> -add another default 'root'/'\\<artist\\> - \\<title\\>/lyric search path\r\n> -add local song path as another default search path\r\n> -add support for lyrics filename configuration via two '[memory]'\r\n> config variables: 'lyric_rootpaths' and 'lyric_filenames'. song\r\n> variables can also be used in these comma delimited list values.\r\n\r\n**config example:**\r\nlyric_filenames = \\<artist\\>.-.\\<title\\>,\\<artist\\> - \\<title\\>.lyrics_mod\r\nlyric_rootpaths = ~/music/lyrics\r\n\r\n**debug example:**\r\n> D: 1.660: ViewLyrics.plugin_on_song_started: Looking for lyrics for ~/media/music/library/Dire Straits/Money for Nothing (1988)/09. Dire Straits - Private Investigations.mp3\r\n> D: 1.660: MP3File.lyric_filename:\r\n>     searching for lyrics in:\r\n>     ~/media/music/lyrics/\\<artist\\>.-.\\<title\\>\r\n>     ~/media/music/lyrics/\\<artist\\> - \\<title\\>.lyrics_mod\r\n>     ~/media/music/lyrics/Dire Straits/Private Investigations.lyric\r\n>     ~/media/music/lyrics/Dire Straits - Private Investigations.lyric\r\n>     ~/.lyrics/\\<artist\\>.-.\\<title\\>\r\n>     ~/.lyrics/\\<artist\\> - \\<title\\>.lyrics_mod\r\n>     ~/.lyrics/Dire Straits/Private Investigations.lyric\r\n>     ~/.lyrics/Dire Straits - Private Investigations.lyric\r\n>     ~/media/music/library/Dire Straits/Money for Nothing (1988)/\\<artist\\>.-.\\<title\\>\r\n>     ~/media/music/library/Dire Straits/Money for Nothing (1988)/\\<artist\\> - \\<title\\>.lyrics_mod\r\n>     ~/media/music/library/Dire Straits/Money for Nothing (1988)/Dire Straits/Private Investigations.lyric\r\n>     ~/media/music/library/Dire Straits/Money for Nothing (1988)/Dire Straits - Private Investigations.lyric\r\n> D: 1.661: MP3File.lyric_filename: extending search to extensions: ['lyric', 'lyrics', '', 'txt']\r\n> D: 1.661: MP3File.__call__: Reading lyrics from ~/media/music/lyrics/Dire Straits - Private Investigations.txt\r\n"},"comment":{"url":"https://api.github.com/repos/quodlibet/quodlibet/issues/comments/373977758","html_url":"https://github.com/quodlibet/quodlibet/pull/2567#issuecomment-373977758","issue_url":"https://api.github.com/repos/quodlibet/quodlibet/issues/2567","id":373977758,"user":{"login":"declension","id":3322808,"avatar_url":"https://avatars0.githubusercontent.com/u/3322808?v=4","gravatar_id":"","url":"https://api.github.com/users/declension","html_url":"https://github.com/declension","followers_url":"https://api.github.com/users/declension/followers","following_url":"https://api.github.com/users/declension/following{/other_user}","gists_url":"https://api.github.com/users/declension/gists{/gist_id}","starred_url":"https://api.github.com/users/declension/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/declension/subscriptions","organizations_url":"https://api.github.com/users/declension/orgs","repos_url":"https://api.github.com/users/declension/repos","events_url":"https://api.github.com/users/declension/events{/privacy}","received_events_url":"https://api.github.com/users/declension/received_events","type":"User","site_admin":false},"created_at":"2018-03-18T07:16:59Z","updated_at":"2018-03-18T07:16:59Z","author_association":"OWNER","body":"Thanks!"}}
{"actor":{"display_login":"declension"}}