{"action":"closed","number":680,"pull_request":{"url":"https://api.github.com/repos/SkygearIO/skygear-server/pulls/680","id":218577189,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NTc3MTg5","html_url":"https://github.com/SkygearIO/skygear-server/pull/680","diff_url":"https://github.com/SkygearIO/skygear-server/pull/680.diff","patch_url":"https://github.com/SkygearIO/skygear-server/pull/680.patch","issue_url":"https://api.github.com/repos/SkygearIO/skygear-server/issues/680","number":680,"state":"closed","locked":false,"title":"next: Signup with password","user":{"login":"Steven-Chan","id":12228201,"node_id":"MDQ6VXNlcjEyMjI4MjAx","avatar_url":"https://avatars1.githubusercontent.com/u/12228201?v=4","gravatar_id":"","url":"https://api.github.com/users/Steven-Chan","html_url":"https://github.com/Steven-Chan","followers_url":"https://api.github.com/users/Steven-Chan/followers","following_url":"https://api.github.com/users/Steven-Chan/following{/other_user}","gists_url":"https://api.github.com/users/Steven-Chan/gists{/gist_id}","starred_url":"https://api.github.com/users/Steven-Chan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Steven-Chan/subscriptions","organizations_url":"https://api.github.com/users/Steven-Chan/orgs","repos_url":"https://api.github.com/users/Steven-Chan/repos","events_url":"https://api.github.com/users/Steven-Chan/events{/privacy}","received_events_url":"https://api.github.com/users/Steven-Chan/received_events","type":"User","site_admin":false},"body":"connect #663 \r\n\r\n---\r\n\r\nI've picked the name `password`, and the table name `_auth_provider_password`, which tries to match the oauth grant type password. But I just realised that we are calling this type of signup/login auth data, e.g. signupWithAuthData and loginWithAuthData in SDK.\r\n\r\n@rickmak @carmenlau any thought on this, I suggest we decide it earlier about the naming thing to avoid refactoring and dealing with conflict.","created_at":"2018-09-27T09:09:26Z","updated_at":"2018-10-03T07:32:41Z","closed_at":"2018-10-03T07:32:41Z","merged_at":"2018-10-03T07:32:41Z","merge_commit_sha":"ac445d8431951254f30595f6abf9b83ddb0547f5","assignee":{"login":"rickmak","id":62677,"node_id":"MDQ6VXNlcjYyNjc3","avatar_url":"https://avatars3.githubusercontent.com/u/62677?v=4","gravatar_id":"","url":"https://api.github.com/users/rickmak","html_url":"https://github.com/rickmak","followers_url":"https://api.github.com/users/rickmak/followers","following_url":"https://api.github.com/users/rickmak/following{/other_user}","gists_url":"https://api.github.com/users/rickmak/gists{/gist_id}","starred_url":"https://api.github.com/users/rickmak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rickmak/subscriptions","organizations_url":"https://api.github.com/users/rickmak/orgs","repos_url":"https://api.github.com/users/rickmak/repos","events_url":"https://api.github.com/users/rickmak/events{/privacy}","received_events_url":"https://api.github.com/users/rickmak/received_events","type":"User","site_admin":false},"assignees":[{"login":"rickmak","id":62677,"node_id":"MDQ6VXNlcjYyNjc3","avatar_url":"https://avatars3.githubusercontent.com/u/62677?v=4","gravatar_id":"","url":"https://api.github.com/users/rickmak","html_url":"https://github.com/rickmak","followers_url":"https://api.github.com/users/rickmak/followers","following_url":"https://api.github.com/users/rickmak/following{/other_user}","gists_url":"https://api.github.com/users/rickmak/gists{/gist_id}","starred_url":"https://api.github.com/users/rickmak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rickmak/subscriptions","organizations_url":"https://api.github.com/users/rickmak/orgs","repos_url":"https://api.github.com/users/rickmak/repos","events_url":"https://api.github.com/users/rickmak/events{/privacy}","received_events_url":"https://api.github.com/users/rickmak/received_events","type":"User","site_admin":false},{"login":"carmenlau","id":388892,"node_id":"MDQ6VXNlcjM4ODg5Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/388892?v=4","gravatar_id":"","url":"https://api.github.com/users/carmenlau","html_url":"https://github.com/carmenlau","followers_url":"https://api.github.com/users/carmenlau/followers","following_url":"https://api.github.com/users/carmenlau/following{/other_user}","gists_url":"https://api.github.com/users/carmenlau/gists{/gist_id}","starred_url":"https://api.github.com/users/carmenlau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carmenlau/subscriptions","organizations_url":"https://api.github.com/users/carmenlau/orgs","repos_url":"https://api.github.com/users/carmenlau/repos","events_url":"https://api.github.com/users/carmenlau/events{/privacy}","received_events_url":"https://api.github.com/users/carmenlau/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1041247475,"node_id":"MDU6TGFiZWwxMDQxMjQ3NDc1","url":"https://api.github.com/repos/SkygearIO/skygear-server/labels/workflow/Review","name":"workflow/Review","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/SkygearIO/skygear-server/pulls/680/commits","review_comments_url":"https://api.github.com/repos/SkygearIO/skygear-server/pulls/680/comments","review_comment_url":"https://api.github.com/repos/SkygearIO/skygear-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SkygearIO/skygear-server/issues/680/comments","statuses_url":"https://api.github.com/repos/SkygearIO/skygear-server/statuses/ac445d8431951254f30595f6abf9b83ddb0547f5","head":{"label":"Steven-Chan:signup-password","ref":"signup-password","sha":"ac445d8431951254f30595f6abf9b83ddb0547f5","user":{"login":"Steven-Chan","id":12228201,"node_id":"MDQ6VXNlcjEyMjI4MjAx","avatar_url":"https://avatars1.githubusercontent.com/u/12228201?v=4","gravatar_id":"","url":"https://api.github.com/users/Steven-Chan","html_url":"https://github.com/Steven-Chan","followers_url":"https://api.github.com/users/Steven-Chan/followers","following_url":"https://api.github.com/users/Steven-Chan/following{/other_user}","gists_url":"https://api.github.com/users/Steven-Chan/gists{/gist_id}","starred_url":"https://api.github.com/users/Steven-Chan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Steven-Chan/subscriptions","organizations_url":"https://api.github.com/users/Steven-Chan/orgs","repos_url":"https://api.github.com/users/Steven-Chan/repos","events_url":"https://api.github.com/users/Steven-Chan/events{/privacy}","received_events_url":"https://api.github.com/users/Steven-Chan/received_events","type":"User","site_admin":false},"repo":{"id":85668618,"node_id":"MDEwOlJlcG9zaXRvcnk4NTY2ODYxOA==","name":"skygear-server","full_name":"Steven-Chan/skygear-server","private":false,"owner":{"login":"Steven-Chan","id":12228201,"node_id":"MDQ6VXNlcjEyMjI4MjAx","avatar_url":"https://avatars1.githubusercontent.com/u/12228201?v=4","gravatar_id":"","url":"https://api.github.com/users/Steven-Chan","html_url":"https://github.com/Steven-Chan","followers_url":"https://api.github.com/users/Steven-Chan/followers","following_url":"https://api.github.com/users/Steven-Chan/following{/other_user}","gists_url":"https://api.github.com/users/Steven-Chan/gists{/gist_id}","starred_url":"https://api.github.com/users/Steven-Chan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Steven-Chan/subscriptions","organizations_url":"https://api.github.com/users/Steven-Chan/orgs","repos_url":"https://api.github.com/users/Steven-Chan/repos","events_url":"https://api.github.com/users/Steven-Chan/events{/privacy}","received_events_url":"https://api.github.com/users/Steven-Chan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Steven-Chan/skygear-server","description":"Skygear Server - Open-source Mobile Backend, making app development easier.","fork":true,"url":"https://api.github.com/repos/Steven-Chan/skygear-server","forks_url":"https://api.github.com/repos/Steven-Chan/skygear-server/forks","keys_url":"https://api.github.com/repos/Steven-Chan/skygear-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Steven-Chan/skygear-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Steven-Chan/skygear-server/teams","hooks_url":"https://api.github.com/repos/Steven-Chan/skygear-server/hooks","issue_events_url":"https://api.github.com/repos/Steven-Chan/skygear-server/issues/events{/number}","events_url":"https://api.github.com/repos/Steven-Chan/skygear-server/events","assignees_url":"https://api.github.com/repos/Steven-Chan/skygear-server/assignees{/user}","branches_url":"https://api.github.com/repos/Steven-Chan/skygear-server/branches{/branch}","tags_url":"https://api.github.com/repos/Steven-Chan/skygear-server/tags","blobs_url":"https://api.github.com/repos/Steven-Chan/skygear-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Steven-Chan/skygear-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Steven-Chan/skygear-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/Steven-Chan/skygear-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Steven-Chan/skygear-server/statuses/{sha}","languages_url":"https://api.github.com/repos/Steven-Chan/skygear-server/languages","stargazers_url":"https://api.github.com/repos/Steven-Chan/skygear-server/stargazers","contributors_url":"https://api.github.com/repos/Steven-Chan/skygear-server/contributors","subscribers_url":"https://api.github.com/repos/Steven-Chan/skygear-server/subscribers","subscription_url":"https://api.github.com/repos/Steven-Chan/skygear-server/subscription","commits_url":"https://api.github.com/repos/Steven-Chan/skygear-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/Steven-Chan/skygear-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/Steven-Chan/skygear-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/Steven-Chan/skygear-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/Steven-Chan/skygear-server/contents/{+path}","compare_url":"https://api.github.com/repos/Steven-Chan/skygear-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Steven-Chan/skygear-server/merges","archive_url":"https://api.github.com/repos/Steven-Chan/skygear-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Steven-Chan/skygear-server/downloads","issues_url":"https://api.github.com/repos/Steven-Chan/skygear-server/issues{/number}","pulls_url":"https://api.github.com/repos/Steven-Chan/skygear-server/pulls{/number}","milestones_url":"https://api.github.com/repos/Steven-Chan/skygear-server/milestones{/number}","notifications_url":"https://api.github.com/repos/Steven-Chan/skygear-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Steven-Chan/skygear-server/labels{/name}","releases_url":"https://api.github.com/repos/Steven-Chan/skygear-server/releases{/id}","deployments_url":"https://api.github.com/repos/Steven-Chan/skygear-server/deployments","created_at":"2017-03-21T06:47:35Z","updated_at":"2017-03-21T06:47:38Z","pushed_at":"2018-10-03T04:09:25Z","git_url":"git://github.com/Steven-Chan/skygear-server.git","ssh_url":"git@github.com:Steven-Chan/skygear-server.git","clone_url":"https://github.com/Steven-Chan/skygear-server.git","svn_url":"https://github.com/Steven-Chan/skygear-server","homepage":"https://skygear.io","size":3118,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SkygearIO:next","ref":"next","sha":"ea7ab1aa8d0fecc017fd4742c0db9162bfcbf4ad","user":{"login":"SkygearIO","id":15025887,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDI1ODg3","avatar_url":"https://avatars1.githubusercontent.com/u/15025887?v=4","gravatar_id":"","url":"https://api.github.com/users/SkygearIO","html_url":"https://github.com/SkygearIO","followers_url":"https://api.github.com/users/SkygearIO/followers","following_url":"https://api.github.com/users/SkygearIO/following{/other_user}","gists_url":"https://api.github.com/users/SkygearIO/gists{/gist_id}","starred_url":"https://api.github.com/users/SkygearIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkygearIO/subscriptions","organizations_url":"https://api.github.com/users/SkygearIO/orgs","repos_url":"https://api.github.com/users/SkygearIO/repos","events_url":"https://api.github.com/users/SkygearIO/events{/privacy}","received_events_url":"https://api.github.com/users/SkygearIO/received_events","type":"Organization","site_admin":false},"repo":{"id":54106815,"node_id":"MDEwOlJlcG9zaXRvcnk1NDEwNjgxNQ==","name":"skygear-server","full_name":"SkygearIO/skygear-server","private":false,"owner":{"login":"SkygearIO","id":15025887,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDI1ODg3","avatar_url":"https://avatars1.githubusercontent.com/u/15025887?v=4","gravatar_id":"","url":"https://api.github.com/users/SkygearIO","html_url":"https://github.com/SkygearIO","followers_url":"https://api.github.com/users/SkygearIO/followers","following_url":"https://api.github.com/users/SkygearIO/following{/other_user}","gists_url":"https://api.github.com/users/SkygearIO/gists{/gist_id}","starred_url":"https://api.github.com/users/SkygearIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkygearIO/subscriptions","organizations_url":"https://api.github.com/users/SkygearIO/orgs","repos_url":"https://api.github.com/users/SkygearIO/repos","events_url":"https://api.github.com/users/SkygearIO/events{/privacy}","received_events_url":"https://api.github.com/users/SkygearIO/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SkygearIO/skygear-server","description":"Skygear Server - Open-source Mobile Backend, making app development easier.","fork":false,"url":"https://api.github.com/repos/SkygearIO/skygear-server","forks_url":"https://api.github.com/repos/SkygearIO/skygear-server/forks","keys_url":"https://api.github.com/repos/SkygearIO/skygear-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SkygearIO/skygear-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SkygearIO/skygear-server/teams","hooks_url":"https://api.github.com/repos/SkygearIO/skygear-server/hooks","issue_events_url":"https://api.github.com/repos/SkygearIO/skygear-server/issues/events{/number}","events_url":"https://api.github.com/repos/SkygearIO/skygear-server/events","assignees_url":"https://api.github.com/repos/SkygearIO/skygear-server/assignees{/user}","branches_url":"https://api.github.com/repos/SkygearIO/skygear-server/branches{/branch}","tags_url":"https://api.github.com/repos/SkygearIO/skygear-server/tags","blobs_url":"https://api.github.com/repos/SkygearIO/skygear-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SkygearIO/skygear-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SkygearIO/skygear-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/SkygearIO/skygear-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SkygearIO/skygear-server/statuses/{sha}","languages_url":"https://api.github.com/repos/SkygearIO/skygear-server/languages","stargazers_url":"https://api.github.com/repos/SkygearIO/skygear-server/stargazers","contributors_url":"https://api.github.com/repos/SkygearIO/skygear-server/contributors","subscribers_url":"https://api.github.com/repos/SkygearIO/skygear-server/subscribers","subscription_url":"https://api.github.com/repos/SkygearIO/skygear-server/subscription","commits_url":"https://api.github.com/repos/SkygearIO/skygear-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/SkygearIO/skygear-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/SkygearIO/skygear-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/SkygearIO/skygear-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/SkygearIO/skygear-server/contents/{+path}","compare_url":"https://api.github.com/repos/SkygearIO/skygear-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SkygearIO/skygear-server/merges","archive_url":"https://api.github.com/repos/SkygearIO/skygear-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SkygearIO/skygear-server/downloads","issues_url":"https://api.github.com/repos/SkygearIO/skygear-server/issues{/number}","pulls_url":"https://api.github.com/repos/SkygearIO/skygear-server/pulls{/number}","milestones_url":"https://api.github.com/repos/SkygearIO/skygear-server/milestones{/number}","notifications_url":"https://api.github.com/repos/SkygearIO/skygear-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SkygearIO/skygear-server/labels{/name}","releases_url":"https://api.github.com/repos/SkygearIO/skygear-server/releases{/id}","deployments_url":"https://api.github.com/repos/SkygearIO/skygear-server/deployments","created_at":"2016-03-17T09:48:42Z","updated_at":"2018-10-02T07:31:04Z","pushed_at":"2018-10-03T07:32:41Z","git_url":"git://github.com/SkygearIO/skygear-server.git","ssh_url":"git@github.com:SkygearIO/skygear-server.git","clone_url":"https://github.com/SkygearIO/skygear-server.git","svn_url":"https://github.com/SkygearIO/skygear-server","homepage":"https://skygear.io","size":3101,"stargazers_count":305,"watchers_count":305,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":69,"mirror_url":null,"archived":false,"open_issues_count":115,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":69,"open_issues":115,"watchers":305,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SkygearIO/skygear-server/pulls/680"},"html":{"href":"https://github.com/SkygearIO/skygear-server/pull/680"},"issue":{"href":"https://api.github.com/repos/SkygearIO/skygear-server/issues/680"},"comments":{"href":"https://api.github.com/repos/SkygearIO/skygear-server/issues/680/comments"},"review_comments":{"href":"https://api.github.com/repos/SkygearIO/skygear-server/pulls/680/comments"},"review_comment":{"href":"https://api.github.com/repos/SkygearIO/skygear-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SkygearIO/skygear-server/pulls/680/commits"},"statuses":{"href":"https://api.github.com/repos/SkygearIO/skygear-server/statuses/ac445d8431951254f30595f6abf9b83ddb0547f5"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"rickmak","id":62677,"node_id":"MDQ6VXNlcjYyNjc3","avatar_url":"https://avatars3.githubusercontent.com/u/62677?v=4","gravatar_id":"","url":"https://api.github.com/users/rickmak","html_url":"https://github.com/rickmak","followers_url":"https://api.github.com/users/rickmak/followers","following_url":"https://api.github.com/users/rickmak/following{/other_user}","gists_url":"https://api.github.com/users/rickmak/gists{/gist_id}","starred_url":"https://api.github.com/users/rickmak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rickmak/subscriptions","organizations_url":"https://api.github.com/users/rickmak/orgs","repos_url":"https://api.github.com/users/rickmak/repos","events_url":"https://api.github.com/users/rickmak/events{/privacy}","received_events_url":"https://api.github.com/users/rickmak/received_events","type":"User","site_admin":false},"comments":1,"review_comments":7,"maintainer_can_modify":false,"commits":5,"additions":148,"deletions":35,"changed_files":8}}
{"actor":{"display_login":"rickmak"}}