{"action":"created","comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/205935749","pull_request_review_id":141310226,"id":205935749,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTkzNTc0OQ==","diff_hunk":"@@ -233,3 +236,11 @@ def speed_list(self: ToggleEntity) -> list:\n     def supported_features(self: ToggleEntity) -> int:\n         \"\"\"Flag supported features.\"\"\"\n         return SUPPORT_OSCILLATE | SUPPORT_SET_SPEED\n+\n+    @property\n+    def state_attributes(self: ToggleEntity) -> dict:\n+        \"\"\"Return optional state attributes.\"\"\"\n+        attributes = super().state_attributes\n+        attributes[ATTR_IS_NIGHT_MODE] = self.is_night_mode","path":"homeassistant/components/fan/dyson.py","position":28,"original_position":28,"commit_id":"2007cfd49eea90c0527e507f458a6d4bf0215cb4","original_commit_id":"2007cfd49eea90c0527e507f458a6d4bf0215cb4","user":{"login":"soraxas","id":22362177,"node_id":"MDQ6VXNlcjIyMzYyMTc3","avatar_url":"https://avatars2.githubusercontent.com/u/22362177?v=4","gravatar_id":"","url":"https://api.github.com/users/soraxas","html_url":"https://github.com/soraxas","followers_url":"https://api.github.com/users/soraxas/followers","following_url":"https://api.github.com/users/soraxas/following{/other_user}","gists_url":"https://api.github.com/users/soraxas/gists{/gist_id}","starred_url":"https://api.github.com/users/soraxas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soraxas/subscriptions","organizations_url":"https://api.github.com/users/soraxas/orgs","repos_url":"https://api.github.com/users/soraxas/repos","events_url":"https://api.github.com/users/soraxas/events{/privacy}","received_events_url":"https://api.github.com/users/soraxas/received_events","type":"User","site_admin":false},"body":"Yes the code is correct. The property is defined in [line 185](https://github.com/soraxas/home-assistant/blob/2007cfd49eea90c0527e507f458a6d4bf0215cb4/homeassistant/components/fan/dyson.py#L185). Similar for `self.is_auto_mode`.","created_at":"2018-07-28T07:22:07Z","updated_at":"2018-07-28T07:22:08Z","html_url":"https://github.com/home-assistant/home-assistant/pull/15716#discussion_r205935749","pull_request_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/15716","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/205935749"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/15716#discussion_r205935749"},"pull_request":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/15716"}},"in_reply_to_id":205934829},"pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/15716","id":204578946,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NTc4OTQ2","html_url":"https://github.com/home-assistant/home-assistant/pull/15716","diff_url":"https://github.com/home-assistant/home-assistant/pull/15716.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/15716.patch","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/15716","number":15716,"state":"open","locked":false,"title":"Dyson Fan - Exposes internal states and fixed on/off state","user":{"login":"soraxas","id":22362177,"node_id":"MDQ6VXNlcjIyMzYyMTc3","avatar_url":"https://avatars2.githubusercontent.com/u/22362177?v=4","gravatar_id":"","url":"https://api.github.com/users/soraxas","html_url":"https://github.com/soraxas","followers_url":"https://api.github.com/users/soraxas/followers","following_url":"https://api.github.com/users/soraxas/following{/other_user}","gists_url":"https://api.github.com/users/soraxas/gists{/gist_id}","starred_url":"https://api.github.com/users/soraxas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soraxas/subscriptions","organizations_url":"https://api.github.com/users/soraxas/orgs","repos_url":"https://api.github.com/users/soraxas/repos","events_url":"https://api.github.com/users/soraxas/events{/privacy}","received_events_url":"https://api.github.com/users/soraxas/received_events","type":"User","site_admin":false},"body":"## Description:\r\nThis PR exposes some internal state to user (namely the night mode and auto mode) via `state_attributes`.\r\n\r\nIn addition, there's a fix on issues of the on/off state of Dyson fan. Upstream library (and in turns the internal structure of dyson fan) has two similar attributes, `fan_state` and `fan_mode`. For a **Dyson Pure Cool Fan**, I think they are essentially the same (always has the same value). However, in **Dyson Pure Hot+Cool Fan** there is a subtle difference. In **Hot+Cool Fan** there is an additional `idle` mode when the fan is in **heat** mode but the target temperature is below the current temperature. That is, the fan is **on**, but since the target temperature is below the current temperature the fan speed becomes slower and it stops outputing heated wind.\r\n\r\nIf we use `fan_state` as it's on/off state, the fan will be recognised as off when the fan is in `idle`, which is incorrect. We should use `fan_mode` instead as it represent the true power state of the fan.\r\n\r\n## Checklist:\r\n  - [x] The code change is tested and works locally.\r\n  - [x] Local tests pass with `tox`. **Your PR cannot be merged unless tests pass**\r\n  - [x] No new dependencies apart of those from the parent component. \r\n  - [x] Unit tests have been added to verify that the new code works.\r\n  - [x] Tests have been added to verify that the new code works.","created_at":"2018-07-28T06:10:48Z","updated_at":"2018-07-28T07:22:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a78bcfdb62b2bbb312bd841ce936857ae4c60ebd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":527871105,"node_id":"MDU6TGFiZWw1Mjc4NzExMDU=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/cla-signed","name":"cla-signed","color":"008000","default":false},{"id":955422305,"node_id":"MDU6TGFiZWw5NTU0MjIzMDU=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/in%20progress","name":"in progress","color":"ededed","default":false},{"id":629997332,"node_id":"MDU6TGFiZWw2Mjk5OTczMzI=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/platform:%20fan.dyson","name":"platform: fan.dyson","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/15716/commits","review_comments_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/15716/comments","review_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/15716/comments","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/2007cfd49eea90c0527e507f458a6d4bf0215cb4","head":{"label":"soraxas:dysonfan","ref":"dysonfan","sha":"2007cfd49eea90c0527e507f458a6d4bf0215cb4","user":{"login":"soraxas","id":22362177,"node_id":"MDQ6VXNlcjIyMzYyMTc3","avatar_url":"https://avatars2.githubusercontent.com/u/22362177?v=4","gravatar_id":"","url":"https://api.github.com/users/soraxas","html_url":"https://github.com/soraxas","followers_url":"https://api.github.com/users/soraxas/followers","following_url":"https://api.github.com/users/soraxas/following{/other_user}","gists_url":"https://api.github.com/users/soraxas/gists{/gist_id}","starred_url":"https://api.github.com/users/soraxas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soraxas/subscriptions","organizations_url":"https://api.github.com/users/soraxas/orgs","repos_url":"https://api.github.com/users/soraxas/repos","events_url":"https://api.github.com/users/soraxas/events{/privacy}","received_events_url":"https://api.github.com/users/soraxas/received_events","type":"User","site_admin":false},"repo":{"id":111978004,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE5NzgwMDQ=","name":"home-assistant","full_name":"soraxas/home-assistant","owner":{"login":"soraxas","id":22362177,"node_id":"MDQ6VXNlcjIyMzYyMTc3","avatar_url":"https://avatars2.githubusercontent.com/u/22362177?v=4","gravatar_id":"","url":"https://api.github.com/users/soraxas","html_url":"https://github.com/soraxas","followers_url":"https://api.github.com/users/soraxas/followers","following_url":"https://api.github.com/users/soraxas/following{/other_user}","gists_url":"https://api.github.com/users/soraxas/gists{/gist_id}","starred_url":"https://api.github.com/users/soraxas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soraxas/subscriptions","organizations_url":"https://api.github.com/users/soraxas/orgs","repos_url":"https://api.github.com/users/soraxas/repos","events_url":"https://api.github.com/users/soraxas/events{/privacy}","received_events_url":"https://api.github.com/users/soraxas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/soraxas/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":true,"url":"https://api.github.com/repos/soraxas/home-assistant","forks_url":"https://api.github.com/repos/soraxas/home-assistant/forks","keys_url":"https://api.github.com/repos/soraxas/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/soraxas/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/soraxas/home-assistant/teams","hooks_url":"https://api.github.com/repos/soraxas/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/soraxas/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/soraxas/home-assistant/events","assignees_url":"https://api.github.com/repos/soraxas/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/soraxas/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/soraxas/home-assistant/tags","blobs_url":"https://api.github.com/repos/soraxas/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/soraxas/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/soraxas/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/soraxas/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/soraxas/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/soraxas/home-assistant/languages","stargazers_url":"https://api.github.com/repos/soraxas/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/soraxas/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/soraxas/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/soraxas/home-assistant/subscription","commits_url":"https://api.github.com/repos/soraxas/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/soraxas/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/soraxas/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/soraxas/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/soraxas/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/soraxas/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/soraxas/home-assistant/merges","archive_url":"https://api.github.com/repos/soraxas/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/soraxas/home-assistant/downloads","issues_url":"https://api.github.com/repos/soraxas/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/soraxas/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/soraxas/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/soraxas/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/soraxas/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/soraxas/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/soraxas/home-assistant/deployments","created_at":"2017-11-25T05:03:35Z","updated_at":"2018-07-27T07:22:18Z","pushed_at":"2018-07-28T06:32:08Z","git_url":"git://github.com/soraxas/home-assistant.git","ssh_url":"git@github.com:soraxas/home-assistant.git","clone_url":"https://github.com/soraxas/home-assistant.git","svn_url":"https://github.com/soraxas/home-assistant","homepage":"https://home-assistant.io","size":85582,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"home-assistant:dev","ref":"dev","sha":"944f4f7c051c21dc00238595e086d1a01f6f235c","user":{"login":"home-assistant","id":13844975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODQ0OTc1","avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":12888993,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg4ODk5Mw==","name":"home-assistant","full_name":"home-assistant/home-assistant","owner":{"login":"home-assistant","id":13844975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODQ0OTc1","avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/home-assistant/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant","forks_url":"https://api.github.com/repos/home-assistant/home-assistant/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant/deployments","created_at":"2013-09-17T07:29:48Z","updated_at":"2018-07-28T02:45:16Z","pushed_at":"2018-07-28T06:32:10Z","git_url":"git://github.com/home-assistant/home-assistant.git","ssh_url":"git@github.com:home-assistant/home-assistant.git","clone_url":"https://github.com/home-assistant/home-assistant.git","svn_url":"https://github.com/home-assistant/home-assistant","homepage":"https://home-assistant.io","size":85199,"stargazers_count":15417,"watchers_count":15417,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4616,"mirror_url":null,"archived":false,"open_issues_count":816,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4616,"open_issues":816,"watchers":15417,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/15716"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/15716"},"issue":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/15716"},"comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/15716/comments"},"review_comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/15716/comments"},"review_comment":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/15716/commits"},"statuses":{"href":"https://api.github.com/repos/home-assistant/home-assistant/statuses/2007cfd49eea90c0527e507f458a6d4bf0215cb4"}},"author_association":"NONE"}}
{"actor":{"display_login":"soraxas"}}