{"action":"created","comment":{"url":"https://api.github.com/repos/USGS-R/scipiper/pulls/comments/243015875","pull_request_review_id":186673121,"id":243015875,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzAxNTg3NQ==","diff_hunk":"@@ -82,23 +83,43 @@ create_task_makefile <- function(\n   }), use.names=FALSE)\n   job_output <- if(isTRUE(ind_complete) || is.na(ind_complete)) {\n     if(is.null(ind_dir)) stop('ind_dir must not be NULL when ind_complete=TRUE')\n-    file.path(ind_dir, as_ind_file(job_target, ind_ext))\n+    file.path(ind_dir, as_ind_file(target_name, ind_ext))\n   } else {\n-    sprintf('%s_%s', job_target, ind_ext)\n+    sprintf('%s_%s', target_name, ind_ext)\n   }\n+  \n+  # prepare the task list for rendering\n+  tasks <- unname(task_plan) # remove list element names where they'd interfere with whisker.render\n+  for(task in seq_along(tasks)) {\n+    # remove lmore ist element names where they'd interfere with whisker.render\n+    tasks[[task]]$steps <- unname(tasks[[task]]$steps)\n+    for(step in seq_along(tasks[[task]]$steps)) {\n+      # add a logical for has_depends\n+      tasks[[task]]$steps[[step]]$has_depends <- length(tasks[[task]]$steps[[step]]$depends) > 0\n+    }\n+  }\n+  \n   job <- list(\n-    target_name = job_target,\n+    target_name = target_name,\n     # even though target_name is an object (not file), job_command should write\n     # to ind_file - again so the calling remake file can use\n     # ind_file as its target\n     command = {\n+      if(!is.null(finalize_fun)){\n+        if(isTRUE(ind_complete) | is.na(ind_complete)) {\n+          message('ind_complete=', ind_complete, ' is incompatable with ', finalize_fun, '(). Using FALSE')\n+          ind_complete <- FALSE\n+          # and will need to skip hashing...\n+        }\n+        sprintf(\"%s(target_name = %s,\\n)\", finalize_fun, target_name) # and more w/ ...","path":"R/create_task_makefile.R","position":54,"original_position":54,"commit_id":"5e416e3d500f35b75d760dc7841092c345865dc9","original_commit_id":"5e416e3d500f35b75d760dc7841092c345865dc9","user":{"login":"jread-usgs","id":2349007,"node_id":"MDQ6VXNlcjIzNDkwMDc=","avatar_url":"https://avatars2.githubusercontent.com/u/2349007?v=4","gravatar_id":"","url":"https://api.github.com/users/jread-usgs","html_url":"https://github.com/jread-usgs","followers_url":"https://api.github.com/users/jread-usgs/followers","following_url":"https://api.github.com/users/jread-usgs/following{/other_user}","gists_url":"https://api.github.com/users/jread-usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/jread-usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jread-usgs/subscriptions","organizations_url":"https://api.github.com/users/jread-usgs/orgs","repos_url":"https://api.github.com/users/jread-usgs/repos","events_url":"https://api.github.com/users/jread-usgs/events{/privacy}","received_events_url":"https://api.github.com/users/jread-usgs/received_events","type":"User","site_admin":false},"body":"ahh yep, you are right. ","created_at":"2018-12-19T17:54:52Z","updated_at":"2018-12-19T17:54:52Z","html_url":"https://github.com/USGS-R/scipiper/pull/86#discussion_r243015875","pull_request_url":"https://api.github.com/repos/USGS-R/scipiper/pulls/86","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/USGS-R/scipiper/pulls/comments/243015875"},"html":{"href":"https://github.com/USGS-R/scipiper/pull/86#discussion_r243015875"},"pull_request":{"href":"https://api.github.com/repos/USGS-R/scipiper/pulls/86"}},"in_reply_to_id":242959718},"pull_request":{"url":"https://api.github.com/repos/USGS-R/scipiper/pulls/86","id":239863805,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5ODYzODA1","html_url":"https://github.com/USGS-R/scipiper/pull/86","diff_url":"https://github.com/USGS-R/scipiper/pull/86.diff","patch_url":"https://github.com/USGS-R/scipiper/pull/86.patch","issue_url":"https://api.github.com/repos/USGS-R/scipiper/issues/86","number":86,"state":"open","locked":false,"title":"initial ideas for combine #52","user":{"login":"jread-usgs","id":2349007,"node_id":"MDQ6VXNlcjIzNDkwMDc=","avatar_url":"https://avatars2.githubusercontent.com/u/2349007?v=4","gravatar_id":"","url":"https://api.github.com/users/jread-usgs","html_url":"https://github.com/jread-usgs","followers_url":"https://api.github.com/users/jread-usgs/followers","following_url":"https://api.github.com/users/jread-usgs/following{/other_user}","gists_url":"https://api.github.com/users/jread-usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/jread-usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jread-usgs/subscriptions","organizations_url":"https://api.github.com/users/jread-usgs/orgs","repos_url":"https://api.github.com/users/jread-usgs/repos","events_url":"https://api.github.com/users/jread-usgs/events{/privacy}","received_events_url":"https://api.github.com/users/jread-usgs/received_events","type":"User","site_admin":false},"body":"initial PR for comment","created_at":"2018-12-19T14:54:05Z","updated_at":"2018-12-19T17:54:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e32f6e522ea672a1f8397e46224c6648e34e0061","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/USGS-R/scipiper/pulls/86/commits","review_comments_url":"https://api.github.com/repos/USGS-R/scipiper/pulls/86/comments","review_comment_url":"https://api.github.com/repos/USGS-R/scipiper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/USGS-R/scipiper/issues/86/comments","statuses_url":"https://api.github.com/repos/USGS-R/scipiper/statuses/5e416e3d500f35b75d760dc7841092c345865dc9","head":{"label":"jread-usgs:task_combiners","ref":"task_combiners","sha":"5e416e3d500f35b75d760dc7841092c345865dc9","user":{"login":"jread-usgs","id":2349007,"node_id":"MDQ6VXNlcjIzNDkwMDc=","avatar_url":"https://avatars2.githubusercontent.com/u/2349007?v=4","gravatar_id":"","url":"https://api.github.com/users/jread-usgs","html_url":"https://github.com/jread-usgs","followers_url":"https://api.github.com/users/jread-usgs/followers","following_url":"https://api.github.com/users/jread-usgs/following{/other_user}","gists_url":"https://api.github.com/users/jread-usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/jread-usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jread-usgs/subscriptions","organizations_url":"https://api.github.com/users/jread-usgs/orgs","repos_url":"https://api.github.com/users/jread-usgs/repos","events_url":"https://api.github.com/users/jread-usgs/events{/privacy}","received_events_url":"https://api.github.com/users/jread-usgs/received_events","type":"User","site_admin":false},"repo":{"id":131998738,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE5OTg3Mzg=","name":"scipiper","full_name":"jread-usgs/scipiper","private":false,"owner":{"login":"jread-usgs","id":2349007,"node_id":"MDQ6VXNlcjIzNDkwMDc=","avatar_url":"https://avatars2.githubusercontent.com/u/2349007?v=4","gravatar_id":"","url":"https://api.github.com/users/jread-usgs","html_url":"https://github.com/jread-usgs","followers_url":"https://api.github.com/users/jread-usgs/followers","following_url":"https://api.github.com/users/jread-usgs/following{/other_user}","gists_url":"https://api.github.com/users/jread-usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/jread-usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jread-usgs/subscriptions","organizations_url":"https://api.github.com/users/jread-usgs/orgs","repos_url":"https://api.github.com/users/jread-usgs/repos","events_url":"https://api.github.com/users/jread-usgs/events{/privacy}","received_events_url":"https://api.github.com/users/jread-usgs/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jread-usgs/scipiper","description":null,"fork":true,"url":"https://api.github.com/repos/jread-usgs/scipiper","forks_url":"https://api.github.com/repos/jread-usgs/scipiper/forks","keys_url":"https://api.github.com/repos/jread-usgs/scipiper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jread-usgs/scipiper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jread-usgs/scipiper/teams","hooks_url":"https://api.github.com/repos/jread-usgs/scipiper/hooks","issue_events_url":"https://api.github.com/repos/jread-usgs/scipiper/issues/events{/number}","events_url":"https://api.github.com/repos/jread-usgs/scipiper/events","assignees_url":"https://api.github.com/repos/jread-usgs/scipiper/assignees{/user}","branches_url":"https://api.github.com/repos/jread-usgs/scipiper/branches{/branch}","tags_url":"https://api.github.com/repos/jread-usgs/scipiper/tags","blobs_url":"https://api.github.com/repos/jread-usgs/scipiper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jread-usgs/scipiper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jread-usgs/scipiper/git/refs{/sha}","trees_url":"https://api.github.com/repos/jread-usgs/scipiper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jread-usgs/scipiper/statuses/{sha}","languages_url":"https://api.github.com/repos/jread-usgs/scipiper/languages","stargazers_url":"https://api.github.com/repos/jread-usgs/scipiper/stargazers","contributors_url":"https://api.github.com/repos/jread-usgs/scipiper/contributors","subscribers_url":"https://api.github.com/repos/jread-usgs/scipiper/subscribers","subscription_url":"https://api.github.com/repos/jread-usgs/scipiper/subscription","commits_url":"https://api.github.com/repos/jread-usgs/scipiper/commits{/sha}","git_commits_url":"https://api.github.com/repos/jread-usgs/scipiper/git/commits{/sha}","comments_url":"https://api.github.com/repos/jread-usgs/scipiper/comments{/number}","issue_comment_url":"https://api.github.com/repos/jread-usgs/scipiper/issues/comments{/number}","contents_url":"https://api.github.com/repos/jread-usgs/scipiper/contents/{+path}","compare_url":"https://api.github.com/repos/jread-usgs/scipiper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jread-usgs/scipiper/merges","archive_url":"https://api.github.com/repos/jread-usgs/scipiper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jread-usgs/scipiper/downloads","issues_url":"https://api.github.com/repos/jread-usgs/scipiper/issues{/number}","pulls_url":"https://api.github.com/repos/jread-usgs/scipiper/pulls{/number}","milestones_url":"https://api.github.com/repos/jread-usgs/scipiper/milestones{/number}","notifications_url":"https://api.github.com/repos/jread-usgs/scipiper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jread-usgs/scipiper/labels{/name}","releases_url":"https://api.github.com/repos/jread-usgs/scipiper/releases{/id}","deployments_url":"https://api.github.com/repos/jread-usgs/scipiper/deployments","created_at":"2018-05-03T13:25:17Z","updated_at":"2018-12-18T22:27:13Z","pushed_at":"2018-12-19T14:53:39Z","git_url":"git://github.com/jread-usgs/scipiper.git","ssh_url":"git@github.com:jread-usgs/scipiper.git","clone_url":"https://github.com/jread-usgs/scipiper.git","svn_url":"https://github.com/jread-usgs/scipiper","homepage":null,"size":271,"stargazers_count":0,"watchers_count":0,"language":"R","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"cc0-1.0","name":"Creative Commons Zero v1.0 Universal","spdx_id":"CC0-1.0","url":"https://api.github.com/licenses/cc0-1.0","node_id":"MDc6TGljZW5zZTY="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"USGS-R:task_combiners","ref":"task_combiners","sha":"c839e719e68e6e144e938205b72aed23510c65fd","user":{"login":"USGS-R","id":3188813,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxODg4MTM=","avatar_url":"https://avatars3.githubusercontent.com/u/3188813?v=4","gravatar_id":"","url":"https://api.github.com/users/USGS-R","html_url":"https://github.com/USGS-R","followers_url":"https://api.github.com/users/USGS-R/followers","following_url":"https://api.github.com/users/USGS-R/following{/other_user}","gists_url":"https://api.github.com/users/USGS-R/gists{/gist_id}","starred_url":"https://api.github.com/users/USGS-R/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/USGS-R/subscriptions","organizations_url":"https://api.github.com/users/USGS-R/orgs","repos_url":"https://api.github.com/users/USGS-R/repos","events_url":"https://api.github.com/users/USGS-R/events{/privacy}","received_events_url":"https://api.github.com/users/USGS-R/received_events","type":"Organization","site_admin":false},"repo":{"id":101014004,"node_id":"MDEwOlJlcG9zaXRvcnkxMDEwMTQwMDQ=","name":"scipiper","full_name":"USGS-R/scipiper","private":false,"owner":{"login":"USGS-R","id":3188813,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxODg4MTM=","avatar_url":"https://avatars3.githubusercontent.com/u/3188813?v=4","gravatar_id":"","url":"https://api.github.com/users/USGS-R","html_url":"https://github.com/USGS-R","followers_url":"https://api.github.com/users/USGS-R/followers","following_url":"https://api.github.com/users/USGS-R/following{/other_user}","gists_url":"https://api.github.com/users/USGS-R/gists{/gist_id}","starred_url":"https://api.github.com/users/USGS-R/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/USGS-R/subscriptions","organizations_url":"https://api.github.com/users/USGS-R/orgs","repos_url":"https://api.github.com/users/USGS-R/repos","events_url":"https://api.github.com/users/USGS-R/events{/privacy}","received_events_url":"https://api.github.com/users/USGS-R/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/USGS-R/scipiper","description":null,"fork":false,"url":"https://api.github.com/repos/USGS-R/scipiper","forks_url":"https://api.github.com/repos/USGS-R/scipiper/forks","keys_url":"https://api.github.com/repos/USGS-R/scipiper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/USGS-R/scipiper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/USGS-R/scipiper/teams","hooks_url":"https://api.github.com/repos/USGS-R/scipiper/hooks","issue_events_url":"https://api.github.com/repos/USGS-R/scipiper/issues/events{/number}","events_url":"https://api.github.com/repos/USGS-R/scipiper/events","assignees_url":"https://api.github.com/repos/USGS-R/scipiper/assignees{/user}","branches_url":"https://api.github.com/repos/USGS-R/scipiper/branches{/branch}","tags_url":"https://api.github.com/repos/USGS-R/scipiper/tags","blobs_url":"https://api.github.com/repos/USGS-R/scipiper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/USGS-R/scipiper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/USGS-R/scipiper/git/refs{/sha}","trees_url":"https://api.github.com/repos/USGS-R/scipiper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/USGS-R/scipiper/statuses/{sha}","languages_url":"https://api.github.com/repos/USGS-R/scipiper/languages","stargazers_url":"https://api.github.com/repos/USGS-R/scipiper/stargazers","contributors_url":"https://api.github.com/repos/USGS-R/scipiper/contributors","subscribers_url":"https://api.github.com/repos/USGS-R/scipiper/subscribers","subscription_url":"https://api.github.com/repos/USGS-R/scipiper/subscription","commits_url":"https://api.github.com/repos/USGS-R/scipiper/commits{/sha}","git_commits_url":"https://api.github.com/repos/USGS-R/scipiper/git/commits{/sha}","comments_url":"https://api.github.com/repos/USGS-R/scipiper/comments{/number}","issue_comment_url":"https://api.github.com/repos/USGS-R/scipiper/issues/comments{/number}","contents_url":"https://api.github.com/repos/USGS-R/scipiper/contents/{+path}","compare_url":"https://api.github.com/repos/USGS-R/scipiper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/USGS-R/scipiper/merges","archive_url":"https://api.github.com/repos/USGS-R/scipiper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/USGS-R/scipiper/downloads","issues_url":"https://api.github.com/repos/USGS-R/scipiper/issues{/number}","pulls_url":"https://api.github.com/repos/USGS-R/scipiper/pulls{/number}","milestones_url":"https://api.github.com/repos/USGS-R/scipiper/milestones{/number}","notifications_url":"https://api.github.com/repos/USGS-R/scipiper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/USGS-R/scipiper/labels{/name}","releases_url":"https://api.github.com/repos/USGS-R/scipiper/releases{/id}","deployments_url":"https://api.github.com/repos/USGS-R/scipiper/deployments","created_at":"2017-08-22T02:50:24Z","updated_at":"2018-12-19T17:32:57Z","pushed_at":"2018-12-19T17:32:55Z","git_url":"git://github.com/USGS-R/scipiper.git","ssh_url":"git@github.com:USGS-R/scipiper.git","clone_url":"https://github.com/USGS-R/scipiper.git","svn_url":"https://github.com/USGS-R/scipiper","homepage":null,"size":270,"stargazers_count":3,"watchers_count":3,"language":"R","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"cc0-1.0","name":"Creative Commons Zero v1.0 Universal","spdx_id":"CC0-1.0","url":"https://api.github.com/licenses/cc0-1.0","node_id":"MDc6TGljZW5zZTY="},"forks":7,"open_issues":36,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/USGS-R/scipiper/pulls/86"},"html":{"href":"https://github.com/USGS-R/scipiper/pull/86"},"issue":{"href":"https://api.github.com/repos/USGS-R/scipiper/issues/86"},"comments":{"href":"https://api.github.com/repos/USGS-R/scipiper/issues/86/comments"},"review_comments":{"href":"https://api.github.com/repos/USGS-R/scipiper/pulls/86/comments"},"review_comment":{"href":"https://api.github.com/repos/USGS-R/scipiper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/USGS-R/scipiper/pulls/86/commits"},"statuses":{"href":"https://api.github.com/repos/USGS-R/scipiper/statuses/5e416e3d500f35b75d760dc7841092c345865dc9"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jread-usgs"}}