{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/220265821","pull_request_review_id":158632061,"id":220265821,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDI2NTgyMQ==","diff_hunk":"@@ -266,7 +266,19 @@ impl<'cx, 'bccx, 'gcx, 'tcx> TypeRelating<'cx, 'bccx, 'gcx, 'tcx> {\n                     locations: self.locations,\n                 });\n \n-            // FIXME all facts!\n+            if let Some(all_facts) = borrowck_context.all_facts {\n+                if let Some(from_location) = self.locations.from_location() {","path":"src/librustc_mir/borrow_check/nll/type_check/relate_tys.rs","position":6,"original_position":6,"commit_id":"68ed229e4497916e77c34be93ca5f3dfc446106a","original_commit_id":"68ed229e4497916e77c34be93ca5f3dfc446106a","user":{"login":"nikomatsakis","id":155238,"node_id":"MDQ6VXNlcjE1NTIzOA==","avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"body":"this would it seems be caught better by just inspecting the final outlives relations and convering them (as I mentioned earlier), then we wouldn't have to repeat this code","created_at":"2018-09-25T16:33:03Z","updated_at":"2018-09-25T16:33:15Z","html_url":"https://github.com/rust-lang/rust/pull/54468#discussion_r220265821","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/54468","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/220265821"},"html":{"href":"https://github.com/rust-lang/rust/pull/54468#discussion_r220265821"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/54468"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/54468","id":217457024,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NDU3MDI0","html_url":"https://github.com/rust-lang/rust/pull/54468","diff_url":"https://github.com/rust-lang/rust/pull/54468.diff","patch_url":"https://github.com/rust-lang/rust/pull/54468.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/54468","number":54468,"state":"open","locked":false,"title":"[NLL] Get Polonius borrow check to work in simple cases","user":{"login":"matthewjasper","id":20113453,"node_id":"MDQ6VXNlcjIwMTEzNDUz","avatar_url":"https://avatars1.githubusercontent.com/u/20113453?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewjasper","html_url":"https://github.com/matthewjasper","followers_url":"https://api.github.com/users/matthewjasper/followers","following_url":"https://api.github.com/users/matthewjasper/following{/other_user}","gists_url":"https://api.github.com/users/matthewjasper/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewjasper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewjasper/subscriptions","organizations_url":"https://api.github.com/users/matthewjasper/orgs","repos_url":"https://api.github.com/users/matthewjasper/repos","events_url":"https://api.github.com/users/matthewjasper/events{/privacy}","received_events_url":"https://api.github.com/users/matthewjasper/received_events","type":"User","site_admin":false},"body":"* Restores the generation of outlives facts from subtyping.\r\n* Restore liveness facts.\r\n* Generate invalidates facts at the start point of each location,\r\n  where we check for errors.\r\n* Add a small test for simple cases (previously these cases have compiled, and more recently ICEd).\r\n\r\nCloses #54212\r\ncc #53142 (will need test)\r\n\r\n### Known limitations\r\n\r\n* Two phase borrows aren't implemented for Polonius yet\r\n* Invalidation facts haven't been updated for some of the recent changes to make `Drop` terminators access fewer things.\r\n* Fact generation is not as optimized as it could be.\r\n* Around 30 tests fail in compare mode, often tests that are ignored in nll compare mode\r\n\r\nr? @nikomatsakis \r\n","created_at":"2018-09-22T13:16:29Z","updated_at":"2018-09-25T16:33:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"89ec93683ba1626d88fbf0a5dd968a8b23b03c5b","assignee":{"login":"nikomatsakis","id":155238,"node_id":"MDQ6VXNlcjE1NTIzOA==","avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"assignees":[{"login":"nikomatsakis","id":155238,"node_id":"MDQ6VXNlcjE1NTIzOA==","avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":604489711,"node_id":"MDU6TGFiZWw2MDQ0ODk3MTE=","url":"https://api.github.com/repos/rust-lang/rust/labels/A-NLL","name":"A-NLL","color":"d7e102","default":false},{"id":583426710,"node_id":"MDU6TGFiZWw1ODM0MjY3MTA=","url":"https://api.github.com/repos/rust-lang/rust/labels/S-waiting-on-review","name":"S-waiting-on-review","color":"d3dddd","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/54468/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/54468/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/54468/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/68ed229e4497916e77c34be93ca5f3dfc446106a","head":{"label":"matthewjasper:fix-polonius","ref":"fix-polonius","sha":"68ed229e4497916e77c34be93ca5f3dfc446106a","user":{"login":"matthewjasper","id":20113453,"node_id":"MDQ6VXNlcjIwMTEzNDUz","avatar_url":"https://avatars1.githubusercontent.com/u/20113453?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewjasper","html_url":"https://github.com/matthewjasper","followers_url":"https://api.github.com/users/matthewjasper/followers","following_url":"https://api.github.com/users/matthewjasper/following{/other_user}","gists_url":"https://api.github.com/users/matthewjasper/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewjasper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewjasper/subscriptions","organizations_url":"https://api.github.com/users/matthewjasper/orgs","repos_url":"https://api.github.com/users/matthewjasper/repos","events_url":"https://api.github.com/users/matthewjasper/events{/privacy}","received_events_url":"https://api.github.com/users/matthewjasper/received_events","type":"User","site_admin":false},"repo":{"id":86588393,"node_id":"MDEwOlJlcG9zaXRvcnk4NjU4ODM5Mw==","name":"rust","full_name":"matthewjasper/rust","private":false,"owner":{"login":"matthewjasper","id":20113453,"node_id":"MDQ6VXNlcjIwMTEzNDUz","avatar_url":"https://avatars1.githubusercontent.com/u/20113453?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewjasper","html_url":"https://github.com/matthewjasper","followers_url":"https://api.github.com/users/matthewjasper/followers","following_url":"https://api.github.com/users/matthewjasper/following{/other_user}","gists_url":"https://api.github.com/users/matthewjasper/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewjasper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewjasper/subscriptions","organizations_url":"https://api.github.com/users/matthewjasper/orgs","repos_url":"https://api.github.com/users/matthewjasper/repos","events_url":"https://api.github.com/users/matthewjasper/events{/privacy}","received_events_url":"https://api.github.com/users/matthewjasper/received_events","type":"User","site_admin":false},"html_url":"https://github.com/matthewjasper/rust","description":"A safe, concurrent, practical language.","fork":true,"url":"https://api.github.com/repos/matthewjasper/rust","forks_url":"https://api.github.com/repos/matthewjasper/rust/forks","keys_url":"https://api.github.com/repos/matthewjasper/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matthewjasper/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matthewjasper/rust/teams","hooks_url":"https://api.github.com/repos/matthewjasper/rust/hooks","issue_events_url":"https://api.github.com/repos/matthewjasper/rust/issues/events{/number}","events_url":"https://api.github.com/repos/matthewjasper/rust/events","assignees_url":"https://api.github.com/repos/matthewjasper/rust/assignees{/user}","branches_url":"https://api.github.com/repos/matthewjasper/rust/branches{/branch}","tags_url":"https://api.github.com/repos/matthewjasper/rust/tags","blobs_url":"https://api.github.com/repos/matthewjasper/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matthewjasper/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matthewjasper/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/matthewjasper/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matthewjasper/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/matthewjasper/rust/languages","stargazers_url":"https://api.github.com/repos/matthewjasper/rust/stargazers","contributors_url":"https://api.github.com/repos/matthewjasper/rust/contributors","subscribers_url":"https://api.github.com/repos/matthewjasper/rust/subscribers","subscription_url":"https://api.github.com/repos/matthewjasper/rust/subscription","commits_url":"https://api.github.com/repos/matthewjasper/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/matthewjasper/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/matthewjasper/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/matthewjasper/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/matthewjasper/rust/contents/{+path}","compare_url":"https://api.github.com/repos/matthewjasper/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matthewjasper/rust/merges","archive_url":"https://api.github.com/repos/matthewjasper/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matthewjasper/rust/downloads","issues_url":"https://api.github.com/repos/matthewjasper/rust/issues{/number}","pulls_url":"https://api.github.com/repos/matthewjasper/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/matthewjasper/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/matthewjasper/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matthewjasper/rust/labels{/name}","releases_url":"https://api.github.com/repos/matthewjasper/rust/releases{/id}","deployments_url":"https://api.github.com/repos/matthewjasper/rust/deployments","created_at":"2017-03-29T13:54:25Z","updated_at":"2018-09-03T21:32:36Z","pushed_at":"2018-09-24T22:34:04Z","git_url":"git://github.com/matthewjasper/rust.git","ssh_url":"git@github.com:matthewjasper/rust.git","clone_url":"https://github.com/matthewjasper/rust.git","svn_url":"https://github.com/matthewjasper/rust","homepage":"https://www.rust-lang.org","size":392689,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"af50e3822c4ceda60445c4a2adbb3bfa480ebd39","user":{"login":"rust-lang","id":5430905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MzA5MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"node_id":"MDEwOlJlcG9zaXRvcnk3MjQ3MTI=","name":"rust","full_name":"rust-lang/rust","private":false,"owner":{"login":"rust-lang","id":5430905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MzA5MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2018-09-25T16:22:43Z","pushed_at":"2018-09-25T15:55:09Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":394616,"stargazers_count":30836,"watchers_count":30836,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5193,"mirror_url":null,"archived":false,"open_issues_count":4377,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5193,"open_issues":4377,"watchers":30836,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/54468"},"html":{"href":"https://github.com/rust-lang/rust/pull/54468"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/54468"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/54468/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/54468/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/54468/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/68ed229e4497916e77c34be93ca5f3dfc446106a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nikomatsakis"}}