{"action":"created","comment":{"url":"https://api.github.com/repos/canonical-websites/snapcraft.io/pulls/comments/194391798","pull_request_review_id":127553321,"id":194391798,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDM5MTc5OA==","diff_hunk":"@@ -15,6 +16,11 @@\n )\n \n \n+account_page = flask.Blueprint(","path":"webapp/publisher/views.py","position":12,"original_position":12,"commit_id":"13a3d7dc40e2232f9709ec9b78b853a7d674b21f","original_commit_id":"13a3d7dc40e2232f9709ec9b78b853a7d674b21f","user":{"login":"tbille","id":2707508,"node_id":"MDQ6VXNlcjI3MDc1MDg=","avatar_url":"https://avatars0.githubusercontent.com/u/2707508?v=4","gravatar_id":"","url":"https://api.github.com/users/tbille","html_url":"https://github.com/tbille","followers_url":"https://api.github.com/users/tbille/followers","following_url":"https://api.github.com/users/tbille/following{/other_user}","gists_url":"https://api.github.com/users/tbille/gists{/gist_id}","starred_url":"https://api.github.com/users/tbille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbille/subscriptions","organizations_url":"https://api.github.com/users/tbille/orgs","repos_url":"https://api.github.com/users/tbille/repos","events_url":"https://api.github.com/users/tbille/events{/privacy}","received_events_url":"https://api.github.com/users/tbille/received_events","type":"User","site_admin":false},"body":"@Lukewh the problem here is that I already have some vars with this name, I think it might be less confusing by having a specific name for the blueprint (we have the same var name for the store and the blog blueprints","created_at":"2018-06-11T12:51:23Z","updated_at":"2018-06-11T12:51:23Z","html_url":"https://github.com/canonical-websites/snapcraft.io/pull/715#discussion_r194391798","pull_request_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/pulls/715","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/canonical-websites/snapcraft.io/pulls/comments/194391798"},"html":{"href":"https://github.com/canonical-websites/snapcraft.io/pull/715#discussion_r194391798"},"pull_request":{"href":"https://api.github.com/repos/canonical-websites/snapcraft.io/pulls/715"}},"in_reply_to_id":194381888},"pull_request":{"url":"https://api.github.com/repos/canonical-websites/snapcraft.io/pulls/715","id":193947809,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzOTQ3ODA5","html_url":"https://github.com/canonical-websites/snapcraft.io/pull/715","diff_url":"https://github.com/canonical-websites/snapcraft.io/pull/715.diff","patch_url":"https://github.com/canonical-websites/snapcraft.io/pull/715.patch","issue_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/issues/715","number":715,"state":"open","locked":false,"title":"Add publisher blueprint","user":{"login":"tbille","id":2707508,"node_id":"MDQ6VXNlcjI3MDc1MDg=","avatar_url":"https://avatars0.githubusercontent.com/u/2707508?v=4","gravatar_id":"","url":"https://api.github.com/users/tbille","html_url":"https://github.com/tbille","followers_url":"https://api.github.com/users/tbille/followers","following_url":"https://api.github.com/users/tbille/following{/other_user}","gists_url":"https://api.github.com/users/tbille/gists{/gist_id}","starred_url":"https://api.github.com/users/tbille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbille/subscriptions","organizations_url":"https://api.github.com/users/tbille/orgs","repos_url":"https://api.github.com/users/tbille/repos","events_url":"https://api.github.com/users/tbille/events{/privacy}","received_events_url":"https://api.github.com/users/tbille/received_events","type":"User","site_admin":false},"body":"# Summary\r\n\r\n- Add publisher bluepirint\r\n- Fix redirections with function `url_for` to avoid hardcoded urls\r\n- Fix tests to apply with the new redirections (`url_for` adds automatically a `/` at the end of the url)\r\n\r\n# QA\r\n\r\n- `./run`\r\n- Navigate in publiser pages and make sure everything works as usual\r\nhttp://127.0.0.1:8004/account\r\nhttp://127.0.0.1:8004/account/details\r\nhttp://127.0.0.1:8004/account/snaps\r\nhttp://127.0.0.1:8004/account/username\r\nhttp://127.0.0.1:8004/account/agreement\r\nhttp://127.0.0.1:8004/account/snaps/toto/listing\r\nhttp://127.0.0.1:8004/account/snaps/toto/market\r\nhttp://127.0.0.1:8004/account/snaps/toto/measure\r\n\r\nList of the routes (by running `flask routes`\r\n```\r\naccount_page.get_account             GET        /account/\r\naccount_page.get_account_details     GET        /account/details\r\naccount_page.get_account_name        GET        /account/username\r\naccount_page.get_account_snaps       GET        /account/snaps\r\naccount_page.get_agreement           GET        /account/agreement\r\naccount_page.get_listing_snap        GET        /account/snaps/<snap_name>/listing\r\naccount_page.get_market_snap         GET        /account/snaps/<snap_name>/market\r\naccount_page.get_measure_snap        GET        /account/snaps/<snap_name>/measure\r\naccount_page.get_register_name       GET        /account/register-name\r\naccount_page.post_account_name       POST       /account/username\r\naccount_page.post_agreement          POST       /account/agreement\r\naccount_page.post_listing_snap       POST       /account/snaps/<snap_name>/listing\r\naccount_page.post_register_name      POST       /account/register-name\r\naccount_page.publisher_snap_metrics  GET        /account/snaps/<snap_name>/metrics\r\n```","created_at":"2018-06-11T11:10:56Z","updated_at":"2018-06-11T12:51:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f22f7ab511b93a61f40b0c1aa7cb686f8e8e9999","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":698999579,"node_id":"MDU6TGFiZWw2OTg5OTk1Nzk=","url":"https://api.github.com/repos/canonical-websites/snapcraft.io/labels/Review:%20Code%20+1","name":"Review: Code +1","color":"38b44a","default":false},{"id":698999583,"node_id":"MDU6TGFiZWw2OTg5OTk1ODM=","url":"https://api.github.com/repos/canonical-websites/snapcraft.io/labels/Review:%20QA%20+1","name":"Review: QA +1","color":"38b44a","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/pulls/715/commits","review_comments_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/pulls/715/comments","review_comment_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/issues/715/comments","statuses_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/statuses/13a3d7dc40e2232f9709ec9b78b853a7d674b21f","head":{"label":"tbille:add-publisher-blueprint","ref":"add-publisher-blueprint","sha":"13a3d7dc40e2232f9709ec9b78b853a7d674b21f","user":{"login":"tbille","id":2707508,"node_id":"MDQ6VXNlcjI3MDc1MDg=","avatar_url":"https://avatars0.githubusercontent.com/u/2707508?v=4","gravatar_id":"","url":"https://api.github.com/users/tbille","html_url":"https://github.com/tbille","followers_url":"https://api.github.com/users/tbille/followers","following_url":"https://api.github.com/users/tbille/following{/other_user}","gists_url":"https://api.github.com/users/tbille/gists{/gist_id}","starred_url":"https://api.github.com/users/tbille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbille/subscriptions","organizations_url":"https://api.github.com/users/tbille/orgs","repos_url":"https://api.github.com/users/tbille/repos","events_url":"https://api.github.com/users/tbille/events{/privacy}","received_events_url":"https://api.github.com/users/tbille/received_events","type":"User","site_admin":false},"repo":{"id":109980720,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk5ODA3MjA=","name":"snapcraft.io","full_name":"tbille/snapcraft.io","owner":{"login":"tbille","id":2707508,"node_id":"MDQ6VXNlcjI3MDc1MDg=","avatar_url":"https://avatars0.githubusercontent.com/u/2707508?v=4","gravatar_id":"","url":"https://api.github.com/users/tbille","html_url":"https://github.com/tbille","followers_url":"https://api.github.com/users/tbille/followers","following_url":"https://api.github.com/users/tbille/following{/other_user}","gists_url":"https://api.github.com/users/tbille/gists{/gist_id}","starred_url":"https://api.github.com/users/tbille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbille/subscriptions","organizations_url":"https://api.github.com/users/tbille/orgs","repos_url":"https://api.github.com/users/tbille/repos","events_url":"https://api.github.com/users/tbille/events{/privacy}","received_events_url":"https://api.github.com/users/tbille/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tbille/snapcraft.io","description":null,"fork":true,"url":"https://api.github.com/repos/tbille/snapcraft.io","forks_url":"https://api.github.com/repos/tbille/snapcraft.io/forks","keys_url":"https://api.github.com/repos/tbille/snapcraft.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tbille/snapcraft.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tbille/snapcraft.io/teams","hooks_url":"https://api.github.com/repos/tbille/snapcraft.io/hooks","issue_events_url":"https://api.github.com/repos/tbille/snapcraft.io/issues/events{/number}","events_url":"https://api.github.com/repos/tbille/snapcraft.io/events","assignees_url":"https://api.github.com/repos/tbille/snapcraft.io/assignees{/user}","branches_url":"https://api.github.com/repos/tbille/snapcraft.io/branches{/branch}","tags_url":"https://api.github.com/repos/tbille/snapcraft.io/tags","blobs_url":"https://api.github.com/repos/tbille/snapcraft.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tbille/snapcraft.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tbille/snapcraft.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/tbille/snapcraft.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tbille/snapcraft.io/statuses/{sha}","languages_url":"https://api.github.com/repos/tbille/snapcraft.io/languages","stargazers_url":"https://api.github.com/repos/tbille/snapcraft.io/stargazers","contributors_url":"https://api.github.com/repos/tbille/snapcraft.io/contributors","subscribers_url":"https://api.github.com/repos/tbille/snapcraft.io/subscribers","subscription_url":"https://api.github.com/repos/tbille/snapcraft.io/subscription","commits_url":"https://api.github.com/repos/tbille/snapcraft.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/tbille/snapcraft.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/tbille/snapcraft.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/tbille/snapcraft.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/tbille/snapcraft.io/contents/{+path}","compare_url":"https://api.github.com/repos/tbille/snapcraft.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tbille/snapcraft.io/merges","archive_url":"https://api.github.com/repos/tbille/snapcraft.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tbille/snapcraft.io/downloads","issues_url":"https://api.github.com/repos/tbille/snapcraft.io/issues{/number}","pulls_url":"https://api.github.com/repos/tbille/snapcraft.io/pulls{/number}","milestones_url":"https://api.github.com/repos/tbille/snapcraft.io/milestones{/number}","notifications_url":"https://api.github.com/repos/tbille/snapcraft.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tbille/snapcraft.io/labels{/name}","releases_url":"https://api.github.com/repos/tbille/snapcraft.io/releases{/id}","deployments_url":"https://api.github.com/repos/tbille/snapcraft.io/deployments","created_at":"2017-11-08T13:39:43Z","updated_at":"2018-02-26T11:46:16Z","pushed_at":"2018-06-11T11:05:17Z","git_url":"git://github.com/tbille/snapcraft.io.git","ssh_url":"git@github.com:tbille/snapcraft.io.git","clone_url":"https://github.com/tbille/snapcraft.io.git","svn_url":"https://github.com/tbille/snapcraft.io","homepage":null,"size":1536,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"canonical-websites:master","ref":"master","sha":"e4fe37dc9c2dbee9a66b65f92789a7dd3009271c","user":{"login":"canonical-websites","id":26072773,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MDcyNzcz","avatar_url":"https://avatars2.githubusercontent.com/u/26072773?v=4","gravatar_id":"","url":"https://api.github.com/users/canonical-websites","html_url":"https://github.com/canonical-websites","followers_url":"https://api.github.com/users/canonical-websites/followers","following_url":"https://api.github.com/users/canonical-websites/following{/other_user}","gists_url":"https://api.github.com/users/canonical-websites/gists{/gist_id}","starred_url":"https://api.github.com/users/canonical-websites/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canonical-websites/subscriptions","organizations_url":"https://api.github.com/users/canonical-websites/orgs","repos_url":"https://api.github.com/users/canonical-websites/repos","events_url":"https://api.github.com/users/canonical-websites/events{/privacy}","received_events_url":"https://api.github.com/users/canonical-websites/received_events","type":"Organization","site_admin":false},"repo":{"id":100534315,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA1MzQzMTU=","name":"snapcraft.io","full_name":"canonical-websites/snapcraft.io","owner":{"login":"canonical-websites","id":26072773,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MDcyNzcz","avatar_url":"https://avatars2.githubusercontent.com/u/26072773?v=4","gravatar_id":"","url":"https://api.github.com/users/canonical-websites","html_url":"https://github.com/canonical-websites","followers_url":"https://api.github.com/users/canonical-websites/followers","following_url":"https://api.github.com/users/canonical-websites/following{/other_user}","gists_url":"https://api.github.com/users/canonical-websites/gists{/gist_id}","starred_url":"https://api.github.com/users/canonical-websites/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canonical-websites/subscriptions","organizations_url":"https://api.github.com/users/canonical-websites/orgs","repos_url":"https://api.github.com/users/canonical-websites/repos","events_url":"https://api.github.com/users/canonical-websites/events{/privacy}","received_events_url":"https://api.github.com/users/canonical-websites/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/canonical-websites/snapcraft.io","description":null,"fork":false,"url":"https://api.github.com/repos/canonical-websites/snapcraft.io","forks_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/forks","keys_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/teams","hooks_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/hooks","issue_events_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/issues/events{/number}","events_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/events","assignees_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/assignees{/user}","branches_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/branches{/branch}","tags_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/tags","blobs_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/statuses/{sha}","languages_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/languages","stargazers_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/stargazers","contributors_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/contributors","subscribers_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/subscribers","subscription_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/subscription","commits_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/contents/{+path}","compare_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/merges","archive_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/downloads","issues_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/issues{/number}","pulls_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/pulls{/number}","milestones_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/milestones{/number}","notifications_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/labels{/name}","releases_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/releases{/id}","deployments_url":"https://api.github.com/repos/canonical-websites/snapcraft.io/deployments","created_at":"2017-08-16T21:29:29Z","updated_at":"2018-06-11T10:01:56Z","pushed_at":"2018-06-11T12:24:37Z","git_url":"git://github.com/canonical-websites/snapcraft.io.git","ssh_url":"git@github.com:canonical-websites/snapcraft.io.git","clone_url":"https://github.com/canonical-websites/snapcraft.io.git","svn_url":"https://github.com/canonical-websites/snapcraft.io","homepage":null,"size":1254,"stargazers_count":11,"watchers_count":11,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":75,"license":null,"forks":22,"open_issues":75,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/canonical-websites/snapcraft.io/pulls/715"},"html":{"href":"https://github.com/canonical-websites/snapcraft.io/pull/715"},"issue":{"href":"https://api.github.com/repos/canonical-websites/snapcraft.io/issues/715"},"comments":{"href":"https://api.github.com/repos/canonical-websites/snapcraft.io/issues/715/comments"},"review_comments":{"href":"https://api.github.com/repos/canonical-websites/snapcraft.io/pulls/715/comments"},"review_comment":{"href":"https://api.github.com/repos/canonical-websites/snapcraft.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/canonical-websites/snapcraft.io/pulls/715/commits"},"statuses":{"href":"https://api.github.com/repos/canonical-websites/snapcraft.io/statuses/13a3d7dc40e2232f9709ec9b78b853a7d674b21f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tbille"}}