{"action":"created","issue":{"url":"https://api.github.com/repos/OpenSmalltalk/opensmalltalk-vm/issues/227","repository_url":"https://api.github.com/repos/OpenSmalltalk/opensmalltalk-vm","labels_url":"https://api.github.com/repos/OpenSmalltalk/opensmalltalk-vm/issues/227/labels{/name}","comments_url":"https://api.github.com/repos/OpenSmalltalk/opensmalltalk-vm/issues/227/comments","events_url":"https://api.github.com/repos/OpenSmalltalk/opensmalltalk-vm/issues/227/events","html_url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/227","id":304185754,"node_id":"MDExOlB1bGxSZXF1ZXN0MTc0MjM3NDM0","number":227,"title":"Second attempt to improve updateSCCSVersions","user":{"login":"j4yk","id":151175,"node_id":"MDQ6VXNlcjE1MTE3NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/151175?v=4","gravatar_id":"","url":"https://api.github.com/users/j4yk","html_url":"https://github.com/j4yk","followers_url":"https://api.github.com/users/j4yk/followers","following_url":"https://api.github.com/users/j4yk/following{/other_user}","gists_url":"https://api.github.com/users/j4yk/gists{/gist_id}","starred_url":"https://api.github.com/users/j4yk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j4yk/subscriptions","organizations_url":"https://api.github.com/users/j4yk/orgs","repos_url":"https://api.github.com/users/j4yk/repos","events_url":"https://api.github.com/users/j4yk/events{/privacy}","received_events_url":"https://api.github.com/users/j4yk/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-03-11T19:24:19Z","updated_at":"2018-12-29T19:52:39Z","closed_at":"2018-12-29T16:05:54Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/OpenSmalltalk/opensmalltalk-vm/pulls/227","html_url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/227","diff_url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/227.diff","patch_url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/227.patch"},"body":"I finally got around to solve the \"not a git repository\" issue with my previous pull request. For the analysis see below. Please review and try it out before merging.\r\n\r\nWhen the script is run as a hook, the environment variable `GIT_DIR` is set to `.git` (path relative to the working tree) for regular repositories. This affects the behavior of `rev-parse`. When the script is run from the working tree and the checkout commands towards the bottom are executed, the script actually invokes itself as the post-checkout script. During that inner invocation, the script would `cd` to `.git/hooks`, and because of the GIT_DIR variable, `rev-parse` would then look for the git repository in `.git/hooks/.git`. This failed, of course.\r\nThe second error message \"unrecognized input\" came from `git apply` when it was fed with empty input (because there were no uncommitted changes to either *Version.h file).\r\n\r\nSince GIT_DIR caused the trouble, why not use it to detect whether the script is run as a hook..."},"comment":{"url":"https://api.github.com/repos/OpenSmalltalk/opensmalltalk-vm/issues/comments/450515900","html_url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/227#issuecomment-450515900","issue_url":"https://api.github.com/repos/OpenSmalltalk/opensmalltalk-vm/issues/227","id":450515900,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDUxNTkwMA==","user":{"login":"fniephaus","id":2368856,"node_id":"MDQ6VXNlcjIzNjg4NTY=","avatar_url":"https://avatars2.githubusercontent.com/u/2368856?v=4","gravatar_id":"","url":"https://api.github.com/users/fniephaus","html_url":"https://github.com/fniephaus","followers_url":"https://api.github.com/users/fniephaus/followers","following_url":"https://api.github.com/users/fniephaus/following{/other_user}","gists_url":"https://api.github.com/users/fniephaus/gists{/gist_id}","starred_url":"https://api.github.com/users/fniephaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fniephaus/subscriptions","organizations_url":"https://api.github.com/users/fniephaus/orgs","repos_url":"https://api.github.com/users/fniephaus/repos","events_url":"https://api.github.com/users/fniephaus/events{/privacy}","received_events_url":"https://api.github.com/users/fniephaus/received_events","type":"User","site_admin":false},"created_at":"2018-12-29T19:52:39Z","updated_at":"2018-12-29T19:52:39Z","author_association":"MEMBER","body":"> Second, I did apply the script manually but it made no alterations to sqSCCSVersion.h in my case (it was already localized to my machine). So it may not be necessary to run it, but it does no harm.\r\n\r\nThe behavior with regard to `sqSCCSVersion.h` shouldn't change at all. More importantly, running the script manually also copies and, in our case, updates the script in the repository's `hooks` directory (see [here](https://github.com/j4yk/opensmalltalk-vm/blob/623dee2b6589723173af8b10d73485a23202c44f/scripts/updateSCCSVersions#L23)) to configure Git for our needs. This change is within the `.git` directory and therefore doesn't alter your local copy, the OpenSmalltalkVM code base."}}
{"actor":{"display_login":"fniephaus"}}