{"action":"created","issue":{"url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/issues/876","repository_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage","labels_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/issues/876/labels{/name}","comments_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/issues/876/comments","events_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/issues/876/events","html_url":"https://github.com/imageworks/OpenShadingLanguage/pull/876","id":308216654,"number":876,"title":"specify the VERSION and SOVERSION when building library shared objects","user":{"login":"mattyjams","id":2974964,"avatar_url":"https://avatars1.githubusercontent.com/u/2974964?v=4","gravatar_id":"","url":"https://api.github.com/users/mattyjams","html_url":"https://github.com/mattyjams","followers_url":"https://api.github.com/users/mattyjams/followers","following_url":"https://api.github.com/users/mattyjams/following{/other_user}","gists_url":"https://api.github.com/users/mattyjams/gists{/gist_id}","starred_url":"https://api.github.com/users/mattyjams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattyjams/subscriptions","organizations_url":"https://api.github.com/users/mattyjams/orgs","repos_url":"https://api.github.com/users/mattyjams/repos","events_url":"https://api.github.com/users/mattyjams/events{/privacy}","received_events_url":"https://api.github.com/users/mattyjams/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-03-24T01:05:36Z","updated_at":"2018-03-27T19:54:19Z","closed_at":"2018-03-26T22:36:51Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/pulls/876","html_url":"https://github.com/imageworks/OpenShadingLanguage/pull/876","diff_url":"https://github.com/imageworks/OpenShadingLanguage/pull/876.diff","patch_url":"https://github.com/imageworks/OpenShadingLanguage/pull/876.patch"},"body":"## Description\r\n\r\nIn this change, we specify the VERSION and SOVERSION properties of library\r\nshared objects so that the SONAME in the shared object contains the OSL version\r\nnumber suffix (major.minor). This also results in the build creating versioned\r\nsymlinks back to the installed shared objects. Code that links against the\r\nlibraries can then link against a specific version of OSL such that the correct\r\nversion can be dynamically linked at runtime.\r\n\r\nThis follows a similar pattern to the one used in OpenImageIO.\r\n\r\n## Tests\r\n\r\n<!-- Did you / should you add a testsuite case (new test, or add to an  -->\r\n<!-- existing test) to verify that this works?                          -->\r\n\r\n\r\n## Checklist:\r\n\r\n<!-- Put an 'x' in the boxes as you complete the checklist items -->\r\n\r\n- [x] I have read the [contribution guidelines](../CONTRIBUTING.md).\r\n- [x] I have previously submitted a [Contributor License Agreement](http://opensource.imageworks.com/cla/).\r\n- [ ] I have updated the documentation, if applicable.\r\n- [ ] I have ensured that the change is tested somewhere in the testsuite (adding new test cases if necessary).\r\n- [x] My code follows the prevailing code style of this project.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/issues/comments/376653528","html_url":"https://github.com/imageworks/OpenShadingLanguage/pull/876#issuecomment-376653528","issue_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/issues/876","id":376653528,"user":{"login":"lgritz","id":504179,"avatar_url":"https://avatars0.githubusercontent.com/u/504179?v=4","gravatar_id":"","url":"https://api.github.com/users/lgritz","html_url":"https://github.com/lgritz","followers_url":"https://api.github.com/users/lgritz/followers","following_url":"https://api.github.com/users/lgritz/following{/other_user}","gists_url":"https://api.github.com/users/lgritz/gists{/gist_id}","starred_url":"https://api.github.com/users/lgritz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgritz/subscriptions","organizations_url":"https://api.github.com/users/lgritz/orgs","repos_url":"https://api.github.com/users/lgritz/repos","events_url":"https://api.github.com/users/lgritz/events{/privacy}","received_events_url":"https://api.github.com/users/lgritz/received_events","type":"User","site_admin":false},"created_at":"2018-03-27T19:54:19Z","updated_at":"2018-03-27T19:54:19Z","author_association":"OWNER","body":"Merged the equivalent patch into RB-1.9 and RB-1.8.\r\n"}}
{"actor":{"display_login":"lgritz"}}