{"action":"opened","issue":{"url":"https://api.github.com/repos/allenai/allennlp/issues/2252","repository_url":"https://api.github.com/repos/allenai/allennlp","labels_url":"https://api.github.com/repos/allenai/allennlp/issues/2252/labels{/name}","comments_url":"https://api.github.com/repos/allenai/allennlp/issues/2252/comments","events_url":"https://api.github.com/repos/allenai/allennlp/issues/2252/events","html_url":"https://github.com/allenai/allennlp/issues/2252","id":394409553,"node_id":"MDU6SXNzdWUzOTQ0MDk1NTM=","number":2252,"title":"Timeline for deprecating top-level token_embedders?","user":{"login":"nelson-liu","id":7272031,"node_id":"MDQ6VXNlcjcyNzIwMzE=","avatar_url":"https://avatars3.githubusercontent.com/u/7272031?v=4","gravatar_id":"","url":"https://api.github.com/users/nelson-liu","html_url":"https://github.com/nelson-liu","followers_url":"https://api.github.com/users/nelson-liu/followers","following_url":"https://api.github.com/users/nelson-liu/following{/other_user}","gists_url":"https://api.github.com/users/nelson-liu/gists{/gist_id}","starred_url":"https://api.github.com/users/nelson-liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nelson-liu/subscriptions","organizations_url":"https://api.github.com/users/nelson-liu/orgs","repos_url":"https://api.github.com/users/nelson-liu/repos","events_url":"https://api.github.com/users/nelson-liu/events{/privacy}","received_events_url":"https://api.github.com/users/nelson-liu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-27T14:35:16Z","updated_at":"2018-12-27T14:35:16Z","closed_at":null,"author_association":"MEMBER","body":"Specifying token embedders for a BasicTextFieldEmbedder as top-level key-value pairs has been deprecated for awhile now---when are we thinking of removing it for good? Perhaps soon, since the config wizard is out?\r\n\r\nRegardless, if we aren't going to immediately remove it, we should probably update the warning https://github.com/allenai/allennlp/blob/3f0953d19de3676ea82e642659fc96d90690e34d/allennlp/modules/text_field_embedders/basic_text_field_embedder.py#L141-L143 to indicate the version it was deprecated, and the version it will be removed."}}
{"actor":{"display_login":"nelson-liu"}}