{"action":"created","comment":{"url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/pulls/comments/242539114","pull_request_review_id":186071162,"id":242539114,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjUzOTExNA==","diff_hunk":"@@ -3709,12 +3770,11 @@ \\subsubsection{Reward accounts per stake key}\n identified with the stake key, and the delegation of the stake key is\n known.\n \n-Withdrawal of rewards is done similarly to the withdrawal transaction\n-from the Chimeric Ledgers paper. This uses the stake key as the witness,\n-which reveals the public part of the stake key. Note that this also\n-requires a nonce to prevent replay attacks. One simplifying approach\n-here might be to use the epoch number as the nonce, and to require the\n-whole reward be withdrawn, and hence this could only be valid once\n+Withdrawal of rewards is done similarly to the withdrawal transaction from the\n+Chimeric Ledgers paper. This uses the stake key as the witness, which reveals\n+the public part of the stake key. Note that this also requires a nonce to\n+prevent replay attacks. We choose to use the epoch number as the nonce, and to\n+require the whole reward be withdrawn, and hence this could only be valid once","path":"docs/delegation_design_spec/delegation_design_spec.tex","position":439,"original_position":424,"commit_id":"2a9db1a8a4782e64e49e26ed6a6ddd6246b86146","original_commit_id":"0c9ff00153136b734905fd53e04334b281068016","user":{"login":"kantp","id":1433735,"node_id":"MDQ6VXNlcjE0MzM3MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1433735?v=4","gravatar_id":"","url":"https://api.github.com/users/kantp","html_url":"https://github.com/kantp","followers_url":"https://api.github.com/users/kantp/followers","following_url":"https://api.github.com/users/kantp/following{/other_user}","gists_url":"https://api.github.com/users/kantp/gists{/gist_id}","starred_url":"https://api.github.com/users/kantp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kantp/subscriptions","organizations_url":"https://api.github.com/users/kantp/orgs","repos_url":"https://api.github.com/users/kantp/repos","events_url":"https://api.github.com/users/kantp/events{/privacy}","received_events_url":"https://api.github.com/users/kantp/received_events","type":"User","site_admin":false},"body":"Ok, changed that part!","created_at":"2018-12-18T13:39:33Z","updated_at":"2018-12-18T13:39:33Z","html_url":"https://github.com/input-output-hk/fm-ledger-rules/pull/138#discussion_r242539114","pull_request_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/pulls/138","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/pulls/comments/242539114"},"html":{"href":"https://github.com/input-output-hk/fm-ledger-rules/pull/138#discussion_r242539114"},"pull_request":{"href":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/pulls/138"}},"in_reply_to_id":242388330},"pull_request":{"url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/pulls/138","id":239268897,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5MjY4ODk3","html_url":"https://github.com/input-output-hk/fm-ledger-rules/pull/138","diff_url":"https://github.com/input-output-hk/fm-ledger-rules/pull/138.diff","patch_url":"https://github.com/input-output-hk/fm-ledger-rules/pull/138.patch","issue_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/issues/138","number":138,"state":"open","locked":false,"title":"Further changes to delegation design doc","user":{"login":"kantp","id":1433735,"node_id":"MDQ6VXNlcjE0MzM3MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1433735?v=4","gravatar_id":"","url":"https://api.github.com/users/kantp","html_url":"https://github.com/kantp","followers_url":"https://api.github.com/users/kantp/followers","following_url":"https://api.github.com/users/kantp/following{/other_user}","gists_url":"https://api.github.com/users/kantp/gists{/gist_id}","starred_url":"https://api.github.com/users/kantp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kantp/subscriptions","organizations_url":"https://api.github.com/users/kantp/orgs","repos_url":"https://api.github.com/users/kantp/repos","events_url":"https://api.github.com/users/kantp/events{/privacy}","received_events_url":"https://api.github.com/users/kantp/received_events","type":"User","site_admin":false},"body":"The last batch of changes in reply to Duncan's extensive review 😅 ","created_at":"2018-12-17T20:09:45Z","updated_at":"2018-12-18T13:39:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"45951519b8ce02a585df8946cd1800b564a0af3a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/pulls/138/commits","review_comments_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/pulls/138/comments","review_comment_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/pulls/comments{/number}","comments_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/issues/138/comments","statuses_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/statuses/2a9db1a8a4782e64e49e26ed6a6ddd6246b86146","head":{"label":"input-output-hk:delegation-review","ref":"delegation-review","sha":"2a9db1a8a4782e64e49e26ed6a6ddd6246b86146","user":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":150113380,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAxMTMzODA=","name":"fm-ledger-rules","full_name":"input-output-hk/fm-ledger-rules","private":false,"owner":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/input-output-hk/fm-ledger-rules","description":"A formal specification and executable model of the ledger rules introduced by the Shelley release","fork":false,"url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules","forks_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/forks","keys_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/teams","hooks_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/events","assignees_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/tags","blobs_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/subscription","commits_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/merges","archive_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/downloads","issues_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/deployments","created_at":"2018-09-24T14:14:10Z","updated_at":"2018-12-17T17:01:56Z","pushed_at":"2018-12-18T13:28:06Z","git_url":"git://github.com/input-output-hk/fm-ledger-rules.git","ssh_url":"git@github.com:input-output-hk/fm-ledger-rules.git","clone_url":"https://github.com/input-output-hk/fm-ledger-rules.git","svn_url":"https://github.com/input-output-hk/fm-ledger-rules","homepage":"","size":693,"stargazers_count":4,"watchers_count":4,"language":"TeX","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":34,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":34,"watchers":4,"default_branch":"master"}},"base":{"label":"input-output-hk:master","ref":"master","sha":"51d45a8026de87fda5a7e5f0b7d621d9721ee37a","user":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":150113380,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAxMTMzODA=","name":"fm-ledger-rules","full_name":"input-output-hk/fm-ledger-rules","private":false,"owner":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/input-output-hk/fm-ledger-rules","description":"A formal specification and executable model of the ledger rules introduced by the Shelley release","fork":false,"url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules","forks_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/forks","keys_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/teams","hooks_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/events","assignees_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/tags","blobs_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/subscription","commits_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/merges","archive_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/downloads","issues_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/deployments","created_at":"2018-09-24T14:14:10Z","updated_at":"2018-12-17T17:01:56Z","pushed_at":"2018-12-18T13:28:06Z","git_url":"git://github.com/input-output-hk/fm-ledger-rules.git","ssh_url":"git@github.com:input-output-hk/fm-ledger-rules.git","clone_url":"https://github.com/input-output-hk/fm-ledger-rules.git","svn_url":"https://github.com/input-output-hk/fm-ledger-rules","homepage":"","size":693,"stargazers_count":4,"watchers_count":4,"language":"TeX","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":34,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":34,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/pulls/138"},"html":{"href":"https://github.com/input-output-hk/fm-ledger-rules/pull/138"},"issue":{"href":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/issues/138"},"comments":{"href":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/issues/138/comments"},"review_comments":{"href":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/pulls/138/comments"},"review_comment":{"href":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/pulls/138/commits"},"statuses":{"href":"https://api.github.com/repos/input-output-hk/fm-ledger-rules/statuses/2a9db1a8a4782e64e49e26ed6a6ddd6246b86146"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kantp"}}