{"action":"created","comment":{"url":"https://api.github.com/repos/oppia/oppia/pulls/comments/190506689","pull_request_review_id":122894843,"id":190506689,"diff_hunk":"@@ -124,10 +124,11 @@ def _get_most_recent_activity_commits(\n         as those from the Oppia migration bot).\n \n         Args:\n-            activity_model_cls: The storage layer object for an activity, such\n-                as exp_models.ExplorationModel.\n-            activity_ids_list: A list of activity IDs (such as exploration IDS)\n-                for which the latest commits will be retrieved.\n+            activity_model_cls: storage_layer_object. The storage layer","path":"core/domain/user_jobs_continuous.py","position":8,"original_position":8,"commit_id":"5ceec7169ee74c599de177726f603c9b1df77b8d","original_commit_id":"5ceec7169ee74c599de177726f603c9b1df77b8d","user":{"login":"apb7","id":24826041,"avatar_url":"https://avatars2.githubusercontent.com/u/24826041?v=4","gravatar_id":"","url":"https://api.github.com/users/apb7","html_url":"https://github.com/apb7","followers_url":"https://api.github.com/users/apb7/followers","following_url":"https://api.github.com/users/apb7/following{/other_user}","gists_url":"https://api.github.com/users/apb7/gists{/gist_id}","starred_url":"https://api.github.com/users/apb7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apb7/subscriptions","organizations_url":"https://api.github.com/users/apb7/orgs","repos_url":"https://api.github.com/users/apb7/repos","events_url":"https://api.github.com/users/apb7/events{/privacy}","received_events_url":"https://api.github.com/users/apb7/received_events","type":"User","site_admin":false},"body":"Should this be `*` since `activity_model_cls`  can be one of `exp_models.ExplorationModel` of `collection_models.CollectionModel`?","created_at":"2018-05-24T08:41:39Z","updated_at":"2018-05-24T08:41:39Z","html_url":"https://github.com/oppia/oppia/pull/4967#discussion_r190506689","pull_request_url":"https://api.github.com/repos/oppia/oppia/pulls/4967","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia/pulls/comments/190506689"},"html":{"href":"https://github.com/oppia/oppia/pull/4967#discussion_r190506689"},"pull_request":{"href":"https://api.github.com/repos/oppia/oppia/pulls/4967"}},"in_reply_to_id":190484674},"pull_request":{"url":"https://api.github.com/repos/oppia/oppia/pulls/4967","id":189749224,"html_url":"https://github.com/oppia/oppia/pull/4967","diff_url":"https://github.com/oppia/oppia/pull/4967.diff","patch_url":"https://github.com/oppia/oppia/pull/4967.patch","issue_url":"https://api.github.com/repos/oppia/oppia/issues/4967","number":4967,"state":"open","locked":false,"title":"Improving the dev workflow: Milestone 1.1.3 Custom pylint checks","user":{"login":"apb7","id":24826041,"avatar_url":"https://avatars2.githubusercontent.com/u/24826041?v=4","gravatar_id":"","url":"https://api.github.com/users/apb7","html_url":"https://github.com/apb7","followers_url":"https://api.github.com/users/apb7/followers","following_url":"https://api.github.com/users/apb7/following{/other_user}","gists_url":"https://api.github.com/users/apb7/gists{/gist_id}","starred_url":"https://api.github.com/users/apb7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apb7/subscriptions","organizations_url":"https://api.github.com/users/apb7/orgs","repos_url":"https://api.github.com/users/apb7/repos","events_url":"https://api.github.com/users/apb7/events{/privacy}","received_events_url":"https://api.github.com/users/apb7/received_events","type":"User","site_admin":false},"body":"<!--\r\n  - Thanks for submitting code to Oppia! Please fill out the following as part of\r\n  - your pull request so we can review your code more easily.\r\n  -->\r\n\r\n## Explanation\r\n<!--\r\n  - Explain what your PR does. If this PR fixes an existing bug, please include \r\n  - \"Fixes #bugnum:\" in the explanation so that GitHub can auto-close the issue \r\n  - when this PR is merged.\r\n  -->\r\nThis PR adds a custom checker for docstrings. The Google Style Docstring checker provided by Pylint has been modified according to the docstring style followed at Oppia.\r\n#### Important points:\r\n1. `Returns`/`Yields` section has been added for docstrings of all functions which use `return` or `yield` even if it is `None`. This has been done to make the check consistent for the complete codebase.\r\n2. `*args` have been addressed as `args` and similarily `**kwargs` have been addressed as `kwargs` in docstrings to make the regex uniform, in all functions.\r\n#### Checks enabled: \r\n1. `redundant-yields-doc`\r\n2. `missing-return-doc`\r\n3. `missing-return-type-doc`\r\n4. `missing-yield-doc`\r\n5. `missing-yield-type-doc`\r\n6. `missing-param-doc`\r\n7. `missing-type-doc`\r\n8. `differing-param-doc`\r\n9. `differing-type-doc`\r\n#### Checks disabled:\r\n1. `multiple-constructor-doc`\r\n2. `missing-raises-doc`\r\n3. `redundant-returns-doc`\r\n\r\n## Checklist\r\n- [ ] The PR title starts with \"Fix #bugnum: \", followed by a short, clear summary of the changes.\r\n- [ ] The PR explanation includes the words \"Fixes #bugnum: ...\".\r\n- [X] The linter/Karma presubmit checks have passed.\r\n  - These should run automatically, but if not, you can manually trigger them locally using `python scripts/pre_commit_linter.py` and `bash scripts/run_frontend_tests.sh`.\r\n- [X] The PR is made from a branch that's **not** called \"develop\".\r\n- [X] The PR follows the [style guide](https://github.com/oppia/oppia/wiki/Coding-style-guide).\r\n- [X] The PR is assigned to an appropriate reviewer.\r\n  - If you're a new contributor, please ask on [Gitter](https://gitter.im/oppia/oppia-chat) for someone to assign a reviewer.\r\n  - If you're not sure who the appropriate reviewer is, please assign to the issue's \"owner\" -- see the \"talk-to\" label on the issue.\r\n","created_at":"2018-05-22T18:14:06Z","updated_at":"2018-05-24T08:41:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"47d1f7fce51373372cd8fbd37c58e183dd69e2d9","assignee":{"login":"apb7","id":24826041,"avatar_url":"https://avatars2.githubusercontent.com/u/24826041?v=4","gravatar_id":"","url":"https://api.github.com/users/apb7","html_url":"https://github.com/apb7","followers_url":"https://api.github.com/users/apb7/followers","following_url":"https://api.github.com/users/apb7/following{/other_user}","gists_url":"https://api.github.com/users/apb7/gists{/gist_id}","starred_url":"https://api.github.com/users/apb7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apb7/subscriptions","organizations_url":"https://api.github.com/users/apb7/orgs","repos_url":"https://api.github.com/users/apb7/repos","events_url":"https://api.github.com/users/apb7/events{/privacy}","received_events_url":"https://api.github.com/users/apb7/received_events","type":"User","site_admin":false},"assignees":[{"login":"apb7","id":24826041,"avatar_url":"https://avatars2.githubusercontent.com/u/24826041?v=4","gravatar_id":"","url":"https://api.github.com/users/apb7","html_url":"https://github.com/apb7","followers_url":"https://api.github.com/users/apb7/followers","following_url":"https://api.github.com/users/apb7/following{/other_user}","gists_url":"https://api.github.com/users/apb7/gists{/gist_id}","starred_url":"https://api.github.com/users/apb7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apb7/subscriptions","organizations_url":"https://api.github.com/users/apb7/orgs","repos_url":"https://api.github.com/users/apb7/repos","events_url":"https://api.github.com/users/apb7/events{/privacy}","received_events_url":"https://api.github.com/users/apb7/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/oppia/oppia/pulls/4967/commits","review_comments_url":"https://api.github.com/repos/oppia/oppia/pulls/4967/comments","review_comment_url":"https://api.github.com/repos/oppia/oppia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oppia/oppia/issues/4967/comments","statuses_url":"https://api.github.com/repos/oppia/oppia/statuses/5ceec7169ee74c599de177726f603c9b1df77b8d","head":{"label":"apb7:custom-pylint-checks","ref":"custom-pylint-checks","sha":"5ceec7169ee74c599de177726f603c9b1df77b8d","user":{"login":"apb7","id":24826041,"avatar_url":"https://avatars2.githubusercontent.com/u/24826041?v=4","gravatar_id":"","url":"https://api.github.com/users/apb7","html_url":"https://github.com/apb7","followers_url":"https://api.github.com/users/apb7/followers","following_url":"https://api.github.com/users/apb7/following{/other_user}","gists_url":"https://api.github.com/users/apb7/gists{/gist_id}","starred_url":"https://api.github.com/users/apb7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apb7/subscriptions","organizations_url":"https://api.github.com/users/apb7/orgs","repos_url":"https://api.github.com/users/apb7/repos","events_url":"https://api.github.com/users/apb7/events{/privacy}","received_events_url":"https://api.github.com/users/apb7/received_events","type":"User","site_admin":false},"repo":{"id":115636067,"name":"oppia","full_name":"apb7/oppia","owner":{"login":"apb7","id":24826041,"avatar_url":"https://avatars2.githubusercontent.com/u/24826041?v=4","gravatar_id":"","url":"https://api.github.com/users/apb7","html_url":"https://github.com/apb7","followers_url":"https://api.github.com/users/apb7/followers","following_url":"https://api.github.com/users/apb7/following{/other_user}","gists_url":"https://api.github.com/users/apb7/gists{/gist_id}","starred_url":"https://api.github.com/users/apb7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apb7/subscriptions","organizations_url":"https://api.github.com/users/apb7/orgs","repos_url":"https://api.github.com/users/apb7/repos","events_url":"https://api.github.com/users/apb7/events{/privacy}","received_events_url":"https://api.github.com/users/apb7/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/apb7/oppia","description":"Tool for collaboratively building interactive lessons.","fork":true,"url":"https://api.github.com/repos/apb7/oppia","forks_url":"https://api.github.com/repos/apb7/oppia/forks","keys_url":"https://api.github.com/repos/apb7/oppia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apb7/oppia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apb7/oppia/teams","hooks_url":"https://api.github.com/repos/apb7/oppia/hooks","issue_events_url":"https://api.github.com/repos/apb7/oppia/issues/events{/number}","events_url":"https://api.github.com/repos/apb7/oppia/events","assignees_url":"https://api.github.com/repos/apb7/oppia/assignees{/user}","branches_url":"https://api.github.com/repos/apb7/oppia/branches{/branch}","tags_url":"https://api.github.com/repos/apb7/oppia/tags","blobs_url":"https://api.github.com/repos/apb7/oppia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apb7/oppia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apb7/oppia/git/refs{/sha}","trees_url":"https://api.github.com/repos/apb7/oppia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apb7/oppia/statuses/{sha}","languages_url":"https://api.github.com/repos/apb7/oppia/languages","stargazers_url":"https://api.github.com/repos/apb7/oppia/stargazers","contributors_url":"https://api.github.com/repos/apb7/oppia/contributors","subscribers_url":"https://api.github.com/repos/apb7/oppia/subscribers","subscription_url":"https://api.github.com/repos/apb7/oppia/subscription","commits_url":"https://api.github.com/repos/apb7/oppia/commits{/sha}","git_commits_url":"https://api.github.com/repos/apb7/oppia/git/commits{/sha}","comments_url":"https://api.github.com/repos/apb7/oppia/comments{/number}","issue_comment_url":"https://api.github.com/repos/apb7/oppia/issues/comments{/number}","contents_url":"https://api.github.com/repos/apb7/oppia/contents/{+path}","compare_url":"https://api.github.com/repos/apb7/oppia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apb7/oppia/merges","archive_url":"https://api.github.com/repos/apb7/oppia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apb7/oppia/downloads","issues_url":"https://api.github.com/repos/apb7/oppia/issues{/number}","pulls_url":"https://api.github.com/repos/apb7/oppia/pulls{/number}","milestones_url":"https://api.github.com/repos/apb7/oppia/milestones{/number}","notifications_url":"https://api.github.com/repos/apb7/oppia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apb7/oppia/labels{/name}","releases_url":"https://api.github.com/repos/apb7/oppia/releases{/id}","deployments_url":"https://api.github.com/repos/apb7/oppia/deployments","created_at":"2017-12-28T15:30:55Z","updated_at":"2018-05-23T08:28:57Z","pushed_at":"2018-05-24T06:35:15Z","git_url":"git://github.com/apb7/oppia.git","ssh_url":"git@github.com:apb7/oppia.git","clone_url":"https://github.com/apb7/oppia.git","svn_url":"https://github.com/apb7/oppia","homepage":"https://www.oppia.org","size":102992,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"oppia:develop","ref":"develop","sha":"ec10dc604b41cc24b92f7ca5c28b031c30c69518","user":{"login":"oppia","id":11620230,"avatar_url":"https://avatars1.githubusercontent.com/u/11620230?v=4","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"repo":{"id":40687563,"name":"oppia","full_name":"oppia/oppia","owner":{"login":"oppia","id":11620230,"avatar_url":"https://avatars1.githubusercontent.com/u/11620230?v=4","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oppia/oppia","description":"Tool for collaboratively building interactive lessons.","fork":false,"url":"https://api.github.com/repos/oppia/oppia","forks_url":"https://api.github.com/repos/oppia/oppia/forks","keys_url":"https://api.github.com/repos/oppia/oppia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oppia/oppia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oppia/oppia/teams","hooks_url":"https://api.github.com/repos/oppia/oppia/hooks","issue_events_url":"https://api.github.com/repos/oppia/oppia/issues/events{/number}","events_url":"https://api.github.com/repos/oppia/oppia/events","assignees_url":"https://api.github.com/repos/oppia/oppia/assignees{/user}","branches_url":"https://api.github.com/repos/oppia/oppia/branches{/branch}","tags_url":"https://api.github.com/repos/oppia/oppia/tags","blobs_url":"https://api.github.com/repos/oppia/oppia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oppia/oppia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oppia/oppia/git/refs{/sha}","trees_url":"https://api.github.com/repos/oppia/oppia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oppia/oppia/statuses/{sha}","languages_url":"https://api.github.com/repos/oppia/oppia/languages","stargazers_url":"https://api.github.com/repos/oppia/oppia/stargazers","contributors_url":"https://api.github.com/repos/oppia/oppia/contributors","subscribers_url":"https://api.github.com/repos/oppia/oppia/subscribers","subscription_url":"https://api.github.com/repos/oppia/oppia/subscription","commits_url":"https://api.github.com/repos/oppia/oppia/commits{/sha}","git_commits_url":"https://api.github.com/repos/oppia/oppia/git/commits{/sha}","comments_url":"https://api.github.com/repos/oppia/oppia/comments{/number}","issue_comment_url":"https://api.github.com/repos/oppia/oppia/issues/comments{/number}","contents_url":"https://api.github.com/repos/oppia/oppia/contents/{+path}","compare_url":"https://api.github.com/repos/oppia/oppia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oppia/oppia/merges","archive_url":"https://api.github.com/repos/oppia/oppia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oppia/oppia/downloads","issues_url":"https://api.github.com/repos/oppia/oppia/issues{/number}","pulls_url":"https://api.github.com/repos/oppia/oppia/pulls{/number}","milestones_url":"https://api.github.com/repos/oppia/oppia/milestones{/number}","notifications_url":"https://api.github.com/repos/oppia/oppia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oppia/oppia/labels{/name}","releases_url":"https://api.github.com/repos/oppia/oppia/releases{/id}","deployments_url":"https://api.github.com/repos/oppia/oppia/deployments","created_at":"2015-08-14T00:16:14Z","updated_at":"2018-05-24T06:06:20Z","pushed_at":"2018-05-24T08:09:40Z","git_url":"git://github.com/oppia/oppia.git","ssh_url":"git@github.com:oppia/oppia.git","clone_url":"https://github.com/oppia/oppia.git","svn_url":"https://github.com/oppia/oppia","homepage":"https://www.oppia.org","size":102937,"stargazers_count":650,"watchers_count":650,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":629,"mirror_url":null,"archived":false,"open_issues_count":298,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":629,"open_issues":298,"watchers":650,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia/pulls/4967"},"html":{"href":"https://github.com/oppia/oppia/pull/4967"},"issue":{"href":"https://api.github.com/repos/oppia/oppia/issues/4967"},"comments":{"href":"https://api.github.com/repos/oppia/oppia/issues/4967/comments"},"review_comments":{"href":"https://api.github.com/repos/oppia/oppia/pulls/4967/comments"},"review_comment":{"href":"https://api.github.com/repos/oppia/oppia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oppia/oppia/pulls/4967/commits"},"statuses":{"href":"https://api.github.com/repos/oppia/oppia/statuses/5ceec7169ee74c599de177726f603c9b1df77b8d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"apb7"}}