{"action":"created","comment":{"url":"https://api.github.com/repos/djc/quinn/pulls/comments/223208559","pull_request_review_id":162285670,"id":223208559,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzIwODU1OQ==","diff_hunk":"@@ -59,7 +58,9 @@ pub use transport_error::Error as TransportError;\n pub const VERSION: u32 = 0xff00_000b;\n \n /// TLS ALPN value for HTTP over QUIC\n-pub const ALPN_QUIC_HTTP: &str = \"hq-11\";\n+lazy_static! {\n+    pub static ref ALPN_QUIC_HTTP: Vec<u8> = \"hq-11\".into();","path":"quinn-proto/src/lib.rs","position":14,"original_position":14,"commit_id":"8cd707a44229bf95e4228912bacd11530979f322","original_commit_id":"8cd707a44229bf95e4228912bacd11530979f322","user":{"login":"stammw","id":6791052,"node_id":"MDQ6VXNlcjY3OTEwNTI=","avatar_url":"https://avatars3.githubusercontent.com/u/6791052?v=4","gravatar_id":"","url":"https://api.github.com/users/stammw","html_url":"https://github.com/stammw","followers_url":"https://api.github.com/users/stammw/followers","following_url":"https://api.github.com/users/stammw/following{/other_user}","gists_url":"https://api.github.com/users/stammw/gists{/gist_id}","starred_url":"https://api.github.com/users/stammw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stammw/subscriptions","organizations_url":"https://api.github.com/users/stammw/orgs","repos_url":"https://api.github.com/users/stammw/repos","events_url":"https://api.github.com/users/stammw/events{/privacy}","received_events_url":"https://api.github.com/users/stammw/received_events","type":"User","site_admin":false},"body":"Thank you for the advice.","created_at":"2018-10-07T10:46:51Z","updated_at":"2018-10-07T10:46:51Z","html_url":"https://github.com/djc/quinn/pull/47#discussion_r223208559","pull_request_url":"https://api.github.com/repos/djc/quinn/pulls/47","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/djc/quinn/pulls/comments/223208559"},"html":{"href":"https://github.com/djc/quinn/pull/47#discussion_r223208559"},"pull_request":{"href":"https://api.github.com/repos/djc/quinn/pulls/47"}},"in_reply_to_id":223208055},"pull_request":{"url":"https://api.github.com/repos/djc/quinn/pulls/47","id":220736610,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNzM2NjEw","html_url":"https://github.com/djc/quinn/pull/47","diff_url":"https://github.com/djc/quinn/pull/47.diff","patch_url":"https://github.com/djc/quinn/pull/47.patch","issue_url":"https://api.github.com/repos/djc/quinn/issues/47","number":47,"state":"open","locked":false,"title":"Let the user select ALPN protocols values #32","user":{"login":"stammw","id":6791052,"node_id":"MDQ6VXNlcjY3OTEwNTI=","avatar_url":"https://avatars3.githubusercontent.com/u/6791052?v=4","gravatar_id":"","url":"https://api.github.com/users/stammw","html_url":"https://github.com/stammw","followers_url":"https://api.github.com/users/stammw/followers","following_url":"https://api.github.com/users/stammw/following{/other_user}","gists_url":"https://api.github.com/users/stammw/gists{/gist_id}","starred_url":"https://api.github.com/users/stammw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stammw/subscriptions","organizations_url":"https://api.github.com/users/stammw/orgs","repos_url":"https://api.github.com/users/stammw/repos","events_url":"https://api.github.com/users/stammw/events{/privacy}","received_events_url":"https://api.github.com/users/stammw/received_events","type":"User","site_admin":false},"body":"I think it might do the job ?\r\n\r\nIt may be interesting to offer features depending on what protocol has been negotiated?","created_at":"2018-10-05T15:16:44Z","updated_at":"2018-10-07T10:46:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e69c63459478a40b6b41c8e62e882edd8b2994ed","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/djc/quinn/pulls/47/commits","review_comments_url":"https://api.github.com/repos/djc/quinn/pulls/47/comments","review_comment_url":"https://api.github.com/repos/djc/quinn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/djc/quinn/issues/47/comments","statuses_url":"https://api.github.com/repos/djc/quinn/statuses/8cd707a44229bf95e4228912bacd11530979f322","head":{"label":"stammw:master","ref":"master","sha":"8cd707a44229bf95e4228912bacd11530979f322","user":{"login":"stammw","id":6791052,"node_id":"MDQ6VXNlcjY3OTEwNTI=","avatar_url":"https://avatars3.githubusercontent.com/u/6791052?v=4","gravatar_id":"","url":"https://api.github.com/users/stammw","html_url":"https://github.com/stammw","followers_url":"https://api.github.com/users/stammw/followers","following_url":"https://api.github.com/users/stammw/following{/other_user}","gists_url":"https://api.github.com/users/stammw/gists{/gist_id}","starred_url":"https://api.github.com/users/stammw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stammw/subscriptions","organizations_url":"https://api.github.com/users/stammw/orgs","repos_url":"https://api.github.com/users/stammw/repos","events_url":"https://api.github.com/users/stammw/events{/privacy}","received_events_url":"https://api.github.com/users/stammw/received_events","type":"User","site_admin":false},"repo":{"id":151731196,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE3MzExOTY=","name":"quinn","full_name":"stammw/quinn","private":false,"owner":{"login":"stammw","id":6791052,"node_id":"MDQ6VXNlcjY3OTEwNTI=","avatar_url":"https://avatars3.githubusercontent.com/u/6791052?v=4","gravatar_id":"","url":"https://api.github.com/users/stammw","html_url":"https://github.com/stammw","followers_url":"https://api.github.com/users/stammw/followers","following_url":"https://api.github.com/users/stammw/following{/other_user}","gists_url":"https://api.github.com/users/stammw/gists{/gist_id}","starred_url":"https://api.github.com/users/stammw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stammw/subscriptions","organizations_url":"https://api.github.com/users/stammw/orgs","repos_url":"https://api.github.com/users/stammw/repos","events_url":"https://api.github.com/users/stammw/events{/privacy}","received_events_url":"https://api.github.com/users/stammw/received_events","type":"User","site_admin":false},"html_url":"https://github.com/stammw/quinn","description":"Futures-based QUIC implementation in Rust","fork":true,"url":"https://api.github.com/repos/stammw/quinn","forks_url":"https://api.github.com/repos/stammw/quinn/forks","keys_url":"https://api.github.com/repos/stammw/quinn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stammw/quinn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stammw/quinn/teams","hooks_url":"https://api.github.com/repos/stammw/quinn/hooks","issue_events_url":"https://api.github.com/repos/stammw/quinn/issues/events{/number}","events_url":"https://api.github.com/repos/stammw/quinn/events","assignees_url":"https://api.github.com/repos/stammw/quinn/assignees{/user}","branches_url":"https://api.github.com/repos/stammw/quinn/branches{/branch}","tags_url":"https://api.github.com/repos/stammw/quinn/tags","blobs_url":"https://api.github.com/repos/stammw/quinn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stammw/quinn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stammw/quinn/git/refs{/sha}","trees_url":"https://api.github.com/repos/stammw/quinn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stammw/quinn/statuses/{sha}","languages_url":"https://api.github.com/repos/stammw/quinn/languages","stargazers_url":"https://api.github.com/repos/stammw/quinn/stargazers","contributors_url":"https://api.github.com/repos/stammw/quinn/contributors","subscribers_url":"https://api.github.com/repos/stammw/quinn/subscribers","subscription_url":"https://api.github.com/repos/stammw/quinn/subscription","commits_url":"https://api.github.com/repos/stammw/quinn/commits{/sha}","git_commits_url":"https://api.github.com/repos/stammw/quinn/git/commits{/sha}","comments_url":"https://api.github.com/repos/stammw/quinn/comments{/number}","issue_comment_url":"https://api.github.com/repos/stammw/quinn/issues/comments{/number}","contents_url":"https://api.github.com/repos/stammw/quinn/contents/{+path}","compare_url":"https://api.github.com/repos/stammw/quinn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stammw/quinn/merges","archive_url":"https://api.github.com/repos/stammw/quinn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stammw/quinn/downloads","issues_url":"https://api.github.com/repos/stammw/quinn/issues{/number}","pulls_url":"https://api.github.com/repos/stammw/quinn/pulls{/number}","milestones_url":"https://api.github.com/repos/stammw/quinn/milestones{/number}","notifications_url":"https://api.github.com/repos/stammw/quinn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stammw/quinn/labels{/name}","releases_url":"https://api.github.com/repos/stammw/quinn/releases{/id}","deployments_url":"https://api.github.com/repos/stammw/quinn/deployments","created_at":"2018-10-05T14:15:40Z","updated_at":"2018-10-07T09:28:57Z","pushed_at":"2018-10-07T09:28:55Z","git_url":"git://github.com/stammw/quinn.git","ssh_url":"git@github.com:stammw/quinn.git","clone_url":"https://github.com/stammw/quinn.git","svn_url":"https://github.com/stammw/quinn","homepage":null,"size":802,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"djc:master","ref":"master","sha":"4807a970a0363660f876a54d3fbfcc76120ac26b","user":{"login":"djc","id":158471,"node_id":"MDQ6VXNlcjE1ODQ3MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/158471?v=4","gravatar_id":"","url":"https://api.github.com/users/djc","html_url":"https://github.com/djc","followers_url":"https://api.github.com/users/djc/followers","following_url":"https://api.github.com/users/djc/following{/other_user}","gists_url":"https://api.github.com/users/djc/gists{/gist_id}","starred_url":"https://api.github.com/users/djc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djc/subscriptions","organizations_url":"https://api.github.com/users/djc/orgs","repos_url":"https://api.github.com/users/djc/repos","events_url":"https://api.github.com/users/djc/events{/privacy}","received_events_url":"https://api.github.com/users/djc/received_events","type":"User","site_admin":false},"repo":{"id":127870944,"node_id":"MDEwOlJlcG9zaXRvcnkxMjc4NzA5NDQ=","name":"quinn","full_name":"djc/quinn","private":false,"owner":{"login":"djc","id":158471,"node_id":"MDQ6VXNlcjE1ODQ3MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/158471?v=4","gravatar_id":"","url":"https://api.github.com/users/djc","html_url":"https://github.com/djc","followers_url":"https://api.github.com/users/djc/followers","following_url":"https://api.github.com/users/djc/following{/other_user}","gists_url":"https://api.github.com/users/djc/gists{/gist_id}","starred_url":"https://api.github.com/users/djc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djc/subscriptions","organizations_url":"https://api.github.com/users/djc/orgs","repos_url":"https://api.github.com/users/djc/repos","events_url":"https://api.github.com/users/djc/events{/privacy}","received_events_url":"https://api.github.com/users/djc/received_events","type":"User","site_admin":false},"html_url":"https://github.com/djc/quinn","description":"Futures-based QUIC implementation in Rust","fork":false,"url":"https://api.github.com/repos/djc/quinn","forks_url":"https://api.github.com/repos/djc/quinn/forks","keys_url":"https://api.github.com/repos/djc/quinn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/djc/quinn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/djc/quinn/teams","hooks_url":"https://api.github.com/repos/djc/quinn/hooks","issue_events_url":"https://api.github.com/repos/djc/quinn/issues/events{/number}","events_url":"https://api.github.com/repos/djc/quinn/events","assignees_url":"https://api.github.com/repos/djc/quinn/assignees{/user}","branches_url":"https://api.github.com/repos/djc/quinn/branches{/branch}","tags_url":"https://api.github.com/repos/djc/quinn/tags","blobs_url":"https://api.github.com/repos/djc/quinn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/djc/quinn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/djc/quinn/git/refs{/sha}","trees_url":"https://api.github.com/repos/djc/quinn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/djc/quinn/statuses/{sha}","languages_url":"https://api.github.com/repos/djc/quinn/languages","stargazers_url":"https://api.github.com/repos/djc/quinn/stargazers","contributors_url":"https://api.github.com/repos/djc/quinn/contributors","subscribers_url":"https://api.github.com/repos/djc/quinn/subscribers","subscription_url":"https://api.github.com/repos/djc/quinn/subscription","commits_url":"https://api.github.com/repos/djc/quinn/commits{/sha}","git_commits_url":"https://api.github.com/repos/djc/quinn/git/commits{/sha}","comments_url":"https://api.github.com/repos/djc/quinn/comments{/number}","issue_comment_url":"https://api.github.com/repos/djc/quinn/issues/comments{/number}","contents_url":"https://api.github.com/repos/djc/quinn/contents/{+path}","compare_url":"https://api.github.com/repos/djc/quinn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/djc/quinn/merges","archive_url":"https://api.github.com/repos/djc/quinn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/djc/quinn/downloads","issues_url":"https://api.github.com/repos/djc/quinn/issues{/number}","pulls_url":"https://api.github.com/repos/djc/quinn/pulls{/number}","milestones_url":"https://api.github.com/repos/djc/quinn/milestones{/number}","notifications_url":"https://api.github.com/repos/djc/quinn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/djc/quinn/labels{/name}","releases_url":"https://api.github.com/repos/djc/quinn/releases{/id}","deployments_url":"https://api.github.com/repos/djc/quinn/deployments","created_at":"2018-04-03T07:47:41Z","updated_at":"2018-10-06T18:21:26Z","pushed_at":"2018-10-07T09:28:56Z","git_url":"git://github.com/djc/quinn.git","ssh_url":"git@github.com:djc/quinn.git","clone_url":"https://github.com/djc/quinn.git","svn_url":"https://github.com/djc/quinn","homepage":null,"size":805,"stargazers_count":109,"watchers_count":109,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":17,"open_issues":16,"watchers":109,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/djc/quinn/pulls/47"},"html":{"href":"https://github.com/djc/quinn/pull/47"},"issue":{"href":"https://api.github.com/repos/djc/quinn/issues/47"},"comments":{"href":"https://api.github.com/repos/djc/quinn/issues/47/comments"},"review_comments":{"href":"https://api.github.com/repos/djc/quinn/pulls/47/comments"},"review_comment":{"href":"https://api.github.com/repos/djc/quinn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/djc/quinn/pulls/47/commits"},"statuses":{"href":"https://api.github.com/repos/djc/quinn/statuses/8cd707a44229bf95e4228912bacd11530979f322"}},"author_association":"NONE"}}
{"actor":{"display_login":"stammw"}}