{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/cluster-ingress-operator/pulls/comments/225645199","pull_request_review_id":165289424,"id":225645199,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTY0NTE5OQ==","diff_hunk":"@@ -163,10 +225,34 @@ func (h *Handler) syncIngressUpdate(ci *ingressv1alpha1.ClusterIngress) error {\n \treturn nil\n }\n \n-func (h *Handler) deleteIngress(ci *ingressv1alpha1.ClusterIngress) error {\n+// ensureRouterDeleted ensures that any router resources associated with the\n+// clusteringress are deleted.\n+func (h *Handler) ensureRouterDeleted(ci *ingressv1alpha1.ClusterIngress) error {\n \tds, err := h.manifestFactory.RouterDaemonSet(ci)\n \tif err != nil {\n \t\treturn fmt.Errorf(\"couldn't build DaemonSet object for deletion: %v\", err)\n \t}\n-\treturn sdk.Delete(ds)\n+\terr = sdk.Delete(ds)\n+\tif !errors.IsNotFound(err) {\n+\t\treturn err\n+\t}\n+\treturn nil\n+}\n+\n+// RemoveString returns a newly created []string that contains all items from slice that\n+// are not equal to s.\n+func RemoveString(slice []string, s string) []string {","path":"pkg/stub/handler.go","position":173,"original_position":173,"commit_id":"03eb5e35c1f537a1331b223bc4ea9126ededc460","original_commit_id":"03eb5e35c1f537a1331b223bc4ea9126ededc460","user":{"login":"ironcladlou","id":298299,"node_id":"MDQ6VXNlcjI5ODI5OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/298299?v=4","gravatar_id":"","url":"https://api.github.com/users/ironcladlou","html_url":"https://github.com/ironcladlou","followers_url":"https://api.github.com/users/ironcladlou/followers","following_url":"https://api.github.com/users/ironcladlou/following{/other_user}","gists_url":"https://api.github.com/users/ironcladlou/gists{/gist_id}","starred_url":"https://api.github.com/users/ironcladlou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironcladlou/subscriptions","organizations_url":"https://api.github.com/users/ironcladlou/orgs","repos_url":"https://api.github.com/users/ironcladlou/repos","events_url":"https://api.github.com/users/ironcladlou/events{/privacy}","received_events_url":"https://api.github.com/users/ironcladlou/received_events","type":"User","site_admin":false},"body":"I wish the upstream `slice` package were in a better place so we could use it and some other nice stuff I'll have to copy in 😞 ","created_at":"2018-10-16T17:53:05Z","updated_at":"2018-10-16T17:53:06Z","html_url":"https://github.com/openshift/cluster-ingress-operator/pull/49#discussion_r225645199","pull_request_url":"https://api.github.com/repos/openshift/cluster-ingress-operator/pulls/49","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openshift/cluster-ingress-operator/pulls/comments/225645199"},"html":{"href":"https://github.com/openshift/cluster-ingress-operator/pull/49#discussion_r225645199"},"pull_request":{"href":"https://api.github.com/repos/openshift/cluster-ingress-operator/pulls/49"}},"in_reply_to_id":225642044},"pull_request":{"url":"https://api.github.com/repos/openshift/cluster-ingress-operator/pulls/49","id":223252910,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMjUyOTEw","html_url":"https://github.com/openshift/cluster-ingress-operator/pull/49","diff_url":"https://github.com/openshift/cluster-ingress-operator/pull/49.diff","patch_url":"https://github.com/openshift/cluster-ingress-operator/pull/49.patch","issue_url":"https://api.github.com/repos/openshift/cluster-ingress-operator/issues/49","number":49,"state":"open","locked":false,"title":"Refactor to level driven design","user":{"login":"ironcladlou","id":298299,"node_id":"MDQ6VXNlcjI5ODI5OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/298299?v=4","gravatar_id":"","url":"https://api.github.com/users/ironcladlou","html_url":"https://github.com/ironcladlou","followers_url":"https://api.github.com/users/ironcladlou/followers","following_url":"https://api.github.com/users/ironcladlou/following{/other_user}","gists_url":"https://api.github.com/users/ironcladlou/gists{/gist_id}","starred_url":"https://api.github.com/users/ironcladlou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironcladlou/subscriptions","organizations_url":"https://api.github.com/users/ironcladlou/orgs","repos_url":"https://api.github.com/users/ironcladlou/repos","events_url":"https://api.github.com/users/ironcladlou/events{/privacy}","received_events_url":"https://api.github.com/users/ironcladlou/received_events","type":"User","site_admin":false},"body":"Refactor the handler to be level driven.\r\n\r\n/cc @openshift/sig-network-edge ","created_at":"2018-10-16T13:35:53Z","updated_at":"2018-10-16T17:53:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7d89676bbce9f257925c9fbd89a4ebcb22bbe07c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1026574273,"node_id":"MDU6TGFiZWwxMDI2NTc0Mjcz","url":"https://api.github.com/repos/openshift/cluster-ingress-operator/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":1027063599,"node_id":"MDU6TGFiZWwxMDI3MDYzNTk5","url":"https://api.github.com/repos/openshift/cluster-ingress-operator/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/cluster-ingress-operator/pulls/49/commits","review_comments_url":"https://api.github.com/repos/openshift/cluster-ingress-operator/pulls/49/comments","review_comment_url":"https://api.github.com/repos/openshift/cluster-ingress-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/cluster-ingress-operator/issues/49/comments","statuses_url":"https://api.github.com/repos/openshift/cluster-ingress-operator/statuses/03eb5e35c1f537a1331b223bc4ea9126ededc460","head":{"label":"ironcladlou:level-driven","ref":"level-driven","sha":"03eb5e35c1f537a1331b223bc4ea9126ededc460","user":{"login":"ironcladlou","id":298299,"node_id":"MDQ6VXNlcjI5ODI5OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/298299?v=4","gravatar_id":"","url":"https://api.github.com/users/ironcladlou","html_url":"https://github.com/ironcladlou","followers_url":"https://api.github.com/users/ironcladlou/followers","following_url":"https://api.github.com/users/ironcladlou/following{/other_user}","gists_url":"https://api.github.com/users/ironcladlou/gists{/gist_id}","starred_url":"https://api.github.com/users/ironcladlou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironcladlou/subscriptions","organizations_url":"https://api.github.com/users/ironcladlou/orgs","repos_url":"https://api.github.com/users/ironcladlou/repos","events_url":"https://api.github.com/users/ironcladlou/events{/privacy}","received_events_url":"https://api.github.com/users/ironcladlou/received_events","type":"User","site_admin":false},"repo":{"id":145021179,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUwMjExNzk=","name":"cluster-ingress-operator","full_name":"ironcladlou/cluster-ingress-operator","private":false,"owner":{"login":"ironcladlou","id":298299,"node_id":"MDQ6VXNlcjI5ODI5OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/298299?v=4","gravatar_id":"","url":"https://api.github.com/users/ironcladlou","html_url":"https://github.com/ironcladlou","followers_url":"https://api.github.com/users/ironcladlou/followers","following_url":"https://api.github.com/users/ironcladlou/following{/other_user}","gists_url":"https://api.github.com/users/ironcladlou/gists{/gist_id}","starred_url":"https://api.github.com/users/ironcladlou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironcladlou/subscriptions","organizations_url":"https://api.github.com/users/ironcladlou/orgs","repos_url":"https://api.github.com/users/ironcladlou/repos","events_url":"https://api.github.com/users/ironcladlou/events{/privacy}","received_events_url":"https://api.github.com/users/ironcladlou/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ironcladlou/cluster-ingress-operator","description":"The Cluster Ingress Operator manages highly available network ingress for OpenShift","fork":true,"url":"https://api.github.com/repos/ironcladlou/cluster-ingress-operator","forks_url":"https://api.github.com/repos/ironcladlou/cluster-ingress-operator/forks","keys_url":"https://api.github.com/repos/ironcladlou/cluster-ingress-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ironcladlou/cluster-ingress-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ironcladlou/cluster-ingress-operator/teams","hooks_url":"https://api.github.com/repos/ironcladlou/cluster-ingress-operator/hooks","issue_events_url":"https://api.github.com/repos/ironcladlou/cluster-ingress-operator/issues/events{/number}","events_url":"https://api.github.com/repos/ironcladlou/cluster-ingress-operator/events","assignees_url":"https://api.github.com/repos/ironcladlou/cluster-ingress-operator/assignees{/user}","branches_url":"https://api.github.com/repos/ironcladlou/cluster-ingress-operator/branches{/branch}","tags_url":"https://api.github.com/repos/ironcladlou/cluster-ingress-operator/tags","blobs_url":"https://api.github.com/repos/ironcladlou/cluster-ingress-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ironcladlou/cluster-ingress-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ironcladlou/cluster-ingress-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/ironcladlou/cluster-ingress-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ironcladlou/cluster-ingress-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/ironcladlou/cluster-ingress-operator/languages","stargazers_url":"https://api.github.com/repos/ironcladlou/cluster-ingress-operator/stargazers","contributors_url":"https://api.github.com/repos/ironcladlou/cluster-ingress-operator/contributors","subscribers_url":"https://api.github.com/repos/ironcladlou/cluster-ingress-operator/subscribers","subscription_url":"https://api.github.com/repos/ironcladlou/cluster-ingress-operator/subscription","commits_url":"https://api.github.com/repos/ironcladlou/cluster-ingress-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/ironcladlou/cluster-ingress-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/ironcladlou/cluster-ingress-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/ironcladlou/cluster-ingress-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/ironcladlou/cluster-ingress-operator/contents/{+path}","compare_url":"https://api.github.com/repos/ironcladlou/cluster-ingress-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ironcladlou/cluster-ingress-operator/merges","archive_url":"https://api.github.com/repos/ironcladlou/cluster-ingress-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ironcladlou/cluster-ingress-operator/downloads","issues_url":"https://api.github.com/repos/ironcladlou/cluster-ingress-operator/issues{/number}","pulls_url":"https://api.github.com/repos/ironcladlou/cluster-ingress-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/ironcladlou/cluster-ingress-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/ironcladlou/cluster-ingress-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ironcladlou/cluster-ingress-operator/labels{/name}","releases_url":"https://api.github.com/repos/ironcladlou/cluster-ingress-operator/releases{/id}","deployments_url":"https://api.github.com/repos/ironcladlou/cluster-ingress-operator/deployments","created_at":"2018-08-16T17:45:40Z","updated_at":"2018-09-27T00:44:46Z","pushed_at":"2018-10-16T14:33:15Z","git_url":"git://github.com/ironcladlou/cluster-ingress-operator.git","ssh_url":"git@github.com:ironcladlou/cluster-ingress-operator.git","clone_url":"https://github.com/ironcladlou/cluster-ingress-operator.git","svn_url":"https://github.com/ironcladlou/cluster-ingress-operator","homepage":null,"size":32309,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"7f924203bce74706e37d0e1dda0fc9338b202afe","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":145020700,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUwMjA3MDA=","name":"cluster-ingress-operator","full_name":"openshift/cluster-ingress-operator","private":false,"owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openshift/cluster-ingress-operator","description":"The Cluster Ingress Operator manages highly available network ingress for OpenShift","fork":false,"url":"https://api.github.com/repos/openshift/cluster-ingress-operator","forks_url":"https://api.github.com/repos/openshift/cluster-ingress-operator/forks","keys_url":"https://api.github.com/repos/openshift/cluster-ingress-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/cluster-ingress-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/cluster-ingress-operator/teams","hooks_url":"https://api.github.com/repos/openshift/cluster-ingress-operator/hooks","issue_events_url":"https://api.github.com/repos/openshift/cluster-ingress-operator/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/cluster-ingress-operator/events","assignees_url":"https://api.github.com/repos/openshift/cluster-ingress-operator/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/cluster-ingress-operator/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/cluster-ingress-operator/tags","blobs_url":"https://api.github.com/repos/openshift/cluster-ingress-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/cluster-ingress-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/cluster-ingress-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/cluster-ingress-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/cluster-ingress-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/cluster-ingress-operator/languages","stargazers_url":"https://api.github.com/repos/openshift/cluster-ingress-operator/stargazers","contributors_url":"https://api.github.com/repos/openshift/cluster-ingress-operator/contributors","subscribers_url":"https://api.github.com/repos/openshift/cluster-ingress-operator/subscribers","subscription_url":"https://api.github.com/repos/openshift/cluster-ingress-operator/subscription","commits_url":"https://api.github.com/repos/openshift/cluster-ingress-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/cluster-ingress-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/cluster-ingress-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/cluster-ingress-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/cluster-ingress-operator/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/cluster-ingress-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/cluster-ingress-operator/merges","archive_url":"https://api.github.com/repos/openshift/cluster-ingress-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/cluster-ingress-operator/downloads","issues_url":"https://api.github.com/repos/openshift/cluster-ingress-operator/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/cluster-ingress-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/cluster-ingress-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/cluster-ingress-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/cluster-ingress-operator/labels{/name}","releases_url":"https://api.github.com/repos/openshift/cluster-ingress-operator/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/cluster-ingress-operator/deployments","created_at":"2018-08-16T17:40:37Z","updated_at":"2018-10-15T14:53:23Z","pushed_at":"2018-10-16T14:33:17Z","git_url":"git://github.com/openshift/cluster-ingress-operator.git","ssh_url":"git@github.com:openshift/cluster-ingress-operator.git","clone_url":"https://github.com/openshift/cluster-ingress-operator.git","svn_url":"https://github.com/openshift/cluster-ingress-operator","homepage":null,"size":32305,"stargazers_count":3,"watchers_count":3,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5,"open_issues":5,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/cluster-ingress-operator/pulls/49"},"html":{"href":"https://github.com/openshift/cluster-ingress-operator/pull/49"},"issue":{"href":"https://api.github.com/repos/openshift/cluster-ingress-operator/issues/49"},"comments":{"href":"https://api.github.com/repos/openshift/cluster-ingress-operator/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/cluster-ingress-operator/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/cluster-ingress-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/cluster-ingress-operator/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/cluster-ingress-operator/statuses/03eb5e35c1f537a1331b223bc4ea9126ededc460"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ironcladlou"}}