{"action":"created","comment":{"url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/pulls/comments/213583159","pull_request_review_id":150447443,"id":213583159,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzU4MzE1OQ==","diff_hunk":"@@ -11,7 +12,11 @@ class NewTimeEntry extends React.Component {\n     client: defaultData.clients[0],\n     activity: defaultData.activities[0],\n     from: defaultData.from,\n-    to: defaultData.to\n+    to: defaultData.to,\n+    isValidDate: true,\n+    isValidFrom: true,\n+    isValidTo: true,\n+    isSubmitInValid: false","path":"components/new-time-entry/NewTimeEntry.jsx","position":17,"original_position":17,"commit_id":"e923c452769c80315f6875d7df4bb0a452f704e6","original_commit_id":"e923c452769c80315f6875d7df4bb0a452f704e6","user":{"login":"seantijmons","id":10575736,"node_id":"MDQ6VXNlcjEwNTc1NzM2","avatar_url":"https://avatars2.githubusercontent.com/u/10575736?v=4","gravatar_id":"","url":"https://api.github.com/users/seantijmons","html_url":"https://github.com/seantijmons","followers_url":"https://api.github.com/users/seantijmons/followers","following_url":"https://api.github.com/users/seantijmons/following{/other_user}","gists_url":"https://api.github.com/users/seantijmons/gists{/gist_id}","starred_url":"https://api.github.com/users/seantijmons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seantijmons/subscriptions","organizations_url":"https://api.github.com/users/seantijmons/orgs","repos_url":"https://api.github.com/users/seantijmons/repos","events_url":"https://api.github.com/users/seantijmons/events{/privacy}","received_events_url":"https://api.github.com/users/seantijmons/received_events","type":"User","site_admin":false},"body":"the isPosting redux state is set on false, so otherwise in NewTimeEntry lines 199&201 will not toggle the button on disabled. I could rename it to isSubmitValid but then it contradicts the name because on load it should be valid","created_at":"2018-08-29T08:12:08Z","updated_at":"2018-08-29T08:12:09Z","html_url":"https://github.com/humanoidsbv/team-awesome-sean/pull/24#discussion_r213583159","pull_request_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/pulls/24","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/pulls/comments/213583159"},"html":{"href":"https://github.com/humanoidsbv/team-awesome-sean/pull/24#discussion_r213583159"},"pull_request":{"href":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/pulls/24"}},"in_reply_to_id":213366004},"pull_request":{"url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/pulls/24","id":211445237,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNDQ1MjM3","html_url":"https://github.com/humanoidsbv/team-awesome-sean/pull/24","diff_url":"https://github.com/humanoidsbv/team-awesome-sean/pull/24.diff","patch_url":"https://github.com/humanoidsbv/team-awesome-sean/pull/24.patch","issue_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/issues/24","number":24,"state":"open","locked":false,"title":"(WIP) When I am adding a time entry, I want my input to be validated #22","user":{"login":"seantijmons","id":10575736,"node_id":"MDQ6VXNlcjEwNTc1NzM2","avatar_url":"https://avatars2.githubusercontent.com/u/10575736?v=4","gravatar_id":"","url":"https://api.github.com/users/seantijmons","html_url":"https://github.com/seantijmons","followers_url":"https://api.github.com/users/seantijmons/followers","following_url":"https://api.github.com/users/seantijmons/following{/other_user}","gists_url":"https://api.github.com/users/seantijmons/gists{/gist_id}","starred_url":"https://api.github.com/users/seantijmons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seantijmons/subscriptions","organizations_url":"https://api.github.com/users/seantijmons/orgs","repos_url":"https://api.github.com/users/seantijmons/repos","events_url":"https://api.github.com/users/seantijmons/events{/privacy}","received_events_url":"https://api.github.com/users/seantijmons/received_events","type":"User","site_admin":false},"body":"fixed scss for the form\r\nadded the duration of inputfields to/from","created_at":"2018-08-28T14:34:19Z","updated_at":"2018-08-29T08:12:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"875bfabbe022c1e39244b14503509076489513d1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"naomiaz","id":29675763,"node_id":"MDQ6VXNlcjI5Njc1NzYz","avatar_url":"https://avatars3.githubusercontent.com/u/29675763?v=4","gravatar_id":"","url":"https://api.github.com/users/naomiaz","html_url":"https://github.com/naomiaz","followers_url":"https://api.github.com/users/naomiaz/followers","following_url":"https://api.github.com/users/naomiaz/following{/other_user}","gists_url":"https://api.github.com/users/naomiaz/gists{/gist_id}","starred_url":"https://api.github.com/users/naomiaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naomiaz/subscriptions","organizations_url":"https://api.github.com/users/naomiaz/orgs","repos_url":"https://api.github.com/users/naomiaz/repos","events_url":"https://api.github.com/users/naomiaz/events{/privacy}","received_events_url":"https://api.github.com/users/naomiaz/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/pulls/24/commits","review_comments_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/pulls/24/comments","review_comment_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/pulls/comments{/number}","comments_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/issues/24/comments","statuses_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/statuses/e923c452769c80315f6875d7df4bb0a452f704e6","head":{"label":"humanoidsbv:feature/form-validation","ref":"feature/form-validation","sha":"e923c452769c80315f6875d7df4bb0a452f704e6","user":{"login":"humanoidsbv","id":41685263,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxNjg1MjYz","avatar_url":"https://avatars0.githubusercontent.com/u/41685263?v=4","gravatar_id":"","url":"https://api.github.com/users/humanoidsbv","html_url":"https://github.com/humanoidsbv","followers_url":"https://api.github.com/users/humanoidsbv/followers","following_url":"https://api.github.com/users/humanoidsbv/following{/other_user}","gists_url":"https://api.github.com/users/humanoidsbv/gists{/gist_id}","starred_url":"https://api.github.com/users/humanoidsbv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/humanoidsbv/subscriptions","organizations_url":"https://api.github.com/users/humanoidsbv/orgs","repos_url":"https://api.github.com/users/humanoidsbv/repos","events_url":"https://api.github.com/users/humanoidsbv/events{/privacy}","received_events_url":"https://api.github.com/users/humanoidsbv/received_events","type":"Organization","site_admin":false},"repo":{"id":143646139,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM2NDYxMzk=","name":"team-awesome-sean","full_name":"humanoidsbv/team-awesome-sean","owner":{"login":"humanoidsbv","id":41685263,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxNjg1MjYz","avatar_url":"https://avatars0.githubusercontent.com/u/41685263?v=4","gravatar_id":"","url":"https://api.github.com/users/humanoidsbv","html_url":"https://github.com/humanoidsbv","followers_url":"https://api.github.com/users/humanoidsbv/followers","following_url":"https://api.github.com/users/humanoidsbv/following{/other_user}","gists_url":"https://api.github.com/users/humanoidsbv/gists{/gist_id}","starred_url":"https://api.github.com/users/humanoidsbv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/humanoidsbv/subscriptions","organizations_url":"https://api.github.com/users/humanoidsbv/orgs","repos_url":"https://api.github.com/users/humanoidsbv/repos","events_url":"https://api.github.com/users/humanoidsbv/events{/privacy}","received_events_url":"https://api.github.com/users/humanoidsbv/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/humanoidsbv/team-awesome-sean","description":null,"fork":false,"url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean","forks_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/forks","keys_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/teams","hooks_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/hooks","issue_events_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/issues/events{/number}","events_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/events","assignees_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/assignees{/user}","branches_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/branches{/branch}","tags_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/tags","blobs_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/git/refs{/sha}","trees_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/statuses/{sha}","languages_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/languages","stargazers_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/stargazers","contributors_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/contributors","subscribers_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/subscribers","subscription_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/subscription","commits_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/commits{/sha}","git_commits_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/git/commits{/sha}","comments_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/comments{/number}","issue_comment_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/issues/comments{/number}","contents_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/contents/{+path}","compare_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/merges","archive_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/downloads","issues_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/issues{/number}","pulls_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/pulls{/number}","milestones_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/milestones{/number}","notifications_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/labels{/name}","releases_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/releases{/id}","deployments_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/deployments","created_at":"2018-08-05T20:40:48Z","updated_at":"2018-08-28T08:20:14Z","pushed_at":"2018-08-28T14:34:19Z","git_url":"git://github.com/humanoidsbv/team-awesome-sean.git","ssh_url":"git@github.com:humanoidsbv/team-awesome-sean.git","clone_url":"https://github.com/humanoidsbv/team-awesome-sean.git","svn_url":"https://github.com/humanoidsbv/team-awesome-sean","homepage":null,"size":991,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"humanoidsbv:master","ref":"master","sha":"7263aa7265666ac84957c2cf6c0120369da23fea","user":{"login":"humanoidsbv","id":41685263,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxNjg1MjYz","avatar_url":"https://avatars0.githubusercontent.com/u/41685263?v=4","gravatar_id":"","url":"https://api.github.com/users/humanoidsbv","html_url":"https://github.com/humanoidsbv","followers_url":"https://api.github.com/users/humanoidsbv/followers","following_url":"https://api.github.com/users/humanoidsbv/following{/other_user}","gists_url":"https://api.github.com/users/humanoidsbv/gists{/gist_id}","starred_url":"https://api.github.com/users/humanoidsbv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/humanoidsbv/subscriptions","organizations_url":"https://api.github.com/users/humanoidsbv/orgs","repos_url":"https://api.github.com/users/humanoidsbv/repos","events_url":"https://api.github.com/users/humanoidsbv/events{/privacy}","received_events_url":"https://api.github.com/users/humanoidsbv/received_events","type":"Organization","site_admin":false},"repo":{"id":143646139,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM2NDYxMzk=","name":"team-awesome-sean","full_name":"humanoidsbv/team-awesome-sean","owner":{"login":"humanoidsbv","id":41685263,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxNjg1MjYz","avatar_url":"https://avatars0.githubusercontent.com/u/41685263?v=4","gravatar_id":"","url":"https://api.github.com/users/humanoidsbv","html_url":"https://github.com/humanoidsbv","followers_url":"https://api.github.com/users/humanoidsbv/followers","following_url":"https://api.github.com/users/humanoidsbv/following{/other_user}","gists_url":"https://api.github.com/users/humanoidsbv/gists{/gist_id}","starred_url":"https://api.github.com/users/humanoidsbv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/humanoidsbv/subscriptions","organizations_url":"https://api.github.com/users/humanoidsbv/orgs","repos_url":"https://api.github.com/users/humanoidsbv/repos","events_url":"https://api.github.com/users/humanoidsbv/events{/privacy}","received_events_url":"https://api.github.com/users/humanoidsbv/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/humanoidsbv/team-awesome-sean","description":null,"fork":false,"url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean","forks_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/forks","keys_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/teams","hooks_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/hooks","issue_events_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/issues/events{/number}","events_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/events","assignees_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/assignees{/user}","branches_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/branches{/branch}","tags_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/tags","blobs_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/git/refs{/sha}","trees_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/statuses/{sha}","languages_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/languages","stargazers_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/stargazers","contributors_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/contributors","subscribers_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/subscribers","subscription_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/subscription","commits_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/commits{/sha}","git_commits_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/git/commits{/sha}","comments_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/comments{/number}","issue_comment_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/issues/comments{/number}","contents_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/contents/{+path}","compare_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/merges","archive_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/downloads","issues_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/issues{/number}","pulls_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/pulls{/number}","milestones_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/milestones{/number}","notifications_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/labels{/name}","releases_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/releases{/id}","deployments_url":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/deployments","created_at":"2018-08-05T20:40:48Z","updated_at":"2018-08-28T08:20:14Z","pushed_at":"2018-08-28T14:34:19Z","git_url":"git://github.com/humanoidsbv/team-awesome-sean.git","ssh_url":"git@github.com:humanoidsbv/team-awesome-sean.git","clone_url":"https://github.com/humanoidsbv/team-awesome-sean.git","svn_url":"https://github.com/humanoidsbv/team-awesome-sean","homepage":null,"size":991,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/pulls/24"},"html":{"href":"https://github.com/humanoidsbv/team-awesome-sean/pull/24"},"issue":{"href":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/issues/24"},"comments":{"href":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/humanoidsbv/team-awesome-sean/statuses/e923c452769c80315f6875d7df4bb0a452f704e6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"seantijmons"}}