{"action":"closed","number":2437,"pull_request":{"url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/pulls/2437","id":211794372,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNzk0Mzcy","html_url":"https://github.com/Microsoft/WindowsCommunityToolkit/pull/2437","diff_url":"https://github.com/Microsoft/WindowsCommunityToolkit/pull/2437.diff","patch_url":"https://github.com/Microsoft/WindowsCommunityToolkit/pull/2437.patch","issue_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/issues/2437","number":2437,"state":"closed","locked":false,"title":"Xaml Island & wrapped controls merging in #2427 & #2435 for #2432","user":{"login":"GraniteStateHacker","id":6042338,"node_id":"MDQ6VXNlcjYwNDIzMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/6042338?v=4","gravatar_id":"","url":"https://api.github.com/users/GraniteStateHacker","html_url":"https://github.com/GraniteStateHacker","followers_url":"https://api.github.com/users/GraniteStateHacker/followers","following_url":"https://api.github.com/users/GraniteStateHacker/following{/other_user}","gists_url":"https://api.github.com/users/GraniteStateHacker/gists{/gist_id}","starred_url":"https://api.github.com/users/GraniteStateHacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GraniteStateHacker/subscriptions","organizations_url":"https://api.github.com/users/GraniteStateHacker/orgs","repos_url":"https://api.github.com/users/GraniteStateHacker/repos","events_url":"https://api.github.com/users/GraniteStateHacker/events{/privacy}","received_events_url":"https://api.github.com/users/GraniteStateHacker/received_events","type":"User","site_admin":false},"body":"Issue: #\r\n<!-- Link to relevant issue. All PRs should be asociated with an issue -->\r\n\r\n## PR Type\r\nWhat kind of change does this PR introduce?\r\nPulling in the latest from #2427 & #2435 so we can look at it & then squash the history as needed.\r\n\r\n<!-- - Bugfix -->\r\n<!-- - Feature -->\r\n<!-- - Code style update (formatting) -->\r\n<!-- - Refactoring (no functional changes, no api changes) -->\r\n<!-- - Build or CI related changes -->\r\n<!-- - Documentation content changes -->\r\n<!-- - Sample app changes -->\r\n<!-- - Other... Please describe: -->\r\n\r\n\r\n## What is the current behavior?\r\n<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->\r\n\r\n\r\n## What is the new behavior?\r\n\r\n\r\n## PR Checklist\r\n\r\nPlease check if your PR fulfills the following requirements:\r\n\r\n- [ ] Tested code with current [supported SDKs](../readme.md#supported)\r\n- [ ] Docs have been added/updated which fit [documentation template](https://github.com/Microsoft/UWPCommunityToolkit/blob/master/docs/.template.md). (for bug fixes / features)\r\n- [ ] Sample in sample app has been added / updated (for bug fixes / features)\r\n    - [ ] Icon has been created (if new sample) following the [Thumbnail Style Guide and templates](https://github.com/Microsoft/UWPCommunityToolkit-design-assets)\r\n- [ ] Tests for the changes have been added (for bug fixes / features) (if applicable)\r\n- [ ] Header has been added to all new source files (run *build/UpdateHeaders.bat*)\r\n- [ ] Contains **NO** breaking changes\r\n\r\n\r\n<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. \r\n     Please note that breaking changes are likely to be rejected -->\r\n\r\n\r\n## Other information\r\n","created_at":"2018-08-29T15:25:17Z","updated_at":"2018-09-13T16:43:16Z","closed_at":"2018-09-13T16:43:16Z","merged_at":null,"merge_commit_sha":"d8437af63c4eee24242b988d23b7f0f90f8b5b3b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"azchohfi","id":527713,"node_id":"MDQ6VXNlcjUyNzcxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/527713?v=4","gravatar_id":"","url":"https://api.github.com/users/azchohfi","html_url":"https://github.com/azchohfi","followers_url":"https://api.github.com/users/azchohfi/followers","following_url":"https://api.github.com/users/azchohfi/following{/other_user}","gists_url":"https://api.github.com/users/azchohfi/gists{/gist_id}","starred_url":"https://api.github.com/users/azchohfi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azchohfi/subscriptions","organizations_url":"https://api.github.com/users/azchohfi/orgs","repos_url":"https://api.github.com/users/azchohfi/repos","events_url":"https://api.github.com/users/azchohfi/events{/privacy}","received_events_url":"https://api.github.com/users/azchohfi/received_events","type":"User","site_admin":false},{"login":"nmetulev","id":711864,"node_id":"MDQ6VXNlcjcxMTg2NA==","avatar_url":"https://avatars1.githubusercontent.com/u/711864?v=4","gravatar_id":"","url":"https://api.github.com/users/nmetulev","html_url":"https://github.com/nmetulev","followers_url":"https://api.github.com/users/nmetulev/followers","following_url":"https://api.github.com/users/nmetulev/following{/other_user}","gists_url":"https://api.github.com/users/nmetulev/gists{/gist_id}","starred_url":"https://api.github.com/users/nmetulev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmetulev/subscriptions","organizations_url":"https://api.github.com/users/nmetulev/orgs","repos_url":"https://api.github.com/users/nmetulev/repos","events_url":"https://api.github.com/users/nmetulev/events{/privacy}","received_events_url":"https://api.github.com/users/nmetulev/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/pulls/2437/commits","review_comments_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/pulls/2437/comments","review_comment_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/issues/2437/comments","statuses_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/statuses/a1416b83ad35d6a4dc4e5606ca894de78052fa4d","head":{"label":"Microsoft:jimwilcox/xaml-islands-converged","ref":"jimwilcox/xaml-islands-converged","sha":"a1416b83ad35d6a4dc4e5606ca894de78052fa4d","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":61403402,"node_id":"MDEwOlJlcG9zaXRvcnk2MTQwMzQwMg==","name":"WindowsCommunityToolkit","full_name":"Microsoft/WindowsCommunityToolkit","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/WindowsCommunityToolkit","description":"The Windows Community Toolkit is a collection of helper functions, custom controls, and app services. It simplifies and demonstrates common developer tasks building UWP apps for Windows 10. The toolkit is part of the .NET Foundation.","fork":false,"url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit","forks_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/forks","keys_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/teams","hooks_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/events","assignees_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/tags","blobs_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/languages","stargazers_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/subscription","commits_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/merges","archive_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/downloads","issues_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/deployments","created_at":"2016-06-17T21:29:46Z","updated_at":"2018-09-13T15:17:51Z","pushed_at":"2018-09-13T16:37:04Z","git_url":"git://github.com/Microsoft/WindowsCommunityToolkit.git","ssh_url":"git@github.com:Microsoft/WindowsCommunityToolkit.git","clone_url":"https://github.com/Microsoft/WindowsCommunityToolkit.git","svn_url":"https://github.com/Microsoft/WindowsCommunityToolkit","homepage":"https://docs.microsoft.com/windows/uwpcommunitytoolkit/","size":415607,"stargazers_count":2618,"watchers_count":2618,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":722,"mirror_url":null,"archived":false,"open_issues_count":210,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":722,"open_issues":210,"watchers":2618,"default_branch":"master"}},"base":{"label":"Microsoft:jimwilcox/xaml-islands-reloaded","ref":"jimwilcox/xaml-islands-reloaded","sha":"8e2f834eb4ba3d0950d3d5021b1f6bbb858906a1","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":61403402,"node_id":"MDEwOlJlcG9zaXRvcnk2MTQwMzQwMg==","name":"WindowsCommunityToolkit","full_name":"Microsoft/WindowsCommunityToolkit","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/WindowsCommunityToolkit","description":"The Windows Community Toolkit is a collection of helper functions, custom controls, and app services. It simplifies and demonstrates common developer tasks building UWP apps for Windows 10. The toolkit is part of the .NET Foundation.","fork":false,"url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit","forks_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/forks","keys_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/teams","hooks_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/events","assignees_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/tags","blobs_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/languages","stargazers_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/subscription","commits_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/merges","archive_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/downloads","issues_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/deployments","created_at":"2016-06-17T21:29:46Z","updated_at":"2018-09-13T15:17:51Z","pushed_at":"2018-09-13T16:37:04Z","git_url":"git://github.com/Microsoft/WindowsCommunityToolkit.git","ssh_url":"git@github.com:Microsoft/WindowsCommunityToolkit.git","clone_url":"https://github.com/Microsoft/WindowsCommunityToolkit.git","svn_url":"https://github.com/Microsoft/WindowsCommunityToolkit","homepage":"https://docs.microsoft.com/windows/uwpcommunitytoolkit/","size":415607,"stargazers_count":2618,"watchers_count":2618,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":722,"mirror_url":null,"archived":false,"open_issues_count":210,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":722,"open_issues":210,"watchers":2618,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/pulls/2437"},"html":{"href":"https://github.com/Microsoft/WindowsCommunityToolkit/pull/2437"},"issue":{"href":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/issues/2437"},"comments":{"href":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/issues/2437/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/pulls/2437/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/pulls/2437/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/WindowsCommunityToolkit/statuses/a1416b83ad35d6a4dc4e5606ca894de78052fa4d"}},"author_association":"COLLABORATOR","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":221,"additions":183,"deletions":130,"changed_files":22}}
{"actor":{"display_login":"GraniteStateHacker"}}