{"action":"created","comment":{"url":"https://api.github.com/repos/iov-one/iov-core/pulls/comments/244153936","pull_request_review_id":188090492,"id":244153936,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDE1MzkzNg==","diff_hunk":"@@ -92,9 +92,23 @@ describe(\"Ed25519Wallet\", () => {\n     expect(newIdentity4.label).toEqual(lastIdentity.label);\n   });\n \n-  it(\"throws when adding the same keypair twice\", async () => {\n-    // Same keypair leads to the same identity identifier, so we don't support it\n+  it(\"can create different identities with the same keypair\", async () => {","path":"packages/iov-keycontrol/src/wallets/ed25519wallet.spec.ts","position":38,"original_position":6,"commit_id":"6ddfff1143237117a602157d53d77617bc483bc9","original_commit_id":"6ddfff1143237117a602157d53d77617bc483bc9","user":{"login":"ethanfrey","id":5689864,"node_id":"MDQ6VXNlcjU2ODk4NjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5689864?v=4","gravatar_id":"","url":"https://api.github.com/users/ethanfrey","html_url":"https://github.com/ethanfrey","followers_url":"https://api.github.com/users/ethanfrey/followers","following_url":"https://api.github.com/users/ethanfrey/following{/other_user}","gists_url":"https://api.github.com/users/ethanfrey/gists{/gist_id}","starred_url":"https://api.github.com/users/ethanfrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethanfrey/subscriptions","organizations_url":"https://api.github.com/users/ethanfrey/orgs","repos_url":"https://api.github.com/users/ethanfrey/repos","events_url":"https://api.github.com/users/ethanfrey/events{/privacy}","received_events_url":"https://api.github.com/users/ethanfrey/received_events","type":"User","site_admin":false},"body":"Good test, thought of the same thing when making that comment.\r\nThat every identity is tied to a chain, and we *encourage* using different keys for each chain, but nothing *prohibits* the reuse","created_at":"2018-12-27T13:35:25Z","updated_at":"2018-12-27T13:35:33Z","html_url":"https://github.com/iov-one/iov-core/pull/637#discussion_r244153936","pull_request_url":"https://api.github.com/repos/iov-one/iov-core/pulls/637","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/iov-one/iov-core/pulls/comments/244153936"},"html":{"href":"https://github.com/iov-one/iov-core/pull/637#discussion_r244153936"},"pull_request":{"href":"https://api.github.com/repos/iov-one/iov-core/pulls/637"}}},"pull_request":{"url":"https://api.github.com/repos/iov-one/iov-core/pulls/637","id":240438588,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNDM4NTg4","html_url":"https://github.com/iov-one/iov-core/pull/637","diff_url":"https://github.com/iov-one/iov-core/pull/637.diff","patch_url":"https://github.com/iov-one/iov-core/pull/637.patch","issue_url":"https://api.github.com/repos/iov-one/iov-core/issues/637","number":637,"state":"closed","locked":false,"title":"Add chain ID to public identity","user":{"login":"webmaster128","id":2603011,"node_id":"MDQ6VXNlcjI2MDMwMTE=","avatar_url":"https://avatars3.githubusercontent.com/u/2603011?v=4","gravatar_id":"","url":"https://api.github.com/users/webmaster128","html_url":"https://github.com/webmaster128","followers_url":"https://api.github.com/users/webmaster128/followers","following_url":"https://api.github.com/users/webmaster128/following{/other_user}","gists_url":"https://api.github.com/users/webmaster128/gists{/gist_id}","starred_url":"https://api.github.com/users/webmaster128/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webmaster128/subscriptions","organizations_url":"https://api.github.com/users/webmaster128/orgs","repos_url":"https://api.github.com/users/webmaster128/repos","events_url":"https://api.github.com/users/webmaster128/events{/privacy}","received_events_url":"https://api.github.com/users/webmaster128/received_events","type":"User","site_admin":false},"body":"Closes #621\r\n\r\n- [x] Add `chainId` parameter to `Wallet.createIdentity`\r\n- [x] Add `chainId` to `PublicIdentity`\r\n- [x] Remove redundant `chainId` parameter from `Wallet.createTransactionSignature`\r\n- [x] Convert `MultiChainSigner.keyToAddress` into `identityToAddress(identity: PublicIdentity): Address`\r\n- [x] Move `PublicIdentity` to bcp-types\r\n- [x] Convert `TxReadCodec.keyToAddress` into `identityToAddress(identity: PublicIdentity): Address`\r\n- [x] CHANGELOG","created_at":"2018-12-21T10:52:06Z","updated_at":"2018-12-27T13:35:33Z","closed_at":"2018-12-27T09:27:07Z","merged_at":"2018-12-27T09:27:07Z","merge_commit_sha":"72b4ac35b248a5cd8cfac4dd1d7f5fdb38c4c365","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/iov-one/iov-core/milestones/20","html_url":"https://github.com/iov-one/iov-core/milestone/20","labels_url":"https://api.github.com/repos/iov-one/iov-core/milestones/20/labels","id":3888572,"node_id":"MDk6TWlsZXN0b25lMzg4ODU3Mg==","number":20,"title":"0.11.0","description":null,"creator":{"login":"webmaster128","id":2603011,"node_id":"MDQ6VXNlcjI2MDMwMTE=","avatar_url":"https://avatars3.githubusercontent.com/u/2603011?v=4","gravatar_id":"","url":"https://api.github.com/users/webmaster128","html_url":"https://github.com/webmaster128","followers_url":"https://api.github.com/users/webmaster128/followers","following_url":"https://api.github.com/users/webmaster128/following{/other_user}","gists_url":"https://api.github.com/users/webmaster128/gists{/gist_id}","starred_url":"https://api.github.com/users/webmaster128/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webmaster128/subscriptions","organizations_url":"https://api.github.com/users/webmaster128/orgs","repos_url":"https://api.github.com/users/webmaster128/repos","events_url":"https://api.github.com/users/webmaster128/events{/privacy}","received_events_url":"https://api.github.com/users/webmaster128/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":9,"state":"open","created_at":"2018-12-11T06:35:22Z","updated_at":"2018-12-27T09:28:33Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/iov-one/iov-core/pulls/637/commits","review_comments_url":"https://api.github.com/repos/iov-one/iov-core/pulls/637/comments","review_comment_url":"https://api.github.com/repos/iov-one/iov-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iov-one/iov-core/issues/637/comments","statuses_url":"https://api.github.com/repos/iov-one/iov-core/statuses/6ddfff1143237117a602157d53d77617bc483bc9","head":{"label":"iov-one:chainId-to-public-identity","ref":"chainId-to-public-identity","sha":"6ddfff1143237117a602157d53d77617bc483bc9","user":{"login":"iov-one","id":34400253,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NDAwMjUz","avatar_url":"https://avatars2.githubusercontent.com/u/34400253?v=4","gravatar_id":"","url":"https://api.github.com/users/iov-one","html_url":"https://github.com/iov-one","followers_url":"https://api.github.com/users/iov-one/followers","following_url":"https://api.github.com/users/iov-one/following{/other_user}","gists_url":"https://api.github.com/users/iov-one/gists{/gist_id}","starred_url":"https://api.github.com/users/iov-one/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iov-one/subscriptions","organizations_url":"https://api.github.com/users/iov-one/orgs","repos_url":"https://api.github.com/users/iov-one/repos","events_url":"https://api.github.com/users/iov-one/events{/privacy}","received_events_url":"https://api.github.com/users/iov-one/received_events","type":"Organization","site_admin":false},"repo":{"id":129950372,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk5NTAzNzI=","name":"iov-core","full_name":"iov-one/iov-core","private":false,"owner":{"login":"iov-one","id":34400253,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NDAwMjUz","avatar_url":"https://avatars2.githubusercontent.com/u/34400253?v=4","gravatar_id":"","url":"https://api.github.com/users/iov-one","html_url":"https://github.com/iov-one","followers_url":"https://api.github.com/users/iov-one/followers","following_url":"https://api.github.com/users/iov-one/following{/other_user}","gists_url":"https://api.github.com/users/iov-one/gists{/gist_id}","starred_url":"https://api.github.com/users/iov-one/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iov-one/subscriptions","organizations_url":"https://api.github.com/users/iov-one/orgs","repos_url":"https://api.github.com/users/iov-one/repos","events_url":"https://api.github.com/users/iov-one/events{/privacy}","received_events_url":"https://api.github.com/users/iov-one/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/iov-one/iov-core","description":"Client library for secure key management and multi-blockchain communication","fork":false,"url":"https://api.github.com/repos/iov-one/iov-core","forks_url":"https://api.github.com/repos/iov-one/iov-core/forks","keys_url":"https://api.github.com/repos/iov-one/iov-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iov-one/iov-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iov-one/iov-core/teams","hooks_url":"https://api.github.com/repos/iov-one/iov-core/hooks","issue_events_url":"https://api.github.com/repos/iov-one/iov-core/issues/events{/number}","events_url":"https://api.github.com/repos/iov-one/iov-core/events","assignees_url":"https://api.github.com/repos/iov-one/iov-core/assignees{/user}","branches_url":"https://api.github.com/repos/iov-one/iov-core/branches{/branch}","tags_url":"https://api.github.com/repos/iov-one/iov-core/tags","blobs_url":"https://api.github.com/repos/iov-one/iov-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iov-one/iov-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iov-one/iov-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/iov-one/iov-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iov-one/iov-core/statuses/{sha}","languages_url":"https://api.github.com/repos/iov-one/iov-core/languages","stargazers_url":"https://api.github.com/repos/iov-one/iov-core/stargazers","contributors_url":"https://api.github.com/repos/iov-one/iov-core/contributors","subscribers_url":"https://api.github.com/repos/iov-one/iov-core/subscribers","subscription_url":"https://api.github.com/repos/iov-one/iov-core/subscription","commits_url":"https://api.github.com/repos/iov-one/iov-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/iov-one/iov-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/iov-one/iov-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/iov-one/iov-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/iov-one/iov-core/contents/{+path}","compare_url":"https://api.github.com/repos/iov-one/iov-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iov-one/iov-core/merges","archive_url":"https://api.github.com/repos/iov-one/iov-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iov-one/iov-core/downloads","issues_url":"https://api.github.com/repos/iov-one/iov-core/issues{/number}","pulls_url":"https://api.github.com/repos/iov-one/iov-core/pulls{/number}","milestones_url":"https://api.github.com/repos/iov-one/iov-core/milestones{/number}","notifications_url":"https://api.github.com/repos/iov-one/iov-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iov-one/iov-core/labels{/name}","releases_url":"https://api.github.com/repos/iov-one/iov-core/releases{/id}","deployments_url":"https://api.github.com/repos/iov-one/iov-core/deployments","created_at":"2018-04-17T18:46:16Z","updated_at":"2018-12-27T09:27:11Z","pushed_at":"2018-12-27T09:27:10Z","git_url":"git://github.com/iov-one/iov-core.git","ssh_url":"git@github.com:iov-one/iov-core.git","clone_url":"https://github.com/iov-one/iov-core.git","svn_url":"https://github.com/iov-one/iov-core","homepage":"https://iov-one.github.io/iov-core-docs/","size":4976,"stargazers_count":175,"watchers_count":175,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":8,"open_issues":48,"watchers":175,"default_branch":"master"}},"base":{"label":"iov-one:master","ref":"master","sha":"d57b6f37e59b8a5bcbc402e1bdfdcff8309824b5","user":{"login":"iov-one","id":34400253,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NDAwMjUz","avatar_url":"https://avatars2.githubusercontent.com/u/34400253?v=4","gravatar_id":"","url":"https://api.github.com/users/iov-one","html_url":"https://github.com/iov-one","followers_url":"https://api.github.com/users/iov-one/followers","following_url":"https://api.github.com/users/iov-one/following{/other_user}","gists_url":"https://api.github.com/users/iov-one/gists{/gist_id}","starred_url":"https://api.github.com/users/iov-one/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iov-one/subscriptions","organizations_url":"https://api.github.com/users/iov-one/orgs","repos_url":"https://api.github.com/users/iov-one/repos","events_url":"https://api.github.com/users/iov-one/events{/privacy}","received_events_url":"https://api.github.com/users/iov-one/received_events","type":"Organization","site_admin":false},"repo":{"id":129950372,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk5NTAzNzI=","name":"iov-core","full_name":"iov-one/iov-core","private":false,"owner":{"login":"iov-one","id":34400253,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NDAwMjUz","avatar_url":"https://avatars2.githubusercontent.com/u/34400253?v=4","gravatar_id":"","url":"https://api.github.com/users/iov-one","html_url":"https://github.com/iov-one","followers_url":"https://api.github.com/users/iov-one/followers","following_url":"https://api.github.com/users/iov-one/following{/other_user}","gists_url":"https://api.github.com/users/iov-one/gists{/gist_id}","starred_url":"https://api.github.com/users/iov-one/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iov-one/subscriptions","organizations_url":"https://api.github.com/users/iov-one/orgs","repos_url":"https://api.github.com/users/iov-one/repos","events_url":"https://api.github.com/users/iov-one/events{/privacy}","received_events_url":"https://api.github.com/users/iov-one/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/iov-one/iov-core","description":"Client library for secure key management and multi-blockchain communication","fork":false,"url":"https://api.github.com/repos/iov-one/iov-core","forks_url":"https://api.github.com/repos/iov-one/iov-core/forks","keys_url":"https://api.github.com/repos/iov-one/iov-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iov-one/iov-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iov-one/iov-core/teams","hooks_url":"https://api.github.com/repos/iov-one/iov-core/hooks","issue_events_url":"https://api.github.com/repos/iov-one/iov-core/issues/events{/number}","events_url":"https://api.github.com/repos/iov-one/iov-core/events","assignees_url":"https://api.github.com/repos/iov-one/iov-core/assignees{/user}","branches_url":"https://api.github.com/repos/iov-one/iov-core/branches{/branch}","tags_url":"https://api.github.com/repos/iov-one/iov-core/tags","blobs_url":"https://api.github.com/repos/iov-one/iov-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iov-one/iov-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iov-one/iov-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/iov-one/iov-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iov-one/iov-core/statuses/{sha}","languages_url":"https://api.github.com/repos/iov-one/iov-core/languages","stargazers_url":"https://api.github.com/repos/iov-one/iov-core/stargazers","contributors_url":"https://api.github.com/repos/iov-one/iov-core/contributors","subscribers_url":"https://api.github.com/repos/iov-one/iov-core/subscribers","subscription_url":"https://api.github.com/repos/iov-one/iov-core/subscription","commits_url":"https://api.github.com/repos/iov-one/iov-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/iov-one/iov-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/iov-one/iov-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/iov-one/iov-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/iov-one/iov-core/contents/{+path}","compare_url":"https://api.github.com/repos/iov-one/iov-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iov-one/iov-core/merges","archive_url":"https://api.github.com/repos/iov-one/iov-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iov-one/iov-core/downloads","issues_url":"https://api.github.com/repos/iov-one/iov-core/issues{/number}","pulls_url":"https://api.github.com/repos/iov-one/iov-core/pulls{/number}","milestones_url":"https://api.github.com/repos/iov-one/iov-core/milestones{/number}","notifications_url":"https://api.github.com/repos/iov-one/iov-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iov-one/iov-core/labels{/name}","releases_url":"https://api.github.com/repos/iov-one/iov-core/releases{/id}","deployments_url":"https://api.github.com/repos/iov-one/iov-core/deployments","created_at":"2018-04-17T18:46:16Z","updated_at":"2018-12-27T09:27:11Z","pushed_at":"2018-12-27T09:27:10Z","git_url":"git://github.com/iov-one/iov-core.git","ssh_url":"git@github.com:iov-one/iov-core.git","clone_url":"https://github.com/iov-one/iov-core.git","svn_url":"https://github.com/iov-one/iov-core","homepage":"https://iov-one.github.io/iov-core-docs/","size":4976,"stargazers_count":175,"watchers_count":175,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":8,"open_issues":48,"watchers":175,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iov-one/iov-core/pulls/637"},"html":{"href":"https://github.com/iov-one/iov-core/pull/637"},"issue":{"href":"https://api.github.com/repos/iov-one/iov-core/issues/637"},"comments":{"href":"https://api.github.com/repos/iov-one/iov-core/issues/637/comments"},"review_comments":{"href":"https://api.github.com/repos/iov-one/iov-core/pulls/637/comments"},"review_comment":{"href":"https://api.github.com/repos/iov-one/iov-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iov-one/iov-core/pulls/637/commits"},"statuses":{"href":"https://api.github.com/repos/iov-one/iov-core/statuses/6ddfff1143237117a602157d53d77617bc483bc9"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"ethanfrey"}}