{"action":"created","comment":{"url":"https://api.github.com/repos/openid/AppAuth-iOS/pulls/comments/218550070","pull_request_review_id":156514038,"id":218550070,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODU1MDA3MA==","diff_hunk":"@@ -2036,7 +2036,7 @@\n \t\t\t\tGCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;\n \t\t\t\tGCC_WARN_UNUSED_FUNCTION = YES;\n \t\t\t\tGCC_WARN_UNUSED_VARIABLE = YES;\n-\t\t\t\tIPHONEOS_DEPLOYMENT_TARGET = 7.0;\n+\t\t\t\tIPHONEOS_DEPLOYMENT_TARGET = 8.0;","path":"AppAuth.xcodeproj/project.pbxproj","position":null,"original_position":23,"commit_id":"16f5d000e7d78ec896a2de5767c0838e883a4760","original_commit_id":"53609d1aa6d42d27b6ec4024dbbdbce823565ac1","user":{"login":"edelabar","id":97080,"node_id":"MDQ6VXNlcjk3MDgw","avatar_url":"https://avatars1.githubusercontent.com/u/97080?v=4","gravatar_id":"","url":"https://api.github.com/users/edelabar","html_url":"https://github.com/edelabar","followers_url":"https://api.github.com/users/edelabar/followers","following_url":"https://api.github.com/users/edelabar/following{/other_user}","gists_url":"https://api.github.com/users/edelabar/gists{/gist_id}","starred_url":"https://api.github.com/users/edelabar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edelabar/subscriptions","organizations_url":"https://api.github.com/users/edelabar/orgs","repos_url":"https://api.github.com/users/edelabar/repos","events_url":"https://api.github.com/users/edelabar/events{/privacy}","received_events_url":"https://api.github.com/users/edelabar/received_events","type":"User","site_admin":false},"body":"No reason, the wizard did it. The Xcode 10 ui only has down to 8.0 in the dropdown but you can type-in whatever version you want. I reverted it to 7.0.","created_at":"2018-09-18T18:44:01Z","updated_at":"2018-09-18T18:44:01Z","html_url":"https://github.com/openid/AppAuth-iOS/pull/294#discussion_r218550070","pull_request_url":"https://api.github.com/repos/openid/AppAuth-iOS/pulls/294","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/openid/AppAuth-iOS/pulls/comments/218550070"},"html":{"href":"https://github.com/openid/AppAuth-iOS/pull/294#discussion_r218550070"},"pull_request":{"href":"https://api.github.com/repos/openid/AppAuth-iOS/pulls/294"}},"in_reply_to_id":218546294},"pull_request":{"url":"https://api.github.com/repos/openid/AppAuth-iOS/pulls/294","id":216345176,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2MzQ1MTc2","html_url":"https://github.com/openid/AppAuth-iOS/pull/294","diff_url":"https://github.com/openid/AppAuth-iOS/pull/294.diff","patch_url":"https://github.com/openid/AppAuth-iOS/pull/294.patch","issue_url":"https://api.github.com/repos/openid/AppAuth-iOS/issues/294","number":294,"state":"open","locked":false,"title":"Run xcode 10 migration wizard","user":{"login":"edelabar","id":97080,"node_id":"MDQ6VXNlcjk3MDgw","avatar_url":"https://avatars1.githubusercontent.com/u/97080?v=4","gravatar_id":"","url":"https://api.github.com/users/edelabar","html_url":"https://github.com/edelabar","followers_url":"https://api.github.com/users/edelabar/followers","following_url":"https://api.github.com/users/edelabar/following{/other_user}","gists_url":"https://api.github.com/users/edelabar/gists{/gist_id}","starred_url":"https://api.github.com/users/edelabar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edelabar/subscriptions","organizations_url":"https://api.github.com/users/edelabar/orgs","repos_url":"https://api.github.com/users/edelabar/repos","events_url":"https://api.github.com/users/edelabar/events{/privacy}","received_events_url":"https://api.github.com/users/edelabar/received_events","type":"User","site_admin":false},"body":"Ran the Xcode 10 migration wizard, no code changes.\r\n\r\nWe use this project as a submodule off a tag, it would be greatly appreciated if you could merge this a create a new tag from it so we can kill the Xcode warnings. Thanks!","created_at":"2018-09-18T15:12:55Z","updated_at":"2018-09-18T18:44:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a6141ac8b154187d56cbbf414f3398dac9c60505","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openid/AppAuth-iOS/pulls/294/commits","review_comments_url":"https://api.github.com/repos/openid/AppAuth-iOS/pulls/294/comments","review_comment_url":"https://api.github.com/repos/openid/AppAuth-iOS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openid/AppAuth-iOS/issues/294/comments","statuses_url":"https://api.github.com/repos/openid/AppAuth-iOS/statuses/16f5d000e7d78ec896a2de5767c0838e883a4760","head":{"label":"CareEvolution:xcode10","ref":"xcode10","sha":"16f5d000e7d78ec896a2de5767c0838e883a4760","user":{"login":"CareEvolution","id":1383436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODM0MzY=","avatar_url":"https://avatars2.githubusercontent.com/u/1383436?v=4","gravatar_id":"","url":"https://api.github.com/users/CareEvolution","html_url":"https://github.com/CareEvolution","followers_url":"https://api.github.com/users/CareEvolution/followers","following_url":"https://api.github.com/users/CareEvolution/following{/other_user}","gists_url":"https://api.github.com/users/CareEvolution/gists{/gist_id}","starred_url":"https://api.github.com/users/CareEvolution/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CareEvolution/subscriptions","organizations_url":"https://api.github.com/users/CareEvolution/orgs","repos_url":"https://api.github.com/users/CareEvolution/repos","events_url":"https://api.github.com/users/CareEvolution/events{/privacy}","received_events_url":"https://api.github.com/users/CareEvolution/received_events","type":"Organization","site_admin":false},"repo":{"id":86068053,"node_id":"MDEwOlJlcG9zaXRvcnk4NjA2ODA1Mw==","name":"AppAuth-iOS","full_name":"CareEvolution/AppAuth-iOS","private":false,"owner":{"login":"CareEvolution","id":1383436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODM0MzY=","avatar_url":"https://avatars2.githubusercontent.com/u/1383436?v=4","gravatar_id":"","url":"https://api.github.com/users/CareEvolution","html_url":"https://github.com/CareEvolution","followers_url":"https://api.github.com/users/CareEvolution/followers","following_url":"https://api.github.com/users/CareEvolution/following{/other_user}","gists_url":"https://api.github.com/users/CareEvolution/gists{/gist_id}","starred_url":"https://api.github.com/users/CareEvolution/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CareEvolution/subscriptions","organizations_url":"https://api.github.com/users/CareEvolution/orgs","repos_url":"https://api.github.com/users/CareEvolution/repos","events_url":"https://api.github.com/users/CareEvolution/events{/privacy}","received_events_url":"https://api.github.com/users/CareEvolution/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CareEvolution/AppAuth-iOS","description":"AppAuth is an OAuth and OpenID Connect client for iOS and macOS.","fork":true,"url":"https://api.github.com/repos/CareEvolution/AppAuth-iOS","forks_url":"https://api.github.com/repos/CareEvolution/AppAuth-iOS/forks","keys_url":"https://api.github.com/repos/CareEvolution/AppAuth-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CareEvolution/AppAuth-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CareEvolution/AppAuth-iOS/teams","hooks_url":"https://api.github.com/repos/CareEvolution/AppAuth-iOS/hooks","issue_events_url":"https://api.github.com/repos/CareEvolution/AppAuth-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/CareEvolution/AppAuth-iOS/events","assignees_url":"https://api.github.com/repos/CareEvolution/AppAuth-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/CareEvolution/AppAuth-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/CareEvolution/AppAuth-iOS/tags","blobs_url":"https://api.github.com/repos/CareEvolution/AppAuth-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CareEvolution/AppAuth-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CareEvolution/AppAuth-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/CareEvolution/AppAuth-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CareEvolution/AppAuth-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/CareEvolution/AppAuth-iOS/languages","stargazers_url":"https://api.github.com/repos/CareEvolution/AppAuth-iOS/stargazers","contributors_url":"https://api.github.com/repos/CareEvolution/AppAuth-iOS/contributors","subscribers_url":"https://api.github.com/repos/CareEvolution/AppAuth-iOS/subscribers","subscription_url":"https://api.github.com/repos/CareEvolution/AppAuth-iOS/subscription","commits_url":"https://api.github.com/repos/CareEvolution/AppAuth-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/CareEvolution/AppAuth-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/CareEvolution/AppAuth-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/CareEvolution/AppAuth-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/CareEvolution/AppAuth-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/CareEvolution/AppAuth-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CareEvolution/AppAuth-iOS/merges","archive_url":"https://api.github.com/repos/CareEvolution/AppAuth-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CareEvolution/AppAuth-iOS/downloads","issues_url":"https://api.github.com/repos/CareEvolution/AppAuth-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/CareEvolution/AppAuth-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/CareEvolution/AppAuth-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/CareEvolution/AppAuth-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CareEvolution/AppAuth-iOS/labels{/name}","releases_url":"https://api.github.com/repos/CareEvolution/AppAuth-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/CareEvolution/AppAuth-iOS/deployments","created_at":"2017-03-24T12:56:43Z","updated_at":"2017-03-24T12:56:45Z","pushed_at":"2018-09-18T18:42:55Z","git_url":"git://github.com/CareEvolution/AppAuth-iOS.git","ssh_url":"git@github.com:CareEvolution/AppAuth-iOS.git","clone_url":"https://github.com/CareEvolution/AppAuth-iOS.git","svn_url":"https://github.com/CareEvolution/AppAuth-iOS","homepage":"https://openid.github.io/AppAuth-iOS","size":1449,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openid:master","ref":"master","sha":"b4ca39a38f0d991bd17c56ebd01756a41da54061","user":{"login":"openid","id":71971,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcxOTcx","avatar_url":"https://avatars2.githubusercontent.com/u/71971?v=4","gravatar_id":"","url":"https://api.github.com/users/openid","html_url":"https://github.com/openid","followers_url":"https://api.github.com/users/openid/followers","following_url":"https://api.github.com/users/openid/following{/other_user}","gists_url":"https://api.github.com/users/openid/gists{/gist_id}","starred_url":"https://api.github.com/users/openid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openid/subscriptions","organizations_url":"https://api.github.com/users/openid/orgs","repos_url":"https://api.github.com/users/openid/repos","events_url":"https://api.github.com/users/openid/events{/privacy}","received_events_url":"https://api.github.com/users/openid/received_events","type":"Organization","site_admin":false},"repo":{"id":51520488,"node_id":"MDEwOlJlcG9zaXRvcnk1MTUyMDQ4OA==","name":"AppAuth-iOS","full_name":"openid/AppAuth-iOS","private":false,"owner":{"login":"openid","id":71971,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcxOTcx","avatar_url":"https://avatars2.githubusercontent.com/u/71971?v=4","gravatar_id":"","url":"https://api.github.com/users/openid","html_url":"https://github.com/openid","followers_url":"https://api.github.com/users/openid/followers","following_url":"https://api.github.com/users/openid/following{/other_user}","gists_url":"https://api.github.com/users/openid/gists{/gist_id}","starred_url":"https://api.github.com/users/openid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openid/subscriptions","organizations_url":"https://api.github.com/users/openid/orgs","repos_url":"https://api.github.com/users/openid/repos","events_url":"https://api.github.com/users/openid/events{/privacy}","received_events_url":"https://api.github.com/users/openid/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openid/AppAuth-iOS","description":"iOS and macOS SDK for communicating with OAuth 2.0 and OpenID Connect providers.","fork":false,"url":"https://api.github.com/repos/openid/AppAuth-iOS","forks_url":"https://api.github.com/repos/openid/AppAuth-iOS/forks","keys_url":"https://api.github.com/repos/openid/AppAuth-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openid/AppAuth-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openid/AppAuth-iOS/teams","hooks_url":"https://api.github.com/repos/openid/AppAuth-iOS/hooks","issue_events_url":"https://api.github.com/repos/openid/AppAuth-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/openid/AppAuth-iOS/events","assignees_url":"https://api.github.com/repos/openid/AppAuth-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/openid/AppAuth-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/openid/AppAuth-iOS/tags","blobs_url":"https://api.github.com/repos/openid/AppAuth-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openid/AppAuth-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openid/AppAuth-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/openid/AppAuth-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openid/AppAuth-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/openid/AppAuth-iOS/languages","stargazers_url":"https://api.github.com/repos/openid/AppAuth-iOS/stargazers","contributors_url":"https://api.github.com/repos/openid/AppAuth-iOS/contributors","subscribers_url":"https://api.github.com/repos/openid/AppAuth-iOS/subscribers","subscription_url":"https://api.github.com/repos/openid/AppAuth-iOS/subscription","commits_url":"https://api.github.com/repos/openid/AppAuth-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/openid/AppAuth-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/openid/AppAuth-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/openid/AppAuth-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/openid/AppAuth-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/openid/AppAuth-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openid/AppAuth-iOS/merges","archive_url":"https://api.github.com/repos/openid/AppAuth-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openid/AppAuth-iOS/downloads","issues_url":"https://api.github.com/repos/openid/AppAuth-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/openid/AppAuth-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/openid/AppAuth-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/openid/AppAuth-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openid/AppAuth-iOS/labels{/name}","releases_url":"https://api.github.com/repos/openid/AppAuth-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/openid/AppAuth-iOS/deployments","created_at":"2016-02-11T14:38:23Z","updated_at":"2018-09-18T10:48:25Z","pushed_at":"2018-09-18T18:42:57Z","git_url":"git://github.com/openid/AppAuth-iOS.git","ssh_url":"git@github.com:openid/AppAuth-iOS.git","clone_url":"https://github.com/openid/AppAuth-iOS.git","svn_url":"https://github.com/openid/AppAuth-iOS","homepage":"https://openid.github.io/AppAuth-iOS","size":1555,"stargazers_count":452,"watchers_count":452,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":197,"mirror_url":null,"archived":false,"open_issues_count":39,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":197,"open_issues":39,"watchers":452,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openid/AppAuth-iOS/pulls/294"},"html":{"href":"https://github.com/openid/AppAuth-iOS/pull/294"},"issue":{"href":"https://api.github.com/repos/openid/AppAuth-iOS/issues/294"},"comments":{"href":"https://api.github.com/repos/openid/AppAuth-iOS/issues/294/comments"},"review_comments":{"href":"https://api.github.com/repos/openid/AppAuth-iOS/pulls/294/comments"},"review_comment":{"href":"https://api.github.com/repos/openid/AppAuth-iOS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openid/AppAuth-iOS/pulls/294/commits"},"statuses":{"href":"https://api.github.com/repos/openid/AppAuth-iOS/statuses/16f5d000e7d78ec896a2de5767c0838e883a4760"}},"author_association":"NONE"}}
{"actor":{"display_login":"edelabar"}}