{"action":"created","comment":{"url":"https://api.github.com/repos/square/retrofit/pulls/comments/219903834","pull_request_review_id":158189984,"id":219903834,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTkwMzgzNA==","diff_hunk":"@@ -61,4 +66,31 @@\n     Object body = service.object().execute().body();\n     assertThat(body).isNull();\n   }\n+\n+  @Test public void delegates() throws IOException {\n+    Retrofit retrofit = new Retrofit.Builder()\n+        .baseUrl(server.url(\"/\"))\n+        .addConverterFactory(new Converter.Factory() {\n+          @Nullable @Override public Converter<ResponseBody, ?> responseBodyConverter(Type type,\n+              Annotation[] annotations, Retrofit retrofit) {\n+            if (getRawType(type) == Optional.class) {","path":"retrofit-converters/guava/src/test/java/retrofit/converter/guava/GuavaOptionalConverterFactoryTest.java","position":29,"original_position":29,"commit_id":"277b1874df25f0249878d8c8f6e55373017ff8f5","original_commit_id":"277b1874df25f0249878d8c8f6e55373017ff8f5","user":{"login":"NightlyNexus","id":4032667,"node_id":"MDQ6VXNlcjQwMzI2Njc=","avatar_url":"https://avatars2.githubusercontent.com/u/4032667?v=4","gravatar_id":"","url":"https://api.github.com/users/NightlyNexus","html_url":"https://github.com/NightlyNexus","followers_url":"https://api.github.com/users/NightlyNexus/followers","following_url":"https://api.github.com/users/NightlyNexus/following{/other_user}","gists_url":"https://api.github.com/users/NightlyNexus/gists{/gist_id}","starred_url":"https://api.github.com/users/NightlyNexus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NightlyNexus/subscriptions","organizations_url":"https://api.github.com/users/NightlyNexus/orgs","repos_url":"https://api.github.com/users/NightlyNexus/repos","events_url":"https://api.github.com/users/NightlyNexus/events{/privacy}","received_events_url":"https://api.github.com/users/NightlyNexus/received_events","type":"User","site_admin":false},"body":"Yeah. I'll change to select for Object.class.","created_at":"2018-09-24T16:33:44Z","updated_at":"2018-09-24T16:33:44Z","html_url":"https://github.com/square/retrofit/pull/2904#discussion_r219903834","pull_request_url":"https://api.github.com/repos/square/retrofit/pulls/2904","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/square/retrofit/pulls/comments/219903834"},"html":{"href":"https://github.com/square/retrofit/pull/2904#discussion_r219903834"},"pull_request":{"href":"https://api.github.com/repos/square/retrofit/pulls/2904"}},"in_reply_to_id":219850023},"pull_request":{"url":"https://api.github.com/repos/square/retrofit/pulls/2904","id":217549216,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NTQ5MjE2","html_url":"https://github.com/square/retrofit/pull/2904","diff_url":"https://github.com/square/retrofit/pull/2904.diff","patch_url":"https://github.com/square/retrofit/pull/2904.patch","issue_url":"https://api.github.com/repos/square/retrofit/issues/2904","number":2904,"state":"open","locked":false,"title":"Fix Optional converter factories not delegating properly.","user":{"login":"NightlyNexus","id":4032667,"node_id":"MDQ6VXNlcjQwMzI2Njc=","avatar_url":"https://avatars2.githubusercontent.com/u/4032667?v=4","gravatar_id":"","url":"https://api.github.com/users/NightlyNexus","html_url":"https://github.com/NightlyNexus","followers_url":"https://api.github.com/users/NightlyNexus/followers","following_url":"https://api.github.com/users/NightlyNexus/following{/other_user}","gists_url":"https://api.github.com/users/NightlyNexus/gists{/gist_id}","starred_url":"https://api.github.com/users/NightlyNexus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NightlyNexus/subscriptions","organizations_url":"https://api.github.com/users/NightlyNexus/orgs","repos_url":"https://api.github.com/users/NightlyNexus/repos","events_url":"https://api.github.com/users/NightlyNexus/events{/privacy}","received_events_url":"https://api.github.com/users/NightlyNexus/received_events","type":"User","site_admin":false},"body":"before, these test would fail with\r\n\r\n```\r\njava.lang.IllegalArgumentException: Unable to create converter for com.google.common.base.Optional<java.lang.Object>\r\n    for method Service.optional\r\n\r\nCaused by: java.lang.IllegalArgumentException: Could not locate ResponseBody converter for class java.lang.Object.\r\n  Skipped:\r\n   * retrofit2.BuiltInConverters\r\n   * retrofit.converter.guava.GuavaOptionalConverterFactoryTest$1\r\n   * retrofit.converter.guava.GuavaOptionalConverterFactory\r\n  Tried:\r\n   * retrofit2.OptionalConverterFactory\r\n```","created_at":"2018-09-24T03:09:30Z","updated_at":"2018-09-24T16:33:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6407e167baf13bc44406a3af2fca28105dff165c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/square/retrofit/pulls/2904/commits","review_comments_url":"https://api.github.com/repos/square/retrofit/pulls/2904/comments","review_comment_url":"https://api.github.com/repos/square/retrofit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/square/retrofit/issues/2904/comments","statuses_url":"https://api.github.com/repos/square/retrofit/statuses/277b1874df25f0249878d8c8f6e55373017ff8f5","head":{"label":"NightlyNexus:eric.2018-09-23.delegating-optional","ref":"eric.2018-09-23.delegating-optional","sha":"277b1874df25f0249878d8c8f6e55373017ff8f5","user":{"login":"NightlyNexus","id":4032667,"node_id":"MDQ6VXNlcjQwMzI2Njc=","avatar_url":"https://avatars2.githubusercontent.com/u/4032667?v=4","gravatar_id":"","url":"https://api.github.com/users/NightlyNexus","html_url":"https://github.com/NightlyNexus","followers_url":"https://api.github.com/users/NightlyNexus/followers","following_url":"https://api.github.com/users/NightlyNexus/following{/other_user}","gists_url":"https://api.github.com/users/NightlyNexus/gists{/gist_id}","starred_url":"https://api.github.com/users/NightlyNexus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NightlyNexus/subscriptions","organizations_url":"https://api.github.com/users/NightlyNexus/orgs","repos_url":"https://api.github.com/users/NightlyNexus/repos","events_url":"https://api.github.com/users/NightlyNexus/events{/privacy}","received_events_url":"https://api.github.com/users/NightlyNexus/received_events","type":"User","site_admin":false},"repo":{"id":35349496,"node_id":"MDEwOlJlcG9zaXRvcnkzNTM0OTQ5Ng==","name":"retrofit","full_name":"NightlyNexus/retrofit","private":false,"owner":{"login":"NightlyNexus","id":4032667,"node_id":"MDQ6VXNlcjQwMzI2Njc=","avatar_url":"https://avatars2.githubusercontent.com/u/4032667?v=4","gravatar_id":"","url":"https://api.github.com/users/NightlyNexus","html_url":"https://github.com/NightlyNexus","followers_url":"https://api.github.com/users/NightlyNexus/followers","following_url":"https://api.github.com/users/NightlyNexus/following{/other_user}","gists_url":"https://api.github.com/users/NightlyNexus/gists{/gist_id}","starred_url":"https://api.github.com/users/NightlyNexus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NightlyNexus/subscriptions","organizations_url":"https://api.github.com/users/NightlyNexus/orgs","repos_url":"https://api.github.com/users/NightlyNexus/repos","events_url":"https://api.github.com/users/NightlyNexus/events{/privacy}","received_events_url":"https://api.github.com/users/NightlyNexus/received_events","type":"User","site_admin":false},"html_url":"https://github.com/NightlyNexus/retrofit","description":"Type-safe REST client for Android and Java by Square, Inc.","fork":true,"url":"https://api.github.com/repos/NightlyNexus/retrofit","forks_url":"https://api.github.com/repos/NightlyNexus/retrofit/forks","keys_url":"https://api.github.com/repos/NightlyNexus/retrofit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NightlyNexus/retrofit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NightlyNexus/retrofit/teams","hooks_url":"https://api.github.com/repos/NightlyNexus/retrofit/hooks","issue_events_url":"https://api.github.com/repos/NightlyNexus/retrofit/issues/events{/number}","events_url":"https://api.github.com/repos/NightlyNexus/retrofit/events","assignees_url":"https://api.github.com/repos/NightlyNexus/retrofit/assignees{/user}","branches_url":"https://api.github.com/repos/NightlyNexus/retrofit/branches{/branch}","tags_url":"https://api.github.com/repos/NightlyNexus/retrofit/tags","blobs_url":"https://api.github.com/repos/NightlyNexus/retrofit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NightlyNexus/retrofit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NightlyNexus/retrofit/git/refs{/sha}","trees_url":"https://api.github.com/repos/NightlyNexus/retrofit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NightlyNexus/retrofit/statuses/{sha}","languages_url":"https://api.github.com/repos/NightlyNexus/retrofit/languages","stargazers_url":"https://api.github.com/repos/NightlyNexus/retrofit/stargazers","contributors_url":"https://api.github.com/repos/NightlyNexus/retrofit/contributors","subscribers_url":"https://api.github.com/repos/NightlyNexus/retrofit/subscribers","subscription_url":"https://api.github.com/repos/NightlyNexus/retrofit/subscription","commits_url":"https://api.github.com/repos/NightlyNexus/retrofit/commits{/sha}","git_commits_url":"https://api.github.com/repos/NightlyNexus/retrofit/git/commits{/sha}","comments_url":"https://api.github.com/repos/NightlyNexus/retrofit/comments{/number}","issue_comment_url":"https://api.github.com/repos/NightlyNexus/retrofit/issues/comments{/number}","contents_url":"https://api.github.com/repos/NightlyNexus/retrofit/contents/{+path}","compare_url":"https://api.github.com/repos/NightlyNexus/retrofit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NightlyNexus/retrofit/merges","archive_url":"https://api.github.com/repos/NightlyNexus/retrofit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NightlyNexus/retrofit/downloads","issues_url":"https://api.github.com/repos/NightlyNexus/retrofit/issues{/number}","pulls_url":"https://api.github.com/repos/NightlyNexus/retrofit/pulls{/number}","milestones_url":"https://api.github.com/repos/NightlyNexus/retrofit/milestones{/number}","notifications_url":"https://api.github.com/repos/NightlyNexus/retrofit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NightlyNexus/retrofit/labels{/name}","releases_url":"https://api.github.com/repos/NightlyNexus/retrofit/releases{/id}","deployments_url":"https://api.github.com/repos/NightlyNexus/retrofit/deployments","created_at":"2015-05-09T23:34:26Z","updated_at":"2016-04-09T21:30:36Z","pushed_at":"2018-09-24T16:29:50Z","git_url":"git://github.com/NightlyNexus/retrofit.git","ssh_url":"git@github.com:NightlyNexus/retrofit.git","clone_url":"https://github.com/NightlyNexus/retrofit.git","svn_url":"https://github.com/NightlyNexus/retrofit","homepage":"http://square.github.io/retrofit/","size":4229,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"square:master","ref":"master","sha":"fa57873925419fdf28b6b19f7cede2b4fbfdb155","user":{"login":"square","id":82592,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNTky","avatar_url":"https://avatars0.githubusercontent.com/u/82592?v=4","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"repo":{"id":892275,"node_id":"MDEwOlJlcG9zaXRvcnk4OTIyNzU=","name":"retrofit","full_name":"square/retrofit","private":false,"owner":{"login":"square","id":82592,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNTky","avatar_url":"https://avatars0.githubusercontent.com/u/82592?v=4","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/square/retrofit","description":"Type-safe HTTP client for Android and Java by Square, Inc.","fork":false,"url":"https://api.github.com/repos/square/retrofit","forks_url":"https://api.github.com/repos/square/retrofit/forks","keys_url":"https://api.github.com/repos/square/retrofit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/square/retrofit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/square/retrofit/teams","hooks_url":"https://api.github.com/repos/square/retrofit/hooks","issue_events_url":"https://api.github.com/repos/square/retrofit/issues/events{/number}","events_url":"https://api.github.com/repos/square/retrofit/events","assignees_url":"https://api.github.com/repos/square/retrofit/assignees{/user}","branches_url":"https://api.github.com/repos/square/retrofit/branches{/branch}","tags_url":"https://api.github.com/repos/square/retrofit/tags","blobs_url":"https://api.github.com/repos/square/retrofit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/square/retrofit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/square/retrofit/git/refs{/sha}","trees_url":"https://api.github.com/repos/square/retrofit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/square/retrofit/statuses/{sha}","languages_url":"https://api.github.com/repos/square/retrofit/languages","stargazers_url":"https://api.github.com/repos/square/retrofit/stargazers","contributors_url":"https://api.github.com/repos/square/retrofit/contributors","subscribers_url":"https://api.github.com/repos/square/retrofit/subscribers","subscription_url":"https://api.github.com/repos/square/retrofit/subscription","commits_url":"https://api.github.com/repos/square/retrofit/commits{/sha}","git_commits_url":"https://api.github.com/repos/square/retrofit/git/commits{/sha}","comments_url":"https://api.github.com/repos/square/retrofit/comments{/number}","issue_comment_url":"https://api.github.com/repos/square/retrofit/issues/comments{/number}","contents_url":"https://api.github.com/repos/square/retrofit/contents/{+path}","compare_url":"https://api.github.com/repos/square/retrofit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/square/retrofit/merges","archive_url":"https://api.github.com/repos/square/retrofit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/square/retrofit/downloads","issues_url":"https://api.github.com/repos/square/retrofit/issues{/number}","pulls_url":"https://api.github.com/repos/square/retrofit/pulls{/number}","milestones_url":"https://api.github.com/repos/square/retrofit/milestones{/number}","notifications_url":"https://api.github.com/repos/square/retrofit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/square/retrofit/labels{/name}","releases_url":"https://api.github.com/repos/square/retrofit/releases{/id}","deployments_url":"https://api.github.com/repos/square/retrofit/deployments","created_at":"2010-09-06T21:39:43Z","updated_at":"2018-09-24T14:11:50Z","pushed_at":"2018-09-24T15:02:44Z","git_url":"git://github.com/square/retrofit.git","ssh_url":"git@github.com:square/retrofit.git","clone_url":"https://github.com/square/retrofit.git","svn_url":"https://github.com/square/retrofit","homepage":"http://square.github.io/retrofit/","size":4801,"stargazers_count":29667,"watchers_count":29667,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5685,"mirror_url":null,"archived":false,"open_issues_count":67,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5685,"open_issues":67,"watchers":29667,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/square/retrofit/pulls/2904"},"html":{"href":"https://github.com/square/retrofit/pull/2904"},"issue":{"href":"https://api.github.com/repos/square/retrofit/issues/2904"},"comments":{"href":"https://api.github.com/repos/square/retrofit/issues/2904/comments"},"review_comments":{"href":"https://api.github.com/repos/square/retrofit/pulls/2904/comments"},"review_comment":{"href":"https://api.github.com/repos/square/retrofit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/square/retrofit/pulls/2904/commits"},"statuses":{"href":"https://api.github.com/repos/square/retrofit/statuses/277b1874df25f0249878d8c8f6e55373017ff8f5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"NightlyNexus"}}