{"action":"created","comment":{"url":"https://api.github.com/repos/brave/brave-core/pulls/comments/213121339","pull_request_review_id":149891483,"id":213121339,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzEyMTMzOQ==","diff_hunk":"@@ -0,0 +1,22 @@\n+diff --git a/services/network/tcp_connected_socket.cc b/services/network/tcp_connected_socket.cc\n+index d8d6a1cd98c81268ab4fb597f682d71664317134..335859f434e3b7822ab483577a25a7da5586b8ec 100644\n+--- a/services/network/tcp_connected_socket.cc\n++++ b/services/network/tcp_connected_socket.cc\n+@@ -46,7 +46,16 @@ TCPConnectedSocket::TCPConnectedSocket(\n+       std::move(send_pipe_handle), traffic_annotation);\n+ }\n+ \n+-TCPConnectedSocket::~TCPConnectedSocket() {}\n++TCPConnectedSocket::~TCPConnectedSocket() {\n++  if (connect_callback_) {","path":"patches/services-network-tcp_connected_socket.cc.patch","position":11,"original_position":11,"commit_id":"17cd247a21880ed54d41f2f3a1e598d3192939ac","original_commit_id":"096f48abfb1c1e044cef70ffdda34d2fc694522f","user":{"login":"yrliou","id":4730197,"node_id":"MDQ6VXNlcjQ3MzAxOTc=","avatar_url":"https://avatars1.githubusercontent.com/u/4730197?v=4","gravatar_id":"","url":"https://api.github.com/users/yrliou","html_url":"https://github.com/yrliou","followers_url":"https://api.github.com/users/yrliou/followers","following_url":"https://api.github.com/users/yrliou/following{/other_user}","gists_url":"https://api.github.com/users/yrliou/gists{/gist_id}","starred_url":"https://api.github.com/users/yrliou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yrliou/subscriptions","organizations_url":"https://api.github.com/users/yrliou/orgs","repos_url":"https://api.github.com/users/yrliou/repos","events_url":"https://api.github.com/users/yrliou/events{/privacy}","received_events_url":"https://api.github.com/users/yrliou/received_events","type":"User","site_admin":false},"body":"Without this, we'll still hit DCHECK in src/out/Debug/gen/services/network/public/mojom/network_context.mojom.cc,\r\nwhich checks if CreateTCPConnectedSocketCallback is destructed without respond.","created_at":"2018-08-27T21:27:06Z","updated_at":"2018-08-27T21:27:06Z","html_url":"https://github.com/brave/brave-core/pull/356#discussion_r213121339","pull_request_url":"https://api.github.com/repos/brave/brave-core/pulls/356","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/brave/brave-core/pulls/comments/213121339"},"html":{"href":"https://github.com/brave/brave-core/pull/356#discussion_r213121339"},"pull_request":{"href":"https://api.github.com/repos/brave/brave-core/pulls/356"}},"in_reply_to_id":213085248},"pull_request":{"url":"https://api.github.com/repos/brave/brave-core/pulls/356","id":210569588,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNTY5NTg4","html_url":"https://github.com/brave/brave-core/pull/356","diff_url":"https://github.com/brave/brave-core/pull/356.diff","patch_url":"https://github.com/brave/brave-core/pull/356.patch","issue_url":"https://api.github.com/repos/brave/brave-core/issues/356","number":356,"state":"open","locked":false,"title":"WebTorrent Support","user":{"login":"yrliou","id":4730197,"node_id":"MDQ6VXNlcjQ3MzAxOTc=","avatar_url":"https://avatars1.githubusercontent.com/u/4730197?v=4","gravatar_id":"","url":"https://api.github.com/users/yrliou","html_url":"https://github.com/yrliou","followers_url":"https://api.github.com/users/yrliou/followers","following_url":"https://api.github.com/users/yrliou/following{/other_user}","gists_url":"https://api.github.com/users/yrliou/gists{/gist_id}","starred_url":"https://api.github.com/users/yrliou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yrliou/subscriptions","organizations_url":"https://api.github.com/users/yrliou/orgs","repos_url":"https://api.github.com/users/yrliou/repos","events_url":"https://api.github.com/users/yrliou/events{/privacy}","received_events_url":"https://api.github.com/users/yrliou/received_events","type":"User","site_admin":false},"body":"What's included in this PR:\r\n- WebTorrent support of magnet links\r\n\r\nWhat's not included in this PR:\r\n- WebTorrent support of .torrent links\r\n- Support of trackless torrents using bittorrent-dht/client\r\n- l10n\r\n\r\n## Submitter Checklist:\r\n\r\n- [x] Submitted a [ticket](https://github.com/brave/brave-browser/issues) for my issue if one did not already exist.\r\n- [ ] Used Github [auto-closing keywords](https://help.github.com/articles/closing-issues-via-commit-messages/) in the commit message.\r\n- [ ] Added/updated tests for this change (for new code or code which already has tests).\r\n- [ ] Ran `git rebase -i` to squash commits (if needed).\r\n- [ ] Tagged reviewers and labelled the pull request as needed.\r\n- [ ] Request a security/privacy review as needed.\r\n- [ ] Add appropriate QA labels (QA/Needed or QA/No-QA-Needed) to include the closed issue in milestone \r\n\r\n## Test Plan:\r\n\r\n\r\n## Reviewer Checklist:\r\n\r\n- [ ] New files have MPL-2.0 license header.\r\n- [ ] Request a security/privacy review as needed.\r\n- [ ] Adequate test coverage exists to prevent regressions \r\n- [ ] Verify test plan is specified in PR before merging to source","created_at":"2018-08-23T20:39:58Z","updated_at":"2018-08-27T21:27:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"deaa19953ec18f7077c5144b212b621565e34e92","assignee":{"login":"yrliou","id":4730197,"node_id":"MDQ6VXNlcjQ3MzAxOTc=","avatar_url":"https://avatars1.githubusercontent.com/u/4730197?v=4","gravatar_id":"","url":"https://api.github.com/users/yrliou","html_url":"https://github.com/yrliou","followers_url":"https://api.github.com/users/yrliou/followers","following_url":"https://api.github.com/users/yrliou/following{/other_user}","gists_url":"https://api.github.com/users/yrliou/gists{/gist_id}","starred_url":"https://api.github.com/users/yrliou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yrliou/subscriptions","organizations_url":"https://api.github.com/users/yrliou/orgs","repos_url":"https://api.github.com/users/yrliou/repos","events_url":"https://api.github.com/users/yrliou/events{/privacy}","received_events_url":"https://api.github.com/users/yrliou/received_events","type":"User","site_admin":false},"assignees":[{"login":"yrliou","id":4730197,"node_id":"MDQ6VXNlcjQ3MzAxOTc=","avatar_url":"https://avatars1.githubusercontent.com/u/4730197?v=4","gravatar_id":"","url":"https://api.github.com/users/yrliou","html_url":"https://github.com/yrliou","followers_url":"https://api.github.com/users/yrliou/followers","following_url":"https://api.github.com/users/yrliou/following{/other_user}","gists_url":"https://api.github.com/users/yrliou/gists{/gist_id}","starred_url":"https://api.github.com/users/yrliou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yrliou/subscriptions","organizations_url":"https://api.github.com/users/yrliou/orgs","repos_url":"https://api.github.com/users/yrliou/repos","events_url":"https://api.github.com/users/yrliou/events{/privacy}","received_events_url":"https://api.github.com/users/yrliou/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"bbondy","id":831718,"node_id":"MDQ6VXNlcjgzMTcxOA==","avatar_url":"https://avatars2.githubusercontent.com/u/831718?v=4","gravatar_id":"","url":"https://api.github.com/users/bbondy","html_url":"https://github.com/bbondy","followers_url":"https://api.github.com/users/bbondy/followers","following_url":"https://api.github.com/users/bbondy/following{/other_user}","gists_url":"https://api.github.com/users/bbondy/gists{/gist_id}","starred_url":"https://api.github.com/users/bbondy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbondy/subscriptions","organizations_url":"https://api.github.com/users/bbondy/orgs","repos_url":"https://api.github.com/users/bbondy/repos","events_url":"https://api.github.com/users/bbondy/events{/privacy}","received_events_url":"https://api.github.com/users/bbondy/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/brave/brave-core/pulls/356/commits","review_comments_url":"https://api.github.com/repos/brave/brave-core/pulls/356/comments","review_comment_url":"https://api.github.com/repos/brave/brave-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brave/brave-core/issues/356/comments","statuses_url":"https://api.github.com/repos/brave/brave-core/statuses/17cd247a21880ed54d41f2f3a1e598d3192939ac","head":{"label":"brave:webtorrent_ext","ref":"webtorrent_ext","sha":"17cd247a21880ed54d41f2f3a1e598d3192939ac","user":{"login":"brave","id":12301619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAxNjE5","avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"repo":{"id":110198384,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAxOTgzODQ=","name":"brave-core","full_name":"brave/brave-core","owner":{"login":"brave","id":12301619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAxNjE5","avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brave/brave-core","description":"Core engine for the Brave browser for macOS, Windows, Linux, and eventually Android ","fork":false,"url":"https://api.github.com/repos/brave/brave-core","forks_url":"https://api.github.com/repos/brave/brave-core/forks","keys_url":"https://api.github.com/repos/brave/brave-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brave/brave-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brave/brave-core/teams","hooks_url":"https://api.github.com/repos/brave/brave-core/hooks","issue_events_url":"https://api.github.com/repos/brave/brave-core/issues/events{/number}","events_url":"https://api.github.com/repos/brave/brave-core/events","assignees_url":"https://api.github.com/repos/brave/brave-core/assignees{/user}","branches_url":"https://api.github.com/repos/brave/brave-core/branches{/branch}","tags_url":"https://api.github.com/repos/brave/brave-core/tags","blobs_url":"https://api.github.com/repos/brave/brave-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brave/brave-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brave/brave-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/brave/brave-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brave/brave-core/statuses/{sha}","languages_url":"https://api.github.com/repos/brave/brave-core/languages","stargazers_url":"https://api.github.com/repos/brave/brave-core/stargazers","contributors_url":"https://api.github.com/repos/brave/brave-core/contributors","subscribers_url":"https://api.github.com/repos/brave/brave-core/subscribers","subscription_url":"https://api.github.com/repos/brave/brave-core/subscription","commits_url":"https://api.github.com/repos/brave/brave-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/brave/brave-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/brave/brave-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/brave/brave-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/brave/brave-core/contents/{+path}","compare_url":"https://api.github.com/repos/brave/brave-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brave/brave-core/merges","archive_url":"https://api.github.com/repos/brave/brave-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brave/brave-core/downloads","issues_url":"https://api.github.com/repos/brave/brave-core/issues{/number}","pulls_url":"https://api.github.com/repos/brave/brave-core/pulls{/number}","milestones_url":"https://api.github.com/repos/brave/brave-core/milestones{/number}","notifications_url":"https://api.github.com/repos/brave/brave-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brave/brave-core/labels{/name}","releases_url":"https://api.github.com/repos/brave/brave-core/releases{/id}","deployments_url":"https://api.github.com/repos/brave/brave-core/deployments","created_at":"2017-11-10T03:33:30Z","updated_at":"2018-08-26T09:07:31Z","pushed_at":"2018-08-27T19:29:14Z","git_url":"git://github.com/brave/brave-core.git","ssh_url":"git@github.com:brave/brave-core.git","clone_url":"https://github.com/brave/brave-core.git","svn_url":"https://github.com/brave/brave-core","homepage":"","size":42129,"stargazers_count":108,"watchers_count":108,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":26,"open_issues":11,"watchers":108,"default_branch":"master"}},"base":{"label":"brave:master","ref":"master","sha":"7913a70d8f21f94eb06932222e208669895dd42f","user":{"login":"brave","id":12301619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAxNjE5","avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"repo":{"id":110198384,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAxOTgzODQ=","name":"brave-core","full_name":"brave/brave-core","owner":{"login":"brave","id":12301619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAxNjE5","avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brave/brave-core","description":"Core engine for the Brave browser for macOS, Windows, Linux, and eventually Android ","fork":false,"url":"https://api.github.com/repos/brave/brave-core","forks_url":"https://api.github.com/repos/brave/brave-core/forks","keys_url":"https://api.github.com/repos/brave/brave-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brave/brave-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brave/brave-core/teams","hooks_url":"https://api.github.com/repos/brave/brave-core/hooks","issue_events_url":"https://api.github.com/repos/brave/brave-core/issues/events{/number}","events_url":"https://api.github.com/repos/brave/brave-core/events","assignees_url":"https://api.github.com/repos/brave/brave-core/assignees{/user}","branches_url":"https://api.github.com/repos/brave/brave-core/branches{/branch}","tags_url":"https://api.github.com/repos/brave/brave-core/tags","blobs_url":"https://api.github.com/repos/brave/brave-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brave/brave-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brave/brave-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/brave/brave-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brave/brave-core/statuses/{sha}","languages_url":"https://api.github.com/repos/brave/brave-core/languages","stargazers_url":"https://api.github.com/repos/brave/brave-core/stargazers","contributors_url":"https://api.github.com/repos/brave/brave-core/contributors","subscribers_url":"https://api.github.com/repos/brave/brave-core/subscribers","subscription_url":"https://api.github.com/repos/brave/brave-core/subscription","commits_url":"https://api.github.com/repos/brave/brave-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/brave/brave-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/brave/brave-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/brave/brave-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/brave/brave-core/contents/{+path}","compare_url":"https://api.github.com/repos/brave/brave-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brave/brave-core/merges","archive_url":"https://api.github.com/repos/brave/brave-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brave/brave-core/downloads","issues_url":"https://api.github.com/repos/brave/brave-core/issues{/number}","pulls_url":"https://api.github.com/repos/brave/brave-core/pulls{/number}","milestones_url":"https://api.github.com/repos/brave/brave-core/milestones{/number}","notifications_url":"https://api.github.com/repos/brave/brave-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brave/brave-core/labels{/name}","releases_url":"https://api.github.com/repos/brave/brave-core/releases{/id}","deployments_url":"https://api.github.com/repos/brave/brave-core/deployments","created_at":"2017-11-10T03:33:30Z","updated_at":"2018-08-26T09:07:31Z","pushed_at":"2018-08-27T19:29:14Z","git_url":"git://github.com/brave/brave-core.git","ssh_url":"git@github.com:brave/brave-core.git","clone_url":"https://github.com/brave/brave-core.git","svn_url":"https://github.com/brave/brave-core","homepage":"","size":42129,"stargazers_count":108,"watchers_count":108,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":26,"open_issues":11,"watchers":108,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brave/brave-core/pulls/356"},"html":{"href":"https://github.com/brave/brave-core/pull/356"},"issue":{"href":"https://api.github.com/repos/brave/brave-core/issues/356"},"comments":{"href":"https://api.github.com/repos/brave/brave-core/issues/356/comments"},"review_comments":{"href":"https://api.github.com/repos/brave/brave-core/pulls/356/comments"},"review_comment":{"href":"https://api.github.com/repos/brave/brave-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brave/brave-core/pulls/356/commits"},"statuses":{"href":"https://api.github.com/repos/brave/brave-core/statuses/17cd247a21880ed54d41f2f3a1e598d3192939ac"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"yrliou"}}