{"action":"opened","number":670,"pull_request":{"url":"https://api.github.com/repos/jetstack/cert-manager/pulls/670","id":196558561,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2NTU4NTYx","html_url":"https://github.com/jetstack/cert-manager/pull/670","diff_url":"https://github.com/jetstack/cert-manager/pull/670.diff","patch_url":"https://github.com/jetstack/cert-manager/pull/670.patch","issue_url":"https://api.github.com/repos/jetstack/cert-manager/issues/670","number":670,"state":"open","locked":false,"title":"add support CNAME for dns-01 challenge","user":{"login":"gurvindersingh","id":186077,"node_id":"MDQ6VXNlcjE4NjA3Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/186077?v=4","gravatar_id":"","url":"https://api.github.com/users/gurvindersingh","html_url":"https://github.com/gurvindersingh","followers_url":"https://api.github.com/users/gurvindersingh/followers","following_url":"https://api.github.com/users/gurvindersingh/following{/other_user}","gists_url":"https://api.github.com/users/gurvindersingh/gists{/gist_id}","starred_url":"https://api.github.com/users/gurvindersingh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gurvindersingh/subscriptions","organizations_url":"https://api.github.com/users/gurvindersingh/orgs","repos_url":"https://api.github.com/users/gurvindersingh/repos","events_url":"https://api.github.com/users/gurvindersingh/events{/privacy}","received_events_url":"https://api.github.com/users/gurvindersingh/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:\r\nDomain for which certificate is asked for can have a `CNAME`, so we should check it.\r\nIf domain has a `CNAME`, create the challenge `TXT` record in the alias domain.\r\n\r\nThis is useful in the scenario where a company like us is using some DNS provider\r\nwhich is not supported dynamically. We can then create a CNAME for records like\r\n\r\n`_acme-challenge.example.com -> example.aws.hosted.com`\r\n\r\nSo this will allow us getting cert for `*.example.com` with creating a `TXT` record in route53 hosted zone for above example.\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n```release-note\r\n```\r\n","created_at":"2018-06-21T19:55:26Z","updated_at":"2018-06-21T19:55:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jetstack/cert-manager/pulls/670/commits","review_comments_url":"https://api.github.com/repos/jetstack/cert-manager/pulls/670/comments","review_comment_url":"https://api.github.com/repos/jetstack/cert-manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jetstack/cert-manager/issues/670/comments","statuses_url":"https://api.github.com/repos/jetstack/cert-manager/statuses/bfde429b8ee27fee05e66fa6abe8283cd853ab96","head":{"label":"gurvindersingh:master","ref":"master","sha":"bfde429b8ee27fee05e66fa6abe8283cd853ab96","user":{"login":"gurvindersingh","id":186077,"node_id":"MDQ6VXNlcjE4NjA3Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/186077?v=4","gravatar_id":"","url":"https://api.github.com/users/gurvindersingh","html_url":"https://github.com/gurvindersingh","followers_url":"https://api.github.com/users/gurvindersingh/followers","following_url":"https://api.github.com/users/gurvindersingh/following{/other_user}","gists_url":"https://api.github.com/users/gurvindersingh/gists{/gist_id}","starred_url":"https://api.github.com/users/gurvindersingh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gurvindersingh/subscriptions","organizations_url":"https://api.github.com/users/gurvindersingh/orgs","repos_url":"https://api.github.com/users/gurvindersingh/repos","events_url":"https://api.github.com/users/gurvindersingh/events{/privacy}","received_events_url":"https://api.github.com/users/gurvindersingh/received_events","type":"User","site_admin":false},"repo":{"id":138210877,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgyMTA4Nzc=","name":"cert-manager","full_name":"gurvindersingh/cert-manager","owner":{"login":"gurvindersingh","id":186077,"node_id":"MDQ6VXNlcjE4NjA3Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/186077?v=4","gravatar_id":"","url":"https://api.github.com/users/gurvindersingh","html_url":"https://github.com/gurvindersingh","followers_url":"https://api.github.com/users/gurvindersingh/followers","following_url":"https://api.github.com/users/gurvindersingh/following{/other_user}","gists_url":"https://api.github.com/users/gurvindersingh/gists{/gist_id}","starred_url":"https://api.github.com/users/gurvindersingh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gurvindersingh/subscriptions","organizations_url":"https://api.github.com/users/gurvindersingh/orgs","repos_url":"https://api.github.com/users/gurvindersingh/repos","events_url":"https://api.github.com/users/gurvindersingh/events{/privacy}","received_events_url":"https://api.github.com/users/gurvindersingh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gurvindersingh/cert-manager","description":"Automatically provision and manage TLS certificates in Kubernetes","fork":true,"url":"https://api.github.com/repos/gurvindersingh/cert-manager","forks_url":"https://api.github.com/repos/gurvindersingh/cert-manager/forks","keys_url":"https://api.github.com/repos/gurvindersingh/cert-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gurvindersingh/cert-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gurvindersingh/cert-manager/teams","hooks_url":"https://api.github.com/repos/gurvindersingh/cert-manager/hooks","issue_events_url":"https://api.github.com/repos/gurvindersingh/cert-manager/issues/events{/number}","events_url":"https://api.github.com/repos/gurvindersingh/cert-manager/events","assignees_url":"https://api.github.com/repos/gurvindersingh/cert-manager/assignees{/user}","branches_url":"https://api.github.com/repos/gurvindersingh/cert-manager/branches{/branch}","tags_url":"https://api.github.com/repos/gurvindersingh/cert-manager/tags","blobs_url":"https://api.github.com/repos/gurvindersingh/cert-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gurvindersingh/cert-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gurvindersingh/cert-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/gurvindersingh/cert-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gurvindersingh/cert-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/gurvindersingh/cert-manager/languages","stargazers_url":"https://api.github.com/repos/gurvindersingh/cert-manager/stargazers","contributors_url":"https://api.github.com/repos/gurvindersingh/cert-manager/contributors","subscribers_url":"https://api.github.com/repos/gurvindersingh/cert-manager/subscribers","subscription_url":"https://api.github.com/repos/gurvindersingh/cert-manager/subscription","commits_url":"https://api.github.com/repos/gurvindersingh/cert-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/gurvindersingh/cert-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/gurvindersingh/cert-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/gurvindersingh/cert-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/gurvindersingh/cert-manager/contents/{+path}","compare_url":"https://api.github.com/repos/gurvindersingh/cert-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gurvindersingh/cert-manager/merges","archive_url":"https://api.github.com/repos/gurvindersingh/cert-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gurvindersingh/cert-manager/downloads","issues_url":"https://api.github.com/repos/gurvindersingh/cert-manager/issues{/number}","pulls_url":"https://api.github.com/repos/gurvindersingh/cert-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/gurvindersingh/cert-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/gurvindersingh/cert-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gurvindersingh/cert-manager/labels{/name}","releases_url":"https://api.github.com/repos/gurvindersingh/cert-manager/releases{/id}","deployments_url":"https://api.github.com/repos/gurvindersingh/cert-manager/deployments","created_at":"2018-06-21T19:01:00Z","updated_at":"2018-06-21T19:52:15Z","pushed_at":"2018-06-21T19:52:14Z","git_url":"git://github.com/gurvindersingh/cert-manager.git","ssh_url":"git@github.com:gurvindersingh/cert-manager.git","clone_url":"https://github.com/gurvindersingh/cert-manager.git","svn_url":"https://github.com/gurvindersingh/cert-manager","homepage":"","size":52710,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jetstack:master","ref":"master","sha":"28c52d6f02e7b19b89fd9f61cb2960be07f05d0b","user":{"login":"jetstack","id":13183983,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTgzOTgz","avatar_url":"https://avatars1.githubusercontent.com/u/13183983?v=4","gravatar_id":"","url":"https://api.github.com/users/jetstack","html_url":"https://github.com/jetstack","followers_url":"https://api.github.com/users/jetstack/followers","following_url":"https://api.github.com/users/jetstack/following{/other_user}","gists_url":"https://api.github.com/users/jetstack/gists{/gist_id}","starred_url":"https://api.github.com/users/jetstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jetstack/subscriptions","organizations_url":"https://api.github.com/users/jetstack/orgs","repos_url":"https://api.github.com/users/jetstack/repos","events_url":"https://api.github.com/users/jetstack/events{/privacy}","received_events_url":"https://api.github.com/users/jetstack/received_events","type":"Organization","site_admin":false},"repo":{"id":92313258,"node_id":"MDEwOlJlcG9zaXRvcnk5MjMxMzI1OA==","name":"cert-manager","full_name":"jetstack/cert-manager","owner":{"login":"jetstack","id":13183983,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTgzOTgz","avatar_url":"https://avatars1.githubusercontent.com/u/13183983?v=4","gravatar_id":"","url":"https://api.github.com/users/jetstack","html_url":"https://github.com/jetstack","followers_url":"https://api.github.com/users/jetstack/followers","following_url":"https://api.github.com/users/jetstack/following{/other_user}","gists_url":"https://api.github.com/users/jetstack/gists{/gist_id}","starred_url":"https://api.github.com/users/jetstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jetstack/subscriptions","organizations_url":"https://api.github.com/users/jetstack/orgs","repos_url":"https://api.github.com/users/jetstack/repos","events_url":"https://api.github.com/users/jetstack/events{/privacy}","received_events_url":"https://api.github.com/users/jetstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jetstack/cert-manager","description":"Automatically provision and manage TLS certificates in Kubernetes","fork":false,"url":"https://api.github.com/repos/jetstack/cert-manager","forks_url":"https://api.github.com/repos/jetstack/cert-manager/forks","keys_url":"https://api.github.com/repos/jetstack/cert-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jetstack/cert-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jetstack/cert-manager/teams","hooks_url":"https://api.github.com/repos/jetstack/cert-manager/hooks","issue_events_url":"https://api.github.com/repos/jetstack/cert-manager/issues/events{/number}","events_url":"https://api.github.com/repos/jetstack/cert-manager/events","assignees_url":"https://api.github.com/repos/jetstack/cert-manager/assignees{/user}","branches_url":"https://api.github.com/repos/jetstack/cert-manager/branches{/branch}","tags_url":"https://api.github.com/repos/jetstack/cert-manager/tags","blobs_url":"https://api.github.com/repos/jetstack/cert-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jetstack/cert-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jetstack/cert-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/jetstack/cert-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jetstack/cert-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/jetstack/cert-manager/languages","stargazers_url":"https://api.github.com/repos/jetstack/cert-manager/stargazers","contributors_url":"https://api.github.com/repos/jetstack/cert-manager/contributors","subscribers_url":"https://api.github.com/repos/jetstack/cert-manager/subscribers","subscription_url":"https://api.github.com/repos/jetstack/cert-manager/subscription","commits_url":"https://api.github.com/repos/jetstack/cert-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/jetstack/cert-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/jetstack/cert-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/jetstack/cert-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/jetstack/cert-manager/contents/{+path}","compare_url":"https://api.github.com/repos/jetstack/cert-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jetstack/cert-manager/merges","archive_url":"https://api.github.com/repos/jetstack/cert-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jetstack/cert-manager/downloads","issues_url":"https://api.github.com/repos/jetstack/cert-manager/issues{/number}","pulls_url":"https://api.github.com/repos/jetstack/cert-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/jetstack/cert-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/jetstack/cert-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jetstack/cert-manager/labels{/name}","releases_url":"https://api.github.com/repos/jetstack/cert-manager/releases{/id}","deployments_url":"https://api.github.com/repos/jetstack/cert-manager/deployments","created_at":"2017-05-24T16:25:59Z","updated_at":"2018-06-21T17:01:21Z","pushed_at":"2018-06-21T12:28:49Z","git_url":"git://github.com/jetstack/cert-manager.git","ssh_url":"git@github.com:jetstack/cert-manager.git","clone_url":"https://github.com/jetstack/cert-manager.git","svn_url":"https://github.com/jetstack/cert-manager","homepage":"","size":52710,"stargazers_count":1435,"watchers_count":1435,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":195,"mirror_url":null,"archived":false,"open_issues_count":138,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":195,"open_issues":138,"watchers":1435,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jetstack/cert-manager/pulls/670"},"html":{"href":"https://github.com/jetstack/cert-manager/pull/670"},"issue":{"href":"https://api.github.com/repos/jetstack/cert-manager/issues/670"},"comments":{"href":"https://api.github.com/repos/jetstack/cert-manager/issues/670/comments"},"review_comments":{"href":"https://api.github.com/repos/jetstack/cert-manager/pulls/670/comments"},"review_comment":{"href":"https://api.github.com/repos/jetstack/cert-manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jetstack/cert-manager/pulls/670/commits"},"statuses":{"href":"https://api.github.com/repos/jetstack/cert-manager/statuses/bfde429b8ee27fee05e66fa6abe8283cd853ab96"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":29,"deletions":11,"changed_files":2}}
{"actor":{"display_login":"gurvindersingh"}}