{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-sigs/kustomize/pulls/comments/223889161","pull_request_review_id":163128557,"id":223889161,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzg4OTE2MQ==","diff_hunk":"@@ -18,14 +18,30 @@ limitations under the License.\n package types\n \n import (\n-\tmetav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\"\n-\n \t\"sigs.k8s.io/kustomize/pkg/patch\"\n )\n \n+// TypeMeta is copied from apimachinery\n+type TypeMeta struct {\n+\t// Kind is a string value representing the REST resource this object represents.\n+\t// Servers may infer this from the endpoint the client submits requests to.\n+\t// Cannot be updated.\n+\t// In CamelCase.\n+\t// More info: https://git.k8s.io/community/contributors/devel/api-conventions.md#types-kinds\n+\t// +optional\n+\tKind string `json:\"kind,omitempty\" protobuf:\"bytes,1,opt,name=kind\"`","path":"pkg/types/kustomization.go","position":17,"original_position":17,"commit_id":"8274d467556ccf3108927573198fe1c7a73c6b1f","original_commit_id":"8274d467556ccf3108927573198fe1c7a73c6b1f","user":{"login":"monopole","id":2928188,"node_id":"MDQ6VXNlcjI5MjgxODg=","avatar_url":"https://avatars3.githubusercontent.com/u/2928188?v=4","gravatar_id":"","url":"https://api.github.com/users/monopole","html_url":"https://github.com/monopole","followers_url":"https://api.github.com/users/monopole/followers","following_url":"https://api.github.com/users/monopole/following{/other_user}","gists_url":"https://api.github.com/users/monopole/gists{/gist_id}","starred_url":"https://api.github.com/users/monopole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monopole/subscriptions","organizations_url":"https://api.github.com/users/monopole/orgs","repos_url":"https://api.github.com/users/monopole/repos","events_url":"https://api.github.com/users/monopole/events{/privacy}","received_events_url":"https://api.github.com/users/monopole/received_events","type":"User","site_admin":false},"body":"Instead of copying all that, just a one line pointer\r\nto original doc so the comments don't get out of sync\r\nand to underscore that this field is exactly the same as the original.\r\n```\r\n// Kind copies apimachinery/pkg/apis/meta/v1.Typemeta.Kind\r\n```\r\n","created_at":"2018-10-09T22:49:46Z","updated_at":"2018-10-09T22:55:46Z","html_url":"https://github.com/kubernetes-sigs/kustomize/pull/445#discussion_r223889161","pull_request_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/pulls/445","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-sigs/kustomize/pulls/comments/223889161"},"html":{"href":"https://github.com/kubernetes-sigs/kustomize/pull/445#discussion_r223889161"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-sigs/kustomize/pulls/445"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes-sigs/kustomize/pulls/445","id":221605802,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNjA1ODAy","html_url":"https://github.com/kubernetes-sigs/kustomize/pull/445","diff_url":"https://github.com/kubernetes-sigs/kustomize/pull/445.diff","patch_url":"https://github.com/kubernetes-sigs/kustomize/pull/445.patch","issue_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/issues/445","number":445,"state":"open","locked":false,"title":"copy TypeMeta from apimachinery","user":{"login":"Liujingfang1","id":8498608,"node_id":"MDQ6VXNlcjg0OTg2MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/8498608?v=4","gravatar_id":"","url":"https://api.github.com/users/Liujingfang1","html_url":"https://github.com/Liujingfang1","followers_url":"https://api.github.com/users/Liujingfang1/followers","following_url":"https://api.github.com/users/Liujingfang1/following{/other_user}","gists_url":"https://api.github.com/users/Liujingfang1/gists{/gist_id}","starred_url":"https://api.github.com/users/Liujingfang1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Liujingfang1/subscriptions","organizations_url":"https://api.github.com/users/Liujingfang1/orgs","repos_url":"https://api.github.com/users/Liujingfang1/repos","events_url":"https://api.github.com/users/Liujingfang1/events{/privacy}","received_events_url":"https://api.github.com/users/Liujingfang1/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-09T22:27:44Z","updated_at":"2018-10-09T22:55:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"815667796857983844aa1b64cc5ae13a35fa0ced","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":952071101,"node_id":"MDU6TGFiZWw5NTIwNzExMDE=","url":"https://api.github.com/repos/kubernetes-sigs/kustomize/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":930398993,"node_id":"MDU6TGFiZWw5MzAzOTg5OTM=","url":"https://api.github.com/repos/kubernetes-sigs/kustomize/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":935471860,"node_id":"MDU6TGFiZWw5MzU0NzE4NjA=","url":"https://api.github.com/repos/kubernetes-sigs/kustomize/labels/size/S","name":"size/S","color":"77bb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/pulls/445/commits","review_comments_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/pulls/445/comments","review_comment_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/issues/445/comments","statuses_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/statuses/8274d467556ccf3108927573198fe1c7a73c6b1f","head":{"label":"Liujingfang1:typemeta","ref":"typemeta","sha":"8274d467556ccf3108927573198fe1c7a73c6b1f","user":{"login":"Liujingfang1","id":8498608,"node_id":"MDQ6VXNlcjg0OTg2MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/8498608?v=4","gravatar_id":"","url":"https://api.github.com/users/Liujingfang1","html_url":"https://github.com/Liujingfang1","followers_url":"https://api.github.com/users/Liujingfang1/followers","following_url":"https://api.github.com/users/Liujingfang1/following{/other_user}","gists_url":"https://api.github.com/users/Liujingfang1/gists{/gist_id}","starred_url":"https://api.github.com/users/Liujingfang1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Liujingfang1/subscriptions","organizations_url":"https://api.github.com/users/Liujingfang1/orgs","repos_url":"https://api.github.com/users/Liujingfang1/repos","events_url":"https://api.github.com/users/Liujingfang1/events{/privacy}","received_events_url":"https://api.github.com/users/Liujingfang1/received_events","type":"User","site_admin":false},"repo":{"id":134768545,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ3Njg1NDU=","name":"kustomize","full_name":"Liujingfang1/kustomize","private":false,"owner":{"login":"Liujingfang1","id":8498608,"node_id":"MDQ6VXNlcjg0OTg2MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/8498608?v=4","gravatar_id":"","url":"https://api.github.com/users/Liujingfang1","html_url":"https://github.com/Liujingfang1","followers_url":"https://api.github.com/users/Liujingfang1/followers","following_url":"https://api.github.com/users/Liujingfang1/following{/other_user}","gists_url":"https://api.github.com/users/Liujingfang1/gists{/gist_id}","starred_url":"https://api.github.com/users/Liujingfang1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Liujingfang1/subscriptions","organizations_url":"https://api.github.com/users/Liujingfang1/orgs","repos_url":"https://api.github.com/users/Liujingfang1/repos","events_url":"https://api.github.com/users/Liujingfang1/events{/privacy}","received_events_url":"https://api.github.com/users/Liujingfang1/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Liujingfang1/kustomize","description":"Customization of kubernetes YAML configurations","fork":true,"url":"https://api.github.com/repos/Liujingfang1/kustomize","forks_url":"https://api.github.com/repos/Liujingfang1/kustomize/forks","keys_url":"https://api.github.com/repos/Liujingfang1/kustomize/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Liujingfang1/kustomize/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Liujingfang1/kustomize/teams","hooks_url":"https://api.github.com/repos/Liujingfang1/kustomize/hooks","issue_events_url":"https://api.github.com/repos/Liujingfang1/kustomize/issues/events{/number}","events_url":"https://api.github.com/repos/Liujingfang1/kustomize/events","assignees_url":"https://api.github.com/repos/Liujingfang1/kustomize/assignees{/user}","branches_url":"https://api.github.com/repos/Liujingfang1/kustomize/branches{/branch}","tags_url":"https://api.github.com/repos/Liujingfang1/kustomize/tags","blobs_url":"https://api.github.com/repos/Liujingfang1/kustomize/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Liujingfang1/kustomize/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Liujingfang1/kustomize/git/refs{/sha}","trees_url":"https://api.github.com/repos/Liujingfang1/kustomize/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Liujingfang1/kustomize/statuses/{sha}","languages_url":"https://api.github.com/repos/Liujingfang1/kustomize/languages","stargazers_url":"https://api.github.com/repos/Liujingfang1/kustomize/stargazers","contributors_url":"https://api.github.com/repos/Liujingfang1/kustomize/contributors","subscribers_url":"https://api.github.com/repos/Liujingfang1/kustomize/subscribers","subscription_url":"https://api.github.com/repos/Liujingfang1/kustomize/subscription","commits_url":"https://api.github.com/repos/Liujingfang1/kustomize/commits{/sha}","git_commits_url":"https://api.github.com/repos/Liujingfang1/kustomize/git/commits{/sha}","comments_url":"https://api.github.com/repos/Liujingfang1/kustomize/comments{/number}","issue_comment_url":"https://api.github.com/repos/Liujingfang1/kustomize/issues/comments{/number}","contents_url":"https://api.github.com/repos/Liujingfang1/kustomize/contents/{+path}","compare_url":"https://api.github.com/repos/Liujingfang1/kustomize/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Liujingfang1/kustomize/merges","archive_url":"https://api.github.com/repos/Liujingfang1/kustomize/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Liujingfang1/kustomize/downloads","issues_url":"https://api.github.com/repos/Liujingfang1/kustomize/issues{/number}","pulls_url":"https://api.github.com/repos/Liujingfang1/kustomize/pulls{/number}","milestones_url":"https://api.github.com/repos/Liujingfang1/kustomize/milestones{/number}","notifications_url":"https://api.github.com/repos/Liujingfang1/kustomize/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Liujingfang1/kustomize/labels{/name}","releases_url":"https://api.github.com/repos/Liujingfang1/kustomize/releases{/id}","deployments_url":"https://api.github.com/repos/Liujingfang1/kustomize/deployments","created_at":"2018-05-24T21:02:30Z","updated_at":"2018-10-09T18:30:48Z","pushed_at":"2018-10-09T22:51:09Z","git_url":"git://github.com/Liujingfang1/kustomize.git","ssh_url":"git@github.com:Liujingfang1/kustomize.git","clone_url":"https://github.com/Liujingfang1/kustomize.git","svn_url":"https://github.com/Liujingfang1/kustomize","homepage":"","size":22408,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"kubernetes-sigs:master","ref":"master","sha":"0faef46773d71bf72d63504a0a5fb0755bccffb0","user":{"login":"kubernetes-sigs","id":36015203,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDE1MjAz","avatar_url":"https://avatars1.githubusercontent.com/u/36015203?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-sigs","html_url":"https://github.com/kubernetes-sigs","followers_url":"https://api.github.com/users/kubernetes-sigs/followers","following_url":"https://api.github.com/users/kubernetes-sigs/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-sigs/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-sigs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-sigs/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-sigs/orgs","repos_url":"https://api.github.com/users/kubernetes-sigs/repos","events_url":"https://api.github.com/users/kubernetes-sigs/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-sigs/received_events","type":"Organization","site_admin":false},"repo":{"id":133067498,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMwNjc0OTg=","name":"kustomize","full_name":"kubernetes-sigs/kustomize","private":false,"owner":{"login":"kubernetes-sigs","id":36015203,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDE1MjAz","avatar_url":"https://avatars1.githubusercontent.com/u/36015203?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-sigs","html_url":"https://github.com/kubernetes-sigs","followers_url":"https://api.github.com/users/kubernetes-sigs/followers","following_url":"https://api.github.com/users/kubernetes-sigs/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-sigs/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-sigs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-sigs/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-sigs/orgs","repos_url":"https://api.github.com/users/kubernetes-sigs/repos","events_url":"https://api.github.com/users/kubernetes-sigs/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-sigs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubernetes-sigs/kustomize","description":"Customization of kubernetes YAML configurations","fork":false,"url":"https://api.github.com/repos/kubernetes-sigs/kustomize","forks_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/forks","keys_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/teams","hooks_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/events","assignees_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/tags","blobs_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/languages","stargazers_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/subscription","commits_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/merges","archive_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/downloads","issues_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/deployments","created_at":"2018-05-11T17:09:33Z","updated_at":"2018-10-09T22:02:57Z","pushed_at":"2018-10-09T22:51:10Z","git_url":"git://github.com/kubernetes-sigs/kustomize.git","ssh_url":"git@github.com:kubernetes-sigs/kustomize.git","clone_url":"https://github.com/kubernetes-sigs/kustomize.git","svn_url":"https://github.com/kubernetes-sigs/kustomize","homepage":"","size":22352,"stargazers_count":1167,"watchers_count":1167,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":108,"mirror_url":null,"archived":false,"open_issues_count":51,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":108,"open_issues":51,"watchers":1167,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-sigs/kustomize/pulls/445"},"html":{"href":"https://github.com/kubernetes-sigs/kustomize/pull/445"},"issue":{"href":"https://api.github.com/repos/kubernetes-sigs/kustomize/issues/445"},"comments":{"href":"https://api.github.com/repos/kubernetes-sigs/kustomize/issues/445/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-sigs/kustomize/pulls/445/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-sigs/kustomize/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-sigs/kustomize/pulls/445/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-sigs/kustomize/statuses/8274d467556ccf3108927573198fe1c7a73c6b1f"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"monopole"}}