{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/pulls/comments/204217108","pull_request_review_id":139264706,"id":204217108,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDIxNzEwOA==","diff_hunk":"@@ -58,7 +58,8 @@ enum State<Fut, T> {\n }\n \n impl<Fut, T> State<Fut, T> {\n-    fn as_pin_mut<'a>(\n+    #[allow(needless_lifetimes, wrong_self_convention)] // https://github.com/rust-lang/rfcs/pull/2362#issuecomment-406804183\n+    fn as_pin_mut(\n         self: PinMut<'a, Self>","path":"futures-util/src/sink/with.rs","position":7,"original_position":7,"commit_id":"144acf908f4832999a8b2b23f4b5c31ece047249","original_commit_id":"144acf908f4832999a8b2b23f4b5c31ece047249","user":{"login":"MajorBreakfast","id":340142,"node_id":"MDQ6VXNlcjM0MDE0Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/340142?v=4","gravatar_id":"","url":"https://api.github.com/users/MajorBreakfast","html_url":"https://github.com/MajorBreakfast","followers_url":"https://api.github.com/users/MajorBreakfast/followers","following_url":"https://api.github.com/users/MajorBreakfast/following{/other_user}","gists_url":"https://api.github.com/users/MajorBreakfast/gists{/gist_id}","starred_url":"https://api.github.com/users/MajorBreakfast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MajorBreakfast/subscriptions","organizations_url":"https://api.github.com/users/MajorBreakfast/orgs","repos_url":"https://api.github.com/users/MajorBreakfast/repos","events_url":"https://api.github.com/users/MajorBreakfast/events{/privacy}","received_events_url":"https://api.github.com/users/MajorBreakfast/received_events","type":"User","site_admin":false},"body":"missing trailing comma","created_at":"2018-07-21T17:55:14Z","updated_at":"2018-07-21T17:55:14Z","html_url":"https://github.com/rust-lang-nursery/futures-rs/pull/1112#discussion_r204217108","pull_request_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/pulls/1112","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/rust-lang-nursery/futures-rs/pulls/comments/204217108"},"html":{"href":"https://github.com/rust-lang-nursery/futures-rs/pull/1112#discussion_r204217108"},"pull_request":{"href":"https://api.github.com/repos/rust-lang-nursery/futures-rs/pulls/1112"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/pulls/1112","id":203018716,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMDE4NzE2","html_url":"https://github.com/rust-lang-nursery/futures-rs/pull/1112","diff_url":"https://github.com/rust-lang-nursery/futures-rs/pull/1112.diff","patch_url":"https://github.com/rust-lang-nursery/futures-rs/pull/1112.patch","issue_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/issues/1112","number":1112,"state":"open","locked":false,"title":"100% Clippy","user":{"login":"Nemo157","id":81079,"node_id":"MDQ6VXNlcjgxMDc5","avatar_url":"https://avatars1.githubusercontent.com/u/81079?v=4","gravatar_id":"","url":"https://api.github.com/users/Nemo157","html_url":"https://github.com/Nemo157","followers_url":"https://api.github.com/users/Nemo157/followers","following_url":"https://api.github.com/users/Nemo157/following{/other_user}","gists_url":"https://api.github.com/users/Nemo157/gists{/gist_id}","starred_url":"https://api.github.com/users/Nemo157/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nemo157/subscriptions","organizations_url":"https://api.github.com/users/Nemo157/orgs","repos_url":"https://api.github.com/users/Nemo157/repos","events_url":"https://api.github.com/users/Nemo157/events{/privacy}","received_events_url":"https://api.github.com/users/Nemo157/received_events","type":"User","site_admin":false},"body":"I think merging all these changes is only worth it if we start gating CI on Clippy, otherwise the buggy allows should be dropped (just means dropping the last 2 commits). ~~With this and #1111 the deny warnings job could be changed to `cargo clippy -- -D warnings` and hit all builtin + Clippy warnings on all the crates at once.~~ (EDIT: Done since #1111 is merged)\r\n\r\nI think the `needless_lifetimes` one could be fixed in Clippy relatively easily, presumably it just doesn't support `arbitrary_self_types` properly. The `redundant_closures` one seems like it won't be able to get a fix soon, it would need Clippy to somehow detect side-effect producing code.\r\n\r\nI'm opening this mostly for discussion on whether gating CI on Clippy is of interest to the team. If it is then I might take a look at doing the upstream fixes to reduce the bad parts of this.","created_at":"2018-07-21T17:17:19Z","updated_at":"2018-07-21T17:55:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae909719f9bc1295c6a6428f2ac647393eacec00","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/pulls/1112/commits","review_comments_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/pulls/1112/comments","review_comment_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/issues/1112/comments","statuses_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/statuses/144acf908f4832999a8b2b23f4b5c31ece047249","head":{"label":"Nemo157:clippy","ref":"clippy","sha":"144acf908f4832999a8b2b23f4b5c31ece047249","user":{"login":"Nemo157","id":81079,"node_id":"MDQ6VXNlcjgxMDc5","avatar_url":"https://avatars1.githubusercontent.com/u/81079?v=4","gravatar_id":"","url":"https://api.github.com/users/Nemo157","html_url":"https://github.com/Nemo157","followers_url":"https://api.github.com/users/Nemo157/followers","following_url":"https://api.github.com/users/Nemo157/following{/other_user}","gists_url":"https://api.github.com/users/Nemo157/gists{/gist_id}","starred_url":"https://api.github.com/users/Nemo157/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nemo157/subscriptions","organizations_url":"https://api.github.com/users/Nemo157/orgs","repos_url":"https://api.github.com/users/Nemo157/repos","events_url":"https://api.github.com/users/Nemo157/events{/privacy}","received_events_url":"https://api.github.com/users/Nemo157/received_events","type":"User","site_admin":false},"repo":{"id":123557266,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM1NTcyNjY=","name":"futures-rs","full_name":"Nemo157/futures-rs","owner":{"login":"Nemo157","id":81079,"node_id":"MDQ6VXNlcjgxMDc5","avatar_url":"https://avatars1.githubusercontent.com/u/81079?v=4","gravatar_id":"","url":"https://api.github.com/users/Nemo157","html_url":"https://github.com/Nemo157","followers_url":"https://api.github.com/users/Nemo157/followers","following_url":"https://api.github.com/users/Nemo157/following{/other_user}","gists_url":"https://api.github.com/users/Nemo157/gists{/gist_id}","starred_url":"https://api.github.com/users/Nemo157/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nemo157/subscriptions","organizations_url":"https://api.github.com/users/Nemo157/orgs","repos_url":"https://api.github.com/users/Nemo157/repos","events_url":"https://api.github.com/users/Nemo157/events{/privacy}","received_events_url":"https://api.github.com/users/Nemo157/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Nemo157/futures-rs","description":"Zero-cost futures and streams in Rust","fork":true,"url":"https://api.github.com/repos/Nemo157/futures-rs","forks_url":"https://api.github.com/repos/Nemo157/futures-rs/forks","keys_url":"https://api.github.com/repos/Nemo157/futures-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Nemo157/futures-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Nemo157/futures-rs/teams","hooks_url":"https://api.github.com/repos/Nemo157/futures-rs/hooks","issue_events_url":"https://api.github.com/repos/Nemo157/futures-rs/issues/events{/number}","events_url":"https://api.github.com/repos/Nemo157/futures-rs/events","assignees_url":"https://api.github.com/repos/Nemo157/futures-rs/assignees{/user}","branches_url":"https://api.github.com/repos/Nemo157/futures-rs/branches{/branch}","tags_url":"https://api.github.com/repos/Nemo157/futures-rs/tags","blobs_url":"https://api.github.com/repos/Nemo157/futures-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Nemo157/futures-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Nemo157/futures-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Nemo157/futures-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Nemo157/futures-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/Nemo157/futures-rs/languages","stargazers_url":"https://api.github.com/repos/Nemo157/futures-rs/stargazers","contributors_url":"https://api.github.com/repos/Nemo157/futures-rs/contributors","subscribers_url":"https://api.github.com/repos/Nemo157/futures-rs/subscribers","subscription_url":"https://api.github.com/repos/Nemo157/futures-rs/subscription","commits_url":"https://api.github.com/repos/Nemo157/futures-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Nemo157/futures-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Nemo157/futures-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Nemo157/futures-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Nemo157/futures-rs/contents/{+path}","compare_url":"https://api.github.com/repos/Nemo157/futures-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Nemo157/futures-rs/merges","archive_url":"https://api.github.com/repos/Nemo157/futures-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Nemo157/futures-rs/downloads","issues_url":"https://api.github.com/repos/Nemo157/futures-rs/issues{/number}","pulls_url":"https://api.github.com/repos/Nemo157/futures-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/Nemo157/futures-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/Nemo157/futures-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Nemo157/futures-rs/labels{/name}","releases_url":"https://api.github.com/repos/Nemo157/futures-rs/releases{/id}","deployments_url":"https://api.github.com/repos/Nemo157/futures-rs/deployments","created_at":"2018-03-02T09:10:30Z","updated_at":"2018-04-03T15:42:34Z","pushed_at":"2018-07-21T17:30:51Z","git_url":"git://github.com/Nemo157/futures-rs.git","ssh_url":"git@github.com:Nemo157/futures-rs.git","clone_url":"https://github.com/Nemo157/futures-rs.git","svn_url":"https://github.com/Nemo157/futures-rs","homepage":"https://docs.rs/futures","size":11859,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang-nursery:master","ref":"master","sha":"910eaccff8da50bc9da989f0bd5babcdbf1ed2c1","user":{"login":"rust-lang-nursery","id":14631425,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0NjMxNDI1","avatar_url":"https://avatars1.githubusercontent.com/u/14631425?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang-nursery","html_url":"https://github.com/rust-lang-nursery","followers_url":"https://api.github.com/users/rust-lang-nursery/followers","following_url":"https://api.github.com/users/rust-lang-nursery/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang-nursery/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang-nursery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang-nursery/subscriptions","organizations_url":"https://api.github.com/users/rust-lang-nursery/orgs","repos_url":"https://api.github.com/users/rust-lang-nursery/repos","events_url":"https://api.github.com/users/rust-lang-nursery/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang-nursery/received_events","type":"Organization","site_admin":false},"repo":{"id":55077261,"node_id":"MDEwOlJlcG9zaXRvcnk1NTA3NzI2MQ==","name":"futures-rs","full_name":"rust-lang-nursery/futures-rs","owner":{"login":"rust-lang-nursery","id":14631425,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0NjMxNDI1","avatar_url":"https://avatars1.githubusercontent.com/u/14631425?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang-nursery","html_url":"https://github.com/rust-lang-nursery","followers_url":"https://api.github.com/users/rust-lang-nursery/followers","following_url":"https://api.github.com/users/rust-lang-nursery/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang-nursery/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang-nursery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang-nursery/subscriptions","organizations_url":"https://api.github.com/users/rust-lang-nursery/orgs","repos_url":"https://api.github.com/users/rust-lang-nursery/repos","events_url":"https://api.github.com/users/rust-lang-nursery/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang-nursery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang-nursery/futures-rs","description":"Zero-cost futures and streams in Rust","fork":false,"url":"https://api.github.com/repos/rust-lang-nursery/futures-rs","forks_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/forks","keys_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/teams","hooks_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/hooks","issue_events_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/events","assignees_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/tags","blobs_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/languages","stargazers_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/stargazers","contributors_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/contributors","subscribers_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/subscribers","subscription_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/subscription","commits_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/merges","archive_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/downloads","issues_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/deployments","created_at":"2016-03-30T16:03:08Z","updated_at":"2018-07-21T17:28:14Z","pushed_at":"2018-07-21T17:30:52Z","git_url":"git://github.com/rust-lang-nursery/futures-rs.git","ssh_url":"git@github.com:rust-lang-nursery/futures-rs.git","clone_url":"https://github.com/rust-lang-nursery/futures-rs.git","svn_url":"https://github.com/rust-lang-nursery/futures-rs","homepage":"https://docs.rs/futures","size":9332,"stargazers_count":2085,"watchers_count":2085,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":249,"mirror_url":null,"archived":false,"open_issues_count":92,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":249,"open_issues":92,"watchers":2085,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang-nursery/futures-rs/pulls/1112"},"html":{"href":"https://github.com/rust-lang-nursery/futures-rs/pull/1112"},"issue":{"href":"https://api.github.com/repos/rust-lang-nursery/futures-rs/issues/1112"},"comments":{"href":"https://api.github.com/repos/rust-lang-nursery/futures-rs/issues/1112/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang-nursery/futures-rs/pulls/1112/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang-nursery/futures-rs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang-nursery/futures-rs/pulls/1112/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang-nursery/futures-rs/statuses/144acf908f4832999a8b2b23f4b5c31ece047249"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"MajorBreakfast"}}