{"push_id":2577405246,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"47b003a828fe98e12947ba98e819ec4e617deef1","before":"c0fe8d6f6942f5cbc93c09825e803ba8cf950522","commits":[{"sha":"47b003a828fe98e12947ba98e819ec4e617deef1","author":{"name":"Dan Abramov","email":"ffbbe9cb1097e7ea6a3dedffde5b4fe769829acc@gmail.com"},"message":"Resolve host configs at build time (#12792)\n\n* Extract base Jest config\r\n\r\nThis makes it easier to change the source config without affecting the build test config.\r\n\r\n* Statically import the host config\r\n\r\nThis changes react-reconciler to import HostConfig instead of getting it through a function argument.\r\n\r\nRather than start with packages like ReactDOM that want to inline it, I started with React Noop and ensured that *custom* renderers using react-reconciler package still work. To do this, I'm making HostConfig module in the reconciler look at a global variable by default (which, in case of the react-reconciler npm package, ends up being the host config argument in the top-level scope).\r\n\r\nThis is still very broken.\r\n\r\n* Add scaffolding for importing an inlined renderer\r\n\r\n* Fix the build\r\n\r\n* ES exports for renderer methods\r\n\r\n* ES modules for host configs\r\n\r\n* Remove closures from the reconciler\r\n\r\n* Check each renderer's config with Flow\r\n\r\n* Fix uncovered Flow issue\r\n\r\nWe know nextHydratableInstance doesn't get mutated inside this function, but Flow doesn't so it thinks it may be null.\r\nHelp Flow.\r\n\r\n* Prettier\r\n\r\n* Get rid of enable*Reconciler flags\r\n\r\nThey are not as useful anymore because for almost all cases (except third party renderers) we *know* whether it supports mutation or persistence.\r\n\r\nThis refactoring means react-reconciler and react-reconciler/persistent third-party packages now ship the same thing.\r\nNot ideal, but this seems worth how simpler the code becomes. We can later look into addressing it by having a single toggle instead.\r\n\r\n* Prettier again\r\n\r\n* Fix Flow config creation issue\r\n\r\n* Fix imprecise Flow typing\r\n\r\n* Revert accidental changes","distinct":true,"url":"https://api.github.com/repos/facebook/react/commits/47b003a828fe98e12947ba98e819ec4e617deef1"}]}
{"actor":{"display_login":"gaearon"}}