{"action":"created","comment":{"url":"https://api.github.com/repos/pk-otus/03_allocator/pulls/comments/211108514","pull_request_review_id":145527331,"id":211108514,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTEwODUxNA==","diff_hunk":"@@ -6,10 +6,12 @@ else()\n    project(allocator VERSION 0.0.1)\n endif()\n \n-configure_file(version.h.in ${PROJECT_SOURCE_DIR}/version.h)\n+file(GLOB HEADER_FILES ${PROJECT_SOURCE_DIR}/*.h)\n+list(REMOVE_ITEM HEADER_FILES ${PROJECT_SOURCE_DIR}/version.h)\n \n-add_executable(allocator main.cpp)\n+configure_file(version.h.in ${PROJECT_SOURCE_DIR}/version.h)","path":"CMakeLists.txt","position":null,"original_position":9,"commit_id":"5f0ece72170d21643e57fd80c8bafb28273ae295","original_commit_id":"5f0ece72170d21643e57fd80c8bafb28273ae295","user":{"login":"ithamsteri","id":208579,"node_id":"MDQ6VXNlcjIwODU3OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/208579?v=4","gravatar_id":"","url":"https://api.github.com/users/ithamsteri","html_url":"https://github.com/ithamsteri","followers_url":"https://api.github.com/users/ithamsteri/followers","following_url":"https://api.github.com/users/ithamsteri/following{/other_user}","gists_url":"https://api.github.com/users/ithamsteri/gists{/gist_id}","starred_url":"https://api.github.com/users/ithamsteri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ithamsteri/subscriptions","organizations_url":"https://api.github.com/users/ithamsteri/orgs","repos_url":"https://api.github.com/users/ithamsteri/repos","events_url":"https://api.github.com/users/ithamsteri/events{/privacy}","received_events_url":"https://api.github.com/users/ithamsteri/received_events","type":"User","site_admin":false},"body":"А нужен ли заголовочный файл `version.h`? В проекте он никак не задействован.","created_at":"2018-08-19T16:48:20Z","updated_at":"2018-08-19T16:55:58Z","html_url":"https://github.com/pk-otus/03_allocator/pull/1#discussion_r211108514","pull_request_url":"https://api.github.com/repos/pk-otus/03_allocator/pulls/1","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/pk-otus/03_allocator/pulls/comments/211108514"},"html":{"href":"https://github.com/pk-otus/03_allocator/pull/1#discussion_r211108514"},"pull_request":{"href":"https://api.github.com/repos/pk-otus/03_allocator/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/pk-otus/03_allocator/pulls/1","id":207516998,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NTE2OTk4","html_url":"https://github.com/pk-otus/03_allocator/pull/1","diff_url":"https://github.com/pk-otus/03_allocator/pull/1.diff","patch_url":"https://github.com/pk-otus/03_allocator/pull/1.patch","issue_url":"https://api.github.com/repos/pk-otus/03_allocator/issues/1","number":1,"state":"open","locked":false,"title":"Review homework 03","user":{"login":"pk-otus","id":40486625,"node_id":"MDQ6VXNlcjQwNDg2NjI1","avatar_url":"https://avatars3.githubusercontent.com/u/40486625?v=4","gravatar_id":"","url":"https://api.github.com/users/pk-otus","html_url":"https://github.com/pk-otus","followers_url":"https://api.github.com/users/pk-otus/followers","following_url":"https://api.github.com/users/pk-otus/following{/other_user}","gists_url":"https://api.github.com/users/pk-otus/gists{/gist_id}","starred_url":"https://api.github.com/users/pk-otus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pk-otus/subscriptions","organizations_url":"https://api.github.com/users/pk-otus/orgs","repos_url":"https://api.github.com/users/pk-otus/repos","events_url":"https://api.github.com/users/pk-otus/events{/privacy}","received_events_url":"https://api.github.com/users/pk-otus/received_events","type":"User","site_admin":false},"body":"This reverts commit 4bbaf0952eced7c444837c8ba08a437fb9be923b.\r\n\r\n Changes to be committed:\r\n\tnew file:   CMakeLists.txt\r\n\tnew file:   allocator_buffer.h\r\n\tnew file:   custom_container.h\r\n\tnew file:   main.cpp\r\n\tnew file:   ndebug.h\r\n\tnew file:   reserving_allocator.h\r\n\tnew file:   version.h.in","created_at":"2018-08-10T06:20:25Z","updated_at":"2018-08-19T16:55:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5633c04bfb1cd888855f93424bd7cda17cca98fc","assignee":{"login":"pk-otus","id":40486625,"node_id":"MDQ6VXNlcjQwNDg2NjI1","avatar_url":"https://avatars3.githubusercontent.com/u/40486625?v=4","gravatar_id":"","url":"https://api.github.com/users/pk-otus","html_url":"https://github.com/pk-otus","followers_url":"https://api.github.com/users/pk-otus/followers","following_url":"https://api.github.com/users/pk-otus/following{/other_user}","gists_url":"https://api.github.com/users/pk-otus/gists{/gist_id}","starred_url":"https://api.github.com/users/pk-otus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pk-otus/subscriptions","organizations_url":"https://api.github.com/users/pk-otus/orgs","repos_url":"https://api.github.com/users/pk-otus/repos","events_url":"https://api.github.com/users/pk-otus/events{/privacy}","received_events_url":"https://api.github.com/users/pk-otus/received_events","type":"User","site_admin":false},"assignees":[{"login":"pk-otus","id":40486625,"node_id":"MDQ6VXNlcjQwNDg2NjI1","avatar_url":"https://avatars3.githubusercontent.com/u/40486625?v=4","gravatar_id":"","url":"https://api.github.com/users/pk-otus","html_url":"https://github.com/pk-otus","followers_url":"https://api.github.com/users/pk-otus/followers","following_url":"https://api.github.com/users/pk-otus/following{/other_user}","gists_url":"https://api.github.com/users/pk-otus/gists{/gist_id}","starred_url":"https://api.github.com/users/pk-otus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pk-otus/subscriptions","organizations_url":"https://api.github.com/users/pk-otus/orgs","repos_url":"https://api.github.com/users/pk-otus/repos","events_url":"https://api.github.com/users/pk-otus/events{/privacy}","received_events_url":"https://api.github.com/users/pk-otus/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pk-otus/03_allocator/pulls/1/commits","review_comments_url":"https://api.github.com/repos/pk-otus/03_allocator/pulls/1/comments","review_comment_url":"https://api.github.com/repos/pk-otus/03_allocator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pk-otus/03_allocator/issues/1/comments","statuses_url":"https://api.github.com/repos/pk-otus/03_allocator/statuses/5f0ece72170d21643e57fd80c8bafb28273ae295","head":{"label":"pk-otus:review1","ref":"review1","sha":"5f0ece72170d21643e57fd80c8bafb28273ae295","user":{"login":"pk-otus","id":40486625,"node_id":"MDQ6VXNlcjQwNDg2NjI1","avatar_url":"https://avatars3.githubusercontent.com/u/40486625?v=4","gravatar_id":"","url":"https://api.github.com/users/pk-otus","html_url":"https://github.com/pk-otus","followers_url":"https://api.github.com/users/pk-otus/followers","following_url":"https://api.github.com/users/pk-otus/following{/other_user}","gists_url":"https://api.github.com/users/pk-otus/gists{/gist_id}","starred_url":"https://api.github.com/users/pk-otus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pk-otus/subscriptions","organizations_url":"https://api.github.com/users/pk-otus/orgs","repos_url":"https://api.github.com/users/pk-otus/repos","events_url":"https://api.github.com/users/pk-otus/events{/privacy}","received_events_url":"https://api.github.com/users/pk-otus/received_events","type":"User","site_admin":false},"repo":{"id":143302443,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMzMDI0NDM=","name":"03_allocator","full_name":"pk-otus/03_allocator","owner":{"login":"pk-otus","id":40486625,"node_id":"MDQ6VXNlcjQwNDg2NjI1","avatar_url":"https://avatars3.githubusercontent.com/u/40486625?v=4","gravatar_id":"","url":"https://api.github.com/users/pk-otus","html_url":"https://github.com/pk-otus","followers_url":"https://api.github.com/users/pk-otus/followers","following_url":"https://api.github.com/users/pk-otus/following{/other_user}","gists_url":"https://api.github.com/users/pk-otus/gists{/gist_id}","starred_url":"https://api.github.com/users/pk-otus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pk-otus/subscriptions","organizations_url":"https://api.github.com/users/pk-otus/orgs","repos_url":"https://api.github.com/users/pk-otus/repos","events_url":"https://api.github.com/users/pk-otus/events{/privacy}","received_events_url":"https://api.github.com/users/pk-otus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pk-otus/03_allocator","description":null,"fork":false,"url":"https://api.github.com/repos/pk-otus/03_allocator","forks_url":"https://api.github.com/repos/pk-otus/03_allocator/forks","keys_url":"https://api.github.com/repos/pk-otus/03_allocator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pk-otus/03_allocator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pk-otus/03_allocator/teams","hooks_url":"https://api.github.com/repos/pk-otus/03_allocator/hooks","issue_events_url":"https://api.github.com/repos/pk-otus/03_allocator/issues/events{/number}","events_url":"https://api.github.com/repos/pk-otus/03_allocator/events","assignees_url":"https://api.github.com/repos/pk-otus/03_allocator/assignees{/user}","branches_url":"https://api.github.com/repos/pk-otus/03_allocator/branches{/branch}","tags_url":"https://api.github.com/repos/pk-otus/03_allocator/tags","blobs_url":"https://api.github.com/repos/pk-otus/03_allocator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pk-otus/03_allocator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pk-otus/03_allocator/git/refs{/sha}","trees_url":"https://api.github.com/repos/pk-otus/03_allocator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pk-otus/03_allocator/statuses/{sha}","languages_url":"https://api.github.com/repos/pk-otus/03_allocator/languages","stargazers_url":"https://api.github.com/repos/pk-otus/03_allocator/stargazers","contributors_url":"https://api.github.com/repos/pk-otus/03_allocator/contributors","subscribers_url":"https://api.github.com/repos/pk-otus/03_allocator/subscribers","subscription_url":"https://api.github.com/repos/pk-otus/03_allocator/subscription","commits_url":"https://api.github.com/repos/pk-otus/03_allocator/commits{/sha}","git_commits_url":"https://api.github.com/repos/pk-otus/03_allocator/git/commits{/sha}","comments_url":"https://api.github.com/repos/pk-otus/03_allocator/comments{/number}","issue_comment_url":"https://api.github.com/repos/pk-otus/03_allocator/issues/comments{/number}","contents_url":"https://api.github.com/repos/pk-otus/03_allocator/contents/{+path}","compare_url":"https://api.github.com/repos/pk-otus/03_allocator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pk-otus/03_allocator/merges","archive_url":"https://api.github.com/repos/pk-otus/03_allocator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pk-otus/03_allocator/downloads","issues_url":"https://api.github.com/repos/pk-otus/03_allocator/issues{/number}","pulls_url":"https://api.github.com/repos/pk-otus/03_allocator/pulls{/number}","milestones_url":"https://api.github.com/repos/pk-otus/03_allocator/milestones{/number}","notifications_url":"https://api.github.com/repos/pk-otus/03_allocator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pk-otus/03_allocator/labels{/name}","releases_url":"https://api.github.com/repos/pk-otus/03_allocator/releases{/id}","deployments_url":"https://api.github.com/repos/pk-otus/03_allocator/deployments","created_at":"2018-08-02T14:01:13Z","updated_at":"2018-08-10T06:18:30Z","pushed_at":"2018-08-17T07:22:53Z","git_url":"git://github.com/pk-otus/03_allocator.git","ssh_url":"git@github.com:pk-otus/03_allocator.git","clone_url":"https://github.com/pk-otus/03_allocator.git","svn_url":"https://github.com/pk-otus/03_allocator","homepage":null,"size":8,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"pk-otus:master","ref":"master","sha":"000cf0b37622e4bb1f921c46f47dc68a4fb266a6","user":{"login":"pk-otus","id":40486625,"node_id":"MDQ6VXNlcjQwNDg2NjI1","avatar_url":"https://avatars3.githubusercontent.com/u/40486625?v=4","gravatar_id":"","url":"https://api.github.com/users/pk-otus","html_url":"https://github.com/pk-otus","followers_url":"https://api.github.com/users/pk-otus/followers","following_url":"https://api.github.com/users/pk-otus/following{/other_user}","gists_url":"https://api.github.com/users/pk-otus/gists{/gist_id}","starred_url":"https://api.github.com/users/pk-otus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pk-otus/subscriptions","organizations_url":"https://api.github.com/users/pk-otus/orgs","repos_url":"https://api.github.com/users/pk-otus/repos","events_url":"https://api.github.com/users/pk-otus/events{/privacy}","received_events_url":"https://api.github.com/users/pk-otus/received_events","type":"User","site_admin":false},"repo":{"id":143302443,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMzMDI0NDM=","name":"03_allocator","full_name":"pk-otus/03_allocator","owner":{"login":"pk-otus","id":40486625,"node_id":"MDQ6VXNlcjQwNDg2NjI1","avatar_url":"https://avatars3.githubusercontent.com/u/40486625?v=4","gravatar_id":"","url":"https://api.github.com/users/pk-otus","html_url":"https://github.com/pk-otus","followers_url":"https://api.github.com/users/pk-otus/followers","following_url":"https://api.github.com/users/pk-otus/following{/other_user}","gists_url":"https://api.github.com/users/pk-otus/gists{/gist_id}","starred_url":"https://api.github.com/users/pk-otus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pk-otus/subscriptions","organizations_url":"https://api.github.com/users/pk-otus/orgs","repos_url":"https://api.github.com/users/pk-otus/repos","events_url":"https://api.github.com/users/pk-otus/events{/privacy}","received_events_url":"https://api.github.com/users/pk-otus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pk-otus/03_allocator","description":null,"fork":false,"url":"https://api.github.com/repos/pk-otus/03_allocator","forks_url":"https://api.github.com/repos/pk-otus/03_allocator/forks","keys_url":"https://api.github.com/repos/pk-otus/03_allocator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pk-otus/03_allocator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pk-otus/03_allocator/teams","hooks_url":"https://api.github.com/repos/pk-otus/03_allocator/hooks","issue_events_url":"https://api.github.com/repos/pk-otus/03_allocator/issues/events{/number}","events_url":"https://api.github.com/repos/pk-otus/03_allocator/events","assignees_url":"https://api.github.com/repos/pk-otus/03_allocator/assignees{/user}","branches_url":"https://api.github.com/repos/pk-otus/03_allocator/branches{/branch}","tags_url":"https://api.github.com/repos/pk-otus/03_allocator/tags","blobs_url":"https://api.github.com/repos/pk-otus/03_allocator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pk-otus/03_allocator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pk-otus/03_allocator/git/refs{/sha}","trees_url":"https://api.github.com/repos/pk-otus/03_allocator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pk-otus/03_allocator/statuses/{sha}","languages_url":"https://api.github.com/repos/pk-otus/03_allocator/languages","stargazers_url":"https://api.github.com/repos/pk-otus/03_allocator/stargazers","contributors_url":"https://api.github.com/repos/pk-otus/03_allocator/contributors","subscribers_url":"https://api.github.com/repos/pk-otus/03_allocator/subscribers","subscription_url":"https://api.github.com/repos/pk-otus/03_allocator/subscription","commits_url":"https://api.github.com/repos/pk-otus/03_allocator/commits{/sha}","git_commits_url":"https://api.github.com/repos/pk-otus/03_allocator/git/commits{/sha}","comments_url":"https://api.github.com/repos/pk-otus/03_allocator/comments{/number}","issue_comment_url":"https://api.github.com/repos/pk-otus/03_allocator/issues/comments{/number}","contents_url":"https://api.github.com/repos/pk-otus/03_allocator/contents/{+path}","compare_url":"https://api.github.com/repos/pk-otus/03_allocator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pk-otus/03_allocator/merges","archive_url":"https://api.github.com/repos/pk-otus/03_allocator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pk-otus/03_allocator/downloads","issues_url":"https://api.github.com/repos/pk-otus/03_allocator/issues{/number}","pulls_url":"https://api.github.com/repos/pk-otus/03_allocator/pulls{/number}","milestones_url":"https://api.github.com/repos/pk-otus/03_allocator/milestones{/number}","notifications_url":"https://api.github.com/repos/pk-otus/03_allocator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pk-otus/03_allocator/labels{/name}","releases_url":"https://api.github.com/repos/pk-otus/03_allocator/releases{/id}","deployments_url":"https://api.github.com/repos/pk-otus/03_allocator/deployments","created_at":"2018-08-02T14:01:13Z","updated_at":"2018-08-10T06:18:30Z","pushed_at":"2018-08-17T07:22:53Z","git_url":"git://github.com/pk-otus/03_allocator.git","ssh_url":"git@github.com:pk-otus/03_allocator.git","clone_url":"https://github.com/pk-otus/03_allocator.git","svn_url":"https://github.com/pk-otus/03_allocator","homepage":null,"size":8,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pk-otus/03_allocator/pulls/1"},"html":{"href":"https://github.com/pk-otus/03_allocator/pull/1"},"issue":{"href":"https://api.github.com/repos/pk-otus/03_allocator/issues/1"},"comments":{"href":"https://api.github.com/repos/pk-otus/03_allocator/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/pk-otus/03_allocator/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/pk-otus/03_allocator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pk-otus/03_allocator/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/pk-otus/03_allocator/statuses/5f0ece72170d21643e57fd80c8bafb28273ae295"}},"author_association":"OWNER"}}
{"actor":{"display_login":"ithamsteri"}}