{"action":"created","comment":{"url":"https://api.github.com/repos/bloomberg/TypeScript/pulls/comments/228673822","pull_request_review_id":169010470,"id":228673822,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODY3MzgyMg==","diff_hunk":"@@ -4270,6 +4270,10 @@\n         \"category\": \"Error\",\r\n         \"code\": 18005\r\n     },\r\n+    \"Private names are not currently supported \": {\r","path":"src/compiler/diagnosticMessages.json","position":4,"original_position":4,"commit_id":"7a839c4955dc9f6219f129d68188b5e9be508bb4","original_commit_id":"7a839c4955dc9f6219f129d68188b5e9be508bb4","user":{"login":"joeywatts","id":980118,"node_id":"MDQ6VXNlcjk4MDExOA==","avatar_url":"https://avatars1.githubusercontent.com/u/980118?v=4","gravatar_id":"","url":"https://api.github.com/users/joeywatts","html_url":"https://github.com/joeywatts","followers_url":"https://api.github.com/users/joeywatts/followers","following_url":"https://api.github.com/users/joeywatts/following{/other_user}","gists_url":"https://api.github.com/users/joeywatts/gists{/gist_id}","starred_url":"https://api.github.com/users/joeywatts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeywatts/subscriptions","organizations_url":"https://api.github.com/users/joeywatts/orgs","repos_url":"https://api.github.com/users/joeywatts/repos","events_url":"https://api.github.com/users/joeywatts/events{/privacy}","received_events_url":"https://api.github.com/users/joeywatts/received_events","type":"User","site_admin":false},"body":"Do error messages typically end with punctuation? I noticed the one below ends with a period.","created_at":"2018-10-26T21:45:12Z","updated_at":"2018-10-26T21:56:57Z","html_url":"https://github.com/bloomberg/TypeScript/pull/12#discussion_r228673822","pull_request_url":"https://api.github.com/repos/bloomberg/TypeScript/pulls/12","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/bloomberg/TypeScript/pulls/comments/228673822"},"html":{"href":"https://github.com/bloomberg/TypeScript/pull/12#discussion_r228673822"},"pull_request":{"href":"https://api.github.com/repos/bloomberg/TypeScript/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/bloomberg/TypeScript/pulls/12","id":226230498,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MjMwNDk4","html_url":"https://github.com/bloomberg/TypeScript/pull/12","diff_url":"https://github.com/bloomberg/TypeScript/pull/12.diff","patch_url":"https://github.com/bloomberg/TypeScript/pull/12.patch","issue_url":"https://api.github.com/repos/bloomberg/TypeScript/issues/12","number":12,"state":"open","locked":false,"title":"Error on Private Names (for now)","user":{"login":"mheiber","id":4691093,"node_id":"MDQ6VXNlcjQ2OTEwOTM=","avatar_url":"https://avatars3.githubusercontent.com/u/4691093?v=4","gravatar_id":"","url":"https://api.github.com/users/mheiber","html_url":"https://github.com/mheiber","followers_url":"https://api.github.com/users/mheiber/followers","following_url":"https://api.github.com/users/mheiber/following{/other_user}","gists_url":"https://api.github.com/users/mheiber/gists{/gist_id}","starred_url":"https://api.github.com/users/mheiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mheiber/subscriptions","organizations_url":"https://api.github.com/users/mheiber/orgs","repos_url":"https://api.github.com/users/mheiber/repos","events_url":"https://api.github.com/users/mheiber/events{/privacy}","received_events_url":"https://api.github.com/users/mheiber/received_events","type":"User","site_admin":false},"body":"Issue diagnostic error for private names,\r\n\"Private names are not currently supported.\"\r\n\r\nThis is part of the strategy of working toward\r\ngetting feedback on the feature without including\r\nit in stable yet.\r\n\r\nSigned-off-by: Max Heiber <mheiber@bloomberg.net>","created_at":"2018-10-26T21:26:08Z","updated_at":"2018-10-26T21:56:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c13146e46c5f1da2c2cbd44ac93f246f3e57b81e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bloomberg/TypeScript/pulls/12/commits","review_comments_url":"https://api.github.com/repos/bloomberg/TypeScript/pulls/12/comments","review_comment_url":"https://api.github.com/repos/bloomberg/TypeScript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bloomberg/TypeScript/issues/12/comments","statuses_url":"https://api.github.com/repos/bloomberg/TypeScript/statuses/7a839c4955dc9f6219f129d68188b5e9be508bb4","head":{"label":"mheiber:parse-private-names-diagnostic","ref":"parse-private-names-diagnostic","sha":"7a839c4955dc9f6219f129d68188b5e9be508bb4","user":{"login":"mheiber","id":4691093,"node_id":"MDQ6VXNlcjQ2OTEwOTM=","avatar_url":"https://avatars3.githubusercontent.com/u/4691093?v=4","gravatar_id":"","url":"https://api.github.com/users/mheiber","html_url":"https://github.com/mheiber","followers_url":"https://api.github.com/users/mheiber/followers","following_url":"https://api.github.com/users/mheiber/following{/other_user}","gists_url":"https://api.github.com/users/mheiber/gists{/gist_id}","starred_url":"https://api.github.com/users/mheiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mheiber/subscriptions","organizations_url":"https://api.github.com/users/mheiber/orgs","repos_url":"https://api.github.com/users/mheiber/repos","events_url":"https://api.github.com/users/mheiber/events{/privacy}","received_events_url":"https://api.github.com/users/mheiber/received_events","type":"User","site_admin":false},"repo":{"id":139506977,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk1MDY5Nzc=","name":"TypeScript","full_name":"mheiber/TypeScript","private":false,"owner":{"login":"mheiber","id":4691093,"node_id":"MDQ6VXNlcjQ2OTEwOTM=","avatar_url":"https://avatars3.githubusercontent.com/u/4691093?v=4","gravatar_id":"","url":"https://api.github.com/users/mheiber","html_url":"https://github.com/mheiber","followers_url":"https://api.github.com/users/mheiber/followers","following_url":"https://api.github.com/users/mheiber/following{/other_user}","gists_url":"https://api.github.com/users/mheiber/gists{/gist_id}","starred_url":"https://api.github.com/users/mheiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mheiber/subscriptions","organizations_url":"https://api.github.com/users/mheiber/orgs","repos_url":"https://api.github.com/users/mheiber/repos","events_url":"https://api.github.com/users/mheiber/events{/privacy}","received_events_url":"https://api.github.com/users/mheiber/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mheiber/TypeScript","description":"TypeScript is a superset of JavaScript that compiles to clean JavaScript output.","fork":true,"url":"https://api.github.com/repos/mheiber/TypeScript","forks_url":"https://api.github.com/repos/mheiber/TypeScript/forks","keys_url":"https://api.github.com/repos/mheiber/TypeScript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mheiber/TypeScript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mheiber/TypeScript/teams","hooks_url":"https://api.github.com/repos/mheiber/TypeScript/hooks","issue_events_url":"https://api.github.com/repos/mheiber/TypeScript/issues/events{/number}","events_url":"https://api.github.com/repos/mheiber/TypeScript/events","assignees_url":"https://api.github.com/repos/mheiber/TypeScript/assignees{/user}","branches_url":"https://api.github.com/repos/mheiber/TypeScript/branches{/branch}","tags_url":"https://api.github.com/repos/mheiber/TypeScript/tags","blobs_url":"https://api.github.com/repos/mheiber/TypeScript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mheiber/TypeScript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mheiber/TypeScript/git/refs{/sha}","trees_url":"https://api.github.com/repos/mheiber/TypeScript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mheiber/TypeScript/statuses/{sha}","languages_url":"https://api.github.com/repos/mheiber/TypeScript/languages","stargazers_url":"https://api.github.com/repos/mheiber/TypeScript/stargazers","contributors_url":"https://api.github.com/repos/mheiber/TypeScript/contributors","subscribers_url":"https://api.github.com/repos/mheiber/TypeScript/subscribers","subscription_url":"https://api.github.com/repos/mheiber/TypeScript/subscription","commits_url":"https://api.github.com/repos/mheiber/TypeScript/commits{/sha}","git_commits_url":"https://api.github.com/repos/mheiber/TypeScript/git/commits{/sha}","comments_url":"https://api.github.com/repos/mheiber/TypeScript/comments{/number}","issue_comment_url":"https://api.github.com/repos/mheiber/TypeScript/issues/comments{/number}","contents_url":"https://api.github.com/repos/mheiber/TypeScript/contents/{+path}","compare_url":"https://api.github.com/repos/mheiber/TypeScript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mheiber/TypeScript/merges","archive_url":"https://api.github.com/repos/mheiber/TypeScript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mheiber/TypeScript/downloads","issues_url":"https://api.github.com/repos/mheiber/TypeScript/issues{/number}","pulls_url":"https://api.github.com/repos/mheiber/TypeScript/pulls{/number}","milestones_url":"https://api.github.com/repos/mheiber/TypeScript/milestones{/number}","notifications_url":"https://api.github.com/repos/mheiber/TypeScript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mheiber/TypeScript/labels{/name}","releases_url":"https://api.github.com/repos/mheiber/TypeScript/releases{/id}","deployments_url":"https://api.github.com/repos/mheiber/TypeScript/deployments","created_at":"2018-07-03T00:03:06Z","updated_at":"2018-07-03T00:03:26Z","pushed_at":"2018-10-26T21:25:34Z","git_url":"git://github.com/mheiber/TypeScript.git","ssh_url":"git@github.com:mheiber/TypeScript.git","clone_url":"https://github.com/mheiber/TypeScript.git","svn_url":"https://github.com/mheiber/TypeScript","homepage":"http://www.typescriptlang.org","size":820033,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":0,"open_issues":4,"watchers":0,"default_branch":"purpose"}},"base":{"label":"bloomberg:es-private-fields","ref":"es-private-fields","sha":"853486f13620b1fe9c11e77aad300327aff5c034","user":{"login":"bloomberg","id":1416818,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTY4MTg=","avatar_url":"https://avatars2.githubusercontent.com/u/1416818?v=4","gravatar_id":"","url":"https://api.github.com/users/bloomberg","html_url":"https://github.com/bloomberg","followers_url":"https://api.github.com/users/bloomberg/followers","following_url":"https://api.github.com/users/bloomberg/following{/other_user}","gists_url":"https://api.github.com/users/bloomberg/gists{/gist_id}","starred_url":"https://api.github.com/users/bloomberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bloomberg/subscriptions","organizations_url":"https://api.github.com/users/bloomberg/orgs","repos_url":"https://api.github.com/users/bloomberg/repos","events_url":"https://api.github.com/users/bloomberg/events{/privacy}","received_events_url":"https://api.github.com/users/bloomberg/received_events","type":"Organization","site_admin":false},"repo":{"id":138790476,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg3OTA0NzY=","name":"TypeScript","full_name":"bloomberg/TypeScript","private":false,"owner":{"login":"bloomberg","id":1416818,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTY4MTg=","avatar_url":"https://avatars2.githubusercontent.com/u/1416818?v=4","gravatar_id":"","url":"https://api.github.com/users/bloomberg","html_url":"https://github.com/bloomberg","followers_url":"https://api.github.com/users/bloomberg/followers","following_url":"https://api.github.com/users/bloomberg/following{/other_user}","gists_url":"https://api.github.com/users/bloomberg/gists{/gist_id}","starred_url":"https://api.github.com/users/bloomberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bloomberg/subscriptions","organizations_url":"https://api.github.com/users/bloomberg/orgs","repos_url":"https://api.github.com/users/bloomberg/repos","events_url":"https://api.github.com/users/bloomberg/events{/privacy}","received_events_url":"https://api.github.com/users/bloomberg/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bloomberg/TypeScript","description":"TypeScript is a superset of JavaScript that compiles to clean JavaScript output.","fork":true,"url":"https://api.github.com/repos/bloomberg/TypeScript","forks_url":"https://api.github.com/repos/bloomberg/TypeScript/forks","keys_url":"https://api.github.com/repos/bloomberg/TypeScript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bloomberg/TypeScript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bloomberg/TypeScript/teams","hooks_url":"https://api.github.com/repos/bloomberg/TypeScript/hooks","issue_events_url":"https://api.github.com/repos/bloomberg/TypeScript/issues/events{/number}","events_url":"https://api.github.com/repos/bloomberg/TypeScript/events","assignees_url":"https://api.github.com/repos/bloomberg/TypeScript/assignees{/user}","branches_url":"https://api.github.com/repos/bloomberg/TypeScript/branches{/branch}","tags_url":"https://api.github.com/repos/bloomberg/TypeScript/tags","blobs_url":"https://api.github.com/repos/bloomberg/TypeScript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bloomberg/TypeScript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bloomberg/TypeScript/git/refs{/sha}","trees_url":"https://api.github.com/repos/bloomberg/TypeScript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bloomberg/TypeScript/statuses/{sha}","languages_url":"https://api.github.com/repos/bloomberg/TypeScript/languages","stargazers_url":"https://api.github.com/repos/bloomberg/TypeScript/stargazers","contributors_url":"https://api.github.com/repos/bloomberg/TypeScript/contributors","subscribers_url":"https://api.github.com/repos/bloomberg/TypeScript/subscribers","subscription_url":"https://api.github.com/repos/bloomberg/TypeScript/subscription","commits_url":"https://api.github.com/repos/bloomberg/TypeScript/commits{/sha}","git_commits_url":"https://api.github.com/repos/bloomberg/TypeScript/git/commits{/sha}","comments_url":"https://api.github.com/repos/bloomberg/TypeScript/comments{/number}","issue_comment_url":"https://api.github.com/repos/bloomberg/TypeScript/issues/comments{/number}","contents_url":"https://api.github.com/repos/bloomberg/TypeScript/contents/{+path}","compare_url":"https://api.github.com/repos/bloomberg/TypeScript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bloomberg/TypeScript/merges","archive_url":"https://api.github.com/repos/bloomberg/TypeScript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bloomberg/TypeScript/downloads","issues_url":"https://api.github.com/repos/bloomberg/TypeScript/issues{/number}","pulls_url":"https://api.github.com/repos/bloomberg/TypeScript/pulls{/number}","milestones_url":"https://api.github.com/repos/bloomberg/TypeScript/milestones{/number}","notifications_url":"https://api.github.com/repos/bloomberg/TypeScript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bloomberg/TypeScript/labels{/name}","releases_url":"https://api.github.com/repos/bloomberg/TypeScript/releases{/id}","deployments_url":"https://api.github.com/repos/bloomberg/TypeScript/deployments","created_at":"2018-06-26T20:36:12Z","updated_at":"2018-09-26T07:44:47Z","pushed_at":"2018-10-26T21:26:08Z","git_url":"git://github.com/bloomberg/TypeScript.git","ssh_url":"git@github.com:bloomberg/TypeScript.git","clone_url":"https://github.com/bloomberg/TypeScript.git","svn_url":"https://github.com/bloomberg/TypeScript","homepage":"http://www.typescriptlang.org","size":825858,"stargazers_count":5,"watchers_count":5,"language":null,"has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":7,"license":null,"forks":6,"open_issues":7,"watchers":5,"default_branch":"purpose"}},"_links":{"self":{"href":"https://api.github.com/repos/bloomberg/TypeScript/pulls/12"},"html":{"href":"https://github.com/bloomberg/TypeScript/pull/12"},"issue":{"href":"https://api.github.com/repos/bloomberg/TypeScript/issues/12"},"comments":{"href":"https://api.github.com/repos/bloomberg/TypeScript/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/bloomberg/TypeScript/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/bloomberg/TypeScript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bloomberg/TypeScript/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/bloomberg/TypeScript/statuses/7a839c4955dc9f6219f129d68188b5e9be508bb4"}},"author_association":"NONE"}}
{"actor":{"display_login":"joeywatts"}}