{"action":"created","comment":{"url":"https://api.github.com/repos/ninamiolane/geomstats/pulls/comments/169401175","pull_request_review_id":97921277,"id":169401175,"diff_hunk":"@@ -153,20 +180,34 @@ def plot(points, ax=None, space=None, **point_draw_kwargs):\n                     'The plot function is not implemented'\n                     ' for the space {}.'.format(space))\n \n-        ax = plt.subplot(111, projection=\"3d\", aspect=\"equal\")\n-        plt.setp(ax,\n-                 xlim=(-ax_s, ax_s),\n-                 ylim=(-ax_s, ax_s),\n-                 zlim=(-ax_s, ax_s),\n-                 xlabel=\"X\", ylabel=\"Y\", zlabel=\"Z\")\n+        if space is 'H2':\n+            ax = plt.subplot(aspect='equal')\n+            plt.setp(ax,\n+                     xlim=(-ax_s, ax_s),\n+                     ylim=(-ax_s, ax_s),\n+                     xlabel='X', ylabel='Y')\n+\n+        else:\n+            ax = plt.subplot(111, projection='3d', aspect='equal')\n+            plt.setp(ax,\n+                     xlim=(-ax_s, ax_s),\n+                     ylim=(-ax_s, ax_s),\n+                     zlim=(-ax_s, ax_s),\n+                     xlabel='X', ylabel='Y', zlabel='Z')\n \n     if space in ('SO3_GROUP', 'SE3_GROUP'):\n         trihedrons = convert_to_trihedron(points, space=space)\n         for t in trihedrons:\n             t.draw(ax, **point_draw_kwargs)\n+\n     elif space is 'S2':\n         sphere = Sphere()\n         sphere.add_points(points)\n         sphere.draw(ax)\n \n+    elif space is 'H2':","path":"geomstats/visualization.py","position":110,"original_position":110,"commit_id":"2a609064125ffd762ed106fb2e4c8c905c340a51","original_commit_id":"2a609064125ffd762ed106fb2e4c8c905c340a51","user":{"login":"johmathe","id":467643,"avatar_url":"https://avatars2.githubusercontent.com/u/467643?v=4","gravatar_id":"","url":"https://api.github.com/users/johmathe","html_url":"https://github.com/johmathe","followers_url":"https://api.github.com/users/johmathe/followers","following_url":"https://api.github.com/users/johmathe/following{/other_user}","gists_url":"https://api.github.com/users/johmathe/gists{/gist_id}","starred_url":"https://api.github.com/users/johmathe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johmathe/subscriptions","organizations_url":"https://api.github.com/users/johmathe/orgs","repos_url":"https://api.github.com/users/johmathe/repos","events_url":"https://api.github.com/users/johmathe/events{/privacy}","received_events_url":"https://api.github.com/users/johmathe/received_events","type":"User","site_admin":false},"body":"are you raising some ValueError if space is not in the 4 possibilities that you're passing?","created_at":"2018-02-20T17:43:31Z","updated_at":"2018-02-20T17:43:47Z","html_url":"https://github.com/ninamiolane/geomstats/pull/23#discussion_r169401175","pull_request_url":"https://api.github.com/repos/ninamiolane/geomstats/pulls/23","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ninamiolane/geomstats/pulls/comments/169401175"},"html":{"href":"https://github.com/ninamiolane/geomstats/pull/23#discussion_r169401175"},"pull_request":{"href":"https://api.github.com/repos/ninamiolane/geomstats/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/ninamiolane/geomstats/pulls/23","id":170131811,"html_url":"https://github.com/ninamiolane/geomstats/pull/23","diff_url":"https://github.com/ninamiolane/geomstats/pull/23.diff","patch_url":"https://github.com/ninamiolane/geomstats/pull/23.patch","issue_url":"https://api.github.com/repos/ninamiolane/geomstats/issues/23","number":23,"state":"open","locked":false,"title":"Nina geodesics h2","user":{"login":"ninamiolane","id":8267869,"avatar_url":"https://avatars3.githubusercontent.com/u/8267869?v=4","gravatar_id":"","url":"https://api.github.com/users/ninamiolane","html_url":"https://github.com/ninamiolane","followers_url":"https://api.github.com/users/ninamiolane/followers","following_url":"https://api.github.com/users/ninamiolane/following{/other_user}","gists_url":"https://api.github.com/users/ninamiolane/gists{/gist_id}","starred_url":"https://api.github.com/users/ninamiolane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ninamiolane/subscriptions","organizations_url":"https://api.github.com/users/ninamiolane/orgs","repos_url":"https://api.github.com/users/ninamiolane/repos","events_url":"https://api.github.com/users/ninamiolane/events{/privacy}","received_events_url":"https://api.github.com/users/ninamiolane/received_events","type":"User","site_admin":false},"body":"Add plot of geodesics for the hyperbolic space in 2D, with Poincare disk visualization.\r\nAdd unit tests to check that the geodesics belong to the space for all spaces.","created_at":"2018-02-20T08:55:43Z","updated_at":"2018-02-20T17:43:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3ddab3504ca0b2338dd63f587126329813d9370a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ninamiolane/geomstats/pulls/23/commits","review_comments_url":"https://api.github.com/repos/ninamiolane/geomstats/pulls/23/comments","review_comment_url":"https://api.github.com/repos/ninamiolane/geomstats/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ninamiolane/geomstats/issues/23/comments","statuses_url":"https://api.github.com/repos/ninamiolane/geomstats/statuses/2a609064125ffd762ed106fb2e4c8c905c340a51","head":{"label":"ninamiolane:nina-geodesics-h2","ref":"nina-geodesics-h2","sha":"2a609064125ffd762ed106fb2e4c8c905c340a51","user":{"login":"ninamiolane","id":8267869,"avatar_url":"https://avatars3.githubusercontent.com/u/8267869?v=4","gravatar_id":"","url":"https://api.github.com/users/ninamiolane","html_url":"https://github.com/ninamiolane","followers_url":"https://api.github.com/users/ninamiolane/followers","following_url":"https://api.github.com/users/ninamiolane/following{/other_user}","gists_url":"https://api.github.com/users/ninamiolane/gists{/gist_id}","starred_url":"https://api.github.com/users/ninamiolane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ninamiolane/subscriptions","organizations_url":"https://api.github.com/users/ninamiolane/orgs","repos_url":"https://api.github.com/users/ninamiolane/repos","events_url":"https://api.github.com/users/ninamiolane/events{/privacy}","received_events_url":"https://api.github.com/users/ninamiolane/received_events","type":"User","site_admin":false},"repo":{"id":108200238,"name":"geomstats","full_name":"ninamiolane/geomstats","owner":{"login":"ninamiolane","id":8267869,"avatar_url":"https://avatars3.githubusercontent.com/u/8267869?v=4","gravatar_id":"","url":"https://api.github.com/users/ninamiolane","html_url":"https://github.com/ninamiolane","followers_url":"https://api.github.com/users/ninamiolane/followers","following_url":"https://api.github.com/users/ninamiolane/following{/other_user}","gists_url":"https://api.github.com/users/ninamiolane/gists{/gist_id}","starred_url":"https://api.github.com/users/ninamiolane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ninamiolane/subscriptions","organizations_url":"https://api.github.com/users/ninamiolane/orgs","repos_url":"https://api.github.com/users/ninamiolane/repos","events_url":"https://api.github.com/users/ninamiolane/events{/privacy}","received_events_url":"https://api.github.com/users/ninamiolane/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ninamiolane/geomstats","description":null,"fork":false,"url":"https://api.github.com/repos/ninamiolane/geomstats","forks_url":"https://api.github.com/repos/ninamiolane/geomstats/forks","keys_url":"https://api.github.com/repos/ninamiolane/geomstats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ninamiolane/geomstats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ninamiolane/geomstats/teams","hooks_url":"https://api.github.com/repos/ninamiolane/geomstats/hooks","issue_events_url":"https://api.github.com/repos/ninamiolane/geomstats/issues/events{/number}","events_url":"https://api.github.com/repos/ninamiolane/geomstats/events","assignees_url":"https://api.github.com/repos/ninamiolane/geomstats/assignees{/user}","branches_url":"https://api.github.com/repos/ninamiolane/geomstats/branches{/branch}","tags_url":"https://api.github.com/repos/ninamiolane/geomstats/tags","blobs_url":"https://api.github.com/repos/ninamiolane/geomstats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ninamiolane/geomstats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ninamiolane/geomstats/git/refs{/sha}","trees_url":"https://api.github.com/repos/ninamiolane/geomstats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ninamiolane/geomstats/statuses/{sha}","languages_url":"https://api.github.com/repos/ninamiolane/geomstats/languages","stargazers_url":"https://api.github.com/repos/ninamiolane/geomstats/stargazers","contributors_url":"https://api.github.com/repos/ninamiolane/geomstats/contributors","subscribers_url":"https://api.github.com/repos/ninamiolane/geomstats/subscribers","subscription_url":"https://api.github.com/repos/ninamiolane/geomstats/subscription","commits_url":"https://api.github.com/repos/ninamiolane/geomstats/commits{/sha}","git_commits_url":"https://api.github.com/repos/ninamiolane/geomstats/git/commits{/sha}","comments_url":"https://api.github.com/repos/ninamiolane/geomstats/comments{/number}","issue_comment_url":"https://api.github.com/repos/ninamiolane/geomstats/issues/comments{/number}","contents_url":"https://api.github.com/repos/ninamiolane/geomstats/contents/{+path}","compare_url":"https://api.github.com/repos/ninamiolane/geomstats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ninamiolane/geomstats/merges","archive_url":"https://api.github.com/repos/ninamiolane/geomstats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ninamiolane/geomstats/downloads","issues_url":"https://api.github.com/repos/ninamiolane/geomstats/issues{/number}","pulls_url":"https://api.github.com/repos/ninamiolane/geomstats/pulls{/number}","milestones_url":"https://api.github.com/repos/ninamiolane/geomstats/milestones{/number}","notifications_url":"https://api.github.com/repos/ninamiolane/geomstats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ninamiolane/geomstats/labels{/name}","releases_url":"https://api.github.com/repos/ninamiolane/geomstats/releases{/id}","deployments_url":"https://api.github.com/repos/ninamiolane/geomstats/deployments","created_at":"2017-10-25T00:44:57Z","updated_at":"2018-01-28T17:16:44Z","pushed_at":"2018-02-20T08:59:11Z","git_url":"git://github.com/ninamiolane/geomstats.git","ssh_url":"git@github.com:ninamiolane/geomstats.git","clone_url":"https://github.com/ninamiolane/geomstats.git","svn_url":"https://github.com/ninamiolane/geomstats","homepage":null,"size":257,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"ninamiolane:master","ref":"master","sha":"7576e0fa4a2ba29d012a5d9163674f163463586a","user":{"login":"ninamiolane","id":8267869,"avatar_url":"https://avatars3.githubusercontent.com/u/8267869?v=4","gravatar_id":"","url":"https://api.github.com/users/ninamiolane","html_url":"https://github.com/ninamiolane","followers_url":"https://api.github.com/users/ninamiolane/followers","following_url":"https://api.github.com/users/ninamiolane/following{/other_user}","gists_url":"https://api.github.com/users/ninamiolane/gists{/gist_id}","starred_url":"https://api.github.com/users/ninamiolane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ninamiolane/subscriptions","organizations_url":"https://api.github.com/users/ninamiolane/orgs","repos_url":"https://api.github.com/users/ninamiolane/repos","events_url":"https://api.github.com/users/ninamiolane/events{/privacy}","received_events_url":"https://api.github.com/users/ninamiolane/received_events","type":"User","site_admin":false},"repo":{"id":108200238,"name":"geomstats","full_name":"ninamiolane/geomstats","owner":{"login":"ninamiolane","id":8267869,"avatar_url":"https://avatars3.githubusercontent.com/u/8267869?v=4","gravatar_id":"","url":"https://api.github.com/users/ninamiolane","html_url":"https://github.com/ninamiolane","followers_url":"https://api.github.com/users/ninamiolane/followers","following_url":"https://api.github.com/users/ninamiolane/following{/other_user}","gists_url":"https://api.github.com/users/ninamiolane/gists{/gist_id}","starred_url":"https://api.github.com/users/ninamiolane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ninamiolane/subscriptions","organizations_url":"https://api.github.com/users/ninamiolane/orgs","repos_url":"https://api.github.com/users/ninamiolane/repos","events_url":"https://api.github.com/users/ninamiolane/events{/privacy}","received_events_url":"https://api.github.com/users/ninamiolane/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ninamiolane/geomstats","description":null,"fork":false,"url":"https://api.github.com/repos/ninamiolane/geomstats","forks_url":"https://api.github.com/repos/ninamiolane/geomstats/forks","keys_url":"https://api.github.com/repos/ninamiolane/geomstats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ninamiolane/geomstats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ninamiolane/geomstats/teams","hooks_url":"https://api.github.com/repos/ninamiolane/geomstats/hooks","issue_events_url":"https://api.github.com/repos/ninamiolane/geomstats/issues/events{/number}","events_url":"https://api.github.com/repos/ninamiolane/geomstats/events","assignees_url":"https://api.github.com/repos/ninamiolane/geomstats/assignees{/user}","branches_url":"https://api.github.com/repos/ninamiolane/geomstats/branches{/branch}","tags_url":"https://api.github.com/repos/ninamiolane/geomstats/tags","blobs_url":"https://api.github.com/repos/ninamiolane/geomstats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ninamiolane/geomstats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ninamiolane/geomstats/git/refs{/sha}","trees_url":"https://api.github.com/repos/ninamiolane/geomstats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ninamiolane/geomstats/statuses/{sha}","languages_url":"https://api.github.com/repos/ninamiolane/geomstats/languages","stargazers_url":"https://api.github.com/repos/ninamiolane/geomstats/stargazers","contributors_url":"https://api.github.com/repos/ninamiolane/geomstats/contributors","subscribers_url":"https://api.github.com/repos/ninamiolane/geomstats/subscribers","subscription_url":"https://api.github.com/repos/ninamiolane/geomstats/subscription","commits_url":"https://api.github.com/repos/ninamiolane/geomstats/commits{/sha}","git_commits_url":"https://api.github.com/repos/ninamiolane/geomstats/git/commits{/sha}","comments_url":"https://api.github.com/repos/ninamiolane/geomstats/comments{/number}","issue_comment_url":"https://api.github.com/repos/ninamiolane/geomstats/issues/comments{/number}","contents_url":"https://api.github.com/repos/ninamiolane/geomstats/contents/{+path}","compare_url":"https://api.github.com/repos/ninamiolane/geomstats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ninamiolane/geomstats/merges","archive_url":"https://api.github.com/repos/ninamiolane/geomstats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ninamiolane/geomstats/downloads","issues_url":"https://api.github.com/repos/ninamiolane/geomstats/issues{/number}","pulls_url":"https://api.github.com/repos/ninamiolane/geomstats/pulls{/number}","milestones_url":"https://api.github.com/repos/ninamiolane/geomstats/milestones{/number}","notifications_url":"https://api.github.com/repos/ninamiolane/geomstats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ninamiolane/geomstats/labels{/name}","releases_url":"https://api.github.com/repos/ninamiolane/geomstats/releases{/id}","deployments_url":"https://api.github.com/repos/ninamiolane/geomstats/deployments","created_at":"2017-10-25T00:44:57Z","updated_at":"2018-01-28T17:16:44Z","pushed_at":"2018-02-20T08:59:11Z","git_url":"git://github.com/ninamiolane/geomstats.git","ssh_url":"git@github.com:ninamiolane/geomstats.git","clone_url":"https://github.com/ninamiolane/geomstats.git","svn_url":"https://github.com/ninamiolane/geomstats","homepage":null,"size":257,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ninamiolane/geomstats/pulls/23"},"html":{"href":"https://github.com/ninamiolane/geomstats/pull/23"},"issue":{"href":"https://api.github.com/repos/ninamiolane/geomstats/issues/23"},"comments":{"href":"https://api.github.com/repos/ninamiolane/geomstats/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/ninamiolane/geomstats/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/ninamiolane/geomstats/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ninamiolane/geomstats/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/ninamiolane/geomstats/statuses/2a609064125ffd762ed106fb2e4c8c905c340a51"}},"author_association":"OWNER"}}
{"actor":{"display_login":"johmathe"}}