{"action":"closed","number":2786,"pull_request":{"url":"https://api.github.com/repos/google/protobuf/pulls/2786","id":108863357,"node_id":"MDExOlB1bGxSZXF1ZXN0MTA4ODYzMzU3","html_url":"https://github.com/google/protobuf/pull/2786","diff_url":"https://github.com/google/protobuf/pull/2786.diff","patch_url":"https://github.com/google/protobuf/pull/2786.patch","issue_url":"https://api.github.com/repos/google/protobuf/issues/2786","number":2786,"state":"closed","locked":false,"title":"Avoid self-swap check when swapping repeated fields.","user":{"login":"ckennelly","id":135530,"node_id":"MDQ6VXNlcjEzNTUzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/135530?v=4","gravatar_id":"","url":"https://api.github.com/users/ckennelly","html_url":"https://github.com/ckennelly","followers_url":"https://api.github.com/users/ckennelly/followers","following_url":"https://api.github.com/users/ckennelly/following{/other_user}","gists_url":"https://api.github.com/users/ckennelly/gists{/gist_id}","starred_url":"https://api.github.com/users/ckennelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckennelly/subscriptions","organizations_url":"https://api.github.com/users/ckennelly/orgs","repos_url":"https://api.github.com/users/ckennelly/repos","events_url":"https://api.github.com/users/ckennelly/events{/privacy}","received_events_url":"https://api.github.com/users/ckennelly/received_events","type":"User","site_admin":false},"body":"In generated code, we check for self-swap in Swap (and same Arena, for protos using Arenas) and then individually check each field for self-swap in `RepeatedField<T>::UnsafeArenaSwap`/`RepeatedPtrField<T>::UnsafeArenaSwap`.  If the first check has passed, the second (per-field) check will as well.\r\n\r\n  `this != other` implies `&(this->some_field_) != &(other->some_field_)`\r\n\r\n  for the same types of `this` and `other`.","created_at":"2017-03-02T22:13:40Z","updated_at":"2018-06-11T20:45:18Z","closed_at":"2018-06-11T20:45:18Z","merged_at":null,"merge_commit_sha":"056585e43ffc6abfde96c7f8f2bafbd58db03f34","assignee":{"login":"TeBoring","id":5195749,"node_id":"MDQ6VXNlcjUxOTU3NDk=","avatar_url":"https://avatars1.githubusercontent.com/u/5195749?v=4","gravatar_id":"","url":"https://api.github.com/users/TeBoring","html_url":"https://github.com/TeBoring","followers_url":"https://api.github.com/users/TeBoring/followers","following_url":"https://api.github.com/users/TeBoring/following{/other_user}","gists_url":"https://api.github.com/users/TeBoring/gists{/gist_id}","starred_url":"https://api.github.com/users/TeBoring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeBoring/subscriptions","organizations_url":"https://api.github.com/users/TeBoring/orgs","repos_url":"https://api.github.com/users/TeBoring/repos","events_url":"https://api.github.com/users/TeBoring/events{/privacy}","received_events_url":"https://api.github.com/users/TeBoring/received_events","type":"User","site_admin":false},"assignees":[{"login":"TeBoring","id":5195749,"node_id":"MDQ6VXNlcjUxOTU3NDk=","avatar_url":"https://avatars1.githubusercontent.com/u/5195749?v=4","gravatar_id":"","url":"https://api.github.com/users/TeBoring","html_url":"https://github.com/TeBoring","followers_url":"https://api.github.com/users/TeBoring/followers","following_url":"https://api.github.com/users/TeBoring/following{/other_user}","gists_url":"https://api.github.com/users/TeBoring/gists{/gist_id}","starred_url":"https://api.github.com/users/TeBoring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeBoring/subscriptions","organizations_url":"https://api.github.com/users/TeBoring/orgs","repos_url":"https://api.github.com/users/TeBoring/repos","events_url":"https://api.github.com/users/TeBoring/events{/privacy}","received_events_url":"https://api.github.com/users/TeBoring/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"acozzette","id":1115459,"node_id":"MDQ6VXNlcjExMTU0NTk=","avatar_url":"https://avatars3.githubusercontent.com/u/1115459?v=4","gravatar_id":"","url":"https://api.github.com/users/acozzette","html_url":"https://github.com/acozzette","followers_url":"https://api.github.com/users/acozzette/followers","following_url":"https://api.github.com/users/acozzette/following{/other_user}","gists_url":"https://api.github.com/users/acozzette/gists{/gist_id}","starred_url":"https://api.github.com/users/acozzette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acozzette/subscriptions","organizations_url":"https://api.github.com/users/acozzette/orgs","repos_url":"https://api.github.com/users/acozzette/repos","events_url":"https://api.github.com/users/acozzette/events{/privacy}","received_events_url":"https://api.github.com/users/acozzette/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":151794609,"node_id":"MDU6TGFiZWwxNTE3OTQ2MDk=","url":"https://api.github.com/repos/google/protobuf/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/google/protobuf/pulls/2786/commits","review_comments_url":"https://api.github.com/repos/google/protobuf/pulls/2786/comments","review_comment_url":"https://api.github.com/repos/google/protobuf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/protobuf/issues/2786/comments","statuses_url":"https://api.github.com/repos/google/protobuf/statuses/db43939cf51a714324edcbae2ccb4ccf6118481d","head":{"label":"ckennelly:swap","ref":"swap","sha":"db43939cf51a714324edcbae2ccb4ccf6118481d","user":{"login":"ckennelly","id":135530,"node_id":"MDQ6VXNlcjEzNTUzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/135530?v=4","gravatar_id":"","url":"https://api.github.com/users/ckennelly","html_url":"https://github.com/ckennelly","followers_url":"https://api.github.com/users/ckennelly/followers","following_url":"https://api.github.com/users/ckennelly/following{/other_user}","gists_url":"https://api.github.com/users/ckennelly/gists{/gist_id}","starred_url":"https://api.github.com/users/ckennelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckennelly/subscriptions","organizations_url":"https://api.github.com/users/ckennelly/orgs","repos_url":"https://api.github.com/users/ckennelly/repos","events_url":"https://api.github.com/users/ckennelly/events{/privacy}","received_events_url":"https://api.github.com/users/ckennelly/received_events","type":"User","site_admin":false},"repo":{"id":73520325,"node_id":"MDEwOlJlcG9zaXRvcnk3MzUyMDMyNQ==","name":"protobuf","full_name":"ckennelly/protobuf","owner":{"login":"ckennelly","id":135530,"node_id":"MDQ6VXNlcjEzNTUzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/135530?v=4","gravatar_id":"","url":"https://api.github.com/users/ckennelly","html_url":"https://github.com/ckennelly","followers_url":"https://api.github.com/users/ckennelly/followers","following_url":"https://api.github.com/users/ckennelly/following{/other_user}","gists_url":"https://api.github.com/users/ckennelly/gists{/gist_id}","starred_url":"https://api.github.com/users/ckennelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckennelly/subscriptions","organizations_url":"https://api.github.com/users/ckennelly/orgs","repos_url":"https://api.github.com/users/ckennelly/repos","events_url":"https://api.github.com/users/ckennelly/events{/privacy}","received_events_url":"https://api.github.com/users/ckennelly/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ckennelly/protobuf","description":"Protocol Buffers - Google's data interchange format","fork":true,"url":"https://api.github.com/repos/ckennelly/protobuf","forks_url":"https://api.github.com/repos/ckennelly/protobuf/forks","keys_url":"https://api.github.com/repos/ckennelly/protobuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ckennelly/protobuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ckennelly/protobuf/teams","hooks_url":"https://api.github.com/repos/ckennelly/protobuf/hooks","issue_events_url":"https://api.github.com/repos/ckennelly/protobuf/issues/events{/number}","events_url":"https://api.github.com/repos/ckennelly/protobuf/events","assignees_url":"https://api.github.com/repos/ckennelly/protobuf/assignees{/user}","branches_url":"https://api.github.com/repos/ckennelly/protobuf/branches{/branch}","tags_url":"https://api.github.com/repos/ckennelly/protobuf/tags","blobs_url":"https://api.github.com/repos/ckennelly/protobuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ckennelly/protobuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ckennelly/protobuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/ckennelly/protobuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ckennelly/protobuf/statuses/{sha}","languages_url":"https://api.github.com/repos/ckennelly/protobuf/languages","stargazers_url":"https://api.github.com/repos/ckennelly/protobuf/stargazers","contributors_url":"https://api.github.com/repos/ckennelly/protobuf/contributors","subscribers_url":"https://api.github.com/repos/ckennelly/protobuf/subscribers","subscription_url":"https://api.github.com/repos/ckennelly/protobuf/subscription","commits_url":"https://api.github.com/repos/ckennelly/protobuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/ckennelly/protobuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/ckennelly/protobuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/ckennelly/protobuf/issues/comments{/number}","contents_url":"https://api.github.com/repos/ckennelly/protobuf/contents/{+path}","compare_url":"https://api.github.com/repos/ckennelly/protobuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ckennelly/protobuf/merges","archive_url":"https://api.github.com/repos/ckennelly/protobuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ckennelly/protobuf/downloads","issues_url":"https://api.github.com/repos/ckennelly/protobuf/issues{/number}","pulls_url":"https://api.github.com/repos/ckennelly/protobuf/pulls{/number}","milestones_url":"https://api.github.com/repos/ckennelly/protobuf/milestones{/number}","notifications_url":"https://api.github.com/repos/ckennelly/protobuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ckennelly/protobuf/labels{/name}","releases_url":"https://api.github.com/repos/ckennelly/protobuf/releases{/id}","deployments_url":"https://api.github.com/repos/ckennelly/protobuf/deployments","created_at":"2016-11-11T23:54:58Z","updated_at":"2016-11-11T23:55:12Z","pushed_at":"2017-03-22T18:48:38Z","git_url":"git://github.com/ckennelly/protobuf.git","ssh_url":"git@github.com:ckennelly/protobuf.git","clone_url":"https://github.com/ckennelly/protobuf.git","svn_url":"https://github.com/ckennelly/protobuf","homepage":"https://developers.google.com/protocol-buffers/","size":38499,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"a7e3b0ab016312f7427426d2cb88b0ab77210b79","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":23357588,"node_id":"MDEwOlJlcG9zaXRvcnkyMzM1NzU4OA==","name":"protobuf","full_name":"google/protobuf","owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/protobuf","description":"Protocol Buffers - Google's data interchange format","fork":false,"url":"https://api.github.com/repos/google/protobuf","forks_url":"https://api.github.com/repos/google/protobuf/forks","keys_url":"https://api.github.com/repos/google/protobuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/protobuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/protobuf/teams","hooks_url":"https://api.github.com/repos/google/protobuf/hooks","issue_events_url":"https://api.github.com/repos/google/protobuf/issues/events{/number}","events_url":"https://api.github.com/repos/google/protobuf/events","assignees_url":"https://api.github.com/repos/google/protobuf/assignees{/user}","branches_url":"https://api.github.com/repos/google/protobuf/branches{/branch}","tags_url":"https://api.github.com/repos/google/protobuf/tags","blobs_url":"https://api.github.com/repos/google/protobuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/protobuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/protobuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/protobuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/protobuf/statuses/{sha}","languages_url":"https://api.github.com/repos/google/protobuf/languages","stargazers_url":"https://api.github.com/repos/google/protobuf/stargazers","contributors_url":"https://api.github.com/repos/google/protobuf/contributors","subscribers_url":"https://api.github.com/repos/google/protobuf/subscribers","subscription_url":"https://api.github.com/repos/google/protobuf/subscription","commits_url":"https://api.github.com/repos/google/protobuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/protobuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/protobuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/protobuf/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/protobuf/contents/{+path}","compare_url":"https://api.github.com/repos/google/protobuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/protobuf/merges","archive_url":"https://api.github.com/repos/google/protobuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/protobuf/downloads","issues_url":"https://api.github.com/repos/google/protobuf/issues{/number}","pulls_url":"https://api.github.com/repos/google/protobuf/pulls{/number}","milestones_url":"https://api.github.com/repos/google/protobuf/milestones{/number}","notifications_url":"https://api.github.com/repos/google/protobuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/protobuf/labels{/name}","releases_url":"https://api.github.com/repos/google/protobuf/releases{/id}","deployments_url":"https://api.github.com/repos/google/protobuf/deployments","created_at":"2014-08-26T15:52:15Z","updated_at":"2018-06-11T19:17:33Z","pushed_at":"2018-06-11T16:21:22Z","git_url":"git://github.com/google/protobuf.git","ssh_url":"git@github.com:google/protobuf.git","clone_url":"https://github.com/google/protobuf.git","svn_url":"https://github.com/google/protobuf","homepage":"https://developers.google.com/protocol-buffers/","size":47695,"stargazers_count":26720,"watchers_count":26720,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7556,"mirror_url":null,"archived":false,"open_issues_count":619,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":7556,"open_issues":619,"watchers":26720,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/protobuf/pulls/2786"},"html":{"href":"https://github.com/google/protobuf/pull/2786"},"issue":{"href":"https://api.github.com/repos/google/protobuf/issues/2786"},"comments":{"href":"https://api.github.com/repos/google/protobuf/issues/2786/comments"},"review_comments":{"href":"https://api.github.com/repos/google/protobuf/pulls/2786/comments"},"review_comment":{"href":"https://api.github.com/repos/google/protobuf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/protobuf/pulls/2786/commits"},"statuses":{"href":"https://api.github.com/repos/google/protobuf/statuses/db43939cf51a714324edcbae2ccb4ccf6118481d"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":69,"deletions":57,"changed_files":11}}
{"actor":{"display_login":"TeBoring"}}