{"action":"created","comment":{"url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/comments/182315806","pull_request_review_id":113084395,"id":182315806,"diff_hunk":"@@ -375,16 +385,6 @@ class TitusClusterCachingAgent implements CachingAgent, CustomScheduledAgent, On\n     }\n   }\n \n-\n-  private void cacheTargetGroups(ServerGroupData data, Map<String, CacheData> targetGroups) {","path":"clouddriver-titus/src/main/groovy/com/netflix/spinnaker/clouddriver/titus/caching/agents/TitusClusterCachingAgent.groovy","position":47,"original_position":47,"commit_id":"67b7e7e0fa779d25bd91a12cccbca60a2091488c","original_commit_id":"67b7e7e0fa779d25bd91a12cccbca60a2091488c","user":{"login":"ajordens","id":388652,"avatar_url":"https://avatars0.githubusercontent.com/u/388652?v=4","gravatar_id":"","url":"https://api.github.com/users/ajordens","html_url":"https://github.com/ajordens","followers_url":"https://api.github.com/users/ajordens/followers","following_url":"https://api.github.com/users/ajordens/following{/other_user}","gists_url":"https://api.github.com/users/ajordens/gists{/gist_id}","starred_url":"https://api.github.com/users/ajordens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajordens/subscriptions","organizations_url":"https://api.github.com/users/ajordens/orgs","repos_url":"https://api.github.com/users/ajordens/repos","events_url":"https://api.github.com/users/ajordens/events{/privacy}","received_events_url":"https://api.github.com/users/ajordens/received_events","type":"User","site_admin":false},"body":"IntelliJ told me this wasn't being used","created_at":"2018-04-18T05:56:53Z","updated_at":"2018-04-18T05:59:41Z","html_url":"https://github.com/spinnaker/clouddriver/pull/2523#discussion_r182315806","pull_request_url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/2523","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/comments/182315806"},"html":{"href":"https://github.com/spinnaker/clouddriver/pull/2523#discussion_r182315806"},"pull_request":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/2523"}}},"pull_request":{"url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/2523","id":182373925,"html_url":"https://github.com/spinnaker/clouddriver/pull/2523","diff_url":"https://github.com/spinnaker/clouddriver/pull/2523.diff","patch_url":"https://github.com/spinnaker/clouddriver/pull/2523.patch","issue_url":"https://api.github.com/repos/spinnaker/clouddriver/issues/2523","number":2523,"state":"open","locked":false,"title":"perf(caching): Support retrieving an individual on-demand record by id","user":{"login":"ajordens","id":388652,"avatar_url":"https://avatars0.githubusercontent.com/u/388652?v=4","gravatar_id":"","url":"https://api.github.com/users/ajordens","html_url":"https://github.com/ajordens","followers_url":"https://api.github.com/users/ajordens/followers","following_url":"https://api.github.com/users/ajordens/following{/other_user}","gists_url":"https://api.github.com/users/ajordens/gists{/gist_id}","starred_url":"https://api.github.com/users/ajordens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajordens/subscriptions","organizations_url":"https://api.github.com/users/ajordens/orgs","repos_url":"https://api.github.com/users/ajordens/repos","events_url":"https://api.github.com/users/ajordens/events{/privacy}","received_events_url":"https://api.github.com/users/ajordens/received_events","type":"User","site_admin":false},"body":"Currently `orca` fetches all on-demand records and filters client-side\r\ndown to the specific record it is interested in.\r\n\r\nThis PR does two things:\r\n- returns a set of typed identifiers as part of the original force cache refresh api\r\n- allows for an `id` parameter to be supplied to the `/cache/{cloudProvider}/{type}` api\r\n\r\nIt currently supports a single `id` parameter as the expected use case\r\nwill be as part of the `ServerGroupForceCacheRefreshTask` which deals\r\nwith one server group at a time.\r\n","created_at":"2018-04-18T05:51:39Z","updated_at":"2018-04-18T05:59:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67bf74702b872b3177026b3782fd2d352ec72648","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/2523/commits","review_comments_url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/2523/comments","review_comment_url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spinnaker/clouddriver/issues/2523/comments","statuses_url":"https://api.github.com/repos/spinnaker/clouddriver/statuses/67b7e7e0fa779d25bd91a12cccbca60a2091488c","head":{"label":"ajordens:support-individual-pending-ondemand-retrieval","ref":"support-individual-pending-ondemand-retrieval","sha":"67b7e7e0fa779d25bd91a12cccbca60a2091488c","user":{"login":"ajordens","id":388652,"avatar_url":"https://avatars0.githubusercontent.com/u/388652?v=4","gravatar_id":"","url":"https://api.github.com/users/ajordens","html_url":"https://github.com/ajordens","followers_url":"https://api.github.com/users/ajordens/followers","following_url":"https://api.github.com/users/ajordens/following{/other_user}","gists_url":"https://api.github.com/users/ajordens/gists{/gist_id}","starred_url":"https://api.github.com/users/ajordens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajordens/subscriptions","organizations_url":"https://api.github.com/users/ajordens/orgs","repos_url":"https://api.github.com/users/ajordens/repos","events_url":"https://api.github.com/users/ajordens/events{/privacy}","received_events_url":"https://api.github.com/users/ajordens/received_events","type":"User","site_admin":false},"repo":{"id":46809140,"name":"clouddriver","full_name":"ajordens/clouddriver","owner":{"login":"ajordens","id":388652,"avatar_url":"https://avatars0.githubusercontent.com/u/388652?v=4","gravatar_id":"","url":"https://api.github.com/users/ajordens","html_url":"https://github.com/ajordens","followers_url":"https://api.github.com/users/ajordens/followers","following_url":"https://api.github.com/users/ajordens/following{/other_user}","gists_url":"https://api.github.com/users/ajordens/gists{/gist_id}","starred_url":"https://api.github.com/users/ajordens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajordens/subscriptions","organizations_url":"https://api.github.com/users/ajordens/orgs","repos_url":"https://api.github.com/users/ajordens/repos","events_url":"https://api.github.com/users/ajordens/events{/privacy}","received_events_url":"https://api.github.com/users/ajordens/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ajordens/clouddriver","description":"read and write operations across cloud providers","fork":true,"url":"https://api.github.com/repos/ajordens/clouddriver","forks_url":"https://api.github.com/repos/ajordens/clouddriver/forks","keys_url":"https://api.github.com/repos/ajordens/clouddriver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ajordens/clouddriver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ajordens/clouddriver/teams","hooks_url":"https://api.github.com/repos/ajordens/clouddriver/hooks","issue_events_url":"https://api.github.com/repos/ajordens/clouddriver/issues/events{/number}","events_url":"https://api.github.com/repos/ajordens/clouddriver/events","assignees_url":"https://api.github.com/repos/ajordens/clouddriver/assignees{/user}","branches_url":"https://api.github.com/repos/ajordens/clouddriver/branches{/branch}","tags_url":"https://api.github.com/repos/ajordens/clouddriver/tags","blobs_url":"https://api.github.com/repos/ajordens/clouddriver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ajordens/clouddriver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ajordens/clouddriver/git/refs{/sha}","trees_url":"https://api.github.com/repos/ajordens/clouddriver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ajordens/clouddriver/statuses/{sha}","languages_url":"https://api.github.com/repos/ajordens/clouddriver/languages","stargazers_url":"https://api.github.com/repos/ajordens/clouddriver/stargazers","contributors_url":"https://api.github.com/repos/ajordens/clouddriver/contributors","subscribers_url":"https://api.github.com/repos/ajordens/clouddriver/subscribers","subscription_url":"https://api.github.com/repos/ajordens/clouddriver/subscription","commits_url":"https://api.github.com/repos/ajordens/clouddriver/commits{/sha}","git_commits_url":"https://api.github.com/repos/ajordens/clouddriver/git/commits{/sha}","comments_url":"https://api.github.com/repos/ajordens/clouddriver/comments{/number}","issue_comment_url":"https://api.github.com/repos/ajordens/clouddriver/issues/comments{/number}","contents_url":"https://api.github.com/repos/ajordens/clouddriver/contents/{+path}","compare_url":"https://api.github.com/repos/ajordens/clouddriver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ajordens/clouddriver/merges","archive_url":"https://api.github.com/repos/ajordens/clouddriver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ajordens/clouddriver/downloads","issues_url":"https://api.github.com/repos/ajordens/clouddriver/issues{/number}","pulls_url":"https://api.github.com/repos/ajordens/clouddriver/pulls{/number}","milestones_url":"https://api.github.com/repos/ajordens/clouddriver/milestones{/number}","notifications_url":"https://api.github.com/repos/ajordens/clouddriver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ajordens/clouddriver/labels{/name}","releases_url":"https://api.github.com/repos/ajordens/clouddriver/releases{/id}","deployments_url":"https://api.github.com/repos/ajordens/clouddriver/deployments","created_at":"2015-11-24T17:59:48Z","updated_at":"2018-04-05T01:11:42Z","pushed_at":"2018-04-18T05:56:31Z","git_url":"git://github.com/ajordens/clouddriver.git","ssh_url":"git@github.com:ajordens/clouddriver.git","clone_url":"https://github.com/ajordens/clouddriver.git","svn_url":"https://github.com/ajordens/clouddriver","homepage":null,"size":34876,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spinnaker:master","ref":"master","sha":"faded2fc23819b7e20a47d2119c4531db004b661","user":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars1.githubusercontent.com/u/7634182?v=4","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"repo":{"id":37556951,"name":"clouddriver","full_name":"spinnaker/clouddriver","owner":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars1.githubusercontent.com/u/7634182?v=4","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spinnaker/clouddriver","description":"read and write operations across cloud providers","fork":false,"url":"https://api.github.com/repos/spinnaker/clouddriver","forks_url":"https://api.github.com/repos/spinnaker/clouddriver/forks","keys_url":"https://api.github.com/repos/spinnaker/clouddriver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spinnaker/clouddriver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spinnaker/clouddriver/teams","hooks_url":"https://api.github.com/repos/spinnaker/clouddriver/hooks","issue_events_url":"https://api.github.com/repos/spinnaker/clouddriver/issues/events{/number}","events_url":"https://api.github.com/repos/spinnaker/clouddriver/events","assignees_url":"https://api.github.com/repos/spinnaker/clouddriver/assignees{/user}","branches_url":"https://api.github.com/repos/spinnaker/clouddriver/branches{/branch}","tags_url":"https://api.github.com/repos/spinnaker/clouddriver/tags","blobs_url":"https://api.github.com/repos/spinnaker/clouddriver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spinnaker/clouddriver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spinnaker/clouddriver/git/refs{/sha}","trees_url":"https://api.github.com/repos/spinnaker/clouddriver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spinnaker/clouddriver/statuses/{sha}","languages_url":"https://api.github.com/repos/spinnaker/clouddriver/languages","stargazers_url":"https://api.github.com/repos/spinnaker/clouddriver/stargazers","contributors_url":"https://api.github.com/repos/spinnaker/clouddriver/contributors","subscribers_url":"https://api.github.com/repos/spinnaker/clouddriver/subscribers","subscription_url":"https://api.github.com/repos/spinnaker/clouddriver/subscription","commits_url":"https://api.github.com/repos/spinnaker/clouddriver/commits{/sha}","git_commits_url":"https://api.github.com/repos/spinnaker/clouddriver/git/commits{/sha}","comments_url":"https://api.github.com/repos/spinnaker/clouddriver/comments{/number}","issue_comment_url":"https://api.github.com/repos/spinnaker/clouddriver/issues/comments{/number}","contents_url":"https://api.github.com/repos/spinnaker/clouddriver/contents/{+path}","compare_url":"https://api.github.com/repos/spinnaker/clouddriver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spinnaker/clouddriver/merges","archive_url":"https://api.github.com/repos/spinnaker/clouddriver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spinnaker/clouddriver/downloads","issues_url":"https://api.github.com/repos/spinnaker/clouddriver/issues{/number}","pulls_url":"https://api.github.com/repos/spinnaker/clouddriver/pulls{/number}","milestones_url":"https://api.github.com/repos/spinnaker/clouddriver/milestones{/number}","notifications_url":"https://api.github.com/repos/spinnaker/clouddriver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spinnaker/clouddriver/labels{/name}","releases_url":"https://api.github.com/repos/spinnaker/clouddriver/releases{/id}","deployments_url":"https://api.github.com/repos/spinnaker/clouddriver/deployments","created_at":"2015-06-16T21:26:02Z","updated_at":"2018-04-17T19:13:13Z","pushed_at":"2018-04-18T05:56:33Z","git_url":"git://github.com/spinnaker/clouddriver.git","ssh_url":"git@github.com:spinnaker/clouddriver.git","clone_url":"https://github.com/spinnaker/clouddriver.git","svn_url":"https://github.com/spinnaker/clouddriver","homepage":null,"size":39218,"stargazers_count":141,"watchers_count":141,"language":"Groovy","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":334,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":334,"open_issues":7,"watchers":141,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/2523"},"html":{"href":"https://github.com/spinnaker/clouddriver/pull/2523"},"issue":{"href":"https://api.github.com/repos/spinnaker/clouddriver/issues/2523"},"comments":{"href":"https://api.github.com/repos/spinnaker/clouddriver/issues/2523/comments"},"review_comments":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/2523/comments"},"review_comment":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/2523/commits"},"statuses":{"href":"https://api.github.com/repos/spinnaker/clouddriver/statuses/67b7e7e0fa779d25bd91a12cccbca60a2091488c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ajordens"}}