{"action":"created","comment":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/comments/189255272","pull_request_review_id":121401807,"id":189255272,"diff_hunk":"@@ -447,6 +459,21 @@ def _perform_absolute_normalisation(self, constants_ws):\n                 mtd[constants_ws].dataY(pixel)[0] = 1.\n                 mtd[constants_ws].dataE(pixel)[0] = 0.\n \n+    def _mask_outside_range(self, constants_ws):","path":"Framework/PythonInterface/plugins/algorithms/WorkflowAlgorithms/PowderDiffILLDetEffCorr.py","position":46,"original_position":46,"commit_id":"bd6e275137bdaff75339c903c5766d616ab92e7d","original_commit_id":"bd6e275137bdaff75339c903c5766d616ab92e7d","user":{"login":"reimundILL","id":19187274,"avatar_url":"https://avatars0.githubusercontent.com/u/19187274?v=4","gravatar_id":"","url":"https://api.github.com/users/reimundILL","html_url":"https://github.com/reimundILL","followers_url":"https://api.github.com/users/reimundILL/followers","following_url":"https://api.github.com/users/reimundILL/following{/other_user}","gists_url":"https://api.github.com/users/reimundILL/gists{/gist_id}","starred_url":"https://api.github.com/users/reimundILL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reimundILL/subscriptions","organizations_url":"https://api.github.com/users/reimundILL/orgs","repos_url":"https://api.github.com/users/reimundILL/repos","events_url":"https://api.github.com/users/reimundILL/events{/privacy}","received_events_url":"https://api.github.com/users/reimundILL/received_events","type":"User","site_admin":false},"body":"Seems to be smart","created_at":"2018-05-18T12:40:36Z","updated_at":"2018-05-18T12:40:36Z","html_url":"https://github.com/mantidproject/mantid/pull/22316#discussion_r189255272","pull_request_url":"https://api.github.com/repos/mantidproject/mantid/pulls/22316","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/comments/189255272"},"html":{"href":"https://github.com/mantidproject/mantid/pull/22316#discussion_r189255272"},"pull_request":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/22316"}}},"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/22316","id":183034157,"html_url":"https://github.com/mantidproject/mantid/pull/22316","diff_url":"https://github.com/mantidproject/mantid/pull/22316.diff","patch_url":"https://github.com/mantidproject/mantid/pull/22316.patch","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/22316","number":22316,"state":"open","locked":false,"title":"D2B detector alignment","user":{"login":"gvardany","id":16865759,"avatar_url":"https://avatars2.githubusercontent.com/u/16865759?v=4","gravatar_id":"","url":"https://api.github.com/users/gvardany","html_url":"https://github.com/gvardany","followers_url":"https://api.github.com/users/gvardany/followers","following_url":"https://api.github.com/users/gvardany/following{/other_user}","gists_url":"https://api.github.com/users/gvardany/gists{/gist_id}","starred_url":"https://api.github.com/users/gvardany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gvardany/subscriptions","organizations_url":"https://api.github.com/users/gvardany/orgs","repos_url":"https://api.github.com/users/gvardany/repos","events_url":"https://api.github.com/users/gvardany/events{/privacy}","received_events_url":"https://api.github.com/users/gvardany/received_events","type":"User","site_admin":false},"body":"This PR implements additional features requested for D2B (see the issue).\r\n\r\n**To test:**\r\nThis script effectively exercises all the new features. It should run and produce a 2D result (inside ws group) that looks like the attachment. Files are attached in a tarball; chop off `.zip`.\r\nQuantitatively it is tested with the unit and system tests.\r\n\r\n```\r\nCALIBFILE = '/Users/vardanyan/Desktop/test-calibPR.nxs' # give some path on your machine\r\ncalib = PowderDiffILLDetEffCorr(CalibrationRun='532008,532009',\r\n                                                        DerivationMethod='GlobalSummedReference2D',\r\n                                                        ExcludedRange=[-5,10],\r\n                                                        OutputWorkspace='calib',\r\n                                                        MaskCriterion=[0.3,3])\r\ncalibmax = mtd['calib'].extractY().flatten().max()\r\nassert(calibmax <= 3)\r\nSaveNexusProcessed(InputWorkspace='calib', Filename=CALIBFILE)\r\nws = PowderDiffILLDetScanReduction(Run = '535401,535402', Output2D=True, Output1D=False, CalibrationFile=CALIBFILE)\r\n```\r\n\r\n![screen shot 2018-04-24 at 10 26 29](https://user-images.githubusercontent.com/16865759/39175467-b2dc9c0c-47aa-11e8-938c-cd353a633655.png)\r\n\r\n[files4PR.tar.gz.zip](https://github.com/mantidproject/mantid/files/1941715/files4PR.tar.gz.zip)\r\n\r\n<!-- Instructions for testing. -->\r\n\r\nAlso merge [PR#110](https://github.com/mantidproject/mantidgeometry/pull/110).\r\nFixes #22274 . <!-- and fix #xxxx or close #xxxx xor resolves #xxxx -->\r\n\r\n**Release Notes** \r\n<!--\r\nEither edit the file in docs/source/release/... and it will be in your pull request or state\r\n*Does not need to be in the release notes.*\r\n-->\r\n\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://www.mantidproject.org/Individual_Ticket_Testing)):\r\n\r\n##### Code Review #####\r\n\r\n- [ ] Is the code of an acceptable quality?\r\n- [ ] Does the code conform to the [coding standards](http://www.mantidproject.org/Coding_Standards)?\r\n- [ ] Are the unit tests small and test the class in isolation?\r\n- [ ] If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- [ ] Do changes function as described? Add comments below that describe the tests performed?\r\n- [ ] Do the changes handle unexpected situations, e.g. bad input?\r\n- [ ] Has the relevant (user and developer) documentation been added/updated?\r\n\r\nDoes everything look good? Mark the review as **Approve**. A member of `@mantidproject/gatekeepers` will take care of it.","created_at":"2018-04-20T11:25:42Z","updated_at":"2018-05-18T12:40:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e39a79696d0b99c765123463fcbbda1db9dd1bc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":40046181,"url":"https://api.github.com/repos/mantidproject/mantid/labels/Component:%20Diffraction","name":"Component: Diffraction","color":"009800","default":false}],"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/67","html_url":"https://github.com/mantidproject/mantid/milestone/67","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/67/labels","id":3113719,"number":67,"title":"Release 3.13","description":"Code Freeze: 29th June\r\nBeta Test: 3rd-17th July","creator":{"login":"NickDraper","id":1017173,"avatar_url":"https://avatars1.githubusercontent.com/u/1017173?v=4","gravatar_id":"","url":"https://api.github.com/users/NickDraper","html_url":"https://github.com/NickDraper","followers_url":"https://api.github.com/users/NickDraper/followers","following_url":"https://api.github.com/users/NickDraper/following{/other_user}","gists_url":"https://api.github.com/users/NickDraper/gists{/gist_id}","starred_url":"https://api.github.com/users/NickDraper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickDraper/subscriptions","organizations_url":"https://api.github.com/users/NickDraper/orgs","repos_url":"https://api.github.com/users/NickDraper/repos","events_url":"https://api.github.com/users/NickDraper/events{/privacy}","received_events_url":"https://api.github.com/users/NickDraper/received_events","type":"User","site_admin":false},"open_issues":300,"closed_issues":222,"state":"open","created_at":"2018-02-13T15:37:12Z","updated_at":"2018-05-18T10:56:55Z","due_on":"2018-07-23T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/mantidproject/mantid/pulls/22316/commits","review_comments_url":"https://api.github.com/repos/mantidproject/mantid/pulls/22316/comments","review_comment_url":"https://api.github.com/repos/mantidproject/mantid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/22316/comments","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/bd6e275137bdaff75339c903c5766d616ab92e7d","head":{"label":"mantidproject:22274_d2b_reduction_alignment","ref":"22274_d2b_reduction_alignment","sha":"bd6e275137bdaff75339c903c5766d616ab92e7d","user":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars0.githubusercontent.com/u/671496?v=4","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"repo":{"id":2594116,"name":"mantid","full_name":"mantidproject/mantid","owner":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars0.githubusercontent.com/u/671496?v=4","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mantidproject/mantid","description":"Main repository for Mantid code","fork":false,"url":"https://api.github.com/repos/mantidproject/mantid","forks_url":"https://api.github.com/repos/mantidproject/mantid/forks","keys_url":"https://api.github.com/repos/mantidproject/mantid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mantidproject/mantid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mantidproject/mantid/teams","hooks_url":"https://api.github.com/repos/mantidproject/mantid/hooks","issue_events_url":"https://api.github.com/repos/mantidproject/mantid/issues/events{/number}","events_url":"https://api.github.com/repos/mantidproject/mantid/events","assignees_url":"https://api.github.com/repos/mantidproject/mantid/assignees{/user}","branches_url":"https://api.github.com/repos/mantidproject/mantid/branches{/branch}","tags_url":"https://api.github.com/repos/mantidproject/mantid/tags","blobs_url":"https://api.github.com/repos/mantidproject/mantid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mantidproject/mantid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mantidproject/mantid/git/refs{/sha}","trees_url":"https://api.github.com/repos/mantidproject/mantid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/{sha}","languages_url":"https://api.github.com/repos/mantidproject/mantid/languages","stargazers_url":"https://api.github.com/repos/mantidproject/mantid/stargazers","contributors_url":"https://api.github.com/repos/mantidproject/mantid/contributors","subscribers_url":"https://api.github.com/repos/mantidproject/mantid/subscribers","subscription_url":"https://api.github.com/repos/mantidproject/mantid/subscription","commits_url":"https://api.github.com/repos/mantidproject/mantid/commits{/sha}","git_commits_url":"https://api.github.com/repos/mantidproject/mantid/git/commits{/sha}","comments_url":"https://api.github.com/repos/mantidproject/mantid/comments{/number}","issue_comment_url":"https://api.github.com/repos/mantidproject/mantid/issues/comments{/number}","contents_url":"https://api.github.com/repos/mantidproject/mantid/contents/{+path}","compare_url":"https://api.github.com/repos/mantidproject/mantid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mantidproject/mantid/merges","archive_url":"https://api.github.com/repos/mantidproject/mantid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mantidproject/mantid/downloads","issues_url":"https://api.github.com/repos/mantidproject/mantid/issues{/number}","pulls_url":"https://api.github.com/repos/mantidproject/mantid/pulls{/number}","milestones_url":"https://api.github.com/repos/mantidproject/mantid/milestones{/number}","notifications_url":"https://api.github.com/repos/mantidproject/mantid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mantidproject/mantid/labels{/name}","releases_url":"https://api.github.com/repos/mantidproject/mantid/releases{/id}","deployments_url":"https://api.github.com/repos/mantidproject/mantid/deployments","created_at":"2011-10-17T19:07:38Z","updated_at":"2018-05-16T13:50:39Z","pushed_at":"2018-05-18T12:15:32Z","git_url":"git://github.com/mantidproject/mantid.git","ssh_url":"git@github.com:mantidproject/mantid.git","clone_url":"https://github.com/mantidproject/mantid.git","svn_url":"https://github.com/mantidproject/mantid","homepage":"www.mantidproject.org","size":482295,"stargazers_count":71,"watchers_count":71,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"archived":false,"open_issues_count":1801,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":55,"open_issues":1801,"watchers":71,"default_branch":"master"}},"base":{"label":"mantidproject:master","ref":"master","sha":"19526909ad2a1edf0e137b58f6be9b6dd2b9194e","user":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars0.githubusercontent.com/u/671496?v=4","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"repo":{"id":2594116,"name":"mantid","full_name":"mantidproject/mantid","owner":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars0.githubusercontent.com/u/671496?v=4","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mantidproject/mantid","description":"Main repository for Mantid code","fork":false,"url":"https://api.github.com/repos/mantidproject/mantid","forks_url":"https://api.github.com/repos/mantidproject/mantid/forks","keys_url":"https://api.github.com/repos/mantidproject/mantid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mantidproject/mantid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mantidproject/mantid/teams","hooks_url":"https://api.github.com/repos/mantidproject/mantid/hooks","issue_events_url":"https://api.github.com/repos/mantidproject/mantid/issues/events{/number}","events_url":"https://api.github.com/repos/mantidproject/mantid/events","assignees_url":"https://api.github.com/repos/mantidproject/mantid/assignees{/user}","branches_url":"https://api.github.com/repos/mantidproject/mantid/branches{/branch}","tags_url":"https://api.github.com/repos/mantidproject/mantid/tags","blobs_url":"https://api.github.com/repos/mantidproject/mantid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mantidproject/mantid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mantidproject/mantid/git/refs{/sha}","trees_url":"https://api.github.com/repos/mantidproject/mantid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/{sha}","languages_url":"https://api.github.com/repos/mantidproject/mantid/languages","stargazers_url":"https://api.github.com/repos/mantidproject/mantid/stargazers","contributors_url":"https://api.github.com/repos/mantidproject/mantid/contributors","subscribers_url":"https://api.github.com/repos/mantidproject/mantid/subscribers","subscription_url":"https://api.github.com/repos/mantidproject/mantid/subscription","commits_url":"https://api.github.com/repos/mantidproject/mantid/commits{/sha}","git_commits_url":"https://api.github.com/repos/mantidproject/mantid/git/commits{/sha}","comments_url":"https://api.github.com/repos/mantidproject/mantid/comments{/number}","issue_comment_url":"https://api.github.com/repos/mantidproject/mantid/issues/comments{/number}","contents_url":"https://api.github.com/repos/mantidproject/mantid/contents/{+path}","compare_url":"https://api.github.com/repos/mantidproject/mantid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mantidproject/mantid/merges","archive_url":"https://api.github.com/repos/mantidproject/mantid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mantidproject/mantid/downloads","issues_url":"https://api.github.com/repos/mantidproject/mantid/issues{/number}","pulls_url":"https://api.github.com/repos/mantidproject/mantid/pulls{/number}","milestones_url":"https://api.github.com/repos/mantidproject/mantid/milestones{/number}","notifications_url":"https://api.github.com/repos/mantidproject/mantid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mantidproject/mantid/labels{/name}","releases_url":"https://api.github.com/repos/mantidproject/mantid/releases{/id}","deployments_url":"https://api.github.com/repos/mantidproject/mantid/deployments","created_at":"2011-10-17T19:07:38Z","updated_at":"2018-05-16T13:50:39Z","pushed_at":"2018-05-18T12:15:32Z","git_url":"git://github.com/mantidproject/mantid.git","ssh_url":"git@github.com:mantidproject/mantid.git","clone_url":"https://github.com/mantidproject/mantid.git","svn_url":"https://github.com/mantidproject/mantid","homepage":"www.mantidproject.org","size":482295,"stargazers_count":71,"watchers_count":71,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"archived":false,"open_issues_count":1801,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":55,"open_issues":1801,"watchers":71,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/22316"},"html":{"href":"https://github.com/mantidproject/mantid/pull/22316"},"issue":{"href":"https://api.github.com/repos/mantidproject/mantid/issues/22316"},"comments":{"href":"https://api.github.com/repos/mantidproject/mantid/issues/22316/comments"},"review_comments":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/22316/comments"},"review_comment":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/22316/commits"},"statuses":{"href":"https://api.github.com/repos/mantidproject/mantid/statuses/bd6e275137bdaff75339c903c5766d616ab92e7d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"reimundILL"}}