{"action":"created","comment":{"url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/comments/166782701","pull_request_review_id":94901312,"id":166782701,"diff_hunk":"@@ -31,40 +32,59 @@ all: docker\n gobuild:\n \t./scripts/build false\n \n+# create output directories\n+.out-stamp:","path":"Makefile","position":16,"original_position":16,"commit_id":"bdd055f6186a6a806984c55dcb317f0a4640aa74","original_commit_id":"b7899a1447836ccad6cb31162473ea4794e7d98a","user":{"login":"petderek","id":1487156,"avatar_url":"https://avatars3.githubusercontent.com/u/1487156?v=4","gravatar_id":"","url":"https://api.github.com/users/petderek","html_url":"https://github.com/petderek","followers_url":"https://api.github.com/users/petderek/followers","following_url":"https://api.github.com/users/petderek/following{/other_user}","gists_url":"https://api.github.com/users/petderek/gists{/gist_id}","starred_url":"https://api.github.com/users/petderek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petderek/subscriptions","organizations_url":"https://api.github.com/users/petderek/orgs","repos_url":"https://api.github.com/users/petderek/repos","events_url":"https://api.github.com/users/petderek/events{/privacy}","received_events_url":"https://api.github.com/users/petderek/received_events","type":"User","site_admin":false},"body":"Yep! It creates a file called `.out-stamp` that tells `make` not to rerun this step.","created_at":"2018-02-07T22:51:38Z","updated_at":"2018-02-07T22:51:38Z","html_url":"https://github.com/aws/amazon-ecs-agent/pull/1173#discussion_r166782701","pull_request_url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/1173","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/comments/166782701"},"html":{"href":"https://github.com/aws/amazon-ecs-agent/pull/1173#discussion_r166782701"},"pull_request":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/1173"}},"in_reply_to_id":166725613},"pull_request":{"url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/1173","id":162210802,"html_url":"https://github.com/aws/amazon-ecs-agent/pull/1173","diff_url":"https://github.com/aws/amazon-ecs-agent/pull/1173.diff","patch_url":"https://github.com/aws/amazon-ecs-agent/pull/1173.patch","issue_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/1173","number":1173,"state":"open","locked":false,"title":"Generate binaries and tests using AWS Codebuild","user":{"login":"petderek","id":1487156,"avatar_url":"https://avatars3.githubusercontent.com/u/1487156?v=4","gravatar_id":"","url":"https://api.github.com/users/petderek","html_url":"https://github.com/petderek","followers_url":"https://api.github.com/users/petderek/followers","following_url":"https://api.github.com/users/petderek/following{/other_user}","gists_url":"https://api.github.com/users/petderek/gists{/gist_id}","starred_url":"https://api.github.com/users/petderek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petderek/subscriptions","organizations_url":"https://api.github.com/users/petderek/orgs","repos_url":"https://api.github.com/users/petderek/repos","events_url":"https://api.github.com/users/petderek/events{/privacy}","received_events_url":"https://api.github.com/users/petderek/received_events","type":"User","site_admin":false},"body":"### Summary \r\nProvides base layer of infrastructure for cross-compiling windows binaries on linux. This is only used in testing for now, but its in a good place where we could extend this to automate builds.\r\n\r\n### Implementation\r\nThis provides the following:\r\n- A makefile target that does the following:\r\n  - compiles linux tarball and cni plugins\r\n  - compiles windows zipfile\r\n  - compiles all functional and integration test binaries\r\n- A codebuild buildspec used to automate the compile step\r\n- Some fixes to the build tooling to make sure that 'root' doesn't own the artifacts\r\n\r\nWhen run with `make codebuild`, your out directory will result:\r\n\r\n```\r\nout\r\n├── amazon-ecs-agent\r\n├── amazon-ecs-agent.exe\r\n├── amazon-ecs-pause.tar\r\n├── cni-plugins\r\n│   ├── ecs-bridge\r\n│   ├── ecs-eni\r\n│   └── ecs-ipam\r\n├── ecs-agent.tar\r\n├── ecs-agent-windows.zip\r\n└── test-artifacts\r\n    ├── unix-app-tests\r\n    ├── unix-engine-tests\r\n    ├── unix-handwritten-tests\r\n    ├── unix-simple-tests\r\n    ├── unix-stats-tests\r\n    ├── windows-app-tests.exe\r\n    ├── windows-engine-tests.exe\r\n    ├── windows-handwritten-tests.exe\r\n    ├── windows-simple-tests.exe\r\n    └── windows-stats-tests.exe\r\n```\r\n\r\n### Licensing\r\n<!--\r\nPlease confirm that this contribution is under the terms of the Apache 2.0\r\nLicense.\r\n-->\r\nThis contribution is under the terms of the Apache 2.0 License: yes\r\n","created_at":"2018-01-10T19:33:47Z","updated_at":"2018-02-07T22:51:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"996a4975b966714ad975c86fec0e1f425572dafd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/1173/commits","review_comments_url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/1173/comments","review_comment_url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/1173/comments","statuses_url":"https://api.github.com/repos/aws/amazon-ecs-agent/statuses/bdd055f6186a6a806984c55dcb317f0a4640aa74","head":{"label":"petderek:build-artifacts","ref":"build-artifacts","sha":"bdd055f6186a6a806984c55dcb317f0a4640aa74","user":{"login":"petderek","id":1487156,"avatar_url":"https://avatars3.githubusercontent.com/u/1487156?v=4","gravatar_id":"","url":"https://api.github.com/users/petderek","html_url":"https://github.com/petderek","followers_url":"https://api.github.com/users/petderek/followers","following_url":"https://api.github.com/users/petderek/following{/other_user}","gists_url":"https://api.github.com/users/petderek/gists{/gist_id}","starred_url":"https://api.github.com/users/petderek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petderek/subscriptions","organizations_url":"https://api.github.com/users/petderek/orgs","repos_url":"https://api.github.com/users/petderek/repos","events_url":"https://api.github.com/users/petderek/events{/privacy}","received_events_url":"https://api.github.com/users/petderek/received_events","type":"User","site_admin":false},"repo":{"id":76498663,"name":"amazon-ecs-agent","full_name":"petderek/amazon-ecs-agent","owner":{"login":"petderek","id":1487156,"avatar_url":"https://avatars3.githubusercontent.com/u/1487156?v=4","gravatar_id":"","url":"https://api.github.com/users/petderek","html_url":"https://github.com/petderek","followers_url":"https://api.github.com/users/petderek/followers","following_url":"https://api.github.com/users/petderek/following{/other_user}","gists_url":"https://api.github.com/users/petderek/gists{/gist_id}","starred_url":"https://api.github.com/users/petderek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petderek/subscriptions","organizations_url":"https://api.github.com/users/petderek/orgs","repos_url":"https://api.github.com/users/petderek/repos","events_url":"https://api.github.com/users/petderek/events{/privacy}","received_events_url":"https://api.github.com/users/petderek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/petderek/amazon-ecs-agent","description":"Amazon EC2 Container Service Agent","fork":true,"url":"https://api.github.com/repos/petderek/amazon-ecs-agent","forks_url":"https://api.github.com/repos/petderek/amazon-ecs-agent/forks","keys_url":"https://api.github.com/repos/petderek/amazon-ecs-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/petderek/amazon-ecs-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/petderek/amazon-ecs-agent/teams","hooks_url":"https://api.github.com/repos/petderek/amazon-ecs-agent/hooks","issue_events_url":"https://api.github.com/repos/petderek/amazon-ecs-agent/issues/events{/number}","events_url":"https://api.github.com/repos/petderek/amazon-ecs-agent/events","assignees_url":"https://api.github.com/repos/petderek/amazon-ecs-agent/assignees{/user}","branches_url":"https://api.github.com/repos/petderek/amazon-ecs-agent/branches{/branch}","tags_url":"https://api.github.com/repos/petderek/amazon-ecs-agent/tags","blobs_url":"https://api.github.com/repos/petderek/amazon-ecs-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/petderek/amazon-ecs-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/petderek/amazon-ecs-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/petderek/amazon-ecs-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/petderek/amazon-ecs-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/petderek/amazon-ecs-agent/languages","stargazers_url":"https://api.github.com/repos/petderek/amazon-ecs-agent/stargazers","contributors_url":"https://api.github.com/repos/petderek/amazon-ecs-agent/contributors","subscribers_url":"https://api.github.com/repos/petderek/amazon-ecs-agent/subscribers","subscription_url":"https://api.github.com/repos/petderek/amazon-ecs-agent/subscription","commits_url":"https://api.github.com/repos/petderek/amazon-ecs-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/petderek/amazon-ecs-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/petderek/amazon-ecs-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/petderek/amazon-ecs-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/petderek/amazon-ecs-agent/contents/{+path}","compare_url":"https://api.github.com/repos/petderek/amazon-ecs-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/petderek/amazon-ecs-agent/merges","archive_url":"https://api.github.com/repos/petderek/amazon-ecs-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/petderek/amazon-ecs-agent/downloads","issues_url":"https://api.github.com/repos/petderek/amazon-ecs-agent/issues{/number}","pulls_url":"https://api.github.com/repos/petderek/amazon-ecs-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/petderek/amazon-ecs-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/petderek/amazon-ecs-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/petderek/amazon-ecs-agent/labels{/name}","releases_url":"https://api.github.com/repos/petderek/amazon-ecs-agent/releases{/id}","deployments_url":"https://api.github.com/repos/petderek/amazon-ecs-agent/deployments","created_at":"2016-12-14T21:31:01Z","updated_at":"2016-12-14T21:31:03Z","pushed_at":"2018-02-07T19:18:25Z","git_url":"git://github.com/petderek/amazon-ecs-agent.git","ssh_url":"git@github.com:petderek/amazon-ecs-agent.git","clone_url":"https://github.com/petderek/amazon-ecs-agent.git","svn_url":"https://github.com/petderek/amazon-ecs-agent","homepage":"http://aws.amazon.com/ecs/","size":28789,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aws:dev","ref":"dev","sha":"2bf4348a0ff89e23be4e82a6c5ff28edf777092c","user":{"login":"aws","id":2232217,"avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"repo":{"id":27551774,"name":"amazon-ecs-agent","full_name":"aws/amazon-ecs-agent","owner":{"login":"aws","id":2232217,"avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aws/amazon-ecs-agent","description":"Amazon Elastic Container Service Agent","fork":false,"url":"https://api.github.com/repos/aws/amazon-ecs-agent","forks_url":"https://api.github.com/repos/aws/amazon-ecs-agent/forks","keys_url":"https://api.github.com/repos/aws/amazon-ecs-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aws/amazon-ecs-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aws/amazon-ecs-agent/teams","hooks_url":"https://api.github.com/repos/aws/amazon-ecs-agent/hooks","issue_events_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/events{/number}","events_url":"https://api.github.com/repos/aws/amazon-ecs-agent/events","assignees_url":"https://api.github.com/repos/aws/amazon-ecs-agent/assignees{/user}","branches_url":"https://api.github.com/repos/aws/amazon-ecs-agent/branches{/branch}","tags_url":"https://api.github.com/repos/aws/amazon-ecs-agent/tags","blobs_url":"https://api.github.com/repos/aws/amazon-ecs-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aws/amazon-ecs-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aws/amazon-ecs-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/aws/amazon-ecs-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aws/amazon-ecs-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/aws/amazon-ecs-agent/languages","stargazers_url":"https://api.github.com/repos/aws/amazon-ecs-agent/stargazers","contributors_url":"https://api.github.com/repos/aws/amazon-ecs-agent/contributors","subscribers_url":"https://api.github.com/repos/aws/amazon-ecs-agent/subscribers","subscription_url":"https://api.github.com/repos/aws/amazon-ecs-agent/subscription","commits_url":"https://api.github.com/repos/aws/amazon-ecs-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/aws/amazon-ecs-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/aws/amazon-ecs-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/aws/amazon-ecs-agent/contents/{+path}","compare_url":"https://api.github.com/repos/aws/amazon-ecs-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aws/amazon-ecs-agent/merges","archive_url":"https://api.github.com/repos/aws/amazon-ecs-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aws/amazon-ecs-agent/downloads","issues_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues{/number}","pulls_url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/aws/amazon-ecs-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/aws/amazon-ecs-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aws/amazon-ecs-agent/labels{/name}","releases_url":"https://api.github.com/repos/aws/amazon-ecs-agent/releases{/id}","deployments_url":"https://api.github.com/repos/aws/amazon-ecs-agent/deployments","created_at":"2014-12-04T17:31:49Z","updated_at":"2018-02-05T06:26:21Z","pushed_at":"2018-02-07T21:56:29Z","git_url":"git://github.com/aws/amazon-ecs-agent.git","ssh_url":"git@github.com:aws/amazon-ecs-agent.git","clone_url":"https://github.com/aws/amazon-ecs-agent.git","svn_url":"https://github.com/aws/amazon-ecs-agent","homepage":"http://aws.amazon.com/ecs/","size":28776,"stargazers_count":1142,"watchers_count":1142,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":295,"mirror_url":null,"archived":false,"open_issues_count":110,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":295,"open_issues":110,"watchers":1142,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/1173"},"html":{"href":"https://github.com/aws/amazon-ecs-agent/pull/1173"},"issue":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/1173"},"comments":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/1173/comments"},"review_comments":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/1173/comments"},"review_comment":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/1173/commits"},"statuses":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/statuses/bdd055f6186a6a806984c55dcb317f0a4640aa74"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"petderek"}}