{"action":"created","issue":{"url":"https://api.github.com/repos/Yoast/yoast-components/issues/671","repository_url":"https://api.github.com/repos/Yoast/yoast-components","labels_url":"https://api.github.com/repos/Yoast/yoast-components/issues/671/labels{/name}","comments_url":"https://api.github.com/repos/Yoast/yoast-components/issues/671/comments","events_url":"https://api.github.com/repos/Yoast/yoast-components/issues/671/events","html_url":"https://github.com/Yoast/yoast-components/issues/671","id":344381966,"node_id":"MDU6SXNzdWUzNDQzODE5NjY=","number":671,"title":"Styling improvements for the Analysis results. ","user":{"login":"boblinthorst","id":11849359,"node_id":"MDQ6VXNlcjExODQ5MzU5","avatar_url":"https://avatars3.githubusercontent.com/u/11849359?v=4","gravatar_id":"","url":"https://api.github.com/users/boblinthorst","html_url":"https://github.com/boblinthorst","followers_url":"https://api.github.com/users/boblinthorst/followers","following_url":"https://api.github.com/users/boblinthorst/following{/other_user}","gists_url":"https://api.github.com/users/boblinthorst/gists{/gist_id}","starred_url":"https://api.github.com/users/boblinthorst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boblinthorst/subscriptions","organizations_url":"https://api.github.com/users/boblinthorst/orgs","repos_url":"https://api.github.com/users/boblinthorst/repos","events_url":"https://api.github.com/users/boblinthorst/events{/privacy}","received_events_url":"https://api.github.com/users/boblinthorst/received_events","type":"User","site_admin":false},"labels":[{"id":903154430,"node_id":"MDU6TGFiZWw5MDMxNTQ0MzA=","url":"https://api.github.com/repos/Yoast/yoast-components/labels/design%20in%20progress","name":"design in progress","color":"ededed","default":false},{"id":987994698,"node_id":"MDU6TGFiZWw5ODc5OTQ2OTg=","url":"https://api.github.com/repos/Yoast/yoast-components/labels/next","name":"next","color":"1a4f7a","default":false}],"state":"open","locked":false,"assignee":{"login":"hedgefield","id":6073772,"node_id":"MDQ6VXNlcjYwNzM3NzI=","avatar_url":"https://avatars0.githubusercontent.com/u/6073772?v=4","gravatar_id":"","url":"https://api.github.com/users/hedgefield","html_url":"https://github.com/hedgefield","followers_url":"https://api.github.com/users/hedgefield/followers","following_url":"https://api.github.com/users/hedgefield/following{/other_user}","gists_url":"https://api.github.com/users/hedgefield/gists{/gist_id}","starred_url":"https://api.github.com/users/hedgefield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hedgefield/subscriptions","organizations_url":"https://api.github.com/users/hedgefield/orgs","repos_url":"https://api.github.com/users/hedgefield/repos","events_url":"https://api.github.com/users/hedgefield/events{/privacy}","received_events_url":"https://api.github.com/users/hedgefield/received_events","type":"User","site_admin":false},"assignees":[{"login":"hedgefield","id":6073772,"node_id":"MDQ6VXNlcjYwNzM3NzI=","avatar_url":"https://avatars0.githubusercontent.com/u/6073772?v=4","gravatar_id":"","url":"https://api.github.com/users/hedgefield","html_url":"https://github.com/hedgefield","followers_url":"https://api.github.com/users/hedgefield/followers","following_url":"https://api.github.com/users/hedgefield/following{/other_user}","gists_url":"https://api.github.com/users/hedgefield/gists{/gist_id}","starred_url":"https://api.github.com/users/hedgefield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hedgefield/subscriptions","organizations_url":"https://api.github.com/users/hedgefield/orgs","repos_url":"https://api.github.com/users/hedgefield/repos","events_url":"https://api.github.com/users/hedgefield/events{/privacy}","received_events_url":"https://api.github.com/users/hedgefield/received_events","type":"User","site_admin":false},{"login":"maartenleenders","id":26220788,"node_id":"MDQ6VXNlcjI2MjIwNzg4","avatar_url":"https://avatars1.githubusercontent.com/u/26220788?v=4","gravatar_id":"","url":"https://api.github.com/users/maartenleenders","html_url":"https://github.com/maartenleenders","followers_url":"https://api.github.com/users/maartenleenders/followers","following_url":"https://api.github.com/users/maartenleenders/following{/other_user}","gists_url":"https://api.github.com/users/maartenleenders/gists{/gist_id}","starred_url":"https://api.github.com/users/maartenleenders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maartenleenders/subscriptions","organizations_url":"https://api.github.com/users/maartenleenders/orgs","repos_url":"https://api.github.com/users/maartenleenders/repos","events_url":"https://api.github.com/users/maartenleenders/events{/privacy}","received_events_url":"https://api.github.com/users/maartenleenders/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-07-25T10:16:30Z","updated_at":"2018-07-27T12:40:15Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Split off from https://github.com/Yoast/yoast-components/pull/492.\r\n\r\nThe PR became way too big, and addressing the styling comments in the PR would make it even bigger than it already is.\r\n\r\nIn the words of @maartenleenders:\r\nThe styling in the ContentAnalysis seems to be slightly below our standards, but that is my opinion. I think we'd do well to give everything a little more 'breathing room' with padding/margins. @hedgefield has offered to sit in on a little styling session to improve things. I would also be fine if you split this up into a new issue, as this PR has become quite big."},"comment":{"url":"https://api.github.com/repos/Yoast/yoast-components/issues/comments/408406964","html_url":"https://github.com/Yoast/yoast-components/issues/671#issuecomment-408406964","issue_url":"https://api.github.com/repos/Yoast/yoast-components/issues/671","id":408406964,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODQwNjk2NA==","user":{"login":"afercia","id":1682452,"node_id":"MDQ6VXNlcjE2ODI0NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1682452?v=4","gravatar_id":"","url":"https://api.github.com/users/afercia","html_url":"https://github.com/afercia","followers_url":"https://api.github.com/users/afercia/followers","following_url":"https://api.github.com/users/afercia/following{/other_user}","gists_url":"https://api.github.com/users/afercia/gists{/gist_id}","starred_url":"https://api.github.com/users/afercia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afercia/subscriptions","organizations_url":"https://api.github.com/users/afercia/orgs","repos_url":"https://api.github.com/users/afercia/repos","events_url":"https://api.github.com/users/afercia/events{/privacy}","received_events_url":"https://api.github.com/users/afercia/received_events","type":"User","site_admin":false},"created_at":"2018-07-27T12:40:15Z","updated_at":"2018-07-27T12:40:15Z","author_association":"CONTRIBUTOR","body":"One important thing to consider is that the ContentAnalysis uses a custom implementation of the \"collapsible header\", duplicating great part of the code. I'd tend to think it shouldn't do this, and just reuse the `Collapsible` component which is going to be refactored in #653 and #654 "}}
{"actor":{"display_login":"afercia"}}