{"action":"created","comment":{"url":"https://api.github.com/repos/DSpace/DSpace/pulls/comments/231060378","pull_request_review_id":171938204,"id":231060378,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTA2MDM3OA==","diff_hunk":"@@ -336,16 +353,30 @@ public MetadataImport(Context c, DSpaceCSV toImport) {\n                         item = wsItem.getItem();\n \n                         // Add the metadata to the item\n+                        List<BulkEditMetadataValue> relationships = new LinkedList<>();\n                         for (BulkEditMetadataValue dcv : whatHasChanged.getAdds()) {\n-                            itemService.addMetadata(c, item, dcv.getSchema(),\n-                                                    dcv.getElement(),\n-                                                    dcv.getQualifier(),\n-                                                    dcv.getLanguage(),\n-                                                    dcv.getValue(),\n-                                                    dcv.getAuthority(),\n-                                                    dcv.getConfidence());\n+                            if (StringUtils.equals(dcv.getSchema(), \"relation\")) {","path":"dspace-api/src/main/java/org/dspace/app/bulkedit/MetadataImport.java","position":66,"original_position":66,"commit_id":"75358b2bddd8111d84f9b505ed689b9900d6c3e0","original_commit_id":"75358b2bddd8111d84f9b505ed689b9900d6c3e0","user":{"login":"benbosman","id":1528033,"node_id":"MDQ6VXNlcjE1MjgwMzM=","avatar_url":"https://avatars2.githubusercontent.com/u/1528033?v=4","gravatar_id":"","url":"https://api.github.com/users/benbosman","html_url":"https://github.com/benbosman","followers_url":"https://api.github.com/users/benbosman/followers","following_url":"https://api.github.com/users/benbosman/following{/other_user}","gists_url":"https://api.github.com/users/benbosman/gists{/gist_id}","starred_url":"https://api.github.com/users/benbosman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benbosman/subscriptions","organizations_url":"https://api.github.com/users/benbosman/orgs","repos_url":"https://api.github.com/users/benbosman/repos","events_url":"https://api.github.com/users/benbosman/events{/privacy}","received_events_url":"https://api.github.com/users/benbosman/received_events","type":"User","site_admin":false},"body":"Alexander and Tim made the a similar recommendation.\r\nAt the moment, this schema for importing relations was only planned for the CSV import.","created_at":"2018-11-06T09:57:47Z","updated_at":"2018-11-06T09:57:47Z","html_url":"https://github.com/DSpace/DSpace/pull/2246#discussion_r231060378","pull_request_url":"https://api.github.com/repos/DSpace/DSpace/pulls/2246","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/DSpace/DSpace/pulls/comments/231060378"},"html":{"href":"https://github.com/DSpace/DSpace/pull/2246#discussion_r231060378"},"pull_request":{"href":"https://api.github.com/repos/DSpace/DSpace/pulls/2246"}},"in_reply_to_id":230900759},"pull_request":{"url":"https://api.github.com/repos/DSpace/DSpace/pulls/2246","id":225814774,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1ODE0Nzc0","html_url":"https://github.com/DSpace/DSpace/pull/2246","diff_url":"https://github.com/DSpace/DSpace/pull/2246.diff","patch_url":"https://github.com/DSpace/DSpace/pull/2246.patch","issue_url":"https://api.github.com/repos/DSpace/DSpace/issues/2246","number":2246,"state":"open","locked":false,"title":"Initial entities PR","user":{"login":"benbosman","id":1528033,"node_id":"MDQ6VXNlcjE1MjgwMzM=","avatar_url":"https://avatars2.githubusercontent.com/u/1528033?v=4","gravatar_id":"","url":"https://api.github.com/users/benbosman","html_url":"https://github.com/benbosman","followers_url":"https://api.github.com/users/benbosman/followers","following_url":"https://api.github.com/users/benbosman/following{/other_user}","gists_url":"https://api.github.com/users/benbosman/gists{/gist_id}","starred_url":"https://api.github.com/users/benbosman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benbosman/subscriptions","organizations_url":"https://api.github.com/users/benbosman/orgs","repos_url":"https://api.github.com/users/benbosman/repos","events_url":"https://api.github.com/users/benbosman/events{/privacy}","received_events_url":"https://api.github.com/users/benbosman/received_events","type":"User","site_admin":false},"body":"This is the initial PR for the REST entities functionality.\r\nIt contains integration tests and Javadocs, but there are still a few things included which will be cleaned up in the future.\r\nA few examples are:\r\n* Customizations specific to setting up the demo\r\n* Bugfixes in the master which are either already in another PR or not yet in another PR\r\n\r\nWe will further cleanup these things, but some will be dependent on other merges in the master\r\nDon't let this stop you from reviewing the functionality","created_at":"2018-10-25T15:55:14Z","updated_at":"2018-11-06T09:57:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b401eb24c95d5af05612b4cad906079887ab7128","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1104463995,"node_id":"MDU6TGFiZWwxMTA0NDYzOTk1","url":"https://api.github.com/repos/DSpace/DSpace/labels/component:%20entities%20(typed%20Items)","name":"component: entities (typed Items)","color":"e2c448","default":false},{"id":382524467,"node_id":"MDU6TGFiZWwzODI1MjQ0Njc=","url":"https://api.github.com/repos/DSpace/DSpace/labels/high%20priority","name":"high priority","color":"b60205","default":false},{"id":121598171,"node_id":"MDU6TGFiZWwxMjE1OTgxNzE=","url":"https://api.github.com/repos/DSpace/DSpace/labels/new%20feature","name":"new feature","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DSpace/DSpace/pulls/2246/commits","review_comments_url":"https://api.github.com/repos/DSpace/DSpace/pulls/2246/comments","review_comment_url":"https://api.github.com/repos/DSpace/DSpace/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DSpace/DSpace/issues/2246/comments","statuses_url":"https://api.github.com/repos/DSpace/DSpace/statuses/75358b2bddd8111d84f9b505ed689b9900d6c3e0","head":{"label":"atmire:entities-PR2","ref":"entities-PR2","sha":"75358b2bddd8111d84f9b505ed689b9900d6c3e0","user":{"login":"atmire","id":913833,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxMzgzMw==","avatar_url":"https://avatars0.githubusercontent.com/u/913833?v=4","gravatar_id":"","url":"https://api.github.com/users/atmire","html_url":"https://github.com/atmire","followers_url":"https://api.github.com/users/atmire/followers","following_url":"https://api.github.com/users/atmire/following{/other_user}","gists_url":"https://api.github.com/users/atmire/gists{/gist_id}","starred_url":"https://api.github.com/users/atmire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atmire/subscriptions","organizations_url":"https://api.github.com/users/atmire/orgs","repos_url":"https://api.github.com/users/atmire/repos","events_url":"https://api.github.com/users/atmire/events{/privacy}","received_events_url":"https://api.github.com/users/atmire/received_events","type":"Organization","site_admin":false},"repo":{"id":5181954,"node_id":"MDEwOlJlcG9zaXRvcnk1MTgxOTU0","name":"DSpace","full_name":"atmire/DSpace","private":false,"owner":{"login":"atmire","id":913833,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxMzgzMw==","avatar_url":"https://avatars0.githubusercontent.com/u/913833?v=4","gravatar_id":"","url":"https://api.github.com/users/atmire","html_url":"https://github.com/atmire","followers_url":"https://api.github.com/users/atmire/followers","following_url":"https://api.github.com/users/atmire/following{/other_user}","gists_url":"https://api.github.com/users/atmire/gists{/gist_id}","starred_url":"https://api.github.com/users/atmire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atmire/subscriptions","organizations_url":"https://api.github.com/users/atmire/orgs","repos_url":"https://api.github.com/users/atmire/repos","events_url":"https://api.github.com/users/atmire/events{/privacy}","received_events_url":"https://api.github.com/users/atmire/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/atmire/DSpace","description":"(Official) The DSpace digital asset management system that powers your Institutional Repository","fork":true,"url":"https://api.github.com/repos/atmire/DSpace","forks_url":"https://api.github.com/repos/atmire/DSpace/forks","keys_url":"https://api.github.com/repos/atmire/DSpace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atmire/DSpace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atmire/DSpace/teams","hooks_url":"https://api.github.com/repos/atmire/DSpace/hooks","issue_events_url":"https://api.github.com/repos/atmire/DSpace/issues/events{/number}","events_url":"https://api.github.com/repos/atmire/DSpace/events","assignees_url":"https://api.github.com/repos/atmire/DSpace/assignees{/user}","branches_url":"https://api.github.com/repos/atmire/DSpace/branches{/branch}","tags_url":"https://api.github.com/repos/atmire/DSpace/tags","blobs_url":"https://api.github.com/repos/atmire/DSpace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atmire/DSpace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atmire/DSpace/git/refs{/sha}","trees_url":"https://api.github.com/repos/atmire/DSpace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atmire/DSpace/statuses/{sha}","languages_url":"https://api.github.com/repos/atmire/DSpace/languages","stargazers_url":"https://api.github.com/repos/atmire/DSpace/stargazers","contributors_url":"https://api.github.com/repos/atmire/DSpace/contributors","subscribers_url":"https://api.github.com/repos/atmire/DSpace/subscribers","subscription_url":"https://api.github.com/repos/atmire/DSpace/subscription","commits_url":"https://api.github.com/repos/atmire/DSpace/commits{/sha}","git_commits_url":"https://api.github.com/repos/atmire/DSpace/git/commits{/sha}","comments_url":"https://api.github.com/repos/atmire/DSpace/comments{/number}","issue_comment_url":"https://api.github.com/repos/atmire/DSpace/issues/comments{/number}","contents_url":"https://api.github.com/repos/atmire/DSpace/contents/{+path}","compare_url":"https://api.github.com/repos/atmire/DSpace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atmire/DSpace/merges","archive_url":"https://api.github.com/repos/atmire/DSpace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atmire/DSpace/downloads","issues_url":"https://api.github.com/repos/atmire/DSpace/issues{/number}","pulls_url":"https://api.github.com/repos/atmire/DSpace/pulls{/number}","milestones_url":"https://api.github.com/repos/atmire/DSpace/milestones{/number}","notifications_url":"https://api.github.com/repos/atmire/DSpace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atmire/DSpace/labels{/name}","releases_url":"https://api.github.com/repos/atmire/DSpace/releases{/id}","deployments_url":"https://api.github.com/repos/atmire/DSpace/deployments","created_at":"2012-07-25T17:00:10Z","updated_at":"2018-10-19T08:19:35Z","pushed_at":"2018-11-05T13:03:07Z","git_url":"git://github.com/atmire/DSpace.git","ssh_url":"git@github.com:atmire/DSpace.git","clone_url":"https://github.com/atmire/DSpace.git","svn_url":"https://github.com/atmire/DSpace","homepage":"https://wiki.duraspace.org/display/DSDOC18/Introduction","size":136730,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":7,"open_issues":2,"watchers":2,"default_branch":"master"}},"base":{"label":"DSpace:configurable_entities","ref":"configurable_entities","sha":"bd9bd233b762762d3866a653ff95fc598cc723c5","user":{"login":"DSpace","id":428620,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyODYyMA==","avatar_url":"https://avatars3.githubusercontent.com/u/428620?v=4","gravatar_id":"","url":"https://api.github.com/users/DSpace","html_url":"https://github.com/DSpace","followers_url":"https://api.github.com/users/DSpace/followers","following_url":"https://api.github.com/users/DSpace/following{/other_user}","gists_url":"https://api.github.com/users/DSpace/gists{/gist_id}","starred_url":"https://api.github.com/users/DSpace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DSpace/subscriptions","organizations_url":"https://api.github.com/users/DSpace/orgs","repos_url":"https://api.github.com/users/DSpace/repos","events_url":"https://api.github.com/users/DSpace/events{/privacy}","received_events_url":"https://api.github.com/users/DSpace/received_events","type":"Organization","site_admin":false},"repo":{"id":3743376,"node_id":"MDEwOlJlcG9zaXRvcnkzNzQzMzc2","name":"DSpace","full_name":"DSpace/DSpace","private":false,"owner":{"login":"DSpace","id":428620,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyODYyMA==","avatar_url":"https://avatars3.githubusercontent.com/u/428620?v=4","gravatar_id":"","url":"https://api.github.com/users/DSpace","html_url":"https://github.com/DSpace","followers_url":"https://api.github.com/users/DSpace/followers","following_url":"https://api.github.com/users/DSpace/following{/other_user}","gists_url":"https://api.github.com/users/DSpace/gists{/gist_id}","starred_url":"https://api.github.com/users/DSpace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DSpace/subscriptions","organizations_url":"https://api.github.com/users/DSpace/orgs","repos_url":"https://api.github.com/users/DSpace/repos","events_url":"https://api.github.com/users/DSpace/events{/privacy}","received_events_url":"https://api.github.com/users/DSpace/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DSpace/DSpace","description":"(Official) The DSpace digital asset management system that powers your Institutional Repository","fork":false,"url":"https://api.github.com/repos/DSpace/DSpace","forks_url":"https://api.github.com/repos/DSpace/DSpace/forks","keys_url":"https://api.github.com/repos/DSpace/DSpace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DSpace/DSpace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DSpace/DSpace/teams","hooks_url":"https://api.github.com/repos/DSpace/DSpace/hooks","issue_events_url":"https://api.github.com/repos/DSpace/DSpace/issues/events{/number}","events_url":"https://api.github.com/repos/DSpace/DSpace/events","assignees_url":"https://api.github.com/repos/DSpace/DSpace/assignees{/user}","branches_url":"https://api.github.com/repos/DSpace/DSpace/branches{/branch}","tags_url":"https://api.github.com/repos/DSpace/DSpace/tags","blobs_url":"https://api.github.com/repos/DSpace/DSpace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DSpace/DSpace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DSpace/DSpace/git/refs{/sha}","trees_url":"https://api.github.com/repos/DSpace/DSpace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DSpace/DSpace/statuses/{sha}","languages_url":"https://api.github.com/repos/DSpace/DSpace/languages","stargazers_url":"https://api.github.com/repos/DSpace/DSpace/stargazers","contributors_url":"https://api.github.com/repos/DSpace/DSpace/contributors","subscribers_url":"https://api.github.com/repos/DSpace/DSpace/subscribers","subscription_url":"https://api.github.com/repos/DSpace/DSpace/subscription","commits_url":"https://api.github.com/repos/DSpace/DSpace/commits{/sha}","git_commits_url":"https://api.github.com/repos/DSpace/DSpace/git/commits{/sha}","comments_url":"https://api.github.com/repos/DSpace/DSpace/comments{/number}","issue_comment_url":"https://api.github.com/repos/DSpace/DSpace/issues/comments{/number}","contents_url":"https://api.github.com/repos/DSpace/DSpace/contents/{+path}","compare_url":"https://api.github.com/repos/DSpace/DSpace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DSpace/DSpace/merges","archive_url":"https://api.github.com/repos/DSpace/DSpace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DSpace/DSpace/downloads","issues_url":"https://api.github.com/repos/DSpace/DSpace/issues{/number}","pulls_url":"https://api.github.com/repos/DSpace/DSpace/pulls{/number}","milestones_url":"https://api.github.com/repos/DSpace/DSpace/milestones{/number}","notifications_url":"https://api.github.com/repos/DSpace/DSpace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DSpace/DSpace/labels{/name}","releases_url":"https://api.github.com/repos/DSpace/DSpace/releases{/id}","deployments_url":"https://api.github.com/repos/DSpace/DSpace/deployments","created_at":"2012-03-16T21:44:52Z","updated_at":"2018-11-02T23:38:11Z","pushed_at":"2018-11-06T00:05:48Z","git_url":"git://github.com/DSpace/DSpace.git","ssh_url":"git@github.com:DSpace/DSpace.git","clone_url":"https://github.com/DSpace/DSpace.git","svn_url":"https://github.com/DSpace/DSpace","homepage":"https://wiki.duraspace.org/display/DSDOC6x/Introduction","size":133588,"stargazers_count":406,"watchers_count":406,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":828,"mirror_url":null,"archived":false,"open_issues_count":174,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":828,"open_issues":174,"watchers":406,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DSpace/DSpace/pulls/2246"},"html":{"href":"https://github.com/DSpace/DSpace/pull/2246"},"issue":{"href":"https://api.github.com/repos/DSpace/DSpace/issues/2246"},"comments":{"href":"https://api.github.com/repos/DSpace/DSpace/issues/2246/comments"},"review_comments":{"href":"https://api.github.com/repos/DSpace/DSpace/pulls/2246/comments"},"review_comment":{"href":"https://api.github.com/repos/DSpace/DSpace/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DSpace/DSpace/pulls/2246/commits"},"statuses":{"href":"https://api.github.com/repos/DSpace/DSpace/statuses/75358b2bddd8111d84f9b505ed689b9900d6c3e0"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"benbosman"}}