{"action":"created","comment":{"url":"https://api.github.com/repos/google/xi-editor/pulls/comments/178595569","pull_request_review_id":108676541,"id":178595569,"diff_hunk":"@@ -349,16 +349,23 @@ impl Documents {\n         self.plugins.toggle_tracing(enabled);\n     }\n \n-    fn save_trace<P: AsRef<Path>>(&self, destination: P, frontend_samples: &Value) {\n+    fn save_trace<P: AsRef<Path>>(&self, destination: P, frontend_samples: Value) {\n         use xi_trace_dump::*;\n \n         let mut frontend_trace = chrome_trace::decode(frontend_samples)\n             .unwrap_or(Vec::with_capacity(0));\n \n-        let mut plugin_traces = self.plugins.collect_trace()\n-            .into_iter()\n-            .map(|json| chrome_trace::decode(&json).unwrap())\n-            .collect::<Vec<_>>();\n+        let mut plugin_traces_json = self.plugins.collect_trace();\n+        let mut plugin_traces = plugin_traces_json.drain(0..)\n+            .map(|json| {\n+                chrome_trace::decode(json).map_err(|e| {\n+                    // TODO(vlovich): transport the name of the plugin along with\n+                    // the sample so we can print a better diagnostic about which\n+                    // plugin failed to send well-formed JSON.","path":"rust/core-lib/src/tabs.rs","position":21,"original_position":21,"commit_id":"7f5c430a777428ab66177d36859e71bf8da9b556","original_commit_id":"7f5c430a777428ab66177d36859e71bf8da9b556","user":{"login":"cmyr","id":3330916,"avatar_url":"https://avatars2.githubusercontent.com/u/3330916?v=4","gravatar_id":"","url":"https://api.github.com/users/cmyr","html_url":"https://github.com/cmyr","followers_url":"https://api.github.com/users/cmyr/followers","following_url":"https://api.github.com/users/cmyr/following{/other_user}","gists_url":"https://api.github.com/users/cmyr/gists{/gist_id}","starred_url":"https://api.github.com/users/cmyr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmyr/subscriptions","organizations_url":"https://api.github.com/users/cmyr/orgs","repos_url":"https://api.github.com/users/cmyr/repos","events_url":"https://api.github.com/users/cmyr/events{/privacy}","received_events_url":"https://api.github.com/users/cmyr/received_events","type":"User","site_admin":false},"body":"Okay that sounds reasonable. This seems pretty close to ready then, just the CI issue. Happy to take another look whenever it's ready.","created_at":"2018-04-02T17:23:31Z","updated_at":"2018-04-02T17:23:32Z","html_url":"https://github.com/google/xi-editor/pull/588#discussion_r178595569","pull_request_url":"https://api.github.com/repos/google/xi-editor/pulls/588","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/google/xi-editor/pulls/comments/178595569"},"html":{"href":"https://github.com/google/xi-editor/pull/588#discussion_r178595569"},"pull_request":{"href":"https://api.github.com/repos/google/xi-editor/pulls/588"}},"in_reply_to_id":178445754},"pull_request":{"url":"https://api.github.com/repos/google/xi-editor/pulls/588","id":178624231,"html_url":"https://github.com/google/xi-editor/pull/588","diff_url":"https://github.com/google/xi-editor/pull/588.diff","patch_url":"https://github.com/google/xi-editor/pull/588.patch","issue_url":"https://api.github.com/repos/google/xi-editor/issues/588","number":588,"state":"open","locked":false,"title":"Cleanup trace library","user":{"login":"vlovich","id":201287,"avatar_url":"https://avatars0.githubusercontent.com/u/201287?v=4","gravatar_id":"","url":"https://api.github.com/users/vlovich","html_url":"https://github.com/vlovich","followers_url":"https://api.github.com/users/vlovich/followers","following_url":"https://api.github.com/users/vlovich/following{/other_user}","gists_url":"https://api.github.com/users/vlovich/gists{/gist_id}","starred_url":"https://api.github.com/users/vlovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlovich/subscriptions","organizations_url":"https://api.github.com/users/vlovich/orgs","repos_url":"https://api.github.com/users/vlovich/repos","events_url":"https://api.github.com/users/vlovich/events{/privacy}","received_events_url":"https://api.github.com/users/vlovich/received_events","type":"User","site_admin":false},"body":"Build a more direct 1:1 mapping of the internal data structure to the\r\nChrome trace event format.  Avoids the overcomplication of assuming we\r\nneed to support something else.  Also provides for a mechanism to do\r\nthings like annotating thread/process names much more naturally &\r\nsimplifies the encoding/decoding a lot (just direct automatic 1:1\r\nmapping to the JSON via serde instead of needing a manual translation\r\nlayer).\r\n\r\nFixes #581 ","created_at":"2018-03-30T19:53:16Z","updated_at":"2018-04-02T17:23:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f214be798774e589f33a24fec26e7a5ad92b996","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":365718022,"url":"https://api.github.com/repos/google/xi-editor/labels/cla:%20yes","name":"cla: yes","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/google/xi-editor/pulls/588/commits","review_comments_url":"https://api.github.com/repos/google/xi-editor/pulls/588/comments","review_comment_url":"https://api.github.com/repos/google/xi-editor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/xi-editor/issues/588/comments","statuses_url":"https://api.github.com/repos/google/xi-editor/statuses/7f5c430a777428ab66177d36859e71bf8da9b556","head":{"label":"vlovich:trace-cleanup","ref":"trace-cleanup","sha":"7f5c430a777428ab66177d36859e71bf8da9b556","user":{"login":"vlovich","id":201287,"avatar_url":"https://avatars0.githubusercontent.com/u/201287?v=4","gravatar_id":"","url":"https://api.github.com/users/vlovich","html_url":"https://github.com/vlovich","followers_url":"https://api.github.com/users/vlovich/followers","following_url":"https://api.github.com/users/vlovich/following{/other_user}","gists_url":"https://api.github.com/users/vlovich/gists{/gist_id}","starred_url":"https://api.github.com/users/vlovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlovich/subscriptions","organizations_url":"https://api.github.com/users/vlovich/orgs","repos_url":"https://api.github.com/users/vlovich/repos","events_url":"https://api.github.com/users/vlovich/events{/privacy}","received_events_url":"https://api.github.com/users/vlovich/received_events","type":"User","site_admin":false},"repo":{"id":114943632,"name":"xi-editor","full_name":"vlovich/xi-editor","owner":{"login":"vlovich","id":201287,"avatar_url":"https://avatars0.githubusercontent.com/u/201287?v=4","gravatar_id":"","url":"https://api.github.com/users/vlovich","html_url":"https://github.com/vlovich","followers_url":"https://api.github.com/users/vlovich/followers","following_url":"https://api.github.com/users/vlovich/following{/other_user}","gists_url":"https://api.github.com/users/vlovich/gists{/gist_id}","starred_url":"https://api.github.com/users/vlovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlovich/subscriptions","organizations_url":"https://api.github.com/users/vlovich/orgs","repos_url":"https://api.github.com/users/vlovich/repos","events_url":"https://api.github.com/users/vlovich/events{/privacy}","received_events_url":"https://api.github.com/users/vlovich/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vlovich/xi-editor","description":"A modern editor with a backend written in Rust.","fork":true,"url":"https://api.github.com/repos/vlovich/xi-editor","forks_url":"https://api.github.com/repos/vlovich/xi-editor/forks","keys_url":"https://api.github.com/repos/vlovich/xi-editor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vlovich/xi-editor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vlovich/xi-editor/teams","hooks_url":"https://api.github.com/repos/vlovich/xi-editor/hooks","issue_events_url":"https://api.github.com/repos/vlovich/xi-editor/issues/events{/number}","events_url":"https://api.github.com/repos/vlovich/xi-editor/events","assignees_url":"https://api.github.com/repos/vlovich/xi-editor/assignees{/user}","branches_url":"https://api.github.com/repos/vlovich/xi-editor/branches{/branch}","tags_url":"https://api.github.com/repos/vlovich/xi-editor/tags","blobs_url":"https://api.github.com/repos/vlovich/xi-editor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vlovich/xi-editor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vlovich/xi-editor/git/refs{/sha}","trees_url":"https://api.github.com/repos/vlovich/xi-editor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vlovich/xi-editor/statuses/{sha}","languages_url":"https://api.github.com/repos/vlovich/xi-editor/languages","stargazers_url":"https://api.github.com/repos/vlovich/xi-editor/stargazers","contributors_url":"https://api.github.com/repos/vlovich/xi-editor/contributors","subscribers_url":"https://api.github.com/repos/vlovich/xi-editor/subscribers","subscription_url":"https://api.github.com/repos/vlovich/xi-editor/subscription","commits_url":"https://api.github.com/repos/vlovich/xi-editor/commits{/sha}","git_commits_url":"https://api.github.com/repos/vlovich/xi-editor/git/commits{/sha}","comments_url":"https://api.github.com/repos/vlovich/xi-editor/comments{/number}","issue_comment_url":"https://api.github.com/repos/vlovich/xi-editor/issues/comments{/number}","contents_url":"https://api.github.com/repos/vlovich/xi-editor/contents/{+path}","compare_url":"https://api.github.com/repos/vlovich/xi-editor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vlovich/xi-editor/merges","archive_url":"https://api.github.com/repos/vlovich/xi-editor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vlovich/xi-editor/downloads","issues_url":"https://api.github.com/repos/vlovich/xi-editor/issues{/number}","pulls_url":"https://api.github.com/repos/vlovich/xi-editor/pulls{/number}","milestones_url":"https://api.github.com/repos/vlovich/xi-editor/milestones{/number}","notifications_url":"https://api.github.com/repos/vlovich/xi-editor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vlovich/xi-editor/labels{/name}","releases_url":"https://api.github.com/repos/vlovich/xi-editor/releases{/id}","deployments_url":"https://api.github.com/repos/vlovich/xi-editor/deployments","created_at":"2017-12-21T00:23:39Z","updated_at":"2017-12-21T00:23:41Z","pushed_at":"2018-03-30T19:52:25Z","git_url":"git://github.com/vlovich/xi-editor.git","ssh_url":"git@github.com:vlovich/xi-editor.git","clone_url":"https://github.com/vlovich/xi-editor.git","svn_url":"https://github.com/vlovich/xi-editor","homepage":"","size":4542,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"663984418adbe3b68692865e6d2b63076dd7d422","user":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":57167764,"name":"xi-editor","full_name":"google/xi-editor","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/xi-editor","description":"A modern editor with a backend written in Rust. https://google.github.io/xi-editor","fork":false,"url":"https://api.github.com/repos/google/xi-editor","forks_url":"https://api.github.com/repos/google/xi-editor/forks","keys_url":"https://api.github.com/repos/google/xi-editor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/xi-editor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/xi-editor/teams","hooks_url":"https://api.github.com/repos/google/xi-editor/hooks","issue_events_url":"https://api.github.com/repos/google/xi-editor/issues/events{/number}","events_url":"https://api.github.com/repos/google/xi-editor/events","assignees_url":"https://api.github.com/repos/google/xi-editor/assignees{/user}","branches_url":"https://api.github.com/repos/google/xi-editor/branches{/branch}","tags_url":"https://api.github.com/repos/google/xi-editor/tags","blobs_url":"https://api.github.com/repos/google/xi-editor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/xi-editor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/xi-editor/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/xi-editor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/xi-editor/statuses/{sha}","languages_url":"https://api.github.com/repos/google/xi-editor/languages","stargazers_url":"https://api.github.com/repos/google/xi-editor/stargazers","contributors_url":"https://api.github.com/repos/google/xi-editor/contributors","subscribers_url":"https://api.github.com/repos/google/xi-editor/subscribers","subscription_url":"https://api.github.com/repos/google/xi-editor/subscription","commits_url":"https://api.github.com/repos/google/xi-editor/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/xi-editor/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/xi-editor/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/xi-editor/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/xi-editor/contents/{+path}","compare_url":"https://api.github.com/repos/google/xi-editor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/xi-editor/merges","archive_url":"https://api.github.com/repos/google/xi-editor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/xi-editor/downloads","issues_url":"https://api.github.com/repos/google/xi-editor/issues{/number}","pulls_url":"https://api.github.com/repos/google/xi-editor/pulls{/number}","milestones_url":"https://api.github.com/repos/google/xi-editor/milestones{/number}","notifications_url":"https://api.github.com/repos/google/xi-editor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/xi-editor/labels{/name}","releases_url":"https://api.github.com/repos/google/xi-editor/releases{/id}","deployments_url":"https://api.github.com/repos/google/xi-editor/deployments","created_at":"2016-04-26T23:03:23Z","updated_at":"2018-04-02T15:49:45Z","pushed_at":"2018-04-02T08:44:23Z","git_url":"git://github.com/google/xi-editor.git","ssh_url":"git@github.com:google/xi-editor.git","clone_url":"https://github.com/google/xi-editor.git","svn_url":"https://github.com/google/xi-editor","homepage":"","size":4591,"stargazers_count":12077,"watchers_count":12077,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":418,"mirror_url":null,"archived":false,"open_issues_count":112,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":418,"open_issues":112,"watchers":12077,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/xi-editor/pulls/588"},"html":{"href":"https://github.com/google/xi-editor/pull/588"},"issue":{"href":"https://api.github.com/repos/google/xi-editor/issues/588"},"comments":{"href":"https://api.github.com/repos/google/xi-editor/issues/588/comments"},"review_comments":{"href":"https://api.github.com/repos/google/xi-editor/pulls/588/comments"},"review_comment":{"href":"https://api.github.com/repos/google/xi-editor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/xi-editor/pulls/588/commits"},"statuses":{"href":"https://api.github.com/repos/google/xi-editor/statuses/7f5c430a777428ab66177d36859e71bf8da9b556"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"cmyr"}}