{"action":"created","comment":{"url":"https://api.github.com/repos/Ultimaker/Uranium/pulls/comments/230724952","pull_request_review_id":171523270,"id":230724952,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDcyNDk1Mg==","diff_hunk":"@@ -397,14 +395,23 @@ def loadPlugin(self, plugin_id: str) -> None:\n             except InvalidMetaDataError:\n                 return\n \n-        #If API version is incompatible, don't load it.\n-        if self._metadata[plugin_id].get(\"plugin\", {}).get(\"api\", 0) != self.APIVersion:\n+        # If API version is incompatible, don't load it.\n+        plugin_api_version = self._metadata[plugin_id].get(\"plugin\", {}).get(\"api\", Version(\"0\"))\n+\n+        if plugin_api_version.getMajor() != self.APIVersion.getMajor():\n             Logger.log(\"w\", \"Plugin %s uses an incompatible API version, disabling\", plugin_id)\n             self.disablePlugin(plugin_id)\n             return\n \n+        if plugin_api_version > self.APIVersion:","path":"UM/PluginRegistry.py","position":32,"original_position":32,"commit_id":"ff98d7b8d12051894852983629411e561c7e2cf0","original_commit_id":"2c85eccb1e5f5705360ed0e72d5302c5d5891954","user":{"login":"alekseisasin","id":29890821,"node_id":"MDQ6VXNlcjI5ODkwODIx","avatar_url":"https://avatars1.githubusercontent.com/u/29890821?v=4","gravatar_id":"","url":"https://api.github.com/users/alekseisasin","html_url":"https://github.com/alekseisasin","followers_url":"https://api.github.com/users/alekseisasin/followers","following_url":"https://api.github.com/users/alekseisasin/following{/other_user}","gists_url":"https://api.github.com/users/alekseisasin/gists{/gist_id}","starred_url":"https://api.github.com/users/alekseisasin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alekseisasin/subscriptions","organizations_url":"https://api.github.com/users/alekseisasin/orgs","repos_url":"https://api.github.com/users/alekseisasin/repos","events_url":"https://api.github.com/users/alekseisasin/events{/privacy}","received_events_url":"https://api.github.com/users/alekseisasin/received_events","type":"User","site_admin":false},"body":"@ChrisTerBeke \r\nAccording to the SDK versioning document in confluence:\r\n\r\n5.2 → 5.2.0 | 5.1 → 5.1.0 | --> The major number is the same, and the minor number requirement is lower can currently available, so we load it.\r\n\r\nI changed the plugin \"Console Logger\" API to 5.2 and   \"self.APIVersion\" to 5.1. The plugin is loaded but disabled. I think we need to update the document.","created_at":"2018-11-05T11:59:15Z","updated_at":"2018-11-05T11:59:15Z","html_url":"https://github.com/Ultimaker/Uranium/pull/416#discussion_r230724952","pull_request_url":"https://api.github.com/repos/Ultimaker/Uranium/pulls/416","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Ultimaker/Uranium/pulls/comments/230724952"},"html":{"href":"https://github.com/Ultimaker/Uranium/pull/416#discussion_r230724952"},"pull_request":{"href":"https://api.github.com/repos/Ultimaker/Uranium/pulls/416"}}},"pull_request":{"url":"https://api.github.com/repos/Ultimaker/Uranium/pulls/416","id":227630662,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NjMwNjYy","html_url":"https://github.com/Ultimaker/Uranium/pull/416","diff_url":"https://github.com/Ultimaker/Uranium/pull/416.diff","patch_url":"https://github.com/Ultimaker/Uranium/pull/416.patch","issue_url":"https://api.github.com/repos/Ultimaker/Uranium/issues/416","number":416,"state":"open","locked":false,"title":"Cura 5840 make plugin sdk use semantic versioning","user":{"login":"nallath","id":3922611,"node_id":"MDQ6VXNlcjM5MjI2MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/3922611?v=4","gravatar_id":"","url":"https://api.github.com/users/nallath","html_url":"https://github.com/nallath","followers_url":"https://api.github.com/users/nallath/followers","following_url":"https://api.github.com/users/nallath/following{/other_user}","gists_url":"https://api.github.com/users/nallath/gists{/gist_id}","starred_url":"https://api.github.com/users/nallath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nallath/subscriptions","organizations_url":"https://api.github.com/users/nallath/orgs","repos_url":"https://api.github.com/users/nallath/repos","events_url":"https://api.github.com/users/nallath/events{/privacy}","received_events_url":"https://api.github.com/users/nallath/received_events","type":"User","site_admin":false},"body":"CURA-5840\r\n\r\nSee also; https://github.com/Ultimaker/Cura/pull/4705","created_at":"2018-11-01T14:08:02Z","updated_at":"2018-11-05T11:59:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d5603c86d68e00299803770edf94a5ff6ee72a4e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Ultimaker/Uranium/pulls/416/commits","review_comments_url":"https://api.github.com/repos/Ultimaker/Uranium/pulls/416/comments","review_comment_url":"https://api.github.com/repos/Ultimaker/Uranium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Ultimaker/Uranium/issues/416/comments","statuses_url":"https://api.github.com/repos/Ultimaker/Uranium/statuses/ff98d7b8d12051894852983629411e561c7e2cf0","head":{"label":"Ultimaker:CURA-5840-make-plugin-sdk-use-semantic-versioning","ref":"CURA-5840-make-plugin-sdk-use-semantic-versioning","sha":"ff98d7b8d12051894852983629411e561c7e2cf0","user":{"login":"Ultimaker","id":499557,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5OTU1Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/499557?v=4","gravatar_id":"","url":"https://api.github.com/users/Ultimaker","html_url":"https://github.com/Ultimaker","followers_url":"https://api.github.com/users/Ultimaker/followers","following_url":"https://api.github.com/users/Ultimaker/following{/other_user}","gists_url":"https://api.github.com/users/Ultimaker/gists{/gist_id}","starred_url":"https://api.github.com/users/Ultimaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ultimaker/subscriptions","organizations_url":"https://api.github.com/users/Ultimaker/orgs","repos_url":"https://api.github.com/users/Ultimaker/repos","events_url":"https://api.github.com/users/Ultimaker/events{/privacy}","received_events_url":"https://api.github.com/users/Ultimaker/received_events","type":"Organization","site_admin":false},"repo":{"id":26438422,"node_id":"MDEwOlJlcG9zaXRvcnkyNjQzODQyMg==","name":"Uranium","full_name":"Ultimaker/Uranium","private":false,"owner":{"login":"Ultimaker","id":499557,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5OTU1Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/499557?v=4","gravatar_id":"","url":"https://api.github.com/users/Ultimaker","html_url":"https://github.com/Ultimaker","followers_url":"https://api.github.com/users/Ultimaker/followers","following_url":"https://api.github.com/users/Ultimaker/following{/other_user}","gists_url":"https://api.github.com/users/Ultimaker/gists{/gist_id}","starred_url":"https://api.github.com/users/Ultimaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ultimaker/subscriptions","organizations_url":"https://api.github.com/users/Ultimaker/orgs","repos_url":"https://api.github.com/users/Ultimaker/repos","events_url":"https://api.github.com/users/Ultimaker/events{/privacy}","received_events_url":"https://api.github.com/users/Ultimaker/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Ultimaker/Uranium","description":" A Python framework for building Desktop applications.","fork":false,"url":"https://api.github.com/repos/Ultimaker/Uranium","forks_url":"https://api.github.com/repos/Ultimaker/Uranium/forks","keys_url":"https://api.github.com/repos/Ultimaker/Uranium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ultimaker/Uranium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ultimaker/Uranium/teams","hooks_url":"https://api.github.com/repos/Ultimaker/Uranium/hooks","issue_events_url":"https://api.github.com/repos/Ultimaker/Uranium/issues/events{/number}","events_url":"https://api.github.com/repos/Ultimaker/Uranium/events","assignees_url":"https://api.github.com/repos/Ultimaker/Uranium/assignees{/user}","branches_url":"https://api.github.com/repos/Ultimaker/Uranium/branches{/branch}","tags_url":"https://api.github.com/repos/Ultimaker/Uranium/tags","blobs_url":"https://api.github.com/repos/Ultimaker/Uranium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ultimaker/Uranium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ultimaker/Uranium/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ultimaker/Uranium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ultimaker/Uranium/statuses/{sha}","languages_url":"https://api.github.com/repos/Ultimaker/Uranium/languages","stargazers_url":"https://api.github.com/repos/Ultimaker/Uranium/stargazers","contributors_url":"https://api.github.com/repos/Ultimaker/Uranium/contributors","subscribers_url":"https://api.github.com/repos/Ultimaker/Uranium/subscribers","subscription_url":"https://api.github.com/repos/Ultimaker/Uranium/subscription","commits_url":"https://api.github.com/repos/Ultimaker/Uranium/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ultimaker/Uranium/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ultimaker/Uranium/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ultimaker/Uranium/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ultimaker/Uranium/contents/{+path}","compare_url":"https://api.github.com/repos/Ultimaker/Uranium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ultimaker/Uranium/merges","archive_url":"https://api.github.com/repos/Ultimaker/Uranium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ultimaker/Uranium/downloads","issues_url":"https://api.github.com/repos/Ultimaker/Uranium/issues{/number}","pulls_url":"https://api.github.com/repos/Ultimaker/Uranium/pulls{/number}","milestones_url":"https://api.github.com/repos/Ultimaker/Uranium/milestones{/number}","notifications_url":"https://api.github.com/repos/Ultimaker/Uranium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ultimaker/Uranium/labels{/name}","releases_url":"https://api.github.com/repos/Ultimaker/Uranium/releases{/id}","deployments_url":"https://api.github.com/repos/Ultimaker/Uranium/deployments","created_at":"2014-11-10T13:56:28Z","updated_at":"2018-11-02T15:02:41Z","pushed_at":"2018-11-02T15:03:17Z","git_url":"git://github.com/Ultimaker/Uranium.git","ssh_url":"git@github.com:Ultimaker/Uranium.git","clone_url":"https://github.com/Ultimaker/Uranium.git","svn_url":"https://github.com/Ultimaker/Uranium","homepage":"","size":21649,"stargazers_count":97,"watchers_count":97,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":88,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":88,"open_issues":26,"watchers":97,"default_branch":"master"}},"base":{"label":"Ultimaker:master","ref":"master","sha":"cbb847a1a2e67858b009abd2db20313e3148c763","user":{"login":"Ultimaker","id":499557,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5OTU1Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/499557?v=4","gravatar_id":"","url":"https://api.github.com/users/Ultimaker","html_url":"https://github.com/Ultimaker","followers_url":"https://api.github.com/users/Ultimaker/followers","following_url":"https://api.github.com/users/Ultimaker/following{/other_user}","gists_url":"https://api.github.com/users/Ultimaker/gists{/gist_id}","starred_url":"https://api.github.com/users/Ultimaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ultimaker/subscriptions","organizations_url":"https://api.github.com/users/Ultimaker/orgs","repos_url":"https://api.github.com/users/Ultimaker/repos","events_url":"https://api.github.com/users/Ultimaker/events{/privacy}","received_events_url":"https://api.github.com/users/Ultimaker/received_events","type":"Organization","site_admin":false},"repo":{"id":26438422,"node_id":"MDEwOlJlcG9zaXRvcnkyNjQzODQyMg==","name":"Uranium","full_name":"Ultimaker/Uranium","private":false,"owner":{"login":"Ultimaker","id":499557,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5OTU1Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/499557?v=4","gravatar_id":"","url":"https://api.github.com/users/Ultimaker","html_url":"https://github.com/Ultimaker","followers_url":"https://api.github.com/users/Ultimaker/followers","following_url":"https://api.github.com/users/Ultimaker/following{/other_user}","gists_url":"https://api.github.com/users/Ultimaker/gists{/gist_id}","starred_url":"https://api.github.com/users/Ultimaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ultimaker/subscriptions","organizations_url":"https://api.github.com/users/Ultimaker/orgs","repos_url":"https://api.github.com/users/Ultimaker/repos","events_url":"https://api.github.com/users/Ultimaker/events{/privacy}","received_events_url":"https://api.github.com/users/Ultimaker/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Ultimaker/Uranium","description":" A Python framework for building Desktop applications.","fork":false,"url":"https://api.github.com/repos/Ultimaker/Uranium","forks_url":"https://api.github.com/repos/Ultimaker/Uranium/forks","keys_url":"https://api.github.com/repos/Ultimaker/Uranium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ultimaker/Uranium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ultimaker/Uranium/teams","hooks_url":"https://api.github.com/repos/Ultimaker/Uranium/hooks","issue_events_url":"https://api.github.com/repos/Ultimaker/Uranium/issues/events{/number}","events_url":"https://api.github.com/repos/Ultimaker/Uranium/events","assignees_url":"https://api.github.com/repos/Ultimaker/Uranium/assignees{/user}","branches_url":"https://api.github.com/repos/Ultimaker/Uranium/branches{/branch}","tags_url":"https://api.github.com/repos/Ultimaker/Uranium/tags","blobs_url":"https://api.github.com/repos/Ultimaker/Uranium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ultimaker/Uranium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ultimaker/Uranium/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ultimaker/Uranium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ultimaker/Uranium/statuses/{sha}","languages_url":"https://api.github.com/repos/Ultimaker/Uranium/languages","stargazers_url":"https://api.github.com/repos/Ultimaker/Uranium/stargazers","contributors_url":"https://api.github.com/repos/Ultimaker/Uranium/contributors","subscribers_url":"https://api.github.com/repos/Ultimaker/Uranium/subscribers","subscription_url":"https://api.github.com/repos/Ultimaker/Uranium/subscription","commits_url":"https://api.github.com/repos/Ultimaker/Uranium/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ultimaker/Uranium/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ultimaker/Uranium/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ultimaker/Uranium/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ultimaker/Uranium/contents/{+path}","compare_url":"https://api.github.com/repos/Ultimaker/Uranium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ultimaker/Uranium/merges","archive_url":"https://api.github.com/repos/Ultimaker/Uranium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ultimaker/Uranium/downloads","issues_url":"https://api.github.com/repos/Ultimaker/Uranium/issues{/number}","pulls_url":"https://api.github.com/repos/Ultimaker/Uranium/pulls{/number}","milestones_url":"https://api.github.com/repos/Ultimaker/Uranium/milestones{/number}","notifications_url":"https://api.github.com/repos/Ultimaker/Uranium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ultimaker/Uranium/labels{/name}","releases_url":"https://api.github.com/repos/Ultimaker/Uranium/releases{/id}","deployments_url":"https://api.github.com/repos/Ultimaker/Uranium/deployments","created_at":"2014-11-10T13:56:28Z","updated_at":"2018-11-02T15:02:41Z","pushed_at":"2018-11-02T15:03:17Z","git_url":"git://github.com/Ultimaker/Uranium.git","ssh_url":"git@github.com:Ultimaker/Uranium.git","clone_url":"https://github.com/Ultimaker/Uranium.git","svn_url":"https://github.com/Ultimaker/Uranium","homepage":"","size":21649,"stargazers_count":97,"watchers_count":97,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":88,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":88,"open_issues":26,"watchers":97,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Ultimaker/Uranium/pulls/416"},"html":{"href":"https://github.com/Ultimaker/Uranium/pull/416"},"issue":{"href":"https://api.github.com/repos/Ultimaker/Uranium/issues/416"},"comments":{"href":"https://api.github.com/repos/Ultimaker/Uranium/issues/416/comments"},"review_comments":{"href":"https://api.github.com/repos/Ultimaker/Uranium/pulls/416/comments"},"review_comment":{"href":"https://api.github.com/repos/Ultimaker/Uranium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Ultimaker/Uranium/pulls/416/commits"},"statuses":{"href":"https://api.github.com/repos/Ultimaker/Uranium/statuses/ff98d7b8d12051894852983629411e561c7e2cf0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"alekseisasin"}}