{"action":"created","comment":{"url":"https://api.github.com/repos/apache/bookkeeper/pulls/comments/193459172","pull_request_review_id":126435968,"id":193459172,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzQ1OTE3Mg==","diff_hunk":"@@ -1822,6 +1892,17 @@ void handleBookieFailure(final Map<Integer, BookieSocketAddress> failedBookies)\n             return;\n         }\n \n+        if (writeFlags.contains(WriteFlag.DEFERRED_SYNC)) {\n+            blockAddCompletions.decrementAndGet();\n+            if (LOG.isDebugEnabled()) {","path":"bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java","position":99,"original_position":90,"commit_id":"f0ac572e46b9c88b46dbefd8066bd7797953a2b6","original_commit_id":"9f5052f31b0ccf9e97c076d375a437810f50ac18","user":{"login":"eolivelli","id":9469110,"node_id":"MDQ6VXNlcjk0NjkxMTA=","avatar_url":"https://avatars0.githubusercontent.com/u/9469110?v=4","gravatar_id":"","url":"https://api.github.com/users/eolivelli","html_url":"https://github.com/eolivelli","followers_url":"https://api.github.com/users/eolivelli/followers","following_url":"https://api.github.com/users/eolivelli/following{/other_user}","gists_url":"https://api.github.com/users/eolivelli/gists{/gist_id}","starred_url":"https://api.github.com/users/eolivelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eolivelli/subscriptions","organizations_url":"https://api.github.com/users/eolivelli/orgs","repos_url":"https://api.github.com/users/eolivelli/repos","events_url":"https://api.github.com/users/eolivelli/events{/privacy}","received_events_url":"https://api.github.com/users/eolivelli/received_events","type":"User","site_admin":false},"body":"done","created_at":"2018-06-06T15:42:15Z","updated_at":"2018-06-06T15:42:15Z","html_url":"https://github.com/apache/bookkeeper/pull/1436#discussion_r193459172","pull_request_url":"https://api.github.com/repos/apache/bookkeeper/pulls/1436","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/comments/193459172"},"html":{"href":"https://github.com/apache/bookkeeper/pull/1436#discussion_r193459172"},"pull_request":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/1436"}},"in_reply_to_id":193181776},"pull_request":{"url":"https://api.github.com/repos/apache/bookkeeper/pulls/1436","id":190328029,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwMzI4MDI5","html_url":"https://github.com/apache/bookkeeper/pull/1436","diff_url":"https://github.com/apache/bookkeeper/pull/1436.diff","patch_url":"https://github.com/apache/bookkeeper/pull/1436.patch","issue_url":"https://api.github.com/repos/apache/bookkeeper/issues/1436","number":1436,"state":"open","locked":false,"title":"BP-14 force() API - client side implementation","user":{"login":"eolivelli","id":9469110,"node_id":"MDQ6VXNlcjk0NjkxMTA=","avatar_url":"https://avatars0.githubusercontent.com/u/9469110?v=4","gravatar_id":"","url":"https://api.github.com/users/eolivelli","html_url":"https://github.com/eolivelli","followers_url":"https://api.github.com/users/eolivelli/followers","following_url":"https://api.github.com/users/eolivelli/following{/other_user}","gists_url":"https://api.github.com/users/eolivelli/gists{/gist_id}","starred_url":"https://api.github.com/users/eolivelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eolivelli/subscriptions","organizations_url":"https://api.github.com/users/eolivelli/orgs","repos_url":"https://api.github.com/users/eolivelli/repos","events_url":"https://api.github.com/users/eolivelli/events{/privacy}","received_events_url":"https://api.github.com/users/eolivelli/received_events","type":"User","site_admin":false},"body":"- Introduce the client side force() API\r\n- Implementation on the client side wire protocol for FORCE_LEDGER RPC\r\n- Disable ensemble changes for DEFERRED_SYNC writers\r\n- Prevent v2 client from using force() API.\r\n\r\nThe force() API enables the client (usually with DEFERRED_SYNC write flags) to require a point of synchronization with all the bookies in the ensemble, to have guarantees about durability of previously written entries (and ackknowledgerd), this way LastAddConfirmed is able to advance.\r\n\r\nFor DEFERRED_SYNC writers LastAddConfirmed will advance only using this API","created_at":"2018-05-24T15:20:25Z","updated_at":"2018-06-06T15:42:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4bada30a7feedd911913ce67a2be5f14ebccf3e6","assignee":{"login":"eolivelli","id":9469110,"node_id":"MDQ6VXNlcjk0NjkxMTA=","avatar_url":"https://avatars0.githubusercontent.com/u/9469110?v=4","gravatar_id":"","url":"https://api.github.com/users/eolivelli","html_url":"https://github.com/eolivelli","followers_url":"https://api.github.com/users/eolivelli/followers","following_url":"https://api.github.com/users/eolivelli/following{/other_user}","gists_url":"https://api.github.com/users/eolivelli/gists{/gist_id}","starred_url":"https://api.github.com/users/eolivelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eolivelli/subscriptions","organizations_url":"https://api.github.com/users/eolivelli/orgs","repos_url":"https://api.github.com/users/eolivelli/repos","events_url":"https://api.github.com/users/eolivelli/events{/privacy}","received_events_url":"https://api.github.com/users/eolivelli/received_events","type":"User","site_admin":false},"assignees":[{"login":"eolivelli","id":9469110,"node_id":"MDQ6VXNlcjk0NjkxMTA=","avatar_url":"https://avatars0.githubusercontent.com/u/9469110?v=4","gravatar_id":"","url":"https://api.github.com/users/eolivelli","html_url":"https://github.com/eolivelli","followers_url":"https://api.github.com/users/eolivelli/followers","following_url":"https://api.github.com/users/eolivelli/following{/other_user}","gists_url":"https://api.github.com/users/eolivelli/gists{/gist_id}","starred_url":"https://api.github.com/users/eolivelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eolivelli/subscriptions","organizations_url":"https://api.github.com/users/eolivelli/orgs","repos_url":"https://api.github.com/users/eolivelli/repos","events_url":"https://api.github.com/users/eolivelli/events{/privacy}","received_events_url":"https://api.github.com/users/eolivelli/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":636301949,"node_id":"MDU6TGFiZWw2MzYzMDE5NDk=","url":"https://api.github.com/repos/apache/bookkeeper/labels/area/client","name":"area/client","color":"f9d0c4","default":false},{"id":636301674,"node_id":"MDU6TGFiZWw2MzYzMDE2NzQ=","url":"https://api.github.com/repos/apache/bookkeeper/labels/area/protocol","name":"area/protocol","color":"f9d0c4","default":false},{"id":823586081,"node_id":"MDU6TGFiZWw4MjM1ODYwODE=","url":"https://api.github.com/repos/apache/bookkeeper/labels/release/4.8.0","name":"release/4.8.0","color":"1d76db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/apache/bookkeeper/pulls/1436/commits","review_comments_url":"https://api.github.com/repos/apache/bookkeeper/pulls/1436/comments","review_comment_url":"https://api.github.com/repos/apache/bookkeeper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/bookkeeper/issues/1436/comments","statuses_url":"https://api.github.com/repos/apache/bookkeeper/statuses/f0ac572e46b9c88b46dbefd8066bd7797953a2b6","head":{"label":"eolivelli:bp14-force-client-api","ref":"bp14-force-client-api","sha":"f0ac572e46b9c88b46dbefd8066bd7797953a2b6","user":{"login":"eolivelli","id":9469110,"node_id":"MDQ6VXNlcjk0NjkxMTA=","avatar_url":"https://avatars0.githubusercontent.com/u/9469110?v=4","gravatar_id":"","url":"https://api.github.com/users/eolivelli","html_url":"https://github.com/eolivelli","followers_url":"https://api.github.com/users/eolivelli/followers","following_url":"https://api.github.com/users/eolivelli/following{/other_user}","gists_url":"https://api.github.com/users/eolivelli/gists{/gist_id}","starred_url":"https://api.github.com/users/eolivelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eolivelli/subscriptions","organizations_url":"https://api.github.com/users/eolivelli/orgs","repos_url":"https://api.github.com/users/eolivelli/repos","events_url":"https://api.github.com/users/eolivelli/events{/privacy}","received_events_url":"https://api.github.com/users/eolivelli/received_events","type":"User","site_admin":false},"repo":{"id":61374519,"node_id":"MDEwOlJlcG9zaXRvcnk2MTM3NDUxOQ==","name":"bookkeeper","full_name":"eolivelli/bookkeeper","owner":{"login":"eolivelli","id":9469110,"node_id":"MDQ6VXNlcjk0NjkxMTA=","avatar_url":"https://avatars0.githubusercontent.com/u/9469110?v=4","gravatar_id":"","url":"https://api.github.com/users/eolivelli","html_url":"https://github.com/eolivelli","followers_url":"https://api.github.com/users/eolivelli/followers","following_url":"https://api.github.com/users/eolivelli/following{/other_user}","gists_url":"https://api.github.com/users/eolivelli/gists{/gist_id}","starred_url":"https://api.github.com/users/eolivelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eolivelli/subscriptions","organizations_url":"https://api.github.com/users/eolivelli/orgs","repos_url":"https://api.github.com/users/eolivelli/repos","events_url":"https://api.github.com/users/eolivelli/events{/privacy}","received_events_url":"https://api.github.com/users/eolivelli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eolivelli/bookkeeper","description":"Mirror of Apache Bookkeeper","fork":true,"url":"https://api.github.com/repos/eolivelli/bookkeeper","forks_url":"https://api.github.com/repos/eolivelli/bookkeeper/forks","keys_url":"https://api.github.com/repos/eolivelli/bookkeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eolivelli/bookkeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eolivelli/bookkeeper/teams","hooks_url":"https://api.github.com/repos/eolivelli/bookkeeper/hooks","issue_events_url":"https://api.github.com/repos/eolivelli/bookkeeper/issues/events{/number}","events_url":"https://api.github.com/repos/eolivelli/bookkeeper/events","assignees_url":"https://api.github.com/repos/eolivelli/bookkeeper/assignees{/user}","branches_url":"https://api.github.com/repos/eolivelli/bookkeeper/branches{/branch}","tags_url":"https://api.github.com/repos/eolivelli/bookkeeper/tags","blobs_url":"https://api.github.com/repos/eolivelli/bookkeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eolivelli/bookkeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eolivelli/bookkeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/eolivelli/bookkeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eolivelli/bookkeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/eolivelli/bookkeeper/languages","stargazers_url":"https://api.github.com/repos/eolivelli/bookkeeper/stargazers","contributors_url":"https://api.github.com/repos/eolivelli/bookkeeper/contributors","subscribers_url":"https://api.github.com/repos/eolivelli/bookkeeper/subscribers","subscription_url":"https://api.github.com/repos/eolivelli/bookkeeper/subscription","commits_url":"https://api.github.com/repos/eolivelli/bookkeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/eolivelli/bookkeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/eolivelli/bookkeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/eolivelli/bookkeeper/issues/comments{/number}","contents_url":"https://api.github.com/repos/eolivelli/bookkeeper/contents/{+path}","compare_url":"https://api.github.com/repos/eolivelli/bookkeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eolivelli/bookkeeper/merges","archive_url":"https://api.github.com/repos/eolivelli/bookkeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eolivelli/bookkeeper/downloads","issues_url":"https://api.github.com/repos/eolivelli/bookkeeper/issues{/number}","pulls_url":"https://api.github.com/repos/eolivelli/bookkeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/eolivelli/bookkeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/eolivelli/bookkeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eolivelli/bookkeeper/labels{/name}","releases_url":"https://api.github.com/repos/eolivelli/bookkeeper/releases{/id}","deployments_url":"https://api.github.com/repos/eolivelli/bookkeeper/deployments","created_at":"2016-06-17T13:11:53Z","updated_at":"2018-03-28T18:26:11Z","pushed_at":"2018-06-06T13:14:18Z","git_url":"git://github.com/eolivelli/bookkeeper.git","ssh_url":"git@github.com:eolivelli/bookkeeper.git","clone_url":"https://github.com/eolivelli/bookkeeper.git","svn_url":"https://github.com/eolivelli/bookkeeper","homepage":null,"size":20500,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"08c115568b1ef63bcbfd885f5ef252b4f3db0720","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":1575956,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc1OTU2","name":"bookkeeper","full_name":"apache/bookkeeper","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/bookkeeper","description":"Apache Bookkeeper","fork":false,"url":"https://api.github.com/repos/apache/bookkeeper","forks_url":"https://api.github.com/repos/apache/bookkeeper/forks","keys_url":"https://api.github.com/repos/apache/bookkeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/bookkeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/bookkeeper/teams","hooks_url":"https://api.github.com/repos/apache/bookkeeper/hooks","issue_events_url":"https://api.github.com/repos/apache/bookkeeper/issues/events{/number}","events_url":"https://api.github.com/repos/apache/bookkeeper/events","assignees_url":"https://api.github.com/repos/apache/bookkeeper/assignees{/user}","branches_url":"https://api.github.com/repos/apache/bookkeeper/branches{/branch}","tags_url":"https://api.github.com/repos/apache/bookkeeper/tags","blobs_url":"https://api.github.com/repos/apache/bookkeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/bookkeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/bookkeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/bookkeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/bookkeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/bookkeeper/languages","stargazers_url":"https://api.github.com/repos/apache/bookkeeper/stargazers","contributors_url":"https://api.github.com/repos/apache/bookkeeper/contributors","subscribers_url":"https://api.github.com/repos/apache/bookkeeper/subscribers","subscription_url":"https://api.github.com/repos/apache/bookkeeper/subscription","commits_url":"https://api.github.com/repos/apache/bookkeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/bookkeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/bookkeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/bookkeeper/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/bookkeeper/contents/{+path}","compare_url":"https://api.github.com/repos/apache/bookkeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/bookkeeper/merges","archive_url":"https://api.github.com/repos/apache/bookkeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/bookkeeper/downloads","issues_url":"https://api.github.com/repos/apache/bookkeeper/issues{/number}","pulls_url":"https://api.github.com/repos/apache/bookkeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/bookkeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/bookkeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/bookkeeper/labels{/name}","releases_url":"https://api.github.com/repos/apache/bookkeeper/releases{/id}","deployments_url":"https://api.github.com/repos/apache/bookkeeper/deployments","created_at":"2011-04-06T07:00:07Z","updated_at":"2018-06-06T06:57:48Z","pushed_at":"2018-06-06T13:14:20Z","git_url":"git://github.com/apache/bookkeeper.git","ssh_url":"git@github.com:apache/bookkeeper.git","clone_url":"https://github.com/apache/bookkeeper.git","svn_url":"https://github.com/apache/bookkeeper","homepage":"https://bookkeeper.apache.org","size":31789,"stargazers_count":340,"watchers_count":340,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":169,"mirror_url":null,"archived":false,"open_issues_count":165,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":169,"open_issues":165,"watchers":340,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/1436"},"html":{"href":"https://github.com/apache/bookkeeper/pull/1436"},"issue":{"href":"https://api.github.com/repos/apache/bookkeeper/issues/1436"},"comments":{"href":"https://api.github.com/repos/apache/bookkeeper/issues/1436/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/1436/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/1436/commits"},"statuses":{"href":"https://api.github.com/repos/apache/bookkeeper/statuses/f0ac572e46b9c88b46dbefd8066bd7797953a2b6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"eolivelli"}}