{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/69941","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/69941/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/69941/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/69941/events","html_url":"https://github.com/kubernetes/kubernetes/pull/69941","id":371247819,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNzM4MzI1","number":69941,"title":"Fix golint issues in plugin/pkg/admission","user":{"login":"miguelbernadi","id":731219,"node_id":"MDQ6VXNlcjczMTIxOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/731219?v=4","gravatar_id":"","url":"https://api.github.com/users/miguelbernadi","html_url":"https://github.com/miguelbernadi","followers_url":"https://api.github.com/users/miguelbernadi/followers","following_url":"https://api.github.com/users/miguelbernadi/following{/other_user}","gists_url":"https://api.github.com/users/miguelbernadi/gists{/gist_id}","starred_url":"https://api.github.com/users/miguelbernadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguelbernadi/subscriptions","organizations_url":"https://api.github.com/users/miguelbernadi/orgs","repos_url":"https://api.github.com/users/miguelbernadi/repos","events_url":"https://api.github.com/users/miguelbernadi/events{/privacy}","received_events_url":"https://api.github.com/users/miguelbernadi/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":122775691,"node_id":"MDU6TGFiZWwxMjI3NzU2OTE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/cleanup","name":"kind/cleanup","color":"c7def8","default":false},{"id":617149945,"node_id":"MDU6TGFiZWw2MTcxNDk5NDU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-sig","name":"needs-sig","color":"ededed","default":false},{"id":349530249,"node_id":"MDU6TGFiZWwzNDk1MzAyNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":253451057,"node_id":"MDU6TGFiZWwyNTM0NTEwNTc=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XL","name":"size/XL","color":"ee5500","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2018-10-17T20:11:50Z","updated_at":"2018-10-28T12:01:37Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/69941","html_url":"https://github.com/kubernetes/kubernetes/pull/69941","diff_url":"https://github.com/kubernetes/kubernetes/pull/69941.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/69941.patch"},"body":"**What this PR does / why we need it**:\r\nFix golint violations in plugin/pkg/admission tree, as reported in #68026 \r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #\r\n\r\n**Special notes for your reviewer**:\r\nI've added some comments were guidance would be welcome regarding how to tackle some issues, or if to ignore them in this PR.\r\n\r\nThey will all be squashed before merging.\r\n**Release note**:\r\n```\r\nNONE\r\n```"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/433698777","html_url":"https://github.com/kubernetes/kubernetes/pull/69941#issuecomment-433698777","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/69941","id":433698777,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzY5ODc3Nw==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-10-28T12:01:37Z","updated_at":"2018-10-28T12:01:37Z","author_association":"CONTRIBUTOR","body":"@miguelbernadi: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-bazel-test | 60a71c8c9277d5610ba7dea30e3ea44cbb029640 | [link](https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/69941/pull-kubernetes-bazel-test/65083/) | `/test pull-kubernetes-bazel-test`\npull-kubernetes-e2e-kops-aws | 60a71c8c9277d5610ba7dea30e3ea44cbb029640 | [link](https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/69941/pull-kubernetes-e2e-kops-aws/111088/) | `/test pull-kubernetes-e2e-kops-aws`\npull-kubernetes-e2e-gce | 60a71c8c9277d5610ba7dea30e3ea44cbb029640 | [link](https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/69941/pull-kubernetes-e2e-gce/57384/) | `/test pull-kubernetes-e2e-gce`\npull-kubernetes-bazel-build | 60a71c8c9277d5610ba7dea30e3ea44cbb029640 | [link](https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/69941/pull-kubernetes-bazel-build/62455/) | `/test pull-kubernetes-bazel-build`\npull-kubernetes-e2e-gce-device-plugin-gpu | 60a71c8c9277d5610ba7dea30e3ea44cbb029640 | [link](https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/69941/pull-kubernetes-e2e-gce-device-plugin-gpu/51379/) | `/test pull-kubernetes-e2e-gce-device-plugin-gpu`\npull-kubernetes-node-e2e | 60a71c8c9277d5610ba7dea30e3ea44cbb029640 | [link](https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/69941/pull-kubernetes-node-e2e/108949/) | `/test pull-kubernetes-node-e2e`\n\n[Full PR test history](https://gubernator.k8s.io/pr/69941). [Your PR dashboard](https://gubernator.k8s.io/pr/miguelbernadi). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}