{"action":"created","comment":{"url":"https://api.github.com/repos/guardian/nitf-scala/pulls/comments/177139678","pull_request_review_id":106961321,"id":177139678,"diff_hunk":"@@ -42,6 +43,31 @@ trait Builder[T] {\n   override def toString: String = build.toString\n }\n \n+trait BlockContentBuilder {\n+  def withNote(x: Note): this.type = withBlockContent(x)\n+  def withFootnote(x: Fn): this.type = withBlockContent(x)\n+  def withMedia(x: Media): this.type = withBlockContent(x)\n+  def withParagraph(x: P): this.type = withBlockContent(x)\n+  def withTable(x: Table): this.type = withBlockContent(x)\n+  def withBlockQuote(x: Bq): this.type = withBlockContent(x)\n+  def withOrderedList(x: Ol): this.type = withBlockContent(x)\n+  def withPreformatted(x: Pre): this.type = withBlockContent(x)\n+  def withUnorderedList(x: Ul): this.type = withBlockContent(x)\n+  def withDefinitionList(x: Dl): this.type = withBlockContent(x)\n+  def withHorizontalRule(x: Hr): this.type = withBlockContent(x)\n+  def withNitfTable(x: NitfTable): this.type = withBlockContent(x)\n+  def withSubordinateHeadline(x: Hl2): this.type = withBlockContent(x)\n+\n+  def withTextParagraph(x: String, markAsSummary: Boolean = true): this.type = {","path":"src/main/scala/Builders.scala","position":27,"original_position":27,"commit_id":"74a60d0f2889b3a78fecb0b323655eaad3f984ce","original_commit_id":"74a60d0f2889b3a78fecb0b323655eaad3f984ce","user":{"login":"hosamaly","id":330633,"avatar_url":"https://avatars1.githubusercontent.com/u/330633?v=4","gravatar_id":"","url":"https://api.github.com/users/hosamaly","html_url":"https://github.com/hosamaly","followers_url":"https://api.github.com/users/hosamaly/followers","following_url":"https://api.github.com/users/hosamaly/following{/other_user}","gists_url":"https://api.github.com/users/hosamaly/gists{/gist_id}","starred_url":"https://api.github.com/users/hosamaly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hosamaly/subscriptions","organizations_url":"https://api.github.com/users/hosamaly/orgs","repos_url":"https://api.github.com/users/hosamaly/repos","events_url":"https://api.github.com/users/hosamaly/events{/privacy}","received_events_url":"https://api.github.com/users/hosamaly/received_events","type":"User","site_admin":false},"body":"This is a new helper method in this class.  It used to exist as `BodyHeadBuilder#withAbstract(String, Boolean)`.","created_at":"2018-03-26T15:45:34Z","updated_at":"2018-03-26T15:45:34Z","html_url":"https://github.com/guardian/nitf-scala/pull/6#discussion_r177139678","pull_request_url":"https://api.github.com/repos/guardian/nitf-scala/pulls/6","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/guardian/nitf-scala/pulls/comments/177139678"},"html":{"href":"https://github.com/guardian/nitf-scala/pull/6#discussion_r177139678"},"pull_request":{"href":"https://api.github.com/repos/guardian/nitf-scala/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/guardian/nitf-scala/pulls/6","id":177487748,"html_url":"https://github.com/guardian/nitf-scala/pull/6","diff_url":"https://github.com/guardian/nitf-scala/pull/6.diff","patch_url":"https://github.com/guardian/nitf-scala/pull/6.patch","issue_url":"https://api.github.com/repos/guardian/nitf-scala/issues/6","number":6,"state":"open","locked":false,"title":"Move builder methods `withText` and `withXml` to their own traits","user":{"login":"hosamaly","id":330633,"avatar_url":"https://avatars1.githubusercontent.com/u/330633?v=4","gravatar_id":"","url":"https://api.github.com/users/hosamaly","html_url":"https://github.com/hosamaly","followers_url":"https://api.github.com/users/hosamaly/followers","following_url":"https://api.github.com/users/hosamaly/following{/other_user}","gists_url":"https://api.github.com/users/hosamaly/gists{/gist_id}","starred_url":"https://api.github.com/users/hosamaly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hosamaly/subscriptions","organizations_url":"https://api.github.com/users/hosamaly/orgs","repos_url":"https://api.github.com/users/hosamaly/repos","events_url":"https://api.github.com/users/hosamaly/events{/privacy}","received_events_url":"https://api.github.com/users/hosamaly/received_events","type":"User","site_admin":false},"body":"* Move builder methods `withText` and `withXml` to their own traits\r\n* Add `DocDataBuilder#withDocId(String)` and `BodyBuilder#withEnd(BodyEnd)`\r\n* Accept an optional `TitleType` in `HeadBuilder#withTitle`\r\n* Implement an `AbstractBuilder`\r\n\r\nThese can go into a release, and then a separate release can be made for:\r\n* Deprecate `MixedContentBuilder#withXml`","created_at":"2018-03-26T15:43:29Z","updated_at":"2018-03-26T15:45:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d811b50686dd7ca13195c566bb857264e483234c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/guardian/nitf-scala/pulls/6/commits","review_comments_url":"https://api.github.com/repos/guardian/nitf-scala/pulls/6/comments","review_comment_url":"https://api.github.com/repos/guardian/nitf-scala/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardian/nitf-scala/issues/6/comments","statuses_url":"https://api.github.com/repos/guardian/nitf-scala/statuses/74a60d0f2889b3a78fecb0b323655eaad3f984ce","head":{"label":"guardian:deprecate-withXml","ref":"deprecate-withXml","sha":"74a60d0f2889b3a78fecb0b323655eaad3f984ce","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":123607116,"name":"nitf-scala","full_name":"guardian/nitf-scala","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/nitf-scala","description":"Scala library to parse and generate News Industry Text Format files","fork":false,"url":"https://api.github.com/repos/guardian/nitf-scala","forks_url":"https://api.github.com/repos/guardian/nitf-scala/forks","keys_url":"https://api.github.com/repos/guardian/nitf-scala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/nitf-scala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/nitf-scala/teams","hooks_url":"https://api.github.com/repos/guardian/nitf-scala/hooks","issue_events_url":"https://api.github.com/repos/guardian/nitf-scala/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/nitf-scala/events","assignees_url":"https://api.github.com/repos/guardian/nitf-scala/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/nitf-scala/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/nitf-scala/tags","blobs_url":"https://api.github.com/repos/guardian/nitf-scala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/nitf-scala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/nitf-scala/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/nitf-scala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/nitf-scala/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/nitf-scala/languages","stargazers_url":"https://api.github.com/repos/guardian/nitf-scala/stargazers","contributors_url":"https://api.github.com/repos/guardian/nitf-scala/contributors","subscribers_url":"https://api.github.com/repos/guardian/nitf-scala/subscribers","subscription_url":"https://api.github.com/repos/guardian/nitf-scala/subscription","commits_url":"https://api.github.com/repos/guardian/nitf-scala/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/nitf-scala/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/nitf-scala/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/nitf-scala/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/nitf-scala/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/nitf-scala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/nitf-scala/merges","archive_url":"https://api.github.com/repos/guardian/nitf-scala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/nitf-scala/downloads","issues_url":"https://api.github.com/repos/guardian/nitf-scala/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/nitf-scala/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/nitf-scala/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/nitf-scala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/nitf-scala/labels{/name}","releases_url":"https://api.github.com/repos/guardian/nitf-scala/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/nitf-scala/deployments","created_at":"2018-03-02T17:06:24Z","updated_at":"2018-03-21T10:55:29Z","pushed_at":"2018-03-26T15:43:30Z","git_url":"git://github.com/guardian/nitf-scala.git","ssh_url":"git@github.com:guardian/nitf-scala.git","clone_url":"https://github.com/guardian/nitf-scala.git","svn_url":"https://github.com/guardian/nitf-scala","homepage":null,"size":307,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"ee057d870798926686a25a1421bc2faf7ae23781","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":123607116,"name":"nitf-scala","full_name":"guardian/nitf-scala","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/nitf-scala","description":"Scala library to parse and generate News Industry Text Format files","fork":false,"url":"https://api.github.com/repos/guardian/nitf-scala","forks_url":"https://api.github.com/repos/guardian/nitf-scala/forks","keys_url":"https://api.github.com/repos/guardian/nitf-scala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/nitf-scala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/nitf-scala/teams","hooks_url":"https://api.github.com/repos/guardian/nitf-scala/hooks","issue_events_url":"https://api.github.com/repos/guardian/nitf-scala/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/nitf-scala/events","assignees_url":"https://api.github.com/repos/guardian/nitf-scala/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/nitf-scala/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/nitf-scala/tags","blobs_url":"https://api.github.com/repos/guardian/nitf-scala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/nitf-scala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/nitf-scala/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/nitf-scala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/nitf-scala/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/nitf-scala/languages","stargazers_url":"https://api.github.com/repos/guardian/nitf-scala/stargazers","contributors_url":"https://api.github.com/repos/guardian/nitf-scala/contributors","subscribers_url":"https://api.github.com/repos/guardian/nitf-scala/subscribers","subscription_url":"https://api.github.com/repos/guardian/nitf-scala/subscription","commits_url":"https://api.github.com/repos/guardian/nitf-scala/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/nitf-scala/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/nitf-scala/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/nitf-scala/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/nitf-scala/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/nitf-scala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/nitf-scala/merges","archive_url":"https://api.github.com/repos/guardian/nitf-scala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/nitf-scala/downloads","issues_url":"https://api.github.com/repos/guardian/nitf-scala/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/nitf-scala/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/nitf-scala/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/nitf-scala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/nitf-scala/labels{/name}","releases_url":"https://api.github.com/repos/guardian/nitf-scala/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/nitf-scala/deployments","created_at":"2018-03-02T17:06:24Z","updated_at":"2018-03-21T10:55:29Z","pushed_at":"2018-03-26T15:43:30Z","git_url":"git://github.com/guardian/nitf-scala.git","ssh_url":"git@github.com:guardian/nitf-scala.git","clone_url":"https://github.com/guardian/nitf-scala.git","svn_url":"https://github.com/guardian/nitf-scala","homepage":null,"size":307,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/nitf-scala/pulls/6"},"html":{"href":"https://github.com/guardian/nitf-scala/pull/6"},"issue":{"href":"https://api.github.com/repos/guardian/nitf-scala/issues/6"},"comments":{"href":"https://api.github.com/repos/guardian/nitf-scala/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/nitf-scala/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/nitf-scala/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardian/nitf-scala/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/nitf-scala/statuses/74a60d0f2889b3a78fecb0b323655eaad3f984ce"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"hosamaly"}}