{"action":"closed","number":344,"pull_request":{"url":"https://api.github.com/repos/spatie/laravel-activitylog/pulls/344","id":168407823,"html_url":"https://github.com/spatie/laravel-activitylog/pull/344","diff_url":"https://github.com/spatie/laravel-activitylog/pull/344.diff","patch_url":"https://github.com/spatie/laravel-activitylog/pull/344.patch","issue_url":"https://api.github.com/repos/spatie/laravel-activitylog/issues/344","number":344,"state":"closed","locked":false,"title":"Use child class instead of base class","user":{"login":"AlexLisenkov","id":3088831,"avatar_url":"https://avatars2.githubusercontent.com/u/3088831?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexLisenkov","html_url":"https://github.com/AlexLisenkov","followers_url":"https://api.github.com/users/AlexLisenkov/followers","following_url":"https://api.github.com/users/AlexLisenkov/following{/other_user}","gists_url":"https://api.github.com/users/AlexLisenkov/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexLisenkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexLisenkov/subscriptions","organizations_url":"https://api.github.com/users/AlexLisenkov/orgs","repos_url":"https://api.github.com/users/AlexLisenkov/repos","events_url":"https://api.github.com/users/AlexLisenkov/events{/privacy}","received_events_url":"https://api.github.com/users/AlexLisenkov/received_events","type":"User","site_admin":false},"body":"I had some problems with this method and inheritance.\r\n`__CLASS__` returned my base class which doesn't use soft deletes, but a child class inheriting the base class did. The statement would be false while I expected it to be true.\r\nFixed it by changing it with `static::class`, this will return the child class.","created_at":"2018-02-10T16:01:55Z","updated_at":"2018-02-10T22:19:59Z","closed_at":"2018-02-10T22:19:59Z","merged_at":"2018-02-10T22:19:59Z","merge_commit_sha":"8e8486b3ee2bb7221f6458bdb4f5c0625c58b9e6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spatie/laravel-activitylog/pulls/344/commits","review_comments_url":"https://api.github.com/repos/spatie/laravel-activitylog/pulls/344/comments","review_comment_url":"https://api.github.com/repos/spatie/laravel-activitylog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spatie/laravel-activitylog/issues/344/comments","statuses_url":"https://api.github.com/repos/spatie/laravel-activitylog/statuses/defe82bcbaf7e63647ffcb82581f275e16cb35ee","head":{"label":"AlexLisenkov:child-class","ref":"child-class","sha":"defe82bcbaf7e63647ffcb82581f275e16cb35ee","user":{"login":"AlexLisenkov","id":3088831,"avatar_url":"https://avatars2.githubusercontent.com/u/3088831?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexLisenkov","html_url":"https://github.com/AlexLisenkov","followers_url":"https://api.github.com/users/AlexLisenkov/followers","following_url":"https://api.github.com/users/AlexLisenkov/following{/other_user}","gists_url":"https://api.github.com/users/AlexLisenkov/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexLisenkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexLisenkov/subscriptions","organizations_url":"https://api.github.com/users/AlexLisenkov/orgs","repos_url":"https://api.github.com/users/AlexLisenkov/repos","events_url":"https://api.github.com/users/AlexLisenkov/events{/privacy}","received_events_url":"https://api.github.com/users/AlexLisenkov/received_events","type":"User","site_admin":false},"repo":{"id":121028834,"name":"laravel-activitylog","full_name":"AlexLisenkov/laravel-activitylog","owner":{"login":"AlexLisenkov","id":3088831,"avatar_url":"https://avatars2.githubusercontent.com/u/3088831?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexLisenkov","html_url":"https://github.com/AlexLisenkov","followers_url":"https://api.github.com/users/AlexLisenkov/followers","following_url":"https://api.github.com/users/AlexLisenkov/following{/other_user}","gists_url":"https://api.github.com/users/AlexLisenkov/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexLisenkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexLisenkov/subscriptions","organizations_url":"https://api.github.com/users/AlexLisenkov/orgs","repos_url":"https://api.github.com/users/AlexLisenkov/repos","events_url":"https://api.github.com/users/AlexLisenkov/events{/privacy}","received_events_url":"https://api.github.com/users/AlexLisenkov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AlexLisenkov/laravel-activitylog","description":"Log activity inside your Laravel app","fork":true,"url":"https://api.github.com/repos/AlexLisenkov/laravel-activitylog","forks_url":"https://api.github.com/repos/AlexLisenkov/laravel-activitylog/forks","keys_url":"https://api.github.com/repos/AlexLisenkov/laravel-activitylog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AlexLisenkov/laravel-activitylog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AlexLisenkov/laravel-activitylog/teams","hooks_url":"https://api.github.com/repos/AlexLisenkov/laravel-activitylog/hooks","issue_events_url":"https://api.github.com/repos/AlexLisenkov/laravel-activitylog/issues/events{/number}","events_url":"https://api.github.com/repos/AlexLisenkov/laravel-activitylog/events","assignees_url":"https://api.github.com/repos/AlexLisenkov/laravel-activitylog/assignees{/user}","branches_url":"https://api.github.com/repos/AlexLisenkov/laravel-activitylog/branches{/branch}","tags_url":"https://api.github.com/repos/AlexLisenkov/laravel-activitylog/tags","blobs_url":"https://api.github.com/repos/AlexLisenkov/laravel-activitylog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AlexLisenkov/laravel-activitylog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AlexLisenkov/laravel-activitylog/git/refs{/sha}","trees_url":"https://api.github.com/repos/AlexLisenkov/laravel-activitylog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AlexLisenkov/laravel-activitylog/statuses/{sha}","languages_url":"https://api.github.com/repos/AlexLisenkov/laravel-activitylog/languages","stargazers_url":"https://api.github.com/repos/AlexLisenkov/laravel-activitylog/stargazers","contributors_url":"https://api.github.com/repos/AlexLisenkov/laravel-activitylog/contributors","subscribers_url":"https://api.github.com/repos/AlexLisenkov/laravel-activitylog/subscribers","subscription_url":"https://api.github.com/repos/AlexLisenkov/laravel-activitylog/subscription","commits_url":"https://api.github.com/repos/AlexLisenkov/laravel-activitylog/commits{/sha}","git_commits_url":"https://api.github.com/repos/AlexLisenkov/laravel-activitylog/git/commits{/sha}","comments_url":"https://api.github.com/repos/AlexLisenkov/laravel-activitylog/comments{/number}","issue_comment_url":"https://api.github.com/repos/AlexLisenkov/laravel-activitylog/issues/comments{/number}","contents_url":"https://api.github.com/repos/AlexLisenkov/laravel-activitylog/contents/{+path}","compare_url":"https://api.github.com/repos/AlexLisenkov/laravel-activitylog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AlexLisenkov/laravel-activitylog/merges","archive_url":"https://api.github.com/repos/AlexLisenkov/laravel-activitylog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AlexLisenkov/laravel-activitylog/downloads","issues_url":"https://api.github.com/repos/AlexLisenkov/laravel-activitylog/issues{/number}","pulls_url":"https://api.github.com/repos/AlexLisenkov/laravel-activitylog/pulls{/number}","milestones_url":"https://api.github.com/repos/AlexLisenkov/laravel-activitylog/milestones{/number}","notifications_url":"https://api.github.com/repos/AlexLisenkov/laravel-activitylog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AlexLisenkov/laravel-activitylog/labels{/name}","releases_url":"https://api.github.com/repos/AlexLisenkov/laravel-activitylog/releases{/id}","deployments_url":"https://api.github.com/repos/AlexLisenkov/laravel-activitylog/deployments","created_at":"2018-02-10T15:46:51Z","updated_at":"2018-02-10T15:46:53Z","pushed_at":"2018-02-10T15:52:03Z","git_url":"git://github.com/AlexLisenkov/laravel-activitylog.git","ssh_url":"git@github.com:AlexLisenkov/laravel-activitylog.git","clone_url":"https://github.com/AlexLisenkov/laravel-activitylog.git","svn_url":"https://github.com/AlexLisenkov/laravel-activitylog","homepage":"https://docs.spatie.be/laravel-activitylog/v1/introduction","size":206,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spatie:master","ref":"master","sha":"becd1b16f216f6dd0dab215fd2c0e91b3db09795","user":{"login":"spatie","id":7535935,"avatar_url":"https://avatars0.githubusercontent.com/u/7535935?v=4","gravatar_id":"","url":"https://api.github.com/users/spatie","html_url":"https://github.com/spatie","followers_url":"https://api.github.com/users/spatie/followers","following_url":"https://api.github.com/users/spatie/following{/other_user}","gists_url":"https://api.github.com/users/spatie/gists{/gist_id}","starred_url":"https://api.github.com/users/spatie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatie/subscriptions","organizations_url":"https://api.github.com/users/spatie/orgs","repos_url":"https://api.github.com/users/spatie/repos","events_url":"https://api.github.com/users/spatie/events{/privacy}","received_events_url":"https://api.github.com/users/spatie/received_events","type":"Organization","site_admin":false},"repo":{"id":61802818,"name":"laravel-activitylog","full_name":"spatie/laravel-activitylog","owner":{"login":"spatie","id":7535935,"avatar_url":"https://avatars0.githubusercontent.com/u/7535935?v=4","gravatar_id":"","url":"https://api.github.com/users/spatie","html_url":"https://github.com/spatie","followers_url":"https://api.github.com/users/spatie/followers","following_url":"https://api.github.com/users/spatie/following{/other_user}","gists_url":"https://api.github.com/users/spatie/gists{/gist_id}","starred_url":"https://api.github.com/users/spatie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatie/subscriptions","organizations_url":"https://api.github.com/users/spatie/orgs","repos_url":"https://api.github.com/users/spatie/repos","events_url":"https://api.github.com/users/spatie/events{/privacy}","received_events_url":"https://api.github.com/users/spatie/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spatie/laravel-activitylog","description":"Log activity inside your Laravel app","fork":false,"url":"https://api.github.com/repos/spatie/laravel-activitylog","forks_url":"https://api.github.com/repos/spatie/laravel-activitylog/forks","keys_url":"https://api.github.com/repos/spatie/laravel-activitylog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spatie/laravel-activitylog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spatie/laravel-activitylog/teams","hooks_url":"https://api.github.com/repos/spatie/laravel-activitylog/hooks","issue_events_url":"https://api.github.com/repos/spatie/laravel-activitylog/issues/events{/number}","events_url":"https://api.github.com/repos/spatie/laravel-activitylog/events","assignees_url":"https://api.github.com/repos/spatie/laravel-activitylog/assignees{/user}","branches_url":"https://api.github.com/repos/spatie/laravel-activitylog/branches{/branch}","tags_url":"https://api.github.com/repos/spatie/laravel-activitylog/tags","blobs_url":"https://api.github.com/repos/spatie/laravel-activitylog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spatie/laravel-activitylog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spatie/laravel-activitylog/git/refs{/sha}","trees_url":"https://api.github.com/repos/spatie/laravel-activitylog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spatie/laravel-activitylog/statuses/{sha}","languages_url":"https://api.github.com/repos/spatie/laravel-activitylog/languages","stargazers_url":"https://api.github.com/repos/spatie/laravel-activitylog/stargazers","contributors_url":"https://api.github.com/repos/spatie/laravel-activitylog/contributors","subscribers_url":"https://api.github.com/repos/spatie/laravel-activitylog/subscribers","subscription_url":"https://api.github.com/repos/spatie/laravel-activitylog/subscription","commits_url":"https://api.github.com/repos/spatie/laravel-activitylog/commits{/sha}","git_commits_url":"https://api.github.com/repos/spatie/laravel-activitylog/git/commits{/sha}","comments_url":"https://api.github.com/repos/spatie/laravel-activitylog/comments{/number}","issue_comment_url":"https://api.github.com/repos/spatie/laravel-activitylog/issues/comments{/number}","contents_url":"https://api.github.com/repos/spatie/laravel-activitylog/contents/{+path}","compare_url":"https://api.github.com/repos/spatie/laravel-activitylog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spatie/laravel-activitylog/merges","archive_url":"https://api.github.com/repos/spatie/laravel-activitylog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spatie/laravel-activitylog/downloads","issues_url":"https://api.github.com/repos/spatie/laravel-activitylog/issues{/number}","pulls_url":"https://api.github.com/repos/spatie/laravel-activitylog/pulls{/number}","milestones_url":"https://api.github.com/repos/spatie/laravel-activitylog/milestones{/number}","notifications_url":"https://api.github.com/repos/spatie/laravel-activitylog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spatie/laravel-activitylog/labels{/name}","releases_url":"https://api.github.com/repos/spatie/laravel-activitylog/releases{/id}","deployments_url":"https://api.github.com/repos/spatie/laravel-activitylog/deployments","created_at":"2016-06-23T12:17:12Z","updated_at":"2018-02-10T18:49:42Z","pushed_at":"2018-02-10T22:19:59Z","git_url":"git://github.com/spatie/laravel-activitylog.git","ssh_url":"git@github.com:spatie/laravel-activitylog.git","clone_url":"https://github.com/spatie/laravel-activitylog.git","svn_url":"https://github.com/spatie/laravel-activitylog","homepage":"https://docs.spatie.be/laravel-activitylog/v1/introduction","size":204,"stargazers_count":1341,"watchers_count":1341,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":206,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":206,"open_issues":0,"watchers":1341,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spatie/laravel-activitylog/pulls/344"},"html":{"href":"https://github.com/spatie/laravel-activitylog/pull/344"},"issue":{"href":"https://api.github.com/repos/spatie/laravel-activitylog/issues/344"},"comments":{"href":"https://api.github.com/repos/spatie/laravel-activitylog/issues/344/comments"},"review_comments":{"href":"https://api.github.com/repos/spatie/laravel-activitylog/pulls/344/comments"},"review_comment":{"href":"https://api.github.com/repos/spatie/laravel-activitylog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spatie/laravel-activitylog/pulls/344/commits"},"statuses":{"href":"https://api.github.com/repos/spatie/laravel-activitylog/statuses/defe82bcbaf7e63647ffcb82581f275e16cb35ee"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"freekmurze","id":483853,"avatar_url":"https://avatars2.githubusercontent.com/u/483853?v=4","gravatar_id":"","url":"https://api.github.com/users/freekmurze","html_url":"https://github.com/freekmurze","followers_url":"https://api.github.com/users/freekmurze/followers","following_url":"https://api.github.com/users/freekmurze/following{/other_user}","gists_url":"https://api.github.com/users/freekmurze/gists{/gist_id}","starred_url":"https://api.github.com/users/freekmurze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freekmurze/subscriptions","organizations_url":"https://api.github.com/users/freekmurze/orgs","repos_url":"https://api.github.com/users/freekmurze/repos","events_url":"https://api.github.com/users/freekmurze/events{/privacy}","received_events_url":"https://api.github.com/users/freekmurze/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"freekmurze"}}