{"action":"closed","number":3198,"pull_request":{"url":"https://api.github.com/repos/learningequality/kolibri/pulls/3198","id":169223351,"html_url":"https://github.com/learningequality/kolibri/pull/3198","diff_url":"https://github.com/learningequality/kolibri/pull/3198.diff","patch_url":"https://github.com/learningequality/kolibri/pull/3198.patch","issue_url":"https://api.github.com/repos/learningequality/kolibri/issues/3198","number":3198,"state":"closed","locked":false,"title":"limit nesting in css - untested","user":{"login":"indirectlylit","id":2367265,"avatar_url":"https://avatars2.githubusercontent.com/u/2367265?v=4","gravatar_id":"","url":"https://api.github.com/users/indirectlylit","html_url":"https://github.com/indirectlylit","followers_url":"https://api.github.com/users/indirectlylit/followers","following_url":"https://api.github.com/users/indirectlylit/following{/other_user}","gists_url":"https://api.github.com/users/indirectlylit/gists{/gist_id}","starred_url":"https://api.github.com/users/indirectlylit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indirectlylit/subscriptions","organizations_url":"https://api.github.com/users/indirectlylit/orgs","repos_url":"https://api.github.com/users/indirectlylit/repos","events_url":"https://api.github.com/users/indirectlylit/events{/privacy}","received_events_url":"https://api.github.com/users/indirectlylit/received_events","type":"User","site_admin":false},"body":"### Summary\r\n\r\nDemonstrates what some of our code might look like without using nesting\r\n\r\n### Reviewer guidance\r\n<!--\r\n * how can a reviewer test these changes?\r\n * are there any risky areas that deserve extra testing\r\n-->\r\n\r\n…\r\n\r\n### References\r\n<!--\r\n * references to related issues and PRs\r\n * links to mockups or specs for new features\r\n * links to the diffs for any dependency updates, e.g. in iceqube or the perseus plugin\r\n-->\r\n\r\n…\r\n\r\n----\r\n\r\n### Contributor Checklist\r\n\r\n- [ ] PR has the correct target branch and milestone\r\n- [ ] PR has 'needs review' or 'work-in-progress' label\r\n- [ ] Contributor has fully tested the PR manually\r\n- [ ] Screenshots of any front-end changes are in the PR description\r\n- [ ] If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')\r\n\r\n### Reviewer Checklist\r\n\r\n- [ ] Automated test coverage is satisfactory\r\n- [ ] Reviewer has fully tested the PR manually\r\n- [ ] PR has been tested for [accessibility regressions](http://kolibri-dev.readthedocs.io/en/develop/manual_testing.html#accessibility-a11y-testing)\r\n- [ ] External dependencies files were updated (`yarn` and `pip`)\r\n- [ ] Documentation is updated\r\n- [ ] Link to diff of internal dependency change is included\r\n- [ ] CHANGELOG.rst is updated for high-level changes\r\n- [ ] Contributor is in AUTHORS.rst\r\n","created_at":"2018-02-14T21:12:39Z","updated_at":"2018-05-04T00:41:31Z","closed_at":"2018-05-04T00:41:30Z","merged_at":null,"merge_commit_sha":"41ffba290827a7685c9026b9b80186c350229a92","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/learningequality/kolibri/pulls/3198/commits","review_comments_url":"https://api.github.com/repos/learningequality/kolibri/pulls/3198/comments","review_comment_url":"https://api.github.com/repos/learningequality/kolibri/pulls/comments{/number}","comments_url":"https://api.github.com/repos/learningequality/kolibri/issues/3198/comments","statuses_url":"https://api.github.com/repos/learningequality/kolibri/statuses/7938c5a5757ad8b0ce07c744f34f8bb1784e3971","head":{"label":"indirectlylit:limit-nesting","ref":"limit-nesting","sha":"7938c5a5757ad8b0ce07c744f34f8bb1784e3971","user":{"login":"indirectlylit","id":2367265,"avatar_url":"https://avatars2.githubusercontent.com/u/2367265?v=4","gravatar_id":"","url":"https://api.github.com/users/indirectlylit","html_url":"https://github.com/indirectlylit","followers_url":"https://api.github.com/users/indirectlylit/followers","following_url":"https://api.github.com/users/indirectlylit/following{/other_user}","gists_url":"https://api.github.com/users/indirectlylit/gists{/gist_id}","starred_url":"https://api.github.com/users/indirectlylit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indirectlylit/subscriptions","organizations_url":"https://api.github.com/users/indirectlylit/orgs","repos_url":"https://api.github.com/users/indirectlylit/repos","events_url":"https://api.github.com/users/indirectlylit/events{/privacy}","received_events_url":"https://api.github.com/users/indirectlylit/received_events","type":"User","site_admin":false},"repo":{"id":54517539,"name":"kolibri","full_name":"indirectlylit/kolibri","owner":{"login":"indirectlylit","id":2367265,"avatar_url":"https://avatars2.githubusercontent.com/u/2367265?v=4","gravatar_id":"","url":"https://api.github.com/users/indirectlylit","html_url":"https://github.com/indirectlylit","followers_url":"https://api.github.com/users/indirectlylit/followers","following_url":"https://api.github.com/users/indirectlylit/following{/other_user}","gists_url":"https://api.github.com/users/indirectlylit/gists{/gist_id}","starred_url":"https://api.github.com/users/indirectlylit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indirectlylit/subscriptions","organizations_url":"https://api.github.com/users/indirectlylit/orgs","repos_url":"https://api.github.com/users/indirectlylit/repos","events_url":"https://api.github.com/users/indirectlylit/events{/privacy}","received_events_url":"https://api.github.com/users/indirectlylit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/indirectlylit/kolibri","description":"Kolibri","fork":true,"url":"https://api.github.com/repos/indirectlylit/kolibri","forks_url":"https://api.github.com/repos/indirectlylit/kolibri/forks","keys_url":"https://api.github.com/repos/indirectlylit/kolibri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/indirectlylit/kolibri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/indirectlylit/kolibri/teams","hooks_url":"https://api.github.com/repos/indirectlylit/kolibri/hooks","issue_events_url":"https://api.github.com/repos/indirectlylit/kolibri/issues/events{/number}","events_url":"https://api.github.com/repos/indirectlylit/kolibri/events","assignees_url":"https://api.github.com/repos/indirectlylit/kolibri/assignees{/user}","branches_url":"https://api.github.com/repos/indirectlylit/kolibri/branches{/branch}","tags_url":"https://api.github.com/repos/indirectlylit/kolibri/tags","blobs_url":"https://api.github.com/repos/indirectlylit/kolibri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/indirectlylit/kolibri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/indirectlylit/kolibri/git/refs{/sha}","trees_url":"https://api.github.com/repos/indirectlylit/kolibri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/indirectlylit/kolibri/statuses/{sha}","languages_url":"https://api.github.com/repos/indirectlylit/kolibri/languages","stargazers_url":"https://api.github.com/repos/indirectlylit/kolibri/stargazers","contributors_url":"https://api.github.com/repos/indirectlylit/kolibri/contributors","subscribers_url":"https://api.github.com/repos/indirectlylit/kolibri/subscribers","subscription_url":"https://api.github.com/repos/indirectlylit/kolibri/subscription","commits_url":"https://api.github.com/repos/indirectlylit/kolibri/commits{/sha}","git_commits_url":"https://api.github.com/repos/indirectlylit/kolibri/git/commits{/sha}","comments_url":"https://api.github.com/repos/indirectlylit/kolibri/comments{/number}","issue_comment_url":"https://api.github.com/repos/indirectlylit/kolibri/issues/comments{/number}","contents_url":"https://api.github.com/repos/indirectlylit/kolibri/contents/{+path}","compare_url":"https://api.github.com/repos/indirectlylit/kolibri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/indirectlylit/kolibri/merges","archive_url":"https://api.github.com/repos/indirectlylit/kolibri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/indirectlylit/kolibri/downloads","issues_url":"https://api.github.com/repos/indirectlylit/kolibri/issues{/number}","pulls_url":"https://api.github.com/repos/indirectlylit/kolibri/pulls{/number}","milestones_url":"https://api.github.com/repos/indirectlylit/kolibri/milestones{/number}","notifications_url":"https://api.github.com/repos/indirectlylit/kolibri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/indirectlylit/kolibri/labels{/name}","releases_url":"https://api.github.com/repos/indirectlylit/kolibri/releases{/id}","deployments_url":"https://api.github.com/repos/indirectlylit/kolibri/deployments","created_at":"2016-03-23T00:08:12Z","updated_at":"2018-04-07T19:47:48Z","pushed_at":"2018-04-20T19:51:10Z","git_url":"git://github.com/indirectlylit/kolibri.git","ssh_url":"git@github.com:indirectlylit/kolibri.git","clone_url":"https://github.com/indirectlylit/kolibri.git","svn_url":"https://github.com/indirectlylit/kolibri","homepage":"http://learningequality.org/kolibri/","size":37665,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"learningequality:develop","ref":"develop","sha":"7f2f58ae151f249feb1352b2c9a0f2749cfa99ca","user":{"login":"learningequality","id":3926525,"avatar_url":"https://avatars1.githubusercontent.com/u/3926525?v=4","gravatar_id":"","url":"https://api.github.com/users/learningequality","html_url":"https://github.com/learningequality","followers_url":"https://api.github.com/users/learningequality/followers","following_url":"https://api.github.com/users/learningequality/following{/other_user}","gists_url":"https://api.github.com/users/learningequality/gists{/gist_id}","starred_url":"https://api.github.com/users/learningequality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/learningequality/subscriptions","organizations_url":"https://api.github.com/users/learningequality/orgs","repos_url":"https://api.github.com/users/learningequality/repos","events_url":"https://api.github.com/users/learningequality/events{/privacy}","received_events_url":"https://api.github.com/users/learningequality/received_events","type":"Organization","site_admin":false},"repo":{"id":49976939,"name":"kolibri","full_name":"learningequality/kolibri","owner":{"login":"learningequality","id":3926525,"avatar_url":"https://avatars1.githubusercontent.com/u/3926525?v=4","gravatar_id":"","url":"https://api.github.com/users/learningequality","html_url":"https://github.com/learningequality","followers_url":"https://api.github.com/users/learningequality/followers","following_url":"https://api.github.com/users/learningequality/following{/other_user}","gists_url":"https://api.github.com/users/learningequality/gists{/gist_id}","starred_url":"https://api.github.com/users/learningequality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/learningequality/subscriptions","organizations_url":"https://api.github.com/users/learningequality/orgs","repos_url":"https://api.github.com/users/learningequality/repos","events_url":"https://api.github.com/users/learningequality/events{/privacy}","received_events_url":"https://api.github.com/users/learningequality/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/learningequality/kolibri","description":"Kolibri: the offline app for universal education","fork":false,"url":"https://api.github.com/repos/learningequality/kolibri","forks_url":"https://api.github.com/repos/learningequality/kolibri/forks","keys_url":"https://api.github.com/repos/learningequality/kolibri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/learningequality/kolibri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/learningequality/kolibri/teams","hooks_url":"https://api.github.com/repos/learningequality/kolibri/hooks","issue_events_url":"https://api.github.com/repos/learningequality/kolibri/issues/events{/number}","events_url":"https://api.github.com/repos/learningequality/kolibri/events","assignees_url":"https://api.github.com/repos/learningequality/kolibri/assignees{/user}","branches_url":"https://api.github.com/repos/learningequality/kolibri/branches{/branch}","tags_url":"https://api.github.com/repos/learningequality/kolibri/tags","blobs_url":"https://api.github.com/repos/learningequality/kolibri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/learningequality/kolibri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/learningequality/kolibri/git/refs{/sha}","trees_url":"https://api.github.com/repos/learningequality/kolibri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/learningequality/kolibri/statuses/{sha}","languages_url":"https://api.github.com/repos/learningequality/kolibri/languages","stargazers_url":"https://api.github.com/repos/learningequality/kolibri/stargazers","contributors_url":"https://api.github.com/repos/learningequality/kolibri/contributors","subscribers_url":"https://api.github.com/repos/learningequality/kolibri/subscribers","subscription_url":"https://api.github.com/repos/learningequality/kolibri/subscription","commits_url":"https://api.github.com/repos/learningequality/kolibri/commits{/sha}","git_commits_url":"https://api.github.com/repos/learningequality/kolibri/git/commits{/sha}","comments_url":"https://api.github.com/repos/learningequality/kolibri/comments{/number}","issue_comment_url":"https://api.github.com/repos/learningequality/kolibri/issues/comments{/number}","contents_url":"https://api.github.com/repos/learningequality/kolibri/contents/{+path}","compare_url":"https://api.github.com/repos/learningequality/kolibri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/learningequality/kolibri/merges","archive_url":"https://api.github.com/repos/learningequality/kolibri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/learningequality/kolibri/downloads","issues_url":"https://api.github.com/repos/learningequality/kolibri/issues{/number}","pulls_url":"https://api.github.com/repos/learningequality/kolibri/pulls{/number}","milestones_url":"https://api.github.com/repos/learningequality/kolibri/milestones{/number}","notifications_url":"https://api.github.com/repos/learningequality/kolibri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/learningequality/kolibri/labels{/name}","releases_url":"https://api.github.com/repos/learningequality/kolibri/releases{/id}","deployments_url":"https://api.github.com/repos/learningequality/kolibri/deployments","created_at":"2016-01-19T19:22:07Z","updated_at":"2018-05-04T00:26:33Z","pushed_at":"2018-05-04T00:28:25Z","git_url":"git://github.com/learningequality/kolibri.git","ssh_url":"git@github.com:learningequality/kolibri.git","clone_url":"https://github.com/learningequality/kolibri.git","svn_url":"https://github.com/learningequality/kolibri","homepage":"http://learningequality.org/kolibri/","size":37604,"stargazers_count":163,"watchers_count":163,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":128,"mirror_url":null,"archived":false,"open_issues_count":245,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":128,"open_issues":245,"watchers":163,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/3198"},"html":{"href":"https://github.com/learningequality/kolibri/pull/3198"},"issue":{"href":"https://api.github.com/repos/learningequality/kolibri/issues/3198"},"comments":{"href":"https://api.github.com/repos/learningequality/kolibri/issues/3198/comments"},"review_comments":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/3198/comments"},"review_comment":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/3198/commits"},"statuses":{"href":"https://api.github.com/repos/learningequality/kolibri/statuses/7938c5a5757ad8b0ce07c744f34f8bb1784e3971"}},"author_association":"OWNER","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":237,"deletions":253,"changed_files":11}}
{"actor":{"display_login":"indirectlylit"}}