{"action":"closed","number":87,"pull_request":{"url":"https://api.github.com/repos/StratusNetwork/projectares/pulls/87","id":186488273,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg2NDg4Mjcz","html_url":"https://github.com/StratusNetwork/projectares/pull/87","diff_url":"https://github.com/StratusNetwork/projectares/pull/87.diff","patch_url":"https://github.com/StratusNetwork/projectares/pull/87.patch","issue_url":"https://api.github.com/repos/StratusNetwork/projectares/issues/87","number":87,"state":"closed","locked":false,"title":"Prevent flags from dropping as items.","user":{"login":"Pugzy","id":8608892,"node_id":"MDQ6VXNlcjg2MDg4OTI=","avatar_url":"https://avatars3.githubusercontent.com/u/8608892?v=4","gravatar_id":"","url":"https://api.github.com/users/Pugzy","html_url":"https://github.com/Pugzy","followers_url":"https://api.github.com/users/Pugzy/followers","following_url":"https://api.github.com/users/Pugzy/following{/other_user}","gists_url":"https://api.github.com/users/Pugzy/gists{/gist_id}","starred_url":"https://api.github.com/users/Pugzy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pugzy/subscriptions","organizations_url":"https://api.github.com/users/Pugzy/orgs","repos_url":"https://api.github.com/users/Pugzy/repos","events_url":"https://api.github.com/users/Pugzy/events{/privacy}","received_events_url":"https://api.github.com/users/Pugzy/received_events","type":"User","site_admin":false},"body":"### Issue\r\nCurrently banners (flags) are always dropped when a player dies whilst carrying it. \r\nThis litters the map with fake flags and could cause confusion for new players.\r\n\r\n### Reason\r\nDrops are checked against the banner item using the `isSimilar` method.\r\n\r\nThis method checks that the following are equal:\r\n\r\n|        method       |     getBannerItem result    |        itemStack result        |\r\n|:-------------------:|:---------------------------:|:------------------------------:|\r\n|           getTypeID == |             true            |              true              |\r\n|       getDurability == |              0              |       (banner datavalue)       |\r\n|         hasItemMeta |             true            |              true              |\r\n| equals(getItemMeta) | banner meta with base color | banner meta without base color |\r\n\r\nAbove is the current output of these tests with the correct items failing in both the `getDurability ` and `equals(getItemMeta)` checks. Through painful testing I've found that this is due to the itemStack having a durability (which is the data value) and the banner having none, the meta comparison fails due to the lack of a `base-color` tag within the itemStack (which the banner has).\r\n\r\n### Resolution\r\nThis pull request resolves the above by using a `BooleanItemTag` over checking just similarities in the meta. This will mean that only flag banners will be removed and similar patterned banners will not. The tag is added at instantiation and checked on player death. \r\n\r\n### Testing\r\nTested using local a PGM server and the two maps `Concourse` (with building allowed after crafting custom banners) and `Palace CTF` a two flag map.\r\n\r\nNot dabbled with Java in a long time and these lambda thingamabobs are new to me so more than welcome for pointers.\r\n   ","created_at":"2018-05-07T23:10:09Z","updated_at":"2018-11-21T00:04:49Z","closed_at":"2018-11-21T00:04:49Z","merged_at":"2018-11-21T00:04:49Z","merge_commit_sha":"72e656ea8ff74b7cf897491402639d6db9a0c18f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":959771378,"node_id":"MDU6TGFiZWw5NTk3NzEzNzg=","url":"https://api.github.com/repos/StratusNetwork/projectares/labels/ready","name":"ready","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/StratusNetwork/projectares/pulls/87/commits","review_comments_url":"https://api.github.com/repos/StratusNetwork/projectares/pulls/87/comments","review_comment_url":"https://api.github.com/repos/StratusNetwork/projectares/pulls/comments{/number}","comments_url":"https://api.github.com/repos/StratusNetwork/projectares/issues/87/comments","statuses_url":"https://api.github.com/repos/StratusNetwork/projectares/statuses/f7a8b75ec0fea1a2df0faea3e50c3b72f1bd8089","head":{"label":"Pugzy:flag-drop","ref":"flag-drop","sha":"f7a8b75ec0fea1a2df0faea3e50c3b72f1bd8089","user":{"login":"Pugzy","id":8608892,"node_id":"MDQ6VXNlcjg2MDg4OTI=","avatar_url":"https://avatars3.githubusercontent.com/u/8608892?v=4","gravatar_id":"","url":"https://api.github.com/users/Pugzy","html_url":"https://github.com/Pugzy","followers_url":"https://api.github.com/users/Pugzy/followers","following_url":"https://api.github.com/users/Pugzy/following{/other_user}","gists_url":"https://api.github.com/users/Pugzy/gists{/gist_id}","starred_url":"https://api.github.com/users/Pugzy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pugzy/subscriptions","organizations_url":"https://api.github.com/users/Pugzy/orgs","repos_url":"https://api.github.com/users/Pugzy/repos","events_url":"https://api.github.com/users/Pugzy/events{/privacy}","received_events_url":"https://api.github.com/users/Pugzy/received_events","type":"User","site_admin":false},"repo":{"id":132523684,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI1MjM2ODQ=","name":"ProjectAres","full_name":"Pugzy/ProjectAres","private":false,"owner":{"login":"Pugzy","id":8608892,"node_id":"MDQ6VXNlcjg2MDg4OTI=","avatar_url":"https://avatars3.githubusercontent.com/u/8608892?v=4","gravatar_id":"","url":"https://api.github.com/users/Pugzy","html_url":"https://github.com/Pugzy","followers_url":"https://api.github.com/users/Pugzy/followers","following_url":"https://api.github.com/users/Pugzy/following{/other_user}","gists_url":"https://api.github.com/users/Pugzy/gists{/gist_id}","starred_url":"https://api.github.com/users/Pugzy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pugzy/subscriptions","organizations_url":"https://api.github.com/users/Pugzy/orgs","repos_url":"https://api.github.com/users/Pugzy/repos","events_url":"https://api.github.com/users/Pugzy/events{/privacy}","received_events_url":"https://api.github.com/users/Pugzy/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Pugzy/ProjectAres","description":"Server-side game plugins that extend the Minecraft stack","fork":true,"url":"https://api.github.com/repos/Pugzy/ProjectAres","forks_url":"https://api.github.com/repos/Pugzy/ProjectAres/forks","keys_url":"https://api.github.com/repos/Pugzy/ProjectAres/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Pugzy/ProjectAres/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Pugzy/ProjectAres/teams","hooks_url":"https://api.github.com/repos/Pugzy/ProjectAres/hooks","issue_events_url":"https://api.github.com/repos/Pugzy/ProjectAres/issues/events{/number}","events_url":"https://api.github.com/repos/Pugzy/ProjectAres/events","assignees_url":"https://api.github.com/repos/Pugzy/ProjectAres/assignees{/user}","branches_url":"https://api.github.com/repos/Pugzy/ProjectAres/branches{/branch}","tags_url":"https://api.github.com/repos/Pugzy/ProjectAres/tags","blobs_url":"https://api.github.com/repos/Pugzy/ProjectAres/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Pugzy/ProjectAres/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Pugzy/ProjectAres/git/refs{/sha}","trees_url":"https://api.github.com/repos/Pugzy/ProjectAres/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Pugzy/ProjectAres/statuses/{sha}","languages_url":"https://api.github.com/repos/Pugzy/ProjectAres/languages","stargazers_url":"https://api.github.com/repos/Pugzy/ProjectAres/stargazers","contributors_url":"https://api.github.com/repos/Pugzy/ProjectAres/contributors","subscribers_url":"https://api.github.com/repos/Pugzy/ProjectAres/subscribers","subscription_url":"https://api.github.com/repos/Pugzy/ProjectAres/subscription","commits_url":"https://api.github.com/repos/Pugzy/ProjectAres/commits{/sha}","git_commits_url":"https://api.github.com/repos/Pugzy/ProjectAres/git/commits{/sha}","comments_url":"https://api.github.com/repos/Pugzy/ProjectAres/comments{/number}","issue_comment_url":"https://api.github.com/repos/Pugzy/ProjectAres/issues/comments{/number}","contents_url":"https://api.github.com/repos/Pugzy/ProjectAres/contents/{+path}","compare_url":"https://api.github.com/repos/Pugzy/ProjectAres/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Pugzy/ProjectAres/merges","archive_url":"https://api.github.com/repos/Pugzy/ProjectAres/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Pugzy/ProjectAres/downloads","issues_url":"https://api.github.com/repos/Pugzy/ProjectAres/issues{/number}","pulls_url":"https://api.github.com/repos/Pugzy/ProjectAres/pulls{/number}","milestones_url":"https://api.github.com/repos/Pugzy/ProjectAres/milestones{/number}","notifications_url":"https://api.github.com/repos/Pugzy/ProjectAres/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Pugzy/ProjectAres/labels{/name}","releases_url":"https://api.github.com/repos/Pugzy/ProjectAres/releases{/id}","deployments_url":"https://api.github.com/repos/Pugzy/ProjectAres/deployments","created_at":"2018-05-07T22:37:40Z","updated_at":"2018-05-20T16:26:53Z","pushed_at":"2018-05-20T16:31:53Z","git_url":"git://github.com/Pugzy/ProjectAres.git","ssh_url":"git@github.com:Pugzy/ProjectAres.git","clone_url":"https://github.com/Pugzy/ProjectAres.git","svn_url":"https://github.com/Pugzy/ProjectAres","homepage":"","size":2207,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"StratusNetwork:master","ref":"master","sha":"a147b9180a3b5fe98128c2178c3c096594495dd2","user":{"login":"StratusNetwork","id":25496659,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NDk2NjU5","avatar_url":"https://avatars3.githubusercontent.com/u/25496659?v=4","gravatar_id":"","url":"https://api.github.com/users/StratusNetwork","html_url":"https://github.com/StratusNetwork","followers_url":"https://api.github.com/users/StratusNetwork/followers","following_url":"https://api.github.com/users/StratusNetwork/following{/other_user}","gists_url":"https://api.github.com/users/StratusNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/StratusNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StratusNetwork/subscriptions","organizations_url":"https://api.github.com/users/StratusNetwork/orgs","repos_url":"https://api.github.com/users/StratusNetwork/repos","events_url":"https://api.github.com/users/StratusNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/StratusNetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":80695167,"node_id":"MDEwOlJlcG9zaXRvcnk4MDY5NTE2Nw==","name":"projectares","full_name":"StratusNetwork/projectares","private":false,"owner":{"login":"StratusNetwork","id":25496659,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NDk2NjU5","avatar_url":"https://avatars3.githubusercontent.com/u/25496659?v=4","gravatar_id":"","url":"https://api.github.com/users/StratusNetwork","html_url":"https://github.com/StratusNetwork","followers_url":"https://api.github.com/users/StratusNetwork/followers","following_url":"https://api.github.com/users/StratusNetwork/following{/other_user}","gists_url":"https://api.github.com/users/StratusNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/StratusNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StratusNetwork/subscriptions","organizations_url":"https://api.github.com/users/StratusNetwork/orgs","repos_url":"https://api.github.com/users/StratusNetwork/repos","events_url":"https://api.github.com/users/StratusNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/StratusNetwork/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/StratusNetwork/projectares","description":"Server-side game plugins that extend the Minecraft stack","fork":true,"url":"https://api.github.com/repos/StratusNetwork/projectares","forks_url":"https://api.github.com/repos/StratusNetwork/projectares/forks","keys_url":"https://api.github.com/repos/StratusNetwork/projectares/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StratusNetwork/projectares/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StratusNetwork/projectares/teams","hooks_url":"https://api.github.com/repos/StratusNetwork/projectares/hooks","issue_events_url":"https://api.github.com/repos/StratusNetwork/projectares/issues/events{/number}","events_url":"https://api.github.com/repos/StratusNetwork/projectares/events","assignees_url":"https://api.github.com/repos/StratusNetwork/projectares/assignees{/user}","branches_url":"https://api.github.com/repos/StratusNetwork/projectares/branches{/branch}","tags_url":"https://api.github.com/repos/StratusNetwork/projectares/tags","blobs_url":"https://api.github.com/repos/StratusNetwork/projectares/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StratusNetwork/projectares/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StratusNetwork/projectares/git/refs{/sha}","trees_url":"https://api.github.com/repos/StratusNetwork/projectares/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StratusNetwork/projectares/statuses/{sha}","languages_url":"https://api.github.com/repos/StratusNetwork/projectares/languages","stargazers_url":"https://api.github.com/repos/StratusNetwork/projectares/stargazers","contributors_url":"https://api.github.com/repos/StratusNetwork/projectares/contributors","subscribers_url":"https://api.github.com/repos/StratusNetwork/projectares/subscribers","subscription_url":"https://api.github.com/repos/StratusNetwork/projectares/subscription","commits_url":"https://api.github.com/repos/StratusNetwork/projectares/commits{/sha}","git_commits_url":"https://api.github.com/repos/StratusNetwork/projectares/git/commits{/sha}","comments_url":"https://api.github.com/repos/StratusNetwork/projectares/comments{/number}","issue_comment_url":"https://api.github.com/repos/StratusNetwork/projectares/issues/comments{/number}","contents_url":"https://api.github.com/repos/StratusNetwork/projectares/contents/{+path}","compare_url":"https://api.github.com/repos/StratusNetwork/projectares/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StratusNetwork/projectares/merges","archive_url":"https://api.github.com/repos/StratusNetwork/projectares/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StratusNetwork/projectares/downloads","issues_url":"https://api.github.com/repos/StratusNetwork/projectares/issues{/number}","pulls_url":"https://api.github.com/repos/StratusNetwork/projectares/pulls{/number}","milestones_url":"https://api.github.com/repos/StratusNetwork/projectares/milestones{/number}","notifications_url":"https://api.github.com/repos/StratusNetwork/projectares/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StratusNetwork/projectares/labels{/name}","releases_url":"https://api.github.com/repos/StratusNetwork/projectares/releases{/id}","deployments_url":"https://api.github.com/repos/StratusNetwork/projectares/deployments","created_at":"2017-02-02T05:05:45Z","updated_at":"2018-11-21T00:03:44Z","pushed_at":"2018-11-21T00:04:48Z","git_url":"git://github.com/StratusNetwork/projectares.git","ssh_url":"git@github.com:StratusNetwork/projectares.git","clone_url":"https://github.com/StratusNetwork/projectares.git","svn_url":"https://github.com/StratusNetwork/projectares","homepage":"","size":2540,"stargazers_count":10,"watchers_count":10,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":18,"open_issues":12,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/StratusNetwork/projectares/pulls/87"},"html":{"href":"https://github.com/StratusNetwork/projectares/pull/87"},"issue":{"href":"https://api.github.com/repos/StratusNetwork/projectares/issues/87"},"comments":{"href":"https://api.github.com/repos/StratusNetwork/projectares/issues/87/comments"},"review_comments":{"href":"https://api.github.com/repos/StratusNetwork/projectares/pulls/87/comments"},"review_comment":{"href":"https://api.github.com/repos/StratusNetwork/projectares/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/StratusNetwork/projectares/pulls/87/commits"},"statuses":{"href":"https://api.github.com/repos/StratusNetwork/projectares/statuses/f7a8b75ec0fea1a2df0faea3e50c3b72f1bd8089"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"AustinLMayes","id":4269021,"node_id":"MDQ6VXNlcjQyNjkwMjE=","avatar_url":"https://avatars2.githubusercontent.com/u/4269021?v=4","gravatar_id":"","url":"https://api.github.com/users/AustinLMayes","html_url":"https://github.com/AustinLMayes","followers_url":"https://api.github.com/users/AustinLMayes/followers","following_url":"https://api.github.com/users/AustinLMayes/following{/other_user}","gists_url":"https://api.github.com/users/AustinLMayes/gists{/gist_id}","starred_url":"https://api.github.com/users/AustinLMayes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AustinLMayes/subscriptions","organizations_url":"https://api.github.com/users/AustinLMayes/orgs","repos_url":"https://api.github.com/users/AustinLMayes/repos","events_url":"https://api.github.com/users/AustinLMayes/events{/privacy}","received_events_url":"https://api.github.com/users/AustinLMayes/received_events","type":"User","site_admin":false},"comments":2,"review_comments":1,"maintainer_can_modify":false,"commits":1,"additions":9,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"AustinLMayes"}}