{"action":"closed","number":5000,"pull_request":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/5000","id":197158381,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MTU4Mzgx","html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/5000","diff_url":"https://github.com/MinecraftForge/MinecraftForge/pull/5000.diff","patch_url":"https://github.com/MinecraftForge/MinecraftForge/pull/5000.patch","issue_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/5000","number":5000,"state":"closed","locked":false,"title":"Make EntityRenderer#orientCamera use EntityRenderer#thirdPersonDistance field","user":{"login":"Larsg310","id":5021026,"node_id":"MDQ6VXNlcjUwMjEwMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/5021026?v=4","gravatar_id":"","url":"https://api.github.com/users/Larsg310","html_url":"https://github.com/Larsg310","followers_url":"https://api.github.com/users/Larsg310/followers","following_url":"https://api.github.com/users/Larsg310/following{/other_user}","gists_url":"https://api.github.com/users/Larsg310/gists{/gist_id}","starred_url":"https://api.github.com/users/Larsg310/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Larsg310/subscriptions","organizations_url":"https://api.github.com/users/Larsg310/orgs","repos_url":"https://api.github.com/users/Larsg310/repos","events_url":"https://api.github.com/users/Larsg310/events{/privacy}","received_events_url":"https://api.github.com/users/Larsg310/received_events","type":"User","site_admin":false},"body":"In previous versions, the `EntityRenderer#orientCamera` method used the `EntityRenderer#thirdPersonDistance` field in its calculations. That was changed, and now uses a hardcoded value of `4.0F`, the same as the field.\r\n\r\nYou used to be able to change the field with Reflection to change the 3rd person camera distance from the player. With it using the hardcoded value, you couldn't.\r\n\r\nThis was reported at the forums (http://www.minecraftforge.net/forum/topic/64894-112-how-do-i-make-the-third-person-zoom-farther-when-riding-my-custom-entity-my-dragon-is-kind-of-big/)\r\n\r\nThis PR fixes that by replacing the hardcoded values with the `EntityRenderer#thirdPersonDistance` field.","created_at":"2018-06-25T15:50:51Z","updated_at":"2018-08-09T06:33:01Z","closed_at":"2018-08-09T06:33:01Z","merged_at":null,"merge_commit_sha":"127087da7f86e18fe8a02eed3ea48d17016ebc8d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":507309489,"node_id":"MDU6TGFiZWw1MDczMDk0ODk=","url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/labels/1.12","name":"1.12","color":"c5def5","default":false},{"id":306653555,"node_id":"MDU6TGFiZWwzMDY2NTM1NTU=","url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/labels/Feature","name":"Feature","color":"009800","default":false},{"id":710171507,"node_id":"MDU6TGFiZWw3MTAxNzE1MDc=","url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/labels/Stale","name":"Stale","color":"e99695","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/5000/commits","review_comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/5000/comments","review_comment_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/5000/comments","statuses_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/4e2a89ef3ce4a8efc1c82b26c89dc20d3d02ea6e","head":{"label":"Larsg310:third-person-distance","ref":"third-person-distance","sha":"4e2a89ef3ce4a8efc1c82b26c89dc20d3d02ea6e","user":{"login":"Larsg310","id":5021026,"node_id":"MDQ6VXNlcjUwMjEwMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/5021026?v=4","gravatar_id":"","url":"https://api.github.com/users/Larsg310","html_url":"https://github.com/Larsg310","followers_url":"https://api.github.com/users/Larsg310/followers","following_url":"https://api.github.com/users/Larsg310/following{/other_user}","gists_url":"https://api.github.com/users/Larsg310/gists{/gist_id}","starred_url":"https://api.github.com/users/Larsg310/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Larsg310/subscriptions","organizations_url":"https://api.github.com/users/Larsg310/orgs","repos_url":"https://api.github.com/users/Larsg310/repos","events_url":"https://api.github.com/users/Larsg310/events{/privacy}","received_events_url":"https://api.github.com/users/Larsg310/received_events","type":"User","site_admin":false},"repo":{"id":138579858,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg1Nzk4NTg=","name":"MinecraftForge","full_name":"Larsg310/MinecraftForge","owner":{"login":"Larsg310","id":5021026,"node_id":"MDQ6VXNlcjUwMjEwMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/5021026?v=4","gravatar_id":"","url":"https://api.github.com/users/Larsg310","html_url":"https://github.com/Larsg310","followers_url":"https://api.github.com/users/Larsg310/followers","following_url":"https://api.github.com/users/Larsg310/following{/other_user}","gists_url":"https://api.github.com/users/Larsg310/gists{/gist_id}","starred_url":"https://api.github.com/users/Larsg310/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Larsg310/subscriptions","organizations_url":"https://api.github.com/users/Larsg310/orgs","repos_url":"https://api.github.com/users/Larsg310/repos","events_url":"https://api.github.com/users/Larsg310/events{/privacy}","received_events_url":"https://api.github.com/users/Larsg310/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Larsg310/MinecraftForge","description":"Modifications to the Minecraft base files to assist in compatibility between mods.","fork":true,"url":"https://api.github.com/repos/Larsg310/MinecraftForge","forks_url":"https://api.github.com/repos/Larsg310/MinecraftForge/forks","keys_url":"https://api.github.com/repos/Larsg310/MinecraftForge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Larsg310/MinecraftForge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Larsg310/MinecraftForge/teams","hooks_url":"https://api.github.com/repos/Larsg310/MinecraftForge/hooks","issue_events_url":"https://api.github.com/repos/Larsg310/MinecraftForge/issues/events{/number}","events_url":"https://api.github.com/repos/Larsg310/MinecraftForge/events","assignees_url":"https://api.github.com/repos/Larsg310/MinecraftForge/assignees{/user}","branches_url":"https://api.github.com/repos/Larsg310/MinecraftForge/branches{/branch}","tags_url":"https://api.github.com/repos/Larsg310/MinecraftForge/tags","blobs_url":"https://api.github.com/repos/Larsg310/MinecraftForge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Larsg310/MinecraftForge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Larsg310/MinecraftForge/git/refs{/sha}","trees_url":"https://api.github.com/repos/Larsg310/MinecraftForge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Larsg310/MinecraftForge/statuses/{sha}","languages_url":"https://api.github.com/repos/Larsg310/MinecraftForge/languages","stargazers_url":"https://api.github.com/repos/Larsg310/MinecraftForge/stargazers","contributors_url":"https://api.github.com/repos/Larsg310/MinecraftForge/contributors","subscribers_url":"https://api.github.com/repos/Larsg310/MinecraftForge/subscribers","subscription_url":"https://api.github.com/repos/Larsg310/MinecraftForge/subscription","commits_url":"https://api.github.com/repos/Larsg310/MinecraftForge/commits{/sha}","git_commits_url":"https://api.github.com/repos/Larsg310/MinecraftForge/git/commits{/sha}","comments_url":"https://api.github.com/repos/Larsg310/MinecraftForge/comments{/number}","issue_comment_url":"https://api.github.com/repos/Larsg310/MinecraftForge/issues/comments{/number}","contents_url":"https://api.github.com/repos/Larsg310/MinecraftForge/contents/{+path}","compare_url":"https://api.github.com/repos/Larsg310/MinecraftForge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Larsg310/MinecraftForge/merges","archive_url":"https://api.github.com/repos/Larsg310/MinecraftForge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Larsg310/MinecraftForge/downloads","issues_url":"https://api.github.com/repos/Larsg310/MinecraftForge/issues{/number}","pulls_url":"https://api.github.com/repos/Larsg310/MinecraftForge/pulls{/number}","milestones_url":"https://api.github.com/repos/Larsg310/MinecraftForge/milestones{/number}","notifications_url":"https://api.github.com/repos/Larsg310/MinecraftForge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Larsg310/MinecraftForge/labels{/name}","releases_url":"https://api.github.com/repos/Larsg310/MinecraftForge/releases{/id}","deployments_url":"https://api.github.com/repos/Larsg310/MinecraftForge/deployments","created_at":"2018-06-25T10:30:16Z","updated_at":"2018-06-25T10:30:22Z","pushed_at":"2018-06-26T10:18:48Z","git_url":"git://github.com/Larsg310/MinecraftForge.git","ssh_url":"git@github.com:Larsg310/MinecraftForge.git","clone_url":"https://github.com/Larsg310/MinecraftForge.git","svn_url":"https://github.com/Larsg310/MinecraftForge","homepage":"","size":91994,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"1.12.x"}},"base":{"label":"MinecraftForge:1.12.x","ref":"1.12.x","sha":"f2d7a197028585886fec828233da82c7c08b3a55","user":{"login":"MinecraftForge","id":1390178,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTAxNzg=","avatar_url":"https://avatars2.githubusercontent.com/u/1390178?v=4","gravatar_id":"","url":"https://api.github.com/users/MinecraftForge","html_url":"https://github.com/MinecraftForge","followers_url":"https://api.github.com/users/MinecraftForge/followers","following_url":"https://api.github.com/users/MinecraftForge/following{/other_user}","gists_url":"https://api.github.com/users/MinecraftForge/gists{/gist_id}","starred_url":"https://api.github.com/users/MinecraftForge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MinecraftForge/subscriptions","organizations_url":"https://api.github.com/users/MinecraftForge/orgs","repos_url":"https://api.github.com/users/MinecraftForge/repos","events_url":"https://api.github.com/users/MinecraftForge/events{/privacy}","received_events_url":"https://api.github.com/users/MinecraftForge/received_events","type":"Organization","site_admin":false},"repo":{"id":3301400,"node_id":"MDEwOlJlcG9zaXRvcnkzMzAxNDAw","name":"MinecraftForge","full_name":"MinecraftForge/MinecraftForge","owner":{"login":"MinecraftForge","id":1390178,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTAxNzg=","avatar_url":"https://avatars2.githubusercontent.com/u/1390178?v=4","gravatar_id":"","url":"https://api.github.com/users/MinecraftForge","html_url":"https://github.com/MinecraftForge","followers_url":"https://api.github.com/users/MinecraftForge/followers","following_url":"https://api.github.com/users/MinecraftForge/following{/other_user}","gists_url":"https://api.github.com/users/MinecraftForge/gists{/gist_id}","starred_url":"https://api.github.com/users/MinecraftForge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MinecraftForge/subscriptions","organizations_url":"https://api.github.com/users/MinecraftForge/orgs","repos_url":"https://api.github.com/users/MinecraftForge/repos","events_url":"https://api.github.com/users/MinecraftForge/events{/privacy}","received_events_url":"https://api.github.com/users/MinecraftForge/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MinecraftForge/MinecraftForge","description":"Modifications to the Minecraft base files to assist in compatibility between mods.","fork":false,"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge","forks_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/forks","keys_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/teams","hooks_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/hooks","issue_events_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/events{/number}","events_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/events","assignees_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/assignees{/user}","branches_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/branches{/branch}","tags_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/tags","blobs_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/refs{/sha}","trees_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/{sha}","languages_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/languages","stargazers_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/stargazers","contributors_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/contributors","subscribers_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/subscribers","subscription_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/subscription","commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/commits{/sha}","git_commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/commits{/sha}","comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/comments{/number}","issue_comment_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/comments{/number}","contents_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/contents/{+path}","compare_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/merges","archive_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/downloads","issues_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues{/number}","pulls_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls{/number}","milestones_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/milestones{/number}","notifications_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/labels{/name}","releases_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/releases{/id}","deployments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/deployments","created_at":"2012-01-30T01:35:01Z","updated_at":"2018-08-09T05:40:21Z","pushed_at":"2018-08-08T20:15:01Z","git_url":"git://github.com/MinecraftForge/MinecraftForge.git","ssh_url":"git@github.com:MinecraftForge/MinecraftForge.git","clone_url":"https://github.com/MinecraftForge/MinecraftForge.git","svn_url":"https://github.com/MinecraftForge/MinecraftForge","homepage":"","size":92590,"stargazers_count":2352,"watchers_count":2352,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1173,"mirror_url":null,"archived":false,"open_issues_count":161,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1173,"open_issues":161,"watchers":2352,"default_branch":"1.12.x"}},"_links":{"self":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/5000"},"html":{"href":"https://github.com/MinecraftForge/MinecraftForge/pull/5000"},"issue":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/5000"},"comments":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/5000/comments"},"review_comments":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/5000/comments"},"review_comment":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/5000/commits"},"statuses":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/4e2a89ef3ce4a8efc1c82b26c89dc20d3d02ea6e"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":2,"maintainer_can_modify":false,"commits":2,"additions":18,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"stale"}}