{"action":"created","comment":{"url":"https://api.github.com/repos/erikchen/performance-memory/pulls/comments/171775425","pull_request_review_id":100687704,"id":171775425,"diff_hunk":"@@ -286,6 +279,39 @@ typically associate with JS.\n   * Large ArrayBuffers are not included in usedJSHeapSize and totalJSHeapSize,\n     since they are backed by PartitionAlloc.\n   * External strings are not included in usedJSHeapSize and totalJSHeapSize\n-  \n+* The numbers are quantized into buckets and time-delayed.\n+\n Moreover performance.memory in Chrome exposes jsHeapSizeLimit which is an JavaScript engine specific\n-heuristic which may not exisit in other JavaScript engines. Therefore, we propose to remove this metric.\n+heuristic which may not exisit in other JavaScript engines.\n+\n+# <a name=\"appendix-d\"></a> Appendix D - Frame Tree Examples\n+\n+Note: All examples assume site isolation - frames from different origins are\n+always hosted in different processes.\n+\n+* Example 1: User opens two tabs to <Origin A>, a simple site with a single\n+  frame.\n+  * More common case: Browser hosts the two frames in different processes.\n+    numberOfFrameTrees is *1* for both sites, and the metrics will be accurate.\n+  * Less common case: Browser hosts the two frames in the same process.\n+    numberOfFrameTrees is *2* for both sites, and the metrics will be\n+    inaccurate.\n+    * Dividing by 2 will not always do the right thing! See next example.\n+* Example 2: User opens tab to <Origin A> [call this *frame 1*], which\n+  window.opens() a new tab to <Origin B>. <Origin B> includes a subframe from\n+  <Origin A> [call this *frame 2*].\n+  * *frame 1* and *frame 2* will be hosted in the same process.\n+    numberOfFrameTrees is *2* when either frame calls performance.memory.\n+* Example 3: User opens tab to <Origin A> [call this *frame 1*]. *Frame 1*","path":"explainer.md","position":119,"original_position":119,"commit_id":"e3bdd0dcd00b76482aba6b5d4881fdf17efa7390","original_commit_id":"e3bdd0dcd00b76482aba6b5d4881fdf17efa7390","user":{"login":"hannespayer","id":5773526,"avatar_url":"https://avatars2.githubusercontent.com/u/5773526?v=4","gravatar_id":"","url":"https://api.github.com/users/hannespayer","html_url":"https://github.com/hannespayer","followers_url":"https://api.github.com/users/hannespayer/followers","following_url":"https://api.github.com/users/hannespayer/following{/other_user}","gists_url":"https://api.github.com/users/hannespayer/gists{/gist_id}","starred_url":"https://api.github.com/users/hannespayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hannespayer/subscriptions","organizations_url":"https://api.github.com/users/hannespayer/orgs","repos_url":"https://api.github.com/users/hannespayer/repos","events_url":"https://api.github.com/users/hannespayer/events{/privacy}","received_events_url":"https://api.github.com/users/hannespayer/received_events","type":"User","site_admin":false},"body":"*Frame 1* -> *frame 1*","created_at":"2018-03-02T06:58:09Z","updated_at":"2018-03-02T07:01:36Z","html_url":"https://github.com/erikchen/performance-memory/pull/9#discussion_r171775425","pull_request_url":"https://api.github.com/repos/erikchen/performance-memory/pulls/9","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/erikchen/performance-memory/pulls/comments/171775425"},"html":{"href":"https://github.com/erikchen/performance-memory/pull/9#discussion_r171775425"},"pull_request":{"href":"https://api.github.com/repos/erikchen/performance-memory/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/erikchen/performance-memory/pulls/9","id":172375407,"html_url":"https://github.com/erikchen/performance-memory/pull/9","diff_url":"https://github.com/erikchen/performance-memory/pull/9.diff","patch_url":"https://github.com/erikchen/performance-memory/pull/9.patch","issue_url":"https://api.github.com/repos/erikchen/performance-memory/issues/9","number":9,"state":"open","locked":false,"title":"Hannes to review","user":{"login":"erikchen","id":833296,"avatar_url":"https://avatars0.githubusercontent.com/u/833296?v=4","gravatar_id":"","url":"https://api.github.com/users/erikchen","html_url":"https://github.com/erikchen","followers_url":"https://api.github.com/users/erikchen/followers","following_url":"https://api.github.com/users/erikchen/following{/other_user}","gists_url":"https://api.github.com/users/erikchen/gists{/gist_id}","starred_url":"https://api.github.com/users/erikchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikchen/subscriptions","organizations_url":"https://api.github.com/users/erikchen/orgs","repos_url":"https://api.github.com/users/erikchen/repos","events_url":"https://api.github.com/users/erikchen/events{/privacy}","received_events_url":"https://api.github.com/users/erikchen/received_events","type":"User","site_admin":false},"body":"Responding to feedback from GSuite, Gmail and Facebook.","created_at":"2018-03-01T22:44:06Z","updated_at":"2018-03-02T07:01:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e72beefa3f087af9a36c084df06d3b238f8f9ab9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/erikchen/performance-memory/pulls/9/commits","review_comments_url":"https://api.github.com/repos/erikchen/performance-memory/pulls/9/comments","review_comment_url":"https://api.github.com/repos/erikchen/performance-memory/pulls/comments{/number}","comments_url":"https://api.github.com/repos/erikchen/performance-memory/issues/9/comments","statuses_url":"https://api.github.com/repos/erikchen/performance-memory/statuses/e3bdd0dcd00b76482aba6b5d4881fdf17efa7390","head":{"label":"erikchen:hannes_to_review","ref":"hannes_to_review","sha":"e3bdd0dcd00b76482aba6b5d4881fdf17efa7390","user":{"login":"erikchen","id":833296,"avatar_url":"https://avatars0.githubusercontent.com/u/833296?v=4","gravatar_id":"","url":"https://api.github.com/users/erikchen","html_url":"https://github.com/erikchen","followers_url":"https://api.github.com/users/erikchen/followers","following_url":"https://api.github.com/users/erikchen/following{/other_user}","gists_url":"https://api.github.com/users/erikchen/gists{/gist_id}","starred_url":"https://api.github.com/users/erikchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikchen/subscriptions","organizations_url":"https://api.github.com/users/erikchen/orgs","repos_url":"https://api.github.com/users/erikchen/repos","events_url":"https://api.github.com/users/erikchen/events{/privacy}","received_events_url":"https://api.github.com/users/erikchen/received_events","type":"User","site_admin":false},"repo":{"id":122224604,"name":"performance-memory","full_name":"erikchen/performance-memory","owner":{"login":"erikchen","id":833296,"avatar_url":"https://avatars0.githubusercontent.com/u/833296?v=4","gravatar_id":"","url":"https://api.github.com/users/erikchen","html_url":"https://github.com/erikchen","followers_url":"https://api.github.com/users/erikchen/followers","following_url":"https://api.github.com/users/erikchen/following{/other_user}","gists_url":"https://api.github.com/users/erikchen/gists{/gist_id}","starred_url":"https://api.github.com/users/erikchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikchen/subscriptions","organizations_url":"https://api.github.com/users/erikchen/orgs","repos_url":"https://api.github.com/users/erikchen/repos","events_url":"https://api.github.com/users/erikchen/events{/privacy}","received_events_url":"https://api.github.com/users/erikchen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/erikchen/performance-memory","description":null,"fork":false,"url":"https://api.github.com/repos/erikchen/performance-memory","forks_url":"https://api.github.com/repos/erikchen/performance-memory/forks","keys_url":"https://api.github.com/repos/erikchen/performance-memory/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erikchen/performance-memory/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erikchen/performance-memory/teams","hooks_url":"https://api.github.com/repos/erikchen/performance-memory/hooks","issue_events_url":"https://api.github.com/repos/erikchen/performance-memory/issues/events{/number}","events_url":"https://api.github.com/repos/erikchen/performance-memory/events","assignees_url":"https://api.github.com/repos/erikchen/performance-memory/assignees{/user}","branches_url":"https://api.github.com/repos/erikchen/performance-memory/branches{/branch}","tags_url":"https://api.github.com/repos/erikchen/performance-memory/tags","blobs_url":"https://api.github.com/repos/erikchen/performance-memory/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erikchen/performance-memory/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erikchen/performance-memory/git/refs{/sha}","trees_url":"https://api.github.com/repos/erikchen/performance-memory/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erikchen/performance-memory/statuses/{sha}","languages_url":"https://api.github.com/repos/erikchen/performance-memory/languages","stargazers_url":"https://api.github.com/repos/erikchen/performance-memory/stargazers","contributors_url":"https://api.github.com/repos/erikchen/performance-memory/contributors","subscribers_url":"https://api.github.com/repos/erikchen/performance-memory/subscribers","subscription_url":"https://api.github.com/repos/erikchen/performance-memory/subscription","commits_url":"https://api.github.com/repos/erikchen/performance-memory/commits{/sha}","git_commits_url":"https://api.github.com/repos/erikchen/performance-memory/git/commits{/sha}","comments_url":"https://api.github.com/repos/erikchen/performance-memory/comments{/number}","issue_comment_url":"https://api.github.com/repos/erikchen/performance-memory/issues/comments{/number}","contents_url":"https://api.github.com/repos/erikchen/performance-memory/contents/{+path}","compare_url":"https://api.github.com/repos/erikchen/performance-memory/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erikchen/performance-memory/merges","archive_url":"https://api.github.com/repos/erikchen/performance-memory/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erikchen/performance-memory/downloads","issues_url":"https://api.github.com/repos/erikchen/performance-memory/issues{/number}","pulls_url":"https://api.github.com/repos/erikchen/performance-memory/pulls{/number}","milestones_url":"https://api.github.com/repos/erikchen/performance-memory/milestones{/number}","notifications_url":"https://api.github.com/repos/erikchen/performance-memory/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erikchen/performance-memory/labels{/name}","releases_url":"https://api.github.com/repos/erikchen/performance-memory/releases{/id}","deployments_url":"https://api.github.com/repos/erikchen/performance-memory/deployments","created_at":"2018-02-20T16:33:31Z","updated_at":"2018-02-20T16:33:31Z","pushed_at":"2018-03-01T22:44:07Z","git_url":"git://github.com/erikchen/performance-memory.git","ssh_url":"git@github.com:erikchen/performance-memory.git","clone_url":"https://github.com/erikchen/performance-memory.git","svn_url":"https://github.com/erikchen/performance-memory","homepage":null,"size":44,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"erikchen:master","ref":"master","sha":"90de312c490b10a3d4e7e2d31c9333892eba2a20","user":{"login":"erikchen","id":833296,"avatar_url":"https://avatars0.githubusercontent.com/u/833296?v=4","gravatar_id":"","url":"https://api.github.com/users/erikchen","html_url":"https://github.com/erikchen","followers_url":"https://api.github.com/users/erikchen/followers","following_url":"https://api.github.com/users/erikchen/following{/other_user}","gists_url":"https://api.github.com/users/erikchen/gists{/gist_id}","starred_url":"https://api.github.com/users/erikchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikchen/subscriptions","organizations_url":"https://api.github.com/users/erikchen/orgs","repos_url":"https://api.github.com/users/erikchen/repos","events_url":"https://api.github.com/users/erikchen/events{/privacy}","received_events_url":"https://api.github.com/users/erikchen/received_events","type":"User","site_admin":false},"repo":{"id":122224604,"name":"performance-memory","full_name":"erikchen/performance-memory","owner":{"login":"erikchen","id":833296,"avatar_url":"https://avatars0.githubusercontent.com/u/833296?v=4","gravatar_id":"","url":"https://api.github.com/users/erikchen","html_url":"https://github.com/erikchen","followers_url":"https://api.github.com/users/erikchen/followers","following_url":"https://api.github.com/users/erikchen/following{/other_user}","gists_url":"https://api.github.com/users/erikchen/gists{/gist_id}","starred_url":"https://api.github.com/users/erikchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikchen/subscriptions","organizations_url":"https://api.github.com/users/erikchen/orgs","repos_url":"https://api.github.com/users/erikchen/repos","events_url":"https://api.github.com/users/erikchen/events{/privacy}","received_events_url":"https://api.github.com/users/erikchen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/erikchen/performance-memory","description":null,"fork":false,"url":"https://api.github.com/repos/erikchen/performance-memory","forks_url":"https://api.github.com/repos/erikchen/performance-memory/forks","keys_url":"https://api.github.com/repos/erikchen/performance-memory/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erikchen/performance-memory/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erikchen/performance-memory/teams","hooks_url":"https://api.github.com/repos/erikchen/performance-memory/hooks","issue_events_url":"https://api.github.com/repos/erikchen/performance-memory/issues/events{/number}","events_url":"https://api.github.com/repos/erikchen/performance-memory/events","assignees_url":"https://api.github.com/repos/erikchen/performance-memory/assignees{/user}","branches_url":"https://api.github.com/repos/erikchen/performance-memory/branches{/branch}","tags_url":"https://api.github.com/repos/erikchen/performance-memory/tags","blobs_url":"https://api.github.com/repos/erikchen/performance-memory/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erikchen/performance-memory/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erikchen/performance-memory/git/refs{/sha}","trees_url":"https://api.github.com/repos/erikchen/performance-memory/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erikchen/performance-memory/statuses/{sha}","languages_url":"https://api.github.com/repos/erikchen/performance-memory/languages","stargazers_url":"https://api.github.com/repos/erikchen/performance-memory/stargazers","contributors_url":"https://api.github.com/repos/erikchen/performance-memory/contributors","subscribers_url":"https://api.github.com/repos/erikchen/performance-memory/subscribers","subscription_url":"https://api.github.com/repos/erikchen/performance-memory/subscription","commits_url":"https://api.github.com/repos/erikchen/performance-memory/commits{/sha}","git_commits_url":"https://api.github.com/repos/erikchen/performance-memory/git/commits{/sha}","comments_url":"https://api.github.com/repos/erikchen/performance-memory/comments{/number}","issue_comment_url":"https://api.github.com/repos/erikchen/performance-memory/issues/comments{/number}","contents_url":"https://api.github.com/repos/erikchen/performance-memory/contents/{+path}","compare_url":"https://api.github.com/repos/erikchen/performance-memory/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erikchen/performance-memory/merges","archive_url":"https://api.github.com/repos/erikchen/performance-memory/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erikchen/performance-memory/downloads","issues_url":"https://api.github.com/repos/erikchen/performance-memory/issues{/number}","pulls_url":"https://api.github.com/repos/erikchen/performance-memory/pulls{/number}","milestones_url":"https://api.github.com/repos/erikchen/performance-memory/milestones{/number}","notifications_url":"https://api.github.com/repos/erikchen/performance-memory/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erikchen/performance-memory/labels{/name}","releases_url":"https://api.github.com/repos/erikchen/performance-memory/releases{/id}","deployments_url":"https://api.github.com/repos/erikchen/performance-memory/deployments","created_at":"2018-02-20T16:33:31Z","updated_at":"2018-02-20T16:33:31Z","pushed_at":"2018-03-01T22:44:07Z","git_url":"git://github.com/erikchen/performance-memory.git","ssh_url":"git@github.com:erikchen/performance-memory.git","clone_url":"https://github.com/erikchen/performance-memory.git","svn_url":"https://github.com/erikchen/performance-memory","homepage":null,"size":44,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/erikchen/performance-memory/pulls/9"},"html":{"href":"https://github.com/erikchen/performance-memory/pull/9"},"issue":{"href":"https://api.github.com/repos/erikchen/performance-memory/issues/9"},"comments":{"href":"https://api.github.com/repos/erikchen/performance-memory/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/erikchen/performance-memory/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/erikchen/performance-memory/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/erikchen/performance-memory/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/erikchen/performance-memory/statuses/e3bdd0dcd00b76482aba6b5d4881fdf17efa7390"}},"author_association":"OWNER"}}
{"actor":{"display_login":"hannespayer"}}