{"action":"opened","number":15,"pull_request":{"url":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/pulls/15","id":197807690,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3ODA3Njkw","html_url":"https://github.com/chaitanyaenr/aos-cd-jobs/pull/15","diff_url":"https://github.com/chaitanyaenr/aos-cd-jobs/pull/15.diff","patch_url":"https://github.com/chaitanyaenr/aos-cd-jobs/pull/15.patch","issue_url":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/issues/15","number":15,"state":"open","locked":false,"title":"Changes to the Jenkinsfile, OpenStack and OpenShift groovy files","user":{"login":"mbruzek","id":6385185,"node_id":"MDQ6VXNlcjYzODUxODU=","avatar_url":"https://avatars2.githubusercontent.com/u/6385185?v=4","gravatar_id":"","url":"https://api.github.com/users/mbruzek","html_url":"https://github.com/mbruzek","followers_url":"https://api.github.com/users/mbruzek/followers","following_url":"https://api.github.com/users/mbruzek/following{/other_user}","gists_url":"https://api.github.com/users/mbruzek/gists{/gist_id}","starred_url":"https://api.github.com/users/mbruzek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbruzek/subscriptions","organizations_url":"https://api.github.com/users/mbruzek/orgs","repos_url":"https://api.github.com/users/mbruzek/repos","events_url":"https://api.github.com/users/mbruzek/events{/privacy}","received_events_url":"https://api.github.com/users/mbruzek/received_events","type":"User","site_admin":false},"body":"These changes make the OpenShift and OpenStack groovy code not need the names of each property and parameter. The code converts properties into parameters and uses the parameters for the next job. This is **much** easier to maintain than having to edit the groovy code every time a property changes.\r\n\r\nAll these files contained a mixture of tabs and space which had indent mismatches on my editor. Please only use tabs or spaces in the files so other people can edit these files correctly.\r\n\r\nI have tested these changes with a Jenkins pipeline job in the staging environment and both jobs work well. \r\n\r\n@chaitanyaenr  and @akrzos please have a look.","created_at":"2018-06-27T17:53:00Z","updated_at":"2018-06-27T17:53:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/pulls/15/commits","review_comments_url":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/pulls/15/comments","review_comment_url":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/issues/15/comments","statuses_url":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/statuses/893c2f9256dbfc11ce8cebff9a899c1853f1ce6c","head":{"label":"mbruzek:mbruzek_alderaan_update","ref":"mbruzek_alderaan_update","sha":"893c2f9256dbfc11ce8cebff9a899c1853f1ce6c","user":{"login":"mbruzek","id":6385185,"node_id":"MDQ6VXNlcjYzODUxODU=","avatar_url":"https://avatars2.githubusercontent.com/u/6385185?v=4","gravatar_id":"","url":"https://api.github.com/users/mbruzek","html_url":"https://github.com/mbruzek","followers_url":"https://api.github.com/users/mbruzek/followers","following_url":"https://api.github.com/users/mbruzek/following{/other_user}","gists_url":"https://api.github.com/users/mbruzek/gists{/gist_id}","starred_url":"https://api.github.com/users/mbruzek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbruzek/subscriptions","organizations_url":"https://api.github.com/users/mbruzek/orgs","repos_url":"https://api.github.com/users/mbruzek/repos","events_url":"https://api.github.com/users/mbruzek/events{/privacy}","received_events_url":"https://api.github.com/users/mbruzek/received_events","type":"User","site_admin":false},"repo":{"id":138763506,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg3NjM1MDY=","name":"aos-cd-jobs","full_name":"mbruzek/aos-cd-jobs","owner":{"login":"mbruzek","id":6385185,"node_id":"MDQ6VXNlcjYzODUxODU=","avatar_url":"https://avatars2.githubusercontent.com/u/6385185?v=4","gravatar_id":"","url":"https://api.github.com/users/mbruzek","html_url":"https://github.com/mbruzek","followers_url":"https://api.github.com/users/mbruzek/followers","following_url":"https://api.github.com/users/mbruzek/following{/other_user}","gists_url":"https://api.github.com/users/mbruzek/gists{/gist_id}","starred_url":"https://api.github.com/users/mbruzek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbruzek/subscriptions","organizations_url":"https://api.github.com/users/mbruzek/orgs","repos_url":"https://api.github.com/users/mbruzek/repos","events_url":"https://api.github.com/users/mbruzek/events{/privacy}","received_events_url":"https://api.github.com/users/mbruzek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mbruzek/aos-cd-jobs","description":null,"fork":true,"url":"https://api.github.com/repos/mbruzek/aos-cd-jobs","forks_url":"https://api.github.com/repos/mbruzek/aos-cd-jobs/forks","keys_url":"https://api.github.com/repos/mbruzek/aos-cd-jobs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mbruzek/aos-cd-jobs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mbruzek/aos-cd-jobs/teams","hooks_url":"https://api.github.com/repos/mbruzek/aos-cd-jobs/hooks","issue_events_url":"https://api.github.com/repos/mbruzek/aos-cd-jobs/issues/events{/number}","events_url":"https://api.github.com/repos/mbruzek/aos-cd-jobs/events","assignees_url":"https://api.github.com/repos/mbruzek/aos-cd-jobs/assignees{/user}","branches_url":"https://api.github.com/repos/mbruzek/aos-cd-jobs/branches{/branch}","tags_url":"https://api.github.com/repos/mbruzek/aos-cd-jobs/tags","blobs_url":"https://api.github.com/repos/mbruzek/aos-cd-jobs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mbruzek/aos-cd-jobs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mbruzek/aos-cd-jobs/git/refs{/sha}","trees_url":"https://api.github.com/repos/mbruzek/aos-cd-jobs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mbruzek/aos-cd-jobs/statuses/{sha}","languages_url":"https://api.github.com/repos/mbruzek/aos-cd-jobs/languages","stargazers_url":"https://api.github.com/repos/mbruzek/aos-cd-jobs/stargazers","contributors_url":"https://api.github.com/repos/mbruzek/aos-cd-jobs/contributors","subscribers_url":"https://api.github.com/repos/mbruzek/aos-cd-jobs/subscribers","subscription_url":"https://api.github.com/repos/mbruzek/aos-cd-jobs/subscription","commits_url":"https://api.github.com/repos/mbruzek/aos-cd-jobs/commits{/sha}","git_commits_url":"https://api.github.com/repos/mbruzek/aos-cd-jobs/git/commits{/sha}","comments_url":"https://api.github.com/repos/mbruzek/aos-cd-jobs/comments{/number}","issue_comment_url":"https://api.github.com/repos/mbruzek/aos-cd-jobs/issues/comments{/number}","contents_url":"https://api.github.com/repos/mbruzek/aos-cd-jobs/contents/{+path}","compare_url":"https://api.github.com/repos/mbruzek/aos-cd-jobs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mbruzek/aos-cd-jobs/merges","archive_url":"https://api.github.com/repos/mbruzek/aos-cd-jobs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mbruzek/aos-cd-jobs/downloads","issues_url":"https://api.github.com/repos/mbruzek/aos-cd-jobs/issues{/number}","pulls_url":"https://api.github.com/repos/mbruzek/aos-cd-jobs/pulls{/number}","milestones_url":"https://api.github.com/repos/mbruzek/aos-cd-jobs/milestones{/number}","notifications_url":"https://api.github.com/repos/mbruzek/aos-cd-jobs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mbruzek/aos-cd-jobs/labels{/name}","releases_url":"https://api.github.com/repos/mbruzek/aos-cd-jobs/releases{/id}","deployments_url":"https://api.github.com/repos/mbruzek/aos-cd-jobs/deployments","created_at":"2018-06-26T16:19:42Z","updated_at":"2018-06-26T16:19:48Z","pushed_at":"2018-06-27T17:49:51Z","git_url":"git://github.com/mbruzek/aos-cd-jobs.git","ssh_url":"git@github.com:mbruzek/aos-cd-jobs.git","clone_url":"https://github.com/mbruzek/aos-cd-jobs.git","svn_url":"https://github.com/mbruzek/aos-cd-jobs","homepage":null,"size":16916,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chaitanyaenr:master","ref":"master","sha":"eab92c13e27359bdb7d84d3451f3617a8d93a5ea","user":{"login":"chaitanyaenr","id":14077093,"node_id":"MDQ6VXNlcjE0MDc3MDkz","avatar_url":"https://avatars1.githubusercontent.com/u/14077093?v=4","gravatar_id":"","url":"https://api.github.com/users/chaitanyaenr","html_url":"https://github.com/chaitanyaenr","followers_url":"https://api.github.com/users/chaitanyaenr/followers","following_url":"https://api.github.com/users/chaitanyaenr/following{/other_user}","gists_url":"https://api.github.com/users/chaitanyaenr/gists{/gist_id}","starred_url":"https://api.github.com/users/chaitanyaenr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaitanyaenr/subscriptions","organizations_url":"https://api.github.com/users/chaitanyaenr/orgs","repos_url":"https://api.github.com/users/chaitanyaenr/repos","events_url":"https://api.github.com/users/chaitanyaenr/events{/privacy}","received_events_url":"https://api.github.com/users/chaitanyaenr/received_events","type":"User","site_admin":false},"repo":{"id":125386622,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUzODY2MjI=","name":"aos-cd-jobs","full_name":"chaitanyaenr/aos-cd-jobs","owner":{"login":"chaitanyaenr","id":14077093,"node_id":"MDQ6VXNlcjE0MDc3MDkz","avatar_url":"https://avatars1.githubusercontent.com/u/14077093?v=4","gravatar_id":"","url":"https://api.github.com/users/chaitanyaenr","html_url":"https://github.com/chaitanyaenr","followers_url":"https://api.github.com/users/chaitanyaenr/followers","following_url":"https://api.github.com/users/chaitanyaenr/following{/other_user}","gists_url":"https://api.github.com/users/chaitanyaenr/gists{/gist_id}","starred_url":"https://api.github.com/users/chaitanyaenr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaitanyaenr/subscriptions","organizations_url":"https://api.github.com/users/chaitanyaenr/orgs","repos_url":"https://api.github.com/users/chaitanyaenr/repos","events_url":"https://api.github.com/users/chaitanyaenr/events{/privacy}","received_events_url":"https://api.github.com/users/chaitanyaenr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chaitanyaenr/aos-cd-jobs","description":null,"fork":true,"url":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs","forks_url":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/forks","keys_url":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/teams","hooks_url":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/hooks","issue_events_url":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/issues/events{/number}","events_url":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/events","assignees_url":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/assignees{/user}","branches_url":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/branches{/branch}","tags_url":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/tags","blobs_url":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/git/refs{/sha}","trees_url":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/statuses/{sha}","languages_url":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/languages","stargazers_url":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/stargazers","contributors_url":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/contributors","subscribers_url":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/subscribers","subscription_url":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/subscription","commits_url":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/commits{/sha}","git_commits_url":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/git/commits{/sha}","comments_url":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/comments{/number}","issue_comment_url":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/issues/comments{/number}","contents_url":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/contents/{+path}","compare_url":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/merges","archive_url":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/downloads","issues_url":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/issues{/number}","pulls_url":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/pulls{/number}","milestones_url":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/milestones{/number}","notifications_url":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/labels{/name}","releases_url":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/releases{/id}","deployments_url":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/deployments","created_at":"2018-03-15T15:20:28Z","updated_at":"2018-06-12T13:57:32Z","pushed_at":"2018-06-27T17:42:46Z","git_url":"git://github.com/chaitanyaenr/aos-cd-jobs.git","ssh_url":"git@github.com:chaitanyaenr/aos-cd-jobs.git","clone_url":"https://github.com/chaitanyaenr/aos-cd-jobs.git","svn_url":"https://github.com/chaitanyaenr/aos-cd-jobs","homepage":null,"size":15258,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":3,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/pulls/15"},"html":{"href":"https://github.com/chaitanyaenr/aos-cd-jobs/pull/15"},"issue":{"href":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/issues/15"},"comments":{"href":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/chaitanyaenr/aos-cd-jobs/statuses/893c2f9256dbfc11ce8cebff9a899c1853f1ce6c"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":22,"additions":1209,"deletions":0,"changed_files":24}}
{"actor":{"display_login":"mbruzek"}}