{"action":"created","issue":{"url":"https://api.github.com/repos/aloneguid/config/issues/71","repository_url":"https://api.github.com/repos/aloneguid/config","labels_url":"https://api.github.com/repos/aloneguid/config/issues/71/labels{/name}","comments_url":"https://api.github.com/repos/aloneguid/config/issues/71/comments","events_url":"https://api.github.com/repos/aloneguid/config/issues/71/events","html_url":"https://github.com/aloneguid/config/issues/71","id":349311726,"node_id":"MDU6SXNzdWUzNDkzMTE3MjY=","number":71,"title":"Store each value based on where it came from","user":{"login":"maelgrove","id":22428830,"node_id":"MDQ6VXNlcjIyNDI4ODMw","avatar_url":"https://avatars2.githubusercontent.com/u/22428830?v=4","gravatar_id":"","url":"https://api.github.com/users/maelgrove","html_url":"https://github.com/maelgrove","followers_url":"https://api.github.com/users/maelgrove/followers","following_url":"https://api.github.com/users/maelgrove/following{/other_user}","gists_url":"https://api.github.com/users/maelgrove/gists{/gist_id}","starred_url":"https://api.github.com/users/maelgrove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maelgrove/subscriptions","organizations_url":"https://api.github.com/users/maelgrove/orgs","repos_url":"https://api.github.com/users/maelgrove/repos","events_url":"https://api.github.com/users/maelgrove/events{/privacy}","received_events_url":"https://api.github.com/users/maelgrove/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-09T22:19:32Z","updated_at":"2018-08-10T22:34:24Z","closed_at":null,"author_association":"NONE","body":"The current implementation stores each change into every `IConfigStore` registered when setting a configuration value, which absolutely makes no sense since you wouldn't want to have your persistent file configuration values end up in a more temporary location, like the environment variables upon setting them. The library should keep track of where a certain configuration value has been retrieved from (using an internal dictionary which maps keys to configuration stores) and only persist them based on their origin."},"comment":{"url":"https://api.github.com/repos/aloneguid/config/issues/comments/412223712","html_url":"https://github.com/aloneguid/config/issues/71#issuecomment-412223712","issue_url":"https://api.github.com/repos/aloneguid/config/issues/71","id":412223712,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjIyMzcxMg==","user":{"login":"maelgrove","id":22428830,"node_id":"MDQ6VXNlcjIyNDI4ODMw","avatar_url":"https://avatars2.githubusercontent.com/u/22428830?v=4","gravatar_id":"","url":"https://api.github.com/users/maelgrove","html_url":"https://github.com/maelgrove","followers_url":"https://api.github.com/users/maelgrove/followers","following_url":"https://api.github.com/users/maelgrove/following{/other_user}","gists_url":"https://api.github.com/users/maelgrove/gists{/gist_id}","starred_url":"https://api.github.com/users/maelgrove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maelgrove/subscriptions","organizations_url":"https://api.github.com/users/maelgrove/orgs","repos_url":"https://api.github.com/users/maelgrove/repos","events_url":"https://api.github.com/users/maelgrove/events{/privacy}","received_events_url":"https://api.github.com/users/maelgrove/received_events","type":"User","site_admin":false},"created_at":"2018-08-10T22:34:24Z","updated_at":"2018-08-10T22:34:24Z","author_association":"NONE","body":"I've created a branch for this over here: [config/values-to-origin](https://github.com/maelgrove/config/tree/values-to-origin) however I'm not quite sure whether to pursue this any further. On one side, it fits the principle of least surprise, as configuration values which originally haven't been defined in a configuration store won't be stored everywhere upon setting them. However, that way it will not be possible to set a configuration value at all if it isn't defined somewhere, which is why a lot of the tests break."}}
{"actor":{"display_login":"maelgrove"}}