{"action":"created","comment":{"url":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/comments/215722585","pull_request_review_id":153052279,"id":215722585,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTcyMjU4NQ==","diff_hunk":"@@ -2,42 +2,52 @@ package tests\n \n import (\n \t\"fmt\"\n+\t\"strconv\"\n+\t\"time\"\n+\n+\t\"net/url\"\n \n \t. \"github.com/onsi/ginkgo\"\n \t. \"github.com/onsi/ginkgo/extensions/table\"\n \t. \"github.com/onsi/gomega\"\n-\t\"github.com/pkg/errors\"\n-\n-\t\"kubevirt.io/containerized-data-importer/tests/framework\"\n-\t\"kubevirt.io/containerized-data-importer/tests/utils\"\n+\t\"github.com/golang/glog\"\n \n \t\"k8s.io/api/core/v1\"\n \t\"kubevirt.io/containerized-data-importer/pkg/common\"\n \t\"kubevirt.io/containerized-data-importer/pkg/controller\"\n+\t\"kubevirt.io/containerized-data-importer/tests/framework\"\n+\t\"kubevirt.io/containerized-data-importer/tests/utils\"\n )\n \n var _ = Describe(\"Transport Tests\", func() {\n \n \tconst (\n \t\tsecretPrefix = \"transport-e2e-sec\"\n \t\ttargetFile   = \"tinyCore.iso\"\n+\t\tsizeCheckPod = \"size-checker\"\n \t)\n \n-\tf, err := framework.NewFramework(\"\", framework.Config{SkipNamespaceCreation: false})\n-\thandelError(errors.Wrap(err, \"error creating test framework\"))\n+\tf := framework.NewFrameworkOrDie(\"transport\", framework.Config{SkipNamespaceCreation: false})","path":"tests/transport_test.go","position":35,"original_position":35,"commit_id":"30a1bf9e7c0bc1e995f3b9f42bbf6c00cf81a093","original_commit_id":"30a1bf9e7c0bc1e995f3b9f42bbf6c00cf81a093","user":{"login":"copejon","id":6430994,"node_id":"MDQ6VXNlcjY0MzA5OTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6430994?v=4","gravatar_id":"","url":"https://api.github.com/users/copejon","html_url":"https://github.com/copejon","followers_url":"https://api.github.com/users/copejon/followers","following_url":"https://api.github.com/users/copejon/following{/other_user}","gists_url":"https://api.github.com/users/copejon/gists{/gist_id}","starred_url":"https://api.github.com/users/copejon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/copejon/subscriptions","organizations_url":"https://api.github.com/users/copejon/orgs","repos_url":"https://api.github.com/users/copejon/repos","events_url":"https://api.github.com/users/copejon/events{/privacy}","received_events_url":"https://api.github.com/users/copejon/received_events","type":"User","site_admin":false},"body":"Correct.  In an earlier comment I believe you asked that I make the field assignment to the default value instead of passing `framework.Config{}`.","created_at":"2018-09-06T18:01:10Z","updated_at":"2018-09-06T18:01:10Z","html_url":"https://github.com/kubevirt/containerized-data-importer/pull/429#discussion_r215722585","pull_request_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/429","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/comments/215722585"},"html":{"href":"https://github.com/kubevirt/containerized-data-importer/pull/429#discussion_r215722585"},"pull_request":{"href":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/429"}},"in_reply_to_id":215721867},"pull_request":{"url":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/429","id":213443489,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNDQzNDg5","html_url":"https://github.com/kubevirt/containerized-data-importer/pull/429","diff_url":"https://github.com/kubevirt/containerized-data-importer/pull/429.diff","patch_url":"https://github.com/kubevirt/containerized-data-importer/pull/429.patch","issue_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/issues/429","number":429,"state":"open","locked":false,"title":"Transport tests validate image size","user":{"login":"copejon","id":6430994,"node_id":"MDQ6VXNlcjY0MzA5OTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6430994?v=4","gravatar_id":"","url":"https://api.github.com/users/copejon","html_url":"https://github.com/copejon","followers_url":"https://api.github.com/users/copejon/followers","following_url":"https://api.github.com/users/copejon/following{/other_user}","gists_url":"https://api.github.com/users/copejon/gists{/gist_id}","starred_url":"https://api.github.com/users/copejon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/copejon/subscriptions","organizations_url":"https://api.github.com/users/copejon/orgs","repos_url":"https://api.github.com/users/copejon/repos","events_url":"https://api.github.com/users/copejon/events{/privacy}","received_events_url":"https://api.github.com/users/copejon/received_events","type":"User","site_admin":false},"body":"Improves transport tests to check that the downloaded file size matches it's remote source's size.\r\nAdds file host utilities for \r\n- getting all remote files\r\n- getting a remote file's size","created_at":"2018-09-05T22:15:10Z","updated_at":"2018-09-06T18:01:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4a156fcac2bc9ee701f1e01dcb063fee33795cad","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/429/commits","review_comments_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/429/comments","review_comment_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/issues/429/comments","statuses_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/statuses/30a1bf9e7c0bc1e995f3b9f42bbf6c00cf81a093","head":{"label":"copejon:functest-validate-images","ref":"functest-validate-images","sha":"30a1bf9e7c0bc1e995f3b9f42bbf6c00cf81a093","user":{"login":"copejon","id":6430994,"node_id":"MDQ6VXNlcjY0MzA5OTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6430994?v=4","gravatar_id":"","url":"https://api.github.com/users/copejon","html_url":"https://github.com/copejon","followers_url":"https://api.github.com/users/copejon/followers","following_url":"https://api.github.com/users/copejon/following{/other_user}","gists_url":"https://api.github.com/users/copejon/gists{/gist_id}","starred_url":"https://api.github.com/users/copejon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/copejon/subscriptions","organizations_url":"https://api.github.com/users/copejon/orgs","repos_url":"https://api.github.com/users/copejon/repos","events_url":"https://api.github.com/users/copejon/events{/privacy}","received_events_url":"https://api.github.com/users/copejon/received_events","type":"User","site_admin":false},"repo":{"id":118969627,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg5Njk2Mjc=","name":"containerized-data-importer","full_name":"copejon/containerized-data-importer","owner":{"login":"copejon","id":6430994,"node_id":"MDQ6VXNlcjY0MzA5OTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6430994?v=4","gravatar_id":"","url":"https://api.github.com/users/copejon","html_url":"https://github.com/copejon","followers_url":"https://api.github.com/users/copejon/followers","following_url":"https://api.github.com/users/copejon/following{/other_user}","gists_url":"https://api.github.com/users/copejon/gists{/gist_id}","starred_url":"https://api.github.com/users/copejon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/copejon/subscriptions","organizations_url":"https://api.github.com/users/copejon/orgs","repos_url":"https://api.github.com/users/copejon/repos","events_url":"https://api.github.com/users/copejon/events{/privacy}","received_events_url":"https://api.github.com/users/copejon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/copejon/containerized-data-importer","description":"Data Import Service for kubernetes, designed with kubevirt in mind.","fork":true,"url":"https://api.github.com/repos/copejon/containerized-data-importer","forks_url":"https://api.github.com/repos/copejon/containerized-data-importer/forks","keys_url":"https://api.github.com/repos/copejon/containerized-data-importer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/copejon/containerized-data-importer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/copejon/containerized-data-importer/teams","hooks_url":"https://api.github.com/repos/copejon/containerized-data-importer/hooks","issue_events_url":"https://api.github.com/repos/copejon/containerized-data-importer/issues/events{/number}","events_url":"https://api.github.com/repos/copejon/containerized-data-importer/events","assignees_url":"https://api.github.com/repos/copejon/containerized-data-importer/assignees{/user}","branches_url":"https://api.github.com/repos/copejon/containerized-data-importer/branches{/branch}","tags_url":"https://api.github.com/repos/copejon/containerized-data-importer/tags","blobs_url":"https://api.github.com/repos/copejon/containerized-data-importer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/copejon/containerized-data-importer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/copejon/containerized-data-importer/git/refs{/sha}","trees_url":"https://api.github.com/repos/copejon/containerized-data-importer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/copejon/containerized-data-importer/statuses/{sha}","languages_url":"https://api.github.com/repos/copejon/containerized-data-importer/languages","stargazers_url":"https://api.github.com/repos/copejon/containerized-data-importer/stargazers","contributors_url":"https://api.github.com/repos/copejon/containerized-data-importer/contributors","subscribers_url":"https://api.github.com/repos/copejon/containerized-data-importer/subscribers","subscription_url":"https://api.github.com/repos/copejon/containerized-data-importer/subscription","commits_url":"https://api.github.com/repos/copejon/containerized-data-importer/commits{/sha}","git_commits_url":"https://api.github.com/repos/copejon/containerized-data-importer/git/commits{/sha}","comments_url":"https://api.github.com/repos/copejon/containerized-data-importer/comments{/number}","issue_comment_url":"https://api.github.com/repos/copejon/containerized-data-importer/issues/comments{/number}","contents_url":"https://api.github.com/repos/copejon/containerized-data-importer/contents/{+path}","compare_url":"https://api.github.com/repos/copejon/containerized-data-importer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/copejon/containerized-data-importer/merges","archive_url":"https://api.github.com/repos/copejon/containerized-data-importer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/copejon/containerized-data-importer/downloads","issues_url":"https://api.github.com/repos/copejon/containerized-data-importer/issues{/number}","pulls_url":"https://api.github.com/repos/copejon/containerized-data-importer/pulls{/number}","milestones_url":"https://api.github.com/repos/copejon/containerized-data-importer/milestones{/number}","notifications_url":"https://api.github.com/repos/copejon/containerized-data-importer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/copejon/containerized-data-importer/labels{/name}","releases_url":"https://api.github.com/repos/copejon/containerized-data-importer/releases{/id}","deployments_url":"https://api.github.com/repos/copejon/containerized-data-importer/deployments","created_at":"2018-01-25T21:26:19Z","updated_at":"2018-09-06T17:39:02Z","pushed_at":"2018-09-06T17:39:20Z","git_url":"git://github.com/copejon/containerized-data-importer.git","ssh_url":"git@github.com:copejon/containerized-data-importer.git","clone_url":"https://github.com/copejon/containerized-data-importer.git","svn_url":"https://github.com/copejon/containerized-data-importer","homepage":"","size":47989,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubevirt:master","ref":"master","sha":"73a492f5c227c805f5a2258676426c4c89f4cc59","user":{"login":"kubevirt","id":18700703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzAwNzAz","avatar_url":"https://avatars1.githubusercontent.com/u/18700703?v=4","gravatar_id":"","url":"https://api.github.com/users/kubevirt","html_url":"https://github.com/kubevirt","followers_url":"https://api.github.com/users/kubevirt/followers","following_url":"https://api.github.com/users/kubevirt/following{/other_user}","gists_url":"https://api.github.com/users/kubevirt/gists{/gist_id}","starred_url":"https://api.github.com/users/kubevirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubevirt/subscriptions","organizations_url":"https://api.github.com/users/kubevirt/orgs","repos_url":"https://api.github.com/users/kubevirt/repos","events_url":"https://api.github.com/users/kubevirt/events{/privacy}","received_events_url":"https://api.github.com/users/kubevirt/received_events","type":"Organization","site_admin":false},"repo":{"id":117756215,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc3NTYyMTU=","name":"containerized-data-importer","full_name":"kubevirt/containerized-data-importer","owner":{"login":"kubevirt","id":18700703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzAwNzAz","avatar_url":"https://avatars1.githubusercontent.com/u/18700703?v=4","gravatar_id":"","url":"https://api.github.com/users/kubevirt","html_url":"https://github.com/kubevirt","followers_url":"https://api.github.com/users/kubevirt/followers","following_url":"https://api.github.com/users/kubevirt/following{/other_user}","gists_url":"https://api.github.com/users/kubevirt/gists{/gist_id}","starred_url":"https://api.github.com/users/kubevirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubevirt/subscriptions","organizations_url":"https://api.github.com/users/kubevirt/orgs","repos_url":"https://api.github.com/users/kubevirt/repos","events_url":"https://api.github.com/users/kubevirt/events{/privacy}","received_events_url":"https://api.github.com/users/kubevirt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubevirt/containerized-data-importer","description":"Data Import Service for kubernetes, designed with kubevirt in mind.","fork":false,"url":"https://api.github.com/repos/kubevirt/containerized-data-importer","forks_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/forks","keys_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/teams","hooks_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/hooks","issue_events_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/issues/events{/number}","events_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/events","assignees_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/assignees{/user}","branches_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/branches{/branch}","tags_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/tags","blobs_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/statuses/{sha}","languages_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/languages","stargazers_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/stargazers","contributors_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/contributors","subscribers_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/subscribers","subscription_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/subscription","commits_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/contents/{+path}","compare_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/merges","archive_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/downloads","issues_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/issues{/number}","pulls_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls{/number}","milestones_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/milestones{/number}","notifications_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/labels{/name}","releases_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/releases{/id}","deployments_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/deployments","created_at":"2018-01-16T23:35:48Z","updated_at":"2018-09-06T16:51:16Z","pushed_at":"2018-09-06T17:39:22Z","git_url":"git://github.com/kubevirt/containerized-data-importer.git","ssh_url":"git@github.com:kubevirt/containerized-data-importer.git","clone_url":"https://github.com/kubevirt/containerized-data-importer.git","svn_url":"https://github.com/kubevirt/containerized-data-importer","homepage":"","size":47981,"stargazers_count":67,"watchers_count":67,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":34,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":28,"open_issues":34,"watchers":67,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/429"},"html":{"href":"https://github.com/kubevirt/containerized-data-importer/pull/429"},"issue":{"href":"https://api.github.com/repos/kubevirt/containerized-data-importer/issues/429"},"comments":{"href":"https://api.github.com/repos/kubevirt/containerized-data-importer/issues/429/comments"},"review_comments":{"href":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/429/comments"},"review_comment":{"href":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/429/commits"},"statuses":{"href":"https://api.github.com/repos/kubevirt/containerized-data-importer/statuses/30a1bf9e7c0bc1e995f3b9f42bbf6c00cf81a093"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"copejon"}}