{"action":"opened","number":50411,"pull_request":{"url":"https://api.github.com/repos/Microsoft/vscode/pulls/50411","id":190385391,"html_url":"https://github.com/Microsoft/vscode/pull/50411","diff_url":"https://github.com/Microsoft/vscode/pull/50411.diff","patch_url":"https://github.com/Microsoft/vscode/pull/50411.patch","issue_url":"https://api.github.com/repos/Microsoft/vscode/issues/50411","number":50411,"state":"open","locked":false,"title":"Fix view order","user":{"login":"ryenus","id":610161,"avatar_url":"https://avatars2.githubusercontent.com/u/610161?v=4","gravatar_id":"","url":"https://api.github.com/users/ryenus","html_url":"https://github.com/ryenus","followers_url":"https://api.github.com/users/ryenus/followers","following_url":"https://api.github.com/users/ryenus/following{/other_user}","gists_url":"https://api.github.com/users/ryenus/gists{/gist_id}","starred_url":"https://api.github.com/users/ryenus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryenus/subscriptions","organizations_url":"https://api.github.com/users/ryenus/orgs","repos_url":"https://api.github.com/users/ryenus/repos","events_url":"https://api.github.com/users/ryenus/events{/privacy}","received_events_url":"https://api.github.com/users/ryenus/received_events","type":"User","site_admin":false},"body":"> `const orderA = viewStateA ? viewStateA.order : a.order;`\r\n> `const orderB = viewStateB ? viewStateB.order : b.order;`\r\n\r\nHere when `viewStateA` has a value like `viewStateA == { order: undefined; }`, we would get `undefined`, even though we wanted to fallback to `a.order`.\r\n","created_at":"2018-05-24T18:48:51Z","updated_at":"2018-05-24T18:48:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/vscode/pulls/50411/commits","review_comments_url":"https://api.github.com/repos/Microsoft/vscode/pulls/50411/comments","review_comment_url":"https://api.github.com/repos/Microsoft/vscode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/vscode/issues/50411/comments","statuses_url":"https://api.github.com/repos/Microsoft/vscode/statuses/956877d6f72ebd52c090e1caa49d2b6beb3c4855","head":{"label":"ryenus:fix-view-order","ref":"fix-view-order","sha":"956877d6f72ebd52c090e1caa49d2b6beb3c4855","user":{"login":"ryenus","id":610161,"avatar_url":"https://avatars2.githubusercontent.com/u/610161?v=4","gravatar_id":"","url":"https://api.github.com/users/ryenus","html_url":"https://github.com/ryenus","followers_url":"https://api.github.com/users/ryenus/followers","following_url":"https://api.github.com/users/ryenus/following{/other_user}","gists_url":"https://api.github.com/users/ryenus/gists{/gist_id}","starred_url":"https://api.github.com/users/ryenus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryenus/subscriptions","organizations_url":"https://api.github.com/users/ryenus/orgs","repos_url":"https://api.github.com/users/ryenus/repos","events_url":"https://api.github.com/users/ryenus/events{/privacy}","received_events_url":"https://api.github.com/users/ryenus/received_events","type":"User","site_admin":false},"repo":{"id":129286005,"name":"vscode","full_name":"ryenus/vscode","owner":{"login":"ryenus","id":610161,"avatar_url":"https://avatars2.githubusercontent.com/u/610161?v=4","gravatar_id":"","url":"https://api.github.com/users/ryenus","html_url":"https://github.com/ryenus","followers_url":"https://api.github.com/users/ryenus/followers","following_url":"https://api.github.com/users/ryenus/following{/other_user}","gists_url":"https://api.github.com/users/ryenus/gists{/gist_id}","starred_url":"https://api.github.com/users/ryenus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryenus/subscriptions","organizations_url":"https://api.github.com/users/ryenus/orgs","repos_url":"https://api.github.com/users/ryenus/repos","events_url":"https://api.github.com/users/ryenus/events{/privacy}","received_events_url":"https://api.github.com/users/ryenus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ryenus/vscode","description":"Visual Studio Code","fork":true,"url":"https://api.github.com/repos/ryenus/vscode","forks_url":"https://api.github.com/repos/ryenus/vscode/forks","keys_url":"https://api.github.com/repos/ryenus/vscode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ryenus/vscode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ryenus/vscode/teams","hooks_url":"https://api.github.com/repos/ryenus/vscode/hooks","issue_events_url":"https://api.github.com/repos/ryenus/vscode/issues/events{/number}","events_url":"https://api.github.com/repos/ryenus/vscode/events","assignees_url":"https://api.github.com/repos/ryenus/vscode/assignees{/user}","branches_url":"https://api.github.com/repos/ryenus/vscode/branches{/branch}","tags_url":"https://api.github.com/repos/ryenus/vscode/tags","blobs_url":"https://api.github.com/repos/ryenus/vscode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ryenus/vscode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ryenus/vscode/git/refs{/sha}","trees_url":"https://api.github.com/repos/ryenus/vscode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ryenus/vscode/statuses/{sha}","languages_url":"https://api.github.com/repos/ryenus/vscode/languages","stargazers_url":"https://api.github.com/repos/ryenus/vscode/stargazers","contributors_url":"https://api.github.com/repos/ryenus/vscode/contributors","subscribers_url":"https://api.github.com/repos/ryenus/vscode/subscribers","subscription_url":"https://api.github.com/repos/ryenus/vscode/subscription","commits_url":"https://api.github.com/repos/ryenus/vscode/commits{/sha}","git_commits_url":"https://api.github.com/repos/ryenus/vscode/git/commits{/sha}","comments_url":"https://api.github.com/repos/ryenus/vscode/comments{/number}","issue_comment_url":"https://api.github.com/repos/ryenus/vscode/issues/comments{/number}","contents_url":"https://api.github.com/repos/ryenus/vscode/contents/{+path}","compare_url":"https://api.github.com/repos/ryenus/vscode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ryenus/vscode/merges","archive_url":"https://api.github.com/repos/ryenus/vscode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ryenus/vscode/downloads","issues_url":"https://api.github.com/repos/ryenus/vscode/issues{/number}","pulls_url":"https://api.github.com/repos/ryenus/vscode/pulls{/number}","milestones_url":"https://api.github.com/repos/ryenus/vscode/milestones{/number}","notifications_url":"https://api.github.com/repos/ryenus/vscode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ryenus/vscode/labels{/name}","releases_url":"https://api.github.com/repos/ryenus/vscode/releases{/id}","deployments_url":"https://api.github.com/repos/ryenus/vscode/deployments","created_at":"2018-04-12T17:10:51Z","updated_at":"2018-05-24T18:28:34Z","pushed_at":"2018-05-24T18:32:41Z","git_url":"git://github.com/ryenus/vscode.git","ssh_url":"git@github.com:ryenus/vscode.git","clone_url":"https://github.com/ryenus/vscode.git","svn_url":"https://github.com/ryenus/vscode","homepage":"https://code.visualstudio.com","size":134043,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"8f3f91d1f7840b8f33503fe404afc7c631ada3af","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":41881900,"name":"vscode","full_name":"Microsoft/vscode","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/vscode","description":"Visual Studio Code","fork":false,"url":"https://api.github.com/repos/Microsoft/vscode","forks_url":"https://api.github.com/repos/Microsoft/vscode/forks","keys_url":"https://api.github.com/repos/Microsoft/vscode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vscode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vscode/teams","hooks_url":"https://api.github.com/repos/Microsoft/vscode/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vscode/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vscode/events","assignees_url":"https://api.github.com/repos/Microsoft/vscode/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vscode/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vscode/tags","blobs_url":"https://api.github.com/repos/Microsoft/vscode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vscode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vscode/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vscode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vscode/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vscode/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vscode/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vscode/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vscode/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vscode/subscription","commits_url":"https://api.github.com/repos/Microsoft/vscode/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vscode/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vscode/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vscode/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vscode/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vscode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vscode/merges","archive_url":"https://api.github.com/repos/Microsoft/vscode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vscode/downloads","issues_url":"https://api.github.com/repos/Microsoft/vscode/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vscode/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vscode/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vscode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vscode/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vscode/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vscode/deployments","created_at":"2015-09-03T20:23:38Z","updated_at":"2018-05-24T18:41:35Z","pushed_at":"2018-05-24T17:46:09Z","git_url":"git://github.com/Microsoft/vscode.git","ssh_url":"git@github.com:Microsoft/vscode.git","clone_url":"https://github.com/Microsoft/vscode.git","svn_url":"https://github.com/Microsoft/vscode","homepage":"https://code.visualstudio.com","size":138997,"stargazers_count":50770,"watchers_count":50770,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6749,"mirror_url":null,"archived":false,"open_issues_count":4789,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":6749,"open_issues":4789,"watchers":50770,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vscode/pulls/50411"},"html":{"href":"https://github.com/Microsoft/vscode/pull/50411"},"issue":{"href":"https://api.github.com/repos/Microsoft/vscode/issues/50411"},"comments":{"href":"https://api.github.com/repos/Microsoft/vscode/issues/50411/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/vscode/pulls/50411/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/vscode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/vscode/pulls/50411/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/vscode/statuses/956877d6f72ebd52c090e1caa49d2b6beb3c4855"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":7,"deletions":15,"changed_files":1}}
{"actor":{"display_login":"ryenus"}}