{"action":"created","comment":{"url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/pulls/comments/225455766","pull_request_review_id":165055832,"id":225455766,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTQ1NTc2Ng==","diff_hunk":"@@ -521,25 +521,43 @@ showCompletionMessage()\n   echo \"All done!\"\n }\n \n+execute()","path":"sbin/build.sh","position":4,"original_position":4,"commit_id":"bfce31627affd6852249574e6e3af8f720c28f8c","original_commit_id":"a16426e1f2c1045c7bbd64d6aeb8d252c70d1b63","user":{"login":"karianna","id":180840,"node_id":"MDQ6VXNlcjE4MDg0MA==","avatar_url":"https://avatars0.githubusercontent.com/u/180840?v=4","gravatar_id":"","url":"https://api.github.com/users/karianna","html_url":"https://github.com/karianna","followers_url":"https://api.github.com/users/karianna/followers","following_url":"https://api.github.com/users/karianna/following{/other_user}","gists_url":"https://api.github.com/users/karianna/gists{/gist_id}","starred_url":"https://api.github.com/users/karianna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karianna/subscriptions","organizations_url":"https://api.github.com/users/karianna/orgs","repos_url":"https://api.github.com/users/karianna/repos","events_url":"https://api.github.com/users/karianna/events{/privacy}","received_events_url":"https://api.github.com/users/karianna/received_events","type":"User","site_admin":false},"body":"Yes I prefer this idea - nice workaround!","created_at":"2018-10-16T09:05:44Z","updated_at":"2018-10-16T09:05:45Z","html_url":"https://github.com/AdoptOpenJDK/openjdk-build/pull/643#discussion_r225455766","pull_request_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/pulls/643","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/pulls/comments/225455766"},"html":{"href":"https://github.com/AdoptOpenJDK/openjdk-build/pull/643#discussion_r225455766"},"pull_request":{"href":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/pulls/643"}},"in_reply_to_id":225092683},"pull_request":{"url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/pulls/643","id":222745361,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNzQ1MzYx","html_url":"https://github.com/AdoptOpenJDK/openjdk-build/pull/643","diff_url":"https://github.com/AdoptOpenJDK/openjdk-build/pull/643.diff","patch_url":"https://github.com/AdoptOpenJDK/openjdk-build/pull/643.patch","issue_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/issues/643","number":643,"state":"open","locked":false,"title":"Add some basic docker documentation on how to ssh into the container #584","user":{"login":"amczarny","id":1258840,"node_id":"MDQ6VXNlcjEyNTg4NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/1258840?v=4","gravatar_id":"","url":"https://api.github.com/users/amczarny","html_url":"https://github.com/amczarny","followers_url":"https://api.github.com/users/amczarny/followers","following_url":"https://api.github.com/users/amczarny/following{/other_user}","gists_url":"https://api.github.com/users/amczarny/gists{/gist_id}","starred_url":"https://api.github.com/users/amczarny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amczarny/subscriptions","organizations_url":"https://api.github.com/users/amczarny/orgs","repos_url":"https://api.github.com/users/amczarny/repos","events_url":"https://api.github.com/users/amczarny/events{/privacy}","received_events_url":"https://api.github.com/users/amczarny/received_events","type":"User","site_admin":false},"body":"fixes #584. Instead of adding documenation I assume it is simpler to have an extra flag --debug-docker which allows you to step over main functions inside docker container build.sh script. \r\nI had number of cases where I had to add /bin/bash inside /sbin/build.sh to investigate the failure.\r\nExample:\r\n```\r\n   =========================\r\n   | DEBUG MODE IS ENABLED |\r\n   =========================\r\n      Script - /openjdk/sbin/build.sh\r\n      Executed function -  removingUnnecessaryFiles\r\n   ========================================================\r\n   | Type 'exit' and press enter to move to next function |\r\n   ========================================================\r\nbuild@2e05fb78e96b:/openjdk/build/src/build/linux-x86_64-normal-server-release/images$ exit\r\nexit\r\nCould not find dir: jdk8u181-b13/Contents/Home\r\n   =========================\r\n   | DEBUG MODE IS ENABLED |\r\n   =========================\r\n      Script - /openjdk/sbin/build.sh\r\n      Executed function -  makeACopyOfLibFreeFontForMacOSX jdk8u181-b13 false\r\n   ========================================================\r\n   | Type 'exit' and press enter to move to next function |\r\n   ========================================================\r\nbuild@2e05fb78e96b:/openjdk/build/src/build/linux-x86_64-normal-server-release/images$ exit\r\nexit\r\nCould not find dir: jdk8u181-b13-jre/Contents/Home\r\n   =========================\r\n   | DEBUG MODE IS ENABLED |\r\n   =========================\r\n      Script - /openjdk/sbin/build.sh\r\n      Executed function -  makeACopyOfLibFreeFontForMacOSX jdk8u181-b13-jre false\r\n   ========================================================\r\n   | Type 'exit' and press enter to move to next function |\r\n   ========================================================\r\n\r\n```\r\nDCO 1.1 Signed-off-by: Andrzej Czarny","created_at":"2018-10-14T21:46:10Z","updated_at":"2018-10-16T09:05:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67d278e5c66c9ec17533fc2dfdb3d13e31d0a36e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":575829128,"node_id":"MDU6TGFiZWw1NzU4MjkxMjg=","url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/labels/documentation","name":"documentation","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/pulls/643/commits","review_comments_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/pulls/643/comments","review_comment_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/issues/643/comments","statuses_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/statuses/bfce31627affd6852249574e6e3af8f720c28f8c","head":{"label":"amczarny:584_add_docker_debug","ref":"584_add_docker_debug","sha":"bfce31627affd6852249574e6e3af8f720c28f8c","user":{"login":"amczarny","id":1258840,"node_id":"MDQ6VXNlcjEyNTg4NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/1258840?v=4","gravatar_id":"","url":"https://api.github.com/users/amczarny","html_url":"https://github.com/amczarny","followers_url":"https://api.github.com/users/amczarny/followers","following_url":"https://api.github.com/users/amczarny/following{/other_user}","gists_url":"https://api.github.com/users/amczarny/gists{/gist_id}","starred_url":"https://api.github.com/users/amczarny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amczarny/subscriptions","organizations_url":"https://api.github.com/users/amczarny/orgs","repos_url":"https://api.github.com/users/amczarny/repos","events_url":"https://api.github.com/users/amczarny/events{/privacy}","received_events_url":"https://api.github.com/users/amczarny/received_events","type":"User","site_admin":false},"repo":{"id":127520359,"node_id":"MDEwOlJlcG9zaXRvcnkxMjc1MjAzNTk=","name":"openjdk-build","full_name":"amczarny/openjdk-build","private":false,"owner":{"login":"amczarny","id":1258840,"node_id":"MDQ6VXNlcjEyNTg4NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/1258840?v=4","gravatar_id":"","url":"https://api.github.com/users/amczarny","html_url":"https://github.com/amczarny","followers_url":"https://api.github.com/users/amczarny/followers","following_url":"https://api.github.com/users/amczarny/following{/other_user}","gists_url":"https://api.github.com/users/amczarny/gists{/gist_id}","starred_url":"https://api.github.com/users/amczarny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amczarny/subscriptions","organizations_url":"https://api.github.com/users/amczarny/orgs","repos_url":"https://api.github.com/users/amczarny/repos","events_url":"https://api.github.com/users/amczarny/events{/privacy}","received_events_url":"https://api.github.com/users/amczarny/received_events","type":"User","site_admin":false},"html_url":"https://github.com/amczarny/openjdk-build","description":"AdoptOpenJDK community OpenJDK build scripts - common across all releases/versions","fork":true,"url":"https://api.github.com/repos/amczarny/openjdk-build","forks_url":"https://api.github.com/repos/amczarny/openjdk-build/forks","keys_url":"https://api.github.com/repos/amczarny/openjdk-build/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amczarny/openjdk-build/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amczarny/openjdk-build/teams","hooks_url":"https://api.github.com/repos/amczarny/openjdk-build/hooks","issue_events_url":"https://api.github.com/repos/amczarny/openjdk-build/issues/events{/number}","events_url":"https://api.github.com/repos/amczarny/openjdk-build/events","assignees_url":"https://api.github.com/repos/amczarny/openjdk-build/assignees{/user}","branches_url":"https://api.github.com/repos/amczarny/openjdk-build/branches{/branch}","tags_url":"https://api.github.com/repos/amczarny/openjdk-build/tags","blobs_url":"https://api.github.com/repos/amczarny/openjdk-build/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amczarny/openjdk-build/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amczarny/openjdk-build/git/refs{/sha}","trees_url":"https://api.github.com/repos/amczarny/openjdk-build/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amczarny/openjdk-build/statuses/{sha}","languages_url":"https://api.github.com/repos/amczarny/openjdk-build/languages","stargazers_url":"https://api.github.com/repos/amczarny/openjdk-build/stargazers","contributors_url":"https://api.github.com/repos/amczarny/openjdk-build/contributors","subscribers_url":"https://api.github.com/repos/amczarny/openjdk-build/subscribers","subscription_url":"https://api.github.com/repos/amczarny/openjdk-build/subscription","commits_url":"https://api.github.com/repos/amczarny/openjdk-build/commits{/sha}","git_commits_url":"https://api.github.com/repos/amczarny/openjdk-build/git/commits{/sha}","comments_url":"https://api.github.com/repos/amczarny/openjdk-build/comments{/number}","issue_comment_url":"https://api.github.com/repos/amczarny/openjdk-build/issues/comments{/number}","contents_url":"https://api.github.com/repos/amczarny/openjdk-build/contents/{+path}","compare_url":"https://api.github.com/repos/amczarny/openjdk-build/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amczarny/openjdk-build/merges","archive_url":"https://api.github.com/repos/amczarny/openjdk-build/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amczarny/openjdk-build/downloads","issues_url":"https://api.github.com/repos/amczarny/openjdk-build/issues{/number}","pulls_url":"https://api.github.com/repos/amczarny/openjdk-build/pulls{/number}","milestones_url":"https://api.github.com/repos/amczarny/openjdk-build/milestones{/number}","notifications_url":"https://api.github.com/repos/amczarny/openjdk-build/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amczarny/openjdk-build/labels{/name}","releases_url":"https://api.github.com/repos/amczarny/openjdk-build/releases{/id}","deployments_url":"https://api.github.com/repos/amczarny/openjdk-build/deployments","created_at":"2018-03-31T09:56:30Z","updated_at":"2018-10-15T21:31:59Z","pushed_at":"2018-10-15T21:38:33Z","git_url":"git://github.com/amczarny/openjdk-build.git","ssh_url":"git@github.com:amczarny/openjdk-build.git","clone_url":"https://github.com/amczarny/openjdk-build.git","svn_url":"https://github.com/amczarny/openjdk-build","homepage":"","size":934,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AdoptOpenJDK:master","ref":"master","sha":"ff58b8999ee15060e4efe5c9aa4bd47921e754c6","user":{"login":"AdoptOpenJDK","id":1673867,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NzM4Njc=","avatar_url":"https://avatars0.githubusercontent.com/u/1673867?v=4","gravatar_id":"","url":"https://api.github.com/users/AdoptOpenJDK","html_url":"https://github.com/AdoptOpenJDK","followers_url":"https://api.github.com/users/AdoptOpenJDK/followers","following_url":"https://api.github.com/users/AdoptOpenJDK/following{/other_user}","gists_url":"https://api.github.com/users/AdoptOpenJDK/gists{/gist_id}","starred_url":"https://api.github.com/users/AdoptOpenJDK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdoptOpenJDK/subscriptions","organizations_url":"https://api.github.com/users/AdoptOpenJDK/orgs","repos_url":"https://api.github.com/users/AdoptOpenJDK/repos","events_url":"https://api.github.com/users/AdoptOpenJDK/events{/privacy}","received_events_url":"https://api.github.com/users/AdoptOpenJDK/received_events","type":"Organization","site_admin":false},"repo":{"id":85294562,"node_id":"MDEwOlJlcG9zaXRvcnk4NTI5NDU2Mg==","name":"openjdk-build","full_name":"AdoptOpenJDK/openjdk-build","private":false,"owner":{"login":"AdoptOpenJDK","id":1673867,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NzM4Njc=","avatar_url":"https://avatars0.githubusercontent.com/u/1673867?v=4","gravatar_id":"","url":"https://api.github.com/users/AdoptOpenJDK","html_url":"https://github.com/AdoptOpenJDK","followers_url":"https://api.github.com/users/AdoptOpenJDK/followers","following_url":"https://api.github.com/users/AdoptOpenJDK/following{/other_user}","gists_url":"https://api.github.com/users/AdoptOpenJDK/gists{/gist_id}","starred_url":"https://api.github.com/users/AdoptOpenJDK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdoptOpenJDK/subscriptions","organizations_url":"https://api.github.com/users/AdoptOpenJDK/orgs","repos_url":"https://api.github.com/users/AdoptOpenJDK/repos","events_url":"https://api.github.com/users/AdoptOpenJDK/events{/privacy}","received_events_url":"https://api.github.com/users/AdoptOpenJDK/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/AdoptOpenJDK/openjdk-build","description":"AdoptOpenJDK community OpenJDK build scripts - common across all releases/versions","fork":false,"url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build","forks_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/forks","keys_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/teams","hooks_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/hooks","issue_events_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/issues/events{/number}","events_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/events","assignees_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/assignees{/user}","branches_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/branches{/branch}","tags_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/tags","blobs_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/git/refs{/sha}","trees_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/statuses/{sha}","languages_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/languages","stargazers_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/stargazers","contributors_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/contributors","subscribers_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/subscribers","subscription_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/subscription","commits_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/commits{/sha}","git_commits_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/git/commits{/sha}","comments_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/comments{/number}","issue_comment_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/issues/comments{/number}","contents_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/contents/{+path}","compare_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/merges","archive_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/downloads","issues_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/issues{/number}","pulls_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/pulls{/number}","milestones_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/milestones{/number}","notifications_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/labels{/name}","releases_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/releases{/id}","deployments_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/deployments","created_at":"2017-03-17T09:31:50Z","updated_at":"2018-10-16T09:04:15Z","pushed_at":"2018-10-16T09:04:12Z","git_url":"git://github.com/AdoptOpenJDK/openjdk-build.git","ssh_url":"git@github.com:AdoptOpenJDK/openjdk-build.git","clone_url":"https://github.com/AdoptOpenJDK/openjdk-build.git","svn_url":"https://github.com/AdoptOpenJDK/openjdk-build","homepage":"","size":922,"stargazers_count":132,"watchers_count":132,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"archived":false,"open_issues_count":159,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":55,"open_issues":159,"watchers":132,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/pulls/643"},"html":{"href":"https://github.com/AdoptOpenJDK/openjdk-build/pull/643"},"issue":{"href":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/issues/643"},"comments":{"href":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/issues/643/comments"},"review_comments":{"href":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/pulls/643/comments"},"review_comment":{"href":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/pulls/643/commits"},"statuses":{"href":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/statuses/bfce31627affd6852249574e6e3af8f720c28f8c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"karianna"}}