{"action":"created","issue":{"url":"https://api.github.com/repos/codice/ddf/issues/3572","repository_url":"https://api.github.com/repos/codice/ddf","labels_url":"https://api.github.com/repos/codice/ddf/issues/3572/labels{/name}","comments_url":"https://api.github.com/repos/codice/ddf/issues/3572/comments","events_url":"https://api.github.com/repos/codice/ddf/issues/3572/events","html_url":"https://github.com/codice/ddf/pull/3572","id":348931022,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MTY3OTA0","number":3572,"title":"[WIP] DDF-4038 Improving sorting of Gazetteer suggestions","user":{"login":"gjvera","id":36056781,"node_id":"MDQ6VXNlcjM2MDU2Nzgx","avatar_url":"https://avatars0.githubusercontent.com/u/36056781?v=4","gravatar_id":"","url":"https://api.github.com/users/gjvera","html_url":"https://github.com/gjvera","followers_url":"https://api.github.com/users/gjvera/followers","following_url":"https://api.github.com/users/gjvera/following{/other_user}","gists_url":"https://api.github.com/users/gjvera/gists{/gist_id}","starred_url":"https://api.github.com/users/gjvera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gjvera/subscriptions","organizations_url":"https://api.github.com/users/gjvera/orgs","repos_url":"https://api.github.com/users/gjvera/repos","events_url":"https://api.github.com/users/gjvera/events{/privacy}","received_events_url":"https://api.github.com/users/gjvera/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"millerw8","id":4419422,"node_id":"MDQ6VXNlcjQ0MTk0MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/4419422?v=4","gravatar_id":"","url":"https://api.github.com/users/millerw8","html_url":"https://github.com/millerw8","followers_url":"https://api.github.com/users/millerw8/followers","following_url":"https://api.github.com/users/millerw8/following{/other_user}","gists_url":"https://api.github.com/users/millerw8/gists{/gist_id}","starred_url":"https://api.github.com/users/millerw8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/millerw8/subscriptions","organizations_url":"https://api.github.com/users/millerw8/orgs","repos_url":"https://api.github.com/users/millerw8/repos","events_url":"https://api.github.com/users/millerw8/events{/privacy}","received_events_url":"https://api.github.com/users/millerw8/received_events","type":"User","site_admin":false},"assignees":[{"login":"millerw8","id":4419422,"node_id":"MDQ6VXNlcjQ0MTk0MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/4419422?v=4","gravatar_id":"","url":"https://api.github.com/users/millerw8","html_url":"https://github.com/millerw8","followers_url":"https://api.github.com/users/millerw8/followers","following_url":"https://api.github.com/users/millerw8/following{/other_user}","gists_url":"https://api.github.com/users/millerw8/gists{/gist_id}","starred_url":"https://api.github.com/users/millerw8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/millerw8/subscriptions","organizations_url":"https://api.github.com/users/millerw8/orgs","repos_url":"https://api.github.com/users/millerw8/repos","events_url":"https://api.github.com/users/millerw8/events{/privacy}","received_events_url":"https://api.github.com/users/millerw8/received_events","type":"User","site_admin":false},{"login":"bdeining","id":6551038,"node_id":"MDQ6VXNlcjY1NTEwMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/6551038?v=4","gravatar_id":"","url":"https://api.github.com/users/bdeining","html_url":"https://github.com/bdeining","followers_url":"https://api.github.com/users/bdeining/followers","following_url":"https://api.github.com/users/bdeining/following{/other_user}","gists_url":"https://api.github.com/users/bdeining/gists{/gist_id}","starred_url":"https://api.github.com/users/bdeining/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdeining/subscriptions","organizations_url":"https://api.github.com/users/bdeining/orgs","repos_url":"https://api.github.com/users/bdeining/repos","events_url":"https://api.github.com/users/bdeining/events{/privacy}","received_events_url":"https://api.github.com/users/bdeining/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-08-08T23:50:34Z","updated_at":"2018-08-09T05:29:43Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/3572","html_url":"https://github.com/codice/ddf/pull/3572","diff_url":"https://github.com/codice/ddf/pull/3572.diff","patch_url":"https://github.com/codice/ddf/pull/3572.patch"},"body":"<!--\r\nUncomment this block and include PR # of change against 2.13.x where appropriate.\r\nWhen doing so, it is reasonable to delete much of the rest of the PR description, leaving only:\r\n- This uncommented block with link to 2.13.x PR\r\n- Reviewers tagged\r\n- Teams tagged\r\n- Committers tagged\r\n- The link to the \"Notes on Review Process\"\r\n\r\n##### ABBREVIATED REVIEW BETWEEN 2.13.X AND MASTER IS IN EFFECT\r\nLink to 2.13.x PR: #XXXX\r\n____\r\n-->\r\n\r\n#### What does this PR do?\r\nWhen doing a keyword search currently the gazetteer data isn't very intuitive. I.E. Paris, Texas comes up before Paris, France, Chinatown, USA comes up before China, etc. This PR sorts suggestions as follows, countries first then geonames data is sorted based on population. Hopefully, this will result in the suggester being a little more intuitive. Currently my implementation creates a score on ingest giving a score of 1 to any country and then creating a score from 2 - 10 based on population, then sorts the suggestions based on their perspective score. \r\n#### Who is reviewing it? \r\n@adimka @GabrielFabian \r\n<!--(please choose AT LEAST two reviewers that need to approve the PR before it can get merged)-->\r\n#### Select relevant component teams: \r\nhttps://github.com/orgs/codice/teams\r\n#### Ask 2 committers to review/merge the PR and tag them here.\r\n@bdeining @millerw8 \r\n<!--\r\nIf you don't know who to ask, you can request reviews in https://groups.google.com/forum/#!forum/ddf-developers .\r\n(please choose ONLY two committers from below, delete the rest)\r\n-->\r\n#### How should this be tested?\r\nIngest [Gazetteer data](https://confluence.di2e.net/display/GSR/Gazetteer+Data) \r\n go to search ui and do a basic search do location (Somewhere specific) and then do a keyword search\r\nType in two letters and see the suggestions and ensure that countries come first \r\n(i.e) when typing in `Ar` you should see Argentina, Armenia, followed by some cities \r\n<!--(List steps with links to updated documentation)-->\r\n#### Any background context you want to provide?\r\n#### What are the relevant tickets?\r\n[DDF-4038](https://codice.atlassian.net/browse/DDF-4038)\r\n#### Screenshots\r\n<!--(if appropriate)-->\r\n#### Checklist:\r\n- [ ] Documentation Updated\r\n- [ ] Update / Add Unit Tests\r\n- [ ] Update / Add Integration Tests \r\n\r\n#### Notes on Review Process\r\nPlease see [Notes on Review Process](https://codice.atlassian.net/wiki/spaces/DDF/pages/71946981/Pull+Request+Guidelines) for further guidance on requirements for merging and abbreviated reviews. \r\n\r\n#### Review Comment Legend:\r\n- ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist. \r\n- ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.\r\n- ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.\r\n"},"comment":{"url":"https://api.github.com/repos/codice/ddf/issues/comments/411641276","html_url":"https://github.com/codice/ddf/pull/3572#issuecomment-411641276","issue_url":"https://api.github.com/repos/codice/ddf/issues/3572","id":411641276,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMTY0MTI3Ng==","user":{"login":"andrewkfiedler","id":11984853,"node_id":"MDQ6VXNlcjExOTg0ODUz","avatar_url":"https://avatars3.githubusercontent.com/u/11984853?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewkfiedler","html_url":"https://github.com/andrewkfiedler","followers_url":"https://api.github.com/users/andrewkfiedler/followers","following_url":"https://api.github.com/users/andrewkfiedler/following{/other_user}","gists_url":"https://api.github.com/users/andrewkfiedler/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewkfiedler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewkfiedler/subscriptions","organizations_url":"https://api.github.com/users/andrewkfiedler/orgs","repos_url":"https://api.github.com/users/andrewkfiedler/repos","events_url":"https://api.github.com/users/andrewkfiedler/events{/privacy}","received_events_url":"https://api.github.com/users/andrewkfiedler/received_events","type":"User","site_admin":false},"created_at":"2018-08-09T05:29:43Z","updated_at":"2018-08-09T05:29:43Z","author_association":"CONTRIBUTOR","body":"❓ It kind of feels like this should be adding two sortbys rather than trying to utilize a single one.\r\n\r\nConsider adding a sortby that solely ranks things by either country or city, and than doing another sortby that's a tiebreaker on population.  \r\n\r\nThen you could avoid needing to use a 1-10 ranking system and simply use population directly."}}
{"actor":{"display_login":"andrewkfiedler"}}