{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/226944251","pull_request_review_id":166872542,"id":226944251,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjk0NDI1MQ==","diff_hunk":"@@ -2,20 +2,21 @@\n \n buildGoPackage rec {\n   name = \"restic-${version}\";\n-  version = \"0.9.2\";\n+  version = \"0.9.3\";\n \n   goPackagePath = \"github.com/restic/restic\";\n \n   src = fetchFromGitHub {\n     owner = \"restic\";\n     repo = \"restic\";\n     rev = \"v${version}\";\n-    sha256 = \"0kl8yk636i3y7f2kd43pydjh4pv7hhq09p5k54jlysnrbf2kjb4h\";\n+    sha256 = \"0l35pdrq1hhcz3cb2qm267m6846mxfwbl1adk2kp748b2q55pdma\";\n   };\n \n+\n   buildPhase = ''\n     cd go/src/${goPackagePath}\n-    go run build.go\n+    GO111MODULE=on GOCACHE=`mktemp -d` go run -mod=vendor build.go","path":"pkgs/tools/backup/restic/default.nix","position":21,"original_position":21,"commit_id":"b0b94d45c0df63f89d7b4e6acb9c25b437f6a2c8","original_commit_id":"b0b94d45c0df63f89d7b4e6acb9c25b437f6a2c8","user":{"login":"dotlambda","id":6806011,"node_id":"MDQ6VXNlcjY4MDYwMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/6806011?v=4","gravatar_id":"","url":"https://api.github.com/users/dotlambda","html_url":"https://github.com/dotlambda","followers_url":"https://api.github.com/users/dotlambda/followers","following_url":"https://api.github.com/users/dotlambda/following{/other_user}","gists_url":"https://api.github.com/users/dotlambda/gists{/gist_id}","starred_url":"https://api.github.com/users/dotlambda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotlambda/subscriptions","organizations_url":"https://api.github.com/users/dotlambda/orgs","repos_url":"https://api.github.com/users/dotlambda/repos","events_url":"https://api.github.com/users/dotlambda/events{/privacy}","received_events_url":"https://api.github.com/users/dotlambda/received_events","type":"User","site_admin":false},"body":"No, I'm getting either `build flag -mod=vendor only valid when using modules` or `go: cannot use modules with build cache disabled` if I I also remove `-mod=vendor`. It also doesn't work if I remove `GO111MODULE=on`.","created_at":"2018-10-22T09:36:29Z","updated_at":"2018-10-22T09:36:33Z","html_url":"https://github.com/NixOS/nixpkgs/pull/48627#discussion_r226944251","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/48627","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/226944251"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/48627#discussion_r226944251"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/48627"}},"in_reply_to_id":226880337},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/48627","id":223612579,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNjEyNTc5","html_url":"https://github.com/NixOS/nixpkgs/pull/48627","diff_url":"https://github.com/NixOS/nixpkgs/pull/48627.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/48627.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/48627","number":48627,"state":"open","locked":false,"title":"restic: 0.9.2 -> 0.9.3","user":{"login":"dotlambda","id":6806011,"node_id":"MDQ6VXNlcjY4MDYwMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/6806011?v=4","gravatar_id":"","url":"https://api.github.com/users/dotlambda","html_url":"https://github.com/dotlambda","followers_url":"https://api.github.com/users/dotlambda/followers","following_url":"https://api.github.com/users/dotlambda/following{/other_user}","gists_url":"https://api.github.com/users/dotlambda/gists{/gist_id}","starred_url":"https://api.github.com/users/dotlambda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotlambda/subscriptions","organizations_url":"https://api.github.com/users/dotlambda/orgs","repos_url":"https://api.github.com/users/dotlambda/repos","events_url":"https://api.github.com/users/dotlambda/events{/privacy}","received_events_url":"https://api.github.com/users/dotlambda/received_events","type":"User","site_admin":false},"body":"restic recently switched to using Go 1.11 modules: https://github.com/restic/restic/pull/1920\r\nI don't know any Go so tried to guess how to do that the right way in Nixpkgs. Please have a look.\r\nAgain: I have no idea whether I'm using `GO111MODULE` and `GOCACHE` the right way.\r\n\r\nAll I can say is that restic seems to run fine according to my short test.\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Determined the impact on package closure size (by running `nix path-info -S` before and after) **(new: 17178568, old: 16659688)**\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\ncc @adisbladis @Mic92 ","created_at":"2018-10-17T13:52:05Z","updated_at":"2018-10-22T09:36:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d097b4332c794259d431a24812e02eac150471c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":731735222,"node_id":"MDU6TGFiZWw3MzE3MzUyMjI=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%201-10","name":"10.rebuild-darwin: 1-10","color":"eeffee","default":false},{"id":731733923,"node_id":"MDU6TGFiZWw3MzE3MzM5MjM=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%201-10","name":"10.rebuild-linux: 1-10","color":"eeffee","default":false},{"id":290122819,"node_id":"MDU6TGFiZWwyOTAxMjI4MTk=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20package%20(update)","name":"8.has: package (update)","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/48627/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/48627/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/48627/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/b0b94d45c0df63f89d7b4e6acb9c25b437f6a2c8","head":{"label":"dotlambda:restic-0.9.3","ref":"restic-0.9.3","sha":"b0b94d45c0df63f89d7b4e6acb9c25b437f6a2c8","user":{"login":"dotlambda","id":6806011,"node_id":"MDQ6VXNlcjY4MDYwMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/6806011?v=4","gravatar_id":"","url":"https://api.github.com/users/dotlambda","html_url":"https://github.com/dotlambda","followers_url":"https://api.github.com/users/dotlambda/followers","following_url":"https://api.github.com/users/dotlambda/following{/other_user}","gists_url":"https://api.github.com/users/dotlambda/gists{/gist_id}","starred_url":"https://api.github.com/users/dotlambda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotlambda/subscriptions","organizations_url":"https://api.github.com/users/dotlambda/orgs","repos_url":"https://api.github.com/users/dotlambda/repos","events_url":"https://api.github.com/users/dotlambda/events{/privacy}","received_events_url":"https://api.github.com/users/dotlambda/received_events","type":"User","site_admin":false},"repo":{"id":95651842,"node_id":"MDEwOlJlcG9zaXRvcnk5NTY1MTg0Mg==","name":"nixpkgs","full_name":"dotlambda/nixpkgs","private":false,"owner":{"login":"dotlambda","id":6806011,"node_id":"MDQ6VXNlcjY4MDYwMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/6806011?v=4","gravatar_id":"","url":"https://api.github.com/users/dotlambda","html_url":"https://github.com/dotlambda","followers_url":"https://api.github.com/users/dotlambda/followers","following_url":"https://api.github.com/users/dotlambda/following{/other_user}","gists_url":"https://api.github.com/users/dotlambda/gists{/gist_id}","starred_url":"https://api.github.com/users/dotlambda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotlambda/subscriptions","organizations_url":"https://api.github.com/users/dotlambda/orgs","repos_url":"https://api.github.com/users/dotlambda/repos","events_url":"https://api.github.com/users/dotlambda/events{/privacy}","received_events_url":"https://api.github.com/users/dotlambda/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dotlambda/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/dotlambda/nixpkgs","forks_url":"https://api.github.com/repos/dotlambda/nixpkgs/forks","keys_url":"https://api.github.com/repos/dotlambda/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotlambda/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotlambda/nixpkgs/teams","hooks_url":"https://api.github.com/repos/dotlambda/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/dotlambda/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/dotlambda/nixpkgs/events","assignees_url":"https://api.github.com/repos/dotlambda/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/dotlambda/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/dotlambda/nixpkgs/tags","blobs_url":"https://api.github.com/repos/dotlambda/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotlambda/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotlambda/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotlambda/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotlambda/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/dotlambda/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/dotlambda/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/dotlambda/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/dotlambda/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/dotlambda/nixpkgs/subscription","commits_url":"https://api.github.com/repos/dotlambda/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotlambda/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotlambda/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotlambda/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotlambda/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/dotlambda/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotlambda/nixpkgs/merges","archive_url":"https://api.github.com/repos/dotlambda/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotlambda/nixpkgs/downloads","issues_url":"https://api.github.com/repos/dotlambda/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/dotlambda/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/dotlambda/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/dotlambda/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotlambda/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/dotlambda/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/dotlambda/nixpkgs/deployments","created_at":"2017-06-28T09:21:37Z","updated_at":"2018-08-22T23:02:37Z","pushed_at":"2018-10-18T17:21:16Z","git_url":"git://github.com/dotlambda/nixpkgs.git","ssh_url":"git@github.com:dotlambda/nixpkgs.git","clone_url":"https://github.com/dotlambda/nixpkgs.git","svn_url":"https://github.com/dotlambda/nixpkgs","homepage":null,"size":794919,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"f6ded23889f652c6e46736eeb721104fbb92c888","user":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQyNzE2","name":"nixpkgs","full_name":"NixOS/nixpkgs","private":false,"owner":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-10-22T07:58:35Z","pushed_at":"2018-10-22T09:23:56Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":871366,"stargazers_count":2915,"watchers_count":2915,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3096,"mirror_url":null,"archived":false,"open_issues_count":3281,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3096,"open_issues":3281,"watchers":2915,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/48627"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/48627"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/48627"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/48627/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/48627/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/48627/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/b0b94d45c0df63f89d7b4e6acb9c25b437f6a2c8"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"dotlambda"}}