{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/jest/pulls/comments/223917242","pull_request_review_id":163162127,"id":223917242,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzkxNzI0Mg==","diff_hunk":"@@ -77,6 +77,12 @@ const jestAdapter = async (\n     runtime.requireModule(config.setupTestFrameworkScriptFile);\n   }\n \n+  if (config.setupTestsAfterJest.length) {","path":"packages/jest-circus/src/legacy_code_todo_rewrite/jest_adapter.js","position":4,"original_position":4,"commit_id":"af4ac93f23751c7367788bd3ffdb8735e6d92ec7","original_commit_id":"51fe135e086f48cadd42a19c31dc593343381131","user":{"login":"natealcedo","id":18214059,"node_id":"MDQ6VXNlcjE4MjE0MDU5","avatar_url":"https://avatars0.githubusercontent.com/u/18214059?v=4","gravatar_id":"","url":"https://api.github.com/users/natealcedo","html_url":"https://github.com/natealcedo","followers_url":"https://api.github.com/users/natealcedo/followers","following_url":"https://api.github.com/users/natealcedo/following{/other_user}","gists_url":"https://api.github.com/users/natealcedo/gists{/gist_id}","starred_url":"https://api.github.com/users/natealcedo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natealcedo/subscriptions","organizations_url":"https://api.github.com/users/natealcedo/orgs","repos_url":"https://api.github.com/users/natealcedo/repos","events_url":"https://api.github.com/users/natealcedo/events{/privacy}","received_events_url":"https://api.github.com/users/natealcedo/received_events","type":"User","site_admin":false},"body":"Just curious, how's the behaviour like if you pass in a wrong path to a file? Is that error handled or is that handled by the runtime. It would be good to gracefully handle that scenario","created_at":"2018-10-10T02:07:00Z","updated_at":"2018-10-10T02:07:00Z","html_url":"https://github.com/facebook/jest/pull/7119#discussion_r223917242","pull_request_url":"https://api.github.com/repos/facebook/jest/pulls/7119","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/facebook/jest/pulls/comments/223917242"},"html":{"href":"https://github.com/facebook/jest/pull/7119#discussion_r223917242"},"pull_request":{"href":"https://api.github.com/repos/facebook/jest/pulls/7119"}},"in_reply_to_id":223238919},"pull_request":{"url":"https://api.github.com/repos/facebook/jest/pulls/7119","id":220989901,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwOTg5OTAx","html_url":"https://github.com/facebook/jest/pull/7119","diff_url":"https://github.com/facebook/jest/pull/7119.diff","patch_url":"https://github.com/facebook/jest/pull/7119.patch","issue_url":"https://api.github.com/repos/facebook/jest/issues/7119","number":7119,"state":"open","locked":false,"title":"Setup before tests but after framework loads","user":{"login":"ddruker","id":12059877,"node_id":"MDQ6VXNlcjEyMDU5ODc3","avatar_url":"https://avatars1.githubusercontent.com/u/12059877?v=4","gravatar_id":"","url":"https://api.github.com/users/ddruker","html_url":"https://github.com/ddruker","followers_url":"https://api.github.com/users/ddruker/followers","following_url":"https://api.github.com/users/ddruker/following{/other_user}","gists_url":"https://api.github.com/users/ddruker/gists{/gist_id}","starred_url":"https://api.github.com/users/ddruker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddruker/subscriptions","organizations_url":"https://api.github.com/users/ddruker/orgs","repos_url":"https://api.github.com/users/ddruker/repos","events_url":"https://api.github.com/users/ddruker/events{/privacy}","received_events_url":"https://api.github.com/users/ddruker/received_events","type":"User","site_admin":false},"body":"## Summary\r\n\r\nCurrently the `setupTestFrameworkScriptFile` option only allows for a single module to be run before each test file is run but after the test framework has been loaded. The option only accepts a string, which is limited and could force someone to import multiple modules into a single file.\r\n\r\nThis PR will create a new configuration called `setupTestsAfterJest`, which is by default an empty array, that can accept multiple paths.\r\n\r\nCloses https://github.com/facebook/jest/issues/6942\r\n\r\n**Sample configuration**\r\n![sam](https://dha4w82d62smt.cloudfront.net/items/412X2a1s1g1n1q0c3c10/Image%202018-10-07%20at%207.34.37%20PM.png?X-CloudApp-Visitor-Id=2665712&v=abbdcb5b)\r\n\r\n## Test plan\r\n\r\nUpdated snapshot tests, unit tests and integration tests for configuration.\r\n","created_at":"2018-10-08T02:06:51Z","updated_at":"2018-10-10T02:07:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"39c21549b29ebcfdba068448f21ab130db9d2a78","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":847426897,"node_id":"MDU6TGFiZWw4NDc0MjY4OTc=","url":"https://api.github.com/repos/facebook/jest/labels/cla%20signed","name":"cla signed","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/jest/pulls/7119/commits","review_comments_url":"https://api.github.com/repos/facebook/jest/pulls/7119/comments","review_comment_url":"https://api.github.com/repos/facebook/jest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/jest/issues/7119/comments","statuses_url":"https://api.github.com/repos/facebook/jest/statuses/af4ac93f23751c7367788bd3ffdb8735e6d92ec7","head":{"label":"ddruker:enhancement/dd-extend-setup-test-after","ref":"enhancement/dd-extend-setup-test-after","sha":"af4ac93f23751c7367788bd3ffdb8735e6d92ec7","user":{"login":"ddruker","id":12059877,"node_id":"MDQ6VXNlcjEyMDU5ODc3","avatar_url":"https://avatars1.githubusercontent.com/u/12059877?v=4","gravatar_id":"","url":"https://api.github.com/users/ddruker","html_url":"https://github.com/ddruker","followers_url":"https://api.github.com/users/ddruker/followers","following_url":"https://api.github.com/users/ddruker/following{/other_user}","gists_url":"https://api.github.com/users/ddruker/gists{/gist_id}","starred_url":"https://api.github.com/users/ddruker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddruker/subscriptions","organizations_url":"https://api.github.com/users/ddruker/orgs","repos_url":"https://api.github.com/users/ddruker/repos","events_url":"https://api.github.com/users/ddruker/events{/privacy}","received_events_url":"https://api.github.com/users/ddruker/received_events","type":"User","site_admin":false},"repo":{"id":151001785,"node_id":"MDEwOlJlcG9zaXRvcnkxNTEwMDE3ODU=","name":"jest","full_name":"ddruker/jest","private":false,"owner":{"login":"ddruker","id":12059877,"node_id":"MDQ6VXNlcjEyMDU5ODc3","avatar_url":"https://avatars1.githubusercontent.com/u/12059877?v=4","gravatar_id":"","url":"https://api.github.com/users/ddruker","html_url":"https://github.com/ddruker","followers_url":"https://api.github.com/users/ddruker/followers","following_url":"https://api.github.com/users/ddruker/following{/other_user}","gists_url":"https://api.github.com/users/ddruker/gists{/gist_id}","starred_url":"https://api.github.com/users/ddruker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddruker/subscriptions","organizations_url":"https://api.github.com/users/ddruker/orgs","repos_url":"https://api.github.com/users/ddruker/repos","events_url":"https://api.github.com/users/ddruker/events{/privacy}","received_events_url":"https://api.github.com/users/ddruker/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ddruker/jest","description":"🃏 Delightful JavaScript Testing.","fork":true,"url":"https://api.github.com/repos/ddruker/jest","forks_url":"https://api.github.com/repos/ddruker/jest/forks","keys_url":"https://api.github.com/repos/ddruker/jest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ddruker/jest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ddruker/jest/teams","hooks_url":"https://api.github.com/repos/ddruker/jest/hooks","issue_events_url":"https://api.github.com/repos/ddruker/jest/issues/events{/number}","events_url":"https://api.github.com/repos/ddruker/jest/events","assignees_url":"https://api.github.com/repos/ddruker/jest/assignees{/user}","branches_url":"https://api.github.com/repos/ddruker/jest/branches{/branch}","tags_url":"https://api.github.com/repos/ddruker/jest/tags","blobs_url":"https://api.github.com/repos/ddruker/jest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ddruker/jest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ddruker/jest/git/refs{/sha}","trees_url":"https://api.github.com/repos/ddruker/jest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ddruker/jest/statuses/{sha}","languages_url":"https://api.github.com/repos/ddruker/jest/languages","stargazers_url":"https://api.github.com/repos/ddruker/jest/stargazers","contributors_url":"https://api.github.com/repos/ddruker/jest/contributors","subscribers_url":"https://api.github.com/repos/ddruker/jest/subscribers","subscription_url":"https://api.github.com/repos/ddruker/jest/subscription","commits_url":"https://api.github.com/repos/ddruker/jest/commits{/sha}","git_commits_url":"https://api.github.com/repos/ddruker/jest/git/commits{/sha}","comments_url":"https://api.github.com/repos/ddruker/jest/comments{/number}","issue_comment_url":"https://api.github.com/repos/ddruker/jest/issues/comments{/number}","contents_url":"https://api.github.com/repos/ddruker/jest/contents/{+path}","compare_url":"https://api.github.com/repos/ddruker/jest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ddruker/jest/merges","archive_url":"https://api.github.com/repos/ddruker/jest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ddruker/jest/downloads","issues_url":"https://api.github.com/repos/ddruker/jest/issues{/number}","pulls_url":"https://api.github.com/repos/ddruker/jest/pulls{/number}","milestones_url":"https://api.github.com/repos/ddruker/jest/milestones{/number}","notifications_url":"https://api.github.com/repos/ddruker/jest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ddruker/jest/labels{/name}","releases_url":"https://api.github.com/repos/ddruker/jest/releases{/id}","deployments_url":"https://api.github.com/repos/ddruker/jest/deployments","created_at":"2018-09-30T19:59:14Z","updated_at":"2018-09-30T19:59:20Z","pushed_at":"2018-10-08T03:27:56Z","git_url":"git://github.com/ddruker/jest.git","ssh_url":"git@github.com:ddruker/jest.git","clone_url":"https://github.com/ddruker/jest.git","svn_url":"https://github.com/ddruker/jest","homepage":"https://facebook.github.io/jest/","size":117076,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"2d972e5470c0e3365a2763279982ebf303136c0a","user":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":15062869,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA2Mjg2OQ==","name":"jest","full_name":"facebook/jest","private":false,"owner":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/facebook/jest","description":"🃏 Delightful JavaScript Testing.","fork":false,"url":"https://api.github.com/repos/facebook/jest","forks_url":"https://api.github.com/repos/facebook/jest/forks","keys_url":"https://api.github.com/repos/facebook/jest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/jest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/jest/teams","hooks_url":"https://api.github.com/repos/facebook/jest/hooks","issue_events_url":"https://api.github.com/repos/facebook/jest/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/jest/events","assignees_url":"https://api.github.com/repos/facebook/jest/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/jest/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/jest/tags","blobs_url":"https://api.github.com/repos/facebook/jest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/jest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/jest/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/jest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/jest/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/jest/languages","stargazers_url":"https://api.github.com/repos/facebook/jest/stargazers","contributors_url":"https://api.github.com/repos/facebook/jest/contributors","subscribers_url":"https://api.github.com/repos/facebook/jest/subscribers","subscription_url":"https://api.github.com/repos/facebook/jest/subscription","commits_url":"https://api.github.com/repos/facebook/jest/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/jest/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/jest/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/jest/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/jest/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/jest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/jest/merges","archive_url":"https://api.github.com/repos/facebook/jest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/jest/downloads","issues_url":"https://api.github.com/repos/facebook/jest/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/jest/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/jest/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/jest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/jest/labels{/name}","releases_url":"https://api.github.com/repos/facebook/jest/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/jest/deployments","created_at":"2013-12-10T00:18:04Z","updated_at":"2018-10-10T01:52:16Z","pushed_at":"2018-10-09T21:08:49Z","git_url":"git://github.com/facebook/jest.git","ssh_url":"git@github.com:facebook/jest.git","clone_url":"https://github.com/facebook/jest.git","svn_url":"https://github.com/facebook/jest","homepage":"https://facebook.github.io/jest/","size":117670,"stargazers_count":20876,"watchers_count":20876,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2737,"mirror_url":null,"archived":false,"open_issues_count":516,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2737,"open_issues":516,"watchers":20876,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/jest/pulls/7119"},"html":{"href":"https://github.com/facebook/jest/pull/7119"},"issue":{"href":"https://api.github.com/repos/facebook/jest/issues/7119"},"comments":{"href":"https://api.github.com/repos/facebook/jest/issues/7119/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/jest/pulls/7119/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/jest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/jest/pulls/7119/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/jest/statuses/af4ac93f23751c7367788bd3ffdb8735e6d92ec7"}},"author_association":"NONE"}}
{"actor":{"display_login":"natealcedo"}}