{"action":"created","comment":{"url":"https://api.github.com/repos/plotly/plotly.js/pulls/comments/215080058","pull_request_review_id":152269843,"id":215080058,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTA4MDA1OA==","diff_hunk":"@@ -6,12 +6,15 @@\n     \"opacity\": 0.7\n   }, {\n     \"type\": \"barpolar\",\n-    \"r\": [1, 2, 3],\n-    \"theta\": [180, 90, 360],\n-    \"opacity\": 0.7\n+    \"r\": [3, 3],\n+    \"theta\": [0, 45],\n+    \"opacity\": 0.7,\n+    \"marker\": {\n+      \"line\": {\"width\": 5}","path":"test/image/mocks/polar_bar-overlay.json","position":13,"original_position":11,"commit_id":"183b73490bf5eabc1914efefb451d731e48771b8","original_commit_id":"183b73490bf5eabc1914efefb451d731e48771b8","user":{"login":"etpinard","id":6675409,"node_id":"MDQ6VXNlcjY2NzU0MDk=","avatar_url":"https://avatars0.githubusercontent.com/u/6675409?v=4","gravatar_id":"","url":"https://api.github.com/users/etpinard","html_url":"https://github.com/etpinard","followers_url":"https://api.github.com/users/etpinard/followers","following_url":"https://api.github.com/users/etpinard/following{/other_user}","gists_url":"https://api.github.com/users/etpinard/gists{/gist_id}","starred_url":"https://api.github.com/users/etpinard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etpinard/subscriptions","organizations_url":"https://api.github.com/users/etpinard/orgs","repos_url":"https://api.github.com/users/etpinard/repos","events_url":"https://api.github.com/users/etpinard/events{/privacy}","received_events_url":"https://api.github.com/users/etpinard/received_events","type":"User","site_admin":false},"body":"which looks like\r\n\r\n![image](https://user-images.githubusercontent.com/6675409/45059971-087a7600-b06c-11e8-8dfa-d7855ada6fd5.png)\r\n\r\ncloseup\r\n\r\n![image](https://user-images.githubusercontent.com/6675409/45059983-0e705700-b06c-11e8-92a8-b1953a69dc6b.png)\r\n\r\nwith the default `stroke-mitelimit`.","created_at":"2018-09-04T21:58:25Z","updated_at":"2018-09-04T21:58:25Z","html_url":"https://github.com/plotly/plotly.js/pull/2954#discussion_r215080058","pull_request_url":"https://api.github.com/repos/plotly/plotly.js/pulls/2954","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/plotly/plotly.js/pulls/comments/215080058"},"html":{"href":"https://github.com/plotly/plotly.js/pull/2954#discussion_r215080058"},"pull_request":{"href":"https://api.github.com/repos/plotly/plotly.js/pulls/2954"}}},"pull_request":{"url":"https://api.github.com/repos/plotly/plotly.js/pulls/2954","id":211869574,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExODY5NTc0","html_url":"https://github.com/plotly/plotly.js/pull/2954","diff_url":"https://github.com/plotly/plotly.js/pull/2954.diff","patch_url":"https://github.com/plotly/plotly.js/pull/2954.patch","issue_url":"https://api.github.com/repos/plotly/plotly.js/issues/2954","number":2954,"state":"open","locked":false,"title":"Add barpolar traces","user":{"login":"etpinard","id":6675409,"node_id":"MDQ6VXNlcjY2NzU0MDk=","avatar_url":"https://avatars0.githubusercontent.com/u/6675409?v=4","gravatar_id":"","url":"https://api.github.com/users/etpinard","html_url":"https://github.com/etpinard","followers_url":"https://api.github.com/users/etpinard/followers","following_url":"https://api.github.com/users/etpinard/following{/other_user}","gists_url":"https://api.github.com/users/etpinard/gists{/gist_id}","starred_url":"https://api.github.com/users/etpinard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etpinard/subscriptions","organizations_url":"https://api.github.com/users/etpinard/orgs","repos_url":"https://api.github.com/users/etpinard/repos","events_url":"https://api.github.com/users/etpinard/events{/privacy}","received_events_url":"https://api.github.com/users/etpinard/received_events","type":"User","site_admin":false},"body":"resolves https://github.com/plotly/plotly.js/issues/2810 (not everything item on there, but enough to replace legacy polar's `area` trace type)\r\n\r\nSay hello to Polar 2.0's version of 'area' traces: `barpolar`. As discussed previously, this trace type is \"really\" like a bar chart but in polar coordinates, hence its name. Here's a much-awaited updated version of our [wind rose example](https://plot.ly/javascript/wind-rose-charts/):\r\n\r\n![peek 2018-08-29 15-50](https://user-images.githubusercontent.com/6675409/44811741-69eda100-aba3-11e8-88ba-72bff6f99ba0.gif)\r\n\r\n\r\nMoreover, `barpolar` isn't just \"really like\" `bar` from a user's standpoint, but also from a dev's standpoint: I was able to reuse almost all of `Bar.crossTraceCalc` (formally known as `Bar.setPositions`), its default logic is a mix of `ScatterPolar` and `Bar` routines.\r\n\r\nThe _hard_ part about this PR was to keep everything DRY. Many path-drawing routines in `plots/polar.js` had to be generalized in order to be used in `BarPolar.plot`. See commits https://github.com/plotly/plotly.js/commit/4d203883d35995047dad83737da5c645defdda99, https://github.com/plotly/plotly.js/commit/95119c455dd86eb87ccf8560bbf724780d8084cb and https://github.com/plotly/plotly.js/commit/facb2f8e57948ac9615d9113c592a279959b2bc3 for more details.\r\n\r\nIn brief, this first version of `barpolar`, includes support for:\r\n- barmode stacked and overlay\r\n- bar width, offset and base\r\n- per-subplot bargap\r\n- `hovermode: 'closest'`, selections\r\n\r\nBut, does not implement:\r\n- orientation 'angular'\r\n- on-graph text\r\n\r\n\r\ncc @alexcjohnson @antoinerg\r\n","created_at":"2018-08-29T19:58:49Z","updated_at":"2018-09-04T21:58:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3a6fe27f6e51770ebb00d1eda5aeed2bee427738","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":330750748,"node_id":"MDU6TGFiZWwzMzA3NTA3NDg=","url":"https://api.github.com/repos/plotly/plotly.js/labels/status:%20reviewable","name":"status: reviewable","color":"33a02c","default":false},{"id":282886923,"node_id":"MDU6TGFiZWwyODI4ODY5MjM=","url":"https://api.github.com/repos/plotly/plotly.js/labels/type:%20bug","name":"type: bug","color":"e31a1c","default":false},{"id":282886925,"node_id":"MDU6TGFiZWwyODI4ODY5MjU=","url":"https://api.github.com/repos/plotly/plotly.js/labels/type:%20feature","name":"type: feature","color":"1f78b4","default":false}],"milestone":{"url":"https://api.github.com/repos/plotly/plotly.js/milestones/37","html_url":"https://github.com/plotly/plotly.js/milestone/37","labels_url":"https://api.github.com/repos/plotly/plotly.js/milestones/37/labels","id":3583715,"node_id":"MDk6TWlsZXN0b25lMzU4MzcxNQ==","number":37,"title":"v1.41.0","description":"","creator":{"login":"etpinard","id":6675409,"node_id":"MDQ6VXNlcjY2NzU0MDk=","avatar_url":"https://avatars0.githubusercontent.com/u/6675409?v=4","gravatar_id":"","url":"https://api.github.com/users/etpinard","html_url":"https://github.com/etpinard","followers_url":"https://api.github.com/users/etpinard/followers","following_url":"https://api.github.com/users/etpinard/following{/other_user}","gists_url":"https://api.github.com/users/etpinard/gists{/gist_id}","starred_url":"https://api.github.com/users/etpinard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etpinard/subscriptions","organizations_url":"https://api.github.com/users/etpinard/orgs","repos_url":"https://api.github.com/users/etpinard/repos","events_url":"https://api.github.com/users/etpinard/events{/privacy}","received_events_url":"https://api.github.com/users/etpinard/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":3,"state":"open","created_at":"2018-08-20T14:07:46Z","updated_at":"2018-09-04T15:56:16Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/plotly/plotly.js/pulls/2954/commits","review_comments_url":"https://api.github.com/repos/plotly/plotly.js/pulls/2954/comments","review_comment_url":"https://api.github.com/repos/plotly/plotly.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/plotly/plotly.js/issues/2954/comments","statuses_url":"https://api.github.com/repos/plotly/plotly.js/statuses/183b73490bf5eabc1914efefb451d731e48771b8","head":{"label":"plotly:barpolar-traces","ref":"barpolar-traces","sha":"183b73490bf5eabc1914efefb451d731e48771b8","user":{"login":"plotly","id":5997976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5OTc5NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/5997976?v=4","gravatar_id":"","url":"https://api.github.com/users/plotly","html_url":"https://github.com/plotly","followers_url":"https://api.github.com/users/plotly/followers","following_url":"https://api.github.com/users/plotly/following{/other_user}","gists_url":"https://api.github.com/users/plotly/gists{/gist_id}","starred_url":"https://api.github.com/users/plotly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plotly/subscriptions","organizations_url":"https://api.github.com/users/plotly/orgs","repos_url":"https://api.github.com/users/plotly/repos","events_url":"https://api.github.com/users/plotly/events{/privacy}","received_events_url":"https://api.github.com/users/plotly/received_events","type":"Organization","site_admin":false},"repo":{"id":45646037,"node_id":"MDEwOlJlcG9zaXRvcnk0NTY0NjAzNw==","name":"plotly.js","full_name":"plotly/plotly.js","owner":{"login":"plotly","id":5997976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5OTc5NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/5997976?v=4","gravatar_id":"","url":"https://api.github.com/users/plotly","html_url":"https://github.com/plotly","followers_url":"https://api.github.com/users/plotly/followers","following_url":"https://api.github.com/users/plotly/following{/other_user}","gists_url":"https://api.github.com/users/plotly/gists{/gist_id}","starred_url":"https://api.github.com/users/plotly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plotly/subscriptions","organizations_url":"https://api.github.com/users/plotly/orgs","repos_url":"https://api.github.com/users/plotly/repos","events_url":"https://api.github.com/users/plotly/events{/privacy}","received_events_url":"https://api.github.com/users/plotly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/plotly/plotly.js","description":"The open source JavaScript graphing library that powers plotly","fork":false,"url":"https://api.github.com/repos/plotly/plotly.js","forks_url":"https://api.github.com/repos/plotly/plotly.js/forks","keys_url":"https://api.github.com/repos/plotly/plotly.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plotly/plotly.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plotly/plotly.js/teams","hooks_url":"https://api.github.com/repos/plotly/plotly.js/hooks","issue_events_url":"https://api.github.com/repos/plotly/plotly.js/issues/events{/number}","events_url":"https://api.github.com/repos/plotly/plotly.js/events","assignees_url":"https://api.github.com/repos/plotly/plotly.js/assignees{/user}","branches_url":"https://api.github.com/repos/plotly/plotly.js/branches{/branch}","tags_url":"https://api.github.com/repos/plotly/plotly.js/tags","blobs_url":"https://api.github.com/repos/plotly/plotly.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plotly/plotly.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plotly/plotly.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/plotly/plotly.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plotly/plotly.js/statuses/{sha}","languages_url":"https://api.github.com/repos/plotly/plotly.js/languages","stargazers_url":"https://api.github.com/repos/plotly/plotly.js/stargazers","contributors_url":"https://api.github.com/repos/plotly/plotly.js/contributors","subscribers_url":"https://api.github.com/repos/plotly/plotly.js/subscribers","subscription_url":"https://api.github.com/repos/plotly/plotly.js/subscription","commits_url":"https://api.github.com/repos/plotly/plotly.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/plotly/plotly.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/plotly/plotly.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/plotly/plotly.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/plotly/plotly.js/contents/{+path}","compare_url":"https://api.github.com/repos/plotly/plotly.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plotly/plotly.js/merges","archive_url":"https://api.github.com/repos/plotly/plotly.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plotly/plotly.js/downloads","issues_url":"https://api.github.com/repos/plotly/plotly.js/issues{/number}","pulls_url":"https://api.github.com/repos/plotly/plotly.js/pulls{/number}","milestones_url":"https://api.github.com/repos/plotly/plotly.js/milestones{/number}","notifications_url":"https://api.github.com/repos/plotly/plotly.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plotly/plotly.js/labels{/name}","releases_url":"https://api.github.com/repos/plotly/plotly.js/releases{/id}","deployments_url":"https://api.github.com/repos/plotly/plotly.js/deployments","created_at":"2015-11-05T23:27:17Z","updated_at":"2018-09-04T15:56:22Z","pushed_at":"2018-09-04T21:56:23Z","git_url":"git://github.com/plotly/plotly.js.git","ssh_url":"git@github.com:plotly/plotly.js.git","clone_url":"https://github.com/plotly/plotly.js.git","svn_url":"https://github.com/plotly/plotly.js","homepage":"https://plot.ly/javascript/","size":445790,"stargazers_count":8843,"watchers_count":8843,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1013,"mirror_url":null,"archived":false,"open_issues_count":559,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1013,"open_issues":559,"watchers":8843,"default_branch":"master"}},"base":{"label":"plotly:master","ref":"master","sha":"19f3800bac848e702948fcc32302ded56ea1cdb7","user":{"login":"plotly","id":5997976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5OTc5NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/5997976?v=4","gravatar_id":"","url":"https://api.github.com/users/plotly","html_url":"https://github.com/plotly","followers_url":"https://api.github.com/users/plotly/followers","following_url":"https://api.github.com/users/plotly/following{/other_user}","gists_url":"https://api.github.com/users/plotly/gists{/gist_id}","starred_url":"https://api.github.com/users/plotly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plotly/subscriptions","organizations_url":"https://api.github.com/users/plotly/orgs","repos_url":"https://api.github.com/users/plotly/repos","events_url":"https://api.github.com/users/plotly/events{/privacy}","received_events_url":"https://api.github.com/users/plotly/received_events","type":"Organization","site_admin":false},"repo":{"id":45646037,"node_id":"MDEwOlJlcG9zaXRvcnk0NTY0NjAzNw==","name":"plotly.js","full_name":"plotly/plotly.js","owner":{"login":"plotly","id":5997976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5OTc5NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/5997976?v=4","gravatar_id":"","url":"https://api.github.com/users/plotly","html_url":"https://github.com/plotly","followers_url":"https://api.github.com/users/plotly/followers","following_url":"https://api.github.com/users/plotly/following{/other_user}","gists_url":"https://api.github.com/users/plotly/gists{/gist_id}","starred_url":"https://api.github.com/users/plotly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plotly/subscriptions","organizations_url":"https://api.github.com/users/plotly/orgs","repos_url":"https://api.github.com/users/plotly/repos","events_url":"https://api.github.com/users/plotly/events{/privacy}","received_events_url":"https://api.github.com/users/plotly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/plotly/plotly.js","description":"The open source JavaScript graphing library that powers plotly","fork":false,"url":"https://api.github.com/repos/plotly/plotly.js","forks_url":"https://api.github.com/repos/plotly/plotly.js/forks","keys_url":"https://api.github.com/repos/plotly/plotly.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plotly/plotly.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plotly/plotly.js/teams","hooks_url":"https://api.github.com/repos/plotly/plotly.js/hooks","issue_events_url":"https://api.github.com/repos/plotly/plotly.js/issues/events{/number}","events_url":"https://api.github.com/repos/plotly/plotly.js/events","assignees_url":"https://api.github.com/repos/plotly/plotly.js/assignees{/user}","branches_url":"https://api.github.com/repos/plotly/plotly.js/branches{/branch}","tags_url":"https://api.github.com/repos/plotly/plotly.js/tags","blobs_url":"https://api.github.com/repos/plotly/plotly.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plotly/plotly.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plotly/plotly.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/plotly/plotly.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plotly/plotly.js/statuses/{sha}","languages_url":"https://api.github.com/repos/plotly/plotly.js/languages","stargazers_url":"https://api.github.com/repos/plotly/plotly.js/stargazers","contributors_url":"https://api.github.com/repos/plotly/plotly.js/contributors","subscribers_url":"https://api.github.com/repos/plotly/plotly.js/subscribers","subscription_url":"https://api.github.com/repos/plotly/plotly.js/subscription","commits_url":"https://api.github.com/repos/plotly/plotly.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/plotly/plotly.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/plotly/plotly.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/plotly/plotly.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/plotly/plotly.js/contents/{+path}","compare_url":"https://api.github.com/repos/plotly/plotly.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plotly/plotly.js/merges","archive_url":"https://api.github.com/repos/plotly/plotly.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plotly/plotly.js/downloads","issues_url":"https://api.github.com/repos/plotly/plotly.js/issues{/number}","pulls_url":"https://api.github.com/repos/plotly/plotly.js/pulls{/number}","milestones_url":"https://api.github.com/repos/plotly/plotly.js/milestones{/number}","notifications_url":"https://api.github.com/repos/plotly/plotly.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plotly/plotly.js/labels{/name}","releases_url":"https://api.github.com/repos/plotly/plotly.js/releases{/id}","deployments_url":"https://api.github.com/repos/plotly/plotly.js/deployments","created_at":"2015-11-05T23:27:17Z","updated_at":"2018-09-04T15:56:22Z","pushed_at":"2018-09-04T21:56:23Z","git_url":"git://github.com/plotly/plotly.js.git","ssh_url":"git@github.com:plotly/plotly.js.git","clone_url":"https://github.com/plotly/plotly.js.git","svn_url":"https://github.com/plotly/plotly.js","homepage":"https://plot.ly/javascript/","size":445790,"stargazers_count":8843,"watchers_count":8843,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1013,"mirror_url":null,"archived":false,"open_issues_count":559,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1013,"open_issues":559,"watchers":8843,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/plotly/plotly.js/pulls/2954"},"html":{"href":"https://github.com/plotly/plotly.js/pull/2954"},"issue":{"href":"https://api.github.com/repos/plotly/plotly.js/issues/2954"},"comments":{"href":"https://api.github.com/repos/plotly/plotly.js/issues/2954/comments"},"review_comments":{"href":"https://api.github.com/repos/plotly/plotly.js/pulls/2954/comments"},"review_comment":{"href":"https://api.github.com/repos/plotly/plotly.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/plotly/plotly.js/pulls/2954/commits"},"statuses":{"href":"https://api.github.com/repos/plotly/plotly.js/statuses/183b73490bf5eabc1914efefb451d731e48771b8"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"etpinard"}}