{"action":"created","comment":{"url":"https://api.github.com/repos/prestodb/presto/pulls/comments/189287318","pull_request_review_id":121442555,"id":189287318,"diff_hunk":"@@ -256,13 +255,59 @@ public static Block geometryToBingTiles(@SqlType(GEOMETRY_TYPE_NAME) Slice input\n             // tile covered by the geometry.\n             BingTile[] tiles = getTilesInBetween(leftUpperTile, rightLowerTile, OPTIMIZED_TILING_MIN_ZOOM_LEVEL);","path":"presto-geospatial/src/main/java/com/facebook/presto/plugin/geospatial/BingTileFunctions.java","position":81,"original_position":64,"commit_id":"610d31538fd8311fa26ec2b462f5fa40d874a1c0","original_commit_id":"b0653d5304d5b3406df99d3de10b9608476fa808","user":{"login":"arhimondr","id":5570988,"avatar_url":"https://avatars3.githubusercontent.com/u/5570988?v=4","gravatar_id":"","url":"https://api.github.com/users/arhimondr","html_url":"https://github.com/arhimondr","followers_url":"https://api.github.com/users/arhimondr/followers","following_url":"https://api.github.com/users/arhimondr/following{/other_user}","gists_url":"https://api.github.com/users/arhimondr/gists{/gist_id}","starred_url":"https://api.github.com/users/arhimondr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arhimondr/subscriptions","organizations_url":"https://api.github.com/users/arhimondr/orgs","repos_url":"https://api.github.com/users/arhimondr/repos","events_url":"https://api.github.com/users/arhimondr/events{/privacy}","received_events_url":"https://api.github.com/users/arhimondr/received_events","type":"User","site_admin":false},"body":"The name of the method is fine. I was talking about the variable name. But even so, i don't have a strong opinion here.","created_at":"2018-05-18T14:30:00Z","updated_at":"2018-05-18T14:30:00Z","html_url":"https://github.com/prestodb/presto/pull/10627#discussion_r189287318","pull_request_url":"https://api.github.com/repos/prestodb/presto/pulls/10627","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments/189287318"},"html":{"href":"https://github.com/prestodb/presto/pull/10627#discussion_r189287318"},"pull_request":{"href":"https://api.github.com/repos/prestodb/presto/pulls/10627"}},"in_reply_to_id":189093306},"pull_request":{"url":"https://api.github.com/repos/prestodb/presto/pulls/10627","id":188608986,"html_url":"https://github.com/prestodb/presto/pull/10627","diff_url":"https://github.com/prestodb/presto/pull/10627.diff","patch_url":"https://github.com/prestodb/presto/pull/10627.patch","issue_url":"https://api.github.com/repos/prestodb/presto/issues/10627","number":10627,"state":"open","locked":false,"title":"Fix geometry_to_bing_tiles function for geometry collections","user":{"login":"mbasmanova","id":27965151,"avatar_url":"https://avatars3.githubusercontent.com/u/27965151?v=4","gravatar_id":"","url":"https://api.github.com/users/mbasmanova","html_url":"https://github.com/mbasmanova","followers_url":"https://api.github.com/users/mbasmanova/followers","following_url":"https://api.github.com/users/mbasmanova/following{/other_user}","gists_url":"https://api.github.com/users/mbasmanova/gists{/gist_id}","starred_url":"https://api.github.com/users/mbasmanova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbasmanova/subscriptions","organizations_url":"https://api.github.com/users/mbasmanova/orgs","repos_url":"https://api.github.com/users/mbasmanova/repos","events_url":"https://api.github.com/users/mbasmanova/events{/privacy}","received_events_url":"https://api.github.com/users/mbasmanova/received_events","type":"User","site_admin":false},"body":"Fix NPE in geometry_to_bing_tiles function when input is a geometry collection.\r\n\r\nFixes #10623","created_at":"2018-05-17T02:36:59Z","updated_at":"2018-05-18T14:30:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67d19e9e907371d6d5e15ee7bb107b75d925dfbf","assignee":null,"assignees":[],"requested_reviewers":[{"login":"nezihyigitbasi","id":1223839,"avatar_url":"https://avatars3.githubusercontent.com/u/1223839?v=4","gravatar_id":"","url":"https://api.github.com/users/nezihyigitbasi","html_url":"https://github.com/nezihyigitbasi","followers_url":"https://api.github.com/users/nezihyigitbasi/followers","following_url":"https://api.github.com/users/nezihyigitbasi/following{/other_user}","gists_url":"https://api.github.com/users/nezihyigitbasi/gists{/gist_id}","starred_url":"https://api.github.com/users/nezihyigitbasi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nezihyigitbasi/subscriptions","organizations_url":"https://api.github.com/users/nezihyigitbasi/orgs","repos_url":"https://api.github.com/users/nezihyigitbasi/repos","events_url":"https://api.github.com/users/nezihyigitbasi/events{/privacy}","received_events_url":"https://api.github.com/users/nezihyigitbasi/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":196992743,"url":"https://api.github.com/repos/prestodb/presto/labels/CLA%20Signed","name":"CLA Signed","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/prestodb/presto/pulls/10627/commits","review_comments_url":"https://api.github.com/repos/prestodb/presto/pulls/10627/comments","review_comment_url":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prestodb/presto/issues/10627/comments","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/610d31538fd8311fa26ec2b462f5fa40d874a1c0","head":{"label":"mbasmanova:fix-geometry-to-bing-tiles","ref":"fix-geometry-to-bing-tiles","sha":"610d31538fd8311fa26ec2b462f5fa40d874a1c0","user":{"login":"mbasmanova","id":27965151,"avatar_url":"https://avatars3.githubusercontent.com/u/27965151?v=4","gravatar_id":"","url":"https://api.github.com/users/mbasmanova","html_url":"https://github.com/mbasmanova","followers_url":"https://api.github.com/users/mbasmanova/followers","following_url":"https://api.github.com/users/mbasmanova/following{/other_user}","gists_url":"https://api.github.com/users/mbasmanova/gists{/gist_id}","starred_url":"https://api.github.com/users/mbasmanova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbasmanova/subscriptions","organizations_url":"https://api.github.com/users/mbasmanova/orgs","repos_url":"https://api.github.com/users/mbasmanova/repos","events_url":"https://api.github.com/users/mbasmanova/events{/privacy}","received_events_url":"https://api.github.com/users/mbasmanova/received_events","type":"User","site_admin":false},"repo":{"id":100315926,"name":"presto","full_name":"mbasmanova/presto","owner":{"login":"mbasmanova","id":27965151,"avatar_url":"https://avatars3.githubusercontent.com/u/27965151?v=4","gravatar_id":"","url":"https://api.github.com/users/mbasmanova","html_url":"https://github.com/mbasmanova","followers_url":"https://api.github.com/users/mbasmanova/followers","following_url":"https://api.github.com/users/mbasmanova/following{/other_user}","gists_url":"https://api.github.com/users/mbasmanova/gists{/gist_id}","starred_url":"https://api.github.com/users/mbasmanova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbasmanova/subscriptions","organizations_url":"https://api.github.com/users/mbasmanova/orgs","repos_url":"https://api.github.com/users/mbasmanova/repos","events_url":"https://api.github.com/users/mbasmanova/events{/privacy}","received_events_url":"https://api.github.com/users/mbasmanova/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mbasmanova/presto","description":"Distributed SQL query engine for big data","fork":true,"url":"https://api.github.com/repos/mbasmanova/presto","forks_url":"https://api.github.com/repos/mbasmanova/presto/forks","keys_url":"https://api.github.com/repos/mbasmanova/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mbasmanova/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mbasmanova/presto/teams","hooks_url":"https://api.github.com/repos/mbasmanova/presto/hooks","issue_events_url":"https://api.github.com/repos/mbasmanova/presto/issues/events{/number}","events_url":"https://api.github.com/repos/mbasmanova/presto/events","assignees_url":"https://api.github.com/repos/mbasmanova/presto/assignees{/user}","branches_url":"https://api.github.com/repos/mbasmanova/presto/branches{/branch}","tags_url":"https://api.github.com/repos/mbasmanova/presto/tags","blobs_url":"https://api.github.com/repos/mbasmanova/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mbasmanova/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mbasmanova/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/mbasmanova/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mbasmanova/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/mbasmanova/presto/languages","stargazers_url":"https://api.github.com/repos/mbasmanova/presto/stargazers","contributors_url":"https://api.github.com/repos/mbasmanova/presto/contributors","subscribers_url":"https://api.github.com/repos/mbasmanova/presto/subscribers","subscription_url":"https://api.github.com/repos/mbasmanova/presto/subscription","commits_url":"https://api.github.com/repos/mbasmanova/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/mbasmanova/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/mbasmanova/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/mbasmanova/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/mbasmanova/presto/contents/{+path}","compare_url":"https://api.github.com/repos/mbasmanova/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mbasmanova/presto/merges","archive_url":"https://api.github.com/repos/mbasmanova/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mbasmanova/presto/downloads","issues_url":"https://api.github.com/repos/mbasmanova/presto/issues{/number}","pulls_url":"https://api.github.com/repos/mbasmanova/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/mbasmanova/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/mbasmanova/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mbasmanova/presto/labels{/name}","releases_url":"https://api.github.com/repos/mbasmanova/presto/releases{/id}","deployments_url":"https://api.github.com/repos/mbasmanova/presto/deployments","created_at":"2017-08-14T22:58:12Z","updated_at":"2018-05-18T14:28:36Z","pushed_at":"2018-05-18T14:28:34Z","git_url":"git://github.com/mbasmanova/presto.git","ssh_url":"git@github.com:mbasmanova/presto.git","clone_url":"https://github.com/mbasmanova/presto.git","svn_url":"https://github.com/mbasmanova/presto","homepage":"https://prestodb.io","size":91397,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prestodb:master","ref":"master","sha":"67b7e4e192382ac8b9309e9e5f1d6973c3b1113b","user":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars0.githubusercontent.com/u/6882181?v=4","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"repo":{"id":5349565,"name":"presto","full_name":"prestodb/presto","owner":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars0.githubusercontent.com/u/6882181?v=4","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prestodb/presto","description":"Distributed SQL query engine for big data","fork":false,"url":"https://api.github.com/repos/prestodb/presto","forks_url":"https://api.github.com/repos/prestodb/presto/forks","keys_url":"https://api.github.com/repos/prestodb/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prestodb/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prestodb/presto/teams","hooks_url":"https://api.github.com/repos/prestodb/presto/hooks","issue_events_url":"https://api.github.com/repos/prestodb/presto/issues/events{/number}","events_url":"https://api.github.com/repos/prestodb/presto/events","assignees_url":"https://api.github.com/repos/prestodb/presto/assignees{/user}","branches_url":"https://api.github.com/repos/prestodb/presto/branches{/branch}","tags_url":"https://api.github.com/repos/prestodb/presto/tags","blobs_url":"https://api.github.com/repos/prestodb/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prestodb/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prestodb/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/prestodb/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/prestodb/presto/languages","stargazers_url":"https://api.github.com/repos/prestodb/presto/stargazers","contributors_url":"https://api.github.com/repos/prestodb/presto/contributors","subscribers_url":"https://api.github.com/repos/prestodb/presto/subscribers","subscription_url":"https://api.github.com/repos/prestodb/presto/subscription","commits_url":"https://api.github.com/repos/prestodb/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/prestodb/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/prestodb/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/prestodb/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/prestodb/presto/contents/{+path}","compare_url":"https://api.github.com/repos/prestodb/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prestodb/presto/merges","archive_url":"https://api.github.com/repos/prestodb/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prestodb/presto/downloads","issues_url":"https://api.github.com/repos/prestodb/presto/issues{/number}","pulls_url":"https://api.github.com/repos/prestodb/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/prestodb/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/prestodb/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prestodb/presto/labels{/name}","releases_url":"https://api.github.com/repos/prestodb/presto/releases{/id}","deployments_url":"https://api.github.com/repos/prestodb/presto/deployments","created_at":"2012-08-09T01:03:37Z","updated_at":"2018-05-18T13:37:56Z","pushed_at":"2018-05-18T11:08:37Z","git_url":"git://github.com/prestodb/presto.git","ssh_url":"git@github.com:prestodb/presto.git","clone_url":"https://github.com/prestodb/presto.git","svn_url":"https://github.com/prestodb/presto","homepage":"https://prestodb.io","size":91361,"stargazers_count":7503,"watchers_count":7503,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2526,"mirror_url":null,"archived":false,"open_issues_count":1292,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2526,"open_issues":1292,"watchers":7503,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/10627"},"html":{"href":"https://github.com/prestodb/presto/pull/10627"},"issue":{"href":"https://api.github.com/repos/prestodb/presto/issues/10627"},"comments":{"href":"https://api.github.com/repos/prestodb/presto/issues/10627/comments"},"review_comments":{"href":"https://api.github.com/repos/prestodb/presto/pulls/10627/comments"},"review_comment":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prestodb/presto/pulls/10627/commits"},"statuses":{"href":"https://api.github.com/repos/prestodb/presto/statuses/610d31538fd8311fa26ec2b462f5fa40d874a1c0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"arhimondr"}}