{"action":"created","comment":{"url":"https://api.github.com/repos/Hananel-Hazan/bindsnet/pulls/comments/235697874","pull_request_review_id":177622086,"id":235697874,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTY5Nzg3NA==","diff_hunk":"@@ -213,11 +212,11 @@ def step(self, a: int) -> Tuple[torch.Tensor, float, bool, Dict[Any, Any]]:\n         :return: Observation, reward, done flag, and information dictionary.\n         \"\"\"\n         # Call gym's environment step function.\n-        self.obs, self.reward, done, info = self.env.step(a)\n+        self.obs, self.reward, self.done, info = self.env.step(a)\n+        print(self.obs)","path":"bindsnet/environment/__init__.py","position":null,"original_position":58,"commit_id":"d09093b75c9ae0b40810ea1ed150586277c85c69","original_commit_id":"ba998c978cecbbf82550a18ab2f840fca0840d09","user":{"login":"djsaunde","id":1245942,"node_id":"MDQ6VXNlcjEyNDU5NDI=","avatar_url":"https://avatars3.githubusercontent.com/u/1245942?v=4","gravatar_id":"","url":"https://api.github.com/users/djsaunde","html_url":"https://github.com/djsaunde","followers_url":"https://api.github.com/users/djsaunde/followers","following_url":"https://api.github.com/users/djsaunde/following{/other_user}","gists_url":"https://api.github.com/users/djsaunde/gists{/gist_id}","starred_url":"https://api.github.com/users/djsaunde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djsaunde/subscriptions","organizations_url":"https://api.github.com/users/djsaunde/orgs","repos_url":"https://api.github.com/users/djsaunde/repos","events_url":"https://api.github.com/users/djsaunde/events{/privacy}","received_events_url":"https://api.github.com/users/djsaunde/received_events","type":"User","site_admin":false},"body":"Bump","created_at":"2018-11-22T11:51:04Z","updated_at":"2018-11-22T11:51:04Z","html_url":"https://github.com/Hananel-Hazan/bindsnet/pull/150#discussion_r235697874","pull_request_url":"https://api.github.com/repos/Hananel-Hazan/bindsnet/pulls/150","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Hananel-Hazan/bindsnet/pulls/comments/235697874"},"html":{"href":"https://github.com/Hananel-Hazan/bindsnet/pull/150#discussion_r235697874"},"pull_request":{"href":"https://api.github.com/repos/Hananel-Hazan/bindsnet/pulls/150"}},"in_reply_to_id":233817987},"pull_request":{"url":"https://api.github.com/repos/Hananel-Hazan/bindsnet/pulls/150","id":231071926,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMDcxOTI2","html_url":"https://github.com/Hananel-Hazan/bindsnet/pull/150","diff_url":"https://github.com/Hananel-Hazan/bindsnet/pull/150.diff","patch_url":"https://github.com/Hananel-Hazan/bindsnet/pull/150.patch","issue_url":"https://api.github.com/repos/Hananel-Hazan/bindsnet/issues/150","number":150,"state":"open","locked":false,"title":"Potential lowerbound, Sparse Encoding, Extending plot window, Line plotting,  Etc.","user":{"login":"godelicbach","id":24662250,"node_id":"MDQ6VXNlcjI0NjYyMjUw","avatar_url":"https://avatars3.githubusercontent.com/u/24662250?v=4","gravatar_id":"","url":"https://api.github.com/users/godelicbach","html_url":"https://github.com/godelicbach","followers_url":"https://api.github.com/users/godelicbach/followers","following_url":"https://api.github.com/users/godelicbach/following{/other_user}","gists_url":"https://api.github.com/users/godelicbach/gists{/gist_id}","starred_url":"https://api.github.com/users/godelicbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godelicbach/subscriptions","organizations_url":"https://api.github.com/users/godelicbach/orgs","repos_url":"https://api.github.com/users/godelicbach/repos","events_url":"https://api.github.com/users/godelicbach/events{/privacy}","received_events_url":"https://api.github.com/users/godelicbach/received_events","type":"User","site_admin":false},"body":"This is the first time I open pull request in github. There might be something mistake that I'm not aware of. Feel free to fix me. \r\n\r\nI've fixed some minor bugs and features. I'll list them below. \r\n\r\n**Features**\r\n1. Lower Bound \r\nI've implemented lower bound of membrane potential for LIFNodes. Whenever its v gets lower than lower bound, it's clipped to lower bound.\r\n\r\n2. Spars Encoding \r\nI've added two more encodings, namely, timing and single. Both are designed for DatasetEnvironment, not for GymEnvironment. Both encodings generates spike-train in which each neuron can only fire only single time or none. In timing encoding, the larger the input feature, the sooner the spike generated. In single encoding, there's no difference in spike timing. Neurons whose corresponding features has larger value than certain quantile will spike and other won't.\r\n\r\n3. Extending plot window \r\nUntil now, plot window of spike and voltage was limited as  plot_interval * time, which means there are no overlap between every plot. I found that this is not so intuitive to analyze the result. So I added new parameter plot_length, which controls the length of the plot window. For example, if plot_length==1.5, then 50% of the plot window would be overlapped with previous plot. \r\n\r\n4. Line Plotting\r\nPlotting voltage dynamics was done by using spectrogram-like pcolormesh so far. I found that this representation is  not intuitive too. Therefore I implemented line plotting mode. In this mode, voltage of each neuron will be plotted as line. Also, there will be a horizontal line which represents the threshold of that neuron layer so that one can clearly see which neuron was closed to firing. You can select between original representation, I named it 'color', and line plotting, called 'line' by using plot_type when you initialize pipeline.\r\n\r\nAnd I also fixed some minor bugs, for example, adding several lines of code for reshaping observation data in order to plot in 2D grayscale image. It worked fine in older version, but I found somehow it changed and not working properly. So I reverted that change. \r\n\r\nI'm sure there would be so many bugs and mistakes in my commit. It would be so thankful if you help me to get through them. ","created_at":"2018-11-15T05:21:39Z","updated_at":"2018-11-22T11:51:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Hananel-Hazan/bindsnet/pulls/150/commits","review_comments_url":"https://api.github.com/repos/Hananel-Hazan/bindsnet/pulls/150/comments","review_comment_url":"https://api.github.com/repos/Hananel-Hazan/bindsnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Hananel-Hazan/bindsnet/issues/150/comments","statuses_url":"https://api.github.com/repos/Hananel-Hazan/bindsnet/statuses/d09093b75c9ae0b40810ea1ed150586277c85c69","head":{"label":"godelicbach:PR","ref":"PR","sha":"d09093b75c9ae0b40810ea1ed150586277c85c69","user":{"login":"godelicbach","id":24662250,"node_id":"MDQ6VXNlcjI0NjYyMjUw","avatar_url":"https://avatars3.githubusercontent.com/u/24662250?v=4","gravatar_id":"","url":"https://api.github.com/users/godelicbach","html_url":"https://github.com/godelicbach","followers_url":"https://api.github.com/users/godelicbach/followers","following_url":"https://api.github.com/users/godelicbach/following{/other_user}","gists_url":"https://api.github.com/users/godelicbach/gists{/gist_id}","starred_url":"https://api.github.com/users/godelicbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godelicbach/subscriptions","organizations_url":"https://api.github.com/users/godelicbach/orgs","repos_url":"https://api.github.com/users/godelicbach/repos","events_url":"https://api.github.com/users/godelicbach/events{/privacy}","received_events_url":"https://api.github.com/users/godelicbach/received_events","type":"User","site_admin":false},"repo":{"id":151526856,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE1MjY4NTY=","name":"bindsnet","full_name":"godelicbach/bindsnet","private":false,"owner":{"login":"godelicbach","id":24662250,"node_id":"MDQ6VXNlcjI0NjYyMjUw","avatar_url":"https://avatars3.githubusercontent.com/u/24662250?v=4","gravatar_id":"","url":"https://api.github.com/users/godelicbach","html_url":"https://github.com/godelicbach","followers_url":"https://api.github.com/users/godelicbach/followers","following_url":"https://api.github.com/users/godelicbach/following{/other_user}","gists_url":"https://api.github.com/users/godelicbach/gists{/gist_id}","starred_url":"https://api.github.com/users/godelicbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godelicbach/subscriptions","organizations_url":"https://api.github.com/users/godelicbach/orgs","repos_url":"https://api.github.com/users/godelicbach/repos","events_url":"https://api.github.com/users/godelicbach/events{/privacy}","received_events_url":"https://api.github.com/users/godelicbach/received_events","type":"User","site_admin":false},"html_url":"https://github.com/godelicbach/bindsnet","description":"Simulation of spiking neural networks (SNNs) using PyTorch.","fork":true,"url":"https://api.github.com/repos/godelicbach/bindsnet","forks_url":"https://api.github.com/repos/godelicbach/bindsnet/forks","keys_url":"https://api.github.com/repos/godelicbach/bindsnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/godelicbach/bindsnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/godelicbach/bindsnet/teams","hooks_url":"https://api.github.com/repos/godelicbach/bindsnet/hooks","issue_events_url":"https://api.github.com/repos/godelicbach/bindsnet/issues/events{/number}","events_url":"https://api.github.com/repos/godelicbach/bindsnet/events","assignees_url":"https://api.github.com/repos/godelicbach/bindsnet/assignees{/user}","branches_url":"https://api.github.com/repos/godelicbach/bindsnet/branches{/branch}","tags_url":"https://api.github.com/repos/godelicbach/bindsnet/tags","blobs_url":"https://api.github.com/repos/godelicbach/bindsnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/godelicbach/bindsnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/godelicbach/bindsnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/godelicbach/bindsnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/godelicbach/bindsnet/statuses/{sha}","languages_url":"https://api.github.com/repos/godelicbach/bindsnet/languages","stargazers_url":"https://api.github.com/repos/godelicbach/bindsnet/stargazers","contributors_url":"https://api.github.com/repos/godelicbach/bindsnet/contributors","subscribers_url":"https://api.github.com/repos/godelicbach/bindsnet/subscribers","subscription_url":"https://api.github.com/repos/godelicbach/bindsnet/subscription","commits_url":"https://api.github.com/repos/godelicbach/bindsnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/godelicbach/bindsnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/godelicbach/bindsnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/godelicbach/bindsnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/godelicbach/bindsnet/contents/{+path}","compare_url":"https://api.github.com/repos/godelicbach/bindsnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/godelicbach/bindsnet/merges","archive_url":"https://api.github.com/repos/godelicbach/bindsnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/godelicbach/bindsnet/downloads","issues_url":"https://api.github.com/repos/godelicbach/bindsnet/issues{/number}","pulls_url":"https://api.github.com/repos/godelicbach/bindsnet/pulls{/number}","milestones_url":"https://api.github.com/repos/godelicbach/bindsnet/milestones{/number}","notifications_url":"https://api.github.com/repos/godelicbach/bindsnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/godelicbach/bindsnet/labels{/name}","releases_url":"https://api.github.com/repos/godelicbach/bindsnet/releases{/id}","deployments_url":"https://api.github.com/repos/godelicbach/bindsnet/deployments","created_at":"2018-10-04T06:15:46Z","updated_at":"2018-11-22T02:43:47Z","pushed_at":"2018-11-22T02:47:28Z","git_url":"git://github.com/godelicbach/bindsnet.git","ssh_url":"git@github.com:godelicbach/bindsnet.git","clone_url":"https://github.com/godelicbach/bindsnet.git","svn_url":"https://github.com/godelicbach/bindsnet","homepage":"","size":80109,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Hananel-Hazan:master","ref":"master","sha":"564318d13f0684d8491f7b18541342ad578e906c","user":{"login":"Hananel-Hazan","id":3954715,"node_id":"MDQ6VXNlcjM5NTQ3MTU=","avatar_url":"https://avatars2.githubusercontent.com/u/3954715?v=4","gravatar_id":"","url":"https://api.github.com/users/Hananel-Hazan","html_url":"https://github.com/Hananel-Hazan","followers_url":"https://api.github.com/users/Hananel-Hazan/followers","following_url":"https://api.github.com/users/Hananel-Hazan/following{/other_user}","gists_url":"https://api.github.com/users/Hananel-Hazan/gists{/gist_id}","starred_url":"https://api.github.com/users/Hananel-Hazan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hananel-Hazan/subscriptions","organizations_url":"https://api.github.com/users/Hananel-Hazan/orgs","repos_url":"https://api.github.com/users/Hananel-Hazan/repos","events_url":"https://api.github.com/users/Hananel-Hazan/events{/privacy}","received_events_url":"https://api.github.com/users/Hananel-Hazan/received_events","type":"User","site_admin":false},"repo":{"id":120948040,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA5NDgwNDA=","name":"bindsnet","full_name":"Hananel-Hazan/bindsnet","private":false,"owner":{"login":"Hananel-Hazan","id":3954715,"node_id":"MDQ6VXNlcjM5NTQ3MTU=","avatar_url":"https://avatars2.githubusercontent.com/u/3954715?v=4","gravatar_id":"","url":"https://api.github.com/users/Hananel-Hazan","html_url":"https://github.com/Hananel-Hazan","followers_url":"https://api.github.com/users/Hananel-Hazan/followers","following_url":"https://api.github.com/users/Hananel-Hazan/following{/other_user}","gists_url":"https://api.github.com/users/Hananel-Hazan/gists{/gist_id}","starred_url":"https://api.github.com/users/Hananel-Hazan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hananel-Hazan/subscriptions","organizations_url":"https://api.github.com/users/Hananel-Hazan/orgs","repos_url":"https://api.github.com/users/Hananel-Hazan/repos","events_url":"https://api.github.com/users/Hananel-Hazan/events{/privacy}","received_events_url":"https://api.github.com/users/Hananel-Hazan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Hananel-Hazan/bindsnet","description":"Simulation of spiking neural networks (SNNs) using PyTorch.","fork":false,"url":"https://api.github.com/repos/Hananel-Hazan/bindsnet","forks_url":"https://api.github.com/repos/Hananel-Hazan/bindsnet/forks","keys_url":"https://api.github.com/repos/Hananel-Hazan/bindsnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Hananel-Hazan/bindsnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Hananel-Hazan/bindsnet/teams","hooks_url":"https://api.github.com/repos/Hananel-Hazan/bindsnet/hooks","issue_events_url":"https://api.github.com/repos/Hananel-Hazan/bindsnet/issues/events{/number}","events_url":"https://api.github.com/repos/Hananel-Hazan/bindsnet/events","assignees_url":"https://api.github.com/repos/Hananel-Hazan/bindsnet/assignees{/user}","branches_url":"https://api.github.com/repos/Hananel-Hazan/bindsnet/branches{/branch}","tags_url":"https://api.github.com/repos/Hananel-Hazan/bindsnet/tags","blobs_url":"https://api.github.com/repos/Hananel-Hazan/bindsnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Hananel-Hazan/bindsnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Hananel-Hazan/bindsnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/Hananel-Hazan/bindsnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Hananel-Hazan/bindsnet/statuses/{sha}","languages_url":"https://api.github.com/repos/Hananel-Hazan/bindsnet/languages","stargazers_url":"https://api.github.com/repos/Hananel-Hazan/bindsnet/stargazers","contributors_url":"https://api.github.com/repos/Hananel-Hazan/bindsnet/contributors","subscribers_url":"https://api.github.com/repos/Hananel-Hazan/bindsnet/subscribers","subscription_url":"https://api.github.com/repos/Hananel-Hazan/bindsnet/subscription","commits_url":"https://api.github.com/repos/Hananel-Hazan/bindsnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/Hananel-Hazan/bindsnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/Hananel-Hazan/bindsnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/Hananel-Hazan/bindsnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/Hananel-Hazan/bindsnet/contents/{+path}","compare_url":"https://api.github.com/repos/Hananel-Hazan/bindsnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Hananel-Hazan/bindsnet/merges","archive_url":"https://api.github.com/repos/Hananel-Hazan/bindsnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Hananel-Hazan/bindsnet/downloads","issues_url":"https://api.github.com/repos/Hananel-Hazan/bindsnet/issues{/number}","pulls_url":"https://api.github.com/repos/Hananel-Hazan/bindsnet/pulls{/number}","milestones_url":"https://api.github.com/repos/Hananel-Hazan/bindsnet/milestones{/number}","notifications_url":"https://api.github.com/repos/Hananel-Hazan/bindsnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Hananel-Hazan/bindsnet/labels{/name}","releases_url":"https://api.github.com/repos/Hananel-Hazan/bindsnet/releases{/id}","deployments_url":"https://api.github.com/repos/Hananel-Hazan/bindsnet/deployments","created_at":"2018-02-09T19:42:37Z","updated_at":"2018-11-22T11:50:46Z","pushed_at":"2018-11-22T11:50:44Z","git_url":"git://github.com/Hananel-Hazan/bindsnet.git","ssh_url":"git@github.com:Hananel-Hazan/bindsnet.git","clone_url":"https://github.com/Hananel-Hazan/bindsnet.git","svn_url":"https://github.com/Hananel-Hazan/bindsnet","homepage":"","size":80111,"stargazers_count":188,"watchers_count":188,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":25,"open_issues":3,"watchers":188,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Hananel-Hazan/bindsnet/pulls/150"},"html":{"href":"https://github.com/Hananel-Hazan/bindsnet/pull/150"},"issue":{"href":"https://api.github.com/repos/Hananel-Hazan/bindsnet/issues/150"},"comments":{"href":"https://api.github.com/repos/Hananel-Hazan/bindsnet/issues/150/comments"},"review_comments":{"href":"https://api.github.com/repos/Hananel-Hazan/bindsnet/pulls/150/comments"},"review_comment":{"href":"https://api.github.com/repos/Hananel-Hazan/bindsnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Hananel-Hazan/bindsnet/pulls/150/commits"},"statuses":{"href":"https://api.github.com/repos/Hananel-Hazan/bindsnet/statuses/d09093b75c9ae0b40810ea1ed150586277c85c69"}},"author_association":"NONE"}}
{"actor":{"display_login":"djsaunde"}}