{"action":"created","comment":{"url":"https://api.github.com/repos/mysociety/alaveteli/pulls/comments/228229122","pull_request_review_id":168453695,"id":228229122,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODIyOTEyMg==","diff_hunk":"@@ -1045,10 +939,7 @@ def make_request\n                         create(:data => load_file_fixture(\"parrot.png\"),\n                                :user => user)\n \n-      post :set_profile_photo, { :id => user.id,\n-                                 :file => @uploadedfile,\n-                                 :submitted_crop_profile_photo => 1,\n-                                 :draft_profile_photo_id => profile_photo.id }\n+      post :set_profile_photo, params: { :id => user.id, :file => @uploadedfile, :submitted_crop_profile_photo => 1, :draft_profile_photo_id => profile_photo.id }","path":"spec/controllers/user_controller_spec.rb","position":639,"original_position":639,"commit_id":"a7ae70eb64ce828d5cd2f7d3441f37ed09800a3a","original_commit_id":"a7ae70eb64ce828d5cd2f7d3441f37ed09800a3a","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Line is too long. [162/80]","created_at":"2018-10-25T15:44:08Z","updated_at":"2018-10-25T15:44:09Z","html_url":"https://github.com/mysociety/alaveteli/pull/4900#discussion_r228229122","pull_request_url":"https://api.github.com/repos/mysociety/alaveteli/pulls/4900","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/mysociety/alaveteli/pulls/comments/228229122"},"html":{"href":"https://github.com/mysociety/alaveteli/pull/4900#discussion_r228229122"},"pull_request":{"href":"https://api.github.com/repos/mysociety/alaveteli/pulls/4900"}}},"pull_request":{"url":"https://api.github.com/repos/mysociety/alaveteli/pulls/4900","id":222478012,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNDc4MDEy","html_url":"https://github.com/mysociety/alaveteli/pull/4900","diff_url":"https://github.com/mysociety/alaveteli/pull/4900.diff","patch_url":"https://github.com/mysociety/alaveteli/pull/4900.patch","issue_url":"https://api.github.com/repos/mysociety/alaveteli/issues/4900","number":4900,"state":"open","locked":false,"title":"[Rails 5] Update functional test requests calls","user":{"login":"gbp","id":5426,"node_id":"MDQ6VXNlcjU0MjY=","avatar_url":"https://avatars1.githubusercontent.com/u/5426?v=4","gravatar_id":"","url":"https://api.github.com/users/gbp","html_url":"https://github.com/gbp","followers_url":"https://api.github.com/users/gbp/followers","following_url":"https://api.github.com/users/gbp/following{/other_user}","gists_url":"https://api.github.com/users/gbp/gists{/gist_id}","starred_url":"https://api.github.com/users/gbp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbp/subscriptions","organizations_url":"https://api.github.com/users/gbp/orgs","repos_url":"https://api.github.com/users/gbp/repos","events_url":"https://api.github.com/users/gbp/events{/privacy}","received_events_url":"https://api.github.com/users/gbp/received_events","type":"User","site_admin":false},"body":"## Relevant issue(s)\r\n\r\nConnects to #3969 \r\nRequires #4893 \r\n\r\n## What does this do?\r\n\r\nUpdates functional test requests calls to keyword argument style.\r\n\r\n## Why was this needed?\r\n\r\nSo many deprecation warnings without this its was impossible to see what is really broken.\r\n","created_at":"2018-10-12T14:05:10Z","updated_at":"2018-10-25T15:44:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9c0a8ef83f2c11ff06827cabdf3331c757f38926","assignee":{"login":"lizconlan","id":27760,"node_id":"MDQ6VXNlcjI3NzYw","avatar_url":"https://avatars2.githubusercontent.com/u/27760?v=4","gravatar_id":"","url":"https://api.github.com/users/lizconlan","html_url":"https://github.com/lizconlan","followers_url":"https://api.github.com/users/lizconlan/followers","following_url":"https://api.github.com/users/lizconlan/following{/other_user}","gists_url":"https://api.github.com/users/lizconlan/gists{/gist_id}","starred_url":"https://api.github.com/users/lizconlan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lizconlan/subscriptions","organizations_url":"https://api.github.com/users/lizconlan/orgs","repos_url":"https://api.github.com/users/lizconlan/repos","events_url":"https://api.github.com/users/lizconlan/events{/privacy}","received_events_url":"https://api.github.com/users/lizconlan/received_events","type":"User","site_admin":false},"assignees":[{"login":"lizconlan","id":27760,"node_id":"MDQ6VXNlcjI3NzYw","avatar_url":"https://avatars2.githubusercontent.com/u/27760?v=4","gravatar_id":"","url":"https://api.github.com/users/lizconlan","html_url":"https://github.com/lizconlan","followers_url":"https://api.github.com/users/lizconlan/followers","following_url":"https://api.github.com/users/lizconlan/following{/other_user}","gists_url":"https://api.github.com/users/lizconlan/gists{/gist_id}","starred_url":"https://api.github.com/users/lizconlan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lizconlan/subscriptions","organizations_url":"https://api.github.com/users/lizconlan/orgs","repos_url":"https://api.github.com/users/lizconlan/repos","events_url":"https://api.github.com/users/lizconlan/events{/privacy}","received_events_url":"https://api.github.com/users/lizconlan/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1088566717,"node_id":"MDU6TGFiZWwxMDg4NTY2NzE3","url":"https://api.github.com/repos/mysociety/alaveteli/labels/rebase%20required","name":"rebase required","color":"74e0e0","default":false}],"milestone":{"url":"https://api.github.com/repos/mysociety/alaveteli/milestones/52","html_url":"https://github.com/mysociety/alaveteli/milestone/52","labels_url":"https://api.github.com/repos/mysociety/alaveteli/milestones/52/labels","id":3732718,"node_id":"MDk6TWlsZXN0b25lMzczMjcxOA==","number":52,"title":"Rails 5","description":"","creator":{"login":"gbp","id":5426,"node_id":"MDQ6VXNlcjU0MjY=","avatar_url":"https://avatars1.githubusercontent.com/u/5426?v=4","gravatar_id":"","url":"https://api.github.com/users/gbp","html_url":"https://github.com/gbp","followers_url":"https://api.github.com/users/gbp/followers","following_url":"https://api.github.com/users/gbp/following{/other_user}","gists_url":"https://api.github.com/users/gbp/gists{/gist_id}","starred_url":"https://api.github.com/users/gbp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbp/subscriptions","organizations_url":"https://api.github.com/users/gbp/orgs","repos_url":"https://api.github.com/users/gbp/repos","events_url":"https://api.github.com/users/gbp/events{/privacy}","received_events_url":"https://api.github.com/users/gbp/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":4,"state":"open","created_at":"2018-10-12T09:03:19Z","updated_at":"2018-10-25T15:40:26Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/mysociety/alaveteli/pulls/4900/commits","review_comments_url":"https://api.github.com/repos/mysociety/alaveteli/pulls/4900/comments","review_comment_url":"https://api.github.com/repos/mysociety/alaveteli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mysociety/alaveteli/issues/4900/comments","statuses_url":"https://api.github.com/repos/mysociety/alaveteli/statuses/a7ae70eb64ce828d5cd2f7d3441f37ed09800a3a","head":{"label":"mysociety:rails-5/functional-test-requests","ref":"rails-5/functional-test-requests","sha":"a7ae70eb64ce828d5cd2f7d3441f37ed09800a3a","user":{"login":"mysociety","id":141338,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTMzOA==","avatar_url":"https://avatars1.githubusercontent.com/u/141338?v=4","gravatar_id":"","url":"https://api.github.com/users/mysociety","html_url":"https://github.com/mysociety","followers_url":"https://api.github.com/users/mysociety/followers","following_url":"https://api.github.com/users/mysociety/following{/other_user}","gists_url":"https://api.github.com/users/mysociety/gists{/gist_id}","starred_url":"https://api.github.com/users/mysociety/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mysociety/subscriptions","organizations_url":"https://api.github.com/users/mysociety/orgs","repos_url":"https://api.github.com/users/mysociety/repos","events_url":"https://api.github.com/users/mysociety/events{/privacy}","received_events_url":"https://api.github.com/users/mysociety/received_events","type":"Organization","site_admin":false},"repo":{"id":1125389,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI1Mzg5","name":"alaveteli","full_name":"mysociety/alaveteli","private":false,"owner":{"login":"mysociety","id":141338,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTMzOA==","avatar_url":"https://avatars1.githubusercontent.com/u/141338?v=4","gravatar_id":"","url":"https://api.github.com/users/mysociety","html_url":"https://github.com/mysociety","followers_url":"https://api.github.com/users/mysociety/followers","following_url":"https://api.github.com/users/mysociety/following{/other_user}","gists_url":"https://api.github.com/users/mysociety/gists{/gist_id}","starred_url":"https://api.github.com/users/mysociety/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mysociety/subscriptions","organizations_url":"https://api.github.com/users/mysociety/orgs","repos_url":"https://api.github.com/users/mysociety/repos","events_url":"https://api.github.com/users/mysociety/events{/privacy}","received_events_url":"https://api.github.com/users/mysociety/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mysociety/alaveteli","description":"Provide a Freedom of Information request system for your jurisdiction","fork":false,"url":"https://api.github.com/repos/mysociety/alaveteli","forks_url":"https://api.github.com/repos/mysociety/alaveteli/forks","keys_url":"https://api.github.com/repos/mysociety/alaveteli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mysociety/alaveteli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mysociety/alaveteli/teams","hooks_url":"https://api.github.com/repos/mysociety/alaveteli/hooks","issue_events_url":"https://api.github.com/repos/mysociety/alaveteli/issues/events{/number}","events_url":"https://api.github.com/repos/mysociety/alaveteli/events","assignees_url":"https://api.github.com/repos/mysociety/alaveteli/assignees{/user}","branches_url":"https://api.github.com/repos/mysociety/alaveteli/branches{/branch}","tags_url":"https://api.github.com/repos/mysociety/alaveteli/tags","blobs_url":"https://api.github.com/repos/mysociety/alaveteli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mysociety/alaveteli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mysociety/alaveteli/git/refs{/sha}","trees_url":"https://api.github.com/repos/mysociety/alaveteli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mysociety/alaveteli/statuses/{sha}","languages_url":"https://api.github.com/repos/mysociety/alaveteli/languages","stargazers_url":"https://api.github.com/repos/mysociety/alaveteli/stargazers","contributors_url":"https://api.github.com/repos/mysociety/alaveteli/contributors","subscribers_url":"https://api.github.com/repos/mysociety/alaveteli/subscribers","subscription_url":"https://api.github.com/repos/mysociety/alaveteli/subscription","commits_url":"https://api.github.com/repos/mysociety/alaveteli/commits{/sha}","git_commits_url":"https://api.github.com/repos/mysociety/alaveteli/git/commits{/sha}","comments_url":"https://api.github.com/repos/mysociety/alaveteli/comments{/number}","issue_comment_url":"https://api.github.com/repos/mysociety/alaveteli/issues/comments{/number}","contents_url":"https://api.github.com/repos/mysociety/alaveteli/contents/{+path}","compare_url":"https://api.github.com/repos/mysociety/alaveteli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mysociety/alaveteli/merges","archive_url":"https://api.github.com/repos/mysociety/alaveteli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mysociety/alaveteli/downloads","issues_url":"https://api.github.com/repos/mysociety/alaveteli/issues{/number}","pulls_url":"https://api.github.com/repos/mysociety/alaveteli/pulls{/number}","milestones_url":"https://api.github.com/repos/mysociety/alaveteli/milestones{/number}","notifications_url":"https://api.github.com/repos/mysociety/alaveteli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mysociety/alaveteli/labels{/name}","releases_url":"https://api.github.com/repos/mysociety/alaveteli/releases{/id}","deployments_url":"https://api.github.com/repos/mysociety/alaveteli/deployments","created_at":"2010-11-30T13:11:39Z","updated_at":"2018-10-25T15:40:29Z","pushed_at":"2018-10-25T15:42:25Z","git_url":"git://github.com/mysociety/alaveteli.git","ssh_url":"git@github.com:mysociety/alaveteli.git","clone_url":"https://github.com/mysociety/alaveteli.git","svn_url":"https://github.com/mysociety/alaveteli","homepage":"http://alaveteli.org","size":115706,"stargazers_count":249,"watchers_count":249,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":150,"mirror_url":null,"archived":false,"open_issues_count":921,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":150,"open_issues":921,"watchers":249,"default_branch":"develop"}},"base":{"label":"mysociety:develop","ref":"develop","sha":"35cca5256305b1f879c78b5a82d2e47c05ea21e0","user":{"login":"mysociety","id":141338,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTMzOA==","avatar_url":"https://avatars1.githubusercontent.com/u/141338?v=4","gravatar_id":"","url":"https://api.github.com/users/mysociety","html_url":"https://github.com/mysociety","followers_url":"https://api.github.com/users/mysociety/followers","following_url":"https://api.github.com/users/mysociety/following{/other_user}","gists_url":"https://api.github.com/users/mysociety/gists{/gist_id}","starred_url":"https://api.github.com/users/mysociety/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mysociety/subscriptions","organizations_url":"https://api.github.com/users/mysociety/orgs","repos_url":"https://api.github.com/users/mysociety/repos","events_url":"https://api.github.com/users/mysociety/events{/privacy}","received_events_url":"https://api.github.com/users/mysociety/received_events","type":"Organization","site_admin":false},"repo":{"id":1125389,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI1Mzg5","name":"alaveteli","full_name":"mysociety/alaveteli","private":false,"owner":{"login":"mysociety","id":141338,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTMzOA==","avatar_url":"https://avatars1.githubusercontent.com/u/141338?v=4","gravatar_id":"","url":"https://api.github.com/users/mysociety","html_url":"https://github.com/mysociety","followers_url":"https://api.github.com/users/mysociety/followers","following_url":"https://api.github.com/users/mysociety/following{/other_user}","gists_url":"https://api.github.com/users/mysociety/gists{/gist_id}","starred_url":"https://api.github.com/users/mysociety/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mysociety/subscriptions","organizations_url":"https://api.github.com/users/mysociety/orgs","repos_url":"https://api.github.com/users/mysociety/repos","events_url":"https://api.github.com/users/mysociety/events{/privacy}","received_events_url":"https://api.github.com/users/mysociety/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mysociety/alaveteli","description":"Provide a Freedom of Information request system for your jurisdiction","fork":false,"url":"https://api.github.com/repos/mysociety/alaveteli","forks_url":"https://api.github.com/repos/mysociety/alaveteli/forks","keys_url":"https://api.github.com/repos/mysociety/alaveteli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mysociety/alaveteli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mysociety/alaveteli/teams","hooks_url":"https://api.github.com/repos/mysociety/alaveteli/hooks","issue_events_url":"https://api.github.com/repos/mysociety/alaveteli/issues/events{/number}","events_url":"https://api.github.com/repos/mysociety/alaveteli/events","assignees_url":"https://api.github.com/repos/mysociety/alaveteli/assignees{/user}","branches_url":"https://api.github.com/repos/mysociety/alaveteli/branches{/branch}","tags_url":"https://api.github.com/repos/mysociety/alaveteli/tags","blobs_url":"https://api.github.com/repos/mysociety/alaveteli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mysociety/alaveteli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mysociety/alaveteli/git/refs{/sha}","trees_url":"https://api.github.com/repos/mysociety/alaveteli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mysociety/alaveteli/statuses/{sha}","languages_url":"https://api.github.com/repos/mysociety/alaveteli/languages","stargazers_url":"https://api.github.com/repos/mysociety/alaveteli/stargazers","contributors_url":"https://api.github.com/repos/mysociety/alaveteli/contributors","subscribers_url":"https://api.github.com/repos/mysociety/alaveteli/subscribers","subscription_url":"https://api.github.com/repos/mysociety/alaveteli/subscription","commits_url":"https://api.github.com/repos/mysociety/alaveteli/commits{/sha}","git_commits_url":"https://api.github.com/repos/mysociety/alaveteli/git/commits{/sha}","comments_url":"https://api.github.com/repos/mysociety/alaveteli/comments{/number}","issue_comment_url":"https://api.github.com/repos/mysociety/alaveteli/issues/comments{/number}","contents_url":"https://api.github.com/repos/mysociety/alaveteli/contents/{+path}","compare_url":"https://api.github.com/repos/mysociety/alaveteli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mysociety/alaveteli/merges","archive_url":"https://api.github.com/repos/mysociety/alaveteli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mysociety/alaveteli/downloads","issues_url":"https://api.github.com/repos/mysociety/alaveteli/issues{/number}","pulls_url":"https://api.github.com/repos/mysociety/alaveteli/pulls{/number}","milestones_url":"https://api.github.com/repos/mysociety/alaveteli/milestones{/number}","notifications_url":"https://api.github.com/repos/mysociety/alaveteli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mysociety/alaveteli/labels{/name}","releases_url":"https://api.github.com/repos/mysociety/alaveteli/releases{/id}","deployments_url":"https://api.github.com/repos/mysociety/alaveteli/deployments","created_at":"2010-11-30T13:11:39Z","updated_at":"2018-10-25T15:40:29Z","pushed_at":"2018-10-25T15:42:25Z","git_url":"git://github.com/mysociety/alaveteli.git","ssh_url":"git@github.com:mysociety/alaveteli.git","clone_url":"https://github.com/mysociety/alaveteli.git","svn_url":"https://github.com/mysociety/alaveteli","homepage":"http://alaveteli.org","size":115706,"stargazers_count":249,"watchers_count":249,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":150,"mirror_url":null,"archived":false,"open_issues_count":921,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":150,"open_issues":921,"watchers":249,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/mysociety/alaveteli/pulls/4900"},"html":{"href":"https://github.com/mysociety/alaveteli/pull/4900"},"issue":{"href":"https://api.github.com/repos/mysociety/alaveteli/issues/4900"},"comments":{"href":"https://api.github.com/repos/mysociety/alaveteli/issues/4900/comments"},"review_comments":{"href":"https://api.github.com/repos/mysociety/alaveteli/pulls/4900/comments"},"review_comment":{"href":"https://api.github.com/repos/mysociety/alaveteli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mysociety/alaveteli/pulls/4900/commits"},"statuses":{"href":"https://api.github.com/repos/mysociety/alaveteli/statuses/a7ae70eb64ce828d5cd2f7d3441f37ed09800a3a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"houndci-bot"}}