{"action":"created","comment":{"url":"https://api.github.com/repos/heptio/ark/pulls/comments/228265794","pull_request_review_id":168499628,"id":228265794,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODI2NTc5NA==","diff_hunk":"@@ -153,6 +161,8 @@ func NewCommand() *cobra.Command {\n \tcommand.Flags().StringSliceVar(&config.restoreResourcePriorities, \"restore-resource-priorities\", config.restoreResourcePriorities, \"desired order of resource restores; any resource not in the list will be restored alphabetically after the prioritized resources\")\n \tcommand.Flags().StringVar(&config.defaultBackupLocation, \"default-backup-storage-location\", config.defaultBackupLocation, \"name of the default backup storage location\")\n \tcommand.Flags().Var(&volumeSnapshotLocations, \"default-volume-snapshot-locations\", \"list of unique volume providers and default volume snapshot location (provider1:location-01,provider2:location-02,...)\")\n+\tcommand.Flags().Float32Var(&config.clientQPS, \"client-qps\", config.clientQPS, \"server's client qps\")\n+\tcommand.Flags().IntVar(&config.clientBurst, \"client-burst\", config.clientBurst, \"server's client burst\")","path":"pkg/cmd/server/server.go","position":34,"original_position":34,"commit_id":"9b0a4e9f7cdee891cb98a002d824a489f6565051","original_commit_id":"bdbc2686e25fa422bcd8e5faed5a995396195355","user":{"login":"ncdc","id":354,"node_id":"MDQ6VXNlcjM1NA==","avatar_url":"https://avatars2.githubusercontent.com/u/354?v=4","gravatar_id":"","url":"https://api.github.com/users/ncdc","html_url":"https://github.com/ncdc","followers_url":"https://api.github.com/users/ncdc/followers","following_url":"https://api.github.com/users/ncdc/following{/other_user}","gists_url":"https://api.github.com/users/ncdc/gists{/gist_id}","starred_url":"https://api.github.com/users/ncdc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncdc/subscriptions","organizations_url":"https://api.github.com/users/ncdc/orgs","repos_url":"https://api.github.com/users/ncdc/repos","events_url":"https://api.github.com/users/ncdc/events{/privacy}","received_events_url":"https://api.github.com/users/ncdc/received_events","type":"User","site_admin":false},"body":"Given that the QPS is the normal number of requests per second, the burst is the ability to exceed the QPS for a short period of time. Here's how it works:\r\n\r\nThere is a \"bucket\" that has a fixed capacity. This capacity is the \"burst\" value. Let's use an example of 30. The bucket is initially filled to capacity, so it has 30 tokens. You can pull tokens out as fast as possible, which means you can initially do 30 requests. The bucket also has a rate at which it is filled - this is the QPS. Here let's use an example of 20. This means a new token is added to the bucket approximately every 1/20 of a second. If you are constantly making requests, the steady rate will be 20/second. If you pause for long enough, the bucket will fill to capacity == burst == 30 in this example.\r\n\r\nI'm still thinking about wording.","created_at":"2018-10-25T17:30:25Z","updated_at":"2018-10-25T17:30:26Z","html_url":"https://github.com/heptio/ark/pull/956#discussion_r228265794","pull_request_url":"https://api.github.com/repos/heptio/ark/pulls/956","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/heptio/ark/pulls/comments/228265794"},"html":{"href":"https://github.com/heptio/ark/pull/956#discussion_r228265794"},"pull_request":{"href":"https://api.github.com/repos/heptio/ark/pulls/956"}},"in_reply_to_id":226705789},"pull_request":{"url":"https://api.github.com/repos/heptio/ark/pulls/956","id":224043498,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MDQzNDk4","html_url":"https://github.com/heptio/ark/pull/956","diff_url":"https://github.com/heptio/ark/pull/956.diff","patch_url":"https://github.com/heptio/ark/pull/956.patch","issue_url":"https://api.github.com/repos/heptio/ark/issues/956","number":956,"state":"open","locked":false,"title":"Added qps and burst to server's client","user":{"login":"ffd2subroutine","id":803653,"node_id":"MDQ6VXNlcjgwMzY1Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/803653?v=4","gravatar_id":"","url":"https://api.github.com/users/ffd2subroutine","html_url":"https://github.com/ffd2subroutine","followers_url":"https://api.github.com/users/ffd2subroutine/followers","following_url":"https://api.github.com/users/ffd2subroutine/following{/other_user}","gists_url":"https://api.github.com/users/ffd2subroutine/gists{/gist_id}","starred_url":"https://api.github.com/users/ffd2subroutine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ffd2subroutine/subscriptions","organizations_url":"https://api.github.com/users/ffd2subroutine/orgs","repos_url":"https://api.github.com/users/ffd2subroutine/repos","events_url":"https://api.github.com/users/ffd2subroutine/events{/privacy}","received_events_url":"https://api.github.com/users/ffd2subroutine/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Darko Radisic <ffd2subroutine@users.noreply.github.com>\r\n\r\nFixes https://github.com/heptio/ark/issues/109","created_at":"2018-10-18T17:50:31Z","updated_at":"2018-10-25T17:30:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b9e6858b0ac3bcaac247718c81e0897496ea7e7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"skriss","id":5241206,"node_id":"MDQ6VXNlcjUyNDEyMDY=","avatar_url":"https://avatars3.githubusercontent.com/u/5241206?v=4","gravatar_id":"","url":"https://api.github.com/users/skriss","html_url":"https://github.com/skriss","followers_url":"https://api.github.com/users/skriss/followers","following_url":"https://api.github.com/users/skriss/following{/other_user}","gists_url":"https://api.github.com/users/skriss/gists{/gist_id}","starred_url":"https://api.github.com/users/skriss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skriss/subscriptions","organizations_url":"https://api.github.com/users/skriss/orgs","repos_url":"https://api.github.com/users/skriss/repos","events_url":"https://api.github.com/users/skriss/events{/privacy}","received_events_url":"https://api.github.com/users/skriss/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/heptio/ark/milestones/8","html_url":"https://github.com/heptio/ark/milestone/8","labels_url":"https://api.github.com/repos/heptio/ark/milestones/8/labels","id":3460464,"node_id":"MDk6TWlsZXN0b25lMzQ2MDQ2NA==","number":8,"title":"v0.10.0","description":"Prepping for replication support.","creator":{"login":"ncdc","id":354,"node_id":"MDQ6VXNlcjM1NA==","avatar_url":"https://avatars2.githubusercontent.com/u/354?v=4","gravatar_id":"","url":"https://api.github.com/users/ncdc","html_url":"https://github.com/ncdc","followers_url":"https://api.github.com/users/ncdc/followers","following_url":"https://api.github.com/users/ncdc/following{/other_user}","gists_url":"https://api.github.com/users/ncdc/gists{/gist_id}","starred_url":"https://api.github.com/users/ncdc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncdc/subscriptions","organizations_url":"https://api.github.com/users/ncdc/orgs","repos_url":"https://api.github.com/users/ncdc/repos","events_url":"https://api.github.com/users/ncdc/events{/privacy}","received_events_url":"https://api.github.com/users/ncdc/received_events","type":"User","site_admin":false},"open_issues":19,"closed_issues":91,"state":"open","created_at":"2018-06-28T17:55:08Z","updated_at":"2018-10-25T05:47:07Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/heptio/ark/pulls/956/commits","review_comments_url":"https://api.github.com/repos/heptio/ark/pulls/956/comments","review_comment_url":"https://api.github.com/repos/heptio/ark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/heptio/ark/issues/956/comments","statuses_url":"https://api.github.com/repos/heptio/ark/statuses/9b0a4e9f7cdee891cb98a002d824a489f6565051","head":{"label":"ffd2subroutine:qps-burst-configurable","ref":"qps-burst-configurable","sha":"9b0a4e9f7cdee891cb98a002d824a489f6565051","user":{"login":"ffd2subroutine","id":803653,"node_id":"MDQ6VXNlcjgwMzY1Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/803653?v=4","gravatar_id":"","url":"https://api.github.com/users/ffd2subroutine","html_url":"https://github.com/ffd2subroutine","followers_url":"https://api.github.com/users/ffd2subroutine/followers","following_url":"https://api.github.com/users/ffd2subroutine/following{/other_user}","gists_url":"https://api.github.com/users/ffd2subroutine/gists{/gist_id}","starred_url":"https://api.github.com/users/ffd2subroutine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ffd2subroutine/subscriptions","organizations_url":"https://api.github.com/users/ffd2subroutine/orgs","repos_url":"https://api.github.com/users/ffd2subroutine/repos","events_url":"https://api.github.com/users/ffd2subroutine/events{/privacy}","received_events_url":"https://api.github.com/users/ffd2subroutine/received_events","type":"User","site_admin":false},"repo":{"id":128661450,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg2NjE0NTA=","name":"ark","full_name":"ffd2subroutine/ark","private":false,"owner":{"login":"ffd2subroutine","id":803653,"node_id":"MDQ6VXNlcjgwMzY1Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/803653?v=4","gravatar_id":"","url":"https://api.github.com/users/ffd2subroutine","html_url":"https://github.com/ffd2subroutine","followers_url":"https://api.github.com/users/ffd2subroutine/followers","following_url":"https://api.github.com/users/ffd2subroutine/following{/other_user}","gists_url":"https://api.github.com/users/ffd2subroutine/gists{/gist_id}","starred_url":"https://api.github.com/users/ffd2subroutine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ffd2subroutine/subscriptions","organizations_url":"https://api.github.com/users/ffd2subroutine/orgs","repos_url":"https://api.github.com/users/ffd2subroutine/repos","events_url":"https://api.github.com/users/ffd2subroutine/events{/privacy}","received_events_url":"https://api.github.com/users/ffd2subroutine/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ffd2subroutine/ark","description":"Heptio Ark is a utility for managing disaster recovery, specifically for your Kubernetes cluster resources and persistent volumes. Brought to you by Heptio.","fork":true,"url":"https://api.github.com/repos/ffd2subroutine/ark","forks_url":"https://api.github.com/repos/ffd2subroutine/ark/forks","keys_url":"https://api.github.com/repos/ffd2subroutine/ark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ffd2subroutine/ark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ffd2subroutine/ark/teams","hooks_url":"https://api.github.com/repos/ffd2subroutine/ark/hooks","issue_events_url":"https://api.github.com/repos/ffd2subroutine/ark/issues/events{/number}","events_url":"https://api.github.com/repos/ffd2subroutine/ark/events","assignees_url":"https://api.github.com/repos/ffd2subroutine/ark/assignees{/user}","branches_url":"https://api.github.com/repos/ffd2subroutine/ark/branches{/branch}","tags_url":"https://api.github.com/repos/ffd2subroutine/ark/tags","blobs_url":"https://api.github.com/repos/ffd2subroutine/ark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ffd2subroutine/ark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ffd2subroutine/ark/git/refs{/sha}","trees_url":"https://api.github.com/repos/ffd2subroutine/ark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ffd2subroutine/ark/statuses/{sha}","languages_url":"https://api.github.com/repos/ffd2subroutine/ark/languages","stargazers_url":"https://api.github.com/repos/ffd2subroutine/ark/stargazers","contributors_url":"https://api.github.com/repos/ffd2subroutine/ark/contributors","subscribers_url":"https://api.github.com/repos/ffd2subroutine/ark/subscribers","subscription_url":"https://api.github.com/repos/ffd2subroutine/ark/subscription","commits_url":"https://api.github.com/repos/ffd2subroutine/ark/commits{/sha}","git_commits_url":"https://api.github.com/repos/ffd2subroutine/ark/git/commits{/sha}","comments_url":"https://api.github.com/repos/ffd2subroutine/ark/comments{/number}","issue_comment_url":"https://api.github.com/repos/ffd2subroutine/ark/issues/comments{/number}","contents_url":"https://api.github.com/repos/ffd2subroutine/ark/contents/{+path}","compare_url":"https://api.github.com/repos/ffd2subroutine/ark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ffd2subroutine/ark/merges","archive_url":"https://api.github.com/repos/ffd2subroutine/ark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ffd2subroutine/ark/downloads","issues_url":"https://api.github.com/repos/ffd2subroutine/ark/issues{/number}","pulls_url":"https://api.github.com/repos/ffd2subroutine/ark/pulls{/number}","milestones_url":"https://api.github.com/repos/ffd2subroutine/ark/milestones{/number}","notifications_url":"https://api.github.com/repos/ffd2subroutine/ark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ffd2subroutine/ark/labels{/name}","releases_url":"https://api.github.com/repos/ffd2subroutine/ark/releases{/id}","deployments_url":"https://api.github.com/repos/ffd2subroutine/ark/deployments","created_at":"2018-04-08T16:40:14Z","updated_at":"2018-10-18T17:16:15Z","pushed_at":"2018-10-19T17:33:43Z","git_url":"git://github.com/ffd2subroutine/ark.git","ssh_url":"git@github.com:ffd2subroutine/ark.git","clone_url":"https://github.com/ffd2subroutine/ark.git","svn_url":"https://github.com/ffd2subroutine/ark","homepage":"https://www.heptio.com","size":10874,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"heptio:master","ref":"master","sha":"d0937a343346a36c67dbbaea0c157b39ee82fbcb","user":{"login":"heptio","id":22035492,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDM1NDky","avatar_url":"https://avatars0.githubusercontent.com/u/22035492?v=4","gravatar_id":"","url":"https://api.github.com/users/heptio","html_url":"https://github.com/heptio","followers_url":"https://api.github.com/users/heptio/followers","following_url":"https://api.github.com/users/heptio/following{/other_user}","gists_url":"https://api.github.com/users/heptio/gists{/gist_id}","starred_url":"https://api.github.com/users/heptio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heptio/subscriptions","organizations_url":"https://api.github.com/users/heptio/orgs","repos_url":"https://api.github.com/users/heptio/repos","events_url":"https://api.github.com/users/heptio/events{/privacy}","received_events_url":"https://api.github.com/users/heptio/received_events","type":"Organization","site_admin":false},"repo":{"id":99143276,"node_id":"MDEwOlJlcG9zaXRvcnk5OTE0MzI3Ng==","name":"ark","full_name":"heptio/ark","private":false,"owner":{"login":"heptio","id":22035492,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDM1NDky","avatar_url":"https://avatars0.githubusercontent.com/u/22035492?v=4","gravatar_id":"","url":"https://api.github.com/users/heptio","html_url":"https://github.com/heptio","followers_url":"https://api.github.com/users/heptio/followers","following_url":"https://api.github.com/users/heptio/following{/other_user}","gists_url":"https://api.github.com/users/heptio/gists{/gist_id}","starred_url":"https://api.github.com/users/heptio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heptio/subscriptions","organizations_url":"https://api.github.com/users/heptio/orgs","repos_url":"https://api.github.com/users/heptio/repos","events_url":"https://api.github.com/users/heptio/events{/privacy}","received_events_url":"https://api.github.com/users/heptio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/heptio/ark","description":"Heptio Ark is a utility for managing disaster recovery, specifically for your Kubernetes cluster resources and persistent volumes. Brought to you by Heptio.","fork":false,"url":"https://api.github.com/repos/heptio/ark","forks_url":"https://api.github.com/repos/heptio/ark/forks","keys_url":"https://api.github.com/repos/heptio/ark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heptio/ark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heptio/ark/teams","hooks_url":"https://api.github.com/repos/heptio/ark/hooks","issue_events_url":"https://api.github.com/repos/heptio/ark/issues/events{/number}","events_url":"https://api.github.com/repos/heptio/ark/events","assignees_url":"https://api.github.com/repos/heptio/ark/assignees{/user}","branches_url":"https://api.github.com/repos/heptio/ark/branches{/branch}","tags_url":"https://api.github.com/repos/heptio/ark/tags","blobs_url":"https://api.github.com/repos/heptio/ark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heptio/ark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heptio/ark/git/refs{/sha}","trees_url":"https://api.github.com/repos/heptio/ark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heptio/ark/statuses/{sha}","languages_url":"https://api.github.com/repos/heptio/ark/languages","stargazers_url":"https://api.github.com/repos/heptio/ark/stargazers","contributors_url":"https://api.github.com/repos/heptio/ark/contributors","subscribers_url":"https://api.github.com/repos/heptio/ark/subscribers","subscription_url":"https://api.github.com/repos/heptio/ark/subscription","commits_url":"https://api.github.com/repos/heptio/ark/commits{/sha}","git_commits_url":"https://api.github.com/repos/heptio/ark/git/commits{/sha}","comments_url":"https://api.github.com/repos/heptio/ark/comments{/number}","issue_comment_url":"https://api.github.com/repos/heptio/ark/issues/comments{/number}","contents_url":"https://api.github.com/repos/heptio/ark/contents/{+path}","compare_url":"https://api.github.com/repos/heptio/ark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heptio/ark/merges","archive_url":"https://api.github.com/repos/heptio/ark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heptio/ark/downloads","issues_url":"https://api.github.com/repos/heptio/ark/issues{/number}","pulls_url":"https://api.github.com/repos/heptio/ark/pulls{/number}","milestones_url":"https://api.github.com/repos/heptio/ark/milestones{/number}","notifications_url":"https://api.github.com/repos/heptio/ark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heptio/ark/labels{/name}","releases_url":"https://api.github.com/repos/heptio/ark/releases{/id}","deployments_url":"https://api.github.com/repos/heptio/ark/deployments","created_at":"2017-08-02T17:22:11Z","updated_at":"2018-10-25T17:18:08Z","pushed_at":"2018-10-25T17:18:04Z","git_url":"git://github.com/heptio/ark.git","ssh_url":"git@github.com:heptio/ark.git","clone_url":"https://github.com/heptio/ark.git","svn_url":"https://github.com/heptio/ark","homepage":"https://www.heptio.com","size":11081,"stargazers_count":1614,"watchers_count":1614,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":227,"mirror_url":null,"archived":false,"open_issues_count":180,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":227,"open_issues":180,"watchers":1614,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/heptio/ark/pulls/956"},"html":{"href":"https://github.com/heptio/ark/pull/956"},"issue":{"href":"https://api.github.com/repos/heptio/ark/issues/956"},"comments":{"href":"https://api.github.com/repos/heptio/ark/issues/956/comments"},"review_comments":{"href":"https://api.github.com/repos/heptio/ark/pulls/956/comments"},"review_comment":{"href":"https://api.github.com/repos/heptio/ark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/heptio/ark/pulls/956/commits"},"statuses":{"href":"https://api.github.com/repos/heptio/ark/statuses/9b0a4e9f7cdee891cb98a002d824a489f6565051"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ncdc"}}