{"action":"closed","number":290,"pull_request":{"url":"https://api.github.com/repos/jetstack/cert-manager/pulls/290","id":167148818,"html_url":"https://github.com/jetstack/cert-manager/pull/290","diff_url":"https://github.com/jetstack/cert-manager/pull/290.diff","patch_url":"https://github.com/jetstack/cert-manager/pull/290.patch","issue_url":"https://api.github.com/repos/jetstack/cert-manager/issues/290","number":290,"state":"closed","locked":false,"title":"Update helm chart to align with k/charts feedback","user":{"login":"munnerz","id":203583,"avatar_url":"https://avatars3.githubusercontent.com/u/203583?v=4","gravatar_id":"","url":"https://api.github.com/users/munnerz","html_url":"https://github.com/munnerz","followers_url":"https://api.github.com/users/munnerz/followers","following_url":"https://api.github.com/users/munnerz/following{/other_user}","gists_url":"https://api.github.com/users/munnerz/gists{/gist_id}","starred_url":"https://api.github.com/users/munnerz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/munnerz/subscriptions","organizations_url":"https://api.github.com/users/munnerz/orgs","repos_url":"https://api.github.com/users/munnerz/repos","events_url":"https://api.github.com/users/munnerz/events{/privacy}","received_events_url":"https://api.github.com/users/munnerz/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:\r\n\r\nThis PR brings the helm chart in line with what is found in kubernetes/charts (changes contained here: https://github.com/kubernetes/charts/pull/3416/commits/008d52cbc4c2b7d2b4981f53214e15779e085fb7).\r\n\r\nIt also addresses some feedback (https://github.com/kubernetes/charts/issues/3513) in order to improve our post-installation documentation by providing links to how to configure issuers/ingress-shim.\r\n\r\n**Release note**:\r\n```release-note\r\nRemove default resource requests in Helm chart. Improve post-deployment informational messages.\r\n```\r\n","created_at":"2018-02-05T13:50:31Z","updated_at":"2018-02-06T10:08:58Z","closed_at":"2018-02-06T10:08:58Z","merged_at":"2018-02-06T10:08:58Z","merge_commit_sha":"a3e463f92b22a0844c8f74654d84ab01ee2e9a19","assignee":{"login":"munnerz","id":203583,"avatar_url":"https://avatars3.githubusercontent.com/u/203583?v=4","gravatar_id":"","url":"https://api.github.com/users/munnerz","html_url":"https://github.com/munnerz","followers_url":"https://api.github.com/users/munnerz/followers","following_url":"https://api.github.com/users/munnerz/following{/other_user}","gists_url":"https://api.github.com/users/munnerz/gists{/gist_id}","starred_url":"https://api.github.com/users/munnerz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/munnerz/subscriptions","organizations_url":"https://api.github.com/users/munnerz/orgs","repos_url":"https://api.github.com/users/munnerz/repos","events_url":"https://api.github.com/users/munnerz/events{/privacy}","received_events_url":"https://api.github.com/users/munnerz/received_events","type":"User","site_admin":false},"assignees":[{"login":"munnerz","id":203583,"avatar_url":"https://avatars3.githubusercontent.com/u/203583?v=4","gravatar_id":"","url":"https://api.github.com/users/munnerz","html_url":"https://github.com/munnerz","followers_url":"https://api.github.com/users/munnerz/followers","following_url":"https://api.github.com/users/munnerz/following{/other_user}","gists_url":"https://api.github.com/users/munnerz/gists{/gist_id}","starred_url":"https://api.github.com/users/munnerz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/munnerz/subscriptions","organizations_url":"https://api.github.com/users/munnerz/orgs","repos_url":"https://api.github.com/users/munnerz/repos","events_url":"https://api.github.com/users/munnerz/events{/privacy}","received_events_url":"https://api.github.com/users/munnerz/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"simonswine","id":223048,"avatar_url":"https://avatars0.githubusercontent.com/u/223048?v=4","gravatar_id":"","url":"https://api.github.com/users/simonswine","html_url":"https://github.com/simonswine","followers_url":"https://api.github.com/users/simonswine/followers","following_url":"https://api.github.com/users/simonswine/following{/other_user}","gists_url":"https://api.github.com/users/simonswine/gists{/gist_id}","starred_url":"https://api.github.com/users/simonswine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonswine/subscriptions","organizations_url":"https://api.github.com/users/simonswine/orgs","repos_url":"https://api.github.com/users/simonswine/repos","events_url":"https://api.github.com/users/simonswine/events{/privacy}","received_events_url":"https://api.github.com/users/simonswine/received_events","type":"User","site_admin":false},{"login":"dippynark","id":28210877,"avatar_url":"https://avatars3.githubusercontent.com/u/28210877?v=4","gravatar_id":"","url":"https://api.github.com/users/dippynark","html_url":"https://github.com/dippynark","followers_url":"https://api.github.com/users/dippynark/followers","following_url":"https://api.github.com/users/dippynark/following{/other_user}","gists_url":"https://api.github.com/users/dippynark/gists{/gist_id}","starred_url":"https://api.github.com/users/dippynark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dippynark/subscriptions","organizations_url":"https://api.github.com/users/dippynark/orgs","repos_url":"https://api.github.com/users/dippynark/repos","events_url":"https://api.github.com/users/dippynark/events{/privacy}","received_events_url":"https://api.github.com/users/dippynark/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/jetstack/cert-manager/pulls/290/commits","review_comments_url":"https://api.github.com/repos/jetstack/cert-manager/pulls/290/comments","review_comment_url":"https://api.github.com/repos/jetstack/cert-manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jetstack/cert-manager/issues/290/comments","statuses_url":"https://api.github.com/repos/jetstack/cert-manager/statuses/5aa3c091e9876b17415cd1b7dcc20702d01e8cc3","head":{"label":"munnerz:update-chart","ref":"update-chart","sha":"5aa3c091e9876b17415cd1b7dcc20702d01e8cc3","user":{"login":"munnerz","id":203583,"avatar_url":"https://avatars3.githubusercontent.com/u/203583?v=4","gravatar_id":"","url":"https://api.github.com/users/munnerz","html_url":"https://github.com/munnerz","followers_url":"https://api.github.com/users/munnerz/followers","following_url":"https://api.github.com/users/munnerz/following{/other_user}","gists_url":"https://api.github.com/users/munnerz/gists{/gist_id}","starred_url":"https://api.github.com/users/munnerz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/munnerz/subscriptions","organizations_url":"https://api.github.com/users/munnerz/orgs","repos_url":"https://api.github.com/users/munnerz/repos","events_url":"https://api.github.com/users/munnerz/events{/privacy}","received_events_url":"https://api.github.com/users/munnerz/received_events","type":"User","site_admin":false},"repo":{"id":104815853,"name":"cert-manager","full_name":"munnerz/cert-manager","owner":{"login":"munnerz","id":203583,"avatar_url":"https://avatars3.githubusercontent.com/u/203583?v=4","gravatar_id":"","url":"https://api.github.com/users/munnerz","html_url":"https://github.com/munnerz","followers_url":"https://api.github.com/users/munnerz/followers","following_url":"https://api.github.com/users/munnerz/following{/other_user}","gists_url":"https://api.github.com/users/munnerz/gists{/gist_id}","starred_url":"https://api.github.com/users/munnerz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/munnerz/subscriptions","organizations_url":"https://api.github.com/users/munnerz/orgs","repos_url":"https://api.github.com/users/munnerz/repos","events_url":"https://api.github.com/users/munnerz/events{/privacy}","received_events_url":"https://api.github.com/users/munnerz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/munnerz/cert-manager","description":"Automatically provision TLS certificates for Kubernetes","fork":true,"url":"https://api.github.com/repos/munnerz/cert-manager","forks_url":"https://api.github.com/repos/munnerz/cert-manager/forks","keys_url":"https://api.github.com/repos/munnerz/cert-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/munnerz/cert-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/munnerz/cert-manager/teams","hooks_url":"https://api.github.com/repos/munnerz/cert-manager/hooks","issue_events_url":"https://api.github.com/repos/munnerz/cert-manager/issues/events{/number}","events_url":"https://api.github.com/repos/munnerz/cert-manager/events","assignees_url":"https://api.github.com/repos/munnerz/cert-manager/assignees{/user}","branches_url":"https://api.github.com/repos/munnerz/cert-manager/branches{/branch}","tags_url":"https://api.github.com/repos/munnerz/cert-manager/tags","blobs_url":"https://api.github.com/repos/munnerz/cert-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/munnerz/cert-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/munnerz/cert-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/munnerz/cert-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/munnerz/cert-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/munnerz/cert-manager/languages","stargazers_url":"https://api.github.com/repos/munnerz/cert-manager/stargazers","contributors_url":"https://api.github.com/repos/munnerz/cert-manager/contributors","subscribers_url":"https://api.github.com/repos/munnerz/cert-manager/subscribers","subscription_url":"https://api.github.com/repos/munnerz/cert-manager/subscription","commits_url":"https://api.github.com/repos/munnerz/cert-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/munnerz/cert-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/munnerz/cert-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/munnerz/cert-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/munnerz/cert-manager/contents/{+path}","compare_url":"https://api.github.com/repos/munnerz/cert-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/munnerz/cert-manager/merges","archive_url":"https://api.github.com/repos/munnerz/cert-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/munnerz/cert-manager/downloads","issues_url":"https://api.github.com/repos/munnerz/cert-manager/issues{/number}","pulls_url":"https://api.github.com/repos/munnerz/cert-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/munnerz/cert-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/munnerz/cert-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/munnerz/cert-manager/labels{/name}","releases_url":"https://api.github.com/repos/munnerz/cert-manager/releases{/id}","deployments_url":"https://api.github.com/repos/munnerz/cert-manager/deployments","created_at":"2017-09-26T00:30:00Z","updated_at":"2018-01-08T10:00:59Z","pushed_at":"2018-02-05T19:16:54Z","git_url":"git://github.com/munnerz/cert-manager.git","ssh_url":"git@github.com:munnerz/cert-manager.git","clone_url":"https://github.com/munnerz/cert-manager.git","svn_url":"https://github.com/munnerz/cert-manager","homepage":"","size":47066,"stargazers_count":4,"watchers_count":4,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":4,"default_branch":"master"}},"base":{"label":"jetstack:master","ref":"master","sha":"35adb0ea13512261ee78c22f1d73a28949ae43ac","user":{"login":"jetstack","id":13183983,"avatar_url":"https://avatars1.githubusercontent.com/u/13183983?v=4","gravatar_id":"","url":"https://api.github.com/users/jetstack","html_url":"https://github.com/jetstack","followers_url":"https://api.github.com/users/jetstack/followers","following_url":"https://api.github.com/users/jetstack/following{/other_user}","gists_url":"https://api.github.com/users/jetstack/gists{/gist_id}","starred_url":"https://api.github.com/users/jetstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jetstack/subscriptions","organizations_url":"https://api.github.com/users/jetstack/orgs","repos_url":"https://api.github.com/users/jetstack/repos","events_url":"https://api.github.com/users/jetstack/events{/privacy}","received_events_url":"https://api.github.com/users/jetstack/received_events","type":"Organization","site_admin":false},"repo":{"id":92313258,"name":"cert-manager","full_name":"jetstack/cert-manager","owner":{"login":"jetstack","id":13183983,"avatar_url":"https://avatars1.githubusercontent.com/u/13183983?v=4","gravatar_id":"","url":"https://api.github.com/users/jetstack","html_url":"https://github.com/jetstack","followers_url":"https://api.github.com/users/jetstack/followers","following_url":"https://api.github.com/users/jetstack/following{/other_user}","gists_url":"https://api.github.com/users/jetstack/gists{/gist_id}","starred_url":"https://api.github.com/users/jetstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jetstack/subscriptions","organizations_url":"https://api.github.com/users/jetstack/orgs","repos_url":"https://api.github.com/users/jetstack/repos","events_url":"https://api.github.com/users/jetstack/events{/privacy}","received_events_url":"https://api.github.com/users/jetstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jetstack/cert-manager","description":"Automatically provision TLS certificates for Kubernetes","fork":false,"url":"https://api.github.com/repos/jetstack/cert-manager","forks_url":"https://api.github.com/repos/jetstack/cert-manager/forks","keys_url":"https://api.github.com/repos/jetstack/cert-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jetstack/cert-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jetstack/cert-manager/teams","hooks_url":"https://api.github.com/repos/jetstack/cert-manager/hooks","issue_events_url":"https://api.github.com/repos/jetstack/cert-manager/issues/events{/number}","events_url":"https://api.github.com/repos/jetstack/cert-manager/events","assignees_url":"https://api.github.com/repos/jetstack/cert-manager/assignees{/user}","branches_url":"https://api.github.com/repos/jetstack/cert-manager/branches{/branch}","tags_url":"https://api.github.com/repos/jetstack/cert-manager/tags","blobs_url":"https://api.github.com/repos/jetstack/cert-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jetstack/cert-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jetstack/cert-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/jetstack/cert-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jetstack/cert-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/jetstack/cert-manager/languages","stargazers_url":"https://api.github.com/repos/jetstack/cert-manager/stargazers","contributors_url":"https://api.github.com/repos/jetstack/cert-manager/contributors","subscribers_url":"https://api.github.com/repos/jetstack/cert-manager/subscribers","subscription_url":"https://api.github.com/repos/jetstack/cert-manager/subscription","commits_url":"https://api.github.com/repos/jetstack/cert-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/jetstack/cert-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/jetstack/cert-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/jetstack/cert-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/jetstack/cert-manager/contents/{+path}","compare_url":"https://api.github.com/repos/jetstack/cert-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jetstack/cert-manager/merges","archive_url":"https://api.github.com/repos/jetstack/cert-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jetstack/cert-manager/downloads","issues_url":"https://api.github.com/repos/jetstack/cert-manager/issues{/number}","pulls_url":"https://api.github.com/repos/jetstack/cert-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/jetstack/cert-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/jetstack/cert-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jetstack/cert-manager/labels{/name}","releases_url":"https://api.github.com/repos/jetstack/cert-manager/releases{/id}","deployments_url":"https://api.github.com/repos/jetstack/cert-manager/deployments","created_at":"2017-05-24T16:25:59Z","updated_at":"2018-02-06T08:27:08Z","pushed_at":"2018-02-06T10:08:58Z","git_url":"git://github.com/jetstack/cert-manager.git","ssh_url":"git@github.com:jetstack/cert-manager.git","clone_url":"https://github.com/jetstack/cert-manager.git","svn_url":"https://github.com/jetstack/cert-manager","homepage":"","size":46994,"stargazers_count":339,"watchers_count":339,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"archived":false,"open_issues_count":73,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":42,"open_issues":73,"watchers":339,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jetstack/cert-manager/pulls/290"},"html":{"href":"https://github.com/jetstack/cert-manager/pull/290"},"issue":{"href":"https://api.github.com/repos/jetstack/cert-manager/issues/290"},"comments":{"href":"https://api.github.com/repos/jetstack/cert-manager/issues/290/comments"},"review_comments":{"href":"https://api.github.com/repos/jetstack/cert-manager/pulls/290/comments"},"review_comment":{"href":"https://api.github.com/repos/jetstack/cert-manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jetstack/cert-manager/pulls/290/commits"},"statuses":{"href":"https://api.github.com/repos/jetstack/cert-manager/statuses/5aa3c091e9876b17415cd1b7dcc20702d01e8cc3"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jetstack-ci-bot","id":33632071,"avatar_url":"https://avatars2.githubusercontent.com/u/33632071?v=4","gravatar_id":"","url":"https://api.github.com/users/jetstack-ci-bot","html_url":"https://github.com/jetstack-ci-bot","followers_url":"https://api.github.com/users/jetstack-ci-bot/followers","following_url":"https://api.github.com/users/jetstack-ci-bot/following{/other_user}","gists_url":"https://api.github.com/users/jetstack-ci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/jetstack-ci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jetstack-ci-bot/subscriptions","organizations_url":"https://api.github.com/users/jetstack-ci-bot/orgs","repos_url":"https://api.github.com/users/jetstack-ci-bot/repos","events_url":"https://api.github.com/users/jetstack-ci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/jetstack-ci-bot/received_events","type":"User","site_admin":false},"comments":8,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":75,"deletions":34,"changed_files":16}}
{"actor":{"display_login":"jetstack-ci-bot"}}