{"action":"created","issue":{"url":"https://api.github.com/repos/openfaas/faas/issues/743","repository_url":"https://api.github.com/repos/openfaas/faas","labels_url":"https://api.github.com/repos/openfaas/faas/issues/743/labels{/name}","comments_url":"https://api.github.com/repos/openfaas/faas/issues/743/comments","events_url":"https://api.github.com/repos/openfaas/faas/issues/743/events","html_url":"https://github.com/openfaas/faas/pull/743","id":337822959,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4OTA3MTUz","number":743,"title":"Enable basic-auth by default","user":{"login":"alexellis","id":6358735,"node_id":"MDQ6VXNlcjYzNTg3MzU=","avatar_url":"https://avatars1.githubusercontent.com/u/6358735?v=4","gravatar_id":"","url":"https://api.github.com/users/alexellis","html_url":"https://github.com/alexellis","followers_url":"https://api.github.com/users/alexellis/followers","following_url":"https://api.github.com/users/alexellis/following{/other_user}","gists_url":"https://api.github.com/users/alexellis/gists{/gist_id}","starred_url":"https://api.github.com/users/alexellis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexellis/subscriptions","organizations_url":"https://api.github.com/users/alexellis/orgs","repos_url":"https://api.github.com/users/alexellis/repos","events_url":"https://api.github.com/users/alexellis/events{/privacy}","received_events_url":"https://api.github.com/users/alexellis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-03T09:45:57Z","updated_at":"2018-07-03T11:58:04Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/openfaas/faas/pulls/743","html_url":"https://github.com/openfaas/faas/pull/743","diff_url":"https://github.com/openfaas/faas/pull/743.diff","patch_url":"https://github.com/openfaas/faas/pull/743.patch"},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\n\r\nEnable basic-auth by default.\r\n\r\nThis changes ./deploy_stack.sh to generate and then apply secrets turning\r\non the built-in basic auth feature of the gateway.\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\n- [x] I have raised an issue to propose this change ([required](https://github.com/openfaas/faas/blob/master/CONTRIBUTING.md))\r\n\r\n#350 #74 \r\n\r\nThe deployment script will enable basic-auth by default to help\r\navoid people deploying to a public IP with no protection from\r\nmalicious actors.\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\n\r\nTested on MacOS with and without --no-auth flag.\r\nDoes not apply for armhf or powershell.\r\n\r\nExample workflow for testing:\r\n\r\n![screen shot 2018-07-03 at 10 25 22 am](https://user-images.githubusercontent.com/6358735/42212622-8a5f18d2-7eae-11e8-9242-eb3da233a79f.png)\r\n\r\nTest with positive and negative workflows: positive - password supplied and consumed, show that auth is working by using wrong password. Negative flow - disable auth and check auth is not required.\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [x] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [x] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [x] I've read the [CONTRIBUTION](https://github.com/openfaas/faas/blob/master/CONTRIBUTING.md) guide\r\n- [x] I have signed-off my commits with `git commit -s`\r\n- [ ] I have added tests to cover my changes.\r\n- [ ] All new and existing tests passed.\r\n\r\nWill need documentation change and change to integration tests to disable auth via `--no-auth` flag when deploying during testing."},"comment":{"url":"https://api.github.com/repos/openfaas/faas/issues/comments/402129836","html_url":"https://github.com/openfaas/faas/pull/743#issuecomment-402129836","issue_url":"https://api.github.com/repos/openfaas/faas/issues/743","id":402129836,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMjEyOTgzNg==","user":{"login":"mrtind","id":34942004,"node_id":"MDQ6VXNlcjM0OTQyMDA0","avatar_url":"https://avatars1.githubusercontent.com/u/34942004?v=4","gravatar_id":"","url":"https://api.github.com/users/mrtind","html_url":"https://github.com/mrtind","followers_url":"https://api.github.com/users/mrtind/followers","following_url":"https://api.github.com/users/mrtind/following{/other_user}","gists_url":"https://api.github.com/users/mrtind/gists{/gist_id}","starred_url":"https://api.github.com/users/mrtind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrtind/subscriptions","organizations_url":"https://api.github.com/users/mrtind/orgs","repos_url":"https://api.github.com/users/mrtind/repos","events_url":"https://api.github.com/users/mrtind/events{/privacy}","received_events_url":"https://api.github.com/users/mrtind/received_events","type":"User","site_admin":false},"created_at":"2018-07-03T11:58:04Z","updated_at":"2018-07-03T11:58:04Z","author_association":"NONE","body":"When i test the change on docker playground deploy stack gives me \r\n./deploy_stack.sh: line 27: shasum: not found\r\nand the password field is left blank."}}
{"actor":{"display_login":"mrtind"}}