{"push_id":2667159492,"size":9,"distinct_size":9,"ref":"refs/heads/dev","head":"7dedbf9420f9e133ec35a3bed05cedb1fadd3148","before":"795c2842b14e8b0b979bee57b1ac01b760da8470","commits":[{"sha":"3ccb28198594ee3c2881ca5b992399a7558489e8","author":{"name":"NoelBright","email":"a44ccbbfab76147db92ad64ea937c3a2454f6f69@gmail.com"},"message":"[Phase 1/5] Add uniform interfaces for jsonrpc, restful and websocket\n\n[rpc/common][rpc/jsonrpc]\nAdd an adapter 'processUnify' to be compatible with old interfaces in\njsonrpc temporarily. In the future the 'processUnify' will be remove.\n\n1. move interfaces from jsonrpc/interfaces.go to common/interfaces.go,\nand modify their parameters and return codes.\n2. add an interface 'Serverer' for jsonrpc, restful and websocket to\nget node and wallet informations from a server not a global variable.\n3. modify some interfaces of jsonrpc by using processUnify.\n\nSigned-off-by: NoelBright <noel.n.bright@gmail.com>","distinct":true,"url":"https://api.github.com/repos/doraemon0/nkn/commits/3ccb28198594ee3c2881ca5b992399a7558489e8"},{"sha":"76bda3e6cd6dca03c5e2f0bfe3f058d9049676fd","author":{"name":"NoelBright","email":"a44ccbbfab76147db92ad64ea937c3a2454f6f69@gmail.com"},"message":"[Phase 2/5] Add uniform interfaces for jsonrpc, restful and websocket\n\nPlan:\nphase 1: move 1/3 interfaces of httpjson/ to common/ and something else.\nphase 2: move 1/3 interfaces of httpjson/ to common/.\nphase 3: move 1/3 interfaces of httpjson/ to common/.\nphase 4: add comments to interfaces in common/ and modify return code to\n         errorcode correspondingly.\nphase 5: remove processUnify from httpjson and embedded interfaces directly.\n\n[rpc/common][rpc/jsonrpc]\nAdd an adapter 'processUnify' to be compatible with old interfaces in\njsonrpc temporarily. In the future the 'processUnify' will be remove.\n\n1. move interfaces from jsonrpc/interfaces.go to common/interfaces.go,\nand modify their parameters and return codes.\n\nSigned-off-by: NoelBright <noel.n.bright@gmail.com>","distinct":true,"url":"https://api.github.com/repos/doraemon0/nkn/commits/76bda3e6cd6dca03c5e2f0bfe3f058d9049676fd"},{"sha":"58dfae72f5d5c52639c799590a628cc38d099901","author":{"name":"NoelBright","email":"a44ccbbfab76147db92ad64ea937c3a2454f6f69@gmail.com"},"message":"[Phase 3/5] Add uniform interfaces for jsonrpc, restful and websocket\n\nPlan:\nphase 1: move 1/3 interfaces of httpjson/ to common/ and something else.\nphase 2: move 1/3 interfaces of httpjson/ to common/.\nphase 3: move 1/3 interfaces of httpjson/ to common/.\nphase 4: add comments to interfaces in common/ and modify return code to\n         errorcode correspondingly.\nphase 5: remove processUnify from httpjson and embedded interfaces directly.\n\n[rpc/common][rpc/jsonrpc]\nAdd an adapter 'processUnify' to be compatible with old interfaces in\njsonrpc temporarily. In the future the 'processUnify' will be remove.\n\n1. move interfaces from jsonrpc/interfaces.go to common/interfaces.go,\nand modify their parameters and return codes.\n\nSigned-off-by: NoelBright <noel.n.bright@gmail.com>","distinct":true,"url":"https://api.github.com/repos/doraemon0/nkn/commits/58dfae72f5d5c52639c799590a628cc38d099901"},{"sha":"a345c3e1c7088d3445239e2dafa12f3709765017","author":{"name":"NoelBright","email":"a44ccbbfab76147db92ad64ea937c3a2454f6f69@gmail.com"},"message":"[Phase 4/5] Add uniform interfaces for jsonrpc, restful and websocket\n\nPlan:\nphase 1: move 1/3 interfaces of httpjson/ to common/ and something else.\nphase 2: move 1/3 interfaces of httpjson/ to common/.\nphase 3: move 1/3 interfaces of httpjson/ to common/.\nphase 4: add comments to interfaces in common/ and modify return code to\n\t errorcode correspondingly.\nphase 5: remove processUnify from httpjson and embedded interfaces directly.\n\n[rpc/common][rpc/jsonrpc]\nAdd an adapter 'processUnify' to be compatible with old interfaces in\njsonrpc temporarily. In the future the 'processUnify' will be remove.\n\n1. add comments to interfaces in common/\n2. modify return code to errorcode correspondingly.\n\nSigned-off-by: NoelBright <noel.n.bright@gmail.com>","distinct":true,"url":"https://api.github.com/repos/doraemon0/nkn/commits/a345c3e1c7088d3445239e2dafa12f3709765017"},{"sha":"5409837cf31372063fa6d305d54e87027c1f4938","author":{"name":"NoelBright","email":"a44ccbbfab76147db92ad64ea937c3a2454f6f69@gmail.com"},"message":" [Phase 5/5] Add uniform interfaces for jsonrpc, restful and websocket\n\nPlan:\nphase 1: move 1/3 interfaces of httpjson/ to common/ and something else.\nphase 2: move 1/3 interfaces of httpjson/ to common/.\nphase 3: move 1/3 interfaces of httpjson/ to common/.\nphase 4: add comments to interfaces in common/ and modify return code to\n\t errorcode correspondingly.\nphase 5: remove processUnify from httpjson and embedded interfaces directly.\n\n[rpc/common][rpc/jsonrpc]\nAdd an adapter 'processUnify' to be compatible with old interfaces in\njsonrpc temporarily. In the future the 'processUnify' will be remove.\n\n1. remove processUnify from httpjson and embedded interfaces directly.\n\nSigned-off-by: NoelBright <noel.n.bright@gmail.com>","distinct":true,"url":"https://api.github.com/repos/doraemon0/nkn/commits/5409837cf31372063fa6d305d54e87027c1f4938"},{"sha":"a6cf54808e8186e996cbe573ad677597bd2b6ae0","author":{"name":"NoelBright","email":"a44ccbbfab76147db92ad64ea937c3a2454f6f69@gmail.com"},"message":"[improvement] modify jsonrpc parameter format and modify common.Handler prototype\n\n[rpc/common][rpc/httpjson][cli]\n1. modify jsonrpc parameter format.\nMove []interface{} to map[string]interface{} to be Compatible with restful and websocket.\n\n2. modify common.Handler prototype.\nfrom\n\"func(Serverer, []interface{}) (map[string]interface, ErrCode)\"\nto\n\"func(Serverer, map[string]interface{}) map[string]interface\"\n\nSigned-off-by: NoelBright <noel.n.bright@gmail.com>","distinct":true,"url":"https://api.github.com/repos/doraemon0/nkn/commits/a6cf54808e8186e996cbe573ad677597bd2b6ae0"},{"sha":"7b18459f44f63978e0953ce5165e0818614fcd0c","author":{"name":"oscar","email":"2dff4fc90e2973f54d62e257480de234bc59e2c4@nkn.org"},"message":"[bugfix] get sigchain transaction error when change mind\n\nShould get transaction from transaction pool rather than por server.\n\nSigned-off-by: oscar <oscar@nkn.org>","distinct":true,"url":"https://api.github.com/repos/doraemon0/nkn/commits/7b18459f44f63978e0953ce5165e0818614fcd0c"},{"sha":"22dfbb439b5d113e851aa620f6f243c94d767e9b","author":{"name":"oscar","email":"2dff4fc90e2973f54d62e257480de234bc59e2c4@nkn.org"},"message":"More consensus log printed\n\n1. print reversed hash\n2. print mind changed state\n\nSigned-off-by: oscar <oscar@nkn.org>","distinct":true,"url":"https://api.github.com/repos/doraemon0/nkn/commits/22dfbb439b5d113e851aa620f6f243c94d767e9b"},{"sha":"7dedbf9420f9e133ec35a3bed05cedb1fadd3148","author":{"name":"oscar","email":"2dff4fc90e2973f54d62e257480de234bc59e2c4@nkn.org"},"message":"Code cleanup for networking module and coding style\n\n1. remove lots of unnecessary log.Debug.\n2. change structure name according to coding style.\n3. change const variable type according to coding style.\n4. cleanup code for networking module\n\nSigned-off-by: oscar <oscar@nkn.org>","distinct":true,"url":"https://api.github.com/repos/doraemon0/nkn/commits/7dedbf9420f9e133ec35a3bed05cedb1fadd3148"}]}
{"actor":{"display_login":"doraemon0"}}