{"action":"created","comment":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/174857800","pull_request_review_id":104235944,"id":174857800,"diff_hunk":"@@ -84,19 +84,19 @@ public void readKey( PageCursor cursor, ZonedDateTimeSchemaKey into, int keySize\n         if ( isZoneId( encodedZone ) )\n         {\n             into.zoneId = asZoneId( encodedZone );\n-            into.zoneOffsetSeconds = 0;\n+            into.zoneOffsetMinutes = 0;\n         }\n         else\n         {\n             into.zoneId = -1;\n-            into.zoneOffsetSeconds = asZoneOffset( encodedZone );\n+            into.zoneOffsetMinutes = asZoneOffset( encodedZone );\n         }\n         into.setEntityId( cursor.getLong() );\n     }\n \n     private int asZoneOffset( int encodedZone )\n     {\n-        return encodedZone;\n+        return (short) encodedZone;","path":"community/kernel/src/main/java/org/neo4j/kernel/impl/index/schema/ZonedDateTimeLayout.java","position":37,"original_position":37,"commit_id":"14f6510d1627b24f824468f08e563f532f2fca2c","original_commit_id":"af3bf82e8c60a753c3035f08efb8c3c67d4a2116","user":{"login":"Lojjs","id":7222590,"avatar_url":"https://avatars1.githubusercontent.com/u/7222590?v=4","gravatar_id":"","url":"https://api.github.com/users/Lojjs","html_url":"https://github.com/Lojjs","followers_url":"https://api.github.com/users/Lojjs/followers","following_url":"https://api.github.com/users/Lojjs/following{/other_user}","gists_url":"https://api.github.com/users/Lojjs/gists{/gist_id}","starred_url":"https://api.github.com/users/Lojjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lojjs/subscriptions","organizations_url":"https://api.github.com/users/Lojjs/orgs","repos_url":"https://api.github.com/users/Lojjs/repos","events_url":"https://api.github.com/users/Lojjs/events{/privacy}","received_events_url":"https://api.github.com/users/Lojjs/received_events","type":"User","site_admin":false},"body":"If you should benefit from returning a `short` here shouldn't the return type of the method also be `short`?","created_at":"2018-03-15T17:02:30Z","updated_at":"2018-03-15T17:11:10Z","html_url":"https://github.com/neo4j/neo4j/pull/11221#discussion_r174857800","pull_request_url":"https://api.github.com/repos/neo4j/neo4j/pulls/11221","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/174857800"},"html":{"href":"https://github.com/neo4j/neo4j/pull/11221#discussion_r174857800"},"pull_request":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/11221"}}},"pull_request":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/11221","id":174285019,"html_url":"https://github.com/neo4j/neo4j/pull/11221","diff_url":"https://github.com/neo4j/neo4j/pull/11221.diff","patch_url":"https://github.com/neo4j/neo4j/pull/11221.patch","issue_url":"https://api.github.com/repos/neo4j/neo4j/issues/11221","number":11221,"state":"open","locked":false,"title":"Temporal acceptance tests","user":{"login":"fickludd","id":3527193,"avatar_url":"https://avatars1.githubusercontent.com/u/3527193?v=4","gravatar_id":"","url":"https://api.github.com/users/fickludd","html_url":"https://github.com/fickludd","followers_url":"https://api.github.com/users/fickludd/followers","following_url":"https://api.github.com/users/fickludd/following{/other_user}","gists_url":"https://api.github.com/users/fickludd/gists{/gist_id}","starred_url":"https://api.github.com/users/fickludd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fickludd/subscriptions","organizations_url":"https://api.github.com/users/fickludd/orgs","repos_url":"https://api.github.com/users/fickludd/repos","events_url":"https://api.github.com/users/fickludd/events{/privacy}","received_events_url":"https://api.github.com/users/fickludd/received_events","type":"User","site_admin":false},"body":"This pull request contains mostly acceptance test refactoring and additions, testing both spatial and temporal indexing capabilities. Some minor bugs were detected and fixed, and others cardified. In particular, we ran into a bug with the spatial index which was deemed to hard to solve here, or possibly we are just missing something. \r\n\r\nIn the final commit we decided to completely refactor how `NodeIndexSeekPipe` execute index seeks, because this was to us very hard to understand. All logic around this is now encapsulated in the new trait `NodeIndexSeeker`, which directly creates the kernel API `IndexQuery` that is used to perform the index seeks. This is possible because we are new versioning cypher on the logical plan.\r\n\r\n~~Builds on temporal index IV (#11181), first commit is `split spatial index test classes into separate files`.~~","created_at":"2018-03-12T06:53:48Z","updated_at":"2018-03-15T17:11:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8b912c69ce930605bbd8b7c07e4fe6ae709f365","assignee":{"login":"Lojjs","id":7222590,"avatar_url":"https://avatars1.githubusercontent.com/u/7222590?v=4","gravatar_id":"","url":"https://api.github.com/users/Lojjs","html_url":"https://github.com/Lojjs","followers_url":"https://api.github.com/users/Lojjs/followers","following_url":"https://api.github.com/users/Lojjs/following{/other_user}","gists_url":"https://api.github.com/users/Lojjs/gists{/gist_id}","starred_url":"https://api.github.com/users/Lojjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lojjs/subscriptions","organizations_url":"https://api.github.com/users/Lojjs/orgs","repos_url":"https://api.github.com/users/Lojjs/repos","events_url":"https://api.github.com/users/Lojjs/events{/privacy}","received_events_url":"https://api.github.com/users/Lojjs/received_events","type":"User","site_admin":false},"assignees":[{"login":"Lojjs","id":7222590,"avatar_url":"https://avatars1.githubusercontent.com/u/7222590?v=4","gravatar_id":"","url":"https://api.github.com/users/Lojjs","html_url":"https://github.com/Lojjs","followers_url":"https://api.github.com/users/Lojjs/followers","following_url":"https://api.github.com/users/Lojjs/following{/other_user}","gists_url":"https://api.github.com/users/Lojjs/gists{/gist_id}","starred_url":"https://api.github.com/users/Lojjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lojjs/subscriptions","organizations_url":"https://api.github.com/users/Lojjs/orgs","repos_url":"https://api.github.com/users/Lojjs/repos","events_url":"https://api.github.com/users/Lojjs/events{/privacy}","received_events_url":"https://api.github.com/users/Lojjs/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":695463446,"url":"https://api.github.com/repos/neo4j/neo4j/labels/3.4","name":"3.4","color":"f9d0c4","default":false},{"id":19073042,"url":"https://api.github.com/repos/neo4j/neo4j/labels/cypher","name":"cypher","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/neo4j/neo4j/pulls/11221/commits","review_comments_url":"https://api.github.com/repos/neo4j/neo4j/pulls/11221/comments","review_comment_url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neo4j/neo4j/issues/11221/comments","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/14f6510d1627b24f824468f08e563f532f2fca2c","head":{"label":"fickludd:3.4-temporal-acceptance-tests","ref":"3.4-temporal-acceptance-tests","sha":"14f6510d1627b24f824468f08e563f532f2fca2c","user":{"login":"fickludd","id":3527193,"avatar_url":"https://avatars1.githubusercontent.com/u/3527193?v=4","gravatar_id":"","url":"https://api.github.com/users/fickludd","html_url":"https://github.com/fickludd","followers_url":"https://api.github.com/users/fickludd/followers","following_url":"https://api.github.com/users/fickludd/following{/other_user}","gists_url":"https://api.github.com/users/fickludd/gists{/gist_id}","starred_url":"https://api.github.com/users/fickludd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fickludd/subscriptions","organizations_url":"https://api.github.com/users/fickludd/orgs","repos_url":"https://api.github.com/users/fickludd/repos","events_url":"https://api.github.com/users/fickludd/events{/privacy}","received_events_url":"https://api.github.com/users/fickludd/received_events","type":"User","site_admin":false},"repo":{"id":60172359,"name":"neo4j","full_name":"fickludd/neo4j","owner":{"login":"fickludd","id":3527193,"avatar_url":"https://avatars1.githubusercontent.com/u/3527193?v=4","gravatar_id":"","url":"https://api.github.com/users/fickludd","html_url":"https://github.com/fickludd","followers_url":"https://api.github.com/users/fickludd/followers","following_url":"https://api.github.com/users/fickludd/following{/other_user}","gists_url":"https://api.github.com/users/fickludd/gists{/gist_id}","starred_url":"https://api.github.com/users/fickludd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fickludd/subscriptions","organizations_url":"https://api.github.com/users/fickludd/orgs","repos_url":"https://api.github.com/users/fickludd/repos","events_url":"https://api.github.com/users/fickludd/events{/privacy}","received_events_url":"https://api.github.com/users/fickludd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fickludd/neo4j","description":"Graphs for Everyone","fork":true,"url":"https://api.github.com/repos/fickludd/neo4j","forks_url":"https://api.github.com/repos/fickludd/neo4j/forks","keys_url":"https://api.github.com/repos/fickludd/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fickludd/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fickludd/neo4j/teams","hooks_url":"https://api.github.com/repos/fickludd/neo4j/hooks","issue_events_url":"https://api.github.com/repos/fickludd/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/fickludd/neo4j/events","assignees_url":"https://api.github.com/repos/fickludd/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/fickludd/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/fickludd/neo4j/tags","blobs_url":"https://api.github.com/repos/fickludd/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fickludd/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fickludd/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/fickludd/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fickludd/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/fickludd/neo4j/languages","stargazers_url":"https://api.github.com/repos/fickludd/neo4j/stargazers","contributors_url":"https://api.github.com/repos/fickludd/neo4j/contributors","subscribers_url":"https://api.github.com/repos/fickludd/neo4j/subscribers","subscription_url":"https://api.github.com/repos/fickludd/neo4j/subscription","commits_url":"https://api.github.com/repos/fickludd/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/fickludd/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/fickludd/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/fickludd/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/fickludd/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/fickludd/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fickludd/neo4j/merges","archive_url":"https://api.github.com/repos/fickludd/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fickludd/neo4j/downloads","issues_url":"https://api.github.com/repos/fickludd/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/fickludd/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/fickludd/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/fickludd/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fickludd/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/fickludd/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/fickludd/neo4j/deployments","created_at":"2016-06-01T11:49:30Z","updated_at":"2016-07-01T13:40:19Z","pushed_at":"2018-03-15T15:06:01Z","git_url":"git://github.com/fickludd/neo4j.git","ssh_url":"git@github.com:fickludd/neo4j.git","clone_url":"https://github.com/fickludd/neo4j.git","svn_url":"https://github.com/fickludd/neo4j","homepage":"http://neo4j.com","size":394079,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":1,"default_branch":"3.1"}},"base":{"label":"neo4j:3.4","ref":"3.4","sha":"88e7c1341e7ea61b0337b2c9f47880da5afd7c33","user":{"login":"neo4j","id":201120,"avatar_url":"https://avatars3.githubusercontent.com/u/201120?v=4","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"repo":{"id":6650539,"name":"neo4j","full_name":"neo4j/neo4j","owner":{"login":"neo4j","id":201120,"avatar_url":"https://avatars3.githubusercontent.com/u/201120?v=4","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neo4j/neo4j","description":"Graphs for Everyone","fork":false,"url":"https://api.github.com/repos/neo4j/neo4j","forks_url":"https://api.github.com/repos/neo4j/neo4j/forks","keys_url":"https://api.github.com/repos/neo4j/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo4j/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo4j/neo4j/teams","hooks_url":"https://api.github.com/repos/neo4j/neo4j/hooks","issue_events_url":"https://api.github.com/repos/neo4j/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/neo4j/neo4j/events","assignees_url":"https://api.github.com/repos/neo4j/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/neo4j/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/neo4j/neo4j/tags","blobs_url":"https://api.github.com/repos/neo4j/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo4j/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo4j/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo4j/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/neo4j/neo4j/languages","stargazers_url":"https://api.github.com/repos/neo4j/neo4j/stargazers","contributors_url":"https://api.github.com/repos/neo4j/neo4j/contributors","subscribers_url":"https://api.github.com/repos/neo4j/neo4j/subscribers","subscription_url":"https://api.github.com/repos/neo4j/neo4j/subscription","commits_url":"https://api.github.com/repos/neo4j/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo4j/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo4j/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo4j/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/neo4j/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/neo4j/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo4j/neo4j/merges","archive_url":"https://api.github.com/repos/neo4j/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo4j/neo4j/downloads","issues_url":"https://api.github.com/repos/neo4j/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/neo4j/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/neo4j/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/neo4j/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo4j/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/neo4j/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/neo4j/neo4j/deployments","created_at":"2012-11-12T08:46:15Z","updated_at":"2018-03-15T15:02:29Z","pushed_at":"2018-03-15T16:35:57Z","git_url":"git://github.com/neo4j/neo4j.git","ssh_url":"git@github.com:neo4j/neo4j.git","clone_url":"https://github.com/neo4j/neo4j.git","svn_url":"https://github.com/neo4j/neo4j","homepage":"http://neo4j.com","size":394338,"stargazers_count":4824,"watchers_count":4824,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1300,"mirror_url":null,"archived":false,"open_issues_count":342,"license":null,"forks":1300,"open_issues":342,"watchers":4824,"default_branch":"3.4"}},"_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/11221"},"html":{"href":"https://github.com/neo4j/neo4j/pull/11221"},"issue":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/11221"},"comments":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/11221/comments"},"review_comments":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/11221/comments"},"review_comment":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/11221/commits"},"statuses":{"href":"https://api.github.com/repos/neo4j/neo4j/statuses/14f6510d1627b24f824468f08e563f532f2fca2c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Lojjs"}}