{"action":"created","comment":{"url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/comments/228584466","pull_request_review_id":168896459,"id":228584466,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODU4NDQ2Ng==","diff_hunk":"@@ -36,17 +36,13 @@ func (b *Builder) getLatestUpstreamVersion() (string, error) {\n // initDirs creates the directories mixer uses\n func (b *Builder) initDirs() error {\n \t// Create folder to store local rpms if defined but doesn't already exist\n-\tif b.Config.Mixer.LocalRPMDir != \"\" {\n-\t\tif err := os.MkdirAll(b.Config.Mixer.LocalRPMDir, 0777); err != nil {\n-\t\t\treturn errors.Wrap(err, \"Failed to create local rpms directory\")\n-\t\t}\n+\tif err := os.MkdirAll(b.Config.Mixer.LocalRPMDir, 0777); err != nil {","path":"builder/init.go","position":8,"original_position":8,"commit_id":"e85a2aaf0095611e7d1d1fb001f505b14559848c","original_commit_id":"e85a2aaf0095611e7d1d1fb001f505b14559848c","user":{"login":"matthewrsj","id":12090084,"node_id":"MDQ6VXNlcjEyMDkwMDg0","avatar_url":"https://avatars0.githubusercontent.com/u/12090084?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewrsj","html_url":"https://github.com/matthewrsj","followers_url":"https://api.github.com/users/matthewrsj/followers","following_url":"https://api.github.com/users/matthewrsj/following{/other_user}","gists_url":"https://api.github.com/users/matthewrsj/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewrsj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewrsj/subscriptions","organizations_url":"https://api.github.com/users/matthewrsj/orgs","repos_url":"https://api.github.com/users/matthewrsj/repos","events_url":"https://api.github.com/users/matthewrsj/events{/privacy}","received_events_url":"https://api.github.com/users/matthewrsj/received_events","type":"User","site_admin":false},"body":"Anyways, I don't see the hard failure as a big deal, I just wanted to bring it up.","created_at":"2018-10-26T16:11:23Z","updated_at":"2018-10-26T16:11:23Z","html_url":"https://github.com/clearlinux/mixer-tools/pull/486#discussion_r228584466","pull_request_url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/486","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/comments/228584466"},"html":{"href":"https://github.com/clearlinux/mixer-tools/pull/486#discussion_r228584466"},"pull_request":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/486"}},"in_reply_to_id":228566295},"pull_request":{"url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/486","id":226085101,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MDg1MTAx","html_url":"https://github.com/clearlinux/mixer-tools/pull/486","diff_url":"https://github.com/clearlinux/mixer-tools/pull/486.diff","patch_url":"https://github.com/clearlinux/mixer-tools/pull/486.patch","issue_url":"https://api.github.com/repos/clearlinux/mixer-tools/issues/486","number":486,"state":"open","locked":false,"title":"init: Always set localrpms","user":{"login":"rchiossi","id":232189,"node_id":"MDQ6VXNlcjIzMjE4OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/232189?v=4","gravatar_id":"","url":"https://api.github.com/users/rchiossi","html_url":"https://github.com/rchiossi","followers_url":"https://api.github.com/users/rchiossi/followers","following_url":"https://api.github.com/users/rchiossi/following{/other_user}","gists_url":"https://api.github.com/users/rchiossi/gists{/gist_id}","starred_url":"https://api.github.com/users/rchiossi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchiossi/subscriptions","organizations_url":"https://api.github.com/users/rchiossi/orgs","repos_url":"https://api.github.com/users/rchiossi/repos","events_url":"https://api.github.com/users/rchiossi/events{/privacy}","received_events_url":"https://api.github.com/users/rchiossi/received_events","type":"User","site_admin":false},"body":"The existence of local repo and local rpms folder has no impact if they\r\nare not used in the mix. This patch removes the `--local-rpms` flag for\r\n`mixer init` and make it always true. This way both folders are always\r\ncreated and configured in builder.conf during init.\r\n\r\nThis patch also update the test cases for config convert to address this\r\nchange since.\r\n\r\nSigned-off-by: Rodrigo Chiossi <rodrigo.chiossi@intel.com>","created_at":"2018-10-26T12:45:06Z","updated_at":"2018-10-26T16:11:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a891e868ec250556963b49efea7bba47cb112bf8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/486/commits","review_comments_url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/486/comments","review_comment_url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/clearlinux/mixer-tools/issues/486/comments","statuses_url":"https://api.github.com/repos/clearlinux/mixer-tools/statuses/e85a2aaf0095611e7d1d1fb001f505b14559848c","head":{"label":"rchiossi:localrpms","ref":"localrpms","sha":"e85a2aaf0095611e7d1d1fb001f505b14559848c","user":{"login":"rchiossi","id":232189,"node_id":"MDQ6VXNlcjIzMjE4OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/232189?v=4","gravatar_id":"","url":"https://api.github.com/users/rchiossi","html_url":"https://github.com/rchiossi","followers_url":"https://api.github.com/users/rchiossi/followers","following_url":"https://api.github.com/users/rchiossi/following{/other_user}","gists_url":"https://api.github.com/users/rchiossi/gists{/gist_id}","starred_url":"https://api.github.com/users/rchiossi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchiossi/subscriptions","organizations_url":"https://api.github.com/users/rchiossi/orgs","repos_url":"https://api.github.com/users/rchiossi/repos","events_url":"https://api.github.com/users/rchiossi/events{/privacy}","received_events_url":"https://api.github.com/users/rchiossi/received_events","type":"User","site_admin":false},"repo":{"id":113222146,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMyMjIxNDY=","name":"mixer-tools","full_name":"rchiossi/mixer-tools","private":false,"owner":{"login":"rchiossi","id":232189,"node_id":"MDQ6VXNlcjIzMjE4OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/232189?v=4","gravatar_id":"","url":"https://api.github.com/users/rchiossi","html_url":"https://github.com/rchiossi","followers_url":"https://api.github.com/users/rchiossi/followers","following_url":"https://api.github.com/users/rchiossi/following{/other_user}","gists_url":"https://api.github.com/users/rchiossi/gists{/gist_id}","starred_url":"https://api.github.com/users/rchiossi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchiossi/subscriptions","organizations_url":"https://api.github.com/users/rchiossi/orgs","repos_url":"https://api.github.com/users/rchiossi/repos","events_url":"https://api.github.com/users/rchiossi/events{/privacy}","received_events_url":"https://api.github.com/users/rchiossi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rchiossi/mixer-tools","description":null,"fork":true,"url":"https://api.github.com/repos/rchiossi/mixer-tools","forks_url":"https://api.github.com/repos/rchiossi/mixer-tools/forks","keys_url":"https://api.github.com/repos/rchiossi/mixer-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rchiossi/mixer-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rchiossi/mixer-tools/teams","hooks_url":"https://api.github.com/repos/rchiossi/mixer-tools/hooks","issue_events_url":"https://api.github.com/repos/rchiossi/mixer-tools/issues/events{/number}","events_url":"https://api.github.com/repos/rchiossi/mixer-tools/events","assignees_url":"https://api.github.com/repos/rchiossi/mixer-tools/assignees{/user}","branches_url":"https://api.github.com/repos/rchiossi/mixer-tools/branches{/branch}","tags_url":"https://api.github.com/repos/rchiossi/mixer-tools/tags","blobs_url":"https://api.github.com/repos/rchiossi/mixer-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rchiossi/mixer-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rchiossi/mixer-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/rchiossi/mixer-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rchiossi/mixer-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/rchiossi/mixer-tools/languages","stargazers_url":"https://api.github.com/repos/rchiossi/mixer-tools/stargazers","contributors_url":"https://api.github.com/repos/rchiossi/mixer-tools/contributors","subscribers_url":"https://api.github.com/repos/rchiossi/mixer-tools/subscribers","subscription_url":"https://api.github.com/repos/rchiossi/mixer-tools/subscription","commits_url":"https://api.github.com/repos/rchiossi/mixer-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/rchiossi/mixer-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/rchiossi/mixer-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/rchiossi/mixer-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/rchiossi/mixer-tools/contents/{+path}","compare_url":"https://api.github.com/repos/rchiossi/mixer-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rchiossi/mixer-tools/merges","archive_url":"https://api.github.com/repos/rchiossi/mixer-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rchiossi/mixer-tools/downloads","issues_url":"https://api.github.com/repos/rchiossi/mixer-tools/issues{/number}","pulls_url":"https://api.github.com/repos/rchiossi/mixer-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/rchiossi/mixer-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/rchiossi/mixer-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rchiossi/mixer-tools/labels{/name}","releases_url":"https://api.github.com/repos/rchiossi/mixer-tools/releases{/id}","deployments_url":"https://api.github.com/repos/rchiossi/mixer-tools/deployments","created_at":"2017-12-05T19:09:03Z","updated_at":"2018-10-17T20:26:30Z","pushed_at":"2018-10-26T16:02:46Z","git_url":"git://github.com/rchiossi/mixer-tools.git","ssh_url":"git@github.com:rchiossi/mixer-tools.git","clone_url":"https://github.com/rchiossi/mixer-tools.git","svn_url":"https://github.com/rchiossi/mixer-tools","homepage":null,"size":1654,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"clearlinux:master","ref":"master","sha":"99e8091205ee979b5d328734b294cad065e14784","user":{"login":"clearlinux","id":12545216,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTQ1MjE2","avatar_url":"https://avatars2.githubusercontent.com/u/12545216?v=4","gravatar_id":"","url":"https://api.github.com/users/clearlinux","html_url":"https://github.com/clearlinux","followers_url":"https://api.github.com/users/clearlinux/followers","following_url":"https://api.github.com/users/clearlinux/following{/other_user}","gists_url":"https://api.github.com/users/clearlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/clearlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clearlinux/subscriptions","organizations_url":"https://api.github.com/users/clearlinux/orgs","repos_url":"https://api.github.com/users/clearlinux/repos","events_url":"https://api.github.com/users/clearlinux/events{/privacy}","received_events_url":"https://api.github.com/users/clearlinux/received_events","type":"Organization","site_admin":false},"repo":{"id":54439474,"node_id":"MDEwOlJlcG9zaXRvcnk1NDQzOTQ3NA==","name":"mixer-tools","full_name":"clearlinux/mixer-tools","private":false,"owner":{"login":"clearlinux","id":12545216,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTQ1MjE2","avatar_url":"https://avatars2.githubusercontent.com/u/12545216?v=4","gravatar_id":"","url":"https://api.github.com/users/clearlinux","html_url":"https://github.com/clearlinux","followers_url":"https://api.github.com/users/clearlinux/followers","following_url":"https://api.github.com/users/clearlinux/following{/other_user}","gists_url":"https://api.github.com/users/clearlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/clearlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clearlinux/subscriptions","organizations_url":"https://api.github.com/users/clearlinux/orgs","repos_url":"https://api.github.com/users/clearlinux/repos","events_url":"https://api.github.com/users/clearlinux/events{/privacy}","received_events_url":"https://api.github.com/users/clearlinux/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/clearlinux/mixer-tools","description":null,"fork":false,"url":"https://api.github.com/repos/clearlinux/mixer-tools","forks_url":"https://api.github.com/repos/clearlinux/mixer-tools/forks","keys_url":"https://api.github.com/repos/clearlinux/mixer-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clearlinux/mixer-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clearlinux/mixer-tools/teams","hooks_url":"https://api.github.com/repos/clearlinux/mixer-tools/hooks","issue_events_url":"https://api.github.com/repos/clearlinux/mixer-tools/issues/events{/number}","events_url":"https://api.github.com/repos/clearlinux/mixer-tools/events","assignees_url":"https://api.github.com/repos/clearlinux/mixer-tools/assignees{/user}","branches_url":"https://api.github.com/repos/clearlinux/mixer-tools/branches{/branch}","tags_url":"https://api.github.com/repos/clearlinux/mixer-tools/tags","blobs_url":"https://api.github.com/repos/clearlinux/mixer-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clearlinux/mixer-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clearlinux/mixer-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/clearlinux/mixer-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clearlinux/mixer-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/clearlinux/mixer-tools/languages","stargazers_url":"https://api.github.com/repos/clearlinux/mixer-tools/stargazers","contributors_url":"https://api.github.com/repos/clearlinux/mixer-tools/contributors","subscribers_url":"https://api.github.com/repos/clearlinux/mixer-tools/subscribers","subscription_url":"https://api.github.com/repos/clearlinux/mixer-tools/subscription","commits_url":"https://api.github.com/repos/clearlinux/mixer-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/clearlinux/mixer-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/clearlinux/mixer-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/clearlinux/mixer-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/clearlinux/mixer-tools/contents/{+path}","compare_url":"https://api.github.com/repos/clearlinux/mixer-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clearlinux/mixer-tools/merges","archive_url":"https://api.github.com/repos/clearlinux/mixer-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clearlinux/mixer-tools/downloads","issues_url":"https://api.github.com/repos/clearlinux/mixer-tools/issues{/number}","pulls_url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/clearlinux/mixer-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/clearlinux/mixer-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clearlinux/mixer-tools/labels{/name}","releases_url":"https://api.github.com/repos/clearlinux/mixer-tools/releases{/id}","deployments_url":"https://api.github.com/repos/clearlinux/mixer-tools/deployments","created_at":"2016-03-22T02:38:26Z","updated_at":"2018-10-24T04:48:35Z","pushed_at":"2018-10-26T14:26:42Z","git_url":"git://github.com/clearlinux/mixer-tools.git","ssh_url":"git@github.com:clearlinux/mixer-tools.git","clone_url":"https://github.com/clearlinux/mixer-tools.git","svn_url":"https://github.com/clearlinux/mixer-tools","homepage":null,"size":1541,"stargazers_count":5,"watchers_count":5,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":54,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":20,"open_issues":54,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/486"},"html":{"href":"https://github.com/clearlinux/mixer-tools/pull/486"},"issue":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/issues/486"},"comments":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/issues/486/comments"},"review_comments":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/486/comments"},"review_comment":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/486/commits"},"statuses":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/statuses/e85a2aaf0095611e7d1d1fb001f505b14559848c"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"matthewrsj"}}