{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/charts/pulls/comments/199560228","pull_request_review_id":133703483,"id":199560228,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTU2MDIyOA==","diff_hunk":"@@ -0,0 +1,70 @@\n+apiVersion: v1\n+kind: Service\n+metadata:\n+  name: {{ template \"fullname\" . }}-halyard\n+  labels:\n+    app: {{ template \"fullname\" . }}\n+    component: halyard\n+spec:\n+  ports:\n+  - port: 8064\n+    name: daemon\n+  clusterIP: None\n+  selector:\n+    app: {{ template \"fullname\" . }}\n+    component: halyard\n+---\n+apiVersion: apps/v1\n+kind: StatefulSet\n+metadata:\n+  name: {{ template \"fullname\" . }}-halyard\n+spec:\n+  serviceName: {{ template \"fullname\" . }}-halyard\n+  replicas: 1\n+  selector:\n+    matchLabels:\n+      app: {{ template \"fullname\" . }}\n+      component: halyard\n+  template:\n+    metadata:\n+      labels:\n+        app: {{ template \"fullname\" . }}\n+        component: halyard\n+    spec:\n+      securityContext:\n+        runAsUser: 1000\n+        fsGroup: 1000\n+      initContainers:\n+      - name: \"create-halyard-local\"\n+        image: {{ .Values.halyard.image.repository }}:{{ .Values.halyard.image.tag }}\n+        command:\n+        - bash\n+        - -c\n+        - \"cp /opt/halyard/config/* /tmp/config && printf 'server:\\n  address: 0.0.0.0\\n' > /tmp/config/halyard-local.yml\"","path":"stable/spinnaker/templates/statefulsets/halyard.yaml","position":null,"original_position":43,"commit_id":"a397e5f0a644685a043a514b489cc6ec865f5b4f","original_commit_id":"d5f558bda603d4d28f0ef07b490681cb23ecd6bf","user":{"login":"viglesiasce","id":410279,"node_id":"MDQ6VXNlcjQxMDI3OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/410279?v=4","gravatar_id":"","url":"https://api.github.com/users/viglesiasce","html_url":"https://github.com/viglesiasce","followers_url":"https://api.github.com/users/viglesiasce/followers","following_url":"https://api.github.com/users/viglesiasce/following{/other_user}","gists_url":"https://api.github.com/users/viglesiasce/gists{/gist_id}","starred_url":"https://api.github.com/users/viglesiasce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viglesiasce/subscriptions","organizations_url":"https://api.github.com/users/viglesiasce/orgs","repos_url":"https://api.github.com/users/viglesiasce/repos","events_url":"https://api.github.com/users/viglesiasce/events{/privacy}","received_events_url":"https://api.github.com/users/viglesiasce/received_events","type":"User","site_admin":false},"body":"Done! Good call.","created_at":"2018-07-02T16:55:58Z","updated_at":"2018-07-02T16:55:58Z","html_url":"https://github.com/kubernetes/charts/pull/6407#discussion_r199560228","pull_request_url":"https://api.github.com/repos/kubernetes/charts/pulls/6407","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/comments/199560228"},"html":{"href":"https://github.com/kubernetes/charts/pull/6407#discussion_r199560228"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/6407"}},"in_reply_to_id":199558188},"pull_request":{"url":"https://api.github.com/repos/kubernetes/charts/pulls/6407","id":198432972,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NDMyOTcy","html_url":"https://github.com/kubernetes/charts/pull/6407","diff_url":"https://github.com/kubernetes/charts/pull/6407.diff","patch_url":"https://github.com/kubernetes/charts/pull/6407.patch","issue_url":"https://api.github.com/repos/kubernetes/charts/issues/6407","number":6407,"state":"open","locked":false,"title":"[stable/spinnaker] Leverage Halyard for installation","user":{"login":"viglesiasce","id":410279,"node_id":"MDQ6VXNlcjQxMDI3OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/410279?v=4","gravatar_id":"","url":"https://api.github.com/users/viglesiasce","html_url":"https://github.com/viglesiasce","followers_url":"https://api.github.com/users/viglesiasce/followers","following_url":"https://api.github.com/users/viglesiasce/following{/other_user}","gists_url":"https://api.github.com/users/viglesiasce/gists{/gist_id}","starred_url":"https://api.github.com/users/viglesiasce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viglesiasce/subscriptions","organizations_url":"https://api.github.com/users/viglesiasce/orgs","repos_url":"https://api.github.com/users/viglesiasce/repos","events_url":"https://api.github.com/users/viglesiasce/events{/privacy}","received_events_url":"https://api.github.com/users/viglesiasce/received_events","type":"User","site_admin":false},"body":"This pull requests removes most of the installation logic from the chart and instead leverages [Halyard](https://www.spinnaker.io/reference/halyard/), the Spinnaker project's tool for creating, configuring, and managing Spinnaker deployments.\r\n\r\nBenefits:\r\n1. Much easier customization\r\n2. Less burden to update Spinnaker version (one liner)\r\n3. Spinnaker Kubernetes v2 provider support\r\n4. Decouples Jenkins installation\r\n5. 2000 less lines of code to maintain","created_at":"2018-06-29T21:53:33Z","updated_at":"2018-07-02T16:55:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b01e9cd7ea712372749e1b7f48058cdab66fb4ce","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mattfarina","id":62991,"node_id":"MDQ6VXNlcjYyOTkx","avatar_url":"https://avatars2.githubusercontent.com/u/62991?v=4","gravatar_id":"","url":"https://api.github.com/users/mattfarina","html_url":"https://github.com/mattfarina","followers_url":"https://api.github.com/users/mattfarina/followers","following_url":"https://api.github.com/users/mattfarina/following{/other_user}","gists_url":"https://api.github.com/users/mattfarina/gists{/gist_id}","starred_url":"https://api.github.com/users/mattfarina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattfarina/subscriptions","organizations_url":"https://api.github.com/users/mattfarina/orgs","repos_url":"https://api.github.com/users/mattfarina/repos","events_url":"https://api.github.com/users/mattfarina/events{/privacy}","received_events_url":"https://api.github.com/users/mattfarina/received_events","type":"User","site_admin":false},{"login":"scottrigby","id":407675,"node_id":"MDQ6VXNlcjQwNzY3NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/407675?v=4","gravatar_id":"","url":"https://api.github.com/users/scottrigby","html_url":"https://github.com/scottrigby","followers_url":"https://api.github.com/users/scottrigby/followers","following_url":"https://api.github.com/users/scottrigby/following{/other_user}","gists_url":"https://api.github.com/users/scottrigby/gists{/gist_id}","starred_url":"https://api.github.com/users/scottrigby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottrigby/subscriptions","organizations_url":"https://api.github.com/users/scottrigby/orgs","repos_url":"https://api.github.com/users/scottrigby/repos","events_url":"https://api.github.com/users/scottrigby/events{/privacy}","received_events_url":"https://api.github.com/users/scottrigby/received_events","type":"User","site_admin":false},{"login":"sameersbn","id":410147,"node_id":"MDQ6VXNlcjQxMDE0Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/410147?v=4","gravatar_id":"","url":"https://api.github.com/users/sameersbn","html_url":"https://github.com/sameersbn","followers_url":"https://api.github.com/users/sameersbn/followers","following_url":"https://api.github.com/users/sameersbn/following{/other_user}","gists_url":"https://api.github.com/users/sameersbn/gists{/gist_id}","starred_url":"https://api.github.com/users/sameersbn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sameersbn/subscriptions","organizations_url":"https://api.github.com/users/sameersbn/orgs","repos_url":"https://api.github.com/users/sameersbn/repos","events_url":"https://api.github.com/users/sameersbn/events{/privacy}","received_events_url":"https://api.github.com/users/sameersbn/received_events","type":"User","site_admin":false},{"login":"timstoop","id":729432,"node_id":"MDQ6VXNlcjcyOTQzMg==","avatar_url":"https://avatars2.githubusercontent.com/u/729432?v=4","gravatar_id":"","url":"https://api.github.com/users/timstoop","html_url":"https://github.com/timstoop","followers_url":"https://api.github.com/users/timstoop/followers","following_url":"https://api.github.com/users/timstoop/following{/other_user}","gists_url":"https://api.github.com/users/timstoop/gists{/gist_id}","starred_url":"https://api.github.com/users/timstoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timstoop/subscriptions","organizations_url":"https://api.github.com/users/timstoop/orgs","repos_url":"https://api.github.com/users/timstoop/repos","events_url":"https://api.github.com/users/timstoop/events{/privacy}","received_events_url":"https://api.github.com/users/timstoop/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":764227863,"node_id":"MDU6TGFiZWw3NjQyMjc4NjM=","url":"https://api.github.com/repos/kubernetes/charts/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":484586588,"node_id":"MDU6TGFiZWw0ODQ1ODY1ODg=","url":"https://api.github.com/repos/kubernetes/charts/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":676666529,"node_id":"MDU6TGFiZWw2NzY2NjY1Mjk=","url":"https://api.github.com/repos/kubernetes/charts/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/charts/pulls/6407/commits","review_comments_url":"https://api.github.com/repos/kubernetes/charts/pulls/6407/comments","review_comment_url":"https://api.github.com/repos/kubernetes/charts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/charts/issues/6407/comments","statuses_url":"https://api.github.com/repos/kubernetes/charts/statuses/a397e5f0a644685a043a514b489cc6ec865f5b4f","head":{"label":"viglesiasce:spin-v1.0.0","ref":"spin-v1.0.0","sha":"a397e5f0a644685a043a514b489cc6ec865f5b4f","user":{"login":"viglesiasce","id":410279,"node_id":"MDQ6VXNlcjQxMDI3OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/410279?v=4","gravatar_id":"","url":"https://api.github.com/users/viglesiasce","html_url":"https://github.com/viglesiasce","followers_url":"https://api.github.com/users/viglesiasce/followers","following_url":"https://api.github.com/users/viglesiasce/following{/other_user}","gists_url":"https://api.github.com/users/viglesiasce/gists{/gist_id}","starred_url":"https://api.github.com/users/viglesiasce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viglesiasce/subscriptions","organizations_url":"https://api.github.com/users/viglesiasce/orgs","repos_url":"https://api.github.com/users/viglesiasce/repos","events_url":"https://api.github.com/users/viglesiasce/events{/privacy}","received_events_url":"https://api.github.com/users/viglesiasce/received_events","type":"User","site_admin":false},"repo":{"id":61092892,"node_id":"MDEwOlJlcG9zaXRvcnk2MTA5Mjg5Mg==","name":"charts","full_name":"viglesiasce/charts","owner":{"login":"viglesiasce","id":410279,"node_id":"MDQ6VXNlcjQxMDI3OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/410279?v=4","gravatar_id":"","url":"https://api.github.com/users/viglesiasce","html_url":"https://github.com/viglesiasce","followers_url":"https://api.github.com/users/viglesiasce/followers","following_url":"https://api.github.com/users/viglesiasce/following{/other_user}","gists_url":"https://api.github.com/users/viglesiasce/gists{/gist_id}","starred_url":"https://api.github.com/users/viglesiasce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viglesiasce/subscriptions","organizations_url":"https://api.github.com/users/viglesiasce/orgs","repos_url":"https://api.github.com/users/viglesiasce/repos","events_url":"https://api.github.com/users/viglesiasce/events{/privacy}","received_events_url":"https://api.github.com/users/viglesiasce/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/viglesiasce/charts","description":"Curated applications for Kubernetes using Helm charts with integrated Deployment Manager templates","fork":true,"url":"https://api.github.com/repos/viglesiasce/charts","forks_url":"https://api.github.com/repos/viglesiasce/charts/forks","keys_url":"https://api.github.com/repos/viglesiasce/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/viglesiasce/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/viglesiasce/charts/teams","hooks_url":"https://api.github.com/repos/viglesiasce/charts/hooks","issue_events_url":"https://api.github.com/repos/viglesiasce/charts/issues/events{/number}","events_url":"https://api.github.com/repos/viglesiasce/charts/events","assignees_url":"https://api.github.com/repos/viglesiasce/charts/assignees{/user}","branches_url":"https://api.github.com/repos/viglesiasce/charts/branches{/branch}","tags_url":"https://api.github.com/repos/viglesiasce/charts/tags","blobs_url":"https://api.github.com/repos/viglesiasce/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/viglesiasce/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/viglesiasce/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/viglesiasce/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/viglesiasce/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/viglesiasce/charts/languages","stargazers_url":"https://api.github.com/repos/viglesiasce/charts/stargazers","contributors_url":"https://api.github.com/repos/viglesiasce/charts/contributors","subscribers_url":"https://api.github.com/repos/viglesiasce/charts/subscribers","subscription_url":"https://api.github.com/repos/viglesiasce/charts/subscription","commits_url":"https://api.github.com/repos/viglesiasce/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/viglesiasce/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/viglesiasce/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/viglesiasce/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/viglesiasce/charts/contents/{+path}","compare_url":"https://api.github.com/repos/viglesiasce/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/viglesiasce/charts/merges","archive_url":"https://api.github.com/repos/viglesiasce/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/viglesiasce/charts/downloads","issues_url":"https://api.github.com/repos/viglesiasce/charts/issues{/number}","pulls_url":"https://api.github.com/repos/viglesiasce/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/viglesiasce/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/viglesiasce/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/viglesiasce/charts/labels{/name}","releases_url":"https://api.github.com/repos/viglesiasce/charts/releases{/id}","deployments_url":"https://api.github.com/repos/viglesiasce/charts/deployments","created_at":"2016-06-14T04:57:41Z","updated_at":"2017-05-04T16:53:54Z","pushed_at":"2018-07-02T16:55:50Z","git_url":"git://github.com/viglesiasce/charts.git","ssh_url":"git@github.com:viglesiasce/charts.git","clone_url":"https://github.com/viglesiasce/charts.git","svn_url":"https://github.com/viglesiasce/charts","homepage":"","size":8246,"stargazers_count":0,"watchers_count":0,"language":"Smarty","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"d5951228356f52d45c57bb3d794faecdd7677a2f","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":46806184,"node_id":"MDEwOlJlcG9zaXRvcnk0NjgwNjE4NA==","name":"charts","full_name":"kubernetes/charts","owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/charts","description":"Curated applications for Kubernetes","fork":false,"url":"https://api.github.com/repos/kubernetes/charts","forks_url":"https://api.github.com/repos/kubernetes/charts/forks","keys_url":"https://api.github.com/repos/kubernetes/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/charts/teams","hooks_url":"https://api.github.com/repos/kubernetes/charts/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/charts/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/charts/events","assignees_url":"https://api.github.com/repos/kubernetes/charts/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/charts/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/charts/tags","blobs_url":"https://api.github.com/repos/kubernetes/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/charts/languages","stargazers_url":"https://api.github.com/repos/kubernetes/charts/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/charts/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/charts/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/charts/subscription","commits_url":"https://api.github.com/repos/kubernetes/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/charts/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/charts/merges","archive_url":"https://api.github.com/repos/kubernetes/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/charts/downloads","issues_url":"https://api.github.com/repos/kubernetes/charts/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/charts/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/charts/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/charts/deployments","created_at":"2015-11-24T17:05:28Z","updated_at":"2018-07-02T13:15:24Z","pushed_at":"2018-07-02T16:55:52Z","git_url":"git://github.com/kubernetes/charts.git","ssh_url":"git@github.com:kubernetes/charts.git","clone_url":"https://github.com/kubernetes/charts.git","svn_url":"https://github.com/kubernetes/charts","homepage":"","size":8738,"stargazers_count":3686,"watchers_count":3686,"language":"Smarty","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3187,"mirror_url":null,"archived":false,"open_issues_count":729,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3187,"open_issues":729,"watchers":3686,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/6407"},"html":{"href":"https://github.com/kubernetes/charts/pull/6407"},"issue":{"href":"https://api.github.com/repos/kubernetes/charts/issues/6407"},"comments":{"href":"https://api.github.com/repos/kubernetes/charts/issues/6407/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/6407/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/6407/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/charts/statuses/a397e5f0a644685a043a514b489cc6ec865f5b4f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"viglesiasce"}}