{"action":"created","issue":{"url":"https://api.github.com/repos/eventespresso/event-espresso-core/issues/815","repository_url":"https://api.github.com/repos/eventespresso/event-espresso-core","labels_url":"https://api.github.com/repos/eventespresso/event-espresso-core/issues/815/labels{/name}","comments_url":"https://api.github.com/repos/eventespresso/event-espresso-core/issues/815/comments","events_url":"https://api.github.com/repos/eventespresso/event-espresso-core/issues/815/events","html_url":"https://github.com/eventespresso/event-espresso-core/pull/815","id":389565265,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NTI3MzQw","number":815,"title":"don’t load our blocks framework if in Divi front-end editor context","user":{"login":"nerrad","id":1429108,"node_id":"MDQ6VXNlcjE0MjkxMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1429108?v=4","gravatar_id":"","url":"https://api.github.com/users/nerrad","html_url":"https://github.com/nerrad","followers_url":"https://api.github.com/users/nerrad/followers","following_url":"https://api.github.com/users/nerrad/following{/other_user}","gists_url":"https://api.github.com/users/nerrad/gists{/gist_id}","starred_url":"https://api.github.com/users/nerrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nerrad/subscriptions","organizations_url":"https://api.github.com/users/nerrad/orgs","repos_url":"https://api.github.com/users/nerrad/repos","events_url":"https://api.github.com/users/nerrad/events{/privacy}","received_events_url":"https://api.github.com/users/nerrad/received_events","type":"User","site_admin":false},"labels":[{"id":904083682,"node_id":"MDU6TGFiZWw5MDQwODM2ODI=","url":"https://api.github.com/repos/eventespresso/event-espresso-core/labels/category:3rd-party-integrations","name":"category:3rd-party-integrations","color":"abc2c1","default":false},{"id":886064778,"node_id":"MDU6TGFiZWw4ODYwNjQ3Nzg=","url":"https://api.github.com/repos/eventespresso/event-espresso-core/labels/category:assets","name":"category:assets","color":"abc2c1","default":false},{"id":883825333,"node_id":"MDU6TGFiZWw4ODM4MjUzMzM=","url":"https://api.github.com/repos/eventespresso/event-espresso-core/labels/category:gutenberg","name":"category:gutenberg","color":"abc2c1","default":false},{"id":904083909,"node_id":"MDU6TGFiZWw5MDQwODM5MDk=","url":"https://api.github.com/repos/eventespresso/event-espresso-core/labels/type:theme/plugin-conflict%20%F0%9F%92%A5","name":"type:theme/plugin-conflict 💥","color":"efefef","default":false}],"state":"open","locked":false,"assignee":{"login":"nerrad","id":1429108,"node_id":"MDQ6VXNlcjE0MjkxMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1429108?v=4","gravatar_id":"","url":"https://api.github.com/users/nerrad","html_url":"https://github.com/nerrad","followers_url":"https://api.github.com/users/nerrad/followers","following_url":"https://api.github.com/users/nerrad/following{/other_user}","gists_url":"https://api.github.com/users/nerrad/gists{/gist_id}","starred_url":"https://api.github.com/users/nerrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nerrad/subscriptions","organizations_url":"https://api.github.com/users/nerrad/orgs","repos_url":"https://api.github.com/users/nerrad/repos","events_url":"https://api.github.com/users/nerrad/events{/privacy}","received_events_url":"https://api.github.com/users/nerrad/received_events","type":"User","site_admin":false},"assignees":[{"login":"nerrad","id":1429108,"node_id":"MDQ6VXNlcjE0MjkxMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1429108?v=4","gravatar_id":"","url":"https://api.github.com/users/nerrad","html_url":"https://github.com/nerrad","followers_url":"https://api.github.com/users/nerrad/followers","following_url":"https://api.github.com/users/nerrad/following{/other_user}","gists_url":"https://api.github.com/users/nerrad/gists{/gist_id}","starred_url":"https://api.github.com/users/nerrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nerrad/subscriptions","organizations_url":"https://api.github.com/users/nerrad/orgs","repos_url":"https://api.github.com/users/nerrad/repos","events_url":"https://api.github.com/users/nerrad/events{/privacy}","received_events_url":"https://api.github.com/users/nerrad/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-12-11T02:04:27Z","updated_at":"2018-12-11T14:59:21Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/eventespresso/event-espresso-core/pulls/815","html_url":"https://github.com/eventespresso/event-espresso-core/pull/815","diff_url":"https://github.com/eventespresso/event-espresso-core/pull/815.diff","patch_url":"https://github.com/eventespresso/event-espresso-core/pull/815.patch"},"body":"<!-- Thanks for your pull request.  Comments within these type of tags will be hidden and not show up when you submit your pull request -->\r\n<!-- Please answer the following questions in order to expediate acceptance -->\r\n\r\n## Problem this Pull Request solves\r\n<!-- Please describe your changes in the context of the problem they solve -->\r\n\r\nSee #814 for background.  Essentially this pull kills any php side block registration (and thus any asset loading) when the divi frontend editor is loading.  Divi uses a request parameter (`et_fb`) when in that view so its trivial for us to just use that to kill loading.\r\n\r\nBrent, I don't generally like putting compatibility things for other plugins directly in our code like this, but in this case I'm _hoping_ that Divi gets on the ball and fixes the conflict issues on their end.  Essentially they are not accounting for the very real possibility that other plugins/themes could start using the WP core block api for loading react, lodash etc on the frontend (along with other `wp` packages). For now, we don't really care because divi doesn't really fully support GB anyways, they currently just _bypass_ the whole thing.\r\n\r\n## How has this been tested\r\n<!-- Please describe in detail how you tested your changes and how testing can be reproduced -->\r\n<!-- Include details of your testing environment, and tests ran to see how your changes affect other areas of code -->\r\n<!-- Include any notes about automated tests you've written for this pull request.  Pull requests with automated tests are preferred. -->\r\n\r\n* [x] tested against the issue reported in #814 with Divi loaded.\r\n* [x] Ensured our assets still load on other non divi frontend editor routes.\r\n\r\n## Checklist\r\n\r\n* [ ] I have read the documentation relating to systems affected by this pull request, see https://github.com/eventespresso/event-espresso-core/tree/master/docs\r\n* [ ] User input is adequately validated and sanitized\r\n* [ ] all publicly displayed strings are internationalized (usually using `esc_html__()`, see https://codex.wordpress.org/I18n_for_WordPress_Developers)\r\n* [ ] My code is tested.\r\n* [ ] My code follows the Event Espresso code style.\r\n* [ ] My code has proper inline documentation.\r\n* [ ] My code accounts for when the site is in Maintenance Mode (MM2 especially disallows usage of models)\r\n"},"comment":{"url":"https://api.github.com/repos/eventespresso/event-espresso-core/issues/comments/446232300","html_url":"https://github.com/eventespresso/event-espresso-core/pull/815#issuecomment-446232300","issue_url":"https://api.github.com/repos/eventespresso/event-espresso-core/issues/815","id":446232300,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjIzMjMwMA==","user":{"login":"joshfeck","id":891156,"node_id":"MDQ6VXNlcjg5MTE1Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/891156?v=4","gravatar_id":"","url":"https://api.github.com/users/joshfeck","html_url":"https://github.com/joshfeck","followers_url":"https://api.github.com/users/joshfeck/followers","following_url":"https://api.github.com/users/joshfeck/following{/other_user}","gists_url":"https://api.github.com/users/joshfeck/gists{/gist_id}","starred_url":"https://api.github.com/users/joshfeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshfeck/subscriptions","organizations_url":"https://api.github.com/users/joshfeck/orgs","repos_url":"https://api.github.com/users/joshfeck/repos","events_url":"https://api.github.com/users/joshfeck/events{/privacy}","received_events_url":"https://api.github.com/users/joshfeck/received_events","type":"User","site_admin":false},"created_at":"2018-12-11T14:59:21Z","updated_at":"2018-12-11T14:59:21Z","author_association":"CONTRIBUTOR","body":"re-tested and it still works. "}}
{"actor":{"display_login":"joshfeck"}}