{"action":"closed","issue":{"url":"https://api.github.com/repos/dmlc/nnvm/issues/351","repository_url":"https://api.github.com/repos/dmlc/nnvm","labels_url":"https://api.github.com/repos/dmlc/nnvm/issues/351/labels{/name}","comments_url":"https://api.github.com/repos/dmlc/nnvm/issues/351/comments","events_url":"https://api.github.com/repos/dmlc/nnvm/issues/351/events","html_url":"https://github.com/dmlc/nnvm/issues/351","id":293338978,"number":351,"title":"Build failure on Windows because of old submodule","user":{"login":"AtuNuka","id":34906252,"avatar_url":"https://avatars1.githubusercontent.com/u/34906252?v=4","gravatar_id":"","url":"https://api.github.com/users/AtuNuka","html_url":"https://github.com/AtuNuka","followers_url":"https://api.github.com/users/AtuNuka/followers","following_url":"https://api.github.com/users/AtuNuka/following{/other_user}","gists_url":"https://api.github.com/users/AtuNuka/gists{/gist_id}","starred_url":"https://api.github.com/users/AtuNuka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AtuNuka/subscriptions","organizations_url":"https://api.github.com/users/AtuNuka/orgs","repos_url":"https://api.github.com/users/AtuNuka/repos","events_url":"https://api.github.com/users/AtuNuka/events{/privacy}","received_events_url":"https://api.github.com/users/AtuNuka/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-01-31T22:42:53Z","updated_at":"2018-02-02T08:35:44Z","closed_at":"2018-02-02T08:35:44Z","author_association":"NONE","body":"Hi,\r\n\r\nNNVM/TVM is failed to build in newest version on Windows in below environment.\r\n\r\nNNVM Commit: dd4f6a9f95a45068252b2f32f7e07d1b07596740\r\nOS: Windows 10 Pro 64bit\r\nCompiler: Visual Studio 15 2017\r\n\r\n```\r\n2>C:\\Users\\nuka\\nnvm\\tvm\\src\\runtime\\workspace_pool.cc(31): error C2059: syntax error: '.'\r\n2>C:\\Users\\nuka\\nnvm\\tvm\\src\\runtime\\workspace_pool.cc(31): error C2143: syntax error: missing ';' before '}'\r\n2>C:\\Users\\nuka\\nnvm\\tvm\\src\\runtime\\workspace_pool.cc(32): error C2059: syntax error: 'if'\r\n2>C:\\Users\\nuka\\nnvm\\tvm\\src\\runtime\\workspace_pool.cc(32): error C2143: syntax error: missing ';' before '{'\r\n2>C:\\Users\\nuka\\nnvm\\tvm\\src\\runtime\\workspace_pool.cc(32): error C2447: '{': missing function header (old-style formal list?)\r\n2>C:\\Users\\nuka\\nnvm\\tvm\\src\\runtime\\workspace_pool.cc(41): error C2059: syntax error: 'else'\r\n2>C:\\Users\\nuka\\nnvm\\tvm\\src\\runtime\\workspace_pool.cc(41): error C2143: syntax error: missing ';' before '{'\r\n2>C:\\Users\\nuka\\nnvm\\tvm\\src\\runtime\\workspace_pool.cc(41): error C2447: '{': missing function header (old-style formal list?)\r\n\r\n<snip>\r\n```\r\n\r\nThis is because ```tvm/src/runtime/workspace_pool.cc``` uses GNU struct initialization. And it seems that this has already been fixed in tvm project.\r\n\r\nhttps://github.com/dmlc/tvm/commit/68b9aa9a05b5914a7c5cf2fce9fda13f4ea6f503#diff-06c69bd0cdfc13afd730c7658460da97\r\n\r\nSo, the real problem is that NNVM is pointing to the old TVM commit.\r\nI'd appreciate to update a submodule TVM to the latest or proper version.\r\n\r\nThanks."}}
{"actor":{"display_login":"AtuNuka"}}