{"action":"created","comment":{"url":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/pulls/comments/208354881","pull_request_review_id":144147051,"id":208354881,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODM1NDg4MQ==","diff_hunk":"@@ -663,12 +875,12 @@ public void testNoFilesWrittenWithoutCommit() throws Exception {\n     Partitioner<FieldSchema> partitioner = new DefaultPartitioner<>();\n     partitioner.configure(parsedConfig);\n     TopicPartitionWriter topicPartitionWriter = new TopicPartitionWriter(\n-        TOPIC_PARTITION, storage, writerProvider, partitioner,  connectorConfig, context);\n+        TOPIC_PARTITION, storage, writerProvider, partitioner, connectorConfig, context);\n \n     String key = \"key\";\n     Schema schema = createSchema();\n     List<Struct> records = createRecordBatches(schema, 3, 3);\n-\n+TimeUnit.SECONDS.toMillis(20);","path":"kafka-connect-s3/src/test/java/io/confluent/connect/s3/TopicPartitionWriterTest.java","position":426,"original_position":426,"commit_id":"1932a75b14d0c92d02d688a56355a4c4bbe34093","original_commit_id":"1932a75b14d0c92d02d688a56355a4c4bbe34093","user":{"login":"rhauch","id":84732,"node_id":"MDQ6VXNlcjg0NzMy","avatar_url":"https://avatars0.githubusercontent.com/u/84732?v=4","gravatar_id":"","url":"https://api.github.com/users/rhauch","html_url":"https://github.com/rhauch","followers_url":"https://api.github.com/users/rhauch/followers","following_url":"https://api.github.com/users/rhauch/following{/other_user}","gists_url":"https://api.github.com/users/rhauch/gists{/gist_id}","starred_url":"https://api.github.com/users/rhauch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhauch/subscriptions","organizations_url":"https://api.github.com/users/rhauch/orgs","repos_url":"https://api.github.com/users/rhauch/repos","events_url":"https://api.github.com/users/rhauch/events{/privacy}","received_events_url":"https://api.github.com/users/rhauch/received_events","type":"User","site_admin":false},"body":"What is this line attempting to do?","created_at":"2018-08-07T19:20:55Z","updated_at":"2018-08-07T19:25:01Z","html_url":"https://github.com/confluentinc/kafka-connect-storage-cloud/pull/187#discussion_r208354881","pull_request_url":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/pulls/187","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/pulls/comments/208354881"},"html":{"href":"https://github.com/confluentinc/kafka-connect-storage-cloud/pull/187#discussion_r208354881"},"pull_request":{"href":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/pulls/187"}}},"pull_request":{"url":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/pulls/187","id":202984171,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyOTg0MTcx","html_url":"https://github.com/confluentinc/kafka-connect-storage-cloud/pull/187","diff_url":"https://github.com/confluentinc/kafka-connect-storage-cloud/pull/187.diff","patch_url":"https://github.com/confluentinc/kafka-connect-storage-cloud/pull/187.patch","issue_url":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/issues/187","number":187,"state":"open","locked":false,"title":"CC-2313 Handle late arriving records in storage cloud sink connectors","user":{"login":"cyrusv","id":550611,"node_id":"MDQ6VXNlcjU1MDYxMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/550611?v=4","gravatar_id":"","url":"https://api.github.com/users/cyrusv","html_url":"https://github.com/cyrusv","followers_url":"https://api.github.com/users/cyrusv/followers","following_url":"https://api.github.com/users/cyrusv/following{/other_user}","gists_url":"https://api.github.com/users/cyrusv/gists{/gist_id}","starred_url":"https://api.github.com/users/cyrusv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyrusv/subscriptions","organizations_url":"https://api.github.com/users/cyrusv/orgs","repos_url":"https://api.github.com/users/cyrusv/repos","events_url":"https://api.github.com/users/cyrusv/events{/privacy}","received_events_url":"https://api.github.com/users/cyrusv/received_events","type":"User","site_admin":false},"body":"We had issues where late-arriving records would cause rollups of s3 files when they were part of the previous partition. \r\n\r\nFor example, consider an s3-sink configured for hourly rollups. Now, if we receive records from a previous partition (\"late-arriving\") then a separate rollup is triggered, so that the record does not appear in the wrong partition. Strictly speaking, this is expected behavior. However, there is demand to have an option to avoid these extra rollups in the event of a system with freqent late-arriving records causing pileup of numerous small files.\r\n\r\nThe proposed strategy is to add a new \"strict\" config option that lets users choose to put records from a previous partition in the current partition if it arrives late. By default, we will be in \"strict\" mode, preserving our current behavior. Some users will choose \"nonstrict\" option to have predictable, consistent file sizes, at the expense of occasionally having records in the wrong partition\r\n\r\nI wanted to check in and get feedback before grinding out all of the TODOs:\r\nTODOs:\r\n- Integrate with GCS and possible HDFS\r\n- Explore whether this behaves as expected for \"scheduled\" rotations\r\n- Explore putting the config in the \"common\" repo\r\n","created_at":"2018-07-21T01:09:19Z","updated_at":"2018-08-07T19:25:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dab4c6a10ee21b2e9b901eaa10b75eb3b59249c3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/pulls/187/commits","review_comments_url":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/pulls/187/comments","review_comment_url":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/pulls/comments{/number}","comments_url":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/issues/187/comments","statuses_url":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/statuses/1932a75b14d0c92d02d688a56355a4c4bbe34093","head":{"label":"cyrusv:cyrus-cc-2313-late-data","ref":"cyrus-cc-2313-late-data","sha":"1932a75b14d0c92d02d688a56355a4c4bbe34093","user":{"login":"cyrusv","id":550611,"node_id":"MDQ6VXNlcjU1MDYxMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/550611?v=4","gravatar_id":"","url":"https://api.github.com/users/cyrusv","html_url":"https://github.com/cyrusv","followers_url":"https://api.github.com/users/cyrusv/followers","following_url":"https://api.github.com/users/cyrusv/following{/other_user}","gists_url":"https://api.github.com/users/cyrusv/gists{/gist_id}","starred_url":"https://api.github.com/users/cyrusv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyrusv/subscriptions","organizations_url":"https://api.github.com/users/cyrusv/orgs","repos_url":"https://api.github.com/users/cyrusv/repos","events_url":"https://api.github.com/users/cyrusv/events{/privacy}","received_events_url":"https://api.github.com/users/cyrusv/received_events","type":"User","site_admin":false},"repo":{"id":135326920,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUzMjY5MjA=","name":"kafka-connect-storage-cloud","full_name":"cyrusv/kafka-connect-storage-cloud","owner":{"login":"cyrusv","id":550611,"node_id":"MDQ6VXNlcjU1MDYxMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/550611?v=4","gravatar_id":"","url":"https://api.github.com/users/cyrusv","html_url":"https://github.com/cyrusv","followers_url":"https://api.github.com/users/cyrusv/followers","following_url":"https://api.github.com/users/cyrusv/following{/other_user}","gists_url":"https://api.github.com/users/cyrusv/gists{/gist_id}","starred_url":"https://api.github.com/users/cyrusv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyrusv/subscriptions","organizations_url":"https://api.github.com/users/cyrusv/orgs","repos_url":"https://api.github.com/users/cyrusv/repos","events_url":"https://api.github.com/users/cyrusv/events{/privacy}","received_events_url":"https://api.github.com/users/cyrusv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cyrusv/kafka-connect-storage-cloud","description":"Kafka Connect suite of connectors for Cloud storage (currently including Amazon S3)","fork":true,"url":"https://api.github.com/repos/cyrusv/kafka-connect-storage-cloud","forks_url":"https://api.github.com/repos/cyrusv/kafka-connect-storage-cloud/forks","keys_url":"https://api.github.com/repos/cyrusv/kafka-connect-storage-cloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cyrusv/kafka-connect-storage-cloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cyrusv/kafka-connect-storage-cloud/teams","hooks_url":"https://api.github.com/repos/cyrusv/kafka-connect-storage-cloud/hooks","issue_events_url":"https://api.github.com/repos/cyrusv/kafka-connect-storage-cloud/issues/events{/number}","events_url":"https://api.github.com/repos/cyrusv/kafka-connect-storage-cloud/events","assignees_url":"https://api.github.com/repos/cyrusv/kafka-connect-storage-cloud/assignees{/user}","branches_url":"https://api.github.com/repos/cyrusv/kafka-connect-storage-cloud/branches{/branch}","tags_url":"https://api.github.com/repos/cyrusv/kafka-connect-storage-cloud/tags","blobs_url":"https://api.github.com/repos/cyrusv/kafka-connect-storage-cloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cyrusv/kafka-connect-storage-cloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cyrusv/kafka-connect-storage-cloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/cyrusv/kafka-connect-storage-cloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cyrusv/kafka-connect-storage-cloud/statuses/{sha}","languages_url":"https://api.github.com/repos/cyrusv/kafka-connect-storage-cloud/languages","stargazers_url":"https://api.github.com/repos/cyrusv/kafka-connect-storage-cloud/stargazers","contributors_url":"https://api.github.com/repos/cyrusv/kafka-connect-storage-cloud/contributors","subscribers_url":"https://api.github.com/repos/cyrusv/kafka-connect-storage-cloud/subscribers","subscription_url":"https://api.github.com/repos/cyrusv/kafka-connect-storage-cloud/subscription","commits_url":"https://api.github.com/repos/cyrusv/kafka-connect-storage-cloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/cyrusv/kafka-connect-storage-cloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/cyrusv/kafka-connect-storage-cloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/cyrusv/kafka-connect-storage-cloud/issues/comments{/number}","contents_url":"https://api.github.com/repos/cyrusv/kafka-connect-storage-cloud/contents/{+path}","compare_url":"https://api.github.com/repos/cyrusv/kafka-connect-storage-cloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cyrusv/kafka-connect-storage-cloud/merges","archive_url":"https://api.github.com/repos/cyrusv/kafka-connect-storage-cloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cyrusv/kafka-connect-storage-cloud/downloads","issues_url":"https://api.github.com/repos/cyrusv/kafka-connect-storage-cloud/issues{/number}","pulls_url":"https://api.github.com/repos/cyrusv/kafka-connect-storage-cloud/pulls{/number}","milestones_url":"https://api.github.com/repos/cyrusv/kafka-connect-storage-cloud/milestones{/number}","notifications_url":"https://api.github.com/repos/cyrusv/kafka-connect-storage-cloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cyrusv/kafka-connect-storage-cloud/labels{/name}","releases_url":"https://api.github.com/repos/cyrusv/kafka-connect-storage-cloud/releases{/id}","deployments_url":"https://api.github.com/repos/cyrusv/kafka-connect-storage-cloud/deployments","created_at":"2018-05-29T16:55:08Z","updated_at":"2018-07-06T16:52:20Z","pushed_at":"2018-08-07T15:42:54Z","git_url":"git://github.com/cyrusv/kafka-connect-storage-cloud.git","ssh_url":"git@github.com:cyrusv/kafka-connect-storage-cloud.git","clone_url":"https://github.com/cyrusv/kafka-connect-storage-cloud.git","svn_url":"https://github.com/cyrusv/kafka-connect-storage-cloud","homepage":"","size":767,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"confluentinc:3.2.x","ref":"3.2.x","sha":"1b172120701305e5f8ba405a2bfb2f0b32d2676c","user":{"login":"confluentinc","id":9439498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0Mzk0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"repo":{"id":74387321,"node_id":"MDEwOlJlcG9zaXRvcnk3NDM4NzMyMQ==","name":"kafka-connect-storage-cloud","full_name":"confluentinc/kafka-connect-storage-cloud","owner":{"login":"confluentinc","id":9439498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0Mzk0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/confluentinc/kafka-connect-storage-cloud","description":"Kafka Connect suite of connectors for Cloud storage (currently including Amazon S3)","fork":false,"url":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud","forks_url":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/forks","keys_url":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/teams","hooks_url":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/hooks","issue_events_url":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/issues/events{/number}","events_url":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/events","assignees_url":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/assignees{/user}","branches_url":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/branches{/branch}","tags_url":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/tags","blobs_url":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/statuses/{sha}","languages_url":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/languages","stargazers_url":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/stargazers","contributors_url":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/contributors","subscribers_url":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/subscribers","subscription_url":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/subscription","commits_url":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/issues/comments{/number}","contents_url":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/contents/{+path}","compare_url":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/merges","archive_url":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/downloads","issues_url":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/issues{/number}","pulls_url":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/pulls{/number}","milestones_url":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/milestones{/number}","notifications_url":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/labels{/name}","releases_url":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/releases{/id}","deployments_url":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/deployments","created_at":"2016-11-21T17:18:28Z","updated_at":"2018-08-03T23:22:31Z","pushed_at":"2018-08-07T15:42:56Z","git_url":"git://github.com/confluentinc/kafka-connect-storage-cloud.git","ssh_url":"git@github.com:confluentinc/kafka-connect-storage-cloud.git","clone_url":"https://github.com/confluentinc/kafka-connect-storage-cloud.git","svn_url":"https://github.com/confluentinc/kafka-connect-storage-cloud","homepage":"","size":869,"stargazers_count":43,"watchers_count":43,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":90,"mirror_url":null,"archived":false,"open_issues_count":40,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":90,"open_issues":40,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/pulls/187"},"html":{"href":"https://github.com/confluentinc/kafka-connect-storage-cloud/pull/187"},"issue":{"href":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/issues/187"},"comments":{"href":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/issues/187/comments"},"review_comments":{"href":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/pulls/187/comments"},"review_comment":{"href":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/pulls/187/commits"},"statuses":{"href":"https://api.github.com/repos/confluentinc/kafka-connect-storage-cloud/statuses/1932a75b14d0c92d02d688a56355a4c4bbe34093"}},"author_association":"NONE"}}
{"actor":{"display_login":"rhauch"}}