{"push_id":2318301816,"size":122,"distinct_size":113,"ref":"refs/heads/pu","head":"8aa5b3cc7eda0a67ddf32016261ebe9ac3a0ad10","before":"6309349edcc6524f008f17ca46f06b7001ad9cc2","commits":[{"sha":"1cdc62f6f16e6dae4343824f08286015c8c4b9c2","author":{"name":"Jeff King","email":"7e57302763bea699aee296fb53304dc616ab92d5@peff.net"},"message":"t0205: drop redundant test\n\nWe check that a shell variable is non-empty, and then we\ncheck that it's equal to a particular value. Just checking\nthe latter covers both cases.\n\nI suspect the original was trying to give better output when\nthe test fails, but using \"-x\" covers that these days.\n\nSigned-off-by: Jeff King <peff@peff.net>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":true,"url":"https://api.github.com/repos/PKRoma/git/commits/1cdc62f6f16e6dae4343824f08286015c8c4b9c2"},{"sha":"373803158198310ba6ce68bfa054191038d87352","author":{"name":"Jeff King","email":"7e57302763bea699aee296fb53304dc616ab92d5@peff.net"},"message":"git-sh-i18n: check GETTEXT_POISON before USE_GETTEXT_SCHEME\n\nRunning \"make NO_GETTEXT=1 GETTEXT_POISON=1\" currently fails\nt0205.\n\nWhile it might seem nonsensical at first glance to both\npoison and disable gettext, it's useful to be able to do a\npoison test-run on a system that doesn't have gettext at\nall. And it works fine for C programs; the problem is only\nwith the shell code.\n\nThe issue is that we check the baked-in USE_GETTEXT_SCHEME\nvalue before GETTEXT_POISON. And when NO_GETTEXT is set, the\nMakefile sets USE_GETTEXT_SCHEME to \"fallthrough\".\n\nSo one fix would be to have the Makefile just set\nUSE_GETTEXT_SCHEME to \"poison\" if GETTEXT_POISON is set.\nBut there are two problems with that:\n\n  1. USE_GETTEXT_SCHEME is actually a user-facing knob, so\n     conceivably somebody could override it with:\n\n       make USE_GETTEXT_SCHEME=gnu GETTEXT_POISON=1\n\n     which would do the wrong thing (though that's much less\n     likely than them having the variable set in their\n     config.mak and just overriding GETTEXT_POISON on the\n     command-line for a one-off test).\n\n  2. We don't actually bake GETTEXT_POISON in to the shell\n     library like we do for the C code. It checks\n     $GIT_GETTEXT_POISON at runtime, which is set up by the\n     test suite. So it makes sense to put the fix in the\n     runtime code, too, which would cover something like:\n\n       GIT_GETTEXT_POISON=foo git foo\n\n     It's not likely that people use the poison code outside\n     of running the test suite, but it's easy enough to make\n     this case work.\n\nSigned-off-by: Jeff King <peff@peff.net>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":true,"url":"https://api.github.com/repos/PKRoma/git/commits/373803158198310ba6ce68bfa054191038d87352"},{"sha":"8cdef01c4282e6006b785a0222589ccd2b65a187","author":{"name":"SZEDER Gábor","email":"2d7398648c7656faf78ca9ed84ec90025e532b11@gmail.com"},"message":"t5541: add 'test_i18ngrep's missing filename parameter\n\nThe test 'push --no-progress silences progress but not status' runs\n'test_i18ngrep' without specifying a filename parameter.  This has\nremained unnoticed since its introduction in e304aeba2 (t5541: test\nmore combinations of --progress, 2012-05-01), because that\n'test_i18ngrep' is supposed to check that the given pattern is not\npresent in its input, and of course it won't find that pattern if its\ninput is empty (as it comes from /dev/null).  This also means that\nthis test could miss a potential breakage of 'git push --no-progress'.\n\nSigned-off-by: SZEDER Gábor <szeder.dev@gmail.com>\nReviewed-by: Jeff King <peff@peff.net>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/PKRoma/git/commits/8cdef01c4282e6006b785a0222589ccd2b65a187"},{"sha":"a4ca4553e08ab5626f744171c1d2d7fbfed11e8b","author":{"name":"SZEDER Gábor","email":"2d7398648c7656faf78ca9ed84ec90025e532b11@gmail.com"},"message":"t5812: add 'test_i18ngrep's missing filename parameter\n\nThe second 'test_i18ngrep' invocation in the test 'curl redirects\nrespect whitelist' is missing its filename parameter.  This has\nremained unnoticed since its introduction in f4113cac0 (http: limit\nredirection to protocol-whitelist, 2015-09-22), because it would only\ncause the test to fail if Git was built with a sufficiently old\nlibcurl version.  The test's two ||-chained 'test_i18ngrep'\ninvocations are supposed to check that either one of the two patterns\nis present in 'git clone's error message.  As it happens, the first\ninvocation covers the error message from any reasonably up-to-date\nlibcurl, thus the second invocation, the one without the filename\nparameter, isn't executed at all.  Apparently no one has run the test\nsuite's httpd tests with such an old libcurl in the last 2+ years, or\nat least they haven't bothered to notify us about the failed test.\n\nFix this by consolidating the two patterns into a single extended\nregexp, eliminating the need for an ||-chained second 'test_i18ngrep'\ninvocation.\n\nSigned-off-by: SZEDER Gábor <szeder.dev@gmail.com>\nReviewed-by: Jeff King <peff@peff.net>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/PKRoma/git/commits/a4ca4553e08ab5626f744171c1d2d7fbfed11e8b"},{"sha":"cc04adc2d0514f0f666b7e123ba2022b1a20dcde","author":{"name":"SZEDER Gábor","email":"2d7398648c7656faf78ca9ed84ec90025e532b11@gmail.com"},"message":"t6022: don't run 'git merge' upstream of a pipe\n\nThe primary purpose of 't6022-merge-rename.sh' is to test 'git merge',\nbut one of the tests runs it upstream of a pipe, hiding its exit code.\nConsequently, the test could continue even if 'git merge' exited with\nerror.\n\nUse an intermediate file between 'git merge' and 'test_i18ngrep' to\ncatch a potential failure of the former.\n\nSigned-off-by: SZEDER Gábor <szeder.dev@gmail.com>\nReviewed-by: Jeff King <peff@peff.net>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/PKRoma/git/commits/cc04adc2d0514f0f666b7e123ba2022b1a20dcde"},{"sha":"3b85ec34b8448d0311ef20e225c76df11c006008","author":{"name":"SZEDER Gábor","email":"2d7398648c7656faf78ca9ed84ec90025e532b11@gmail.com"},"message":"t4001: don't run 'git status' upstream of a pipe\n\nThe primary purpose of three tests in 't4001-diff-rename.sh' is to\ncheck rename detection in 'git status', but all three do so by running\n'git status' upstream of a pipe, hiding its exit code.  Consequently,\nthe test could continue even if 'git status' exited with error.\n\nUse an intermediate file between 'git status' and 'test_i18ngrep' to\ncatch a potential failure of the former.\n\nSigned-off-by: SZEDER Gábor <szeder.dev@gmail.com>\nReviewed-by: Jeff King <peff@peff.net>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/PKRoma/git/commits/3b85ec34b8448d0311ef20e225c76df11c006008"},{"sha":"927c1a643a9320368a95046f855371b0ce473263","author":{"name":"SZEDER Gábor","email":"2d7398648c7656faf78ca9ed84ec90025e532b11@gmail.com"},"message":"t5510: consolidate 'grep' and 'test_i18ngrep' patterns\n\nOne of the tests in 't5510-fetch.sh' checks the output of 'git fetch'\nusing 'test_i18ngrep', and while doing so it prefilters the output\nwith 'grep' before piping the result into 'test_i18ngrep'.\n\nThis prefiltering is unnecessary, with the appropriate pattern\n'test_i18ngrep' can do it all by itself.  Furthermore, piping data\ninto 'test_i18ngrep' will interfere with the linting that will be\nadded in a later patch.\n\nSigned-off-by: SZEDER Gábor <szeder.dev@gmail.com>\nReviewed-by: Jeff King <peff@peff.net>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/PKRoma/git/commits/927c1a643a9320368a95046f855371b0ce473263"},{"sha":"93b4b0313c8d9d3600fc27b7023dab0d9d9be739","author":{"name":"SZEDER Gábor","email":"2d7398648c7656faf78ca9ed84ec90025e532b11@gmail.com"},"message":"t5536: let 'test_i18ngrep' read the file without redirection\n\nRedirecting 'test_i18ngrep's standard input from a file will interfere\nwith the linting that will be added in a later patch.\n\nSigned-off-by: SZEDER Gábor <szeder.dev@gmail.com>\nReviewed-by: Jeff King <peff@peff.net>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/PKRoma/git/commits/93b4b0313c8d9d3600fc27b7023dab0d9d9be739"},{"sha":"0f59128f7bb6ce20889156efd101d1e059377eaa","author":{"name":"SZEDER Gábor","email":"2d7398648c7656faf78ca9ed84ec90025e532b11@gmail.com"},"message":"t: move 'test_i18ncmp' and 'test_i18ngrep' to 'test-lib-functions.sh'\n\nBoth 'test_i18ncmp' and 'test_i18ngrep' helper functions are supposed\nto be called from our test scripts, so they should be in\n'test-lib-functions.sh'.\n\nSigned-off-by: SZEDER Gábor <szeder.dev@gmail.com>\nReviewed-by: Jeff King <peff@peff.net>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/PKRoma/git/commits/0f59128f7bb6ce20889156efd101d1e059377eaa"},{"sha":"fd29d7b9d767296e0f8fbd3f7def735424fdbb30","author":{"name":"SZEDER Gábor","email":"2d7398648c7656faf78ca9ed84ec90025e532b11@gmail.com"},"message":"t: validate 'test_i18ngrep's parameters\n\nSome of the previous patches in this series fixed bogus\n'test_i18ngrep' invocations:\n\n  - Two invocations where the tested git command's standard output is\n    directly piped into 'test_i18ngrep'.  While convenient, this is an\n    antipattern, because the pipe hides the git command's exit code,\n    and the test could continue even if the command exited with error.\n\n  - Two invocations that had neither a filename parameter nor anything\n    piped into their standard input, yet both managed to remain\n    unnoticed for years.  A third similarly bogus invocation is\n    currently lurking in 'pu' for a couple of weeks now.\n\nPrevent similar mistakes in the future by validating 'test_i18ngrep's\nparameters requiring that\n\n  - The last parameter names an existing file to be read, effectively\n    forbidding piping into 'test_i18ngrep'.\n\n    Note that this change will also forbid cases where 'test_i18ngrep'\n    would legitimately read its standard input, e.g. when its standard\n    input is redirected from a file, or when a git command's standard\n    output is first written to an intermediate file, which is then\n    preprocessed by a non-git command before the results are piped\n    into 'test_i18ngrep'.  See two of the previous patches for the\n    only such cases we had in our test suite.  However, reliably\n    preventing the piping antipattern is arguably more important than\n    supporting these cases, which can be easily worked around by\n    opening the file directly or using an intermediate file anyway.\n\n  - There are at least two parameters, not including the optional '!'\n    to negate the pattern.  This ought to catch corner cases when\n    'test_i18ngrep' looks for the name of an existing file on its\n    standard input; the above check would miss this case becase the\n    filename as pattern would be the last parameter.\n\n    Note that this is not quite perfect, as it doesn't account for any\n    'grep --options' given as parameters.  However, doing so would be\n    far too complicated, considering that patterns can start with\n    dashes as well, and in the majority of the cases we don't use any\n    such options anyway.\n\nSigned-off-by: SZEDER Gábor <szeder.dev@gmail.com>\nReviewed-by: Jeff King <peff@peff.net>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/PKRoma/git/commits/fd29d7b9d767296e0f8fbd3f7def735424fdbb30"},{"sha":"63b1a175ee284f37c009e0afd7ee88a7c04ca515","author":{"name":"SZEDER Gábor","email":"2d7398648c7656faf78ca9ed84ec90025e532b11@gmail.com"},"message":"t: make 'test_i18ngrep' more informative on failure\n\nWhen 'test_i18ngrep' can't find the expected pattern, it exits\ncompletely silently; when its negated form does find the pattern that\nshouldn't be there, it prints the matching line(s) but otherwise exits\nwithout any error message.  This leaves the developer puzzled about\nwhat could have gone wrong.\n\nMake 'test_i18ngrep' more informative on failure by printing an error\nmessage including the invoked 'grep' command and the contents of the\nfile it had to scan through.\n\nNote that this \"dump the scanned file\" part is not quite perfect, as\nit dumps only the file specified as the function's last positional\nparameter, thus assuming that there is only a single file parameter.\nI think that's a reasonable assumption to make, one that holds true in\nthe current code base.  And even if someone were to scan multiple\nfiles at once in the future, the worst thing that could happen is that\nthe verbose error message won't include the contents of all those\nfiles, only the last one.  Alas, we can't really do any better than\nthis, because checking whether the other positional parameters match a\nfilename can result in false positives: 't3400-rebase.sh' and\n't3404-rebase-interactive.sh' contain one test each, where the\n'test_i18ngrep's pattern verbatimly matches a file in the trash\ndirectory.\n\nSigned-off-by: SZEDER Gábor <szeder.dev@gmail.com>\nReviewed-by: Jeff King <peff@peff.net>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/PKRoma/git/commits/63b1a175ee284f37c009e0afd7ee88a7c04ca515"},{"sha":"02de1c4c30fc11ab95ce3135002dca4ea25b48da","author":{"name":"Ævar Arnfjörð Bjarmason","email":"f39cfd0b24e0a81f65944956d2eafe947e5be136@gmail.com"},"message":"fetch: don't redundantly NULL something calloc() gave us\n\nStop redundantly NULL-ing the last element of the refs structure,\nwhich was retrieved via calloc(), and is thus guaranteed to be\npre-NULL'd.\n\nThis code dates back to b888d61c83 (\"Make fetch a builtin\",\n2007-09-10), where wasn't any reason to do this back then either, it's\njust boilerplate left over from when git-fetch was initially\nintroduced.\n\nThe motivation for this change was to make a subsequent change which\nwould also modify the refs variable smaller, since it won't have to\ncopy this redundant \"NULL the last + 1 item\" pattern.\n\nWe may not end up keeping that change, but as this pattern is still\npointless, so let's fix it.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":true,"url":"https://api.github.com/repos/PKRoma/git/commits/02de1c4c30fc11ab95ce3135002dca4ea25b48da"},{"sha":"7e97a4989cd14be606c2c50a7a61f3a10b6341fb","author":{"name":"Ævar Arnfjörð Bjarmason","email":"f39cfd0b24e0a81f65944956d2eafe947e5be136@gmail.com"},"message":"fetch: trivially refactor assignment to ref_nr\n\nTrivially refactor an assignment to make a subsequent patch\nsmaller. The \"ref_nr\" variable is initialized to 0 earlier, just as\n\"j\" is, and \"j\" is only incremented in that loop, so this change isn't\na logic error.\n\nThis change makes a subsequent change which splits the incrementing of\n\"ref_nr\" into two blocks.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":true,"url":"https://api.github.com/repos/PKRoma/git/commits/7e97a4989cd14be606c2c50a7a61f3a10b6341fb"},{"sha":"0f586ccb95718f1bd6fe190c722da94c85e7e96c","author":{"name":"Ævar Arnfjörð Bjarmason","email":"f39cfd0b24e0a81f65944956d2eafe947e5be136@gmail.com"},"message":"fetch: stop accessing \"remote\" variable indirectly\n\nAccess the \"remote\" variable passed to the fetch_one() directly rather\nthan through the gtransport wrapper struct constructed in this\nfunction for other purposes.\n\nThis makes the code more readable, as it's now obvious that the remote\nstruct doesn't somehow get munged by the prepare_transport() function\nabove, which takes the \"remote\" struct as an argument and constructs\nthe \"gtransport\" struct, containing among other things the \"remote\"\nstruct.\n\nA subsequent change will copy this pattern to access a new\nremote->prune_tags field, but without the use of the gtransport\nvariable. It's useful once that change lands to see that the two\npieces of code behave exactly the same.\n\nThis pattern of accessing the container struct was added in\n737c5a9cde (\"fetch: make --prune configurable\", 2013-07-13) when this\ncode was initially introduced.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":true,"url":"https://api.github.com/repos/PKRoma/git/commits/0f586ccb95718f1bd6fe190c722da94c85e7e96c"},{"sha":"06b59a00e66624da8001dc82c754da12d4bf9151","author":{"name":"Ævar Arnfjörð Bjarmason","email":"f39cfd0b24e0a81f65944956d2eafe947e5be136@gmail.com"},"message":"remote: add a macro for \"refs/tags/*:refs/tags/*\"\n\nAdd a macro with the refspec string \"refs/tags/*:refs/tags/*\". There's\nbeen a pre-defined struct version of this since e0aaa29ff3 (\"Have a\nconstant extern refspec for \"--tags\"\", 2008-04-17), but nothing that\ncould be passed to e.g. add_fetch_refspec().\n\nThis will be used in subsequent commits to avoid hardcoding this\nstring in multiple places.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":true,"url":"https://api.github.com/repos/PKRoma/git/commits/06b59a00e66624da8001dc82c754da12d4bf9151"},{"sha":"ce4c67335aed37254a1cf1189ff4848049566573","author":{"name":"Ævar Arnfjörð Bjarmason","email":"f39cfd0b24e0a81f65944956d2eafe947e5be136@gmail.com"},"message":"fetch tests: refactor in preparation for testing tag pruning\n\nIn a subsequent commit this function will learn to test for tag\npruning, prepare for that by making space for more variables, and\nmaking it clear that \"expected\" here refers to branches.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":true,"url":"https://api.github.com/repos/PKRoma/git/commits/ce4c67335aed37254a1cf1189ff4848049566573"},{"sha":"512f424ed2c4e8c7193dd9ccca1ba0f697eba70c","author":{"name":"Ævar Arnfjörð Bjarmason","email":"f39cfd0b24e0a81f65944956d2eafe947e5be136@gmail.com"},"message":"fetch tests: re-arrange arguments for future readability\n\nRe-arrange the arguments to the test_configured_prune() function used\nin this test to pass the arguments to --fetch last. A subsequent\nchange will test for more elaborate fetch arguments, including long\nrefspecs. It'll be more readable to be able to wrap those on a new\nline of their own.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":true,"url":"https://api.github.com/repos/PKRoma/git/commits/512f424ed2c4e8c7193dd9ccca1ba0f697eba70c"},{"sha":"e1c241124fd6592eeb52fb493423a22e0670d4d1","author":{"name":"Ævar Arnfjörð Bjarmason","email":"f39cfd0b24e0a81f65944956d2eafe947e5be136@gmail.com"},"message":"fetch tests: add a tag to be deleted to the pruning tests\n\nAdd a tag to be deleted to the fetch --prune tests. The tag is always\nkept for now, which is the expected behavior, but now I can add a test\nfor tag pruning in a later commit.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":true,"url":"https://api.github.com/repos/PKRoma/git/commits/e1c241124fd6592eeb52fb493423a22e0670d4d1"},{"sha":"02a339e656c26b5d6ebbd127fbb36ff5934717bf","author":{"name":"Ævar Arnfjörð Bjarmason","email":"f39cfd0b24e0a81f65944956d2eafe947e5be136@gmail.com"},"message":"fetch tests: test --prune and refspec interaction\n\nAdd a test for the interaction between explicitly provided refspecs\nand fetch.prune.\n\nThere's no point in adding this boilerplate to every combination of\nunset/false/true, it's instructive and sufficient to show that no\nmatter if the variable is unset, false or true the refspec on the\ncommand-line overrides any configuration variable.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":true,"url":"https://api.github.com/repos/PKRoma/git/commits/02a339e656c26b5d6ebbd127fbb36ff5934717bf"},{"sha":"1cfab2d82ba743cca8439d0d8d4f7fc2bd246765","author":{"name":"Ævar Arnfjörð Bjarmason","email":"f39cfd0b24e0a81f65944956d2eafe947e5be136@gmail.com"},"message":"fetch tests: double quote a variable for interpolation\n\nIf the $cmdline variable contains arguments with spaces they won't be\ninterpolated correctly, since the body of the test is single quoted,\nand because test-lib.sh does its own eval().\n\nThis will be used in a subsequent commit to pass arguments that need\nto be quoted to git-fetch, i.e. a file:// path to fetch, which will\nhave a space in it.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":true,"url":"https://api.github.com/repos/PKRoma/git/commits/1cfab2d82ba743cca8439d0d8d4f7fc2bd246765"}]}
{"actor":{"display_login":"PKRoma"}}