{"action":"created","issue":{"url":"https://api.github.com/repos/osmlab/atlas/issues/99","repository_url":"https://api.github.com/repos/osmlab/atlas","labels_url":"https://api.github.com/repos/osmlab/atlas/issues/99/labels{/name}","comments_url":"https://api.github.com/repos/osmlab/atlas/issues/99/comments","events_url":"https://api.github.com/repos/osmlab/atlas/issues/99/events","html_url":"https://github.com/osmlab/atlas/pull/99","id":307458161,"number":99,"title":"Do Not Merge: Save Atlas to ProtobufAtlas similar to TextAtlas","user":{"login":"lucaspcram","id":8269882,"avatar_url":"https://avatars0.githubusercontent.com/u/8269882?v=4","gravatar_id":"","url":"https://api.github.com/users/lucaspcram","html_url":"https://github.com/lucaspcram","followers_url":"https://api.github.com/users/lucaspcram/followers","following_url":"https://api.github.com/users/lucaspcram/following{/other_user}","gists_url":"https://api.github.com/users/lucaspcram/gists{/gist_id}","starred_url":"https://api.github.com/users/lucaspcram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucaspcram/subscriptions","organizations_url":"https://api.github.com/users/lucaspcram/orgs","repos_url":"https://api.github.com/users/lucaspcram/repos","events_url":"https://api.github.com/users/lucaspcram/events{/privacy}","received_events_url":"https://api.github.com/users/lucaspcram/received_events","type":"User","site_admin":false},"labels":[{"id":664543820,"url":"https://api.github.com/repos/osmlab/atlas/labels/New%20Feature","name":"New Feature","color":"128A0C","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-03-21T23:53:09Z","updated_at":"2018-03-27T00:58:43Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/osmlab/atlas/pulls/99","html_url":"https://github.com/osmlab/atlas/pull/99","diff_url":"https://github.com/osmlab/atlas/pull/99.diff","patch_url":"https://github.com/osmlab/atlas/pull/99.patch"},"body":"~Since I changed the build flow of the Atlas project to accommodate protobuf, I think it may be a good idea to create a protobuf (or some other name) branch on the repo. I don't want to break peoples' Eclipse workflow on the dev branch until we are further along with this update. In the interest of this objective, we should probably close this PR and I'll reopen it on the protobuf branch once that is created.~\r\nEDIT: After discussion with Matthieu, we have decided to not create a protobuf branch on the repo. Instead, I will push to a protobuf branch on my fork, then submit PRs against dev for review. We can discuss, I'll make changes in my fork, then resubmit or restart the PR. When the feature is complete, we will consolidate and pull the changes into dev.\r\n\r\nOther than that, I was hoping we could have an initial discussion about the proposed changes, and make sure I am moving in the right direction before I really start cranking out more code."},"comment":{"url":"https://api.github.com/repos/osmlab/atlas/issues/comments/376360377","html_url":"https://github.com/osmlab/atlas/pull/99#issuecomment-376360377","issue_url":"https://api.github.com/repos/osmlab/atlas/issues/99","id":376360377,"user":{"login":"MikeGost","id":18317260,"avatar_url":"https://avatars3.githubusercontent.com/u/18317260?v=4","gravatar_id":"","url":"https://api.github.com/users/MikeGost","html_url":"https://github.com/MikeGost","followers_url":"https://api.github.com/users/MikeGost/followers","following_url":"https://api.github.com/users/MikeGost/following{/other_user}","gists_url":"https://api.github.com/users/MikeGost/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeGost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeGost/subscriptions","organizations_url":"https://api.github.com/users/MikeGost/orgs","repos_url":"https://api.github.com/users/MikeGost/repos","events_url":"https://api.github.com/users/MikeGost/events{/privacy}","received_events_url":"https://api.github.com/users/MikeGost/received_events","type":"User","site_admin":false},"created_at":"2018-03-27T00:58:43Z","updated_at":"2018-03-27T00:58:43Z","author_association":"CONTRIBUTOR","body":"@lucaspcram - great job so far! I'd try to merge this PR and work on a new one that has the PackedAtlas in proto format. Couple of thoughts:\r\n\r\n1. Before merging this one, I would address Matthieu's notes regarding gradle and the build process, that way we can easily merge this.\r\n2. I really like what you did by putting this PR up early, iterating through it and adding more functionality and tests as you went along. Perhaps you could take a similar approach for the next PR - open it up when you there's enough for others to follow and iterate over that. I wouldn't worry too much about email junk, everyone watching can add a filter.\r\n\r\nCurious on @matthieun's thoughts!"}}
{"actor":{"display_login":"MikeGost"}}