{"action":"closed","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/16504","repository_url":"https://api.github.com/repos/openshift/origin","labels_url":"https://api.github.com/repos/openshift/origin/issues/16504/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/16504/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/16504/events","html_url":"https://github.com/openshift/origin/issues/16504","id":259812414,"number":16504,"title":"Pre-Hook pod doesn't inherit all imagePullSecrets","user":{"login":"deanhighmarkit","id":19221272,"avatar_url":"https://avatars2.githubusercontent.com/u/19221272?v=4","gravatar_id":"","url":"https://api.github.com/users/deanhighmarkit","html_url":"https://github.com/deanhighmarkit","followers_url":"https://api.github.com/users/deanhighmarkit/followers","following_url":"https://api.github.com/users/deanhighmarkit/following{/other_user}","gists_url":"https://api.github.com/users/deanhighmarkit/gists{/gist_id}","starred_url":"https://api.github.com/users/deanhighmarkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deanhighmarkit/subscriptions","organizations_url":"https://api.github.com/users/deanhighmarkit/orgs","repos_url":"https://api.github.com/users/deanhighmarkit/repos","events_url":"https://api.github.com/users/deanhighmarkit/events{/privacy}","received_events_url":"https://api.github.com/users/deanhighmarkit/received_events","type":"User","site_admin":false},"labels":[{"id":210155386,"url":"https://api.github.com/repos/openshift/origin/labels/component/apps","name":"component/apps","color":"0052cc","default":false},{"id":118251699,"url":"https://api.github.com/repos/openshift/origin/labels/kind/bug","name":"kind/bug","color":"e11d21","default":false},{"id":858447969,"url":"https://api.github.com/repos/openshift/origin/labels/lifecycle/rotten","name":"lifecycle/rotten","color":"604460","default":false},{"id":210152331,"url":"https://api.github.com/repos/openshift/origin/labels/priority/P3","name":"priority/P3","color":"fad8c7","default":false}],"state":"closed","locked":false,"assignee":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars2.githubusercontent.com/u/44136?v=4","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"assignees":[{"login":"mfojtik","id":44136,"avatar_url":"https://avatars2.githubusercontent.com/u/44136?v=4","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2017-09-22T13:19:11Z","updated_at":"2018-04-22T23:28:45Z","closed_at":"2018-04-22T23:28:45Z","author_association":"NONE","body":"If I create a deployment pre-hook it fails to pull the image from the central repository even though it is the same container that is being deployed without the hook. \r\n\r\n##### Version\r\noc v1.5.1+7b451fc\r\nkubernetes v1.5.2+43a9be4\r\nfeatures: Basic-Auth GSSAPI Kerberos SPNEGO\r\n\r\nServer https://localhost:8443\r\nopenshift v1.5.1+7b451fc\r\nkubernetes v1.5.2+43a9be4\r\n\r\n##### Steps To Reproduce\r\n1. Configure private repo for image-import as done here, https://docs.openshift.com/container-platform/3.5/dev_guide/managing_images.html#private-registries.\r\n2. Configure imagestreams to import from private repository. \r\n3. oc set deployment-hook dc/thecomponent --pre -- echo \"TEST\"\r\n4. oc rollout latest thecomponent\r\n\r\n##### Current Result\r\nThe pre container does not contain the same imagePullSecrets as the parent.\r\n\r\nIt has a \"default\" secret\r\n```\r\n  imagePullSecrets:\r\n  - name: default-dockercfg-k48vs\r\n```\r\nThe primary container has 2 secrets both with necessary permissions to pull from local and remote repos.\r\n```\r\n  imagePullSecrets:\r\n  - name: systemuser-dockercfg-bmgr9\r\n  - name: central-registry\r\n```\r\n##### Expected Result\r\n\r\nI expect the secrets to be inherited by the pre container as I would like to drive a schema sync at this phase of the deployment. \r\n\r\n##### Additional Information\r\nN/A\r\n"}}
{"actor":{"display_login":"openshift-ci-robot"}}