{"action":"created","comment":{"url":"https://api.github.com/repos/IntelAI/mlt/pulls/comments/197935721","pull_request_review_id":131776353,"id":197935721,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzkzNTcyMQ==","diff_hunk":"@@ -135,12 +136,33 @@ def _deploy_new_container(self):\n \n         print(\"Deploying {}\".format(remote_container_name))\n         kubernetes_helpers.ensure_namespace_exists(self.namespace)\n+        app_run_id = str(uuid.uuid4())\n+        if self.is_custom():\n+            self._custom_deploy(app_name=app_name,\n+                                app_run_id=app_run_id,\n+                                remote_container_name=remote_container_name)\n+        else:\n+            self._default_deploy(app_name=app_name,\n+                                 app_run_id=app_run_id,\n+                                 remote_container_name=remote_container_name)\n \n+    @staticmethod\n+    def is_custom():","path":"mlt/commands/deploy.py","position":23,"original_position":23,"commit_id":"fb68d4dfc6062b6a52c25919702af0df796fef6e","original_commit_id":"fb68d4dfc6062b6a52c25919702af0df796fef6e","user":{"login":"karthikvadla","id":16564109,"node_id":"MDQ6VXNlcjE2NTY0MTA5","avatar_url":"https://avatars1.githubusercontent.com/u/16564109?v=4","gravatar_id":"","url":"https://api.github.com/users/karthikvadla","html_url":"https://github.com/karthikvadla","followers_url":"https://api.github.com/users/karthikvadla/followers","following_url":"https://api.github.com/users/karthikvadla/following{/other_user}","gists_url":"https://api.github.com/users/karthikvadla/gists{/gist_id}","starred_url":"https://api.github.com/users/karthikvadla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karthikvadla/subscriptions","organizations_url":"https://api.github.com/users/karthikvadla/orgs","repos_url":"https://api.github.com/users/karthikvadla/repos","events_url":"https://api.github.com/users/karthikvadla/events{/privacy}","received_events_url":"https://api.github.com/users/karthikvadla/received_events","type":"User","site_admin":false},"body":"yeah can do that","created_at":"2018-06-25T20:43:59Z","updated_at":"2018-06-25T20:43:59Z","html_url":"https://github.com/IntelAI/mlt/pull/280#discussion_r197935721","pull_request_url":"https://api.github.com/repos/IntelAI/mlt/pulls/280","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/IntelAI/mlt/pulls/comments/197935721"},"html":{"href":"https://github.com/IntelAI/mlt/pull/280#discussion_r197935721"},"pull_request":{"href":"https://api.github.com/repos/IntelAI/mlt/pulls/280"}},"in_reply_to_id":197900344},"pull_request":{"url":"https://api.github.com/repos/IntelAI/mlt/pulls/280","id":193174051,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMTc0MDUx","html_url":"https://github.com/IntelAI/mlt/pull/280","diff_url":"https://github.com/IntelAI/mlt/pull/280.diff","patch_url":"https://github.com/IntelAI/mlt/pull/280.patch","issue_url":"https://api.github.com/repos/IntelAI/mlt/issues/280","number":280,"state":"open","locked":false,"title":"Add horovod template to MLT","user":{"login":"karthikvadla","id":16564109,"node_id":"MDQ6VXNlcjE2NTY0MTA5","avatar_url":"https://avatars1.githubusercontent.com/u/16564109?v=4","gravatar_id":"","url":"https://api.github.com/users/karthikvadla","html_url":"https://github.com/karthikvadla","followers_url":"https://api.github.com/users/karthikvadla/followers","following_url":"https://api.github.com/users/karthikvadla/following{/other_user}","gists_url":"https://api.github.com/users/karthikvadla/gists{/gist_id}","starred_url":"https://api.github.com/users/karthikvadla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karthikvadla/subscriptions","organizations_url":"https://api.github.com/users/karthikvadla/orgs","repos_url":"https://api.github.com/users/karthikvadla/repos","events_url":"https://api.github.com/users/karthikvadla/events{/privacy}","received_events_url":"https://api.github.com/users/karthikvadla/received_events","type":"User","site_admin":false},"body":"Adds horovod template #112 \r\n\r\nIf you aren't done, please add the `wip` label until you're ready for review.\r\n\r\n\r\n## Reviewer Checklist\r\n\r\n - [ ] Do you understand it?\r\n - [ ] Is it correct?\r\n - [ ] Is it safe?\r\n - [ ] Is it legally compliant?\r\n - [ ] Is it robust?\r\n - [ ] Is it simple?\r\n - [ ] Is it tested?\r\n - [ ] Is it documented?\r\n - [ ] Is the style consistent?\r\n\r\nSee [the reviewer guide](docs/reviews.md) for more detail on each check.\r\n","created_at":"2018-06-07T00:19:30Z","updated_at":"2018-06-25T20:43:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bddb19fba8c7fe598bc2b797ae600d14cd5e85e8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ConnorDoyle","id":379372,"node_id":"MDQ6VXNlcjM3OTM3Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/379372?v=4","gravatar_id":"","url":"https://api.github.com/users/ConnorDoyle","html_url":"https://github.com/ConnorDoyle","followers_url":"https://api.github.com/users/ConnorDoyle/followers","following_url":"https://api.github.com/users/ConnorDoyle/following{/other_user}","gists_url":"https://api.github.com/users/ConnorDoyle/gists{/gist_id}","starred_url":"https://api.github.com/users/ConnorDoyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConnorDoyle/subscriptions","organizations_url":"https://api.github.com/users/ConnorDoyle/orgs","repos_url":"https://api.github.com/users/ConnorDoyle/repos","events_url":"https://api.github.com/users/ConnorDoyle/events{/privacy}","received_events_url":"https://api.github.com/users/ConnorDoyle/received_events","type":"User","site_admin":false},{"login":"nqn","id":897374,"node_id":"MDQ6VXNlcjg5NzM3NA==","avatar_url":"https://avatars0.githubusercontent.com/u/897374?v=4","gravatar_id":"","url":"https://api.github.com/users/nqn","html_url":"https://github.com/nqn","followers_url":"https://api.github.com/users/nqn/followers","following_url":"https://api.github.com/users/nqn/following{/other_user}","gists_url":"https://api.github.com/users/nqn/gists{/gist_id}","starred_url":"https://api.github.com/users/nqn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nqn/subscriptions","organizations_url":"https://api.github.com/users/nqn/orgs","repos_url":"https://api.github.com/users/nqn/repos","events_url":"https://api.github.com/users/nqn/events{/privacy}","received_events_url":"https://api.github.com/users/nqn/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/IntelAI/mlt/pulls/280/commits","review_comments_url":"https://api.github.com/repos/IntelAI/mlt/pulls/280/comments","review_comment_url":"https://api.github.com/repos/IntelAI/mlt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IntelAI/mlt/issues/280/comments","statuses_url":"https://api.github.com/repos/IntelAI/mlt/statuses/fb68d4dfc6062b6a52c25919702af0df796fef6e","head":{"label":"IntelAI:karthik/horovod_template","ref":"karthik/horovod_template","sha":"fb68d4dfc6062b6a52c25919702af0df796fef6e","user":{"login":"IntelAI","id":37351515,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MzUxNTE1","avatar_url":"https://avatars3.githubusercontent.com/u/37351515?v=4","gravatar_id":"","url":"https://api.github.com/users/IntelAI","html_url":"https://github.com/IntelAI","followers_url":"https://api.github.com/users/IntelAI/followers","following_url":"https://api.github.com/users/IntelAI/following{/other_user}","gists_url":"https://api.github.com/users/IntelAI/gists{/gist_id}","starred_url":"https://api.github.com/users/IntelAI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IntelAI/subscriptions","organizations_url":"https://api.github.com/users/IntelAI/orgs","repos_url":"https://api.github.com/users/IntelAI/repos","events_url":"https://api.github.com/users/IntelAI/events{/privacy}","received_events_url":"https://api.github.com/users/IntelAI/received_events","type":"Organization","site_admin":false},"repo":{"id":117160047,"node_id":"MDEwOlJlcG9zaXRvcnkxMTcxNjAwNDc=","name":"mlt","full_name":"IntelAI/mlt","owner":{"login":"IntelAI","id":37351515,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MzUxNTE1","avatar_url":"https://avatars3.githubusercontent.com/u/37351515?v=4","gravatar_id":"","url":"https://api.github.com/users/IntelAI","html_url":"https://github.com/IntelAI","followers_url":"https://api.github.com/users/IntelAI/followers","following_url":"https://api.github.com/users/IntelAI/following{/other_user}","gists_url":"https://api.github.com/users/IntelAI/gists{/gist_id}","starred_url":"https://api.github.com/users/IntelAI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IntelAI/subscriptions","organizations_url":"https://api.github.com/users/IntelAI/orgs","repos_url":"https://api.github.com/users/IntelAI/repos","events_url":"https://api.github.com/users/IntelAI/events{/privacy}","received_events_url":"https://api.github.com/users/IntelAI/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IntelAI/mlt","description":"ML Container Templates","fork":false,"url":"https://api.github.com/repos/IntelAI/mlt","forks_url":"https://api.github.com/repos/IntelAI/mlt/forks","keys_url":"https://api.github.com/repos/IntelAI/mlt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IntelAI/mlt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IntelAI/mlt/teams","hooks_url":"https://api.github.com/repos/IntelAI/mlt/hooks","issue_events_url":"https://api.github.com/repos/IntelAI/mlt/issues/events{/number}","events_url":"https://api.github.com/repos/IntelAI/mlt/events","assignees_url":"https://api.github.com/repos/IntelAI/mlt/assignees{/user}","branches_url":"https://api.github.com/repos/IntelAI/mlt/branches{/branch}","tags_url":"https://api.github.com/repos/IntelAI/mlt/tags","blobs_url":"https://api.github.com/repos/IntelAI/mlt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IntelAI/mlt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IntelAI/mlt/git/refs{/sha}","trees_url":"https://api.github.com/repos/IntelAI/mlt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IntelAI/mlt/statuses/{sha}","languages_url":"https://api.github.com/repos/IntelAI/mlt/languages","stargazers_url":"https://api.github.com/repos/IntelAI/mlt/stargazers","contributors_url":"https://api.github.com/repos/IntelAI/mlt/contributors","subscribers_url":"https://api.github.com/repos/IntelAI/mlt/subscribers","subscription_url":"https://api.github.com/repos/IntelAI/mlt/subscription","commits_url":"https://api.github.com/repos/IntelAI/mlt/commits{/sha}","git_commits_url":"https://api.github.com/repos/IntelAI/mlt/git/commits{/sha}","comments_url":"https://api.github.com/repos/IntelAI/mlt/comments{/number}","issue_comment_url":"https://api.github.com/repos/IntelAI/mlt/issues/comments{/number}","contents_url":"https://api.github.com/repos/IntelAI/mlt/contents/{+path}","compare_url":"https://api.github.com/repos/IntelAI/mlt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IntelAI/mlt/merges","archive_url":"https://api.github.com/repos/IntelAI/mlt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IntelAI/mlt/downloads","issues_url":"https://api.github.com/repos/IntelAI/mlt/issues{/number}","pulls_url":"https://api.github.com/repos/IntelAI/mlt/pulls{/number}","milestones_url":"https://api.github.com/repos/IntelAI/mlt/milestones{/number}","notifications_url":"https://api.github.com/repos/IntelAI/mlt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IntelAI/mlt/labels{/name}","releases_url":"https://api.github.com/repos/IntelAI/mlt/releases{/id}","deployments_url":"https://api.github.com/repos/IntelAI/mlt/deployments","created_at":"2018-01-11T22:15:45Z","updated_at":"2018-06-25T06:39:57Z","pushed_at":"2018-06-25T18:12:31Z","git_url":"git://github.com/IntelAI/mlt.git","ssh_url":"git@github.com:IntelAI/mlt.git","clone_url":"https://github.com/IntelAI/mlt.git","svn_url":"https://github.com/IntelAI/mlt","homepage":"","size":1018,"stargazers_count":49,"watchers_count":49,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":66,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":10,"open_issues":66,"watchers":49,"default_branch":"master"}},"base":{"label":"IntelAI:master","ref":"master","sha":"2aeaf1c9a16d30e361fd5d0a798fefc7fc55e82e","user":{"login":"IntelAI","id":37351515,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MzUxNTE1","avatar_url":"https://avatars3.githubusercontent.com/u/37351515?v=4","gravatar_id":"","url":"https://api.github.com/users/IntelAI","html_url":"https://github.com/IntelAI","followers_url":"https://api.github.com/users/IntelAI/followers","following_url":"https://api.github.com/users/IntelAI/following{/other_user}","gists_url":"https://api.github.com/users/IntelAI/gists{/gist_id}","starred_url":"https://api.github.com/users/IntelAI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IntelAI/subscriptions","organizations_url":"https://api.github.com/users/IntelAI/orgs","repos_url":"https://api.github.com/users/IntelAI/repos","events_url":"https://api.github.com/users/IntelAI/events{/privacy}","received_events_url":"https://api.github.com/users/IntelAI/received_events","type":"Organization","site_admin":false},"repo":{"id":117160047,"node_id":"MDEwOlJlcG9zaXRvcnkxMTcxNjAwNDc=","name":"mlt","full_name":"IntelAI/mlt","owner":{"login":"IntelAI","id":37351515,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MzUxNTE1","avatar_url":"https://avatars3.githubusercontent.com/u/37351515?v=4","gravatar_id":"","url":"https://api.github.com/users/IntelAI","html_url":"https://github.com/IntelAI","followers_url":"https://api.github.com/users/IntelAI/followers","following_url":"https://api.github.com/users/IntelAI/following{/other_user}","gists_url":"https://api.github.com/users/IntelAI/gists{/gist_id}","starred_url":"https://api.github.com/users/IntelAI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IntelAI/subscriptions","organizations_url":"https://api.github.com/users/IntelAI/orgs","repos_url":"https://api.github.com/users/IntelAI/repos","events_url":"https://api.github.com/users/IntelAI/events{/privacy}","received_events_url":"https://api.github.com/users/IntelAI/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IntelAI/mlt","description":"ML Container Templates","fork":false,"url":"https://api.github.com/repos/IntelAI/mlt","forks_url":"https://api.github.com/repos/IntelAI/mlt/forks","keys_url":"https://api.github.com/repos/IntelAI/mlt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IntelAI/mlt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IntelAI/mlt/teams","hooks_url":"https://api.github.com/repos/IntelAI/mlt/hooks","issue_events_url":"https://api.github.com/repos/IntelAI/mlt/issues/events{/number}","events_url":"https://api.github.com/repos/IntelAI/mlt/events","assignees_url":"https://api.github.com/repos/IntelAI/mlt/assignees{/user}","branches_url":"https://api.github.com/repos/IntelAI/mlt/branches{/branch}","tags_url":"https://api.github.com/repos/IntelAI/mlt/tags","blobs_url":"https://api.github.com/repos/IntelAI/mlt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IntelAI/mlt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IntelAI/mlt/git/refs{/sha}","trees_url":"https://api.github.com/repos/IntelAI/mlt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IntelAI/mlt/statuses/{sha}","languages_url":"https://api.github.com/repos/IntelAI/mlt/languages","stargazers_url":"https://api.github.com/repos/IntelAI/mlt/stargazers","contributors_url":"https://api.github.com/repos/IntelAI/mlt/contributors","subscribers_url":"https://api.github.com/repos/IntelAI/mlt/subscribers","subscription_url":"https://api.github.com/repos/IntelAI/mlt/subscription","commits_url":"https://api.github.com/repos/IntelAI/mlt/commits{/sha}","git_commits_url":"https://api.github.com/repos/IntelAI/mlt/git/commits{/sha}","comments_url":"https://api.github.com/repos/IntelAI/mlt/comments{/number}","issue_comment_url":"https://api.github.com/repos/IntelAI/mlt/issues/comments{/number}","contents_url":"https://api.github.com/repos/IntelAI/mlt/contents/{+path}","compare_url":"https://api.github.com/repos/IntelAI/mlt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IntelAI/mlt/merges","archive_url":"https://api.github.com/repos/IntelAI/mlt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IntelAI/mlt/downloads","issues_url":"https://api.github.com/repos/IntelAI/mlt/issues{/number}","pulls_url":"https://api.github.com/repos/IntelAI/mlt/pulls{/number}","milestones_url":"https://api.github.com/repos/IntelAI/mlt/milestones{/number}","notifications_url":"https://api.github.com/repos/IntelAI/mlt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IntelAI/mlt/labels{/name}","releases_url":"https://api.github.com/repos/IntelAI/mlt/releases{/id}","deployments_url":"https://api.github.com/repos/IntelAI/mlt/deployments","created_at":"2018-01-11T22:15:45Z","updated_at":"2018-06-25T06:39:57Z","pushed_at":"2018-06-25T18:12:31Z","git_url":"git://github.com/IntelAI/mlt.git","ssh_url":"git@github.com:IntelAI/mlt.git","clone_url":"https://github.com/IntelAI/mlt.git","svn_url":"https://github.com/IntelAI/mlt","homepage":"","size":1018,"stargazers_count":49,"watchers_count":49,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":66,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":10,"open_issues":66,"watchers":49,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/IntelAI/mlt/pulls/280"},"html":{"href":"https://github.com/IntelAI/mlt/pull/280"},"issue":{"href":"https://api.github.com/repos/IntelAI/mlt/issues/280"},"comments":{"href":"https://api.github.com/repos/IntelAI/mlt/issues/280/comments"},"review_comments":{"href":"https://api.github.com/repos/IntelAI/mlt/pulls/280/comments"},"review_comment":{"href":"https://api.github.com/repos/IntelAI/mlt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IntelAI/mlt/pulls/280/commits"},"statuses":{"href":"https://api.github.com/repos/IntelAI/mlt/statuses/fb68d4dfc6062b6a52c25919702af0df796fef6e"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"karthikvadla"}}