{"action":"created","comment":{"url":"https://api.github.com/repos/root-project/root/pulls/comments/186119639","pull_request_review_id":117651575,"id":186119639,"diff_hunk":"@@ -167,6 +167,8 @@ ROOT_BUILD_OPTION(table OFF \"Build libTable contrib library\")\n ROOT_BUILD_OPTION(tcmalloc OFF \"Using the tcmalloc allocator\")\n ROOT_BUILD_OPTION(thread ON \"Using thread library (cannot be disabled)\")\n ROOT_BUILD_OPTION(tmva ON \"Build TMVA multi variate analysis library\")\n+ROOT_BUILD_OPTION(tmva-cpu ON \"Build TMVA with CPU support for deep learning. Requires BLAS\")\n+ROOT_BUILD_OPTION(tmva-gpu ON \"Build TMVA with GPU support for deep learning. Requries CUDA\")","path":"cmake/modules/RootBuildOptions.cmake","position":5,"original_position":5,"commit_id":"71bdcb0d4f218df0e8819221e5dcf23054c0018d","original_commit_id":"71bdcb0d4f218df0e8819221e5dcf23054c0018d","user":{"login":"amadio","id":249404,"avatar_url":"https://avatars2.githubusercontent.com/u/249404?v=4","gravatar_id":"","url":"https://api.github.com/users/amadio","html_url":"https://github.com/amadio","followers_url":"https://api.github.com/users/amadio/followers","following_url":"https://api.github.com/users/amadio/following{/other_user}","gists_url":"https://api.github.com/users/amadio/gists{/gist_id}","starred_url":"https://api.github.com/users/amadio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amadio/subscriptions","organizations_url":"https://api.github.com/users/amadio/orgs","repos_url":"https://api.github.com/users/amadio/repos","events_url":"https://api.github.com/users/amadio/events{/privacy}","received_events_url":"https://api.github.com/users/amadio/received_events","type":"User","site_admin":false},"body":"Do we really need the extra CMake options? We can probably reuse the `cuda` option, and add only `blas` to the list. What do you think?","created_at":"2018-05-04T15:32:22Z","updated_at":"2018-05-04T15:32:22Z","html_url":"https://github.com/root-project/root/pull/1976#discussion_r186119639","pull_request_url":"https://api.github.com/repos/root-project/root/pulls/1976","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/root-project/root/pulls/comments/186119639"},"html":{"href":"https://github.com/root-project/root/pull/1976#discussion_r186119639"},"pull_request":{"href":"https://api.github.com/repos/root-project/root/pulls/1976"}}},"pull_request":{"url":"https://api.github.com/repos/root-project/root/pulls/1976","id":185996493,"html_url":"https://github.com/root-project/root/pull/1976","diff_url":"https://github.com/root-project/root/pull/1976.diff","patch_url":"https://github.com/root-project/root/pull/1976.patch","issue_url":"https://api.github.com/repos/root-project/root/issues/1976","number":1976,"state":"open","locked":false,"title":"Add RNN to TMVA","user":{"login":"lmoneta","id":5213559,"avatar_url":"https://avatars1.githubusercontent.com/u/5213559?v=4","gravatar_id":"","url":"https://api.github.com/users/lmoneta","html_url":"https://github.com/lmoneta","followers_url":"https://api.github.com/users/lmoneta/followers","following_url":"https://api.github.com/users/lmoneta/following{/other_user}","gists_url":"https://api.github.com/users/lmoneta/gists{/gist_id}","starred_url":"https://api.github.com/users/lmoneta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lmoneta/subscriptions","organizations_url":"https://api.github.com/users/lmoneta/orgs","repos_url":"https://api.github.com/users/lmoneta/repos","events_url":"https://api.github.com/users/lmoneta/events{/privacy}","received_events_url":"https://api.github.com/users/lmoneta/received_events","type":"User","site_admin":false},"body":"This PR include the RNN developed by Saurav Shektar, GSOC 2017","created_at":"2018-05-04T14:14:43Z","updated_at":"2018-05-04T15:32:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5cf267686010be5cd59bcd4c60f44682a21c68d8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Axel-Naumann","id":144675,"avatar_url":"https://avatars1.githubusercontent.com/u/144675?v=4","gravatar_id":"","url":"https://api.github.com/users/Axel-Naumann","html_url":"https://github.com/Axel-Naumann","followers_url":"https://api.github.com/users/Axel-Naumann/followers","following_url":"https://api.github.com/users/Axel-Naumann/following{/other_user}","gists_url":"https://api.github.com/users/Axel-Naumann/gists{/gist_id}","starred_url":"https://api.github.com/users/Axel-Naumann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Axel-Naumann/subscriptions","organizations_url":"https://api.github.com/users/Axel-Naumann/orgs","repos_url":"https://api.github.com/users/Axel-Naumann/repos","events_url":"https://api.github.com/users/Axel-Naumann/events{/privacy}","received_events_url":"https://api.github.com/users/Axel-Naumann/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/root-project/root/pulls/1976/commits","review_comments_url":"https://api.github.com/repos/root-project/root/pulls/1976/comments","review_comment_url":"https://api.github.com/repos/root-project/root/pulls/comments{/number}","comments_url":"https://api.github.com/repos/root-project/root/issues/1976/comments","statuses_url":"https://api.github.com/repos/root-project/root/statuses/71bdcb0d4f218df0e8819221e5dcf23054c0018d","head":{"label":"lmoneta:tmva-dnn-rnn","ref":"tmva-dnn-rnn","sha":"71bdcb0d4f218df0e8819221e5dcf23054c0018d","user":{"login":"lmoneta","id":5213559,"avatar_url":"https://avatars1.githubusercontent.com/u/5213559?v=4","gravatar_id":"","url":"https://api.github.com/users/lmoneta","html_url":"https://github.com/lmoneta","followers_url":"https://api.github.com/users/lmoneta/followers","following_url":"https://api.github.com/users/lmoneta/following{/other_user}","gists_url":"https://api.github.com/users/lmoneta/gists{/gist_id}","starred_url":"https://api.github.com/users/lmoneta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lmoneta/subscriptions","organizations_url":"https://api.github.com/users/lmoneta/orgs","repos_url":"https://api.github.com/users/lmoneta/repos","events_url":"https://api.github.com/users/lmoneta/events{/privacy}","received_events_url":"https://api.github.com/users/lmoneta/received_events","type":"User","site_admin":false},"repo":{"id":12644760,"name":"root","full_name":"lmoneta/root","owner":{"login":"lmoneta","id":5213559,"avatar_url":"https://avatars1.githubusercontent.com/u/5213559?v=4","gravatar_id":"","url":"https://api.github.com/users/lmoneta","html_url":"https://github.com/lmoneta","followers_url":"https://api.github.com/users/lmoneta/followers","following_url":"https://api.github.com/users/lmoneta/following{/other_user}","gists_url":"https://api.github.com/users/lmoneta/gists{/gist_id}","starred_url":"https://api.github.com/users/lmoneta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lmoneta/subscriptions","organizations_url":"https://api.github.com/users/lmoneta/orgs","repos_url":"https://api.github.com/users/lmoneta/repos","events_url":"https://api.github.com/users/lmoneta/events{/privacy}","received_events_url":"https://api.github.com/users/lmoneta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lmoneta/root","description":"Mirror of official ROOT git repository located at ","fork":true,"url":"https://api.github.com/repos/lmoneta/root","forks_url":"https://api.github.com/repos/lmoneta/root/forks","keys_url":"https://api.github.com/repos/lmoneta/root/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lmoneta/root/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lmoneta/root/teams","hooks_url":"https://api.github.com/repos/lmoneta/root/hooks","issue_events_url":"https://api.github.com/repos/lmoneta/root/issues/events{/number}","events_url":"https://api.github.com/repos/lmoneta/root/events","assignees_url":"https://api.github.com/repos/lmoneta/root/assignees{/user}","branches_url":"https://api.github.com/repos/lmoneta/root/branches{/branch}","tags_url":"https://api.github.com/repos/lmoneta/root/tags","blobs_url":"https://api.github.com/repos/lmoneta/root/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lmoneta/root/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lmoneta/root/git/refs{/sha}","trees_url":"https://api.github.com/repos/lmoneta/root/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lmoneta/root/statuses/{sha}","languages_url":"https://api.github.com/repos/lmoneta/root/languages","stargazers_url":"https://api.github.com/repos/lmoneta/root/stargazers","contributors_url":"https://api.github.com/repos/lmoneta/root/contributors","subscribers_url":"https://api.github.com/repos/lmoneta/root/subscribers","subscription_url":"https://api.github.com/repos/lmoneta/root/subscription","commits_url":"https://api.github.com/repos/lmoneta/root/commits{/sha}","git_commits_url":"https://api.github.com/repos/lmoneta/root/git/commits{/sha}","comments_url":"https://api.github.com/repos/lmoneta/root/comments{/number}","issue_comment_url":"https://api.github.com/repos/lmoneta/root/issues/comments{/number}","contents_url":"https://api.github.com/repos/lmoneta/root/contents/{+path}","compare_url":"https://api.github.com/repos/lmoneta/root/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lmoneta/root/merges","archive_url":"https://api.github.com/repos/lmoneta/root/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lmoneta/root/downloads","issues_url":"https://api.github.com/repos/lmoneta/root/issues{/number}","pulls_url":"https://api.github.com/repos/lmoneta/root/pulls{/number}","milestones_url":"https://api.github.com/repos/lmoneta/root/milestones{/number}","notifications_url":"https://api.github.com/repos/lmoneta/root/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lmoneta/root/labels{/name}","releases_url":"https://api.github.com/repos/lmoneta/root/releases{/id}","deployments_url":"https://api.github.com/repos/lmoneta/root/deployments","created_at":"2013-09-06T13:31:15Z","updated_at":"2017-03-01T14:12:57Z","pushed_at":"2018-05-04T14:14:32Z","git_url":"git://github.com/lmoneta/root.git","ssh_url":"git@github.com:lmoneta/root.git","clone_url":"https://github.com/lmoneta/root.git","svn_url":"https://github.com/lmoneta/root","homepage":"http://root.cern.ch","size":689370,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"root-project:master","ref":"master","sha":"99af46f752c3cbcec432308bb078ce1142bb768a","user":{"login":"root-project","id":6450093,"avatar_url":"https://avatars1.githubusercontent.com/u/6450093?v=4","gravatar_id":"","url":"https://api.github.com/users/root-project","html_url":"https://github.com/root-project","followers_url":"https://api.github.com/users/root-project/followers","following_url":"https://api.github.com/users/root-project/following{/other_user}","gists_url":"https://api.github.com/users/root-project/gists{/gist_id}","starred_url":"https://api.github.com/users/root-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/root-project/subscriptions","organizations_url":"https://api.github.com/users/root-project/orgs","repos_url":"https://api.github.com/users/root-project/repos","events_url":"https://api.github.com/users/root-project/events{/privacy}","received_events_url":"https://api.github.com/users/root-project/received_events","type":"Organization","site_admin":false},"repo":{"id":10994345,"name":"root","full_name":"root-project/root","owner":{"login":"root-project","id":6450093,"avatar_url":"https://avatars1.githubusercontent.com/u/6450093?v=4","gravatar_id":"","url":"https://api.github.com/users/root-project","html_url":"https://github.com/root-project","followers_url":"https://api.github.com/users/root-project/followers","following_url":"https://api.github.com/users/root-project/following{/other_user}","gists_url":"https://api.github.com/users/root-project/gists{/gist_id}","starred_url":"https://api.github.com/users/root-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/root-project/subscriptions","organizations_url":"https://api.github.com/users/root-project/orgs","repos_url":"https://api.github.com/users/root-project/repos","events_url":"https://api.github.com/users/root-project/events{/privacy}","received_events_url":"https://api.github.com/users/root-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/root-project/root","description":"The official ROOT repository","fork":false,"url":"https://api.github.com/repos/root-project/root","forks_url":"https://api.github.com/repos/root-project/root/forks","keys_url":"https://api.github.com/repos/root-project/root/keys{/key_id}","collaborators_url":"https://api.github.com/repos/root-project/root/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/root-project/root/teams","hooks_url":"https://api.github.com/repos/root-project/root/hooks","issue_events_url":"https://api.github.com/repos/root-project/root/issues/events{/number}","events_url":"https://api.github.com/repos/root-project/root/events","assignees_url":"https://api.github.com/repos/root-project/root/assignees{/user}","branches_url":"https://api.github.com/repos/root-project/root/branches{/branch}","tags_url":"https://api.github.com/repos/root-project/root/tags","blobs_url":"https://api.github.com/repos/root-project/root/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/root-project/root/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/root-project/root/git/refs{/sha}","trees_url":"https://api.github.com/repos/root-project/root/git/trees{/sha}","statuses_url":"https://api.github.com/repos/root-project/root/statuses/{sha}","languages_url":"https://api.github.com/repos/root-project/root/languages","stargazers_url":"https://api.github.com/repos/root-project/root/stargazers","contributors_url":"https://api.github.com/repos/root-project/root/contributors","subscribers_url":"https://api.github.com/repos/root-project/root/subscribers","subscription_url":"https://api.github.com/repos/root-project/root/subscription","commits_url":"https://api.github.com/repos/root-project/root/commits{/sha}","git_commits_url":"https://api.github.com/repos/root-project/root/git/commits{/sha}","comments_url":"https://api.github.com/repos/root-project/root/comments{/number}","issue_comment_url":"https://api.github.com/repos/root-project/root/issues/comments{/number}","contents_url":"https://api.github.com/repos/root-project/root/contents/{+path}","compare_url":"https://api.github.com/repos/root-project/root/compare/{base}...{head}","merges_url":"https://api.github.com/repos/root-project/root/merges","archive_url":"https://api.github.com/repos/root-project/root/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/root-project/root/downloads","issues_url":"https://api.github.com/repos/root-project/root/issues{/number}","pulls_url":"https://api.github.com/repos/root-project/root/pulls{/number}","milestones_url":"https://api.github.com/repos/root-project/root/milestones{/number}","notifications_url":"https://api.github.com/repos/root-project/root/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/root-project/root/labels{/name}","releases_url":"https://api.github.com/repos/root-project/root/releases{/id}","deployments_url":"https://api.github.com/repos/root-project/root/deployments","created_at":"2013-06-27T10:46:59Z","updated_at":"2018-05-04T14:54:18Z","pushed_at":"2018-05-04T15:24:58Z","git_url":"git://github.com/root-project/root.git","ssh_url":"git@github.com:root-project/root.git","clone_url":"https://github.com/root-project/root.git","svn_url":"https://github.com/root-project/root","homepage":"https://root.cern","size":687866,"stargazers_count":573,"watchers_count":573,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":421,"mirror_url":null,"archived":false,"open_issues_count":53,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":421,"open_issues":53,"watchers":573,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/root-project/root/pulls/1976"},"html":{"href":"https://github.com/root-project/root/pull/1976"},"issue":{"href":"https://api.github.com/repos/root-project/root/issues/1976"},"comments":{"href":"https://api.github.com/repos/root-project/root/issues/1976/comments"},"review_comments":{"href":"https://api.github.com/repos/root-project/root/pulls/1976/comments"},"review_comment":{"href":"https://api.github.com/repos/root-project/root/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/root-project/root/pulls/1976/commits"},"statuses":{"href":"https://api.github.com/repos/root-project/root/statuses/71bdcb0d4f218df0e8819221e5dcf23054c0018d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"amadio"}}