{"action":"created","comment":{"url":"https://api.github.com/repos/wix/wix-style-react/pulls/comments/209923156","pull_request_review_id":146028777,"id":209923156,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTkyMzE1Ng==","diff_hunk":"@@ -3,15 +3,19 @@ import {node} from 'prop-types';\n import styles from './Content.scss';\n \n class Content extends Component {\n-\n   static propTypes = {\n     children: node\n   };\n \n+  _getChildName = children =>\n+    children.type && (children.type.name || children.type.displayName);","path":"src/Card/Content/Content.js","position":10,"original_position":10,"commit_id":"d8c436c2cb84015f67ff6efee7584bc65d5cc7d5","original_commit_id":"d8c436c2cb84015f67ff6efee7584bc65d5cc7d5","user":{"login":"shlomitc","id":6093192,"node_id":"MDQ6VXNlcjYwOTMxOTI=","avatar_url":"https://avatars0.githubusercontent.com/u/6093192?v=4","gravatar_id":"","url":"https://api.github.com/users/shlomitc","html_url":"https://github.com/shlomitc","followers_url":"https://api.github.com/users/shlomitc/followers","following_url":"https://api.github.com/users/shlomitc/following{/other_user}","gists_url":"https://api.github.com/users/shlomitc/gists{/gist_id}","starred_url":"https://api.github.com/users/shlomitc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlomitc/subscriptions","organizations_url":"https://api.github.com/users/shlomitc/orgs","repos_url":"https://api.github.com/users/shlomitc/repos","events_url":"https://api.github.com/users/shlomitc/events{/privacy}","received_events_url":"https://api.github.com/users/shlomitc/received_events","type":"User","site_admin":false},"body":"We're going to solve the HMR anyway. For example Page component doesn't work in newly generated projects. So it's not we're organizing our code, we're handling an issue.\r\n\r\nIf possible, I prefer not adding more `displayName` if statements, because we'll just need to solve it later. @yardnsm is trying to fix it now for the Page, so sync together regarding a solution.","created_at":"2018-08-14T11:58:03Z","updated_at":"2018-08-14T11:58:04Z","html_url":"https://github.com/wix/wix-style-react/pull/2130#discussion_r209923156","pull_request_url":"https://api.github.com/repos/wix/wix-style-react/pulls/2130","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/wix/wix-style-react/pulls/comments/209923156"},"html":{"href":"https://github.com/wix/wix-style-react/pull/2130#discussion_r209923156"},"pull_request":{"href":"https://api.github.com/repos/wix/wix-style-react/pulls/2130"}},"in_reply_to_id":209920294},"pull_request":{"url":"https://api.github.com/repos/wix/wix-style-react/pulls/2130","id":208201524,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MjAxNTI0","html_url":"https://github.com/wix/wix-style-react/pull/2130","diff_url":"https://github.com/wix/wix-style-react/pull/2130.diff","patch_url":"https://github.com/wix/wix-style-react/pull/2130.patch","issue_url":"https://api.github.com/repos/wix/wix-style-react/issues/2130","number":2130,"state":"open","locked":false,"title":"chore(Card.EmptyState): remove additional component and simply use composition","user":{"login":"argshook","id":4284659,"node_id":"MDQ6VXNlcjQyODQ2NTk=","avatar_url":"https://avatars2.githubusercontent.com/u/4284659?v=4","gravatar_id":"","url":"https://api.github.com/users/argshook","html_url":"https://github.com/argshook","followers_url":"https://api.github.com/users/argshook/followers","following_url":"https://api.github.com/users/argshook/following{/other_user}","gists_url":"https://api.github.com/users/argshook/gists{/gist_id}","starred_url":"https://api.github.com/users/argshook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/argshook/subscriptions","organizations_url":"https://api.github.com/users/argshook/orgs","repos_url":"https://api.github.com/users/argshook/repos","events_url":"https://api.github.com/users/argshook/events{/privacy}","received_events_url":"https://api.github.com/users/argshook/received_events","type":"User","site_admin":false},"body":"with addition of `EmptyState` to `Card` as `Card.EmptyState` all consumers who use just `Card` would suddenly get `EmptyState` in their bundles too, even if they never use it.\r\n\r\nmoreover, `EmptyState` wants to have `section` theme by default and in that case `Card.EmptyState`\r\nonly purpose is to set different padding.\r\n\r\nso, instead of adding additional component, weigh into consumers bundle and create additional API,\r\nit's much more simple to just set different padding in `Card.Content` when children is `EmptyState`.\r\n\r\nno new API, practically no new code, only composition\r\n\r\ndepends on https://github.com/wix/wix-style-react/pull/2129 (merged)\r\nrelated https://github.com/wix/wix-style-react/pull/2117","created_at":"2018-08-14T08:13:47Z","updated_at":"2018-08-14T11:58:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"085dc94ee92506ad47c95ec87482095eabc30430","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wix/wix-style-react/pulls/2130/commits","review_comments_url":"https://api.github.com/repos/wix/wix-style-react/pulls/2130/comments","review_comment_url":"https://api.github.com/repos/wix/wix-style-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wix/wix-style-react/issues/2130/comments","statuses_url":"https://api.github.com/repos/wix/wix-style-react/statuses/d8c436c2cb84015f67ff6efee7584bc65d5cc7d5","head":{"label":"wix:chore/remove-card-emptystate","ref":"chore/remove-card-emptystate","sha":"d8c436c2cb84015f67ff6efee7584bc65d5cc7d5","user":{"login":"wix","id":686511,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/686511?v=4","gravatar_id":"","url":"https://api.github.com/users/wix","html_url":"https://github.com/wix","followers_url":"https://api.github.com/users/wix/followers","following_url":"https://api.github.com/users/wix/following{/other_user}","gists_url":"https://api.github.com/users/wix/gists{/gist_id}","starred_url":"https://api.github.com/users/wix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wix/subscriptions","organizations_url":"https://api.github.com/users/wix/orgs","repos_url":"https://api.github.com/users/wix/repos","events_url":"https://api.github.com/users/wix/events{/privacy}","received_events_url":"https://api.github.com/users/wix/received_events","type":"Organization","site_admin":false},"repo":{"id":73713311,"node_id":"MDEwOlJlcG9zaXRvcnk3MzcxMzMxMQ==","name":"wix-style-react","full_name":"wix/wix-style-react","owner":{"login":"wix","id":686511,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/686511?v=4","gravatar_id":"","url":"https://api.github.com/users/wix","html_url":"https://github.com/wix","followers_url":"https://api.github.com/users/wix/followers","following_url":"https://api.github.com/users/wix/following{/other_user}","gists_url":"https://api.github.com/users/wix/gists{/gist_id}","starred_url":"https://api.github.com/users/wix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wix/subscriptions","organizations_url":"https://api.github.com/users/wix/orgs","repos_url":"https://api.github.com/users/wix/repos","events_url":"https://api.github.com/users/wix/events{/privacy}","received_events_url":"https://api.github.com/users/wix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wix/wix-style-react","description":"Common React UI components for all Wix verticals developing in React","fork":false,"url":"https://api.github.com/repos/wix/wix-style-react","forks_url":"https://api.github.com/repos/wix/wix-style-react/forks","keys_url":"https://api.github.com/repos/wix/wix-style-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wix/wix-style-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wix/wix-style-react/teams","hooks_url":"https://api.github.com/repos/wix/wix-style-react/hooks","issue_events_url":"https://api.github.com/repos/wix/wix-style-react/issues/events{/number}","events_url":"https://api.github.com/repos/wix/wix-style-react/events","assignees_url":"https://api.github.com/repos/wix/wix-style-react/assignees{/user}","branches_url":"https://api.github.com/repos/wix/wix-style-react/branches{/branch}","tags_url":"https://api.github.com/repos/wix/wix-style-react/tags","blobs_url":"https://api.github.com/repos/wix/wix-style-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wix/wix-style-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wix/wix-style-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/wix/wix-style-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wix/wix-style-react/statuses/{sha}","languages_url":"https://api.github.com/repos/wix/wix-style-react/languages","stargazers_url":"https://api.github.com/repos/wix/wix-style-react/stargazers","contributors_url":"https://api.github.com/repos/wix/wix-style-react/contributors","subscribers_url":"https://api.github.com/repos/wix/wix-style-react/subscribers","subscription_url":"https://api.github.com/repos/wix/wix-style-react/subscription","commits_url":"https://api.github.com/repos/wix/wix-style-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/wix/wix-style-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/wix/wix-style-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/wix/wix-style-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/wix/wix-style-react/contents/{+path}","compare_url":"https://api.github.com/repos/wix/wix-style-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wix/wix-style-react/merges","archive_url":"https://api.github.com/repos/wix/wix-style-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wix/wix-style-react/downloads","issues_url":"https://api.github.com/repos/wix/wix-style-react/issues{/number}","pulls_url":"https://api.github.com/repos/wix/wix-style-react/pulls{/number}","milestones_url":"https://api.github.com/repos/wix/wix-style-react/milestones{/number}","notifications_url":"https://api.github.com/repos/wix/wix-style-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wix/wix-style-react/labels{/name}","releases_url":"https://api.github.com/repos/wix/wix-style-react/releases{/id}","deployments_url":"https://api.github.com/repos/wix/wix-style-react/deployments","created_at":"2016-11-14T14:37:00Z","updated_at":"2018-08-14T10:00:29Z","pushed_at":"2018-08-14T11:43:12Z","git_url":"git://github.com/wix/wix-style-react.git","ssh_url":"git@github.com:wix/wix-style-react.git","clone_url":"https://github.com/wix/wix-style-react.git","svn_url":"https://github.com/wix/wix-style-react","homepage":"https://wix-wix-style-react.surge.sh","size":8292,"stargazers_count":326,"watchers_count":326,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":76,"mirror_url":null,"archived":false,"open_issues_count":90,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":76,"open_issues":90,"watchers":326,"default_branch":"master"}},"base":{"label":"wix:master","ref":"master","sha":"6d2257b0b93737c8afdb19a5734165a088c2d76b","user":{"login":"wix","id":686511,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/686511?v=4","gravatar_id":"","url":"https://api.github.com/users/wix","html_url":"https://github.com/wix","followers_url":"https://api.github.com/users/wix/followers","following_url":"https://api.github.com/users/wix/following{/other_user}","gists_url":"https://api.github.com/users/wix/gists{/gist_id}","starred_url":"https://api.github.com/users/wix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wix/subscriptions","organizations_url":"https://api.github.com/users/wix/orgs","repos_url":"https://api.github.com/users/wix/repos","events_url":"https://api.github.com/users/wix/events{/privacy}","received_events_url":"https://api.github.com/users/wix/received_events","type":"Organization","site_admin":false},"repo":{"id":73713311,"node_id":"MDEwOlJlcG9zaXRvcnk3MzcxMzMxMQ==","name":"wix-style-react","full_name":"wix/wix-style-react","owner":{"login":"wix","id":686511,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/686511?v=4","gravatar_id":"","url":"https://api.github.com/users/wix","html_url":"https://github.com/wix","followers_url":"https://api.github.com/users/wix/followers","following_url":"https://api.github.com/users/wix/following{/other_user}","gists_url":"https://api.github.com/users/wix/gists{/gist_id}","starred_url":"https://api.github.com/users/wix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wix/subscriptions","organizations_url":"https://api.github.com/users/wix/orgs","repos_url":"https://api.github.com/users/wix/repos","events_url":"https://api.github.com/users/wix/events{/privacy}","received_events_url":"https://api.github.com/users/wix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wix/wix-style-react","description":"Common React UI components for all Wix verticals developing in React","fork":false,"url":"https://api.github.com/repos/wix/wix-style-react","forks_url":"https://api.github.com/repos/wix/wix-style-react/forks","keys_url":"https://api.github.com/repos/wix/wix-style-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wix/wix-style-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wix/wix-style-react/teams","hooks_url":"https://api.github.com/repos/wix/wix-style-react/hooks","issue_events_url":"https://api.github.com/repos/wix/wix-style-react/issues/events{/number}","events_url":"https://api.github.com/repos/wix/wix-style-react/events","assignees_url":"https://api.github.com/repos/wix/wix-style-react/assignees{/user}","branches_url":"https://api.github.com/repos/wix/wix-style-react/branches{/branch}","tags_url":"https://api.github.com/repos/wix/wix-style-react/tags","blobs_url":"https://api.github.com/repos/wix/wix-style-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wix/wix-style-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wix/wix-style-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/wix/wix-style-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wix/wix-style-react/statuses/{sha}","languages_url":"https://api.github.com/repos/wix/wix-style-react/languages","stargazers_url":"https://api.github.com/repos/wix/wix-style-react/stargazers","contributors_url":"https://api.github.com/repos/wix/wix-style-react/contributors","subscribers_url":"https://api.github.com/repos/wix/wix-style-react/subscribers","subscription_url":"https://api.github.com/repos/wix/wix-style-react/subscription","commits_url":"https://api.github.com/repos/wix/wix-style-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/wix/wix-style-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/wix/wix-style-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/wix/wix-style-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/wix/wix-style-react/contents/{+path}","compare_url":"https://api.github.com/repos/wix/wix-style-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wix/wix-style-react/merges","archive_url":"https://api.github.com/repos/wix/wix-style-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wix/wix-style-react/downloads","issues_url":"https://api.github.com/repos/wix/wix-style-react/issues{/number}","pulls_url":"https://api.github.com/repos/wix/wix-style-react/pulls{/number}","milestones_url":"https://api.github.com/repos/wix/wix-style-react/milestones{/number}","notifications_url":"https://api.github.com/repos/wix/wix-style-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wix/wix-style-react/labels{/name}","releases_url":"https://api.github.com/repos/wix/wix-style-react/releases{/id}","deployments_url":"https://api.github.com/repos/wix/wix-style-react/deployments","created_at":"2016-11-14T14:37:00Z","updated_at":"2018-08-14T10:00:29Z","pushed_at":"2018-08-14T11:43:12Z","git_url":"git://github.com/wix/wix-style-react.git","ssh_url":"git@github.com:wix/wix-style-react.git","clone_url":"https://github.com/wix/wix-style-react.git","svn_url":"https://github.com/wix/wix-style-react","homepage":"https://wix-wix-style-react.surge.sh","size":8292,"stargazers_count":326,"watchers_count":326,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":76,"mirror_url":null,"archived":false,"open_issues_count":90,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":76,"open_issues":90,"watchers":326,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wix/wix-style-react/pulls/2130"},"html":{"href":"https://github.com/wix/wix-style-react/pull/2130"},"issue":{"href":"https://api.github.com/repos/wix/wix-style-react/issues/2130"},"comments":{"href":"https://api.github.com/repos/wix/wix-style-react/issues/2130/comments"},"review_comments":{"href":"https://api.github.com/repos/wix/wix-style-react/pulls/2130/comments"},"review_comment":{"href":"https://api.github.com/repos/wix/wix-style-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wix/wix-style-react/pulls/2130/commits"},"statuses":{"href":"https://api.github.com/repos/wix/wix-style-react/statuses/d8c436c2cb84015f67ff6efee7584bc65d5cc7d5"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"shlomitc"}}