{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/21087","repository_url":"https://api.github.com/repos/servo/servo","labels_url":"https://api.github.com/repos/servo/servo/issues/21087/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/21087/comments","events_url":"https://api.github.com/repos/servo/servo/issues/21087/events","html_url":"https://github.com/servo/servo/pull/21087","id":335091538,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2ODk2Mzg3","number":21087,"title":"Add window icon on X11 and Windows","user":{"login":"UK992","id":1530353,"node_id":"MDQ6VXNlcjE1MzAzNTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1530353?v=4","gravatar_id":"","url":"https://api.github.com/users/UK992","html_url":"https://github.com/UK992","followers_url":"https://api.github.com/users/UK992/followers","following_url":"https://api.github.com/users/UK992/following{/other_user}","gists_url":"https://api.github.com/users/UK992/gists{/gist_id}","starred_url":"https://api.github.com/users/UK992/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UK992/subscriptions","organizations_url":"https://api.github.com/users/UK992/orgs","repos_url":"https://api.github.com/users/UK992/repos","events_url":"https://api.github.com/users/UK992/events{/privacy}","received_events_url":"https://api.github.com/users/UK992/received_events","type":"User","site_admin":false},"labels":[{"id":152310100,"node_id":"MDU6TGFiZWwxNTIzMTAxMDA=","url":"https://api.github.com/repos/servo/servo/labels/S-tests-failed","name":"S-tests-failed","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":{"login":"jdm","id":27658,"node_id":"MDQ6VXNlcjI3NjU4","avatar_url":"https://avatars1.githubusercontent.com/u/27658?v=4","gravatar_id":"","url":"https://api.github.com/users/jdm","html_url":"https://github.com/jdm","followers_url":"https://api.github.com/users/jdm/followers","following_url":"https://api.github.com/users/jdm/following{/other_user}","gists_url":"https://api.github.com/users/jdm/gists{/gist_id}","starred_url":"https://api.github.com/users/jdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdm/subscriptions","organizations_url":"https://api.github.com/users/jdm/orgs","repos_url":"https://api.github.com/users/jdm/repos","events_url":"https://api.github.com/users/jdm/events{/privacy}","received_events_url":"https://api.github.com/users/jdm/received_events","type":"User","site_admin":false},"assignees":[{"login":"jdm","id":27658,"node_id":"MDQ6VXNlcjI3NjU4","avatar_url":"https://avatars1.githubusercontent.com/u/27658?v=4","gravatar_id":"","url":"https://api.github.com/users/jdm","html_url":"https://github.com/jdm","followers_url":"https://api.github.com/users/jdm/followers","following_url":"https://api.github.com/users/jdm/following{/other_user}","gists_url":"https://api.github.com/users/jdm/gists{/gist_id}","starred_url":"https://api.github.com/users/jdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdm/subscriptions","organizations_url":"https://api.github.com/users/jdm/orgs","repos_url":"https://api.github.com/users/jdm/repos","events_url":"https://api.github.com/users/jdm/events{/privacy}","received_events_url":"https://api.github.com/users/jdm/received_events","type":"User","site_admin":false}],"milestone":null,"comments":11,"created_at":"2018-06-23T11:10:56Z","updated_at":"2018-06-30T20:19:08Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/21087","html_url":"https://github.com/servo/servo/pull/21087","diff_url":"https://github.com/servo/servo/pull/21087.diff","patch_url":"https://github.com/servo/servo/pull/21087.patch"},"body":"<!-- Please describe your changes on the following line: -->\r\n\r\n\r\n---\r\n<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->\r\n- [X] `./mach build -d` does not report any errors\r\n- [ ] `./mach test-tidy` does not report any errors\r\n- [ ] These changes fix #20761\r\n\r\n<!-- Either: -->\r\n- [ ] There are tests for these changes OR\r\n- [ ] These changes do not require tests because _____\r\n\r\n<!-- Also, please make sure that \"Allow edits from maintainers\" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->\r\n\r\n<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/21087)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/401563925","html_url":"https://github.com/servo/servo/pull/21087#issuecomment-401563925","issue_url":"https://api.github.com/repos/servo/servo/issues/21087","id":401563925,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTU2MzkyNQ==","user":{"login":"atouchet","id":26315797,"node_id":"MDQ6VXNlcjI2MzE1Nzk3","avatar_url":"https://avatars2.githubusercontent.com/u/26315797?v=4","gravatar_id":"","url":"https://api.github.com/users/atouchet","html_url":"https://github.com/atouchet","followers_url":"https://api.github.com/users/atouchet/followers","following_url":"https://api.github.com/users/atouchet/following{/other_user}","gists_url":"https://api.github.com/users/atouchet/gists{/gist_id}","starred_url":"https://api.github.com/users/atouchet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atouchet/subscriptions","organizations_url":"https://api.github.com/users/atouchet/orgs","repos_url":"https://api.github.com/users/atouchet/repos","events_url":"https://api.github.com/users/atouchet/events{/privacy}","received_events_url":"https://api.github.com/users/atouchet/received_events","type":"User","site_admin":false},"created_at":"2018-06-30T20:19:08Z","updated_at":"2018-06-30T20:19:08Z","author_association":"CONTRIBUTOR","body":"@UK992 would it be possible to update straight to winit 0.16/glutin 0.17? That would help fix a couple of additional issues (see: https://github.com/servo/servo/issues/20505#issuecomment-401513634, https://github.com/servo/servo/pull/21094#issuecomment-401447878)."}}
{"actor":{"display_login":"atouchet"}}