{"action":"closed","number":5662,"pull_request":{"url":"https://api.github.com/repos/python/mypy/pulls/5662","id":217533988,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NTMzOTg4","html_url":"https://github.com/python/mypy/pull/5662","diff_url":"https://github.com/python/mypy/pull/5662.diff","patch_url":"https://github.com/python/mypy/pull/5662.patch","issue_url":"https://api.github.com/repos/python/mypy/issues/5662","number":5662,"state":"closed","locked":false,"title":"Fix crash on overriding class level type alias","user":{"login":"ilevkivskyi","id":12005495,"node_id":"MDQ6VXNlcjEyMDA1NDk1","avatar_url":"https://avatars1.githubusercontent.com/u/12005495?v=4","gravatar_id":"","url":"https://api.github.com/users/ilevkivskyi","html_url":"https://github.com/ilevkivskyi","followers_url":"https://api.github.com/users/ilevkivskyi/followers","following_url":"https://api.github.com/users/ilevkivskyi/following{/other_user}","gists_url":"https://api.github.com/users/ilevkivskyi/gists{/gist_id}","starred_url":"https://api.github.com/users/ilevkivskyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilevkivskyi/subscriptions","organizations_url":"https://api.github.com/users/ilevkivskyi/orgs","repos_url":"https://api.github.com/users/ilevkivskyi/repos","events_url":"https://api.github.com/users/ilevkivskyi/events{/privacy}","received_events_url":"https://api.github.com/users/ilevkivskyi/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/python/mypy/issues/5425\r\n\r\nThe solution is to just prohibit overriding type aliases in subclass. In some sense they are implicitly final, because we need to know them statically (they can be used as type sin annotations).\r\n\r\nThe assert that was triggered missed two cases for superclass node: `TypeAlias` and `Var`, for `Var` I just return `Any` since there are no way to determine type if deferring failed (currently there is fixed number of type-checking passes).","created_at":"2018-09-23T22:08:48Z","updated_at":"2018-09-24T14:02:39Z","closed_at":"2018-09-24T14:02:39Z","merged_at":null,"merge_commit_sha":"b4c23522188e252b9f18f4b0248d565a4a13ff76","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Michael0x2a","id":1424628,"node_id":"MDQ6VXNlcjE0MjQ2Mjg=","avatar_url":"https://avatars1.githubusercontent.com/u/1424628?v=4","gravatar_id":"","url":"https://api.github.com/users/Michael0x2a","html_url":"https://github.com/Michael0x2a","followers_url":"https://api.github.com/users/Michael0x2a/followers","following_url":"https://api.github.com/users/Michael0x2a/following{/other_user}","gists_url":"https://api.github.com/users/Michael0x2a/gists{/gist_id}","starred_url":"https://api.github.com/users/Michael0x2a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Michael0x2a/subscriptions","organizations_url":"https://api.github.com/users/Michael0x2a/orgs","repos_url":"https://api.github.com/users/Michael0x2a/repos","events_url":"https://api.github.com/users/Michael0x2a/events{/privacy}","received_events_url":"https://api.github.com/users/Michael0x2a/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/python/mypy/pulls/5662/commits","review_comments_url":"https://api.github.com/repos/python/mypy/pulls/5662/comments","review_comment_url":"https://api.github.com/repos/python/mypy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/python/mypy/issues/5662/comments","statuses_url":"https://api.github.com/repos/python/mypy/statuses/291281cdde724e6d829aebaf363dbd4789cfb2b7","head":{"label":"ilevkivskyi:fix-alias-over","ref":"fix-alias-over","sha":"291281cdde724e6d829aebaf363dbd4789cfb2b7","user":{"login":"ilevkivskyi","id":12005495,"node_id":"MDQ6VXNlcjEyMDA1NDk1","avatar_url":"https://avatars1.githubusercontent.com/u/12005495?v=4","gravatar_id":"","url":"https://api.github.com/users/ilevkivskyi","html_url":"https://github.com/ilevkivskyi","followers_url":"https://api.github.com/users/ilevkivskyi/followers","following_url":"https://api.github.com/users/ilevkivskyi/following{/other_user}","gists_url":"https://api.github.com/users/ilevkivskyi/gists{/gist_id}","starred_url":"https://api.github.com/users/ilevkivskyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilevkivskyi/subscriptions","organizations_url":"https://api.github.com/users/ilevkivskyi/orgs","repos_url":"https://api.github.com/users/ilevkivskyi/repos","events_url":"https://api.github.com/users/ilevkivskyi/events{/privacy}","received_events_url":"https://api.github.com/users/ilevkivskyi/received_events","type":"User","site_admin":false},"repo":{"id":55439770,"node_id":"MDEwOlJlcG9zaXRvcnk1NTQzOTc3MA==","name":"mypy","full_name":"ilevkivskyi/mypy","private":false,"owner":{"login":"ilevkivskyi","id":12005495,"node_id":"MDQ6VXNlcjEyMDA1NDk1","avatar_url":"https://avatars1.githubusercontent.com/u/12005495?v=4","gravatar_id":"","url":"https://api.github.com/users/ilevkivskyi","html_url":"https://github.com/ilevkivskyi","followers_url":"https://api.github.com/users/ilevkivskyi/followers","following_url":"https://api.github.com/users/ilevkivskyi/following{/other_user}","gists_url":"https://api.github.com/users/ilevkivskyi/gists{/gist_id}","starred_url":"https://api.github.com/users/ilevkivskyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilevkivskyi/subscriptions","organizations_url":"https://api.github.com/users/ilevkivskyi/orgs","repos_url":"https://api.github.com/users/ilevkivskyi/repos","events_url":"https://api.github.com/users/ilevkivskyi/events{/privacy}","received_events_url":"https://api.github.com/users/ilevkivskyi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ilevkivskyi/mypy","description":"Optional static typing for Python","fork":true,"url":"https://api.github.com/repos/ilevkivskyi/mypy","forks_url":"https://api.github.com/repos/ilevkivskyi/mypy/forks","keys_url":"https://api.github.com/repos/ilevkivskyi/mypy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ilevkivskyi/mypy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ilevkivskyi/mypy/teams","hooks_url":"https://api.github.com/repos/ilevkivskyi/mypy/hooks","issue_events_url":"https://api.github.com/repos/ilevkivskyi/mypy/issues/events{/number}","events_url":"https://api.github.com/repos/ilevkivskyi/mypy/events","assignees_url":"https://api.github.com/repos/ilevkivskyi/mypy/assignees{/user}","branches_url":"https://api.github.com/repos/ilevkivskyi/mypy/branches{/branch}","tags_url":"https://api.github.com/repos/ilevkivskyi/mypy/tags","blobs_url":"https://api.github.com/repos/ilevkivskyi/mypy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ilevkivskyi/mypy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ilevkivskyi/mypy/git/refs{/sha}","trees_url":"https://api.github.com/repos/ilevkivskyi/mypy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ilevkivskyi/mypy/statuses/{sha}","languages_url":"https://api.github.com/repos/ilevkivskyi/mypy/languages","stargazers_url":"https://api.github.com/repos/ilevkivskyi/mypy/stargazers","contributors_url":"https://api.github.com/repos/ilevkivskyi/mypy/contributors","subscribers_url":"https://api.github.com/repos/ilevkivskyi/mypy/subscribers","subscription_url":"https://api.github.com/repos/ilevkivskyi/mypy/subscription","commits_url":"https://api.github.com/repos/ilevkivskyi/mypy/commits{/sha}","git_commits_url":"https://api.github.com/repos/ilevkivskyi/mypy/git/commits{/sha}","comments_url":"https://api.github.com/repos/ilevkivskyi/mypy/comments{/number}","issue_comment_url":"https://api.github.com/repos/ilevkivskyi/mypy/issues/comments{/number}","contents_url":"https://api.github.com/repos/ilevkivskyi/mypy/contents/{+path}","compare_url":"https://api.github.com/repos/ilevkivskyi/mypy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ilevkivskyi/mypy/merges","archive_url":"https://api.github.com/repos/ilevkivskyi/mypy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ilevkivskyi/mypy/downloads","issues_url":"https://api.github.com/repos/ilevkivskyi/mypy/issues{/number}","pulls_url":"https://api.github.com/repos/ilevkivskyi/mypy/pulls{/number}","milestones_url":"https://api.github.com/repos/ilevkivskyi/mypy/milestones{/number}","notifications_url":"https://api.github.com/repos/ilevkivskyi/mypy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ilevkivskyi/mypy/labels{/name}","releases_url":"https://api.github.com/repos/ilevkivskyi/mypy/releases{/id}","deployments_url":"https://api.github.com/repos/ilevkivskyi/mypy/deployments","created_at":"2016-04-04T19:45:28Z","updated_at":"2018-06-09T17:35:02Z","pushed_at":"2018-09-23T23:43:17Z","git_url":"git://github.com/ilevkivskyi/mypy.git","ssh_url":"git@github.com:ilevkivskyi/mypy.git","clone_url":"https://github.com/ilevkivskyi/mypy.git","svn_url":"https://github.com/ilevkivskyi/mypy","homepage":"http://www.mypy-lang.org/","size":29435,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"python:master","ref":"master","sha":"5afea77bbb343986309b8b5584825e960553de9e","user":{"login":"python","id":1525981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjU5ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/1525981?v=4","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"repo":{"id":7053637,"node_id":"MDEwOlJlcG9zaXRvcnk3MDUzNjM3","name":"mypy","full_name":"python/mypy","private":false,"owner":{"login":"python","id":1525981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjU5ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/1525981?v=4","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/python/mypy","description":"Optional static typing for Python 2 and 3 (PEP 484)","fork":false,"url":"https://api.github.com/repos/python/mypy","forks_url":"https://api.github.com/repos/python/mypy/forks","keys_url":"https://api.github.com/repos/python/mypy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python/mypy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python/mypy/teams","hooks_url":"https://api.github.com/repos/python/mypy/hooks","issue_events_url":"https://api.github.com/repos/python/mypy/issues/events{/number}","events_url":"https://api.github.com/repos/python/mypy/events","assignees_url":"https://api.github.com/repos/python/mypy/assignees{/user}","branches_url":"https://api.github.com/repos/python/mypy/branches{/branch}","tags_url":"https://api.github.com/repos/python/mypy/tags","blobs_url":"https://api.github.com/repos/python/mypy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python/mypy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python/mypy/git/refs{/sha}","trees_url":"https://api.github.com/repos/python/mypy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python/mypy/statuses/{sha}","languages_url":"https://api.github.com/repos/python/mypy/languages","stargazers_url":"https://api.github.com/repos/python/mypy/stargazers","contributors_url":"https://api.github.com/repos/python/mypy/contributors","subscribers_url":"https://api.github.com/repos/python/mypy/subscribers","subscription_url":"https://api.github.com/repos/python/mypy/subscription","commits_url":"https://api.github.com/repos/python/mypy/commits{/sha}","git_commits_url":"https://api.github.com/repos/python/mypy/git/commits{/sha}","comments_url":"https://api.github.com/repos/python/mypy/comments{/number}","issue_comment_url":"https://api.github.com/repos/python/mypy/issues/comments{/number}","contents_url":"https://api.github.com/repos/python/mypy/contents/{+path}","compare_url":"https://api.github.com/repos/python/mypy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python/mypy/merges","archive_url":"https://api.github.com/repos/python/mypy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python/mypy/downloads","issues_url":"https://api.github.com/repos/python/mypy/issues{/number}","pulls_url":"https://api.github.com/repos/python/mypy/pulls{/number}","milestones_url":"https://api.github.com/repos/python/mypy/milestones{/number}","notifications_url":"https://api.github.com/repos/python/mypy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python/mypy/labels{/name}","releases_url":"https://api.github.com/repos/python/mypy/releases{/id}","deployments_url":"https://api.github.com/repos/python/mypy/deployments","created_at":"2012-12-07T13:30:23Z","updated_at":"2018-09-24T13:26:42Z","pushed_at":"2018-09-23T23:57:39Z","git_url":"git://github.com/python/mypy.git","ssh_url":"git@github.com:python/mypy.git","clone_url":"https://github.com/python/mypy.git","svn_url":"https://github.com/python/mypy","homepage":"http://www.mypy-lang.org/","size":28456,"stargazers_count":4601,"watchers_count":4601,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":627,"mirror_url":null,"archived":false,"open_issues_count":882,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":627,"open_issues":882,"watchers":4601,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/python/mypy/pulls/5662"},"html":{"href":"https://github.com/python/mypy/pull/5662"},"issue":{"href":"https://api.github.com/repos/python/mypy/issues/5662"},"comments":{"href":"https://api.github.com/repos/python/mypy/issues/5662/comments"},"review_comments":{"href":"https://api.github.com/repos/python/mypy/pulls/5662/comments"},"review_comment":{"href":"https://api.github.com/repos/python/mypy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/python/mypy/pulls/5662/commits"},"statuses":{"href":"https://api.github.com/repos/python/mypy/statuses/291281cdde724e6d829aebaf363dbd4789cfb2b7"}},"author_association":"COLLABORATOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":5,"maintainer_can_modify":false,"commits":1,"additions":51,"deletions":2,"changed_files":3}}
{"actor":{"display_login":"ilevkivskyi"}}