{"action":"created","issue":{"url":"https://api.github.com/repos/tgstation/tgstation/issues/39826","repository_url":"https://api.github.com/repos/tgstation/tgstation","labels_url":"https://api.github.com/repos/tgstation/tgstation/issues/39826/labels{/name}","comments_url":"https://api.github.com/repos/tgstation/tgstation/issues/39826/comments","events_url":"https://api.github.com/repos/tgstation/tgstation/issues/39826/events","html_url":"https://github.com/tgstation/tgstation/pull/39826","id":352355758,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5Njg3MzQ2","number":39826,"title":"Slash SSatmos init time by 93%","user":{"login":"SpaceManiac","id":222630,"node_id":"MDQ6VXNlcjIyMjYzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/222630?v=4","gravatar_id":"","url":"https://api.github.com/users/SpaceManiac","html_url":"https://github.com/SpaceManiac","followers_url":"https://api.github.com/users/SpaceManiac/followers","following_url":"https://api.github.com/users/SpaceManiac/following{/other_user}","gists_url":"https://api.github.com/users/SpaceManiac/gists{/gist_id}","starred_url":"https://api.github.com/users/SpaceManiac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpaceManiac/subscriptions","organizations_url":"https://api.github.com/users/SpaceManiac/orgs","repos_url":"https://api.github.com/users/SpaceManiac/repos","events_url":"https://api.github.com/users/SpaceManiac/events{/privacy}","received_events_url":"https://api.github.com/users/SpaceManiac/received_events","type":"User","site_admin":false},"labels":[{"id":575115976,"node_id":"MDU6TGFiZWw1NzUxMTU5NzY=","url":"https://api.github.com/repos/tgstation/tgstation/labels/Atmospherics","name":"Atmospherics","color":"9300ff","default":false},{"id":627951053,"node_id":"MDU6TGFiZWw2Mjc5NTEwNTM=","url":"https://api.github.com/repos/tgstation/tgstation/labels/Code%20Improvement","name":"Code Improvement","color":"551A8B","default":false},{"id":31457173,"node_id":"MDU6TGFiZWwzMTQ1NzE3Mw==","url":"https://api.github.com/repos/tgstation/tgstation/labels/Performance","name":"Performance","color":"0b02e1","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-08-21T01:49:57Z","updated_at":"2018-08-21T02:50:57Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/tgstation/tgstation/pulls/39826","html_url":"https://github.com/tgstation/tgstation/pull/39826","diff_url":"https://github.com/tgstation/tgstation/pull/39826.diff","patch_url":"https://github.com/tgstation/tgstation/pull/39826.patch"},"body":":cl:\r\ncode: Atmospherics now initializes 93% faster.\r\n/:cl:\r\n\r\nOn BoxStation with default configs, takes SSatmos init from 46.3 seconds to 3.5 seconds.\r\n\r\nAccording to profiling, and confirmed in a test project, `setup_allturfs` spends almost all of its time on the `active_turfs -= T` line, slowly and painfully removing every turf in the world from `active_turfs` one by one. Instead, let's just clear it outright.\r\n\r\nNo ill effects observed, but someone who knows atmos code better should double-check this.\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/tgstation/tgstation/issues/comments/414532697","html_url":"https://github.com/tgstation/tgstation/pull/39826#issuecomment-414532697","issue_url":"https://api.github.com/repos/tgstation/tgstation/issues/39826","id":414532697,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNDUzMjY5Nw==","user":{"login":"Cyberboss","id":8171642,"node_id":"MDQ6VXNlcjgxNzE2NDI=","avatar_url":"https://avatars3.githubusercontent.com/u/8171642?v=4","gravatar_id":"","url":"https://api.github.com/users/Cyberboss","html_url":"https://github.com/Cyberboss","followers_url":"https://api.github.com/users/Cyberboss/followers","following_url":"https://api.github.com/users/Cyberboss/following{/other_user}","gists_url":"https://api.github.com/users/Cyberboss/gists{/gist_id}","starred_url":"https://api.github.com/users/Cyberboss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cyberboss/subscriptions","organizations_url":"https://api.github.com/users/Cyberboss/orgs","repos_url":"https://api.github.com/users/Cyberboss/repos","events_url":"https://api.github.com/users/Cyberboss/events{/privacy}","received_events_url":"https://api.github.com/users/Cyberboss/received_events","type":"User","site_admin":false},"created_at":"2018-08-21T02:50:57Z","updated_at":"2018-08-21T02:50:57Z","author_association":"MEMBER","body":"I checked deep, this shouldn't cause any issues\n\nOn Mon, Aug 20, 2018, 10:43 PM Tad Hardesty <notifications@github.com>\nwrote:\n\n> turfs_to_init is every turf in the world; active_turfs -= turfs_to_init\n> is just as slow; and Initalize_Atmos() will add src back to active_turfs\n> if indeed there is a problem.\n>\n> —\n> You are receiving this because you commented.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/tgstation/tgstation/pull/39826#issuecomment-414531531>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AHyweloOuRDUI5bOunQ7JSbHs8tNAHh-ks5uS3PSgaJpZM4WE-HW>\n> .\n>\n"}}
{"actor":{"display_login":"Cyberboss"}}