{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/233562264","pull_request_review_id":175006663,"id":233562264,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzU2MjI2NA==","diff_hunk":"@@ -570,27 +595,49 @@ extension Availability {\n }\n \n @objc(SWTReplacementAvailable) class ReplacementAvailable {\n-    @objc(replacingMethodInReplacementClassWithFirst:second:) func methodReplacingInReplacementClass(first: Int, second: Int) -> Void {}\n-  \n+    @objc(replacingMethodInReplacementClassWithPrimitiveParametersWithFirst:second:)\n+    func methodReplacingInReplacementClassWithPrimitiveParameters(first: Int, second: Int) -> Void {}\n+    \n+    @objc(replacingMethodInReplacementClassWithSuperclassObjectParametersWithFirst:second:)\n+    func methodReplacingInReplacementClassWithClassObjectParameters(first: SubclassOfReplacementAvailable, second: SubclassOfReplacementAvailable) -> Void {}","path":"test/PrintAsObjC/availability.swift","position":208,"original_position":120,"commit_id":"38b673146fbc92b40077d579d12893cde956d50c","original_commit_id":"38c337717c210a23f5d80ad81daee297619f10e0","user":{"login":"jrose-apple","id":15097531,"node_id":"MDQ6VXNlcjE1MDk3NTMx","avatar_url":"https://avatars2.githubusercontent.com/u/15097531?v=4","gravatar_id":"","url":"https://api.github.com/users/jrose-apple","html_url":"https://github.com/jrose-apple","followers_url":"https://api.github.com/users/jrose-apple/followers","following_url":"https://api.github.com/users/jrose-apple/following{/other_user}","gists_url":"https://api.github.com/users/jrose-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/jrose-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrose-apple/subscriptions","organizations_url":"https://api.github.com/users/jrose-apple/orgs","repos_url":"https://api.github.com/users/jrose-apple/repos","events_url":"https://api.github.com/users/jrose-apple/events{/privacy}","received_events_url":"https://api.github.com/users/jrose-apple/received_events","type":"User","site_admin":false},"body":"See, it's good to have the test case: this is backwards! You can rename from a method that takes \"Subclass\" to a method that takes \"Base\", but not the other way around (because some existing calls might break).\r\n\r\nAlternately, maybe we shouldn't be matching types at all, since sometimes people *do* do incompatible renames. What do you think?","created_at":"2018-11-14T18:18:01Z","updated_at":"2018-11-14T18:18:01Z","html_url":"https://github.com/apple/swift/pull/19645#discussion_r233562264","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/19645","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/233562264"},"html":{"href":"https://github.com/apple/swift/pull/19645#discussion_r233562264"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/19645"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/19645","id":219469857,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NDY5ODU3","html_url":"https://github.com/apple/swift/pull/19645","diff_url":"https://github.com/apple/swift/pull/19645.diff","patch_url":"https://github.com/apple/swift/pull/19645.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/19645","number":19645,"state":"open","locked":false,"title":"Improve the behavior of the custom @objc name in the available attribute when generates ObjC headers","user":{"login":"pitiphong-p","id":426153,"node_id":"MDQ6VXNlcjQyNjE1Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/426153?v=4","gravatar_id":"","url":"https://api.github.com/users/pitiphong-p","html_url":"https://github.com/pitiphong-p","followers_url":"https://api.github.com/users/pitiphong-p/followers","following_url":"https://api.github.com/users/pitiphong-p/following{/other_user}","gists_url":"https://api.github.com/users/pitiphong-p/gists{/gist_id}","starred_url":"https://api.github.com/users/pitiphong-p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pitiphong-p/subscriptions","organizations_url":"https://api.github.com/users/pitiphong-p/orgs","repos_url":"https://api.github.com/users/pitiphong-p/repos","events_url":"https://api.github.com/users/pitiphong-p/events{/privacy}","received_events_url":"https://api.github.com/users/pitiphong-p/received_events","type":"User","site_admin":false},"body":"<!-- What's in this pull request? -->\r\nThis PR is an improvement of the #18081. It adds a few improvements for the custom `@objc` name in the available attribute when generates ObjC headers\r\n\r\nHere's a list of the improvements\r\n1. The compiler will follow the base type when the rename attribute references to the declaration in other Type\r\n2. The compiler will try to look at the type of the method parameter when the rename attribute references to an overloading method\r\n\r\n<!-- If this pull request resolves any bugs in the Swift bug tracker, provide a link: -->\r\n\r\n<!--\r\nBefore merging this pull request, you must run the Swift continuous integration tests.\r\nFor information about triggering CI builds via @swift-ci, see:\r\nhttps://github.com/apple/swift/blob/master/docs/ContinuousIntegration.md#swift-ci\r\n\r\nThank you for your contribution to Swift!\r\n-->","created_at":"2018-10-01T18:22:45Z","updated_at":"2018-11-14T18:18:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2045803945807dc843a0fd19db95d0c0e09ffe2b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/19645/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/19645/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/19645/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/38b673146fbc92b40077d579d12893cde956d50c","head":{"label":"pitiphong-p:objc-rename-attribute-type-following","ref":"objc-rename-attribute-type-following","sha":"38b673146fbc92b40077d579d12893cde956d50c","user":{"login":"pitiphong-p","id":426153,"node_id":"MDQ6VXNlcjQyNjE1Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/426153?v=4","gravatar_id":"","url":"https://api.github.com/users/pitiphong-p","html_url":"https://github.com/pitiphong-p","followers_url":"https://api.github.com/users/pitiphong-p/followers","following_url":"https://api.github.com/users/pitiphong-p/following{/other_user}","gists_url":"https://api.github.com/users/pitiphong-p/gists{/gist_id}","starred_url":"https://api.github.com/users/pitiphong-p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pitiphong-p/subscriptions","organizations_url":"https://api.github.com/users/pitiphong-p/orgs","repos_url":"https://api.github.com/users/pitiphong-p/repos","events_url":"https://api.github.com/users/pitiphong-p/events{/privacy}","received_events_url":"https://api.github.com/users/pitiphong-p/received_events","type":"User","site_admin":false},"repo":{"id":54909620,"node_id":"MDEwOlJlcG9zaXRvcnk1NDkwOTYyMA==","name":"swift","full_name":"pitiphong-p/swift","private":false,"owner":{"login":"pitiphong-p","id":426153,"node_id":"MDQ6VXNlcjQyNjE1Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/426153?v=4","gravatar_id":"","url":"https://api.github.com/users/pitiphong-p","html_url":"https://github.com/pitiphong-p","followers_url":"https://api.github.com/users/pitiphong-p/followers","following_url":"https://api.github.com/users/pitiphong-p/following{/other_user}","gists_url":"https://api.github.com/users/pitiphong-p/gists{/gist_id}","starred_url":"https://api.github.com/users/pitiphong-p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pitiphong-p/subscriptions","organizations_url":"https://api.github.com/users/pitiphong-p/orgs","repos_url":"https://api.github.com/users/pitiphong-p/repos","events_url":"https://api.github.com/users/pitiphong-p/events{/privacy}","received_events_url":"https://api.github.com/users/pitiphong-p/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pitiphong-p/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/pitiphong-p/swift","forks_url":"https://api.github.com/repos/pitiphong-p/swift/forks","keys_url":"https://api.github.com/repos/pitiphong-p/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pitiphong-p/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pitiphong-p/swift/teams","hooks_url":"https://api.github.com/repos/pitiphong-p/swift/hooks","issue_events_url":"https://api.github.com/repos/pitiphong-p/swift/issues/events{/number}","events_url":"https://api.github.com/repos/pitiphong-p/swift/events","assignees_url":"https://api.github.com/repos/pitiphong-p/swift/assignees{/user}","branches_url":"https://api.github.com/repos/pitiphong-p/swift/branches{/branch}","tags_url":"https://api.github.com/repos/pitiphong-p/swift/tags","blobs_url":"https://api.github.com/repos/pitiphong-p/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pitiphong-p/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pitiphong-p/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/pitiphong-p/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pitiphong-p/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/pitiphong-p/swift/languages","stargazers_url":"https://api.github.com/repos/pitiphong-p/swift/stargazers","contributors_url":"https://api.github.com/repos/pitiphong-p/swift/contributors","subscribers_url":"https://api.github.com/repos/pitiphong-p/swift/subscribers","subscription_url":"https://api.github.com/repos/pitiphong-p/swift/subscription","commits_url":"https://api.github.com/repos/pitiphong-p/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/pitiphong-p/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/pitiphong-p/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/pitiphong-p/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/pitiphong-p/swift/contents/{+path}","compare_url":"https://api.github.com/repos/pitiphong-p/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pitiphong-p/swift/merges","archive_url":"https://api.github.com/repos/pitiphong-p/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pitiphong-p/swift/downloads","issues_url":"https://api.github.com/repos/pitiphong-p/swift/issues{/number}","pulls_url":"https://api.github.com/repos/pitiphong-p/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/pitiphong-p/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/pitiphong-p/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pitiphong-p/swift/labels{/name}","releases_url":"https://api.github.com/repos/pitiphong-p/swift/releases{/id}","deployments_url":"https://api.github.com/repos/pitiphong-p/swift/deployments","created_at":"2016-03-28T17:21:55Z","updated_at":"2018-07-16T09:41:28Z","pushed_at":"2018-11-14T12:33:46Z","git_url":"git://github.com/pitiphong-p/swift.git","ssh_url":"git@github.com:pitiphong-p/swift.git","clone_url":"https://github.com/pitiphong-p/swift.git","svn_url":"https://github.com/pitiphong-p/swift","homepage":"https://swift.org/","size":315527,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"7b03ea54ab9d71860aee36835eee5dde3cf3d274","user":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"node_id":"MDEwOlJlcG9zaXRvcnk0NDgzODk0OQ==","name":"swift","full_name":"apple/swift","private":false,"owner":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2018-11-14T18:11:32Z","pushed_at":"2018-11-14T18:10:02Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org","size":364455,"stargazers_count":45754,"watchers_count":45754,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7254,"mirror_url":null,"archived":false,"open_issues_count":429,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7254,"open_issues":429,"watchers":45754,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/19645"},"html":{"href":"https://github.com/apple/swift/pull/19645"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/19645"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/19645/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/19645/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/19645/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/38b673146fbc92b40077d579d12893cde956d50c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jrose-apple"}}