{"action":"closed","issue":{"url":"https://api.github.com/repos/kubevirt/containerized-data-importer/issues/131","repository_url":"https://api.github.com/repos/kubevirt/containerized-data-importer","labels_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/issues/131/labels{/name}","comments_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/issues/131/comments","events_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/issues/131/events","html_url":"https://github.com/kubevirt/containerized-data-importer/issues/131","id":320005669,"node_id":"MDU6SXNzdWUzMjAwMDU2Njk=","number":131,"title":"Improve controller unit tests","user":{"login":"jeffvance","id":3076896,"node_id":"MDQ6VXNlcjMwNzY4OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/3076896?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffvance","html_url":"https://github.com/jeffvance","followers_url":"https://api.github.com/users/jeffvance/followers","following_url":"https://api.github.com/users/jeffvance/following{/other_user}","gists_url":"https://api.github.com/users/jeffvance/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffvance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffvance/subscriptions","organizations_url":"https://api.github.com/users/jeffvance/orgs","repos_url":"https://api.github.com/users/jeffvance/repos","events_url":"https://api.github.com/users/jeffvance/events{/privacy}","received_events_url":"https://api.github.com/users/jeffvance/received_events","type":"User","site_admin":false},"labels":[{"id":894025552,"node_id":"MDU6TGFiZWw4OTQwMjU1NTI=","url":"https://api.github.com/repos/kubevirt/containerized-data-importer/labels/P2","name":"P2","color":"a4f9b5","default":false},{"id":921829496,"node_id":"MDU6TGFiZWw5MjE4Mjk0OTY=","url":"https://api.github.com/repos/kubevirt/containerized-data-importer/labels/testing","name":"testing","color":"9ff4b0","default":false}],"state":"closed","locked":false,"assignee":{"login":"jeffvance","id":3076896,"node_id":"MDQ6VXNlcjMwNzY4OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/3076896?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffvance","html_url":"https://github.com/jeffvance","followers_url":"https://api.github.com/users/jeffvance/followers","following_url":"https://api.github.com/users/jeffvance/following{/other_user}","gists_url":"https://api.github.com/users/jeffvance/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffvance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffvance/subscriptions","organizations_url":"https://api.github.com/users/jeffvance/orgs","repos_url":"https://api.github.com/users/jeffvance/repos","events_url":"https://api.github.com/users/jeffvance/events{/privacy}","received_events_url":"https://api.github.com/users/jeffvance/received_events","type":"User","site_admin":false},"assignees":[{"login":"jeffvance","id":3076896,"node_id":"MDQ6VXNlcjMwNzY4OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/3076896?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffvance","html_url":"https://github.com/jeffvance","followers_url":"https://api.github.com/users/jeffvance/followers","following_url":"https://api.github.com/users/jeffvance/following{/other_user}","gists_url":"https://api.github.com/users/jeffvance/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffvance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffvance/subscriptions","organizations_url":"https://api.github.com/users/jeffvance/orgs","repos_url":"https://api.github.com/users/jeffvance/repos","events_url":"https://api.github.com/users/jeffvance/events{/privacy}","received_events_url":"https://api.github.com/users/jeffvance/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2018-05-03T17:08:50Z","updated_at":"2018-08-01T01:58:34Z","closed_at":"2018-08-01T01:58:34Z","author_association":"COLLABORATOR","body":"The current controller unit tests are more like functional tests in that they call higher level functions (`NewController`, `ProcessNextItem`) rather than some of lower level funcs (which may need to be exported?).\r\n1.  We should _consider_ moving the current unit tests to _/test/_ so they are treated as functional tests and create real controller unit tests.\r\n2.  We probably should remove the tests using an empty namespace since this is not a supported condition."}}
{"actor":{"display_login":"jeffvance"}}