{"action":"created","comment":{"url":"https://api.github.com/repos/kiali/kiali-ui/pulls/comments/193655263","pull_request_review_id":126668129,"id":193655263,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzY1NTI2Mw==","diff_hunk":"@@ -1,66 +1,97 @@\n import * as React from 'react';\n-import { Col, Row } from 'patternfly-react';\n-import LocalTime from '../../../components/Time/LocalTime';\n+import { Col, Row, OverlayTrigger, Tooltip } from 'patternfly-react';\n import Badge from '../../../components/Badge/Badge';\n import { Pod } from '../../../types/ServiceInfo';\n import { PfColors } from '../../../components/Pf/PfColors';\n+import { PodsGroup, groupPods } from './ServiceInfoPodsGrouping';\n \n interface Props {\n   pods?: Pod[];\n }\n \n class ServiceInfoPods extends React.Component<Props> {\n+  groups: PodsGroup[];\n+\n   constructor(props: Props) {\n     super(props);\n+    if (props.pods) {\n+      this.groups = groupPods(props.pods);\n+    } else {\n+      this.groups = [];\n+    }\n   }\n \n   render() {\n     return (\n       <div className=\"card-pf\">\n         <Row className=\"row-cards-pf\">\n           <Col xs={12} sm={12} md={12} lg={12}>\n-            {(this.props.pods || []).map((pod, u) => (\n+            {(this.groups || []).map((group, u) => (\n               <div className=\"card-pf-body\" key={'pods_' + u}>\n-                <h3>{pod.name}</h3>\n+                <h3>\n+                  {group.numberOfPods > 1 ? (\n+                    <OverlayTrigger\n+                      // prettier-ignore\n+                      overlay={<Tooltip id={'pod_names_' + u} title=\"Pod Names\">{group.names.join(', ')}</Tooltip>}\n+                      placement=\"top\"\n+                      trigger={['hover', 'focus']}\n+                    >\n+                      <span>{group.commonPrefix + '... (' + group.numberOfPods + ' replicas)'}</span>\n+                    </OverlayTrigger>\n+                  ) : (\n+                    group.commonPrefix","path":"src/pages/ServiceDetails/ServiceInfo/ServiceInfoPods.tsx","position":46,"original_position":46,"commit_id":"4b93ec98a8daf226d7820cae50e9e7db88d435ac","original_commit_id":"4b93ec98a8daf226d7820cae50e9e7db88d435ac","user":{"login":"lucasponce","id":1662329,"node_id":"MDQ6VXNlcjE2NjIzMjk=","avatar_url":"https://avatars0.githubusercontent.com/u/1662329?v=4","gravatar_id":"","url":"https://api.github.com/users/lucasponce","html_url":"https://github.com/lucasponce","followers_url":"https://api.github.com/users/lucasponce/followers","following_url":"https://api.github.com/users/lucasponce/following{/other_user}","gists_url":"https://api.github.com/users/lucasponce/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasponce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasponce/subscriptions","organizations_url":"https://api.github.com/users/lucasponce/orgs","repos_url":"https://api.github.com/users/lucasponce/repos","events_url":"https://api.github.com/users/lucasponce/events{/privacy}","received_events_url":"https://api.github.com/users/lucasponce/received_events","type":"User","site_admin":false},"body":"I wonder if for UX perspective, it should also be added a \"(1 replica)\" msg in the single result.\r\nI don't know, users could think that instead of a pod, it's something like a group with no pods.\r\nI see it's redundant but I missed the \"(1 replica)\" here just to see the same format.","created_at":"2018-06-07T07:52:52Z","updated_at":"2018-06-07T07:52:52Z","html_url":"https://github.com/kiali/kiali-ui/pull/396#discussion_r193655263","pull_request_url":"https://api.github.com/repos/kiali/kiali-ui/pulls/396","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kiali/kiali-ui/pulls/comments/193655263"},"html":{"href":"https://github.com/kiali/kiali-ui/pull/396#discussion_r193655263"},"pull_request":{"href":"https://api.github.com/repos/kiali/kiali-ui/pulls/396"}}},"pull_request":{"url":"https://api.github.com/repos/kiali/kiali-ui/pulls/396","id":192076462,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMDc2NDYy","html_url":"https://github.com/kiali/kiali-ui/pull/396","diff_url":"https://github.com/kiali/kiali-ui/pull/396.diff","patch_url":"https://github.com/kiali/kiali-ui/pull/396.patch","issue_url":"https://api.github.com/repos/kiali/kiali-ui/issues/396","number":396,"state":"open","locked":false,"title":"KIALI-866 Group pods of same origin","user":{"login":"jotak","id":2153442,"node_id":"MDQ6VXNlcjIxNTM0NDI=","avatar_url":"https://avatars1.githubusercontent.com/u/2153442?v=4","gravatar_id":"","url":"https://api.github.com/users/jotak","html_url":"https://github.com/jotak","followers_url":"https://api.github.com/users/jotak/followers","following_url":"https://api.github.com/users/jotak/following{/other_user}","gists_url":"https://api.github.com/users/jotak/gists{/gist_id}","starred_url":"https://api.github.com/users/jotak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jotak/subscriptions","organizations_url":"https://api.github.com/users/jotak/orgs","repos_url":"https://api.github.com/users/jotak/repos","events_url":"https://api.github.com/users/jotak/events{/privacy}","received_events_url":"https://api.github.com/users/jotak/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-01T15:58:57Z","updated_at":"2018-06-07T07:52:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e2ea1eacfce7ba99f2dff330d1887ac3e22de68","assignee":null,"assignees":[],"requested_reviewers":[{"login":"xeviknal","id":613814,"node_id":"MDQ6VXNlcjYxMzgxNA==","avatar_url":"https://avatars2.githubusercontent.com/u/613814?v=4","gravatar_id":"","url":"https://api.github.com/users/xeviknal","html_url":"https://github.com/xeviknal","followers_url":"https://api.github.com/users/xeviknal/followers","following_url":"https://api.github.com/users/xeviknal/following{/other_user}","gists_url":"https://api.github.com/users/xeviknal/gists{/gist_id}","starred_url":"https://api.github.com/users/xeviknal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xeviknal/subscriptions","organizations_url":"https://api.github.com/users/xeviknal/orgs","repos_url":"https://api.github.com/users/xeviknal/repos","events_url":"https://api.github.com/users/xeviknal/events{/privacy}","received_events_url":"https://api.github.com/users/xeviknal/received_events","type":"User","site_admin":false},{"login":"aljesusg","id":3019213,"node_id":"MDQ6VXNlcjMwMTkyMTM=","avatar_url":"https://avatars2.githubusercontent.com/u/3019213?v=4","gravatar_id":"","url":"https://api.github.com/users/aljesusg","html_url":"https://github.com/aljesusg","followers_url":"https://api.github.com/users/aljesusg/followers","following_url":"https://api.github.com/users/aljesusg/following{/other_user}","gists_url":"https://api.github.com/users/aljesusg/gists{/gist_id}","starred_url":"https://api.github.com/users/aljesusg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aljesusg/subscriptions","organizations_url":"https://api.github.com/users/aljesusg/orgs","repos_url":"https://api.github.com/users/aljesusg/repos","events_url":"https://api.github.com/users/aljesusg/events{/privacy}","received_events_url":"https://api.github.com/users/aljesusg/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kiali/kiali-ui/pulls/396/commits","review_comments_url":"https://api.github.com/repos/kiali/kiali-ui/pulls/396/comments","review_comment_url":"https://api.github.com/repos/kiali/kiali-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kiali/kiali-ui/issues/396/comments","statuses_url":"https://api.github.com/repos/kiali/kiali-ui/statuses/4b93ec98a8daf226d7820cae50e9e7db88d435ac","head":{"label":"jotak:kiali-866","ref":"kiali-866","sha":"4b93ec98a8daf226d7820cae50e9e7db88d435ac","user":{"login":"jotak","id":2153442,"node_id":"MDQ6VXNlcjIxNTM0NDI=","avatar_url":"https://avatars1.githubusercontent.com/u/2153442?v=4","gravatar_id":"","url":"https://api.github.com/users/jotak","html_url":"https://github.com/jotak","followers_url":"https://api.github.com/users/jotak/followers","following_url":"https://api.github.com/users/jotak/following{/other_user}","gists_url":"https://api.github.com/users/jotak/gists{/gist_id}","starred_url":"https://api.github.com/users/jotak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jotak/subscriptions","organizations_url":"https://api.github.com/users/jotak/orgs","repos_url":"https://api.github.com/users/jotak/repos","events_url":"https://api.github.com/users/jotak/events{/privacy}","received_events_url":"https://api.github.com/users/jotak/received_events","type":"User","site_admin":false},"repo":{"id":120734238,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA3MzQyMzg=","name":"swsui","full_name":"jotak/swsui","owner":{"login":"jotak","id":2153442,"node_id":"MDQ6VXNlcjIxNTM0NDI=","avatar_url":"https://avatars1.githubusercontent.com/u/2153442?v=4","gravatar_id":"","url":"https://api.github.com/users/jotak","html_url":"https://github.com/jotak","followers_url":"https://api.github.com/users/jotak/followers","following_url":"https://api.github.com/users/jotak/following{/other_user}","gists_url":"https://api.github.com/users/jotak/gists{/gist_id}","starred_url":"https://api.github.com/users/jotak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jotak/subscriptions","organizations_url":"https://api.github.com/users/jotak/orgs","repos_url":"https://api.github.com/users/jotak/repos","events_url":"https://api.github.com/users/jotak/events{/privacy}","received_events_url":"https://api.github.com/users/jotak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jotak/swsui","description":null,"fork":true,"url":"https://api.github.com/repos/jotak/swsui","forks_url":"https://api.github.com/repos/jotak/swsui/forks","keys_url":"https://api.github.com/repos/jotak/swsui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jotak/swsui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jotak/swsui/teams","hooks_url":"https://api.github.com/repos/jotak/swsui/hooks","issue_events_url":"https://api.github.com/repos/jotak/swsui/issues/events{/number}","events_url":"https://api.github.com/repos/jotak/swsui/events","assignees_url":"https://api.github.com/repos/jotak/swsui/assignees{/user}","branches_url":"https://api.github.com/repos/jotak/swsui/branches{/branch}","tags_url":"https://api.github.com/repos/jotak/swsui/tags","blobs_url":"https://api.github.com/repos/jotak/swsui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jotak/swsui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jotak/swsui/git/refs{/sha}","trees_url":"https://api.github.com/repos/jotak/swsui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jotak/swsui/statuses/{sha}","languages_url":"https://api.github.com/repos/jotak/swsui/languages","stargazers_url":"https://api.github.com/repos/jotak/swsui/stargazers","contributors_url":"https://api.github.com/repos/jotak/swsui/contributors","subscribers_url":"https://api.github.com/repos/jotak/swsui/subscribers","subscription_url":"https://api.github.com/repos/jotak/swsui/subscription","commits_url":"https://api.github.com/repos/jotak/swsui/commits{/sha}","git_commits_url":"https://api.github.com/repos/jotak/swsui/git/commits{/sha}","comments_url":"https://api.github.com/repos/jotak/swsui/comments{/number}","issue_comment_url":"https://api.github.com/repos/jotak/swsui/issues/comments{/number}","contents_url":"https://api.github.com/repos/jotak/swsui/contents/{+path}","compare_url":"https://api.github.com/repos/jotak/swsui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jotak/swsui/merges","archive_url":"https://api.github.com/repos/jotak/swsui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jotak/swsui/downloads","issues_url":"https://api.github.com/repos/jotak/swsui/issues{/number}","pulls_url":"https://api.github.com/repos/jotak/swsui/pulls{/number}","milestones_url":"https://api.github.com/repos/jotak/swsui/milestones{/number}","notifications_url":"https://api.github.com/repos/jotak/swsui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jotak/swsui/labels{/name}","releases_url":"https://api.github.com/repos/jotak/swsui/releases{/id}","deployments_url":"https://api.github.com/repos/jotak/swsui/deployments","created_at":"2018-02-08T08:39:31Z","updated_at":"2018-05-23T06:55:32Z","pushed_at":"2018-06-06T12:52:39Z","git_url":"git://github.com/jotak/swsui.git","ssh_url":"git@github.com:jotak/swsui.git","clone_url":"https://github.com/jotak/swsui.git","svn_url":"https://github.com/jotak/swsui","homepage":null,"size":2012,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kiali:master","ref":"master","sha":"3242211bde0a980ac6095182a27cfa45cb0e36c7","user":{"login":"kiali","id":36001875,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDAxODc1","avatar_url":"https://avatars2.githubusercontent.com/u/36001875?v=4","gravatar_id":"","url":"https://api.github.com/users/kiali","html_url":"https://github.com/kiali","followers_url":"https://api.github.com/users/kiali/followers","following_url":"https://api.github.com/users/kiali/following{/other_user}","gists_url":"https://api.github.com/users/kiali/gists{/gist_id}","starred_url":"https://api.github.com/users/kiali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiali/subscriptions","organizations_url":"https://api.github.com/users/kiali/orgs","repos_url":"https://api.github.com/users/kiali/repos","events_url":"https://api.github.com/users/kiali/events{/privacy}","received_events_url":"https://api.github.com/users/kiali/received_events","type":"Organization","site_admin":false},"repo":{"id":120308264,"node_id":"MDEwOlJlcG9zaXRvcnkxMjAzMDgyNjQ=","name":"kiali-ui","full_name":"kiali/kiali-ui","owner":{"login":"kiali","id":36001875,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDAxODc1","avatar_url":"https://avatars2.githubusercontent.com/u/36001875?v=4","gravatar_id":"","url":"https://api.github.com/users/kiali","html_url":"https://github.com/kiali","followers_url":"https://api.github.com/users/kiali/followers","following_url":"https://api.github.com/users/kiali/following{/other_user}","gists_url":"https://api.github.com/users/kiali/gists{/gist_id}","starred_url":"https://api.github.com/users/kiali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiali/subscriptions","organizations_url":"https://api.github.com/users/kiali/orgs","repos_url":"https://api.github.com/users/kiali/repos","events_url":"https://api.github.com/users/kiali/events{/privacy}","received_events_url":"https://api.github.com/users/kiali/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kiali/kiali-ui","description":"Frontend part of Kiali (use kiali/kial to report issues)","fork":false,"url":"https://api.github.com/repos/kiali/kiali-ui","forks_url":"https://api.github.com/repos/kiali/kiali-ui/forks","keys_url":"https://api.github.com/repos/kiali/kiali-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kiali/kiali-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kiali/kiali-ui/teams","hooks_url":"https://api.github.com/repos/kiali/kiali-ui/hooks","issue_events_url":"https://api.github.com/repos/kiali/kiali-ui/issues/events{/number}","events_url":"https://api.github.com/repos/kiali/kiali-ui/events","assignees_url":"https://api.github.com/repos/kiali/kiali-ui/assignees{/user}","branches_url":"https://api.github.com/repos/kiali/kiali-ui/branches{/branch}","tags_url":"https://api.github.com/repos/kiali/kiali-ui/tags","blobs_url":"https://api.github.com/repos/kiali/kiali-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kiali/kiali-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kiali/kiali-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/kiali/kiali-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kiali/kiali-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/kiali/kiali-ui/languages","stargazers_url":"https://api.github.com/repos/kiali/kiali-ui/stargazers","contributors_url":"https://api.github.com/repos/kiali/kiali-ui/contributors","subscribers_url":"https://api.github.com/repos/kiali/kiali-ui/subscribers","subscription_url":"https://api.github.com/repos/kiali/kiali-ui/subscription","commits_url":"https://api.github.com/repos/kiali/kiali-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/kiali/kiali-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/kiali/kiali-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/kiali/kiali-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/kiali/kiali-ui/contents/{+path}","compare_url":"https://api.github.com/repos/kiali/kiali-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kiali/kiali-ui/merges","archive_url":"https://api.github.com/repos/kiali/kiali-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kiali/kiali-ui/downloads","issues_url":"https://api.github.com/repos/kiali/kiali-ui/issues{/number}","pulls_url":"https://api.github.com/repos/kiali/kiali-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/kiali/kiali-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/kiali/kiali-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kiali/kiali-ui/labels{/name}","releases_url":"https://api.github.com/repos/kiali/kiali-ui/releases{/id}","deployments_url":"https://api.github.com/repos/kiali/kiali-ui/deployments","created_at":"2018-02-05T13:27:15Z","updated_at":"2018-06-07T02:20:51Z","pushed_at":"2018-06-07T02:20:48Z","git_url":"git://github.com/kiali/kiali-ui.git","ssh_url":"git@github.com:kiali/kiali-ui.git","clone_url":"https://github.com/kiali/kiali-ui.git","svn_url":"https://github.com/kiali/kiali-ui","homepage":"https://kiali.org/","size":2015,"stargazers_count":24,"watchers_count":24,"language":"TypeScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":17,"open_issues":13,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kiali/kiali-ui/pulls/396"},"html":{"href":"https://github.com/kiali/kiali-ui/pull/396"},"issue":{"href":"https://api.github.com/repos/kiali/kiali-ui/issues/396"},"comments":{"href":"https://api.github.com/repos/kiali/kiali-ui/issues/396/comments"},"review_comments":{"href":"https://api.github.com/repos/kiali/kiali-ui/pulls/396/comments"},"review_comment":{"href":"https://api.github.com/repos/kiali/kiali-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kiali/kiali-ui/pulls/396/commits"},"statuses":{"href":"https://api.github.com/repos/kiali/kiali-ui/statuses/4b93ec98a8daf226d7820cae50e9e7db88d435ac"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lucasponce"}}