{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc-java/pulls/comments/181473062","pull_request_review_id":112114200,"id":181473062,"diff_hunk":"@@ -17,14 +17,25 @@\n package io.grpc.netty;\n \n import io.grpc.Internal;\n+import io.grpc.internal.Channelz.TcpInfo;\n+import java.util.Map;\n \n /**\n  * An internal accessor. Do not use.\n  */\n @Internal\n public final class InternalNettySocketSupport {\n \n-  public interface InternalHelper extends NettySocketSupport.Helper { }\n+  public interface InternalHelper extends NettySocketSupport.Helper {\n+    @Override\n+    InternalNativeSocketOptions getNativeSocketOptions(io.netty.channel.Channel ch);\n+  }\n+\n+  public static class InternalNativeSocketOptions extends NettySocketSupport.NativeSocketOptions {","path":"netty/src/main/java/io/grpc/netty/InternalNettySocketSupport.java","position":19,"original_position":19,"commit_id":"388e036bfa3d30641ad9a3f125a95a9da9b2fe85","original_commit_id":"388e036bfa3d30641ad9a3f125a95a9da9b2fe85","user":{"login":"carl-mastrangelo","id":8943572,"avatar_url":"https://avatars0.githubusercontent.com/u/8943572?v=4","gravatar_id":"","url":"https://api.github.com/users/carl-mastrangelo","html_url":"https://github.com/carl-mastrangelo","followers_url":"https://api.github.com/users/carl-mastrangelo/followers","following_url":"https://api.github.com/users/carl-mastrangelo/following{/other_user}","gists_url":"https://api.github.com/users/carl-mastrangelo/gists{/gist_id}","starred_url":"https://api.github.com/users/carl-mastrangelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carl-mastrangelo/subscriptions","organizations_url":"https://api.github.com/users/carl-mastrangelo/orgs","repos_url":"https://api.github.com/users/carl-mastrangelo/repos","events_url":"https://api.github.com/users/carl-mastrangelo/events{/privacy}","received_events_url":"https://api.github.com/users/carl-mastrangelo/received_events","type":"User","site_admin":false},"body":"final","created_at":"2018-04-13T18:27:10Z","updated_at":"2018-04-13T18:27:33Z","html_url":"https://github.com/grpc/grpc-java/pull/4335#discussion_r181473062","pull_request_url":"https://api.github.com/repos/grpc/grpc-java/pulls/4335","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/comments/181473062"},"html":{"href":"https://github.com/grpc/grpc-java/pull/4335#discussion_r181473062"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/4335"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc-java/pulls/4335","id":181335086,"html_url":"https://github.com/grpc/grpc-java/pull/4335","diff_url":"https://github.com/grpc/grpc-java/pull/4335.diff","patch_url":"https://github.com/grpc/grpc-java/pull/4335.patch","issue_url":"https://api.github.com/repos/grpc/grpc-java/issues/4335","number":4335,"state":"open","locked":false,"title":"netty: fix visibility issues with InternalNettySocketSupport","user":{"login":"zpencer","id":2819812,"avatar_url":"https://avatars0.githubusercontent.com/u/2819812?v=4","gravatar_id":"","url":"https://api.github.com/users/zpencer","html_url":"https://github.com/zpencer","followers_url":"https://api.github.com/users/zpencer/followers","following_url":"https://api.github.com/users/zpencer/following{/other_user}","gists_url":"https://api.github.com/users/zpencer/gists{/gist_id}","starred_url":"https://api.github.com/users/zpencer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zpencer/subscriptions","organizations_url":"https://api.github.com/users/zpencer/orgs","repos_url":"https://api.github.com/users/zpencer/repos","events_url":"https://api.github.com/users/zpencer/events{/privacy}","received_events_url":"https://api.github.com/users/zpencer/received_events","type":"User","site_admin":false},"body":"Previous version is not actually extendable from other packages.","created_at":"2018-04-12T21:49:28Z","updated_at":"2018-04-13T18:27:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"530f1fa3ce87e701fd11d3baad86f24a363312ca","assignee":{"login":"carl-mastrangelo","id":8943572,"avatar_url":"https://avatars0.githubusercontent.com/u/8943572?v=4","gravatar_id":"","url":"https://api.github.com/users/carl-mastrangelo","html_url":"https://github.com/carl-mastrangelo","followers_url":"https://api.github.com/users/carl-mastrangelo/followers","following_url":"https://api.github.com/users/carl-mastrangelo/following{/other_user}","gists_url":"https://api.github.com/users/carl-mastrangelo/gists{/gist_id}","starred_url":"https://api.github.com/users/carl-mastrangelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carl-mastrangelo/subscriptions","organizations_url":"https://api.github.com/users/carl-mastrangelo/orgs","repos_url":"https://api.github.com/users/carl-mastrangelo/repos","events_url":"https://api.github.com/users/carl-mastrangelo/events{/privacy}","received_events_url":"https://api.github.com/users/carl-mastrangelo/received_events","type":"User","site_admin":false},"assignees":[{"login":"carl-mastrangelo","id":8943572,"avatar_url":"https://avatars0.githubusercontent.com/u/8943572?v=4","gravatar_id":"","url":"https://api.github.com/users/carl-mastrangelo","html_url":"https://github.com/carl-mastrangelo","followers_url":"https://api.github.com/users/carl-mastrangelo/followers","following_url":"https://api.github.com/users/carl-mastrangelo/following{/other_user}","gists_url":"https://api.github.com/users/carl-mastrangelo/gists{/gist_id}","starred_url":"https://api.github.com/users/carl-mastrangelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carl-mastrangelo/subscriptions","organizations_url":"https://api.github.com/users/carl-mastrangelo/orgs","repos_url":"https://api.github.com/users/carl-mastrangelo/repos","events_url":"https://api.github.com/users/carl-mastrangelo/events{/privacy}","received_events_url":"https://api.github.com/users/carl-mastrangelo/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc-java/pulls/4335/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc-java/pulls/4335/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc-java/issues/4335/comments","statuses_url":"https://api.github.com/repos/grpc/grpc-java/statuses/388e036bfa3d30641ad9a3f125a95a9da9b2fe85","head":{"label":"zpencer:netty-socksupp-accessor","ref":"netty-socksupp-accessor","sha":"388e036bfa3d30641ad9a3f125a95a9da9b2fe85","user":{"login":"zpencer","id":2819812,"avatar_url":"https://avatars0.githubusercontent.com/u/2819812?v=4","gravatar_id":"","url":"https://api.github.com/users/zpencer","html_url":"https://github.com/zpencer","followers_url":"https://api.github.com/users/zpencer/followers","following_url":"https://api.github.com/users/zpencer/following{/other_user}","gists_url":"https://api.github.com/users/zpencer/gists{/gist_id}","starred_url":"https://api.github.com/users/zpencer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zpencer/subscriptions","organizations_url":"https://api.github.com/users/zpencer/orgs","repos_url":"https://api.github.com/users/zpencer/repos","events_url":"https://api.github.com/users/zpencer/events{/privacy}","received_events_url":"https://api.github.com/users/zpencer/received_events","type":"User","site_admin":false},"repo":{"id":89497167,"name":"grpc-java","full_name":"zpencer/grpc-java","owner":{"login":"zpencer","id":2819812,"avatar_url":"https://avatars0.githubusercontent.com/u/2819812?v=4","gravatar_id":"","url":"https://api.github.com/users/zpencer","html_url":"https://github.com/zpencer","followers_url":"https://api.github.com/users/zpencer/followers","following_url":"https://api.github.com/users/zpencer/following{/other_user}","gists_url":"https://api.github.com/users/zpencer/gists{/gist_id}","starred_url":"https://api.github.com/users/zpencer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zpencer/subscriptions","organizations_url":"https://api.github.com/users/zpencer/orgs","repos_url":"https://api.github.com/users/zpencer/repos","events_url":"https://api.github.com/users/zpencer/events{/privacy}","received_events_url":"https://api.github.com/users/zpencer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zpencer/grpc-java","description":"The Java gRPC implementation. HTTP/2 based RPC","fork":true,"url":"https://api.github.com/repos/zpencer/grpc-java","forks_url":"https://api.github.com/repos/zpencer/grpc-java/forks","keys_url":"https://api.github.com/repos/zpencer/grpc-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zpencer/grpc-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zpencer/grpc-java/teams","hooks_url":"https://api.github.com/repos/zpencer/grpc-java/hooks","issue_events_url":"https://api.github.com/repos/zpencer/grpc-java/issues/events{/number}","events_url":"https://api.github.com/repos/zpencer/grpc-java/events","assignees_url":"https://api.github.com/repos/zpencer/grpc-java/assignees{/user}","branches_url":"https://api.github.com/repos/zpencer/grpc-java/branches{/branch}","tags_url":"https://api.github.com/repos/zpencer/grpc-java/tags","blobs_url":"https://api.github.com/repos/zpencer/grpc-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zpencer/grpc-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zpencer/grpc-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/zpencer/grpc-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zpencer/grpc-java/statuses/{sha}","languages_url":"https://api.github.com/repos/zpencer/grpc-java/languages","stargazers_url":"https://api.github.com/repos/zpencer/grpc-java/stargazers","contributors_url":"https://api.github.com/repos/zpencer/grpc-java/contributors","subscribers_url":"https://api.github.com/repos/zpencer/grpc-java/subscribers","subscription_url":"https://api.github.com/repos/zpencer/grpc-java/subscription","commits_url":"https://api.github.com/repos/zpencer/grpc-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/zpencer/grpc-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/zpencer/grpc-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/zpencer/grpc-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/zpencer/grpc-java/contents/{+path}","compare_url":"https://api.github.com/repos/zpencer/grpc-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zpencer/grpc-java/merges","archive_url":"https://api.github.com/repos/zpencer/grpc-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zpencer/grpc-java/downloads","issues_url":"https://api.github.com/repos/zpencer/grpc-java/issues{/number}","pulls_url":"https://api.github.com/repos/zpencer/grpc-java/pulls{/number}","milestones_url":"https://api.github.com/repos/zpencer/grpc-java/milestones{/number}","notifications_url":"https://api.github.com/repos/zpencer/grpc-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zpencer/grpc-java/labels{/name}","releases_url":"https://api.github.com/repos/zpencer/grpc-java/releases{/id}","deployments_url":"https://api.github.com/repos/zpencer/grpc-java/deployments","created_at":"2017-04-26T15:28:10Z","updated_at":"2017-04-26T15:28:13Z","pushed_at":"2018-04-13T16:21:39Z","git_url":"git://github.com/zpencer/grpc-java.git","ssh_url":"git@github.com:zpencer/grpc-java.git","clone_url":"https://github.com/zpencer/grpc-java.git","svn_url":"https://github.com/zpencer/grpc-java","homepage":"http://grpc.io","size":21221,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"6d7e19cbe5dfaaeb787cff9c15c0778213c939dc","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729926,"name":"grpc-java","full_name":"grpc/grpc-java","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc-java","description":"The Java gRPC implementation. HTTP/2 based RPC","fork":false,"url":"https://api.github.com/repos/grpc/grpc-java","forks_url":"https://api.github.com/repos/grpc/grpc-java/forks","keys_url":"https://api.github.com/repos/grpc/grpc-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc-java/teams","hooks_url":"https://api.github.com/repos/grpc/grpc-java/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc-java/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc-java/events","assignees_url":"https://api.github.com/repos/grpc/grpc-java/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc-java/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc-java/tags","blobs_url":"https://api.github.com/repos/grpc/grpc-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc-java/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc-java/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc-java/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc-java/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc-java/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc-java/subscription","commits_url":"https://api.github.com/repos/grpc/grpc-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc-java/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc-java/merges","archive_url":"https://api.github.com/repos/grpc/grpc-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc-java/downloads","issues_url":"https://api.github.com/repos/grpc/grpc-java/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc-java/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc-java/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc-java/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc-java/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc-java/deployments","created_at":"2014-12-08T19:00:00Z","updated_at":"2018-04-13T18:14:11Z","pushed_at":"2018-04-13T18:14:00Z","git_url":"git://github.com/grpc/grpc-java.git","ssh_url":"git@github.com:grpc/grpc-java.git","clone_url":"https://github.com/grpc/grpc-java.git","svn_url":"https://github.com/grpc/grpc-java","homepage":"https://grpc.io","size":23357,"stargazers_count":4092,"watchers_count":4092,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":1329,"mirror_url":null,"archived":false,"open_issues_count":348,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1329,"open_issues":348,"watchers":4092,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/4335"},"html":{"href":"https://github.com/grpc/grpc-java/pull/4335"},"issue":{"href":"https://api.github.com/repos/grpc/grpc-java/issues/4335"},"comments":{"href":"https://api.github.com/repos/grpc/grpc-java/issues/4335/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/4335/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/4335/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc-java/statuses/388e036bfa3d30641ad9a3f125a95a9da9b2fe85"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"carl-mastrangelo"}}