{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq-content/issues/390","repository_url":"https://api.github.com/repos/ManageIQ/manageiq-content","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-content/issues/390/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-content/issues/390/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq-content/issues/390/events","html_url":"https://github.com/ManageIQ/manageiq-content/pull/390","id":347132362,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1ODI4NjE3","number":390,"title":"Remove the `if` conditionals to improve test coverage","user":{"login":"bdunne","id":651659,"node_id":"MDQ6VXNlcjY1MTY1OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/651659?v=4","gravatar_id":"","url":"https://api.github.com/users/bdunne","html_url":"https://github.com/bdunne","followers_url":"https://api.github.com/users/bdunne/followers","following_url":"https://api.github.com/users/bdunne/following{/other_user}","gists_url":"https://api.github.com/users/bdunne/gists{/gist_id}","starred_url":"https://api.github.com/users/bdunne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdunne/subscriptions","organizations_url":"https://api.github.com/users/bdunne/orgs","repos_url":"https://api.github.com/users/bdunne/repos","events_url":"https://api.github.com/users/bdunne/events{/privacy}","received_events_url":"https://api.github.com/users/bdunne/received_events","type":"User","site_admin":false},"labels":[{"id":736076686,"node_id":"MDU6TGFiZWw3MzYwNzY2ODY=","url":"https://api.github.com/repos/ManageIQ/manageiq-content/labels/gaprindashvili/no","name":"gaprindashvili/no","color":"000000","default":false},{"id":557091895,"node_id":"MDU6TGFiZWw1NTcwOTE4OTU=","url":"https://api.github.com/repos/ManageIQ/manageiq-content/labels/test","name":"test","color":"bfe5bf","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-08-02T18:52:18Z","updated_at":"2018-08-03T16:54:44Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-content/pulls/390","html_url":"https://github.com/ManageIQ/manageiq-content/pull/390","diff_url":"https://github.com/ManageIQ/manageiq-content/pull/390.diff","patch_url":"https://github.com/ManageIQ/manageiq-content/pull/390.patch"},"body":"Prevent the module from running when required by hooking the class definition and stubbing the call to `.new` during require.  Doing this ensures that the `.new` calls a real class that already exists.\r\n\r\nUnfortunately, the class name is occasionally misspelled and this code path was previously not covered.  This adds test coverage for this path."},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-content/issues/comments/410313499","html_url":"https://github.com/ManageIQ/manageiq-content/pull/390#issuecomment-410313499","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-content/issues/390","id":410313499,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMDMxMzQ5OQ==","user":{"login":"bdunne","id":651659,"node_id":"MDQ6VXNlcjY1MTY1OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/651659?v=4","gravatar_id":"","url":"https://api.github.com/users/bdunne","html_url":"https://github.com/bdunne","followers_url":"https://api.github.com/users/bdunne/followers","following_url":"https://api.github.com/users/bdunne/following{/other_user}","gists_url":"https://api.github.com/users/bdunne/gists{/gist_id}","starred_url":"https://api.github.com/users/bdunne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdunne/subscriptions","organizations_url":"https://api.github.com/users/bdunne/orgs","repos_url":"https://api.github.com/users/bdunne/repos","events_url":"https://api.github.com/users/bdunne/events{/privacy}","received_events_url":"https://api.github.com/users/bdunne/received_events","type":"User","site_admin":false},"created_at":"2018-08-03T16:54:44Z","updated_at":"2018-08-03T16:54:44Z","author_association":"MEMBER","body":"Okay, updated the PR with the new approach to increasing test coverage.  Let me know what you think @mkanoor \r\nThere are a few classes outside of the \"ManageIQ::Automate\" namespace that are not covered by this change, but I think those should be addressed by changing the namespacing in a separate PR.\r\ncc @Fryguy "}}
{"actor":{"display_login":"bdunne"}}