{"action":"created","comment":{"url":"https://api.github.com/repos/CPLUOS/nano/pulls/comments/197789191","pull_request_review_id":131599167,"id":197789191,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Nzc4OTE5MQ==","diff_hunk":"@@ -25,10 +25,21 @@ string getType (const string& path){\n   size_t found = path.find(\"tt\");\n   return(path.substr(found));\n }\n-\n+long getFileSize(const string& filename) {","path":"analysis/bin/vtsAnalyser.cc","position":14,"original_position":14,"commit_id":"58881277623b0c7447aee3a5e2d0b9113e77cda0","original_commit_id":"58881277623b0c7447aee3a5e2d0b9113e77cda0","user":{"login":"watson-ij","id":29137092,"node_id":"MDQ6VXNlcjI5MTM3MDky","avatar_url":"https://avatars0.githubusercontent.com/u/29137092?v=4","gravatar_id":"","url":"https://api.github.com/users/watson-ij","html_url":"https://github.com/watson-ij","followers_url":"https://api.github.com/users/watson-ij/followers","following_url":"https://api.github.com/users/watson-ij/following{/other_user}","gists_url":"https://api.github.com/users/watson-ij/gists{/gist_id}","starred_url":"https://api.github.com/users/watson-ij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/watson-ij/subscriptions","organizations_url":"https://api.github.com/users/watson-ij/orgs","repos_url":"https://api.github.com/users/watson-ij/repos","events_url":"https://api.github.com/users/watson-ij/events{/privacy}","received_events_url":"https://api.github.com/users/watson-ij/received_events","type":"User","site_admin":false},"body":"Do we need this version? Can't you just filename.c_str() at the call site?","created_at":"2018-06-25T13:10:02Z","updated_at":"2018-06-25T13:10:09Z","html_url":"https://github.com/CPLUOS/nano/pull/96#discussion_r197789191","pull_request_url":"https://api.github.com/repos/CPLUOS/nano/pulls/96","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/CPLUOS/nano/pulls/comments/197789191"},"html":{"href":"https://github.com/CPLUOS/nano/pull/96#discussion_r197789191"},"pull_request":{"href":"https://api.github.com/repos/CPLUOS/nano/pulls/96"}}},"pull_request":{"url":"https://api.github.com/repos/CPLUOS/nano/pulls/96","id":197071401,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MDcxNDAx","html_url":"https://github.com/CPLUOS/nano/pull/96","diff_url":"https://github.com/CPLUOS/nano/pull/96.diff","patch_url":"https://github.com/CPLUOS/nano/pull/96.patch","issue_url":"https://api.github.com/repos/CPLUOS/nano/issues/96","number":96,"state":"open","locked":false,"title":"Add Test() in vtsAnalyser.cc and jetIndex for jetSelection() and rename name of vars","user":{"login":"jang00777","id":29889599,"node_id":"MDQ6VXNlcjI5ODg5NTk5","avatar_url":"https://avatars3.githubusercontent.com/u/29889599?v=4","gravatar_id":"","url":"https://api.github.com/users/jang00777","html_url":"https://github.com/jang00777","followers_url":"https://api.github.com/users/jang00777/followers","following_url":"https://api.github.com/users/jang00777/following{/other_user}","gists_url":"https://api.github.com/users/jang00777/gists{/gist_id}","starred_url":"https://api.github.com/users/jang00777/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jang00777/subscriptions","organizations_url":"https://api.github.com/users/jang00777/orgs","repos_url":"https://api.github.com/users/jang00777/repos","events_url":"https://api.github.com/users/jang00777/events{/privacy}","received_events_url":"https://api.github.com/users/jang00777/received_events","type":"User","site_admin":false},"body":"1. I added Test() in vtsAnalyser.cc (even though this isn't completed yet I did pr because the func save several vectors about hadTruth(had)_observable\r\n2. Now you can load jet index about jet which pass jetSelection() in topObjSelection using GetFirstMother()\r\n3. For avoiding confusion, variables in hadAnalyser.h and vtsAnalyser.h was renamed like the follow : \r\n    b_observable_had -> b_had_observable","created_at":"2018-06-25T10:41:15Z","updated_at":"2018-06-25T13:10:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0971c170aa3498c50f9101e47a499f6688301069","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CPLUOS/nano/pulls/96/commits","review_comments_url":"https://api.github.com/repos/CPLUOS/nano/pulls/96/comments","review_comment_url":"https://api.github.com/repos/CPLUOS/nano/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CPLUOS/nano/issues/96/comments","statuses_url":"https://api.github.com/repos/CPLUOS/nano/statuses/58881277623b0c7447aee3a5e2d0b9113e77cda0","head":{"label":"jang00777:master","ref":"master","sha":"58881277623b0c7447aee3a5e2d0b9113e77cda0","user":{"login":"jang00777","id":29889599,"node_id":"MDQ6VXNlcjI5ODg5NTk5","avatar_url":"https://avatars3.githubusercontent.com/u/29889599?v=4","gravatar_id":"","url":"https://api.github.com/users/jang00777","html_url":"https://github.com/jang00777","followers_url":"https://api.github.com/users/jang00777/followers","following_url":"https://api.github.com/users/jang00777/following{/other_user}","gists_url":"https://api.github.com/users/jang00777/gists{/gist_id}","starred_url":"https://api.github.com/users/jang00777/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jang00777/subscriptions","organizations_url":"https://api.github.com/users/jang00777/orgs","repos_url":"https://api.github.com/users/jang00777/repos","events_url":"https://api.github.com/users/jang00777/events{/privacy}","received_events_url":"https://api.github.com/users/jang00777/received_events","type":"User","site_admin":false},"repo":{"id":137023858,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcwMjM4NTg=","name":"nano","full_name":"jang00777/nano","owner":{"login":"jang00777","id":29889599,"node_id":"MDQ6VXNlcjI5ODg5NTk5","avatar_url":"https://avatars3.githubusercontent.com/u/29889599?v=4","gravatar_id":"","url":"https://api.github.com/users/jang00777","html_url":"https://github.com/jang00777","followers_url":"https://api.github.com/users/jang00777/followers","following_url":"https://api.github.com/users/jang00777/following{/other_user}","gists_url":"https://api.github.com/users/jang00777/gists{/gist_id}","starred_url":"https://api.github.com/users/jang00777/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jang00777/subscriptions","organizations_url":"https://api.github.com/users/jang00777/orgs","repos_url":"https://api.github.com/users/jang00777/repos","events_url":"https://api.github.com/users/jang00777/events{/privacy}","received_events_url":"https://api.github.com/users/jang00777/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jang00777/nano","description":"nanoAOD tools for production and analysis","fork":true,"url":"https://api.github.com/repos/jang00777/nano","forks_url":"https://api.github.com/repos/jang00777/nano/forks","keys_url":"https://api.github.com/repos/jang00777/nano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jang00777/nano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jang00777/nano/teams","hooks_url":"https://api.github.com/repos/jang00777/nano/hooks","issue_events_url":"https://api.github.com/repos/jang00777/nano/issues/events{/number}","events_url":"https://api.github.com/repos/jang00777/nano/events","assignees_url":"https://api.github.com/repos/jang00777/nano/assignees{/user}","branches_url":"https://api.github.com/repos/jang00777/nano/branches{/branch}","tags_url":"https://api.github.com/repos/jang00777/nano/tags","blobs_url":"https://api.github.com/repos/jang00777/nano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jang00777/nano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jang00777/nano/git/refs{/sha}","trees_url":"https://api.github.com/repos/jang00777/nano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jang00777/nano/statuses/{sha}","languages_url":"https://api.github.com/repos/jang00777/nano/languages","stargazers_url":"https://api.github.com/repos/jang00777/nano/stargazers","contributors_url":"https://api.github.com/repos/jang00777/nano/contributors","subscribers_url":"https://api.github.com/repos/jang00777/nano/subscribers","subscription_url":"https://api.github.com/repos/jang00777/nano/subscription","commits_url":"https://api.github.com/repos/jang00777/nano/commits{/sha}","git_commits_url":"https://api.github.com/repos/jang00777/nano/git/commits{/sha}","comments_url":"https://api.github.com/repos/jang00777/nano/comments{/number}","issue_comment_url":"https://api.github.com/repos/jang00777/nano/issues/comments{/number}","contents_url":"https://api.github.com/repos/jang00777/nano/contents/{+path}","compare_url":"https://api.github.com/repos/jang00777/nano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jang00777/nano/merges","archive_url":"https://api.github.com/repos/jang00777/nano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jang00777/nano/downloads","issues_url":"https://api.github.com/repos/jang00777/nano/issues{/number}","pulls_url":"https://api.github.com/repos/jang00777/nano/pulls{/number}","milestones_url":"https://api.github.com/repos/jang00777/nano/milestones{/number}","notifications_url":"https://api.github.com/repos/jang00777/nano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jang00777/nano/labels{/name}","releases_url":"https://api.github.com/repos/jang00777/nano/releases{/id}","deployments_url":"https://api.github.com/repos/jang00777/nano/deployments","created_at":"2018-06-12T05:56:58Z","updated_at":"2018-06-25T10:34:00Z","pushed_at":"2018-06-25T10:33:57Z","git_url":"git://github.com/jang00777/nano.git","ssh_url":"git@github.com:jang00777/nano.git","clone_url":"https://github.com/jang00777/nano.git","svn_url":"https://github.com/jang00777/nano","homepage":"https://github.com/CPLUOS/nano/wiki","size":796,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CPLUOS:master","ref":"master","sha":"672faae39594cc27f22a05b2fccf905d651a086a","user":{"login":"CPLUOS","id":33823127,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODIzMTI3","avatar_url":"https://avatars3.githubusercontent.com/u/33823127?v=4","gravatar_id":"","url":"https://api.github.com/users/CPLUOS","html_url":"https://github.com/CPLUOS","followers_url":"https://api.github.com/users/CPLUOS/followers","following_url":"https://api.github.com/users/CPLUOS/following{/other_user}","gists_url":"https://api.github.com/users/CPLUOS/gists{/gist_id}","starred_url":"https://api.github.com/users/CPLUOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CPLUOS/subscriptions","organizations_url":"https://api.github.com/users/CPLUOS/orgs","repos_url":"https://api.github.com/users/CPLUOS/repos","events_url":"https://api.github.com/users/CPLUOS/events{/privacy}","received_events_url":"https://api.github.com/users/CPLUOS/received_events","type":"Organization","site_admin":false},"repo":{"id":127641232,"node_id":"MDEwOlJlcG9zaXRvcnkxMjc2NDEyMzI=","name":"nano","full_name":"CPLUOS/nano","owner":{"login":"CPLUOS","id":33823127,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODIzMTI3","avatar_url":"https://avatars3.githubusercontent.com/u/33823127?v=4","gravatar_id":"","url":"https://api.github.com/users/CPLUOS","html_url":"https://github.com/CPLUOS","followers_url":"https://api.github.com/users/CPLUOS/followers","following_url":"https://api.github.com/users/CPLUOS/following{/other_user}","gists_url":"https://api.github.com/users/CPLUOS/gists{/gist_id}","starred_url":"https://api.github.com/users/CPLUOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CPLUOS/subscriptions","organizations_url":"https://api.github.com/users/CPLUOS/orgs","repos_url":"https://api.github.com/users/CPLUOS/repos","events_url":"https://api.github.com/users/CPLUOS/events{/privacy}","received_events_url":"https://api.github.com/users/CPLUOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CPLUOS/nano","description":"nanoAOD tools for production and analysis","fork":false,"url":"https://api.github.com/repos/CPLUOS/nano","forks_url":"https://api.github.com/repos/CPLUOS/nano/forks","keys_url":"https://api.github.com/repos/CPLUOS/nano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CPLUOS/nano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CPLUOS/nano/teams","hooks_url":"https://api.github.com/repos/CPLUOS/nano/hooks","issue_events_url":"https://api.github.com/repos/CPLUOS/nano/issues/events{/number}","events_url":"https://api.github.com/repos/CPLUOS/nano/events","assignees_url":"https://api.github.com/repos/CPLUOS/nano/assignees{/user}","branches_url":"https://api.github.com/repos/CPLUOS/nano/branches{/branch}","tags_url":"https://api.github.com/repos/CPLUOS/nano/tags","blobs_url":"https://api.github.com/repos/CPLUOS/nano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CPLUOS/nano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CPLUOS/nano/git/refs{/sha}","trees_url":"https://api.github.com/repos/CPLUOS/nano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CPLUOS/nano/statuses/{sha}","languages_url":"https://api.github.com/repos/CPLUOS/nano/languages","stargazers_url":"https://api.github.com/repos/CPLUOS/nano/stargazers","contributors_url":"https://api.github.com/repos/CPLUOS/nano/contributors","subscribers_url":"https://api.github.com/repos/CPLUOS/nano/subscribers","subscription_url":"https://api.github.com/repos/CPLUOS/nano/subscription","commits_url":"https://api.github.com/repos/CPLUOS/nano/commits{/sha}","git_commits_url":"https://api.github.com/repos/CPLUOS/nano/git/commits{/sha}","comments_url":"https://api.github.com/repos/CPLUOS/nano/comments{/number}","issue_comment_url":"https://api.github.com/repos/CPLUOS/nano/issues/comments{/number}","contents_url":"https://api.github.com/repos/CPLUOS/nano/contents/{+path}","compare_url":"https://api.github.com/repos/CPLUOS/nano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CPLUOS/nano/merges","archive_url":"https://api.github.com/repos/CPLUOS/nano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CPLUOS/nano/downloads","issues_url":"https://api.github.com/repos/CPLUOS/nano/issues{/number}","pulls_url":"https://api.github.com/repos/CPLUOS/nano/pulls{/number}","milestones_url":"https://api.github.com/repos/CPLUOS/nano/milestones{/number}","notifications_url":"https://api.github.com/repos/CPLUOS/nano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CPLUOS/nano/labels{/name}","releases_url":"https://api.github.com/repos/CPLUOS/nano/releases{/id}","deployments_url":"https://api.github.com/repos/CPLUOS/nano/deployments","created_at":"2018-04-01T15:21:21Z","updated_at":"2018-06-21T05:49:03Z","pushed_at":"2018-06-25T10:41:16Z","git_url":"git://github.com/CPLUOS/nano.git","ssh_url":"git@github.com:CPLUOS/nano.git","clone_url":"https://github.com/CPLUOS/nano.git","svn_url":"https://github.com/CPLUOS/nano","homepage":"https://github.com/CPLUOS/nano/wiki","size":795,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":12,"license":null,"forks":13,"open_issues":12,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CPLUOS/nano/pulls/96"},"html":{"href":"https://github.com/CPLUOS/nano/pull/96"},"issue":{"href":"https://api.github.com/repos/CPLUOS/nano/issues/96"},"comments":{"href":"https://api.github.com/repos/CPLUOS/nano/issues/96/comments"},"review_comments":{"href":"https://api.github.com/repos/CPLUOS/nano/pulls/96/comments"},"review_comment":{"href":"https://api.github.com/repos/CPLUOS/nano/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CPLUOS/nano/pulls/96/commits"},"statuses":{"href":"https://api.github.com/repos/CPLUOS/nano/statuses/58881277623b0c7447aee3a5e2d0b9113e77cda0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"watson-ij"}}