{"action":"created","comment":{"url":"https://api.github.com/repos/dimagi/commcare-cloud/pulls/comments/238176364","pull_request_review_id":179709888,"id":238176364,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODE3NjM2NA==","diff_hunk":"@@ -17,6 +17,17 @@ nginx_sites:\n       path: \"{{ www_home }}/hq_media/cache\"\n       max_size: \"2g\"\n       inactive_time: \"24h\"\n+   mappings:\n+    - name: \"$digest_submission\"\n+      variable: \"$http_authorization\"\n+      value: \"$server_name\"\n+   limit_req_zones:\n+    - name: \"restore\"\n+      zone: \"$digest_submission\"\n+      rate: \"6r/s\"\n+    - name: \"submissions\"\n+      zone: \"$digest_submission\"","path":"src/commcare_cloud/ansible/roles/nginx/vars/cchq_ssl.yml","position":13,"original_position":13,"commit_id":"9e55430e0080c3065986fec5cb3df1b80a5a5e83","original_commit_id":"9e55430e0080c3065986fec5cb3df1b80a5a5e83","user":{"login":"snopoke","id":249606,"node_id":"MDQ6VXNlcjI0OTYwNg==","avatar_url":"https://avatars3.githubusercontent.com/u/249606?v=4","gravatar_id":"","url":"https://api.github.com/users/snopoke","html_url":"https://github.com/snopoke","followers_url":"https://api.github.com/users/snopoke/followers","following_url":"https://api.github.com/users/snopoke/following{/other_user}","gists_url":"https://api.github.com/users/snopoke/gists{/gist_id}","starred_url":"https://api.github.com/users/snopoke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snopoke/subscriptions","organizations_url":"https://api.github.com/users/snopoke/orgs","repos_url":"https://api.github.com/users/snopoke/repos","events_url":"https://api.github.com/users/snopoke/events{/privacy}","received_events_url":"https://api.github.com/users/snopoke/received_events","type":"User","site_admin":false},"body":"I don't think we should use that zone as it's global. We want to restrict it per IP right? In that case we should use $binary_remote_addr","created_at":"2018-12-03T08:30:27Z","updated_at":"2018-12-03T08:30:54Z","html_url":"https://github.com/dimagi/commcare-cloud/pull/2450#discussion_r238176364","pull_request_url":"https://api.github.com/repos/dimagi/commcare-cloud/pulls/2450","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dimagi/commcare-cloud/pulls/comments/238176364"},"html":{"href":"https://github.com/dimagi/commcare-cloud/pull/2450#discussion_r238176364"},"pull_request":{"href":"https://api.github.com/repos/dimagi/commcare-cloud/pulls/2450"}}},"pull_request":{"url":"https://api.github.com/repos/dimagi/commcare-cloud/pulls/2450","id":234428507,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NDI4NTA3","html_url":"https://github.com/dimagi/commcare-cloud/pull/2450","diff_url":"https://github.com/dimagi/commcare-cloud/pull/2450.diff","patch_url":"https://github.com/dimagi/commcare-cloud/pull/2450.patch","issue_url":"https://api.github.com/repos/dimagi/commcare-cloud/issues/2450","number":2450,"state":"open","locked":false,"title":"limit pna requests","user":{"login":"jmtroth0","id":13040327,"node_id":"MDQ6VXNlcjEzMDQwMzI3","avatar_url":"https://avatars0.githubusercontent.com/u/13040327?v=4","gravatar_id":"","url":"https://api.github.com/users/jmtroth0","html_url":"https://github.com/jmtroth0","followers_url":"https://api.github.com/users/jmtroth0/followers","following_url":"https://api.github.com/users/jmtroth0/following{/other_user}","gists_url":"https://api.github.com/users/jmtroth0/gists{/gist_id}","starred_url":"https://api.github.com/users/jmtroth0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmtroth0/subscriptions","organizations_url":"https://api.github.com/users/jmtroth0/orgs","repos_url":"https://api.github.com/users/jmtroth0/repos","events_url":"https://api.github.com/users/jmtroth0/events{/privacy}","received_events_url":"https://api.github.com/users/jmtroth0/received_events","type":"User","site_admin":false},"body":"@snopoke this is what I was suggesting in the email about the okhttp retries. Let me know if you think it makes sense. I also haven't tested it, which probably should be done before this goes out.\r\n\r\nbuddy: @kaapstorm ","created_at":"2018-11-28T21:23:08Z","updated_at":"2018-12-03T08:30:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"833154944bb0a6aacd03bb9800a03f1b6c62c577","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dimagi/commcare-cloud/pulls/2450/commits","review_comments_url":"https://api.github.com/repos/dimagi/commcare-cloud/pulls/2450/comments","review_comment_url":"https://api.github.com/repos/dimagi/commcare-cloud/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dimagi/commcare-cloud/issues/2450/comments","statuses_url":"https://api.github.com/repos/dimagi/commcare-cloud/statuses/9e55430e0080c3065986fec5cb3df1b80a5a5e83","head":{"label":"dimagi:jr/limit-pna-requests","ref":"jr/limit-pna-requests","sha":"9e55430e0080c3065986fec5cb3df1b80a5a5e83","user":{"login":"dimagi","id":94514,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0NTE0","avatar_url":"https://avatars1.githubusercontent.com/u/94514?v=4","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"repo":{"id":22074543,"node_id":"MDEwOlJlcG9zaXRvcnkyMjA3NDU0Mw==","name":"commcare-cloud","full_name":"dimagi/commcare-cloud","private":false,"owner":{"login":"dimagi","id":94514,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0NTE0","avatar_url":"https://avatars1.githubusercontent.com/u/94514?v=4","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dimagi/commcare-cloud","description":"Tools for standing up and managing a CommCare HQ server environment","fork":false,"url":"https://api.github.com/repos/dimagi/commcare-cloud","forks_url":"https://api.github.com/repos/dimagi/commcare-cloud/forks","keys_url":"https://api.github.com/repos/dimagi/commcare-cloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dimagi/commcare-cloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dimagi/commcare-cloud/teams","hooks_url":"https://api.github.com/repos/dimagi/commcare-cloud/hooks","issue_events_url":"https://api.github.com/repos/dimagi/commcare-cloud/issues/events{/number}","events_url":"https://api.github.com/repos/dimagi/commcare-cloud/events","assignees_url":"https://api.github.com/repos/dimagi/commcare-cloud/assignees{/user}","branches_url":"https://api.github.com/repos/dimagi/commcare-cloud/branches{/branch}","tags_url":"https://api.github.com/repos/dimagi/commcare-cloud/tags","blobs_url":"https://api.github.com/repos/dimagi/commcare-cloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dimagi/commcare-cloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dimagi/commcare-cloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/dimagi/commcare-cloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dimagi/commcare-cloud/statuses/{sha}","languages_url":"https://api.github.com/repos/dimagi/commcare-cloud/languages","stargazers_url":"https://api.github.com/repos/dimagi/commcare-cloud/stargazers","contributors_url":"https://api.github.com/repos/dimagi/commcare-cloud/contributors","subscribers_url":"https://api.github.com/repos/dimagi/commcare-cloud/subscribers","subscription_url":"https://api.github.com/repos/dimagi/commcare-cloud/subscription","commits_url":"https://api.github.com/repos/dimagi/commcare-cloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/dimagi/commcare-cloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/dimagi/commcare-cloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/dimagi/commcare-cloud/issues/comments{/number}","contents_url":"https://api.github.com/repos/dimagi/commcare-cloud/contents/{+path}","compare_url":"https://api.github.com/repos/dimagi/commcare-cloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dimagi/commcare-cloud/merges","archive_url":"https://api.github.com/repos/dimagi/commcare-cloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dimagi/commcare-cloud/downloads","issues_url":"https://api.github.com/repos/dimagi/commcare-cloud/issues{/number}","pulls_url":"https://api.github.com/repos/dimagi/commcare-cloud/pulls{/number}","milestones_url":"https://api.github.com/repos/dimagi/commcare-cloud/milestones{/number}","notifications_url":"https://api.github.com/repos/dimagi/commcare-cloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dimagi/commcare-cloud/labels{/name}","releases_url":"https://api.github.com/repos/dimagi/commcare-cloud/releases{/id}","deployments_url":"https://api.github.com/repos/dimagi/commcare-cloud/deployments","created_at":"2014-07-21T18:04:26Z","updated_at":"2018-12-03T08:27:08Z","pushed_at":"2018-12-03T08:27:12Z","git_url":"git://github.com/dimagi/commcare-cloud.git","ssh_url":"git@github.com:dimagi/commcare-cloud.git","clone_url":"https://github.com/dimagi/commcare-cloud.git","svn_url":"https://github.com/dimagi/commcare-cloud","homepage":"https://dimagi.github.io/commcare-cloud/","size":12691,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":42,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":12,"open_issues":42,"watchers":10,"default_branch":"master"}},"base":{"label":"dimagi:master","ref":"master","sha":"3cc5fe956dbe68218b728e85f1d21eac068b757b","user":{"login":"dimagi","id":94514,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0NTE0","avatar_url":"https://avatars1.githubusercontent.com/u/94514?v=4","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"repo":{"id":22074543,"node_id":"MDEwOlJlcG9zaXRvcnkyMjA3NDU0Mw==","name":"commcare-cloud","full_name":"dimagi/commcare-cloud","private":false,"owner":{"login":"dimagi","id":94514,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0NTE0","avatar_url":"https://avatars1.githubusercontent.com/u/94514?v=4","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dimagi/commcare-cloud","description":"Tools for standing up and managing a CommCare HQ server environment","fork":false,"url":"https://api.github.com/repos/dimagi/commcare-cloud","forks_url":"https://api.github.com/repos/dimagi/commcare-cloud/forks","keys_url":"https://api.github.com/repos/dimagi/commcare-cloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dimagi/commcare-cloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dimagi/commcare-cloud/teams","hooks_url":"https://api.github.com/repos/dimagi/commcare-cloud/hooks","issue_events_url":"https://api.github.com/repos/dimagi/commcare-cloud/issues/events{/number}","events_url":"https://api.github.com/repos/dimagi/commcare-cloud/events","assignees_url":"https://api.github.com/repos/dimagi/commcare-cloud/assignees{/user}","branches_url":"https://api.github.com/repos/dimagi/commcare-cloud/branches{/branch}","tags_url":"https://api.github.com/repos/dimagi/commcare-cloud/tags","blobs_url":"https://api.github.com/repos/dimagi/commcare-cloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dimagi/commcare-cloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dimagi/commcare-cloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/dimagi/commcare-cloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dimagi/commcare-cloud/statuses/{sha}","languages_url":"https://api.github.com/repos/dimagi/commcare-cloud/languages","stargazers_url":"https://api.github.com/repos/dimagi/commcare-cloud/stargazers","contributors_url":"https://api.github.com/repos/dimagi/commcare-cloud/contributors","subscribers_url":"https://api.github.com/repos/dimagi/commcare-cloud/subscribers","subscription_url":"https://api.github.com/repos/dimagi/commcare-cloud/subscription","commits_url":"https://api.github.com/repos/dimagi/commcare-cloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/dimagi/commcare-cloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/dimagi/commcare-cloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/dimagi/commcare-cloud/issues/comments{/number}","contents_url":"https://api.github.com/repos/dimagi/commcare-cloud/contents/{+path}","compare_url":"https://api.github.com/repos/dimagi/commcare-cloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dimagi/commcare-cloud/merges","archive_url":"https://api.github.com/repos/dimagi/commcare-cloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dimagi/commcare-cloud/downloads","issues_url":"https://api.github.com/repos/dimagi/commcare-cloud/issues{/number}","pulls_url":"https://api.github.com/repos/dimagi/commcare-cloud/pulls{/number}","milestones_url":"https://api.github.com/repos/dimagi/commcare-cloud/milestones{/number}","notifications_url":"https://api.github.com/repos/dimagi/commcare-cloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dimagi/commcare-cloud/labels{/name}","releases_url":"https://api.github.com/repos/dimagi/commcare-cloud/releases{/id}","deployments_url":"https://api.github.com/repos/dimagi/commcare-cloud/deployments","created_at":"2014-07-21T18:04:26Z","updated_at":"2018-12-03T08:27:08Z","pushed_at":"2018-12-03T08:27:12Z","git_url":"git://github.com/dimagi/commcare-cloud.git","ssh_url":"git@github.com:dimagi/commcare-cloud.git","clone_url":"https://github.com/dimagi/commcare-cloud.git","svn_url":"https://github.com/dimagi/commcare-cloud","homepage":"https://dimagi.github.io/commcare-cloud/","size":12691,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":42,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":12,"open_issues":42,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dimagi/commcare-cloud/pulls/2450"},"html":{"href":"https://github.com/dimagi/commcare-cloud/pull/2450"},"issue":{"href":"https://api.github.com/repos/dimagi/commcare-cloud/issues/2450"},"comments":{"href":"https://api.github.com/repos/dimagi/commcare-cloud/issues/2450/comments"},"review_comments":{"href":"https://api.github.com/repos/dimagi/commcare-cloud/pulls/2450/comments"},"review_comment":{"href":"https://api.github.com/repos/dimagi/commcare-cloud/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dimagi/commcare-cloud/pulls/2450/commits"},"statuses":{"href":"https://api.github.com/repos/dimagi/commcare-cloud/statuses/9e55430e0080c3065986fec5cb3df1b80a5a5e83"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"snopoke"}}