{"action":"created","comment":{"url":"https://api.github.com/repos/yast/yast-firewall/pulls/comments/183298048","pull_request_review_id":114268414,"id":183298048,"diff_hunk":"@@ -47,48 +42,90 @@\n       let(:installed) { false }\n \n       it \"returns true\" do\n+        expect(subject).to_not receive(:configure_firewall)\n         expect(subject.write).to eq true\n       end\n     end\n \n     context \"when firewalld is installed\" do\n-      it \"enables the firewalld service if enabled in the proposal\" do\n-        allow(proposal_settings).to receive(\"enable_firewall\").and_return(true)\n-        expect(firewalld).to receive(\"enable!\")\n+      it \"configures the firewall according to the proposal settings\" do\n+        expect(subject).to receive(:configure_firewall)\n \n         subject.write\n       end\n \n-      it \"disables the firewalld service if disabled in the proposal\" do\n-        expect(firewalld).to receive(\"disable!\")\n-\n-        subject.write\n+      it \"returns true\" do","path":"test/lib/y2firewall/clients/installation_finish_test.rb","position":58,"original_position":58,"commit_id":"934195bfa93a72eedcfc262370a47ea4fcc06f6c","original_commit_id":"934195bfa93a72eedcfc262370a47ea4fcc06f6c","user":{"login":"mchf","id":1579239,"avatar_url":"https://avatars3.githubusercontent.com/u/1579239?v=4","gravatar_id":"","url":"https://api.github.com/users/mchf","html_url":"https://github.com/mchf","followers_url":"https://api.github.com/users/mchf/followers","following_url":"https://api.github.com/users/mchf/following{/other_user}","gists_url":"https://api.github.com/users/mchf/gists{/gist_id}","starred_url":"https://api.github.com/users/mchf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mchf/subscriptions","organizations_url":"https://api.github.com/users/mchf/orgs","repos_url":"https://api.github.com/users/mchf/repos","events_url":"https://api.github.com/users/mchf/events{/privacy}","received_events_url":"https://api.github.com/users/mchf/received_events","type":"User","site_admin":false},"body":"the first one ;-) But anyway this is NP for me.","created_at":"2018-04-23T07:31:39Z","updated_at":"2018-04-23T07:31:39Z","html_url":"https://github.com/yast/yast-firewall/pull/60#discussion_r183298048","pull_request_url":"https://api.github.com/repos/yast/yast-firewall/pulls/60","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/yast/yast-firewall/pulls/comments/183298048"},"html":{"href":"https://github.com/yast/yast-firewall/pull/60#discussion_r183298048"},"pull_request":{"href":"https://api.github.com/repos/yast/yast-firewall/pulls/60"}},"in_reply_to_id":183286742},"pull_request":{"url":"https://api.github.com/repos/yast/yast-firewall/pulls/60","id":183278971,"html_url":"https://github.com/yast/yast-firewall/pull/60","diff_url":"https://github.com/yast/yast-firewall/pull/60.diff","patch_url":"https://github.com/yast/yast-firewall/pull/60.patch","issue_url":"https://api.github.com/repos/yast/yast-firewall/issues/60","number":60,"state":"open","locked":false,"title":"Installation: Use tigervnc firewalld service definition","user":{"login":"teclator","id":7056681,"avatar_url":"https://avatars3.githubusercontent.com/u/7056681?v=4","gravatar_id":"","url":"https://api.github.com/users/teclator","html_url":"https://github.com/teclator","followers_url":"https://api.github.com/users/teclator/followers","following_url":"https://api.github.com/users/teclator/following{/other_user}","gists_url":"https://api.github.com/users/teclator/gists{/gist_id}","starred_url":"https://api.github.com/users/teclator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teclator/subscriptions","organizations_url":"https://api.github.com/users/teclator/orgs","repos_url":"https://api.github.com/users/teclator/repos","events_url":"https://api.github.com/users/teclator/events{/privacy}","received_events_url":"https://api.github.com/users/teclator/received_events","type":"User","site_admin":false},"body":"[Trello Card](https://trello.com/c/WbNLhdQb/1414-5-15-ga-or-mu-bug-1088647-build-5502-openqa-test-fails-in-yast2vnc-firewalld-does-not-create-rule-for-vnc-and-bug-1088646-build)\r\n","created_at":"2018-04-22T15:32:33Z","updated_at":"2018-04-23T07:31:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3ae219b8c2e9f988d00ecb0dd398fdd92bddf6f9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/yast/yast-firewall/pulls/60/commits","review_comments_url":"https://api.github.com/repos/yast/yast-firewall/pulls/60/comments","review_comment_url":"https://api.github.com/repos/yast/yast-firewall/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yast/yast-firewall/issues/60/comments","statuses_url":"https://api.github.com/repos/yast/yast-firewall/statuses/934195bfa93a72eedcfc262370a47ea4fcc06f6c","head":{"label":"yast:autoyast_tigervnc","ref":"autoyast_tigervnc","sha":"934195bfa93a72eedcfc262370a47ea4fcc06f6c","user":{"login":"yast","id":909990,"avatar_url":"https://avatars1.githubusercontent.com/u/909990?v=4","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"repo":{"id":9883285,"name":"yast-firewall","full_name":"yast/yast-firewall","owner":{"login":"yast","id":909990,"avatar_url":"https://avatars1.githubusercontent.com/u/909990?v=4","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yast/yast-firewall","description":null,"fork":false,"url":"https://api.github.com/repos/yast/yast-firewall","forks_url":"https://api.github.com/repos/yast/yast-firewall/forks","keys_url":"https://api.github.com/repos/yast/yast-firewall/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yast/yast-firewall/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yast/yast-firewall/teams","hooks_url":"https://api.github.com/repos/yast/yast-firewall/hooks","issue_events_url":"https://api.github.com/repos/yast/yast-firewall/issues/events{/number}","events_url":"https://api.github.com/repos/yast/yast-firewall/events","assignees_url":"https://api.github.com/repos/yast/yast-firewall/assignees{/user}","branches_url":"https://api.github.com/repos/yast/yast-firewall/branches{/branch}","tags_url":"https://api.github.com/repos/yast/yast-firewall/tags","blobs_url":"https://api.github.com/repos/yast/yast-firewall/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yast/yast-firewall/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yast/yast-firewall/git/refs{/sha}","trees_url":"https://api.github.com/repos/yast/yast-firewall/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yast/yast-firewall/statuses/{sha}","languages_url":"https://api.github.com/repos/yast/yast-firewall/languages","stargazers_url":"https://api.github.com/repos/yast/yast-firewall/stargazers","contributors_url":"https://api.github.com/repos/yast/yast-firewall/contributors","subscribers_url":"https://api.github.com/repos/yast/yast-firewall/subscribers","subscription_url":"https://api.github.com/repos/yast/yast-firewall/subscription","commits_url":"https://api.github.com/repos/yast/yast-firewall/commits{/sha}","git_commits_url":"https://api.github.com/repos/yast/yast-firewall/git/commits{/sha}","comments_url":"https://api.github.com/repos/yast/yast-firewall/comments{/number}","issue_comment_url":"https://api.github.com/repos/yast/yast-firewall/issues/comments{/number}","contents_url":"https://api.github.com/repos/yast/yast-firewall/contents/{+path}","compare_url":"https://api.github.com/repos/yast/yast-firewall/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yast/yast-firewall/merges","archive_url":"https://api.github.com/repos/yast/yast-firewall/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yast/yast-firewall/downloads","issues_url":"https://api.github.com/repos/yast/yast-firewall/issues{/number}","pulls_url":"https://api.github.com/repos/yast/yast-firewall/pulls{/number}","milestones_url":"https://api.github.com/repos/yast/yast-firewall/milestones{/number}","notifications_url":"https://api.github.com/repos/yast/yast-firewall/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yast/yast-firewall/labels{/name}","releases_url":"https://api.github.com/repos/yast/yast-firewall/releases{/id}","deployments_url":"https://api.github.com/repos/yast/yast-firewall/deployments","created_at":"2013-05-06T09:06:24Z","updated_at":"2018-04-17T10:56:05Z","pushed_at":"2018-04-23T00:15:29Z","git_url":"git://github.com/yast/yast-firewall.git","ssh_url":"git@github.com:yast/yast-firewall.git","clone_url":"https://github.com/yast/yast-firewall.git","svn_url":"https://github.com/yast/yast-firewall","homepage":null,"size":892,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":8,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"yast:master","ref":"master","sha":"9ad0d84c47e67293c6404a86a1310c8379c2dde0","user":{"login":"yast","id":909990,"avatar_url":"https://avatars1.githubusercontent.com/u/909990?v=4","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"repo":{"id":9883285,"name":"yast-firewall","full_name":"yast/yast-firewall","owner":{"login":"yast","id":909990,"avatar_url":"https://avatars1.githubusercontent.com/u/909990?v=4","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yast/yast-firewall","description":null,"fork":false,"url":"https://api.github.com/repos/yast/yast-firewall","forks_url":"https://api.github.com/repos/yast/yast-firewall/forks","keys_url":"https://api.github.com/repos/yast/yast-firewall/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yast/yast-firewall/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yast/yast-firewall/teams","hooks_url":"https://api.github.com/repos/yast/yast-firewall/hooks","issue_events_url":"https://api.github.com/repos/yast/yast-firewall/issues/events{/number}","events_url":"https://api.github.com/repos/yast/yast-firewall/events","assignees_url":"https://api.github.com/repos/yast/yast-firewall/assignees{/user}","branches_url":"https://api.github.com/repos/yast/yast-firewall/branches{/branch}","tags_url":"https://api.github.com/repos/yast/yast-firewall/tags","blobs_url":"https://api.github.com/repos/yast/yast-firewall/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yast/yast-firewall/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yast/yast-firewall/git/refs{/sha}","trees_url":"https://api.github.com/repos/yast/yast-firewall/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yast/yast-firewall/statuses/{sha}","languages_url":"https://api.github.com/repos/yast/yast-firewall/languages","stargazers_url":"https://api.github.com/repos/yast/yast-firewall/stargazers","contributors_url":"https://api.github.com/repos/yast/yast-firewall/contributors","subscribers_url":"https://api.github.com/repos/yast/yast-firewall/subscribers","subscription_url":"https://api.github.com/repos/yast/yast-firewall/subscription","commits_url":"https://api.github.com/repos/yast/yast-firewall/commits{/sha}","git_commits_url":"https://api.github.com/repos/yast/yast-firewall/git/commits{/sha}","comments_url":"https://api.github.com/repos/yast/yast-firewall/comments{/number}","issue_comment_url":"https://api.github.com/repos/yast/yast-firewall/issues/comments{/number}","contents_url":"https://api.github.com/repos/yast/yast-firewall/contents/{+path}","compare_url":"https://api.github.com/repos/yast/yast-firewall/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yast/yast-firewall/merges","archive_url":"https://api.github.com/repos/yast/yast-firewall/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yast/yast-firewall/downloads","issues_url":"https://api.github.com/repos/yast/yast-firewall/issues{/number}","pulls_url":"https://api.github.com/repos/yast/yast-firewall/pulls{/number}","milestones_url":"https://api.github.com/repos/yast/yast-firewall/milestones{/number}","notifications_url":"https://api.github.com/repos/yast/yast-firewall/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yast/yast-firewall/labels{/name}","releases_url":"https://api.github.com/repos/yast/yast-firewall/releases{/id}","deployments_url":"https://api.github.com/repos/yast/yast-firewall/deployments","created_at":"2013-05-06T09:06:24Z","updated_at":"2018-04-17T10:56:05Z","pushed_at":"2018-04-23T00:15:29Z","git_url":"git://github.com/yast/yast-firewall.git","ssh_url":"git@github.com:yast/yast-firewall.git","clone_url":"https://github.com/yast/yast-firewall.git","svn_url":"https://github.com/yast/yast-firewall","homepage":null,"size":892,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":8,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yast/yast-firewall/pulls/60"},"html":{"href":"https://github.com/yast/yast-firewall/pull/60"},"issue":{"href":"https://api.github.com/repos/yast/yast-firewall/issues/60"},"comments":{"href":"https://api.github.com/repos/yast/yast-firewall/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/yast/yast-firewall/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/yast/yast-firewall/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yast/yast-firewall/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/yast/yast-firewall/statuses/934195bfa93a72eedcfc262370a47ea4fcc06f6c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mchf"}}