{"action":"created","issue":{"url":"https://api.github.com/repos/cgrandin/hake-assessment/issues/391","repository_url":"https://api.github.com/repos/cgrandin/hake-assessment","labels_url":"https://api.github.com/repos/cgrandin/hake-assessment/issues/391/labels{/name}","comments_url":"https://api.github.com/repos/cgrandin/hake-assessment/issues/391/comments","events_url":"https://api.github.com/repos/cgrandin/hake-assessment/issues/391/events","html_url":"https://github.com/cgrandin/hake-assessment/issues/391","id":296119242,"number":391,"title":"Canadian JV catch was double-counted","user":{"login":"cgrandin","id":4551051,"avatar_url":"https://avatars3.githubusercontent.com/u/4551051?v=4","gravatar_id":"","url":"https://api.github.com/users/cgrandin","html_url":"https://github.com/cgrandin","followers_url":"https://api.github.com/users/cgrandin/followers","following_url":"https://api.github.com/users/cgrandin/following{/other_user}","gists_url":"https://api.github.com/users/cgrandin/gists{/gist_id}","starred_url":"https://api.github.com/users/cgrandin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgrandin/subscriptions","organizations_url":"https://api.github.com/users/cgrandin/orgs","repos_url":"https://api.github.com/users/cgrandin/repos","events_url":"https://api.github.com/users/cgrandin/events{/privacy}","received_events_url":"https://api.github.com/users/cgrandin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"taylori","id":4992918,"avatar_url":"https://avatars2.githubusercontent.com/u/4992918?v=4","gravatar_id":"","url":"https://api.github.com/users/taylori","html_url":"https://github.com/taylori","followers_url":"https://api.github.com/users/taylori/followers","following_url":"https://api.github.com/users/taylori/following{/other_user}","gists_url":"https://api.github.com/users/taylori/gists{/gist_id}","starred_url":"https://api.github.com/users/taylori/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taylori/subscriptions","organizations_url":"https://api.github.com/users/taylori/orgs","repos_url":"https://api.github.com/users/taylori/repos","events_url":"https://api.github.com/users/taylori/events{/privacy}","received_events_url":"https://api.github.com/users/taylori/received_events","type":"User","site_admin":false},"assignees":[{"login":"taylori","id":4992918,"avatar_url":"https://avatars2.githubusercontent.com/u/4992918?v=4","gravatar_id":"","url":"https://api.github.com/users/taylori","html_url":"https://github.com/taylori","followers_url":"https://api.github.com/users/taylori/followers","following_url":"https://api.github.com/users/taylori/following{/other_user}","gists_url":"https://api.github.com/users/taylori/gists{/gist_id}","starred_url":"https://api.github.com/users/taylori/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taylori/subscriptions","organizations_url":"https://api.github.com/users/taylori/orgs","repos_url":"https://api.github.com/users/taylori/repos","events_url":"https://api.github.com/users/taylori/events{/privacy}","received_events_url":"https://api.github.com/users/taylori/received_events","type":"User","site_admin":false},{"login":"aaronmberger","id":7946234,"avatar_url":"https://avatars2.githubusercontent.com/u/7946234?v=4","gravatar_id":"","url":"https://api.github.com/users/aaronmberger","html_url":"https://github.com/aaronmberger","followers_url":"https://api.github.com/users/aaronmberger/followers","following_url":"https://api.github.com/users/aaronmberger/following{/other_user}","gists_url":"https://api.github.com/users/aaronmberger/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronmberger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronmberger/subscriptions","organizations_url":"https://api.github.com/users/aaronmberger/orgs","repos_url":"https://api.github.com/users/aaronmberger/repos","events_url":"https://api.github.com/users/aaronmberger/events{/privacy}","received_events_url":"https://api.github.com/users/aaronmberger/received_events","type":"User","site_admin":false}],"milestone":null,"comments":52,"created_at":"2018-02-10T17:50:15Z","updated_at":"2018-02-12T18:13:34Z","closed_at":null,"author_association":"OWNER","body":"Due to a very small bug in the catch code, the JV catch was lumped into the Shoreside catch as well as being reported separately. This means the JV catch was added to the Canadian total twice, so the value should be 5608 t less than what we used in the model. I apologize for this, it really was a tiny bug (two characters on one line of code). I think the impact will be minimal, as it's only 1% of the catch but maybe we should run a sensitivity and have it ready for the SRG.\r\n\r\nI uploaded the corrected file into the Google drive. It's called\r\n`JVCorrected-Canada-Landings_Fleet_Year_Month.csv`\r\n"},"comment":{"url":"https://api.github.com/repos/cgrandin/hake-assessment/issues/comments/365011198","html_url":"https://github.com/cgrandin/hake-assessment/issues/391#issuecomment-365011198","issue_url":"https://api.github.com/repos/cgrandin/hake-assessment/issues/391","id":365011198,"user":{"login":"andrew-edwards","id":6977190,"avatar_url":"https://avatars2.githubusercontent.com/u/6977190?v=4","gravatar_id":"","url":"https://api.github.com/users/andrew-edwards","html_url":"https://github.com/andrew-edwards","followers_url":"https://api.github.com/users/andrew-edwards/followers","following_url":"https://api.github.com/users/andrew-edwards/following{/other_user}","gists_url":"https://api.github.com/users/andrew-edwards/gists{/gist_id}","starred_url":"https://api.github.com/users/andrew-edwards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrew-edwards/subscriptions","organizations_url":"https://api.github.com/users/andrew-edwards/orgs","repos_url":"https://api.github.com/users/andrew-edwards/repos","events_url":"https://api.github.com/users/andrew-edwards/events{/privacy}","received_events_url":"https://api.github.com/users/andrew-edwards/received_events","type":"User","site_admin":false},"created_at":"2018-02-12T18:13:34Z","updated_at":"2018-02-12T18:13:34Z","author_association":"COLLABORATOR","body":"Doing some minor edits. Final sentence:\r\n```\r\nTaken together, the net effect of these changes was an average change of \r\n0.5\\% in total catch over the years 2007 to 2017. The total change \r\nwas 15,798 t over a period with total catch of over 300,000,000~t.    [I put millions in numbers to make it easier to compare]\r\n```\r\nIs the 0.5% from working out the change each year then taking the mean of those? \r\nIsn't it 0.005%?  I get that from doing\r\n```\r\n> 15798/(3e8) * 100\r\n[1] 0.005266\r\n```\r\n\r\n"}}
{"actor":{"display_login":"andrew-edwards"}}