{"action":"created","comment":{"url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/pulls/comments/197610412","pull_request_review_id":131393173,"id":197610412,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzYxMDQxMg==","diff_hunk":"@@ -17,6 +17,23 @@ def json_dump(self):\n             username=self.username,\n             email=self.email)\n \n+class Ride(object):\n+    \"\"\"A Ride class to define the ride object.\"\"\"\n+    pk = 1","path":"app/models.py","position":null,"original_position":6,"commit_id":"ef5646f46c9ae81e1d887ad7689a68a72202c823","original_commit_id":"ef5646f46c9ae81e1d887ad7689a68a72202c823","user":{"login":"kwanj-k","id":33450849,"node_id":"MDQ6VXNlcjMzNDUwODQ5","avatar_url":"https://avatars0.githubusercontent.com/u/33450849?v=4","gravatar_id":"","url":"https://api.github.com/users/kwanj-k","html_url":"https://github.com/kwanj-k","followers_url":"https://api.github.com/users/kwanj-k/followers","following_url":"https://api.github.com/users/kwanj-k/following{/other_user}","gists_url":"https://api.github.com/users/kwanj-k/gists{/gist_id}","starred_url":"https://api.github.com/users/kwanj-k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwanj-k/subscriptions","organizations_url":"https://api.github.com/users/kwanj-k/orgs","repos_url":"https://api.github.com/users/kwanj-k/repos","events_url":"https://api.github.com/users/kwanj-k/events{/privacy}","received_events_url":"https://api.github.com/users/kwanj-k/received_events","type":"User","site_admin":false},"body":"Thanks Joshua, i was trying to go for primary key but it felt too long.\r\nI will see what i can do","created_at":"2018-06-23T12:13:43Z","updated_at":"2018-06-23T12:13:43Z","html_url":"https://github.com/kwanj-k/ride-my-way-API-V1/pull/2#discussion_r197610412","pull_request_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/pulls/2","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/pulls/comments/197610412"},"html":{"href":"https://github.com/kwanj-k/ride-my-way-API-V1/pull/2#discussion_r197610412"},"pull_request":{"href":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/pulls/2"}},"in_reply_to_id":197609686},"pull_request":{"url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/pulls/2","id":196892457,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2ODkyNDU3","html_url":"https://github.com/kwanj-k/ride-my-way-API-V1/pull/2","diff_url":"https://github.com/kwanj-k/ride-my-way-API-V1/pull/2.diff","patch_url":"https://github.com/kwanj-k/ride-my-way-API-V1/pull/2.patch","issue_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/issues/2","number":2,"state":"open","locked":false,"title":"#158531032-Added signup and signin endpoints ","user":{"login":"kwanj-k","id":33450849,"node_id":"MDQ6VXNlcjMzNDUwODQ5","avatar_url":"https://avatars0.githubusercontent.com/u/33450849?v=4","gravatar_id":"","url":"https://api.github.com/users/kwanj-k","html_url":"https://github.com/kwanj-k","followers_url":"https://api.github.com/users/kwanj-k/followers","following_url":"https://api.github.com/users/kwanj-k/following{/other_user}","gists_url":"https://api.github.com/users/kwanj-k/gists{/gist_id}","starred_url":"https://api.github.com/users/kwanj-k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwanj-k/subscriptions","organizations_url":"https://api.github.com/users/kwanj-k/orgs","repos_url":"https://api.github.com/users/kwanj-k/repos","events_url":"https://api.github.com/users/kwanj-k/events{/privacy}","received_events_url":"https://api.github.com/users/kwanj-k/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\nAdd signup and sign in endpoints\r\n\r\n### Description of Task to be completed\r\n* Create authentication end-points and get 3 of the tests to pass\r\n\r\n### How should I test it?\r\n 1. Clone the repo\r\n  ```\r\n  $ git clone https://github.com/kwanj-k/ride-my-way-API-V1.git\r\n  $ cd into the cloned repo\r\n  $ git checkout ft-signup/signin-#158531032\r\n  ```\r\nCreate a virtualenv and activate it::\r\n\r\n    Virtualenv -p python3 .\r\n    source bin/activate\r\n\r\nInstall the dependencies::\r\n\r\n    pip install -r requirements.txt \r\n\r\n### Running tests without coverage\r\nRun the tests from the terminal\r\n```\r\npython manage.py test\r\n```\r\n\r\n### Running tests with coverage\r\nRun tests with coverage by running this command in the terminal\r\n```\r\npytest --cov-report term-missing --cov=app\r\n```\r\n\r\n### What PT stories?\r\n[ft-signup/sign-#158531032]https://www.pivotaltracker.com/story/show/158531032\r\n\r\n\r\n\r\n\r\n","created_at":"2018-06-23T09:34:40Z","updated_at":"2018-06-23T12:13:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8b2aa110d863558bd3849db14924a301fc80808","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/pulls/2/commits","review_comments_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/pulls/2/comments","review_comment_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/issues/2/comments","statuses_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/statuses/ef5646f46c9ae81e1d887ad7689a68a72202c823","head":{"label":"kwanj-k:ft-signup/signin-#158531032","ref":"ft-signup/signin-#158531032","sha":"ef5646f46c9ae81e1d887ad7689a68a72202c823","user":{"login":"kwanj-k","id":33450849,"node_id":"MDQ6VXNlcjMzNDUwODQ5","avatar_url":"https://avatars0.githubusercontent.com/u/33450849?v=4","gravatar_id":"","url":"https://api.github.com/users/kwanj-k","html_url":"https://github.com/kwanj-k","followers_url":"https://api.github.com/users/kwanj-k/followers","following_url":"https://api.github.com/users/kwanj-k/following{/other_user}","gists_url":"https://api.github.com/users/kwanj-k/gists{/gist_id}","starred_url":"https://api.github.com/users/kwanj-k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwanj-k/subscriptions","organizations_url":"https://api.github.com/users/kwanj-k/orgs","repos_url":"https://api.github.com/users/kwanj-k/repos","events_url":"https://api.github.com/users/kwanj-k/events{/privacy}","received_events_url":"https://api.github.com/users/kwanj-k/received_events","type":"User","site_admin":false},"repo":{"id":138273227,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgyNzMyMjc=","name":"ride-my-way-API-V1","full_name":"kwanj-k/ride-my-way-API-V1","owner":{"login":"kwanj-k","id":33450849,"node_id":"MDQ6VXNlcjMzNDUwODQ5","avatar_url":"https://avatars0.githubusercontent.com/u/33450849?v=4","gravatar_id":"","url":"https://api.github.com/users/kwanj-k","html_url":"https://github.com/kwanj-k","followers_url":"https://api.github.com/users/kwanj-k/followers","following_url":"https://api.github.com/users/kwanj-k/following{/other_user}","gists_url":"https://api.github.com/users/kwanj-k/gists{/gist_id}","starred_url":"https://api.github.com/users/kwanj-k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwanj-k/subscriptions","organizations_url":"https://api.github.com/users/kwanj-k/orgs","repos_url":"https://api.github.com/users/kwanj-k/repos","events_url":"https://api.github.com/users/kwanj-k/events{/privacy}","received_events_url":"https://api.github.com/users/kwanj-k/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kwanj-k/ride-my-way-API-V1","description":null,"fork":false,"url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1","forks_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/forks","keys_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/teams","hooks_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/hooks","issue_events_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/issues/events{/number}","events_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/events","assignees_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/assignees{/user}","branches_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/branches{/branch}","tags_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/tags","blobs_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/git/refs{/sha}","trees_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/statuses/{sha}","languages_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/languages","stargazers_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/stargazers","contributors_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/contributors","subscribers_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/subscribers","subscription_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/subscription","commits_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/commits{/sha}","git_commits_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/git/commits{/sha}","comments_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/comments{/number}","issue_comment_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/issues/comments{/number}","contents_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/contents/{+path}","compare_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/merges","archive_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/downloads","issues_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/issues{/number}","pulls_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/pulls{/number}","milestones_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/milestones{/number}","notifications_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/labels{/name}","releases_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/releases{/id}","deployments_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/deployments","created_at":"2018-06-22T07:57:41Z","updated_at":"2018-06-22T07:57:43Z","pushed_at":"2018-06-23T12:11:48Z","git_url":"git://github.com/kwanj-k/ride-my-way-API-V1.git","ssh_url":"git@github.com:kwanj-k/ride-my-way-API-V1.git","clone_url":"https://github.com/kwanj-k/ride-my-way-API-V1.git","svn_url":"https://github.com/kwanj-k/ride-my-way-API-V1","homepage":null,"size":20,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"kwanj-k:master","ref":"master","sha":"9d90a5cd61ed4a0c8b2565abd27eb2a93caf7b11","user":{"login":"kwanj-k","id":33450849,"node_id":"MDQ6VXNlcjMzNDUwODQ5","avatar_url":"https://avatars0.githubusercontent.com/u/33450849?v=4","gravatar_id":"","url":"https://api.github.com/users/kwanj-k","html_url":"https://github.com/kwanj-k","followers_url":"https://api.github.com/users/kwanj-k/followers","following_url":"https://api.github.com/users/kwanj-k/following{/other_user}","gists_url":"https://api.github.com/users/kwanj-k/gists{/gist_id}","starred_url":"https://api.github.com/users/kwanj-k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwanj-k/subscriptions","organizations_url":"https://api.github.com/users/kwanj-k/orgs","repos_url":"https://api.github.com/users/kwanj-k/repos","events_url":"https://api.github.com/users/kwanj-k/events{/privacy}","received_events_url":"https://api.github.com/users/kwanj-k/received_events","type":"User","site_admin":false},"repo":{"id":138273227,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgyNzMyMjc=","name":"ride-my-way-API-V1","full_name":"kwanj-k/ride-my-way-API-V1","owner":{"login":"kwanj-k","id":33450849,"node_id":"MDQ6VXNlcjMzNDUwODQ5","avatar_url":"https://avatars0.githubusercontent.com/u/33450849?v=4","gravatar_id":"","url":"https://api.github.com/users/kwanj-k","html_url":"https://github.com/kwanj-k","followers_url":"https://api.github.com/users/kwanj-k/followers","following_url":"https://api.github.com/users/kwanj-k/following{/other_user}","gists_url":"https://api.github.com/users/kwanj-k/gists{/gist_id}","starred_url":"https://api.github.com/users/kwanj-k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwanj-k/subscriptions","organizations_url":"https://api.github.com/users/kwanj-k/orgs","repos_url":"https://api.github.com/users/kwanj-k/repos","events_url":"https://api.github.com/users/kwanj-k/events{/privacy}","received_events_url":"https://api.github.com/users/kwanj-k/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kwanj-k/ride-my-way-API-V1","description":null,"fork":false,"url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1","forks_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/forks","keys_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/teams","hooks_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/hooks","issue_events_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/issues/events{/number}","events_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/events","assignees_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/assignees{/user}","branches_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/branches{/branch}","tags_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/tags","blobs_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/git/refs{/sha}","trees_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/statuses/{sha}","languages_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/languages","stargazers_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/stargazers","contributors_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/contributors","subscribers_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/subscribers","subscription_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/subscription","commits_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/commits{/sha}","git_commits_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/git/commits{/sha}","comments_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/comments{/number}","issue_comment_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/issues/comments{/number}","contents_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/contents/{+path}","compare_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/merges","archive_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/downloads","issues_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/issues{/number}","pulls_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/pulls{/number}","milestones_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/milestones{/number}","notifications_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/labels{/name}","releases_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/releases{/id}","deployments_url":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/deployments","created_at":"2018-06-22T07:57:41Z","updated_at":"2018-06-22T07:57:43Z","pushed_at":"2018-06-23T12:11:48Z","git_url":"git://github.com/kwanj-k/ride-my-way-API-V1.git","ssh_url":"git@github.com:kwanj-k/ride-my-way-API-V1.git","clone_url":"https://github.com/kwanj-k/ride-my-way-API-V1.git","svn_url":"https://github.com/kwanj-k/ride-my-way-API-V1","homepage":null,"size":20,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/pulls/2"},"html":{"href":"https://github.com/kwanj-k/ride-my-way-API-V1/pull/2"},"issue":{"href":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/issues/2"},"comments":{"href":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/kwanj-k/ride-my-way-API-V1/statuses/ef5646f46c9ae81e1d887ad7689a68a72202c823"}},"author_association":"OWNER"}}
{"actor":{"display_login":"kwanj-k"}}