{"action":"created","issue":{"url":"https://api.github.com/repos/gfx-rs/gfx/issues/2017","repository_url":"https://api.github.com/repos/gfx-rs/gfx","labels_url":"https://api.github.com/repos/gfx-rs/gfx/issues/2017/labels{/name}","comments_url":"https://api.github.com/repos/gfx-rs/gfx/issues/2017/comments","events_url":"https://api.github.com/repos/gfx-rs/gfx/issues/2017/events","html_url":"https://github.com/gfx-rs/gfx/pull/2017","id":322559465,"number":2017,"title":"[mtl] force Store mode on depth/stencil clears","user":{"login":"kvark","id":107301,"avatar_url":"https://avatars1.githubusercontent.com/u/107301?v=4","gravatar_id":"","url":"https://api.github.com/users/kvark","html_url":"https://github.com/kvark","followers_url":"https://api.github.com/users/kvark/followers","following_url":"https://api.github.com/users/kvark/following{/other_user}","gists_url":"https://api.github.com/users/kvark/gists{/gist_id}","starred_url":"https://api.github.com/users/kvark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kvark/subscriptions","organizations_url":"https://api.github.com/users/kvark/orgs","repos_url":"https://api.github.com/users/kvark/repos","events_url":"https://api.github.com/users/kvark/events{/privacy}","received_events_url":"https://api.github.com/users/kvark/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-05-13T02:58:25Z","updated_at":"2018-05-14T00:07:12Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/gfx-rs/gfx/pulls/2017","html_url":"https://github.com/gfx-rs/gfx/pull/2017","diff_url":"https://github.com/gfx-rs/gfx/pull/2017.diff","patch_url":"https://github.com/gfx-rs/gfx/pull/2017.patch"},"body":"Apparently the store mode is DontCare *by default* on depth/stencil. This change doesn't let us pass more tests though - something is broken up in multiple spots (no sure who to blame yet):\r\n  - clearing multiple ranges doesn't work with UINT/INT (go figure what it has to do with multiple ranges...)\r\n  - clearing 1D texture doesn't work with any formats above 16 bits (e.g. RGBA8, RG16, etc), except for sRGB ones (we do have a hack in place to treat 1D textures as 2D if mipmaps are requested, but still unclear how is this related with the observed limitations)\r\n\r\nNote: CTS has a lot of magic in it, and maybe it's simply broken (that already happened a few times), or there is something wonky going on around transfers/mapping that are required to check the results (even if clears are fine).\r\n\r\nPR checklist:\r\n- [x] `make` succeeds (on *nix)\r\n- [ ] `make reftests` succeeds (Nope, it actually hangs :( right after the beta 5 update)\r\n- [] tested examples with the following backends:\r\n"},"comment":{"url":"https://api.github.com/repos/gfx-rs/gfx/issues/comments/388665955","html_url":"https://github.com/gfx-rs/gfx/pull/2017#issuecomment-388665955","issue_url":"https://api.github.com/repos/gfx-rs/gfx/issues/2017","id":388665955,"user":{"login":"bors[bot]","id":26634292,"avatar_url":"https://avatars3.githubusercontent.com/in/1847?v=4","gravatar_id":"","url":"https://api.github.com/users/bors%5Bbot%5D","html_url":"https://github.com/apps/bors","followers_url":"https://api.github.com/users/bors%5Bbot%5D/followers","following_url":"https://api.github.com/users/bors%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/bors%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/bors%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bors%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/bors%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/bors%5Bbot%5D/repos","events_url":"https://api.github.com/users/bors%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/bors%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-05-14T00:07:12Z","updated_at":"2018-05-14T00:07:12Z","author_association":"CONTRIBUTOR","body":"# Build succeeded\n  * [continuous-integration/travis-ci/push](https://travis-ci.org/gfx-rs/gfx/builds/378500586?utm_source=github_status&utm_medium=notification)\n  * [continuous-integration/appveyor/branch](https://ci.appveyor.com/project/kvark/gfx/build/1.0.3164)"}}
{"actor":{"display_login":"bors"}}