{"action":"created","comment":{"url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/comments/169507028","pull_request_review_id":98044205,"id":169507028,"diff_hunk":"@@ -1,12 +1,13 @@\n FROM tfb:latest\n \n-RUN add-apt-repository -y ppa:openjdk-r/ppa\n-RUN apt-get update\n-RUN apt-get install -qqy -o Dpkg::Options::=\"--force-confdef\" -o Dpkg::Options::=\"--force-confold\" \\\n-    openjdk-8-jdk ant\n+RUN mkdir /java\n+WORKDIR /java\n+RUN curl https://download.java.net/java/GA/jdk9/9.0.4/binaries/openjdk-9.0.4_linux-x64_bin.tar.gz | tar xz\n+ENV JAVA_HOME=/java/jdk-9.0.4\n+ENV PATH=\"${JAVA_HOME}/bin:${PATH}\"\n \n-# https://bugs.launchpad.net/ubuntu/+source/ca-certificates-java/+bug/1396760\n-RUN /var/lib/dpkg/info/ca-certificates-java.postinst configure\n-\n-ENV JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64\n-ENV PATH=\"/usr/lib/jvm/java-8-openjdk-amd64/bin:${PATH}\"\n\\ No newline at end of file\n+RUN mkdir /maven","path":"toolset/setup/linux/docker/java.dockerfile","position":19,"original_position":19,"commit_id":"4e5b9ee75fd919b938bf70f475cf896445d1c177","original_commit_id":"4e5b9ee75fd919b938bf70f475cf896445d1c177","user":{"login":"nbrady-techempower","id":1304934,"avatar_url":"https://avatars3.githubusercontent.com/u/1304934?v=4","gravatar_id":"","url":"https://api.github.com/users/nbrady-techempower","html_url":"https://github.com/nbrady-techempower","followers_url":"https://api.github.com/users/nbrady-techempower/followers","following_url":"https://api.github.com/users/nbrady-techempower/following{/other_user}","gists_url":"https://api.github.com/users/nbrady-techempower/gists{/gist_id}","starred_url":"https://api.github.com/users/nbrady-techempower/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbrady-techempower/subscriptions","organizations_url":"https://api.github.com/users/nbrady-techempower/orgs","repos_url":"https://api.github.com/users/nbrady-techempower/repos","events_url":"https://api.github.com/users/nbrady-techempower/events{/privacy}","received_events_url":"https://api.github.com/users/nbrady-techempower/received_events","type":"User","site_admin":false},"body":"I agree @michaelhixson I feel the same way. I've discussed this with @msmith-techempower too, as it was one of the first concerns that jumped out at me. I don't know of a better way other than creating different combinations as the need arises, and that is definitely unsatisfying. Right now, I don't think there are a ton of frameworks that would need this.\r\n\r\nI think a compromise could be installing maven, ant, gradle, etc within the java-8 and java-9 dockerfiles. Does it make sense to separate these things out? Does having an image built with gradle on it negatively affect java frameworks that don't use gradle? Other than the first installation time?","created_at":"2018-02-21T00:47:43Z","updated_at":"2018-02-21T00:47:43Z","html_url":"https://github.com/TechEmpower/FrameworkBenchmarks/pull/3311#discussion_r169507028","pull_request_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/3311","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/comments/169507028"},"html":{"href":"https://github.com/TechEmpower/FrameworkBenchmarks/pull/3311#discussion_r169507028"},"pull_request":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/3311"}},"in_reply_to_id":169467206},"pull_request":{"url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/3311","id":170286546,"html_url":"https://github.com/TechEmpower/FrameworkBenchmarks/pull/3311","diff_url":"https://github.com/TechEmpower/FrameworkBenchmarks/pull/3311.diff","patch_url":"https://github.com/TechEmpower/FrameworkBenchmarks/pull/3311.patch","issue_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/issues/3311","number":3311,"state":"open","locked":false,"title":"Convert the undertow tests to docker","user":{"login":"michaelhixson","id":297150,"avatar_url":"https://avatars3.githubusercontent.com/u/297150?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelhixson","html_url":"https://github.com/michaelhixson","followers_url":"https://api.github.com/users/michaelhixson/followers","following_url":"https://api.github.com/users/michaelhixson/following{/other_user}","gists_url":"https://api.github.com/users/michaelhixson/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelhixson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelhixson/subscriptions","organizations_url":"https://api.github.com/users/michaelhixson/orgs","repos_url":"https://api.github.com/users/michaelhixson/repos","events_url":"https://api.github.com/users/michaelhixson/events{/privacy}","received_events_url":"https://api.github.com/users/michaelhixson/received_events","type":"User","site_admin":false},"body":"The databases don't work for me locally, but I'm told they are supposed to work, so let's see what Travis says.","created_at":"2018-02-20T19:30:35Z","updated_at":"2018-02-21T00:47:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e375ecedbeaf721c360adf66dd385dca680462f3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":839287897,"url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/labels/PR:%20Docker","name":"PR: Docker","color":"3f85c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/3311/commits","review_comments_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/3311/comments","review_comment_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/issues/3311/comments","statuses_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/statuses/4e5b9ee75fd919b938bf70f475cf896445d1c177","head":{"label":"michaelhixson:undertow-docker","ref":"undertow-docker","sha":"4e5b9ee75fd919b938bf70f475cf896445d1c177","user":{"login":"michaelhixson","id":297150,"avatar_url":"https://avatars3.githubusercontent.com/u/297150?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelhixson","html_url":"https://github.com/michaelhixson","followers_url":"https://api.github.com/users/michaelhixson/followers","following_url":"https://api.github.com/users/michaelhixson/following{/other_user}","gists_url":"https://api.github.com/users/michaelhixson/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelhixson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelhixson/subscriptions","organizations_url":"https://api.github.com/users/michaelhixson/orgs","repos_url":"https://api.github.com/users/michaelhixson/repos","events_url":"https://api.github.com/users/michaelhixson/events{/privacy}","received_events_url":"https://api.github.com/users/michaelhixson/received_events","type":"User","site_admin":false},"repo":{"id":80167535,"name":"FrameworkBenchmarks","full_name":"michaelhixson/FrameworkBenchmarks","owner":{"login":"michaelhixson","id":297150,"avatar_url":"https://avatars3.githubusercontent.com/u/297150?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelhixson","html_url":"https://github.com/michaelhixson","followers_url":"https://api.github.com/users/michaelhixson/followers","following_url":"https://api.github.com/users/michaelhixson/following{/other_user}","gists_url":"https://api.github.com/users/michaelhixson/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelhixson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelhixson/subscriptions","organizations_url":"https://api.github.com/users/michaelhixson/orgs","repos_url":"https://api.github.com/users/michaelhixson/repos","events_url":"https://api.github.com/users/michaelhixson/events{/privacy}","received_events_url":"https://api.github.com/users/michaelhixson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/michaelhixson/FrameworkBenchmarks","description":"Source code for the framework benchmarking project","fork":true,"url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks","forks_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/forks","keys_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/teams","hooks_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/hooks","issue_events_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/issues/events{/number}","events_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/events","assignees_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/assignees{/user}","branches_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/branches{/branch}","tags_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/tags","blobs_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/git/refs{/sha}","trees_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/statuses/{sha}","languages_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/languages","stargazers_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/stargazers","contributors_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/contributors","subscribers_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/subscribers","subscription_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/subscription","commits_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/commits{/sha}","git_commits_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/git/commits{/sha}","comments_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/comments{/number}","issue_comment_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/issues/comments{/number}","contents_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/contents/{+path}","compare_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/merges","archive_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/downloads","issues_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/issues{/number}","pulls_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/pulls{/number}","milestones_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/milestones{/number}","notifications_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/labels{/name}","releases_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/releases{/id}","deployments_url":"https://api.github.com/repos/michaelhixson/FrameworkBenchmarks/deployments","created_at":"2017-01-26T23:58:27Z","updated_at":"2017-01-26T23:58:34Z","pushed_at":"2018-02-20T22:07:31Z","git_url":"git://github.com/michaelhixson/FrameworkBenchmarks.git","ssh_url":"git@github.com:michaelhixson/FrameworkBenchmarks.git","clone_url":"https://github.com/michaelhixson/FrameworkBenchmarks.git","svn_url":"https://github.com/michaelhixson/FrameworkBenchmarks","homepage":"http://www.techempower.com/benchmarks/","size":277665,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TechEmpower:docker","ref":"docker","sha":"37fc9ac09ce42e753c9dd63f5b12bb9dede4b833","user":{"login":"TechEmpower","id":3910062,"avatar_url":"https://avatars2.githubusercontent.com/u/3910062?v=4","gravatar_id":"","url":"https://api.github.com/users/TechEmpower","html_url":"https://github.com/TechEmpower","followers_url":"https://api.github.com/users/TechEmpower/followers","following_url":"https://api.github.com/users/TechEmpower/following{/other_user}","gists_url":"https://api.github.com/users/TechEmpower/gists{/gist_id}","starred_url":"https://api.github.com/users/TechEmpower/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TechEmpower/subscriptions","organizations_url":"https://api.github.com/users/TechEmpower/orgs","repos_url":"https://api.github.com/users/TechEmpower/repos","events_url":"https://api.github.com/users/TechEmpower/events{/privacy}","received_events_url":"https://api.github.com/users/TechEmpower/received_events","type":"Organization","site_admin":false},"repo":{"id":8957264,"name":"FrameworkBenchmarks","full_name":"TechEmpower/FrameworkBenchmarks","owner":{"login":"TechEmpower","id":3910062,"avatar_url":"https://avatars2.githubusercontent.com/u/3910062?v=4","gravatar_id":"","url":"https://api.github.com/users/TechEmpower","html_url":"https://github.com/TechEmpower","followers_url":"https://api.github.com/users/TechEmpower/followers","following_url":"https://api.github.com/users/TechEmpower/following{/other_user}","gists_url":"https://api.github.com/users/TechEmpower/gists{/gist_id}","starred_url":"https://api.github.com/users/TechEmpower/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TechEmpower/subscriptions","organizations_url":"https://api.github.com/users/TechEmpower/orgs","repos_url":"https://api.github.com/users/TechEmpower/repos","events_url":"https://api.github.com/users/TechEmpower/events{/privacy}","received_events_url":"https://api.github.com/users/TechEmpower/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TechEmpower/FrameworkBenchmarks","description":"Source for the TechEmpower Framework Benchmarks project","fork":false,"url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks","forks_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/forks","keys_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/teams","hooks_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/hooks","issue_events_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/issues/events{/number}","events_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/events","assignees_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/assignees{/user}","branches_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/branches{/branch}","tags_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/tags","blobs_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/git/refs{/sha}","trees_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/statuses/{sha}","languages_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/languages","stargazers_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/stargazers","contributors_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/contributors","subscribers_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/subscribers","subscription_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/subscription","commits_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/commits{/sha}","git_commits_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/git/commits{/sha}","comments_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/comments{/number}","issue_comment_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/issues/comments{/number}","contents_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/contents/{+path}","compare_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/merges","archive_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/downloads","issues_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/issues{/number}","pulls_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls{/number}","milestones_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/milestones{/number}","notifications_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/labels{/name}","releases_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/releases{/id}","deployments_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/deployments","created_at":"2013-03-22T17:33:54Z","updated_at":"2018-02-20T22:58:44Z","pushed_at":"2018-02-21T00:34:34Z","git_url":"git://github.com/TechEmpower/FrameworkBenchmarks.git","ssh_url":"git@github.com:TechEmpower/FrameworkBenchmarks.git","clone_url":"https://github.com/TechEmpower/FrameworkBenchmarks.git","svn_url":"https://github.com/TechEmpower/FrameworkBenchmarks","homepage":"https://www.techempower.com/benchmarks/","size":270344,"stargazers_count":3059,"watchers_count":3059,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1015,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":1015,"open_issues":22,"watchers":3059,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/3311"},"html":{"href":"https://github.com/TechEmpower/FrameworkBenchmarks/pull/3311"},"issue":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/issues/3311"},"comments":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/issues/3311/comments"},"review_comments":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/3311/comments"},"review_comment":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/3311/commits"},"statuses":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/statuses/4e5b9ee75fd919b938bf70f475cf896445d1c177"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nbrady-techempower"}}