{"action":"created","issue":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/27699","repository_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/27699/labels{/name}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/27699/comments","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/27699/events","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/27699","id":345898964,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0OTA0MDkx","number":27699,"title":"Add location state as an optional parameter for Location types in History and React Router","user":{"login":"gwmccull","id":580060,"node_id":"MDQ6VXNlcjU4MDA2MA==","avatar_url":"https://avatars2.githubusercontent.com/u/580060?v=4","gravatar_id":"","url":"https://api.github.com/users/gwmccull","html_url":"https://github.com/gwmccull","followers_url":"https://api.github.com/users/gwmccull/followers","following_url":"https://api.github.com/users/gwmccull/following{/other_user}","gists_url":"https://api.github.com/users/gwmccull/gists{/gist_id}","starred_url":"https://api.github.com/users/gwmccull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwmccull/subscriptions","organizations_url":"https://api.github.com/users/gwmccull/orgs","repos_url":"https://api.github.com/users/gwmccull/repos","events_url":"https://api.github.com/users/gwmccull/events{/privacy}","received_events_url":"https://api.github.com/users/gwmccull/received_events","type":"User","site_admin":false},"labels":[{"id":397523192,"node_id":"MDU6TGFiZWwzOTc1MjMxOTI=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Awaiting%20reviewer%20feedback","name":"Awaiting reviewer feedback","color":"0052cc","default":false},{"id":684321576,"node_id":"MDU6TGFiZWw2ODQzMjE1NzY=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Popular%20package","name":"Popular package","color":"fbca04","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-07-30T19:21:00Z","updated_at":"2018-08-01T07:16:49Z","closed_at":"2018-07-30T19:38:56Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/27699","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/27699","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/27699.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/27699.patch"},"body":"Please fill in this template.\r\n\r\n- [x] Use a meaningful title for the pull request. Include the name of the package modified.\r\n- [x] Test the change in your own code. (Compile and run.)\r\n- [x] Add or edit tests to reflect the change. (Run with `npm test`.)\r\n- [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).\r\n- [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).\r\n- [x] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).\r\n\r\nSelect one of these and delete the others:\r\n\r\nIf adding a new definition:\r\n- [ ] The package does not already provide its own types, or cannot have its `.d.ts` files generated via `--declaration`\r\n- [ ] If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.\r\n- [ ] Create it with `dts-gen --dt`, not by basing it on an existing project.\r\n- [ ] `tslint.json` should be present, and `tsconfig.json` should have `noImplicitAny`, `noImplicitThis`, `strictNullChecks`, and `strictFunctionTypes` set to `true`.\r\n\r\nIf changing an existing definition:\r\n- [x] Provide a URL to documentation or source code which provides context for the suggested changes: https://reacttraining.com/react-router/native/api/Link/to-object `see documentation for state property of location object`\r\n- [x] Increase the version number in the header if appropriate.\r\n- [ ] If you are making substantial changes, consider adding a `tslint.json` containing `{ \"extends\": \"dtslint/dt.json\" }`.\r\n\r\nIf removing a declaration:\r\n- [ ] If a package was never on DefinitelyTyped, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)\r\n- [ ] Delete the package's directory.\r\n- [ ] Add it to `notNeededPackages.json`.\r\n"},"comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments/409474871","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/27699#issuecomment-409474871","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/27699","id":409474871,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTQ3NDg3MQ==","user":{"login":"sorenhoyer","id":2083553,"node_id":"MDQ6VXNlcjIwODM1NTM=","avatar_url":"https://avatars1.githubusercontent.com/u/2083553?v=4","gravatar_id":"","url":"https://api.github.com/users/sorenhoyer","html_url":"https://github.com/sorenhoyer","followers_url":"https://api.github.com/users/sorenhoyer/followers","following_url":"https://api.github.com/users/sorenhoyer/following{/other_user}","gists_url":"https://api.github.com/users/sorenhoyer/gists{/gist_id}","starred_url":"https://api.github.com/users/sorenhoyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sorenhoyer/subscriptions","organizations_url":"https://api.github.com/users/sorenhoyer/orgs","repos_url":"https://api.github.com/users/sorenhoyer/repos","events_url":"https://api.github.com/users/sorenhoyer/events{/privacy}","received_events_url":"https://api.github.com/users/sorenhoyer/received_events","type":"User","site_admin":false},"created_at":"2018-08-01T07:16:49Z","updated_at":"2018-08-01T07:16:49Z","author_association":"NONE","body":"After 4.0.30 (this change) our builds fail with the error `node_modules/@types/react-router/index.d.ts(69,13): error TS2315: Type 'Locat' is not generic.`. "}}
{"actor":{"display_login":"sorenhoyer"}}