{"action":"created","comment":{"url":"https://api.github.com/repos/apache/arrow/pulls/comments/194169741","pull_request_review_id":127300761,"id":194169741,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDE2OTc0MQ==","diff_hunk":"@@ -107,7 +110,16 @@ class TypeInferrer {\n       } else if (is_floating(type->id())) {\n         ++float_count_;\n       } else if (type->id() == Type::TIMESTAMP) {\n-        ++timestamp_count_;\n+        auto type2 = std::dynamic_pointer_cast<TimestampType>(type);\n+        if (type2->unit() == TimeUnit::NANO) {\n+          ++timestamp_nano_count_;\n+        } else if (type2->unit() == TimeUnit::MICRO) {\n+          ++timestamp_micro_count_;\n+        } else if (type2->unit() == TimeUnit::MILLI) {\n+          ++timestamp_milli_count_;\n+        } else if (type2->unit() == TimeUnit::SECOND) {\n+          ++timestamp_second_count_;\n+        }","path":"cpp/src/arrow/python/builtin_convert.cc","position":35,"original_position":35,"commit_id":"b3ab6e17871e3c14f5f4a6d973398a3c06f11b65","original_commit_id":"b3ab6e17871e3c14f5f4a6d973398a3c06f11b65","user":{"login":"wesm","id":329591,"node_id":"MDQ6VXNlcjMyOTU5MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/329591?v=4","gravatar_id":"","url":"https://api.github.com/users/wesm","html_url":"https://github.com/wesm","followers_url":"https://api.github.com/users/wesm/followers","following_url":"https://api.github.com/users/wesm/following{/other_user}","gists_url":"https://api.github.com/users/wesm/gists{/gist_id}","starred_url":"https://api.github.com/users/wesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesm/subscriptions","organizations_url":"https://api.github.com/users/wesm/orgs","repos_url":"https://api.github.com/users/wesm/repos","events_url":"https://api.github.com/users/wesm/events{/privacy}","received_events_url":"https://api.github.com/users/wesm/received_events","type":"User","site_admin":false},"body":"If the scalar type is some other unit (or unitless? can't remember how we're handling that at the moment) then you should raise in an `else` branch","created_at":"2018-06-08T20:14:57Z","updated_at":"2018-06-08T20:16:12Z","html_url":"https://github.com/apache/arrow/pull/2118#discussion_r194169741","pull_request_url":"https://api.github.com/repos/apache/arrow/pulls/2118","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apache/arrow/pulls/comments/194169741"},"html":{"href":"https://github.com/apache/arrow/pull/2118#discussion_r194169741"},"pull_request":{"href":"https://api.github.com/repos/apache/arrow/pulls/2118"}}},"pull_request":{"url":"https://api.github.com/repos/apache/arrow/pulls/2118","id":193565192,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNTY1MTky","html_url":"https://github.com/apache/arrow/pull/2118","diff_url":"https://github.com/apache/arrow/pull/2118.diff","patch_url":"https://github.com/apache/arrow/pull/2118.patch","issue_url":"https://api.github.com/repos/apache/arrow/issues/2118","number":2118,"state":"open","locked":false,"title":"ARROW-2554: [Python] fix timestamp unit detection from python lists","user":{"login":"crepererum","id":1529400,"node_id":"MDQ6VXNlcjE1Mjk0MDA=","avatar_url":"https://avatars1.githubusercontent.com/u/1529400?v=4","gravatar_id":"","url":"https://api.github.com/users/crepererum","html_url":"https://github.com/crepererum","followers_url":"https://api.github.com/users/crepererum/followers","following_url":"https://api.github.com/users/crepererum/following{/other_user}","gists_url":"https://api.github.com/users/crepererum/gists{/gist_id}","starred_url":"https://api.github.com/users/crepererum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crepererum/subscriptions","organizations_url":"https://api.github.com/users/crepererum/orgs","repos_url":"https://api.github.com/users/crepererum/repos","events_url":"https://api.github.com/users/crepererum/events{/privacy}","received_events_url":"https://api.github.com/users/crepererum/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-08T09:57:16Z","updated_at":"2018-06-08T20:16:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ca6431488cad5bd94d794cacb66c621ce940b578","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/arrow/pulls/2118/commits","review_comments_url":"https://api.github.com/repos/apache/arrow/pulls/2118/comments","review_comment_url":"https://api.github.com/repos/apache/arrow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/arrow/issues/2118/comments","statuses_url":"https://api.github.com/repos/apache/arrow/statuses/b3ab6e17871e3c14f5f4a6d973398a3c06f11b65","head":{"label":"crepererum:ARROW-2554","ref":"ARROW-2554","sha":"b3ab6e17871e3c14f5f4a6d973398a3c06f11b65","user":{"login":"crepererum","id":1529400,"node_id":"MDQ6VXNlcjE1Mjk0MDA=","avatar_url":"https://avatars1.githubusercontent.com/u/1529400?v=4","gravatar_id":"","url":"https://api.github.com/users/crepererum","html_url":"https://github.com/crepererum","followers_url":"https://api.github.com/users/crepererum/followers","following_url":"https://api.github.com/users/crepererum/following{/other_user}","gists_url":"https://api.github.com/users/crepererum/gists{/gist_id}","starred_url":"https://api.github.com/users/crepererum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crepererum/subscriptions","organizations_url":"https://api.github.com/users/crepererum/orgs","repos_url":"https://api.github.com/users/crepererum/repos","events_url":"https://api.github.com/users/crepererum/events{/privacy}","received_events_url":"https://api.github.com/users/crepererum/received_events","type":"User","site_admin":false},"repo":{"id":98651872,"node_id":"MDEwOlJlcG9zaXRvcnk5ODY1MTg3Mg==","name":"arrow","full_name":"crepererum/arrow","owner":{"login":"crepererum","id":1529400,"node_id":"MDQ6VXNlcjE1Mjk0MDA=","avatar_url":"https://avatars1.githubusercontent.com/u/1529400?v=4","gravatar_id":"","url":"https://api.github.com/users/crepererum","html_url":"https://github.com/crepererum","followers_url":"https://api.github.com/users/crepererum/followers","following_url":"https://api.github.com/users/crepererum/following{/other_user}","gists_url":"https://api.github.com/users/crepererum/gists{/gist_id}","starred_url":"https://api.github.com/users/crepererum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crepererum/subscriptions","organizations_url":"https://api.github.com/users/crepererum/orgs","repos_url":"https://api.github.com/users/crepererum/repos","events_url":"https://api.github.com/users/crepererum/events{/privacy}","received_events_url":"https://api.github.com/users/crepererum/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/crepererum/arrow","description":"Apache Arrow is a columnar in-memory analytics layer designed to accelerate big data. It houses a set of canonical in-memory representations of flat and hierarchical data along with multiple language-bindings for structure manipulation. It also provides IPC and common algorithm implementations. ","fork":true,"url":"https://api.github.com/repos/crepererum/arrow","forks_url":"https://api.github.com/repos/crepererum/arrow/forks","keys_url":"https://api.github.com/repos/crepererum/arrow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crepererum/arrow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crepererum/arrow/teams","hooks_url":"https://api.github.com/repos/crepererum/arrow/hooks","issue_events_url":"https://api.github.com/repos/crepererum/arrow/issues/events{/number}","events_url":"https://api.github.com/repos/crepererum/arrow/events","assignees_url":"https://api.github.com/repos/crepererum/arrow/assignees{/user}","branches_url":"https://api.github.com/repos/crepererum/arrow/branches{/branch}","tags_url":"https://api.github.com/repos/crepererum/arrow/tags","blobs_url":"https://api.github.com/repos/crepererum/arrow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crepererum/arrow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crepererum/arrow/git/refs{/sha}","trees_url":"https://api.github.com/repos/crepererum/arrow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crepererum/arrow/statuses/{sha}","languages_url":"https://api.github.com/repos/crepererum/arrow/languages","stargazers_url":"https://api.github.com/repos/crepererum/arrow/stargazers","contributors_url":"https://api.github.com/repos/crepererum/arrow/contributors","subscribers_url":"https://api.github.com/repos/crepererum/arrow/subscribers","subscription_url":"https://api.github.com/repos/crepererum/arrow/subscription","commits_url":"https://api.github.com/repos/crepererum/arrow/commits{/sha}","git_commits_url":"https://api.github.com/repos/crepererum/arrow/git/commits{/sha}","comments_url":"https://api.github.com/repos/crepererum/arrow/comments{/number}","issue_comment_url":"https://api.github.com/repos/crepererum/arrow/issues/comments{/number}","contents_url":"https://api.github.com/repos/crepererum/arrow/contents/{+path}","compare_url":"https://api.github.com/repos/crepererum/arrow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crepererum/arrow/merges","archive_url":"https://api.github.com/repos/crepererum/arrow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crepererum/arrow/downloads","issues_url":"https://api.github.com/repos/crepererum/arrow/issues{/number}","pulls_url":"https://api.github.com/repos/crepererum/arrow/pulls{/number}","milestones_url":"https://api.github.com/repos/crepererum/arrow/milestones{/number}","notifications_url":"https://api.github.com/repos/crepererum/arrow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crepererum/arrow/labels{/name}","releases_url":"https://api.github.com/repos/crepererum/arrow/releases{/id}","deployments_url":"https://api.github.com/repos/crepererum/arrow/deployments","created_at":"2017-07-28T13:25:12Z","updated_at":"2017-07-28T13:25:16Z","pushed_at":"2018-06-08T13:15:18Z","git_url":"git://github.com/crepererum/arrow.git","ssh_url":"git@github.com:crepererum/arrow.git","clone_url":"https://github.com/crepererum/arrow.git","svn_url":"https://github.com/crepererum/arrow","homepage":"https://arrow.apache.org","size":12866,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"e82a34a3cb30a92a5ef00cca74d054e84cee7a6c","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":51905353,"node_id":"MDEwOlJlcG9zaXRvcnk1MTkwNTM1Mw==","name":"arrow","full_name":"apache/arrow","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/arrow","description":"Apache Arrow is a cross-language development platform for in-memory data. It specifies a standardized language-independent columnar memory format for flat and hierarchical data, organized for efficient analytic operations on modern hardware. It also provides computational libraries and zero-copy streaming messaging and interprocess communication. Languages currently supported include C, C++, Java, JavaScript, Python, and Ruby.","fork":false,"url":"https://api.github.com/repos/apache/arrow","forks_url":"https://api.github.com/repos/apache/arrow/forks","keys_url":"https://api.github.com/repos/apache/arrow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/arrow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/arrow/teams","hooks_url":"https://api.github.com/repos/apache/arrow/hooks","issue_events_url":"https://api.github.com/repos/apache/arrow/issues/events{/number}","events_url":"https://api.github.com/repos/apache/arrow/events","assignees_url":"https://api.github.com/repos/apache/arrow/assignees{/user}","branches_url":"https://api.github.com/repos/apache/arrow/branches{/branch}","tags_url":"https://api.github.com/repos/apache/arrow/tags","blobs_url":"https://api.github.com/repos/apache/arrow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/arrow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/arrow/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/arrow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/arrow/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/arrow/languages","stargazers_url":"https://api.github.com/repos/apache/arrow/stargazers","contributors_url":"https://api.github.com/repos/apache/arrow/contributors","subscribers_url":"https://api.github.com/repos/apache/arrow/subscribers","subscription_url":"https://api.github.com/repos/apache/arrow/subscription","commits_url":"https://api.github.com/repos/apache/arrow/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/arrow/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/arrow/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/arrow/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/arrow/contents/{+path}","compare_url":"https://api.github.com/repos/apache/arrow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/arrow/merges","archive_url":"https://api.github.com/repos/apache/arrow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/arrow/downloads","issues_url":"https://api.github.com/repos/apache/arrow/issues{/number}","pulls_url":"https://api.github.com/repos/apache/arrow/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/arrow/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/arrow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/arrow/labels{/name}","releases_url":"https://api.github.com/repos/apache/arrow/releases{/id}","deployments_url":"https://api.github.com/repos/apache/arrow/deployments","created_at":"2016-02-17T08:00:23Z","updated_at":"2018-06-08T19:47:59Z","pushed_at":"2018-06-08T19:47:50Z","git_url":"git://github.com/apache/arrow.git","ssh_url":"git@github.com:apache/arrow.git","clone_url":"https://github.com/apache/arrow.git","svn_url":"https://github.com/apache/arrow","homepage":"https://arrow.apache.org","size":12873,"stargazers_count":2044,"watchers_count":2044,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":566,"mirror_url":null,"archived":false,"open_issues_count":60,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":566,"open_issues":60,"watchers":2044,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/arrow/pulls/2118"},"html":{"href":"https://github.com/apache/arrow/pull/2118"},"issue":{"href":"https://api.github.com/repos/apache/arrow/issues/2118"},"comments":{"href":"https://api.github.com/repos/apache/arrow/issues/2118/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/arrow/pulls/2118/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/arrow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/arrow/pulls/2118/commits"},"statuses":{"href":"https://api.github.com/repos/apache/arrow/statuses/b3ab6e17871e3c14f5f4a6d973398a3c06f11b65"}},"author_association":"NONE"}}
{"actor":{"display_login":"wesm"}}