{"action":"opened","number":3335,"pull_request":{"url":"https://api.github.com/repos/ReactiveX/rxjs/pulls/3335","id":170533836,"html_url":"https://github.com/ReactiveX/rxjs/pull/3335","diff_url":"https://github.com/ReactiveX/rxjs/pull/3335.diff","patch_url":"https://github.com/ReactiveX/rxjs/pull/3335.patch","issue_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/3335","number":3335,"state":"open","locked":false,"title":"fix(toArray): do not mutate array per subscription","user":{"login":"kwonoj","id":1210596,"avatar_url":"https://avatars2.githubusercontent.com/u/1210596?v=4","gravatar_id":"","url":"https://api.github.com/users/kwonoj","html_url":"https://github.com/kwonoj","followers_url":"https://api.github.com/users/kwonoj/followers","following_url":"https://api.github.com/users/kwonoj/following{/other_user}","gists_url":"https://api.github.com/users/kwonoj/gists{/gist_id}","starred_url":"https://api.github.com/users/kwonoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwonoj/subscriptions","organizations_url":"https://api.github.com/users/kwonoj/orgs","repos_url":"https://api.github.com/users/kwonoj/repos","events_url":"https://api.github.com/users/kwonoj/events{/privacy}","received_events_url":"https://api.github.com/users/kwonoj/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you very much for your pull request!\r\n\r\nIf your PR is the addition of a new operator, please make sure all these boxes are ticked with an x:\r\n\r\n- [ ] Add the operator to Rx\r\n- [ ] It must have a `-spec.ts` tests file covering the canonical corner cases, with marble diagram tests\r\n- [ ] If possible, write a `asDiagram` test case too, for PNG diagram generation purposes\r\n- [ ] The spec file should have a type definition test at the end of the spec to verify type definition for various use cases\r\n- [ ] The operator must be documented in JSDoc style in the implementation file, including also the PNG marble diagram image\r\n- [ ] The operator should be listed in `doc/operators.md` in a category of operators\r\n- [ ] The operator should also be documented. See [Documentation Guidelines](../CONTRIBUTING.md).\r\n- [ ] It should also be inserted in the operator decision tree file `doc/decision-tree-widget/tree.yml`\r\n- [ ] You may need to update `MIGRATION.md` if the operator differs from the corresponding one in RxJS v4\r\n-->\r\n\r\n**Description:**\r\nThis is cherry pick changes from master, while v6 alpha fixed it latest v5 doesn't have fixes.\r\n\r\n**Related issue (if exists):**\r\n- closes https://github.com/ReactiveX/rxjs/issues/3141","created_at":"2018-02-21T17:13:37Z","updated_at":"2018-02-21T17:13:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ReactiveX/rxjs/pulls/3335/commits","review_comments_url":"https://api.github.com/repos/ReactiveX/rxjs/pulls/3335/comments","review_comment_url":"https://api.github.com/repos/ReactiveX/rxjs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/3335/comments","statuses_url":"https://api.github.com/repos/ReactiveX/rxjs/statuses/72ded7b4edbe7fe1cec7090b3c527ec105bf9657","head":{"label":"kwonoj:cherry-pick-toarray-fix","ref":"cherry-pick-toarray-fix","sha":"72ded7b4edbe7fe1cec7090b3c527ec105bf9657","user":{"login":"kwonoj","id":1210596,"avatar_url":"https://avatars2.githubusercontent.com/u/1210596?v=4","gravatar_id":"","url":"https://api.github.com/users/kwonoj","html_url":"https://github.com/kwonoj","followers_url":"https://api.github.com/users/kwonoj/followers","following_url":"https://api.github.com/users/kwonoj/following{/other_user}","gists_url":"https://api.github.com/users/kwonoj/gists{/gist_id}","starred_url":"https://api.github.com/users/kwonoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwonoj/subscriptions","organizations_url":"https://api.github.com/users/kwonoj/orgs","repos_url":"https://api.github.com/users/kwonoj/repos","events_url":"https://api.github.com/users/kwonoj/events{/privacy}","received_events_url":"https://api.github.com/users/kwonoj/received_events","type":"User","site_admin":false},"repo":{"id":41501851,"name":"rxjs","full_name":"kwonoj/rxjs","owner":{"login":"kwonoj","id":1210596,"avatar_url":"https://avatars2.githubusercontent.com/u/1210596?v=4","gravatar_id":"","url":"https://api.github.com/users/kwonoj","html_url":"https://github.com/kwonoj","followers_url":"https://api.github.com/users/kwonoj/followers","following_url":"https://api.github.com/users/kwonoj/following{/other_user}","gists_url":"https://api.github.com/users/kwonoj/gists{/gist_id}","starred_url":"https://api.github.com/users/kwonoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwonoj/subscriptions","organizations_url":"https://api.github.com/users/kwonoj/orgs","repos_url":"https://api.github.com/users/kwonoj/repos","events_url":"https://api.github.com/users/kwonoj/events{/privacy}","received_events_url":"https://api.github.com/users/kwonoj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kwonoj/rxjs","description":"A reactive programming library for JavaScript","fork":true,"url":"https://api.github.com/repos/kwonoj/rxjs","forks_url":"https://api.github.com/repos/kwonoj/rxjs/forks","keys_url":"https://api.github.com/repos/kwonoj/rxjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kwonoj/rxjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kwonoj/rxjs/teams","hooks_url":"https://api.github.com/repos/kwonoj/rxjs/hooks","issue_events_url":"https://api.github.com/repos/kwonoj/rxjs/issues/events{/number}","events_url":"https://api.github.com/repos/kwonoj/rxjs/events","assignees_url":"https://api.github.com/repos/kwonoj/rxjs/assignees{/user}","branches_url":"https://api.github.com/repos/kwonoj/rxjs/branches{/branch}","tags_url":"https://api.github.com/repos/kwonoj/rxjs/tags","blobs_url":"https://api.github.com/repos/kwonoj/rxjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kwonoj/rxjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kwonoj/rxjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/kwonoj/rxjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kwonoj/rxjs/statuses/{sha}","languages_url":"https://api.github.com/repos/kwonoj/rxjs/languages","stargazers_url":"https://api.github.com/repos/kwonoj/rxjs/stargazers","contributors_url":"https://api.github.com/repos/kwonoj/rxjs/contributors","subscribers_url":"https://api.github.com/repos/kwonoj/rxjs/subscribers","subscription_url":"https://api.github.com/repos/kwonoj/rxjs/subscription","commits_url":"https://api.github.com/repos/kwonoj/rxjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/kwonoj/rxjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/kwonoj/rxjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/kwonoj/rxjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/kwonoj/rxjs/contents/{+path}","compare_url":"https://api.github.com/repos/kwonoj/rxjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kwonoj/rxjs/merges","archive_url":"https://api.github.com/repos/kwonoj/rxjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kwonoj/rxjs/downloads","issues_url":"https://api.github.com/repos/kwonoj/rxjs/issues{/number}","pulls_url":"https://api.github.com/repos/kwonoj/rxjs/pulls{/number}","milestones_url":"https://api.github.com/repos/kwonoj/rxjs/milestones{/number}","notifications_url":"https://api.github.com/repos/kwonoj/rxjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kwonoj/rxjs/labels{/name}","releases_url":"https://api.github.com/repos/kwonoj/rxjs/releases{/id}","deployments_url":"https://api.github.com/repos/kwonoj/rxjs/deployments","created_at":"2015-08-27T17:41:24Z","updated_at":"2017-04-30T21:11:37Z","pushed_at":"2018-02-21T17:12:49Z","git_url":"git://github.com/kwonoj/rxjs.git","ssh_url":"git@github.com:kwonoj/rxjs.git","clone_url":"https://github.com/kwonoj/rxjs.git","svn_url":"https://github.com/kwonoj/rxjs","homepage":null,"size":8069,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ReactiveX:stable","ref":"stable","sha":"c7e33e43224f8c2292335ecd9d933c3fbd5f9d74","user":{"login":"ReactiveX","id":6407041,"avatar_url":"https://avatars1.githubusercontent.com/u/6407041?v=4","gravatar_id":"","url":"https://api.github.com/users/ReactiveX","html_url":"https://github.com/ReactiveX","followers_url":"https://api.github.com/users/ReactiveX/followers","following_url":"https://api.github.com/users/ReactiveX/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveX/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveX/subscriptions","organizations_url":"https://api.github.com/users/ReactiveX/orgs","repos_url":"https://api.github.com/users/ReactiveX/repos","events_url":"https://api.github.com/users/ReactiveX/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveX/received_events","type":"Organization","site_admin":false},"repo":{"id":32247847,"name":"rxjs","full_name":"ReactiveX/rxjs","owner":{"login":"ReactiveX","id":6407041,"avatar_url":"https://avatars1.githubusercontent.com/u/6407041?v=4","gravatar_id":"","url":"https://api.github.com/users/ReactiveX","html_url":"https://github.com/ReactiveX","followers_url":"https://api.github.com/users/ReactiveX/followers","following_url":"https://api.github.com/users/ReactiveX/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveX/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveX/subscriptions","organizations_url":"https://api.github.com/users/ReactiveX/orgs","repos_url":"https://api.github.com/users/ReactiveX/repos","events_url":"https://api.github.com/users/ReactiveX/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveX/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ReactiveX/rxjs","description":"A reactive programming library for JavaScript","fork":false,"url":"https://api.github.com/repos/ReactiveX/rxjs","forks_url":"https://api.github.com/repos/ReactiveX/rxjs/forks","keys_url":"https://api.github.com/repos/ReactiveX/rxjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ReactiveX/rxjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ReactiveX/rxjs/teams","hooks_url":"https://api.github.com/repos/ReactiveX/rxjs/hooks","issue_events_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/events{/number}","events_url":"https://api.github.com/repos/ReactiveX/rxjs/events","assignees_url":"https://api.github.com/repos/ReactiveX/rxjs/assignees{/user}","branches_url":"https://api.github.com/repos/ReactiveX/rxjs/branches{/branch}","tags_url":"https://api.github.com/repos/ReactiveX/rxjs/tags","blobs_url":"https://api.github.com/repos/ReactiveX/rxjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ReactiveX/rxjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ReactiveX/rxjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ReactiveX/rxjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ReactiveX/rxjs/statuses/{sha}","languages_url":"https://api.github.com/repos/ReactiveX/rxjs/languages","stargazers_url":"https://api.github.com/repos/ReactiveX/rxjs/stargazers","contributors_url":"https://api.github.com/repos/ReactiveX/rxjs/contributors","subscribers_url":"https://api.github.com/repos/ReactiveX/rxjs/subscribers","subscription_url":"https://api.github.com/repos/ReactiveX/rxjs/subscription","commits_url":"https://api.github.com/repos/ReactiveX/rxjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ReactiveX/rxjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ReactiveX/rxjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ReactiveX/rxjs/contents/{+path}","compare_url":"https://api.github.com/repos/ReactiveX/rxjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ReactiveX/rxjs/merges","archive_url":"https://api.github.com/repos/ReactiveX/rxjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ReactiveX/rxjs/downloads","issues_url":"https://api.github.com/repos/ReactiveX/rxjs/issues{/number}","pulls_url":"https://api.github.com/repos/ReactiveX/rxjs/pulls{/number}","milestones_url":"https://api.github.com/repos/ReactiveX/rxjs/milestones{/number}","notifications_url":"https://api.github.com/repos/ReactiveX/rxjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ReactiveX/rxjs/labels{/name}","releases_url":"https://api.github.com/repos/ReactiveX/rxjs/releases{/id}","deployments_url":"https://api.github.com/repos/ReactiveX/rxjs/deployments","created_at":"2015-03-15T06:17:10Z","updated_at":"2018-02-21T17:09:44Z","pushed_at":"2018-02-21T00:15:34Z","git_url":"git://github.com/ReactiveX/rxjs.git","ssh_url":"git@github.com:ReactiveX/rxjs.git","clone_url":"https://github.com/ReactiveX/rxjs.git","svn_url":"https://github.com/ReactiveX/rxjs","homepage":"http://reactivex.io/rxjs","size":85322,"stargazers_count":10845,"watchers_count":10845,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1021,"mirror_url":null,"archived":false,"open_issues_count":293,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1021,"open_issues":293,"watchers":10845,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ReactiveX/rxjs/pulls/3335"},"html":{"href":"https://github.com/ReactiveX/rxjs/pull/3335"},"issue":{"href":"https://api.github.com/repos/ReactiveX/rxjs/issues/3335"},"comments":{"href":"https://api.github.com/repos/ReactiveX/rxjs/issues/3335/comments"},"review_comments":{"href":"https://api.github.com/repos/ReactiveX/rxjs/pulls/3335/comments"},"review_comment":{"href":"https://api.github.com/repos/ReactiveX/rxjs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ReactiveX/rxjs/pulls/3335/commits"},"statuses":{"href":"https://api.github.com/repos/ReactiveX/rxjs/statuses/72ded7b4edbe7fe1cec7090b3c527ec105bf9657"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":3,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"kwonoj"}}