{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/197969188","pull_request_review_id":131815605,"id":197969188,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Nzk2OTE4OA==","diff_hunk":"@@ -98,17 +98,16 @@ def version_check(self):\n         stdout, _, retcode = run_cmd([self.cc[0], \"--vsn\"], redirect=True)\n         msg = None\n         min_ver, max_ver = self.ARMCC_RANGE\n-        first_line = stdout.splitlines()[0]\n-        match = self.ARMCC_VERSION_RE.match(first_line)\n-        if match:\n-            found_version = LooseVersion(match.group(1))\n-            if found_version < min_ver or found_version > max_ver:\n-                msg = (\"Compiler version mismatch: Have {}; \"\n-                       \"expected >= {} < {}\"\n-                       .format(found_version, min_ver, max_ver))\n-        else:\n+        match = self.ARMCC_VERSION_RE.search(stdout)\n+        found_version = LooseVersion(match.group(0)) if match else None\n+        min_ver, max_ver = self.ARM_RANGE\n+        if found_version and (found_version < min_ver or found_version >= max_ver):\n+            msg = (\"Compiler version mismatch: Have {}; \"\n+                   \"expected version >= {} and < {}\"\n+                   .format(found_version, min_ver, max_ver))\n+        elif len(match.groups()) != 1:","path":"tools/toolchains/arm.py","position":null,"original_position":29,"commit_id":"0e56c1805854ca7dc740c0872e9bb1d659a9f6ca","original_commit_id":"1a9474e4d93bdfec093de7056c1f0552f7004c48","user":{"login":"theotherjimmy","id":685409,"node_id":"MDQ6VXNlcjY4NTQwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/685409?v=4","gravatar_id":"","url":"https://api.github.com/users/theotherjimmy","html_url":"https://github.com/theotherjimmy","followers_url":"https://api.github.com/users/theotherjimmy/followers","following_url":"https://api.github.com/users/theotherjimmy/following{/other_user}","gists_url":"https://api.github.com/users/theotherjimmy/gists{/gist_id}","starred_url":"https://api.github.com/users/theotherjimmy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theotherjimmy/subscriptions","organizations_url":"https://api.github.com/users/theotherjimmy/orgs","repos_url":"https://api.github.com/users/theotherjimmy/repos","events_url":"https://api.github.com/users/theotherjimmy/events{/privacy}","received_events_url":"https://api.github.com/users/theotherjimmy/received_events","type":"User","site_admin":false},"body":"Actually, I think this is correct.","created_at":"2018-06-25T23:04:52Z","updated_at":"2018-06-25T23:04:52Z","html_url":"https://github.com/ARMmbed/mbed-os/pull/7247#discussion_r197969188","pull_request_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/7247","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/197969188"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/7247#discussion_r197969188"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/7247"}},"in_reply_to_id":197921372},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/7247","id":195619416,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NjE5NDE2","html_url":"https://github.com/ARMmbed/mbed-os/pull/7247","diff_url":"https://github.com/ARMmbed/mbed-os/pull/7247.diff","patch_url":"https://github.com/ARMmbed/mbed-os/pull/7247.patch","issue_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/7247","number":7247,"state":"open","locked":false,"title":"Tools: Check compiler version","user":{"login":"theotherjimmy","id":685409,"node_id":"MDQ6VXNlcjY4NTQwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/685409?v=4","gravatar_id":"","url":"https://api.github.com/users/theotherjimmy","html_url":"https://github.com/theotherjimmy","followers_url":"https://api.github.com/users/theotherjimmy/followers","following_url":"https://api.github.com/users/theotherjimmy/following{/other_user}","gists_url":"https://api.github.com/users/theotherjimmy/gists{/gist_id}","starred_url":"https://api.github.com/users/theotherjimmy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theotherjimmy/subscriptions","organizations_url":"https://api.github.com/users/theotherjimmy/orgs","repos_url":"https://api.github.com/users/theotherjimmy/repos","events_url":"https://api.github.com/users/theotherjimmy/events{/privacy}","received_events_url":"https://api.github.com/users/theotherjimmy/received_events","type":"User","site_admin":false},"body":"### Description\n\nIn the past, we allowed any version of any toolchain. That will be a \nproblem if/when we upgrade to ARM Compiler 5.10 or IAR 8. This PR\nhas the tools enforce the version of the compiler on `mbed compile`,\npreventing any issues with compiler version\n\n### Pull request type\n\n    [x] Fix\n    [ ] Refactor\n    [ ] New target\n    [ ] Feature\n    [ ] Breaking change","created_at":"2018-06-18T19:06:21Z","updated_at":"2018-06-25T23:04:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"accc267aa09da4821fc63e91d34b8acc09df7cec","assignee":null,"assignees":[],"requested_reviewers":[{"login":"SenRamakri","id":31017510,"node_id":"MDQ6VXNlcjMxMDE3NTEw","avatar_url":"https://avatars0.githubusercontent.com/u/31017510?v=4","gravatar_id":"","url":"https://api.github.com/users/SenRamakri","html_url":"https://github.com/SenRamakri","followers_url":"https://api.github.com/users/SenRamakri/followers","following_url":"https://api.github.com/users/SenRamakri/following{/other_user}","gists_url":"https://api.github.com/users/SenRamakri/gists{/gist_id}","starred_url":"https://api.github.com/users/SenRamakri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SenRamakri/subscriptions","organizations_url":"https://api.github.com/users/SenRamakri/orgs","repos_url":"https://api.github.com/users/SenRamakri/repos","events_url":"https://api.github.com/users/SenRamakri/events{/privacy}","received_events_url":"https://api.github.com/users/SenRamakri/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":147112891,"node_id":"MDU6TGFiZWwxNDcxMTI4OTE=","url":"https://api.github.com/repos/ARMmbed/mbed-os/labels/needs:%20review","name":"needs: review","color":"fbca04","default":false},{"id":965671858,"node_id":"MDU6TGFiZWw5NjU2NzE4NTg=","url":"https://api.github.com/repos/ARMmbed/mbed-os/labels/release-version:%205.9.2","name":"release-version: 5.9.2","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/7247/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/7247/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/7247/comments","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/0e56c1805854ca7dc740c0872e9bb1d659a9f6ca","head":{"label":"theotherjimmy:toolchain-version-check","ref":"toolchain-version-check","sha":"0e56c1805854ca7dc740c0872e9bb1d659a9f6ca","user":{"login":"theotherjimmy","id":685409,"node_id":"MDQ6VXNlcjY4NTQwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/685409?v=4","gravatar_id":"","url":"https://api.github.com/users/theotherjimmy","html_url":"https://github.com/theotherjimmy","followers_url":"https://api.github.com/users/theotherjimmy/followers","following_url":"https://api.github.com/users/theotherjimmy/following{/other_user}","gists_url":"https://api.github.com/users/theotherjimmy/gists{/gist_id}","starred_url":"https://api.github.com/users/theotherjimmy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theotherjimmy/subscriptions","organizations_url":"https://api.github.com/users/theotherjimmy/orgs","repos_url":"https://api.github.com/users/theotherjimmy/repos","events_url":"https://api.github.com/users/theotherjimmy/events{/privacy}","received_events_url":"https://api.github.com/users/theotherjimmy/received_events","type":"User","site_admin":false},"repo":{"id":59587271,"node_id":"MDEwOlJlcG9zaXRvcnk1OTU4NzI3MQ==","name":"mbed","full_name":"theotherjimmy/mbed","owner":{"login":"theotherjimmy","id":685409,"node_id":"MDQ6VXNlcjY4NTQwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/685409?v=4","gravatar_id":"","url":"https://api.github.com/users/theotherjimmy","html_url":"https://github.com/theotherjimmy","followers_url":"https://api.github.com/users/theotherjimmy/followers","following_url":"https://api.github.com/users/theotherjimmy/following{/other_user}","gists_url":"https://api.github.com/users/theotherjimmy/gists{/gist_id}","starred_url":"https://api.github.com/users/theotherjimmy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theotherjimmy/subscriptions","organizations_url":"https://api.github.com/users/theotherjimmy/orgs","repos_url":"https://api.github.com/users/theotherjimmy/repos","events_url":"https://api.github.com/users/theotherjimmy/events{/privacy}","received_events_url":"https://api.github.com/users/theotherjimmy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/theotherjimmy/mbed","description":"mbed libraries and tools (Classic). For mbed OS, look here: https://www.mbed.com/en/development/software/mbed-os/","fork":true,"url":"https://api.github.com/repos/theotherjimmy/mbed","forks_url":"https://api.github.com/repos/theotherjimmy/mbed/forks","keys_url":"https://api.github.com/repos/theotherjimmy/mbed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theotherjimmy/mbed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theotherjimmy/mbed/teams","hooks_url":"https://api.github.com/repos/theotherjimmy/mbed/hooks","issue_events_url":"https://api.github.com/repos/theotherjimmy/mbed/issues/events{/number}","events_url":"https://api.github.com/repos/theotherjimmy/mbed/events","assignees_url":"https://api.github.com/repos/theotherjimmy/mbed/assignees{/user}","branches_url":"https://api.github.com/repos/theotherjimmy/mbed/branches{/branch}","tags_url":"https://api.github.com/repos/theotherjimmy/mbed/tags","blobs_url":"https://api.github.com/repos/theotherjimmy/mbed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theotherjimmy/mbed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theotherjimmy/mbed/git/refs{/sha}","trees_url":"https://api.github.com/repos/theotherjimmy/mbed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theotherjimmy/mbed/statuses/{sha}","languages_url":"https://api.github.com/repos/theotherjimmy/mbed/languages","stargazers_url":"https://api.github.com/repos/theotherjimmy/mbed/stargazers","contributors_url":"https://api.github.com/repos/theotherjimmy/mbed/contributors","subscribers_url":"https://api.github.com/repos/theotherjimmy/mbed/subscribers","subscription_url":"https://api.github.com/repos/theotherjimmy/mbed/subscription","commits_url":"https://api.github.com/repos/theotherjimmy/mbed/commits{/sha}","git_commits_url":"https://api.github.com/repos/theotherjimmy/mbed/git/commits{/sha}","comments_url":"https://api.github.com/repos/theotherjimmy/mbed/comments{/number}","issue_comment_url":"https://api.github.com/repos/theotherjimmy/mbed/issues/comments{/number}","contents_url":"https://api.github.com/repos/theotherjimmy/mbed/contents/{+path}","compare_url":"https://api.github.com/repos/theotherjimmy/mbed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theotherjimmy/mbed/merges","archive_url":"https://api.github.com/repos/theotherjimmy/mbed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theotherjimmy/mbed/downloads","issues_url":"https://api.github.com/repos/theotherjimmy/mbed/issues{/number}","pulls_url":"https://api.github.com/repos/theotherjimmy/mbed/pulls{/number}","milestones_url":"https://api.github.com/repos/theotherjimmy/mbed/milestones{/number}","notifications_url":"https://api.github.com/repos/theotherjimmy/mbed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theotherjimmy/mbed/labels{/name}","releases_url":"https://api.github.com/repos/theotherjimmy/mbed/releases{/id}","deployments_url":"https://api.github.com/repos/theotherjimmy/mbed/deployments","created_at":"2016-05-24T15:53:58Z","updated_at":"2016-05-24T15:54:55Z","pushed_at":"2018-06-25T23:04:40Z","git_url":"git://github.com/theotherjimmy/mbed.git","ssh_url":"git@github.com:theotherjimmy/mbed.git","clone_url":"https://github.com/theotherjimmy/mbed.git","svn_url":"https://github.com/theotherjimmy/mbed","homepage":"","size":218036,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ARMmbed:master","ref":"master","sha":"701d49d8eb647315ecab19884a7d7252042c8c8d","user":{"login":"ARMmbed","id":8916057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MTYwNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":8270972,"node_id":"MDEwOlJlcG9zaXRvcnk4MjcwOTcy","name":"mbed-os","full_name":"ARMmbed/mbed-os","owner":{"login":"ARMmbed","id":8916057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MTYwNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/mbed-os","description":"ARM Mbed OS is a platform operating system designed for the internet of things","fork":false,"url":"https://api.github.com/repos/ARMmbed/mbed-os","forks_url":"https://api.github.com/repos/ARMmbed/mbed-os/forks","keys_url":"https://api.github.com/repos/ARMmbed/mbed-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/mbed-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/mbed-os/teams","hooks_url":"https://api.github.com/repos/ARMmbed/mbed-os/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/mbed-os/events","assignees_url":"https://api.github.com/repos/ARMmbed/mbed-os/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/mbed-os/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/tags","blobs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/mbed-os/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/mbed-os/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/mbed-os/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscription","commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/mbed-os/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/mbed-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/mbed-os/merges","archive_url":"https://api.github.com/repos/ARMmbed/mbed-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/mbed-os/downloads","issues_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/mbed-os/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/mbed-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/mbed-os/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/mbed-os/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/mbed-os/deployments","created_at":"2013-02-18T15:23:11Z","updated_at":"2018-06-25T17:09:25Z","pushed_at":"2018-06-25T23:04:42Z","git_url":"git://github.com/ARMmbed/mbed-os.git","ssh_url":"git@github.com:ARMmbed/mbed-os.git","clone_url":"https://github.com/ARMmbed/mbed-os.git","svn_url":"https://github.com/ARMmbed/mbed-os","homepage":"https://mbed.com","size":216983,"stargazers_count":1710,"watchers_count":1710,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1486,"mirror_url":null,"archived":false,"open_issues_count":402,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1486,"open_issues":402,"watchers":1710,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/7247"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/7247"},"issue":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/7247"},"comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/7247/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/7247/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/7247/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/0e56c1805854ca7dc740c0872e9bb1d659a9f6ca"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"theotherjimmy"}}