{"action":"created","comment":{"url":"https://api.github.com/repos/opesci/devito/pulls/comments/169998105","pull_request_review_id":98612277,"id":169998105,"diff_hunk":"@@ -1010,8 +1010,17 @@ def argument_defaults(self, alias=None):\n \n         :param alias: (Optional) name under which to store values.\n         \"\"\"\n-        args = super(SparseFunction, self).argument_defaults(alias=alias)\n-        args.update(self.coordinates.argument_defaults())\n+        key_name = self.name if alias is None else alias.name or self.name\n+        key_indices = self.indices if alias is None else alias.indices\n+        key_coords = self.coordinates.name if alias is None else alias.coordinates.name\n+\n+        args = ArgumentMap({key_name: self._data_buffer})","path":"devito/function.py","position":10,"original_position":10,"commit_id":"f3734eb6fc53bbfa384ef026dfbfad2e666e2c5a","original_commit_id":"dbfa3e063c1df52c0bc14f13565462557e00fe70","user":{"login":"mloubout","id":5702350,"avatar_url":"https://avatars3.githubusercontent.com/u/5702350?v=4","gravatar_id":"","url":"https://api.github.com/users/mloubout","html_url":"https://github.com/mloubout","followers_url":"https://api.github.com/users/mloubout/followers","following_url":"https://api.github.com/users/mloubout/following{/other_user}","gists_url":"https://api.github.com/users/mloubout/gists{/gist_id}","starred_url":"https://api.github.com/users/mloubout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mloubout/subscriptions","organizations_url":"https://api.github.com/users/mloubout/orgs","repos_url":"https://api.github.com/users/mloubout/repos","events_url":"https://api.github.com/users/mloubout/events{/privacy}","received_events_url":"https://api.github.com/users/mloubout/received_events","type":"User","site_admin":false},"body":"`super` is what was part of the problem creating a bunch of wrong arguments as it only takes the name but does not know about name dependent indices.","created_at":"2018-02-22T15:40:42Z","updated_at":"2018-02-22T15:40:42Z","html_url":"https://github.com/opesci/devito/pull/494#discussion_r169998105","pull_request_url":"https://api.github.com/repos/opesci/devito/pulls/494","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/opesci/devito/pulls/comments/169998105"},"html":{"href":"https://github.com/opesci/devito/pull/494#discussion_r169998105"},"pull_request":{"href":"https://api.github.com/repos/opesci/devito/pulls/494"}},"in_reply_to_id":169554164},"pull_request":{"url":"https://api.github.com/repos/opesci/devito/pulls/494","id":170269115,"html_url":"https://github.com/opesci/devito/pull/494","diff_url":"https://github.com/opesci/devito/pull/494.diff","patch_url":"https://github.com/opesci/devito/pull/494.patch","issue_url":"https://api.github.com/repos/opesci/devito/issues/494","number":494,"state":"open","locked":false,"title":"Aliasing hotfix","user":{"login":"mloubout","id":5702350,"avatar_url":"https://avatars3.githubusercontent.com/u/5702350?v=4","gravatar_id":"","url":"https://api.github.com/users/mloubout","html_url":"https://github.com/mloubout","followers_url":"https://api.github.com/users/mloubout/followers","following_url":"https://api.github.com/users/mloubout/following{/other_user}","gists_url":"https://api.github.com/users/mloubout/gists{/gist_id}","starred_url":"https://api.github.com/users/mloubout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mloubout/subscriptions","organizations_url":"https://api.github.com/users/mloubout/orgs","repos_url":"https://api.github.com/users/mloubout/repos","events_url":"https://api.github.com/users/mloubout/events{/privacy}","received_events_url":"https://api.github.com/users/mloubout/received_events","type":"User","site_admin":false},"body":"This small PR fixes  the aliasing for SparseFunction that was only working on its name and coordinate name.\r\n\r\nSparseFunction have a `p%name` dimension that needs to be properly addressed too and is done here.","created_at":"2018-02-20T18:13:11Z","updated_at":"2018-02-22T15:40:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8325d15f1e2f884030d7881bda6cb48ac735ff46","assignee":null,"assignees":[],"requested_reviewers":[{"login":"navjotk","id":679809,"avatar_url":"https://avatars0.githubusercontent.com/u/679809?v=4","gravatar_id":"","url":"https://api.github.com/users/navjotk","html_url":"https://github.com/navjotk","followers_url":"https://api.github.com/users/navjotk/followers","following_url":"https://api.github.com/users/navjotk/following{/other_user}","gists_url":"https://api.github.com/users/navjotk/gists{/gist_id}","starred_url":"https://api.github.com/users/navjotk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/navjotk/subscriptions","organizations_url":"https://api.github.com/users/navjotk/orgs","repos_url":"https://api.github.com/users/navjotk/repos","events_url":"https://api.github.com/users/navjotk/events{/privacy}","received_events_url":"https://api.github.com/users/navjotk/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/opesci/devito/pulls/494/commits","review_comments_url":"https://api.github.com/repos/opesci/devito/pulls/494/comments","review_comment_url":"https://api.github.com/repos/opesci/devito/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opesci/devito/issues/494/comments","statuses_url":"https://api.github.com/repos/opesci/devito/statuses/f3734eb6fc53bbfa384ef026dfbfad2e666e2c5a","head":{"label":"opesci:sparse-aliasing","ref":"sparse-aliasing","sha":"f3734eb6fc53bbfa384ef026dfbfad2e666e2c5a","user":{"login":"opesci","id":10018551,"avatar_url":"https://avatars1.githubusercontent.com/u/10018551?v=4","gravatar_id":"","url":"https://api.github.com/users/opesci","html_url":"https://github.com/opesci","followers_url":"https://api.github.com/users/opesci/followers","following_url":"https://api.github.com/users/opesci/following{/other_user}","gists_url":"https://api.github.com/users/opesci/gists{/gist_id}","starred_url":"https://api.github.com/users/opesci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opesci/subscriptions","organizations_url":"https://api.github.com/users/opesci/orgs","repos_url":"https://api.github.com/users/opesci/repos","events_url":"https://api.github.com/users/opesci/events{/privacy}","received_events_url":"https://api.github.com/users/opesci/received_events","type":"Organization","site_admin":false},"repo":{"id":54585666,"name":"devito","full_name":"opesci/devito","owner":{"login":"opesci","id":10018551,"avatar_url":"https://avatars1.githubusercontent.com/u/10018551?v=4","gravatar_id":"","url":"https://api.github.com/users/opesci","html_url":"https://github.com/opesci","followers_url":"https://api.github.com/users/opesci/followers","following_url":"https://api.github.com/users/opesci/following{/other_user}","gists_url":"https://api.github.com/users/opesci/gists{/gist_id}","starred_url":"https://api.github.com/users/opesci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opesci/subscriptions","organizations_url":"https://api.github.com/users/opesci/orgs","repos_url":"https://api.github.com/users/opesci/repos","events_url":"https://api.github.com/users/opesci/events{/privacy}","received_events_url":"https://api.github.com/users/opesci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opesci/devito","description":"Code generation framework for automated finite difference computation","fork":false,"url":"https://api.github.com/repos/opesci/devito","forks_url":"https://api.github.com/repos/opesci/devito/forks","keys_url":"https://api.github.com/repos/opesci/devito/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opesci/devito/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opesci/devito/teams","hooks_url":"https://api.github.com/repos/opesci/devito/hooks","issue_events_url":"https://api.github.com/repos/opesci/devito/issues/events{/number}","events_url":"https://api.github.com/repos/opesci/devito/events","assignees_url":"https://api.github.com/repos/opesci/devito/assignees{/user}","branches_url":"https://api.github.com/repos/opesci/devito/branches{/branch}","tags_url":"https://api.github.com/repos/opesci/devito/tags","blobs_url":"https://api.github.com/repos/opesci/devito/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opesci/devito/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opesci/devito/git/refs{/sha}","trees_url":"https://api.github.com/repos/opesci/devito/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opesci/devito/statuses/{sha}","languages_url":"https://api.github.com/repos/opesci/devito/languages","stargazers_url":"https://api.github.com/repos/opesci/devito/stargazers","contributors_url":"https://api.github.com/repos/opesci/devito/contributors","subscribers_url":"https://api.github.com/repos/opesci/devito/subscribers","subscription_url":"https://api.github.com/repos/opesci/devito/subscription","commits_url":"https://api.github.com/repos/opesci/devito/commits{/sha}","git_commits_url":"https://api.github.com/repos/opesci/devito/git/commits{/sha}","comments_url":"https://api.github.com/repos/opesci/devito/comments{/number}","issue_comment_url":"https://api.github.com/repos/opesci/devito/issues/comments{/number}","contents_url":"https://api.github.com/repos/opesci/devito/contents/{+path}","compare_url":"https://api.github.com/repos/opesci/devito/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opesci/devito/merges","archive_url":"https://api.github.com/repos/opesci/devito/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opesci/devito/downloads","issues_url":"https://api.github.com/repos/opesci/devito/issues{/number}","pulls_url":"https://api.github.com/repos/opesci/devito/pulls{/number}","milestones_url":"https://api.github.com/repos/opesci/devito/milestones{/number}","notifications_url":"https://api.github.com/repos/opesci/devito/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opesci/devito/labels{/name}","releases_url":"https://api.github.com/repos/opesci/devito/releases{/id}","deployments_url":"https://api.github.com/repos/opesci/devito/deployments","created_at":"2016-03-23T18:59:49Z","updated_at":"2018-02-19T02:21:26Z","pushed_at":"2018-02-22T13:11:28Z","git_url":"git://github.com/opesci/devito.git","ssh_url":"git@github.com:opesci/devito.git","clone_url":"https://github.com/opesci/devito.git","svn_url":"https://github.com/opesci/devito","homepage":"http://www.opesci.org/devito-public","size":43298,"stargazers_count":46,"watchers_count":46,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":10,"open_issues":30,"watchers":46,"default_branch":"master"}},"base":{"label":"opesci:master","ref":"master","sha":"6896b27fc991d7ddfaf6ddf5a09548676f9278d1","user":{"login":"opesci","id":10018551,"avatar_url":"https://avatars1.githubusercontent.com/u/10018551?v=4","gravatar_id":"","url":"https://api.github.com/users/opesci","html_url":"https://github.com/opesci","followers_url":"https://api.github.com/users/opesci/followers","following_url":"https://api.github.com/users/opesci/following{/other_user}","gists_url":"https://api.github.com/users/opesci/gists{/gist_id}","starred_url":"https://api.github.com/users/opesci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opesci/subscriptions","organizations_url":"https://api.github.com/users/opesci/orgs","repos_url":"https://api.github.com/users/opesci/repos","events_url":"https://api.github.com/users/opesci/events{/privacy}","received_events_url":"https://api.github.com/users/opesci/received_events","type":"Organization","site_admin":false},"repo":{"id":54585666,"name":"devito","full_name":"opesci/devito","owner":{"login":"opesci","id":10018551,"avatar_url":"https://avatars1.githubusercontent.com/u/10018551?v=4","gravatar_id":"","url":"https://api.github.com/users/opesci","html_url":"https://github.com/opesci","followers_url":"https://api.github.com/users/opesci/followers","following_url":"https://api.github.com/users/opesci/following{/other_user}","gists_url":"https://api.github.com/users/opesci/gists{/gist_id}","starred_url":"https://api.github.com/users/opesci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opesci/subscriptions","organizations_url":"https://api.github.com/users/opesci/orgs","repos_url":"https://api.github.com/users/opesci/repos","events_url":"https://api.github.com/users/opesci/events{/privacy}","received_events_url":"https://api.github.com/users/opesci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opesci/devito","description":"Code generation framework for automated finite difference computation","fork":false,"url":"https://api.github.com/repos/opesci/devito","forks_url":"https://api.github.com/repos/opesci/devito/forks","keys_url":"https://api.github.com/repos/opesci/devito/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opesci/devito/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opesci/devito/teams","hooks_url":"https://api.github.com/repos/opesci/devito/hooks","issue_events_url":"https://api.github.com/repos/opesci/devito/issues/events{/number}","events_url":"https://api.github.com/repos/opesci/devito/events","assignees_url":"https://api.github.com/repos/opesci/devito/assignees{/user}","branches_url":"https://api.github.com/repos/opesci/devito/branches{/branch}","tags_url":"https://api.github.com/repos/opesci/devito/tags","blobs_url":"https://api.github.com/repos/opesci/devito/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opesci/devito/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opesci/devito/git/refs{/sha}","trees_url":"https://api.github.com/repos/opesci/devito/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opesci/devito/statuses/{sha}","languages_url":"https://api.github.com/repos/opesci/devito/languages","stargazers_url":"https://api.github.com/repos/opesci/devito/stargazers","contributors_url":"https://api.github.com/repos/opesci/devito/contributors","subscribers_url":"https://api.github.com/repos/opesci/devito/subscribers","subscription_url":"https://api.github.com/repos/opesci/devito/subscription","commits_url":"https://api.github.com/repos/opesci/devito/commits{/sha}","git_commits_url":"https://api.github.com/repos/opesci/devito/git/commits{/sha}","comments_url":"https://api.github.com/repos/opesci/devito/comments{/number}","issue_comment_url":"https://api.github.com/repos/opesci/devito/issues/comments{/number}","contents_url":"https://api.github.com/repos/opesci/devito/contents/{+path}","compare_url":"https://api.github.com/repos/opesci/devito/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opesci/devito/merges","archive_url":"https://api.github.com/repos/opesci/devito/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opesci/devito/downloads","issues_url":"https://api.github.com/repos/opesci/devito/issues{/number}","pulls_url":"https://api.github.com/repos/opesci/devito/pulls{/number}","milestones_url":"https://api.github.com/repos/opesci/devito/milestones{/number}","notifications_url":"https://api.github.com/repos/opesci/devito/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opesci/devito/labels{/name}","releases_url":"https://api.github.com/repos/opesci/devito/releases{/id}","deployments_url":"https://api.github.com/repos/opesci/devito/deployments","created_at":"2016-03-23T18:59:49Z","updated_at":"2018-02-19T02:21:26Z","pushed_at":"2018-02-22T13:11:28Z","git_url":"git://github.com/opesci/devito.git","ssh_url":"git@github.com:opesci/devito.git","clone_url":"https://github.com/opesci/devito.git","svn_url":"https://github.com/opesci/devito","homepage":"http://www.opesci.org/devito-public","size":43298,"stargazers_count":46,"watchers_count":46,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":10,"open_issues":30,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opesci/devito/pulls/494"},"html":{"href":"https://github.com/opesci/devito/pull/494"},"issue":{"href":"https://api.github.com/repos/opesci/devito/issues/494"},"comments":{"href":"https://api.github.com/repos/opesci/devito/issues/494/comments"},"review_comments":{"href":"https://api.github.com/repos/opesci/devito/pulls/494/comments"},"review_comment":{"href":"https://api.github.com/repos/opesci/devito/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opesci/devito/pulls/494/commits"},"statuses":{"href":"https://api.github.com/repos/opesci/devito/statuses/f3734eb6fc53bbfa384ef026dfbfad2e666e2c5a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mloubout"}}