{"action":"opened","number":12661,"pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12661","id":171234520,"html_url":"https://github.com/home-assistant/home-assistant/pull/12661","diff_url":"https://github.com/home-assistant/home-assistant/pull/12661.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/12661.patch","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/12661","number":12661,"state":"open","locked":false,"title":"Fix Citybikes naming.","user":{"login":"aronsky","id":4709644,"avatar_url":"https://avatars3.githubusercontent.com/u/4709644?v=4","gravatar_id":"","url":"https://api.github.com/users/aronsky","html_url":"https://github.com/aronsky","followers_url":"https://api.github.com/users/aronsky/followers","following_url":"https://api.github.com/users/aronsky/following{/other_user}","gists_url":"https://api.github.com/users/aronsky/gists{/gist_id}","starred_url":"https://api.github.com/users/aronsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aronsky/subscriptions","organizations_url":"https://api.github.com/users/aronsky/orgs","repos_url":"https://api.github.com/users/aronsky/repos","events_url":"https://api.github.com/users/aronsky/events{/privacy}","received_events_url":"https://api.github.com/users/aronsky/received_events","type":"User","site_admin":false},"body":"## Description:\r\n\r\nThe recent changes in Home Assistant core broke the naming scheme for CityBikes sensors. This PR fixes the naming.\r\n\r\nBasically, up until now, Citybikes assigned each bike-sharing station a name based on the network and station IDs, to be used by HASS for generation of the entity ID of the station. The friendly name attribute was used to provide a nice, readable alternative to this ID.\r\n\r\nHowever, following some recent changes (I believe PR #12237), the custom friendly name seems to be discarded by HASS, if the name attribute exists.\r\n\r\nIn over to overcome this, Citybikes now provides an `entity_id` property based on the previous template of network ID and station ID, while the `name` property is used to provide a friendly name, when available.\r\n\r\nThis change may be breaking, depending on user configuration, as the user-configurable name of the station cluster is not incorporated in the entity ID anymore.\r\n\r\n\r\n**Related issue (if applicable):**\r\nNo issue was created, a direct fix is proposed here instead.\r\n\r\n## Checklist:\r\n  - [X] The code change is tested and works locally.\r\n  - [X] Local tests with `tox` run successfully. **Your PR cannot be merged unless tests pass**\r\n","created_at":"2018-02-25T15:10:24Z","updated_at":"2018-02-25T15:10:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12661/commits","review_comments_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12661/comments","review_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/12661/comments","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/8b12c303b4c2ec4b4413519f624be188bc570cfd","head":{"label":"aronsky:citybikes-fix-friendly-names","ref":"citybikes-fix-friendly-names","sha":"8b12c303b4c2ec4b4413519f624be188bc570cfd","user":{"login":"aronsky","id":4709644,"avatar_url":"https://avatars3.githubusercontent.com/u/4709644?v=4","gravatar_id":"","url":"https://api.github.com/users/aronsky","html_url":"https://github.com/aronsky","followers_url":"https://api.github.com/users/aronsky/followers","following_url":"https://api.github.com/users/aronsky/following{/other_user}","gists_url":"https://api.github.com/users/aronsky/gists{/gist_id}","starred_url":"https://api.github.com/users/aronsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aronsky/subscriptions","organizations_url":"https://api.github.com/users/aronsky/orgs","repos_url":"https://api.github.com/users/aronsky/repos","events_url":"https://api.github.com/users/aronsky/events{/privacy}","received_events_url":"https://api.github.com/users/aronsky/received_events","type":"User","site_admin":false},"repo":{"id":81301357,"name":"home-assistant","full_name":"aronsky/home-assistant","owner":{"login":"aronsky","id":4709644,"avatar_url":"https://avatars3.githubusercontent.com/u/4709644?v=4","gravatar_id":"","url":"https://api.github.com/users/aronsky","html_url":"https://github.com/aronsky","followers_url":"https://api.github.com/users/aronsky/followers","following_url":"https://api.github.com/users/aronsky/following{/other_user}","gists_url":"https://api.github.com/users/aronsky/gists{/gist_id}","starred_url":"https://api.github.com/users/aronsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aronsky/subscriptions","organizations_url":"https://api.github.com/users/aronsky/orgs","repos_url":"https://api.github.com/users/aronsky/repos","events_url":"https://api.github.com/users/aronsky/events{/privacy}","received_events_url":"https://api.github.com/users/aronsky/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aronsky/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":true,"url":"https://api.github.com/repos/aronsky/home-assistant","forks_url":"https://api.github.com/repos/aronsky/home-assistant/forks","keys_url":"https://api.github.com/repos/aronsky/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aronsky/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aronsky/home-assistant/teams","hooks_url":"https://api.github.com/repos/aronsky/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/aronsky/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/aronsky/home-assistant/events","assignees_url":"https://api.github.com/repos/aronsky/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/aronsky/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/aronsky/home-assistant/tags","blobs_url":"https://api.github.com/repos/aronsky/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aronsky/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aronsky/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/aronsky/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aronsky/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/aronsky/home-assistant/languages","stargazers_url":"https://api.github.com/repos/aronsky/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/aronsky/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/aronsky/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/aronsky/home-assistant/subscription","commits_url":"https://api.github.com/repos/aronsky/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/aronsky/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/aronsky/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/aronsky/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/aronsky/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/aronsky/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aronsky/home-assistant/merges","archive_url":"https://api.github.com/repos/aronsky/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aronsky/home-assistant/downloads","issues_url":"https://api.github.com/repos/aronsky/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/aronsky/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/aronsky/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/aronsky/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aronsky/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/aronsky/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/aronsky/home-assistant/deployments","created_at":"2017-02-08T07:35:05Z","updated_at":"2017-02-08T07:35:10Z","pushed_at":"2018-02-25T14:58:10Z","git_url":"git://github.com/aronsky/home-assistant.git","ssh_url":"git@github.com:aronsky/home-assistant.git","clone_url":"https://github.com/aronsky/home-assistant.git","svn_url":"https://github.com/aronsky/home-assistant","homepage":"https://home-assistant.io","size":78924,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"home-assistant:dev","ref":"dev","sha":"63552abce501ab0fe5a6f01f5a8a765b1fd97fb2","user":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":12888993,"name":"home-assistant","full_name":"home-assistant/home-assistant","owner":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/home-assistant/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant","forks_url":"https://api.github.com/repos/home-assistant/home-assistant/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant/deployments","created_at":"2013-09-17T07:29:48Z","updated_at":"2018-02-25T15:00:53Z","pushed_at":"2018-02-25T15:05:39Z","git_url":"git://github.com/home-assistant/home-assistant.git","ssh_url":"git@github.com:home-assistant/home-assistant.git","clone_url":"https://github.com/home-assistant/home-assistant.git","svn_url":"https://github.com/home-assistant/home-assistant","homepage":"https://home-assistant.io","size":78965,"stargazers_count":12782,"watchers_count":12782,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3685,"mirror_url":null,"archived":false,"open_issues_count":846,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3685,"open_issues":846,"watchers":12782,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12661"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/12661"},"issue":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/12661"},"comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/12661/comments"},"review_comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12661/comments"},"review_comment":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12661/commits"},"statuses":{"href":"https://api.github.com/repos/home-assistant/home-assistant/statuses/8b12c303b4c2ec4b4413519f624be188bc570cfd"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":13,"deletions":6,"changed_files":1}}
{"actor":{"display_login":"aronsky"}}