{"action":"created","comment":{"url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/pulls/comments/188671848","pull_request_review_id":120697801,"id":188671848,"diff_hunk":"@@ -0,0 +1,33 @@\n+# Default values for django-app.\n+# This is a YAML-formatted file.\n+# Declare variables to be passed into your templates.\n+\n+replicaCount: 1\n+\n+image:\n+  repository: 926803513772.dkr.ecr.eu-west-1.amazonaws.com/cloud-platform-demo-app\n+  tag: latest\n+  pullPolicy: IfNotPresent\n+\n+service:\n+  type: ClusterIP\n+  port: 80\n+\n+ingress:\n+  enabled: true\n+  annotations: {}\n+    # kubernetes.io/ingress.class: nginx\n+    # kubernetes.io/tls-acme: \"true\"\n+  path: /\n+  hosts:\n+    - helm-demo.apps.cloud-platforms-test.k8s.integration.dsd.io\n+  tls: []\n+  #  - secretName: chart-example-tls\n+  #    hosts:\n+  #      - chart-example.local\n+\n+postgresql:\n+    postgresUser: \"django\"","path":"helm_deploy/django-app/values.yaml","position":30,"original_position":30,"commit_id":"38f98e0ae90a6e69a364b487450f4ea7336905ee","original_commit_id":"b4f777216484b83b37b5b964be0ec8e8c7822d12","user":{"login":"jasonBirchall","id":31217584,"avatar_url":"https://avatars1.githubusercontent.com/u/31217584?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonBirchall","html_url":"https://github.com/jasonBirchall","followers_url":"https://api.github.com/users/jasonBirchall/followers","following_url":"https://api.github.com/users/jasonBirchall/following{/other_user}","gists_url":"https://api.github.com/users/jasonBirchall/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonBirchall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonBirchall/subscriptions","organizations_url":"https://api.github.com/users/jasonBirchall/orgs","repos_url":"https://api.github.com/users/jasonBirchall/repos","events_url":"https://api.github.com/users/jasonBirchall/events{/privacy}","received_events_url":"https://api.github.com/users/jasonBirchall/received_events","type":"User","site_admin":false},"body":"The password for postgres is set at creation time. All you'd be doing is defining the username. For the quickstart are you happy to have the username hardcoded? (maybe make it explicit in user docs)","created_at":"2018-05-16T15:34:44Z","updated_at":"2018-05-16T15:34:44Z","html_url":"https://github.com/ministryofjustice/cloud-platform-reference-app/pull/38#discussion_r188671848","pull_request_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/pulls/38","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/pulls/comments/188671848"},"html":{"href":"https://github.com/ministryofjustice/cloud-platform-reference-app/pull/38#discussion_r188671848"},"pull_request":{"href":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/pulls/38"}},"in_reply_to_id":188559339},"pull_request":{"url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/pulls/38","id":188363304,"html_url":"https://github.com/ministryofjustice/cloud-platform-reference-app/pull/38","diff_url":"https://github.com/ministryofjustice/cloud-platform-reference-app/pull/38.diff","patch_url":"https://github.com/ministryofjustice/cloud-platform-reference-app/pull/38.patch","issue_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/issues/38","number":38,"state":"open","locked":false,"title":"Helm chart creation for Django reference app.","user":{"login":"jasonBirchall","id":31217584,"avatar_url":"https://avatars1.githubusercontent.com/u/31217584?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonBirchall","html_url":"https://github.com/jasonBirchall","followers_url":"https://api.github.com/users/jasonBirchall/followers","following_url":"https://api.github.com/users/jasonBirchall/following{/other_user}","gists_url":"https://api.github.com/users/jasonBirchall/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonBirchall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonBirchall/subscriptions","organizations_url":"https://api.github.com/users/jasonBirchall/orgs","repos_url":"https://api.github.com/users/jasonBirchall/repos","events_url":"https://api.github.com/users/jasonBirchall/events{/privacy}","received_events_url":"https://api.github.com/users/jasonBirchall/received_events","type":"User","site_admin":false},"body":"connects to https://github.com/ministryofjustice/cloud-platform-user-docs/issues/24\r\n\r\n**WHAT**\r\n1. Removed the old Helm chart.\r\n2. Added new charts for Django app deploy. \r\n3. Added Postgres to the app and created a dependency in the helm chart.\r\n\r\n**WHY**\r\n1. Old Helm chart is just a static yaml file. No templating used.\r\n2. As per ticket: https://waffle.io/ministryofjustice/cloud-platform/cards/5af3111f00e2eb001deb8954\r\n3. Using dependencies, create postgres db and hook it up to the application. \r\n\r\n**NOTES**\r\n- Secrets are in plain text due to the nature of the quick start.","created_at":"2018-05-16T09:01:56Z","updated_at":"2018-05-16T15:34:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b4752f90d54e17ffbcdb65348e817dcafffcd473","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/pulls/38/commits","review_comments_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/pulls/38/comments","review_comment_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/issues/38/comments","statuses_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/statuses/38f98e0ae90a6e69a364b487450f4ea7336905ee","head":{"label":"ministryofjustice:fix/helm-review","ref":"fix/helm-review","sha":"38f98e0ae90a6e69a364b487450f4ea7336905ee","user":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars3.githubusercontent.com/u/2203574?v=4","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"repo":{"id":131595384,"name":"cloud-platform-reference-app","full_name":"ministryofjustice/cloud-platform-reference-app","owner":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars3.githubusercontent.com/u/2203574?v=4","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ministryofjustice/cloud-platform-reference-app","description":"Reference Django application for 'Getting Started' with MoJ's Cloud-Platform  ","fork":false,"url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app","forks_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/forks","keys_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/teams","hooks_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/hooks","issue_events_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/issues/events{/number}","events_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/events","assignees_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/assignees{/user}","branches_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/branches{/branch}","tags_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/tags","blobs_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/statuses/{sha}","languages_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/languages","stargazers_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/stargazers","contributors_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/contributors","subscribers_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/subscribers","subscription_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/subscription","commits_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/contents/{+path}","compare_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/merges","archive_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/downloads","issues_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/issues{/number}","pulls_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/pulls{/number}","milestones_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/milestones{/number}","notifications_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/labels{/name}","releases_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/releases{/id}","deployments_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/deployments","created_at":"2018-04-30T12:51:57Z","updated_at":"2018-05-16T08:02:06Z","pushed_at":"2018-05-16T15:31:49Z","git_url":"git://github.com/ministryofjustice/cloud-platform-reference-app.git","ssh_url":"git@github.com:ministryofjustice/cloud-platform-reference-app.git","clone_url":"https://github.com/ministryofjustice/cloud-platform-reference-app.git","svn_url":"https://github.com/ministryofjustice/cloud-platform-reference-app","homepage":"","size":18840,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":11,"license":null,"forks":0,"open_issues":11,"watchers":0,"default_branch":"master"}},"base":{"label":"ministryofjustice:master","ref":"master","sha":"fa378072804fc2719eaa0b32eef7cc3203d0205b","user":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars3.githubusercontent.com/u/2203574?v=4","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"repo":{"id":131595384,"name":"cloud-platform-reference-app","full_name":"ministryofjustice/cloud-platform-reference-app","owner":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars3.githubusercontent.com/u/2203574?v=4","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ministryofjustice/cloud-platform-reference-app","description":"Reference Django application for 'Getting Started' with MoJ's Cloud-Platform  ","fork":false,"url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app","forks_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/forks","keys_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/teams","hooks_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/hooks","issue_events_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/issues/events{/number}","events_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/events","assignees_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/assignees{/user}","branches_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/branches{/branch}","tags_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/tags","blobs_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/statuses/{sha}","languages_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/languages","stargazers_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/stargazers","contributors_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/contributors","subscribers_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/subscribers","subscription_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/subscription","commits_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/contents/{+path}","compare_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/merges","archive_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/downloads","issues_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/issues{/number}","pulls_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/pulls{/number}","milestones_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/milestones{/number}","notifications_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/labels{/name}","releases_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/releases{/id}","deployments_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/deployments","created_at":"2018-04-30T12:51:57Z","updated_at":"2018-05-16T08:02:06Z","pushed_at":"2018-05-16T15:31:49Z","git_url":"git://github.com/ministryofjustice/cloud-platform-reference-app.git","ssh_url":"git@github.com:ministryofjustice/cloud-platform-reference-app.git","clone_url":"https://github.com/ministryofjustice/cloud-platform-reference-app.git","svn_url":"https://github.com/ministryofjustice/cloud-platform-reference-app","homepage":"","size":18840,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":11,"license":null,"forks":0,"open_issues":11,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/pulls/38"},"html":{"href":"https://github.com/ministryofjustice/cloud-platform-reference-app/pull/38"},"issue":{"href":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/issues/38"},"comments":{"href":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/ministryofjustice/cloud-platform-reference-app/statuses/38f98e0ae90a6e69a364b487450f4ea7336905ee"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jasonBirchall"}}