{"action":"created","comment":{"url":"https://api.github.com/repos/phan/phan/pulls/comments/190820368","pull_request_review_id":123279062,"id":190820368,"diff_hunk":"@@ -49,7 +49,12 @@ public static function initPhanConfig(array $opts) : int\n                 return 1;\n             }\n \n-            $vendor_path = \"$cwd/vendor\";\n+            if (!empty($composer_settings['config']['vendor_dir'])) {","path":"src/Phan/Config/Initializer.php","position":null,"original_position":5,"commit_id":"93876bc9b83a530d802c797ca9da480fca8357b0","original_commit_id":"0276dd1104fb5e49a1f460f9da08809418aeee7b","user":{"login":"maksimovic","id":1126226,"avatar_url":"https://avatars2.githubusercontent.com/u/1126226?v=4","gravatar_id":"","url":"https://api.github.com/users/maksimovic","html_url":"https://github.com/maksimovic","followers_url":"https://api.github.com/users/maksimovic/followers","following_url":"https://api.github.com/users/maksimovic/following{/other_user}","gists_url":"https://api.github.com/users/maksimovic/gists{/gist_id}","starred_url":"https://api.github.com/users/maksimovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maksimovic/subscriptions","organizations_url":"https://api.github.com/users/maksimovic/orgs","repos_url":"https://api.github.com/users/maksimovic/repos","events_url":"https://api.github.com/users/maksimovic/events{/privacy}","received_events_url":"https://api.github.com/users/maksimovic/received_events","type":"User","site_admin":false},"body":"Can't believe I've missed the array key.\r\n\r\nSimplified the check itself according to your comment, too.","created_at":"2018-05-25T08:13:58Z","updated_at":"2018-05-25T08:13:58Z","html_url":"https://github.com/phan/phan/pull/1723#discussion_r190820368","pull_request_url":"https://api.github.com/repos/phan/phan/pulls/1723","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/phan/phan/pulls/comments/190820368"},"html":{"href":"https://github.com/phan/phan/pull/1723#discussion_r190820368"},"pull_request":{"href":"https://api.github.com/repos/phan/phan/pulls/1723"}},"in_reply_to_id":190638927},"pull_request":{"url":"https://api.github.com/repos/phan/phan/pulls/1723","id":190259779,"html_url":"https://github.com/phan/phan/pull/1723","diff_url":"https://github.com/phan/phan/pull/1723.diff","patch_url":"https://github.com/phan/phan/pull/1723.patch","issue_url":"https://api.github.com/repos/phan/phan/issues/1723","number":1723,"state":"open","locked":false,"title":"Read \"vendor-dir\" from composer.json","user":{"login":"maksimovic","id":1126226,"avatar_url":"https://avatars2.githubusercontent.com/u/1126226?v=4","gravatar_id":"","url":"https://api.github.com/users/maksimovic","html_url":"https://github.com/maksimovic","followers_url":"https://api.github.com/users/maksimovic/followers","following_url":"https://api.github.com/users/maksimovic/following{/other_user}","gists_url":"https://api.github.com/users/maksimovic/gists{/gist_id}","starred_url":"https://api.github.com/users/maksimovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maksimovic/subscriptions","organizations_url":"https://api.github.com/users/maksimovic/orgs","repos_url":"https://api.github.com/users/maksimovic/repos","events_url":"https://api.github.com/users/maksimovic/events{/privacy}","received_events_url":"https://api.github.com/users/maksimovic/received_events","type":"User","site_admin":false},"body":"Phan is currently assuming that `vendor` dir is at its default location, but that might not always be the case. `vendor`'s location can be manipulated via composer's `config` option [vendor-dir](https://getcomposer.org/doc/06-config.md#vendor-dir).\r\n\r\nIssue: #1612 ","created_at":"2018-05-24T11:42:28Z","updated_at":"2018-05-25T08:13:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef90e0eb5f96f14709ac782902f3e42e193bd9b4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/phan/phan/pulls/1723/commits","review_comments_url":"https://api.github.com/repos/phan/phan/pulls/1723/comments","review_comment_url":"https://api.github.com/repos/phan/phan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/phan/phan/issues/1723/comments","statuses_url":"https://api.github.com/repos/phan/phan/statuses/93876bc9b83a530d802c797ca9da480fca8357b0","head":{"label":"maksimovic:custom-vendor-dir","ref":"custom-vendor-dir","sha":"93876bc9b83a530d802c797ca9da480fca8357b0","user":{"login":"maksimovic","id":1126226,"avatar_url":"https://avatars2.githubusercontent.com/u/1126226?v=4","gravatar_id":"","url":"https://api.github.com/users/maksimovic","html_url":"https://github.com/maksimovic","followers_url":"https://api.github.com/users/maksimovic/followers","following_url":"https://api.github.com/users/maksimovic/following{/other_user}","gists_url":"https://api.github.com/users/maksimovic/gists{/gist_id}","starred_url":"https://api.github.com/users/maksimovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maksimovic/subscriptions","organizations_url":"https://api.github.com/users/maksimovic/orgs","repos_url":"https://api.github.com/users/maksimovic/repos","events_url":"https://api.github.com/users/maksimovic/events{/privacy}","received_events_url":"https://api.github.com/users/maksimovic/received_events","type":"User","site_admin":false},"repo":{"id":134695512,"name":"phan","full_name":"maksimovic/phan","owner":{"login":"maksimovic","id":1126226,"avatar_url":"https://avatars2.githubusercontent.com/u/1126226?v=4","gravatar_id":"","url":"https://api.github.com/users/maksimovic","html_url":"https://github.com/maksimovic","followers_url":"https://api.github.com/users/maksimovic/followers","following_url":"https://api.github.com/users/maksimovic/following{/other_user}","gists_url":"https://api.github.com/users/maksimovic/gists{/gist_id}","starred_url":"https://api.github.com/users/maksimovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maksimovic/subscriptions","organizations_url":"https://api.github.com/users/maksimovic/orgs","repos_url":"https://api.github.com/users/maksimovic/repos","events_url":"https://api.github.com/users/maksimovic/events{/privacy}","received_events_url":"https://api.github.com/users/maksimovic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maksimovic/phan","description":"Phan is a static analyzer for PHP. Phan prefers to avoid false-positives and attempts to prove incorrectness rather than correctness.","fork":true,"url":"https://api.github.com/repos/maksimovic/phan","forks_url":"https://api.github.com/repos/maksimovic/phan/forks","keys_url":"https://api.github.com/repos/maksimovic/phan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maksimovic/phan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maksimovic/phan/teams","hooks_url":"https://api.github.com/repos/maksimovic/phan/hooks","issue_events_url":"https://api.github.com/repos/maksimovic/phan/issues/events{/number}","events_url":"https://api.github.com/repos/maksimovic/phan/events","assignees_url":"https://api.github.com/repos/maksimovic/phan/assignees{/user}","branches_url":"https://api.github.com/repos/maksimovic/phan/branches{/branch}","tags_url":"https://api.github.com/repos/maksimovic/phan/tags","blobs_url":"https://api.github.com/repos/maksimovic/phan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maksimovic/phan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maksimovic/phan/git/refs{/sha}","trees_url":"https://api.github.com/repos/maksimovic/phan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maksimovic/phan/statuses/{sha}","languages_url":"https://api.github.com/repos/maksimovic/phan/languages","stargazers_url":"https://api.github.com/repos/maksimovic/phan/stargazers","contributors_url":"https://api.github.com/repos/maksimovic/phan/contributors","subscribers_url":"https://api.github.com/repos/maksimovic/phan/subscribers","subscription_url":"https://api.github.com/repos/maksimovic/phan/subscription","commits_url":"https://api.github.com/repos/maksimovic/phan/commits{/sha}","git_commits_url":"https://api.github.com/repos/maksimovic/phan/git/commits{/sha}","comments_url":"https://api.github.com/repos/maksimovic/phan/comments{/number}","issue_comment_url":"https://api.github.com/repos/maksimovic/phan/issues/comments{/number}","contents_url":"https://api.github.com/repos/maksimovic/phan/contents/{+path}","compare_url":"https://api.github.com/repos/maksimovic/phan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maksimovic/phan/merges","archive_url":"https://api.github.com/repos/maksimovic/phan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maksimovic/phan/downloads","issues_url":"https://api.github.com/repos/maksimovic/phan/issues{/number}","pulls_url":"https://api.github.com/repos/maksimovic/phan/pulls{/number}","milestones_url":"https://api.github.com/repos/maksimovic/phan/milestones{/number}","notifications_url":"https://api.github.com/repos/maksimovic/phan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maksimovic/phan/labels{/name}","releases_url":"https://api.github.com/repos/maksimovic/phan/releases{/id}","deployments_url":"https://api.github.com/repos/maksimovic/phan/deployments","created_at":"2018-05-24T09:51:06Z","updated_at":"2018-05-24T09:51:11Z","pushed_at":"2018-05-25T08:10:33Z","git_url":"git://github.com/maksimovic/phan.git","ssh_url":"git@github.com:maksimovic/phan.git","clone_url":"https://github.com/maksimovic/phan.git","svn_url":"https://github.com/maksimovic/phan","homepage":"","size":11253,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"phan:master","ref":"master","sha":"87bd61252ff2b96cf479bd95546a520163ebed1e","user":{"login":"phan","id":31359272,"avatar_url":"https://avatars2.githubusercontent.com/u/31359272?v=4","gravatar_id":"","url":"https://api.github.com/users/phan","html_url":"https://github.com/phan","followers_url":"https://api.github.com/users/phan/followers","following_url":"https://api.github.com/users/phan/following{/other_user}","gists_url":"https://api.github.com/users/phan/gists{/gist_id}","starred_url":"https://api.github.com/users/phan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phan/subscriptions","organizations_url":"https://api.github.com/users/phan/orgs","repos_url":"https://api.github.com/users/phan/repos","events_url":"https://api.github.com/users/phan/events{/privacy}","received_events_url":"https://api.github.com/users/phan/received_events","type":"Organization","site_admin":false},"repo":{"id":44751102,"name":"phan","full_name":"phan/phan","owner":{"login":"phan","id":31359272,"avatar_url":"https://avatars2.githubusercontent.com/u/31359272?v=4","gravatar_id":"","url":"https://api.github.com/users/phan","html_url":"https://github.com/phan","followers_url":"https://api.github.com/users/phan/followers","following_url":"https://api.github.com/users/phan/following{/other_user}","gists_url":"https://api.github.com/users/phan/gists{/gist_id}","starred_url":"https://api.github.com/users/phan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phan/subscriptions","organizations_url":"https://api.github.com/users/phan/orgs","repos_url":"https://api.github.com/users/phan/repos","events_url":"https://api.github.com/users/phan/events{/privacy}","received_events_url":"https://api.github.com/users/phan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phan/phan","description":"Phan is a static analyzer for PHP. Phan prefers to avoid false-positives and attempts to prove incorrectness rather than correctness.","fork":false,"url":"https://api.github.com/repos/phan/phan","forks_url":"https://api.github.com/repos/phan/phan/forks","keys_url":"https://api.github.com/repos/phan/phan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phan/phan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phan/phan/teams","hooks_url":"https://api.github.com/repos/phan/phan/hooks","issue_events_url":"https://api.github.com/repos/phan/phan/issues/events{/number}","events_url":"https://api.github.com/repos/phan/phan/events","assignees_url":"https://api.github.com/repos/phan/phan/assignees{/user}","branches_url":"https://api.github.com/repos/phan/phan/branches{/branch}","tags_url":"https://api.github.com/repos/phan/phan/tags","blobs_url":"https://api.github.com/repos/phan/phan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phan/phan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phan/phan/git/refs{/sha}","trees_url":"https://api.github.com/repos/phan/phan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phan/phan/statuses/{sha}","languages_url":"https://api.github.com/repos/phan/phan/languages","stargazers_url":"https://api.github.com/repos/phan/phan/stargazers","contributors_url":"https://api.github.com/repos/phan/phan/contributors","subscribers_url":"https://api.github.com/repos/phan/phan/subscribers","subscription_url":"https://api.github.com/repos/phan/phan/subscription","commits_url":"https://api.github.com/repos/phan/phan/commits{/sha}","git_commits_url":"https://api.github.com/repos/phan/phan/git/commits{/sha}","comments_url":"https://api.github.com/repos/phan/phan/comments{/number}","issue_comment_url":"https://api.github.com/repos/phan/phan/issues/comments{/number}","contents_url":"https://api.github.com/repos/phan/phan/contents/{+path}","compare_url":"https://api.github.com/repos/phan/phan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phan/phan/merges","archive_url":"https://api.github.com/repos/phan/phan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phan/phan/downloads","issues_url":"https://api.github.com/repos/phan/phan/issues{/number}","pulls_url":"https://api.github.com/repos/phan/phan/pulls{/number}","milestones_url":"https://api.github.com/repos/phan/phan/milestones{/number}","notifications_url":"https://api.github.com/repos/phan/phan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phan/phan/labels{/name}","releases_url":"https://api.github.com/repos/phan/phan/releases{/id}","deployments_url":"https://api.github.com/repos/phan/phan/deployments","created_at":"2015-10-22T14:34:09Z","updated_at":"2018-05-24T23:32:43Z","pushed_at":"2018-05-25T08:10:34Z","git_url":"git://github.com/phan/phan.git","ssh_url":"git@github.com:phan/phan.git","clone_url":"https://github.com/phan/phan.git","svn_url":"https://github.com/phan/phan","homepage":"","size":11300,"stargazers_count":2914,"watchers_count":2914,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":207,"mirror_url":null,"archived":false,"open_issues_count":254,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":207,"open_issues":254,"watchers":2914,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/phan/phan/pulls/1723"},"html":{"href":"https://github.com/phan/phan/pull/1723"},"issue":{"href":"https://api.github.com/repos/phan/phan/issues/1723"},"comments":{"href":"https://api.github.com/repos/phan/phan/issues/1723/comments"},"review_comments":{"href":"https://api.github.com/repos/phan/phan/pulls/1723/comments"},"review_comment":{"href":"https://api.github.com/repos/phan/phan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/phan/phan/pulls/1723/commits"},"statuses":{"href":"https://api.github.com/repos/phan/phan/statuses/93876bc9b83a530d802c797ca9da480fca8357b0"}},"author_association":"NONE"}}
{"actor":{"display_login":"maksimovic"}}