{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/22858","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/22858/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/22858/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/22858/events","html_url":"https://github.com/nodejs/node/pull/22858","id":360218734,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NTI3ODY2","number":22858,"title":"lib: remove useless input parameters and make 'digest' clear in the doc","user":{"login":"Maledong","id":40081831,"node_id":"MDQ6VXNlcjQwMDgxODMx","avatar_url":"https://avatars0.githubusercontent.com/u/40081831?v=4","gravatar_id":"","url":"https://api.github.com/users/Maledong","html_url":"https://github.com/Maledong","followers_url":"https://api.github.com/users/Maledong/followers","following_url":"https://api.github.com/users/Maledong/following{/other_user}","gists_url":"https://api.github.com/users/Maledong/gists{/gist_id}","starred_url":"https://api.github.com/users/Maledong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Maledong/subscriptions","organizations_url":"https://api.github.com/users/Maledong/orgs","repos_url":"https://api.github.com/users/Maledong/repos","events_url":"https://api.github.com/users/Maledong/events{/privacy}","received_events_url":"https://api.github.com/users/Maledong/received_events","type":"User","site_admin":false},"labels":[{"id":155267357,"node_id":"MDU6TGFiZWwxNTUyNjczNTc=","url":"https://api.github.com/repos/nodejs/node/labels/crypto","name":"crypto","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-09-14T09:05:23Z","updated_at":"2018-09-15T16:13:45Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/22858","html_url":"https://github.com/nodejs/node/pull/22858","diff_url":"https://github.com/nodejs/node/pull/22858.diff","patch_url":"https://github.com/nodejs/node/pull/22858.patch"},"body":"1) Remove 'callback' in 'check' function, because we don't check or use\r\nthat directly.\r\n\r\n2) Adjust the orders of codes in 'pbkdf2' to have a quick check whether\r\nthe callback is a function or not instead of using it into the 'check'\r\nmethod.\r\n\r\n3) Add explainations to 'digest' in the doc.\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [ ] tests and/or benchmarks are included\r\n- [x] documentation is changed or added\r\n- [x] commit message follows [commit guidelines]\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/421593189","html_url":"https://github.com/nodejs/node/pull/22858#issuecomment-421593189","issue_url":"https://api.github.com/repos/nodejs/node/issues/22858","id":421593189,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTU5MzE4OQ==","user":{"login":"Trott","id":718899,"node_id":"MDQ6VXNlcjcxODg5OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/718899?v=4","gravatar_id":"","url":"https://api.github.com/users/Trott","html_url":"https://github.com/Trott","followers_url":"https://api.github.com/users/Trott/followers","following_url":"https://api.github.com/users/Trott/following{/other_user}","gists_url":"https://api.github.com/users/Trott/gists{/gist_id}","starred_url":"https://api.github.com/users/Trott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trott/subscriptions","organizations_url":"https://api.github.com/users/Trott/orgs","repos_url":"https://api.github.com/users/Trott/repos","events_url":"https://api.github.com/users/Trott/events{/privacy}","received_events_url":"https://api.github.com/users/Trott/received_events","type":"User","site_admin":false},"created_at":"2018-09-15T16:13:45Z","updated_at":"2018-09-15T16:13:45Z","author_association":"MEMBER","body":"(Any reason not to immediately introduce a Documentation-only deprecation? /cc @tniessen Is that already happening in another PR? If so, presumably the docs are updated there already and so maybe this isn't necessary, except perhaps for backporting to older versions or something?)"}}
{"actor":{"display_login":"Trott"}}