{"action":"opened","number":11819,"pull_request":{"url":"https://api.github.com/repos/electron/electron/pulls/11819","id":166946594,"html_url":"https://github.com/electron/electron/pull/11819","diff_url":"https://github.com/electron/electron/pull/11819.diff","patch_url":"https://github.com/electron/electron/pull/11819.patch","issue_url":"https://api.github.com/repos/electron/electron/issues/11819","number":11819,"state":"open","locked":false,"title":"feat(worditerator): bump up worditerator into latest","user":{"login":"kwonoj","id":1210596,"avatar_url":"https://avatars2.githubusercontent.com/u/1210596?v=4","gravatar_id":"","url":"https://api.github.com/users/kwonoj","html_url":"https://github.com/kwonoj","followers_url":"https://api.github.com/users/kwonoj/followers","following_url":"https://api.github.com/users/kwonoj/following{/other_user}","gists_url":"https://api.github.com/users/kwonoj/gists{/gist_id}","starred_url":"https://api.github.com/users/kwonoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwonoj/subscriptions","organizations_url":"https://api.github.com/users/kwonoj/orgs","repos_url":"https://api.github.com/users/kwonoj/repos","events_url":"https://api.github.com/users/kwonoj/events{/privacy}","received_events_url":"https://api.github.com/users/kwonoj/received_events","type":"User","site_admin":false},"body":"This PR intends to bump up `SpellcheckWordIterator` implementation from latest chromium source. There was few fix / enhancements around word iterator, brief changes are like below: \r\n\r\n```\r\n75b1c3a Convert 0 and NULL to nullptr in components. \r\nfabb284 Convert chrome/renderer to std::unique_ptr by thakis \r\n3a99491 Correct OutputArabic()s filtering of chars irrelevant to spell-checking by krb \r\ne73d852 Convert Pass()→std::move() in //chrome by dcheng \r\n2729e44 Switch to standard integer types in chrome/. by avi \r\n4f336a6 Updates SpellcheckWordIterator::GetNextWord to return an enum.\r\n```\r\n\r\nNot sure how to migrate test cases - there are `spellcheck_worditerator_unittest.cc` in chromium source, but doesn't seem like corresponding test cases in Electron's repo side. Open up as PR to get suggestion / or opinions around.","created_at":"2018-02-03T04:49:58Z","updated_at":"2018-02-03T04:49:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/electron/electron/pulls/11819/commits","review_comments_url":"https://api.github.com/repos/electron/electron/pulls/11819/comments","review_comment_url":"https://api.github.com/repos/electron/electron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/electron/electron/issues/11819/comments","statuses_url":"https://api.github.com/repos/electron/electron/statuses/9522b1bf51a7c0c520b473b0f9ee1d773a7cbdaf","head":{"label":"kwonoj:feat-worditerator","ref":"feat-worditerator","sha":"9522b1bf51a7c0c520b473b0f9ee1d773a7cbdaf","user":{"login":"kwonoj","id":1210596,"avatar_url":"https://avatars2.githubusercontent.com/u/1210596?v=4","gravatar_id":"","url":"https://api.github.com/users/kwonoj","html_url":"https://github.com/kwonoj","followers_url":"https://api.github.com/users/kwonoj/followers","following_url":"https://api.github.com/users/kwonoj/following{/other_user}","gists_url":"https://api.github.com/users/kwonoj/gists{/gist_id}","starred_url":"https://api.github.com/users/kwonoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwonoj/subscriptions","organizations_url":"https://api.github.com/users/kwonoj/orgs","repos_url":"https://api.github.com/users/kwonoj/repos","events_url":"https://api.github.com/users/kwonoj/events{/privacy}","received_events_url":"https://api.github.com/users/kwonoj/received_events","type":"User","site_admin":false},"repo":{"id":98697527,"name":"electron","full_name":"kwonoj/electron","owner":{"login":"kwonoj","id":1210596,"avatar_url":"https://avatars2.githubusercontent.com/u/1210596?v=4","gravatar_id":"","url":"https://api.github.com/users/kwonoj","html_url":"https://github.com/kwonoj","followers_url":"https://api.github.com/users/kwonoj/followers","following_url":"https://api.github.com/users/kwonoj/following{/other_user}","gists_url":"https://api.github.com/users/kwonoj/gists{/gist_id}","starred_url":"https://api.github.com/users/kwonoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwonoj/subscriptions","organizations_url":"https://api.github.com/users/kwonoj/orgs","repos_url":"https://api.github.com/users/kwonoj/repos","events_url":"https://api.github.com/users/kwonoj/events{/privacy}","received_events_url":"https://api.github.com/users/kwonoj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kwonoj/electron","description":"Build cross platform desktop apps with JavaScript, HTML, and CSS","fork":true,"url":"https://api.github.com/repos/kwonoj/electron","forks_url":"https://api.github.com/repos/kwonoj/electron/forks","keys_url":"https://api.github.com/repos/kwonoj/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kwonoj/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kwonoj/electron/teams","hooks_url":"https://api.github.com/repos/kwonoj/electron/hooks","issue_events_url":"https://api.github.com/repos/kwonoj/electron/issues/events{/number}","events_url":"https://api.github.com/repos/kwonoj/electron/events","assignees_url":"https://api.github.com/repos/kwonoj/electron/assignees{/user}","branches_url":"https://api.github.com/repos/kwonoj/electron/branches{/branch}","tags_url":"https://api.github.com/repos/kwonoj/electron/tags","blobs_url":"https://api.github.com/repos/kwonoj/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kwonoj/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kwonoj/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/kwonoj/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kwonoj/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/kwonoj/electron/languages","stargazers_url":"https://api.github.com/repos/kwonoj/electron/stargazers","contributors_url":"https://api.github.com/repos/kwonoj/electron/contributors","subscribers_url":"https://api.github.com/repos/kwonoj/electron/subscribers","subscription_url":"https://api.github.com/repos/kwonoj/electron/subscription","commits_url":"https://api.github.com/repos/kwonoj/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/kwonoj/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/kwonoj/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/kwonoj/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/kwonoj/electron/contents/{+path}","compare_url":"https://api.github.com/repos/kwonoj/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kwonoj/electron/merges","archive_url":"https://api.github.com/repos/kwonoj/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kwonoj/electron/downloads","issues_url":"https://api.github.com/repos/kwonoj/electron/issues{/number}","pulls_url":"https://api.github.com/repos/kwonoj/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/kwonoj/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/kwonoj/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kwonoj/electron/labels{/name}","releases_url":"https://api.github.com/repos/kwonoj/electron/releases{/id}","deployments_url":"https://api.github.com/repos/kwonoj/electron/deployments","created_at":"2017-07-29T00:26:28Z","updated_at":"2017-07-29T00:26:44Z","pushed_at":"2018-02-03T04:44:29Z","git_url":"git://github.com/kwonoj/electron.git","ssh_url":"git@github.com:kwonoj/electron.git","clone_url":"https://github.com/kwonoj/electron.git","svn_url":"https://github.com/kwonoj/electron","homepage":"https://electron.atom.io","size":34821,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"electron:master","ref":"master","sha":"62d2a3472fc597143b9b2b387df4861434191be1","user":{"login":"electron","id":13409222,"avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"name":"electron","full_name":"electron/electron","owner":{"login":"electron","id":13409222,"avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/electron/electron","description":"Build cross platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2018-02-03T03:17:51Z","pushed_at":"2018-02-03T02:31:03Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":35186,"stargazers_count":56142,"watchers_count":56142,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7288,"mirror_url":null,"archived":false,"open_issues_count":851,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":7288,"open_issues":851,"watchers":56142,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/electron/electron/pulls/11819"},"html":{"href":"https://github.com/electron/electron/pull/11819"},"issue":{"href":"https://api.github.com/repos/electron/electron/issues/11819"},"comments":{"href":"https://api.github.com/repos/electron/electron/issues/11819/comments"},"review_comments":{"href":"https://api.github.com/repos/electron/electron/pulls/11819/comments"},"review_comment":{"href":"https://api.github.com/repos/electron/electron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/electron/electron/pulls/11819/commits"},"statuses":{"href":"https://api.github.com/repos/electron/electron/statuses/9522b1bf51a7c0c520b473b0f9ee1d773a7cbdaf"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":80,"deletions":33,"changed_files":2}}
{"actor":{"display_login":"kwonoj"}}