{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/243669972","pull_request_review_id":187509718,"id":243669972,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzY2OTk3Mg==","diff_hunk":"@@ -19,6 +19,7 @@\n \n import java.io.File;\n import java.io.IOException;\n+import java.lang.reflect.Method;","path":"common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java","position":4,"original_position":4,"commit_id":"e2414ca2789f4e26969b262306a7c04f43a5f0c8","original_commit_id":"e2414ca2789f4e26969b262306a7c04f43a5f0c8","user":{"login":"pgandhi999","id":22228190,"node_id":"MDQ6VXNlcjIyMjI4MTkw","avatar_url":"https://avatars0.githubusercontent.com/u/22228190?v=4","gravatar_id":"","url":"https://api.github.com/users/pgandhi999","html_url":"https://github.com/pgandhi999","followers_url":"https://api.github.com/users/pgandhi999/followers","following_url":"https://api.github.com/users/pgandhi999/following{/other_user}","gists_url":"https://api.github.com/users/pgandhi999/gists{/gist_id}","starred_url":"https://api.github.com/users/pgandhi999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgandhi999/subscriptions","organizations_url":"https://api.github.com/users/pgandhi999/orgs","repos_url":"https://api.github.com/users/pgandhi999/repos","events_url":"https://api.github.com/users/pgandhi999/events{/privacy}","received_events_url":"https://api.github.com/users/pgandhi999/received_events","type":"User","site_admin":false},"body":"Thank you so much. Sorry about that.","created_at":"2018-12-21T19:18:55Z","updated_at":"2018-12-21T19:18:55Z","html_url":"https://github.com/apache/spark/pull/22498#discussion_r243669972","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/22498","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/243669972"},"html":{"href":"https://github.com/apache/spark/pull/22498#discussion_r243669972"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/22498"}},"in_reply_to_id":243668455},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/22498","id":217010710,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MDEwNzEw","html_url":"https://github.com/apache/spark/pull/22498","diff_url":"https://github.com/apache/spark/pull/22498.diff","patch_url":"https://github.com/apache/spark/pull/22498.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/22498","number":22498,"state":"open","locked":false,"title":"[SPARK-25642] : Adding two new metrics to record the number of registered connections as well as the number of active connections to YARN Shuffle Service","user":{"login":"pgandhi999","id":22228190,"node_id":"MDQ6VXNlcjIyMjI4MTkw","avatar_url":"https://avatars0.githubusercontent.com/u/22228190?v=4","gravatar_id":"","url":"https://api.github.com/users/pgandhi999","html_url":"https://github.com/pgandhi999","followers_url":"https://api.github.com/users/pgandhi999/followers","following_url":"https://api.github.com/users/pgandhi999/following{/other_user}","gists_url":"https://api.github.com/users/pgandhi999/gists{/gist_id}","starred_url":"https://api.github.com/users/pgandhi999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgandhi999/subscriptions","organizations_url":"https://api.github.com/users/pgandhi999/orgs","repos_url":"https://api.github.com/users/pgandhi999/repos","events_url":"https://api.github.com/users/pgandhi999/events{/privacy}","received_events_url":"https://api.github.com/users/pgandhi999/received_events","type":"User","site_admin":false},"body":"Recently, the ability to expose the metrics for YARN Shuffle Service was added as part of [SPARK-18364](https://github.com/apache/spark/pull/22485). We need to add some metrics to be able to determine the number of active connections as well as open connections to the external shuffle service to benchmark network and connection issues on large cluster environments.\r\n\r\n## What changes were proposed in this pull request?\r\n\r\nAdded two more shuffle server metrics for Spark Yarn shuffle service: numRegisteredConnections which indicate the number of registered connections to the shuffle service and numActiveConnections which indicate the number of active connections to the shuffle service at any given point in time. \r\n\r\n## How was this patch tested?\r\n\r\nIf these metrics are outputted to a file, we get something like this:\r\n\r\n1533674653489 default.shuffleService: Hostname=server1.abc.com, openBlockRequestLatencyMillis_count=729, openBlockRequestLatencyMillis_rate15=0.7110833548897356, openBlockRequestLatencyMillis_rate5=1.657808981793011, openBlockRequestLatencyMillis_rate1=2.2404486061620474, openBlockRequestLatencyMillis_rateMean=0.9242558551196706,\r\nnumRegisteredConnections=35,\r\nblockTransferRateBytes_count=2635880512, blockTransferRateBytes_rate15=2578547.6094160094, blockTransferRateBytes_rate5=6048721.726302424, blockTransferRateBytes_rate1=8548922.518223226, blockTransferRateBytes_rateMean=3341878.633637769, registeredExecutorsSize=5, registerExecutorRequestLatencyMillis_count=5, registerExecutorRequestLatencyMillis_rate15=0.0027973949328659836, registerExecutorRequestLatencyMillis_rate5=0.0021278007987206426, registerExecutorRequestLatencyMillis_rate1=2.8270296777387467E-6, registerExecutorRequestLatencyMillis_rateMean=0.006339206380043053, numActiveConnections=35\r\n","created_at":"2018-09-20T15:16:24Z","updated_at":"2018-12-21T19:18:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be60394184f0e9affa994043f3f79ef8981f7f20","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/22498/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/22498/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/22498/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/e2414ca2789f4e26969b262306a7c04f43a5f0c8","head":{"label":"pgandhi999:SPARK-18364","ref":"SPARK-18364","sha":"e2414ca2789f4e26969b262306a7c04f43a5f0c8","user":{"login":"pgandhi999","id":22228190,"node_id":"MDQ6VXNlcjIyMjI4MTkw","avatar_url":"https://avatars0.githubusercontent.com/u/22228190?v=4","gravatar_id":"","url":"https://api.github.com/users/pgandhi999","html_url":"https://github.com/pgandhi999","followers_url":"https://api.github.com/users/pgandhi999/followers","following_url":"https://api.github.com/users/pgandhi999/following{/other_user}","gists_url":"https://api.github.com/users/pgandhi999/gists{/gist_id}","starred_url":"https://api.github.com/users/pgandhi999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgandhi999/subscriptions","organizations_url":"https://api.github.com/users/pgandhi999/orgs","repos_url":"https://api.github.com/users/pgandhi999/repos","events_url":"https://api.github.com/users/pgandhi999/events{/privacy}","received_events_url":"https://api.github.com/users/pgandhi999/received_events","type":"User","site_admin":false},"repo":{"id":97985305,"node_id":"MDEwOlJlcG9zaXRvcnk5Nzk4NTMwNQ==","name":"spark","full_name":"pgandhi999/spark","private":false,"owner":{"login":"pgandhi999","id":22228190,"node_id":"MDQ6VXNlcjIyMjI4MTkw","avatar_url":"https://avatars0.githubusercontent.com/u/22228190?v=4","gravatar_id":"","url":"https://api.github.com/users/pgandhi999","html_url":"https://github.com/pgandhi999","followers_url":"https://api.github.com/users/pgandhi999/followers","following_url":"https://api.github.com/users/pgandhi999/following{/other_user}","gists_url":"https://api.github.com/users/pgandhi999/gists{/gist_id}","starred_url":"https://api.github.com/users/pgandhi999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgandhi999/subscriptions","organizations_url":"https://api.github.com/users/pgandhi999/orgs","repos_url":"https://api.github.com/users/pgandhi999/repos","events_url":"https://api.github.com/users/pgandhi999/events{/privacy}","received_events_url":"https://api.github.com/users/pgandhi999/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pgandhi999/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/pgandhi999/spark","forks_url":"https://api.github.com/repos/pgandhi999/spark/forks","keys_url":"https://api.github.com/repos/pgandhi999/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pgandhi999/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pgandhi999/spark/teams","hooks_url":"https://api.github.com/repos/pgandhi999/spark/hooks","issue_events_url":"https://api.github.com/repos/pgandhi999/spark/issues/events{/number}","events_url":"https://api.github.com/repos/pgandhi999/spark/events","assignees_url":"https://api.github.com/repos/pgandhi999/spark/assignees{/user}","branches_url":"https://api.github.com/repos/pgandhi999/spark/branches{/branch}","tags_url":"https://api.github.com/repos/pgandhi999/spark/tags","blobs_url":"https://api.github.com/repos/pgandhi999/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pgandhi999/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pgandhi999/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/pgandhi999/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pgandhi999/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/pgandhi999/spark/languages","stargazers_url":"https://api.github.com/repos/pgandhi999/spark/stargazers","contributors_url":"https://api.github.com/repos/pgandhi999/spark/contributors","subscribers_url":"https://api.github.com/repos/pgandhi999/spark/subscribers","subscription_url":"https://api.github.com/repos/pgandhi999/spark/subscription","commits_url":"https://api.github.com/repos/pgandhi999/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/pgandhi999/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/pgandhi999/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/pgandhi999/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/pgandhi999/spark/contents/{+path}","compare_url":"https://api.github.com/repos/pgandhi999/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pgandhi999/spark/merges","archive_url":"https://api.github.com/repos/pgandhi999/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pgandhi999/spark/downloads","issues_url":"https://api.github.com/repos/pgandhi999/spark/issues{/number}","pulls_url":"https://api.github.com/repos/pgandhi999/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/pgandhi999/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/pgandhi999/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pgandhi999/spark/labels{/name}","releases_url":"https://api.github.com/repos/pgandhi999/spark/releases{/id}","deployments_url":"https://api.github.com/repos/pgandhi999/spark/deployments","created_at":"2017-07-21T20:46:46Z","updated_at":"2018-12-20T17:35:10Z","pushed_at":"2018-12-21T14:00:34Z","git_url":"git://github.com/pgandhi999/spark.git","ssh_url":"git@github.com:pgandhi999/spark.git","clone_url":"https://github.com/pgandhi999/spark.git","svn_url":"https://github.com/pgandhi999/spark","homepage":null,"size":287230,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"a888d202ab719ccb13b328aa445341d1d6b06881","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"node_id":"MDEwOlJlcG9zaXRvcnkxNzE2NTY1OA==","name":"spark","full_name":"apache/spark","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/spark","description":"Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2018-12-21T18:45:45Z","pushed_at":"2018-12-21T18:53:40Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":"","size":289800,"stargazers_count":19969,"watchers_count":19969,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":17761,"mirror_url":null,"archived":false,"open_issues_count":458,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":17761,"open_issues":458,"watchers":19969,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/22498"},"html":{"href":"https://github.com/apache/spark/pull/22498"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/22498"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/22498/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/22498/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/22498/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/e2414ca2789f4e26969b262306a7c04f43a5f0c8"}},"author_association":"NONE"}}
{"actor":{"display_login":"pgandhi999"}}