{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/242384948","pull_request_review_id":185880187,"id":242384948,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjM4NDk0OA==","diff_hunk":"@@ -5518,7 +5518,12 @@ int PrimaryLogPG::do_read(OpContext *ctx, OSDOp& osd_op) {\n     }\n     if (r >= 0)\n       op.extent.length = r;\n-    else {\n+    else if (r == -EAGAIN) {","path":"src/osd/PrimaryLogPG.cc","position":5,"original_position":5,"commit_id":"db9b760a979c6ee68afa9f0431e20d153e7bf577","original_commit_id":"db9b760a979c6ee68afa9f0431e20d153e7bf577","user":{"login":"xiexingguo","id":14193361,"node_id":"MDQ6VXNlcjE0MTkzMzYx","avatar_url":"https://avatars3.githubusercontent.com/u/14193361?v=4","gravatar_id":"","url":"https://api.github.com/users/xiexingguo","html_url":"https://github.com/xiexingguo","followers_url":"https://api.github.com/users/xiexingguo/followers","following_url":"https://api.github.com/users/xiexingguo/following{/other_user}","gists_url":"https://api.github.com/users/xiexingguo/gists{/gist_id}","starred_url":"https://api.github.com/users/xiexingguo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiexingguo/subscriptions","organizations_url":"https://api.github.com/users/xiexingguo/orgs","repos_url":"https://api.github.com/users/xiexingguo/repos","events_url":"https://api.github.com/users/xiexingguo/events{/privacy}","received_events_url":"https://api.github.com/users/xiexingguo/received_events","type":"User","site_admin":false},"body":"Ahh, that's right","created_at":"2018-12-18T02:01:51Z","updated_at":"2018-12-18T02:01:51Z","html_url":"https://github.com/ceph/ceph/pull/25584#discussion_r242384948","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/25584","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/242384948"},"html":{"href":"https://github.com/ceph/ceph/pull/25584#discussion_r242384948"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/25584"}},"in_reply_to_id":242164079},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/25584","id":239072769,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5MDcyNzY5","html_url":"https://github.com/ceph/ceph/pull/25584","diff_url":"https://github.com/ceph/ceph/pull/25584.diff","patch_url":"https://github.com/ceph/ceph/pull/25584.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/25584","number":25584,"state":"open","locked":false,"title":"osd/read: fix the extent length error of the sync read","user":{"login":"thinkercui","id":9260926,"node_id":"MDQ6VXNlcjkyNjA5MjY=","avatar_url":"https://avatars1.githubusercontent.com/u/9260926?v=4","gravatar_id":"","url":"https://api.github.com/users/thinkercui","html_url":"https://github.com/thinkercui","followers_url":"https://api.github.com/users/thinkercui/followers","following_url":"https://api.github.com/users/thinkercui/following{/other_user}","gists_url":"https://api.github.com/users/thinkercui/gists{/gist_id}","starred_url":"https://api.github.com/users/thinkercui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thinkercui/subscriptions","organizations_url":"https://api.github.com/users/thinkercui/orgs","repos_url":"https://api.github.com/users/thinkercui/repos","events_url":"https://api.github.com/users/thinkercui/events{/privacy}","received_events_url":"https://api.github.com/users/thinkercui/received_events","type":"User","site_admin":false},"body":"The extent.length of the sync read is changed to 0, when\r\nthe read is failed. This makes the retry of the read with\r\na offset of 0 to read the total object.\r\nLet the extent.length as it is, if the return code is -EAGAIN,\r\nwhich will make the read try again later with the correct\r\nextent.length.\r\n\r\nSigned-off-by: Xiaofei Cui <cuixiaofei@sangfor.com.cn>\r\n\r\n\r\n<!--\r\nThank you for opening a pull request!  Here are some tips on creating\r\na well formatted contribution.\r\n\r\nPlease give your pull request a title like \"[component]: [short description]\"\r\n\r\nThis is the format for commit messages:\r\n\r\n\"\"\"\r\n[component]: [short description]\r\n\r\n[A longer multiline description]\r\n\r\nFixes: [ticket URL on tracker.ceph.com, create one if necessary]\r\nSigned-off-by: [Your Name] <[your email]>\r\n\"\"\"\r\n\r\nThe Signed-off-by line is important, and it is your certification that\r\nyour contributions satisfy the Developers Certificate or Origin.  For\r\nmore detail, see SubmittingPatches.rst.\r\n\r\nThe component is the short name of a major daemon or subsystem,\r\nsomething like \"mon\", \"osd\", \"mds\", \"rbd, \"rgw\", etc. For ceph-mgr modules,\r\ngive the component as \"mgr/<module name>\" rather than a path into pybind.\r\n\r\nFor more examples, simply use \"git log\" and look at some historical commits.\r\n\r\nThis was just a quick overview.  More information for contributors is available here:\r\nhttps://raw.githubusercontent.com/ceph/ceph/master/SubmittingPatches.rst\r\n\r\n-->\r\n\r\n- [ ] References tracker ticket\r\n- [ ] Updates documentation if necessary\r\n- [ ] Includes tests for new functionality or reproducer for bug\r\n\r\n","created_at":"2018-12-17T09:15:59Z","updated_at":"2018-12-18T02:01:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78440382f496796e026ff83498cea9ca31777bbd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":144329561,"node_id":"MDU6TGFiZWwxNDQzMjk1NjE=","url":"https://api.github.com/repos/ceph/ceph/labels/core","name":"core","color":"0041a2","default":false},{"id":340048817,"node_id":"MDU6TGFiZWwzNDAwNDg4MTc=","url":"https://api.github.com/repos/ceph/ceph/labels/needs-review","name":"needs-review","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/25584/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/25584/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/25584/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/db9b760a979c6ee68afa9f0431e20d153e7bf577","head":{"label":"thinkercui:bugfix","ref":"bugfix","sha":"db9b760a979c6ee68afa9f0431e20d153e7bf577","user":{"login":"thinkercui","id":9260926,"node_id":"MDQ6VXNlcjkyNjA5MjY=","avatar_url":"https://avatars1.githubusercontent.com/u/9260926?v=4","gravatar_id":"","url":"https://api.github.com/users/thinkercui","html_url":"https://github.com/thinkercui","followers_url":"https://api.github.com/users/thinkercui/followers","following_url":"https://api.github.com/users/thinkercui/following{/other_user}","gists_url":"https://api.github.com/users/thinkercui/gists{/gist_id}","starred_url":"https://api.github.com/users/thinkercui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thinkercui/subscriptions","organizations_url":"https://api.github.com/users/thinkercui/orgs","repos_url":"https://api.github.com/users/thinkercui/repos","events_url":"https://api.github.com/users/thinkercui/events{/privacy}","received_events_url":"https://api.github.com/users/thinkercui/received_events","type":"User","site_admin":false},"repo":{"id":134543240,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ1NDMyNDA=","name":"ceph","full_name":"thinkercui/ceph","private":false,"owner":{"login":"thinkercui","id":9260926,"node_id":"MDQ6VXNlcjkyNjA5MjY=","avatar_url":"https://avatars1.githubusercontent.com/u/9260926?v=4","gravatar_id":"","url":"https://api.github.com/users/thinkercui","html_url":"https://github.com/thinkercui","followers_url":"https://api.github.com/users/thinkercui/followers","following_url":"https://api.github.com/users/thinkercui/following{/other_user}","gists_url":"https://api.github.com/users/thinkercui/gists{/gist_id}","starred_url":"https://api.github.com/users/thinkercui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thinkercui/subscriptions","organizations_url":"https://api.github.com/users/thinkercui/orgs","repos_url":"https://api.github.com/users/thinkercui/repos","events_url":"https://api.github.com/users/thinkercui/events{/privacy}","received_events_url":"https://api.github.com/users/thinkercui/received_events","type":"User","site_admin":false},"html_url":"https://github.com/thinkercui/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/thinkercui/ceph","forks_url":"https://api.github.com/repos/thinkercui/ceph/forks","keys_url":"https://api.github.com/repos/thinkercui/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thinkercui/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thinkercui/ceph/teams","hooks_url":"https://api.github.com/repos/thinkercui/ceph/hooks","issue_events_url":"https://api.github.com/repos/thinkercui/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/thinkercui/ceph/events","assignees_url":"https://api.github.com/repos/thinkercui/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/thinkercui/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/thinkercui/ceph/tags","blobs_url":"https://api.github.com/repos/thinkercui/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thinkercui/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thinkercui/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/thinkercui/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thinkercui/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/thinkercui/ceph/languages","stargazers_url":"https://api.github.com/repos/thinkercui/ceph/stargazers","contributors_url":"https://api.github.com/repos/thinkercui/ceph/contributors","subscribers_url":"https://api.github.com/repos/thinkercui/ceph/subscribers","subscription_url":"https://api.github.com/repos/thinkercui/ceph/subscription","commits_url":"https://api.github.com/repos/thinkercui/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/thinkercui/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/thinkercui/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/thinkercui/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/thinkercui/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/thinkercui/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thinkercui/ceph/merges","archive_url":"https://api.github.com/repos/thinkercui/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thinkercui/ceph/downloads","issues_url":"https://api.github.com/repos/thinkercui/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/thinkercui/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/thinkercui/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/thinkercui/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thinkercui/ceph/labels{/name}","releases_url":"https://api.github.com/repos/thinkercui/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/thinkercui/ceph/deployments","created_at":"2018-05-23T09:09:25Z","updated_at":"2018-05-23T09:09:47Z","pushed_at":"2018-12-17T12:25:37Z","git_url":"git://github.com/thinkercui/ceph.git","ssh_url":"git@github.com:thinkercui/ceph.git","clone_url":"https://github.com/thinkercui/ceph.git","svn_url":"https://github.com/thinkercui/ceph","homepage":"http://ceph.com","size":328636,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"2efb9ce8a2ec7c23ac55f54711b6d45138037bf7","user":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"node_id":"MDEwOlJlcG9zaXRvcnkyMzEwNDk1","name":"ceph","full_name":"ceph/ceph","private":false,"owner":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2018-12-17T21:38:08Z","pushed_at":"2018-12-18T00:42:22Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":338749,"stargazers_count":5406,"watchers_count":5406,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2841,"mirror_url":null,"archived":false,"open_issues_count":629,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2841,"open_issues":629,"watchers":5406,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/25584"},"html":{"href":"https://github.com/ceph/ceph/pull/25584"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/25584"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/25584/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/25584/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/25584/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/db9b760a979c6ee68afa9f0431e20d153e7bf577"}},"author_association":"NONE"}}
{"actor":{"display_login":"xiexingguo"}}