{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/14380","repository_url":"https://api.github.com/repos/bitcoin/bitcoin","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/14380/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/14380/comments","events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/14380/events","html_url":"https://github.com/bitcoin/bitcoin/pull/14380","id":366183685,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5OTIxMDMw","number":14380,"title":"fix assert crash when specified change output spend size is unknown","user":{"login":"instagibbs","id":5767891,"node_id":"MDQ6VXNlcjU3Njc4OTE=","avatar_url":"https://avatars0.githubusercontent.com/u/5767891?v=4","gravatar_id":"","url":"https://api.github.com/users/instagibbs","html_url":"https://github.com/instagibbs","followers_url":"https://api.github.com/users/instagibbs/followers","following_url":"https://api.github.com/users/instagibbs/following{/other_user}","gists_url":"https://api.github.com/users/instagibbs/gists{/gist_id}","starred_url":"https://api.github.com/users/instagibbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/instagibbs/subscriptions","organizations_url":"https://api.github.com/users/instagibbs/orgs","repos_url":"https://api.github.com/users/instagibbs/repos","events_url":"https://api.github.com/users/instagibbs/events{/privacy}","received_events_url":"https://api.github.com/users/instagibbs/received_events","type":"User","site_admin":false},"labels":[{"id":955867938,"node_id":"MDU6TGFiZWw5NTU4Njc5Mzg=","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Needs%20rebase","name":"Needs rebase","color":"cccccc","default":false},{"id":149424,"node_id":"MDU6TGFiZWwxNDk0MjQ=","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Wallet","name":"Wallet","color":"08a781","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":18,"created_at":"2018-10-03T05:45:29Z","updated_at":"2018-11-10T04:42:40Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14380","html_url":"https://github.com/bitcoin/bitcoin/pull/14380","diff_url":"https://github.com/bitcoin/bitcoin/pull/14380.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/14380.patch"},"body":"This is triggered anytime a fundraw type call(psbt or legacy) is used with a change output address that the wallet doesn't know how to sign for.\r\n\r\nThis regression was added in 6a34ff5335786615771ca423134a484b04831c4e since BnB coin selection actually cares about this.\r\n\r\nThe fix is to assume the smallest typical spend, a P2SH-P2WPKH, which is calculated using a \"prototype\" dummy signature flow. Future work could generalize this infrastructure to get estimated sizes of inputs for a variety of types.\r\n\r\nI also removed a comment which I believe is stale and misleading."},"comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/437557918","html_url":"https://github.com/bitcoin/bitcoin/pull/14380#issuecomment-437557918","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/14380","id":437557918,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzU1NzkxOA==","user":{"login":"DrahtBot","id":39886733,"node_id":"MDQ6VXNlcjM5ODg2NzMz","avatar_url":"https://avatars2.githubusercontent.com/u/39886733?v=4","gravatar_id":"","url":"https://api.github.com/users/DrahtBot","html_url":"https://github.com/DrahtBot","followers_url":"https://api.github.com/users/DrahtBot/followers","following_url":"https://api.github.com/users/DrahtBot/following{/other_user}","gists_url":"https://api.github.com/users/DrahtBot/gists{/gist_id}","starred_url":"https://api.github.com/users/DrahtBot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrahtBot/subscriptions","organizations_url":"https://api.github.com/users/DrahtBot/orgs","repos_url":"https://api.github.com/users/DrahtBot/repos","events_url":"https://api.github.com/users/DrahtBot/events{/privacy}","received_events_url":"https://api.github.com/users/DrahtBot/received_events","type":"User","site_admin":false},"created_at":"2018-11-10T04:42:40Z","updated_at":"2018-11-10T04:42:40Z","author_association":"CONTRIBUTOR","body":"<!--cf906140f33d8803c4a75a2196329ecb-->Needs rebase"}}
{"actor":{"display_login":"DrahtBot"}}