{"action":"created","issue":{"url":"https://api.github.com/repos/ProvidenceGeeks/website-frontend/issues/152","repository_url":"https://api.github.com/repos/ProvidenceGeeks/website-frontend","labels_url":"https://api.github.com/repos/ProvidenceGeeks/website-frontend/issues/152/labels{/name}","comments_url":"https://api.github.com/repos/ProvidenceGeeks/website-frontend/issues/152/comments","events_url":"https://api.github.com/repos/ProvidenceGeeks/website-frontend/issues/152/events","html_url":"https://github.com/ProvidenceGeeks/website-frontend/issues/152","id":318428720,"number":152,"title":"remove external request (Google Font API) happening in the Critical Rendering Path","user":{"login":"thescientist13","id":895923,"avatar_url":"https://avatars0.githubusercontent.com/u/895923?v=4","gravatar_id":"","url":"https://api.github.com/users/thescientist13","html_url":"https://github.com/thescientist13","followers_url":"https://api.github.com/users/thescientist13/followers","following_url":"https://api.github.com/users/thescientist13/following{/other_user}","gists_url":"https://api.github.com/users/thescientist13/gists{/gist_id}","starred_url":"https://api.github.com/users/thescientist13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thescientist13/subscriptions","organizations_url":"https://api.github.com/users/thescientist13/orgs","repos_url":"https://api.github.com/users/thescientist13/repos","events_url":"https://api.github.com/users/thescientist13/events{/privacy}","received_events_url":"https://api.github.com/users/thescientist13/received_events","type":"User","site_admin":false},"labels":[{"id":881590640,"url":"https://api.github.com/repos/ProvidenceGeeks/website-frontend/labels/0.3.0","name":"0.3.0","color":"98ff91","default":false}],"state":"open","locked":false,"assignee":{"login":"thescientist13","id":895923,"avatar_url":"https://avatars0.githubusercontent.com/u/895923?v=4","gravatar_id":"","url":"https://api.github.com/users/thescientist13","html_url":"https://github.com/thescientist13","followers_url":"https://api.github.com/users/thescientist13/followers","following_url":"https://api.github.com/users/thescientist13/following{/other_user}","gists_url":"https://api.github.com/users/thescientist13/gists{/gist_id}","starred_url":"https://api.github.com/users/thescientist13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thescientist13/subscriptions","organizations_url":"https://api.github.com/users/thescientist13/orgs","repos_url":"https://api.github.com/users/thescientist13/repos","events_url":"https://api.github.com/users/thescientist13/events{/privacy}","received_events_url":"https://api.github.com/users/thescientist13/received_events","type":"User","site_admin":false},"assignees":[{"login":"thescientist13","id":895923,"avatar_url":"https://avatars0.githubusercontent.com/u/895923?v=4","gravatar_id":"","url":"https://api.github.com/users/thescientist13","html_url":"https://github.com/thescientist13","followers_url":"https://api.github.com/users/thescientist13/followers","following_url":"https://api.github.com/users/thescientist13/following{/other_user}","gists_url":"https://api.github.com/users/thescientist13/gists{/gist_id}","starred_url":"https://api.github.com/users/thescientist13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thescientist13/subscriptions","organizations_url":"https://api.github.com/users/thescientist13/orgs","repos_url":"https://api.github.com/users/thescientist13/repos","events_url":"https://api.github.com/users/thescientist13/events{/privacy}","received_events_url":"https://api.github.com/users/thescientist13/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/ProvidenceGeeks/website-frontend/milestones/1","html_url":"https://github.com/ProvidenceGeeks/website-frontend/milestone/1","labels_url":"https://api.github.com/repos/ProvidenceGeeks/website-frontend/milestones/1/labels","id":2927495,"number":1,"title":"Lighthouse Compliance","description":"This is tracking the effort to be in compliance with Google's Lighthouse Web Application auditing tool\r\nhttps://developers.google.com/web/tools/lighthouse/\r\n\r\nThe goal is to have passing (>= 90%) scores for all 4 categories","creator":{"login":"thescientist13","id":895923,"avatar_url":"https://avatars0.githubusercontent.com/u/895923?v=4","gravatar_id":"","url":"https://api.github.com/users/thescientist13","html_url":"https://github.com/thescientist13","followers_url":"https://api.github.com/users/thescientist13/followers","following_url":"https://api.github.com/users/thescientist13/following{/other_user}","gists_url":"https://api.github.com/users/thescientist13/gists{/gist_id}","starred_url":"https://api.github.com/users/thescientist13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thescientist13/subscriptions","organizations_url":"https://api.github.com/users/thescientist13/orgs","repos_url":"https://api.github.com/users/thescientist13/repos","events_url":"https://api.github.com/users/thescientist13/events{/privacy}","received_events_url":"https://api.github.com/users/thescientist13/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":13,"state":"open","created_at":"2017-11-21T04:39:38Z","updated_at":"2018-04-27T14:22:51Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2018-04-27T14:22:51Z","updated_at":"2018-04-27T14:51:35Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"## Type of Change\r\n- [ ] New Feature Request\r\n- [x] Improvement / Suggestion\r\n- [ ] Bug\r\n- [x] Other (please clarify below)\r\nA technical task to improve the loading of the site by eliminating and external HTTP request to Google Fonts API, which I believe is the cause for all the white page time seen in the Lighthouse timeline.\r\n<img width=\"725\" alt=\"screen shot 2018-04-27 at 10 14 57 am\" src=\"https://user-images.githubusercontent.com/895923/39367187-0be85ccc-4a04-11e8-846f-eb6e2a9a9c5e.png\">\r\n\r\nAlthough the score is \"good\". Having to make an external HTTP request kind of defeats the purpose of inlining critical CSS.  \r\n\r\nLooking at the network tabs shows this request can be lengthy (117ms ) relative to say API requests the app makes (< 50ms).\r\n<img width=\"1618\" alt=\"screen shot 2018-04-27 at 10 17 30 am\" src=\"https://user-images.githubusercontent.com/895923/39367496-e003c4b0-4a04-11e8-9ca6-eae9c0db2d4c.png\">\r\n\r\n<img width=\"1441\" alt=\"screen shot 2018-04-27 at 10 21 13 am\" src=\"https://user-images.githubusercontent.com/895923/39367503-e6350970-4a04-11e8-9740-90a2c36d47ec.png\">\r\n\r\n\r\n\r\n## Summary\r\n<!--\r\nPlease provide as much detail as possible and refer to these samples\r\n\r\nNew Feature Request / Improvement:\r\n- Description: A new feature to show data from cool social media service\r\n- Designs: A link or upload of some design mock up\r\n- Dependencies: integration with cool social media service's API\r\n- Acceptance Criteria:\r\n1. Should do XYZ\r\n1. Should let user see such and such\r\n\r\nBug:\r\n- Please provide:\r\n1. Summary\r\n1. OS/Browser, version/device used if mobile\r\n1. Environment url(s)\r\n1. Exact steps to reproduce (example below)\r\n      1. Go to [url]\r\n      1. Click on [asset]\r\n1. Expected result: It should do ABC\r\n1. Actual result: It does XYZ\r\n1. Error message (if applicable)\r\n1. screenshot(jpg) or video(gif) if any\r\n      1. Naming Convention: defect_’page’_’feature’’#’; ex: defect_events-list_hoverover1\r\n\r\nOther:\r\n- Please provide all relevant details\r\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/ProvidenceGeeks/website-frontend/issues/comments/384994073","html_url":"https://github.com/ProvidenceGeeks/website-frontend/issues/152#issuecomment-384994073","issue_url":"https://api.github.com/repos/ProvidenceGeeks/website-frontend/issues/152","id":384994073,"user":{"login":"thescientist13","id":895923,"avatar_url":"https://avatars0.githubusercontent.com/u/895923?v=4","gravatar_id":"","url":"https://api.github.com/users/thescientist13","html_url":"https://github.com/thescientist13","followers_url":"https://api.github.com/users/thescientist13/followers","following_url":"https://api.github.com/users/thescientist13/following{/other_user}","gists_url":"https://api.github.com/users/thescientist13/gists{/gist_id}","starred_url":"https://api.github.com/users/thescientist13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thescientist13/subscriptions","organizations_url":"https://api.github.com/users/thescientist13/orgs","repos_url":"https://api.github.com/users/thescientist13/repos","events_url":"https://api.github.com/users/thescientist13/events{/privacy}","received_events_url":"https://api.github.com/users/thescientist13/received_events","type":"User","site_admin":false},"created_at":"2018-04-27T14:51:35Z","updated_at":"2018-04-27T14:51:35Z","author_association":"CONTRIBUTOR","body":"thanks @paul-barry-kenzan .\r\n\r\nWe are doing that currently too, but that external request (`https://fonts.googleapis.com/`) is what I see as a potential bottleneck in our case.  \r\n\r\nIt's just a hunch, but I'm hoping by taking an external HTTP request out of the Critical Rendering Path results in the app taking less time to paint something, even if the performance isn't significantly improved.  At least to the user there is the perception of something happening on the page, which is better than the three seconds of white screen, IMO.\r\n\r\nIn the network tab, it looks like 110ms of the request to the font is just time waiting for the request to be fulfilled (the TTfB)\r\n<img width=\"1608\" alt=\"screen shot 2018-04-27 at 10 40 04 am\" src=\"https://user-images.githubusercontent.com/895923/39368664-2dc819aa-4a08-11e8-948b-95db535ca69a.png\">"}}
{"actor":{"display_login":"thescientist13"}}