{"action":"created","comment":{"url":"https://api.github.com/repos/vega/editor/pulls/comments/207771448","pull_request_review_id":143449317,"id":207771448,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzc3MTQ0OA==","diff_hunk":"@@ -109,7 +113,7 @@ export default class DataViewer extends React.Component<Props, State> {\n           </button>\n           <div className=\"pagination-wrapper\">{pagination}</div>\n         </div>\n-        <ErrorBoundary>{table}</ErrorBoundary>\n+        {this.props.error ? <span className=\"error\">Something is wrong. Check logs.</span> : table}","path":"src/components/data-viewer/renderer.tsx","position":33,"original_position":33,"commit_id":"2e986b5afde2c4ea66b9cbef780ffbd9ef1b19ee","original_commit_id":"2e986b5afde2c4ea66b9cbef780ffbd9ef1b19ee","user":{"login":"domoritz","id":589034,"node_id":"MDQ6VXNlcjU4OTAzNA==","avatar_url":"https://avatars2.githubusercontent.com/u/589034?v=4","gravatar_id":"","url":"https://api.github.com/users/domoritz","html_url":"https://github.com/domoritz","followers_url":"https://api.github.com/users/domoritz/followers","following_url":"https://api.github.com/users/domoritz/following{/other_user}","gists_url":"https://api.github.com/users/domoritz/gists{/gist_id}","starred_url":"https://api.github.com/users/domoritz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domoritz/subscriptions","organizations_url":"https://api.github.com/users/domoritz/orgs","repos_url":"https://api.github.com/users/domoritz/repos","events_url":"https://api.github.com/users/domoritz/events{/privacy}","received_events_url":"https://api.github.com/users/domoritz/received_events","type":"User","site_admin":false},"body":"This is not a clean solution. The error boundary was good. Please revert this. ","created_at":"2018-08-06T04:28:55Z","updated_at":"2018-08-06T04:29:06Z","html_url":"https://github.com/vega/editor/pull/146#discussion_r207771448","pull_request_url":"https://api.github.com/repos/vega/editor/pulls/146","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/vega/editor/pulls/comments/207771448"},"html":{"href":"https://github.com/vega/editor/pull/146#discussion_r207771448"},"pull_request":{"href":"https://api.github.com/repos/vega/editor/pulls/146"}}},"pull_request":{"url":"https://api.github.com/repos/vega/editor/pulls/146","id":206286126,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2Mjg2MTI2","html_url":"https://github.com/vega/editor/pull/146","diff_url":"https://github.com/vega/editor/pull/146.diff","patch_url":"https://github.com/vega/editor/pull/146.patch","issue_url":"https://api.github.com/repos/vega/editor/issues/146","number":146,"state":"open","locked":false,"title":"Follow-up Fixes: Data-viewer","user":{"login":"ydlamba","id":21237466,"node_id":"MDQ6VXNlcjIxMjM3NDY2","avatar_url":"https://avatars0.githubusercontent.com/u/21237466?v=4","gravatar_id":"","url":"https://api.github.com/users/ydlamba","html_url":"https://github.com/ydlamba","followers_url":"https://api.github.com/users/ydlamba/followers","following_url":"https://api.github.com/users/ydlamba/following{/other_user}","gists_url":"https://api.github.com/users/ydlamba/gists{/gist_id}","starred_url":"https://api.github.com/users/ydlamba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ydlamba/subscriptions","organizations_url":"https://api.github.com/users/ydlamba/orgs","repos_url":"https://api.github.com/users/ydlamba/repos","events_url":"https://api.github.com/users/ydlamba/events{/privacy}","received_events_url":"https://api.github.com/users/ydlamba/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-06T04:27:10Z","updated_at":"2018-08-06T04:29:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ca901df6171f6ec63aa54799a9a0f56c1da229f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vega/editor/pulls/146/commits","review_comments_url":"https://api.github.com/repos/vega/editor/pulls/146/comments","review_comment_url":"https://api.github.com/repos/vega/editor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vega/editor/issues/146/comments","statuses_url":"https://api.github.com/repos/vega/editor/statuses/2e986b5afde2c4ea66b9cbef780ffbd9ef1b19ee","head":{"label":"vega:ydl/followup-fixes","ref":"ydl/followup-fixes","sha":"2e986b5afde2c4ea66b9cbef780ffbd9ef1b19ee","user":{"login":"vega","id":11796929,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzk2OTI5","avatar_url":"https://avatars3.githubusercontent.com/u/11796929?v=4","gravatar_id":"","url":"https://api.github.com/users/vega","html_url":"https://github.com/vega","followers_url":"https://api.github.com/users/vega/followers","following_url":"https://api.github.com/users/vega/following{/other_user}","gists_url":"https://api.github.com/users/vega/gists{/gist_id}","starred_url":"https://api.github.com/users/vega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vega/subscriptions","organizations_url":"https://api.github.com/users/vega/orgs","repos_url":"https://api.github.com/users/vega/repos","events_url":"https://api.github.com/users/vega/events{/privacy}","received_events_url":"https://api.github.com/users/vega/received_events","type":"Organization","site_admin":false},"repo":{"id":93451048,"node_id":"MDEwOlJlcG9zaXRvcnk5MzQ1MTA0OA==","name":"editor","full_name":"vega/editor","owner":{"login":"vega","id":11796929,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzk2OTI5","avatar_url":"https://avatars3.githubusercontent.com/u/11796929?v=4","gravatar_id":"","url":"https://api.github.com/users/vega","html_url":"https://github.com/vega","followers_url":"https://api.github.com/users/vega/followers","following_url":"https://api.github.com/users/vega/following{/other_user}","gists_url":"https://api.github.com/users/vega/gists{/gist_id}","starred_url":"https://api.github.com/users/vega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vega/subscriptions","organizations_url":"https://api.github.com/users/vega/orgs","repos_url":"https://api.github.com/users/vega/repos","events_url":"https://api.github.com/users/vega/events{/privacy}","received_events_url":"https://api.github.com/users/vega/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vega/editor","description":"Editor/IDE for Vega and Vega-Lite","fork":false,"url":"https://api.github.com/repos/vega/editor","forks_url":"https://api.github.com/repos/vega/editor/forks","keys_url":"https://api.github.com/repos/vega/editor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vega/editor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vega/editor/teams","hooks_url":"https://api.github.com/repos/vega/editor/hooks","issue_events_url":"https://api.github.com/repos/vega/editor/issues/events{/number}","events_url":"https://api.github.com/repos/vega/editor/events","assignees_url":"https://api.github.com/repos/vega/editor/assignees{/user}","branches_url":"https://api.github.com/repos/vega/editor/branches{/branch}","tags_url":"https://api.github.com/repos/vega/editor/tags","blobs_url":"https://api.github.com/repos/vega/editor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vega/editor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vega/editor/git/refs{/sha}","trees_url":"https://api.github.com/repos/vega/editor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vega/editor/statuses/{sha}","languages_url":"https://api.github.com/repos/vega/editor/languages","stargazers_url":"https://api.github.com/repos/vega/editor/stargazers","contributors_url":"https://api.github.com/repos/vega/editor/contributors","subscribers_url":"https://api.github.com/repos/vega/editor/subscribers","subscription_url":"https://api.github.com/repos/vega/editor/subscription","commits_url":"https://api.github.com/repos/vega/editor/commits{/sha}","git_commits_url":"https://api.github.com/repos/vega/editor/git/commits{/sha}","comments_url":"https://api.github.com/repos/vega/editor/comments{/number}","issue_comment_url":"https://api.github.com/repos/vega/editor/issues/comments{/number}","contents_url":"https://api.github.com/repos/vega/editor/contents/{+path}","compare_url":"https://api.github.com/repos/vega/editor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vega/editor/merges","archive_url":"https://api.github.com/repos/vega/editor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vega/editor/downloads","issues_url":"https://api.github.com/repos/vega/editor/issues{/number}","pulls_url":"https://api.github.com/repos/vega/editor/pulls{/number}","milestones_url":"https://api.github.com/repos/vega/editor/milestones{/number}","notifications_url":"https://api.github.com/repos/vega/editor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vega/editor/labels{/name}","releases_url":"https://api.github.com/repos/vega/editor/releases{/id}","deployments_url":"https://api.github.com/repos/vega/editor/deployments","created_at":"2017-06-05T22:02:17Z","updated_at":"2018-08-06T02:37:12Z","pushed_at":"2018-08-06T04:27:11Z","git_url":"git://github.com/vega/editor.git","ssh_url":"git@github.com:vega/editor.git","clone_url":"https://github.com/vega/editor.git","svn_url":"https://github.com/vega/editor","homepage":"https://vega.github.io/editor/","size":151311,"stargazers_count":25,"watchers_count":25,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":12,"open_issues":30,"watchers":25,"default_branch":"master"}},"base":{"label":"vega:master","ref":"master","sha":"b1474566a56daad537e00bad795b808b0a4d2951","user":{"login":"vega","id":11796929,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzk2OTI5","avatar_url":"https://avatars3.githubusercontent.com/u/11796929?v=4","gravatar_id":"","url":"https://api.github.com/users/vega","html_url":"https://github.com/vega","followers_url":"https://api.github.com/users/vega/followers","following_url":"https://api.github.com/users/vega/following{/other_user}","gists_url":"https://api.github.com/users/vega/gists{/gist_id}","starred_url":"https://api.github.com/users/vega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vega/subscriptions","organizations_url":"https://api.github.com/users/vega/orgs","repos_url":"https://api.github.com/users/vega/repos","events_url":"https://api.github.com/users/vega/events{/privacy}","received_events_url":"https://api.github.com/users/vega/received_events","type":"Organization","site_admin":false},"repo":{"id":93451048,"node_id":"MDEwOlJlcG9zaXRvcnk5MzQ1MTA0OA==","name":"editor","full_name":"vega/editor","owner":{"login":"vega","id":11796929,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzk2OTI5","avatar_url":"https://avatars3.githubusercontent.com/u/11796929?v=4","gravatar_id":"","url":"https://api.github.com/users/vega","html_url":"https://github.com/vega","followers_url":"https://api.github.com/users/vega/followers","following_url":"https://api.github.com/users/vega/following{/other_user}","gists_url":"https://api.github.com/users/vega/gists{/gist_id}","starred_url":"https://api.github.com/users/vega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vega/subscriptions","organizations_url":"https://api.github.com/users/vega/orgs","repos_url":"https://api.github.com/users/vega/repos","events_url":"https://api.github.com/users/vega/events{/privacy}","received_events_url":"https://api.github.com/users/vega/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vega/editor","description":"Editor/IDE for Vega and Vega-Lite","fork":false,"url":"https://api.github.com/repos/vega/editor","forks_url":"https://api.github.com/repos/vega/editor/forks","keys_url":"https://api.github.com/repos/vega/editor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vega/editor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vega/editor/teams","hooks_url":"https://api.github.com/repos/vega/editor/hooks","issue_events_url":"https://api.github.com/repos/vega/editor/issues/events{/number}","events_url":"https://api.github.com/repos/vega/editor/events","assignees_url":"https://api.github.com/repos/vega/editor/assignees{/user}","branches_url":"https://api.github.com/repos/vega/editor/branches{/branch}","tags_url":"https://api.github.com/repos/vega/editor/tags","blobs_url":"https://api.github.com/repos/vega/editor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vega/editor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vega/editor/git/refs{/sha}","trees_url":"https://api.github.com/repos/vega/editor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vega/editor/statuses/{sha}","languages_url":"https://api.github.com/repos/vega/editor/languages","stargazers_url":"https://api.github.com/repos/vega/editor/stargazers","contributors_url":"https://api.github.com/repos/vega/editor/contributors","subscribers_url":"https://api.github.com/repos/vega/editor/subscribers","subscription_url":"https://api.github.com/repos/vega/editor/subscription","commits_url":"https://api.github.com/repos/vega/editor/commits{/sha}","git_commits_url":"https://api.github.com/repos/vega/editor/git/commits{/sha}","comments_url":"https://api.github.com/repos/vega/editor/comments{/number}","issue_comment_url":"https://api.github.com/repos/vega/editor/issues/comments{/number}","contents_url":"https://api.github.com/repos/vega/editor/contents/{+path}","compare_url":"https://api.github.com/repos/vega/editor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vega/editor/merges","archive_url":"https://api.github.com/repos/vega/editor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vega/editor/downloads","issues_url":"https://api.github.com/repos/vega/editor/issues{/number}","pulls_url":"https://api.github.com/repos/vega/editor/pulls{/number}","milestones_url":"https://api.github.com/repos/vega/editor/milestones{/number}","notifications_url":"https://api.github.com/repos/vega/editor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vega/editor/labels{/name}","releases_url":"https://api.github.com/repos/vega/editor/releases{/id}","deployments_url":"https://api.github.com/repos/vega/editor/deployments","created_at":"2017-06-05T22:02:17Z","updated_at":"2018-08-06T02:37:12Z","pushed_at":"2018-08-06T04:27:11Z","git_url":"git://github.com/vega/editor.git","ssh_url":"git@github.com:vega/editor.git","clone_url":"https://github.com/vega/editor.git","svn_url":"https://github.com/vega/editor","homepage":"https://vega.github.io/editor/","size":151311,"stargazers_count":25,"watchers_count":25,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":12,"open_issues":30,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vega/editor/pulls/146"},"html":{"href":"https://github.com/vega/editor/pull/146"},"issue":{"href":"https://api.github.com/repos/vega/editor/issues/146"},"comments":{"href":"https://api.github.com/repos/vega/editor/issues/146/comments"},"review_comments":{"href":"https://api.github.com/repos/vega/editor/pulls/146/comments"},"review_comment":{"href":"https://api.github.com/repos/vega/editor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vega/editor/pulls/146/commits"},"statuses":{"href":"https://api.github.com/repos/vega/editor/statuses/2e986b5afde2c4ea66b9cbef780ffbd9ef1b19ee"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"domoritz"}}