{"action":"created","comment":{"url":"https://api.github.com/repos/rigetti/rpcq/pulls/comments/238340681","pull_request_review_id":180857994,"id":238340681,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODM0MDY4MQ==","diff_hunk":"@@ -533,78 +210,196 @@ We distinguish between the following options for any field type:\n     tbl))\n \n \n-(defmacro defmessage (class-name field-specs &key (documentation nil))\n-  \"Create a (de-)serializable message definition with name CLASS-NAME and slots (SLOT-SPECS).\"\n+(defmacro defmessage (class-name parent-name field-specs &key (documentation nil))\n+  \"Create a (de-)serializable message definition.  Its class name is CLASS-NAME; its parent message class is named by the list PARENT-NAMES (which is neither () or of length 1); and its slots are specified by FIELD-SPECS.","path":"src/rpcq.lisp","position":null,"original_position":368,"commit_id":"62b37367679b36c778840017780836380358d2df","original_commit_id":"bc74faede022cd39475531b0ab3083a0a3b53adf","user":{"login":"ecp-rigetti","id":30057877,"node_id":"MDQ6VXNlcjMwMDU3ODc3","avatar_url":"https://avatars1.githubusercontent.com/u/30057877?v=4","gravatar_id":"","url":"https://api.github.com/users/ecp-rigetti","html_url":"https://github.com/ecp-rigetti","followers_url":"https://api.github.com/users/ecp-rigetti/followers","following_url":"https://api.github.com/users/ecp-rigetti/following{/other_user}","gists_url":"https://api.github.com/users/ecp-rigetti/gists{/gist_id}","starred_url":"https://api.github.com/users/ecp-rigetti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ecp-rigetti/subscriptions","organizations_url":"https://api.github.com/users/ecp-rigetti/orgs","repos_url":"https://api.github.com/users/ecp-rigetti/repos","events_url":"https://api.github.com/users/ecp-rigetti/events{/privacy}","received_events_url":"https://api.github.com/users/ecp-rigetti/received_events","type":"User","site_admin":false},"body":"The docstring you're referencing doesn't exist anymore, this snippet is `Outdated`.\r\n\r\nIt's a list because (1) I want the syntax to look like `defclass` and (2) no other convention for sending this information to `defmessage` makes any more sense (e.g., `NIL` or a symbol doesn't look any prettier to me).","created_at":"2018-12-03T16:30:56Z","updated_at":"2018-12-03T16:30:57Z","html_url":"https://github.com/rigetti/rpcq/pull/9#discussion_r238340681","pull_request_url":"https://api.github.com/repos/rigetti/rpcq/pulls/9","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/rigetti/rpcq/pulls/comments/238340681"},"html":{"href":"https://github.com/rigetti/rpcq/pull/9#discussion_r238340681"},"pull_request":{"href":"https://api.github.com/repos/rigetti/rpcq/pulls/9"}},"in_reply_to_id":234777156},"pull_request":{"url":"https://api.github.com/repos/rigetti/rpcq/pulls/9","id":225854340,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1ODU0MzQw","html_url":"https://github.com/rigetti/rpcq/pull/9","diff_url":"https://github.com/rigetti/rpcq/pull/9.diff","patch_url":"https://github.com/rigetti/rpcq/pull/9.patch","issue_url":"https://api.github.com/repos/rigetti/rpcq/issues/9","number":9,"state":"open","locked":false,"title":"python3 message generation","user":{"login":"ecp-rigetti","id":30057877,"node_id":"MDQ6VXNlcjMwMDU3ODc3","avatar_url":"https://avatars1.githubusercontent.com/u/30057877?v=4","gravatar_id":"","url":"https://api.github.com/users/ecp-rigetti","html_url":"https://github.com/ecp-rigetti","followers_url":"https://api.github.com/users/ecp-rigetti/followers","following_url":"https://api.github.com/users/ecp-rigetti/following{/other_user}","gists_url":"https://api.github.com/users/ecp-rigetti/gists{/gist_id}","starred_url":"https://api.github.com/users/ecp-rigetti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ecp-rigetti/subscriptions","organizations_url":"https://api.github.com/users/ecp-rigetti/orgs","repos_url":"https://api.github.com/users/ecp-rigetti/repos","events_url":"https://api.github.com/users/ecp-rigetti/events{/privacy}","received_events_url":"https://api.github.com/users/ecp-rigetti/received_events","type":"User","site_admin":false},"body":"This branch contains some new features at the message declaration level: message inheritance and field deprecation. Additionally, following a template laid out by @stevenheidel , this branch contains a python message generator that uses python3 dataclasses.\r\n\r\nIt's not ready for prime time:\r\n\r\n* The handling of deprecated optional fields in the python3 output is not very good.\r\n* It doesn't sort optional/required fields in the python3 output, so previously functioning message definitions generate bad output.\r\n\r\nIt is ready for comment, though.","created_at":"2018-10-25T18:11:22Z","updated_at":"2018-12-03T16:30:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5a01fc0e09b3b4ff31aaa712eba862a9c048056d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rigetti/rpcq/pulls/9/commits","review_comments_url":"https://api.github.com/repos/rigetti/rpcq/pulls/9/comments","review_comment_url":"https://api.github.com/repos/rigetti/rpcq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rigetti/rpcq/issues/9/comments","statuses_url":"https://api.github.com/repos/rigetti/rpcq/statuses/62b37367679b36c778840017780836380358d2df","head":{"label":"ecp-rigetti:feature/better-message-generation","ref":"feature/better-message-generation","sha":"62b37367679b36c778840017780836380358d2df","user":{"login":"ecp-rigetti","id":30057877,"node_id":"MDQ6VXNlcjMwMDU3ODc3","avatar_url":"https://avatars1.githubusercontent.com/u/30057877?v=4","gravatar_id":"","url":"https://api.github.com/users/ecp-rigetti","html_url":"https://github.com/ecp-rigetti","followers_url":"https://api.github.com/users/ecp-rigetti/followers","following_url":"https://api.github.com/users/ecp-rigetti/following{/other_user}","gists_url":"https://api.github.com/users/ecp-rigetti/gists{/gist_id}","starred_url":"https://api.github.com/users/ecp-rigetti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ecp-rigetti/subscriptions","organizations_url":"https://api.github.com/users/ecp-rigetti/orgs","repos_url":"https://api.github.com/users/ecp-rigetti/repos","events_url":"https://api.github.com/users/ecp-rigetti/events{/privacy}","received_events_url":"https://api.github.com/users/ecp-rigetti/received_events","type":"User","site_admin":false},"repo":{"id":153163892,"node_id":"MDEwOlJlcG9zaXRvcnkxNTMxNjM4OTI=","name":"rpcq","full_name":"ecp-rigetti/rpcq","private":false,"owner":{"login":"ecp-rigetti","id":30057877,"node_id":"MDQ6VXNlcjMwMDU3ODc3","avatar_url":"https://avatars1.githubusercontent.com/u/30057877?v=4","gravatar_id":"","url":"https://api.github.com/users/ecp-rigetti","html_url":"https://github.com/ecp-rigetti","followers_url":"https://api.github.com/users/ecp-rigetti/followers","following_url":"https://api.github.com/users/ecp-rigetti/following{/other_user}","gists_url":"https://api.github.com/users/ecp-rigetti/gists{/gist_id}","starred_url":"https://api.github.com/users/ecp-rigetti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ecp-rigetti/subscriptions","organizations_url":"https://api.github.com/users/ecp-rigetti/orgs","repos_url":"https://api.github.com/users/ecp-rigetti/repos","events_url":"https://api.github.com/users/ecp-rigetti/events{/privacy}","received_events_url":"https://api.github.com/users/ecp-rigetti/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ecp-rigetti/rpcq","description":"The RPC framework and message specification for Rigetti QCS.","fork":true,"url":"https://api.github.com/repos/ecp-rigetti/rpcq","forks_url":"https://api.github.com/repos/ecp-rigetti/rpcq/forks","keys_url":"https://api.github.com/repos/ecp-rigetti/rpcq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ecp-rigetti/rpcq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ecp-rigetti/rpcq/teams","hooks_url":"https://api.github.com/repos/ecp-rigetti/rpcq/hooks","issue_events_url":"https://api.github.com/repos/ecp-rigetti/rpcq/issues/events{/number}","events_url":"https://api.github.com/repos/ecp-rigetti/rpcq/events","assignees_url":"https://api.github.com/repos/ecp-rigetti/rpcq/assignees{/user}","branches_url":"https://api.github.com/repos/ecp-rigetti/rpcq/branches{/branch}","tags_url":"https://api.github.com/repos/ecp-rigetti/rpcq/tags","blobs_url":"https://api.github.com/repos/ecp-rigetti/rpcq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ecp-rigetti/rpcq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ecp-rigetti/rpcq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ecp-rigetti/rpcq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ecp-rigetti/rpcq/statuses/{sha}","languages_url":"https://api.github.com/repos/ecp-rigetti/rpcq/languages","stargazers_url":"https://api.github.com/repos/ecp-rigetti/rpcq/stargazers","contributors_url":"https://api.github.com/repos/ecp-rigetti/rpcq/contributors","subscribers_url":"https://api.github.com/repos/ecp-rigetti/rpcq/subscribers","subscription_url":"https://api.github.com/repos/ecp-rigetti/rpcq/subscription","commits_url":"https://api.github.com/repos/ecp-rigetti/rpcq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ecp-rigetti/rpcq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ecp-rigetti/rpcq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ecp-rigetti/rpcq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ecp-rigetti/rpcq/contents/{+path}","compare_url":"https://api.github.com/repos/ecp-rigetti/rpcq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ecp-rigetti/rpcq/merges","archive_url":"https://api.github.com/repos/ecp-rigetti/rpcq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ecp-rigetti/rpcq/downloads","issues_url":"https://api.github.com/repos/ecp-rigetti/rpcq/issues{/number}","pulls_url":"https://api.github.com/repos/ecp-rigetti/rpcq/pulls{/number}","milestones_url":"https://api.github.com/repos/ecp-rigetti/rpcq/milestones{/number}","notifications_url":"https://api.github.com/repos/ecp-rigetti/rpcq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ecp-rigetti/rpcq/labels{/name}","releases_url":"https://api.github.com/repos/ecp-rigetti/rpcq/releases{/id}","deployments_url":"https://api.github.com/repos/ecp-rigetti/rpcq/deployments","created_at":"2018-10-15T18:40:09Z","updated_at":"2018-11-26T14:04:47Z","pushed_at":"2018-12-03T14:30:55Z","git_url":"git://github.com/ecp-rigetti/rpcq.git","ssh_url":"git@github.com:ecp-rigetti/rpcq.git","clone_url":"https://github.com/ecp-rigetti/rpcq.git","svn_url":"https://github.com/ecp-rigetti/rpcq","homepage":"","size":82,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rigetti:master","ref":"master","sha":"27a1da449174511c2a381ab76f07f05ec99b5120","user":{"login":"rigetti","id":16469771,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDY5Nzcx","avatar_url":"https://avatars1.githubusercontent.com/u/16469771?v=4","gravatar_id":"","url":"https://api.github.com/users/rigetti","html_url":"https://github.com/rigetti","followers_url":"https://api.github.com/users/rigetti/followers","following_url":"https://api.github.com/users/rigetti/following{/other_user}","gists_url":"https://api.github.com/users/rigetti/gists{/gist_id}","starred_url":"https://api.github.com/users/rigetti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rigetti/subscriptions","organizations_url":"https://api.github.com/users/rigetti/orgs","repos_url":"https://api.github.com/users/rigetti/repos","events_url":"https://api.github.com/users/rigetti/events{/privacy}","received_events_url":"https://api.github.com/users/rigetti/received_events","type":"Organization","site_admin":false},"repo":{"id":152646040,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI2NDYwNDA=","name":"rpcq","full_name":"rigetti/rpcq","private":false,"owner":{"login":"rigetti","id":16469771,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDY5Nzcx","avatar_url":"https://avatars1.githubusercontent.com/u/16469771?v=4","gravatar_id":"","url":"https://api.github.com/users/rigetti","html_url":"https://github.com/rigetti","followers_url":"https://api.github.com/users/rigetti/followers","following_url":"https://api.github.com/users/rigetti/following{/other_user}","gists_url":"https://api.github.com/users/rigetti/gists{/gist_id}","starred_url":"https://api.github.com/users/rigetti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rigetti/subscriptions","organizations_url":"https://api.github.com/users/rigetti/orgs","repos_url":"https://api.github.com/users/rigetti/repos","events_url":"https://api.github.com/users/rigetti/events{/privacy}","received_events_url":"https://api.github.com/users/rigetti/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rigetti/rpcq","description":"The RPC framework and message specification for Rigetti QCS.","fork":false,"url":"https://api.github.com/repos/rigetti/rpcq","forks_url":"https://api.github.com/repos/rigetti/rpcq/forks","keys_url":"https://api.github.com/repos/rigetti/rpcq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rigetti/rpcq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rigetti/rpcq/teams","hooks_url":"https://api.github.com/repos/rigetti/rpcq/hooks","issue_events_url":"https://api.github.com/repos/rigetti/rpcq/issues/events{/number}","events_url":"https://api.github.com/repos/rigetti/rpcq/events","assignees_url":"https://api.github.com/repos/rigetti/rpcq/assignees{/user}","branches_url":"https://api.github.com/repos/rigetti/rpcq/branches{/branch}","tags_url":"https://api.github.com/repos/rigetti/rpcq/tags","blobs_url":"https://api.github.com/repos/rigetti/rpcq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rigetti/rpcq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rigetti/rpcq/git/refs{/sha}","trees_url":"https://api.github.com/repos/rigetti/rpcq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rigetti/rpcq/statuses/{sha}","languages_url":"https://api.github.com/repos/rigetti/rpcq/languages","stargazers_url":"https://api.github.com/repos/rigetti/rpcq/stargazers","contributors_url":"https://api.github.com/repos/rigetti/rpcq/contributors","subscribers_url":"https://api.github.com/repos/rigetti/rpcq/subscribers","subscription_url":"https://api.github.com/repos/rigetti/rpcq/subscription","commits_url":"https://api.github.com/repos/rigetti/rpcq/commits{/sha}","git_commits_url":"https://api.github.com/repos/rigetti/rpcq/git/commits{/sha}","comments_url":"https://api.github.com/repos/rigetti/rpcq/comments{/number}","issue_comment_url":"https://api.github.com/repos/rigetti/rpcq/issues/comments{/number}","contents_url":"https://api.github.com/repos/rigetti/rpcq/contents/{+path}","compare_url":"https://api.github.com/repos/rigetti/rpcq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rigetti/rpcq/merges","archive_url":"https://api.github.com/repos/rigetti/rpcq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rigetti/rpcq/downloads","issues_url":"https://api.github.com/repos/rigetti/rpcq/issues{/number}","pulls_url":"https://api.github.com/repos/rigetti/rpcq/pulls{/number}","milestones_url":"https://api.github.com/repos/rigetti/rpcq/milestones{/number}","notifications_url":"https://api.github.com/repos/rigetti/rpcq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rigetti/rpcq/labels{/name}","releases_url":"https://api.github.com/repos/rigetti/rpcq/releases{/id}","deployments_url":"https://api.github.com/repos/rigetti/rpcq/deployments","created_at":"2018-10-11T19:38:34Z","updated_at":"2018-11-26T17:50:20Z","pushed_at":"2018-12-03T14:30:58Z","git_url":"git://github.com/rigetti/rpcq.git","ssh_url":"git@github.com:rigetti/rpcq.git","clone_url":"https://github.com/rigetti/rpcq.git","svn_url":"https://github.com/rigetti/rpcq","homepage":"","size":66,"stargazers_count":18,"watchers_count":18,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5,"open_issues":5,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rigetti/rpcq/pulls/9"},"html":{"href":"https://github.com/rigetti/rpcq/pull/9"},"issue":{"href":"https://api.github.com/repos/rigetti/rpcq/issues/9"},"comments":{"href":"https://api.github.com/repos/rigetti/rpcq/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/rigetti/rpcq/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/rigetti/rpcq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rigetti/rpcq/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/rigetti/rpcq/statuses/62b37367679b36c778840017780836380358d2df"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"ecp-rigetti"}}