{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/verify-service-provider/pulls/comments/230709287","pull_request_review_id":171503880,"id":230709287,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDcwOTI4Nw==","diff_hunk":"@@ -15,28 +15,31 @@\n import org.opensaml.xmlsec.signature.Signature;\n import uk.gov.ida.saml.core.IdaSamlBootstrap;\n \n+import uk.gov.ida.saml.core.domain.AuthnContext;\n+import uk.gov.ida.saml.core.domain.MatchingDataset;\n import uk.gov.ida.saml.core.extensions.IdaAuthnContext;\n import uk.gov.ida.saml.core.test.TestCredentialFactory;\n import uk.gov.ida.saml.core.test.builders.AssertionBuilder;\n+import uk.gov.ida.saml.core.transformers.AuthnContextFactory;\n import uk.gov.ida.saml.core.transformers.VerifyMatchingDatasetUnmarshaller;\n \n import uk.gov.ida.saml.core.validators.assertion.AssertionAttributeStatementValidator;\n import uk.gov.ida.saml.security.SamlAssertionsSignatureValidator;\n import uk.gov.ida.saml.security.validators.ValidatedAssertions;\n import uk.gov.ida.shared.utils.datetime.DateTimeFreezer;\n+import uk.gov.ida.verifyserviceprovider.domain.AssertionData;\n import uk.gov.ida.verifyserviceprovider.dto.LevelOfAssurance;\n import uk.gov.ida.verifyserviceprovider.exceptions.SamlResponseValidationException;\n+import uk.gov.ida.verifyserviceprovider.services.AssertionClassifier;\n import uk.gov.ida.verifyserviceprovider.services.NonMatchingAssertionService;\n-import uk.gov.ida.verifyserviceprovider.validators.AssertionValidator;\n-import uk.gov.ida.verifyserviceprovider.validators.ConditionsValidator;\n-import uk.gov.ida.verifyserviceprovider.validators.InstantValidator;\n import uk.gov.ida.verifyserviceprovider.validators.SubjectValidator;\n \n+import java.util.Arrays;\n import java.util.List;\n \n import static java.util.Arrays.asList;\n import static java.util.Collections.emptyList;\n-import static org.assertj.core.api.Assertions.assertThat;\n+import static org.assertj.core.api.Java6Assertions.assertThat;","path":"src/test/java/unit/uk/gov/ida/verifyserviceprovider/services/NonMatchingAssertionServiceTest.java","position":32,"original_position":32,"commit_id":"652d04dc3094c84dcc7f8a3c0b53073608ba3572","original_commit_id":"652d04dc3094c84dcc7f8a3c0b53073608ba3572","user":{"login":"andy-paine","id":14118619,"node_id":"MDQ6VXNlcjE0MTE4NjE5","avatar_url":"https://avatars3.githubusercontent.com/u/14118619?v=4","gravatar_id":"","url":"https://api.github.com/users/andy-paine","html_url":"https://github.com/andy-paine","followers_url":"https://api.github.com/users/andy-paine/followers","following_url":"https://api.github.com/users/andy-paine/following{/other_user}","gists_url":"https://api.github.com/users/andy-paine/gists{/gist_id}","starred_url":"https://api.github.com/users/andy-paine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy-paine/subscriptions","organizations_url":"https://api.github.com/users/andy-paine/orgs","repos_url":"https://api.github.com/users/andy-paine/repos","events_url":"https://api.github.com/users/andy-paine/events{/privacy}","received_events_url":"https://api.github.com/users/andy-paine/received_events","type":"User","site_admin":false},"body":"Probably want to keep using `org.assertj.core.api.Assertions.assertThat` rather than Java6","created_at":"2018-11-05T10:58:15Z","updated_at":"2018-11-05T10:58:16Z","html_url":"https://github.com/alphagov/verify-service-provider/pull/106#discussion_r230709287","pull_request_url":"https://api.github.com/repos/alphagov/verify-service-provider/pulls/106","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/alphagov/verify-service-provider/pulls/comments/230709287"},"html":{"href":"https://github.com/alphagov/verify-service-provider/pull/106#discussion_r230709287"},"pull_request":{"href":"https://api.github.com/repos/alphagov/verify-service-provider/pulls/106"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/verify-service-provider/pulls/106","id":227197115,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MTk3MTE1","html_url":"https://github.com/alphagov/verify-service-provider/pull/106","diff_url":"https://github.com/alphagov/verify-service-provider/pull/106.diff","patch_url":"https://github.com/alphagov/verify-service-provider/pull/106.patch","issue_url":"https://api.github.com/repos/alphagov/verify-service-provider/issues/106","number":106,"state":"open","locked":false,"title":"KBddnTLg translate assertions in the vsp","user":{"login":"jkunle","id":3749690,"node_id":"MDQ6VXNlcjM3NDk2OTA=","avatar_url":"https://avatars2.githubusercontent.com/u/3749690?v=4","gravatar_id":"","url":"https://api.github.com/users/jkunle","html_url":"https://github.com/jkunle","followers_url":"https://api.github.com/users/jkunle/followers","following_url":"https://api.github.com/users/jkunle/following{/other_user}","gists_url":"https://api.github.com/users/jkunle/gists{/gist_id}","starred_url":"https://api.github.com/users/jkunle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkunle/subscriptions","organizations_url":"https://api.github.com/users/jkunle/orgs","repos_url":"https://api.github.com/users/jkunle/repos","events_url":"https://api.github.com/users/jkunle/events{/privacy}","received_events_url":"https://api.github.com/users/jkunle/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-31T08:29:08Z","updated_at":"2018-11-05T10:58:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da67cb2432b1eea45a9c82c7f6343ad89c4fc363","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/verify-service-provider/pulls/106/commits","review_comments_url":"https://api.github.com/repos/alphagov/verify-service-provider/pulls/106/comments","review_comment_url":"https://api.github.com/repos/alphagov/verify-service-provider/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/verify-service-provider/issues/106/comments","statuses_url":"https://api.github.com/repos/alphagov/verify-service-provider/statuses/652d04dc3094c84dcc7f8a3c0b53073608ba3572","head":{"label":"alphagov:KBddnTLg-translate-assertions-in-the-vsp","ref":"KBddnTLg-translate-assertions-in-the-vsp","sha":"652d04dc3094c84dcc7f8a3c0b53073608ba3572","user":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":97612449,"node_id":"MDEwOlJlcG9zaXRvcnk5NzYxMjQ0OQ==","name":"verify-service-provider","full_name":"alphagov/verify-service-provider","private":false,"owner":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/alphagov/verify-service-provider","description":":crown: :ballot_box_with_check: The easiest way to connect to GOV.UK Verify","fork":false,"url":"https://api.github.com/repos/alphagov/verify-service-provider","forks_url":"https://api.github.com/repos/alphagov/verify-service-provider/forks","keys_url":"https://api.github.com/repos/alphagov/verify-service-provider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/verify-service-provider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/verify-service-provider/teams","hooks_url":"https://api.github.com/repos/alphagov/verify-service-provider/hooks","issue_events_url":"https://api.github.com/repos/alphagov/verify-service-provider/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/verify-service-provider/events","assignees_url":"https://api.github.com/repos/alphagov/verify-service-provider/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/verify-service-provider/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/verify-service-provider/tags","blobs_url":"https://api.github.com/repos/alphagov/verify-service-provider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/verify-service-provider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/verify-service-provider/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/verify-service-provider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/verify-service-provider/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/verify-service-provider/languages","stargazers_url":"https://api.github.com/repos/alphagov/verify-service-provider/stargazers","contributors_url":"https://api.github.com/repos/alphagov/verify-service-provider/contributors","subscribers_url":"https://api.github.com/repos/alphagov/verify-service-provider/subscribers","subscription_url":"https://api.github.com/repos/alphagov/verify-service-provider/subscription","commits_url":"https://api.github.com/repos/alphagov/verify-service-provider/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/verify-service-provider/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/verify-service-provider/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/verify-service-provider/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/verify-service-provider/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/verify-service-provider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/verify-service-provider/merges","archive_url":"https://api.github.com/repos/alphagov/verify-service-provider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/verify-service-provider/downloads","issues_url":"https://api.github.com/repos/alphagov/verify-service-provider/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/verify-service-provider/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/verify-service-provider/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/verify-service-provider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/verify-service-provider/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/verify-service-provider/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/verify-service-provider/deployments","created_at":"2017-07-18T15:04:41Z","updated_at":"2018-11-01T16:28:32Z","pushed_at":"2018-11-02T18:45:37Z","git_url":"git://github.com/alphagov/verify-service-provider.git","ssh_url":"git@github.com:alphagov/verify-service-provider.git","clone_url":"https://github.com/alphagov/verify-service-provider.git","svn_url":"https://github.com/alphagov/verify-service-provider","homepage":"","size":2004,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":7,"open_issues":4,"watchers":7,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"f3e6ccae73bd5e6551382d0d9363111b51b2ca9f","user":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":97612449,"node_id":"MDEwOlJlcG9zaXRvcnk5NzYxMjQ0OQ==","name":"verify-service-provider","full_name":"alphagov/verify-service-provider","private":false,"owner":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/alphagov/verify-service-provider","description":":crown: :ballot_box_with_check: The easiest way to connect to GOV.UK Verify","fork":false,"url":"https://api.github.com/repos/alphagov/verify-service-provider","forks_url":"https://api.github.com/repos/alphagov/verify-service-provider/forks","keys_url":"https://api.github.com/repos/alphagov/verify-service-provider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/verify-service-provider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/verify-service-provider/teams","hooks_url":"https://api.github.com/repos/alphagov/verify-service-provider/hooks","issue_events_url":"https://api.github.com/repos/alphagov/verify-service-provider/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/verify-service-provider/events","assignees_url":"https://api.github.com/repos/alphagov/verify-service-provider/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/verify-service-provider/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/verify-service-provider/tags","blobs_url":"https://api.github.com/repos/alphagov/verify-service-provider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/verify-service-provider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/verify-service-provider/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/verify-service-provider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/verify-service-provider/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/verify-service-provider/languages","stargazers_url":"https://api.github.com/repos/alphagov/verify-service-provider/stargazers","contributors_url":"https://api.github.com/repos/alphagov/verify-service-provider/contributors","subscribers_url":"https://api.github.com/repos/alphagov/verify-service-provider/subscribers","subscription_url":"https://api.github.com/repos/alphagov/verify-service-provider/subscription","commits_url":"https://api.github.com/repos/alphagov/verify-service-provider/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/verify-service-provider/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/verify-service-provider/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/verify-service-provider/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/verify-service-provider/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/verify-service-provider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/verify-service-provider/merges","archive_url":"https://api.github.com/repos/alphagov/verify-service-provider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/verify-service-provider/downloads","issues_url":"https://api.github.com/repos/alphagov/verify-service-provider/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/verify-service-provider/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/verify-service-provider/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/verify-service-provider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/verify-service-provider/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/verify-service-provider/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/verify-service-provider/deployments","created_at":"2017-07-18T15:04:41Z","updated_at":"2018-11-01T16:28:32Z","pushed_at":"2018-11-02T18:45:37Z","git_url":"git://github.com/alphagov/verify-service-provider.git","ssh_url":"git@github.com:alphagov/verify-service-provider.git","clone_url":"https://github.com/alphagov/verify-service-provider.git","svn_url":"https://github.com/alphagov/verify-service-provider","homepage":"","size":2004,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":7,"open_issues":4,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/verify-service-provider/pulls/106"},"html":{"href":"https://github.com/alphagov/verify-service-provider/pull/106"},"issue":{"href":"https://api.github.com/repos/alphagov/verify-service-provider/issues/106"},"comments":{"href":"https://api.github.com/repos/alphagov/verify-service-provider/issues/106/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/verify-service-provider/pulls/106/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/verify-service-provider/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/verify-service-provider/pulls/106/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/verify-service-provider/statuses/652d04dc3094c84dcc7f8a3c0b53073608ba3572"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"andy-paine"}}