{"action":"created","issue":{"url":"https://api.github.com/repos/helm/charts/issues/9624","repository_url":"https://api.github.com/repos/helm/charts","labels_url":"https://api.github.com/repos/helm/charts/issues/9624/labels{/name}","comments_url":"https://api.github.com/repos/helm/charts/issues/9624/comments","events_url":"https://api.github.com/repos/helm/charts/issues/9624/events","html_url":"https://github.com/helm/charts/pull/9624","id":385671255,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NTg2NjQy","number":9624,"title":"[stable/mysqldump] several changes ","user":{"login":"monotek","id":1069919,"node_id":"MDQ6VXNlcjEwNjk5MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/1069919?v=4","gravatar_id":"","url":"https://api.github.com/users/monotek","html_url":"https://github.com/monotek","followers_url":"https://api.github.com/users/monotek/followers","following_url":"https://api.github.com/users/monotek/following{/other_user}","gists_url":"https://api.github.com/users/monotek/gists{/gist_id}","starred_url":"https://api.github.com/users/monotek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monotek/subscriptions","organizations_url":"https://api.github.com/users/monotek/orgs","repos_url":"https://api.github.com/users/monotek/repos","events_url":"https://api.github.com/users/monotek/events{/privacy}","received_events_url":"https://api.github.com/users/monotek/received_events","type":"User","site_admin":false},"labels":[{"id":1037076588,"node_id":"MDU6TGFiZWwxMDM3MDc2NTg4","url":"https://api.github.com/repos/helm/charts/labels/Contribution%20Allowed","name":"Contribution Allowed","color":"3df47d","default":false},{"id":676596499,"node_id":"MDU6TGFiZWw2NzY1OTY0OTk=","url":"https://api.github.com/repos/helm/charts/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":{"login":"paulczar","id":2488346,"node_id":"MDQ6VXNlcjI0ODgzNDY=","avatar_url":"https://avatars2.githubusercontent.com/u/2488346?v=4","gravatar_id":"","url":"https://api.github.com/users/paulczar","html_url":"https://github.com/paulczar","followers_url":"https://api.github.com/users/paulczar/followers","following_url":"https://api.github.com/users/paulczar/following{/other_user}","gists_url":"https://api.github.com/users/paulczar/gists{/gist_id}","starred_url":"https://api.github.com/users/paulczar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulczar/subscriptions","organizations_url":"https://api.github.com/users/paulczar/orgs","repos_url":"https://api.github.com/users/paulczar/repos","events_url":"https://api.github.com/users/paulczar/events{/privacy}","received_events_url":"https://api.github.com/users/paulczar/received_events","type":"User","site_admin":false},"assignees":[{"login":"mattfarina","id":62991,"node_id":"MDQ6VXNlcjYyOTkx","avatar_url":"https://avatars2.githubusercontent.com/u/62991?v=4","gravatar_id":"","url":"https://api.github.com/users/mattfarina","html_url":"https://github.com/mattfarina","followers_url":"https://api.github.com/users/mattfarina/followers","following_url":"https://api.github.com/users/mattfarina/following{/other_user}","gists_url":"https://api.github.com/users/mattfarina/gists{/gist_id}","starred_url":"https://api.github.com/users/mattfarina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattfarina/subscriptions","organizations_url":"https://api.github.com/users/mattfarina/orgs","repos_url":"https://api.github.com/users/mattfarina/repos","events_url":"https://api.github.com/users/mattfarina/events{/privacy}","received_events_url":"https://api.github.com/users/mattfarina/received_events","type":"User","site_admin":false},{"login":"paulczar","id":2488346,"node_id":"MDQ6VXNlcjI0ODgzNDY=","avatar_url":"https://avatars2.githubusercontent.com/u/2488346?v=4","gravatar_id":"","url":"https://api.github.com/users/paulczar","html_url":"https://github.com/paulczar","followers_url":"https://api.github.com/users/paulczar/followers","following_url":"https://api.github.com/users/paulczar/following{/other_user}","gists_url":"https://api.github.com/users/paulczar/gists{/gist_id}","starred_url":"https://api.github.com/users/paulczar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulczar/subscriptions","organizations_url":"https://api.github.com/users/paulczar/orgs","repos_url":"https://api.github.com/users/paulczar/repos","events_url":"https://api.github.com/users/paulczar/events{/privacy}","received_events_url":"https://api.github.com/users/paulczar/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2018-11-29T10:38:01Z","updated_at":"2018-12-04T17:38:51Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/helm/charts/pulls/9624","html_url":"https://github.com/helm/charts/pull/9624","diff_url":"https://github.com/helm/charts/pull/9624.diff","patch_url":"https://github.com/helm/charts/pull/9624.patch"},"body":"<!--\r\nThank you for contributing to helm/charts. Before you submit this PR we'd like to\r\nmake sure you are aware of our technical requirements and best practices:\r\n\r\n* https://github.com/helm/charts/blob/master/CONTRIBUTING.md#technical-requirements\r\n* https://github.com/helm/helm/tree/master/docs/chart_best_practices\r\n\r\nFor a quick overview across what we will look at reviewing your PR, please read\r\nour review guidelines:\r\n\r\n* https://github.com/helm/charts/blob/master/REVIEW_GUIDELINES.md\r\n\r\nFollowing our best practices right from the start will accelerate the review process and\r\nhelp get your PR merged quicker.\r\n\r\nWhen updates to your PR are requested, please add new commits and do not squash the\r\nhistory. This will make it easier to identify new changes. The PR will be squashed\r\nanyways when it is merged. Thanks.\r\n\r\nFor fast feedback, please @-mention maintainers that are listed in the Chart.yaml file.\r\nPlease make sure you test your changes before you push them. Once pushed, a CircleCI\r\nwill run across your changes and do some initial checks and linting. These checks run\r\nvery quickly. Please check the results. We would like these checks to pass before we\r\neven continue reviewing your changes.\r\n-->\r\n\r\n#### What this PR does / why we need it:\r\n* added gzip compression\r\n* added single db backups\r\n* added split db backups to single backup files\r\n* added ssh upload\r\n* added google storage bucket upload\r\n* added houskeeping (delete old backups in pvc and on remote)\r\n* changed docker image to have google cloud sdk available\r\n* added resource limits config options\r\n* added affinity & tolerations config options\r\n* renamed template files\r\n* changed default backup time to 03:00\r\n* changed app version to reflect helm chart version not mysql client version\r\n* changed labels the helm 2.11 way\r\n\r\n\r\n#### Which issue this PR fixes\r\n*(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*\r\n  - fixes #\r\n\r\n#### Special notes for your reviewer:\r\n\r\n#### Checklist\r\n[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]\r\n- [x] [DCO](https://www.helm.sh/blog/helm-dco/index.html) signed\r\n- [x] Chart Version bumped\r\n- [x] Variables are documented in the README.md\r\n"},"comment":{"url":"https://api.github.com/repos/helm/charts/issues/comments/444189122","html_url":"https://github.com/helm/charts/pull/9624#issuecomment-444189122","issue_url":"https://api.github.com/repos/helm/charts/issues/9624","id":444189122,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NDE4OTEyMg==","user":{"login":"monotek","id":1069919,"node_id":"MDQ6VXNlcjEwNjk5MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/1069919?v=4","gravatar_id":"","url":"https://api.github.com/users/monotek","html_url":"https://github.com/monotek","followers_url":"https://api.github.com/users/monotek/followers","following_url":"https://api.github.com/users/monotek/following{/other_user}","gists_url":"https://api.github.com/users/monotek/gists{/gist_id}","starred_url":"https://api.github.com/users/monotek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monotek/subscriptions","organizations_url":"https://api.github.com/users/monotek/orgs","repos_url":"https://api.github.com/users/monotek/repos","events_url":"https://api.github.com/users/monotek/events{/privacy}","received_events_url":"https://api.github.com/users/monotek/received_events","type":"User","site_admin":false},"created_at":"2018-12-04T17:38:51Z","updated_at":"2018-12-04T17:38:51Z","author_association":"CONTRIBUTOR","body":"/assign @davidkarlsen"}}
{"actor":{"display_login":"monotek"}}