{"action":"created","comment":{"url":"https://api.github.com/repos/machinebox/graphql/pulls/comments/225234176","pull_request_review_id":164791553,"id":225234176,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTIzNDE3Ng==","diff_hunk":"@@ -42,6 +42,8 @@ import (\n \t\"github.com/pkg/errors\"\n )\n \n+const errorNon200Template = \"graphql: server returned a non-200 status code: %v\"","path":"graphql.go","position":null,"original_position":4,"commit_id":"6a25cc387dc44df464457e857ed50c1a50ac83f1","original_commit_id":"9835de6386a382ad4ee4c16c23742f7d658adc21","user":{"login":"erutherford","id":1719563,"node_id":"MDQ6VXNlcjE3MTk1NjM=","avatar_url":"https://avatars0.githubusercontent.com/u/1719563?v=4","gravatar_id":"","url":"https://api.github.com/users/erutherford","html_url":"https://github.com/erutherford","followers_url":"https://api.github.com/users/erutherford/followers","following_url":"https://api.github.com/users/erutherford/following{/other_user}","gists_url":"https://api.github.com/users/erutherford/gists{/gist_id}","starred_url":"https://api.github.com/users/erutherford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erutherford/subscriptions","organizations_url":"https://api.github.com/users/erutherford/orgs","repos_url":"https://api.github.com/users/erutherford/repos","events_url":"https://api.github.com/users/erutherford/events{/privacy}","received_events_url":"https://api.github.com/users/erutherford/received_events","type":"User","site_admin":false},"body":"thanks @matryer, I pulled the constant and duplicated the string.","created_at":"2018-10-15T16:33:10Z","updated_at":"2018-10-15T16:33:10Z","html_url":"https://github.com/machinebox/graphql/pull/19#discussion_r225234176","pull_request_url":"https://api.github.com/repos/machinebox/graphql/pulls/19","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/machinebox/graphql/pulls/comments/225234176"},"html":{"href":"https://github.com/machinebox/graphql/pull/19#discussion_r225234176"},"pull_request":{"href":"https://api.github.com/repos/machinebox/graphql/pulls/19"}},"in_reply_to_id":225096950},"pull_request":{"url":"https://api.github.com/repos/machinebox/graphql/pulls/19","id":212505707,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNTA1NzA3","html_url":"https://github.com/machinebox/graphql/pull/19","diff_url":"https://github.com/machinebox/graphql/pull/19.diff","patch_url":"https://github.com/machinebox/graphql/pull/19.patch","issue_url":"https://api.github.com/repos/machinebox/graphql/issues/19","number":19,"state":"open","locked":false,"title":"8 - Provide clearer error for non-200 status codes without JSON","user":{"login":"erutherford","id":1719563,"node_id":"MDQ6VXNlcjE3MTk1NjM=","avatar_url":"https://avatars0.githubusercontent.com/u/1719563?v=4","gravatar_id":"","url":"https://api.github.com/users/erutherford","html_url":"https://github.com/erutherford","followers_url":"https://api.github.com/users/erutherford/followers","following_url":"https://api.github.com/users/erutherford/following{/other_user}","gists_url":"https://api.github.com/users/erutherford/gists{/gist_id}","starred_url":"https://api.github.com/users/erutherford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erutherford/subscriptions","organizations_url":"https://api.github.com/users/erutherford/orgs","repos_url":"https://api.github.com/users/erutherford/repos","events_url":"https://api.github.com/users/erutherford/events{/privacy}","received_events_url":"https://api.github.com/users/erutherford/received_events","type":"User","site_admin":false},"body":"# What\r\n- This adds a check for a non-200 status code if there's a failure to unmarshal the response from the server.\r\n-  Added tests to confirm the current behavior of returning the first error in the index if it is able to parse the response.\r\n\r\nmachinebox#8","created_at":"2018-08-31T22:19:18Z","updated_at":"2018-10-15T16:33:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f9655efedf90863dba0847b87f35e760be06519","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/machinebox/graphql/pulls/19/commits","review_comments_url":"https://api.github.com/repos/machinebox/graphql/pulls/19/comments","review_comment_url":"https://api.github.com/repos/machinebox/graphql/pulls/comments{/number}","comments_url":"https://api.github.com/repos/machinebox/graphql/issues/19/comments","statuses_url":"https://api.github.com/repos/machinebox/graphql/statuses/6a25cc387dc44df464457e857ed50c1a50ac83f1","head":{"label":"erutherford:8-check-status-code","ref":"8-check-status-code","sha":"6a25cc387dc44df464457e857ed50c1a50ac83f1","user":{"login":"erutherford","id":1719563,"node_id":"MDQ6VXNlcjE3MTk1NjM=","avatar_url":"https://avatars0.githubusercontent.com/u/1719563?v=4","gravatar_id":"","url":"https://api.github.com/users/erutherford","html_url":"https://github.com/erutherford","followers_url":"https://api.github.com/users/erutherford/followers","following_url":"https://api.github.com/users/erutherford/following{/other_user}","gists_url":"https://api.github.com/users/erutherford/gists{/gist_id}","starred_url":"https://api.github.com/users/erutherford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erutherford/subscriptions","organizations_url":"https://api.github.com/users/erutherford/orgs","repos_url":"https://api.github.com/users/erutherford/repos","events_url":"https://api.github.com/users/erutherford/events{/privacy}","received_events_url":"https://api.github.com/users/erutherford/received_events","type":"User","site_admin":false},"repo":{"id":146945220,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY5NDUyMjA=","name":"graphql","full_name":"erutherford/graphql","private":false,"owner":{"login":"erutherford","id":1719563,"node_id":"MDQ6VXNlcjE3MTk1NjM=","avatar_url":"https://avatars0.githubusercontent.com/u/1719563?v=4","gravatar_id":"","url":"https://api.github.com/users/erutherford","html_url":"https://github.com/erutherford","followers_url":"https://api.github.com/users/erutherford/followers","following_url":"https://api.github.com/users/erutherford/following{/other_user}","gists_url":"https://api.github.com/users/erutherford/gists{/gist_id}","starred_url":"https://api.github.com/users/erutherford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erutherford/subscriptions","organizations_url":"https://api.github.com/users/erutherford/orgs","repos_url":"https://api.github.com/users/erutherford/repos","events_url":"https://api.github.com/users/erutherford/events{/privacy}","received_events_url":"https://api.github.com/users/erutherford/received_events","type":"User","site_admin":false},"html_url":"https://github.com/erutherford/graphql","description":"Simple low-level GraphQL HTTP client for Go","fork":true,"url":"https://api.github.com/repos/erutherford/graphql","forks_url":"https://api.github.com/repos/erutherford/graphql/forks","keys_url":"https://api.github.com/repos/erutherford/graphql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erutherford/graphql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erutherford/graphql/teams","hooks_url":"https://api.github.com/repos/erutherford/graphql/hooks","issue_events_url":"https://api.github.com/repos/erutherford/graphql/issues/events{/number}","events_url":"https://api.github.com/repos/erutherford/graphql/events","assignees_url":"https://api.github.com/repos/erutherford/graphql/assignees{/user}","branches_url":"https://api.github.com/repos/erutherford/graphql/branches{/branch}","tags_url":"https://api.github.com/repos/erutherford/graphql/tags","blobs_url":"https://api.github.com/repos/erutherford/graphql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erutherford/graphql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erutherford/graphql/git/refs{/sha}","trees_url":"https://api.github.com/repos/erutherford/graphql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erutherford/graphql/statuses/{sha}","languages_url":"https://api.github.com/repos/erutherford/graphql/languages","stargazers_url":"https://api.github.com/repos/erutherford/graphql/stargazers","contributors_url":"https://api.github.com/repos/erutherford/graphql/contributors","subscribers_url":"https://api.github.com/repos/erutherford/graphql/subscribers","subscription_url":"https://api.github.com/repos/erutherford/graphql/subscription","commits_url":"https://api.github.com/repos/erutherford/graphql/commits{/sha}","git_commits_url":"https://api.github.com/repos/erutherford/graphql/git/commits{/sha}","comments_url":"https://api.github.com/repos/erutherford/graphql/comments{/number}","issue_comment_url":"https://api.github.com/repos/erutherford/graphql/issues/comments{/number}","contents_url":"https://api.github.com/repos/erutherford/graphql/contents/{+path}","compare_url":"https://api.github.com/repos/erutherford/graphql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erutherford/graphql/merges","archive_url":"https://api.github.com/repos/erutherford/graphql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erutherford/graphql/downloads","issues_url":"https://api.github.com/repos/erutherford/graphql/issues{/number}","pulls_url":"https://api.github.com/repos/erutherford/graphql/pulls{/number}","milestones_url":"https://api.github.com/repos/erutherford/graphql/milestones{/number}","notifications_url":"https://api.github.com/repos/erutherford/graphql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erutherford/graphql/labels{/name}","releases_url":"https://api.github.com/repos/erutherford/graphql/releases{/id}","deployments_url":"https://api.github.com/repos/erutherford/graphql/deployments","created_at":"2018-08-31T21:49:04Z","updated_at":"2018-08-31T21:49:06Z","pushed_at":"2018-10-15T16:31:08Z","git_url":"git://github.com/erutherford/graphql.git","ssh_url":"git@github.com:erutherford/graphql.git","clone_url":"https://github.com/erutherford/graphql.git","svn_url":"https://github.com/erutherford/graphql","homepage":"https://blog.machinebox.io/a-graphql-client-library-for-go-5bffd0455878","size":45,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"machinebox:master","ref":"master","sha":"05b17f3157491bbfa5d6fc2006443a272d960d15","user":{"login":"machinebox","id":25792946,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NzkyOTQ2","avatar_url":"https://avatars3.githubusercontent.com/u/25792946?v=4","gravatar_id":"","url":"https://api.github.com/users/machinebox","html_url":"https://github.com/machinebox","followers_url":"https://api.github.com/users/machinebox/followers","following_url":"https://api.github.com/users/machinebox/following{/other_user}","gists_url":"https://api.github.com/users/machinebox/gists{/gist_id}","starred_url":"https://api.github.com/users/machinebox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/machinebox/subscriptions","organizations_url":"https://api.github.com/users/machinebox/orgs","repos_url":"https://api.github.com/users/machinebox/repos","events_url":"https://api.github.com/users/machinebox/events{/privacy}","received_events_url":"https://api.github.com/users/machinebox/received_events","type":"Organization","site_admin":false},"repo":{"id":113361906,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMzNjE5MDY=","name":"graphql","full_name":"machinebox/graphql","private":false,"owner":{"login":"machinebox","id":25792946,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NzkyOTQ2","avatar_url":"https://avatars3.githubusercontent.com/u/25792946?v=4","gravatar_id":"","url":"https://api.github.com/users/machinebox","html_url":"https://github.com/machinebox","followers_url":"https://api.github.com/users/machinebox/followers","following_url":"https://api.github.com/users/machinebox/following{/other_user}","gists_url":"https://api.github.com/users/machinebox/gists{/gist_id}","starred_url":"https://api.github.com/users/machinebox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/machinebox/subscriptions","organizations_url":"https://api.github.com/users/machinebox/orgs","repos_url":"https://api.github.com/users/machinebox/repos","events_url":"https://api.github.com/users/machinebox/events{/privacy}","received_events_url":"https://api.github.com/users/machinebox/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/machinebox/graphql","description":"Simple low-level GraphQL HTTP client for Go","fork":false,"url":"https://api.github.com/repos/machinebox/graphql","forks_url":"https://api.github.com/repos/machinebox/graphql/forks","keys_url":"https://api.github.com/repos/machinebox/graphql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/machinebox/graphql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/machinebox/graphql/teams","hooks_url":"https://api.github.com/repos/machinebox/graphql/hooks","issue_events_url":"https://api.github.com/repos/machinebox/graphql/issues/events{/number}","events_url":"https://api.github.com/repos/machinebox/graphql/events","assignees_url":"https://api.github.com/repos/machinebox/graphql/assignees{/user}","branches_url":"https://api.github.com/repos/machinebox/graphql/branches{/branch}","tags_url":"https://api.github.com/repos/machinebox/graphql/tags","blobs_url":"https://api.github.com/repos/machinebox/graphql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/machinebox/graphql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/machinebox/graphql/git/refs{/sha}","trees_url":"https://api.github.com/repos/machinebox/graphql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/machinebox/graphql/statuses/{sha}","languages_url":"https://api.github.com/repos/machinebox/graphql/languages","stargazers_url":"https://api.github.com/repos/machinebox/graphql/stargazers","contributors_url":"https://api.github.com/repos/machinebox/graphql/contributors","subscribers_url":"https://api.github.com/repos/machinebox/graphql/subscribers","subscription_url":"https://api.github.com/repos/machinebox/graphql/subscription","commits_url":"https://api.github.com/repos/machinebox/graphql/commits{/sha}","git_commits_url":"https://api.github.com/repos/machinebox/graphql/git/commits{/sha}","comments_url":"https://api.github.com/repos/machinebox/graphql/comments{/number}","issue_comment_url":"https://api.github.com/repos/machinebox/graphql/issues/comments{/number}","contents_url":"https://api.github.com/repos/machinebox/graphql/contents/{+path}","compare_url":"https://api.github.com/repos/machinebox/graphql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/machinebox/graphql/merges","archive_url":"https://api.github.com/repos/machinebox/graphql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/machinebox/graphql/downloads","issues_url":"https://api.github.com/repos/machinebox/graphql/issues{/number}","pulls_url":"https://api.github.com/repos/machinebox/graphql/pulls{/number}","milestones_url":"https://api.github.com/repos/machinebox/graphql/milestones{/number}","notifications_url":"https://api.github.com/repos/machinebox/graphql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/machinebox/graphql/labels{/name}","releases_url":"https://api.github.com/repos/machinebox/graphql/releases{/id}","deployments_url":"https://api.github.com/repos/machinebox/graphql/deployments","created_at":"2017-12-06T20:04:19Z","updated_at":"2018-10-15T12:59:54Z","pushed_at":"2018-10-15T16:31:09Z","git_url":"git://github.com/machinebox/graphql.git","ssh_url":"git@github.com:machinebox/graphql.git","clone_url":"https://github.com/machinebox/graphql.git","svn_url":"https://github.com/machinebox/graphql","homepage":"https://blog.machinebox.io/a-graphql-client-library-for-go-5bffd0455878","size":44,"stargazers_count":262,"watchers_count":262,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":21,"open_issues":6,"watchers":262,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/machinebox/graphql/pulls/19"},"html":{"href":"https://github.com/machinebox/graphql/pull/19"},"issue":{"href":"https://api.github.com/repos/machinebox/graphql/issues/19"},"comments":{"href":"https://api.github.com/repos/machinebox/graphql/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/machinebox/graphql/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/machinebox/graphql/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/machinebox/graphql/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/machinebox/graphql/statuses/6a25cc387dc44df464457e857ed50c1a50ac83f1"}},"author_association":"NONE"}}
{"actor":{"display_login":"erutherford"}}