{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments/229807928","pull_request_review_id":170396325,"id":229807928,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTgwNzkyOA==","diff_hunk":"@@ -124,11 +125,16 @@ public NewAzureADApplicationCommand()\n         {\n             DateTime currentTime = DateTime.UtcNow;\n             StartDate = currentTime;\n-            EndDate = currentTime.AddYears(1);\n         }\n \n         public override void ExecuteCmdlet()\n         {\n+            if (!this.IsParameterBound(c => c.EndDate))\n+            {\n+                WriteVerbose(\"No value specified for -EndDate parameter; setting the value to one year after start date.\");","path":"src/ResourceManager/Resources/Commands.Resources/ActiveDirectory/NewAzureADApplicationCommand.cs","position":19,"original_position":19,"commit_id":"992ade94d509076e87aa237988847b3597c0c8ba","original_commit_id":"992ade94d509076e87aa237988847b3597c0c8ba","user":{"login":"markcowl","id":1054056,"node_id":"MDQ6VXNlcjEwNTQwNTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1054056?v=4","gravatar_id":"","url":"https://api.github.com/users/markcowl","html_url":"https://github.com/markcowl","followers_url":"https://api.github.com/users/markcowl/followers","following_url":"https://api.github.com/users/markcowl/following{/other_user}","gists_url":"https://api.github.com/users/markcowl/gists{/gist_id}","starred_url":"https://api.github.com/users/markcowl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markcowl/subscriptions","organizations_url":"https://api.github.com/users/markcowl/orgs","repos_url":"https://api.github.com/users/markcowl/repos","events_url":"https://api.github.com/users/markcowl/events{/privacy}","received_events_url":"https://api.github.com/users/markcowl/received_events","type":"User","site_admin":false},"body":"This should be a resource string","created_at":"2018-10-31T18:03:21Z","updated_at":"2018-10-31T18:03:43Z","html_url":"https://github.com/Azure/azure-powershell/pull/7710#discussion_r229807928","pull_request_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/7710","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments/229807928"},"html":{"href":"https://github.com/Azure/azure-powershell/pull/7710#discussion_r229807928"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/7710"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-powershell/pulls/7710","id":227124514,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MTI0NTE0","html_url":"https://github.com/Azure/azure-powershell/pull/7710","diff_url":"https://github.com/Azure/azure-powershell/pull/7710.diff","patch_url":"https://github.com/Azure/azure-powershell/pull/7710.patch","issue_url":"https://api.github.com/repos/Azure/azure-powershell/issues/7710","number":7710,"state":"open","locked":false,"title":"Fix issue where EndDate parameter was not being honored for AD cmdlets","user":{"login":"cormacpayne","id":4462409,"node_id":"MDQ6VXNlcjQ0NjI0MDk=","avatar_url":"https://avatars2.githubusercontent.com/u/4462409?v=4","gravatar_id":"","url":"https://api.github.com/users/cormacpayne","html_url":"https://github.com/cormacpayne","followers_url":"https://api.github.com/users/cormacpayne/followers","following_url":"https://api.github.com/users/cormacpayne/following{/other_user}","gists_url":"https://api.github.com/users/cormacpayne/gists{/gist_id}","starred_url":"https://api.github.com/users/cormacpayne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cormacpayne/subscriptions","organizations_url":"https://api.github.com/users/cormacpayne/orgs","repos_url":"https://api.github.com/users/cormacpayne/repos","events_url":"https://api.github.com/users/cormacpayne/events{/privacy}","received_events_url":"https://api.github.com/users/cormacpayne/received_events","type":"User","site_admin":false},"body":"<!-- DO NOT DELETE THIS TEMPLATE -->\r\n\r\n## Description\r\n\r\n<!-- Please add a brief description of the changes made in this PR -->\r\n\r\nFix for https://github.com/Azure/azure-powershell/issues/7700\r\n\r\nThere are a few cmdlets that don't respect the value of `-EndDate` parameter, or don't get the accurate \"one year after start date\" default value, which is fixed in this PR.\r\n\r\n## Checklist\r\n\r\n- [x] I have read the [_Submitting Changes_](https://github.com/Azure/azure-powershell/blob/preview/CONTRIBUTING.md#submitting-changes) section of [`CONTRIBUTING.md`](https://github.com/Azure/azure-powershell/blob/preview/CONTRIBUTING.md)\r\n- [x] The title of the PR is clear and informative\r\n- [x] The appropriate [change log has been updated](https://github.com/Azure/azure-powershell/blob/preview/CONTRIBUTING.md#updating-the-change-log)\r\n- [x] The PR does not introduce [breaking changes](https://github.com/Azure/azure-powershell/blob/preview/documentation/breaking-changes/breaking-changes-definition.md)\r\n- [ ] If applicable, the changes made in the PR have proper test coverage\r\n- [ ] For public API changes to cmdlets:\r\n    - [ ] the changes have gone through a [cmdlet design review](https://github.com/Azure/azure-powershell-cmdlet-review-pr) (Microsoft internal partners only)\r\n    - [ ] the cmdlet markdown files were [generated using the `platyPS` module](https://github.com/Azure/azure-powershell/blob/preview/documentation/development-docs/help-generation.md)\r\n","created_at":"2018-10-31T00:35:51Z","updated_at":"2018-10-31T18:03:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"554f672ec8dc7819d7dd178bf51c6ba7a536ee45","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1056158818,"node_id":"MDU6TGFiZWwxMDU2MTU4ODE4","url":"https://api.github.com/repos/Azure/azure-powershell/labels/needs-review","name":"needs-review","color":"fbcfff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/7710/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/7710/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-powershell/issues/7710/comments","statuses_url":"https://api.github.com/repos/Azure/azure-powershell/statuses/992ade94d509076e87aa237988847b3597c0c8ba","head":{"label":"cormacpayne:new-sp-cred-fix","ref":"new-sp-cred-fix","sha":"992ade94d509076e87aa237988847b3597c0c8ba","user":{"login":"cormacpayne","id":4462409,"node_id":"MDQ6VXNlcjQ0NjI0MDk=","avatar_url":"https://avatars2.githubusercontent.com/u/4462409?v=4","gravatar_id":"","url":"https://api.github.com/users/cormacpayne","html_url":"https://github.com/cormacpayne","followers_url":"https://api.github.com/users/cormacpayne/followers","following_url":"https://api.github.com/users/cormacpayne/following{/other_user}","gists_url":"https://api.github.com/users/cormacpayne/gists{/gist_id}","starred_url":"https://api.github.com/users/cormacpayne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cormacpayne/subscriptions","organizations_url":"https://api.github.com/users/cormacpayne/orgs","repos_url":"https://api.github.com/users/cormacpayne/repos","events_url":"https://api.github.com/users/cormacpayne/events{/privacy}","received_events_url":"https://api.github.com/users/cormacpayne/received_events","type":"User","site_admin":false},"repo":{"id":64254912,"node_id":"MDEwOlJlcG9zaXRvcnk2NDI1NDkxMg==","name":"azure-powershell","full_name":"cormacpayne/azure-powershell","private":false,"owner":{"login":"cormacpayne","id":4462409,"node_id":"MDQ6VXNlcjQ0NjI0MDk=","avatar_url":"https://avatars2.githubusercontent.com/u/4462409?v=4","gravatar_id":"","url":"https://api.github.com/users/cormacpayne","html_url":"https://github.com/cormacpayne","followers_url":"https://api.github.com/users/cormacpayne/followers","following_url":"https://api.github.com/users/cormacpayne/following{/other_user}","gists_url":"https://api.github.com/users/cormacpayne/gists{/gist_id}","starred_url":"https://api.github.com/users/cormacpayne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cormacpayne/subscriptions","organizations_url":"https://api.github.com/users/cormacpayne/orgs","repos_url":"https://api.github.com/users/cormacpayne/repos","events_url":"https://api.github.com/users/cormacpayne/events{/privacy}","received_events_url":"https://api.github.com/users/cormacpayne/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cormacpayne/azure-powershell","description":"Microsoft Azure PowerShell","fork":true,"url":"https://api.github.com/repos/cormacpayne/azure-powershell","forks_url":"https://api.github.com/repos/cormacpayne/azure-powershell/forks","keys_url":"https://api.github.com/repos/cormacpayne/azure-powershell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cormacpayne/azure-powershell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cormacpayne/azure-powershell/teams","hooks_url":"https://api.github.com/repos/cormacpayne/azure-powershell/hooks","issue_events_url":"https://api.github.com/repos/cormacpayne/azure-powershell/issues/events{/number}","events_url":"https://api.github.com/repos/cormacpayne/azure-powershell/events","assignees_url":"https://api.github.com/repos/cormacpayne/azure-powershell/assignees{/user}","branches_url":"https://api.github.com/repos/cormacpayne/azure-powershell/branches{/branch}","tags_url":"https://api.github.com/repos/cormacpayne/azure-powershell/tags","blobs_url":"https://api.github.com/repos/cormacpayne/azure-powershell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cormacpayne/azure-powershell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cormacpayne/azure-powershell/git/refs{/sha}","trees_url":"https://api.github.com/repos/cormacpayne/azure-powershell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cormacpayne/azure-powershell/statuses/{sha}","languages_url":"https://api.github.com/repos/cormacpayne/azure-powershell/languages","stargazers_url":"https://api.github.com/repos/cormacpayne/azure-powershell/stargazers","contributors_url":"https://api.github.com/repos/cormacpayne/azure-powershell/contributors","subscribers_url":"https://api.github.com/repos/cormacpayne/azure-powershell/subscribers","subscription_url":"https://api.github.com/repos/cormacpayne/azure-powershell/subscription","commits_url":"https://api.github.com/repos/cormacpayne/azure-powershell/commits{/sha}","git_commits_url":"https://api.github.com/repos/cormacpayne/azure-powershell/git/commits{/sha}","comments_url":"https://api.github.com/repos/cormacpayne/azure-powershell/comments{/number}","issue_comment_url":"https://api.github.com/repos/cormacpayne/azure-powershell/issues/comments{/number}","contents_url":"https://api.github.com/repos/cormacpayne/azure-powershell/contents/{+path}","compare_url":"https://api.github.com/repos/cormacpayne/azure-powershell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cormacpayne/azure-powershell/merges","archive_url":"https://api.github.com/repos/cormacpayne/azure-powershell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cormacpayne/azure-powershell/downloads","issues_url":"https://api.github.com/repos/cormacpayne/azure-powershell/issues{/number}","pulls_url":"https://api.github.com/repos/cormacpayne/azure-powershell/pulls{/number}","milestones_url":"https://api.github.com/repos/cormacpayne/azure-powershell/milestones{/number}","notifications_url":"https://api.github.com/repos/cormacpayne/azure-powershell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cormacpayne/azure-powershell/labels{/name}","releases_url":"https://api.github.com/repos/cormacpayne/azure-powershell/releases{/id}","deployments_url":"https://api.github.com/repos/cormacpayne/azure-powershell/deployments","created_at":"2016-07-26T21:09:37Z","updated_at":"2018-10-30T18:19:42Z","pushed_at":"2018-10-31T00:34:03Z","git_url":"git://github.com/cormacpayne/azure-powershell.git","ssh_url":"git@github.com:cormacpayne/azure-powershell.git","clone_url":"https://github.com/cormacpayne/azure-powershell.git","svn_url":"https://github.com/cormacpayne/azure-powershell","homepage":null,"size":705069,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"preview"}},"base":{"label":"Azure:release-2018-11-06","ref":"release-2018-11-06","sha":"43cad7e627ce42ad2a1c566d9770d82f0b8c5cff","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":23891194,"node_id":"MDEwOlJlcG9zaXRvcnkyMzg5MTE5NA==","name":"azure-powershell","full_name":"Azure/azure-powershell","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/azure-powershell","description":"Microsoft Azure PowerShell","fork":false,"url":"https://api.github.com/repos/Azure/azure-powershell","forks_url":"https://api.github.com/repos/Azure/azure-powershell/forks","keys_url":"https://api.github.com/repos/Azure/azure-powershell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-powershell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-powershell/teams","hooks_url":"https://api.github.com/repos/Azure/azure-powershell/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-powershell/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-powershell/events","assignees_url":"https://api.github.com/repos/Azure/azure-powershell/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-powershell/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-powershell/tags","blobs_url":"https://api.github.com/repos/Azure/azure-powershell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-powershell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-powershell/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-powershell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-powershell/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-powershell/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-powershell/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-powershell/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-powershell/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-powershell/subscription","commits_url":"https://api.github.com/repos/Azure/azure-powershell/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-powershell/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-powershell/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-powershell/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-powershell/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-powershell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-powershell/merges","archive_url":"https://api.github.com/repos/Azure/azure-powershell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-powershell/downloads","issues_url":"https://api.github.com/repos/Azure/azure-powershell/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-powershell/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-powershell/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-powershell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-powershell/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-powershell/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-powershell/deployments","created_at":"2014-09-10T20:35:18Z","updated_at":"2018-10-31T08:06:22Z","pushed_at":"2018-10-31T17:54:20Z","git_url":"git://github.com/Azure/azure-powershell.git","ssh_url":"git@github.com:Azure/azure-powershell.git","clone_url":"https://github.com/Azure/azure-powershell.git","svn_url":"https://github.com/Azure/azure-powershell","homepage":null,"size":738936,"stargazers_count":1201,"watchers_count":1201,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1264,"mirror_url":null,"archived":false,"open_issues_count":740,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1264,"open_issues":740,"watchers":1201,"default_branch":"preview"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/7710"},"html":{"href":"https://github.com/Azure/azure-powershell/pull/7710"},"issue":{"href":"https://api.github.com/repos/Azure/azure-powershell/issues/7710"},"comments":{"href":"https://api.github.com/repos/Azure/azure-powershell/issues/7710/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/7710/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/7710/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-powershell/statuses/992ade94d509076e87aa237988847b3597c0c8ba"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"markcowl"}}