{"action":"opened","number":13,"pull_request":{"url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/pulls/13","id":227674785,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3Njc0Nzg1","html_url":"https://github.com/westonruter/twentyseventeen-westonson/pull/13","diff_url":"https://github.com/westonruter/twentyseventeen-westonson/pull/13.diff","patch_url":"https://github.com/westonruter/twentyseventeen-westonson/pull/13.patch","issue_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/issues/13","number":13,"state":"open","locked":false,"title":"Prevent HTML5 novalidate attribute from being added to commentform in AMP","user":{"login":"westonruter","id":134745,"node_id":"MDQ6VXNlcjEzNDc0NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/134745?v=4","gravatar_id":"","url":"https://api.github.com/users/westonruter","html_url":"https://github.com/westonruter","followers_url":"https://api.github.com/users/westonruter/followers","following_url":"https://api.github.com/users/westonruter/following{/other_user}","gists_url":"https://api.github.com/users/westonruter/gists{/gist_id}","starred_url":"https://api.github.com/users/westonruter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/westonruter/subscriptions","organizations_url":"https://api.github.com/users/westonruter/orgs","repos_url":"https://api.github.com/users/westonruter/repos","events_url":"https://api.github.com/users/westonruter/events{/privacy}","received_events_url":"https://api.github.com/users/westonruter/received_events","type":"User","site_admin":false},"body":"Unfortunately WordPress forces the `novalidate` attribute to be present on forms when the theme supports HTML5:\r\n\r\nhttps://github.com/WordPress/wordpress-develop/blob/5d92e0c0a950399c53294a41000305ddcf47efb5/src/wp-includes/comment-template.php#L2383\r\n\r\nBut in AMP we really need the browser to be doing the client-side validation, especially in the case of when the user is offline because in that case the service worker will queue an _invalid_ comment to replay, which will then get rejected by the server. So we need to make sure we do client-side validation to help ensure that a valid request will be queued for background sync.\r\n\r\nThis needs to be worked into the `AMP_Comments_Sanitizer` in the AMP plugin itself.","created_at":"2018-11-01T16:16:21Z","updated_at":"2018-11-01T16:16:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/pulls/13/commits","review_comments_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/pulls/13/comments","review_comment_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/pulls/comments{/number}","comments_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/issues/13/comments","statuses_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/statuses/c44b0fd1f370f104e75a5757668afa5c28bf3e1c","head":{"label":"westonruter:fix/commentform-novalidate","ref":"fix/commentform-novalidate","sha":"c44b0fd1f370f104e75a5757668afa5c28bf3e1c","user":{"login":"westonruter","id":134745,"node_id":"MDQ6VXNlcjEzNDc0NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/134745?v=4","gravatar_id":"","url":"https://api.github.com/users/westonruter","html_url":"https://github.com/westonruter","followers_url":"https://api.github.com/users/westonruter/followers","following_url":"https://api.github.com/users/westonruter/following{/other_user}","gists_url":"https://api.github.com/users/westonruter/gists{/gist_id}","starred_url":"https://api.github.com/users/westonruter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/westonruter/subscriptions","organizations_url":"https://api.github.com/users/westonruter/orgs","repos_url":"https://api.github.com/users/westonruter/repos","events_url":"https://api.github.com/users/westonruter/events{/privacy}","received_events_url":"https://api.github.com/users/westonruter/received_events","type":"User","site_admin":false},"repo":{"id":99171390,"node_id":"MDEwOlJlcG9zaXRvcnk5OTE3MTM5MA==","name":"twentyseventeen-westonson","full_name":"westonruter/twentyseventeen-westonson","private":false,"owner":{"login":"westonruter","id":134745,"node_id":"MDQ6VXNlcjEzNDc0NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/134745?v=4","gravatar_id":"","url":"https://api.github.com/users/westonruter","html_url":"https://github.com/westonruter","followers_url":"https://api.github.com/users/westonruter/followers","following_url":"https://api.github.com/users/westonruter/following{/other_user}","gists_url":"https://api.github.com/users/westonruter/gists{/gist_id}","starred_url":"https://api.github.com/users/westonruter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/westonruter/subscriptions","organizations_url":"https://api.github.com/users/westonruter/orgs","repos_url":"https://api.github.com/users/westonruter/repos","events_url":"https://api.github.com/users/westonruter/events{/privacy}","received_events_url":"https://api.github.com/users/westonruter/received_events","type":"User","site_admin":false},"html_url":"https://github.com/westonruter/twentyseventeen-westonson","description":"My child theme of Twenty Seventeen for testing.","fork":false,"url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson","forks_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/forks","keys_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/keys{/key_id}","collaborators_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/teams","hooks_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/hooks","issue_events_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/issues/events{/number}","events_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/events","assignees_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/assignees{/user}","branches_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/branches{/branch}","tags_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/tags","blobs_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/git/refs{/sha}","trees_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/git/trees{/sha}","statuses_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/statuses/{sha}","languages_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/languages","stargazers_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/stargazers","contributors_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/contributors","subscribers_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/subscribers","subscription_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/subscription","commits_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/commits{/sha}","git_commits_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/git/commits{/sha}","comments_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/comments{/number}","issue_comment_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/issues/comments{/number}","contents_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/contents/{+path}","compare_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/compare/{base}...{head}","merges_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/merges","archive_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/downloads","issues_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/issues{/number}","pulls_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/pulls{/number}","milestones_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/milestones{/number}","notifications_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/labels{/name}","releases_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/releases{/id}","deployments_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/deployments","created_at":"2017-08-02T23:59:45Z","updated_at":"2018-11-01T15:51:38Z","pushed_at":"2018-11-01T16:13:17Z","git_url":"git://github.com/westonruter/twentyseventeen-westonson.git","ssh_url":"git@github.com:westonruter/twentyseventeen-westonson.git","clone_url":"https://github.com/westonruter/twentyseventeen-westonson.git","svn_url":"https://github.com/westonruter/twentyseventeen-westonson","homepage":null,"size":2177,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":9,"license":null,"forks":0,"open_issues":9,"watchers":2,"default_branch":"master"}},"base":{"label":"westonruter:master","ref":"master","sha":"293443b0c5dc4bed296d6d45024b78a0316e496a","user":{"login":"westonruter","id":134745,"node_id":"MDQ6VXNlcjEzNDc0NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/134745?v=4","gravatar_id":"","url":"https://api.github.com/users/westonruter","html_url":"https://github.com/westonruter","followers_url":"https://api.github.com/users/westonruter/followers","following_url":"https://api.github.com/users/westonruter/following{/other_user}","gists_url":"https://api.github.com/users/westonruter/gists{/gist_id}","starred_url":"https://api.github.com/users/westonruter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/westonruter/subscriptions","organizations_url":"https://api.github.com/users/westonruter/orgs","repos_url":"https://api.github.com/users/westonruter/repos","events_url":"https://api.github.com/users/westonruter/events{/privacy}","received_events_url":"https://api.github.com/users/westonruter/received_events","type":"User","site_admin":false},"repo":{"id":99171390,"node_id":"MDEwOlJlcG9zaXRvcnk5OTE3MTM5MA==","name":"twentyseventeen-westonson","full_name":"westonruter/twentyseventeen-westonson","private":false,"owner":{"login":"westonruter","id":134745,"node_id":"MDQ6VXNlcjEzNDc0NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/134745?v=4","gravatar_id":"","url":"https://api.github.com/users/westonruter","html_url":"https://github.com/westonruter","followers_url":"https://api.github.com/users/westonruter/followers","following_url":"https://api.github.com/users/westonruter/following{/other_user}","gists_url":"https://api.github.com/users/westonruter/gists{/gist_id}","starred_url":"https://api.github.com/users/westonruter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/westonruter/subscriptions","organizations_url":"https://api.github.com/users/westonruter/orgs","repos_url":"https://api.github.com/users/westonruter/repos","events_url":"https://api.github.com/users/westonruter/events{/privacy}","received_events_url":"https://api.github.com/users/westonruter/received_events","type":"User","site_admin":false},"html_url":"https://github.com/westonruter/twentyseventeen-westonson","description":"My child theme of Twenty Seventeen for testing.","fork":false,"url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson","forks_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/forks","keys_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/keys{/key_id}","collaborators_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/teams","hooks_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/hooks","issue_events_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/issues/events{/number}","events_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/events","assignees_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/assignees{/user}","branches_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/branches{/branch}","tags_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/tags","blobs_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/git/refs{/sha}","trees_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/git/trees{/sha}","statuses_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/statuses/{sha}","languages_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/languages","stargazers_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/stargazers","contributors_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/contributors","subscribers_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/subscribers","subscription_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/subscription","commits_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/commits{/sha}","git_commits_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/git/commits{/sha}","comments_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/comments{/number}","issue_comment_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/issues/comments{/number}","contents_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/contents/{+path}","compare_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/compare/{base}...{head}","merges_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/merges","archive_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/downloads","issues_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/issues{/number}","pulls_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/pulls{/number}","milestones_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/milestones{/number}","notifications_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/labels{/name}","releases_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/releases{/id}","deployments_url":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/deployments","created_at":"2017-08-02T23:59:45Z","updated_at":"2018-11-01T15:51:38Z","pushed_at":"2018-11-01T16:13:17Z","git_url":"git://github.com/westonruter/twentyseventeen-westonson.git","ssh_url":"git@github.com:westonruter/twentyseventeen-westonson.git","clone_url":"https://github.com/westonruter/twentyseventeen-westonson.git","svn_url":"https://github.com/westonruter/twentyseventeen-westonson","homepage":null,"size":2177,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":9,"license":null,"forks":0,"open_issues":9,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/pulls/13"},"html":{"href":"https://github.com/westonruter/twentyseventeen-westonson/pull/13"},"issue":{"href":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/issues/13"},"comments":{"href":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/westonruter/twentyseventeen-westonson/statuses/c44b0fd1f370f104e75a5757668afa5c28bf3e1c"}},"author_association":"OWNER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":38,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"westonruter"}}