{"action":"created","issue":{"url":"https://api.github.com/repos/AustereTony-MCMods/ReBind/issues/3","repository_url":"https://api.github.com/repos/AustereTony-MCMods/ReBind","labels_url":"https://api.github.com/repos/AustereTony-MCMods/ReBind/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/AustereTony-MCMods/ReBind/issues/3/comments","events_url":"https://api.github.com/repos/AustereTony-MCMods/ReBind/issues/3/events","html_url":"https://github.com/AustereTony-MCMods/ReBind/issues/3","id":346986974,"node_id":"MDU6SXNzdWUzNDY5ODY5NzQ=","number":3,"title":"[1.7.10] Incompatibility with Macros litemod","user":{"login":"DracoScythem","id":12873273,"node_id":"MDQ6VXNlcjEyODczMjcz","avatar_url":"https://avatars1.githubusercontent.com/u/12873273?v=4","gravatar_id":"","url":"https://api.github.com/users/DracoScythem","html_url":"https://github.com/DracoScythem","followers_url":"https://api.github.com/users/DracoScythem/followers","following_url":"https://api.github.com/users/DracoScythem/following{/other_user}","gists_url":"https://api.github.com/users/DracoScythem/gists{/gist_id}","starred_url":"https://api.github.com/users/DracoScythem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DracoScythem/subscriptions","organizations_url":"https://api.github.com/users/DracoScythem/orgs","repos_url":"https://api.github.com/users/DracoScythem/repos","events_url":"https://api.github.com/users/DracoScythem/events{/privacy}","received_events_url":"https://api.github.com/users/DracoScythem/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-08-02T12:19:34Z","updated_at":"2018-08-03T22:35:49Z","closed_at":null,"author_association":"NONE","body":"If the Macros litemod is installed alongside ReBind opening the controls menu crashes the game.\r\nMC: 1.7.10\r\nVersions: 2.7.0 [latest] (ReBind) / 0.10.12 [latest] (Macros)\r\nFull log: https://paste.ee/p/H7zWG (normal) / https://paste.ee/p/Oz3qH (incl. debug and trace logs)\r\nMacros MCF thread: https://www.minecraftforum.net/forums/mapping-and-modding-java-edition/minecraft-mods/1275039-macro-keybind-mod\r\n\r\nIf you need more information, please don't hesitate to ask :)"},"comment":{"url":"https://api.github.com/repos/AustereTony-MCMods/ReBind/issues/comments/410393334","html_url":"https://github.com/AustereTony-MCMods/ReBind/issues/3#issuecomment-410393334","issue_url":"https://api.github.com/repos/AustereTony-MCMods/ReBind/issues/3","id":410393334,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMDM5MzMzNA==","user":{"login":"AustereTony-MCMods","id":38701702,"node_id":"MDQ6VXNlcjM4NzAxNzAy","avatar_url":"https://avatars0.githubusercontent.com/u/38701702?v=4","gravatar_id":"","url":"https://api.github.com/users/AustereTony-MCMods","html_url":"https://github.com/AustereTony-MCMods","followers_url":"https://api.github.com/users/AustereTony-MCMods/followers","following_url":"https://api.github.com/users/AustereTony-MCMods/following{/other_user}","gists_url":"https://api.github.com/users/AustereTony-MCMods/gists{/gist_id}","starred_url":"https://api.github.com/users/AustereTony-MCMods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AustereTony-MCMods/subscriptions","organizations_url":"https://api.github.com/users/AustereTony-MCMods/orgs","repos_url":"https://api.github.com/users/AustereTony-MCMods/repos","events_url":"https://api.github.com/users/AustereTony-MCMods/events{/privacy}","received_events_url":"https://api.github.com/users/AustereTony-MCMods/received_events","type":"User","site_admin":false},"created_at":"2018-08-03T22:35:49Z","updated_at":"2018-08-03T22:35:49Z","author_association":"OWNER","body":"Your conclusions helped me to figure it out so far. The _main_ problem was Macros created two KeyBinding instances, but didn't add it to GameSettings#keyBindings array. KeyBindingProperty instances are created for every KeyBinding so i just added extra keybindings check from KeyBindingProperty map to ReBindHooks#removeHiddenKeybindings() (which called after all mods postinit) and now all unregistered keybindings will be added to GameSettings#keyBindings array. Thus GuiListExtended.IGuiListEntry array in GuiKeyBindingList will be created with proper size.\r\n\r\nYou can downloaded and test working build from my google drive: [link](https://drive.google.com/file/d/1oJ1rOABrZ35OLhe46JAQir55S11ly3pc/view). At least it will not crash. But because of custom implementation of GuiListExtended.IGuiListEntry there are some limitations for this keybindings manipulation via ReBind config. It's not possible to hide or disable Macros keybindings from controls menu, but other features should work.\r\n\r\nWaiting for your response."}}
{"actor":{"display_login":"AustereTony-MCMods"}}