{"action":"created","comment":{"url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/pulls/comments/229882209","pull_request_review_id":170490123,"id":229882209,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTg4MjIwOQ==","diff_hunk":"@@ -61,12 +61,15 @@ export default class CustomListEditor extends React.Component<CustomListEditorPr\n       <div className=\"custom-list-editor\">\n         <div className=\"custom-list-editor-header\">\n           <div>\n-            <TextWithEditMode\n-              text={listTitle}\n-              placeholder=\"list title\"\n-              onUpdate={this.changeTitle}\n-              ref=\"listTitle\"\n-              />\n+            <fieldset>\n+              <legend className=\"visuallyHidden\">List name</legend>\n+              <TextWithEditMode\n+                text={listTitle}\n+                placeholder=\"list title\"\n+                onUpdate={this.changeTitle}\n+                ref=\"listTitle\"\n+                />\n+            </fieldset>","path":"src/components/CustomListEditor.tsx","position":18,"original_position":18,"commit_id":"5888940a7d3400b6825d173f656631a3c22c23d9","original_commit_id":"5888940a7d3400b6825d173f656631a3c22c23d9","user":{"login":"aslagle","id":3409215,"node_id":"MDQ6VXNlcjM0MDkyMTU=","avatar_url":"https://avatars3.githubusercontent.com/u/3409215?v=4","gravatar_id":"","url":"https://api.github.com/users/aslagle","html_url":"https://github.com/aslagle","followers_url":"https://api.github.com/users/aslagle/followers","following_url":"https://api.github.com/users/aslagle/following{/other_user}","gists_url":"https://api.github.com/users/aslagle/gists{/gist_id}","starred_url":"https://api.github.com/users/aslagle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aslagle/subscriptions","organizations_url":"https://api.github.com/users/aslagle/orgs","repos_url":"https://api.github.com/users/aslagle/repos","events_url":"https://api.github.com/users/aslagle/events{/privacy}","received_events_url":"https://api.github.com/users/aslagle/received_events","type":"User","site_admin":false},"body":"Maybe that's something we missed in the last branch.","created_at":"2018-10-31T21:58:30Z","updated_at":"2018-10-31T21:58:30Z","html_url":"https://github.com/NYPL-Simplified/circulation-web/pull/181#discussion_r229882209","pull_request_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/pulls/181","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NYPL-Simplified/circulation-web/pulls/comments/229882209"},"html":{"href":"https://github.com/NYPL-Simplified/circulation-web/pull/181#discussion_r229882209"},"pull_request":{"href":"https://api.github.com/repos/NYPL-Simplified/circulation-web/pulls/181"}},"in_reply_to_id":229882098},"pull_request":{"url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/pulls/181","id":227399926,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3Mzk5OTI2","html_url":"https://github.com/NYPL-Simplified/circulation-web/pull/181","diff_url":"https://github.com/NYPL-Simplified/circulation-web/pull/181.diff","patch_url":"https://github.com/NYPL-Simplified/circulation-web/pull/181.patch","issue_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/issues/181","number":181,"state":"open","locked":false,"title":"Group a11y fields","user":{"login":"EdwinGuzman","id":1280564,"node_id":"MDQ6VXNlcjEyODA1NjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1280564?v=4","gravatar_id":"","url":"https://api.github.com/users/EdwinGuzman","html_url":"https://github.com/EdwinGuzman","followers_url":"https://api.github.com/users/EdwinGuzman/followers","following_url":"https://api.github.com/users/EdwinGuzman/following{/other_user}","gists_url":"https://api.github.com/users/EdwinGuzman/gists{/gist_id}","starred_url":"https://api.github.com/users/EdwinGuzman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EdwinGuzman/subscriptions","organizations_url":"https://api.github.com/users/EdwinGuzman/orgs","repos_url":"https://api.github.com/users/EdwinGuzman/repos","events_url":"https://api.github.com/users/EdwinGuzman/events{/privacy}","received_events_url":"https://api.github.com/users/EdwinGuzman/received_events","type":"User","site_admin":false},"body":"First pass at fixing [SIMPLY-1317](https://jira.nypl.org/browse/SIMPLY-1317).\r\n\r\nWrapping most input fields inside different forms with `<fieldset>` if it made sense to include a title and to group them together. Added `visuallyHidden` css rules to hide most fieldset `legend` elements because they are not needed, but are useful for screen readers.\r\n\r\nNot much really changes except the DOM structure. I did not tackle `LibraryEditForm `, `ProtocolFormField`, or `ServiceEditForm` but will attempt for the next pass where I also hope to group together required and non-required fields together.","created_at":"2018-10-31T18:38:23Z","updated_at":"2018-10-31T21:58:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b151c5be09cde71f6fb5ebff32640ecb98c3425","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/pulls/181/commits","review_comments_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/pulls/181/comments","review_comment_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/issues/181/comments","statuses_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/statuses/5888940a7d3400b6825d173f656631a3c22c23d9","head":{"label":"NYPL-Simplified:group-a11y-fields","ref":"group-a11y-fields","sha":"5888940a7d3400b6825d173f656631a3c22c23d9","user":{"login":"NYPL-Simplified","id":16416905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDE2OTA1","avatar_url":"https://avatars1.githubusercontent.com/u/16416905?v=4","gravatar_id":"","url":"https://api.github.com/users/NYPL-Simplified","html_url":"https://github.com/NYPL-Simplified","followers_url":"https://api.github.com/users/NYPL-Simplified/followers","following_url":"https://api.github.com/users/NYPL-Simplified/following{/other_user}","gists_url":"https://api.github.com/users/NYPL-Simplified/gists{/gist_id}","starred_url":"https://api.github.com/users/NYPL-Simplified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYPL-Simplified/subscriptions","organizations_url":"https://api.github.com/users/NYPL-Simplified/orgs","repos_url":"https://api.github.com/users/NYPL-Simplified/repos","events_url":"https://api.github.com/users/NYPL-Simplified/events{/privacy}","received_events_url":"https://api.github.com/users/NYPL-Simplified/received_events","type":"Organization","site_admin":false},"repo":{"id":52620621,"node_id":"MDEwOlJlcG9zaXRvcnk1MjYyMDYyMQ==","name":"circulation-web","full_name":"NYPL-Simplified/circulation-web","private":false,"owner":{"login":"NYPL-Simplified","id":16416905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDE2OTA1","avatar_url":"https://avatars1.githubusercontent.com/u/16416905?v=4","gravatar_id":"","url":"https://api.github.com/users/NYPL-Simplified","html_url":"https://github.com/NYPL-Simplified","followers_url":"https://api.github.com/users/NYPL-Simplified/followers","following_url":"https://api.github.com/users/NYPL-Simplified/following{/other_user}","gists_url":"https://api.github.com/users/NYPL-Simplified/gists{/gist_id}","starred_url":"https://api.github.com/users/NYPL-Simplified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYPL-Simplified/subscriptions","organizations_url":"https://api.github.com/users/NYPL-Simplified/orgs","repos_url":"https://api.github.com/users/NYPL-Simplified/repos","events_url":"https://api.github.com/users/NYPL-Simplified/events{/privacy}","received_events_url":"https://api.github.com/users/NYPL-Simplified/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NYPL-Simplified/circulation-web","description":"Web front-end for the Circulation Manager admin interface","fork":false,"url":"https://api.github.com/repos/NYPL-Simplified/circulation-web","forks_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/forks","keys_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/teams","hooks_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/hooks","issue_events_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/issues/events{/number}","events_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/events","assignees_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/assignees{/user}","branches_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/branches{/branch}","tags_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/tags","blobs_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/statuses/{sha}","languages_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/languages","stargazers_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/stargazers","contributors_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/contributors","subscribers_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/subscribers","subscription_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/subscription","commits_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/contents/{+path}","compare_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/merges","archive_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/downloads","issues_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/issues{/number}","pulls_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/pulls{/number}","milestones_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/milestones{/number}","notifications_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/labels{/name}","releases_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/releases{/id}","deployments_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/deployments","created_at":"2016-02-26T17:21:47Z","updated_at":"2018-10-30T18:29:36Z","pushed_at":"2018-10-31T18:38:24Z","git_url":"git://github.com/NYPL-Simplified/circulation-web.git","ssh_url":"git@github.com:NYPL-Simplified/circulation-web.git","clone_url":"https://github.com/NYPL-Simplified/circulation-web.git","svn_url":"https://github.com/NYPL-Simplified/circulation-web","homepage":"","size":1162,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":23,"license":null,"forks":0,"open_issues":23,"watchers":0,"default_branch":"master"}},"base":{"label":"NYPL-Simplified:master","ref":"master","sha":"613f62a96d81958dff49a658f2a7fbe88d686e11","user":{"login":"NYPL-Simplified","id":16416905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDE2OTA1","avatar_url":"https://avatars1.githubusercontent.com/u/16416905?v=4","gravatar_id":"","url":"https://api.github.com/users/NYPL-Simplified","html_url":"https://github.com/NYPL-Simplified","followers_url":"https://api.github.com/users/NYPL-Simplified/followers","following_url":"https://api.github.com/users/NYPL-Simplified/following{/other_user}","gists_url":"https://api.github.com/users/NYPL-Simplified/gists{/gist_id}","starred_url":"https://api.github.com/users/NYPL-Simplified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYPL-Simplified/subscriptions","organizations_url":"https://api.github.com/users/NYPL-Simplified/orgs","repos_url":"https://api.github.com/users/NYPL-Simplified/repos","events_url":"https://api.github.com/users/NYPL-Simplified/events{/privacy}","received_events_url":"https://api.github.com/users/NYPL-Simplified/received_events","type":"Organization","site_admin":false},"repo":{"id":52620621,"node_id":"MDEwOlJlcG9zaXRvcnk1MjYyMDYyMQ==","name":"circulation-web","full_name":"NYPL-Simplified/circulation-web","private":false,"owner":{"login":"NYPL-Simplified","id":16416905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDE2OTA1","avatar_url":"https://avatars1.githubusercontent.com/u/16416905?v=4","gravatar_id":"","url":"https://api.github.com/users/NYPL-Simplified","html_url":"https://github.com/NYPL-Simplified","followers_url":"https://api.github.com/users/NYPL-Simplified/followers","following_url":"https://api.github.com/users/NYPL-Simplified/following{/other_user}","gists_url":"https://api.github.com/users/NYPL-Simplified/gists{/gist_id}","starred_url":"https://api.github.com/users/NYPL-Simplified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYPL-Simplified/subscriptions","organizations_url":"https://api.github.com/users/NYPL-Simplified/orgs","repos_url":"https://api.github.com/users/NYPL-Simplified/repos","events_url":"https://api.github.com/users/NYPL-Simplified/events{/privacy}","received_events_url":"https://api.github.com/users/NYPL-Simplified/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NYPL-Simplified/circulation-web","description":"Web front-end for the Circulation Manager admin interface","fork":false,"url":"https://api.github.com/repos/NYPL-Simplified/circulation-web","forks_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/forks","keys_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/teams","hooks_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/hooks","issue_events_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/issues/events{/number}","events_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/events","assignees_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/assignees{/user}","branches_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/branches{/branch}","tags_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/tags","blobs_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/statuses/{sha}","languages_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/languages","stargazers_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/stargazers","contributors_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/contributors","subscribers_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/subscribers","subscription_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/subscription","commits_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/contents/{+path}","compare_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/merges","archive_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/downloads","issues_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/issues{/number}","pulls_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/pulls{/number}","milestones_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/milestones{/number}","notifications_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/labels{/name}","releases_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/releases{/id}","deployments_url":"https://api.github.com/repos/NYPL-Simplified/circulation-web/deployments","created_at":"2016-02-26T17:21:47Z","updated_at":"2018-10-30T18:29:36Z","pushed_at":"2018-10-31T18:38:24Z","git_url":"git://github.com/NYPL-Simplified/circulation-web.git","ssh_url":"git@github.com:NYPL-Simplified/circulation-web.git","clone_url":"https://github.com/NYPL-Simplified/circulation-web.git","svn_url":"https://github.com/NYPL-Simplified/circulation-web","homepage":"","size":1162,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":23,"license":null,"forks":0,"open_issues":23,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NYPL-Simplified/circulation-web/pulls/181"},"html":{"href":"https://github.com/NYPL-Simplified/circulation-web/pull/181"},"issue":{"href":"https://api.github.com/repos/NYPL-Simplified/circulation-web/issues/181"},"comments":{"href":"https://api.github.com/repos/NYPL-Simplified/circulation-web/issues/181/comments"},"review_comments":{"href":"https://api.github.com/repos/NYPL-Simplified/circulation-web/pulls/181/comments"},"review_comment":{"href":"https://api.github.com/repos/NYPL-Simplified/circulation-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NYPL-Simplified/circulation-web/pulls/181/commits"},"statuses":{"href":"https://api.github.com/repos/NYPL-Simplified/circulation-web/statuses/5888940a7d3400b6825d173f656631a3c22c23d9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"aslagle"}}