{"action":"created","issue":{"url":"https://api.github.com/repos/jekyll/jekyll/issues/7204","repository_url":"https://api.github.com/repos/jekyll/jekyll","labels_url":"https://api.github.com/repos/jekyll/jekyll/issues/7204/labels{/name}","comments_url":"https://api.github.com/repos/jekyll/jekyll/issues/7204/comments","events_url":"https://api.github.com/repos/jekyll/jekyll/issues/7204/events","html_url":"https://github.com/jekyll/jekyll/pull/7204","id":355317115,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExODc0Nzg4","number":7204,"title":"Add SHA256 Based Incremental Regeneration Option","user":{"login":"steinbachr","id":1424445,"node_id":"MDQ6VXNlcjE0MjQ0NDU=","avatar_url":"https://avatars0.githubusercontent.com/u/1424445?v=4","gravatar_id":"","url":"https://api.github.com/users/steinbachr","html_url":"https://github.com/steinbachr","followers_url":"https://api.github.com/users/steinbachr/followers","following_url":"https://api.github.com/users/steinbachr/following{/other_user}","gists_url":"https://api.github.com/users/steinbachr/gists{/gist_id}","starred_url":"https://api.github.com/users/steinbachr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steinbachr/subscriptions","organizations_url":"https://api.github.com/users/steinbachr/orgs","repos_url":"https://api.github.com/users/steinbachr/repos","events_url":"https://api.github.com/users/steinbachr/events{/privacy}","received_events_url":"https://api.github.com/users/steinbachr/received_events","type":"User","site_admin":false},"labels":[{"id":22580614,"node_id":"MDU6TGFiZWwyMjU4MDYxNA==","url":"https://api.github.com/repos/jekyll/jekyll/labels/fix","name":"fix","color":"eb6420","default":false},{"id":381288654,"node_id":"MDU6TGFiZWwzODEyODg2NTQ=","url":"https://api.github.com/repos/jekyll/jekyll/labels/incremental-regeneration","name":"incremental-regeneration","color":"94ed17","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-08-29T20:18:48Z","updated_at":"2018-08-31T10:47:15Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/jekyll/jekyll/pulls/7204","html_url":"https://github.com/jekyll/jekyll/pull/7204","diff_url":"https://github.com/jekyll/jekyll/pull/7204.diff","patch_url":"https://github.com/jekyll/jekyll/pull/7204.patch"},"body":"This is related to PR https://github.com/jekyll/jekyll/pull/7201.\r\n\r\nEven after applying the patch from the referenced PR, we were still seeing issues in CI (CircleCI to be specific) containers with `incremental` builds not seeing speedups. Specifically, when using CircleCI `restore_cache`/`save_cache` functionality to persist the state of `.jekyll-metadata`/`.jekyll-cache`. The cause, it would appear, is that whenever the cache was restored, the `mtime` of the restored files were set to the current time, while the `.jekyll-metadata` stored the true mtime's.\r\n\r\nThis PR introduces a generic solution by adding a new configuration option - `incremental_key` - which (for now) can be one of `mtime` (default) or `hash`. When set to hash, the SHA256 hash of the file contents is used as the basis for comparison when determining whether a file has been modified."},"comment":{"url":"https://api.github.com/repos/jekyll/jekyll/issues/comments/417626959","html_url":"https://github.com/jekyll/jekyll/pull/7204#issuecomment-417626959","issue_url":"https://api.github.com/repos/jekyll/jekyll/issues/7204","id":417626959,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNzYyNjk1OQ==","user":{"login":"DirtyF","id":103008,"node_id":"MDQ6VXNlcjEwMzAwOA==","avatar_url":"https://avatars3.githubusercontent.com/u/103008?v=4","gravatar_id":"","url":"https://api.github.com/users/DirtyF","html_url":"https://github.com/DirtyF","followers_url":"https://api.github.com/users/DirtyF/followers","following_url":"https://api.github.com/users/DirtyF/following{/other_user}","gists_url":"https://api.github.com/users/DirtyF/gists{/gist_id}","starred_url":"https://api.github.com/users/DirtyF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DirtyF/subscriptions","organizations_url":"https://api.github.com/users/DirtyF/orgs","repos_url":"https://api.github.com/users/DirtyF/repos","events_url":"https://api.github.com/users/DirtyF/events{/privacy}","received_events_url":"https://api.github.com/users/DirtyF/received_events","type":"User","site_admin":false},"created_at":"2018-08-31T10:47:15Z","updated_at":"2018-08-31T10:47:15Z","author_association":"MEMBER","body":"> Canonically, it seemed the build times were comparable.\r\n\r\nUtterson shows it's a tiny bit slower, would need more benchmark though."}}
{"actor":{"display_login":"DirtyF"}}