{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/208417379","pull_request_review_id":144222913,"id":208417379,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODQxNzM3OQ==","diff_hunk":"@@ -1024,7 +1025,7 @@ bool TypeChecker::coercePatternToType(Pattern *&P, DeclContext *dc, Type type,\n     // If this is the payload of an enum, and the type is a single-element\n     // labeled tuple, treat this as a tuple pattern. It's unlikely that the\n     // user is interested in binding a variable of type (foo: Int).\n-    if ((options & TypeResolutionFlags::EnumPatternPayload)\n+    if ((options.getContext() == TypeResolverContext::EnumPatternPayload)","path":"lib/Sema/TypeCheckPattern.cpp","position":72,"original_position":72,"commit_id":"b0192af7ad021289cb17281402c649b52dedba17","original_commit_id":"b0192af7ad021289cb17281402c649b52dedba17","user":{"login":"slavapestov","id":66486,"node_id":"MDQ6VXNlcjY2NDg2","avatar_url":"https://avatars1.githubusercontent.com/u/66486?v=4","gravatar_id":"","url":"https://api.github.com/users/slavapestov","html_url":"https://github.com/slavapestov","followers_url":"https://api.github.com/users/slavapestov/followers","following_url":"https://api.github.com/users/slavapestov/following{/other_user}","gists_url":"https://api.github.com/users/slavapestov/gists{/gist_id}","starred_url":"https://api.github.com/users/slavapestov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slavapestov/subscriptions","organizations_url":"https://api.github.com/users/slavapestov/orgs","repos_url":"https://api.github.com/users/slavapestov/repos","events_url":"https://api.github.com/users/slavapestov/events{/privacy}","received_events_url":"https://api.github.com/users/slavapestov/received_events","type":"User","site_admin":false},"body":"maybe options.is(TypeResolverContext::EnumPatternPayload) would read better?","created_at":"2018-08-07T23:38:20Z","updated_at":"2018-08-07T23:38:20Z","html_url":"https://github.com/apple/swift/pull/18546#discussion_r208417379","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/18546","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/208417379"},"html":{"href":"https://github.com/apple/swift/pull/18546#discussion_r208417379"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/18546"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/18546","id":206701695,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NzAxNjk1","html_url":"https://github.com/apple/swift/pull/18546","diff_url":"https://github.com/apple/swift/pull/18546.diff","patch_url":"https://github.com/apple/swift/pull/18546.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/18546","number":18546,"state":"open","locked":false,"title":"[Sema] NFC: Refactor most TypeResolutionFlags into a traditional enum","user":{"login":"davezarzycki","id":1071982,"node_id":"MDQ6VXNlcjEwNzE5ODI=","avatar_url":"https://avatars2.githubusercontent.com/u/1071982?v=4","gravatar_id":"","url":"https://api.github.com/users/davezarzycki","html_url":"https://github.com/davezarzycki","followers_url":"https://api.github.com/users/davezarzycki/followers","following_url":"https://api.github.com/users/davezarzycki/following{/other_user}","gists_url":"https://api.github.com/users/davezarzycki/gists{/gist_id}","starred_url":"https://api.github.com/users/davezarzycki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davezarzycki/subscriptions","organizations_url":"https://api.github.com/users/davezarzycki/orgs","repos_url":"https://api.github.com/users/davezarzycki/repos","events_url":"https://api.github.com/users/davezarzycki/events{/privacy}","received_events_url":"https://api.github.com/users/davezarzycki/received_events","type":"User","site_admin":false},"body":"`TypeResolutionFlags` is overly complicated at the moment because the vast majority of flag combinations are impossible and nonsensical. With this patch, we create a new `TypeResolverContext` type that is a classic enum and far easier to reason about. It also enables \"exhaustive enum\" checking, unlike the \"flags\" based approach.","created_at":"2018-08-07T13:40:11Z","updated_at":"2018-08-07T23:38:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"96a871db213a016df6a62e93d8897c11dd07ba5d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rudkx","id":162784,"node_id":"MDQ6VXNlcjE2Mjc4NA==","avatar_url":"https://avatars1.githubusercontent.com/u/162784?v=4","gravatar_id":"","url":"https://api.github.com/users/rudkx","html_url":"https://github.com/rudkx","followers_url":"https://api.github.com/users/rudkx/followers","following_url":"https://api.github.com/users/rudkx/following{/other_user}","gists_url":"https://api.github.com/users/rudkx/gists{/gist_id}","starred_url":"https://api.github.com/users/rudkx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rudkx/subscriptions","organizations_url":"https://api.github.com/users/rudkx/orgs","repos_url":"https://api.github.com/users/rudkx/repos","events_url":"https://api.github.com/users/rudkx/events{/privacy}","received_events_url":"https://api.github.com/users/rudkx/received_events","type":"User","site_admin":false},{"login":"DougGregor","id":989428,"node_id":"MDQ6VXNlcjk4OTQyOA==","avatar_url":"https://avatars3.githubusercontent.com/u/989428?v=4","gravatar_id":"","url":"https://api.github.com/users/DougGregor","html_url":"https://github.com/DougGregor","followers_url":"https://api.github.com/users/DougGregor/followers","following_url":"https://api.github.com/users/DougGregor/following{/other_user}","gists_url":"https://api.github.com/users/DougGregor/gists{/gist_id}","starred_url":"https://api.github.com/users/DougGregor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DougGregor/subscriptions","organizations_url":"https://api.github.com/users/DougGregor/orgs","repos_url":"https://api.github.com/users/DougGregor/repos","events_url":"https://api.github.com/users/DougGregor/events{/privacy}","received_events_url":"https://api.github.com/users/DougGregor/received_events","type":"User","site_admin":false},{"login":"CodaFi","id":1896383,"node_id":"MDQ6VXNlcjE4OTYzODM=","avatar_url":"https://avatars3.githubusercontent.com/u/1896383?v=4","gravatar_id":"","url":"https://api.github.com/users/CodaFi","html_url":"https://github.com/CodaFi","followers_url":"https://api.github.com/users/CodaFi/followers","following_url":"https://api.github.com/users/CodaFi/following{/other_user}","gists_url":"https://api.github.com/users/CodaFi/gists{/gist_id}","starred_url":"https://api.github.com/users/CodaFi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodaFi/subscriptions","organizations_url":"https://api.github.com/users/CodaFi/orgs","repos_url":"https://api.github.com/users/CodaFi/repos","events_url":"https://api.github.com/users/CodaFi/events{/privacy}","received_events_url":"https://api.github.com/users/CodaFi/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/18546/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/18546/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/18546/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/b0192af7ad021289cb17281402c649b52dedba17","head":{"label":"davezarzycki:more_type_resolution_clean_up","ref":"more_type_resolution_clean_up","sha":"b0192af7ad021289cb17281402c649b52dedba17","user":{"login":"davezarzycki","id":1071982,"node_id":"MDQ6VXNlcjEwNzE5ODI=","avatar_url":"https://avatars2.githubusercontent.com/u/1071982?v=4","gravatar_id":"","url":"https://api.github.com/users/davezarzycki","html_url":"https://github.com/davezarzycki","followers_url":"https://api.github.com/users/davezarzycki/followers","following_url":"https://api.github.com/users/davezarzycki/following{/other_user}","gists_url":"https://api.github.com/users/davezarzycki/gists{/gist_id}","starred_url":"https://api.github.com/users/davezarzycki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davezarzycki/subscriptions","organizations_url":"https://api.github.com/users/davezarzycki/orgs","repos_url":"https://api.github.com/users/davezarzycki/repos","events_url":"https://api.github.com/users/davezarzycki/events{/privacy}","received_events_url":"https://api.github.com/users/davezarzycki/received_events","type":"User","site_admin":false},"repo":{"id":47463067,"node_id":"MDEwOlJlcG9zaXRvcnk0NzQ2MzA2Nw==","name":"swift","full_name":"davezarzycki/swift","owner":{"login":"davezarzycki","id":1071982,"node_id":"MDQ6VXNlcjEwNzE5ODI=","avatar_url":"https://avatars2.githubusercontent.com/u/1071982?v=4","gravatar_id":"","url":"https://api.github.com/users/davezarzycki","html_url":"https://github.com/davezarzycki","followers_url":"https://api.github.com/users/davezarzycki/followers","following_url":"https://api.github.com/users/davezarzycki/following{/other_user}","gists_url":"https://api.github.com/users/davezarzycki/gists{/gist_id}","starred_url":"https://api.github.com/users/davezarzycki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davezarzycki/subscriptions","organizations_url":"https://api.github.com/users/davezarzycki/orgs","repos_url":"https://api.github.com/users/davezarzycki/repos","events_url":"https://api.github.com/users/davezarzycki/events{/privacy}","received_events_url":"https://api.github.com/users/davezarzycki/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davezarzycki/swift","description":null,"fork":true,"url":"https://api.github.com/repos/davezarzycki/swift","forks_url":"https://api.github.com/repos/davezarzycki/swift/forks","keys_url":"https://api.github.com/repos/davezarzycki/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davezarzycki/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davezarzycki/swift/teams","hooks_url":"https://api.github.com/repos/davezarzycki/swift/hooks","issue_events_url":"https://api.github.com/repos/davezarzycki/swift/issues/events{/number}","events_url":"https://api.github.com/repos/davezarzycki/swift/events","assignees_url":"https://api.github.com/repos/davezarzycki/swift/assignees{/user}","branches_url":"https://api.github.com/repos/davezarzycki/swift/branches{/branch}","tags_url":"https://api.github.com/repos/davezarzycki/swift/tags","blobs_url":"https://api.github.com/repos/davezarzycki/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davezarzycki/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davezarzycki/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/davezarzycki/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davezarzycki/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/davezarzycki/swift/languages","stargazers_url":"https://api.github.com/repos/davezarzycki/swift/stargazers","contributors_url":"https://api.github.com/repos/davezarzycki/swift/contributors","subscribers_url":"https://api.github.com/repos/davezarzycki/swift/subscribers","subscription_url":"https://api.github.com/repos/davezarzycki/swift/subscription","commits_url":"https://api.github.com/repos/davezarzycki/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/davezarzycki/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/davezarzycki/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/davezarzycki/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/davezarzycki/swift/contents/{+path}","compare_url":"https://api.github.com/repos/davezarzycki/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davezarzycki/swift/merges","archive_url":"https://api.github.com/repos/davezarzycki/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davezarzycki/swift/downloads","issues_url":"https://api.github.com/repos/davezarzycki/swift/issues{/number}","pulls_url":"https://api.github.com/repos/davezarzycki/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/davezarzycki/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/davezarzycki/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davezarzycki/swift/labels{/name}","releases_url":"https://api.github.com/repos/davezarzycki/swift/releases{/id}","deployments_url":"https://api.github.com/repos/davezarzycki/swift/deployments","created_at":"2015-12-05T16:23:41Z","updated_at":"2017-08-16T19:02:08Z","pushed_at":"2018-08-07T13:37:42Z","git_url":"git://github.com/davezarzycki/swift.git","ssh_url":"git@github.com:davezarzycki/swift.git","clone_url":"https://github.com/davezarzycki/swift.git","svn_url":"https://github.com/davezarzycki/swift","homepage":"","size":295208,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":1,"default_branch":"github_readme"}},"base":{"label":"apple:master","ref":"master","sha":"b5fef06c2cfac8c723872dcbbc661ebe66110216","user":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"node_id":"MDEwOlJlcG9zaXRvcnk0NDgzODk0OQ==","name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2018-08-07T22:41:05Z","pushed_at":"2018-08-07T23:16:26Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":323005,"stargazers_count":44775,"watchers_count":44775,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7057,"mirror_url":null,"archived":false,"open_issues_count":357,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7057,"open_issues":357,"watchers":44775,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/18546"},"html":{"href":"https://github.com/apple/swift/pull/18546"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/18546"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/18546/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/18546/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/18546/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/b0192af7ad021289cb17281402c649b52dedba17"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"slavapestov"}}