{"action":"opened","number":93,"pull_request":{"url":"https://api.github.com/repos/XiaoMi/rdsn/pulls/93","id":193591603,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNTkxNjAz","html_url":"https://github.com/XiaoMi/rdsn/pull/93","diff_url":"https://github.com/XiaoMi/rdsn/pull/93.diff","patch_url":"https://github.com/XiaoMi/rdsn/pull/93.patch","issue_url":"https://api.github.com/repos/XiaoMi/rdsn/issues/93","number":93,"state":"open","locked":false,"title":"core: remove io-per-queue's io mode & fastrun's running mode","user":{"login":"shengofsun","id":1041832,"node_id":"MDQ6VXNlcjEwNDE4MzI=","avatar_url":"https://avatars0.githubusercontent.com/u/1041832?v=4","gravatar_id":"","url":"https://api.github.com/users/shengofsun","html_url":"https://github.com/shengofsun","followers_url":"https://api.github.com/users/shengofsun/followers","following_url":"https://api.github.com/users/shengofsun/following{/other_user}","gists_url":"https://api.github.com/users/shengofsun/gists{/gist_id}","starred_url":"https://api.github.com/users/shengofsun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shengofsun/subscriptions","organizations_url":"https://api.github.com/users/shengofsun/orgs","repos_url":"https://api.github.com/users/shengofsun/repos","events_url":"https://api.github.com/users/shengofsun/events{/privacy}","received_events_url":"https://api.github.com/users/shengofsun/received_events","type":"User","site_admin":false},"body":"删除了难懂的、可能有bug、我们也基本用不上的fastrun和io-per-queue。因为想要fastrun得允许一个进程下开多个socket端口。\r\n\r\nfastrun下的moodycamel_queue保留了下来，性能优化的时候可能用得着。\r\n\r\n移除io-per-queue后，之前timer-service改成了io-per-node, 也就是全局一个timer线程。根据测试的结果来看这个影响不是很大，基本上线程比较闲，观察都是Sleep状态，cpu利用率大概20%左右。也可以从这个角度来推想：我们的aio thread也是全局只有一个的，也没有成为系统的瓶颈。这个带来的好处是，系统的总线程数减少了非常多。\r\n","created_at":"2018-06-08T11:54:53Z","updated_at":"2018-06-08T11:54:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/XiaoMi/rdsn/pulls/93/commits","review_comments_url":"https://api.github.com/repos/XiaoMi/rdsn/pulls/93/comments","review_comment_url":"https://api.github.com/repos/XiaoMi/rdsn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/XiaoMi/rdsn/issues/93/comments","statuses_url":"https://api.github.com/repos/XiaoMi/rdsn/statuses/079cedbb285e21196ce0d5c5ec14c51ae6cff800","head":{"label":"shengofsun:master","ref":"master","sha":"079cedbb285e21196ce0d5c5ec14c51ae6cff800","user":{"login":"shengofsun","id":1041832,"node_id":"MDQ6VXNlcjEwNDE4MzI=","avatar_url":"https://avatars0.githubusercontent.com/u/1041832?v=4","gravatar_id":"","url":"https://api.github.com/users/shengofsun","html_url":"https://github.com/shengofsun","followers_url":"https://api.github.com/users/shengofsun/followers","following_url":"https://api.github.com/users/shengofsun/following{/other_user}","gists_url":"https://api.github.com/users/shengofsun/gists{/gist_id}","starred_url":"https://api.github.com/users/shengofsun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shengofsun/subscriptions","organizations_url":"https://api.github.com/users/shengofsun/orgs","repos_url":"https://api.github.com/users/shengofsun/repos","events_url":"https://api.github.com/users/shengofsun/events{/privacy}","received_events_url":"https://api.github.com/users/shengofsun/received_events","type":"User","site_admin":false},"repo":{"id":120423956,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA0MjM5NTY=","name":"rdsn","full_name":"shengofsun/rdsn","owner":{"login":"shengofsun","id":1041832,"node_id":"MDQ6VXNlcjEwNDE4MzI=","avatar_url":"https://avatars0.githubusercontent.com/u/1041832?v=4","gravatar_id":"","url":"https://api.github.com/users/shengofsun","html_url":"https://github.com/shengofsun","followers_url":"https://api.github.com/users/shengofsun/followers","following_url":"https://api.github.com/users/shengofsun/following{/other_user}","gists_url":"https://api.github.com/users/shengofsun/gists{/gist_id}","starred_url":"https://api.github.com/users/shengofsun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shengofsun/subscriptions","organizations_url":"https://api.github.com/users/shengofsun/orgs","repos_url":"https://api.github.com/users/shengofsun/repos","events_url":"https://api.github.com/users/shengofsun/events{/privacy}","received_events_url":"https://api.github.com/users/shengofsun/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shengofsun/rdsn","description":null,"fork":true,"url":"https://api.github.com/repos/shengofsun/rdsn","forks_url":"https://api.github.com/repos/shengofsun/rdsn/forks","keys_url":"https://api.github.com/repos/shengofsun/rdsn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shengofsun/rdsn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shengofsun/rdsn/teams","hooks_url":"https://api.github.com/repos/shengofsun/rdsn/hooks","issue_events_url":"https://api.github.com/repos/shengofsun/rdsn/issues/events{/number}","events_url":"https://api.github.com/repos/shengofsun/rdsn/events","assignees_url":"https://api.github.com/repos/shengofsun/rdsn/assignees{/user}","branches_url":"https://api.github.com/repos/shengofsun/rdsn/branches{/branch}","tags_url":"https://api.github.com/repos/shengofsun/rdsn/tags","blobs_url":"https://api.github.com/repos/shengofsun/rdsn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shengofsun/rdsn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shengofsun/rdsn/git/refs{/sha}","trees_url":"https://api.github.com/repos/shengofsun/rdsn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shengofsun/rdsn/statuses/{sha}","languages_url":"https://api.github.com/repos/shengofsun/rdsn/languages","stargazers_url":"https://api.github.com/repos/shengofsun/rdsn/stargazers","contributors_url":"https://api.github.com/repos/shengofsun/rdsn/contributors","subscribers_url":"https://api.github.com/repos/shengofsun/rdsn/subscribers","subscription_url":"https://api.github.com/repos/shengofsun/rdsn/subscription","commits_url":"https://api.github.com/repos/shengofsun/rdsn/commits{/sha}","git_commits_url":"https://api.github.com/repos/shengofsun/rdsn/git/commits{/sha}","comments_url":"https://api.github.com/repos/shengofsun/rdsn/comments{/number}","issue_comment_url":"https://api.github.com/repos/shengofsun/rdsn/issues/comments{/number}","contents_url":"https://api.github.com/repos/shengofsun/rdsn/contents/{+path}","compare_url":"https://api.github.com/repos/shengofsun/rdsn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shengofsun/rdsn/merges","archive_url":"https://api.github.com/repos/shengofsun/rdsn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shengofsun/rdsn/downloads","issues_url":"https://api.github.com/repos/shengofsun/rdsn/issues{/number}","pulls_url":"https://api.github.com/repos/shengofsun/rdsn/pulls{/number}","milestones_url":"https://api.github.com/repos/shengofsun/rdsn/milestones{/number}","notifications_url":"https://api.github.com/repos/shengofsun/rdsn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shengofsun/rdsn/labels{/name}","releases_url":"https://api.github.com/repos/shengofsun/rdsn/releases{/id}","deployments_url":"https://api.github.com/repos/shengofsun/rdsn/deployments","created_at":"2018-02-06T08:25:09Z","updated_at":"2018-06-08T11:33:55Z","pushed_at":"2018-06-08T11:33:53Z","git_url":"git://github.com/shengofsun/rdsn.git","ssh_url":"git@github.com:shengofsun/rdsn.git","clone_url":"https://github.com/shengofsun/rdsn.git","svn_url":"https://github.com/shengofsun/rdsn","homepage":null,"size":78673,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"XiaoMi:master","ref":"master","sha":"9377c4caf911563935c0937492c11a312f1bced4","user":{"login":"XiaoMi","id":1309360,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMDkzNjA=","avatar_url":"https://avatars3.githubusercontent.com/u/1309360?v=4","gravatar_id":"","url":"https://api.github.com/users/XiaoMi","html_url":"https://github.com/XiaoMi","followers_url":"https://api.github.com/users/XiaoMi/followers","following_url":"https://api.github.com/users/XiaoMi/following{/other_user}","gists_url":"https://api.github.com/users/XiaoMi/gists{/gist_id}","starred_url":"https://api.github.com/users/XiaoMi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XiaoMi/subscriptions","organizations_url":"https://api.github.com/users/XiaoMi/orgs","repos_url":"https://api.github.com/users/XiaoMi/repos","events_url":"https://api.github.com/users/XiaoMi/events{/privacy}","received_events_url":"https://api.github.com/users/XiaoMi/received_events","type":"Organization","site_admin":false},"repo":{"id":104966876,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQ5NjY4NzY=","name":"rdsn","full_name":"XiaoMi/rdsn","owner":{"login":"XiaoMi","id":1309360,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMDkzNjA=","avatar_url":"https://avatars3.githubusercontent.com/u/1309360?v=4","gravatar_id":"","url":"https://api.github.com/users/XiaoMi","html_url":"https://github.com/XiaoMi","followers_url":"https://api.github.com/users/XiaoMi/followers","following_url":"https://api.github.com/users/XiaoMi/following{/other_user}","gists_url":"https://api.github.com/users/XiaoMi/gists{/gist_id}","starred_url":"https://api.github.com/users/XiaoMi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XiaoMi/subscriptions","organizations_url":"https://api.github.com/users/XiaoMi/orgs","repos_url":"https://api.github.com/users/XiaoMi/repos","events_url":"https://api.github.com/users/XiaoMi/events{/privacy}","received_events_url":"https://api.github.com/users/XiaoMi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/XiaoMi/rdsn","description":null,"fork":false,"url":"https://api.github.com/repos/XiaoMi/rdsn","forks_url":"https://api.github.com/repos/XiaoMi/rdsn/forks","keys_url":"https://api.github.com/repos/XiaoMi/rdsn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/XiaoMi/rdsn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/XiaoMi/rdsn/teams","hooks_url":"https://api.github.com/repos/XiaoMi/rdsn/hooks","issue_events_url":"https://api.github.com/repos/XiaoMi/rdsn/issues/events{/number}","events_url":"https://api.github.com/repos/XiaoMi/rdsn/events","assignees_url":"https://api.github.com/repos/XiaoMi/rdsn/assignees{/user}","branches_url":"https://api.github.com/repos/XiaoMi/rdsn/branches{/branch}","tags_url":"https://api.github.com/repos/XiaoMi/rdsn/tags","blobs_url":"https://api.github.com/repos/XiaoMi/rdsn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/XiaoMi/rdsn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/XiaoMi/rdsn/git/refs{/sha}","trees_url":"https://api.github.com/repos/XiaoMi/rdsn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/XiaoMi/rdsn/statuses/{sha}","languages_url":"https://api.github.com/repos/XiaoMi/rdsn/languages","stargazers_url":"https://api.github.com/repos/XiaoMi/rdsn/stargazers","contributors_url":"https://api.github.com/repos/XiaoMi/rdsn/contributors","subscribers_url":"https://api.github.com/repos/XiaoMi/rdsn/subscribers","subscription_url":"https://api.github.com/repos/XiaoMi/rdsn/subscription","commits_url":"https://api.github.com/repos/XiaoMi/rdsn/commits{/sha}","git_commits_url":"https://api.github.com/repos/XiaoMi/rdsn/git/commits{/sha}","comments_url":"https://api.github.com/repos/XiaoMi/rdsn/comments{/number}","issue_comment_url":"https://api.github.com/repos/XiaoMi/rdsn/issues/comments{/number}","contents_url":"https://api.github.com/repos/XiaoMi/rdsn/contents/{+path}","compare_url":"https://api.github.com/repos/XiaoMi/rdsn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/XiaoMi/rdsn/merges","archive_url":"https://api.github.com/repos/XiaoMi/rdsn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/XiaoMi/rdsn/downloads","issues_url":"https://api.github.com/repos/XiaoMi/rdsn/issues{/number}","pulls_url":"https://api.github.com/repos/XiaoMi/rdsn/pulls{/number}","milestones_url":"https://api.github.com/repos/XiaoMi/rdsn/milestones{/number}","notifications_url":"https://api.github.com/repos/XiaoMi/rdsn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/XiaoMi/rdsn/labels{/name}","releases_url":"https://api.github.com/repos/XiaoMi/rdsn/releases{/id}","deployments_url":"https://api.github.com/repos/XiaoMi/rdsn/deployments","created_at":"2017-09-27T03:19:21Z","updated_at":"2018-06-08T07:35:30Z","pushed_at":"2018-06-08T07:35:28Z","git_url":"git://github.com/XiaoMi/rdsn.git","ssh_url":"git@github.com:XiaoMi/rdsn.git","clone_url":"https://github.com/XiaoMi/rdsn.git","svn_url":"https://github.com/XiaoMi/rdsn","homepage":null,"size":79057,"stargazers_count":27,"watchers_count":27,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":12,"open_issues":18,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/XiaoMi/rdsn/pulls/93"},"html":{"href":"https://github.com/XiaoMi/rdsn/pull/93"},"issue":{"href":"https://api.github.com/repos/XiaoMi/rdsn/issues/93"},"comments":{"href":"https://api.github.com/repos/XiaoMi/rdsn/issues/93/comments"},"review_comments":{"href":"https://api.github.com/repos/XiaoMi/rdsn/pulls/93/comments"},"review_comment":{"href":"https://api.github.com/repos/XiaoMi/rdsn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/XiaoMi/rdsn/pulls/93/commits"},"statuses":{"href":"https://api.github.com/repos/XiaoMi/rdsn/statuses/079cedbb285e21196ce0d5c5ec14c51ae6cff800"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":168,"deletions":6309,"changed_files":138}}
{"actor":{"display_login":"shengofsun"}}