{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/20368","repository_url":"https://api.github.com/repos/servo/servo","labels_url":"https://api.github.com/repos/servo/servo/issues/20368/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/20368/comments","events_url":"https://api.github.com/repos/servo/servo/issues/20368/events","html_url":"https://github.com/servo/servo/pull/20368","id":307000194,"number":20368,"title":"refactor(counter_style): parse int via parse_non_negative","user":{"login":"kwonoj","id":1210596,"avatar_url":"https://avatars2.githubusercontent.com/u/1210596?v=4","gravatar_id":"","url":"https://api.github.com/users/kwonoj","html_url":"https://github.com/kwonoj","followers_url":"https://api.github.com/users/kwonoj/followers","following_url":"https://api.github.com/users/kwonoj/following{/other_user}","gists_url":"https://api.github.com/users/kwonoj/gists{/gist_id}","starred_url":"https://api.github.com/users/kwonoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwonoj/subscriptions","organizations_url":"https://api.github.com/users/kwonoj/orgs","repos_url":"https://api.github.com/users/kwonoj/repos","events_url":"https://api.github.com/users/kwonoj/events{/privacy}","received_events_url":"https://api.github.com/users/kwonoj/received_events","type":"User","site_admin":false},"labels":[{"id":152310043,"url":"https://api.github.com/repos/servo/servo/labels/S-awaiting-review","name":"S-awaiting-review","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":{"login":"asajeffrey","id":403333,"avatar_url":"https://avatars1.githubusercontent.com/u/403333?v=4","gravatar_id":"","url":"https://api.github.com/users/asajeffrey","html_url":"https://github.com/asajeffrey","followers_url":"https://api.github.com/users/asajeffrey/followers","following_url":"https://api.github.com/users/asajeffrey/following{/other_user}","gists_url":"https://api.github.com/users/asajeffrey/gists{/gist_id}","starred_url":"https://api.github.com/users/asajeffrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asajeffrey/subscriptions","organizations_url":"https://api.github.com/users/asajeffrey/orgs","repos_url":"https://api.github.com/users/asajeffrey/repos","events_url":"https://api.github.com/users/asajeffrey/events{/privacy}","received_events_url":"https://api.github.com/users/asajeffrey/received_events","type":"User","site_admin":false},"assignees":[{"login":"asajeffrey","id":403333,"avatar_url":"https://avatars1.githubusercontent.com/u/403333?v=4","gravatar_id":"","url":"https://api.github.com/users/asajeffrey","html_url":"https://github.com/asajeffrey","followers_url":"https://api.github.com/users/asajeffrey/followers","following_url":"https://api.github.com/users/asajeffrey/following{/other_user}","gists_url":"https://api.github.com/users/asajeffrey/gists{/gist_id}","starred_url":"https://api.github.com/users/asajeffrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asajeffrey/subscriptions","organizations_url":"https://api.github.com/users/asajeffrey/orgs","repos_url":"https://api.github.com/users/asajeffrey/repos","events_url":"https://api.github.com/users/asajeffrey/events{/privacy}","received_events_url":"https://api.github.com/users/asajeffrey/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-03-20T19:07:57Z","updated_at":"2018-03-20T19:08:03Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/20368","html_url":"https://github.com/servo/servo/pull/20368","diff_url":"https://github.com/servo/servo/pull/20368.diff","patch_url":"https://github.com/servo/servo/pull/20368.patch"},"body":"<!-- Please describe your changes on the following line: -->\r\nRelates to #20332.\r\n\r\nThis PR intends to refactor `counter_style` to use `parse_non_negative` where applicable, mostly which uses `expect_integer` currently. Change still grabs value from parsed result then assign it into each struct as needed and does not change definition of struct (i.e `AdditiveTuple`) itself.\r\n\r\n---\r\n<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->\r\n- [x] `./mach build -d` does not report any errors\r\n- [x] `./mach test-tidy` does not report any errors\r\n- [x] These changes fix #20332 (github issue number if applicable).\r\n\r\n<!-- Either: -->\r\n- [ ] There are tests for these changes OR\r\n- [ ] These changes do not require tests because _____\r\n- This PR has locally built & ran unit test on macOS.\r\n\r\n<!-- Also, please make sure that \"Allow edits from maintainers\" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->\r\n\r\n<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->\r\n"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/374720362","html_url":"https://github.com/servo/servo/pull/20368#issuecomment-374720362","issue_url":"https://api.github.com/repos/servo/servo/issues/20368","id":374720362,"user":{"login":"highfive","id":5750442,"avatar_url":"https://avatars2.githubusercontent.com/u/5750442?v=4","gravatar_id":"","url":"https://api.github.com/users/highfive","html_url":"https://github.com/highfive","followers_url":"https://api.github.com/users/highfive/followers","following_url":"https://api.github.com/users/highfive/following{/other_user}","gists_url":"https://api.github.com/users/highfive/gists{/gist_id}","starred_url":"https://api.github.com/users/highfive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfive/subscriptions","organizations_url":"https://api.github.com/users/highfive/orgs","repos_url":"https://api.github.com/users/highfive/repos","events_url":"https://api.github.com/users/highfive/events{/privacy}","received_events_url":"https://api.github.com/users/highfive/received_events","type":"User","site_admin":false},"created_at":"2018-03-20T19:08:03Z","updated_at":"2018-03-20T19:08:03Z","author_association":"NONE","body":"<img src=\"http://www.joshmatthews.net/warning.svg\" alt=\"warning\" height=20> **Warning** <img src=\"http://www.joshmatthews.net/warning.svg\" alt=\"warning\" height=20>\n\n* These commits modify style code, but no tests are modified. Please consider adding a test!"}}
{"actor":{"display_login":"highfive"}}