{"action":"created","issue":{"url":"https://api.github.com/repos/jun0205/react-static-boilerplate/issues/14","repository_url":"https://api.github.com/repos/jun0205/react-static-boilerplate","labels_url":"https://api.github.com/repos/jun0205/react-static-boilerplate/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/jun0205/react-static-boilerplate/issues/14/comments","events_url":"https://api.github.com/repos/jun0205/react-static-boilerplate/issues/14/events","html_url":"https://github.com/jun0205/react-static-boilerplate/issues/14","id":309782568,"number":14,"title":"DEBUG build is not compatible with IE8","user":{"login":"bcowgill","id":968686,"avatar_url":"https://avatars1.githubusercontent.com/u/968686?v=4","gravatar_id":"","url":"https://api.github.com/users/bcowgill","html_url":"https://github.com/bcowgill","followers_url":"https://api.github.com/users/bcowgill/followers","following_url":"https://api.github.com/users/bcowgill/following{/other_user}","gists_url":"https://api.github.com/users/bcowgill/gists{/gist_id}","starred_url":"https://api.github.com/users/bcowgill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcowgill/subscriptions","organizations_url":"https://api.github.com/users/bcowgill/orgs","repos_url":"https://api.github.com/users/bcowgill/repos","events_url":"https://api.github.com/users/bcowgill/events{/privacy}","received_events_url":"https://api.github.com/users/bcowgill/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-29T14:41:51Z","updated_at":"2018-03-30T03:59:44Z","closed_at":null,"author_association":"NONE","body":"First of all, thanks a million for making this IE8 compatible react repository available.  We're in route to production and suddenly told that we have to support IE8 because the business hasn't completed it's IE8 decommissioning project on time.\r\n\r\nThe issue I've noticed is if you do the debug build yarn build:debug then the app fails to load in IE8.\r\nI get Expected Identifier error in vendor bundle\r\n```\r\n if (true) {\r\n    var REACT_ELEMENT_TYPE = (typeof Symbol === 'function' &&\r\n===>      Symbol.for &&\r\n```\r\n\r\nAnd Expected identifier, string or number in main bundle  \r\n```\r\nfunction _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }\r\nmust be the default: obj\r\n```\r\n\r\nI found If I always to the Uglify call then it works...\r\n\r\n```\r\nif (!DEBUG) {\r\n  config.plugins.push(new webpack.optimize.DedupePlugin())\r\n}\r\n// Must always be done or it won't work in IE8\r\n  config.plugins.push(new webpack.optimize.UglifyJsPlugin({\r\n    compress: { warnings: VERBOSE, screw_ie8: false },\r\n    mangle: { screw_ie8: false },\r\n    output: { screw_ie8: false },\r\n  }))\r\nif (!DEBUG) {\r\n  config.plugins.push(new webpack.optimize.AggressiveMergingPlugin())\r\n  config.module.loaders\r\n    .find(x => x.loader === 'babel-loader').query.plugins\r\n    .unshift(\r\n    'transform-react-remove-prop-types',\r\n    'transform-react-constant-elements',\r\n    'transform-react-inline-elements',\r\n    'transform-es3-modules-literals',\r\n    'transform-es3-member-expression-literals',\r\n    'transform-es3-property-literals'\r\n    )\r\n}\r\n```\r\n\r\nI tried changing it so it didn't compress or mangle, but still did the output screw_ie8 but that caused the same problem."},"comment":{"url":"https://api.github.com/repos/jun0205/react-static-boilerplate/issues/comments/377439309","html_url":"https://github.com/jun0205/react-static-boilerplate/issues/14#issuecomment-377439309","issue_url":"https://api.github.com/repos/jun0205/react-static-boilerplate/issues/14","id":377439309,"user":{"login":"jun0205","id":922174,"avatar_url":"https://avatars2.githubusercontent.com/u/922174?v=4","gravatar_id":"","url":"https://api.github.com/users/jun0205","html_url":"https://github.com/jun0205","followers_url":"https://api.github.com/users/jun0205/followers","following_url":"https://api.github.com/users/jun0205/following{/other_user}","gists_url":"https://api.github.com/users/jun0205/gists{/gist_id}","starred_url":"https://api.github.com/users/jun0205/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jun0205/subscriptions","organizations_url":"https://api.github.com/users/jun0205/orgs","repos_url":"https://api.github.com/users/jun0205/repos","events_url":"https://api.github.com/users/jun0205/events{/privacy}","received_events_url":"https://api.github.com/users/jun0205/received_events","type":"User","site_admin":false},"created_at":"2018-03-30T03:59:44Z","updated_at":"2018-03-30T03:59:44Z","author_association":"OWNER","body":"Thank you.\r\nFix https://github.com/jun0205/react-static-boilerplate/commit/4c38aeff1e173ddb249b379645e79d2a45c05aa7"}}
{"actor":{"display_login":"jun0205"}}