{"action":"created","issue":{"url":"https://api.github.com/repos/marmelab/admin-on-rest/issues/1459","repository_url":"https://api.github.com/repos/marmelab/admin-on-rest","labels_url":"https://api.github.com/repos/marmelab/admin-on-rest/issues/1459/labels{/name}","comments_url":"https://api.github.com/repos/marmelab/admin-on-rest/issues/1459/comments","events_url":"https://api.github.com/repos/marmelab/admin-on-rest/issues/1459/events","html_url":"https://github.com/marmelab/admin-on-rest/pull/1459","id":293565583,"number":1459,"title":"[WIP] Decoupling allowEmpty prop from reference selectors","user":{"login":"alexisjanvier","id":547706,"avatar_url":"https://avatars0.githubusercontent.com/u/547706?v=4","gravatar_id":"","url":"https://api.github.com/users/alexisjanvier","html_url":"https://github.com/alexisjanvier","followers_url":"https://api.github.com/users/alexisjanvier/followers","following_url":"https://api.github.com/users/alexisjanvier/following{/other_user}","gists_url":"https://api.github.com/users/alexisjanvier/gists{/gist_id}","starred_url":"https://api.github.com/users/alexisjanvier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexisjanvier/subscriptions","organizations_url":"https://api.github.com/users/alexisjanvier/orgs","repos_url":"https://api.github.com/users/alexisjanvier/repos","events_url":"https://api.github.com/users/alexisjanvier/events{/privacy}","received_events_url":"https://api.github.com/users/alexisjanvier/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/marmelab/admin-on-rest/milestones/16","html_url":"https://github.com/marmelab/admin-on-rest/milestone/16","labels_url":"https://api.github.com/repos/marmelab/admin-on-rest/milestones/16/labels","id":3058087,"number":16,"title":"1.4.0","description":"","creator":{"login":"djhi","id":1122076,"avatar_url":"https://avatars2.githubusercontent.com/u/1122076?v=4","gravatar_id":"","url":"https://api.github.com/users/djhi","html_url":"https://github.com/djhi","followers_url":"https://api.github.com/users/djhi/followers","following_url":"https://api.github.com/users/djhi/following{/other_user}","gists_url":"https://api.github.com/users/djhi/gists{/gist_id}","starred_url":"https://api.github.com/users/djhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djhi/subscriptions","organizations_url":"https://api.github.com/users/djhi/orgs","repos_url":"https://api.github.com/users/djhi/repos","events_url":"https://api.github.com/users/djhi/events{/privacy}","received_events_url":"https://api.github.com/users/djhi/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":27,"state":"open","created_at":"2018-01-23T16:31:21Z","updated_at":"2018-02-07T15:44:32Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2018-02-01T15:11:06Z","updated_at":"2018-02-12T14:31:20Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/marmelab/admin-on-rest/pulls/1459","html_url":"https://github.com/marmelab/admin-on-rest/pull/1459","diff_url":"https://github.com/marmelab/admin-on-rest/pull/1459.diff","patch_url":"https://github.com/marmelab/admin-on-rest/pull/1459.patch"},"body":"Fix #953 \r\nFix #1153 \r\n\r\n`allowEmpty` should only be used to add or not an empty choice in the choices list, with a value of null.\r\nIt must not interfere with the fetch of references.\r\n\r\nThe reference selectors must indicate either that the reference fetch is in progress, that the reference fetch has failed, or display the *choice component* with choices based on the fetched references.\r\n\r\n### todo\r\n- [x] Display of a spinner during references fetch\r\n![fetchok](https://user-images.githubusercontent.com/547706/35847513-f6b23512-0b1a-11e8-9420-73cdab32cb30.gif)\r\n\r\n- [x] Display fetch error if it exists\r\n![fetchko](https://user-images.githubusercontent.com/547706/35847559-113381de-0b1b-11e8-8692-479e78ffdb77.gif)\r\n\r\n\r\n- [x] Render children component after fetch with allowEmpty prop binded\r\n- [x] Update documentation about `allowEmpty`\r\n"},"comment":{"url":"https://api.github.com/repos/marmelab/admin-on-rest/issues/comments/364939091","html_url":"https://github.com/marmelab/admin-on-rest/pull/1459#issuecomment-364939091","issue_url":"https://api.github.com/repos/marmelab/admin-on-rest/issues/1459","id":364939091,"user":{"login":"alexisjanvier","id":547706,"avatar_url":"https://avatars0.githubusercontent.com/u/547706?v=4","gravatar_id":"","url":"https://api.github.com/users/alexisjanvier","html_url":"https://github.com/alexisjanvier","followers_url":"https://api.github.com/users/alexisjanvier/followers","following_url":"https://api.github.com/users/alexisjanvier/following{/other_user}","gists_url":"https://api.github.com/users/alexisjanvier/gists{/gist_id}","starred_url":"https://api.github.com/users/alexisjanvier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexisjanvier/subscriptions","organizations_url":"https://api.github.com/users/alexisjanvier/orgs","repos_url":"https://api.github.com/users/alexisjanvier/repos","events_url":"https://api.github.com/users/alexisjanvier/events{/privacy}","received_events_url":"https://api.github.com/users/alexisjanvier/received_events","type":"User","site_admin":false},"created_at":"2018-02-12T14:31:20Z","updated_at":"2018-02-12T14:31:20Z","author_association":"MEMBER","body":"@fzaninotto #854 is about `<Reference*Field>` not `<Reference*Input>`. This should be adressed in another PR."}}
{"actor":{"display_login":"alexisjanvier"}}