{"action":"created","comment":{"url":"https://api.github.com/repos/nos/client/pulls/comments/244403684","pull_request_review_id":188366047,"id":244403684,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDQwMzY4NA==","diff_hunk":"@@ -0,0 +1,5 @@\n+import { randomBytes } from 'crypto';","path":"src/renderer/browser/util/getRandomIV.js","position":1,"original_position":1,"commit_id":"de290d4fbbef1c55163432b957aebedb6b8f7b2b","original_commit_id":"de290d4fbbef1c55163432b957aebedb6b8f7b2b","user":{"login":"DalderupMaurice","id":10922045,"node_id":"MDQ6VXNlcjEwOTIyMDQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10922045?v=4","gravatar_id":"","url":"https://api.github.com/users/DalderupMaurice","html_url":"https://github.com/DalderupMaurice","followers_url":"https://api.github.com/users/DalderupMaurice/followers","following_url":"https://api.github.com/users/DalderupMaurice/following{/other_user}","gists_url":"https://api.github.com/users/DalderupMaurice/gists{/gist_id}","starred_url":"https://api.github.com/users/DalderupMaurice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DalderupMaurice/subscriptions","organizations_url":"https://api.github.com/users/DalderupMaurice/orgs","repos_url":"https://api.github.com/users/DalderupMaurice/repos","events_url":"https://api.github.com/users/DalderupMaurice/events{/privacy}","received_events_url":"https://api.github.com/users/DalderupMaurice/received_events","type":"User","site_admin":false},"body":"Also this dep doesn't seem to be included in the `package.json`/yarn.lock file","created_at":"2018-12-28T20:40:02Z","updated_at":"2018-12-28T20:40:02Z","html_url":"https://github.com/nos/client/pull/241#discussion_r244403684","pull_request_url":"https://api.github.com/repos/nos/client/pulls/241","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nos/client/pulls/comments/244403684"},"html":{"href":"https://github.com/nos/client/pull/241#discussion_r244403684"},"pull_request":{"href":"https://api.github.com/repos/nos/client/pulls/241"}}},"pull_request":{"url":"https://api.github.com/repos/nos/client/pulls/241","id":195364222,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MzY0MjIy","html_url":"https://github.com/nos/client/pull/241","diff_url":"https://github.com/nos/client/pull/241.diff","patch_url":"https://github.com/nos/client/pull/241.patch","issue_url":"https://api.github.com/repos/nos/client/issues/241","number":241,"state":"open","locked":false,"title":"feat(encrypt): add functions to allow encryption and decryption of arbitrary data","user":{"login":"trueinsider","id":662644,"node_id":"MDQ6VXNlcjY2MjY0NA==","avatar_url":"https://avatars3.githubusercontent.com/u/662644?v=4","gravatar_id":"","url":"https://api.github.com/users/trueinsider","html_url":"https://github.com/trueinsider","followers_url":"https://api.github.com/users/trueinsider/followers","following_url":"https://api.github.com/users/trueinsider/following{/other_user}","gists_url":"https://api.github.com/users/trueinsider/gists{/gist_id}","starred_url":"https://api.github.com/users/trueinsider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trueinsider/subscriptions","organizations_url":"https://api.github.com/users/trueinsider/orgs","repos_url":"https://api.github.com/users/trueinsider/repos","events_url":"https://api.github.com/users/trueinsider/events{/privacy}","received_events_url":"https://api.github.com/users/trueinsider/received_events","type":"User","site_admin":false},"body":"## Description\r\nThere is three new API functions:\r\n`getPublicKey` -- provides the public key of the currently authenticated account\r\n`encrypt` -- allows to encrypt arbitrary data\r\n`decrypt` -- allows to decrypt previously encrypted data\r\n\r\n## Motivation and Context\r\nTo securely exchange messages in the decentralized applications context some kind of encryption is necessary.\r\n\r\n## How Has This Been Tested?\r\nTested in client connected to nos-local with the help of slightly modified template dApp. Also there is new tests added.\r\n\r\n## Types of changes\r\n- [ ] Chore (tests, refactors, and fixes)\r\n- [x] New feature (adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n\r\n## Checklist:\r\n- [x] My code follows the code style of this project.\r\n- [x] The commit message follows our guidelines\r\n- [x] Tests for the changes have been added (for bug fixes / features)\r\n- [x] Docs have been added / updated (for bug fixes / features)\r\n- [x] I have read the **CONTRIBUTING** document.","created_at":"2018-06-17T06:41:32Z","updated_at":"2018-12-28T20:40:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0e86428edd2873c45a10293cd2f6560a06a336d5","assignee":{"login":"mhuggins","id":169093,"node_id":"MDQ6VXNlcjE2OTA5Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/169093?v=4","gravatar_id":"","url":"https://api.github.com/users/mhuggins","html_url":"https://github.com/mhuggins","followers_url":"https://api.github.com/users/mhuggins/followers","following_url":"https://api.github.com/users/mhuggins/following{/other_user}","gists_url":"https://api.github.com/users/mhuggins/gists{/gist_id}","starred_url":"https://api.github.com/users/mhuggins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhuggins/subscriptions","organizations_url":"https://api.github.com/users/mhuggins/orgs","repos_url":"https://api.github.com/users/mhuggins/repos","events_url":"https://api.github.com/users/mhuggins/events{/privacy}","received_events_url":"https://api.github.com/users/mhuggins/received_events","type":"User","site_admin":false},"assignees":[{"login":"mhuggins","id":169093,"node_id":"MDQ6VXNlcjE2OTA5Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/169093?v=4","gravatar_id":"","url":"https://api.github.com/users/mhuggins","html_url":"https://github.com/mhuggins","followers_url":"https://api.github.com/users/mhuggins/followers","following_url":"https://api.github.com/users/mhuggins/following{/other_user}","gists_url":"https://api.github.com/users/mhuggins/gists{/gist_id}","starred_url":"https://api.github.com/users/mhuggins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhuggins/subscriptions","organizations_url":"https://api.github.com/users/mhuggins/orgs","repos_url":"https://api.github.com/users/mhuggins/repos","events_url":"https://api.github.com/users/mhuggins/events{/privacy}","received_events_url":"https://api.github.com/users/mhuggins/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":835230505,"node_id":"MDU6TGFiZWw4MzUyMzA1MDU=","url":"https://api.github.com/repos/nos/client/labels/PR:%20don't%20merge","name":"PR: don't merge","color":"d93f0b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nos/client/pulls/241/commits","review_comments_url":"https://api.github.com/repos/nos/client/pulls/241/comments","review_comment_url":"https://api.github.com/repos/nos/client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nos/client/issues/241/comments","statuses_url":"https://api.github.com/repos/nos/client/statuses/de290d4fbbef1c55163432b957aebedb6b8f7b2b","head":{"label":"trueinsider:feat/encrypt","ref":"feat/encrypt","sha":"de290d4fbbef1c55163432b957aebedb6b8f7b2b","user":{"login":"trueinsider","id":662644,"node_id":"MDQ6VXNlcjY2MjY0NA==","avatar_url":"https://avatars3.githubusercontent.com/u/662644?v=4","gravatar_id":"","url":"https://api.github.com/users/trueinsider","html_url":"https://github.com/trueinsider","followers_url":"https://api.github.com/users/trueinsider/followers","following_url":"https://api.github.com/users/trueinsider/following{/other_user}","gists_url":"https://api.github.com/users/trueinsider/gists{/gist_id}","starred_url":"https://api.github.com/users/trueinsider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trueinsider/subscriptions","organizations_url":"https://api.github.com/users/trueinsider/orgs","repos_url":"https://api.github.com/users/trueinsider/repos","events_url":"https://api.github.com/users/trueinsider/events{/privacy}","received_events_url":"https://api.github.com/users/trueinsider/received_events","type":"User","site_admin":false},"repo":{"id":137631982,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc2MzE5ODI=","name":"client","full_name":"trueinsider/client","private":false,"owner":{"login":"trueinsider","id":662644,"node_id":"MDQ6VXNlcjY2MjY0NA==","avatar_url":"https://avatars3.githubusercontent.com/u/662644?v=4","gravatar_id":"","url":"https://api.github.com/users/trueinsider","html_url":"https://github.com/trueinsider","followers_url":"https://api.github.com/users/trueinsider/followers","following_url":"https://api.github.com/users/trueinsider/following{/other_user}","gists_url":"https://api.github.com/users/trueinsider/gists{/gist_id}","starred_url":"https://api.github.com/users/trueinsider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trueinsider/subscriptions","organizations_url":"https://api.github.com/users/trueinsider/orgs","repos_url":"https://api.github.com/users/trueinsider/repos","events_url":"https://api.github.com/users/trueinsider/events{/privacy}","received_events_url":"https://api.github.com/users/trueinsider/received_events","type":"User","site_admin":false},"html_url":"https://github.com/trueinsider/client","description":"The nOS Client","fork":true,"url":"https://api.github.com/repos/trueinsider/client","forks_url":"https://api.github.com/repos/trueinsider/client/forks","keys_url":"https://api.github.com/repos/trueinsider/client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trueinsider/client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trueinsider/client/teams","hooks_url":"https://api.github.com/repos/trueinsider/client/hooks","issue_events_url":"https://api.github.com/repos/trueinsider/client/issues/events{/number}","events_url":"https://api.github.com/repos/trueinsider/client/events","assignees_url":"https://api.github.com/repos/trueinsider/client/assignees{/user}","branches_url":"https://api.github.com/repos/trueinsider/client/branches{/branch}","tags_url":"https://api.github.com/repos/trueinsider/client/tags","blobs_url":"https://api.github.com/repos/trueinsider/client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trueinsider/client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trueinsider/client/git/refs{/sha}","trees_url":"https://api.github.com/repos/trueinsider/client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trueinsider/client/statuses/{sha}","languages_url":"https://api.github.com/repos/trueinsider/client/languages","stargazers_url":"https://api.github.com/repos/trueinsider/client/stargazers","contributors_url":"https://api.github.com/repos/trueinsider/client/contributors","subscribers_url":"https://api.github.com/repos/trueinsider/client/subscribers","subscription_url":"https://api.github.com/repos/trueinsider/client/subscription","commits_url":"https://api.github.com/repos/trueinsider/client/commits{/sha}","git_commits_url":"https://api.github.com/repos/trueinsider/client/git/commits{/sha}","comments_url":"https://api.github.com/repos/trueinsider/client/comments{/number}","issue_comment_url":"https://api.github.com/repos/trueinsider/client/issues/comments{/number}","contents_url":"https://api.github.com/repos/trueinsider/client/contents/{+path}","compare_url":"https://api.github.com/repos/trueinsider/client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trueinsider/client/merges","archive_url":"https://api.github.com/repos/trueinsider/client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trueinsider/client/downloads","issues_url":"https://api.github.com/repos/trueinsider/client/issues{/number}","pulls_url":"https://api.github.com/repos/trueinsider/client/pulls{/number}","milestones_url":"https://api.github.com/repos/trueinsider/client/milestones{/number}","notifications_url":"https://api.github.com/repos/trueinsider/client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trueinsider/client/labels{/name}","releases_url":"https://api.github.com/repos/trueinsider/client/releases{/id}","deployments_url":"https://api.github.com/repos/trueinsider/client/deployments","created_at":"2018-06-17T05:45:48Z","updated_at":"2018-07-23T20:55:41Z","pushed_at":"2018-12-28T20:34:43Z","git_url":"git://github.com/trueinsider/client.git","ssh_url":"git@github.com:trueinsider/client.git","clone_url":"https://github.com/trueinsider/client.git","svn_url":"https://github.com/trueinsider/client","homepage":"https://nos.io","size":4674,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"nos:develop","ref":"develop","sha":"97d204bdd94ec91d7d4ff079256765b07940efc1","user":{"login":"nos","id":36414779,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NDE0Nzc5","avatar_url":"https://avatars3.githubusercontent.com/u/36414779?v=4","gravatar_id":"","url":"https://api.github.com/users/nos","html_url":"https://github.com/nos","followers_url":"https://api.github.com/users/nos/followers","following_url":"https://api.github.com/users/nos/following{/other_user}","gists_url":"https://api.github.com/users/nos/gists{/gist_id}","starred_url":"https://api.github.com/users/nos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nos/subscriptions","organizations_url":"https://api.github.com/users/nos/orgs","repos_url":"https://api.github.com/users/nos/repos","events_url":"https://api.github.com/users/nos/events{/privacy}","received_events_url":"https://api.github.com/users/nos/received_events","type":"Organization","site_admin":false},"repo":{"id":121267259,"node_id":"MDEwOlJlcG9zaXRvcnkxMjEyNjcyNTk=","name":"client","full_name":"nos/client","private":false,"owner":{"login":"nos","id":36414779,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NDE0Nzc5","avatar_url":"https://avatars3.githubusercontent.com/u/36414779?v=4","gravatar_id":"","url":"https://api.github.com/users/nos","html_url":"https://github.com/nos","followers_url":"https://api.github.com/users/nos/followers","following_url":"https://api.github.com/users/nos/following{/other_user}","gists_url":"https://api.github.com/users/nos/gists{/gist_id}","starred_url":"https://api.github.com/users/nos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nos/subscriptions","organizations_url":"https://api.github.com/users/nos/orgs","repos_url":"https://api.github.com/users/nos/repos","events_url":"https://api.github.com/users/nos/events{/privacy}","received_events_url":"https://api.github.com/users/nos/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nos/client","description":"The nOS Client","fork":false,"url":"https://api.github.com/repos/nos/client","forks_url":"https://api.github.com/repos/nos/client/forks","keys_url":"https://api.github.com/repos/nos/client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nos/client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nos/client/teams","hooks_url":"https://api.github.com/repos/nos/client/hooks","issue_events_url":"https://api.github.com/repos/nos/client/issues/events{/number}","events_url":"https://api.github.com/repos/nos/client/events","assignees_url":"https://api.github.com/repos/nos/client/assignees{/user}","branches_url":"https://api.github.com/repos/nos/client/branches{/branch}","tags_url":"https://api.github.com/repos/nos/client/tags","blobs_url":"https://api.github.com/repos/nos/client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nos/client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nos/client/git/refs{/sha}","trees_url":"https://api.github.com/repos/nos/client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nos/client/statuses/{sha}","languages_url":"https://api.github.com/repos/nos/client/languages","stargazers_url":"https://api.github.com/repos/nos/client/stargazers","contributors_url":"https://api.github.com/repos/nos/client/contributors","subscribers_url":"https://api.github.com/repos/nos/client/subscribers","subscription_url":"https://api.github.com/repos/nos/client/subscription","commits_url":"https://api.github.com/repos/nos/client/commits{/sha}","git_commits_url":"https://api.github.com/repos/nos/client/git/commits{/sha}","comments_url":"https://api.github.com/repos/nos/client/comments{/number}","issue_comment_url":"https://api.github.com/repos/nos/client/issues/comments{/number}","contents_url":"https://api.github.com/repos/nos/client/contents/{+path}","compare_url":"https://api.github.com/repos/nos/client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nos/client/merges","archive_url":"https://api.github.com/repos/nos/client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nos/client/downloads","issues_url":"https://api.github.com/repos/nos/client/issues{/number}","pulls_url":"https://api.github.com/repos/nos/client/pulls{/number}","milestones_url":"https://api.github.com/repos/nos/client/milestones{/number}","notifications_url":"https://api.github.com/repos/nos/client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nos/client/labels{/name}","releases_url":"https://api.github.com/repos/nos/client/releases{/id}","deployments_url":"https://api.github.com/repos/nos/client/deployments","created_at":"2018-02-12T15:54:37Z","updated_at":"2018-12-28T20:09:08Z","pushed_at":"2018-12-28T20:34:44Z","git_url":"git://github.com/nos/client.git","ssh_url":"git@github.com:nos/client.git","clone_url":"https://github.com/nos/client.git","svn_url":"https://github.com/nos/client","homepage":"https://nos.io","size":6571,"stargazers_count":177,"watchers_count":177,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":80,"mirror_url":null,"archived":false,"open_issues_count":81,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":80,"open_issues":81,"watchers":177,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/nos/client/pulls/241"},"html":{"href":"https://github.com/nos/client/pull/241"},"issue":{"href":"https://api.github.com/repos/nos/client/issues/241"},"comments":{"href":"https://api.github.com/repos/nos/client/issues/241/comments"},"review_comments":{"href":"https://api.github.com/repos/nos/client/pulls/241/comments"},"review_comment":{"href":"https://api.github.com/repos/nos/client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nos/client/pulls/241/commits"},"statuses":{"href":"https://api.github.com/repos/nos/client/statuses/de290d4fbbef1c55163432b957aebedb6b8f7b2b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"DalderupMaurice"}}