{"action":"created","comment":{"url":"https://api.github.com/repos/libero/php-coding-standard/pulls/comments/234118910","pull_request_review_id":175692351,"id":234118910,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDExODkxMA==","diff_hunk":"@@ -0,0 +1,28 @@\n+---DESCRIPTION---\n+Statements must not be empty, except catch blocks\n+---CONTENTS---\n+<?php\n+\n+declare(strict_types=1);\n+\n+if ($foo) {\n+    // Bar","path":"tests/cases/php/empty-statement","position":9,"original_position":9,"commit_id":"6f94fd9b1f7921bd64addf2ba671d575463a9bae","original_commit_id":"6f94fd9b1f7921bd64addf2ba671d575463a9bae","user":{"login":"thewilkybarkid","id":1784740,"node_id":"MDQ6VXNlcjE3ODQ3NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/1784740?v=4","gravatar_id":"","url":"https://api.github.com/users/thewilkybarkid","html_url":"https://github.com/thewilkybarkid","followers_url":"https://api.github.com/users/thewilkybarkid/followers","following_url":"https://api.github.com/users/thewilkybarkid/following{/other_user}","gists_url":"https://api.github.com/users/thewilkybarkid/gists{/gist_id}","starred_url":"https://api.github.com/users/thewilkybarkid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thewilkybarkid/subscriptions","organizations_url":"https://api.github.com/users/thewilkybarkid/orgs","repos_url":"https://api.github.com/users/thewilkybarkid/repos","events_url":"https://api.github.com/users/thewilkybarkid/events{/privacy}","received_events_url":"https://api.github.com/users/thewilkybarkid/received_events","type":"User","site_admin":false},"body":"Could find anything locally. Searched Symfony as it's a large codebase, there are a few, such as:\r\n\r\n- https://github.com/symfony/symfony/blob/737726516e819fc0b1ea43dc6491bddd6d98b1f4/src/Symfony/Component/DependencyInjection/Container.php#L161-L163\r\n- https://github.com/symfony/symfony/blob/737726516e819fc0b1ea43dc6491bddd6d98b1f4/src/Symfony/Component/Debug/ExceptionHandler.php#L123-L125\r\n- https://github.com/symfony/symfony/blob/737726516e819fc0b1ea43dc6491bddd6d98b1f4/src/Symfony/Component/PropertyAccess/PropertyAccessor.php#L339-L341\r\n- https://github.com/symfony/symfony/blob/737726516e819fc0b1ea43dc6491bddd6d98b1f4/src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler.php#L120-L122\r\n\r\nI think this cases are all avoidable (by returning early etc), but maybe this should just be something for code review.","created_at":"2018-11-16T08:12:08Z","updated_at":"2018-11-16T08:12:09Z","html_url":"https://github.com/libero/php-coding-standard/pull/34#discussion_r234118910","pull_request_url":"https://api.github.com/repos/libero/php-coding-standard/pulls/34","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/libero/php-coding-standard/pulls/comments/234118910"},"html":{"href":"https://github.com/libero/php-coding-standard/pull/34#discussion_r234118910"},"pull_request":{"href":"https://api.github.com/repos/libero/php-coding-standard/pulls/34"}},"in_reply_to_id":233818322},"pull_request":{"url":"https://api.github.com/repos/libero/php-coding-standard/pulls/34","id":231171023,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMTcxMDIz","html_url":"https://github.com/libero/php-coding-standard/pull/34","diff_url":"https://github.com/libero/php-coding-standard/pull/34.diff","patch_url":"https://github.com/libero/php-coding-standard/pull/34.patch","issue_url":"https://api.github.com/repos/libero/php-coding-standard/issues/34","number":34,"state":"open","locked":false,"title":"Statements must not be empty, except catch blocks","user":{"login":"thewilkybarkid","id":1784740,"node_id":"MDQ6VXNlcjE3ODQ3NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/1784740?v=4","gravatar_id":"","url":"https://api.github.com/users/thewilkybarkid","html_url":"https://github.com/thewilkybarkid","followers_url":"https://api.github.com/users/thewilkybarkid/followers","following_url":"https://api.github.com/users/thewilkybarkid/following{/other_user}","gists_url":"https://api.github.com/users/thewilkybarkid/gists{/gist_id}","starred_url":"https://api.github.com/users/thewilkybarkid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thewilkybarkid/subscriptions","organizations_url":"https://api.github.com/users/thewilkybarkid/orgs","repos_url":"https://api.github.com/users/thewilkybarkid/repos","events_url":"https://api.github.com/users/thewilkybarkid/events{/privacy}","received_events_url":"https://api.github.com/users/thewilkybarkid/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-15T12:05:28Z","updated_at":"2018-11-16T08:12:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4fb0a536c87afe9d227352402ee6016973cdd37","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1034376530,"node_id":"MDU6TGFiZWwxMDM0Mzc2NTMw","url":"https://api.github.com/repos/libero/php-coding-standard/labels/feature","name":"feature","color":"a2eeef","default":false}],"milestone":{"url":"https://api.github.com/repos/libero/php-coding-standard/milestones/6","html_url":"https://github.com/libero/php-coding-standard/milestone/6","labels_url":"https://api.github.com/repos/libero/php-coding-standard/milestones/6/labels","id":3823663,"node_id":"MDk6TWlsZXN0b25lMzgyMzY2Mw==","number":6,"title":"0.4.0","description":"","creator":{"login":"thewilkybarkid","id":1784740,"node_id":"MDQ6VXNlcjE3ODQ3NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/1784740?v=4","gravatar_id":"","url":"https://api.github.com/users/thewilkybarkid","html_url":"https://github.com/thewilkybarkid","followers_url":"https://api.github.com/users/thewilkybarkid/followers","following_url":"https://api.github.com/users/thewilkybarkid/following{/other_user}","gists_url":"https://api.github.com/users/thewilkybarkid/gists{/gist_id}","starred_url":"https://api.github.com/users/thewilkybarkid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thewilkybarkid/subscriptions","organizations_url":"https://api.github.com/users/thewilkybarkid/orgs","repos_url":"https://api.github.com/users/thewilkybarkid/repos","events_url":"https://api.github.com/users/thewilkybarkid/events{/privacy}","received_events_url":"https://api.github.com/users/thewilkybarkid/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":0,"state":"open","created_at":"2018-11-15T08:07:15Z","updated_at":"2018-11-15T13:31:34Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/libero/php-coding-standard/pulls/34/commits","review_comments_url":"https://api.github.com/repos/libero/php-coding-standard/pulls/34/comments","review_comment_url":"https://api.github.com/repos/libero/php-coding-standard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libero/php-coding-standard/issues/34/comments","statuses_url":"https://api.github.com/repos/libero/php-coding-standard/statuses/6f94fd9b1f7921bd64addf2ba671d575463a9bae","head":{"label":"thewilkybarkid:empty-statement","ref":"empty-statement","sha":"6f94fd9b1f7921bd64addf2ba671d575463a9bae","user":{"login":"thewilkybarkid","id":1784740,"node_id":"MDQ6VXNlcjE3ODQ3NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/1784740?v=4","gravatar_id":"","url":"https://api.github.com/users/thewilkybarkid","html_url":"https://github.com/thewilkybarkid","followers_url":"https://api.github.com/users/thewilkybarkid/followers","following_url":"https://api.github.com/users/thewilkybarkid/following{/other_user}","gists_url":"https://api.github.com/users/thewilkybarkid/gists{/gist_id}","starred_url":"https://api.github.com/users/thewilkybarkid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thewilkybarkid/subscriptions","organizations_url":"https://api.github.com/users/thewilkybarkid/orgs","repos_url":"https://api.github.com/users/thewilkybarkid/repos","events_url":"https://api.github.com/users/thewilkybarkid/events{/privacy}","received_events_url":"https://api.github.com/users/thewilkybarkid/received_events","type":"User","site_admin":false},"repo":{"id":146002206,"node_id":"MDEwOlJlcG9zaXRvcnkxNDYwMDIyMDY=","name":"php-coding-standard","full_name":"thewilkybarkid/php-coding-standard","private":false,"owner":{"login":"thewilkybarkid","id":1784740,"node_id":"MDQ6VXNlcjE3ODQ3NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/1784740?v=4","gravatar_id":"","url":"https://api.github.com/users/thewilkybarkid","html_url":"https://github.com/thewilkybarkid","followers_url":"https://api.github.com/users/thewilkybarkid/followers","following_url":"https://api.github.com/users/thewilkybarkid/following{/other_user}","gists_url":"https://api.github.com/users/thewilkybarkid/gists{/gist_id}","starred_url":"https://api.github.com/users/thewilkybarkid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thewilkybarkid/subscriptions","organizations_url":"https://api.github.com/users/thewilkybarkid/orgs","repos_url":"https://api.github.com/users/thewilkybarkid/repos","events_url":"https://api.github.com/users/thewilkybarkid/events{/privacy}","received_events_url":"https://api.github.com/users/thewilkybarkid/received_events","type":"User","site_admin":false},"html_url":"https://github.com/thewilkybarkid/php-coding-standard","description":"Libero PHP coding standard","fork":true,"url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard","forks_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/forks","keys_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/teams","hooks_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/hooks","issue_events_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/issues/events{/number}","events_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/events","assignees_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/assignees{/user}","branches_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/branches{/branch}","tags_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/tags","blobs_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/git/refs{/sha}","trees_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/statuses/{sha}","languages_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/languages","stargazers_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/stargazers","contributors_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/contributors","subscribers_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/subscribers","subscription_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/subscription","commits_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/commits{/sha}","git_commits_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/git/commits{/sha}","comments_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/comments{/number}","issue_comment_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/issues/comments{/number}","contents_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/contents/{+path}","compare_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/merges","archive_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/downloads","issues_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/issues{/number}","pulls_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/pulls{/number}","milestones_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/milestones{/number}","notifications_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/labels{/name}","releases_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/releases{/id}","deployments_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/deployments","created_at":"2018-08-24T14:32:06Z","updated_at":"2018-09-24T06:36:49Z","pushed_at":"2018-11-15T13:30:59Z","git_url":"git://github.com/thewilkybarkid/php-coding-standard.git","ssh_url":"git@github.com:thewilkybarkid/php-coding-standard.git","clone_url":"https://github.com/thewilkybarkid/php-coding-standard.git","svn_url":"https://github.com/thewilkybarkid/php-coding-standard","homepage":null,"size":81,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"libero:master","ref":"master","sha":"0bba2855baed3a9d9e3a8bcb009ef477a60ed122","user":{"login":"libero","id":37089447,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MDg5NDQ3","avatar_url":"https://avatars1.githubusercontent.com/u/37089447?v=4","gravatar_id":"","url":"https://api.github.com/users/libero","html_url":"https://github.com/libero","followers_url":"https://api.github.com/users/libero/followers","following_url":"https://api.github.com/users/libero/following{/other_user}","gists_url":"https://api.github.com/users/libero/gists{/gist_id}","starred_url":"https://api.github.com/users/libero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libero/subscriptions","organizations_url":"https://api.github.com/users/libero/orgs","repos_url":"https://api.github.com/users/libero/repos","events_url":"https://api.github.com/users/libero/events{/privacy}","received_events_url":"https://api.github.com/users/libero/received_events","type":"Organization","site_admin":false},"repo":{"id":146001837,"node_id":"MDEwOlJlcG9zaXRvcnkxNDYwMDE4Mzc=","name":"php-coding-standard","full_name":"libero/php-coding-standard","private":false,"owner":{"login":"libero","id":37089447,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MDg5NDQ3","avatar_url":"https://avatars1.githubusercontent.com/u/37089447?v=4","gravatar_id":"","url":"https://api.github.com/users/libero","html_url":"https://github.com/libero","followers_url":"https://api.github.com/users/libero/followers","following_url":"https://api.github.com/users/libero/following{/other_user}","gists_url":"https://api.github.com/users/libero/gists{/gist_id}","starred_url":"https://api.github.com/users/libero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libero/subscriptions","organizations_url":"https://api.github.com/users/libero/orgs","repos_url":"https://api.github.com/users/libero/repos","events_url":"https://api.github.com/users/libero/events{/privacy}","received_events_url":"https://api.github.com/users/libero/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/libero/php-coding-standard","description":"Libero PHP coding standard","fork":false,"url":"https://api.github.com/repos/libero/php-coding-standard","forks_url":"https://api.github.com/repos/libero/php-coding-standard/forks","keys_url":"https://api.github.com/repos/libero/php-coding-standard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libero/php-coding-standard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libero/php-coding-standard/teams","hooks_url":"https://api.github.com/repos/libero/php-coding-standard/hooks","issue_events_url":"https://api.github.com/repos/libero/php-coding-standard/issues/events{/number}","events_url":"https://api.github.com/repos/libero/php-coding-standard/events","assignees_url":"https://api.github.com/repos/libero/php-coding-standard/assignees{/user}","branches_url":"https://api.github.com/repos/libero/php-coding-standard/branches{/branch}","tags_url":"https://api.github.com/repos/libero/php-coding-standard/tags","blobs_url":"https://api.github.com/repos/libero/php-coding-standard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libero/php-coding-standard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libero/php-coding-standard/git/refs{/sha}","trees_url":"https://api.github.com/repos/libero/php-coding-standard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libero/php-coding-standard/statuses/{sha}","languages_url":"https://api.github.com/repos/libero/php-coding-standard/languages","stargazers_url":"https://api.github.com/repos/libero/php-coding-standard/stargazers","contributors_url":"https://api.github.com/repos/libero/php-coding-standard/contributors","subscribers_url":"https://api.github.com/repos/libero/php-coding-standard/subscribers","subscription_url":"https://api.github.com/repos/libero/php-coding-standard/subscription","commits_url":"https://api.github.com/repos/libero/php-coding-standard/commits{/sha}","git_commits_url":"https://api.github.com/repos/libero/php-coding-standard/git/commits{/sha}","comments_url":"https://api.github.com/repos/libero/php-coding-standard/comments{/number}","issue_comment_url":"https://api.github.com/repos/libero/php-coding-standard/issues/comments{/number}","contents_url":"https://api.github.com/repos/libero/php-coding-standard/contents/{+path}","compare_url":"https://api.github.com/repos/libero/php-coding-standard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libero/php-coding-standard/merges","archive_url":"https://api.github.com/repos/libero/php-coding-standard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libero/php-coding-standard/downloads","issues_url":"https://api.github.com/repos/libero/php-coding-standard/issues{/number}","pulls_url":"https://api.github.com/repos/libero/php-coding-standard/pulls{/number}","milestones_url":"https://api.github.com/repos/libero/php-coding-standard/milestones{/number}","notifications_url":"https://api.github.com/repos/libero/php-coding-standard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libero/php-coding-standard/labels{/name}","releases_url":"https://api.github.com/repos/libero/php-coding-standard/releases{/id}","deployments_url":"https://api.github.com/repos/libero/php-coding-standard/deployments","created_at":"2018-08-24T14:29:07Z","updated_at":"2018-11-15T08:04:52Z","pushed_at":"2018-11-15T13:31:35Z","git_url":"git://github.com/libero/php-coding-standard.git","ssh_url":"git@github.com:libero/php-coding-standard.git","clone_url":"https://github.com/libero/php-coding-standard.git","svn_url":"https://github.com/libero/php-coding-standard","homepage":null,"size":66,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libero/php-coding-standard/pulls/34"},"html":{"href":"https://github.com/libero/php-coding-standard/pull/34"},"issue":{"href":"https://api.github.com/repos/libero/php-coding-standard/issues/34"},"comments":{"href":"https://api.github.com/repos/libero/php-coding-standard/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/libero/php-coding-standard/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/libero/php-coding-standard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libero/php-coding-standard/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/libero/php-coding-standard/statuses/6f94fd9b1f7921bd64addf2ba671d575463a9bae"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"thewilkybarkid"}}