{"action":"closed","issue":{"url":"https://api.github.com/repos/PredixDev/px-modal/issues/34","repository_url":"https://api.github.com/repos/PredixDev/px-modal","labels_url":"https://api.github.com/repos/PredixDev/px-modal/issues/34/labels{/name}","comments_url":"https://api.github.com/repos/PredixDev/px-modal/issues/34/comments","events_url":"https://api.github.com/repos/PredixDev/px-modal/issues/34/events","html_url":"https://github.com/PredixDev/px-modal/issues/34","id":294597047,"number":34,"title":"Modal closing behavior on 'accept' button clicked","user":{"login":"sachinkantipudi","id":13139814,"avatar_url":"https://avatars0.githubusercontent.com/u/13139814?v=4","gravatar_id":"","url":"https://api.github.com/users/sachinkantipudi","html_url":"https://github.com/sachinkantipudi","followers_url":"https://api.github.com/users/sachinkantipudi/followers","following_url":"https://api.github.com/users/sachinkantipudi/following{/other_user}","gists_url":"https://api.github.com/users/sachinkantipudi/gists{/gist_id}","starred_url":"https://api.github.com/users/sachinkantipudi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sachinkantipudi/subscriptions","organizations_url":"https://api.github.com/users/sachinkantipudi/orgs","repos_url":"https://api.github.com/users/sachinkantipudi/repos","events_url":"https://api.github.com/users/sachinkantipudi/events{/privacy}","received_events_url":"https://api.github.com/users/sachinkantipudi/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"davidrleonard","id":6456757,"avatar_url":"https://avatars3.githubusercontent.com/u/6456757?v=4","gravatar_id":"","url":"https://api.github.com/users/davidrleonard","html_url":"https://github.com/davidrleonard","followers_url":"https://api.github.com/users/davidrleonard/followers","following_url":"https://api.github.com/users/davidrleonard/following{/other_user}","gists_url":"https://api.github.com/users/davidrleonard/gists{/gist_id}","starred_url":"https://api.github.com/users/davidrleonard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidrleonard/subscriptions","organizations_url":"https://api.github.com/users/davidrleonard/orgs","repos_url":"https://api.github.com/users/davidrleonard/repos","events_url":"https://api.github.com/users/davidrleonard/events{/privacy}","received_events_url":"https://api.github.com/users/davidrleonard/received_events","type":"User","site_admin":false},"assignees":[{"login":"davidrleonard","id":6456757,"avatar_url":"https://avatars3.githubusercontent.com/u/6456757?v=4","gravatar_id":"","url":"https://api.github.com/users/davidrleonard","html_url":"https://github.com/davidrleonard","followers_url":"https://api.github.com/users/davidrleonard/followers","following_url":"https://api.github.com/users/davidrleonard/following{/other_user}","gists_url":"https://api.github.com/users/davidrleonard/gists{/gist_id}","starred_url":"https://api.github.com/users/davidrleonard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidrleonard/subscriptions","organizations_url":"https://api.github.com/users/davidrleonard/orgs","repos_url":"https://api.github.com/users/davidrleonard/repos","events_url":"https://api.github.com/users/davidrleonard/events{/privacy}","received_events_url":"https://api.github.com/users/davidrleonard/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2018-02-06T01:04:17Z","updated_at":"2018-02-08T00:44:14Z","closed_at":"2018-02-08T00:44:14Z","author_association":"NONE","body":"Hi,\r\n\r\n## Expected behavior and actual behavior:\r\nExpected: When positive action button is disabled (say form empty) in the modal, clicking on it should not close the modal\r\nActual: Modal is closing\r\n\r\n## Steps to reproduce the problem:\r\nHave a modal with custom header and body (div slot). Initial state of the positive action button is disabled (let's say), and now click on positive action button. Currently modal is closing. It should close only when you click on enabled button. \r\n\r\n## Environment (_component version number, Browser (including version), operating system, hardware, etc_):\r\npx-modal: 3.2.1\r\n\r\n## Screenshots (_optional, but very helpful_):\r\n<img width=\"482\" alt=\"screen shot 2018-02-05 at 5 00 42 pm\" src=\"https://user-images.githubusercontent.com/13139814/35836633-2de7c4fa-0a96-11e8-99f3-ff8b2d2182ac.png\">\r\n\r\n## Root cause found:\r\n`<div class=\"modal__accept-trigger\" on-tap=\"_handleAcceptTriggerTapped\">`\r\non-tap should not be there on parent div, it should affect only button inside that div. \r\n"}}
{"actor":{"display_login":"davidrleonard"}}