{"action":"created","comment":{"url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/pulls/comments/220036832","pull_request_review_id":158351897,"id":220036832,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDAzNjgzMg==","diff_hunk":"@@ -36,6 +40,12 @@ def create\n     @parser.user_id = current_user.id\n     @source = @parser.source\n \n+    @partners = if can? :manage, Partner\n+              Partner.asc(:name)","path":"app/controllers/parsers_controller.rb","position":39,"original_position":39,"commit_id":"71aab1e81ac503eceb9faec6388a8e03cb6a866b","original_commit_id":"71aab1e81ac503eceb9faec6388a8e03cb6a866b","user":{"login":"theomarkkuspaul","id":13745712,"node_id":"MDQ6VXNlcjEzNzQ1NzEy","avatar_url":"https://avatars0.githubusercontent.com/u/13745712?v=4","gravatar_id":"","url":"https://api.github.com/users/theomarkkuspaul","html_url":"https://github.com/theomarkkuspaul","followers_url":"https://api.github.com/users/theomarkkuspaul/followers","following_url":"https://api.github.com/users/theomarkkuspaul/following{/other_user}","gists_url":"https://api.github.com/users/theomarkkuspaul/gists{/gist_id}","starred_url":"https://api.github.com/users/theomarkkuspaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theomarkkuspaul/subscriptions","organizations_url":"https://api.github.com/users/theomarkkuspaul/orgs","repos_url":"https://api.github.com/users/theomarkkuspaul/repos","events_url":"https://api.github.com/users/theomarkkuspaul/events{/privacy}","received_events_url":"https://api.github.com/users/theomarkkuspaul/received_events","type":"User","site_admin":false},"body":"double check indentation here?","created_at":"2018-09-25T01:33:35Z","updated_at":"2018-09-25T01:52:18Z","html_url":"https://github.com/DigitalNZ/supplejack_manager/pull/74#discussion_r220036832","pull_request_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/pulls/74","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DigitalNZ/supplejack_manager/pulls/comments/220036832"},"html":{"href":"https://github.com/DigitalNZ/supplejack_manager/pull/74#discussion_r220036832"},"pull_request":{"href":"https://api.github.com/repos/DigitalNZ/supplejack_manager/pulls/74"}}},"pull_request":{"url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/pulls/74","id":217828117,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3ODI4MTE3","html_url":"https://github.com/DigitalNZ/supplejack_manager/pull/74","diff_url":"https://github.com/DigitalNZ/supplejack_manager/pull/74.diff","patch_url":"https://github.com/DigitalNZ/supplejack_manager/pull/74.patch","issue_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/issues/74","number":74,"state":"open","locked":false,"title":"PREVENT ILLEGAL PARSER NAMES: As Tonya I want to be informed and blocked from entering any illegal characters in a new parser name, so that the parser does not save fine while silently failing to preview or run","user":{"login":"Reinkaos","id":1848911,"node_id":"MDQ6VXNlcjE4NDg5MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1848911?v=4","gravatar_id":"","url":"https://api.github.com/users/Reinkaos","html_url":"https://github.com/Reinkaos","followers_url":"https://api.github.com/users/Reinkaos/followers","following_url":"https://api.github.com/users/Reinkaos/following{/other_user}","gists_url":"https://api.github.com/users/Reinkaos/gists{/gist_id}","starred_url":"https://api.github.com/users/Reinkaos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Reinkaos/subscriptions","organizations_url":"https://api.github.com/users/Reinkaos/orgs","repos_url":"https://api.github.com/users/Reinkaos/repos","events_url":"https://api.github.com/users/Reinkaos/events{/privacy}","received_events_url":"https://api.github.com/users/Reinkaos/received_events","type":"User","site_admin":false},"body":"**Acceptance Criteria**\r\n- New parser name field does not accept/save when illegal characters are present\r\n- Harvester is informed of what characters are (or are not) allowed to be used and asked to change before the parser/form is saved\r\n\r\n**Notes**\r\n- If you use macrons or full stops (or probably other illegal char's) in a parser name, it will silently fail to do anything (eg preview or harvest). Form needs some validation warnings and/or hint text in the new parser form that helps prevent this problem\r\nhttp://harvester.dnz0a.cloud.digitalnz.org/parsers/new","created_at":"2018-09-25T00:56:44Z","updated_at":"2018-09-25T01:52:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb1133717c334ca0912814440c70abe996e3ea9b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/pulls/74/commits","review_comments_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/pulls/74/comments","review_comment_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/issues/74/comments","statuses_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/statuses/71aab1e81ac503eceb9faec6388a8e03cb6a866b","head":{"label":"DigitalNZ:rm/prevent-illegal-parser-names","ref":"rm/prevent-illegal-parser-names","sha":"71aab1e81ac503eceb9faec6388a8e03cb6a866b","user":{"login":"DigitalNZ","id":93386,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzMzg2","avatar_url":"https://avatars2.githubusercontent.com/u/93386?v=4","gravatar_id":"","url":"https://api.github.com/users/DigitalNZ","html_url":"https://github.com/DigitalNZ","followers_url":"https://api.github.com/users/DigitalNZ/followers","following_url":"https://api.github.com/users/DigitalNZ/following{/other_user}","gists_url":"https://api.github.com/users/DigitalNZ/gists{/gist_id}","starred_url":"https://api.github.com/users/DigitalNZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DigitalNZ/subscriptions","organizations_url":"https://api.github.com/users/DigitalNZ/orgs","repos_url":"https://api.github.com/users/DigitalNZ/repos","events_url":"https://api.github.com/users/DigitalNZ/events{/privacy}","received_events_url":"https://api.github.com/users/DigitalNZ/received_events","type":"Organization","site_admin":false},"repo":{"id":18787015,"node_id":"MDEwOlJlcG9zaXRvcnkxODc4NzAxNQ==","name":"supplejack_manager","full_name":"DigitalNZ/supplejack_manager","private":false,"owner":{"login":"DigitalNZ","id":93386,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzMzg2","avatar_url":"https://avatars2.githubusercontent.com/u/93386?v=4","gravatar_id":"","url":"https://api.github.com/users/DigitalNZ","html_url":"https://github.com/DigitalNZ","followers_url":"https://api.github.com/users/DigitalNZ/followers","following_url":"https://api.github.com/users/DigitalNZ/following{/other_user}","gists_url":"https://api.github.com/users/DigitalNZ/gists{/gist_id}","starred_url":"https://api.github.com/users/DigitalNZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DigitalNZ/subscriptions","organizations_url":"https://api.github.com/users/DigitalNZ/orgs","repos_url":"https://api.github.com/users/DigitalNZ/repos","events_url":"https://api.github.com/users/DigitalNZ/events{/privacy}","received_events_url":"https://api.github.com/users/DigitalNZ/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DigitalNZ/supplejack_manager","description":"Supplejack Stack Manager UI","fork":false,"url":"https://api.github.com/repos/DigitalNZ/supplejack_manager","forks_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/forks","keys_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/teams","hooks_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/hooks","issue_events_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/issues/events{/number}","events_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/events","assignees_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/assignees{/user}","branches_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/branches{/branch}","tags_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/tags","blobs_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/statuses/{sha}","languages_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/languages","stargazers_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/stargazers","contributors_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/contributors","subscribers_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/subscribers","subscription_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/subscription","commits_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/contents/{+path}","compare_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/merges","archive_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/downloads","issues_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/issues{/number}","pulls_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/pulls{/number}","milestones_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/milestones{/number}","notifications_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/labels{/name}","releases_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/releases{/id}","deployments_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/deployments","created_at":"2014-04-15T04:06:27Z","updated_at":"2018-06-11T03:59:41Z","pushed_at":"2018-09-25T01:30:49Z","git_url":"git://github.com/DigitalNZ/supplejack_manager.git","ssh_url":"git@github.com:DigitalNZ/supplejack_manager.git","clone_url":"https://github.com/DigitalNZ/supplejack_manager.git","svn_url":"https://github.com/DigitalNZ/supplejack_manager","homepage":"http://digitalnz.github.io/supplejack/start/supplejack-manager.html","size":2082,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":8,"open_issues":3,"watchers":5,"default_branch":"master"}},"base":{"label":"DigitalNZ:master","ref":"master","sha":"32225550385e8b454ec432939b5839b1a5997c4a","user":{"login":"DigitalNZ","id":93386,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzMzg2","avatar_url":"https://avatars2.githubusercontent.com/u/93386?v=4","gravatar_id":"","url":"https://api.github.com/users/DigitalNZ","html_url":"https://github.com/DigitalNZ","followers_url":"https://api.github.com/users/DigitalNZ/followers","following_url":"https://api.github.com/users/DigitalNZ/following{/other_user}","gists_url":"https://api.github.com/users/DigitalNZ/gists{/gist_id}","starred_url":"https://api.github.com/users/DigitalNZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DigitalNZ/subscriptions","organizations_url":"https://api.github.com/users/DigitalNZ/orgs","repos_url":"https://api.github.com/users/DigitalNZ/repos","events_url":"https://api.github.com/users/DigitalNZ/events{/privacy}","received_events_url":"https://api.github.com/users/DigitalNZ/received_events","type":"Organization","site_admin":false},"repo":{"id":18787015,"node_id":"MDEwOlJlcG9zaXRvcnkxODc4NzAxNQ==","name":"supplejack_manager","full_name":"DigitalNZ/supplejack_manager","private":false,"owner":{"login":"DigitalNZ","id":93386,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzMzg2","avatar_url":"https://avatars2.githubusercontent.com/u/93386?v=4","gravatar_id":"","url":"https://api.github.com/users/DigitalNZ","html_url":"https://github.com/DigitalNZ","followers_url":"https://api.github.com/users/DigitalNZ/followers","following_url":"https://api.github.com/users/DigitalNZ/following{/other_user}","gists_url":"https://api.github.com/users/DigitalNZ/gists{/gist_id}","starred_url":"https://api.github.com/users/DigitalNZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DigitalNZ/subscriptions","organizations_url":"https://api.github.com/users/DigitalNZ/orgs","repos_url":"https://api.github.com/users/DigitalNZ/repos","events_url":"https://api.github.com/users/DigitalNZ/events{/privacy}","received_events_url":"https://api.github.com/users/DigitalNZ/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DigitalNZ/supplejack_manager","description":"Supplejack Stack Manager UI","fork":false,"url":"https://api.github.com/repos/DigitalNZ/supplejack_manager","forks_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/forks","keys_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/teams","hooks_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/hooks","issue_events_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/issues/events{/number}","events_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/events","assignees_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/assignees{/user}","branches_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/branches{/branch}","tags_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/tags","blobs_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/statuses/{sha}","languages_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/languages","stargazers_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/stargazers","contributors_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/contributors","subscribers_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/subscribers","subscription_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/subscription","commits_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/contents/{+path}","compare_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/merges","archive_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/downloads","issues_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/issues{/number}","pulls_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/pulls{/number}","milestones_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/milestones{/number}","notifications_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/labels{/name}","releases_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/releases{/id}","deployments_url":"https://api.github.com/repos/DigitalNZ/supplejack_manager/deployments","created_at":"2014-04-15T04:06:27Z","updated_at":"2018-06-11T03:59:41Z","pushed_at":"2018-09-25T01:30:49Z","git_url":"git://github.com/DigitalNZ/supplejack_manager.git","ssh_url":"git@github.com:DigitalNZ/supplejack_manager.git","clone_url":"https://github.com/DigitalNZ/supplejack_manager.git","svn_url":"https://github.com/DigitalNZ/supplejack_manager","homepage":"http://digitalnz.github.io/supplejack/start/supplejack-manager.html","size":2082,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":8,"open_issues":3,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DigitalNZ/supplejack_manager/pulls/74"},"html":{"href":"https://github.com/DigitalNZ/supplejack_manager/pull/74"},"issue":{"href":"https://api.github.com/repos/DigitalNZ/supplejack_manager/issues/74"},"comments":{"href":"https://api.github.com/repos/DigitalNZ/supplejack_manager/issues/74/comments"},"review_comments":{"href":"https://api.github.com/repos/DigitalNZ/supplejack_manager/pulls/74/comments"},"review_comment":{"href":"https://api.github.com/repos/DigitalNZ/supplejack_manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DigitalNZ/supplejack_manager/pulls/74/commits"},"statuses":{"href":"https://api.github.com/repos/DigitalNZ/supplejack_manager/statuses/71aab1e81ac503eceb9faec6388a8e03cb6a866b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"theomarkkuspaul"}}