{"action":"created","comment":{"url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/pulls/comments/207570902","pull_request_review_id":143214159,"id":207570902,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzU3MDkwMg==","diff_hunk":"@@ -1,14 +1,19 @@\n {\n   \"name\": \"@highpoint/bs-js-fetch\",\n+  \"bs-dev-dependencies\": [\"bs-tape\"],\n   \"sources\": [\n     {\n       \"dir\": \"src\"\n+    }, \n+    {\n+      \"dir\": \"tests\",\n+      \"type\": \"dev\"\n     }\n   ],\n   \"refmt\": 3,\n   \"suffix\": \".bs.js\",\n   \"package-specs\": {\n-    \"module\": \"es6\",\n+    \"module\": \"commonjs\",","path":"bsconfig.json","position":17,"original_position":17,"commit_id":"9f84ca643268953ea7c33ee185a235d18a27debc","original_commit_id":"9f84ca643268953ea7c33ee185a235d18a27debc","user":{"login":"mciparelli","id":403621,"node_id":"MDQ6VXNlcjQwMzYyMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/403621?v=4","gravatar_id":"","url":"https://api.github.com/users/mciparelli","html_url":"https://github.com/mciparelli","followers_url":"https://api.github.com/users/mciparelli/followers","following_url":"https://api.github.com/users/mciparelli/following{/other_user}","gists_url":"https://api.github.com/users/mciparelli/gists{/gist_id}","starred_url":"https://api.github.com/users/mciparelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mciparelli/subscriptions","organizations_url":"https://api.github.com/users/mciparelli/orgs","repos_url":"https://api.github.com/users/mciparelli/repos","events_url":"https://api.github.com/users/mciparelli/events{/privacy}","received_events_url":"https://api.github.com/users/mciparelli/received_events","type":"User","site_admin":false},"body":"Built versions only matter for tests, and I just wanted to have it running as quickly as possible. I could've used no bundler, but the package I'm using to run tests in the browser adds the stdin as a normal script tag (https://github.com/juliangruber/browser-run/blob/master/static/index.html) so I needed to use a bundler and went with browserify which is the simplest to setup. If I wanted to keep es6 I would've had to use a browserify transform, felt simpler/faster to just switch to commonjs instead.","created_at":"2018-08-03T14:53:32Z","updated_at":"2018-08-03T14:53:32Z","html_url":"https://github.com/hp-mobile/bs-js-fetch/pull/4#discussion_r207570902","pull_request_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/pulls/4","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hp-mobile/bs-js-fetch/pulls/comments/207570902"},"html":{"href":"https://github.com/hp-mobile/bs-js-fetch/pull/4#discussion_r207570902"},"pull_request":{"href":"https://api.github.com/repos/hp-mobile/bs-js-fetch/pulls/4"}},"in_reply_to_id":207561552},"pull_request":{"url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/pulls/4","id":205895285,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1ODk1Mjg1","html_url":"https://github.com/hp-mobile/bs-js-fetch/pull/4","diff_url":"https://github.com/hp-mobile/bs-js-fetch/pull/4.diff","patch_url":"https://github.com/hp-mobile/bs-js-fetch/pull/4.patch","issue_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/issues/4","number":4,"state":"open","locked":false,"title":"Add tests","user":{"login":"mciparelli","id":403621,"node_id":"MDQ6VXNlcjQwMzYyMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/403621?v=4","gravatar_id":"","url":"https://api.github.com/users/mciparelli","html_url":"https://github.com/mciparelli","followers_url":"https://api.github.com/users/mciparelli/followers","following_url":"https://api.github.com/users/mciparelli/following{/other_user}","gists_url":"https://api.github.com/users/mciparelli/gists{/gist_id}","starred_url":"https://api.github.com/users/mciparelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mciparelli/subscriptions","organizations_url":"https://api.github.com/users/mciparelli/orgs","repos_url":"https://api.github.com/users/mciparelli/repos","events_url":"https://api.github.com/users/mciparelli/events{/privacy}","received_events_url":"https://api.github.com/users/mciparelli/received_events","type":"User","site_admin":false},"body":null,"created_at":"2018-08-03T00:21:55Z","updated_at":"2018-08-03T14:53:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"afa9735fbe64d601edbde9546a1154a4817f2ba4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/pulls/4/commits","review_comments_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/pulls/4/comments","review_comment_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/issues/4/comments","statuses_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/statuses/9f84ca643268953ea7c33ee185a235d18a27debc","head":{"label":"hp-mobile:add-tests","ref":"add-tests","sha":"9f84ca643268953ea7c33ee185a235d18a27debc","user":{"login":"hp-mobile","id":2566172,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NjYxNzI=","avatar_url":"https://avatars3.githubusercontent.com/u/2566172?v=4","gravatar_id":"","url":"https://api.github.com/users/hp-mobile","html_url":"https://github.com/hp-mobile","followers_url":"https://api.github.com/users/hp-mobile/followers","following_url":"https://api.github.com/users/hp-mobile/following{/other_user}","gists_url":"https://api.github.com/users/hp-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/hp-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hp-mobile/subscriptions","organizations_url":"https://api.github.com/users/hp-mobile/orgs","repos_url":"https://api.github.com/users/hp-mobile/repos","events_url":"https://api.github.com/users/hp-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/hp-mobile/received_events","type":"Organization","site_admin":false},"repo":{"id":142896947,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI4OTY5NDc=","name":"bs-js-fetch","full_name":"hp-mobile/bs-js-fetch","owner":{"login":"hp-mobile","id":2566172,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NjYxNzI=","avatar_url":"https://avatars3.githubusercontent.com/u/2566172?v=4","gravatar_id":"","url":"https://api.github.com/users/hp-mobile","html_url":"https://github.com/hp-mobile","followers_url":"https://api.github.com/users/hp-mobile/followers","following_url":"https://api.github.com/users/hp-mobile/following{/other_user}","gists_url":"https://api.github.com/users/hp-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/hp-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hp-mobile/subscriptions","organizations_url":"https://api.github.com/users/hp-mobile/orgs","repos_url":"https://api.github.com/users/hp-mobile/repos","events_url":"https://api.github.com/users/hp-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/hp-mobile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hp-mobile/bs-js-fetch","description":"BuckleScript bindings for HighPoint Fetch Library","fork":false,"url":"https://api.github.com/repos/hp-mobile/bs-js-fetch","forks_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/forks","keys_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/teams","hooks_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/hooks","issue_events_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/issues/events{/number}","events_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/events","assignees_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/assignees{/user}","branches_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/branches{/branch}","tags_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/tags","blobs_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/git/refs{/sha}","trees_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/statuses/{sha}","languages_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/languages","stargazers_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/stargazers","contributors_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/contributors","subscribers_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/subscribers","subscription_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/subscription","commits_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/commits{/sha}","git_commits_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/git/commits{/sha}","comments_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/comments{/number}","issue_comment_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/issues/comments{/number}","contents_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/contents/{+path}","compare_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/merges","archive_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/downloads","issues_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/issues{/number}","pulls_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/pulls{/number}","milestones_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/milestones{/number}","notifications_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/labels{/name}","releases_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/releases{/id}","deployments_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/deployments","created_at":"2018-07-30T15:52:10Z","updated_at":"2018-08-02T19:10:44Z","pushed_at":"2018-08-03T00:21:55Z","git_url":"git://github.com/hp-mobile/bs-js-fetch.git","ssh_url":"git@github.com:hp-mobile/bs-js-fetch.git","clone_url":"https://github.com/hp-mobile/bs-js-fetch.git","svn_url":"https://github.com/hp-mobile/bs-js-fetch","homepage":null,"size":36,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"hp-mobile:master","ref":"master","sha":"f784c8a2ddeb144ccf8754bf570fd50f9e17ddba","user":{"login":"hp-mobile","id":2566172,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NjYxNzI=","avatar_url":"https://avatars3.githubusercontent.com/u/2566172?v=4","gravatar_id":"","url":"https://api.github.com/users/hp-mobile","html_url":"https://github.com/hp-mobile","followers_url":"https://api.github.com/users/hp-mobile/followers","following_url":"https://api.github.com/users/hp-mobile/following{/other_user}","gists_url":"https://api.github.com/users/hp-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/hp-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hp-mobile/subscriptions","organizations_url":"https://api.github.com/users/hp-mobile/orgs","repos_url":"https://api.github.com/users/hp-mobile/repos","events_url":"https://api.github.com/users/hp-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/hp-mobile/received_events","type":"Organization","site_admin":false},"repo":{"id":142896947,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI4OTY5NDc=","name":"bs-js-fetch","full_name":"hp-mobile/bs-js-fetch","owner":{"login":"hp-mobile","id":2566172,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NjYxNzI=","avatar_url":"https://avatars3.githubusercontent.com/u/2566172?v=4","gravatar_id":"","url":"https://api.github.com/users/hp-mobile","html_url":"https://github.com/hp-mobile","followers_url":"https://api.github.com/users/hp-mobile/followers","following_url":"https://api.github.com/users/hp-mobile/following{/other_user}","gists_url":"https://api.github.com/users/hp-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/hp-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hp-mobile/subscriptions","organizations_url":"https://api.github.com/users/hp-mobile/orgs","repos_url":"https://api.github.com/users/hp-mobile/repos","events_url":"https://api.github.com/users/hp-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/hp-mobile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hp-mobile/bs-js-fetch","description":"BuckleScript bindings for HighPoint Fetch Library","fork":false,"url":"https://api.github.com/repos/hp-mobile/bs-js-fetch","forks_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/forks","keys_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/teams","hooks_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/hooks","issue_events_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/issues/events{/number}","events_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/events","assignees_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/assignees{/user}","branches_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/branches{/branch}","tags_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/tags","blobs_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/git/refs{/sha}","trees_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/statuses/{sha}","languages_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/languages","stargazers_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/stargazers","contributors_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/contributors","subscribers_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/subscribers","subscription_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/subscription","commits_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/commits{/sha}","git_commits_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/git/commits{/sha}","comments_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/comments{/number}","issue_comment_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/issues/comments{/number}","contents_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/contents/{+path}","compare_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/merges","archive_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/downloads","issues_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/issues{/number}","pulls_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/pulls{/number}","milestones_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/milestones{/number}","notifications_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/labels{/name}","releases_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/releases{/id}","deployments_url":"https://api.github.com/repos/hp-mobile/bs-js-fetch/deployments","created_at":"2018-07-30T15:52:10Z","updated_at":"2018-08-02T19:10:44Z","pushed_at":"2018-08-03T00:21:55Z","git_url":"git://github.com/hp-mobile/bs-js-fetch.git","ssh_url":"git@github.com:hp-mobile/bs-js-fetch.git","clone_url":"https://github.com/hp-mobile/bs-js-fetch.git","svn_url":"https://github.com/hp-mobile/bs-js-fetch","homepage":null,"size":36,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hp-mobile/bs-js-fetch/pulls/4"},"html":{"href":"https://github.com/hp-mobile/bs-js-fetch/pull/4"},"issue":{"href":"https://api.github.com/repos/hp-mobile/bs-js-fetch/issues/4"},"comments":{"href":"https://api.github.com/repos/hp-mobile/bs-js-fetch/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/hp-mobile/bs-js-fetch/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/hp-mobile/bs-js-fetch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hp-mobile/bs-js-fetch/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/hp-mobile/bs-js-fetch/statuses/9f84ca643268953ea7c33ee185a235d18a27debc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mciparelli"}}