{"action":"closed","number":480,"pull_request":{"url":"https://api.github.com/repos/ucsdlib/damspas/pulls/480","id":200750305,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNzUwMzA1","html_url":"https://github.com/ucsdlib/damspas/pull/480","diff_url":"https://github.com/ucsdlib/damspas/pull/480.diff","patch_url":"https://github.com/ucsdlib/damspas/pull/480.patch","issue_url":"https://api.github.com/repos/ucsdlib/damspas/issues/480","number":480,"state":"closed","locked":false,"title":"Fix display behavior of metadata-only collections","user":{"login":"VivianChu","id":1864660,"node_id":"MDQ6VXNlcjE4NjQ2NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/1864660?v=4","gravatar_id":"","url":"https://api.github.com/users/VivianChu","html_url":"https://github.com/VivianChu","followers_url":"https://api.github.com/users/VivianChu/followers","following_url":"https://api.github.com/users/VivianChu/following{/other_user}","gists_url":"https://api.github.com/users/VivianChu/gists{/gist_id}","starred_url":"https://api.github.com/users/VivianChu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VivianChu/subscriptions","organizations_url":"https://api.github.com/users/VivianChu/orgs","repos_url":"https://api.github.com/users/VivianChu/repos","events_url":"https://api.github.com/users/VivianChu/events{/privacy}","received_events_url":"https://api.github.com/users/VivianChu/received_events","type":"User","site_admin":false},"body":"Fixes #466 \r\n\r\n#### Local Checklist\r\n- [x] Tests written and passing locally?\r\n- [x] Code style checked?\r\n- [x] QA-ed locally?\r\n- [x] Rebased with `master` branch?\r\n- [ ] Configuration updated (if needed)?\r\n- [ ] Documentation updated (if needed)?\r\n\r\n#### What does this PR do?\r\nFix display behavior for both simple and complex metadata-only objects. \r\nAlso fix the search results generic icon for the metadata-only objects in public collections.\r\n\r\n##### Why are we doing this? Any context of related work?\r\nCurrently on staging, these collections and objects are not behaving as expected. If I am on campus, I am seeing metadata-only behavior.\r\n\r\nReferences #466 \r\n\r\n@ucsdlib/developers - please review\r\n","created_at":"2018-07-11T16:00:28Z","updated_at":"2018-07-13T22:10:06Z","closed_at":"2018-07-13T22:10:05Z","merged_at":"2018-07-13T22:10:05Z","merge_commit_sha":"795d9026d2c5ab2473d94c4c2a796ff0d3c48144","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ucsdlib/damspas/pulls/480/commits","review_comments_url":"https://api.github.com/repos/ucsdlib/damspas/pulls/480/comments","review_comment_url":"https://api.github.com/repos/ucsdlib/damspas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ucsdlib/damspas/issues/480/comments","statuses_url":"https://api.github.com/repos/ucsdlib/damspas/statuses/0eb6ed2eb6baaae5e454eaf3dcba2d752c98bc2e","head":{"label":"ucsdlib:feature/metadata-only","ref":"feature/metadata-only","sha":"0eb6ed2eb6baaae5e454eaf3dcba2d752c98bc2e","user":{"login":"ucsdlib","id":2387725,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzODc3MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/2387725?v=4","gravatar_id":"","url":"https://api.github.com/users/ucsdlib","html_url":"https://github.com/ucsdlib","followers_url":"https://api.github.com/users/ucsdlib/followers","following_url":"https://api.github.com/users/ucsdlib/following{/other_user}","gists_url":"https://api.github.com/users/ucsdlib/gists{/gist_id}","starred_url":"https://api.github.com/users/ucsdlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ucsdlib/subscriptions","organizations_url":"https://api.github.com/users/ucsdlib/orgs","repos_url":"https://api.github.com/users/ucsdlib/repos","events_url":"https://api.github.com/users/ucsdlib/events{/privacy}","received_events_url":"https://api.github.com/users/ucsdlib/received_events","type":"Organization","site_admin":false},"repo":{"id":17287926,"node_id":"MDEwOlJlcG9zaXRvcnkxNzI4NzkyNg==","name":"damspas","full_name":"ucsdlib/damspas","owner":{"login":"ucsdlib","id":2387725,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzODc3MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/2387725?v=4","gravatar_id":"","url":"https://api.github.com/users/ucsdlib","html_url":"https://github.com/ucsdlib","followers_url":"https://api.github.com/users/ucsdlib/followers","following_url":"https://api.github.com/users/ucsdlib/following{/other_user}","gists_url":"https://api.github.com/users/ucsdlib/gists{/gist_id}","starred_url":"https://api.github.com/users/ucsdlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ucsdlib/subscriptions","organizations_url":"https://api.github.com/users/ucsdlib/orgs","repos_url":"https://api.github.com/users/ucsdlib/repos","events_url":"https://api.github.com/users/ucsdlib/events{/privacy}","received_events_url":"https://api.github.com/users/ucsdlib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ucsdlib/damspas","description":"UC San Diego DAMS Hydra Head","fork":false,"url":"https://api.github.com/repos/ucsdlib/damspas","forks_url":"https://api.github.com/repos/ucsdlib/damspas/forks","keys_url":"https://api.github.com/repos/ucsdlib/damspas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ucsdlib/damspas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ucsdlib/damspas/teams","hooks_url":"https://api.github.com/repos/ucsdlib/damspas/hooks","issue_events_url":"https://api.github.com/repos/ucsdlib/damspas/issues/events{/number}","events_url":"https://api.github.com/repos/ucsdlib/damspas/events","assignees_url":"https://api.github.com/repos/ucsdlib/damspas/assignees{/user}","branches_url":"https://api.github.com/repos/ucsdlib/damspas/branches{/branch}","tags_url":"https://api.github.com/repos/ucsdlib/damspas/tags","blobs_url":"https://api.github.com/repos/ucsdlib/damspas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ucsdlib/damspas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ucsdlib/damspas/git/refs{/sha}","trees_url":"https://api.github.com/repos/ucsdlib/damspas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ucsdlib/damspas/statuses/{sha}","languages_url":"https://api.github.com/repos/ucsdlib/damspas/languages","stargazers_url":"https://api.github.com/repos/ucsdlib/damspas/stargazers","contributors_url":"https://api.github.com/repos/ucsdlib/damspas/contributors","subscribers_url":"https://api.github.com/repos/ucsdlib/damspas/subscribers","subscription_url":"https://api.github.com/repos/ucsdlib/damspas/subscription","commits_url":"https://api.github.com/repos/ucsdlib/damspas/commits{/sha}","git_commits_url":"https://api.github.com/repos/ucsdlib/damspas/git/commits{/sha}","comments_url":"https://api.github.com/repos/ucsdlib/damspas/comments{/number}","issue_comment_url":"https://api.github.com/repos/ucsdlib/damspas/issues/comments{/number}","contents_url":"https://api.github.com/repos/ucsdlib/damspas/contents/{+path}","compare_url":"https://api.github.com/repos/ucsdlib/damspas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ucsdlib/damspas/merges","archive_url":"https://api.github.com/repos/ucsdlib/damspas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ucsdlib/damspas/downloads","issues_url":"https://api.github.com/repos/ucsdlib/damspas/issues{/number}","pulls_url":"https://api.github.com/repos/ucsdlib/damspas/pulls{/number}","milestones_url":"https://api.github.com/repos/ucsdlib/damspas/milestones{/number}","notifications_url":"https://api.github.com/repos/ucsdlib/damspas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ucsdlib/damspas/labels{/name}","releases_url":"https://api.github.com/repos/ucsdlib/damspas/releases{/id}","deployments_url":"https://api.github.com/repos/ucsdlib/damspas/deployments","created_at":"2014-02-28T14:07:19Z","updated_at":"2018-07-10T18:16:05Z","pushed_at":"2018-07-13T22:10:05Z","git_url":"git://github.com/ucsdlib/damspas.git","ssh_url":"git@github.com:ucsdlib/damspas.git","clone_url":"https://github.com/ucsdlib/damspas.git","svn_url":"https://github.com/ucsdlib/damspas","homepage":null,"size":36308,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":44,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4,"open_issues":44,"watchers":5,"default_branch":"develop"}},"base":{"label":"ucsdlib:develop","ref":"develop","sha":"d1c5b193863ce2364669568e89c0e06f0537c6b3","user":{"login":"ucsdlib","id":2387725,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzODc3MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/2387725?v=4","gravatar_id":"","url":"https://api.github.com/users/ucsdlib","html_url":"https://github.com/ucsdlib","followers_url":"https://api.github.com/users/ucsdlib/followers","following_url":"https://api.github.com/users/ucsdlib/following{/other_user}","gists_url":"https://api.github.com/users/ucsdlib/gists{/gist_id}","starred_url":"https://api.github.com/users/ucsdlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ucsdlib/subscriptions","organizations_url":"https://api.github.com/users/ucsdlib/orgs","repos_url":"https://api.github.com/users/ucsdlib/repos","events_url":"https://api.github.com/users/ucsdlib/events{/privacy}","received_events_url":"https://api.github.com/users/ucsdlib/received_events","type":"Organization","site_admin":false},"repo":{"id":17287926,"node_id":"MDEwOlJlcG9zaXRvcnkxNzI4NzkyNg==","name":"damspas","full_name":"ucsdlib/damspas","owner":{"login":"ucsdlib","id":2387725,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzODc3MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/2387725?v=4","gravatar_id":"","url":"https://api.github.com/users/ucsdlib","html_url":"https://github.com/ucsdlib","followers_url":"https://api.github.com/users/ucsdlib/followers","following_url":"https://api.github.com/users/ucsdlib/following{/other_user}","gists_url":"https://api.github.com/users/ucsdlib/gists{/gist_id}","starred_url":"https://api.github.com/users/ucsdlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ucsdlib/subscriptions","organizations_url":"https://api.github.com/users/ucsdlib/orgs","repos_url":"https://api.github.com/users/ucsdlib/repos","events_url":"https://api.github.com/users/ucsdlib/events{/privacy}","received_events_url":"https://api.github.com/users/ucsdlib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ucsdlib/damspas","description":"UC San Diego DAMS Hydra Head","fork":false,"url":"https://api.github.com/repos/ucsdlib/damspas","forks_url":"https://api.github.com/repos/ucsdlib/damspas/forks","keys_url":"https://api.github.com/repos/ucsdlib/damspas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ucsdlib/damspas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ucsdlib/damspas/teams","hooks_url":"https://api.github.com/repos/ucsdlib/damspas/hooks","issue_events_url":"https://api.github.com/repos/ucsdlib/damspas/issues/events{/number}","events_url":"https://api.github.com/repos/ucsdlib/damspas/events","assignees_url":"https://api.github.com/repos/ucsdlib/damspas/assignees{/user}","branches_url":"https://api.github.com/repos/ucsdlib/damspas/branches{/branch}","tags_url":"https://api.github.com/repos/ucsdlib/damspas/tags","blobs_url":"https://api.github.com/repos/ucsdlib/damspas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ucsdlib/damspas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ucsdlib/damspas/git/refs{/sha}","trees_url":"https://api.github.com/repos/ucsdlib/damspas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ucsdlib/damspas/statuses/{sha}","languages_url":"https://api.github.com/repos/ucsdlib/damspas/languages","stargazers_url":"https://api.github.com/repos/ucsdlib/damspas/stargazers","contributors_url":"https://api.github.com/repos/ucsdlib/damspas/contributors","subscribers_url":"https://api.github.com/repos/ucsdlib/damspas/subscribers","subscription_url":"https://api.github.com/repos/ucsdlib/damspas/subscription","commits_url":"https://api.github.com/repos/ucsdlib/damspas/commits{/sha}","git_commits_url":"https://api.github.com/repos/ucsdlib/damspas/git/commits{/sha}","comments_url":"https://api.github.com/repos/ucsdlib/damspas/comments{/number}","issue_comment_url":"https://api.github.com/repos/ucsdlib/damspas/issues/comments{/number}","contents_url":"https://api.github.com/repos/ucsdlib/damspas/contents/{+path}","compare_url":"https://api.github.com/repos/ucsdlib/damspas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ucsdlib/damspas/merges","archive_url":"https://api.github.com/repos/ucsdlib/damspas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ucsdlib/damspas/downloads","issues_url":"https://api.github.com/repos/ucsdlib/damspas/issues{/number}","pulls_url":"https://api.github.com/repos/ucsdlib/damspas/pulls{/number}","milestones_url":"https://api.github.com/repos/ucsdlib/damspas/milestones{/number}","notifications_url":"https://api.github.com/repos/ucsdlib/damspas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ucsdlib/damspas/labels{/name}","releases_url":"https://api.github.com/repos/ucsdlib/damspas/releases{/id}","deployments_url":"https://api.github.com/repos/ucsdlib/damspas/deployments","created_at":"2014-02-28T14:07:19Z","updated_at":"2018-07-10T18:16:05Z","pushed_at":"2018-07-13T22:10:05Z","git_url":"git://github.com/ucsdlib/damspas.git","ssh_url":"git@github.com:ucsdlib/damspas.git","clone_url":"https://github.com/ucsdlib/damspas.git","svn_url":"https://github.com/ucsdlib/damspas","homepage":null,"size":36308,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":44,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4,"open_issues":44,"watchers":5,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ucsdlib/damspas/pulls/480"},"html":{"href":"https://github.com/ucsdlib/damspas/pull/480"},"issue":{"href":"https://api.github.com/repos/ucsdlib/damspas/issues/480"},"comments":{"href":"https://api.github.com/repos/ucsdlib/damspas/issues/480/comments"},"review_comments":{"href":"https://api.github.com/repos/ucsdlib/damspas/pulls/480/comments"},"review_comment":{"href":"https://api.github.com/repos/ucsdlib/damspas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ucsdlib/damspas/pulls/480/commits"},"statuses":{"href":"https://api.github.com/repos/ucsdlib/damspas/statuses/0eb6ed2eb6baaae5e454eaf3dcba2d752c98bc2e"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"hweng","id":2432753,"node_id":"MDQ6VXNlcjI0MzI3NTM=","avatar_url":"https://avatars1.githubusercontent.com/u/2432753?v=4","gravatar_id":"","url":"https://api.github.com/users/hweng","html_url":"https://github.com/hweng","followers_url":"https://api.github.com/users/hweng/followers","following_url":"https://api.github.com/users/hweng/following{/other_user}","gists_url":"https://api.github.com/users/hweng/gists{/gist_id}","starred_url":"https://api.github.com/users/hweng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hweng/subscriptions","organizations_url":"https://api.github.com/users/hweng/orgs","repos_url":"https://api.github.com/users/hweng/repos","events_url":"https://api.github.com/users/hweng/events{/privacy}","received_events_url":"https://api.github.com/users/hweng/received_events","type":"User","site_admin":false},"comments":10,"review_comments":19,"maintainer_can_modify":false,"commits":5,"additions":299,"deletions":28,"changed_files":9}}
{"actor":{"display_login":"hweng"}}