{"action":"created","issue":{"url":"https://api.github.com/repos/rs/SDWebImage/issues/2412","repository_url":"https://api.github.com/repos/rs/SDWebImage","labels_url":"https://api.github.com/repos/rs/SDWebImage/issues/2412/labels{/name}","comments_url":"https://api.github.com/repos/rs/SDWebImage/issues/2412/comments","events_url":"https://api.github.com/repos/rs/SDWebImage/issues/2412/events","html_url":"https://github.com/rs/SDWebImage/pull/2412","id":346498700,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MzQ2NDU4","number":2412,"title":"Fix rename of default disk cache directory","user":{"login":"zhongwuzw","id":5061845,"node_id":"MDQ6VXNlcjUwNjE4NDU=","avatar_url":"https://avatars0.githubusercontent.com/u/5061845?v=4","gravatar_id":"","url":"https://api.github.com/users/zhongwuzw","html_url":"https://github.com/zhongwuzw","followers_url":"https://api.github.com/users/zhongwuzw/followers","following_url":"https://api.github.com/users/zhongwuzw/following{/other_user}","gists_url":"https://api.github.com/users/zhongwuzw/gists{/gist_id}","starred_url":"https://api.github.com/users/zhongwuzw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhongwuzw/subscriptions","organizations_url":"https://api.github.com/users/zhongwuzw/orgs","repos_url":"https://api.github.com/users/zhongwuzw/repos","events_url":"https://api.github.com/users/zhongwuzw/events{/privacy}","received_events_url":"https://api.github.com/users/zhongwuzw/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-01T08:28:29Z","updated_at":"2018-08-01T08:49:53Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/rs/SDWebImage/pulls/2412","html_url":"https://github.com/rs/SDWebImage/pull/2412","diff_url":"https://github.com/rs/SDWebImage/pull/2412.diff","patch_url":"https://github.com/rs/SDWebImage/pull/2412.patch"},"body":"### New Pull Request Checklist\r\n\r\n* [x] I have read and understood the [CONTRIBUTING guide](https://github.com/rs/SDWebImage/blob/master/.github/CONTRIBUTING.md)\r\n* [x] I have read the [Documentation](http://cocoadocs.org/docsets/SDWebImage/)\r\n* [x] I have searched for a similar pull request in the [project](https://github.com/rs/SDWebImage/pulls) and found none\r\n\r\n* [ ] I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)\r\n* [ ] I have added the required tests to prove the fix/feature I am adding\r\n* [ ] I have updated the documentation (if necessary)\r\n* [ ] I have run the tests and they pass\r\n* [ ] I have run the lint and it passes (`pod lib lint`)\r\n\r\nThis merge request fixes / reffers to the following issues: ...\r\n\r\n### Pull Request Description\r\n\r\n1. Maybe from `5.x`? We changed the default disk cache name of directory, we can't just simply do the rename operation, because the older version's directory is still exist (ps. if user upgrade from older to `5.x`), and may contains many images, if we do not handle these images, they would always exists, cannot access, delete or anything.\r\n2. Remove the compiler warnings of `options`.\r\n"},"comment":{"url":"https://api.github.com/repos/rs/SDWebImage/issues/comments/409500998","html_url":"https://github.com/rs/SDWebImage/pull/2412#issuecomment-409500998","issue_url":"https://api.github.com/repos/rs/SDWebImage/issues/2412","id":409500998,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTUwMDk5OA==","user":{"login":"dreampiggy","id":6919743,"node_id":"MDQ6VXNlcjY5MTk3NDM=","avatar_url":"https://avatars2.githubusercontent.com/u/6919743?v=4","gravatar_id":"","url":"https://api.github.com/users/dreampiggy","html_url":"https://github.com/dreampiggy","followers_url":"https://api.github.com/users/dreampiggy/followers","following_url":"https://api.github.com/users/dreampiggy/following{/other_user}","gists_url":"https://api.github.com/users/dreampiggy/gists{/gist_id}","starred_url":"https://api.github.com/users/dreampiggy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dreampiggy/subscriptions","organizations_url":"https://api.github.com/users/dreampiggy/orgs","repos_url":"https://api.github.com/users/dreampiggy/repos","events_url":"https://api.github.com/users/dreampiggy/events{/privacy}","received_events_url":"https://api.github.com/users/dreampiggy/received_events","type":"User","site_admin":false},"created_at":"2018-08-01T08:49:53Z","updated_at":"2018-08-01T08:49:53Z","author_association":"COLLABORATOR","body":"@zhongwuzw You can still rename the default path as you want. Just keep the cache folder without any issue.\r\n\r\n```\r\nSDImageCacheConfig.defaultCacheConfig.namespacePrefix = @\"com.hackemist.SDWebImageCache.default\";\r\n```\r\n\r\nSo I don't think we need to do anything like movement, each time you call method in `SDImageCache`"}}
{"actor":{"display_login":"dreampiggy"}}