{"action":"created","issue":{"url":"https://api.github.com/repos/simplesteph/kafka-connect-github-source/issues/10","repository_url":"https://api.github.com/repos/simplesteph/kafka-connect-github-source","labels_url":"https://api.github.com/repos/simplesteph/kafka-connect-github-source/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/simplesteph/kafka-connect-github-source/issues/10/comments","events_url":"https://api.github.com/repos/simplesteph/kafka-connect-github-source/issues/10/events","html_url":"https://github.com/simplesteph/kafka-connect-github-source/pull/10","id":310268583,"number":10,"title":"Changed configuration to support multiple repositories and topic","user":{"login":"giampaolotrapasso","id":7675964,"avatar_url":"https://avatars0.githubusercontent.com/u/7675964?v=4","gravatar_id":"","url":"https://api.github.com/users/giampaolotrapasso","html_url":"https://github.com/giampaolotrapasso","followers_url":"https://api.github.com/users/giampaolotrapasso/followers","following_url":"https://api.github.com/users/giampaolotrapasso/following{/other_user}","gists_url":"https://api.github.com/users/giampaolotrapasso/gists{/gist_id}","starred_url":"https://api.github.com/users/giampaolotrapasso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giampaolotrapasso/subscriptions","organizations_url":"https://api.github.com/users/giampaolotrapasso/orgs","repos_url":"https://api.github.com/users/giampaolotrapasso/repos","events_url":"https://api.github.com/users/giampaolotrapasso/events{/privacy}","received_events_url":"https://api.github.com/users/giampaolotrapasso/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-31T20:12:08Z","updated_at":"2018-05-13T10:37:51Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/simplesteph/kafka-connect-github-source/pulls/10","html_url":"https://github.com/simplesteph/kafka-connect-github-source/pull/10","diff_url":"https://github.com/simplesteph/kafka-connect-github-source/pull/10.diff","patch_url":"https://github.com/simplesteph/kafka-connect-github-source/pull/10.patch"},"body":"Changed configuration to support multiple repositories and topic (issue #2).\r\nI did not create a single client. First idea was to create a static singleton, but not sure how it would work on a distributed connector. I need to check better how connector works on a distributed environment.\r\n\r\nIn case, it can be done one a different issue.\r\nLet me know what do you think."},"comment":{"url":"https://api.github.com/repos/simplesteph/kafka-connect-github-source/issues/comments/388617227","html_url":"https://github.com/simplesteph/kafka-connect-github-source/pull/10#issuecomment-388617227","issue_url":"https://api.github.com/repos/simplesteph/kafka-connect-github-source/issues/10","id":388617227,"user":{"login":"simplesteph","id":20851561,"avatar_url":"https://avatars0.githubusercontent.com/u/20851561?v=4","gravatar_id":"","url":"https://api.github.com/users/simplesteph","html_url":"https://github.com/simplesteph","followers_url":"https://api.github.com/users/simplesteph/followers","following_url":"https://api.github.com/users/simplesteph/following{/other_user}","gists_url":"https://api.github.com/users/simplesteph/gists{/gist_id}","starred_url":"https://api.github.com/users/simplesteph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simplesteph/subscriptions","organizations_url":"https://api.github.com/users/simplesteph/orgs","repos_url":"https://api.github.com/users/simplesteph/repos","events_url":"https://api.github.com/users/simplesteph/events{/privacy}","received_events_url":"https://api.github.com/users/simplesteph/received_events","type":"User","site_admin":false},"created_at":"2018-05-13T10:37:51Z","updated_at":"2018-05-13T10:37:51Z","author_association":"OWNER","body":"1. backwards compatibility: new configs should precede over old config (if both are supplied), we deprecate the old config, but we keep both for now\r\n\r\n2. I looked back at my comment and it may not make sense. I like your approach in some ways. I think there are two options. \r\na. ignore the maxTasks parameters. I sort of like this, if we outline it in the documentation. Simplifies user config too\r\nb. do your approach, ignoring some repo (may lead to unexpected behaviour)\r\nc. do what JdbcConnector does: https://github.com/confluentinc/kafka-connect-jdbc/blob/master/src/main/java/io/confluent/connect/jdbc/JdbcSourceConnector.java#L151 \r\nand each task can pull from multiple repos (round robin as you said, or multiple futures and awaiting on them).\r\n\r\nTo be honest I'm leaning towards `2.a.`\r\nWhat do you think?\r\n"}}
{"actor":{"display_login":"simplesteph"}}