{"action":"created","comment":{"url":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/comments/211376434","pull_request_review_id":147783468,"id":211376434,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTM3NjQzNA==","diff_hunk":"@@ -1,4 +1,4 @@\n-package importer\n+package impoter","path":"pkg/impoter/importer_suite_test.go","position":2,"original_position":2,"commit_id":"480ce59ae2d2ce0ae9c1c5e97d102ba8b07fe566","original_commit_id":"480ce59ae2d2ce0ae9c1c5e97d102ba8b07fe566","user":{"login":"copejon","id":6430994,"node_id":"MDQ6VXNlcjY0MzA5OTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6430994?v=4","gravatar_id":"","url":"https://api.github.com/users/copejon","html_url":"https://github.com/copejon","followers_url":"https://api.github.com/users/copejon/followers","following_url":"https://api.github.com/users/copejon/following{/other_user}","gists_url":"https://api.github.com/users/copejon/gists{/gist_id}","starred_url":"https://api.github.com/users/copejon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/copejon/subscriptions","organizations_url":"https://api.github.com/users/copejon/orgs","repos_url":"https://api.github.com/users/copejon/repos","events_url":"https://api.github.com/users/copejon/events{/privacy}","received_events_url":"https://api.github.com/users/copejon/received_events","type":"User","site_admin":false},"body":"yes! Thanks, will fix","created_at":"2018-08-20T19:13:23Z","updated_at":"2018-08-20T19:13:23Z","html_url":"https://github.com/kubevirt/containerized-data-importer/pull/348#discussion_r211376434","pull_request_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/348","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/comments/211376434"},"html":{"href":"https://github.com/kubevirt/containerized-data-importer/pull/348#discussion_r211376434"},"pull_request":{"href":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/348"}},"in_reply_to_id":210934945},"pull_request":{"url":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/348","id":208998718,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4OTk4NzE4","html_url":"https://github.com/kubevirt/containerized-data-importer/pull/348","diff_url":"https://github.com/kubevirt/containerized-data-importer/pull/348.diff","patch_url":"https://github.com/kubevirt/containerized-data-importer/pull/348.patch","issue_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/issues/348","number":348,"state":"open","locked":false,"title":"Colocate high level unit tests with their respective packages","user":{"login":"copejon","id":6430994,"node_id":"MDQ6VXNlcjY0MzA5OTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6430994?v=4","gravatar_id":"","url":"https://api.github.com/users/copejon","html_url":"https://github.com/copejon","followers_url":"https://api.github.com/users/copejon/followers","following_url":"https://api.github.com/users/copejon/following{/other_user}","gists_url":"https://api.github.com/users/copejon/gists{/gist_id}","starred_url":"https://api.github.com/users/copejon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/copejon/subscriptions","organizations_url":"https://api.github.com/users/copejon/orgs","repos_url":"https://api.github.com/users/copejon/repos","events_url":"https://api.github.com/users/copejon/events{/privacy}","received_events_url":"https://api.github.com/users/copejon/received_events","type":"User","site_admin":false},"body":"This PR moves all high level unit tests and their utilities from test/functional/... into their respective packages.  \r\n\r\ne.g. `test/functional/importer/*` -> `pkg/importer/`\r\n\r\nMinor code changes are required to correct imports, de-dupe some commons variables, and fix the relative path to the test image.\r\n\r\n```\r\ntest/functional/controller/controller_suite_test.go -> pkg/controller/import_controller_ginkgo_suite_test.go\r\ntest/functional/controller/controller_test.go -> pkg/controller/import_controller_ginkgo_test.go\r\ntest/functional/importer/datastream/datastream_test.go -> pkg/importer/datastream_ginkgo_test.go\r\ntest/functional/importer/datastream/datastream_suite_test.go -> pkg/importer/datastream_suite_test.go\r\ntest/functional/importer/importer_suite_test.go -> pkg/impoter/importer_suite_test.go\r\ntest/functional/importer/importer_test.go -> pkg/impoter/importer_test.go\r\ntest/framework/fileConversion.go -> tests/framework/fileConversion.go\r\ntest/images/cirros-qcow2.img -> tests/images/cirros-qcow2.img\r\ntest/images/tinyCore.iso -> tests/images/tinyCore.iso\r\n```\r\n\r\nTODO\r\n\r\n- [ ]   Adjust build flow to handle mixed (standard and ginkgo) tests colocated in the same dir","created_at":"2018-08-16T22:11:27Z","updated_at":"2018-08-20T19:13:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c741b1f5f60d5ea0991d5227f8987d784931fc6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":894024422,"node_id":"MDU6TGFiZWw4OTQwMjQ0MjI=","url":"https://api.github.com/repos/kubevirt/containerized-data-importer/labels/P1","name":"P1","color":"f99e70","default":false},{"id":907411908,"node_id":"MDU6TGFiZWw5MDc0MTE5MDg=","url":"https://api.github.com/repos/kubevirt/containerized-data-importer/labels/WIP","name":"WIP","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/348/commits","review_comments_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/348/comments","review_comment_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/issues/348/comments","statuses_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/statuses/480ce59ae2d2ce0ae9c1c5e97d102ba8b07fe566","head":{"label":"copejon:colocate-unit-tests","ref":"colocate-unit-tests","sha":"480ce59ae2d2ce0ae9c1c5e97d102ba8b07fe566","user":{"login":"copejon","id":6430994,"node_id":"MDQ6VXNlcjY0MzA5OTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6430994?v=4","gravatar_id":"","url":"https://api.github.com/users/copejon","html_url":"https://github.com/copejon","followers_url":"https://api.github.com/users/copejon/followers","following_url":"https://api.github.com/users/copejon/following{/other_user}","gists_url":"https://api.github.com/users/copejon/gists{/gist_id}","starred_url":"https://api.github.com/users/copejon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/copejon/subscriptions","organizations_url":"https://api.github.com/users/copejon/orgs","repos_url":"https://api.github.com/users/copejon/repos","events_url":"https://api.github.com/users/copejon/events{/privacy}","received_events_url":"https://api.github.com/users/copejon/received_events","type":"User","site_admin":false},"repo":{"id":118969627,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg5Njk2Mjc=","name":"containerized-data-importer","full_name":"copejon/containerized-data-importer","owner":{"login":"copejon","id":6430994,"node_id":"MDQ6VXNlcjY0MzA5OTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6430994?v=4","gravatar_id":"","url":"https://api.github.com/users/copejon","html_url":"https://github.com/copejon","followers_url":"https://api.github.com/users/copejon/followers","following_url":"https://api.github.com/users/copejon/following{/other_user}","gists_url":"https://api.github.com/users/copejon/gists{/gist_id}","starred_url":"https://api.github.com/users/copejon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/copejon/subscriptions","organizations_url":"https://api.github.com/users/copejon/orgs","repos_url":"https://api.github.com/users/copejon/repos","events_url":"https://api.github.com/users/copejon/events{/privacy}","received_events_url":"https://api.github.com/users/copejon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/copejon/containerized-data-importer","description":"Data Import Service for kubernetes, designed with kubevirt in mind.","fork":true,"url":"https://api.github.com/repos/copejon/containerized-data-importer","forks_url":"https://api.github.com/repos/copejon/containerized-data-importer/forks","keys_url":"https://api.github.com/repos/copejon/containerized-data-importer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/copejon/containerized-data-importer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/copejon/containerized-data-importer/teams","hooks_url":"https://api.github.com/repos/copejon/containerized-data-importer/hooks","issue_events_url":"https://api.github.com/repos/copejon/containerized-data-importer/issues/events{/number}","events_url":"https://api.github.com/repos/copejon/containerized-data-importer/events","assignees_url":"https://api.github.com/repos/copejon/containerized-data-importer/assignees{/user}","branches_url":"https://api.github.com/repos/copejon/containerized-data-importer/branches{/branch}","tags_url":"https://api.github.com/repos/copejon/containerized-data-importer/tags","blobs_url":"https://api.github.com/repos/copejon/containerized-data-importer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/copejon/containerized-data-importer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/copejon/containerized-data-importer/git/refs{/sha}","trees_url":"https://api.github.com/repos/copejon/containerized-data-importer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/copejon/containerized-data-importer/statuses/{sha}","languages_url":"https://api.github.com/repos/copejon/containerized-data-importer/languages","stargazers_url":"https://api.github.com/repos/copejon/containerized-data-importer/stargazers","contributors_url":"https://api.github.com/repos/copejon/containerized-data-importer/contributors","subscribers_url":"https://api.github.com/repos/copejon/containerized-data-importer/subscribers","subscription_url":"https://api.github.com/repos/copejon/containerized-data-importer/subscription","commits_url":"https://api.github.com/repos/copejon/containerized-data-importer/commits{/sha}","git_commits_url":"https://api.github.com/repos/copejon/containerized-data-importer/git/commits{/sha}","comments_url":"https://api.github.com/repos/copejon/containerized-data-importer/comments{/number}","issue_comment_url":"https://api.github.com/repos/copejon/containerized-data-importer/issues/comments{/number}","contents_url":"https://api.github.com/repos/copejon/containerized-data-importer/contents/{+path}","compare_url":"https://api.github.com/repos/copejon/containerized-data-importer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/copejon/containerized-data-importer/merges","archive_url":"https://api.github.com/repos/copejon/containerized-data-importer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/copejon/containerized-data-importer/downloads","issues_url":"https://api.github.com/repos/copejon/containerized-data-importer/issues{/number}","pulls_url":"https://api.github.com/repos/copejon/containerized-data-importer/pulls{/number}","milestones_url":"https://api.github.com/repos/copejon/containerized-data-importer/milestones{/number}","notifications_url":"https://api.github.com/repos/copejon/containerized-data-importer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/copejon/containerized-data-importer/labels{/name}","releases_url":"https://api.github.com/repos/copejon/containerized-data-importer/releases{/id}","deployments_url":"https://api.github.com/repos/copejon/containerized-data-importer/deployments","created_at":"2018-01-25T21:26:19Z","updated_at":"2018-08-20T19:09:30Z","pushed_at":"2018-08-20T19:09:41Z","git_url":"git://github.com/copejon/containerized-data-importer.git","ssh_url":"git@github.com:copejon/containerized-data-importer.git","clone_url":"https://github.com/copejon/containerized-data-importer.git","svn_url":"https://github.com/copejon/containerized-data-importer","homepage":"","size":47362,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubevirt:master","ref":"master","sha":"2a651c8725067b40e5d0de23947450b4279ce2d9","user":{"login":"kubevirt","id":18700703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzAwNzAz","avatar_url":"https://avatars1.githubusercontent.com/u/18700703?v=4","gravatar_id":"","url":"https://api.github.com/users/kubevirt","html_url":"https://github.com/kubevirt","followers_url":"https://api.github.com/users/kubevirt/followers","following_url":"https://api.github.com/users/kubevirt/following{/other_user}","gists_url":"https://api.github.com/users/kubevirt/gists{/gist_id}","starred_url":"https://api.github.com/users/kubevirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubevirt/subscriptions","organizations_url":"https://api.github.com/users/kubevirt/orgs","repos_url":"https://api.github.com/users/kubevirt/repos","events_url":"https://api.github.com/users/kubevirt/events{/privacy}","received_events_url":"https://api.github.com/users/kubevirt/received_events","type":"Organization","site_admin":false},"repo":{"id":117756215,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc3NTYyMTU=","name":"containerized-data-importer","full_name":"kubevirt/containerized-data-importer","owner":{"login":"kubevirt","id":18700703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzAwNzAz","avatar_url":"https://avatars1.githubusercontent.com/u/18700703?v=4","gravatar_id":"","url":"https://api.github.com/users/kubevirt","html_url":"https://github.com/kubevirt","followers_url":"https://api.github.com/users/kubevirt/followers","following_url":"https://api.github.com/users/kubevirt/following{/other_user}","gists_url":"https://api.github.com/users/kubevirt/gists{/gist_id}","starred_url":"https://api.github.com/users/kubevirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubevirt/subscriptions","organizations_url":"https://api.github.com/users/kubevirt/orgs","repos_url":"https://api.github.com/users/kubevirt/repos","events_url":"https://api.github.com/users/kubevirt/events{/privacy}","received_events_url":"https://api.github.com/users/kubevirt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubevirt/containerized-data-importer","description":"Data Import Service for kubernetes, designed with kubevirt in mind.","fork":false,"url":"https://api.github.com/repos/kubevirt/containerized-data-importer","forks_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/forks","keys_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/teams","hooks_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/hooks","issue_events_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/issues/events{/number}","events_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/events","assignees_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/assignees{/user}","branches_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/branches{/branch}","tags_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/tags","blobs_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/statuses/{sha}","languages_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/languages","stargazers_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/stargazers","contributors_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/contributors","subscribers_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/subscribers","subscription_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/subscription","commits_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/contents/{+path}","compare_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/merges","archive_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/downloads","issues_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/issues{/number}","pulls_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls{/number}","milestones_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/milestones{/number}","notifications_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/labels{/name}","releases_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/releases{/id}","deployments_url":"https://api.github.com/repos/kubevirt/containerized-data-importer/deployments","created_at":"2018-01-16T23:35:48Z","updated_at":"2018-08-17T22:07:19Z","pushed_at":"2018-08-20T19:09:43Z","git_url":"git://github.com/kubevirt/containerized-data-importer.git","ssh_url":"git@github.com:kubevirt/containerized-data-importer.git","clone_url":"https://github.com/kubevirt/containerized-data-importer.git","svn_url":"https://github.com/kubevirt/containerized-data-importer","homepage":"","size":47358,"stargazers_count":7,"watchers_count":7,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":35,"license":null,"forks":17,"open_issues":35,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/348"},"html":{"href":"https://github.com/kubevirt/containerized-data-importer/pull/348"},"issue":{"href":"https://api.github.com/repos/kubevirt/containerized-data-importer/issues/348"},"comments":{"href":"https://api.github.com/repos/kubevirt/containerized-data-importer/issues/348/comments"},"review_comments":{"href":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/348/comments"},"review_comment":{"href":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubevirt/containerized-data-importer/pulls/348/commits"},"statuses":{"href":"https://api.github.com/repos/kubevirt/containerized-data-importer/statuses/480ce59ae2d2ce0ae9c1c5e97d102ba8b07fe566"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"copejon"}}