{"action":"created","comment":{"url":"https://api.github.com/repos/systemd/systemd/pulls/comments/203948174","pull_request_review_id":138940714,"id":203948174,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzk0ODE3NA==","diff_hunk":"@@ -1488,7 +1501,11 @@ static int copy_files(Item *i) {\n                 }\n         }\n \n-        return path_set_perms(i, i->path);\n+        fd = openat(dfd, bn, O_NOFOLLOW|O_CLOEXEC|O_PATH);\n+        if (fd < 0)\n+                return log_error_errno(fd, \"Failed to openat(%s): %m\", i->path);","path":"src/tmpfiles/tmpfiles.c","position":null,"original_position":58,"commit_id":"081eb626236689c8711230f0ddcbf90e5cb1dec4","original_commit_id":"8357a98eade6342a9ec0602b6d647df8954acc63","user":{"login":"fbuihuu","id":251384,"node_id":"MDQ6VXNlcjI1MTM4NA==","avatar_url":"https://avatars3.githubusercontent.com/u/251384?v=4","gravatar_id":"","url":"https://api.github.com/users/fbuihuu","html_url":"https://github.com/fbuihuu","followers_url":"https://api.github.com/users/fbuihuu/followers","following_url":"https://api.github.com/users/fbuihuu/following{/other_user}","gists_url":"https://api.github.com/users/fbuihuu/gists{/gist_id}","starred_url":"https://api.github.com/users/fbuihuu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbuihuu/subscriptions","organizations_url":"https://api.github.com/users/fbuihuu/orgs","repos_url":"https://api.github.com/users/fbuihuu/repos","events_url":"https://api.github.com/users/fbuihuu/events{/privacy}","received_events_url":"https://api.github.com/users/fbuihuu/received_events","type":"User","site_admin":false},"body":"yeah...","created_at":"2018-07-20T06:26:44Z","updated_at":"2018-07-20T06:26:44Z","html_url":"https://github.com/systemd/systemd/pull/8822#discussion_r203948174","pull_request_url":"https://api.github.com/repos/systemd/systemd/pulls/8822","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/systemd/systemd/pulls/comments/203948174"},"html":{"href":"https://github.com/systemd/systemd/pull/8822#discussion_r203948174"},"pull_request":{"href":"https://api.github.com/repos/systemd/systemd/pulls/8822"}},"in_reply_to_id":203751032},"pull_request":{"url":"https://api.github.com/repos/systemd/systemd/pulls/8822","id":184246351,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg0MjQ2MzUx","html_url":"https://github.com/systemd/systemd/pull/8822","diff_url":"https://github.com/systemd/systemd/pull/8822.diff","patch_url":"https://github.com/systemd/systemd/pull/8822.patch","issue_url":"https://api.github.com/repos/systemd/systemd/issues/8822","number":8822,"state":"open","locked":false,"title":"Make tmpfiles safe","user":{"login":"fbuihuu","id":251384,"node_id":"MDQ6VXNlcjI1MTM4NA==","avatar_url":"https://avatars3.githubusercontent.com/u/251384?v=4","gravatar_id":"","url":"https://api.github.com/users/fbuihuu","html_url":"https://github.com/fbuihuu","followers_url":"https://api.github.com/users/fbuihuu/followers","following_url":"https://api.github.com/users/fbuihuu/following{/other_user}","gists_url":"https://api.github.com/users/fbuihuu/gists{/gist_id}","starred_url":"https://api.github.com/users/fbuihuu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbuihuu/subscriptions","organizations_url":"https://api.github.com/users/fbuihuu/orgs","repos_url":"https://api.github.com/users/fbuihuu/repos","events_url":"https://api.github.com/users/fbuihuu/events{/privacy}","received_events_url":"https://api.github.com/users/fbuihuu/received_events","type":"User","site_admin":false},"body":"It's an RFC as a starting point to fix https://github.com/systemd/systemd/issues/7986 completely.\r\n\r\nCurrently this makes 'f' completely safe only. If this appears to be an acceptable fix, I'll fix the rest of the operations.","created_at":"2018-04-26T07:15:58Z","updated_at":"2018-07-20T06:26:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"910588f0e33d2643f4386a6a73bd7e56b8051731","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":223160378,"node_id":"MDU6TGFiZWwyMjMxNjAzNzg=","url":"https://api.github.com/repos/systemd/systemd/labels/tmpfiles","name":"tmpfiles","color":"bfd4f2","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/systemd/systemd/pulls/8822/commits","review_comments_url":"https://api.github.com/repos/systemd/systemd/pulls/8822/comments","review_comment_url":"https://api.github.com/repos/systemd/systemd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/systemd/systemd/issues/8822/comments","statuses_url":"https://api.github.com/repos/systemd/systemd/statuses/081eb626236689c8711230f0ddcbf90e5cb1dec4","head":{"label":"fbuihuu:rfc-tmpfiles-safe-upstream","ref":"rfc-tmpfiles-safe-upstream","sha":"081eb626236689c8711230f0ddcbf90e5cb1dec4","user":{"login":"fbuihuu","id":251384,"node_id":"MDQ6VXNlcjI1MTM4NA==","avatar_url":"https://avatars3.githubusercontent.com/u/251384?v=4","gravatar_id":"","url":"https://api.github.com/users/fbuihuu","html_url":"https://github.com/fbuihuu","followers_url":"https://api.github.com/users/fbuihuu/followers","following_url":"https://api.github.com/users/fbuihuu/following{/other_user}","gists_url":"https://api.github.com/users/fbuihuu/gists{/gist_id}","starred_url":"https://api.github.com/users/fbuihuu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbuihuu/subscriptions","organizations_url":"https://api.github.com/users/fbuihuu/orgs","repos_url":"https://api.github.com/users/fbuihuu/repos","events_url":"https://api.github.com/users/fbuihuu/events{/privacy}","received_events_url":"https://api.github.com/users/fbuihuu/received_events","type":"User","site_admin":false},"repo":{"id":43303412,"node_id":"MDEwOlJlcG9zaXRvcnk0MzMwMzQxMg==","name":"systemd","full_name":"fbuihuu/systemd","owner":{"login":"fbuihuu","id":251384,"node_id":"MDQ6VXNlcjI1MTM4NA==","avatar_url":"https://avatars3.githubusercontent.com/u/251384?v=4","gravatar_id":"","url":"https://api.github.com/users/fbuihuu","html_url":"https://github.com/fbuihuu","followers_url":"https://api.github.com/users/fbuihuu/followers","following_url":"https://api.github.com/users/fbuihuu/following{/other_user}","gists_url":"https://api.github.com/users/fbuihuu/gists{/gist_id}","starred_url":"https://api.github.com/users/fbuihuu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbuihuu/subscriptions","organizations_url":"https://api.github.com/users/fbuihuu/orgs","repos_url":"https://api.github.com/users/fbuihuu/repos","events_url":"https://api.github.com/users/fbuihuu/events{/privacy}","received_events_url":"https://api.github.com/users/fbuihuu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fbuihuu/systemd","description":"systemd upstream","fork":true,"url":"https://api.github.com/repos/fbuihuu/systemd","forks_url":"https://api.github.com/repos/fbuihuu/systemd/forks","keys_url":"https://api.github.com/repos/fbuihuu/systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fbuihuu/systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fbuihuu/systemd/teams","hooks_url":"https://api.github.com/repos/fbuihuu/systemd/hooks","issue_events_url":"https://api.github.com/repos/fbuihuu/systemd/issues/events{/number}","events_url":"https://api.github.com/repos/fbuihuu/systemd/events","assignees_url":"https://api.github.com/repos/fbuihuu/systemd/assignees{/user}","branches_url":"https://api.github.com/repos/fbuihuu/systemd/branches{/branch}","tags_url":"https://api.github.com/repos/fbuihuu/systemd/tags","blobs_url":"https://api.github.com/repos/fbuihuu/systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fbuihuu/systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fbuihuu/systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/fbuihuu/systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fbuihuu/systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/fbuihuu/systemd/languages","stargazers_url":"https://api.github.com/repos/fbuihuu/systemd/stargazers","contributors_url":"https://api.github.com/repos/fbuihuu/systemd/contributors","subscribers_url":"https://api.github.com/repos/fbuihuu/systemd/subscribers","subscription_url":"https://api.github.com/repos/fbuihuu/systemd/subscription","commits_url":"https://api.github.com/repos/fbuihuu/systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/fbuihuu/systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/fbuihuu/systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/fbuihuu/systemd/issues/comments{/number}","contents_url":"https://api.github.com/repos/fbuihuu/systemd/contents/{+path}","compare_url":"https://api.github.com/repos/fbuihuu/systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fbuihuu/systemd/merges","archive_url":"https://api.github.com/repos/fbuihuu/systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fbuihuu/systemd/downloads","issues_url":"https://api.github.com/repos/fbuihuu/systemd/issues{/number}","pulls_url":"https://api.github.com/repos/fbuihuu/systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/fbuihuu/systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/fbuihuu/systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fbuihuu/systemd/labels{/name}","releases_url":"https://api.github.com/repos/fbuihuu/systemd/releases{/id}","deployments_url":"https://api.github.com/repos/fbuihuu/systemd/deployments","created_at":"2015-09-28T13:44:04Z","updated_at":"2018-06-28T11:17:01Z","pushed_at":"2018-07-17T08:33:52Z","git_url":"git://github.com/fbuihuu/systemd.git","ssh_url":"git@github.com:fbuihuu/systemd.git","clone_url":"https://github.com/fbuihuu/systemd.git","svn_url":"https://github.com/fbuihuu/systemd","homepage":"http://www.freedesktop.org/wiki/Software/systemd/","size":94439,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"systemd:master","ref":"master","sha":"5b5d82615011b9827466b7cd5756da35627a1608","user":{"login":"systemd","id":1918868,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MTg4Njg=","avatar_url":"https://avatars0.githubusercontent.com/u/1918868?v=4","gravatar_id":"","url":"https://api.github.com/users/systemd","html_url":"https://github.com/systemd","followers_url":"https://api.github.com/users/systemd/followers","following_url":"https://api.github.com/users/systemd/following{/other_user}","gists_url":"https://api.github.com/users/systemd/gists{/gist_id}","starred_url":"https://api.github.com/users/systemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemd/subscriptions","organizations_url":"https://api.github.com/users/systemd/orgs","repos_url":"https://api.github.com/users/systemd/repos","events_url":"https://api.github.com/users/systemd/events{/privacy}","received_events_url":"https://api.github.com/users/systemd/received_events","type":"Organization","site_admin":false},"repo":{"id":32873313,"node_id":"MDEwOlJlcG9zaXRvcnkzMjg3MzMxMw==","name":"systemd","full_name":"systemd/systemd","owner":{"login":"systemd","id":1918868,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MTg4Njg=","avatar_url":"https://avatars0.githubusercontent.com/u/1918868?v=4","gravatar_id":"","url":"https://api.github.com/users/systemd","html_url":"https://github.com/systemd","followers_url":"https://api.github.com/users/systemd/followers","following_url":"https://api.github.com/users/systemd/following{/other_user}","gists_url":"https://api.github.com/users/systemd/gists{/gist_id}","starred_url":"https://api.github.com/users/systemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemd/subscriptions","organizations_url":"https://api.github.com/users/systemd/orgs","repos_url":"https://api.github.com/users/systemd/repos","events_url":"https://api.github.com/users/systemd/events{/privacy}","received_events_url":"https://api.github.com/users/systemd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/systemd/systemd","description":"⚙️ 🐧 systemd System and Service Manager ","fork":false,"url":"https://api.github.com/repos/systemd/systemd","forks_url":"https://api.github.com/repos/systemd/systemd/forks","keys_url":"https://api.github.com/repos/systemd/systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/systemd/systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/systemd/systemd/teams","hooks_url":"https://api.github.com/repos/systemd/systemd/hooks","issue_events_url":"https://api.github.com/repos/systemd/systemd/issues/events{/number}","events_url":"https://api.github.com/repos/systemd/systemd/events","assignees_url":"https://api.github.com/repos/systemd/systemd/assignees{/user}","branches_url":"https://api.github.com/repos/systemd/systemd/branches{/branch}","tags_url":"https://api.github.com/repos/systemd/systemd/tags","blobs_url":"https://api.github.com/repos/systemd/systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/systemd/systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/systemd/systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/systemd/systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/systemd/systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/systemd/systemd/languages","stargazers_url":"https://api.github.com/repos/systemd/systemd/stargazers","contributors_url":"https://api.github.com/repos/systemd/systemd/contributors","subscribers_url":"https://api.github.com/repos/systemd/systemd/subscribers","subscription_url":"https://api.github.com/repos/systemd/systemd/subscription","commits_url":"https://api.github.com/repos/systemd/systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/systemd/systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/systemd/systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/systemd/systemd/issues/comments{/number}","contents_url":"https://api.github.com/repos/systemd/systemd/contents/{+path}","compare_url":"https://api.github.com/repos/systemd/systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/systemd/systemd/merges","archive_url":"https://api.github.com/repos/systemd/systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/systemd/systemd/downloads","issues_url":"https://api.github.com/repos/systemd/systemd/issues{/number}","pulls_url":"https://api.github.com/repos/systemd/systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/systemd/systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/systemd/systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/systemd/systemd/labels{/name}","releases_url":"https://api.github.com/repos/systemd/systemd/releases{/id}","deployments_url":"https://api.github.com/repos/systemd/systemd/deployments","created_at":"2015-03-25T15:27:27Z","updated_at":"2018-07-20T06:26:02Z","pushed_at":"2018-07-20T06:01:37Z","git_url":"git://github.com/systemd/systemd.git","ssh_url":"git@github.com:systemd/systemd.git","clone_url":"https://github.com/systemd/systemd.git","svn_url":"https://github.com/systemd/systemd","homepage":"https://www.freedesktop.org/wiki/Software/systemd/","size":94177,"stargazers_count":3382,"watchers_count":3382,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1296,"mirror_url":null,"archived":false,"open_issues_count":978,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":1296,"open_issues":978,"watchers":3382,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/systemd/systemd/pulls/8822"},"html":{"href":"https://github.com/systemd/systemd/pull/8822"},"issue":{"href":"https://api.github.com/repos/systemd/systemd/issues/8822"},"comments":{"href":"https://api.github.com/repos/systemd/systemd/issues/8822/comments"},"review_comments":{"href":"https://api.github.com/repos/systemd/systemd/pulls/8822/comments"},"review_comment":{"href":"https://api.github.com/repos/systemd/systemd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/systemd/systemd/pulls/8822/commits"},"statuses":{"href":"https://api.github.com/repos/systemd/systemd/statuses/081eb626236689c8711230f0ddcbf90e5cb1dec4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"fbuihuu"}}