{"action":"created","comment":{"url":"https://api.github.com/repos/Khan/KaTeX/pulls/comments/187025168","pull_request_review_id":118719760,"id":187025168,"diff_hunk":"@@ -202,8 +201,9 @@ const htmlBuilder = function(group, options) {\n             }\n \n             if (colDescr.separator === \"|\") {\n-                const separator = stretchy.ruleSpan(\"vertical-separator\", 0.05,\n-                    options);\n+                const separator = buildCommon.makeSpan(\n+                    [\"vertical-separator\"], [], options\n+            );","path":"src/environments/array.js","position":16,"original_position":16,"commit_id":"2ed55e8ea943edeae1f331641fbb33a2a4218616","original_commit_id":"2ed55e8ea943edeae1f331641fbb33a2a4218616","user":{"login":"ylemkimon","id":888148,"avatar_url":"https://avatars1.githubusercontent.com/u/888148?v=4","gravatar_id":"","url":"https://api.github.com/users/ylemkimon","html_url":"https://github.com/ylemkimon","followers_url":"https://api.github.com/users/ylemkimon/followers","following_url":"https://api.github.com/users/ylemkimon/following{/other_user}","gists_url":"https://api.github.com/users/ylemkimon/gists{/gist_id}","starred_url":"https://api.github.com/users/ylemkimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ylemkimon/subscriptions","organizations_url":"https://api.github.com/users/ylemkimon/orgs","repos_url":"https://api.github.com/users/ylemkimon/repos","events_url":"https://api.github.com/users/ylemkimon/events{/privacy}","received_events_url":"https://api.github.com/users/ylemkimon/received_events","type":"User","site_admin":false},"body":"The indentation of this line seems to be wrong.","created_at":"2018-05-09T12:38:25Z","updated_at":"2018-05-09T12:38:25Z","html_url":"https://github.com/Khan/KaTeX/pull/1249#discussion_r187025168","pull_request_url":"https://api.github.com/repos/Khan/KaTeX/pulls/1249","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Khan/KaTeX/pulls/comments/187025168"},"html":{"href":"https://github.com/Khan/KaTeX/pull/1249#discussion_r187025168"},"pull_request":{"href":"https://api.github.com/repos/Khan/KaTeX/pulls/1249"}}},"pull_request":{"url":"https://api.github.com/repos/Khan/KaTeX/pulls/1249","id":178957926,"html_url":"https://github.com/Khan/KaTeX/pull/1249","diff_url":"https://github.com/Khan/KaTeX/pull/1249.diff","patch_url":"https://github.com/Khan/KaTeX/pull/1249.patch","issue_url":"https://api.github.com/repos/Khan/KaTeX/issues/1249","number":1249,"state":"open","locked":false,"title":"Revert frac-lines to borders","user":{"login":"ronkok","id":16403058,"avatar_url":"https://avatars3.githubusercontent.com/u/16403058?v=4","gravatar_id":"","url":"https://api.github.com/users/ronkok","html_url":"https://github.com/ronkok","followers_url":"https://api.github.com/users/ronkok/followers","following_url":"https://api.github.com/users/ronkok/following{/other_user}","gists_url":"https://api.github.com/users/ronkok/gists{/gist_id}","starred_url":"https://api.github.com/users/ronkok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronkok/subscriptions","organizations_url":"https://api.github.com/users/ronkok/orgs","repos_url":"https://api.github.com/users/ronkok/repos","events_url":"https://api.github.com/users/ronkok/events{/privacy}","received_events_url":"https://api.github.com/users/ronkok/received_events","type":"User","site_admin":false},"body":"This PR reverts the rendering of frac-lines from SVG paths back to span borders. This solves the thick grey bar reported by @mbourne in issue #1173.\r\n\r\nThe result is a frac-line similar to KaTeX v0.9.0-alpha1. The frac-lines are span borders and the CSS contains a `min-height: 1px;` rule to keep those borders visible.\r\n\r\nThere is one difference between this PR and v0.9.0-alpha1. The earlier work contained a second CSS rule:\r\n```\r\n@media screen and (-webkit-min-device-pixel-ratio: 2), screen and (min-resolution: 192dpi) {\r\n      .katex .mfrac .fracline {\r\n            min-height:0.5px;\r\n    }\r\n}\r\n```\r\nThat second CSS rule did not help much. Instead, it caused some lines to disappear.  So this PR omits that second CSS rule.\r\n\r\nIn the thread to issue #1173, people tested the rendering from the proposed approach and reported that frac-lines disappeared only at sizes that were already too small to read.","created_at":"2018-04-02T23:27:41Z","updated_at":"2018-05-09T12:38:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"37bfeeaa292e29cc87147f23b62a6415fe1dd990","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kevinbarabash","id":1044413,"avatar_url":"https://avatars3.githubusercontent.com/u/1044413?v=4","gravatar_id":"","url":"https://api.github.com/users/kevinbarabash","html_url":"https://github.com/kevinbarabash","followers_url":"https://api.github.com/users/kevinbarabash/followers","following_url":"https://api.github.com/users/kevinbarabash/following{/other_user}","gists_url":"https://api.github.com/users/kevinbarabash/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinbarabash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinbarabash/subscriptions","organizations_url":"https://api.github.com/users/kevinbarabash/orgs","repos_url":"https://api.github.com/users/kevinbarabash/repos","events_url":"https://api.github.com/users/kevinbarabash/events{/privacy}","received_events_url":"https://api.github.com/users/kevinbarabash/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Khan/KaTeX/pulls/1249/commits","review_comments_url":"https://api.github.com/repos/Khan/KaTeX/pulls/1249/comments","review_comment_url":"https://api.github.com/repos/Khan/KaTeX/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Khan/KaTeX/issues/1249/comments","statuses_url":"https://api.github.com/repos/Khan/KaTeX/statuses/2ed55e8ea943edeae1f331641fbb33a2a4218616","head":{"label":"ronkok:fracLineBorder","ref":"fracLineBorder","sha":"2ed55e8ea943edeae1f331641fbb33a2a4218616","user":{"login":"ronkok","id":16403058,"avatar_url":"https://avatars3.githubusercontent.com/u/16403058?v=4","gravatar_id":"","url":"https://api.github.com/users/ronkok","html_url":"https://github.com/ronkok","followers_url":"https://api.github.com/users/ronkok/followers","following_url":"https://api.github.com/users/ronkok/following{/other_user}","gists_url":"https://api.github.com/users/ronkok/gists{/gist_id}","starred_url":"https://api.github.com/users/ronkok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronkok/subscriptions","organizations_url":"https://api.github.com/users/ronkok/orgs","repos_url":"https://api.github.com/users/ronkok/repos","events_url":"https://api.github.com/users/ronkok/events{/privacy}","received_events_url":"https://api.github.com/users/ronkok/received_events","type":"User","site_admin":false},"repo":{"id":120239578,"name":"KaTeX","full_name":"ronkok/KaTeX","owner":{"login":"ronkok","id":16403058,"avatar_url":"https://avatars3.githubusercontent.com/u/16403058?v=4","gravatar_id":"","url":"https://api.github.com/users/ronkok","html_url":"https://github.com/ronkok","followers_url":"https://api.github.com/users/ronkok/followers","following_url":"https://api.github.com/users/ronkok/following{/other_user}","gists_url":"https://api.github.com/users/ronkok/gists{/gist_id}","starred_url":"https://api.github.com/users/ronkok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronkok/subscriptions","organizations_url":"https://api.github.com/users/ronkok/orgs","repos_url":"https://api.github.com/users/ronkok/repos","events_url":"https://api.github.com/users/ronkok/events{/privacy}","received_events_url":"https://api.github.com/users/ronkok/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ronkok/KaTeX","description":"Fast math typesetting for the web.","fork":true,"url":"https://api.github.com/repos/ronkok/KaTeX","forks_url":"https://api.github.com/repos/ronkok/KaTeX/forks","keys_url":"https://api.github.com/repos/ronkok/KaTeX/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ronkok/KaTeX/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ronkok/KaTeX/teams","hooks_url":"https://api.github.com/repos/ronkok/KaTeX/hooks","issue_events_url":"https://api.github.com/repos/ronkok/KaTeX/issues/events{/number}","events_url":"https://api.github.com/repos/ronkok/KaTeX/events","assignees_url":"https://api.github.com/repos/ronkok/KaTeX/assignees{/user}","branches_url":"https://api.github.com/repos/ronkok/KaTeX/branches{/branch}","tags_url":"https://api.github.com/repos/ronkok/KaTeX/tags","blobs_url":"https://api.github.com/repos/ronkok/KaTeX/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ronkok/KaTeX/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ronkok/KaTeX/git/refs{/sha}","trees_url":"https://api.github.com/repos/ronkok/KaTeX/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ronkok/KaTeX/statuses/{sha}","languages_url":"https://api.github.com/repos/ronkok/KaTeX/languages","stargazers_url":"https://api.github.com/repos/ronkok/KaTeX/stargazers","contributors_url":"https://api.github.com/repos/ronkok/KaTeX/contributors","subscribers_url":"https://api.github.com/repos/ronkok/KaTeX/subscribers","subscription_url":"https://api.github.com/repos/ronkok/KaTeX/subscription","commits_url":"https://api.github.com/repos/ronkok/KaTeX/commits{/sha}","git_commits_url":"https://api.github.com/repos/ronkok/KaTeX/git/commits{/sha}","comments_url":"https://api.github.com/repos/ronkok/KaTeX/comments{/number}","issue_comment_url":"https://api.github.com/repos/ronkok/KaTeX/issues/comments{/number}","contents_url":"https://api.github.com/repos/ronkok/KaTeX/contents/{+path}","compare_url":"https://api.github.com/repos/ronkok/KaTeX/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ronkok/KaTeX/merges","archive_url":"https://api.github.com/repos/ronkok/KaTeX/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ronkok/KaTeX/downloads","issues_url":"https://api.github.com/repos/ronkok/KaTeX/issues{/number}","pulls_url":"https://api.github.com/repos/ronkok/KaTeX/pulls{/number}","milestones_url":"https://api.github.com/repos/ronkok/KaTeX/milestones{/number}","notifications_url":"https://api.github.com/repos/ronkok/KaTeX/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ronkok/KaTeX/labels{/name}","releases_url":"https://api.github.com/repos/ronkok/KaTeX/releases{/id}","deployments_url":"https://api.github.com/repos/ronkok/KaTeX/deployments","created_at":"2018-02-05T01:23:40Z","updated_at":"2018-05-08T01:00:30Z","pushed_at":"2018-05-09T12:34:20Z","git_url":"git://github.com/ronkok/KaTeX.git","ssh_url":"git@github.com:ronkok/KaTeX.git","clone_url":"https://github.com/ronkok/KaTeX.git","svn_url":"https://github.com/ronkok/KaTeX","homepage":"https://khan.github.io/KaTeX/","size":24209,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Khan:master","ref":"master","sha":"0a2bd8878d0c7f5c386ef90aaf8434884910d6c5","user":{"login":"Khan","id":15455,"avatar_url":"https://avatars1.githubusercontent.com/u/15455?v=4","gravatar_id":"","url":"https://api.github.com/users/Khan","html_url":"https://github.com/Khan","followers_url":"https://api.github.com/users/Khan/followers","following_url":"https://api.github.com/users/Khan/following{/other_user}","gists_url":"https://api.github.com/users/Khan/gists{/gist_id}","starred_url":"https://api.github.com/users/Khan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Khan/subscriptions","organizations_url":"https://api.github.com/users/Khan/orgs","repos_url":"https://api.github.com/users/Khan/repos","events_url":"https://api.github.com/users/Khan/events{/privacy}","received_events_url":"https://api.github.com/users/Khan/received_events","type":"Organization","site_admin":false},"repo":{"id":11195700,"name":"KaTeX","full_name":"Khan/KaTeX","owner":{"login":"Khan","id":15455,"avatar_url":"https://avatars1.githubusercontent.com/u/15455?v=4","gravatar_id":"","url":"https://api.github.com/users/Khan","html_url":"https://github.com/Khan","followers_url":"https://api.github.com/users/Khan/followers","following_url":"https://api.github.com/users/Khan/following{/other_user}","gists_url":"https://api.github.com/users/Khan/gists{/gist_id}","starred_url":"https://api.github.com/users/Khan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Khan/subscriptions","organizations_url":"https://api.github.com/users/Khan/orgs","repos_url":"https://api.github.com/users/Khan/repos","events_url":"https://api.github.com/users/Khan/events{/privacy}","received_events_url":"https://api.github.com/users/Khan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Khan/KaTeX","description":"Fast math typesetting for the web.","fork":false,"url":"https://api.github.com/repos/Khan/KaTeX","forks_url":"https://api.github.com/repos/Khan/KaTeX/forks","keys_url":"https://api.github.com/repos/Khan/KaTeX/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Khan/KaTeX/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Khan/KaTeX/teams","hooks_url":"https://api.github.com/repos/Khan/KaTeX/hooks","issue_events_url":"https://api.github.com/repos/Khan/KaTeX/issues/events{/number}","events_url":"https://api.github.com/repos/Khan/KaTeX/events","assignees_url":"https://api.github.com/repos/Khan/KaTeX/assignees{/user}","branches_url":"https://api.github.com/repos/Khan/KaTeX/branches{/branch}","tags_url":"https://api.github.com/repos/Khan/KaTeX/tags","blobs_url":"https://api.github.com/repos/Khan/KaTeX/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Khan/KaTeX/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Khan/KaTeX/git/refs{/sha}","trees_url":"https://api.github.com/repos/Khan/KaTeX/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Khan/KaTeX/statuses/{sha}","languages_url":"https://api.github.com/repos/Khan/KaTeX/languages","stargazers_url":"https://api.github.com/repos/Khan/KaTeX/stargazers","contributors_url":"https://api.github.com/repos/Khan/KaTeX/contributors","subscribers_url":"https://api.github.com/repos/Khan/KaTeX/subscribers","subscription_url":"https://api.github.com/repos/Khan/KaTeX/subscription","commits_url":"https://api.github.com/repos/Khan/KaTeX/commits{/sha}","git_commits_url":"https://api.github.com/repos/Khan/KaTeX/git/commits{/sha}","comments_url":"https://api.github.com/repos/Khan/KaTeX/comments{/number}","issue_comment_url":"https://api.github.com/repos/Khan/KaTeX/issues/comments{/number}","contents_url":"https://api.github.com/repos/Khan/KaTeX/contents/{+path}","compare_url":"https://api.github.com/repos/Khan/KaTeX/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Khan/KaTeX/merges","archive_url":"https://api.github.com/repos/Khan/KaTeX/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Khan/KaTeX/downloads","issues_url":"https://api.github.com/repos/Khan/KaTeX/issues{/number}","pulls_url":"https://api.github.com/repos/Khan/KaTeX/pulls{/number}","milestones_url":"https://api.github.com/repos/Khan/KaTeX/milestones{/number}","notifications_url":"https://api.github.com/repos/Khan/KaTeX/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Khan/KaTeX/labels{/name}","releases_url":"https://api.github.com/repos/Khan/KaTeX/releases{/id}","deployments_url":"https://api.github.com/repos/Khan/KaTeX/deployments","created_at":"2013-07-05T09:01:54Z","updated_at":"2018-05-09T11:00:21Z","pushed_at":"2018-05-09T12:34:22Z","git_url":"git://github.com/Khan/KaTeX.git","ssh_url":"git@github.com:Khan/KaTeX.git","clone_url":"https://github.com/Khan/KaTeX.git","svn_url":"https://github.com/Khan/KaTeX","homepage":"https://khan.github.io/KaTeX/","size":26842,"stargazers_count":8225,"watchers_count":8225,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":573,"mirror_url":null,"archived":false,"open_issues_count":209,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":573,"open_issues":209,"watchers":8225,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Khan/KaTeX/pulls/1249"},"html":{"href":"https://github.com/Khan/KaTeX/pull/1249"},"issue":{"href":"https://api.github.com/repos/Khan/KaTeX/issues/1249"},"comments":{"href":"https://api.github.com/repos/Khan/KaTeX/issues/1249/comments"},"review_comments":{"href":"https://api.github.com/repos/Khan/KaTeX/pulls/1249/comments"},"review_comment":{"href":"https://api.github.com/repos/Khan/KaTeX/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Khan/KaTeX/pulls/1249/commits"},"statuses":{"href":"https://api.github.com/repos/Khan/KaTeX/statuses/2ed55e8ea943edeae1f331641fbb33a2a4218616"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"ylemkimon"}}