{"action":"closed","number":299,"pull_request":{"url":"https://api.github.com/repos/PrivateBin/PrivateBin/pulls/299","id":180124796,"html_url":"https://github.com/PrivateBin/PrivateBin/pull/299","diff_url":"https://github.com/PrivateBin/PrivateBin/pull/299.diff","patch_url":"https://github.com/PrivateBin/PrivateBin/pull/299.patch","issue_url":"https://api.github.com/repos/PrivateBin/PrivateBin/issues/299","number":299,"state":"closed","locked":false,"title":"Use Webpack","user":{"login":"otaku","id":696343,"avatar_url":"https://avatars3.githubusercontent.com/u/696343?v=4","gravatar_id":"","url":"https://api.github.com/users/otaku","html_url":"https://github.com/otaku","followers_url":"https://api.github.com/users/otaku/followers","following_url":"https://api.github.com/users/otaku/following{/other_user}","gists_url":"https://api.github.com/users/otaku/gists{/gist_id}","starred_url":"https://api.github.com/users/otaku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otaku/subscriptions","organizations_url":"https://api.github.com/users/otaku/orgs","repos_url":"https://api.github.com/users/otaku/repos","events_url":"https://api.github.com/users/otaku/events{/privacy}","received_events_url":"https://api.github.com/users/otaku/received_events","type":"User","site_admin":false},"body":"Have you considered the use of Webpack or any other build tools?\r\n\r\nThere's a few benefits:\r\n* Decoupling code\r\n* Creating a singular javascript file with all dependencies (faster page load speed)\r\n  * For optional dependencies such as kjua, code-prettify, etc are all lazy-loaded if needed.\r\n* It's actually a lot easier to read separate files instead of a monolith file\r\n* Moving dependencies into package management.\r\n\r\nCon:\r\n* You now need node to modify the javascript\r\n* Lazy loaded javascript files are not validated by SRI, but SRI is also sort of pointless if you're serving the files anyway.  Any proxy could technically modify the HTML page with the SRI and update it themselves.\r\n\r\nFuture Benefits:\r\n* Sourcemaps to provide actual insight into errors.\r\n* Ability to use ES6+ (with babel)\r\n* Easier to write tests and to run tests\r\n* Moving all CSS into a singular file\r\n* Generation of SRI for javascript / css if that's still preferred [ for the html templates ]\r\n  * I'd suggest moving assets file into a separate template file to be included\r\n* All of webpack plugins and modules","created_at":"2018-04-07T20:58:29Z","updated_at":"2018-04-08T21:03:59Z","closed_at":"2018-04-08T21:03:59Z","merged_at":null,"merge_commit_sha":"5e9fad9939d4d68a492286c0c28c8a82b3b7b4a7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PrivateBin/PrivateBin/pulls/299/commits","review_comments_url":"https://api.github.com/repos/PrivateBin/PrivateBin/pulls/299/comments","review_comment_url":"https://api.github.com/repos/PrivateBin/PrivateBin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PrivateBin/PrivateBin/issues/299/comments","statuses_url":"https://api.github.com/repos/PrivateBin/PrivateBin/statuses/db19ba7b725680176d25019c055b4ffb10fcf7ea","head":{"label":"otaku:webpack","ref":"webpack","sha":"db19ba7b725680176d25019c055b4ffb10fcf7ea","user":{"login":"otaku","id":696343,"avatar_url":"https://avatars3.githubusercontent.com/u/696343?v=4","gravatar_id":"","url":"https://api.github.com/users/otaku","html_url":"https://github.com/otaku","followers_url":"https://api.github.com/users/otaku/followers","following_url":"https://api.github.com/users/otaku/following{/other_user}","gists_url":"https://api.github.com/users/otaku/gists{/gist_id}","starred_url":"https://api.github.com/users/otaku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otaku/subscriptions","organizations_url":"https://api.github.com/users/otaku/orgs","repos_url":"https://api.github.com/users/otaku/repos","events_url":"https://api.github.com/users/otaku/events{/privacy}","received_events_url":"https://api.github.com/users/otaku/received_events","type":"User","site_admin":false},"repo":{"id":128481673,"name":"PrivateBin","full_name":"otaku/PrivateBin","owner":{"login":"otaku","id":696343,"avatar_url":"https://avatars3.githubusercontent.com/u/696343?v=4","gravatar_id":"","url":"https://api.github.com/users/otaku","html_url":"https://github.com/otaku","followers_url":"https://api.github.com/users/otaku/followers","following_url":"https://api.github.com/users/otaku/following{/other_user}","gists_url":"https://api.github.com/users/otaku/gists{/gist_id}","starred_url":"https://api.github.com/users/otaku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otaku/subscriptions","organizations_url":"https://api.github.com/users/otaku/orgs","repos_url":"https://api.github.com/users/otaku/repos","events_url":"https://api.github.com/users/otaku/events{/privacy}","received_events_url":"https://api.github.com/users/otaku/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/otaku/PrivateBin","description":"A minimalist, open source online pastebin where the server has zero knowledge of pasted data. Data is encrypted/decrypted in the browser using 256 bits AES.","fork":true,"url":"https://api.github.com/repos/otaku/PrivateBin","forks_url":"https://api.github.com/repos/otaku/PrivateBin/forks","keys_url":"https://api.github.com/repos/otaku/PrivateBin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/otaku/PrivateBin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/otaku/PrivateBin/teams","hooks_url":"https://api.github.com/repos/otaku/PrivateBin/hooks","issue_events_url":"https://api.github.com/repos/otaku/PrivateBin/issues/events{/number}","events_url":"https://api.github.com/repos/otaku/PrivateBin/events","assignees_url":"https://api.github.com/repos/otaku/PrivateBin/assignees{/user}","branches_url":"https://api.github.com/repos/otaku/PrivateBin/branches{/branch}","tags_url":"https://api.github.com/repos/otaku/PrivateBin/tags","blobs_url":"https://api.github.com/repos/otaku/PrivateBin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/otaku/PrivateBin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/otaku/PrivateBin/git/refs{/sha}","trees_url":"https://api.github.com/repos/otaku/PrivateBin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/otaku/PrivateBin/statuses/{sha}","languages_url":"https://api.github.com/repos/otaku/PrivateBin/languages","stargazers_url":"https://api.github.com/repos/otaku/PrivateBin/stargazers","contributors_url":"https://api.github.com/repos/otaku/PrivateBin/contributors","subscribers_url":"https://api.github.com/repos/otaku/PrivateBin/subscribers","subscription_url":"https://api.github.com/repos/otaku/PrivateBin/subscription","commits_url":"https://api.github.com/repos/otaku/PrivateBin/commits{/sha}","git_commits_url":"https://api.github.com/repos/otaku/PrivateBin/git/commits{/sha}","comments_url":"https://api.github.com/repos/otaku/PrivateBin/comments{/number}","issue_comment_url":"https://api.github.com/repos/otaku/PrivateBin/issues/comments{/number}","contents_url":"https://api.github.com/repos/otaku/PrivateBin/contents/{+path}","compare_url":"https://api.github.com/repos/otaku/PrivateBin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/otaku/PrivateBin/merges","archive_url":"https://api.github.com/repos/otaku/PrivateBin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/otaku/PrivateBin/downloads","issues_url":"https://api.github.com/repos/otaku/PrivateBin/issues{/number}","pulls_url":"https://api.github.com/repos/otaku/PrivateBin/pulls{/number}","milestones_url":"https://api.github.com/repos/otaku/PrivateBin/milestones{/number}","notifications_url":"https://api.github.com/repos/otaku/PrivateBin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/otaku/PrivateBin/labels{/name}","releases_url":"https://api.github.com/repos/otaku/PrivateBin/releases{/id}","deployments_url":"https://api.github.com/repos/otaku/PrivateBin/deployments","created_at":"2018-04-07T00:01:01Z","updated_at":"2018-04-07T02:36:39Z","pushed_at":"2018-04-07T19:07:27Z","git_url":"git://github.com/otaku/PrivateBin.git","ssh_url":"git@github.com:otaku/PrivateBin.git","clone_url":"https://github.com/otaku/PrivateBin.git","svn_url":"https://github.com/otaku/PrivateBin","homepage":"https://privatebin.info/","size":9088,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PrivateBin:master","ref":"master","sha":"df921ad658690d5844a435fa9c359e5c91750e11","user":{"login":"PrivateBin","id":20367028,"avatar_url":"https://avatars1.githubusercontent.com/u/20367028?v=4","gravatar_id":"","url":"https://api.github.com/users/PrivateBin","html_url":"https://github.com/PrivateBin","followers_url":"https://api.github.com/users/PrivateBin/followers","following_url":"https://api.github.com/users/PrivateBin/following{/other_user}","gists_url":"https://api.github.com/users/PrivateBin/gists{/gist_id}","starred_url":"https://api.github.com/users/PrivateBin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrivateBin/subscriptions","organizations_url":"https://api.github.com/users/PrivateBin/orgs","repos_url":"https://api.github.com/users/PrivateBin/repos","events_url":"https://api.github.com/users/PrivateBin/events{/privacy}","received_events_url":"https://api.github.com/users/PrivateBin/received_events","type":"Organization","site_admin":false},"repo":{"id":62937181,"name":"PrivateBin","full_name":"PrivateBin/PrivateBin","owner":{"login":"PrivateBin","id":20367028,"avatar_url":"https://avatars1.githubusercontent.com/u/20367028?v=4","gravatar_id":"","url":"https://api.github.com/users/PrivateBin","html_url":"https://github.com/PrivateBin","followers_url":"https://api.github.com/users/PrivateBin/followers","following_url":"https://api.github.com/users/PrivateBin/following{/other_user}","gists_url":"https://api.github.com/users/PrivateBin/gists{/gist_id}","starred_url":"https://api.github.com/users/PrivateBin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrivateBin/subscriptions","organizations_url":"https://api.github.com/users/PrivateBin/orgs","repos_url":"https://api.github.com/users/PrivateBin/repos","events_url":"https://api.github.com/users/PrivateBin/events{/privacy}","received_events_url":"https://api.github.com/users/PrivateBin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PrivateBin/PrivateBin","description":"A minimalist, open source online pastebin where the server has zero knowledge of pasted data. Data is encrypted/decrypted in the browser using 256 bits AES.","fork":false,"url":"https://api.github.com/repos/PrivateBin/PrivateBin","forks_url":"https://api.github.com/repos/PrivateBin/PrivateBin/forks","keys_url":"https://api.github.com/repos/PrivateBin/PrivateBin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PrivateBin/PrivateBin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PrivateBin/PrivateBin/teams","hooks_url":"https://api.github.com/repos/PrivateBin/PrivateBin/hooks","issue_events_url":"https://api.github.com/repos/PrivateBin/PrivateBin/issues/events{/number}","events_url":"https://api.github.com/repos/PrivateBin/PrivateBin/events","assignees_url":"https://api.github.com/repos/PrivateBin/PrivateBin/assignees{/user}","branches_url":"https://api.github.com/repos/PrivateBin/PrivateBin/branches{/branch}","tags_url":"https://api.github.com/repos/PrivateBin/PrivateBin/tags","blobs_url":"https://api.github.com/repos/PrivateBin/PrivateBin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PrivateBin/PrivateBin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PrivateBin/PrivateBin/git/refs{/sha}","trees_url":"https://api.github.com/repos/PrivateBin/PrivateBin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PrivateBin/PrivateBin/statuses/{sha}","languages_url":"https://api.github.com/repos/PrivateBin/PrivateBin/languages","stargazers_url":"https://api.github.com/repos/PrivateBin/PrivateBin/stargazers","contributors_url":"https://api.github.com/repos/PrivateBin/PrivateBin/contributors","subscribers_url":"https://api.github.com/repos/PrivateBin/PrivateBin/subscribers","subscription_url":"https://api.github.com/repos/PrivateBin/PrivateBin/subscription","commits_url":"https://api.github.com/repos/PrivateBin/PrivateBin/commits{/sha}","git_commits_url":"https://api.github.com/repos/PrivateBin/PrivateBin/git/commits{/sha}","comments_url":"https://api.github.com/repos/PrivateBin/PrivateBin/comments{/number}","issue_comment_url":"https://api.github.com/repos/PrivateBin/PrivateBin/issues/comments{/number}","contents_url":"https://api.github.com/repos/PrivateBin/PrivateBin/contents/{+path}","compare_url":"https://api.github.com/repos/PrivateBin/PrivateBin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PrivateBin/PrivateBin/merges","archive_url":"https://api.github.com/repos/PrivateBin/PrivateBin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PrivateBin/PrivateBin/downloads","issues_url":"https://api.github.com/repos/PrivateBin/PrivateBin/issues{/number}","pulls_url":"https://api.github.com/repos/PrivateBin/PrivateBin/pulls{/number}","milestones_url":"https://api.github.com/repos/PrivateBin/PrivateBin/milestones{/number}","notifications_url":"https://api.github.com/repos/PrivateBin/PrivateBin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PrivateBin/PrivateBin/labels{/name}","releases_url":"https://api.github.com/repos/PrivateBin/PrivateBin/releases{/id}","deployments_url":"https://api.github.com/repos/PrivateBin/PrivateBin/deployments","created_at":"2016-07-09T07:03:25Z","updated_at":"2018-04-06T13:47:08Z","pushed_at":"2018-04-07T20:58:30Z","git_url":"git://github.com/PrivateBin/PrivateBin.git","ssh_url":"git@github.com:PrivateBin/PrivateBin.git","clone_url":"https://github.com/PrivateBin/PrivateBin.git","svn_url":"https://github.com/PrivateBin/PrivateBin","homepage":"https://privatebin.info/","size":9000,"stargazers_count":803,"watchers_count":803,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":118,"mirror_url":null,"archived":false,"open_issues_count":89,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":118,"open_issues":89,"watchers":803,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PrivateBin/PrivateBin/pulls/299"},"html":{"href":"https://github.com/PrivateBin/PrivateBin/pull/299"},"issue":{"href":"https://api.github.com/repos/PrivateBin/PrivateBin/issues/299"},"comments":{"href":"https://api.github.com/repos/PrivateBin/PrivateBin/issues/299/comments"},"review_comments":{"href":"https://api.github.com/repos/PrivateBin/PrivateBin/pulls/299/comments"},"review_comment":{"href":"https://api.github.com/repos/PrivateBin/PrivateBin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PrivateBin/PrivateBin/pulls/299/commits"},"statuses":{"href":"https://api.github.com/repos/PrivateBin/PrivateBin/statuses/db19ba7b725680176d25019c055b4ffb10fcf7ea"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":9767,"deletions":3,"changed_files":22}}
{"actor":{"display_login":"rugk"}}