{"action":"created","issue":{"url":"https://api.github.com/repos/auth0/node-samlp/issues/75","repository_url":"https://api.github.com/repos/auth0/node-samlp","labels_url":"https://api.github.com/repos/auth0/node-samlp/issues/75/labels{/name}","comments_url":"https://api.github.com/repos/auth0/node-samlp/issues/75/comments","events_url":"https://api.github.com/repos/auth0/node-samlp/issues/75/events","html_url":"https://github.com/auth0/node-samlp/pull/75","id":358534815,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MjQ2NTM4","number":75,"title":"Use xml-crypto@1.0.1","user":{"login":"LoneRifle","id":10572368,"node_id":"MDQ6VXNlcjEwNTcyMzY4","avatar_url":"https://avatars2.githubusercontent.com/u/10572368?v=4","gravatar_id":"","url":"https://api.github.com/users/LoneRifle","html_url":"https://github.com/LoneRifle","followers_url":"https://api.github.com/users/LoneRifle/followers","following_url":"https://api.github.com/users/LoneRifle/following{/other_user}","gists_url":"https://api.github.com/users/LoneRifle/gists{/gist_id}","starred_url":"https://api.github.com/users/LoneRifle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LoneRifle/subscriptions","organizations_url":"https://api.github.com/users/LoneRifle/orgs","repos_url":"https://api.github.com/users/LoneRifle/repos","events_url":"https://api.github.com/users/LoneRifle/events{/privacy}","received_events_url":"https://api.github.com/users/LoneRifle/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-09-10T09:14:06Z","updated_at":"2018-11-17T08:34:08Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/auth0/node-samlp/pulls/75","html_url":"https://github.com/auth0/node-samlp/pull/75","diff_url":"https://github.com/auth0/node-samlp/pull/75.diff","patch_url":"https://github.com/auth0/node-samlp/pull/75.patch"},"body":"A new release of xml-crypto was made, delivering several bugfixes (notably now allowing double-signing of responses). Despite the major version change, API and behaviour should remain largely the same\r\n\r\nFixes #69 "},"comment":{"url":"https://api.github.com/repos/auth0/node-samlp/issues/comments/439600021","html_url":"https://github.com/auth0/node-samlp/pull/75#issuecomment-439600021","issue_url":"https://api.github.com/repos/auth0/node-samlp/issues/75","id":439600021,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTYwMDAyMQ==","user":{"login":"LoneRifle","id":10572368,"node_id":"MDQ6VXNlcjEwNTcyMzY4","avatar_url":"https://avatars2.githubusercontent.com/u/10572368?v=4","gravatar_id":"","url":"https://api.github.com/users/LoneRifle","html_url":"https://github.com/LoneRifle","followers_url":"https://api.github.com/users/LoneRifle/followers","following_url":"https://api.github.com/users/LoneRifle/following{/other_user}","gists_url":"https://api.github.com/users/LoneRifle/gists{/gist_id}","starred_url":"https://api.github.com/users/LoneRifle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LoneRifle/subscriptions","organizations_url":"https://api.github.com/users/LoneRifle/orgs","repos_url":"https://api.github.com/users/LoneRifle/repos","events_url":"https://api.github.com/users/LoneRifle/events{/privacy}","received_events_url":"https://api.github.com/users/LoneRifle/received_events","type":"User","site_admin":false},"created_at":"2018-11-17T08:34:08Z","updated_at":"2018-11-17T08:34:08Z","author_association":"NONE","body":"As it turns out, there is an existing test suite that already checks for signed response. Due to the xml-crypto bug however, the suite never tested for the presence of signed assertions, which are necessary to prove double-signing. \r\n\r\nI've simply added a test to check for the signed assertion. This should fail on the master branch (since the assertion signature gets decimated) but work for the patch."}}
{"actor":{"display_login":"LoneRifle"}}