{"action":"created","comment":{"url":"https://api.github.com/repos/apache/geode-native/pulls/comments/189333963","pull_request_review_id":121493552,"id":189333963,"diff_hunk":"@@ -1422,3054 +1189,630 @@ void runBasicMergeOps2()\n       CacheHelper.ClearLocators();\n     }\n \n-    #endregion\n-\n-    #region Basic merge three PDxType3\n-\n-    void initializePdxAssemblyOne3(bool useWeakHashmap)\n+    private void dinitPdxSerializer()\n     {\n-      m_pdxVesionOneAsm = Assembly.LoadFrom(\"PdxVersion1Lib.dll\");\n-\n-      CacheHelper.DCache.TypeRegistry.RegisterPdxType(registerPdxTypeOne3);\n-\n-      Type pt = m_pdxVesionOneAsm.GetType(\"PdxVersionTests.PdxTypes3\");\n-\n-      object ob = pt.InvokeMember(\"Reset\", BindingFlags.Default | BindingFlags.InvokeMethod, null, null,\n-        new object[] {useWeakHashmap});\n+      CacheHelper.DCache.TypeRegistry.PdxSerializer = null;\n     }\n \n-    IPdxSerializable registerPdxTypeOne3()\n+    private void doPutGetWithPdxSerializerNoReg()\n     {\n-      Type pt = m_pdxVesionOneAsm.GetType(\"PdxVersionTests.PdxTypes3\");\n-\n-      object ob = pt.InvokeMember(\"CreateDeserializable\", BindingFlags.Default | BindingFlags.InvokeMethod, null, null,\n-        null);\n+      Region region0 = CacheHelper.GetVerifyRegion<object, object>(m_regionNames[0]);\n \n-      return (IPdxSerializable) ob;\n-    }\n+      for (int i = 0; i < 10; i++)\n+      {\n+        object put = new SerializePdxNoRegister(true);\n+        ;\n \n-    void initializePdxAssemblyTwo3(bool useWeakHashmap)\n-    {\n-      m_pdxVesionTwoAsm = Assembly.LoadFrom(\"PdxVersion2Lib.dll\");\n+        region0[i] = put;\n \n-      CacheHelper.DCache.TypeRegistry.RegisterPdxType(registerPdxTypeTwo3);\n-      Type pt = m_pdxVesionTwoAsm.GetType(\"PdxVersionTests.PdxTypes3\");\n+        object ret = region0[i];\n \n-      object ob = pt.InvokeMember(\"Reset\", BindingFlags.Default | BindingFlags.InvokeMethod, null, null,\n-        new object[] {useWeakHashmap});\n+        Assert.AreEqual(put, ret);\n+      }\n     }\n \n-    IPdxSerializable registerPdxTypeTwo3()\n+    private void doGetWithPdxSerializerC2NoReg()\n     {\n-      Type pt = m_pdxVesionTwoAsm.GetType(\"PdxVersionTests.PdxTypes3\");\n+      Region region0 = CacheHelper.GetVerifyRegion<object, object>(m_regionNames[0]);\n \n-      object ob = pt.InvokeMember(\"CreateDeserializable\", BindingFlags.Default | BindingFlags.InvokeMethod, null, null,\n-        null);\n+      for (int i = 0; i < 10; i++)\n+      {\n+        object local = new SerializePdxNoRegister(true);\n+        ;","path":"clicache/integration-test/ThinClientPdxTests2.cs","position":null,"original_position":1983,"commit_id":"30b84d17951dce7bcbc7b8683eca650b674a3324","original_commit_id":"f6729cfbeb47d18d94daee708022992bc1c9ac46","user":{"login":"mcmellawatt","id":1082688,"avatar_url":"https://avatars0.githubusercontent.com/u/1082688?v=4","gravatar_id":"","url":"https://api.github.com/users/mcmellawatt","html_url":"https://github.com/mcmellawatt","followers_url":"https://api.github.com/users/mcmellawatt/followers","following_url":"https://api.github.com/users/mcmellawatt/following{/other_user}","gists_url":"https://api.github.com/users/mcmellawatt/gists{/gist_id}","starred_url":"https://api.github.com/users/mcmellawatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcmellawatt/subscriptions","organizations_url":"https://api.github.com/users/mcmellawatt/orgs","repos_url":"https://api.github.com/users/mcmellawatt/repos","events_url":"https://api.github.com/users/mcmellawatt/events{/privacy}","received_events_url":"https://api.github.com/users/mcmellawatt/received_events","type":"User","site_admin":false},"body":"Extra semicolon","created_at":"2018-05-18T17:06:19Z","updated_at":"2018-05-18T17:11:16Z","html_url":"https://github.com/apache/geode-native/pull/296#discussion_r189333963","pull_request_url":"https://api.github.com/repos/apache/geode-native/pulls/296","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/geode-native/pulls/comments/189333963"},"html":{"href":"https://github.com/apache/geode-native/pull/296#discussion_r189333963"},"pull_request":{"href":"https://api.github.com/repos/apache/geode-native/pulls/296"}}},"pull_request":{"url":"https://api.github.com/repos/apache/geode-native/pulls/296","id":189074407,"html_url":"https://github.com/apache/geode-native/pull/296","diff_url":"https://github.com/apache/geode-native/pull/296.diff","patch_url":"https://github.com/apache/geode-native/pull/296.patch","issue_url":"https://api.github.com/repos/apache/geode-native/issues/296","number":296,"state":"open","locked":false,"title":"GEODE-5205 break up thin client pdx tests","user":{"login":"moleske","id":12620096,"avatar_url":"https://avatars3.githubusercontent.com/u/12620096?v=4","gravatar_id":"","url":"https://api.github.com/users/moleske","html_url":"https://github.com/moleske","followers_url":"https://api.github.com/users/moleske/followers","following_url":"https://api.github.com/users/moleske/following{/other_user}","gists_url":"https://api.github.com/users/moleske/gists{/gist_id}","starred_url":"https://api.github.com/users/moleske/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moleske/subscriptions","organizations_url":"https://api.github.com/users/moleske/orgs","repos_url":"https://api.github.com/users/moleske/repos","events_url":"https://api.github.com/users/moleske/events{/privacy}","received_events_url":"https://api.github.com/users/moleske/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-18T16:22:09Z","updated_at":"2018-05-18T17:11:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49e64e3296d915efb997159d5195e0c0cba59859","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/geode-native/pulls/296/commits","review_comments_url":"https://api.github.com/repos/apache/geode-native/pulls/296/comments","review_comment_url":"https://api.github.com/repos/apache/geode-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/geode-native/issues/296/comments","statuses_url":"https://api.github.com/repos/apache/geode-native/statuses/30b84d17951dce7bcbc7b8683eca650b674a3324","head":{"label":"austxcodemonkey:GEODE-5205_break_up_thin_client_pdx_tests","ref":"GEODE-5205_break_up_thin_client_pdx_tests","sha":"30b84d17951dce7bcbc7b8683eca650b674a3324","user":{"login":"austxcodemonkey","id":3029555,"avatar_url":"https://avatars3.githubusercontent.com/u/3029555?v=4","gravatar_id":"","url":"https://api.github.com/users/austxcodemonkey","html_url":"https://github.com/austxcodemonkey","followers_url":"https://api.github.com/users/austxcodemonkey/followers","following_url":"https://api.github.com/users/austxcodemonkey/following{/other_user}","gists_url":"https://api.github.com/users/austxcodemonkey/gists{/gist_id}","starred_url":"https://api.github.com/users/austxcodemonkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/austxcodemonkey/subscriptions","organizations_url":"https://api.github.com/users/austxcodemonkey/orgs","repos_url":"https://api.github.com/users/austxcodemonkey/repos","events_url":"https://api.github.com/users/austxcodemonkey/events{/privacy}","received_events_url":"https://api.github.com/users/austxcodemonkey/received_events","type":"User","site_admin":false},"repo":{"id":122256536,"name":"geode-native","full_name":"austxcodemonkey/geode-native","owner":{"login":"austxcodemonkey","id":3029555,"avatar_url":"https://avatars3.githubusercontent.com/u/3029555?v=4","gravatar_id":"","url":"https://api.github.com/users/austxcodemonkey","html_url":"https://github.com/austxcodemonkey","followers_url":"https://api.github.com/users/austxcodemonkey/followers","following_url":"https://api.github.com/users/austxcodemonkey/following{/other_user}","gists_url":"https://api.github.com/users/austxcodemonkey/gists{/gist_id}","starred_url":"https://api.github.com/users/austxcodemonkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/austxcodemonkey/subscriptions","organizations_url":"https://api.github.com/users/austxcodemonkey/orgs","repos_url":"https://api.github.com/users/austxcodemonkey/repos","events_url":"https://api.github.com/users/austxcodemonkey/events{/privacy}","received_events_url":"https://api.github.com/users/austxcodemonkey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/austxcodemonkey/geode-native","description":"Apache Geode native components","fork":true,"url":"https://api.github.com/repos/austxcodemonkey/geode-native","forks_url":"https://api.github.com/repos/austxcodemonkey/geode-native/forks","keys_url":"https://api.github.com/repos/austxcodemonkey/geode-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/austxcodemonkey/geode-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/austxcodemonkey/geode-native/teams","hooks_url":"https://api.github.com/repos/austxcodemonkey/geode-native/hooks","issue_events_url":"https://api.github.com/repos/austxcodemonkey/geode-native/issues/events{/number}","events_url":"https://api.github.com/repos/austxcodemonkey/geode-native/events","assignees_url":"https://api.github.com/repos/austxcodemonkey/geode-native/assignees{/user}","branches_url":"https://api.github.com/repos/austxcodemonkey/geode-native/branches{/branch}","tags_url":"https://api.github.com/repos/austxcodemonkey/geode-native/tags","blobs_url":"https://api.github.com/repos/austxcodemonkey/geode-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/austxcodemonkey/geode-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/austxcodemonkey/geode-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/austxcodemonkey/geode-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/austxcodemonkey/geode-native/statuses/{sha}","languages_url":"https://api.github.com/repos/austxcodemonkey/geode-native/languages","stargazers_url":"https://api.github.com/repos/austxcodemonkey/geode-native/stargazers","contributors_url":"https://api.github.com/repos/austxcodemonkey/geode-native/contributors","subscribers_url":"https://api.github.com/repos/austxcodemonkey/geode-native/subscribers","subscription_url":"https://api.github.com/repos/austxcodemonkey/geode-native/subscription","commits_url":"https://api.github.com/repos/austxcodemonkey/geode-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/austxcodemonkey/geode-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/austxcodemonkey/geode-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/austxcodemonkey/geode-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/austxcodemonkey/geode-native/contents/{+path}","compare_url":"https://api.github.com/repos/austxcodemonkey/geode-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/austxcodemonkey/geode-native/merges","archive_url":"https://api.github.com/repos/austxcodemonkey/geode-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/austxcodemonkey/geode-native/downloads","issues_url":"https://api.github.com/repos/austxcodemonkey/geode-native/issues{/number}","pulls_url":"https://api.github.com/repos/austxcodemonkey/geode-native/pulls{/number}","milestones_url":"https://api.github.com/repos/austxcodemonkey/geode-native/milestones{/number}","notifications_url":"https://api.github.com/repos/austxcodemonkey/geode-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/austxcodemonkey/geode-native/labels{/name}","releases_url":"https://api.github.com/repos/austxcodemonkey/geode-native/releases{/id}","deployments_url":"https://api.github.com/repos/austxcodemonkey/geode-native/deployments","created_at":"2018-02-20T21:08:20Z","updated_at":"2018-04-23T15:15:50Z","pushed_at":"2018-05-18T00:39:12Z","git_url":"git://github.com/austxcodemonkey/geode-native.git","ssh_url":"git@github.com:austxcodemonkey/geode-native.git","clone_url":"https://github.com/austxcodemonkey/geode-native.git","svn_url":"https://github.com/austxcodemonkey/geode-native","homepage":"","size":18412,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"apache:develop","ref":"develop","sha":"ecd5caf93388e0739d2c632c6bf96b21d5ce6fde","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":80904111,"name":"geode-native","full_name":"apache/geode-native","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/geode-native","description":"Apache Geode native components","fork":false,"url":"https://api.github.com/repos/apache/geode-native","forks_url":"https://api.github.com/repos/apache/geode-native/forks","keys_url":"https://api.github.com/repos/apache/geode-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/geode-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/geode-native/teams","hooks_url":"https://api.github.com/repos/apache/geode-native/hooks","issue_events_url":"https://api.github.com/repos/apache/geode-native/issues/events{/number}","events_url":"https://api.github.com/repos/apache/geode-native/events","assignees_url":"https://api.github.com/repos/apache/geode-native/assignees{/user}","branches_url":"https://api.github.com/repos/apache/geode-native/branches{/branch}","tags_url":"https://api.github.com/repos/apache/geode-native/tags","blobs_url":"https://api.github.com/repos/apache/geode-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/geode-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/geode-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/geode-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/geode-native/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/geode-native/languages","stargazers_url":"https://api.github.com/repos/apache/geode-native/stargazers","contributors_url":"https://api.github.com/repos/apache/geode-native/contributors","subscribers_url":"https://api.github.com/repos/apache/geode-native/subscribers","subscription_url":"https://api.github.com/repos/apache/geode-native/subscription","commits_url":"https://api.github.com/repos/apache/geode-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/geode-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/geode-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/geode-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/geode-native/contents/{+path}","compare_url":"https://api.github.com/repos/apache/geode-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/geode-native/merges","archive_url":"https://api.github.com/repos/apache/geode-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/geode-native/downloads","issues_url":"https://api.github.com/repos/apache/geode-native/issues{/number}","pulls_url":"https://api.github.com/repos/apache/geode-native/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/geode-native/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/geode-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/geode-native/labels{/name}","releases_url":"https://api.github.com/repos/apache/geode-native/releases{/id}","deployments_url":"https://api.github.com/repos/apache/geode-native/deployments","created_at":"2017-02-04T08:00:06Z","updated_at":"2018-05-18T16:56:05Z","pushed_at":"2018-05-18T16:56:03Z","git_url":"git://github.com/apache/geode-native.git","ssh_url":"git@github.com:apache/geode-native.git","clone_url":"https://github.com/apache/geode-native.git","svn_url":"https://github.com/apache/geode-native","homepage":"","size":18163,"stargazers_count":19,"watchers_count":19,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":28,"open_issues":3,"watchers":19,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/geode-native/pulls/296"},"html":{"href":"https://github.com/apache/geode-native/pull/296"},"issue":{"href":"https://api.github.com/repos/apache/geode-native/issues/296"},"comments":{"href":"https://api.github.com/repos/apache/geode-native/issues/296/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/geode-native/pulls/296/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/geode-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/geode-native/pulls/296/commits"},"statuses":{"href":"https://api.github.com/repos/apache/geode-native/statuses/30b84d17951dce7bcbc7b8683eca650b674a3324"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mcmellawatt"}}