{"action":"created","issue":{"url":"https://api.github.com/repos/python/cpython/issues/6362","repository_url":"https://api.github.com/repos/python/cpython","labels_url":"https://api.github.com/repos/python/cpython/issues/6362/labels{/name}","comments_url":"https://api.github.com/repos/python/cpython/issues/6362/comments","events_url":"https://api.github.com/repos/python/cpython/issues/6362/events","html_url":"https://github.com/python/cpython/pull/6362","id":310707907,"number":6362,"title":"Changed a line where it said \"the_world_is_flat\"","user":{"login":"radamar","id":16580616,"avatar_url":"https://avatars3.githubusercontent.com/u/16580616?v=4","gravatar_id":"","url":"https://api.github.com/users/radamar","html_url":"https://github.com/radamar","followers_url":"https://api.github.com/users/radamar/followers","following_url":"https://api.github.com/users/radamar/following{/other_user}","gists_url":"https://api.github.com/users/radamar/gists{/gist_id}","starred_url":"https://api.github.com/users/radamar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radamar/subscriptions","organizations_url":"https://api.github.com/users/radamar/orgs","repos_url":"https://api.github.com/users/radamar/repos","events_url":"https://api.github.com/users/radamar/events{/privacy}","received_events_url":"https://api.github.com/users/radamar/received_events","type":"User","site_admin":false},"labels":[{"id":536945571,"url":"https://api.github.com/repos/python/cpython/labels/CLA%20not%20signed","name":"CLA not signed","color":"b60205","default":false},{"id":666979821,"url":"https://api.github.com/repos/python/cpython/labels/awaiting%20review","name":"awaiting review","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-04-03T06:19:27Z","updated_at":"2018-04-03T08:41:13Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/python/cpython/pulls/6362","html_url":"https://github.com/python/cpython/pull/6362","diff_url":"https://github.com/python/cpython/pull/6362.diff","patch_url":"https://github.com/python/cpython/pull/6362.patch"},"body":"# Changed a line where it said \"the_world_is_flat\"\r\n\r\nThis was in there since 3rd April, 2000. Science has progressed since and we know better now. This is a duplicate pull request, created because serhiy-storchaka pointed out some errors in #6343.\r\n\r\n> You have to create a pull request to the master branch.\r\n\r\nI think it's correct now. Base fork: python/cpython base: master\r\n\r\n> `the_world_is_flat == False` is an example of extremely bad style.\r\n\r\nI went through the [styling guidelines][1]\r\n\r\n> Python is full of jokes.\r\n\r\nOk, thanks for stating your observation. But this doesn't make any sense for the PR. Is it a requirement that every line of program in Python be a joke?\r\n\r\nOverall, this meets all the suggestions made by serhiy-storchaka. I am not very funny but maybe someone else can come up with a good joke that doesn't imply false statements which are debated _passionately_ to this day.\r\n\r\n[1]: https://www.python.org/dev/peps/pep-0008/\r\n\r\n\r\n<!--\r\nThanks for your contribution!\r\nPlease read this comment in its entirety. It's quite important.\r\n\r\n# Pull Request title\r\n\r\nIt should be in the following format:\r\n```\r\nbpo-NNNN: Summary of the changes made\r\n```\r\nWhere: bpo-NNNN refers to the issue number in the https://bugs.python.org.\r\n\r\nMost PRs will require an issue number. Trivial changes, like fixing a typo, do not need an issue.\r\n\r\n# Backport Pull Request title\r\n\r\nIf this is a backport PR (PR made against branches other than `master`),\r\nplease ensure that the PR title is in the following format:\r\n```\r\n[X.Y] <title from the original PR> (GH-NNNN)\r\n```\r\nWhere: [X.Y] is the branch name, e.g. [3.6].\r\n\r\nGH-NNNN refers to the PR number from `master`.\r\n\r\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/python/cpython/issues/comments/378174084","html_url":"https://github.com/python/cpython/pull/6362#issuecomment-378174084","issue_url":"https://api.github.com/repos/python/cpython/issues/6362","id":378174084,"user":{"login":"radamar","id":16580616,"avatar_url":"https://avatars3.githubusercontent.com/u/16580616?v=4","gravatar_id":"","url":"https://api.github.com/users/radamar","html_url":"https://github.com/radamar","followers_url":"https://api.github.com/users/radamar/followers","following_url":"https://api.github.com/users/radamar/following{/other_user}","gists_url":"https://api.github.com/users/radamar/gists{/gist_id}","starred_url":"https://api.github.com/users/radamar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radamar/subscriptions","organizations_url":"https://api.github.com/users/radamar/orgs","repos_url":"https://api.github.com/users/radamar/repos","events_url":"https://api.github.com/users/radamar/events{/privacy}","received_events_url":"https://api.github.com/users/radamar/received_events","type":"User","site_admin":false},"created_at":"2018-04-03T08:41:13Z","updated_at":"2018-04-03T08:41:13Z","author_association":"NONE","body":"> I afraid you have confused by the difference between the Boolean truth value and true facts of the real world.\r\n\r\nyes! Someone else could too! And then what will you say it was just a joke and you didn't get it, so my own fault?\r\n\r\n> This example contains a joke. Maybe it contains even more joke than I understand (some hidden references). Your proposition kills the joke.\r\n\r\nOk, i get it. This is a really important joke and the author 'fdrake' might have referenced it somewhere else. So i will take back my proposition.\r\nHow about this one:\r\n`\r\n# Disclaimer: Earth is spherical!\r\n>>> the_world_is_flat = True\r\n>>> if the_world_is_flat:\r\n...     print(\"Be careful not to fall off!\")\r\nBe careful not to fall off!\r\n`\r\nI didn't touch the joke. Is this better?"}}
{"actor":{"display_login":"radamar"}}