{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/24141","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/24141/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/24141/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/24141/events","html_url":"https://github.com/cockroachdb/cockroach/pull/24141","id":307501767,"number":24141,"title":"acceptance: fix and reenable TestDockerCSharp","user":{"login":"benesch","id":882976,"avatar_url":"https://avatars1.githubusercontent.com/u/882976?v=4","gravatar_id":"","url":"https://api.github.com/users/benesch","html_url":"https://github.com/benesch","followers_url":"https://api.github.com/users/benesch/followers","following_url":"https://api.github.com/users/benesch/following{/other_user}","gists_url":"https://api.github.com/users/benesch/gists{/gist_id}","starred_url":"https://api.github.com/users/benesch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benesch/subscriptions","organizations_url":"https://api.github.com/users/benesch/orgs","repos_url":"https://api.github.com/users/benesch/repos","events_url":"https://api.github.com/users/benesch/events{/privacy}","received_events_url":"https://api.github.com/users/benesch/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-22T04:24:19Z","updated_at":"2018-03-22T15:52:39Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/24141","html_url":"https://github.com/cockroachdb/cockroach/pull/24141","diff_url":"https://github.com/cockroachdb/cockroach/pull/24141.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/24141.patch"},"body":"The name resolution overhaul (#22371) caused TestDockerCSharp to start\r\nfailing. Specifically, I suspect that Npgsql performs some query on a\r\ntable in the pg_catalog schema, which now requires the session database\r\nto exist. There seems to be no way to prevent Npgsql from performing\r\nthis query, so simply instruct it to connect to the system database,\r\nwhich is guaranteed to exist.\r\n\r\nAlso delete a test that checked the oid of the pg_catalog namespace\r\nentry. That's changed since the test has been skipped, and seems like a\r\nmoving target. I'm not sure why we cared about the oid's value in the\r\nfirst place.\r\n\r\nFix #22769.\r\n\r\nRelease note: None"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/375356986","html_url":"https://github.com/cockroachdb/cockroach/pull/24141#issuecomment-375356986","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/24141","id":375356986,"user":{"login":"BramGruneir","id":1614265,"avatar_url":"https://avatars1.githubusercontent.com/u/1614265?v=4","gravatar_id":"","url":"https://api.github.com/users/BramGruneir","html_url":"https://github.com/BramGruneir","followers_url":"https://api.github.com/users/BramGruneir/followers","following_url":"https://api.github.com/users/BramGruneir/following{/other_user}","gists_url":"https://api.github.com/users/BramGruneir/gists{/gist_id}","starred_url":"https://api.github.com/users/BramGruneir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BramGruneir/subscriptions","organizations_url":"https://api.github.com/users/BramGruneir/orgs","repos_url":"https://api.github.com/users/BramGruneir/repos","events_url":"https://api.github.com/users/BramGruneir/events{/privacy}","received_events_url":"https://api.github.com/users/BramGruneir/received_events","type":"User","site_admin":false},"created_at":"2018-03-22T15:52:39Z","updated_at":"2018-03-22T15:52:39Z","author_association":"OWNER","body":"<img class=\"emoji\" title=\":lgtm:\" alt=\":lgtm:\" align=\"absmiddle\" src=\"https://reviewable.io/lgtm.png\" height=\"20\" width=\"61\"/>\n\nThanks for looking at this.\n\n---\n\nReviewed 2 of 2 files at r1.\nReview status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.\n\n---\n\n\n\n*Comments from [Reviewable](https://beta.reviewable.io/reviews/cockroachdb/cockroach/24141#-:-L8DPJ6I3ntGHHHiK5AQ:biqs7fh)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"BramGruneir"}}