{"comment":{"url":"https://api.github.com/repos/ericpaulbishop/gargoyle/comments/28139182","html_url":"https://github.com/ericpaulbishop/gargoyle/commit/6284d4d3de136285b5c27a7084190fb3493a4701#commitcomment-28139182","id":28139182,"user":{"login":"ericpaulbishop","id":251665,"avatar_url":"https://avatars0.githubusercontent.com/u/251665?v=4","gravatar_id":"","url":"https://api.github.com/users/ericpaulbishop","html_url":"https://github.com/ericpaulbishop","followers_url":"https://api.github.com/users/ericpaulbishop/followers","following_url":"https://api.github.com/users/ericpaulbishop/following{/other_user}","gists_url":"https://api.github.com/users/ericpaulbishop/gists{/gist_id}","starred_url":"https://api.github.com/users/ericpaulbishop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericpaulbishop/subscriptions","organizations_url":"https://api.github.com/users/ericpaulbishop/orgs","repos_url":"https://api.github.com/users/ericpaulbishop/repos","events_url":"https://api.github.com/users/ericpaulbishop/events{/privacy}","received_events_url":"https://api.github.com/users/ericpaulbishop/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":null,"commit_id":"6284d4d3de136285b5c27a7084190fb3493a4701","created_at":"2018-03-17T17:03:36Z","updated_at":"2018-03-17T17:03:36Z","author_association":"OWNER","body":"All help is definitely very, very welcome! \r\n\r\nNote that I'm actually tracking not the lede-17.01 branch but the master (unstable) branch because I anticipate a release from that branch very shortly. Also this gets around any issues that might be caused by the rename of openwrt => lede (which I would eventually just have to revert anyway if I did a release based on 17.01, because in the latest it's switched back).\r\n\r\nHowever, there is a reason I prefer to include packages that are in the packages repo and not the main openwrt repo, directly into the gargoyle repository. \r\n\r\nA long time ago I did it as you suggest, but the problem I kept running into is that doing it this way results in version mismatch issues. If you don't lock the packages repo version to a specific commit, then you have the problem that it can get ahead of the branch the main repo tracks. If you do lock the packages repo version to a specific commit then you have to update it every time you want to update even a single package needed in there to the latest version, and that can mean it will get ahead of the main openwrt repo anyway. Also, that would mean every time you want to bump the version of one package, you bump the version of ALL of them, which can introduce incompatibilities.\r\n\r\nFor that reason I've found it's easier to just not rely on the packages repo, but copy the packages needed from there into the gargoyle repo. The downside of that, of course, is that all version upgrades need to be handled manually. However, I prefer this to the case where I want to bump one package and then find I need to fix 10 because they all just changed... and then realize that bumping one of those other 10 packages means that it now relies on a feature that is only in a newer version of the main openwrt repo, which means that has to be updated too. This has happened. \r\n\r\n\r\n\r\n\r\n"}}
{"actor":{"display_login":"ericpaulbishop"}}