{"action":"created","issue":{"url":"https://api.github.com/repos/xenko3d/xenko/issues/289","repository_url":"https://api.github.com/repos/xenko3d/xenko","labels_url":"https://api.github.com/repos/xenko3d/xenko/issues/289/labels{/name}","comments_url":"https://api.github.com/repos/xenko3d/xenko/issues/289/comments","events_url":"https://api.github.com/repos/xenko3d/xenko/issues/289/events","html_url":"https://github.com/xenko3d/xenko/pull/289","id":389422574,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NDE2MDgw","number":289,"title":"[WIP] Update BulletSharp to latest version","user":{"login":"Eideren","id":5742236,"node_id":"MDQ6VXNlcjU3NDIyMzY=","avatar_url":"https://avatars2.githubusercontent.com/u/5742236?v=4","gravatar_id":"","url":"https://api.github.com/users/Eideren","html_url":"https://github.com/Eideren","followers_url":"https://api.github.com/users/Eideren/followers","following_url":"https://api.github.com/users/Eideren/following{/other_user}","gists_url":"https://api.github.com/users/Eideren/gists{/gist_id}","starred_url":"https://api.github.com/users/Eideren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eideren/subscriptions","organizations_url":"https://api.github.com/users/Eideren/orgs","repos_url":"https://api.github.com/users/Eideren/repos","events_url":"https://api.github.com/users/Eideren/events{/privacy}","received_events_url":"https://api.github.com/users/Eideren/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-12-10T18:08:51Z","updated_at":"2018-12-11T14:30:08Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/xenko3d/xenko/pulls/289","html_url":"https://github.com/xenko3d/xenko/pull/289","diff_url":"https://github.com/xenko3d/xenko/pull/289.diff","patch_url":"https://github.com/xenko3d/xenko/pull/289.patch"},"body":"Our version of BulletSharp is a modified, extremely old, pre-github version of https://github.com/AndresTraks/BulletSharpPInvoke , this PR should fix dependencies and the likes to allow us to pull from a clean and up to date nuget version of BulletSharpPInvoke instead.\r\nXenko's version contains a bunch of methods and fields which will have to be replaced with workarounds, some of which don't have any straightforward substitute.\r\nI don't know yet where I can find/or how I could replace CollisionWorld's 'GetCollisions' and CollisionObject's 'GetManaged', if you have any idea, feel free to jump in.\r\n\r\nPlease verify the lines I changed and take a look at the implicit conversion I wrote, tell me if I should just stick to a straightforward new instance + field assignment instead. \r\nPointer cast is about two times faster for Vector3s and should be even more so for Matrix but it will fail if the fields don't match between the two types properly, I verified and they should match but should I write some kind of test to validate all of that ?\r\n\r\nRef\r\n**IOs**\r\n__Internal:https://github.com/Eideren/_xenko_bulletsharp_temp/commit/b9d189281ae6f7a259aa72b24924547a88f7e24d\r\n-thread:https://bugzilla.xamarin.com/show_bug.cgi?id=24943\r\nmisc changes:https://github.com/Eideren/_xenko_bulletsharp_temp/commit/46a9f0ec0bdf106becdcf198d4e241e43fac05d2\r\n**Bullet Source**\r\noriginal:https://github.com/sinkingsugar/BulletSharpPInvoke\r\nx_decomp:https://github.com/Eideren/_xenko_bulletsharp_temp\r\n\r\n- SharpMotionState \r\n- GetManaged\r\n- GetCollisions"},"comment":{"url":"https://api.github.com/repos/xenko3d/xenko/issues/comments/446221707","html_url":"https://github.com/xenko3d/xenko/pull/289#issuecomment-446221707","issue_url":"https://api.github.com/repos/xenko3d/xenko/issues/289","id":446221707,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjIyMTcwNw==","user":{"login":"xen2","id":527565,"node_id":"MDQ6VXNlcjUyNzU2NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/527565?v=4","gravatar_id":"","url":"https://api.github.com/users/xen2","html_url":"https://github.com/xen2","followers_url":"https://api.github.com/users/xen2/followers","following_url":"https://api.github.com/users/xen2/following{/other_user}","gists_url":"https://api.github.com/users/xen2/gists{/gist_id}","starred_url":"https://api.github.com/users/xen2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xen2/subscriptions","organizations_url":"https://api.github.com/users/xen2/orgs","repos_url":"https://api.github.com/users/xen2/repos","events_url":"https://api.github.com/users/xen2/events{/privacy}","received_events_url":"https://api.github.com/users/xen2/received_events","type":"User","site_admin":false},"created_at":"2018-12-11T14:30:08Z","updated_at":"2018-12-11T14:30:08Z","author_association":"MEMBER","body":"BTW, while I still have it on top of my head, some remarks about how those native libs are compiled so far:\r\n\r\nWe were usually building the sources for libbulletc and some other native libraries that needs target OS in manually in various computer/VM (hard for people to do it themselves from scratch since those VM had lot of specific software installed).\r\n\r\nIt would be great if we were switching to something more reproducible and easier to test.\r\nFor example, something that can either (1) run in CI, or (2) something that can setup a full docker instance with all dependencies (for Linux/Android, or similar system for Mac), or a combination of both.\r\n\r\nThat's probably something we should do for all those dependencies that can't be built using our C++ native layer directly in Xenko projects (which support only a very limited subset of the standard library) but instead need to be built on the target OS."}}
{"actor":{"display_login":"xen2"}}