{"action":"created","comment":{"url":"https://api.github.com/repos/corda/corda/pulls/comments/183026131","pull_request_review_id":113947079,"id":183026131,"diff_hunk":"@@ -137,7 +137,7 @@ class CordappLoader private constructor(private val cordappJarPaths: List<Restri\n                 FileOutputStream(cordappJAR).use {\n                     JarOutputStream(it).use { jos ->\n                         val scanDir = File(path.toURI())\n-                        scanDir.walkTopDown().forEach {\n+                        scanDir.listFiles().filter { it.isFile }.forEach {","path":"node/src/main/kotlin/net/corda/node/internal/cordapp/CordappLoader.kt","position":5,"original_position":5,"commit_id":"8271062bc90271eca9324ea653e6ef52bc7b5b4d","original_commit_id":"68befb8d60743f359d8d7c3b5660fe08abae62bc","user":{"login":"vkolomeyko","id":31008341,"avatar_url":"https://avatars2.githubusercontent.com/u/31008341?v=4","gravatar_id":"","url":"https://api.github.com/users/vkolomeyko","html_url":"https://github.com/vkolomeyko","followers_url":"https://api.github.com/users/vkolomeyko/followers","following_url":"https://api.github.com/users/vkolomeyko/following{/other_user}","gists_url":"https://api.github.com/users/vkolomeyko/gists{/gist_id}","starred_url":"https://api.github.com/users/vkolomeyko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkolomeyko/subscriptions","organizations_url":"https://api.github.com/users/vkolomeyko/orgs","repos_url":"https://api.github.com/users/vkolomeyko/repos","events_url":"https://api.github.com/users/vkolomeyko/events{/privacy}","received_events_url":"https://api.github.com/users/vkolomeyko/received_events","type":"User","site_admin":false},"body":"Method name is `createDevCordappJar()` and this is indeed only used during CI or local test run - no production impact. @Clintonio - could you opine here?\r\n\r\nWith this in mind - this is relatively safe change to make.\r\n\r\nAs for performance improvements for attachements scanning, more changes in the pipeline, e.g.: #2982\r\nBut still having smaller attachments JARs would be valuable and to me is a sensible thing to do.","created_at":"2018-04-20T11:52:48Z","updated_at":"2018-04-20T11:52:48Z","html_url":"https://github.com/corda/corda/pull/2941#discussion_r183026131","pull_request_url":"https://api.github.com/repos/corda/corda/pulls/2941","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/corda/corda/pulls/comments/183026131"},"html":{"href":"https://github.com/corda/corda/pull/2941#discussion_r183026131"},"pull_request":{"href":"https://api.github.com/repos/corda/corda/pulls/2941"}},"in_reply_to_id":179773784},"pull_request":{"url":"https://api.github.com/repos/corda/corda/pulls/2941","id":179962548,"html_url":"https://github.com/corda/corda/pull/2941","diff_url":"https://github.com/corda/corda/pull/2941.diff","patch_url":"https://github.com/corda/corda/pull/2941.patch","issue_url":"https://api.github.com/repos/corda/corda/issues/2941","number":2941,"state":"open","locked":false,"title":"Do not perform deep scan when assembling Dev Cordap Jar.","user":{"login":"vkolomeyko","id":31008341,"avatar_url":"https://avatars2.githubusercontent.com/u/31008341?v=4","gravatar_id":"","url":"https://api.github.com/users/vkolomeyko","html_url":"https://github.com/vkolomeyko","followers_url":"https://api.github.com/users/vkolomeyko/followers","following_url":"https://api.github.com/users/vkolomeyko/following{/other_user}","gists_url":"https://api.github.com/users/vkolomeyko/gists{/gist_id}","starred_url":"https://api.github.com/users/vkolomeyko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkolomeyko/subscriptions","organizations_url":"https://api.github.com/users/vkolomeyko/orgs","repos_url":"https://api.github.com/users/vkolomeyko/repos","events_url":"https://api.github.com/users/vkolomeyko/events{/privacy}","received_events_url":"https://api.github.com/users/vkolomeyko/received_events","type":"User","site_admin":false},"body":"Note: It is still possible to list every necessary package explicitly.\r\nThis is important as package name of the integration test is automatically included into list of packages to scan.\r\nE.g. In case of integration test `DistributedServiceTests` the package is `net.corda.node.services` which is quite extensive, resulting big attachments (multiple MB) to be produced\r\nand handled. This creates a notable delay in test execution.","created_at":"2018-04-06T14:20:33Z","updated_at":"2018-04-20T11:52:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2248060994801366bf8d490fc004aee31e3a00b3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Clintonio","id":474659,"avatar_url":"https://avatars2.githubusercontent.com/u/474659?v=4","gravatar_id":"","url":"https://api.github.com/users/Clintonio","html_url":"https://github.com/Clintonio","followers_url":"https://api.github.com/users/Clintonio/followers","following_url":"https://api.github.com/users/Clintonio/following{/other_user}","gists_url":"https://api.github.com/users/Clintonio/gists{/gist_id}","starred_url":"https://api.github.com/users/Clintonio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Clintonio/subscriptions","organizations_url":"https://api.github.com/users/Clintonio/orgs","repos_url":"https://api.github.com/users/Clintonio/repos","events_url":"https://api.github.com/users/Clintonio/events{/privacy}","received_events_url":"https://api.github.com/users/Clintonio/received_events","type":"User","site_admin":false},{"login":"mikehearn","id":971089,"avatar_url":"https://avatars2.githubusercontent.com/u/971089?v=4","gravatar_id":"","url":"https://api.github.com/users/mikehearn","html_url":"https://github.com/mikehearn","followers_url":"https://api.github.com/users/mikehearn/followers","following_url":"https://api.github.com/users/mikehearn/following{/other_user}","gists_url":"https://api.github.com/users/mikehearn/gists{/gist_id}","starred_url":"https://api.github.com/users/mikehearn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikehearn/subscriptions","organizations_url":"https://api.github.com/users/mikehearn/orgs","repos_url":"https://api.github.com/users/mikehearn/repos","events_url":"https://api.github.com/users/mikehearn/events{/privacy}","received_events_url":"https://api.github.com/users/mikehearn/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/corda/corda/pulls/2941/commits","review_comments_url":"https://api.github.com/repos/corda/corda/pulls/2941/comments","review_comment_url":"https://api.github.com/repos/corda/corda/pulls/comments{/number}","comments_url":"https://api.github.com/repos/corda/corda/issues/2941/comments","statuses_url":"https://api.github.com/repos/corda/corda/statuses/8271062bc90271eca9324ea653e6ef52bc7b5b4d","head":{"label":"corda:feature/vkolomeyko/CordappLoaderPerf","ref":"feature/vkolomeyko/CordappLoaderPerf","sha":"8271062bc90271eca9324ea653e6ef52bc7b5b4d","user":{"login":"corda","id":22600631,"avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"repo":{"id":70137417,"name":"corda","full_name":"corda/corda","owner":{"login":"corda","id":22600631,"avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/corda/corda","description":"Corda is a distributed ledger platform designed to record, manage and automate legal agreements between business partners. Designed by (and for) the world's largest financial institutions yet with applications in multiple industries.  It offers a unique response to the privacy and scalability challenges facing decentralised applications.","fork":false,"url":"https://api.github.com/repos/corda/corda","forks_url":"https://api.github.com/repos/corda/corda/forks","keys_url":"https://api.github.com/repos/corda/corda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/corda/corda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/corda/corda/teams","hooks_url":"https://api.github.com/repos/corda/corda/hooks","issue_events_url":"https://api.github.com/repos/corda/corda/issues/events{/number}","events_url":"https://api.github.com/repos/corda/corda/events","assignees_url":"https://api.github.com/repos/corda/corda/assignees{/user}","branches_url":"https://api.github.com/repos/corda/corda/branches{/branch}","tags_url":"https://api.github.com/repos/corda/corda/tags","blobs_url":"https://api.github.com/repos/corda/corda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/corda/corda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/corda/corda/git/refs{/sha}","trees_url":"https://api.github.com/repos/corda/corda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/corda/corda/statuses/{sha}","languages_url":"https://api.github.com/repos/corda/corda/languages","stargazers_url":"https://api.github.com/repos/corda/corda/stargazers","contributors_url":"https://api.github.com/repos/corda/corda/contributors","subscribers_url":"https://api.github.com/repos/corda/corda/subscribers","subscription_url":"https://api.github.com/repos/corda/corda/subscription","commits_url":"https://api.github.com/repos/corda/corda/commits{/sha}","git_commits_url":"https://api.github.com/repos/corda/corda/git/commits{/sha}","comments_url":"https://api.github.com/repos/corda/corda/comments{/number}","issue_comment_url":"https://api.github.com/repos/corda/corda/issues/comments{/number}","contents_url":"https://api.github.com/repos/corda/corda/contents/{+path}","compare_url":"https://api.github.com/repos/corda/corda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/corda/corda/merges","archive_url":"https://api.github.com/repos/corda/corda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/corda/corda/downloads","issues_url":"https://api.github.com/repos/corda/corda/issues{/number}","pulls_url":"https://api.github.com/repos/corda/corda/pulls{/number}","milestones_url":"https://api.github.com/repos/corda/corda/milestones{/number}","notifications_url":"https://api.github.com/repos/corda/corda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/corda/corda/labels{/name}","releases_url":"https://api.github.com/repos/corda/corda/releases{/id}","deployments_url":"https://api.github.com/repos/corda/corda/deployments","created_at":"2016-10-06T08:46:29Z","updated_at":"2018-04-20T10:07:44Z","pushed_at":"2018-04-20T10:59:45Z","git_url":"git://github.com/corda/corda.git","ssh_url":"git@github.com:corda/corda.git","clone_url":"https://github.com/corda/corda.git","svn_url":"https://github.com/corda/corda","homepage":"https://www.corda.net","size":120032,"stargazers_count":1796,"watchers_count":1796,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":470,"mirror_url":null,"archived":false,"open_issues_count":140,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":470,"open_issues":140,"watchers":1796,"default_branch":"master"}},"base":{"label":"corda:master","ref":"master","sha":"60323cca1517b94ba751c628cb829e2142b926b9","user":{"login":"corda","id":22600631,"avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"repo":{"id":70137417,"name":"corda","full_name":"corda/corda","owner":{"login":"corda","id":22600631,"avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/corda/corda","description":"Corda is a distributed ledger platform designed to record, manage and automate legal agreements between business partners. Designed by (and for) the world's largest financial institutions yet with applications in multiple industries.  It offers a unique response to the privacy and scalability challenges facing decentralised applications.","fork":false,"url":"https://api.github.com/repos/corda/corda","forks_url":"https://api.github.com/repos/corda/corda/forks","keys_url":"https://api.github.com/repos/corda/corda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/corda/corda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/corda/corda/teams","hooks_url":"https://api.github.com/repos/corda/corda/hooks","issue_events_url":"https://api.github.com/repos/corda/corda/issues/events{/number}","events_url":"https://api.github.com/repos/corda/corda/events","assignees_url":"https://api.github.com/repos/corda/corda/assignees{/user}","branches_url":"https://api.github.com/repos/corda/corda/branches{/branch}","tags_url":"https://api.github.com/repos/corda/corda/tags","blobs_url":"https://api.github.com/repos/corda/corda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/corda/corda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/corda/corda/git/refs{/sha}","trees_url":"https://api.github.com/repos/corda/corda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/corda/corda/statuses/{sha}","languages_url":"https://api.github.com/repos/corda/corda/languages","stargazers_url":"https://api.github.com/repos/corda/corda/stargazers","contributors_url":"https://api.github.com/repos/corda/corda/contributors","subscribers_url":"https://api.github.com/repos/corda/corda/subscribers","subscription_url":"https://api.github.com/repos/corda/corda/subscription","commits_url":"https://api.github.com/repos/corda/corda/commits{/sha}","git_commits_url":"https://api.github.com/repos/corda/corda/git/commits{/sha}","comments_url":"https://api.github.com/repos/corda/corda/comments{/number}","issue_comment_url":"https://api.github.com/repos/corda/corda/issues/comments{/number}","contents_url":"https://api.github.com/repos/corda/corda/contents/{+path}","compare_url":"https://api.github.com/repos/corda/corda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/corda/corda/merges","archive_url":"https://api.github.com/repos/corda/corda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/corda/corda/downloads","issues_url":"https://api.github.com/repos/corda/corda/issues{/number}","pulls_url":"https://api.github.com/repos/corda/corda/pulls{/number}","milestones_url":"https://api.github.com/repos/corda/corda/milestones{/number}","notifications_url":"https://api.github.com/repos/corda/corda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/corda/corda/labels{/name}","releases_url":"https://api.github.com/repos/corda/corda/releases{/id}","deployments_url":"https://api.github.com/repos/corda/corda/deployments","created_at":"2016-10-06T08:46:29Z","updated_at":"2018-04-20T10:07:44Z","pushed_at":"2018-04-20T10:59:45Z","git_url":"git://github.com/corda/corda.git","ssh_url":"git@github.com:corda/corda.git","clone_url":"https://github.com/corda/corda.git","svn_url":"https://github.com/corda/corda","homepage":"https://www.corda.net","size":120032,"stargazers_count":1796,"watchers_count":1796,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":470,"mirror_url":null,"archived":false,"open_issues_count":140,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":470,"open_issues":140,"watchers":1796,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/corda/corda/pulls/2941"},"html":{"href":"https://github.com/corda/corda/pull/2941"},"issue":{"href":"https://api.github.com/repos/corda/corda/issues/2941"},"comments":{"href":"https://api.github.com/repos/corda/corda/issues/2941/comments"},"review_comments":{"href":"https://api.github.com/repos/corda/corda/pulls/2941/comments"},"review_comment":{"href":"https://api.github.com/repos/corda/corda/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/corda/corda/pulls/2941/commits"},"statuses":{"href":"https://api.github.com/repos/corda/corda/statuses/8271062bc90271eca9324ea653e6ef52bc7b5b4d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vkolomeyko"}}