{"action":"created","issue":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/10819","repository_url":"https://api.github.com/repos/MarlinFirmware/Marlin","labels_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/10819/labels{/name}","comments_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/10819/comments","events_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/10819/events","html_url":"https://github.com/MarlinFirmware/Marlin/pull/10819","id":325514243,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg5ODMxNjk1","number":10819,"title":"[2.0.x] MKS Sbase Delta sample config","user":{"login":"DavidBates","id":1494603,"node_id":"MDQ6VXNlcjE0OTQ2MDM=","avatar_url":"https://avatars2.githubusercontent.com/u/1494603?v=4","gravatar_id":"","url":"https://api.github.com/users/DavidBates","html_url":"https://github.com/DavidBates","followers_url":"https://api.github.com/users/DavidBates/followers","following_url":"https://api.github.com/users/DavidBates/following{/other_user}","gists_url":"https://api.github.com/users/DavidBates/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidBates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidBates/subscriptions","organizations_url":"https://api.github.com/users/DavidBates/orgs","repos_url":"https://api.github.com/users/DavidBates/repos","events_url":"https://api.github.com/users/DavidBates/events{/privacy}","received_events_url":"https://api.github.com/users/DavidBates/received_events","type":"User","site_admin":false},"labels":[{"id":338043718,"node_id":"MDU6TGFiZWwzMzgwNDM3MTg=","url":"https://api.github.com/repos/MarlinFirmware/Marlin/labels/PR:%20Configurations","name":"PR: Configurations","color":"bfe5bf","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-05-23T01:09:14Z","updated_at":"2018-10-15T15:29:28Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/10819","html_url":"https://github.com/MarlinFirmware/Marlin/pull/10819","diff_url":"https://github.com/MarlinFirmware/Marlin/pull/10819.diff","patch_url":"https://github.com/MarlinFirmware/Marlin/pull/10819.patch"},"body":"Merged existing delta/generic and mks/sbase configs for users with Delta running MKS Sbase boards.\r\n\r\n### Requirements\r\n\r\n* Filling out this template is required. Pull Requests without a clear description may be closed at the maintainers' discretion.\r\n\r\n### Description\r\n\r\nMerged the config examples in delta/generic and mks/sbase to create a sample config for users like me with delta printers using MKS Sbase. I stayed away from putting my own printers config in and keeping it inline with the current generic delta config. \r\n\r\n### Benefits\r\n\r\nEnabling delta printer owners running MKS Sbase boards a shorter time to adopting Marlin\r\n\r\n### Related Issues\r\n\r\n<!-- Whether this fixes a bug or fulfills a feature request, please list any related Issues here. -->\r\n"},"comment":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/comments/429901009","html_url":"https://github.com/MarlinFirmware/Marlin/pull/10819#issuecomment-429901009","issue_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/10819","id":429901009,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTkwMTAwOQ==","user":{"login":"tcm0116","id":1868773,"node_id":"MDQ6VXNlcjE4Njg3NzM=","avatar_url":"https://avatars2.githubusercontent.com/u/1868773?v=4","gravatar_id":"","url":"https://api.github.com/users/tcm0116","html_url":"https://github.com/tcm0116","followers_url":"https://api.github.com/users/tcm0116/followers","following_url":"https://api.github.com/users/tcm0116/following{/other_user}","gists_url":"https://api.github.com/users/tcm0116/gists{/gist_id}","starred_url":"https://api.github.com/users/tcm0116/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcm0116/subscriptions","organizations_url":"https://api.github.com/users/tcm0116/orgs","repos_url":"https://api.github.com/users/tcm0116/repos","events_url":"https://api.github.com/users/tcm0116/events{/privacy}","received_events_url":"https://api.github.com/users/tcm0116/received_events","type":"User","site_admin":false},"created_at":"2018-10-15T15:29:28Z","updated_at":"2018-10-15T15:29:28Z","author_association":"CONTRIBUTOR","body":"While it's a bit tedious to have the printer-specific configuration files contain all of the possible options, it makes things a lot easier when upgrading Marlin to newer versions. Removing all of the unused configuration options leads to diffs with tons of differences that are time consuming to resolve. \r\n\r\nI actually think we should eliminate the generic delta configuration and merge the changes into the basic example configuration. There are a few of the differences that can be automatically handled in the Conditionals_post.h. "}}
{"actor":{"display_login":"tcm0116"}}