{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/13557","repository_url":"https://api.github.com/repos/bitcoin/bitcoin","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/13557/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/13557/comments","events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/13557/events","html_url":"https://github.com/bitcoin/bitcoin/pull/13557","id":336456382,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3OTA1MTMw","number":13557,"title":"BIP 174 PSBT Serializations and RPCs","user":{"login":"achow101","id":3782274,"node_id":"MDQ6VXNlcjM3ODIyNzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3782274?v=4","gravatar_id":"","url":"https://api.github.com/users/achow101","html_url":"https://github.com/achow101","followers_url":"https://api.github.com/users/achow101/followers","following_url":"https://api.github.com/users/achow101/following{/other_user}","gists_url":"https://api.github.com/users/achow101/gists{/gist_id}","starred_url":"https://api.github.com/users/achow101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achow101/subscriptions","organizations_url":"https://api.github.com/users/achow101/orgs","repos_url":"https://api.github.com/users/achow101/repos","events_url":"https://api.github.com/users/achow101/events{/privacy}","received_events_url":"https://api.github.com/users/achow101/received_events","type":"User","site_admin":false},"labels":[{"id":98279177,"node_id":"MDU6TGFiZWw5ODI3OTE3Nw==","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/RPC/REST/ZMQ","name":"RPC/REST/ZMQ","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-06-28T03:04:17Z","updated_at":"2018-07-05T18:00:14Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/13557","html_url":"https://github.com/bitcoin/bitcoin/pull/13557","diff_url":"https://github.com/bitcoin/bitcoin/pull/13557.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/13557.patch"},"body":"This Pull Request fully implements the [updated](https://github.com/bitcoin/bips/pull/694) BIP 174 specification. It is based upon #13425 which implements the majority of the signing logic.\r\n\r\nBIP 174 specifies a binary transaction format which contains the information necessary for a signer to produce signatures for the transaction and holds the signatures for an input while the input does not have a complete set of signatures.\r\n\r\nThis PR contains structs for PSBT, serialization, and deserialzation code. Some changes to `SignatureData` have been made to support detection of UTXO type and storing public keys.\r\n\r\n***\r\n\r\nMany RPCs have been added to handle PSBTs.\r\n\r\n`walletprocesspsbt` takes a PSBT format transaction, updates the PSBT with any inputs related to this wallet, signs, and finalizes the transaction. There is also an option to not sign and just update.\r\n\r\n`walletcreatefundedpsbt` creates a PSBT from user provided data in the same form as createrawtransaction. It also funds the transaction and takes an options argument in the same form as `fundrawtransaction`. The resulting PSBT is blank with no input or output data filled in. It is analogous to a combination of `createrawtransaction` and `fundrawtransaction`\r\n\r\n`decodepsbt` takes a PSBT and decodes it to JSON. It is analogous to `decoderawtransaction`\r\n\r\n`combinepsbt` takes multiple PSBTs for the same tx and combines them. It is analogous to `combinerawtransaction`\r\n\r\n`finalizepsbt` takes a PSBT and finalizes the inputs. If all inputs are final, it extracts the network serialized transaction and returns that instead of a PSBT unless instructed otherwise.\r\n\r\n`createpsbt` is like `createrawtransaction` but for PSBTs instead of raw transactions.\r\n\r\n`convertpsbt` takes a network serialized transaction and converts it into a psbt. The resulting psbt will lose all signature data and an explicit flag must be set to allow transactions with signature data to be converted.\r\n\r\n***\r\n\r\nThis supersedes #12136"},"comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/402805217","html_url":"https://github.com/bitcoin/bitcoin/pull/13557#issuecomment-402805217","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/13557","id":402805217,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMjgwNTIxNw==","user":{"login":"achow101","id":3782274,"node_id":"MDQ6VXNlcjM3ODIyNzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3782274?v=4","gravatar_id":"","url":"https://api.github.com/users/achow101","html_url":"https://github.com/achow101","followers_url":"https://api.github.com/users/achow101/followers","following_url":"https://api.github.com/users/achow101/following{/other_user}","gists_url":"https://api.github.com/users/achow101/gists{/gist_id}","starred_url":"https://api.github.com/users/achow101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achow101/subscriptions","organizations_url":"https://api.github.com/users/achow101/orgs","repos_url":"https://api.github.com/users/achow101/repos","events_url":"https://api.github.com/users/achow101/events{/privacy}","received_events_url":"https://api.github.com/users/achow101/received_events","type":"User","site_admin":false},"created_at":"2018-07-05T18:00:14Z","updated_at":"2018-07-05T18:00:14Z","author_association":"MEMBER","body":"Rebased onto master after #13425 was merged. Will address comments soon."}}
{"actor":{"display_login":"achow101"}}