{"action":"created","comment":{"url":"https://api.github.com/repos/eventespresso/event-espresso-core/pulls/comments/210246499","pull_request_review_id":146415699,"id":210246499,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDI0NjQ5OQ==","diff_hunk":"@@ -31,5 +30,7 @@ export const QueryLimit = ( {\n \t\t\tmax={ max }\n \t\t\tonChange={ onLimitChange }\n \t\t/>\n+\t) : (\n+\t\tnull","path":"assets/src/components/query/limit/index.js","position":33,"original_position":33,"commit_id":"7cd4c99fd50f0edfce0922bd693fe5c8c831bee5","original_commit_id":"7cd4c99fd50f0edfce0922bd693fe5c8c831bee5","user":{"login":"nerrad","id":1429108,"node_id":"MDQ6VXNlcjE0MjkxMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1429108?v=4","gravatar_id":"","url":"https://api.github.com/users/nerrad","html_url":"https://github.com/nerrad","followers_url":"https://api.github.com/users/nerrad/followers","following_url":"https://api.github.com/users/nerrad/following{/other_user}","gists_url":"https://api.github.com/users/nerrad/gists{/gist_id}","starred_url":"https://api.github.com/users/nerrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nerrad/subscriptions","organizations_url":"https://api.github.com/users/nerrad/orgs","repos_url":"https://api.github.com/users/nerrad/repos","events_url":"https://api.github.com/users/nerrad/events{/privacy}","received_events_url":"https://api.github.com/users/nerrad/received_events","type":"User","site_admin":false},"body":"I like the changes you made here to verify that onLimitChange is a function before passing along to the component, but I'm wondering whether we _need_ to do this.  When we do this type checking, there is no error in the console and thus no helpful indication for _why_ something isn't working.  So I think it may be actually more useful here if we do _no_ type checking for onChange here and simply pass it along.  If client code does not define a function for onChange then there will be an error thrown in the console with a stack trace that helps provide information about what caused the error.\r\n\r\nI would consider this similar to how we throw uncaught exceptions in php except with javascript you don't have to throw the error because it automatically happens for syntax errors.\r\n\r\nNow, if this was a prop passed through because of dynamic user facing controls I would agree its type needs to be checked.  But this is a prop passed through from actual code written so its the kind of error that would immediately surface if utilized incorrectly.\r\n\r\nIncidentally this is why I think:\r\n\r\n- WordPress GB team doesn't do extensive typechecking in their components (notice that `RangeControl` does not have type checking for `onChange`.\r\n- Many js teams use typescript or flow because it provides typechecking outside of runtime while actually writing code.  I don't think we need to go there yet because its a whole other syntax to learn and will slow our progress even more.  \r\n\r\nI'm not saying we drop type checking all-together.  I just think that for certain props passed along that are defined by code, if a console error produced by javascript would be sufficient to trace improper usage of a component then I think that should be sufficient.","created_at":"2018-08-15T12:02:58Z","updated_at":"2018-08-15T12:15:33Z","html_url":"https://github.com/eventespresso/event-espresso-core/pull/479#discussion_r210246499","pull_request_url":"https://api.github.com/repos/eventespresso/event-espresso-core/pulls/479","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/eventespresso/event-espresso-core/pulls/comments/210246499"},"html":{"href":"https://github.com/eventespresso/event-espresso-core/pull/479#discussion_r210246499"},"pull_request":{"href":"https://api.github.com/repos/eventespresso/event-espresso-core/pulls/479"}}},"pull_request":{"url":"https://api.github.com/repos/eventespresso/event-espresso-core/pulls/479","id":190634264,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwNjM0MjY0","html_url":"https://github.com/eventespresso/event-espresso-core/pull/479","diff_url":"https://github.com/eventespresso/event-espresso-core/pull/479.diff","patch_url":"https://github.com/eventespresso/event-espresso-core/pull/479.patch","issue_url":"https://api.github.com/repos/eventespresso/event-espresso-core/issues/479","number":479,"state":"open","locked":false,"title":"Gutenberg/event attendees block","user":{"login":"tn3rb","id":1751030,"node_id":"MDQ6VXNlcjE3NTEwMzA=","avatar_url":"https://avatars1.githubusercontent.com/u/1751030?v=4","gravatar_id":"","url":"https://api.github.com/users/tn3rb","html_url":"https://github.com/tn3rb","followers_url":"https://api.github.com/users/tn3rb/followers","following_url":"https://api.github.com/users/tn3rb/following{/other_user}","gists_url":"https://api.github.com/users/tn3rb/gists{/gist_id}","starred_url":"https://api.github.com/users/tn3rb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tn3rb/subscriptions","organizations_url":"https://api.github.com/users/tn3rb/orgs","repos_url":"https://api.github.com/users/tn3rb/repos","events_url":"https://api.github.com/users/tn3rb/events{/privacy}","received_events_url":"https://api.github.com/users/tn3rb/received_events","type":"User","site_admin":false},"body":"## Problem this Pull Request solves\r\nAllows discussion around the development of Gutenberg blocks\r\n","created_at":"2018-05-25T16:10:25Z","updated_at":"2018-08-15T12:15:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6b0f82011846312c0a966047aaff51efbca2dba2","assignee":{"login":"nerrad","id":1429108,"node_id":"MDQ6VXNlcjE0MjkxMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1429108?v=4","gravatar_id":"","url":"https://api.github.com/users/nerrad","html_url":"https://github.com/nerrad","followers_url":"https://api.github.com/users/nerrad/followers","following_url":"https://api.github.com/users/nerrad/following{/other_user}","gists_url":"https://api.github.com/users/nerrad/gists{/gist_id}","starred_url":"https://api.github.com/users/nerrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nerrad/subscriptions","organizations_url":"https://api.github.com/users/nerrad/orgs","repos_url":"https://api.github.com/users/nerrad/repos","events_url":"https://api.github.com/users/nerrad/events{/privacy}","received_events_url":"https://api.github.com/users/nerrad/received_events","type":"User","site_admin":false},"assignees":[{"login":"nerrad","id":1429108,"node_id":"MDQ6VXNlcjE0MjkxMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1429108?v=4","gravatar_id":"","url":"https://api.github.com/users/nerrad","html_url":"https://github.com/nerrad","followers_url":"https://api.github.com/users/nerrad/followers","following_url":"https://api.github.com/users/nerrad/following{/other_user}","gists_url":"https://api.github.com/users/nerrad/gists{/gist_id}","starred_url":"https://api.github.com/users/nerrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nerrad/subscriptions","organizations_url":"https://api.github.com/users/nerrad/orgs","repos_url":"https://api.github.com/users/nerrad/repos","events_url":"https://api.github.com/users/nerrad/events{/privacy}","received_events_url":"https://api.github.com/users/nerrad/received_events","type":"User","site_admin":false},{"login":"tn3rb","id":1751030,"node_id":"MDQ6VXNlcjE3NTEwMzA=","avatar_url":"https://avatars1.githubusercontent.com/u/1751030?v=4","gravatar_id":"","url":"https://api.github.com/users/tn3rb","html_url":"https://github.com/tn3rb","followers_url":"https://api.github.com/users/tn3rb/followers","following_url":"https://api.github.com/users/tn3rb/following{/other_user}","gists_url":"https://api.github.com/users/tn3rb/gists{/gist_id}","starred_url":"https://api.github.com/users/tn3rb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tn3rb/subscriptions","organizations_url":"https://api.github.com/users/tn3rb/orgs","repos_url":"https://api.github.com/users/tn3rb/repos","events_url":"https://api.github.com/users/tn3rb/events{/privacy}","received_events_url":"https://api.github.com/users/tn3rb/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":883825333,"node_id":"MDU6TGFiZWw4ODM4MjUzMzM=","url":"https://api.github.com/repos/eventespresso/event-espresso-core/labels/category:gutenberg","name":"category:gutenberg","color":"abc2c1","default":false},{"id":906208204,"node_id":"MDU6TGFiZWw5MDYyMDgyMDQ=","url":"https://api.github.com/repos/eventespresso/event-espresso-core/labels/status:review","name":"status:review","color":"f7d500","default":false},{"id":22687539,"node_id":"MDU6TGFiZWwyMjY4NzUzOQ==","url":"https://api.github.com/repos/eventespresso/event-espresso-core/labels/type:enhancement%20%F0%9F%8E%89","name":"type:enhancement 🎉","color":"efefef","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/eventespresso/event-espresso-core/pulls/479/commits","review_comments_url":"https://api.github.com/repos/eventespresso/event-espresso-core/pulls/479/comments","review_comment_url":"https://api.github.com/repos/eventespresso/event-espresso-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eventespresso/event-espresso-core/issues/479/comments","statuses_url":"https://api.github.com/repos/eventespresso/event-espresso-core/statuses/7cd4c99fd50f0edfce0922bd693fe5c8c831bee5","head":{"label":"eventespresso:Gutenberg/event-attendees-block","ref":"Gutenberg/event-attendees-block","sha":"7cd4c99fd50f0edfce0922bd693fe5c8c831bee5","user":{"login":"eventespresso","id":3077278,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNzcyNzg=","avatar_url":"https://avatars2.githubusercontent.com/u/3077278?v=4","gravatar_id":"","url":"https://api.github.com/users/eventespresso","html_url":"https://github.com/eventespresso","followers_url":"https://api.github.com/users/eventespresso/followers","following_url":"https://api.github.com/users/eventespresso/following{/other_user}","gists_url":"https://api.github.com/users/eventespresso/gists{/gist_id}","starred_url":"https://api.github.com/users/eventespresso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eventespresso/subscriptions","organizations_url":"https://api.github.com/users/eventespresso/orgs","repos_url":"https://api.github.com/users/eventespresso/repos","events_url":"https://api.github.com/users/eventespresso/events{/privacy}","received_events_url":"https://api.github.com/users/eventespresso/received_events","type":"Organization","site_admin":false},"repo":{"id":7252233,"node_id":"MDEwOlJlcG9zaXRvcnk3MjUyMjMz","name":"event-espresso-core","full_name":"eventespresso/event-espresso-core","owner":{"login":"eventespresso","id":3077278,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNzcyNzg=","avatar_url":"https://avatars2.githubusercontent.com/u/3077278?v=4","gravatar_id":"","url":"https://api.github.com/users/eventespresso","html_url":"https://github.com/eventespresso","followers_url":"https://api.github.com/users/eventespresso/followers","following_url":"https://api.github.com/users/eventespresso/following{/other_user}","gists_url":"https://api.github.com/users/eventespresso/gists{/gist_id}","starred_url":"https://api.github.com/users/eventespresso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eventespresso/subscriptions","organizations_url":"https://api.github.com/users/eventespresso/orgs","repos_url":"https://api.github.com/users/eventespresso/repos","events_url":"https://api.github.com/users/eventespresso/events{/privacy}","received_events_url":"https://api.github.com/users/eventespresso/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eventespresso/event-espresso-core","description":"Event Espresso 4 Core for WordPress: Build an Event Ticketing Website Today!","fork":false,"url":"https://api.github.com/repos/eventespresso/event-espresso-core","forks_url":"https://api.github.com/repos/eventespresso/event-espresso-core/forks","keys_url":"https://api.github.com/repos/eventespresso/event-espresso-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eventespresso/event-espresso-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eventespresso/event-espresso-core/teams","hooks_url":"https://api.github.com/repos/eventespresso/event-espresso-core/hooks","issue_events_url":"https://api.github.com/repos/eventespresso/event-espresso-core/issues/events{/number}","events_url":"https://api.github.com/repos/eventespresso/event-espresso-core/events","assignees_url":"https://api.github.com/repos/eventespresso/event-espresso-core/assignees{/user}","branches_url":"https://api.github.com/repos/eventespresso/event-espresso-core/branches{/branch}","tags_url":"https://api.github.com/repos/eventespresso/event-espresso-core/tags","blobs_url":"https://api.github.com/repos/eventespresso/event-espresso-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eventespresso/event-espresso-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eventespresso/event-espresso-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/eventespresso/event-espresso-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eventespresso/event-espresso-core/statuses/{sha}","languages_url":"https://api.github.com/repos/eventespresso/event-espresso-core/languages","stargazers_url":"https://api.github.com/repos/eventespresso/event-espresso-core/stargazers","contributors_url":"https://api.github.com/repos/eventespresso/event-espresso-core/contributors","subscribers_url":"https://api.github.com/repos/eventespresso/event-espresso-core/subscribers","subscription_url":"https://api.github.com/repos/eventespresso/event-espresso-core/subscription","commits_url":"https://api.github.com/repos/eventespresso/event-espresso-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/eventespresso/event-espresso-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/eventespresso/event-espresso-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/eventespresso/event-espresso-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/eventespresso/event-espresso-core/contents/{+path}","compare_url":"https://api.github.com/repos/eventespresso/event-espresso-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eventespresso/event-espresso-core/merges","archive_url":"https://api.github.com/repos/eventespresso/event-espresso-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eventespresso/event-espresso-core/downloads","issues_url":"https://api.github.com/repos/eventespresso/event-espresso-core/issues{/number}","pulls_url":"https://api.github.com/repos/eventespresso/event-espresso-core/pulls{/number}","milestones_url":"https://api.github.com/repos/eventespresso/event-espresso-core/milestones{/number}","notifications_url":"https://api.github.com/repos/eventespresso/event-espresso-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eventespresso/event-espresso-core/labels{/name}","releases_url":"https://api.github.com/repos/eventespresso/event-espresso-core/releases{/id}","deployments_url":"https://api.github.com/repos/eventespresso/event-espresso-core/deployments","created_at":"2012-12-20T04:38:57Z","updated_at":"2018-08-14T13:31:17Z","pushed_at":"2018-08-15T09:55:28Z","git_url":"git://github.com/eventespresso/event-espresso-core.git","ssh_url":"git@github.com:eventespresso/event-espresso-core.git","clone_url":"https://github.com/eventespresso/event-espresso-core.git","svn_url":"https://github.com/eventespresso/event-espresso-core","homepage":"https://eventespresso.com","size":109261,"stargazers_count":85,"watchers_count":85,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":56,"mirror_url":null,"archived":false,"open_issues_count":85,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":56,"open_issues":85,"watchers":85,"default_branch":"master"}},"base":{"label":"eventespresso:Gutenberg/master","ref":"Gutenberg/master","sha":"0cafc4737e7651ea45bacb20c39aaa343e353eee","user":{"login":"eventespresso","id":3077278,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNzcyNzg=","avatar_url":"https://avatars2.githubusercontent.com/u/3077278?v=4","gravatar_id":"","url":"https://api.github.com/users/eventespresso","html_url":"https://github.com/eventespresso","followers_url":"https://api.github.com/users/eventespresso/followers","following_url":"https://api.github.com/users/eventespresso/following{/other_user}","gists_url":"https://api.github.com/users/eventespresso/gists{/gist_id}","starred_url":"https://api.github.com/users/eventespresso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eventespresso/subscriptions","organizations_url":"https://api.github.com/users/eventespresso/orgs","repos_url":"https://api.github.com/users/eventespresso/repos","events_url":"https://api.github.com/users/eventespresso/events{/privacy}","received_events_url":"https://api.github.com/users/eventespresso/received_events","type":"Organization","site_admin":false},"repo":{"id":7252233,"node_id":"MDEwOlJlcG9zaXRvcnk3MjUyMjMz","name":"event-espresso-core","full_name":"eventespresso/event-espresso-core","owner":{"login":"eventespresso","id":3077278,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNzcyNzg=","avatar_url":"https://avatars2.githubusercontent.com/u/3077278?v=4","gravatar_id":"","url":"https://api.github.com/users/eventespresso","html_url":"https://github.com/eventespresso","followers_url":"https://api.github.com/users/eventespresso/followers","following_url":"https://api.github.com/users/eventespresso/following{/other_user}","gists_url":"https://api.github.com/users/eventespresso/gists{/gist_id}","starred_url":"https://api.github.com/users/eventespresso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eventespresso/subscriptions","organizations_url":"https://api.github.com/users/eventespresso/orgs","repos_url":"https://api.github.com/users/eventespresso/repos","events_url":"https://api.github.com/users/eventespresso/events{/privacy}","received_events_url":"https://api.github.com/users/eventespresso/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eventespresso/event-espresso-core","description":"Event Espresso 4 Core for WordPress: Build an Event Ticketing Website Today!","fork":false,"url":"https://api.github.com/repos/eventespresso/event-espresso-core","forks_url":"https://api.github.com/repos/eventespresso/event-espresso-core/forks","keys_url":"https://api.github.com/repos/eventespresso/event-espresso-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eventespresso/event-espresso-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eventespresso/event-espresso-core/teams","hooks_url":"https://api.github.com/repos/eventespresso/event-espresso-core/hooks","issue_events_url":"https://api.github.com/repos/eventespresso/event-espresso-core/issues/events{/number}","events_url":"https://api.github.com/repos/eventespresso/event-espresso-core/events","assignees_url":"https://api.github.com/repos/eventespresso/event-espresso-core/assignees{/user}","branches_url":"https://api.github.com/repos/eventespresso/event-espresso-core/branches{/branch}","tags_url":"https://api.github.com/repos/eventespresso/event-espresso-core/tags","blobs_url":"https://api.github.com/repos/eventespresso/event-espresso-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eventespresso/event-espresso-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eventespresso/event-espresso-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/eventespresso/event-espresso-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eventespresso/event-espresso-core/statuses/{sha}","languages_url":"https://api.github.com/repos/eventespresso/event-espresso-core/languages","stargazers_url":"https://api.github.com/repos/eventespresso/event-espresso-core/stargazers","contributors_url":"https://api.github.com/repos/eventespresso/event-espresso-core/contributors","subscribers_url":"https://api.github.com/repos/eventespresso/event-espresso-core/subscribers","subscription_url":"https://api.github.com/repos/eventespresso/event-espresso-core/subscription","commits_url":"https://api.github.com/repos/eventespresso/event-espresso-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/eventespresso/event-espresso-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/eventespresso/event-espresso-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/eventespresso/event-espresso-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/eventespresso/event-espresso-core/contents/{+path}","compare_url":"https://api.github.com/repos/eventespresso/event-espresso-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eventespresso/event-espresso-core/merges","archive_url":"https://api.github.com/repos/eventespresso/event-espresso-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eventespresso/event-espresso-core/downloads","issues_url":"https://api.github.com/repos/eventespresso/event-espresso-core/issues{/number}","pulls_url":"https://api.github.com/repos/eventespresso/event-espresso-core/pulls{/number}","milestones_url":"https://api.github.com/repos/eventespresso/event-espresso-core/milestones{/number}","notifications_url":"https://api.github.com/repos/eventespresso/event-espresso-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eventespresso/event-espresso-core/labels{/name}","releases_url":"https://api.github.com/repos/eventespresso/event-espresso-core/releases{/id}","deployments_url":"https://api.github.com/repos/eventespresso/event-espresso-core/deployments","created_at":"2012-12-20T04:38:57Z","updated_at":"2018-08-14T13:31:17Z","pushed_at":"2018-08-15T09:55:28Z","git_url":"git://github.com/eventespresso/event-espresso-core.git","ssh_url":"git@github.com:eventespresso/event-espresso-core.git","clone_url":"https://github.com/eventespresso/event-espresso-core.git","svn_url":"https://github.com/eventespresso/event-espresso-core","homepage":"https://eventespresso.com","size":109261,"stargazers_count":85,"watchers_count":85,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":56,"mirror_url":null,"archived":false,"open_issues_count":85,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":56,"open_issues":85,"watchers":85,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eventespresso/event-espresso-core/pulls/479"},"html":{"href":"https://github.com/eventespresso/event-espresso-core/pull/479"},"issue":{"href":"https://api.github.com/repos/eventespresso/event-espresso-core/issues/479"},"comments":{"href":"https://api.github.com/repos/eventespresso/event-espresso-core/issues/479/comments"},"review_comments":{"href":"https://api.github.com/repos/eventespresso/event-espresso-core/pulls/479/comments"},"review_comment":{"href":"https://api.github.com/repos/eventespresso/event-espresso-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eventespresso/event-espresso-core/pulls/479/commits"},"statuses":{"href":"https://api.github.com/repos/eventespresso/event-espresso-core/statuses/7cd4c99fd50f0edfce0922bd693fe5c8c831bee5"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"nerrad"}}