{"action":"created","comment":{"url":"https://api.github.com/repos/vespa-engine/vespa/pulls/comments/175814206","pull_request_review_id":105406095,"id":175814206,"diff_hunk":"@@ -27,4 +39,52 @@ PKCS10CertificationRequest getBcCsr() {\n     public X500Principal getSubject() {\n         return new X500Principal(csr.getSubject().toString());\n     }\n+\n+    public List<String> getSubjectAlternativeNames() {\n+        return getExtensions()\n+                .map(extensions -> GeneralNames.fromExtensions(extensions, Extension.subjectAlternativeName))\n+                .filter(Objects::nonNull)\n+                .flatMap(generalNames -> Arrays.stream(generalNames.getNames()))\n+                .map(Pkcs10Csr::toString)\n+                .collect(toList());\n+    }\n+\n+    /**\n+     * @return true if CA certificate\n+     */\n+    public boolean getBasicConstraints() {\n+        return getExtensions()\n+                .map(BasicConstraints::fromExtensions)\n+                .findAny()","path":"vespa-athenz/src/main/java/com/yahoo/vespa/athenz/tls/Pkcs10Csr.java","position":58,"original_position":50,"commit_id":"35e483cde7a1188ca6fc08d655036854e0b0add8","original_commit_id":"fa5f0b521fc492ca3dc46b1db5f002401ba577fc","user":{"login":"bjorncs","id":798335,"avatar_url":"https://avatars3.githubusercontent.com/u/798335?v=4","gravatar_id":"","url":"https://api.github.com/users/bjorncs","html_url":"https://github.com/bjorncs","followers_url":"https://api.github.com/users/bjorncs/followers","following_url":"https://api.github.com/users/bjorncs/following{/other_user}","gists_url":"https://api.github.com/users/bjorncs/gists{/gist_id}","starred_url":"https://api.github.com/users/bjorncs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjorncs/subscriptions","organizations_url":"https://api.github.com/users/bjorncs/orgs","repos_url":"https://api.github.com/users/bjorncs/repos","events_url":"https://api.github.com/users/bjorncs/events{/privacy}","received_events_url":"https://api.github.com/users/bjorncs/received_events","type":"User","site_admin":false},"body":"Good point. It should be `OptionaBoolean`.","created_at":"2018-03-20T15:37:06Z","updated_at":"2018-03-20T15:37:06Z","html_url":"https://github.com/vespa-engine/vespa/pull/5386#discussion_r175814206","pull_request_url":"https://api.github.com/repos/vespa-engine/vespa/pulls/5386","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/comments/175814206"},"html":{"href":"https://github.com/vespa-engine/vespa/pull/5386#discussion_r175814206"},"pull_request":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/5386"}},"in_reply_to_id":175766359},"pull_request":{"url":"https://api.github.com/repos/vespa-engine/vespa/pulls/5386","id":175928129,"html_url":"https://github.com/vespa-engine/vespa/pull/5386","diff_url":"https://github.com/vespa-engine/vespa/pull/5386.diff","patch_url":"https://github.com/vespa-engine/vespa/pull/5386.patch","issue_url":"https://api.github.com/repos/vespa-engine/vespa/issues/5386","number":5386,"state":"open","locked":false,"title":"Bjorncs/certificate builder","user":{"login":"bjorncs","id":798335,"avatar_url":"https://avatars3.githubusercontent.com/u/798335?v=4","gravatar_id":"","url":"https://api.github.com/users/bjorncs","html_url":"https://github.com/bjorncs","followers_url":"https://api.github.com/users/bjorncs/followers","following_url":"https://api.github.com/users/bjorncs/following{/other_user}","gists_url":"https://api.github.com/users/bjorncs/gists{/gist_id}","starred_url":"https://api.github.com/users/bjorncs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjorncs/subscriptions","organizations_url":"https://api.github.com/users/bjorncs/orgs","repos_url":"https://api.github.com/users/bjorncs/repos","events_url":"https://api.github.com/users/bjorncs/events{/privacy}","received_events_url":"https://api.github.com/users/bjorncs/received_events","type":"User","site_admin":false},"body":"FYI @mpolden ","created_at":"2018-03-19T15:04:32Z","updated_at":"2018-03-20T15:37:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d830417f9094eec12c3dc10286006a8d6bd3a44f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vespa-engine/vespa/pulls/5386/commits","review_comments_url":"https://api.github.com/repos/vespa-engine/vespa/pulls/5386/comments","review_comment_url":"https://api.github.com/repos/vespa-engine/vespa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vespa-engine/vespa/issues/5386/comments","statuses_url":"https://api.github.com/repos/vespa-engine/vespa/statuses/35e483cde7a1188ca6fc08d655036854e0b0add8","head":{"label":"vespa-engine:bjorncs/certificate-builder","ref":"bjorncs/certificate-builder","sha":"35e483cde7a1188ca6fc08d655036854e0b0add8","user":{"login":"vespa-engine","id":29299694,"avatar_url":"https://avatars1.githubusercontent.com/u/29299694?v=4","gravatar_id":"","url":"https://api.github.com/users/vespa-engine","html_url":"https://github.com/vespa-engine","followers_url":"https://api.github.com/users/vespa-engine/followers","following_url":"https://api.github.com/users/vespa-engine/following{/other_user}","gists_url":"https://api.github.com/users/vespa-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/vespa-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vespa-engine/subscriptions","organizations_url":"https://api.github.com/users/vespa-engine/orgs","repos_url":"https://api.github.com/users/vespa-engine/repos","events_url":"https://api.github.com/users/vespa-engine/events{/privacy}","received_events_url":"https://api.github.com/users/vespa-engine/received_events","type":"Organization","site_admin":false},"repo":{"id":60377070,"name":"vespa","full_name":"vespa-engine/vespa","owner":{"login":"vespa-engine","id":29299694,"avatar_url":"https://avatars1.githubusercontent.com/u/29299694?v=4","gravatar_id":"","url":"https://api.github.com/users/vespa-engine","html_url":"https://github.com/vespa-engine","followers_url":"https://api.github.com/users/vespa-engine/followers","following_url":"https://api.github.com/users/vespa-engine/following{/other_user}","gists_url":"https://api.github.com/users/vespa-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/vespa-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vespa-engine/subscriptions","organizations_url":"https://api.github.com/users/vespa-engine/orgs","repos_url":"https://api.github.com/users/vespa-engine/repos","events_url":"https://api.github.com/users/vespa-engine/events{/privacy}","received_events_url":"https://api.github.com/users/vespa-engine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vespa-engine/vespa","description":"Vespa - the open big data serving engine","fork":false,"url":"https://api.github.com/repos/vespa-engine/vespa","forks_url":"https://api.github.com/repos/vespa-engine/vespa/forks","keys_url":"https://api.github.com/repos/vespa-engine/vespa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vespa-engine/vespa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vespa-engine/vespa/teams","hooks_url":"https://api.github.com/repos/vespa-engine/vespa/hooks","issue_events_url":"https://api.github.com/repos/vespa-engine/vespa/issues/events{/number}","events_url":"https://api.github.com/repos/vespa-engine/vespa/events","assignees_url":"https://api.github.com/repos/vespa-engine/vespa/assignees{/user}","branches_url":"https://api.github.com/repos/vespa-engine/vespa/branches{/branch}","tags_url":"https://api.github.com/repos/vespa-engine/vespa/tags","blobs_url":"https://api.github.com/repos/vespa-engine/vespa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vespa-engine/vespa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vespa-engine/vespa/git/refs{/sha}","trees_url":"https://api.github.com/repos/vespa-engine/vespa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vespa-engine/vespa/statuses/{sha}","languages_url":"https://api.github.com/repos/vespa-engine/vespa/languages","stargazers_url":"https://api.github.com/repos/vespa-engine/vespa/stargazers","contributors_url":"https://api.github.com/repos/vespa-engine/vespa/contributors","subscribers_url":"https://api.github.com/repos/vespa-engine/vespa/subscribers","subscription_url":"https://api.github.com/repos/vespa-engine/vespa/subscription","commits_url":"https://api.github.com/repos/vespa-engine/vespa/commits{/sha}","git_commits_url":"https://api.github.com/repos/vespa-engine/vespa/git/commits{/sha}","comments_url":"https://api.github.com/repos/vespa-engine/vespa/comments{/number}","issue_comment_url":"https://api.github.com/repos/vespa-engine/vespa/issues/comments{/number}","contents_url":"https://api.github.com/repos/vespa-engine/vespa/contents/{+path}","compare_url":"https://api.github.com/repos/vespa-engine/vespa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vespa-engine/vespa/merges","archive_url":"https://api.github.com/repos/vespa-engine/vespa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vespa-engine/vespa/downloads","issues_url":"https://api.github.com/repos/vespa-engine/vespa/issues{/number}","pulls_url":"https://api.github.com/repos/vespa-engine/vespa/pulls{/number}","milestones_url":"https://api.github.com/repos/vespa-engine/vespa/milestones{/number}","notifications_url":"https://api.github.com/repos/vespa-engine/vespa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vespa-engine/vespa/labels{/name}","releases_url":"https://api.github.com/repos/vespa-engine/vespa/releases{/id}","deployments_url":"https://api.github.com/repos/vespa-engine/vespa/deployments","created_at":"2016-06-03T20:54:20Z","updated_at":"2018-03-20T15:01:44Z","pushed_at":"2018-03-20T15:30:13Z","git_url":"git://github.com/vespa-engine/vespa.git","ssh_url":"git@github.com:vespa-engine/vespa.git","clone_url":"https://github.com/vespa-engine/vespa.git","svn_url":"https://github.com/vespa-engine/vespa","homepage":"http://vespa.ai/","size":64831,"stargazers_count":2464,"watchers_count":2464,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":288,"mirror_url":null,"archived":false,"open_issues_count":42,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":288,"open_issues":42,"watchers":2464,"default_branch":"master"}},"base":{"label":"vespa-engine:master","ref":"master","sha":"c650fe2cef2548f9137e6f7c9214799de144ffc3","user":{"login":"vespa-engine","id":29299694,"avatar_url":"https://avatars1.githubusercontent.com/u/29299694?v=4","gravatar_id":"","url":"https://api.github.com/users/vespa-engine","html_url":"https://github.com/vespa-engine","followers_url":"https://api.github.com/users/vespa-engine/followers","following_url":"https://api.github.com/users/vespa-engine/following{/other_user}","gists_url":"https://api.github.com/users/vespa-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/vespa-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vespa-engine/subscriptions","organizations_url":"https://api.github.com/users/vespa-engine/orgs","repos_url":"https://api.github.com/users/vespa-engine/repos","events_url":"https://api.github.com/users/vespa-engine/events{/privacy}","received_events_url":"https://api.github.com/users/vespa-engine/received_events","type":"Organization","site_admin":false},"repo":{"id":60377070,"name":"vespa","full_name":"vespa-engine/vespa","owner":{"login":"vespa-engine","id":29299694,"avatar_url":"https://avatars1.githubusercontent.com/u/29299694?v=4","gravatar_id":"","url":"https://api.github.com/users/vespa-engine","html_url":"https://github.com/vespa-engine","followers_url":"https://api.github.com/users/vespa-engine/followers","following_url":"https://api.github.com/users/vespa-engine/following{/other_user}","gists_url":"https://api.github.com/users/vespa-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/vespa-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vespa-engine/subscriptions","organizations_url":"https://api.github.com/users/vespa-engine/orgs","repos_url":"https://api.github.com/users/vespa-engine/repos","events_url":"https://api.github.com/users/vespa-engine/events{/privacy}","received_events_url":"https://api.github.com/users/vespa-engine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vespa-engine/vespa","description":"Vespa - the open big data serving engine","fork":false,"url":"https://api.github.com/repos/vespa-engine/vespa","forks_url":"https://api.github.com/repos/vespa-engine/vespa/forks","keys_url":"https://api.github.com/repos/vespa-engine/vespa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vespa-engine/vespa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vespa-engine/vespa/teams","hooks_url":"https://api.github.com/repos/vespa-engine/vespa/hooks","issue_events_url":"https://api.github.com/repos/vespa-engine/vespa/issues/events{/number}","events_url":"https://api.github.com/repos/vespa-engine/vespa/events","assignees_url":"https://api.github.com/repos/vespa-engine/vespa/assignees{/user}","branches_url":"https://api.github.com/repos/vespa-engine/vespa/branches{/branch}","tags_url":"https://api.github.com/repos/vespa-engine/vespa/tags","blobs_url":"https://api.github.com/repos/vespa-engine/vespa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vespa-engine/vespa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vespa-engine/vespa/git/refs{/sha}","trees_url":"https://api.github.com/repos/vespa-engine/vespa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vespa-engine/vespa/statuses/{sha}","languages_url":"https://api.github.com/repos/vespa-engine/vespa/languages","stargazers_url":"https://api.github.com/repos/vespa-engine/vespa/stargazers","contributors_url":"https://api.github.com/repos/vespa-engine/vespa/contributors","subscribers_url":"https://api.github.com/repos/vespa-engine/vespa/subscribers","subscription_url":"https://api.github.com/repos/vespa-engine/vespa/subscription","commits_url":"https://api.github.com/repos/vespa-engine/vespa/commits{/sha}","git_commits_url":"https://api.github.com/repos/vespa-engine/vespa/git/commits{/sha}","comments_url":"https://api.github.com/repos/vespa-engine/vespa/comments{/number}","issue_comment_url":"https://api.github.com/repos/vespa-engine/vespa/issues/comments{/number}","contents_url":"https://api.github.com/repos/vespa-engine/vespa/contents/{+path}","compare_url":"https://api.github.com/repos/vespa-engine/vespa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vespa-engine/vespa/merges","archive_url":"https://api.github.com/repos/vespa-engine/vespa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vespa-engine/vespa/downloads","issues_url":"https://api.github.com/repos/vespa-engine/vespa/issues{/number}","pulls_url":"https://api.github.com/repos/vespa-engine/vespa/pulls{/number}","milestones_url":"https://api.github.com/repos/vespa-engine/vespa/milestones{/number}","notifications_url":"https://api.github.com/repos/vespa-engine/vespa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vespa-engine/vespa/labels{/name}","releases_url":"https://api.github.com/repos/vespa-engine/vespa/releases{/id}","deployments_url":"https://api.github.com/repos/vespa-engine/vespa/deployments","created_at":"2016-06-03T20:54:20Z","updated_at":"2018-03-20T15:01:44Z","pushed_at":"2018-03-20T15:30:13Z","git_url":"git://github.com/vespa-engine/vespa.git","ssh_url":"git@github.com:vespa-engine/vespa.git","clone_url":"https://github.com/vespa-engine/vespa.git","svn_url":"https://github.com/vespa-engine/vespa","homepage":"http://vespa.ai/","size":64831,"stargazers_count":2464,"watchers_count":2464,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":288,"mirror_url":null,"archived":false,"open_issues_count":42,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":288,"open_issues":42,"watchers":2464,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/5386"},"html":{"href":"https://github.com/vespa-engine/vespa/pull/5386"},"issue":{"href":"https://api.github.com/repos/vespa-engine/vespa/issues/5386"},"comments":{"href":"https://api.github.com/repos/vespa-engine/vespa/issues/5386/comments"},"review_comments":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/5386/comments"},"review_comment":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/5386/commits"},"statuses":{"href":"https://api.github.com/repos/vespa-engine/vespa/statuses/35e483cde7a1188ca6fc08d655036854e0b0add8"}},"author_association":"OWNER"}}
{"actor":{"display_login":"bjorncs"}}