{"action":"created","issue":{"url":"https://api.github.com/repos/apache/kafka/issues/5163","repository_url":"https://api.github.com/repos/apache/kafka","labels_url":"https://api.github.com/repos/apache/kafka/issues/5163/labels{/name}","comments_url":"https://api.github.com/repos/apache/kafka/issues/5163/comments","events_url":"https://api.github.com/repos/apache/kafka/issues/5163/events","html_url":"https://github.com/apache/kafka/pull/5163","id":330472295,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNDc1NDI4","number":5163,"title":"KAFKA-7021: Reuse source based on config","user":{"login":"guozhangwang","id":10729597,"node_id":"MDQ6VXNlcjEwNzI5NTk3","avatar_url":"https://avatars0.githubusercontent.com/u/10729597?v=4","gravatar_id":"","url":"https://api.github.com/users/guozhangwang","html_url":"https://github.com/guozhangwang","followers_url":"https://api.github.com/users/guozhangwang/followers","following_url":"https://api.github.com/users/guozhangwang/following{/other_user}","gists_url":"https://api.github.com/users/guozhangwang/gists{/gist_id}","starred_url":"https://api.github.com/users/guozhangwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guozhangwang/subscriptions","organizations_url":"https://api.github.com/users/guozhangwang/orgs","repos_url":"https://api.github.com/users/guozhangwang/repos","events_url":"https://api.github.com/users/guozhangwang/events{/privacy}","received_events_url":"https://api.github.com/users/guozhangwang/received_events","type":"User","site_admin":false},"labels":[{"id":820747028,"node_id":"MDU6TGFiZWw4MjA3NDcwMjg=","url":"https://api.github.com/repos/apache/kafka/labels/streams","name":"streams","color":"63edea","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-06-07T23:41:30Z","updated_at":"2018-06-11T23:09:01Z","closed_at":"2018-06-11T23:08:24Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/5163","html_url":"https://github.com/apache/kafka/pull/5163","diff_url":"https://github.com/apache/kafka/pull/5163.diff","patch_url":"https://github.com/apache/kafka/pull/5163.patch"},"body":"This PR actually contains two changes:\r\n\r\n1) leverage on the TOPOLOGY_OPTIMIZATION config to \"adjust\" the topology internally to reuse the source topic.\r\n\r\n2) fixed a long dangling bug that whenever source topic is reused as changelog topic, write the checkpoint file for the consumed offset, this is done by union the `ackedOffset` from the producer, plus the `consumed` offset from the consumer, note we will priori ackedOffset since the same topic may show up in both (think about repartition topic), by doing this the consumed offset from source topics can be treated as checkpointed offset when reuse happens.\r\n\r\n3) added a few unit and integration tests with / wo  the reusing, and make sure the restoration, standby task, and internal topic creation behaviors are all correct.\r\n\r\n### Committer Checklist (excluded from commit message)\r\n- [ ] Verify design and implementation \r\n- [ ] Verify test coverage and CI build status\r\n- [ ] Verify documentation (including upgrade notes)\r\n"},"comment":{"url":"https://api.github.com/repos/apache/kafka/issues/comments/396414817","html_url":"https://github.com/apache/kafka/pull/5163#issuecomment-396414817","issue_url":"https://api.github.com/repos/apache/kafka/issues/5163","id":396414817,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NjQxNDgxNw==","user":{"login":"guozhangwang","id":10729597,"node_id":"MDQ6VXNlcjEwNzI5NTk3","avatar_url":"https://avatars0.githubusercontent.com/u/10729597?v=4","gravatar_id":"","url":"https://api.github.com/users/guozhangwang","html_url":"https://github.com/guozhangwang","followers_url":"https://api.github.com/users/guozhangwang/followers","following_url":"https://api.github.com/users/guozhangwang/following{/other_user}","gists_url":"https://api.github.com/users/guozhangwang/gists{/gist_id}","starred_url":"https://api.github.com/users/guozhangwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guozhangwang/subscriptions","organizations_url":"https://api.github.com/users/guozhangwang/orgs","repos_url":"https://api.github.com/users/guozhangwang/repos","events_url":"https://api.github.com/users/guozhangwang/events{/privacy}","received_events_url":"https://api.github.com/users/guozhangwang/received_events","type":"User","site_admin":false},"created_at":"2018-06-11T23:09:01Z","updated_at":"2018-06-11T23:09:01Z","author_association":"CONTRIBUTOR","body":"Thanks for the reviews, I've merged it to trunk.\r\n\r\nWill provide a separate PR for upgrade docs, and have separate PRs for older branches."}}
{"actor":{"display_login":"guozhangwang"}}