{"action":"created","comment":{"url":"https://api.github.com/repos/aliyun/fun/pulls/comments/200810524","pull_request_review_id":135201707,"id":200810524,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDgxMDUyNA==","diff_hunk":"@@ -74,6 +74,8 @@ exports.compress = async function (func, rootDir, type) {\n };\n \n async function zipFolder(zip, folder, folders) {\n+  if (folder === '.git') {return ;}","path":"lib/zip.js","position":4,"original_position":4,"commit_id":"72bb7af90882128ad8b8cbc9d79fc2e8798f4773","original_commit_id":"72bb7af90882128ad8b8cbc9d79fc2e8798f4773","user":{"login":"vangie","id":1388582,"node_id":"MDQ6VXNlcjEzODg1ODI=","avatar_url":"https://avatars3.githubusercontent.com/u/1388582?v=4","gravatar_id":"","url":"https://api.github.com/users/vangie","html_url":"https://github.com/vangie","followers_url":"https://api.github.com/users/vangie/followers","following_url":"https://api.github.com/users/vangie/following{/other_user}","gists_url":"https://api.github.com/users/vangie/gists{/gist_id}","starred_url":"https://api.github.com/users/vangie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vangie/subscriptions","organizations_url":"https://api.github.com/users/vangie/orgs","repos_url":"https://api.github.com/users/vangie/repos","events_url":"https://api.github.com/users/vangie/events{/privacy}","received_events_url":"https://api.github.com/users/vangie/received_events","type":"User","site_admin":false},"body":"常见的 CVS 系统都支持一下吧，比如 SVN","created_at":"2018-07-07T11:57:39Z","updated_at":"2018-07-07T11:57:52Z","html_url":"https://github.com/aliyun/fun/pull/57#discussion_r200810524","pull_request_url":"https://api.github.com/repos/aliyun/fun/pulls/57","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/aliyun/fun/pulls/comments/200810524"},"html":{"href":"https://github.com/aliyun/fun/pull/57#discussion_r200810524"},"pull_request":{"href":"https://api.github.com/repos/aliyun/fun/pulls/57"}}},"pull_request":{"url":"https://api.github.com/repos/aliyun/fun/pulls/57","id":199887251,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5ODg3MjUx","html_url":"https://github.com/aliyun/fun/pull/57","diff_url":"https://github.com/aliyun/fun/pull/57.diff","patch_url":"https://github.com/aliyun/fun/pull/57.patch","issue_url":"https://api.github.com/repos/aliyun/fun/issues/57","number":57,"state":"open","locked":false,"title":"Enhance user experience","user":{"login":"tanhe123","id":4676235,"node_id":"MDQ6VXNlcjQ2NzYyMzU=","avatar_url":"https://avatars3.githubusercontent.com/u/4676235?v=4","gravatar_id":"","url":"https://api.github.com/users/tanhe123","html_url":"https://github.com/tanhe123","followers_url":"https://api.github.com/users/tanhe123/followers","following_url":"https://api.github.com/users/tanhe123/following{/other_user}","gists_url":"https://api.github.com/users/tanhe123/gists{/gist_id}","starred_url":"https://api.github.com/users/tanhe123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tanhe123/subscriptions","organizations_url":"https://api.github.com/users/tanhe123/orgs","repos_url":"https://api.github.com/users/tanhe123/repos","events_url":"https://api.github.com/users/tanhe123/events{/privacy}","received_events_url":"https://api.github.com/users/tanhe123/received_events","type":"User","site_admin":false},"body":"优化 apigateway、sls log、代码上传等方面的体验：\r\n\r\n1. api gateway 添加了 openid、description 的支持\r\n2. sls 是异步创建的，官方承诺 30 秒可用，所以加入了重试机制\r\n3. sls logstore 如果没有索引，会创建默认索引。\r\n4. 优化代码压缩，主要是两个手段：提高压缩 level 及忽略 .git \r\n5. 为 fc 调用添加 user-agent 标识","created_at":"2018-07-07T08:34:39Z","updated_at":"2018-07-07T11:57:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0e2fde7ebae729edac48b424dd248598c06c489d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"JacksonTian","id":327019,"node_id":"MDQ6VXNlcjMyNzAxOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/327019?v=4","gravatar_id":"","url":"https://api.github.com/users/JacksonTian","html_url":"https://github.com/JacksonTian","followers_url":"https://api.github.com/users/JacksonTian/followers","following_url":"https://api.github.com/users/JacksonTian/following{/other_user}","gists_url":"https://api.github.com/users/JacksonTian/gists{/gist_id}","starred_url":"https://api.github.com/users/JacksonTian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JacksonTian/subscriptions","organizations_url":"https://api.github.com/users/JacksonTian/orgs","repos_url":"https://api.github.com/users/JacksonTian/repos","events_url":"https://api.github.com/users/JacksonTian/events{/privacy}","received_events_url":"https://api.github.com/users/JacksonTian/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aliyun/fun/pulls/57/commits","review_comments_url":"https://api.github.com/repos/aliyun/fun/pulls/57/comments","review_comment_url":"https://api.github.com/repos/aliyun/fun/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aliyun/fun/issues/57/comments","statuses_url":"https://api.github.com/repos/aliyun/fun/statuses/72bb7af90882128ad8b8cbc9d79fc2e8798f4773","head":{"label":"aliyun:enhance_user_experience","ref":"enhance_user_experience","sha":"72bb7af90882128ad8b8cbc9d79fc2e8798f4773","user":{"login":"aliyun","id":941070,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0MTA3MA==","avatar_url":"https://avatars3.githubusercontent.com/u/941070?v=4","gravatar_id":"","url":"https://api.github.com/users/aliyun","html_url":"https://github.com/aliyun","followers_url":"https://api.github.com/users/aliyun/followers","following_url":"https://api.github.com/users/aliyun/following{/other_user}","gists_url":"https://api.github.com/users/aliyun/gists{/gist_id}","starred_url":"https://api.github.com/users/aliyun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aliyun/subscriptions","organizations_url":"https://api.github.com/users/aliyun/orgs","repos_url":"https://api.github.com/users/aliyun/repos","events_url":"https://api.github.com/users/aliyun/events{/privacy}","received_events_url":"https://api.github.com/users/aliyun/received_events","type":"Organization","site_admin":false},"repo":{"id":98859345,"node_id":"MDEwOlJlcG9zaXRvcnk5ODg1OTM0NQ==","name":"fun","full_name":"aliyun/fun","owner":{"login":"aliyun","id":941070,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0MTA3MA==","avatar_url":"https://avatars3.githubusercontent.com/u/941070?v=4","gravatar_id":"","url":"https://api.github.com/users/aliyun","html_url":"https://github.com/aliyun","followers_url":"https://api.github.com/users/aliyun/followers","following_url":"https://api.github.com/users/aliyun/following{/other_user}","gists_url":"https://api.github.com/users/aliyun/gists{/gist_id}","starred_url":"https://api.github.com/users/aliyun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aliyun/subscriptions","organizations_url":"https://api.github.com/users/aliyun/orgs","repos_url":"https://api.github.com/users/aliyun/repos","events_url":"https://api.github.com/users/aliyun/events{/privacy}","received_events_url":"https://api.github.com/users/aliyun/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aliyun/fun","description":"(have) Fun with Serverless(API Gateway & Function Compute)","fork":false,"url":"https://api.github.com/repos/aliyun/fun","forks_url":"https://api.github.com/repos/aliyun/fun/forks","keys_url":"https://api.github.com/repos/aliyun/fun/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aliyun/fun/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aliyun/fun/teams","hooks_url":"https://api.github.com/repos/aliyun/fun/hooks","issue_events_url":"https://api.github.com/repos/aliyun/fun/issues/events{/number}","events_url":"https://api.github.com/repos/aliyun/fun/events","assignees_url":"https://api.github.com/repos/aliyun/fun/assignees{/user}","branches_url":"https://api.github.com/repos/aliyun/fun/branches{/branch}","tags_url":"https://api.github.com/repos/aliyun/fun/tags","blobs_url":"https://api.github.com/repos/aliyun/fun/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aliyun/fun/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aliyun/fun/git/refs{/sha}","trees_url":"https://api.github.com/repos/aliyun/fun/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aliyun/fun/statuses/{sha}","languages_url":"https://api.github.com/repos/aliyun/fun/languages","stargazers_url":"https://api.github.com/repos/aliyun/fun/stargazers","contributors_url":"https://api.github.com/repos/aliyun/fun/contributors","subscribers_url":"https://api.github.com/repos/aliyun/fun/subscribers","subscription_url":"https://api.github.com/repos/aliyun/fun/subscription","commits_url":"https://api.github.com/repos/aliyun/fun/commits{/sha}","git_commits_url":"https://api.github.com/repos/aliyun/fun/git/commits{/sha}","comments_url":"https://api.github.com/repos/aliyun/fun/comments{/number}","issue_comment_url":"https://api.github.com/repos/aliyun/fun/issues/comments{/number}","contents_url":"https://api.github.com/repos/aliyun/fun/contents/{+path}","compare_url":"https://api.github.com/repos/aliyun/fun/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aliyun/fun/merges","archive_url":"https://api.github.com/repos/aliyun/fun/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aliyun/fun/downloads","issues_url":"https://api.github.com/repos/aliyun/fun/issues{/number}","pulls_url":"https://api.github.com/repos/aliyun/fun/pulls{/number}","milestones_url":"https://api.github.com/repos/aliyun/fun/milestones{/number}","notifications_url":"https://api.github.com/repos/aliyun/fun/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aliyun/fun/labels{/name}","releases_url":"https://api.github.com/repos/aliyun/fun/releases{/id}","deployments_url":"https://api.github.com/repos/aliyun/fun/deployments","created_at":"2017-07-31T07:12:41Z","updated_at":"2018-07-05T12:51:34Z","pushed_at":"2018-07-07T09:23:03Z","git_url":"git://github.com/aliyun/fun.git","ssh_url":"git@github.com:aliyun/fun.git","clone_url":"https://github.com/aliyun/fun.git","svn_url":"https://github.com/aliyun/fun","homepage":"","size":1160,"stargazers_count":79,"watchers_count":79,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":8,"open_issues":8,"watchers":79,"default_branch":"master"}},"base":{"label":"aliyun:master","ref":"master","sha":"205bbfcf28d8edf07bb4b45a903ad6d8129ba258","user":{"login":"aliyun","id":941070,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0MTA3MA==","avatar_url":"https://avatars3.githubusercontent.com/u/941070?v=4","gravatar_id":"","url":"https://api.github.com/users/aliyun","html_url":"https://github.com/aliyun","followers_url":"https://api.github.com/users/aliyun/followers","following_url":"https://api.github.com/users/aliyun/following{/other_user}","gists_url":"https://api.github.com/users/aliyun/gists{/gist_id}","starred_url":"https://api.github.com/users/aliyun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aliyun/subscriptions","organizations_url":"https://api.github.com/users/aliyun/orgs","repos_url":"https://api.github.com/users/aliyun/repos","events_url":"https://api.github.com/users/aliyun/events{/privacy}","received_events_url":"https://api.github.com/users/aliyun/received_events","type":"Organization","site_admin":false},"repo":{"id":98859345,"node_id":"MDEwOlJlcG9zaXRvcnk5ODg1OTM0NQ==","name":"fun","full_name":"aliyun/fun","owner":{"login":"aliyun","id":941070,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0MTA3MA==","avatar_url":"https://avatars3.githubusercontent.com/u/941070?v=4","gravatar_id":"","url":"https://api.github.com/users/aliyun","html_url":"https://github.com/aliyun","followers_url":"https://api.github.com/users/aliyun/followers","following_url":"https://api.github.com/users/aliyun/following{/other_user}","gists_url":"https://api.github.com/users/aliyun/gists{/gist_id}","starred_url":"https://api.github.com/users/aliyun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aliyun/subscriptions","organizations_url":"https://api.github.com/users/aliyun/orgs","repos_url":"https://api.github.com/users/aliyun/repos","events_url":"https://api.github.com/users/aliyun/events{/privacy}","received_events_url":"https://api.github.com/users/aliyun/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aliyun/fun","description":"(have) Fun with Serverless(API Gateway & Function Compute)","fork":false,"url":"https://api.github.com/repos/aliyun/fun","forks_url":"https://api.github.com/repos/aliyun/fun/forks","keys_url":"https://api.github.com/repos/aliyun/fun/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aliyun/fun/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aliyun/fun/teams","hooks_url":"https://api.github.com/repos/aliyun/fun/hooks","issue_events_url":"https://api.github.com/repos/aliyun/fun/issues/events{/number}","events_url":"https://api.github.com/repos/aliyun/fun/events","assignees_url":"https://api.github.com/repos/aliyun/fun/assignees{/user}","branches_url":"https://api.github.com/repos/aliyun/fun/branches{/branch}","tags_url":"https://api.github.com/repos/aliyun/fun/tags","blobs_url":"https://api.github.com/repos/aliyun/fun/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aliyun/fun/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aliyun/fun/git/refs{/sha}","trees_url":"https://api.github.com/repos/aliyun/fun/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aliyun/fun/statuses/{sha}","languages_url":"https://api.github.com/repos/aliyun/fun/languages","stargazers_url":"https://api.github.com/repos/aliyun/fun/stargazers","contributors_url":"https://api.github.com/repos/aliyun/fun/contributors","subscribers_url":"https://api.github.com/repos/aliyun/fun/subscribers","subscription_url":"https://api.github.com/repos/aliyun/fun/subscription","commits_url":"https://api.github.com/repos/aliyun/fun/commits{/sha}","git_commits_url":"https://api.github.com/repos/aliyun/fun/git/commits{/sha}","comments_url":"https://api.github.com/repos/aliyun/fun/comments{/number}","issue_comment_url":"https://api.github.com/repos/aliyun/fun/issues/comments{/number}","contents_url":"https://api.github.com/repos/aliyun/fun/contents/{+path}","compare_url":"https://api.github.com/repos/aliyun/fun/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aliyun/fun/merges","archive_url":"https://api.github.com/repos/aliyun/fun/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aliyun/fun/downloads","issues_url":"https://api.github.com/repos/aliyun/fun/issues{/number}","pulls_url":"https://api.github.com/repos/aliyun/fun/pulls{/number}","milestones_url":"https://api.github.com/repos/aliyun/fun/milestones{/number}","notifications_url":"https://api.github.com/repos/aliyun/fun/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aliyun/fun/labels{/name}","releases_url":"https://api.github.com/repos/aliyun/fun/releases{/id}","deployments_url":"https://api.github.com/repos/aliyun/fun/deployments","created_at":"2017-07-31T07:12:41Z","updated_at":"2018-07-05T12:51:34Z","pushed_at":"2018-07-07T09:23:03Z","git_url":"git://github.com/aliyun/fun.git","ssh_url":"git@github.com:aliyun/fun.git","clone_url":"https://github.com/aliyun/fun.git","svn_url":"https://github.com/aliyun/fun","homepage":"","size":1160,"stargazers_count":79,"watchers_count":79,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":8,"open_issues":8,"watchers":79,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aliyun/fun/pulls/57"},"html":{"href":"https://github.com/aliyun/fun/pull/57"},"issue":{"href":"https://api.github.com/repos/aliyun/fun/issues/57"},"comments":{"href":"https://api.github.com/repos/aliyun/fun/issues/57/comments"},"review_comments":{"href":"https://api.github.com/repos/aliyun/fun/pulls/57/comments"},"review_comment":{"href":"https://api.github.com/repos/aliyun/fun/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aliyun/fun/pulls/57/commits"},"statuses":{"href":"https://api.github.com/repos/aliyun/fun/statuses/72bb7af90882128ad8b8cbc9d79fc2e8798f4773"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"vangie"}}