{"action":"created","comment":{"url":"https://api.github.com/repos/hashicorp/vault/pulls/comments/210668690","pull_request_review_id":146933401,"id":210668690,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDY2ODY5MA==","diff_hunk":"@@ -23,6 +27,12 @@ func pathConfigAccess(b *backend) *framework.Path {\n \t\t\t\tType:        framework.TypeString,\n \t\t\t\tDescription: \"Token for API calls\",\n \t\t\t},\n+\n+\t\t\t\"max_token_name_length\": &framework.FieldSchema{\n+\t\t\t\tType:        framework.TypeInt,\n+\t\t\t\tDescription: \"Max length for name of generated Nomad tokens\",\n+\t\t\t\tDefault:     maxTokenNameLength,","path":"builtin/logical/nomad/path_config_access.go","position":19,"original_position":19,"commit_id":"3c3aa32967a8ee9cbddbd9d5c90ac12c4577b79c","original_commit_id":"3c3aa32967a8ee9cbddbd9d5c90ac12c4577b79c","user":{"login":"chrishoffman","id":99742,"node_id":"MDQ6VXNlcjk5NzQy","avatar_url":"https://avatars2.githubusercontent.com/u/99742?v=4","gravatar_id":"","url":"https://api.github.com/users/chrishoffman","html_url":"https://github.com/chrishoffman","followers_url":"https://api.github.com/users/chrishoffman/followers","following_url":"https://api.github.com/users/chrishoffman/following{/other_user}","gists_url":"https://api.github.com/users/chrishoffman/gists{/gist_id}","starred_url":"https://api.github.com/users/chrishoffman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrishoffman/subscriptions","organizations_url":"https://api.github.com/users/chrishoffman/orgs","repos_url":"https://api.github.com/users/chrishoffman/repos","events_url":"https://api.github.com/users/chrishoffman/events{/privacy}","received_events_url":"https://api.github.com/users/chrishoffman/received_events","type":"User","site_admin":false},"body":"I think the zero value is fine, it is the same as default.  I don't think we need to do any int pointer work. Does this api support create vs update?  If so, you should be able to handle the case where they don't provide the value and just patch the updated fields.  ","created_at":"2018-08-16T16:55:41Z","updated_at":"2018-08-16T16:55:41Z","html_url":"https://github.com/hashicorp/vault/pull/5117#discussion_r210668690","pull_request_url":"https://api.github.com/repos/hashicorp/vault/pulls/5117","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/comments/210668690"},"html":{"href":"https://github.com/hashicorp/vault/pull/5117#discussion_r210668690"},"pull_request":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/5117"}},"in_reply_to_id":210653889},"pull_request":{"url":"https://api.github.com/repos/hashicorp/vault/pulls/5117","id":208887354,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4ODg3MzU0","html_url":"https://github.com/hashicorp/vault/pull/5117","diff_url":"https://github.com/hashicorp/vault/pull/5117.diff","patch_url":"https://github.com/hashicorp/vault/pull/5117.patch","issue_url":"https://api.github.com/repos/hashicorp/vault/issues/5117","number":5117,"state":"open","locked":false,"title":"[WIP] Support custom max Nomad token name length [supersedes https://github.com/hashicorp/vault/pull/4361]","user":{"login":"catsby","id":61721,"node_id":"MDQ6VXNlcjYxNzIx","avatar_url":"https://avatars3.githubusercontent.com/u/61721?v=4","gravatar_id":"","url":"https://api.github.com/users/catsby","html_url":"https://github.com/catsby","followers_url":"https://api.github.com/users/catsby/followers","following_url":"https://api.github.com/users/catsby/following{/other_user}","gists_url":"https://api.github.com/users/catsby/gists{/gist_id}","starred_url":"https://api.github.com/users/catsby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catsby/subscriptions","organizations_url":"https://api.github.com/users/catsby/orgs","repos_url":"https://api.github.com/users/catsby/repos","events_url":"https://api.github.com/users/catsby/events{/privacy}","received_events_url":"https://api.github.com/users/catsby/received_events","type":"User","site_admin":false},"body":"Continuing https://github.com/hashicorp/vault/pull/4361 to allow users to supply a custom max length for Nomad credential token names. For Nomad version 0.8.3 and before, the max length for the *name* of the token is 64 characters. With Nomad 0.8.4+, the max length is now 256. \r\n\r\nHere we apply a default max length of 256, but allow users to override that with either the `max_token_length` attribute, or using the `NOMAD_MAX_TOKEN_LENGTH` environment variable. \r\n\r\nNOTE: I've switched the tests to use my fork of the Dockerized Nomad at [catsby/nomad](https://hub.docker.com/r/catsby/nomad/) on docker hub. The current version is 0.8.3 and I needed 0.8.4 to support the new max length. \r\n\r\nUpdating the docs now and will push when they are done. Opening this PR now for early review.","created_at":"2018-08-16T14:54:21Z","updated_at":"2018-08-16T16:55:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8bd1ea2a63a8bc961bbaea37e1dd3a31c46a8bf1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/hashicorp/vault/milestones/34","html_url":"https://github.com/hashicorp/vault/milestone/34","labels_url":"https://api.github.com/repos/hashicorp/vault/milestones/34/labels","id":3259973,"node_id":"MDk6TWlsZXN0b25lMzI1OTk3Mw==","number":34,"title":"0.11","description":"","creator":{"login":"jefferai","id":28627,"node_id":"MDQ6VXNlcjI4NjI3","avatar_url":"https://avatars0.githubusercontent.com/u/28627?v=4","gravatar_id":"","url":"https://api.github.com/users/jefferai","html_url":"https://github.com/jefferai","followers_url":"https://api.github.com/users/jefferai/followers","following_url":"https://api.github.com/users/jefferai/following{/other_user}","gists_url":"https://api.github.com/users/jefferai/gists{/gist_id}","starred_url":"https://api.github.com/users/jefferai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jefferai/subscriptions","organizations_url":"https://api.github.com/users/jefferai/orgs","repos_url":"https://api.github.com/users/jefferai/repos","events_url":"https://api.github.com/users/jefferai/events{/privacy}","received_events_url":"https://api.github.com/users/jefferai/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":19,"state":"open","created_at":"2018-04-11T19:20:02Z","updated_at":"2018-08-16T16:07:20Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/hashicorp/vault/pulls/5117/commits","review_comments_url":"https://api.github.com/repos/hashicorp/vault/pulls/5117/comments","review_comment_url":"https://api.github.com/repos/hashicorp/vault/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hashicorp/vault/issues/5117/comments","statuses_url":"https://api.github.com/repos/hashicorp/vault/statuses/3c3aa32967a8ee9cbddbd9d5c90ac12c4577b79c","head":{"label":"hashicorp:nomad-token-length","ref":"nomad-token-length","sha":"3c3aa32967a8ee9cbddbd9d5c90ac12c4577b79c","user":{"login":"hashicorp","id":761456,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MTQ1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/761456?v=4","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"repo":{"id":31288958,"node_id":"MDEwOlJlcG9zaXRvcnkzMTI4ODk1OA==","name":"vault","full_name":"hashicorp/vault","owner":{"login":"hashicorp","id":761456,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MTQ1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/761456?v=4","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hashicorp/vault","description":"A tool for secrets management, encryption as a service, and privileged access management","fork":false,"url":"https://api.github.com/repos/hashicorp/vault","forks_url":"https://api.github.com/repos/hashicorp/vault/forks","keys_url":"https://api.github.com/repos/hashicorp/vault/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hashicorp/vault/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hashicorp/vault/teams","hooks_url":"https://api.github.com/repos/hashicorp/vault/hooks","issue_events_url":"https://api.github.com/repos/hashicorp/vault/issues/events{/number}","events_url":"https://api.github.com/repos/hashicorp/vault/events","assignees_url":"https://api.github.com/repos/hashicorp/vault/assignees{/user}","branches_url":"https://api.github.com/repos/hashicorp/vault/branches{/branch}","tags_url":"https://api.github.com/repos/hashicorp/vault/tags","blobs_url":"https://api.github.com/repos/hashicorp/vault/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hashicorp/vault/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hashicorp/vault/git/refs{/sha}","trees_url":"https://api.github.com/repos/hashicorp/vault/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hashicorp/vault/statuses/{sha}","languages_url":"https://api.github.com/repos/hashicorp/vault/languages","stargazers_url":"https://api.github.com/repos/hashicorp/vault/stargazers","contributors_url":"https://api.github.com/repos/hashicorp/vault/contributors","subscribers_url":"https://api.github.com/repos/hashicorp/vault/subscribers","subscription_url":"https://api.github.com/repos/hashicorp/vault/subscription","commits_url":"https://api.github.com/repos/hashicorp/vault/commits{/sha}","git_commits_url":"https://api.github.com/repos/hashicorp/vault/git/commits{/sha}","comments_url":"https://api.github.com/repos/hashicorp/vault/comments{/number}","issue_comment_url":"https://api.github.com/repos/hashicorp/vault/issues/comments{/number}","contents_url":"https://api.github.com/repos/hashicorp/vault/contents/{+path}","compare_url":"https://api.github.com/repos/hashicorp/vault/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hashicorp/vault/merges","archive_url":"https://api.github.com/repos/hashicorp/vault/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hashicorp/vault/downloads","issues_url":"https://api.github.com/repos/hashicorp/vault/issues{/number}","pulls_url":"https://api.github.com/repos/hashicorp/vault/pulls{/number}","milestones_url":"https://api.github.com/repos/hashicorp/vault/milestones{/number}","notifications_url":"https://api.github.com/repos/hashicorp/vault/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hashicorp/vault/labels{/name}","releases_url":"https://api.github.com/repos/hashicorp/vault/releases{/id}","deployments_url":"https://api.github.com/repos/hashicorp/vault/deployments","created_at":"2015-02-25T00:15:59Z","updated_at":"2018-08-16T16:44:44Z","pushed_at":"2018-08-16T16:44:38Z","git_url":"git://github.com/hashicorp/vault.git","ssh_url":"git@github.com:hashicorp/vault.git","clone_url":"https://github.com/hashicorp/vault.git","svn_url":"https://github.com/hashicorp/vault","homepage":"https://www.vaultproject.io/","size":72365,"stargazers_count":9832,"watchers_count":9832,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1490,"mirror_url":null,"archived":false,"open_issues_count":268,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":1490,"open_issues":268,"watchers":9832,"default_branch":"master"}},"base":{"label":"hashicorp:master","ref":"master","sha":"088e73b854887f3dfa996b995e0164fca41b7f21","user":{"login":"hashicorp","id":761456,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MTQ1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/761456?v=4","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"repo":{"id":31288958,"node_id":"MDEwOlJlcG9zaXRvcnkzMTI4ODk1OA==","name":"vault","full_name":"hashicorp/vault","owner":{"login":"hashicorp","id":761456,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MTQ1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/761456?v=4","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hashicorp/vault","description":"A tool for secrets management, encryption as a service, and privileged access management","fork":false,"url":"https://api.github.com/repos/hashicorp/vault","forks_url":"https://api.github.com/repos/hashicorp/vault/forks","keys_url":"https://api.github.com/repos/hashicorp/vault/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hashicorp/vault/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hashicorp/vault/teams","hooks_url":"https://api.github.com/repos/hashicorp/vault/hooks","issue_events_url":"https://api.github.com/repos/hashicorp/vault/issues/events{/number}","events_url":"https://api.github.com/repos/hashicorp/vault/events","assignees_url":"https://api.github.com/repos/hashicorp/vault/assignees{/user}","branches_url":"https://api.github.com/repos/hashicorp/vault/branches{/branch}","tags_url":"https://api.github.com/repos/hashicorp/vault/tags","blobs_url":"https://api.github.com/repos/hashicorp/vault/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hashicorp/vault/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hashicorp/vault/git/refs{/sha}","trees_url":"https://api.github.com/repos/hashicorp/vault/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hashicorp/vault/statuses/{sha}","languages_url":"https://api.github.com/repos/hashicorp/vault/languages","stargazers_url":"https://api.github.com/repos/hashicorp/vault/stargazers","contributors_url":"https://api.github.com/repos/hashicorp/vault/contributors","subscribers_url":"https://api.github.com/repos/hashicorp/vault/subscribers","subscription_url":"https://api.github.com/repos/hashicorp/vault/subscription","commits_url":"https://api.github.com/repos/hashicorp/vault/commits{/sha}","git_commits_url":"https://api.github.com/repos/hashicorp/vault/git/commits{/sha}","comments_url":"https://api.github.com/repos/hashicorp/vault/comments{/number}","issue_comment_url":"https://api.github.com/repos/hashicorp/vault/issues/comments{/number}","contents_url":"https://api.github.com/repos/hashicorp/vault/contents/{+path}","compare_url":"https://api.github.com/repos/hashicorp/vault/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hashicorp/vault/merges","archive_url":"https://api.github.com/repos/hashicorp/vault/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hashicorp/vault/downloads","issues_url":"https://api.github.com/repos/hashicorp/vault/issues{/number}","pulls_url":"https://api.github.com/repos/hashicorp/vault/pulls{/number}","milestones_url":"https://api.github.com/repos/hashicorp/vault/milestones{/number}","notifications_url":"https://api.github.com/repos/hashicorp/vault/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hashicorp/vault/labels{/name}","releases_url":"https://api.github.com/repos/hashicorp/vault/releases{/id}","deployments_url":"https://api.github.com/repos/hashicorp/vault/deployments","created_at":"2015-02-25T00:15:59Z","updated_at":"2018-08-16T16:44:44Z","pushed_at":"2018-08-16T16:44:38Z","git_url":"git://github.com/hashicorp/vault.git","ssh_url":"git@github.com:hashicorp/vault.git","clone_url":"https://github.com/hashicorp/vault.git","svn_url":"https://github.com/hashicorp/vault","homepage":"https://www.vaultproject.io/","size":72365,"stargazers_count":9832,"watchers_count":9832,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1490,"mirror_url":null,"archived":false,"open_issues_count":268,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":1490,"open_issues":268,"watchers":9832,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/5117"},"html":{"href":"https://github.com/hashicorp/vault/pull/5117"},"issue":{"href":"https://api.github.com/repos/hashicorp/vault/issues/5117"},"comments":{"href":"https://api.github.com/repos/hashicorp/vault/issues/5117/comments"},"review_comments":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/5117/comments"},"review_comment":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/5117/commits"},"statuses":{"href":"https://api.github.com/repos/hashicorp/vault/statuses/3c3aa32967a8ee9cbddbd9d5c90ac12c4577b79c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"chrishoffman"}}