{"action":"opened","number":128,"pull_request":{"url":"https://api.github.com/repos/eiriklv/react-masonry-component/pulls/128","id":191033329,"html_url":"https://github.com/eiriklv/react-masonry-component/pull/128","diff_url":"https://github.com/eiriklv/react-masonry-component/pull/128.diff","patch_url":"https://github.com/eiriklv/react-masonry-component/pull/128.patch","issue_url":"https://api.github.com/repos/eiriklv/react-masonry-component/issues/128","number":128,"state":"open","locked":false,"title":"🐛 this.imagesLoadedCancelRef is not a function","user":{"login":"A-Tokyo","id":12428415,"avatar_url":"https://avatars1.githubusercontent.com/u/12428415?v=4","gravatar_id":"","url":"https://api.github.com/users/A-Tokyo","html_url":"https://github.com/A-Tokyo","followers_url":"https://api.github.com/users/A-Tokyo/followers","following_url":"https://api.github.com/users/A-Tokyo/following{/other_user}","gists_url":"https://api.github.com/users/A-Tokyo/gists{/gist_id}","starred_url":"https://api.github.com/users/A-Tokyo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/A-Tokyo/subscriptions","organizations_url":"https://api.github.com/users/A-Tokyo/orgs","repos_url":"https://api.github.com/users/A-Tokyo/repos","events_url":"https://api.github.com/users/A-Tokyo/events{/privacy}","received_events_url":"https://api.github.com/users/A-Tokyo/received_events","type":"User","site_admin":false},"body":"## Description\r\nWhen `disableImagesLoaded` is true, `componentWillUnmount` throws `this.imagesLoadedCancelRef is not a function`\r\n\r\n### How to reproduce\r\n- Pass `disableImagesLoaded` prop, render then unmount the component.\r\n\r\n### Fix\r\n- Only call `derefImagesLoaded` in `componentWillUnmount` if `imagesLoadedCancelRef` was truthy.\r\n\r\n<img width=\"556\" alt=\"screen shot 2018-05-29 at 6 58 51 am\" src=\"https://user-images.githubusercontent.com/12428415/40638815-cc2cba92-630d-11e8-9407-552783509e82.png\">\r\n","created_at":"2018-05-29T05:00:43Z","updated_at":"2018-05-29T05:00:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/eiriklv/react-masonry-component/pulls/128/commits","review_comments_url":"https://api.github.com/repos/eiriklv/react-masonry-component/pulls/128/comments","review_comment_url":"https://api.github.com/repos/eiriklv/react-masonry-component/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eiriklv/react-masonry-component/issues/128/comments","statuses_url":"https://api.github.com/repos/eiriklv/react-masonry-component/statuses/2b64618734639698d313cbde9ae3896b5a46747d","head":{"label":"A-Tokyo:hotfix/imagesLoadedCancelRef","ref":"hotfix/imagesLoadedCancelRef","sha":"2b64618734639698d313cbde9ae3896b5a46747d","user":{"login":"A-Tokyo","id":12428415,"avatar_url":"https://avatars1.githubusercontent.com/u/12428415?v=4","gravatar_id":"","url":"https://api.github.com/users/A-Tokyo","html_url":"https://github.com/A-Tokyo","followers_url":"https://api.github.com/users/A-Tokyo/followers","following_url":"https://api.github.com/users/A-Tokyo/following{/other_user}","gists_url":"https://api.github.com/users/A-Tokyo/gists{/gist_id}","starred_url":"https://api.github.com/users/A-Tokyo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/A-Tokyo/subscriptions","organizations_url":"https://api.github.com/users/A-Tokyo/orgs","repos_url":"https://api.github.com/users/A-Tokyo/repos","events_url":"https://api.github.com/users/A-Tokyo/events{/privacy}","received_events_url":"https://api.github.com/users/A-Tokyo/received_events","type":"User","site_admin":false},"repo":{"id":135242873,"name":"react-masonry-component","full_name":"A-Tokyo/react-masonry-component","owner":{"login":"A-Tokyo","id":12428415,"avatar_url":"https://avatars1.githubusercontent.com/u/12428415?v=4","gravatar_id":"","url":"https://api.github.com/users/A-Tokyo","html_url":"https://github.com/A-Tokyo","followers_url":"https://api.github.com/users/A-Tokyo/followers","following_url":"https://api.github.com/users/A-Tokyo/following{/other_user}","gists_url":"https://api.github.com/users/A-Tokyo/gists{/gist_id}","starred_url":"https://api.github.com/users/A-Tokyo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/A-Tokyo/subscriptions","organizations_url":"https://api.github.com/users/A-Tokyo/orgs","repos_url":"https://api.github.com/users/A-Tokyo/repos","events_url":"https://api.github.com/users/A-Tokyo/events{/privacy}","received_events_url":"https://api.github.com/users/A-Tokyo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/A-Tokyo/react-masonry-component","description":"A React.js component for using @desandro's Masonry","fork":true,"url":"https://api.github.com/repos/A-Tokyo/react-masonry-component","forks_url":"https://api.github.com/repos/A-Tokyo/react-masonry-component/forks","keys_url":"https://api.github.com/repos/A-Tokyo/react-masonry-component/keys{/key_id}","collaborators_url":"https://api.github.com/repos/A-Tokyo/react-masonry-component/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/A-Tokyo/react-masonry-component/teams","hooks_url":"https://api.github.com/repos/A-Tokyo/react-masonry-component/hooks","issue_events_url":"https://api.github.com/repos/A-Tokyo/react-masonry-component/issues/events{/number}","events_url":"https://api.github.com/repos/A-Tokyo/react-masonry-component/events","assignees_url":"https://api.github.com/repos/A-Tokyo/react-masonry-component/assignees{/user}","branches_url":"https://api.github.com/repos/A-Tokyo/react-masonry-component/branches{/branch}","tags_url":"https://api.github.com/repos/A-Tokyo/react-masonry-component/tags","blobs_url":"https://api.github.com/repos/A-Tokyo/react-masonry-component/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/A-Tokyo/react-masonry-component/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/A-Tokyo/react-masonry-component/git/refs{/sha}","trees_url":"https://api.github.com/repos/A-Tokyo/react-masonry-component/git/trees{/sha}","statuses_url":"https://api.github.com/repos/A-Tokyo/react-masonry-component/statuses/{sha}","languages_url":"https://api.github.com/repos/A-Tokyo/react-masonry-component/languages","stargazers_url":"https://api.github.com/repos/A-Tokyo/react-masonry-component/stargazers","contributors_url":"https://api.github.com/repos/A-Tokyo/react-masonry-component/contributors","subscribers_url":"https://api.github.com/repos/A-Tokyo/react-masonry-component/subscribers","subscription_url":"https://api.github.com/repos/A-Tokyo/react-masonry-component/subscription","commits_url":"https://api.github.com/repos/A-Tokyo/react-masonry-component/commits{/sha}","git_commits_url":"https://api.github.com/repos/A-Tokyo/react-masonry-component/git/commits{/sha}","comments_url":"https://api.github.com/repos/A-Tokyo/react-masonry-component/comments{/number}","issue_comment_url":"https://api.github.com/repos/A-Tokyo/react-masonry-component/issues/comments{/number}","contents_url":"https://api.github.com/repos/A-Tokyo/react-masonry-component/contents/{+path}","compare_url":"https://api.github.com/repos/A-Tokyo/react-masonry-component/compare/{base}...{head}","merges_url":"https://api.github.com/repos/A-Tokyo/react-masonry-component/merges","archive_url":"https://api.github.com/repos/A-Tokyo/react-masonry-component/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/A-Tokyo/react-masonry-component/downloads","issues_url":"https://api.github.com/repos/A-Tokyo/react-masonry-component/issues{/number}","pulls_url":"https://api.github.com/repos/A-Tokyo/react-masonry-component/pulls{/number}","milestones_url":"https://api.github.com/repos/A-Tokyo/react-masonry-component/milestones{/number}","notifications_url":"https://api.github.com/repos/A-Tokyo/react-masonry-component/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/A-Tokyo/react-masonry-component/labels{/name}","releases_url":"https://api.github.com/repos/A-Tokyo/react-masonry-component/releases{/id}","deployments_url":"https://api.github.com/repos/A-Tokyo/react-masonry-component/deployments","created_at":"2018-05-29T04:55:15Z","updated_at":"2018-05-29T04:55:16Z","pushed_at":"2018-05-29T04:57:12Z","git_url":"git://github.com/A-Tokyo/react-masonry-component.git","ssh_url":"git@github.com:A-Tokyo/react-masonry-component.git","clone_url":"https://github.com/A-Tokyo/react-masonry-component.git","svn_url":"https://github.com/A-Tokyo/react-masonry-component","homepage":"","size":364,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eiriklv:master","ref":"master","sha":"9044631f9b84c317b5311e374ab818a7e3a20092","user":{"login":"eiriklv","id":3486317,"avatar_url":"https://avatars3.githubusercontent.com/u/3486317?v=4","gravatar_id":"","url":"https://api.github.com/users/eiriklv","html_url":"https://github.com/eiriklv","followers_url":"https://api.github.com/users/eiriklv/followers","following_url":"https://api.github.com/users/eiriklv/following{/other_user}","gists_url":"https://api.github.com/users/eiriklv/gists{/gist_id}","starred_url":"https://api.github.com/users/eiriklv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eiriklv/subscriptions","organizations_url":"https://api.github.com/users/eiriklv/orgs","repos_url":"https://api.github.com/users/eiriklv/repos","events_url":"https://api.github.com/users/eiriklv/events{/privacy}","received_events_url":"https://api.github.com/users/eiriklv/received_events","type":"User","site_admin":false},"repo":{"id":39904885,"name":"react-masonry-component","full_name":"eiriklv/react-masonry-component","owner":{"login":"eiriklv","id":3486317,"avatar_url":"https://avatars3.githubusercontent.com/u/3486317?v=4","gravatar_id":"","url":"https://api.github.com/users/eiriklv","html_url":"https://github.com/eiriklv","followers_url":"https://api.github.com/users/eiriklv/followers","following_url":"https://api.github.com/users/eiriklv/following{/other_user}","gists_url":"https://api.github.com/users/eiriklv/gists{/gist_id}","starred_url":"https://api.github.com/users/eiriklv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eiriklv/subscriptions","organizations_url":"https://api.github.com/users/eiriklv/orgs","repos_url":"https://api.github.com/users/eiriklv/repos","events_url":"https://api.github.com/users/eiriklv/events{/privacy}","received_events_url":"https://api.github.com/users/eiriklv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eiriklv/react-masonry-component","description":"A React.js component for using @desandro's Masonry","fork":false,"url":"https://api.github.com/repos/eiriklv/react-masonry-component","forks_url":"https://api.github.com/repos/eiriklv/react-masonry-component/forks","keys_url":"https://api.github.com/repos/eiriklv/react-masonry-component/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eiriklv/react-masonry-component/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eiriklv/react-masonry-component/teams","hooks_url":"https://api.github.com/repos/eiriklv/react-masonry-component/hooks","issue_events_url":"https://api.github.com/repos/eiriklv/react-masonry-component/issues/events{/number}","events_url":"https://api.github.com/repos/eiriklv/react-masonry-component/events","assignees_url":"https://api.github.com/repos/eiriklv/react-masonry-component/assignees{/user}","branches_url":"https://api.github.com/repos/eiriklv/react-masonry-component/branches{/branch}","tags_url":"https://api.github.com/repos/eiriklv/react-masonry-component/tags","blobs_url":"https://api.github.com/repos/eiriklv/react-masonry-component/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eiriklv/react-masonry-component/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eiriklv/react-masonry-component/git/refs{/sha}","trees_url":"https://api.github.com/repos/eiriklv/react-masonry-component/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eiriklv/react-masonry-component/statuses/{sha}","languages_url":"https://api.github.com/repos/eiriklv/react-masonry-component/languages","stargazers_url":"https://api.github.com/repos/eiriklv/react-masonry-component/stargazers","contributors_url":"https://api.github.com/repos/eiriklv/react-masonry-component/contributors","subscribers_url":"https://api.github.com/repos/eiriklv/react-masonry-component/subscribers","subscription_url":"https://api.github.com/repos/eiriklv/react-masonry-component/subscription","commits_url":"https://api.github.com/repos/eiriklv/react-masonry-component/commits{/sha}","git_commits_url":"https://api.github.com/repos/eiriklv/react-masonry-component/git/commits{/sha}","comments_url":"https://api.github.com/repos/eiriklv/react-masonry-component/comments{/number}","issue_comment_url":"https://api.github.com/repos/eiriklv/react-masonry-component/issues/comments{/number}","contents_url":"https://api.github.com/repos/eiriklv/react-masonry-component/contents/{+path}","compare_url":"https://api.github.com/repos/eiriklv/react-masonry-component/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eiriklv/react-masonry-component/merges","archive_url":"https://api.github.com/repos/eiriklv/react-masonry-component/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eiriklv/react-masonry-component/downloads","issues_url":"https://api.github.com/repos/eiriklv/react-masonry-component/issues{/number}","pulls_url":"https://api.github.com/repos/eiriklv/react-masonry-component/pulls{/number}","milestones_url":"https://api.github.com/repos/eiriklv/react-masonry-component/milestones{/number}","notifications_url":"https://api.github.com/repos/eiriklv/react-masonry-component/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eiriklv/react-masonry-component/labels{/name}","releases_url":"https://api.github.com/repos/eiriklv/react-masonry-component/releases{/id}","deployments_url":"https://api.github.com/repos/eiriklv/react-masonry-component/deployments","created_at":"2015-07-29T16:46:18Z","updated_at":"2018-05-28T15:28:37Z","pushed_at":"2018-05-03T03:09:06Z","git_url":"git://github.com/eiriklv/react-masonry-component.git","ssh_url":"git@github.com:eiriklv/react-masonry-component.git","clone_url":"https://github.com/eiriklv/react-masonry-component.git","svn_url":"https://github.com/eiriklv/react-masonry-component","homepage":"","size":364,"stargazers_count":799,"watchers_count":799,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":97,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":97,"open_issues":30,"watchers":799,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eiriklv/react-masonry-component/pulls/128"},"html":{"href":"https://github.com/eiriklv/react-masonry-component/pull/128"},"issue":{"href":"https://api.github.com/repos/eiriklv/react-masonry-component/issues/128"},"comments":{"href":"https://api.github.com/repos/eiriklv/react-masonry-component/issues/128/comments"},"review_comments":{"href":"https://api.github.com/repos/eiriklv/react-masonry-component/pulls/128/comments"},"review_comment":{"href":"https://api.github.com/repos/eiriklv/react-masonry-component/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eiriklv/react-masonry-component/pulls/128/commits"},"statuses":{"href":"https://api.github.com/repos/eiriklv/react-masonry-component/statuses/2b64618734639698d313cbde9ae3896b5a46747d"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":3,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"A-Tokyo"}}