{"action":"created","comment":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments/230484585","pull_request_review_id":171241578,"id":230484585,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDQ4NDU4NQ==","diff_hunk":"@@ -2,6 +2,6 @@\n <packages>\n   <package id=\"Greg\" version=\"1.0.6176.18754\" targetFramework=\"net45\" />\n   <package id=\"Newtonsoft.Json\" version=\"8.0.3\" targetFramework=\"net45\" />\n-  <package id=\"RestSharp\" version=\"105.2.3\" targetFramework=\"net45\" />\n+  <package id=\"RestSharp\" version=\"105.2.3\" targetFramework=\"net45\" requireReinstallation=\"true\" />","path":"src/DynamoCore/packages.config","position":5,"original_position":5,"commit_id":"3a39cb7cb3aa305d12d18c1fab9c29fbdc9b80d9","original_commit_id":"3a39cb7cb3aa305d12d18c1fab9c29fbdc9b80d9","user":{"login":"mjkkirschner","id":508936,"node_id":"MDQ6VXNlcjUwODkzNg==","avatar_url":"https://avatars3.githubusercontent.com/u/508936?v=4","gravatar_id":"","url":"https://api.github.com/users/mjkkirschner","html_url":"https://github.com/mjkkirschner","followers_url":"https://api.github.com/users/mjkkirschner/followers","following_url":"https://api.github.com/users/mjkkirschner/following{/other_user}","gists_url":"https://api.github.com/users/mjkkirschner/gists{/gist_id}","starred_url":"https://api.github.com/users/mjkkirschner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjkkirschner/subscriptions","organizations_url":"https://api.github.com/users/mjkkirschner/orgs","repos_url":"https://api.github.com/users/mjkkirschner/repos","events_url":"https://api.github.com/users/mjkkirschner/events{/privacy}","received_events_url":"https://api.github.com/users/mjkkirschner/received_events","type":"User","site_admin":false},"body":"I think it has to do with how restSharp used to have multiple targets but then moved them all to a net45 folder. But I'm not sure.","created_at":"2018-11-02T19:31:35Z","updated_at":"2018-11-02T19:31:36Z","html_url":"https://github.com/DynamoDS/Dynamo/pull/9174#discussion_r230484585","pull_request_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/9174","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments/230484585"},"html":{"href":"https://github.com/DynamoDS/Dynamo/pull/9174#discussion_r230484585"},"pull_request":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/9174"}},"in_reply_to_id":230477567},"pull_request":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/9174","id":222584073,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNTg0MDcz","html_url":"https://github.com/DynamoDS/Dynamo/pull/9174","diff_url":"https://github.com/DynamoDS/Dynamo/pull/9174.diff","patch_url":"https://github.com/DynamoDS/Dynamo/pull/9174.patch","issue_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/9174","number":9174,"state":"open","locked":false,"title":"update to .Net4.7","user":{"login":"mjkkirschner","id":508936,"node_id":"MDQ6VXNlcjUwODkzNg==","avatar_url":"https://avatars3.githubusercontent.com/u/508936?v=4","gravatar_id":"","url":"https://api.github.com/users/mjkkirschner","html_url":"https://github.com/mjkkirschner","followers_url":"https://api.github.com/users/mjkkirschner/followers","following_url":"https://api.github.com/users/mjkkirschner/following{/other_user}","gists_url":"https://api.github.com/users/mjkkirschner/gists{/gist_id}","starred_url":"https://api.github.com/users/mjkkirschner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjkkirschner/subscriptions","organizations_url":"https://api.github.com/users/mjkkirschner/orgs","repos_url":"https://api.github.com/users/mjkkirschner/repos","events_url":"https://api.github.com/users/mjkkirschner/events{/privacy}","received_events_url":"https://api.github.com/users/mjkkirschner/received_events","type":"User","site_admin":false},"body":"### Purpose\r\n\r\n- [x] update target framework version\r\n- [x] run tests\r\n- [ ] consider adding .netstandard nuget package and prebuild copy step.\r\n- [ ] improve TLS story in referenced dlls or file task for this\r\n- [x] research DynamoRevit implications (likely minimal)\r\n- [ ] research package implications\r\n- [ ] research any nugets needing updates?\r\n- [x] build machine updates?\r\n\r\n### Declarations\r\n\r\nCheck these if you believe they are true\r\n\r\n- [ ] The code base is in a better state after this PR\r\n- [ ] Is documented according to the [standards](https://github.com/DynamoDS/Dynamo/wiki/Coding-Standards)\r\n- [ ] The level of testing this PR includes is appropriate\r\n- [ ] User facing strings, if any, are extracted into `*.resx` files\r\n- [ ] All tests pass using the self-service CI.\r\n- [ ] Snapshot of UI changes, if any.\r\n- [ ] Changes to the API follow [Semantic Versioning](https://github.com/DynamoDS/Dynamo/wiki/Dynamo-Versions), and are documented in the [API Changes](https://github.com/DynamoDS/Dynamo/wiki/API-Changes) document.\r\n\r\n### Reviewers\r\n\r\n@alfarok \r\n@ColinDayOrg \r\n### FYIs\r\n\r\n@QilongTang @smangarole ","created_at":"2018-10-12T20:55:49Z","updated_at":"2018-11-02T19:31:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3089c21c26814fff6235c4f0049120ddb92bab20","assignee":null,"assignees":[],"requested_reviewers":[{"login":"QilongTang","id":3942418,"node_id":"MDQ6VXNlcjM5NDI0MTg=","avatar_url":"https://avatars2.githubusercontent.com/u/3942418?v=4","gravatar_id":"","url":"https://api.github.com/users/QilongTang","html_url":"https://github.com/QilongTang","followers_url":"https://api.github.com/users/QilongTang/followers","following_url":"https://api.github.com/users/QilongTang/following{/other_user}","gists_url":"https://api.github.com/users/QilongTang/gists{/gist_id}","starred_url":"https://api.github.com/users/QilongTang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QilongTang/subscriptions","organizations_url":"https://api.github.com/users/QilongTang/orgs","repos_url":"https://api.github.com/users/QilongTang/repos","events_url":"https://api.github.com/users/QilongTang/events{/privacy}","received_events_url":"https://api.github.com/users/QilongTang/received_events","type":"User","site_admin":false},{"login":"ColinDayOrg","id":10959111,"node_id":"MDQ6VXNlcjEwOTU5MTEx","avatar_url":"https://avatars0.githubusercontent.com/u/10959111?v=4","gravatar_id":"","url":"https://api.github.com/users/ColinDayOrg","html_url":"https://github.com/ColinDayOrg","followers_url":"https://api.github.com/users/ColinDayOrg/followers","following_url":"https://api.github.com/users/ColinDayOrg/following{/other_user}","gists_url":"https://api.github.com/users/ColinDayOrg/gists{/gist_id}","starred_url":"https://api.github.com/users/ColinDayOrg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ColinDayOrg/subscriptions","organizations_url":"https://api.github.com/users/ColinDayOrg/orgs","repos_url":"https://api.github.com/users/ColinDayOrg/repos","events_url":"https://api.github.com/users/ColinDayOrg/events{/privacy}","received_events_url":"https://api.github.com/users/ColinDayOrg/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1056947173,"node_id":"MDU6TGFiZWwxMDU2OTQ3MTcz","url":"https://api.github.com/repos/DynamoDS/Dynamo/labels/2.x","name":"2.x","color":"BDD684","default":false},{"id":207906980,"node_id":"MDU6TGFiZWwyMDc5MDY5ODA=","url":"https://api.github.com/repos/DynamoDS/Dynamo/labels/PTAL","name":"PTAL","color":"207de5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/9174/commits","review_comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/9174/comments","review_comment_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/9174/comments","statuses_url":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/3a39cb7cb3aa305d12d18c1fab9c29fbdc9b80d9","head":{"label":"mjkkirschner:updateNET47","ref":"updateNET47","sha":"3a39cb7cb3aa305d12d18c1fab9c29fbdc9b80d9","user":{"login":"mjkkirschner","id":508936,"node_id":"MDQ6VXNlcjUwODkzNg==","avatar_url":"https://avatars3.githubusercontent.com/u/508936?v=4","gravatar_id":"","url":"https://api.github.com/users/mjkkirschner","html_url":"https://github.com/mjkkirschner","followers_url":"https://api.github.com/users/mjkkirschner/followers","following_url":"https://api.github.com/users/mjkkirschner/following{/other_user}","gists_url":"https://api.github.com/users/mjkkirschner/gists{/gist_id}","starred_url":"https://api.github.com/users/mjkkirschner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjkkirschner/subscriptions","organizations_url":"https://api.github.com/users/mjkkirschner/orgs","repos_url":"https://api.github.com/users/mjkkirschner/repos","events_url":"https://api.github.com/users/mjkkirschner/events{/privacy}","received_events_url":"https://api.github.com/users/mjkkirschner/received_events","type":"User","site_admin":false},"repo":{"id":14159492,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE1OTQ5Mg==","name":"Dynamo","full_name":"mjkkirschner/Dynamo","private":false,"owner":{"login":"mjkkirschner","id":508936,"node_id":"MDQ6VXNlcjUwODkzNg==","avatar_url":"https://avatars3.githubusercontent.com/u/508936?v=4","gravatar_id":"","url":"https://api.github.com/users/mjkkirschner","html_url":"https://github.com/mjkkirschner","followers_url":"https://api.github.com/users/mjkkirschner/followers","following_url":"https://api.github.com/users/mjkkirschner/following{/other_user}","gists_url":"https://api.github.com/users/mjkkirschner/gists{/gist_id}","starred_url":"https://api.github.com/users/mjkkirschner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjkkirschner/subscriptions","organizations_url":"https://api.github.com/users/mjkkirschner/orgs","repos_url":"https://api.github.com/users/mjkkirschner/repos","events_url":"https://api.github.com/users/mjkkirschner/events{/privacy}","received_events_url":"https://api.github.com/users/mjkkirschner/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mjkkirschner/Dynamo","description":"Visual Programming For Revit","fork":true,"url":"https://api.github.com/repos/mjkkirschner/Dynamo","forks_url":"https://api.github.com/repos/mjkkirschner/Dynamo/forks","keys_url":"https://api.github.com/repos/mjkkirschner/Dynamo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mjkkirschner/Dynamo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mjkkirschner/Dynamo/teams","hooks_url":"https://api.github.com/repos/mjkkirschner/Dynamo/hooks","issue_events_url":"https://api.github.com/repos/mjkkirschner/Dynamo/issues/events{/number}","events_url":"https://api.github.com/repos/mjkkirschner/Dynamo/events","assignees_url":"https://api.github.com/repos/mjkkirschner/Dynamo/assignees{/user}","branches_url":"https://api.github.com/repos/mjkkirschner/Dynamo/branches{/branch}","tags_url":"https://api.github.com/repos/mjkkirschner/Dynamo/tags","blobs_url":"https://api.github.com/repos/mjkkirschner/Dynamo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mjkkirschner/Dynamo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mjkkirschner/Dynamo/git/refs{/sha}","trees_url":"https://api.github.com/repos/mjkkirschner/Dynamo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mjkkirschner/Dynamo/statuses/{sha}","languages_url":"https://api.github.com/repos/mjkkirschner/Dynamo/languages","stargazers_url":"https://api.github.com/repos/mjkkirschner/Dynamo/stargazers","contributors_url":"https://api.github.com/repos/mjkkirschner/Dynamo/contributors","subscribers_url":"https://api.github.com/repos/mjkkirschner/Dynamo/subscribers","subscription_url":"https://api.github.com/repos/mjkkirschner/Dynamo/subscription","commits_url":"https://api.github.com/repos/mjkkirschner/Dynamo/commits{/sha}","git_commits_url":"https://api.github.com/repos/mjkkirschner/Dynamo/git/commits{/sha}","comments_url":"https://api.github.com/repos/mjkkirschner/Dynamo/comments{/number}","issue_comment_url":"https://api.github.com/repos/mjkkirschner/Dynamo/issues/comments{/number}","contents_url":"https://api.github.com/repos/mjkkirschner/Dynamo/contents/{+path}","compare_url":"https://api.github.com/repos/mjkkirschner/Dynamo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mjkkirschner/Dynamo/merges","archive_url":"https://api.github.com/repos/mjkkirschner/Dynamo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mjkkirschner/Dynamo/downloads","issues_url":"https://api.github.com/repos/mjkkirschner/Dynamo/issues{/number}","pulls_url":"https://api.github.com/repos/mjkkirschner/Dynamo/pulls{/number}","milestones_url":"https://api.github.com/repos/mjkkirschner/Dynamo/milestones{/number}","notifications_url":"https://api.github.com/repos/mjkkirschner/Dynamo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mjkkirschner/Dynamo/labels{/name}","releases_url":"https://api.github.com/repos/mjkkirschner/Dynamo/releases{/id}","deployments_url":"https://api.github.com/repos/mjkkirschner/Dynamo/deployments","created_at":"2013-11-06T01:18:42Z","updated_at":"2015-01-20T19:30:58Z","pushed_at":"2018-11-02T18:47:10Z","git_url":"git://github.com/mjkkirschner/Dynamo.git","ssh_url":"git@github.com:mjkkirschner/Dynamo.git","clone_url":"https://github.com/mjkkirschner/Dynamo.git","svn_url":"https://github.com/mjkkirschner/Dynamo","homepage":"http://dynamobim.org","size":1141334,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DynamoDS:master","ref":"master","sha":"5083f3442efbd7ea1f6a16f465afd5c89685deca","user":{"login":"DynamoDS","id":6528209,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1MjgyMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/6528209?v=4","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"repo":{"id":3395179,"node_id":"MDEwOlJlcG9zaXRvcnkzMzk1MTc5","name":"Dynamo","full_name":"DynamoDS/Dynamo","private":false,"owner":{"login":"DynamoDS","id":6528209,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1MjgyMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/6528209?v=4","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DynamoDS/Dynamo","description":"Open Source Graphical Programming for Design","fork":false,"url":"https://api.github.com/repos/DynamoDS/Dynamo","forks_url":"https://api.github.com/repos/DynamoDS/Dynamo/forks","keys_url":"https://api.github.com/repos/DynamoDS/Dynamo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DynamoDS/Dynamo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DynamoDS/Dynamo/teams","hooks_url":"https://api.github.com/repos/DynamoDS/Dynamo/hooks","issue_events_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/events{/number}","events_url":"https://api.github.com/repos/DynamoDS/Dynamo/events","assignees_url":"https://api.github.com/repos/DynamoDS/Dynamo/assignees{/user}","branches_url":"https://api.github.com/repos/DynamoDS/Dynamo/branches{/branch}","tags_url":"https://api.github.com/repos/DynamoDS/Dynamo/tags","blobs_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/refs{/sha}","trees_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/{sha}","languages_url":"https://api.github.com/repos/DynamoDS/Dynamo/languages","stargazers_url":"https://api.github.com/repos/DynamoDS/Dynamo/stargazers","contributors_url":"https://api.github.com/repos/DynamoDS/Dynamo/contributors","subscribers_url":"https://api.github.com/repos/DynamoDS/Dynamo/subscribers","subscription_url":"https://api.github.com/repos/DynamoDS/Dynamo/subscription","commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/commits{/sha}","git_commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/commits{/sha}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/comments{/number}","issue_comment_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/comments{/number}","contents_url":"https://api.github.com/repos/DynamoDS/Dynamo/contents/{+path}","compare_url":"https://api.github.com/repos/DynamoDS/Dynamo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DynamoDS/Dynamo/merges","archive_url":"https://api.github.com/repos/DynamoDS/Dynamo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DynamoDS/Dynamo/downloads","issues_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues{/number}","pulls_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls{/number}","milestones_url":"https://api.github.com/repos/DynamoDS/Dynamo/milestones{/number}","notifications_url":"https://api.github.com/repos/DynamoDS/Dynamo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DynamoDS/Dynamo/labels{/name}","releases_url":"https://api.github.com/repos/DynamoDS/Dynamo/releases{/id}","deployments_url":"https://api.github.com/repos/DynamoDS/Dynamo/deployments","created_at":"2012-02-09T07:35:33Z","updated_at":"2018-11-01T19:22:59Z","pushed_at":"2018-11-02T18:47:12Z","git_url":"git://github.com/DynamoDS/Dynamo.git","ssh_url":"git@github.com:DynamoDS/Dynamo.git","clone_url":"https://github.com/DynamoDS/Dynamo.git","svn_url":"https://github.com/DynamoDS/Dynamo","homepage":"http://dynamobim.org","size":1393463,"stargazers_count":650,"watchers_count":650,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":372,"mirror_url":null,"archived":false,"open_issues_count":504,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":372,"open_issues":504,"watchers":650,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/9174"},"html":{"href":"https://github.com/DynamoDS/Dynamo/pull/9174"},"issue":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/issues/9174"},"comments":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/issues/9174/comments"},"review_comments":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/9174/comments"},"review_comment":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/9174/commits"},"statuses":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/3a39cb7cb3aa305d12d18c1fab9c29fbdc9b80d9"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mjkkirschner"}}