{"action":"closed","number":893,"pull_request":{"url":"https://api.github.com/repos/verdaccio/verdaccio/pulls/893","id":205854868,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1ODU0ODY4","html_url":"https://github.com/verdaccio/verdaccio/pull/893","diff_url":"https://github.com/verdaccio/verdaccio/pull/893.diff","patch_url":"https://github.com/verdaccio/verdaccio/pull/893.patch","issue_url":"https://api.github.com/repos/verdaccio/verdaccio/issues/893","number":893,"state":"closed","locked":false,"title":"fix: bugs related to logging with type json","user":{"login":"mlucool","id":1813603,"node_id":"MDQ6VXNlcjE4MTM2MDM=","avatar_url":"https://avatars1.githubusercontent.com/u/1813603?v=4","gravatar_id":"","url":"https://api.github.com/users/mlucool","html_url":"https://github.com/mlucool","followers_url":"https://api.github.com/users/mlucool/followers","following_url":"https://api.github.com/users/mlucool/following{/other_user}","gists_url":"https://api.github.com/users/mlucool/gists{/gist_id}","starred_url":"https://api.github.com/users/mlucool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlucool/subscriptions","organizations_url":"https://api.github.com/users/mlucool/orgs","repos_url":"https://api.github.com/users/mlucool/repos","events_url":"https://api.github.com/users/mlucool/events{/privacy}","received_events_url":"https://api.github.com/users/mlucool/received_events","type":"User","site_admin":false},"body":"This commit cleans up some logging infra and ensures that the msg\r\nin the json log are the same as what you get when you use pretty.\r\nIt also removes some confusing nulls that appear in the logs.\r\n\r\n**Type:**\r\n\r\nThe following has been addressed in the PR: bug\r\n\r\n**Description:**\r\nWhen using the log format `json` the msg would be untemplated version (e.g.)\r\n```\r\n\"msg\":\"@{status}, user: @{user}(@{remoteIP}), req: '@{request.method} @{request.url}'\r\n```\r\nThis fixes that by refactoring and sharing the same template logic in all cases.","created_at":"2018-08-02T20:40:46Z","updated_at":"2018-08-24T20:07:25Z","closed_at":"2018-08-24T20:07:25Z","merged_at":"2018-08-24T20:07:25Z","merge_commit_sha":"cd231badb72e1da75c1494ab17c3d2a0db06b510","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":690593527,"node_id":"MDU6TGFiZWw2OTA1OTM1Mjc=","url":"https://api.github.com/repos/verdaccio/verdaccio/labels/Fixed","name":"Fixed","color":"0e8a16","default":false},{"id":926273105,"node_id":"MDU6TGFiZWw5MjYyNzMxMDU=","url":"https://api.github.com/repos/verdaccio/verdaccio/labels/High%20Priority","name":"High Priority","color":"961b15","default":false}],"milestone":{"url":"https://api.github.com/repos/verdaccio/verdaccio/milestones/14","html_url":"https://github.com/verdaccio/verdaccio/milestone/14","labels_url":"https://api.github.com/repos/verdaccio/verdaccio/milestones/14/labels","id":3389697,"node_id":"MDk6TWlsZXN0b25lMzM4OTY5Nw==","number":14,"title":"3.x.x","description":"","creator":{"login":"juanpicado","id":558752,"node_id":"MDQ6VXNlcjU1ODc1Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/558752?v=4","gravatar_id":"","url":"https://api.github.com/users/juanpicado","html_url":"https://github.com/juanpicado","followers_url":"https://api.github.com/users/juanpicado/followers","following_url":"https://api.github.com/users/juanpicado/following{/other_user}","gists_url":"https://api.github.com/users/juanpicado/gists{/gist_id}","starred_url":"https://api.github.com/users/juanpicado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanpicado/subscriptions","organizations_url":"https://api.github.com/users/juanpicado/orgs","repos_url":"https://api.github.com/users/juanpicado/repos","events_url":"https://api.github.com/users/juanpicado/events{/privacy}","received_events_url":"https://api.github.com/users/juanpicado/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":33,"state":"open","created_at":"2018-05-31T07:56:40Z","updated_at":"2018-08-24T20:07:25Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/verdaccio/verdaccio/pulls/893/commits","review_comments_url":"https://api.github.com/repos/verdaccio/verdaccio/pulls/893/comments","review_comment_url":"https://api.github.com/repos/verdaccio/verdaccio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/verdaccio/verdaccio/issues/893/comments","statuses_url":"https://api.github.com/repos/verdaccio/verdaccio/statuses/06786889082b472805f2593f642c230a61e84e88","head":{"label":"mlucool:fix-logging","ref":"fix-logging","sha":"06786889082b472805f2593f642c230a61e84e88","user":{"login":"mlucool","id":1813603,"node_id":"MDQ6VXNlcjE4MTM2MDM=","avatar_url":"https://avatars1.githubusercontent.com/u/1813603?v=4","gravatar_id":"","url":"https://api.github.com/users/mlucool","html_url":"https://github.com/mlucool","followers_url":"https://api.github.com/users/mlucool/followers","following_url":"https://api.github.com/users/mlucool/following{/other_user}","gists_url":"https://api.github.com/users/mlucool/gists{/gist_id}","starred_url":"https://api.github.com/users/mlucool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlucool/subscriptions","organizations_url":"https://api.github.com/users/mlucool/orgs","repos_url":"https://api.github.com/users/mlucool/repos","events_url":"https://api.github.com/users/mlucool/events{/privacy}","received_events_url":"https://api.github.com/users/mlucool/received_events","type":"User","site_admin":false},"repo":{"id":143342332,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMzNDIzMzI=","name":"verdaccio","full_name":"mlucool/verdaccio","owner":{"login":"mlucool","id":1813603,"node_id":"MDQ6VXNlcjE4MTM2MDM=","avatar_url":"https://avatars1.githubusercontent.com/u/1813603?v=4","gravatar_id":"","url":"https://api.github.com/users/mlucool","html_url":"https://github.com/mlucool","followers_url":"https://api.github.com/users/mlucool/followers","following_url":"https://api.github.com/users/mlucool/following{/other_user}","gists_url":"https://api.github.com/users/mlucool/gists{/gist_id}","starred_url":"https://api.github.com/users/mlucool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlucool/subscriptions","organizations_url":"https://api.github.com/users/mlucool/orgs","repos_url":"https://api.github.com/users/mlucool/repos","events_url":"https://api.github.com/users/mlucool/events{/privacy}","received_events_url":"https://api.github.com/users/mlucool/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mlucool/verdaccio","description":"📦🔐A lightweight private npm proxy registry","fork":true,"url":"https://api.github.com/repos/mlucool/verdaccio","forks_url":"https://api.github.com/repos/mlucool/verdaccio/forks","keys_url":"https://api.github.com/repos/mlucool/verdaccio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mlucool/verdaccio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mlucool/verdaccio/teams","hooks_url":"https://api.github.com/repos/mlucool/verdaccio/hooks","issue_events_url":"https://api.github.com/repos/mlucool/verdaccio/issues/events{/number}","events_url":"https://api.github.com/repos/mlucool/verdaccio/events","assignees_url":"https://api.github.com/repos/mlucool/verdaccio/assignees{/user}","branches_url":"https://api.github.com/repos/mlucool/verdaccio/branches{/branch}","tags_url":"https://api.github.com/repos/mlucool/verdaccio/tags","blobs_url":"https://api.github.com/repos/mlucool/verdaccio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mlucool/verdaccio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mlucool/verdaccio/git/refs{/sha}","trees_url":"https://api.github.com/repos/mlucool/verdaccio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mlucool/verdaccio/statuses/{sha}","languages_url":"https://api.github.com/repos/mlucool/verdaccio/languages","stargazers_url":"https://api.github.com/repos/mlucool/verdaccio/stargazers","contributors_url":"https://api.github.com/repos/mlucool/verdaccio/contributors","subscribers_url":"https://api.github.com/repos/mlucool/verdaccio/subscribers","subscription_url":"https://api.github.com/repos/mlucool/verdaccio/subscription","commits_url":"https://api.github.com/repos/mlucool/verdaccio/commits{/sha}","git_commits_url":"https://api.github.com/repos/mlucool/verdaccio/git/commits{/sha}","comments_url":"https://api.github.com/repos/mlucool/verdaccio/comments{/number}","issue_comment_url":"https://api.github.com/repos/mlucool/verdaccio/issues/comments{/number}","contents_url":"https://api.github.com/repos/mlucool/verdaccio/contents/{+path}","compare_url":"https://api.github.com/repos/mlucool/verdaccio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mlucool/verdaccio/merges","archive_url":"https://api.github.com/repos/mlucool/verdaccio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mlucool/verdaccio/downloads","issues_url":"https://api.github.com/repos/mlucool/verdaccio/issues{/number}","pulls_url":"https://api.github.com/repos/mlucool/verdaccio/pulls{/number}","milestones_url":"https://api.github.com/repos/mlucool/verdaccio/milestones{/number}","notifications_url":"https://api.github.com/repos/mlucool/verdaccio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mlucool/verdaccio/labels{/name}","releases_url":"https://api.github.com/repos/mlucool/verdaccio/releases{/id}","deployments_url":"https://api.github.com/repos/mlucool/verdaccio/deployments","created_at":"2018-08-02T20:33:23Z","updated_at":"2018-08-02T20:33:27Z","pushed_at":"2018-08-24T18:56:50Z","git_url":"git://github.com/mlucool/verdaccio.git","ssh_url":"git@github.com:mlucool/verdaccio.git","clone_url":"https://github.com/mlucool/verdaccio.git","svn_url":"https://github.com/mlucool/verdaccio","homepage":"https://www.verdaccio.org/","size":24981,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"verdaccio:master","ref":"master","sha":"d2a715dcbcd2f6b6fe6ef8635eb189dbd311fe5a","user":{"login":"verdaccio","id":18487506,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NDg3NTA2","avatar_url":"https://avatars2.githubusercontent.com/u/18487506?v=4","gravatar_id":"","url":"https://api.github.com/users/verdaccio","html_url":"https://github.com/verdaccio","followers_url":"https://api.github.com/users/verdaccio/followers","following_url":"https://api.github.com/users/verdaccio/following{/other_user}","gists_url":"https://api.github.com/users/verdaccio/gists{/gist_id}","starred_url":"https://api.github.com/users/verdaccio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/verdaccio/subscriptions","organizations_url":"https://api.github.com/users/verdaccio/orgs","repos_url":"https://api.github.com/users/verdaccio/repos","events_url":"https://api.github.com/users/verdaccio/events{/privacy}","received_events_url":"https://api.github.com/users/verdaccio/received_events","type":"Organization","site_admin":false},"repo":{"id":56333861,"node_id":"MDEwOlJlcG9zaXRvcnk1NjMzMzg2MQ==","name":"verdaccio","full_name":"verdaccio/verdaccio","owner":{"login":"verdaccio","id":18487506,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NDg3NTA2","avatar_url":"https://avatars2.githubusercontent.com/u/18487506?v=4","gravatar_id":"","url":"https://api.github.com/users/verdaccio","html_url":"https://github.com/verdaccio","followers_url":"https://api.github.com/users/verdaccio/followers","following_url":"https://api.github.com/users/verdaccio/following{/other_user}","gists_url":"https://api.github.com/users/verdaccio/gists{/gist_id}","starred_url":"https://api.github.com/users/verdaccio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/verdaccio/subscriptions","organizations_url":"https://api.github.com/users/verdaccio/orgs","repos_url":"https://api.github.com/users/verdaccio/repos","events_url":"https://api.github.com/users/verdaccio/events{/privacy}","received_events_url":"https://api.github.com/users/verdaccio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/verdaccio/verdaccio","description":"📦🔐A lightweight private npm proxy registry","fork":false,"url":"https://api.github.com/repos/verdaccio/verdaccio","forks_url":"https://api.github.com/repos/verdaccio/verdaccio/forks","keys_url":"https://api.github.com/repos/verdaccio/verdaccio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/verdaccio/verdaccio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/verdaccio/verdaccio/teams","hooks_url":"https://api.github.com/repos/verdaccio/verdaccio/hooks","issue_events_url":"https://api.github.com/repos/verdaccio/verdaccio/issues/events{/number}","events_url":"https://api.github.com/repos/verdaccio/verdaccio/events","assignees_url":"https://api.github.com/repos/verdaccio/verdaccio/assignees{/user}","branches_url":"https://api.github.com/repos/verdaccio/verdaccio/branches{/branch}","tags_url":"https://api.github.com/repos/verdaccio/verdaccio/tags","blobs_url":"https://api.github.com/repos/verdaccio/verdaccio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/verdaccio/verdaccio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/verdaccio/verdaccio/git/refs{/sha}","trees_url":"https://api.github.com/repos/verdaccio/verdaccio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/verdaccio/verdaccio/statuses/{sha}","languages_url":"https://api.github.com/repos/verdaccio/verdaccio/languages","stargazers_url":"https://api.github.com/repos/verdaccio/verdaccio/stargazers","contributors_url":"https://api.github.com/repos/verdaccio/verdaccio/contributors","subscribers_url":"https://api.github.com/repos/verdaccio/verdaccio/subscribers","subscription_url":"https://api.github.com/repos/verdaccio/verdaccio/subscription","commits_url":"https://api.github.com/repos/verdaccio/verdaccio/commits{/sha}","git_commits_url":"https://api.github.com/repos/verdaccio/verdaccio/git/commits{/sha}","comments_url":"https://api.github.com/repos/verdaccio/verdaccio/comments{/number}","issue_comment_url":"https://api.github.com/repos/verdaccio/verdaccio/issues/comments{/number}","contents_url":"https://api.github.com/repos/verdaccio/verdaccio/contents/{+path}","compare_url":"https://api.github.com/repos/verdaccio/verdaccio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/verdaccio/verdaccio/merges","archive_url":"https://api.github.com/repos/verdaccio/verdaccio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/verdaccio/verdaccio/downloads","issues_url":"https://api.github.com/repos/verdaccio/verdaccio/issues{/number}","pulls_url":"https://api.github.com/repos/verdaccio/verdaccio/pulls{/number}","milestones_url":"https://api.github.com/repos/verdaccio/verdaccio/milestones{/number}","notifications_url":"https://api.github.com/repos/verdaccio/verdaccio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/verdaccio/verdaccio/labels{/name}","releases_url":"https://api.github.com/repos/verdaccio/verdaccio/releases{/id}","deployments_url":"https://api.github.com/repos/verdaccio/verdaccio/deployments","created_at":"2016-04-15T16:21:12Z","updated_at":"2018-08-24T16:27:14Z","pushed_at":"2018-08-24T20:07:25Z","git_url":"git://github.com/verdaccio/verdaccio.git","ssh_url":"git@github.com:verdaccio/verdaccio.git","clone_url":"https://github.com/verdaccio/verdaccio.git","svn_url":"https://github.com/verdaccio/verdaccio","homepage":"https://www.verdaccio.org/","size":25457,"stargazers_count":4075,"watchers_count":4075,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":467,"mirror_url":null,"archived":false,"open_issues_count":83,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":467,"open_issues":83,"watchers":4075,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/verdaccio/verdaccio/pulls/893"},"html":{"href":"https://github.com/verdaccio/verdaccio/pull/893"},"issue":{"href":"https://api.github.com/repos/verdaccio/verdaccio/issues/893"},"comments":{"href":"https://api.github.com/repos/verdaccio/verdaccio/issues/893/comments"},"review_comments":{"href":"https://api.github.com/repos/verdaccio/verdaccio/pulls/893/comments"},"review_comment":{"href":"https://api.github.com/repos/verdaccio/verdaccio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/verdaccio/verdaccio/pulls/893/commits"},"statuses":{"href":"https://api.github.com/repos/verdaccio/verdaccio/statuses/06786889082b472805f2593f642c230a61e84e88"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"juanpicado","id":558752,"node_id":"MDQ6VXNlcjU1ODc1Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/558752?v=4","gravatar_id":"","url":"https://api.github.com/users/juanpicado","html_url":"https://github.com/juanpicado","followers_url":"https://api.github.com/users/juanpicado/followers","following_url":"https://api.github.com/users/juanpicado/following{/other_user}","gists_url":"https://api.github.com/users/juanpicado/gists{/gist_id}","starred_url":"https://api.github.com/users/juanpicado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanpicado/subscriptions","organizations_url":"https://api.github.com/users/juanpicado/orgs","repos_url":"https://api.github.com/users/juanpicado/repos","events_url":"https://api.github.com/users/juanpicado/events{/privacy}","received_events_url":"https://api.github.com/users/juanpicado/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":5,"additions":50,"deletions":42,"changed_files":3}}
{"actor":{"display_login":"juanpicado"}}