{"action":"created","issue":{"url":"https://api.github.com/repos/RobotLocomotion/drake/issues/8341","repository_url":"https://api.github.com/repos/RobotLocomotion/drake","labels_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/8341/labels{/name}","comments_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/8341/comments","events_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/8341/events","html_url":"https://github.com/RobotLocomotion/drake/pull/8341","id":304449660,"number":8341,"title":"Install links of links instead of copying the file it points to.","user":{"login":"fbudin69500","id":399640,"avatar_url":"https://avatars0.githubusercontent.com/u/399640?v=4","gravatar_id":"","url":"https://api.github.com/users/fbudin69500","html_url":"https://github.com/fbudin69500","followers_url":"https://api.github.com/users/fbudin69500/followers","following_url":"https://api.github.com/users/fbudin69500/following{/other_user}","gists_url":"https://api.github.com/users/fbudin69500/gists{/gist_id}","starred_url":"https://api.github.com/users/fbudin69500/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbudin69500/subscriptions","organizations_url":"https://api.github.com/users/fbudin69500/orgs","repos_url":"https://api.github.com/users/fbudin69500/repos","events_url":"https://api.github.com/users/fbudin69500/events{/privacy}","received_events_url":"https://api.github.com/users/fbudin69500/received_events","type":"User","site_admin":false},"labels":[{"id":77798003,"url":"https://api.github.com/repos/RobotLocomotion/drake/labels/priority:%20high","name":"priority: high","color":"b60205","default":false}],"state":"open","locked":false,"assignee":{"login":"jamiesnape","id":3630149,"avatar_url":"https://avatars3.githubusercontent.com/u/3630149?v=4","gravatar_id":"","url":"https://api.github.com/users/jamiesnape","html_url":"https://github.com/jamiesnape","followers_url":"https://api.github.com/users/jamiesnape/followers","following_url":"https://api.github.com/users/jamiesnape/following{/other_user}","gists_url":"https://api.github.com/users/jamiesnape/gists{/gist_id}","starred_url":"https://api.github.com/users/jamiesnape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamiesnape/subscriptions","organizations_url":"https://api.github.com/users/jamiesnape/orgs","repos_url":"https://api.github.com/users/jamiesnape/repos","events_url":"https://api.github.com/users/jamiesnape/events{/privacy}","received_events_url":"https://api.github.com/users/jamiesnape/received_events","type":"User","site_admin":false},"assignees":[{"login":"jamiesnape","id":3630149,"avatar_url":"https://avatars3.githubusercontent.com/u/3630149?v=4","gravatar_id":"","url":"https://api.github.com/users/jamiesnape","html_url":"https://github.com/jamiesnape","followers_url":"https://api.github.com/users/jamiesnape/followers","following_url":"https://api.github.com/users/jamiesnape/following{/other_user}","gists_url":"https://api.github.com/users/jamiesnape/gists{/gist_id}","starred_url":"https://api.github.com/users/jamiesnape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamiesnape/subscriptions","organizations_url":"https://api.github.com/users/jamiesnape/orgs","repos_url":"https://api.github.com/users/jamiesnape/repos","events_url":"https://api.github.com/users/jamiesnape/events{/privacy}","received_events_url":"https://api.github.com/users/jamiesnape/received_events","type":"User","site_admin":false},{"login":"jwnimmer-tri","id":17596505,"avatar_url":"https://avatars3.githubusercontent.com/u/17596505?v=4","gravatar_id":"","url":"https://api.github.com/users/jwnimmer-tri","html_url":"https://github.com/jwnimmer-tri","followers_url":"https://api.github.com/users/jwnimmer-tri/followers","following_url":"https://api.github.com/users/jwnimmer-tri/following{/other_user}","gists_url":"https://api.github.com/users/jwnimmer-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/jwnimmer-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwnimmer-tri/subscriptions","organizations_url":"https://api.github.com/users/jwnimmer-tri/orgs","repos_url":"https://api.github.com/users/jwnimmer-tri/repos","events_url":"https://api.github.com/users/jwnimmer-tri/events{/privacy}","received_events_url":"https://api.github.com/users/jwnimmer-tri/received_events","type":"User","site_admin":false}],"milestone":null,"comments":12,"created_at":"2018-03-12T16:40:18Z","updated_at":"2018-03-13T18:11:03Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/RobotLocomotion/drake/pulls/8341","html_url":"https://github.com/RobotLocomotion/drake/pull/8341","diff_url":"https://github.com/RobotLocomotion/drake/pull/8341.diff","patch_url":"https://github.com/RobotLocomotion/drake/pull/8341.patch"},"body":"Until this patch, at install time, all links were replaced by a real file.\r\nIn the case of VTK and maybe other libraries, this lead to duplicating all\r\nthe libraries. It was also creating problems when calling the function\r\n`strip` (issue  #8253).\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/robotlocomotion/drake/8341)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/RobotLocomotion/drake/issues/comments/372764836","html_url":"https://github.com/RobotLocomotion/drake/pull/8341#issuecomment-372764836","issue_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/8341","id":372764836,"user":{"login":"fbudin69500","id":399640,"avatar_url":"https://avatars0.githubusercontent.com/u/399640?v=4","gravatar_id":"","url":"https://api.github.com/users/fbudin69500","html_url":"https://github.com/fbudin69500","followers_url":"https://api.github.com/users/fbudin69500/followers","following_url":"https://api.github.com/users/fbudin69500/following{/other_user}","gists_url":"https://api.github.com/users/fbudin69500/gists{/gist_id}","starred_url":"https://api.github.com/users/fbudin69500/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbudin69500/subscriptions","organizations_url":"https://api.github.com/users/fbudin69500/orgs","repos_url":"https://api.github.com/users/fbudin69500/repos","events_url":"https://api.github.com/users/fbudin69500/events{/privacy}","received_events_url":"https://api.github.com/users/fbudin69500/received_events","type":"User","site_admin":false},"created_at":"2018-03-13T18:11:03Z","updated_at":"2018-03-13T18:11:03Z","author_association":"CONTRIBUTOR","body":"\n\n\n\nReview status: 1 of 2 files reviewed at latest revision, 4 unresolved discussions.\n\n---\n\n*[tools/install/install.py.in, line 89 at r1](https://reviewable.io:443/reviews/robotlocomotion/drake/8341#-L7QXRRK7-qm-7W_CcFU:-L7VYiIh2QkawoVMSoE7:b-896fix) ([raw file](https://github.com/robotlocomotion/drake/blob/140a8b7e7d6ae6d40e54c48235e77a0c7c9889a6/tools/install/install.py.in#L89)):*\n<details><summary><i>Previously, jwnimmer-tri (Jeremy Nimmer) wrote…</i></summary><blockquote>\n\nWell, the `src` above in the other method was fine (though its fine to be changed too).\n\nMy defect was the `src, ... = func(src)` re-assignment here, `src` is both the argument to the function, and the result of `is_relative_link`.\n\nI was imagining \n```python\nrelative_link, is_link = is_relative_link(src)\nif is_link:\n  os.symlink(relative_link, dst)\n```\nThough I guess at that point, might as well do:\n```python\nrelative_link = is_relative_link(src)\nif link:\n  os.symlink(relative_link, dst)\nelse:\n  shutil.copy2(src, dst)\n```\n```\n</blockquote></details>\n\nDone.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/robotlocomotion/drake/8341)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"fbudin69500"}}