{"action":"created","comment":{"url":"https://api.github.com/repos/palantir/tslint/pulls/comments/183092558","pull_request_review_id":114029816,"id":183092558,"diff_hunk":"@@ -0,0 +1,97 @@\n+/**\n+ * @license\n+ * Copyright 2014 Palantir Technologies, Inc.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+import * as ts from \"typescript\";\n+\n+import * as Lint from \"../index\";\n+\n+export class Rule extends Lint.Rules.TypedRule {\n+    /* tslint:disable:object-literal-sort-keys */\n+    public static metadata: Lint.IRuleMetadata = {\n+        ruleName: \"no-restricted-globals\",\n+        description: \"Disallow specific global variables.\",\n+        descriptionDetails: Lint.Utils.dedent`\n+            Disallowing usage of specific global variables can be useful if you want to allow\n+            a set of global variables by enabling an environment, but still want to disallow\n+            some of those. For instance, early Internet Explorer versions exposed the current\n+            DOM event as a global variable event, but using this variable has been considered\n+            as a bad practice for a long time. Restricting this will make sure this variable\n+            isn’t used in browser code.\n+        `,\n+        optionsDescription: \"This rule takes a list of strings, where each string is a global to be restricted.\",\n+        options: {\n+            type: \"list\",\n+            items: {type: \"string\"},\n+        },\n+        optionExamples: [\n+            [\n+                true,\n+                \"name\",\n+                \"length\",\n+                \"event\",\n+            ],\n+        ],\n+        type: \"functionality\",\n+        typescriptOnly: false,\n+        requiresTypeInfo: true,\n+    };\n+    /* tslint:enable:object-literal-sort-keys */\n+\n+    public static FAILURE_STRING(name: string) {\n+        return `Unexpected global variable '${name}'. Use local parameter instead.`;","path":"src/rules/noRestrictedGlobalsRule.ts","position":55,"original_position":55,"commit_id":"614353a11860aa79b70d0b367c1e7b66fd6509f4","original_commit_id":"614353a11860aa79b70d0b367c1e7b66fd6509f4","user":{"login":"Zzzen","id":6630042,"avatar_url":"https://avatars0.githubusercontent.com/u/6630042?v=4","gravatar_id":"","url":"https://api.github.com/users/Zzzen","html_url":"https://github.com/Zzzen","followers_url":"https://api.github.com/users/Zzzen/followers","following_url":"https://api.github.com/users/Zzzen/following{/other_user}","gists_url":"https://api.github.com/users/Zzzen/gists{/gist_id}","starred_url":"https://api.github.com/users/Zzzen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zzzen/subscriptions","organizations_url":"https://api.github.com/users/Zzzen/orgs","repos_url":"https://api.github.com/users/Zzzen/repos","events_url":"https://api.github.com/users/Zzzen/events{/privacy}","received_events_url":"https://api.github.com/users/Zzzen/received_events","type":"User","site_admin":false},"body":"Updated. thanks","created_at":"2018-04-20T15:44:47Z","updated_at":"2018-04-20T15:44:47Z","html_url":"https://github.com/palantir/tslint/pull/3824#discussion_r183092558","pull_request_url":"https://api.github.com/repos/palantir/tslint/pulls/3824","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/palantir/tslint/pulls/comments/183092558"},"html":{"href":"https://github.com/palantir/tslint/pull/3824#discussion_r183092558"},"pull_request":{"href":"https://api.github.com/repos/palantir/tslint/pulls/3824"}},"in_reply_to_id":182942645},"pull_request":{"url":"https://api.github.com/repos/palantir/tslint/pulls/3824","id":180348652,"html_url":"https://github.com/palantir/tslint/pull/3824","diff_url":"https://github.com/palantir/tslint/pull/3824.diff","patch_url":"https://github.com/palantir/tslint/pull/3824.patch","issue_url":"https://api.github.com/repos/palantir/tslint/issues/3824","number":3824,"state":"open","locked":false,"title":"[new-rule] no-restricted-globals","user":{"login":"Zzzen","id":6630042,"avatar_url":"https://avatars0.githubusercontent.com/u/6630042?v=4","gravatar_id":"","url":"https://api.github.com/users/Zzzen","html_url":"https://github.com/Zzzen","followers_url":"https://api.github.com/users/Zzzen/followers","following_url":"https://api.github.com/users/Zzzen/following{/other_user}","gists_url":"https://api.github.com/users/Zzzen/gists{/gist_id}","starred_url":"https://api.github.com/users/Zzzen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zzzen/subscriptions","organizations_url":"https://api.github.com/users/Zzzen/orgs","repos_url":"https://api.github.com/users/Zzzen/repos","events_url":"https://api.github.com/users/Zzzen/events{/privacy}","received_events_url":"https://api.github.com/users/Zzzen/received_events","type":"User","site_admin":false},"body":"#### PR checklist\r\n\r\n- [x] Addresses an existing issue: #922\r\n- [x] New feature, bugfix, or enhancement\r\n  - [x] Includes tests\r\n- [ ] Documentation update\r\n\r\n#### Overview of change:\r\n  prevents accidental access to variables that are declared in `lib.dom.d.ts`.\r\n\r\n#### Is there anything you'd like reviewers to focus on?\r\n  1. a descriptive rule name\r\n  2. corner cases\r\n  3. performance\r\n<!-- optional -->\r\n\r\n#### CHANGELOG.md entry:\r\n\r\n<!-- optional (example: \"[new-rule] `arrow-return-shorthand`\") -->\r\n<!-- suggested tags: [new-rule], [new-rule-option], [new-fixer], [bugfix], [enhancement], [api], [rule-change], [no-log] -->\r\n","created_at":"2018-04-09T15:39:24Z","updated_at":"2018-04-20T15:44:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1c492e9cef321905e591eb0dd3941ebd4dcfeba","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/palantir/tslint/pulls/3824/commits","review_comments_url":"https://api.github.com/repos/palantir/tslint/pulls/3824/comments","review_comment_url":"https://api.github.com/repos/palantir/tslint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/palantir/tslint/issues/3824/comments","statuses_url":"https://api.github.com/repos/palantir/tslint/statuses/614353a11860aa79b70d0b367c1e7b66fd6509f4","head":{"label":"Zzzen:master","ref":"master","sha":"614353a11860aa79b70d0b367c1e7b66fd6509f4","user":{"login":"Zzzen","id":6630042,"avatar_url":"https://avatars0.githubusercontent.com/u/6630042?v=4","gravatar_id":"","url":"https://api.github.com/users/Zzzen","html_url":"https://github.com/Zzzen","followers_url":"https://api.github.com/users/Zzzen/followers","following_url":"https://api.github.com/users/Zzzen/following{/other_user}","gists_url":"https://api.github.com/users/Zzzen/gists{/gist_id}","starred_url":"https://api.github.com/users/Zzzen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zzzen/subscriptions","organizations_url":"https://api.github.com/users/Zzzen/orgs","repos_url":"https://api.github.com/users/Zzzen/repos","events_url":"https://api.github.com/users/Zzzen/events{/privacy}","received_events_url":"https://api.github.com/users/Zzzen/received_events","type":"User","site_admin":false},"repo":{"id":128790371,"name":"tslint","full_name":"Zzzen/tslint","owner":{"login":"Zzzen","id":6630042,"avatar_url":"https://avatars0.githubusercontent.com/u/6630042?v=4","gravatar_id":"","url":"https://api.github.com/users/Zzzen","html_url":"https://github.com/Zzzen","followers_url":"https://api.github.com/users/Zzzen/followers","following_url":"https://api.github.com/users/Zzzen/following{/other_user}","gists_url":"https://api.github.com/users/Zzzen/gists{/gist_id}","starred_url":"https://api.github.com/users/Zzzen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zzzen/subscriptions","organizations_url":"https://api.github.com/users/Zzzen/orgs","repos_url":"https://api.github.com/users/Zzzen/repos","events_url":"https://api.github.com/users/Zzzen/events{/privacy}","received_events_url":"https://api.github.com/users/Zzzen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Zzzen/tslint","description":":vertical_traffic_light: An extensible linter for the TypeScript language","fork":true,"url":"https://api.github.com/repos/Zzzen/tslint","forks_url":"https://api.github.com/repos/Zzzen/tslint/forks","keys_url":"https://api.github.com/repos/Zzzen/tslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zzzen/tslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zzzen/tslint/teams","hooks_url":"https://api.github.com/repos/Zzzen/tslint/hooks","issue_events_url":"https://api.github.com/repos/Zzzen/tslint/issues/events{/number}","events_url":"https://api.github.com/repos/Zzzen/tslint/events","assignees_url":"https://api.github.com/repos/Zzzen/tslint/assignees{/user}","branches_url":"https://api.github.com/repos/Zzzen/tslint/branches{/branch}","tags_url":"https://api.github.com/repos/Zzzen/tslint/tags","blobs_url":"https://api.github.com/repos/Zzzen/tslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zzzen/tslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zzzen/tslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zzzen/tslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zzzen/tslint/statuses/{sha}","languages_url":"https://api.github.com/repos/Zzzen/tslint/languages","stargazers_url":"https://api.github.com/repos/Zzzen/tslint/stargazers","contributors_url":"https://api.github.com/repos/Zzzen/tslint/contributors","subscribers_url":"https://api.github.com/repos/Zzzen/tslint/subscribers","subscription_url":"https://api.github.com/repos/Zzzen/tslint/subscription","commits_url":"https://api.github.com/repos/Zzzen/tslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zzzen/tslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zzzen/tslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zzzen/tslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zzzen/tslint/contents/{+path}","compare_url":"https://api.github.com/repos/Zzzen/tslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zzzen/tslint/merges","archive_url":"https://api.github.com/repos/Zzzen/tslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zzzen/tslint/downloads","issues_url":"https://api.github.com/repos/Zzzen/tslint/issues{/number}","pulls_url":"https://api.github.com/repos/Zzzen/tslint/pulls{/number}","milestones_url":"https://api.github.com/repos/Zzzen/tslint/milestones{/number}","notifications_url":"https://api.github.com/repos/Zzzen/tslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zzzen/tslint/labels{/name}","releases_url":"https://api.github.com/repos/Zzzen/tslint/releases{/id}","deployments_url":"https://api.github.com/repos/Zzzen/tslint/deployments","created_at":"2018-04-09T15:07:19Z","updated_at":"2018-04-10T12:36:33Z","pushed_at":"2018-04-10T12:36:29Z","git_url":"git://github.com/Zzzen/tslint.git","ssh_url":"git@github.com:Zzzen/tslint.git","clone_url":"https://github.com/Zzzen/tslint.git","svn_url":"https://github.com/Zzzen/tslint","homepage":"http://palantir.github.io/tslint/","size":13789,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"palantir:master","ref":"master","sha":"375de6d76a500a2dab3a18724b170cfd00d55479","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":11672345,"name":"tslint","full_name":"palantir/tslint","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/tslint","description":":vertical_traffic_light: An extensible linter for the TypeScript language","fork":false,"url":"https://api.github.com/repos/palantir/tslint","forks_url":"https://api.github.com/repos/palantir/tslint/forks","keys_url":"https://api.github.com/repos/palantir/tslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/tslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/tslint/teams","hooks_url":"https://api.github.com/repos/palantir/tslint/hooks","issue_events_url":"https://api.github.com/repos/palantir/tslint/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/tslint/events","assignees_url":"https://api.github.com/repos/palantir/tslint/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/tslint/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/tslint/tags","blobs_url":"https://api.github.com/repos/palantir/tslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/tslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/tslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/tslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/tslint/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/tslint/languages","stargazers_url":"https://api.github.com/repos/palantir/tslint/stargazers","contributors_url":"https://api.github.com/repos/palantir/tslint/contributors","subscribers_url":"https://api.github.com/repos/palantir/tslint/subscribers","subscription_url":"https://api.github.com/repos/palantir/tslint/subscription","commits_url":"https://api.github.com/repos/palantir/tslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/tslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/tslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/tslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/tslint/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/tslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/tslint/merges","archive_url":"https://api.github.com/repos/palantir/tslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/tslint/downloads","issues_url":"https://api.github.com/repos/palantir/tslint/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/tslint/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/tslint/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/tslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/tslint/labels{/name}","releases_url":"https://api.github.com/repos/palantir/tslint/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/tslint/deployments","created_at":"2013-07-25T22:19:18Z","updated_at":"2018-04-20T15:04:54Z","pushed_at":"2018-04-20T06:51:28Z","git_url":"git://github.com/palantir/tslint.git","ssh_url":"git@github.com:palantir/tslint.git","clone_url":"https://github.com/palantir/tslint.git","svn_url":"https://github.com/palantir/tslint","homepage":"http://palantir.github.io/tslint/","size":13691,"stargazers_count":3201,"watchers_count":3201,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":634,"mirror_url":null,"archived":false,"open_issues_count":600,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":634,"open_issues":600,"watchers":3201,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/tslint/pulls/3824"},"html":{"href":"https://github.com/palantir/tslint/pull/3824"},"issue":{"href":"https://api.github.com/repos/palantir/tslint/issues/3824"},"comments":{"href":"https://api.github.com/repos/palantir/tslint/issues/3824/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/tslint/pulls/3824/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/tslint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/palantir/tslint/pulls/3824/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/tslint/statuses/614353a11860aa79b70d0b367c1e7b66fd6509f4"}},"author_association":"NONE"}}
{"actor":{"display_login":"Zzzen"}}