{"action":"created","issue":{"url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/issues/3212","repository_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui","labels_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/issues/3212/labels{/name}","comments_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/issues/3212/comments","events_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/issues/3212/events","html_url":"https://github.com/fabric8-ui/fabric8-ui/pull/3212","id":346592443,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NDE5NDI1","number":3212,"title":"\"My Spaces\" search","user":{"login":"andrewazores","id":3787464,"node_id":"MDQ6VXNlcjM3ODc0NjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3787464?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewazores","html_url":"https://github.com/andrewazores","followers_url":"https://api.github.com/users/andrewazores/followers","following_url":"https://api.github.com/users/andrewazores/following{/other_user}","gists_url":"https://api.github.com/users/andrewazores/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewazores/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewazores/subscriptions","organizations_url":"https://api.github.com/users/andrewazores/orgs","repos_url":"https://api.github.com/users/andrewazores/repos","events_url":"https://api.github.com/users/andrewazores/events{/privacy}","received_events_url":"https://api.github.com/users/andrewazores/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2018-08-01T13:08:30Z","updated_at":"2018-08-27T19:58:47Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/pulls/3212","html_url":"https://github.com/fabric8-ui/fabric8-ui/pull/3212","diff_url":"https://github.com/fabric8-ui/fabric8-ui/pull/3212.diff","patch_url":"https://github.com/fabric8-ui/fabric8-ui/pull/3212.patch"},"body":"This PR introduces initial support for a search feature on the My Spaces page, as described in the relevant design issue [0]. A button is added to the My Spaces toolbar which summons a search dialog, containing a simple search term text field and submission button above an infinite scroll results list. Other features described in the design issue, such as search typeahead, the ability to request to join spaces, and the ability to sort the results list, are left implemented for future enhancements, since these will require additional enabling backend support features.\r\n\r\nThe invision designs for the feature are here: https://redhat.invisionapp.com/share/P7LNZNZUZ9Y#/screens\r\n\r\nAnd this GIF is a quick demo of what the feature looks like as proposed in this PR:\r\n\r\n![43343519-836f4d9e-91b4-11e8-9822-7e18ea0acfba](https://user-images.githubusercontent.com/3787464/44547446-239eca80-a6e9-11e8-835a-79b7f77032e7.gif)\r\n\r\nBelow are some more screenshots illustrating the feature.\r\n\r\nToolbar button added:\r\n![screenshot_2018-08-23_15-03-31](https://user-images.githubusercontent.com/3787464/44546449-f00e7100-a6e5-11e8-9afb-b597b77dca44.png)\r\n\r\nInitial state:\r\n![screenshot_2018-08-23_15-03-58](https://user-images.githubusercontent.com/3787464/44546455-f7ce1580-a6e5-11e8-8756-d2630649ca14.png)\r\n\r\nEmpty state (no results for search):\r\n![screenshot_2018-08-23_15-04-20](https://user-images.githubusercontent.com/3787464/44546458-fe5c8d00-a6e5-11e8-9260-9de84f44c9ae.png)\r\n\r\nResults list:\r\n![screenshot_2018-08-23_15-04-42](https://user-images.githubusercontent.com/3787464/44546465-0288aa80-a6e6-11e8-893d-59a34704df5f.png)\r\n\r\n\r\n[0] https://github.com/openshiftio/openshift.io/issues/3655"},"comment":{"url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/issues/comments/416349041","html_url":"https://github.com/fabric8-ui/fabric8-ui/pull/3212#issuecomment-416349041","issue_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/issues/3212","id":416349041,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNjM0OTA0MQ==","user":{"login":"andrewazores","id":3787464,"node_id":"MDQ6VXNlcjM3ODc0NjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3787464?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewazores","html_url":"https://github.com/andrewazores","followers_url":"https://api.github.com/users/andrewazores/followers","following_url":"https://api.github.com/users/andrewazores/following{/other_user}","gists_url":"https://api.github.com/users/andrewazores/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewazores/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewazores/subscriptions","organizations_url":"https://api.github.com/users/andrewazores/orgs","repos_url":"https://api.github.com/users/andrewazores/repos","events_url":"https://api.github.com/users/andrewazores/events{/privacy}","received_events_url":"https://api.github.com/users/andrewazores/received_events","type":"User","site_admin":false},"created_at":"2018-08-27T19:58:47Z","updated_at":"2018-08-27T19:58:47Z","author_association":"MEMBER","body":"There is a number of results displayed. In my \"Results list\" screenshot, it says \"134 items\" in the top right. That's the total number of matching results. From there it's possible to calculate how many are expected in the results that have not yet been shown, but this was not included in the designs for the feature.\r\n\r\nI don't know why those images don't load. The view just attempts to load the image specified by the query response. I can investigate if those are due to an empty image URL string or some similar case and either hide the image or load a default instead, though I would expect the query response to point to some reasonable default to begin with."}}
{"actor":{"display_login":"andrewazores"}}