{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/kibana/issues/21408","repository_url":"https://api.github.com/repos/elastic/kibana","labels_url":"https://api.github.com/repos/elastic/kibana/issues/21408/labels{/name}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/21408/comments","events_url":"https://api.github.com/repos/elastic/kibana/issues/21408/events","html_url":"https://github.com/elastic/kibana/pull/21408","id":345767419,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0ODExNjQ5","number":21408,"title":"Spaces Phase 1","user":{"login":"legrego","id":3493255,"node_id":"MDQ6VXNlcjM0OTMyNTU=","avatar_url":"https://avatars2.githubusercontent.com/u/3493255?v=4","gravatar_id":"","url":"https://api.github.com/users/legrego","html_url":"https://github.com/legrego","followers_url":"https://api.github.com/users/legrego/followers","following_url":"https://api.github.com/users/legrego/following{/other_user}","gists_url":"https://api.github.com/users/legrego/gists{/gist_id}","starred_url":"https://api.github.com/users/legrego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/legrego/subscriptions","organizations_url":"https://api.github.com/users/legrego/orgs","repos_url":"https://api.github.com/users/legrego/repos","events_url":"https://api.github.com/users/legrego/events{/privacy}","received_events_url":"https://api.github.com/users/legrego/received_events","type":"User","site_admin":false},"labels":[{"id":820277882,"node_id":"MDU6TGFiZWw4MjAyNzc4ODI=","url":"https://api.github.com/repos/elastic/kibana/labels/:Security","name":":Security","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":52,"created_at":"2018-07-30T13:52:42Z","updated_at":"2018-09-22T00:49:55Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/21408","html_url":"https://github.com/elastic/kibana/pull/21408","diff_url":"https://github.com/elastic/kibana/pull/21408.diff","patch_url":"https://github.com/elastic/kibana/pull/21408.patch"},"body":"### Review notes\r\nThis is generally ready for review. We are awaiting https://github.com/elastic/elasticsearch/issues/32777 to improve handling when users do not have any access to Kibana, but this should not hold up the overall review for this PR.\r\n\r\nThis PR is massive, there's no denying that. Here's what to focus on:\r\n1) `x-pack/plugins/spaces`: This is, well, the Spaces plugin. Everything in here is brand new. The server code is arguably more important, but feel free to review whatever you see fit.\r\n2) `x-pack/plugins/security`: There are large and significant changes here to allow Spaces to be securable. To save a bit of time, you are free to ignore changes in `x-pack/plugins/security/public`: These are the UI changes for the role management screen, which were previously reviewed by both us and the design team.\r\n3) `x-pack/test/saved_object_api_integration` and `x-pack/test/spaces_api_integration`: These are the API test suites which verify functionality for:\r\n     a) Both security and spaces enabled\r\n     b) Only security enabled\r\n     c) Only spaces enabled\r\n\r\nWhat to ignore:\r\n1) As mentioned above, you are free to ignore changes in `x-pack/plugins/security/public`\r\n2) Changes to `kibana/src/server/*`: These changes are part of a [different PR that we're targeting against master](https://github.com/elastic/kibana/pull/23378) for easier review.\r\n\r\n## Saved Objects Client Extensions\r\nA bulk of the changes to the saved objects service are in the namespaces PR, but we have a couple of important changes included here.\r\n\r\n### Priority Queue for wrappers\r\nWe have implemented a priority queue which allows plugins to specify the order in which their SOC wrapper should be applied: `kibana/src/server/saved_objects/service/lib/priority_collection.ts`. We are leveraging this to ensure that both the security SOC wrapper and the spaces SOC wrapper are applied in the correct order (more details below).\r\n\r\n### Spaces SOC Wrapper\r\nThis wrapper is very simple, and it is only responsible for two things:\r\n1) Prevent users from interacting with any `space` objects (use the Spaces client instead, described below)\r\n2) Provide a `namespace` to the underlying Saved Objects Client, and ensure that no other wrappers/callers have provided a namespace. In order to accomplish this, the Spaces wrapper uses the priority queue to ensure that it is the last wrapper invoked before calling the underlying client.\r\n\r\n### Security SOC Wrapper\r\nThis wrapper is responsible for performing authorization checks. It uses the priority queue to ensure that it is the first wrapper invoked. To say another way, if the authorization checks fail, then no other wrappers will be called, and the base client will not be called either. This wrapper authorizes users in one of two ways: RBAC or Legacy. More details on this are below.\r\n\r\n\r\n### Examples:\r\n`GET /s/marketing/api/saved_objects/index-pattern/foo`\r\n\r\n**When both Security and Spaces are enabled:**\r\n1) Saved objects API retrieves an instance of the SOC via `savedObjects.getScopedClient()`, and invokes its `get` function\r\n2) The Security wrapper is invoked.\r\n    a) Authorization checks are performed to ensure user can access this particular saved object at this space.\r\n3) The Spaces wrapper is invoked.\r\n   a) Spaces applies a `namespace` to be used by the underlying client\r\n4) The underlying client/repository are invoked to retrieve the object from ES.\r\n\r\n**When only Spaces are enabled:**\r\n1) Saved objects API retrieves an instance of the SOC via `savedObjects.getScopedClient()`, and invokes its `get` function\r\n2) The Spaces wrapper is invoked.\r\n   a) Spaces applies a `namespace` to be used by the underlying client\r\n3) The underlying client/repository are invoked to retrieve the object from ES.\r\n\r\n**When only Security is enabled:**\r\n(assume `/s/marketing` is no longer part of the request)\r\n1) Saved objects API retrieves an instance of the SOC via `savedObjects.getScopedClient()`, and invokes its `get` function\r\n2) The Security wrapper is invoked.\r\n   a) Authorization checks are performed to ensure user can access this particular saved object globally.\r\n3) The underlying client/repository are invoked to retrieve the object from ES.\r\n\r\n## Authorization\r\nAuthorization changes for this project are centered around Saved Objects, and builds on the work introduced in RBAC Phase 1.\r\n\r\n### Saved objects client\r\n#### Security without spaces\r\nWhen security is enabled, but spaces is disabled, then the authorization model behaves the same way as before: If the user is taking advantage of Kibana Privileges, then we check their privileges \"globally\" before proceeding. A \"global\" privilege check specifies `resources: ['*']` when calling the [ES _has_privileges api.](https://www.elastic.co/guide/en/elasticsearch/reference/current/security-api-has-privileges.html). Legacy users (non-rbac) will continue to use the underlying index privileges for authorization.\r\n\r\n#### Security with spaces\r\nWhen both plugins are enabled, then the authorization model becomes more fine-tuned. Rather than checking privileges globally, the privileges are checked against a specific resource that matches the user's active space. In order to accomplish this, the Security plugin needs to know if Spaces is enabled, and if so, it needs to ask Spaces for the user's active space. The subsequent call to the `ES _has_privileges api` would use `resources: ['space:marketing']` to verify that the user is authorized at the `marketing` space. Legacy users (non-rbac) will continue to use the underlying index privileges for authorization. **NOTE** The legacy behavior implies that those users will have access to all spaces. The read/write restrictions are still enforced, but there is no way to restrict access to a specific space for legacy auth users.\r\n\r\n#### Spaces without security\r\nNo authorization performed. Everyone can access everything.\r\n\r\n### Spaces client\r\nSpaces, when enabled, prevents saved objects of type `space` from being CRUD'd via the Saved Objects Client. Instead, the only \"approved\" way to work with these objects is through the new Spaces client (`kibana/x-pack/plugins/spaces/lib/spaces_client.ts`).\r\n\r\nWhen security is enabled, the Spaces client performs its own set of authorization checks before allowing the request to proceed. The Spaces client knows which authorization checks need to happen for a particular request, but it doesn't know _how_ to check privileges. To accomplish this, the spaces client will delegate the check security's authorization service.\r\n\r\n#### FAQ: Why oh why can't you used the Saved Objects Client instead!?\r\nThat's a great question! We did this primarily to simplify the authorization model (at least for our initial release). Accessing regular saved objects follows a predictible authorization pattern (described above). Spaces themselves inform the authorization model, and this interplay would have greatly increased the complexity. We are brainstorming ideas to obselete the Spaces client in favor of using the Saved Objects Client everywhere, but that's certainly out of scope for this release.\r\n\r\n\r\n\r\n## Test Coverage\r\n### Saved Objects API\r\nA bulk of the changes to enable spaces are centered around saved objects, so we have spent a majority of our time automating tests against the saved objects api.\r\n\r\n**`x-pack/test/saved_object_api_integration/`** contains the test suites for the saved objects api. There is a `common/suites` subfolder which contains a bulk of the test logic. The suites defined here are used in the following test configurations:\r\n1) Spaces only: `./spaces_only`\r\n2) Security and spaces: `./security_and_spaces`\r\n3) Security only: `./security_only`\r\n\r\nEach of these test configurations will start up ES/Kibana with the appropriate license and plugin set. Each set runs through the entire test suite described in `common/suites`. Each test with in each suite is run multiple times with different inputs, to test the various permutations of authentication, authorization type (legacy vs RBAC), space-level privileges, and the user's active space.  \r\n\r\n### Spaces API\r\nSpaces provides an experimental public API.\r\n\r\n**`x-pack/test/spaces_api_integration`** contains the test suites for the Spaces API. Similar to the Saved Objects API tests described above, there is a `common/suites` folder which contains a bulk of the test logic. The suites defined here are used in the following test configurations:\r\n1) Spaces only: `./spaces_only`\r\n2) Security and spaces: `./security_and_spaces`\r\n\r\n\r\n### Role Management UI\r\nWe did not provide any new functional UI tests for role management, but the existing suite was updated to accomidate the screen rewrite.\r\n\r\nWe do have a decent suite of jest unit tests for the various components that make up the new role management screen. They're nested within `kibana/x-pack/plugins/security/public/views/management/edit_role`\r\n\r\n### Spaces Management UI\r\nWe did not provide any new functional UI tests for spaces management, but the components that make up the screens are well-tested, and can be found within `kibana/x-pack/plugins/spaces/public/views/management/edit_space`\r\n\r\n### Spaces Functional UI Tests\r\nThere are a couple of UI tests that verify _basic_ functionality. They assert that a user can login, select a space, and then choose a different space once inside: `kibana/x-pack/test/functional/apps/spaces`\r\n\r\n\r\n\r\n## Reference\r\n\r\nNotable child PRs are listed below for easier digesting. Note that some of these PRs are built on other PRs, so the deltas in the links below may be outdated. Cross reference with this PR when in doubt.\r\n\r\n### UI\r\n- Reactify Role Management Screen: https://github.com/elastic/kibana/pull/19035\r\n- Space Aware Privileges UI: https://github.com/elastic/kibana/pull/21049\r\n- Space Selector (in Kibana Nav): https://github.com/elastic/kibana/pull/19497\r\n- Recently viewed Widget: https://github.com/elastic/kibana/pull/22492\r\n- Support Space rename/delete: https://github.com/elastic/kibana/pull/22586\r\n\r\n### Saved Objects Client\r\n- ~~Space Aware Saved Objects: https://github.com/elastic/kibana/pull/18862~~\r\n- ~~Add Space ID to document id: https://github.com/elastic/kibana/pull/21372~~\r\n- Saved object namespaces (supercedes #18862 and #21372):  https://github.com/elastic/kibana/pull/22357\r\n- Securing saved objects: https://github.com/elastic/kibana/pull/21995\r\n- Dedicated Spaces client (w/ security): https://github.com/elastic/kibana/pull/21995\r\n\r\n### Other\r\n- Public Spaces API (experimental): https://github.com/elastic/kibana/pull/22501\r\n- Telemetry: https://github.com/elastic/kibana/pull/20581\r\n- Reporting: https://github.com/elastic/kibana/pull/21457\r\n- Spencer's original Spaces work: https://github.com/elastic/kibana/pull/18664\r\n- Expose `spaceId` to \"Add Data\" tutorials: https://github.com/elastic/kibana/pull/22760\r\n\r\nCloses #18948 \r\n\r\n\"Release Note: Create spaces within Kibana to organize dashboards, visualizations, and other saved objects. Secure access to each space when X-Pack Security is enabled\""},"comment":{"url":"https://api.github.com/repos/elastic/kibana/issues/comments/423704713","html_url":"https://github.com/elastic/kibana/pull/21408#issuecomment-423704713","issue_url":"https://api.github.com/repos/elastic/kibana/issues/21408","id":423704713,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMzcwNDcxMw==","user":{"login":"spalger","id":1329312,"node_id":"MDQ6VXNlcjEzMjkzMTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1329312?v=4","gravatar_id":"","url":"https://api.github.com/users/spalger","html_url":"https://github.com/spalger","followers_url":"https://api.github.com/users/spalger/followers","following_url":"https://api.github.com/users/spalger/following{/other_user}","gists_url":"https://api.github.com/users/spalger/gists{/gist_id}","starred_url":"https://api.github.com/users/spalger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spalger/subscriptions","organizations_url":"https://api.github.com/users/spalger/orgs","repos_url":"https://api.github.com/users/spalger/repos","events_url":"https://api.github.com/users/spalger/events{/privacy}","received_events_url":"https://api.github.com/users/spalger/received_events","type":"User","site_admin":false},"created_at":"2018-09-22T00:49:55Z","updated_at":"2018-09-22T00:49:55Z","author_association":"MEMBER","body":"I've dug through a lot of this, focusing mostly on the integration with security, the saved objects client, and test coverage, and I'm pretty confident this is going to be great. Thanks for being available to answer my questions @legrego and @kobelb, and thanks for all the hard work on this epic feature!"}}
{"actor":{"display_login":"spalger"}}