{"action":"created","comment":{"url":"https://api.github.com/repos/wix/react-native-ui-lib/pulls/comments/244733111","pull_request_review_id":188673715,"id":244733111,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDczMzExMQ==","diff_hunk":"@@ -1,51 +1,59 @@\n // const validColors = require(\"./src/style/colorsPalette\").colorsPalette;\n // const extraFixColorsMap = require(\"./src/style/colorsPalette\").extraFixColorsMap;\n // const assetsDepJson = require('./eslint-rules/tests/assets_deprecation.json');\n+// const deprecationsJson = require('./eslint-rules/tests/component_deprecation.json');\n \n module.exports = {\n-  \"parser\": \"babel-eslint\",\n-  \"plugins\": [\"react-native\", \"uilib\"],\n-  \"extends\": [\"airbnb\"],\n-  \"rules\": {\n-    \"arrow-body-style\": \"off\",\n-    \"class-methods-use-this\": \"off\",\n-    \"consistent-return\": \"off\",\n-    \"global-require\": \"off\",\n-    \"max-len\": [2, 130, 4, {\"ignoreUrls\": true}],\n-    \"no-nested-ternary\": \"off\",\n-    \"no-else-return\": \"off\",\n-    \"no-plusplus\": \"off\",\n-    \"no-return-assign\": \"off\",\n-    \"no-trailing-spaces\": \"off\",\n-    \"no-use-before-define\": \"off\",\n-    \"no-unneeded-ternary\": \"off\",\n-    \"object-curly-spacing\": \"off\",\n-    \"react/forbid-prop-types\": \"off\",\n-    \"react/jsx-filename-extension\": \"off\",\n-    \"react/jsx-space-before-closing\": \"off\",\n-    \"react/jsx-tag-spacing\": \"off\",\n-    \"react/prefer-stateless-function\": \"off\",\n-    \"react/require-default-props\": \"off\",\n+  'parser': 'babel-eslint',\n+  'plugins': ['react-native', 'uilib'],","path":".eslintrc.js","position":31,"original_position":31,"commit_id":"f51c683daa511485bbd778107a0287e001f02dbe","original_commit_id":"f51c683daa511485bbd778107a0287e001f02dbe","user":{"login":"ethanshar","id":1780255,"node_id":"MDQ6VXNlcjE3ODAyNTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1780255?v=4","gravatar_id":"","url":"https://api.github.com/users/ethanshar","html_url":"https://github.com/ethanshar","followers_url":"https://api.github.com/users/ethanshar/followers","following_url":"https://api.github.com/users/ethanshar/following{/other_user}","gists_url":"https://api.github.com/users/ethanshar/gists{/gist_id}","starred_url":"https://api.github.com/users/ethanshar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethanshar/subscriptions","organizations_url":"https://api.github.com/users/ethanshar/orgs","repos_url":"https://api.github.com/users/ethanshar/repos","events_url":"https://api.github.com/users/ethanshar/events{/privacy}","received_events_url":"https://api.github.com/users/ethanshar/received_events","type":"User","site_admin":false},"body":"does it mean uilib rules will be applied on our src files? ","created_at":"2019-01-02T13:17:37Z","updated_at":"2019-01-02T13:17:48Z","html_url":"https://github.com/wix/react-native-ui-lib/pull/343#discussion_r244733111","pull_request_url":"https://api.github.com/repos/wix/react-native-ui-lib/pulls/343","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/wix/react-native-ui-lib/pulls/comments/244733111"},"html":{"href":"https://github.com/wix/react-native-ui-lib/pull/343#discussion_r244733111"},"pull_request":{"href":"https://api.github.com/repos/wix/react-native-ui-lib/pulls/343"}}},"pull_request":{"url":"https://api.github.com/repos/wix/react-native-ui-lib/pulls/343","id":241715506,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNzE1NTA2","html_url":"https://github.com/wix/react-native-ui-lib/pull/343","diff_url":"https://github.com/wix/react-native-ui-lib/pull/343.diff","patch_url":"https://github.com/wix/react-native-ui-lib/pull/343.patch","issue_url":"https://api.github.com/repos/wix/react-native-ui-lib/issues/343","number":343,"state":"open","locked":false,"title":"Fix for deprecated components rule","user":{"login":"Inbal-Tish","id":33805983,"node_id":"MDQ6VXNlcjMzODA1OTgz","avatar_url":"https://avatars3.githubusercontent.com/u/33805983?v=4","gravatar_id":"","url":"https://api.github.com/users/Inbal-Tish","html_url":"https://github.com/Inbal-Tish","followers_url":"https://api.github.com/users/Inbal-Tish/followers","following_url":"https://api.github.com/users/Inbal-Tish/following{/other_user}","gists_url":"https://api.github.com/users/Inbal-Tish/gists{/gist_id}","starred_url":"https://api.github.com/users/Inbal-Tish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Inbal-Tish/subscriptions","organizations_url":"https://api.github.com/users/Inbal-Tish/orgs","repos_url":"https://api.github.com/users/Inbal-Tish/repos","events_url":"https://api.github.com/users/Inbal-Tish/events{/privacy}","received_events_url":"https://api.github.com/users/Inbal-Tish/received_events","type":"User","site_admin":false},"body":"To have a second alert on import (unless it's sub-component deprecation or prop deprecation)","created_at":"2019-01-02T10:39:21Z","updated_at":"2019-01-02T13:17:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"327ede5cd94c9bcf5d7de8915dc17a5e5de536db","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wix/react-native-ui-lib/pulls/343/commits","review_comments_url":"https://api.github.com/repos/wix/react-native-ui-lib/pulls/343/comments","review_comment_url":"https://api.github.com/repos/wix/react-native-ui-lib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wix/react-native-ui-lib/issues/343/comments","statuses_url":"https://api.github.com/repos/wix/react-native-ui-lib/statuses/f51c683daa511485bbd778107a0287e001f02dbe","head":{"label":"wix:fix/component_deprecation_lint","ref":"fix/component_deprecation_lint","sha":"f51c683daa511485bbd778107a0287e001f02dbe","user":{"login":"wix","id":686511,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/686511?v=4","gravatar_id":"","url":"https://api.github.com/users/wix","html_url":"https://github.com/wix","followers_url":"https://api.github.com/users/wix/followers","following_url":"https://api.github.com/users/wix/following{/other_user}","gists_url":"https://api.github.com/users/wix/gists{/gist_id}","starred_url":"https://api.github.com/users/wix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wix/subscriptions","organizations_url":"https://api.github.com/users/wix/orgs","repos_url":"https://api.github.com/users/wix/repos","events_url":"https://api.github.com/users/wix/events{/privacy}","received_events_url":"https://api.github.com/users/wix/received_events","type":"Organization","site_admin":false},"repo":{"id":81314550,"node_id":"MDEwOlJlcG9zaXRvcnk4MTMxNDU1MA==","name":"react-native-ui-lib","full_name":"wix/react-native-ui-lib","private":false,"owner":{"login":"wix","id":686511,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/686511?v=4","gravatar_id":"","url":"https://api.github.com/users/wix","html_url":"https://github.com/wix","followers_url":"https://api.github.com/users/wix/followers","following_url":"https://api.github.com/users/wix/following{/other_user}","gists_url":"https://api.github.com/users/wix/gists{/gist_id}","starred_url":"https://api.github.com/users/wix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wix/subscriptions","organizations_url":"https://api.github.com/users/wix/orgs","repos_url":"https://api.github.com/users/wix/repos","events_url":"https://api.github.com/users/wix/events{/privacy}","received_events_url":"https://api.github.com/users/wix/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wix/react-native-ui-lib","description":"UI Components Library for React Native","fork":false,"url":"https://api.github.com/repos/wix/react-native-ui-lib","forks_url":"https://api.github.com/repos/wix/react-native-ui-lib/forks","keys_url":"https://api.github.com/repos/wix/react-native-ui-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wix/react-native-ui-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wix/react-native-ui-lib/teams","hooks_url":"https://api.github.com/repos/wix/react-native-ui-lib/hooks","issue_events_url":"https://api.github.com/repos/wix/react-native-ui-lib/issues/events{/number}","events_url":"https://api.github.com/repos/wix/react-native-ui-lib/events","assignees_url":"https://api.github.com/repos/wix/react-native-ui-lib/assignees{/user}","branches_url":"https://api.github.com/repos/wix/react-native-ui-lib/branches{/branch}","tags_url":"https://api.github.com/repos/wix/react-native-ui-lib/tags","blobs_url":"https://api.github.com/repos/wix/react-native-ui-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wix/react-native-ui-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wix/react-native-ui-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/wix/react-native-ui-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wix/react-native-ui-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/wix/react-native-ui-lib/languages","stargazers_url":"https://api.github.com/repos/wix/react-native-ui-lib/stargazers","contributors_url":"https://api.github.com/repos/wix/react-native-ui-lib/contributors","subscribers_url":"https://api.github.com/repos/wix/react-native-ui-lib/subscribers","subscription_url":"https://api.github.com/repos/wix/react-native-ui-lib/subscription","commits_url":"https://api.github.com/repos/wix/react-native-ui-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/wix/react-native-ui-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/wix/react-native-ui-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/wix/react-native-ui-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/wix/react-native-ui-lib/contents/{+path}","compare_url":"https://api.github.com/repos/wix/react-native-ui-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wix/react-native-ui-lib/merges","archive_url":"https://api.github.com/repos/wix/react-native-ui-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wix/react-native-ui-lib/downloads","issues_url":"https://api.github.com/repos/wix/react-native-ui-lib/issues{/number}","pulls_url":"https://api.github.com/repos/wix/react-native-ui-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/wix/react-native-ui-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/wix/react-native-ui-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wix/react-native-ui-lib/labels{/name}","releases_url":"https://api.github.com/repos/wix/react-native-ui-lib/releases{/id}","deployments_url":"https://api.github.com/repos/wix/react-native-ui-lib/deployments","created_at":"2017-02-08T09:55:18Z","updated_at":"2019-01-02T01:53:08Z","pushed_at":"2019-01-02T13:15:48Z","git_url":"git://github.com/wix/react-native-ui-lib.git","ssh_url":"git@github.com:wix/react-native-ui-lib.git","clone_url":"https://github.com/wix/react-native-ui-lib.git","svn_url":"https://github.com/wix/react-native-ui-lib","homepage":"https://wix.github.io/react-native-ui-lib/","size":33776,"stargazers_count":1361,"watchers_count":1361,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":150,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":150,"open_issues":26,"watchers":1361,"default_branch":"master"}},"base":{"label":"wix:master","ref":"master","sha":"202a860dd1f67413a069194142828ea3c52751f4","user":{"login":"wix","id":686511,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/686511?v=4","gravatar_id":"","url":"https://api.github.com/users/wix","html_url":"https://github.com/wix","followers_url":"https://api.github.com/users/wix/followers","following_url":"https://api.github.com/users/wix/following{/other_user}","gists_url":"https://api.github.com/users/wix/gists{/gist_id}","starred_url":"https://api.github.com/users/wix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wix/subscriptions","organizations_url":"https://api.github.com/users/wix/orgs","repos_url":"https://api.github.com/users/wix/repos","events_url":"https://api.github.com/users/wix/events{/privacy}","received_events_url":"https://api.github.com/users/wix/received_events","type":"Organization","site_admin":false},"repo":{"id":81314550,"node_id":"MDEwOlJlcG9zaXRvcnk4MTMxNDU1MA==","name":"react-native-ui-lib","full_name":"wix/react-native-ui-lib","private":false,"owner":{"login":"wix","id":686511,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/686511?v=4","gravatar_id":"","url":"https://api.github.com/users/wix","html_url":"https://github.com/wix","followers_url":"https://api.github.com/users/wix/followers","following_url":"https://api.github.com/users/wix/following{/other_user}","gists_url":"https://api.github.com/users/wix/gists{/gist_id}","starred_url":"https://api.github.com/users/wix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wix/subscriptions","organizations_url":"https://api.github.com/users/wix/orgs","repos_url":"https://api.github.com/users/wix/repos","events_url":"https://api.github.com/users/wix/events{/privacy}","received_events_url":"https://api.github.com/users/wix/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wix/react-native-ui-lib","description":"UI Components Library for React Native","fork":false,"url":"https://api.github.com/repos/wix/react-native-ui-lib","forks_url":"https://api.github.com/repos/wix/react-native-ui-lib/forks","keys_url":"https://api.github.com/repos/wix/react-native-ui-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wix/react-native-ui-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wix/react-native-ui-lib/teams","hooks_url":"https://api.github.com/repos/wix/react-native-ui-lib/hooks","issue_events_url":"https://api.github.com/repos/wix/react-native-ui-lib/issues/events{/number}","events_url":"https://api.github.com/repos/wix/react-native-ui-lib/events","assignees_url":"https://api.github.com/repos/wix/react-native-ui-lib/assignees{/user}","branches_url":"https://api.github.com/repos/wix/react-native-ui-lib/branches{/branch}","tags_url":"https://api.github.com/repos/wix/react-native-ui-lib/tags","blobs_url":"https://api.github.com/repos/wix/react-native-ui-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wix/react-native-ui-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wix/react-native-ui-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/wix/react-native-ui-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wix/react-native-ui-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/wix/react-native-ui-lib/languages","stargazers_url":"https://api.github.com/repos/wix/react-native-ui-lib/stargazers","contributors_url":"https://api.github.com/repos/wix/react-native-ui-lib/contributors","subscribers_url":"https://api.github.com/repos/wix/react-native-ui-lib/subscribers","subscription_url":"https://api.github.com/repos/wix/react-native-ui-lib/subscription","commits_url":"https://api.github.com/repos/wix/react-native-ui-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/wix/react-native-ui-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/wix/react-native-ui-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/wix/react-native-ui-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/wix/react-native-ui-lib/contents/{+path}","compare_url":"https://api.github.com/repos/wix/react-native-ui-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wix/react-native-ui-lib/merges","archive_url":"https://api.github.com/repos/wix/react-native-ui-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wix/react-native-ui-lib/downloads","issues_url":"https://api.github.com/repos/wix/react-native-ui-lib/issues{/number}","pulls_url":"https://api.github.com/repos/wix/react-native-ui-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/wix/react-native-ui-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/wix/react-native-ui-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wix/react-native-ui-lib/labels{/name}","releases_url":"https://api.github.com/repos/wix/react-native-ui-lib/releases{/id}","deployments_url":"https://api.github.com/repos/wix/react-native-ui-lib/deployments","created_at":"2017-02-08T09:55:18Z","updated_at":"2019-01-02T01:53:08Z","pushed_at":"2019-01-02T13:15:48Z","git_url":"git://github.com/wix/react-native-ui-lib.git","ssh_url":"git@github.com:wix/react-native-ui-lib.git","clone_url":"https://github.com/wix/react-native-ui-lib.git","svn_url":"https://github.com/wix/react-native-ui-lib","homepage":"https://wix.github.io/react-native-ui-lib/","size":33776,"stargazers_count":1361,"watchers_count":1361,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":150,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":150,"open_issues":26,"watchers":1361,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wix/react-native-ui-lib/pulls/343"},"html":{"href":"https://github.com/wix/react-native-ui-lib/pull/343"},"issue":{"href":"https://api.github.com/repos/wix/react-native-ui-lib/issues/343"},"comments":{"href":"https://api.github.com/repos/wix/react-native-ui-lib/issues/343/comments"},"review_comments":{"href":"https://api.github.com/repos/wix/react-native-ui-lib/pulls/343/comments"},"review_comment":{"href":"https://api.github.com/repos/wix/react-native-ui-lib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wix/react-native-ui-lib/pulls/343/commits"},"statuses":{"href":"https://api.github.com/repos/wix/react-native-ui-lib/statuses/f51c683daa511485bbd778107a0287e001f02dbe"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"ethanshar"}}