{"action":"created","issue":{"url":"https://api.github.com/repos/OrchardCMS/OrchardCore/issues/1483","repository_url":"https://api.github.com/repos/OrchardCMS/OrchardCore","labels_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/issues/1483/labels{/name}","comments_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/issues/1483/comments","events_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/issues/1483/events","html_url":"https://github.com/OrchardCMS/OrchardCore/pull/1483","id":296604911,"number":1483,"title":"Get rid of modules manifest files","user":{"login":"jtkech","id":8586360,"avatar_url":"https://avatars1.githubusercontent.com/u/8586360?v=4","gravatar_id":"","url":"https://api.github.com/users/jtkech","html_url":"https://github.com/jtkech","followers_url":"https://api.github.com/users/jtkech/followers","following_url":"https://api.github.com/users/jtkech/following{/other_user}","gists_url":"https://api.github.com/users/jtkech/gists{/gist_id}","starred_url":"https://api.github.com/users/jtkech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtkech/subscriptions","organizations_url":"https://api.github.com/users/jtkech/orgs","repos_url":"https://api.github.com/users/jtkech/repos","events_url":"https://api.github.com/users/jtkech/events{/privacy}","received_events_url":"https://api.github.com/users/jtkech/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-13T03:48:20Z","updated_at":"2018-02-14T01:09:29Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/OrchardCMS/OrchardCore/pulls/1483","html_url":"https://github.com/OrchardCMS/OrchardCore/pull/1483","diff_url":"https://github.com/OrchardCMS/OrchardCore/pull/1483.diff","patch_url":"https://github.com/OrchardCMS/OrchardCore/pull/1483.patch"},"body":"Fixes #1420 \r\n\r\nSo, here a version that seems to fully work without modules manifest files.\r\n\r\n- Need more checkings.\r\n\r\n- I removed some components that maybe we want to keep, let me know.\r\n\r\n- I integrated some changes related to some of my other PRs but that i needed here for testing things. E.g to show the full dependencies of each feature in the modules page of the admin.\r\n\r\n- I also have a testing version which not uses the `modules.names.map` file which is updated on building. This by resolving modules names at run time. Let me know if it is worth to work on this.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/OrchardCMS/OrchardCore/issues/comments/365461513","html_url":"https://github.com/OrchardCMS/OrchardCore/pull/1483#issuecomment-365461513","issue_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/issues/1483","id":365461513,"user":{"login":"jtkech","id":8586360,"avatar_url":"https://avatars1.githubusercontent.com/u/8586360?v=4","gravatar_id":"","url":"https://api.github.com/users/jtkech","html_url":"https://github.com/jtkech","followers_url":"https://api.github.com/users/jtkech/followers","following_url":"https://api.github.com/users/jtkech/following{/other_user}","gists_url":"https://api.github.com/users/jtkech/gists{/gist_id}","starred_url":"https://api.github.com/users/jtkech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtkech/subscriptions","organizations_url":"https://api.github.com/users/jtkech/orgs","repos_url":"https://api.github.com/users/jtkech/repos","events_url":"https://api.github.com/users/jtkech/events{/privacy}","received_events_url":"https://api.github.com/users/jtkech/received_events","type":"User","site_admin":false},"created_at":"2018-02-14T01:09:29Z","updated_at":"2018-02-14T01:09:29Z","author_association":"MEMBER","body":"I answer to my own question ;)\r\n\r\n> Which syntax you prefer?\r\n\r\nI think @PinpointTownes is right, better to use c# naming conventions. I will update it."}}
{"actor":{"display_login":"jtkech"}}