{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Blazor/pulls/comments/219598538","pull_request_review_id":157821597,"id":219598538,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTU5ODUzOA==","diff_hunk":"@@ -218,48 +217,55 @@ private void RewriteChildren(RazorSourceDocument source, IntermediateNode node)\n                                             stack.Pop();\n                                         }\n \n-                                        if (token.Type == HtmlTokenType.EndTag)\n+                                        break;\n+                                    }\n+\n+                                case HtmlTokenType.EndTag:\n+                                    {\n+                                        var tag = token.AsTag();\n+\n+                                        var popped = stack.Pop();\n+                                        if (stack.Count == 0)\n                                         {\n-                                            var popped = stack.Pop();\n-                                            if (stack.Count == 0)\n+                                            // If we managed to 'bottom out' the stack then we have an unbalanced end tag.\n+                                            // Put back the current node so we don't crash.\n+                                            stack.Push(popped);\n+\n+                                            var tagName = parser.GetTagNameOriginalCasing(token.AsTag());","path":"src/Microsoft.AspNetCore.Blazor.Razor.Extensions/ComponentDocumentRewritePass.cs","position":38,"original_position":38,"commit_id":"6801e14a6d71b614895d5fc6cfa71d470538f366","original_commit_id":"6801e14a6d71b614895d5fc6cfa71d470538f366","user":{"login":"rynowak","id":1430011,"node_id":"MDQ6VXNlcjE0MzAwMTE=","avatar_url":"https://avatars1.githubusercontent.com/u/1430011?v=4","gravatar_id":"","url":"https://api.github.com/users/rynowak","html_url":"https://github.com/rynowak","followers_url":"https://api.github.com/users/rynowak/followers","following_url":"https://api.github.com/users/rynowak/following{/other_user}","gists_url":"https://api.github.com/users/rynowak/gists{/gist_id}","starred_url":"https://api.github.com/users/rynowak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rynowak/subscriptions","organizations_url":"https://api.github.com/users/rynowak/orgs","repos_url":"https://api.github.com/users/rynowak/repos","events_url":"https://api.github.com/users/rynowak/events{/privacy}","received_events_url":"https://api.github.com/users/rynowak/received_events","type":"User","site_admin":false},"body":"yeah, you're right 👍 ","created_at":"2018-09-21T19:04:23Z","updated_at":"2018-09-21T19:04:24Z","html_url":"https://github.com/aspnet/Blazor/pull/1457#discussion_r219598538","pull_request_url":"https://api.github.com/repos/aspnet/Blazor/pulls/1457","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Blazor/pulls/comments/219598538"},"html":{"href":"https://github.com/aspnet/Blazor/pull/1457#discussion_r219598538"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Blazor/pulls/1457"}},"in_reply_to_id":219460561},"pull_request":{"url":"https://api.github.com/repos/aspnet/Blazor/pulls/1457","id":217106380,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MTA2Mzgw","html_url":"https://github.com/aspnet/Blazor/pull/1457","diff_url":"https://github.com/aspnet/Blazor/pull/1457.diff","patch_url":"https://github.com/aspnet/Blazor/pull/1457.patch","issue_url":"https://api.github.com/repos/aspnet/Blazor/issues/1457","number":1457,"state":"open","locked":false,"title":"Fix #1399 - crash on start-end syntax for void element","user":{"login":"rynowak","id":1430011,"node_id":"MDQ6VXNlcjE0MzAwMTE=","avatar_url":"https://avatars1.githubusercontent.com/u/1430011?v=4","gravatar_id":"","url":"https://api.github.com/users/rynowak","html_url":"https://github.com/rynowak","followers_url":"https://api.github.com/users/rynowak/followers","following_url":"https://api.github.com/users/rynowak/following{/other_user}","gists_url":"https://api.github.com/users/rynowak/gists{/gist_id}","starred_url":"https://api.github.com/users/rynowak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rynowak/subscriptions","organizations_url":"https://api.github.com/users/rynowak/orgs","repos_url":"https://api.github.com/users/rynowak/repos","events_url":"https://api.github.com/users/rynowak/events{/privacy}","received_events_url":"https://api.github.com/users/rynowak/received_events","type":"User","site_admin":false},"body":"We weren't correctly recovering when a void element is written as a\r\nstart-end pair. This change cleans up some of the plumbing around\r\nend-tag handling and adds recognition for this case.\r\n\r\nAdded a new bespoke diagnostic for the void element case.","created_at":"2018-09-20T21:03:59Z","updated_at":"2018-09-21T19:04:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3049739089cb77fe2073e6ad6e2d7f0645f07833","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Blazor/pulls/1457/commits","review_comments_url":"https://api.github.com/repos/aspnet/Blazor/pulls/1457/comments","review_comment_url":"https://api.github.com/repos/aspnet/Blazor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/Blazor/issues/1457/comments","statuses_url":"https://api.github.com/repos/aspnet/Blazor/statuses/6801e14a6d71b614895d5fc6cfa71d470538f366","head":{"label":"aspnet:rynowak/fix-1399","ref":"rynowak/fix-1399","sha":"6801e14a6d71b614895d5fc6cfa71d470538f366","user":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":116160755,"node_id":"MDEwOlJlcG9zaXRvcnkxMTYxNjA3NTU=","name":"Blazor","full_name":"aspnet/Blazor","private":false,"owner":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aspnet/Blazor","description":"Blazor is an experimental .NET web framework using C#/Razor and HTML that runs in the browser with WebAssembly","fork":false,"url":"https://api.github.com/repos/aspnet/Blazor","forks_url":"https://api.github.com/repos/aspnet/Blazor/forks","keys_url":"https://api.github.com/repos/aspnet/Blazor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Blazor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Blazor/teams","hooks_url":"https://api.github.com/repos/aspnet/Blazor/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Blazor/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Blazor/events","assignees_url":"https://api.github.com/repos/aspnet/Blazor/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Blazor/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Blazor/tags","blobs_url":"https://api.github.com/repos/aspnet/Blazor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Blazor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Blazor/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Blazor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Blazor/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Blazor/languages","stargazers_url":"https://api.github.com/repos/aspnet/Blazor/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Blazor/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Blazor/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Blazor/subscription","commits_url":"https://api.github.com/repos/aspnet/Blazor/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Blazor/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Blazor/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Blazor/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Blazor/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Blazor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Blazor/merges","archive_url":"https://api.github.com/repos/aspnet/Blazor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Blazor/downloads","issues_url":"https://api.github.com/repos/aspnet/Blazor/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Blazor/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Blazor/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Blazor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Blazor/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Blazor/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/Blazor/deployments","created_at":"2018-01-03T16:53:27Z","updated_at":"2018-09-21T18:55:52Z","pushed_at":"2018-09-20T21:27:14Z","git_url":"git://github.com/aspnet/Blazor.git","ssh_url":"git@github.com:aspnet/Blazor.git","clone_url":"https://github.com/aspnet/Blazor.git","svn_url":"https://github.com/aspnet/Blazor","homepage":"https://blazor.net/","size":176526,"stargazers_count":6511,"watchers_count":6511,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":556,"mirror_url":null,"archived":false,"open_issues_count":162,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":556,"open_issues":162,"watchers":6511,"default_branch":"master"}},"base":{"label":"aspnet:master","ref":"master","sha":"ce11f517d370b501433a62a56fbd4be1704000ad","user":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":116160755,"node_id":"MDEwOlJlcG9zaXRvcnkxMTYxNjA3NTU=","name":"Blazor","full_name":"aspnet/Blazor","private":false,"owner":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aspnet/Blazor","description":"Blazor is an experimental .NET web framework using C#/Razor and HTML that runs in the browser with WebAssembly","fork":false,"url":"https://api.github.com/repos/aspnet/Blazor","forks_url":"https://api.github.com/repos/aspnet/Blazor/forks","keys_url":"https://api.github.com/repos/aspnet/Blazor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Blazor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Blazor/teams","hooks_url":"https://api.github.com/repos/aspnet/Blazor/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Blazor/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Blazor/events","assignees_url":"https://api.github.com/repos/aspnet/Blazor/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Blazor/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Blazor/tags","blobs_url":"https://api.github.com/repos/aspnet/Blazor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Blazor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Blazor/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Blazor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Blazor/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Blazor/languages","stargazers_url":"https://api.github.com/repos/aspnet/Blazor/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Blazor/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Blazor/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Blazor/subscription","commits_url":"https://api.github.com/repos/aspnet/Blazor/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Blazor/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Blazor/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Blazor/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Blazor/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Blazor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Blazor/merges","archive_url":"https://api.github.com/repos/aspnet/Blazor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Blazor/downloads","issues_url":"https://api.github.com/repos/aspnet/Blazor/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Blazor/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Blazor/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Blazor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Blazor/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Blazor/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/Blazor/deployments","created_at":"2018-01-03T16:53:27Z","updated_at":"2018-09-21T18:55:52Z","pushed_at":"2018-09-20T21:27:14Z","git_url":"git://github.com/aspnet/Blazor.git","ssh_url":"git@github.com:aspnet/Blazor.git","clone_url":"https://github.com/aspnet/Blazor.git","svn_url":"https://github.com/aspnet/Blazor","homepage":"https://blazor.net/","size":176526,"stargazers_count":6511,"watchers_count":6511,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":556,"mirror_url":null,"archived":false,"open_issues_count":162,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":556,"open_issues":162,"watchers":6511,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Blazor/pulls/1457"},"html":{"href":"https://github.com/aspnet/Blazor/pull/1457"},"issue":{"href":"https://api.github.com/repos/aspnet/Blazor/issues/1457"},"comments":{"href":"https://api.github.com/repos/aspnet/Blazor/issues/1457/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Blazor/pulls/1457/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Blazor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Blazor/pulls/1457/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Blazor/statuses/6801e14a6d71b614895d5fc6cfa71d470538f366"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"rynowak"}}