{"action":"created","comment":{"url":"https://api.github.com/repos/go-python/gopy/pulls/comments/194640978","pull_request_review_id":127848503,"id":194640978,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDY0MDk3OA==","diff_hunk":"@@ -20,6 +20,9 @@ func (g *cpyGen) genType(sym *symbol) {\n \tif sym.isBasic() && !sym.isNamed() {\n \t\treturn\n \t}\n+\tif (sym.kind & skPointer) != 0 {","path":"bind/gencpy_type.go","position":4,"original_position":4,"commit_id":"77b69b39c55f56e5aff44d395bea253266d24df3","original_commit_id":"77b69b39c55f56e5aff44d395bea253266d24df3","user":{"login":"sbinet","id":1070920,"node_id":"MDQ6VXNlcjEwNzA5MjA=","avatar_url":"https://avatars2.githubusercontent.com/u/1070920?v=4","gravatar_id":"","url":"https://api.github.com/users/sbinet","html_url":"https://github.com/sbinet","followers_url":"https://api.github.com/users/sbinet/followers","following_url":"https://api.github.com/users/sbinet/following{/other_user}","gists_url":"https://api.github.com/users/sbinet/gists{/gist_id}","starred_url":"https://api.github.com/users/sbinet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbinet/subscriptions","organizations_url":"https://api.github.com/users/sbinet/orgs","repos_url":"https://api.github.com/users/sbinet/repos","events_url":"https://api.github.com/users/sbinet/events{/privacy}","received_events_url":"https://api.github.com/users/sbinet/received_events","type":"User","site_admin":false},"body":"couldn't this be rewritten as:\r\n```go\r\nif sym.isPointer() {\r\n    return\r\n}\r\n```","created_at":"2018-06-12T07:40:15Z","updated_at":"2018-06-12T07:41:42Z","html_url":"https://github.com/go-python/gopy/pull/165#discussion_r194640978","pull_request_url":"https://api.github.com/repos/go-python/gopy/pulls/165","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/go-python/gopy/pulls/comments/194640978"},"html":{"href":"https://github.com/go-python/gopy/pull/165#discussion_r194640978"},"pull_request":{"href":"https://api.github.com/repos/go-python/gopy/pulls/165"}}},"pull_request":{"url":"https://api.github.com/repos/go-python/gopy/pulls/165","id":194040934,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MDQwOTM0","html_url":"https://github.com/go-python/gopy/pull/165","diff_url":"https://github.com/go-python/gopy/pull/165.diff","patch_url":"https://github.com/go-python/gopy/pull/165.patch","issue_url":"https://api.github.com/repos/go-python/gopy/issues/165","number":165,"state":"open","locked":false,"title":"Support for pointer-to-slice parameters","user":{"login":"ondra","id":22541,"node_id":"MDQ6VXNlcjIyNTQx","avatar_url":"https://avatars0.githubusercontent.com/u/22541?v=4","gravatar_id":"","url":"https://api.github.com/users/ondra","html_url":"https://github.com/ondra","followers_url":"https://api.github.com/users/ondra/followers","following_url":"https://api.github.com/users/ondra/following{/other_user}","gists_url":"https://api.github.com/users/ondra/gists{/gist_id}","starred_url":"https://api.github.com/users/ondra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ondra/subscriptions","organizations_url":"https://api.github.com/users/ondra/orgs","repos_url":"https://api.github.com/users/ondra/repos","events_url":"https://api.github.com/users/ondra/events{/privacy}","received_events_url":"https://api.github.com/users/ondra/received_events","type":"User","site_admin":false},"body":"Implement support for pointer-to-slice parameters for methods and functions:\r\n\r\nPython:\r\n```\r\nimport tst\r\ns = tst.StrSlice()\r\ntst.Fill(s)\r\nprint s\r\n```\r\n\r\nGo:\r\n```\r\npackage tst\r\ntype StrSlice []string\r\nfunc Fill(s *StrSlice) {\r\n        *s = StrSlice{\"A\", \"B\"}\r\n}\r\n```\r\n\r\nThis doesn't implement pointer support in general (as we didn't need it), but the fixes should make the implementation easier.","created_at":"2018-06-11T16:48:48Z","updated_at":"2018-06-12T07:41:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8cdc0f3aa15785ce7ddab994fc4152ae02c0616","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/go-python/gopy/pulls/165/commits","review_comments_url":"https://api.github.com/repos/go-python/gopy/pulls/165/comments","review_comment_url":"https://api.github.com/repos/go-python/gopy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/go-python/gopy/issues/165/comments","statuses_url":"https://api.github.com/repos/go-python/gopy/statuses/77b69b39c55f56e5aff44d395bea253266d24df3","head":{"label":"ondra:pointer_params","ref":"pointer_params","sha":"77b69b39c55f56e5aff44d395bea253266d24df3","user":{"login":"ondra","id":22541,"node_id":"MDQ6VXNlcjIyNTQx","avatar_url":"https://avatars0.githubusercontent.com/u/22541?v=4","gravatar_id":"","url":"https://api.github.com/users/ondra","html_url":"https://github.com/ondra","followers_url":"https://api.github.com/users/ondra/followers","following_url":"https://api.github.com/users/ondra/following{/other_user}","gists_url":"https://api.github.com/users/ondra/gists{/gist_id}","starred_url":"https://api.github.com/users/ondra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ondra/subscriptions","organizations_url":"https://api.github.com/users/ondra/orgs","repos_url":"https://api.github.com/users/ondra/repos","events_url":"https://api.github.com/users/ondra/events{/privacy}","received_events_url":"https://api.github.com/users/ondra/received_events","type":"User","site_admin":false},"repo":{"id":136947657,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY5NDc2NTc=","name":"gopy","full_name":"ondra/gopy","owner":{"login":"ondra","id":22541,"node_id":"MDQ6VXNlcjIyNTQx","avatar_url":"https://avatars0.githubusercontent.com/u/22541?v=4","gravatar_id":"","url":"https://api.github.com/users/ondra","html_url":"https://github.com/ondra","followers_url":"https://api.github.com/users/ondra/followers","following_url":"https://api.github.com/users/ondra/following{/other_user}","gists_url":"https://api.github.com/users/ondra/gists{/gist_id}","starred_url":"https://api.github.com/users/ondra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ondra/subscriptions","organizations_url":"https://api.github.com/users/ondra/orgs","repos_url":"https://api.github.com/users/ondra/repos","events_url":"https://api.github.com/users/ondra/events{/privacy}","received_events_url":"https://api.github.com/users/ondra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ondra/gopy","description":"gopy generates a CPython extension module from a go package.","fork":true,"url":"https://api.github.com/repos/ondra/gopy","forks_url":"https://api.github.com/repos/ondra/gopy/forks","keys_url":"https://api.github.com/repos/ondra/gopy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ondra/gopy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ondra/gopy/teams","hooks_url":"https://api.github.com/repos/ondra/gopy/hooks","issue_events_url":"https://api.github.com/repos/ondra/gopy/issues/events{/number}","events_url":"https://api.github.com/repos/ondra/gopy/events","assignees_url":"https://api.github.com/repos/ondra/gopy/assignees{/user}","branches_url":"https://api.github.com/repos/ondra/gopy/branches{/branch}","tags_url":"https://api.github.com/repos/ondra/gopy/tags","blobs_url":"https://api.github.com/repos/ondra/gopy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ondra/gopy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ondra/gopy/git/refs{/sha}","trees_url":"https://api.github.com/repos/ondra/gopy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ondra/gopy/statuses/{sha}","languages_url":"https://api.github.com/repos/ondra/gopy/languages","stargazers_url":"https://api.github.com/repos/ondra/gopy/stargazers","contributors_url":"https://api.github.com/repos/ondra/gopy/contributors","subscribers_url":"https://api.github.com/repos/ondra/gopy/subscribers","subscription_url":"https://api.github.com/repos/ondra/gopy/subscription","commits_url":"https://api.github.com/repos/ondra/gopy/commits{/sha}","git_commits_url":"https://api.github.com/repos/ondra/gopy/git/commits{/sha}","comments_url":"https://api.github.com/repos/ondra/gopy/comments{/number}","issue_comment_url":"https://api.github.com/repos/ondra/gopy/issues/comments{/number}","contents_url":"https://api.github.com/repos/ondra/gopy/contents/{+path}","compare_url":"https://api.github.com/repos/ondra/gopy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ondra/gopy/merges","archive_url":"https://api.github.com/repos/ondra/gopy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ondra/gopy/downloads","issues_url":"https://api.github.com/repos/ondra/gopy/issues{/number}","pulls_url":"https://api.github.com/repos/ondra/gopy/pulls{/number}","milestones_url":"https://api.github.com/repos/ondra/gopy/milestones{/number}","notifications_url":"https://api.github.com/repos/ondra/gopy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ondra/gopy/labels{/name}","releases_url":"https://api.github.com/repos/ondra/gopy/releases{/id}","deployments_url":"https://api.github.com/repos/ondra/gopy/deployments","created_at":"2018-06-11T15:45:36Z","updated_at":"2018-06-11T15:45:38Z","pushed_at":"2018-06-11T20:30:16Z","git_url":"git://github.com/ondra/gopy.git","ssh_url":"git@github.com:ondra/gopy.git","clone_url":"https://github.com/ondra/gopy.git","svn_url":"https://github.com/ondra/gopy","homepage":"","size":411,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"go-python:master","ref":"master","sha":"d4b4f9ee3ac3c4f30f80b4e3b74d46d9aa01f0d6","user":{"login":"go-python","id":7604679,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MDQ2Nzk=","avatar_url":"https://avatars2.githubusercontent.com/u/7604679?v=4","gravatar_id":"","url":"https://api.github.com/users/go-python","html_url":"https://github.com/go-python","followers_url":"https://api.github.com/users/go-python/followers","following_url":"https://api.github.com/users/go-python/following{/other_user}","gists_url":"https://api.github.com/users/go-python/gists{/gist_id}","starred_url":"https://api.github.com/users/go-python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-python/subscriptions","organizations_url":"https://api.github.com/users/go-python/orgs","repos_url":"https://api.github.com/users/go-python/repos","events_url":"https://api.github.com/users/go-python/events{/privacy}","received_events_url":"https://api.github.com/users/go-python/received_events","type":"Organization","site_admin":false},"repo":{"id":30081813,"node_id":"MDEwOlJlcG9zaXRvcnkzMDA4MTgxMw==","name":"gopy","full_name":"go-python/gopy","owner":{"login":"go-python","id":7604679,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MDQ2Nzk=","avatar_url":"https://avatars2.githubusercontent.com/u/7604679?v=4","gravatar_id":"","url":"https://api.github.com/users/go-python","html_url":"https://github.com/go-python","followers_url":"https://api.github.com/users/go-python/followers","following_url":"https://api.github.com/users/go-python/following{/other_user}","gists_url":"https://api.github.com/users/go-python/gists{/gist_id}","starred_url":"https://api.github.com/users/go-python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-python/subscriptions","organizations_url":"https://api.github.com/users/go-python/orgs","repos_url":"https://api.github.com/users/go-python/repos","events_url":"https://api.github.com/users/go-python/events{/privacy}","received_events_url":"https://api.github.com/users/go-python/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/go-python/gopy","description":"gopy generates a CPython extension module from a go package.","fork":false,"url":"https://api.github.com/repos/go-python/gopy","forks_url":"https://api.github.com/repos/go-python/gopy/forks","keys_url":"https://api.github.com/repos/go-python/gopy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/go-python/gopy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/go-python/gopy/teams","hooks_url":"https://api.github.com/repos/go-python/gopy/hooks","issue_events_url":"https://api.github.com/repos/go-python/gopy/issues/events{/number}","events_url":"https://api.github.com/repos/go-python/gopy/events","assignees_url":"https://api.github.com/repos/go-python/gopy/assignees{/user}","branches_url":"https://api.github.com/repos/go-python/gopy/branches{/branch}","tags_url":"https://api.github.com/repos/go-python/gopy/tags","blobs_url":"https://api.github.com/repos/go-python/gopy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/go-python/gopy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/go-python/gopy/git/refs{/sha}","trees_url":"https://api.github.com/repos/go-python/gopy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/go-python/gopy/statuses/{sha}","languages_url":"https://api.github.com/repos/go-python/gopy/languages","stargazers_url":"https://api.github.com/repos/go-python/gopy/stargazers","contributors_url":"https://api.github.com/repos/go-python/gopy/contributors","subscribers_url":"https://api.github.com/repos/go-python/gopy/subscribers","subscription_url":"https://api.github.com/repos/go-python/gopy/subscription","commits_url":"https://api.github.com/repos/go-python/gopy/commits{/sha}","git_commits_url":"https://api.github.com/repos/go-python/gopy/git/commits{/sha}","comments_url":"https://api.github.com/repos/go-python/gopy/comments{/number}","issue_comment_url":"https://api.github.com/repos/go-python/gopy/issues/comments{/number}","contents_url":"https://api.github.com/repos/go-python/gopy/contents/{+path}","compare_url":"https://api.github.com/repos/go-python/gopy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/go-python/gopy/merges","archive_url":"https://api.github.com/repos/go-python/gopy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/go-python/gopy/downloads","issues_url":"https://api.github.com/repos/go-python/gopy/issues{/number}","pulls_url":"https://api.github.com/repos/go-python/gopy/pulls{/number}","milestones_url":"https://api.github.com/repos/go-python/gopy/milestones{/number}","notifications_url":"https://api.github.com/repos/go-python/gopy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/go-python/gopy/labels{/name}","releases_url":"https://api.github.com/repos/go-python/gopy/releases{/id}","deployments_url":"https://api.github.com/repos/go-python/gopy/deployments","created_at":"2015-01-30T17:03:16Z","updated_at":"2018-06-09T17:06:37Z","pushed_at":"2018-06-11T20:30:17Z","git_url":"git://github.com/go-python/gopy.git","ssh_url":"git@github.com:go-python/gopy.git","clone_url":"https://github.com/go-python/gopy.git","svn_url":"https://github.com/go-python/gopy","homepage":"","size":396,"stargazers_count":645,"watchers_count":645,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"archived":false,"open_issues_count":54,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":38,"open_issues":54,"watchers":645,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/go-python/gopy/pulls/165"},"html":{"href":"https://github.com/go-python/gopy/pull/165"},"issue":{"href":"https://api.github.com/repos/go-python/gopy/issues/165"},"comments":{"href":"https://api.github.com/repos/go-python/gopy/issues/165/comments"},"review_comments":{"href":"https://api.github.com/repos/go-python/gopy/pulls/165/comments"},"review_comment":{"href":"https://api.github.com/repos/go-python/gopy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/go-python/gopy/pulls/165/commits"},"statuses":{"href":"https://api.github.com/repos/go-python/gopy/statuses/77b69b39c55f56e5aff44d395bea253266d24df3"}},"author_association":"NONE"}}
{"actor":{"display_login":"sbinet"}}