{"action":"created","comment":{"url":"https://api.github.com/repos/paypal/go.crypto/pulls/comments/166442061","pull_request_review_id":94504552,"id":166442061,"diff_hunk":"@@ -8,24 +8,45 @@ import (\n \t\"encoding/binary\"\n \t\"errors\"\n \t\"fmt\"\n+\t\"github.com/containous/traefik/log\"\n )\n \n-// Base64Encoding to use when reading from or writing to\n-// a Keystore. Most clients will not need to change this.\n-var Base64Encoding = base64.StdEncoding\n-\n var (\n \tdefaultIV   = []byte{0xA6, 0xA6, 0xA6, 0xA6, 0xA6, 0xA6, 0xA6, 0xA6}\n \talternateIV = []byte{0xA6, 0x59, 0x59, 0xA6}\n )\n \n-// Keystore stores encrypted keys. The map is keyed by key name;\n+// Keystore stores encrypted keys and encoding. The map is keyed by key name;\n // value are encrypted, base64-encoded keys.\n-type Keystore map[string]string\n+type Keystore struct {\n+\tKS map[string]string","path":"keystore/keystore.go","position":21,"original_position":21,"commit_id":"6b47aca75a4a1e9eb52f2324552e9376f48b25af","original_commit_id":"575b383612fe07f0463a58da4e96f7598b39799c","user":{"login":"pvoicu","id":464555,"avatar_url":"https://avatars1.githubusercontent.com/u/464555?v=4","gravatar_id":"","url":"https://api.github.com/users/pvoicu","html_url":"https://github.com/pvoicu","followers_url":"https://api.github.com/users/pvoicu/followers","following_url":"https://api.github.com/users/pvoicu/following{/other_user}","gists_url":"https://api.github.com/users/pvoicu/gists{/gist_id}","starred_url":"https://api.github.com/users/pvoicu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvoicu/subscriptions","organizations_url":"https://api.github.com/users/pvoicu/orgs","repos_url":"https://api.github.com/users/pvoicu/repos","events_url":"https://api.github.com/users/pvoicu/events{/privacy}","received_events_url":"https://api.github.com/users/pvoicu/received_events","type":"User","site_admin":false},"body":"Please note that this change is not backwards compatible, for example if an user for example is using Keystore type as a golang map. My project actually does that.\r\nSo here is the 3rd option, if we want to stay backward compatible, we could just make a minor change to add an Init method that just overrides the default encoder, and leave everything else unchanged.\r\n","created_at":"2018-02-06T21:08:20Z","updated_at":"2018-02-06T21:08:20Z","html_url":"https://github.com/paypal/go.crypto/pull/3#discussion_r166442061","pull_request_url":"https://api.github.com/repos/paypal/go.crypto/pulls/3","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/paypal/go.crypto/pulls/comments/166442061"},"html":{"href":"https://github.com/paypal/go.crypto/pull/3#discussion_r166442061"},"pull_request":{"href":"https://api.github.com/repos/paypal/go.crypto/pulls/3"}},"in_reply_to_id":165795903},"pull_request":{"url":"https://api.github.com/repos/paypal/go.crypto/pulls/3","id":166892849,"html_url":"https://github.com/paypal/go.crypto/pull/3","diff_url":"https://github.com/paypal/go.crypto/pull/3.diff","patch_url":"https://github.com/paypal/go.crypto/pull/3.patch","issue_url":"https://api.github.com/repos/paypal/go.crypto/issues/3","number":3,"state":"open","locked":false,"title":"refactor","user":{"login":"az-qbradley","id":5687206,"avatar_url":"https://avatars2.githubusercontent.com/u/5687206?v=4","gravatar_id":"","url":"https://api.github.com/users/az-qbradley","html_url":"https://github.com/az-qbradley","followers_url":"https://api.github.com/users/az-qbradley/followers","following_url":"https://api.github.com/users/az-qbradley/following{/other_user}","gists_url":"https://api.github.com/users/az-qbradley/gists{/gist_id}","starred_url":"https://api.github.com/users/az-qbradley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/az-qbradley/subscriptions","organizations_url":"https://api.github.com/users/az-qbradley/orgs","repos_url":"https://api.github.com/users/az-qbradley/repos","events_url":"https://api.github.com/users/az-qbradley/events{/privacy}","received_events_url":"https://api.github.com/users/az-qbradley/received_events","type":"User","site_admin":false},"body":"Refactor to allow change base64 encoding charset.","created_at":"2018-02-02T20:11:04Z","updated_at":"2018-02-06T21:08:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2fcd391aabbff3b4c5db85d42317554f0f11225a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/paypal/go.crypto/pulls/3/commits","review_comments_url":"https://api.github.com/repos/paypal/go.crypto/pulls/3/comments","review_comment_url":"https://api.github.com/repos/paypal/go.crypto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/paypal/go.crypto/issues/3/comments","statuses_url":"https://api.github.com/repos/paypal/go.crypto/statuses/6b47aca75a4a1e9eb52f2324552e9376f48b25af","head":{"label":"az-qbradley:refactor","ref":"refactor","sha":"6b47aca75a4a1e9eb52f2324552e9376f48b25af","user":{"login":"az-qbradley","id":5687206,"avatar_url":"https://avatars2.githubusercontent.com/u/5687206?v=4","gravatar_id":"","url":"https://api.github.com/users/az-qbradley","html_url":"https://github.com/az-qbradley","followers_url":"https://api.github.com/users/az-qbradley/followers","following_url":"https://api.github.com/users/az-qbradley/following{/other_user}","gists_url":"https://api.github.com/users/az-qbradley/gists{/gist_id}","starred_url":"https://api.github.com/users/az-qbradley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/az-qbradley/subscriptions","organizations_url":"https://api.github.com/users/az-qbradley/orgs","repos_url":"https://api.github.com/users/az-qbradley/repos","events_url":"https://api.github.com/users/az-qbradley/events{/privacy}","received_events_url":"https://api.github.com/users/az-qbradley/received_events","type":"User","site_admin":false},"repo":{"id":119967585,"name":"go.crypto","full_name":"az-qbradley/go.crypto","owner":{"login":"az-qbradley","id":5687206,"avatar_url":"https://avatars2.githubusercontent.com/u/5687206?v=4","gravatar_id":"","url":"https://api.github.com/users/az-qbradley","html_url":"https://github.com/az-qbradley","followers_url":"https://api.github.com/users/az-qbradley/followers","following_url":"https://api.github.com/users/az-qbradley/following{/other_user}","gists_url":"https://api.github.com/users/az-qbradley/gists{/gist_id}","starred_url":"https://api.github.com/users/az-qbradley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/az-qbradley/subscriptions","organizations_url":"https://api.github.com/users/az-qbradley/orgs","repos_url":"https://api.github.com/users/az-qbradley/repos","events_url":"https://api.github.com/users/az-qbradley/events{/privacy}","received_events_url":"https://api.github.com/users/az-qbradley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/az-qbradley/go.crypto","description":"Go crypto packages","fork":true,"url":"https://api.github.com/repos/az-qbradley/go.crypto","forks_url":"https://api.github.com/repos/az-qbradley/go.crypto/forks","keys_url":"https://api.github.com/repos/az-qbradley/go.crypto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/az-qbradley/go.crypto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/az-qbradley/go.crypto/teams","hooks_url":"https://api.github.com/repos/az-qbradley/go.crypto/hooks","issue_events_url":"https://api.github.com/repos/az-qbradley/go.crypto/issues/events{/number}","events_url":"https://api.github.com/repos/az-qbradley/go.crypto/events","assignees_url":"https://api.github.com/repos/az-qbradley/go.crypto/assignees{/user}","branches_url":"https://api.github.com/repos/az-qbradley/go.crypto/branches{/branch}","tags_url":"https://api.github.com/repos/az-qbradley/go.crypto/tags","blobs_url":"https://api.github.com/repos/az-qbradley/go.crypto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/az-qbradley/go.crypto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/az-qbradley/go.crypto/git/refs{/sha}","trees_url":"https://api.github.com/repos/az-qbradley/go.crypto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/az-qbradley/go.crypto/statuses/{sha}","languages_url":"https://api.github.com/repos/az-qbradley/go.crypto/languages","stargazers_url":"https://api.github.com/repos/az-qbradley/go.crypto/stargazers","contributors_url":"https://api.github.com/repos/az-qbradley/go.crypto/contributors","subscribers_url":"https://api.github.com/repos/az-qbradley/go.crypto/subscribers","subscription_url":"https://api.github.com/repos/az-qbradley/go.crypto/subscription","commits_url":"https://api.github.com/repos/az-qbradley/go.crypto/commits{/sha}","git_commits_url":"https://api.github.com/repos/az-qbradley/go.crypto/git/commits{/sha}","comments_url":"https://api.github.com/repos/az-qbradley/go.crypto/comments{/number}","issue_comment_url":"https://api.github.com/repos/az-qbradley/go.crypto/issues/comments{/number}","contents_url":"https://api.github.com/repos/az-qbradley/go.crypto/contents/{+path}","compare_url":"https://api.github.com/repos/az-qbradley/go.crypto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/az-qbradley/go.crypto/merges","archive_url":"https://api.github.com/repos/az-qbradley/go.crypto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/az-qbradley/go.crypto/downloads","issues_url":"https://api.github.com/repos/az-qbradley/go.crypto/issues{/number}","pulls_url":"https://api.github.com/repos/az-qbradley/go.crypto/pulls{/number}","milestones_url":"https://api.github.com/repos/az-qbradley/go.crypto/milestones{/number}","notifications_url":"https://api.github.com/repos/az-qbradley/go.crypto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/az-qbradley/go.crypto/labels{/name}","releases_url":"https://api.github.com/repos/az-qbradley/go.crypto/releases{/id}","deployments_url":"https://api.github.com/repos/az-qbradley/go.crypto/deployments","created_at":"2018-02-02T10:24:41Z","updated_at":"2018-02-02T10:24:43Z","pushed_at":"2018-02-06T21:06:34Z","git_url":"git://github.com/az-qbradley/go.crypto.git","ssh_url":"git@github.com:az-qbradley/go.crypto.git","clone_url":"https://github.com/az-qbradley/go.crypto.git","svn_url":"https://github.com/az-qbradley/go.crypto","homepage":null,"size":10,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"paypal:master","ref":"master","sha":"e7c9a1f9df98c185eeedee5709246ef6b7d4d937","user":{"login":"paypal","id":476675,"avatar_url":"https://avatars1.githubusercontent.com/u/476675?v=4","gravatar_id":"","url":"https://api.github.com/users/paypal","html_url":"https://github.com/paypal","followers_url":"https://api.github.com/users/paypal/followers","following_url":"https://api.github.com/users/paypal/following{/other_user}","gists_url":"https://api.github.com/users/paypal/gists{/gist_id}","starred_url":"https://api.github.com/users/paypal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paypal/subscriptions","organizations_url":"https://api.github.com/users/paypal/orgs","repos_url":"https://api.github.com/users/paypal/repos","events_url":"https://api.github.com/users/paypal/events{/privacy}","received_events_url":"https://api.github.com/users/paypal/received_events","type":"Organization","site_admin":false},"repo":{"id":16556668,"name":"go.crypto","full_name":"paypal/go.crypto","owner":{"login":"paypal","id":476675,"avatar_url":"https://avatars1.githubusercontent.com/u/476675?v=4","gravatar_id":"","url":"https://api.github.com/users/paypal","html_url":"https://github.com/paypal","followers_url":"https://api.github.com/users/paypal/followers","following_url":"https://api.github.com/users/paypal/following{/other_user}","gists_url":"https://api.github.com/users/paypal/gists{/gist_id}","starred_url":"https://api.github.com/users/paypal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paypal/subscriptions","organizations_url":"https://api.github.com/users/paypal/orgs","repos_url":"https://api.github.com/users/paypal/repos","events_url":"https://api.github.com/users/paypal/events{/privacy}","received_events_url":"https://api.github.com/users/paypal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/paypal/go.crypto","description":"Go crypto packages","fork":false,"url":"https://api.github.com/repos/paypal/go.crypto","forks_url":"https://api.github.com/repos/paypal/go.crypto/forks","keys_url":"https://api.github.com/repos/paypal/go.crypto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paypal/go.crypto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paypal/go.crypto/teams","hooks_url":"https://api.github.com/repos/paypal/go.crypto/hooks","issue_events_url":"https://api.github.com/repos/paypal/go.crypto/issues/events{/number}","events_url":"https://api.github.com/repos/paypal/go.crypto/events","assignees_url":"https://api.github.com/repos/paypal/go.crypto/assignees{/user}","branches_url":"https://api.github.com/repos/paypal/go.crypto/branches{/branch}","tags_url":"https://api.github.com/repos/paypal/go.crypto/tags","blobs_url":"https://api.github.com/repos/paypal/go.crypto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paypal/go.crypto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paypal/go.crypto/git/refs{/sha}","trees_url":"https://api.github.com/repos/paypal/go.crypto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paypal/go.crypto/statuses/{sha}","languages_url":"https://api.github.com/repos/paypal/go.crypto/languages","stargazers_url":"https://api.github.com/repos/paypal/go.crypto/stargazers","contributors_url":"https://api.github.com/repos/paypal/go.crypto/contributors","subscribers_url":"https://api.github.com/repos/paypal/go.crypto/subscribers","subscription_url":"https://api.github.com/repos/paypal/go.crypto/subscription","commits_url":"https://api.github.com/repos/paypal/go.crypto/commits{/sha}","git_commits_url":"https://api.github.com/repos/paypal/go.crypto/git/commits{/sha}","comments_url":"https://api.github.com/repos/paypal/go.crypto/comments{/number}","issue_comment_url":"https://api.github.com/repos/paypal/go.crypto/issues/comments{/number}","contents_url":"https://api.github.com/repos/paypal/go.crypto/contents/{+path}","compare_url":"https://api.github.com/repos/paypal/go.crypto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paypal/go.crypto/merges","archive_url":"https://api.github.com/repos/paypal/go.crypto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paypal/go.crypto/downloads","issues_url":"https://api.github.com/repos/paypal/go.crypto/issues{/number}","pulls_url":"https://api.github.com/repos/paypal/go.crypto/pulls{/number}","milestones_url":"https://api.github.com/repos/paypal/go.crypto/milestones{/number}","notifications_url":"https://api.github.com/repos/paypal/go.crypto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paypal/go.crypto/labels{/name}","releases_url":"https://api.github.com/repos/paypal/go.crypto/releases{/id}","deployments_url":"https://api.github.com/repos/paypal/go.crypto/deployments","created_at":"2014-02-05T20:07:49Z","updated_at":"2018-02-02T19:48:33Z","pushed_at":"2018-02-06T21:06:36Z","git_url":"git://github.com/paypal/go.crypto.git","ssh_url":"git@github.com:paypal/go.crypto.git","clone_url":"https://github.com/paypal/go.crypto.git","svn_url":"https://github.com/paypal/go.crypto","homepage":null,"size":9,"stargazers_count":23,"watchers_count":23,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":8,"open_issues":1,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/paypal/go.crypto/pulls/3"},"html":{"href":"https://github.com/paypal/go.crypto/pull/3"},"issue":{"href":"https://api.github.com/repos/paypal/go.crypto/issues/3"},"comments":{"href":"https://api.github.com/repos/paypal/go.crypto/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/paypal/go.crypto/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/paypal/go.crypto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/paypal/go.crypto/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/paypal/go.crypto/statuses/6b47aca75a4a1e9eb52f2324552e9376f48b25af"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pvoicu"}}