{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/23052","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/23052/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/23052/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/23052/events","html_url":"https://github.com/cms-sw/cmssw/pull/23052","id":317580261,"number":23052,"title":"Fix automated pixel pair mitigation to include \"Fed25\" information","user":{"login":"makortel","id":33993,"avatar_url":"https://avatars3.githubusercontent.com/u/33993?v=4","gravatar_id":"","url":"https://api.github.com/users/makortel","html_url":"https://github.com/makortel","followers_url":"https://api.github.com/users/makortel/followers","following_url":"https://api.github.com/users/makortel/following{/other_user}","gists_url":"https://api.github.com/users/makortel/gists{/gist_id}","starred_url":"https://api.github.com/users/makortel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makortel/subscriptions","organizations_url":"https://api.github.com/users/makortel/orgs","repos_url":"https://api.github.com/users/makortel/repos","events_url":"https://api.github.com/users/makortel/events{/privacy}","received_events_url":"https://api.github.com/users/makortel/received_events","type":"User","site_admin":false},"labels":[{"id":290514703,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/bug-fix","name":"bug-fix","color":"b8860b","default":false},{"id":673935047,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/code-checks-approved","name":"code-checks-approved","color":"2cbe4e","default":false},{"id":88645479,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-available","name":"comparison-available","color":"2cbe4e","default":false},{"id":56953091,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"ff8000","default":false},{"id":52820010,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04","default":false},{"id":56131195,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-approved","name":"tests-approved","color":"2cbe4e","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/76","html_url":"https://github.com/cms-sw/cmssw/milestone/76","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/76/labels","id":3227631,"number":76,"title":"CMSSW_10_2_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":53,"closed_issues":207,"state":"open","created_at":"2018-03-29T07:57:10Z","updated_at":"2018-04-26T16:29:24Z","due_on":null,"closed_at":null},"comments":27,"created_at":"2018-04-25T11:05:21Z","updated_at":"2018-04-26T18:36:14Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/23052","html_url":"https://github.com/cms-sw/cmssw/pull/23052","diff_url":"https://github.com/cms-sw/cmssw/pull/23052.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/23052.patch"},"body":"The investigation of https://hypernews.cern.ch/HyperNews/CMS/get/recoTracking/1760.html lead to finding that the \"Fed25\" (\"stuck TBM\") information is not currently used in the automated pixel pair mitigation (an oversight in #21630?). This PR fixes the configuration to read the information.\r\n\r\nTested in 10_1_0, expecting changes (=more pixelPair tracks) in workflows processing data containing \"Fed25\" errors.\r\n\r\n@VinInn "},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/384746657","html_url":"https://github.com/cms-sw/cmssw/pull/23052#issuecomment-384746657","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/23052","id":384746657,"user":{"login":"slava77","id":4676718,"avatar_url":"https://avatars2.githubusercontent.com/u/4676718?v=4","gravatar_id":"","url":"https://api.github.com/users/slava77","html_url":"https://github.com/slava77","followers_url":"https://api.github.com/users/slava77/followers","following_url":"https://api.github.com/users/slava77/following{/other_user}","gists_url":"https://api.github.com/users/slava77/gists{/gist_id}","starred_url":"https://api.github.com/users/slava77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slava77/subscriptions","organizations_url":"https://api.github.com/users/slava77/orgs","repos_url":"https://api.github.com/users/slava77/repos","events_url":"https://api.github.com/users/slava77/events{/privacy}","received_events_url":"https://api.github.com/users/slava77/received_events","type":"User","site_admin":false},"created_at":"2018-04-26T18:36:14Z","updated_at":"2018-04-26T18:36:14Z","author_association":"CONTRIBUTOR","body":"Here are some observations from 2017F matrix workflows\r\n\r\n136.831 JetHT Run 305064, LumiSection 81\r\n(the behavior appears to be about the same also in wf 136.829 : Run 305064, LumiSection 39 and \r\n136.83 : Run 305064, LumiSection 81)\r\n- CPU\r\n    -  in pixel pair seeding parts is up by x10; total in pixelPairStep is up by x2\r\n    - later iterations decrease by a few %\r\n    - total in iter tracking (\\*Step\\* in tracking module names) is up by 4.2%\r\n    - the rest of reco is up by 1.5%\r\n- Disk: about 1% increase in RECO and miniAOD, driven by the increase in the number of tracks and PF candidates by about 2% each.\r\n\r\n- at the generalTracks level: \r\n    - the additional tracks are clearly in the pixel pair, as expected. About double the count in this case. ![all_sign1016vsorig_runjetht2017f136p831c_recotracks_generaltracks__rereco_obj_originalalgo](https://user-images.githubusercontent.com/4676718/39321933-2b9e2190-493d-11e8-8b75-937b1e8b74de.png)\r\n    -  most additions are at low pt, high eta (and ~flat in phi!) , short length. Combined, it seems like most of the added tracks are fakes.\r\n![all_sign1016vsorig_runjetht2017f136p831c_log10recotracks_generaltracks__rereco_obj_pt](https://user-images.githubusercontent.com/4676718/39321968-4ffb8b40-493d-11e8-8d56-3d34384b0fb1.png)\r\n![all_sign1016vsorig_runjetht2017f136p831c_recotracks_generaltracks__rereco_obj_eta](https://user-images.githubusercontent.com/4676718/39322014-67c7543e-493d-11e8-843b-16e13a56a28a.png)\r\n![all_sign1016vsorig_runjetht2017f136p831c_recotracks_generaltracks__rereco_obj_phi](https://user-images.githubusercontent.com/4676718/39322050-76f736c2-493d-11e8-8a41-222c38f79819.png)\r\n![all_sign1016vsorig_runjetht2017f136p831c_recotracks_generaltracks__rereco_obj_found](https://user-images.githubusercontent.com/4676718/39322021-6cf85746-493d-11e8-95ae-99d1c4b062db.png)\r\n\r\n\r\nThe above high level plots are going in line with the lower level details:\r\n- the fraction of pixPair seeds that make a candidate is down \r\n<img width=\"739\" alt=\"wf136 831_pixpair_candoverseed\" src=\"https://user-images.githubusercontent.com/4676718/39324723-0b98de78-4945-11e8-91b7-d417fb603875.png\">\r\n\r\nThe number of seeds is up by about x4\r\n<img width=\"738\" alt=\"wf136 831_pixpair_seed_etaphi\" src=\"https://user-images.githubusercontent.com/4676718/39324847-6f255566-4945-11e8-864a-788b3a3ab70a.png\">\r\n\r\nPerhaps the most strikingly different plot is the pixelPair seeding regions eta-phi\r\n<img width=\"739\" alt=\"wf136 831_pixpair_region_etaphi\" src=\"https://user-images.githubusercontent.com/4676718/39324884-8fea333e-4945-11e8-987d-1a6c685f8c85.png\">\r\n\r\nThe added candidates are somewhat localized\r\n<img width=\"739\" alt=\"wf136 831_pixpair_cand_etaphi\" src=\"https://user-images.githubusercontent.com/4676718/39324823-4db90314-4945-11e8-8160-39ba773b9834.png\">\r\n\r\nAs far as I understand, these are all somewhat expected changes.\r\n\r\nThe hit pattern efficiency plot shows some drop in efficiency\r\n<img width=\"740\" alt=\"wf136 831_tkpt1_eff_pattern\" src=\"https://user-images.githubusercontent.com/4676718/39324935-c0099988-4945-11e8-9255-190c8cf42aa5.png\">\r\nI guess addition of shorter/poorer tracks to the reference can lead to visible degradation in this kind of plot.\r\n\r\n\r\n\r\n\r\n"}}
{"actor":{"display_login":"slava77"}}