{"action":"created","comment":{"url":"https://api.github.com/repos/snipe/snipe-it/pulls/comments/229948486","pull_request_review_id":170567936,"id":229948486,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTk0ODQ4Ng==","diff_hunk":"@@ -869,7 +869,7 @@ public function postLdapSettings(Request $request)\n         $setting->ldap_server             = $request->input('ldap_server');\n         $setting->ldap_server_cert_ignore = $request->input('ldap_server_cert_ignore', false);\n         $setting->ldap_uname              = $request->input('ldap_uname');\n-        if (Input::has('ldap_pword')) {\n+        if ($request->input('ldap_pword') !== '') {","path":"app/Http/Controllers/SettingsController.php","position":5,"original_position":5,"commit_id":"a094e77f0570c31f1db8a711f31bd75b9649915b","original_commit_id":"a094e77f0570c31f1db8a711f31bd75b9649915b","user":{"login":"jwhulette","id":4930051,"node_id":"MDQ6VXNlcjQ5MzAwNTE=","avatar_url":"https://avatars1.githubusercontent.com/u/4930051?v=4","gravatar_id":"","url":"https://api.github.com/users/jwhulette","html_url":"https://github.com/jwhulette","followers_url":"https://api.github.com/users/jwhulette/followers","following_url":"https://api.github.com/users/jwhulette/following{/other_user}","gists_url":"https://api.github.com/users/jwhulette/gists{/gist_id}","starred_url":"https://api.github.com/users/jwhulette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwhulette/subscriptions","organizations_url":"https://api.github.com/users/jwhulette/orgs","repos_url":"https://api.github.com/users/jwhulette/repos","events_url":"https://api.github.com/users/jwhulette/events{/privacy}","received_events_url":"https://api.github.com/users/jwhulette/received_events","type":"User","site_admin":false},"body":"Reverted change. Will open a new PR.","created_at":"2018-11-01T06:19:04Z","updated_at":"2018-11-01T06:19:04Z","html_url":"https://github.com/snipe/snipe-it/pull/6352#discussion_r229948486","pull_request_url":"https://api.github.com/repos/snipe/snipe-it/pulls/6352","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/snipe/snipe-it/pulls/comments/229948486"},"html":{"href":"https://github.com/snipe/snipe-it/pull/6352#discussion_r229948486"},"pull_request":{"href":"https://api.github.com/repos/snipe/snipe-it/pulls/6352"}},"in_reply_to_id":229915261},"pull_request":{"url":"https://api.github.com/repos/snipe/snipe-it/pulls/6352","id":224725263,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NzI1MjYz","html_url":"https://github.com/snipe/snipe-it/pull/6352","diff_url":"https://github.com/snipe/snipe-it/pull/6352.diff","patch_url":"https://github.com/snipe/snipe-it/pull/6352.patch","issue_url":"https://api.github.com/repos/snipe/snipe-it/issues/6352","number":6352,"state":"open","locked":false,"title":"[WIP] v5 Develop: New LDAP implementation","user":{"login":"jwhulette","id":4930051,"node_id":"MDQ6VXNlcjQ5MzAwNTE=","avatar_url":"https://avatars1.githubusercontent.com/u/4930051?v=4","gravatar_id":"","url":"https://api.github.com/users/jwhulette","html_url":"https://github.com/jwhulette","followers_url":"https://api.github.com/users/jwhulette/followers","following_url":"https://api.github.com/users/jwhulette/following{/other_user}","gists_url":"https://api.github.com/users/jwhulette/gists{/gist_id}","starred_url":"https://api.github.com/users/jwhulette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwhulette/subscriptions","organizations_url":"https://api.github.com/users/jwhulette/orgs","repos_url":"https://api.github.com/users/jwhulette/repos","events_url":"https://api.github.com/users/jwhulette/events{/privacy}","received_events_url":"https://api.github.com/users/jwhulette/received_events","type":"User","site_admin":false},"body":"This is a new implementation of LDAP for snipeit. \n1. I know this is a huge pull request, but I think I have made the code cleaner an more organized. \n2. I know you will be reluctant to merge this request and I would be too. I would ideally have people testing it before merging. \n3. If you think this is a good direction, I would like to do some more clean up and implement some of the features requested and fix some of the  issues reported if the update does not already solve them. \n4. Thoughts?","created_at":"2018-10-22T15:50:23Z","updated_at":"2018-11-01T06:19:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3da6fae939af25670b0f58bec6702666bcd99b41","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/snipe/snipe-it/pulls/6352/commits","review_comments_url":"https://api.github.com/repos/snipe/snipe-it/pulls/6352/comments","review_comment_url":"https://api.github.com/repos/snipe/snipe-it/pulls/comments{/number}","comments_url":"https://api.github.com/repos/snipe/snipe-it/issues/6352/comments","statuses_url":"https://api.github.com/repos/snipe/snipe-it/statuses/a094e77f0570c31f1db8a711f31bd75b9649915b","head":{"label":"jwhulette:WIP_LDAP","ref":"WIP_LDAP","sha":"a094e77f0570c31f1db8a711f31bd75b9649915b","user":{"login":"jwhulette","id":4930051,"node_id":"MDQ6VXNlcjQ5MzAwNTE=","avatar_url":"https://avatars1.githubusercontent.com/u/4930051?v=4","gravatar_id":"","url":"https://api.github.com/users/jwhulette","html_url":"https://github.com/jwhulette","followers_url":"https://api.github.com/users/jwhulette/followers","following_url":"https://api.github.com/users/jwhulette/following{/other_user}","gists_url":"https://api.github.com/users/jwhulette/gists{/gist_id}","starred_url":"https://api.github.com/users/jwhulette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwhulette/subscriptions","organizations_url":"https://api.github.com/users/jwhulette/orgs","repos_url":"https://api.github.com/users/jwhulette/repos","events_url":"https://api.github.com/users/jwhulette/events{/privacy}","received_events_url":"https://api.github.com/users/jwhulette/received_events","type":"User","site_admin":false},"repo":{"id":146325933,"node_id":"MDEwOlJlcG9zaXRvcnkxNDYzMjU5MzM=","name":"snipe-it","full_name":"jwhulette/snipe-it","private":false,"owner":{"login":"jwhulette","id":4930051,"node_id":"MDQ6VXNlcjQ5MzAwNTE=","avatar_url":"https://avatars1.githubusercontent.com/u/4930051?v=4","gravatar_id":"","url":"https://api.github.com/users/jwhulette","html_url":"https://github.com/jwhulette","followers_url":"https://api.github.com/users/jwhulette/followers","following_url":"https://api.github.com/users/jwhulette/following{/other_user}","gists_url":"https://api.github.com/users/jwhulette/gists{/gist_id}","starred_url":"https://api.github.com/users/jwhulette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwhulette/subscriptions","organizations_url":"https://api.github.com/users/jwhulette/orgs","repos_url":"https://api.github.com/users/jwhulette/repos","events_url":"https://api.github.com/users/jwhulette/events{/privacy}","received_events_url":"https://api.github.com/users/jwhulette/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jwhulette/snipe-it","description":"A free open source IT asset/license management system","fork":true,"url":"https://api.github.com/repos/jwhulette/snipe-it","forks_url":"https://api.github.com/repos/jwhulette/snipe-it/forks","keys_url":"https://api.github.com/repos/jwhulette/snipe-it/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jwhulette/snipe-it/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jwhulette/snipe-it/teams","hooks_url":"https://api.github.com/repos/jwhulette/snipe-it/hooks","issue_events_url":"https://api.github.com/repos/jwhulette/snipe-it/issues/events{/number}","events_url":"https://api.github.com/repos/jwhulette/snipe-it/events","assignees_url":"https://api.github.com/repos/jwhulette/snipe-it/assignees{/user}","branches_url":"https://api.github.com/repos/jwhulette/snipe-it/branches{/branch}","tags_url":"https://api.github.com/repos/jwhulette/snipe-it/tags","blobs_url":"https://api.github.com/repos/jwhulette/snipe-it/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jwhulette/snipe-it/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jwhulette/snipe-it/git/refs{/sha}","trees_url":"https://api.github.com/repos/jwhulette/snipe-it/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jwhulette/snipe-it/statuses/{sha}","languages_url":"https://api.github.com/repos/jwhulette/snipe-it/languages","stargazers_url":"https://api.github.com/repos/jwhulette/snipe-it/stargazers","contributors_url":"https://api.github.com/repos/jwhulette/snipe-it/contributors","subscribers_url":"https://api.github.com/repos/jwhulette/snipe-it/subscribers","subscription_url":"https://api.github.com/repos/jwhulette/snipe-it/subscription","commits_url":"https://api.github.com/repos/jwhulette/snipe-it/commits{/sha}","git_commits_url":"https://api.github.com/repos/jwhulette/snipe-it/git/commits{/sha}","comments_url":"https://api.github.com/repos/jwhulette/snipe-it/comments{/number}","issue_comment_url":"https://api.github.com/repos/jwhulette/snipe-it/issues/comments{/number}","contents_url":"https://api.github.com/repos/jwhulette/snipe-it/contents/{+path}","compare_url":"https://api.github.com/repos/jwhulette/snipe-it/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jwhulette/snipe-it/merges","archive_url":"https://api.github.com/repos/jwhulette/snipe-it/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jwhulette/snipe-it/downloads","issues_url":"https://api.github.com/repos/jwhulette/snipe-it/issues{/number}","pulls_url":"https://api.github.com/repos/jwhulette/snipe-it/pulls{/number}","milestones_url":"https://api.github.com/repos/jwhulette/snipe-it/milestones{/number}","notifications_url":"https://api.github.com/repos/jwhulette/snipe-it/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jwhulette/snipe-it/labels{/name}","releases_url":"https://api.github.com/repos/jwhulette/snipe-it/releases{/id}","deployments_url":"https://api.github.com/repos/jwhulette/snipe-it/deployments","created_at":"2018-08-27T16:42:04Z","updated_at":"2018-10-31T13:30:14Z","pushed_at":"2018-10-31T23:40:03Z","git_url":"git://github.com/jwhulette/snipe-it.git","ssh_url":"git@github.com:jwhulette/snipe-it.git","clone_url":"https://github.com/jwhulette/snipe-it.git","svn_url":"https://github.com/jwhulette/snipe-it","homepage":"https://snipeitapp.com","size":89258,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"snipe:develop","ref":"develop","sha":"e443a576f72eca5c3243f7c4b202021f6763b542","user":{"login":"snipe","id":197404,"node_id":"MDQ6VXNlcjE5NzQwNA==","avatar_url":"https://avatars0.githubusercontent.com/u/197404?v=4","gravatar_id":"","url":"https://api.github.com/users/snipe","html_url":"https://github.com/snipe","followers_url":"https://api.github.com/users/snipe/followers","following_url":"https://api.github.com/users/snipe/following{/other_user}","gists_url":"https://api.github.com/users/snipe/gists{/gist_id}","starred_url":"https://api.github.com/users/snipe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snipe/subscriptions","organizations_url":"https://api.github.com/users/snipe/orgs","repos_url":"https://api.github.com/users/snipe/repos","events_url":"https://api.github.com/users/snipe/events{/privacy}","received_events_url":"https://api.github.com/users/snipe/received_events","type":"User","site_admin":false},"repo":{"id":14346979,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM0Njk3OQ==","name":"snipe-it","full_name":"snipe/snipe-it","private":false,"owner":{"login":"snipe","id":197404,"node_id":"MDQ6VXNlcjE5NzQwNA==","avatar_url":"https://avatars0.githubusercontent.com/u/197404?v=4","gravatar_id":"","url":"https://api.github.com/users/snipe","html_url":"https://github.com/snipe","followers_url":"https://api.github.com/users/snipe/followers","following_url":"https://api.github.com/users/snipe/following{/other_user}","gists_url":"https://api.github.com/users/snipe/gists{/gist_id}","starred_url":"https://api.github.com/users/snipe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snipe/subscriptions","organizations_url":"https://api.github.com/users/snipe/orgs","repos_url":"https://api.github.com/users/snipe/repos","events_url":"https://api.github.com/users/snipe/events{/privacy}","received_events_url":"https://api.github.com/users/snipe/received_events","type":"User","site_admin":false},"html_url":"https://github.com/snipe/snipe-it","description":"A free open source IT asset/license management system","fork":false,"url":"https://api.github.com/repos/snipe/snipe-it","forks_url":"https://api.github.com/repos/snipe/snipe-it/forks","keys_url":"https://api.github.com/repos/snipe/snipe-it/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snipe/snipe-it/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snipe/snipe-it/teams","hooks_url":"https://api.github.com/repos/snipe/snipe-it/hooks","issue_events_url":"https://api.github.com/repos/snipe/snipe-it/issues/events{/number}","events_url":"https://api.github.com/repos/snipe/snipe-it/events","assignees_url":"https://api.github.com/repos/snipe/snipe-it/assignees{/user}","branches_url":"https://api.github.com/repos/snipe/snipe-it/branches{/branch}","tags_url":"https://api.github.com/repos/snipe/snipe-it/tags","blobs_url":"https://api.github.com/repos/snipe/snipe-it/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snipe/snipe-it/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snipe/snipe-it/git/refs{/sha}","trees_url":"https://api.github.com/repos/snipe/snipe-it/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snipe/snipe-it/statuses/{sha}","languages_url":"https://api.github.com/repos/snipe/snipe-it/languages","stargazers_url":"https://api.github.com/repos/snipe/snipe-it/stargazers","contributors_url":"https://api.github.com/repos/snipe/snipe-it/contributors","subscribers_url":"https://api.github.com/repos/snipe/snipe-it/subscribers","subscription_url":"https://api.github.com/repos/snipe/snipe-it/subscription","commits_url":"https://api.github.com/repos/snipe/snipe-it/commits{/sha}","git_commits_url":"https://api.github.com/repos/snipe/snipe-it/git/commits{/sha}","comments_url":"https://api.github.com/repos/snipe/snipe-it/comments{/number}","issue_comment_url":"https://api.github.com/repos/snipe/snipe-it/issues/comments{/number}","contents_url":"https://api.github.com/repos/snipe/snipe-it/contents/{+path}","compare_url":"https://api.github.com/repos/snipe/snipe-it/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snipe/snipe-it/merges","archive_url":"https://api.github.com/repos/snipe/snipe-it/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snipe/snipe-it/downloads","issues_url":"https://api.github.com/repos/snipe/snipe-it/issues{/number}","pulls_url":"https://api.github.com/repos/snipe/snipe-it/pulls{/number}","milestones_url":"https://api.github.com/repos/snipe/snipe-it/milestones{/number}","notifications_url":"https://api.github.com/repos/snipe/snipe-it/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snipe/snipe-it/labels{/name}","releases_url":"https://api.github.com/repos/snipe/snipe-it/releases{/id}","deployments_url":"https://api.github.com/repos/snipe/snipe-it/deployments","created_at":"2013-11-12T22:25:47Z","updated_at":"2018-10-31T18:11:45Z","pushed_at":"2018-11-01T01:03:32Z","git_url":"git://github.com/snipe/snipe-it.git","ssh_url":"git@github.com:snipe/snipe-it.git","clone_url":"https://github.com/snipe/snipe-it.git","svn_url":"https://github.com/snipe/snipe-it","homepage":"https://snipeitapp.com","size":89141,"stargazers_count":2439,"watchers_count":2439,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1029,"mirror_url":null,"archived":false,"open_issues_count":245,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":1029,"open_issues":245,"watchers":2439,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/snipe/snipe-it/pulls/6352"},"html":{"href":"https://github.com/snipe/snipe-it/pull/6352"},"issue":{"href":"https://api.github.com/repos/snipe/snipe-it/issues/6352"},"comments":{"href":"https://api.github.com/repos/snipe/snipe-it/issues/6352/comments"},"review_comments":{"href":"https://api.github.com/repos/snipe/snipe-it/pulls/6352/comments"},"review_comment":{"href":"https://api.github.com/repos/snipe/snipe-it/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/snipe/snipe-it/pulls/6352/commits"},"statuses":{"href":"https://api.github.com/repos/snipe/snipe-it/statuses/a094e77f0570c31f1db8a711f31bd75b9649915b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jwhulette"}}