{"action":"created","issue":{"url":"https://api.github.com/repos/google/periph/issues/341","repository_url":"https://api.github.com/repos/google/periph","labels_url":"https://api.github.com/repos/google/periph/issues/341/labels{/name}","comments_url":"https://api.github.com/repos/google/periph/issues/341/comments","events_url":"https://api.github.com/repos/google/periph/issues/341/events","html_url":"https://github.com/google/periph/pull/341","id":381823994,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNzA0MDg0","number":341,"title":"physic: performance improvements","user":{"login":"NeuralSpaz","id":6887502,"node_id":"MDQ6VXNlcjY4ODc1MDI=","avatar_url":"https://avatars2.githubusercontent.com/u/6887502?v=4","gravatar_id":"","url":"https://api.github.com/users/NeuralSpaz","html_url":"https://github.com/NeuralSpaz","followers_url":"https://api.github.com/users/NeuralSpaz/followers","following_url":"https://api.github.com/users/NeuralSpaz/following{/other_user}","gists_url":"https://api.github.com/users/NeuralSpaz/gists{/gist_id}","starred_url":"https://api.github.com/users/NeuralSpaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NeuralSpaz/subscriptions","organizations_url":"https://api.github.com/users/NeuralSpaz/orgs","repos_url":"https://api.github.com/users/NeuralSpaz/repos","events_url":"https://api.github.com/users/NeuralSpaz/events{/privacy}","received_events_url":"https://api.github.com/users/NeuralSpaz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-11-17T03:40:12Z","updated_at":"2018-11-19T01:11:47Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/google/periph/pulls/341","html_url":"https://github.com/google/periph/pull/341","diff_url":"https://github.com/google/periph/pull/341.diff","patch_url":"https://github.com/google/periph/pull/341.patch"},"body":"Removed strings.ToLower() from units switches as this was causing an extra allocation. \r\nThis change is ~ 50% faster."},"comment":{"url":"https://api.github.com/repos/google/periph/issues/comments/439743983","html_url":"https://github.com/google/periph/pull/341#issuecomment-439743983","issue_url":"https://api.github.com/repos/google/periph/issues/341","id":439743983,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTc0Mzk4Mw==","user":{"login":"maruel","id":75011,"node_id":"MDQ6VXNlcjc1MDEx","avatar_url":"https://avatars2.githubusercontent.com/u/75011?v=4","gravatar_id":"","url":"https://api.github.com/users/maruel","html_url":"https://github.com/maruel","followers_url":"https://api.github.com/users/maruel/followers","following_url":"https://api.github.com/users/maruel/following{/other_user}","gists_url":"https://api.github.com/users/maruel/gists{/gist_id}","starred_url":"https://api.github.com/users/maruel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maruel/subscriptions","organizations_url":"https://api.github.com/users/maruel/orgs","repos_url":"https://api.github.com/users/maruel/repos","events_url":"https://api.github.com/users/maruel/events{/privacy}","received_events_url":"https://api.github.com/users/maruel/received_events","type":"User","site_admin":false},"created_at":"2018-11-19T01:11:47Z","updated_at":"2018-11-19T01:11:47Z","author_association":"MEMBER","body":"> I have a question though, do we really need to support both the acronym and the full form for every units? i.e. just supporting \"m\" and not \"meter\" and \"meters\" would probably be fine.\r\n\r\ntime.ParseDuration() is a precedent, it supports \"1m\", not \"1min\" or \"1 minute\""}}
{"actor":{"display_login":"maruel"}}