{"action":"created","comment":{"url":"https://api.github.com/repos/caicloud/cyclone/pulls/comments/232118490","pull_request_review_id":173243660,"id":232118490,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjExODQ5MA==","diff_hunk":"@@ -28,3 +28,10 @@ type StageItem struct {\n \t// Stages that this stage depends on\n \tDepends []string `json:\"depends\"`\n }\n+","path":"pkg/apis/cyclone/v1alpha1/workflow.go","position":4,"original_position":4,"commit_id":"c8ac152a4497a9e0db7302429fead2c05b9dc72c","original_commit_id":"c8ac152a4497a9e0db7302429fead2c05b9dc72c","user":{"login":"ddysher","id":2191361,"node_id":"MDQ6VXNlcjIxOTEzNjE=","avatar_url":"https://avatars1.githubusercontent.com/u/2191361?v=4","gravatar_id":"","url":"https://api.github.com/users/ddysher","html_url":"https://github.com/ddysher","followers_url":"https://api.github.com/users/ddysher/followers","following_url":"https://api.github.com/users/ddysher/following{/other_user}","gists_url":"https://api.github.com/users/ddysher/gists{/gist_id}","starred_url":"https://api.github.com/users/ddysher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddysher/subscriptions","organizations_url":"https://api.github.com/users/ddysher/orgs","repos_url":"https://api.github.com/users/ddysher/repos","events_url":"https://api.github.com/users/ddysher/events{/privacy}","received_events_url":"https://api.github.com/users/ddysher/received_events","type":"User","site_admin":false},"body":"Also, can we change json tag `stageItem` to just `stages`?","created_at":"2018-11-09T01:25:10Z","updated_at":"2018-11-09T01:41:05Z","html_url":"https://github.com/caicloud/cyclone/pull/598#discussion_r232118490","pull_request_url":"https://api.github.com/repos/caicloud/cyclone/pulls/598","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/caicloud/cyclone/pulls/comments/232118490"},"html":{"href":"https://github.com/caicloud/cyclone/pull/598#discussion_r232118490"},"pull_request":{"href":"https://api.github.com/repos/caicloud/cyclone/pulls/598"}},"in_reply_to_id":232117920},"pull_request":{"url":"https://api.github.com/repos/caicloud/cyclone/pulls/598","id":229280608,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5MjgwNjA4","html_url":"https://github.com/caicloud/cyclone/pull/598","diff_url":"https://github.com/caicloud/cyclone/pull/598.diff","patch_url":"https://github.com/caicloud/cyclone/pull/598.patch","issue_url":"https://api.github.com/repos/caicloud/cyclone/issues/598","number":598,"state":"open","locked":false,"title":"fix: crd definition problems","user":{"login":"cd1989","id":16573984,"node_id":"MDQ6VXNlcjE2NTczOTg0","avatar_url":"https://avatars0.githubusercontent.com/u/16573984?v=4","gravatar_id":"","url":"https://api.github.com/users/cd1989","html_url":"https://github.com/cd1989","followers_url":"https://api.github.com/users/cd1989/followers","following_url":"https://api.github.com/users/cd1989/following{/other_user}","gists_url":"https://api.github.com/users/cd1989/gists{/gist_id}","starred_url":"https://api.github.com/users/cd1989/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cd1989/subscriptions","organizations_url":"https://api.github.com/users/cd1989/orgs","repos_url":"https://api.github.com/users/cd1989/repos","events_url":"https://api.github.com/users/cd1989/events{/privacy}","received_events_url":"https://api.github.com/users/cd1989/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request! See below for tips! -->\r\n\r\n**What this PR does / why we need it**:\r\n\r\nFix crd definition problems.\r\n\r\n**Which issue(s) this PR is related to** *(optional, link to 3rd issue(s))*:\r\n\r\nFixes #\r\n\r\nReference to #\r\n<!-- 填在 Fixes，PR 合并就会关 issue。填在 Reference to 会关联 issue，不会联动关闭，caicloud/quality 请用这个。-->\r\n\r\n**Special notes for your reviewer**:\r\n\r\n/cc @zhujian7 \r\n\r\n<!-- Please answer the following questions during the code freeze, and delete this line.\r\n**Code freeze questions**\r\n\r\n1. What causes this PR to not be merged before code freeze?\r\n2. Why this PR is absolutely necessary for this version? Paste a screenshot of smoke testing docs if you could.\r\n3. What's the effects after merging it?\r\n4. Is there anyway we can skip this to not affect the overall process?\r\n-->\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n\r\n```release-note\r\nNONE\r\n```\r\n\r\n<!--  Thanks for sending a pull request! Here are some tips:\r\n\r\n1. https://github.com/caicloud/engineering/blob/master/docs/review_conventions.md  <-- what is the review process looks like\r\n2. https://github.com/caicloud/engineering/blob/master/docs/commit_conventions.md  <-- how to structure your git commit\r\n3. https://github.com/caicloud/engineering/blob/master/docs/caicloud_bot.md        <-- how to work with caicloud bot\r\n\r\nOther tips from Kubernetes cmomunity:\r\n\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n4. If the PR is unfinished, see how to mark it: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n","created_at":"2018-11-08T08:11:42Z","updated_at":"2018-11-09T01:41:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3a828754907e13ff1a64a44a6dbb06fe48700648","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":845942386,"node_id":"MDU6TGFiZWw4NDU5NDIzODY=","url":"https://api.github.com/repos/caicloud/cyclone/labels/caicloud-cla:%20yes","name":"caicloud-cla: yes","color":"bfe5bf","default":false},{"id":809637389,"node_id":"MDU6TGFiZWw4MDk2MzczODk=","url":"https://api.github.com/repos/caicloud/cyclone/labels/do-not-merge/hold","name":"do-not-merge/hold","color":"e11d21","default":false},{"id":805914010,"node_id":"MDU6TGFiZWw4MDU5MTQwMTA=","url":"https://api.github.com/repos/caicloud/cyclone/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":798944198,"node_id":"MDU6TGFiZWw3OTg5NDQxOTg=","url":"https://api.github.com/repos/caicloud/cyclone/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/caicloud/cyclone/pulls/598/commits","review_comments_url":"https://api.github.com/repos/caicloud/cyclone/pulls/598/comments","review_comment_url":"https://api.github.com/repos/caicloud/cyclone/pulls/comments{/number}","comments_url":"https://api.github.com/repos/caicloud/cyclone/issues/598/comments","statuses_url":"https://api.github.com/repos/caicloud/cyclone/statuses/c8ac152a4497a9e0db7302429fead2c05b9dc72c","head":{"label":"cd1989:crd-refinement","ref":"crd-refinement","sha":"c8ac152a4497a9e0db7302429fead2c05b9dc72c","user":{"login":"cd1989","id":16573984,"node_id":"MDQ6VXNlcjE2NTczOTg0","avatar_url":"https://avatars0.githubusercontent.com/u/16573984?v=4","gravatar_id":"","url":"https://api.github.com/users/cd1989","html_url":"https://github.com/cd1989","followers_url":"https://api.github.com/users/cd1989/followers","following_url":"https://api.github.com/users/cd1989/following{/other_user}","gists_url":"https://api.github.com/users/cd1989/gists{/gist_id}","starred_url":"https://api.github.com/users/cd1989/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cd1989/subscriptions","organizations_url":"https://api.github.com/users/cd1989/orgs","repos_url":"https://api.github.com/users/cd1989/repos","events_url":"https://api.github.com/users/cd1989/events{/privacy}","received_events_url":"https://api.github.com/users/cd1989/received_events","type":"User","site_admin":false},"repo":{"id":156380831,"node_id":"MDEwOlJlcG9zaXRvcnkxNTYzODA4MzE=","name":"cyclone","full_name":"cd1989/cyclone","private":false,"owner":{"login":"cd1989","id":16573984,"node_id":"MDQ6VXNlcjE2NTczOTg0","avatar_url":"https://avatars0.githubusercontent.com/u/16573984?v=4","gravatar_id":"","url":"https://api.github.com/users/cd1989","html_url":"https://github.com/cd1989","followers_url":"https://api.github.com/users/cd1989/followers","following_url":"https://api.github.com/users/cd1989/following{/other_user}","gists_url":"https://api.github.com/users/cd1989/gists{/gist_id}","starred_url":"https://api.github.com/users/cd1989/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cd1989/subscriptions","organizations_url":"https://api.github.com/users/cd1989/orgs","repos_url":"https://api.github.com/users/cd1989/repos","events_url":"https://api.github.com/users/cd1989/events{/privacy}","received_events_url":"https://api.github.com/users/cd1989/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cd1989/cyclone","description":"A cloud native CI/CD platform built for container workflow","fork":true,"url":"https://api.github.com/repos/cd1989/cyclone","forks_url":"https://api.github.com/repos/cd1989/cyclone/forks","keys_url":"https://api.github.com/repos/cd1989/cyclone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cd1989/cyclone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cd1989/cyclone/teams","hooks_url":"https://api.github.com/repos/cd1989/cyclone/hooks","issue_events_url":"https://api.github.com/repos/cd1989/cyclone/issues/events{/number}","events_url":"https://api.github.com/repos/cd1989/cyclone/events","assignees_url":"https://api.github.com/repos/cd1989/cyclone/assignees{/user}","branches_url":"https://api.github.com/repos/cd1989/cyclone/branches{/branch}","tags_url":"https://api.github.com/repos/cd1989/cyclone/tags","blobs_url":"https://api.github.com/repos/cd1989/cyclone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cd1989/cyclone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cd1989/cyclone/git/refs{/sha}","trees_url":"https://api.github.com/repos/cd1989/cyclone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cd1989/cyclone/statuses/{sha}","languages_url":"https://api.github.com/repos/cd1989/cyclone/languages","stargazers_url":"https://api.github.com/repos/cd1989/cyclone/stargazers","contributors_url":"https://api.github.com/repos/cd1989/cyclone/contributors","subscribers_url":"https://api.github.com/repos/cd1989/cyclone/subscribers","subscription_url":"https://api.github.com/repos/cd1989/cyclone/subscription","commits_url":"https://api.github.com/repos/cd1989/cyclone/commits{/sha}","git_commits_url":"https://api.github.com/repos/cd1989/cyclone/git/commits{/sha}","comments_url":"https://api.github.com/repos/cd1989/cyclone/comments{/number}","issue_comment_url":"https://api.github.com/repos/cd1989/cyclone/issues/comments{/number}","contents_url":"https://api.github.com/repos/cd1989/cyclone/contents/{+path}","compare_url":"https://api.github.com/repos/cd1989/cyclone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cd1989/cyclone/merges","archive_url":"https://api.github.com/repos/cd1989/cyclone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cd1989/cyclone/downloads","issues_url":"https://api.github.com/repos/cd1989/cyclone/issues{/number}","pulls_url":"https://api.github.com/repos/cd1989/cyclone/pulls{/number}","milestones_url":"https://api.github.com/repos/cd1989/cyclone/milestones{/number}","notifications_url":"https://api.github.com/repos/cd1989/cyclone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cd1989/cyclone/labels{/name}","releases_url":"https://api.github.com/repos/cd1989/cyclone/releases{/id}","deployments_url":"https://api.github.com/repos/cd1989/cyclone/deployments","created_at":"2018-11-06T12:32:14Z","updated_at":"2018-11-06T12:32:17Z","pushed_at":"2018-11-08T13:45:59Z","git_url":"git://github.com/cd1989/cyclone.git","ssh_url":"git@github.com:cd1989/cyclone.git","clone_url":"https://github.com/cd1989/cyclone.git","svn_url":"https://github.com/cd1989/cyclone","homepage":"","size":69279,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"caicloud:develop","ref":"develop","sha":"daefc36a926d85483e2ead87cbcddde4ec843131","user":{"login":"caicloud","id":12522124,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTIyMTI0","avatar_url":"https://avatars2.githubusercontent.com/u/12522124?v=4","gravatar_id":"","url":"https://api.github.com/users/caicloud","html_url":"https://github.com/caicloud","followers_url":"https://api.github.com/users/caicloud/followers","following_url":"https://api.github.com/users/caicloud/following{/other_user}","gists_url":"https://api.github.com/users/caicloud/gists{/gist_id}","starred_url":"https://api.github.com/users/caicloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caicloud/subscriptions","organizations_url":"https://api.github.com/users/caicloud/orgs","repos_url":"https://api.github.com/users/caicloud/repos","events_url":"https://api.github.com/users/caicloud/events{/privacy}","received_events_url":"https://api.github.com/users/caicloud/received_events","type":"Organization","site_admin":false},"repo":{"id":71099614,"node_id":"MDEwOlJlcG9zaXRvcnk3MTA5OTYxNA==","name":"cyclone","full_name":"caicloud/cyclone","private":false,"owner":{"login":"caicloud","id":12522124,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTIyMTI0","avatar_url":"https://avatars2.githubusercontent.com/u/12522124?v=4","gravatar_id":"","url":"https://api.github.com/users/caicloud","html_url":"https://github.com/caicloud","followers_url":"https://api.github.com/users/caicloud/followers","following_url":"https://api.github.com/users/caicloud/following{/other_user}","gists_url":"https://api.github.com/users/caicloud/gists{/gist_id}","starred_url":"https://api.github.com/users/caicloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caicloud/subscriptions","organizations_url":"https://api.github.com/users/caicloud/orgs","repos_url":"https://api.github.com/users/caicloud/repos","events_url":"https://api.github.com/users/caicloud/events{/privacy}","received_events_url":"https://api.github.com/users/caicloud/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/caicloud/cyclone","description":"A cloud native CI/CD platform built for container workflow","fork":false,"url":"https://api.github.com/repos/caicloud/cyclone","forks_url":"https://api.github.com/repos/caicloud/cyclone/forks","keys_url":"https://api.github.com/repos/caicloud/cyclone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caicloud/cyclone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caicloud/cyclone/teams","hooks_url":"https://api.github.com/repos/caicloud/cyclone/hooks","issue_events_url":"https://api.github.com/repos/caicloud/cyclone/issues/events{/number}","events_url":"https://api.github.com/repos/caicloud/cyclone/events","assignees_url":"https://api.github.com/repos/caicloud/cyclone/assignees{/user}","branches_url":"https://api.github.com/repos/caicloud/cyclone/branches{/branch}","tags_url":"https://api.github.com/repos/caicloud/cyclone/tags","blobs_url":"https://api.github.com/repos/caicloud/cyclone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caicloud/cyclone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caicloud/cyclone/git/refs{/sha}","trees_url":"https://api.github.com/repos/caicloud/cyclone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caicloud/cyclone/statuses/{sha}","languages_url":"https://api.github.com/repos/caicloud/cyclone/languages","stargazers_url":"https://api.github.com/repos/caicloud/cyclone/stargazers","contributors_url":"https://api.github.com/repos/caicloud/cyclone/contributors","subscribers_url":"https://api.github.com/repos/caicloud/cyclone/subscribers","subscription_url":"https://api.github.com/repos/caicloud/cyclone/subscription","commits_url":"https://api.github.com/repos/caicloud/cyclone/commits{/sha}","git_commits_url":"https://api.github.com/repos/caicloud/cyclone/git/commits{/sha}","comments_url":"https://api.github.com/repos/caicloud/cyclone/comments{/number}","issue_comment_url":"https://api.github.com/repos/caicloud/cyclone/issues/comments{/number}","contents_url":"https://api.github.com/repos/caicloud/cyclone/contents/{+path}","compare_url":"https://api.github.com/repos/caicloud/cyclone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caicloud/cyclone/merges","archive_url":"https://api.github.com/repos/caicloud/cyclone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caicloud/cyclone/downloads","issues_url":"https://api.github.com/repos/caicloud/cyclone/issues{/number}","pulls_url":"https://api.github.com/repos/caicloud/cyclone/pulls{/number}","milestones_url":"https://api.github.com/repos/caicloud/cyclone/milestones{/number}","notifications_url":"https://api.github.com/repos/caicloud/cyclone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caicloud/cyclone/labels{/name}","releases_url":"https://api.github.com/repos/caicloud/cyclone/releases{/id}","deployments_url":"https://api.github.com/repos/caicloud/cyclone/deployments","created_at":"2016-10-17T04:19:35Z","updated_at":"2018-11-08T23:27:24Z","pushed_at":"2018-11-08T13:46:01Z","git_url":"git://github.com/caicloud/cyclone.git","ssh_url":"git@github.com:caicloud/cyclone.git","clone_url":"https://github.com/caicloud/cyclone.git","svn_url":"https://github.com/caicloud/cyclone","homepage":"","size":69262,"stargazers_count":606,"watchers_count":606,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":112,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":112,"open_issues":11,"watchers":606,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/caicloud/cyclone/pulls/598"},"html":{"href":"https://github.com/caicloud/cyclone/pull/598"},"issue":{"href":"https://api.github.com/repos/caicloud/cyclone/issues/598"},"comments":{"href":"https://api.github.com/repos/caicloud/cyclone/issues/598/comments"},"review_comments":{"href":"https://api.github.com/repos/caicloud/cyclone/pulls/598/comments"},"review_comment":{"href":"https://api.github.com/repos/caicloud/cyclone/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/caicloud/cyclone/pulls/598/commits"},"statuses":{"href":"https://api.github.com/repos/caicloud/cyclone/statuses/c8ac152a4497a9e0db7302429fead2c05b9dc72c"}},"author_association":"NONE"}}
{"actor":{"display_login":"ddysher"}}