{"action":"created","comment":{"url":"https://api.github.com/repos/MirServer/mir/pulls/comments/185408270","pull_request_review_id":116788380,"id":185408270,"diff_hunk":"@@ -1,6 +1,8 @@\n add_subdirectory(protocol/)\n add_subdirectory(generated/)\n \n+include_directories(../frontend_xwayland)","path":"src/server/frontend_wayland/CMakeLists.txt","position":4,"original_position":4,"commit_id":"067e04e80ed396337f6e5f31723744acf9b8fd17","original_commit_id":"067e04e80ed396337f6e5f31723744acf9b8fd17","user":{"login":"AlanGriffiths","id":9048879,"avatar_url":"https://avatars1.githubusercontent.com/u/9048879?v=4","gravatar_id":"","url":"https://api.github.com/users/AlanGriffiths","html_url":"https://github.com/AlanGriffiths","followers_url":"https://api.github.com/users/AlanGriffiths/followers","following_url":"https://api.github.com/users/AlanGriffiths/following{/other_user}","gists_url":"https://api.github.com/users/AlanGriffiths/gists{/gist_id}","starred_url":"https://api.github.com/users/AlanGriffiths/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlanGriffiths/subscriptions","organizations_url":"https://api.github.com/users/AlanGriffiths/orgs","repos_url":"https://api.github.com/users/AlanGriffiths/repos","events_url":"https://api.github.com/users/AlanGriffiths/events{/privacy}","received_events_url":"https://api.github.com/users/AlanGriffiths/received_events","type":"User","site_admin":false},"body":"This makes me wonder if we'd be better with frontend_wayland/x11. (Just opening discussion, not suggesting a change.)","created_at":"2018-05-02T07:05:41Z","updated_at":"2018-05-02T07:51:41Z","html_url":"https://github.com/MirServer/mir/pull/352#discussion_r185408270","pull_request_url":"https://api.github.com/repos/MirServer/mir/pulls/352","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/MirServer/mir/pulls/comments/185408270"},"html":{"href":"https://github.com/MirServer/mir/pull/352#discussion_r185408270"},"pull_request":{"href":"https://api.github.com/repos/MirServer/mir/pulls/352"}}},"pull_request":{"url":"https://api.github.com/repos/MirServer/mir/pulls/352","id":185188607,"html_url":"https://github.com/MirServer/mir/pull/352","diff_url":"https://github.com/MirServer/mir/pull/352.diff","patch_url":"https://github.com/MirServer/mir/pull/352.patch","issue_url":"https://api.github.com/repos/MirServer/mir/issues/352","number":352,"state":"open","locked":false,"title":"Initial X11 support","user":{"login":"mariogrip","id":1642635,"avatar_url":"https://avatars1.githubusercontent.com/u/1642635?v=4","gravatar_id":"","url":"https://api.github.com/users/mariogrip","html_url":"https://github.com/mariogrip","followers_url":"https://api.github.com/users/mariogrip/followers","following_url":"https://api.github.com/users/mariogrip/following{/other_user}","gists_url":"https://api.github.com/users/mariogrip/gists{/gist_id}","starred_url":"https://api.github.com/users/mariogrip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariogrip/subscriptions","organizations_url":"https://api.github.com/users/mariogrip/orgs","repos_url":"https://api.github.com/users/mariogrip/repos","events_url":"https://api.github.com/users/mariogrip/events{/privacy}","received_events_url":"https://api.github.com/users/mariogrip/received_events","type":"User","site_admin":false},"body":"This adds basic X11 support using Xwayland.\r\n\r\nThis uses the X11 api to create a X11 window manager to handle events and shell surface creation etc\r\n\r\nThis is not finished, just up to get the review started, so don't merge yet!","created_at":"2018-05-01T14:22:00Z","updated_at":"2018-05-02T07:51:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6408d8ddfe75082389b314f101ff4a25de33c6c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":772600637,"url":"https://api.github.com/repos/MirServer/mir/labels/no-merge","name":"no-merge","color":"000000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/MirServer/mir/pulls/352/commits","review_comments_url":"https://api.github.com/repos/MirServer/mir/pulls/352/comments","review_comment_url":"https://api.github.com/repos/MirServer/mir/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MirServer/mir/issues/352/comments","statuses_url":"https://api.github.com/repos/MirServer/mir/statuses/067e04e80ed396337f6e5f31723744acf9b8fd17","head":{"label":"ubports:x11-support","ref":"x11-support","sha":"067e04e80ed396337f6e5f31723744acf9b8fd17","user":{"login":"ubports","id":11358614,"avatar_url":"https://avatars1.githubusercontent.com/u/11358614?v=4","gravatar_id":"","url":"https://api.github.com/users/ubports","html_url":"https://github.com/ubports","followers_url":"https://api.github.com/users/ubports/followers","following_url":"https://api.github.com/users/ubports/following{/other_user}","gists_url":"https://api.github.com/users/ubports/gists{/gist_id}","starred_url":"https://api.github.com/users/ubports/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubports/subscriptions","organizations_url":"https://api.github.com/users/ubports/orgs","repos_url":"https://api.github.com/users/ubports/repos","events_url":"https://api.github.com/users/ubports/events{/privacy}","received_events_url":"https://api.github.com/users/ubports/received_events","type":"Organization","site_admin":false},"repo":{"id":115992465,"name":"mir-1","full_name":"ubports/mir-1","owner":{"login":"ubports","id":11358614,"avatar_url":"https://avatars1.githubusercontent.com/u/11358614?v=4","gravatar_id":"","url":"https://api.github.com/users/ubports","html_url":"https://github.com/ubports","followers_url":"https://api.github.com/users/ubports/followers","following_url":"https://api.github.com/users/ubports/following{/other_user}","gists_url":"https://api.github.com/users/ubports/gists{/gist_id}","starred_url":"https://api.github.com/users/ubports/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubports/subscriptions","organizations_url":"https://api.github.com/users/ubports/orgs","repos_url":"https://api.github.com/users/ubports/repos","events_url":"https://api.github.com/users/ubports/events{/privacy}","received_events_url":"https://api.github.com/users/ubports/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ubports/mir-1","description":"The Mir compositor","fork":true,"url":"https://api.github.com/repos/ubports/mir-1","forks_url":"https://api.github.com/repos/ubports/mir-1/forks","keys_url":"https://api.github.com/repos/ubports/mir-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ubports/mir-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ubports/mir-1/teams","hooks_url":"https://api.github.com/repos/ubports/mir-1/hooks","issue_events_url":"https://api.github.com/repos/ubports/mir-1/issues/events{/number}","events_url":"https://api.github.com/repos/ubports/mir-1/events","assignees_url":"https://api.github.com/repos/ubports/mir-1/assignees{/user}","branches_url":"https://api.github.com/repos/ubports/mir-1/branches{/branch}","tags_url":"https://api.github.com/repos/ubports/mir-1/tags","blobs_url":"https://api.github.com/repos/ubports/mir-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ubports/mir-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ubports/mir-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/ubports/mir-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ubports/mir-1/statuses/{sha}","languages_url":"https://api.github.com/repos/ubports/mir-1/languages","stargazers_url":"https://api.github.com/repos/ubports/mir-1/stargazers","contributors_url":"https://api.github.com/repos/ubports/mir-1/contributors","subscribers_url":"https://api.github.com/repos/ubports/mir-1/subscribers","subscription_url":"https://api.github.com/repos/ubports/mir-1/subscription","commits_url":"https://api.github.com/repos/ubports/mir-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/ubports/mir-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/ubports/mir-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/ubports/mir-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/ubports/mir-1/contents/{+path}","compare_url":"https://api.github.com/repos/ubports/mir-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ubports/mir-1/merges","archive_url":"https://api.github.com/repos/ubports/mir-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ubports/mir-1/downloads","issues_url":"https://api.github.com/repos/ubports/mir-1/issues{/number}","pulls_url":"https://api.github.com/repos/ubports/mir-1/pulls{/number}","milestones_url":"https://api.github.com/repos/ubports/mir-1/milestones{/number}","notifications_url":"https://api.github.com/repos/ubports/mir-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ubports/mir-1/labels{/name}","releases_url":"https://api.github.com/repos/ubports/mir-1/releases{/id}","deployments_url":"https://api.github.com/repos/ubports/mir-1/deployments","created_at":"2018-01-02T08:25:27Z","updated_at":"2018-05-01T21:49:40Z","pushed_at":"2018-05-01T19:05:29Z","git_url":"git://github.com/ubports/mir-1.git","ssh_url":"git@github.com:ubports/mir-1.git","clone_url":"https://github.com/ubports/mir-1.git","svn_url":"https://github.com/ubports/mir-1","homepage":null,"size":177870,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"MirServer:master","ref":"master","sha":"d8414af1639527a975ced3b2c338423ed512cef9","user":{"login":"MirServer","id":30658783,"avatar_url":"https://avatars2.githubusercontent.com/u/30658783?v=4","gravatar_id":"","url":"https://api.github.com/users/MirServer","html_url":"https://github.com/MirServer","followers_url":"https://api.github.com/users/MirServer/followers","following_url":"https://api.github.com/users/MirServer/following{/other_user}","gists_url":"https://api.github.com/users/MirServer/gists{/gist_id}","starred_url":"https://api.github.com/users/MirServer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MirServer/subscriptions","organizations_url":"https://api.github.com/users/MirServer/orgs","repos_url":"https://api.github.com/users/MirServer/repos","events_url":"https://api.github.com/users/MirServer/events{/privacy}","received_events_url":"https://api.github.com/users/MirServer/received_events","type":"Organization","site_admin":false},"repo":{"id":99117626,"name":"mir","full_name":"MirServer/mir","owner":{"login":"MirServer","id":30658783,"avatar_url":"https://avatars2.githubusercontent.com/u/30658783?v=4","gravatar_id":"","url":"https://api.github.com/users/MirServer","html_url":"https://github.com/MirServer","followers_url":"https://api.github.com/users/MirServer/followers","following_url":"https://api.github.com/users/MirServer/following{/other_user}","gists_url":"https://api.github.com/users/MirServer/gists{/gist_id}","starred_url":"https://api.github.com/users/MirServer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MirServer/subscriptions","organizations_url":"https://api.github.com/users/MirServer/orgs","repos_url":"https://api.github.com/users/MirServer/repos","events_url":"https://api.github.com/users/MirServer/events{/privacy}","received_events_url":"https://api.github.com/users/MirServer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MirServer/mir","description":"The Mir compositor","fork":false,"url":"https://api.github.com/repos/MirServer/mir","forks_url":"https://api.github.com/repos/MirServer/mir/forks","keys_url":"https://api.github.com/repos/MirServer/mir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MirServer/mir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MirServer/mir/teams","hooks_url":"https://api.github.com/repos/MirServer/mir/hooks","issue_events_url":"https://api.github.com/repos/MirServer/mir/issues/events{/number}","events_url":"https://api.github.com/repos/MirServer/mir/events","assignees_url":"https://api.github.com/repos/MirServer/mir/assignees{/user}","branches_url":"https://api.github.com/repos/MirServer/mir/branches{/branch}","tags_url":"https://api.github.com/repos/MirServer/mir/tags","blobs_url":"https://api.github.com/repos/MirServer/mir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MirServer/mir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MirServer/mir/git/refs{/sha}","trees_url":"https://api.github.com/repos/MirServer/mir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MirServer/mir/statuses/{sha}","languages_url":"https://api.github.com/repos/MirServer/mir/languages","stargazers_url":"https://api.github.com/repos/MirServer/mir/stargazers","contributors_url":"https://api.github.com/repos/MirServer/mir/contributors","subscribers_url":"https://api.github.com/repos/MirServer/mir/subscribers","subscription_url":"https://api.github.com/repos/MirServer/mir/subscription","commits_url":"https://api.github.com/repos/MirServer/mir/commits{/sha}","git_commits_url":"https://api.github.com/repos/MirServer/mir/git/commits{/sha}","comments_url":"https://api.github.com/repos/MirServer/mir/comments{/number}","issue_comment_url":"https://api.github.com/repos/MirServer/mir/issues/comments{/number}","contents_url":"https://api.github.com/repos/MirServer/mir/contents/{+path}","compare_url":"https://api.github.com/repos/MirServer/mir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MirServer/mir/merges","archive_url":"https://api.github.com/repos/MirServer/mir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MirServer/mir/downloads","issues_url":"https://api.github.com/repos/MirServer/mir/issues{/number}","pulls_url":"https://api.github.com/repos/MirServer/mir/pulls{/number}","milestones_url":"https://api.github.com/repos/MirServer/mir/milestones{/number}","notifications_url":"https://api.github.com/repos/MirServer/mir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MirServer/mir/labels{/name}","releases_url":"https://api.github.com/repos/MirServer/mir/releases{/id}","deployments_url":"https://api.github.com/repos/MirServer/mir/deployments","created_at":"2017-08-02T13:09:25Z","updated_at":"2018-05-01T18:06:52Z","pushed_at":"2018-05-01T19:05:30Z","git_url":"git://github.com/MirServer/mir.git","ssh_url":"git@github.com:MirServer/mir.git","clone_url":"https://github.com/MirServer/mir.git","svn_url":"https://github.com/MirServer/mir","homepage":null,"size":177937,"stargazers_count":90,"watchers_count":90,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":15,"open_issues":25,"watchers":90,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MirServer/mir/pulls/352"},"html":{"href":"https://github.com/MirServer/mir/pull/352"},"issue":{"href":"https://api.github.com/repos/MirServer/mir/issues/352"},"comments":{"href":"https://api.github.com/repos/MirServer/mir/issues/352/comments"},"review_comments":{"href":"https://api.github.com/repos/MirServer/mir/pulls/352/comments"},"review_comment":{"href":"https://api.github.com/repos/MirServer/mir/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MirServer/mir/pulls/352/commits"},"statuses":{"href":"https://api.github.com/repos/MirServer/mir/statuses/067e04e80ed396337f6e5f31723744acf9b8fd17"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"AlanGriffiths"}}