{"action":"created","comment":{"url":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/comments/196936443","pull_request_review_id":130581488,"id":196936443,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjkzNjQ0Mw==","diff_hunk":"@@ -151,16 +151,18 @@ def _reset_time_logs(self, force=False):\n         with LockFile(file_lock) as _lock_file:\n             assert _lock_file is not None\n             if os.path.exists(file_path):\n-                if not force:\n-                    with open(file_path, 'rb+') as time_log_file:\n-                        existing_times = pickle.load(time_log_file)\n-                        if time.time() - existing_times['last_reset'] > \\\n-                                24 * 60 * 60:  # Reset if more than a day old\n-                            pass\n-                        elif time.time() - existing_times['last_reset'] < \\\n-                                RESET_TIME_LOG_TIMEOUT:\n-                            # no need to reset, another thread did recently\n-                            return\n+                with open(file_path, 'rb+') as time_log_file:\n+                    existing_times = pickle.load(time_log_file)\n+                    if time.time() - existing_times['last_reset'] > \\","path":"parlai/mturk/core/mturk_manager.py","position":16,"original_position":16,"commit_id":"b1fad27271d21d56adbbd53c02cbbb8f169422a7","original_commit_id":"b1fad27271d21d56adbbd53c02cbbb8f169422a7","user":{"login":"klshuster","id":8562788,"node_id":"MDQ6VXNlcjg1NjI3ODg=","avatar_url":"https://avatars3.githubusercontent.com/u/8562788?v=4","gravatar_id":"","url":"https://api.github.com/users/klshuster","html_url":"https://github.com/klshuster","followers_url":"https://api.github.com/users/klshuster/followers","following_url":"https://api.github.com/users/klshuster/following{/other_user}","gists_url":"https://api.github.com/users/klshuster/gists{/gist_id}","starred_url":"https://api.github.com/users/klshuster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klshuster/subscriptions","organizations_url":"https://api.github.com/users/klshuster/orgs","repos_url":"https://api.github.com/users/klshuster/repos","events_url":"https://api.github.com/users/klshuster/events{/privacy}","received_events_url":"https://api.github.com/users/klshuster/received_events","type":"User","site_admin":false},"body":"sorry, maybe i am confused - so this checks if the last reset was greater than a day, and then does nothing if so?","created_at":"2018-06-20T20:45:04Z","updated_at":"2018-06-20T20:46:45Z","html_url":"https://github.com/facebookresearch/ParlAI/pull/900#discussion_r196936443","pull_request_url":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/900","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/comments/196936443"},"html":{"href":"https://github.com/facebookresearch/ParlAI/pull/900#discussion_r196936443"},"pull_request":{"href":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/900"}}},"pull_request":{"url":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/900","id":196265334,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MjY1MzM0","html_url":"https://github.com/facebookresearch/ParlAI/pull/900","diff_url":"https://github.com/facebookresearch/ParlAI/pull/900.diff","patch_url":"https://github.com/facebookresearch/ParlAI/pull/900.patch","issue_url":"https://api.github.com/repos/facebookresearch/ParlAI/issues/900","number":900,"state":"open","locked":false,"title":"[MTurk] Fixing time resets","user":{"login":"JackUrb","id":1276867,"node_id":"MDQ6VXNlcjEyNzY4Njc=","avatar_url":"https://avatars2.githubusercontent.com/u/1276867?v=4","gravatar_id":"","url":"https://api.github.com/users/JackUrb","html_url":"https://github.com/JackUrb","followers_url":"https://api.github.com/users/JackUrb/followers","following_url":"https://api.github.com/users/JackUrb/following{/other_user}","gists_url":"https://api.github.com/users/JackUrb/gists{/gist_id}","starred_url":"https://api.github.com/users/JackUrb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JackUrb/subscriptions","organizations_url":"https://api.github.com/users/JackUrb/orgs","repos_url":"https://api.github.com/users/JackUrb/repos","events_url":"https://api.github.com/users/JackUrb/events{/privacy}","received_events_url":"https://api.github.com/users/JackUrb/received_events","type":"User","site_admin":false},"body":"Explicitly ensures freeing workers by freeing all the workers being removed from a refreshed worker_time file. Ensures repeated delete_qualification calls don't crash the system.","created_at":"2018-06-20T20:38:25Z","updated_at":"2018-06-20T20:46:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"478b56161cc5c186abbc07cce4f4c6f4d5dbd324","assignee":{"login":"JackUrb","id":1276867,"node_id":"MDQ6VXNlcjEyNzY4Njc=","avatar_url":"https://avatars2.githubusercontent.com/u/1276867?v=4","gravatar_id":"","url":"https://api.github.com/users/JackUrb","html_url":"https://github.com/JackUrb","followers_url":"https://api.github.com/users/JackUrb/followers","following_url":"https://api.github.com/users/JackUrb/following{/other_user}","gists_url":"https://api.github.com/users/JackUrb/gists{/gist_id}","starred_url":"https://api.github.com/users/JackUrb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JackUrb/subscriptions","organizations_url":"https://api.github.com/users/JackUrb/orgs","repos_url":"https://api.github.com/users/JackUrb/repos","events_url":"https://api.github.com/users/JackUrb/events{/privacy}","received_events_url":"https://api.github.com/users/JackUrb/received_events","type":"User","site_admin":false},"assignees":[{"login":"JackUrb","id":1276867,"node_id":"MDQ6VXNlcjEyNzY4Njc=","avatar_url":"https://avatars2.githubusercontent.com/u/1276867?v=4","gravatar_id":"","url":"https://api.github.com/users/JackUrb","html_url":"https://github.com/JackUrb","followers_url":"https://api.github.com/users/JackUrb/followers","following_url":"https://api.github.com/users/JackUrb/following{/other_user}","gists_url":"https://api.github.com/users/JackUrb/gists{/gist_id}","starred_url":"https://api.github.com/users/JackUrb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JackUrb/subscriptions","organizations_url":"https://api.github.com/users/JackUrb/orgs","repos_url":"https://api.github.com/users/JackUrb/repos","events_url":"https://api.github.com/users/JackUrb/events{/privacy}","received_events_url":"https://api.github.com/users/JackUrb/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":590886701,"node_id":"MDU6TGFiZWw1OTA4ODY3MDE=","url":"https://api.github.com/repos/facebookresearch/ParlAI/labels/CLA%20Signed","name":"CLA Signed","color":"009900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/900/commits","review_comments_url":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/900/comments","review_comment_url":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebookresearch/ParlAI/issues/900/comments","statuses_url":"https://api.github.com/repos/facebookresearch/ParlAI/statuses/b1fad27271d21d56adbbd53c02cbbb8f169422a7","head":{"label":"facebookresearch:ensure-worker-freed","ref":"ensure-worker-freed","sha":"b1fad27271d21d56adbbd53c02cbbb8f169422a7","user":{"login":"facebookresearch","id":16943930,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTQzOTMw","avatar_url":"https://avatars0.githubusercontent.com/u/16943930?v=4","gravatar_id":"","url":"https://api.github.com/users/facebookresearch","html_url":"https://github.com/facebookresearch","followers_url":"https://api.github.com/users/facebookresearch/followers","following_url":"https://api.github.com/users/facebookresearch/following{/other_user}","gists_url":"https://api.github.com/users/facebookresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/facebookresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebookresearch/subscriptions","organizations_url":"https://api.github.com/users/facebookresearch/orgs","repos_url":"https://api.github.com/users/facebookresearch/repos","events_url":"https://api.github.com/users/facebookresearch/events{/privacy}","received_events_url":"https://api.github.com/users/facebookresearch/received_events","type":"Organization","site_admin":false},"repo":{"id":89266735,"node_id":"MDEwOlJlcG9zaXRvcnk4OTI2NjczNQ==","name":"ParlAI","full_name":"facebookresearch/ParlAI","owner":{"login":"facebookresearch","id":16943930,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTQzOTMw","avatar_url":"https://avatars0.githubusercontent.com/u/16943930?v=4","gravatar_id":"","url":"https://api.github.com/users/facebookresearch","html_url":"https://github.com/facebookresearch","followers_url":"https://api.github.com/users/facebookresearch/followers","following_url":"https://api.github.com/users/facebookresearch/following{/other_user}","gists_url":"https://api.github.com/users/facebookresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/facebookresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebookresearch/subscriptions","organizations_url":"https://api.github.com/users/facebookresearch/orgs","repos_url":"https://api.github.com/users/facebookresearch/repos","events_url":"https://api.github.com/users/facebookresearch/events{/privacy}","received_events_url":"https://api.github.com/users/facebookresearch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebookresearch/ParlAI","description":"A framework for training and evaluating AI models on a variety of openly available dialog datasets.","fork":false,"url":"https://api.github.com/repos/facebookresearch/ParlAI","forks_url":"https://api.github.com/repos/facebookresearch/ParlAI/forks","keys_url":"https://api.github.com/repos/facebookresearch/ParlAI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebookresearch/ParlAI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebookresearch/ParlAI/teams","hooks_url":"https://api.github.com/repos/facebookresearch/ParlAI/hooks","issue_events_url":"https://api.github.com/repos/facebookresearch/ParlAI/issues/events{/number}","events_url":"https://api.github.com/repos/facebookresearch/ParlAI/events","assignees_url":"https://api.github.com/repos/facebookresearch/ParlAI/assignees{/user}","branches_url":"https://api.github.com/repos/facebookresearch/ParlAI/branches{/branch}","tags_url":"https://api.github.com/repos/facebookresearch/ParlAI/tags","blobs_url":"https://api.github.com/repos/facebookresearch/ParlAI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebookresearch/ParlAI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebookresearch/ParlAI/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebookresearch/ParlAI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebookresearch/ParlAI/statuses/{sha}","languages_url":"https://api.github.com/repos/facebookresearch/ParlAI/languages","stargazers_url":"https://api.github.com/repos/facebookresearch/ParlAI/stargazers","contributors_url":"https://api.github.com/repos/facebookresearch/ParlAI/contributors","subscribers_url":"https://api.github.com/repos/facebookresearch/ParlAI/subscribers","subscription_url":"https://api.github.com/repos/facebookresearch/ParlAI/subscription","commits_url":"https://api.github.com/repos/facebookresearch/ParlAI/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebookresearch/ParlAI/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebookresearch/ParlAI/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebookresearch/ParlAI/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebookresearch/ParlAI/contents/{+path}","compare_url":"https://api.github.com/repos/facebookresearch/ParlAI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebookresearch/ParlAI/merges","archive_url":"https://api.github.com/repos/facebookresearch/ParlAI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebookresearch/ParlAI/downloads","issues_url":"https://api.github.com/repos/facebookresearch/ParlAI/issues{/number}","pulls_url":"https://api.github.com/repos/facebookresearch/ParlAI/pulls{/number}","milestones_url":"https://api.github.com/repos/facebookresearch/ParlAI/milestones{/number}","notifications_url":"https://api.github.com/repos/facebookresearch/ParlAI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebookresearch/ParlAI/labels{/name}","releases_url":"https://api.github.com/repos/facebookresearch/ParlAI/releases{/id}","deployments_url":"https://api.github.com/repos/facebookresearch/ParlAI/deployments","created_at":"2017-04-24T17:10:44Z","updated_at":"2018-06-20T19:24:52Z","pushed_at":"2018-06-20T20:46:29Z","git_url":"git://github.com/facebookresearch/ParlAI.git","ssh_url":"git@github.com:facebookresearch/ParlAI.git","clone_url":"https://github.com/facebookresearch/ParlAI.git","svn_url":"https://github.com/facebookresearch/ParlAI","homepage":"parl.ai","size":10616,"stargazers_count":3405,"watchers_count":3405,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":588,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":588,"open_issues":23,"watchers":3405,"default_branch":"master"}},"base":{"label":"facebookresearch:master","ref":"master","sha":"ed28cdc55552900f1ec2c4f08a11c35dfa2f4b58","user":{"login":"facebookresearch","id":16943930,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTQzOTMw","avatar_url":"https://avatars0.githubusercontent.com/u/16943930?v=4","gravatar_id":"","url":"https://api.github.com/users/facebookresearch","html_url":"https://github.com/facebookresearch","followers_url":"https://api.github.com/users/facebookresearch/followers","following_url":"https://api.github.com/users/facebookresearch/following{/other_user}","gists_url":"https://api.github.com/users/facebookresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/facebookresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebookresearch/subscriptions","organizations_url":"https://api.github.com/users/facebookresearch/orgs","repos_url":"https://api.github.com/users/facebookresearch/repos","events_url":"https://api.github.com/users/facebookresearch/events{/privacy}","received_events_url":"https://api.github.com/users/facebookresearch/received_events","type":"Organization","site_admin":false},"repo":{"id":89266735,"node_id":"MDEwOlJlcG9zaXRvcnk4OTI2NjczNQ==","name":"ParlAI","full_name":"facebookresearch/ParlAI","owner":{"login":"facebookresearch","id":16943930,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTQzOTMw","avatar_url":"https://avatars0.githubusercontent.com/u/16943930?v=4","gravatar_id":"","url":"https://api.github.com/users/facebookresearch","html_url":"https://github.com/facebookresearch","followers_url":"https://api.github.com/users/facebookresearch/followers","following_url":"https://api.github.com/users/facebookresearch/following{/other_user}","gists_url":"https://api.github.com/users/facebookresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/facebookresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebookresearch/subscriptions","organizations_url":"https://api.github.com/users/facebookresearch/orgs","repos_url":"https://api.github.com/users/facebookresearch/repos","events_url":"https://api.github.com/users/facebookresearch/events{/privacy}","received_events_url":"https://api.github.com/users/facebookresearch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebookresearch/ParlAI","description":"A framework for training and evaluating AI models on a variety of openly available dialog datasets.","fork":false,"url":"https://api.github.com/repos/facebookresearch/ParlAI","forks_url":"https://api.github.com/repos/facebookresearch/ParlAI/forks","keys_url":"https://api.github.com/repos/facebookresearch/ParlAI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebookresearch/ParlAI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebookresearch/ParlAI/teams","hooks_url":"https://api.github.com/repos/facebookresearch/ParlAI/hooks","issue_events_url":"https://api.github.com/repos/facebookresearch/ParlAI/issues/events{/number}","events_url":"https://api.github.com/repos/facebookresearch/ParlAI/events","assignees_url":"https://api.github.com/repos/facebookresearch/ParlAI/assignees{/user}","branches_url":"https://api.github.com/repos/facebookresearch/ParlAI/branches{/branch}","tags_url":"https://api.github.com/repos/facebookresearch/ParlAI/tags","blobs_url":"https://api.github.com/repos/facebookresearch/ParlAI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebookresearch/ParlAI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebookresearch/ParlAI/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebookresearch/ParlAI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebookresearch/ParlAI/statuses/{sha}","languages_url":"https://api.github.com/repos/facebookresearch/ParlAI/languages","stargazers_url":"https://api.github.com/repos/facebookresearch/ParlAI/stargazers","contributors_url":"https://api.github.com/repos/facebookresearch/ParlAI/contributors","subscribers_url":"https://api.github.com/repos/facebookresearch/ParlAI/subscribers","subscription_url":"https://api.github.com/repos/facebookresearch/ParlAI/subscription","commits_url":"https://api.github.com/repos/facebookresearch/ParlAI/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebookresearch/ParlAI/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebookresearch/ParlAI/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebookresearch/ParlAI/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebookresearch/ParlAI/contents/{+path}","compare_url":"https://api.github.com/repos/facebookresearch/ParlAI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebookresearch/ParlAI/merges","archive_url":"https://api.github.com/repos/facebookresearch/ParlAI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebookresearch/ParlAI/downloads","issues_url":"https://api.github.com/repos/facebookresearch/ParlAI/issues{/number}","pulls_url":"https://api.github.com/repos/facebookresearch/ParlAI/pulls{/number}","milestones_url":"https://api.github.com/repos/facebookresearch/ParlAI/milestones{/number}","notifications_url":"https://api.github.com/repos/facebookresearch/ParlAI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebookresearch/ParlAI/labels{/name}","releases_url":"https://api.github.com/repos/facebookresearch/ParlAI/releases{/id}","deployments_url":"https://api.github.com/repos/facebookresearch/ParlAI/deployments","created_at":"2017-04-24T17:10:44Z","updated_at":"2018-06-20T19:24:52Z","pushed_at":"2018-06-20T20:46:29Z","git_url":"git://github.com/facebookresearch/ParlAI.git","ssh_url":"git@github.com:facebookresearch/ParlAI.git","clone_url":"https://github.com/facebookresearch/ParlAI.git","svn_url":"https://github.com/facebookresearch/ParlAI","homepage":"parl.ai","size":10616,"stargazers_count":3405,"watchers_count":3405,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":588,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":588,"open_issues":23,"watchers":3405,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/900"},"html":{"href":"https://github.com/facebookresearch/ParlAI/pull/900"},"issue":{"href":"https://api.github.com/repos/facebookresearch/ParlAI/issues/900"},"comments":{"href":"https://api.github.com/repos/facebookresearch/ParlAI/issues/900/comments"},"review_comments":{"href":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/900/comments"},"review_comment":{"href":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/900/commits"},"statuses":{"href":"https://api.github.com/repos/facebookresearch/ParlAI/statuses/b1fad27271d21d56adbbd53c02cbbb8f169422a7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"klshuster"}}