{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/190714507","pull_request_review_id":123151992,"id":190714507,"diff_hunk":"@@ -101,7 +124,7 @@ public unsafe struct OBJECT_ATTRIBUTES\n             /// </summary>\n             public unsafe OBJECT_ATTRIBUTES(UNICODE_STRING* objectName, ObjectAttributes attributes, IntPtr rootDirectory)\n             {\n-                Length = (uint)sizeof(OBJECT_ATTRIBUTES);\n+                Length = (uint)Marshal.SizeOf(typeof(OBJECT_ATTRIBUTES));","path":"src/Common/src/Interop/Windows/NtDll/Interop.NtCreateFile.cs","position":81,"original_position":81,"commit_id":"51fedd274c4d8b1b206c6cc58775e499b10532a3","original_commit_id":"51fedd274c4d8b1b206c6cc58775e499b10532a3","user":{"login":"JeremyKuhne","id":8184940,"avatar_url":"https://avatars3.githubusercontent.com/u/8184940?v=4","gravatar_id":"","url":"https://api.github.com/users/JeremyKuhne","html_url":"https://github.com/JeremyKuhne","followers_url":"https://api.github.com/users/JeremyKuhne/followers","following_url":"https://api.github.com/users/JeremyKuhne/following{/other_user}","gists_url":"https://api.github.com/users/JeremyKuhne/gists{/gist_id}","starred_url":"https://api.github.com/users/JeremyKuhne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeremyKuhne/subscriptions","organizations_url":"https://api.github.com/users/JeremyKuhne/orgs","repos_url":"https://api.github.com/users/JeremyKuhne/repos","events_url":"https://api.github.com/users/JeremyKuhne/events{/privacy}","received_events_url":"https://api.github.com/users/JeremyKuhne/received_events","type":"User","site_admin":false},"body":"Don't change this to Marshal.SizeOf- it is much more expensive.","created_at":"2018-05-24T20:06:52Z","updated_at":"2018-05-24T20:06:52Z","html_url":"https://github.com/dotnet/corefx/pull/29879#discussion_r190714507","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/29879","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/190714507"},"html":{"href":"https://github.com/dotnet/corefx/pull/29879#discussion_r190714507"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/29879"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/29879","id":190125308,"html_url":"https://github.com/dotnet/corefx/pull/29879","diff_url":"https://github.com/dotnet/corefx/pull/29879.diff","patch_url":"https://github.com/dotnet/corefx/pull/29879.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/29879","number":29879,"state":"open","locked":false,"title":"GH Issue #15652 SqlFileStream Implementation","user":{"login":"keeratsingh","id":2684055,"avatar_url":"https://avatars0.githubusercontent.com/u/2684055?v=4","gravatar_id":"","url":"https://api.github.com/users/keeratsingh","html_url":"https://github.com/keeratsingh","followers_url":"https://api.github.com/users/keeratsingh/followers","following_url":"https://api.github.com/users/keeratsingh/following{/other_user}","gists_url":"https://api.github.com/users/keeratsingh/gists{/gist_id}","starred_url":"https://api.github.com/users/keeratsingh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keeratsingh/subscriptions","organizations_url":"https://api.github.com/users/keeratsingh/orgs","repos_url":"https://api.github.com/users/keeratsingh/repos","events_url":"https://api.github.com/users/keeratsingh/events{/privacy}","received_events_url":"https://api.github.com/users/keeratsingh/received_events","type":"User","site_admin":false},"body":"This Pull Request ports the SqlFileStream #15652 capability only on Windows.\r\nSqlClient throws `SqlFileStream is not supported on this platform` exception for Non-Windows Platforms.\r\n\r\n| Client        | Server           | Feasible  | Comments  |\r\n| :------------- |:-------------| :-----|  :----- |\r\n| Windows      | Windows | Yes | Implemented by this PR. |\r\n| Windows      | Linux      |  No |  SQL Server on Linux does not support FileStream. |\r\n| Linux | Windows      |   No | Currently there is no way to open a file over SMB and pass the Extended Attributes. |\r\n| Linux | Linux      |    No | SQL Server on Linux does not support FileStream. |","created_at":"2018-05-23T22:43:25Z","updated_at":"2018-05-24T20:06:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"114548b3aa79736c33193245f7919cc77013fa32","assignee":null,"assignees":[],"requested_reviewers":[{"login":"saurabh500","id":1623701,"avatar_url":"https://avatars3.githubusercontent.com/u/1623701?v=4","gravatar_id":"","url":"https://api.github.com/users/saurabh500","html_url":"https://github.com/saurabh500","followers_url":"https://api.github.com/users/saurabh500/followers","following_url":"https://api.github.com/users/saurabh500/following{/other_user}","gists_url":"https://api.github.com/users/saurabh500/gists{/gist_id}","starred_url":"https://api.github.com/users/saurabh500/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saurabh500/subscriptions","organizations_url":"https://api.github.com/users/saurabh500/orgs","repos_url":"https://api.github.com/users/saurabh500/repos","events_url":"https://api.github.com/users/saurabh500/events{/privacy}","received_events_url":"https://api.github.com/users/saurabh500/received_events","type":"User","site_admin":false},{"login":"corivera","id":12820011,"avatar_url":"https://avatars1.githubusercontent.com/u/12820011?v=4","gravatar_id":"","url":"https://api.github.com/users/corivera","html_url":"https://github.com/corivera","followers_url":"https://api.github.com/users/corivera/followers","following_url":"https://api.github.com/users/corivera/following{/other_user}","gists_url":"https://api.github.com/users/corivera/gists{/gist_id}","starred_url":"https://api.github.com/users/corivera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corivera/subscriptions","organizations_url":"https://api.github.com/users/corivera/orgs","repos_url":"https://api.github.com/users/corivera/repos","events_url":"https://api.github.com/users/corivera/events{/privacy}","received_events_url":"https://api.github.com/users/corivera/received_events","type":"User","site_admin":false},{"login":"geleems","id":19577035,"avatar_url":"https://avatars0.githubusercontent.com/u/19577035?v=4","gravatar_id":"","url":"https://api.github.com/users/geleems","html_url":"https://github.com/geleems","followers_url":"https://api.github.com/users/geleems/followers","following_url":"https://api.github.com/users/geleems/following{/other_user}","gists_url":"https://api.github.com/users/geleems/gists{/gist_id}","starred_url":"https://api.github.com/users/geleems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geleems/subscriptions","organizations_url":"https://api.github.com/users/geleems/orgs","repos_url":"https://api.github.com/users/geleems/repos","events_url":"https://api.github.com/users/geleems/events{/privacy}","received_events_url":"https://api.github.com/users/geleems/received_events","type":"User","site_admin":false},{"login":"AfsanehR","id":21184024,"avatar_url":"https://avatars0.githubusercontent.com/u/21184024?v=4","gravatar_id":"","url":"https://api.github.com/users/AfsanehR","html_url":"https://github.com/AfsanehR","followers_url":"https://api.github.com/users/AfsanehR/followers","following_url":"https://api.github.com/users/AfsanehR/following{/other_user}","gists_url":"https://api.github.com/users/AfsanehR/gists{/gist_id}","starred_url":"https://api.github.com/users/AfsanehR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AfsanehR/subscriptions","organizations_url":"https://api.github.com/users/AfsanehR/orgs","repos_url":"https://api.github.com/users/AfsanehR/repos","events_url":"https://api.github.com/users/AfsanehR/events{/privacy}","received_events_url":"https://api.github.com/users/AfsanehR/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/29879/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/29879/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/29879/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/51fedd274c4d8b1b206c6cc58775e499b10532a3","head":{"label":"keeratsingh:gh_15652_SqlFileStream","ref":"gh_15652_SqlFileStream","sha":"51fedd274c4d8b1b206c6cc58775e499b10532a3","user":{"login":"keeratsingh","id":2684055,"avatar_url":"https://avatars0.githubusercontent.com/u/2684055?v=4","gravatar_id":"","url":"https://api.github.com/users/keeratsingh","html_url":"https://github.com/keeratsingh","followers_url":"https://api.github.com/users/keeratsingh/followers","following_url":"https://api.github.com/users/keeratsingh/following{/other_user}","gists_url":"https://api.github.com/users/keeratsingh/gists{/gist_id}","starred_url":"https://api.github.com/users/keeratsingh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keeratsingh/subscriptions","organizations_url":"https://api.github.com/users/keeratsingh/orgs","repos_url":"https://api.github.com/users/keeratsingh/repos","events_url":"https://api.github.com/users/keeratsingh/events{/privacy}","received_events_url":"https://api.github.com/users/keeratsingh/received_events","type":"User","site_admin":false},"repo":{"id":119455270,"name":"corefx","full_name":"keeratsingh/corefx","owner":{"login":"keeratsingh","id":2684055,"avatar_url":"https://avatars0.githubusercontent.com/u/2684055?v=4","gravatar_id":"","url":"https://api.github.com/users/keeratsingh","html_url":"https://github.com/keeratsingh","followers_url":"https://api.github.com/users/keeratsingh/followers","following_url":"https://api.github.com/users/keeratsingh/following{/other_user}","gists_url":"https://api.github.com/users/keeratsingh/gists{/gist_id}","starred_url":"https://api.github.com/users/keeratsingh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keeratsingh/subscriptions","organizations_url":"https://api.github.com/users/keeratsingh/orgs","repos_url":"https://api.github.com/users/keeratsingh/repos","events_url":"https://api.github.com/users/keeratsingh/events{/privacy}","received_events_url":"https://api.github.com/users/keeratsingh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/keeratsingh/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others. We welcome contributions.","fork":true,"url":"https://api.github.com/repos/keeratsingh/corefx","forks_url":"https://api.github.com/repos/keeratsingh/corefx/forks","keys_url":"https://api.github.com/repos/keeratsingh/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keeratsingh/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keeratsingh/corefx/teams","hooks_url":"https://api.github.com/repos/keeratsingh/corefx/hooks","issue_events_url":"https://api.github.com/repos/keeratsingh/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/keeratsingh/corefx/events","assignees_url":"https://api.github.com/repos/keeratsingh/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/keeratsingh/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/keeratsingh/corefx/tags","blobs_url":"https://api.github.com/repos/keeratsingh/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keeratsingh/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keeratsingh/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/keeratsingh/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keeratsingh/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/keeratsingh/corefx/languages","stargazers_url":"https://api.github.com/repos/keeratsingh/corefx/stargazers","contributors_url":"https://api.github.com/repos/keeratsingh/corefx/contributors","subscribers_url":"https://api.github.com/repos/keeratsingh/corefx/subscribers","subscription_url":"https://api.github.com/repos/keeratsingh/corefx/subscription","commits_url":"https://api.github.com/repos/keeratsingh/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/keeratsingh/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/keeratsingh/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/keeratsingh/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/keeratsingh/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/keeratsingh/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keeratsingh/corefx/merges","archive_url":"https://api.github.com/repos/keeratsingh/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keeratsingh/corefx/downloads","issues_url":"https://api.github.com/repos/keeratsingh/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/keeratsingh/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/keeratsingh/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/keeratsingh/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keeratsingh/corefx/labels{/name}","releases_url":"https://api.github.com/repos/keeratsingh/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/keeratsingh/corefx/deployments","created_at":"2018-01-29T23:28:22Z","updated_at":"2018-05-23T23:14:52Z","pushed_at":"2018-05-23T23:14:44Z","git_url":"git://github.com/keeratsingh/corefx.git","ssh_url":"git@github.com:keeratsingh/corefx.git","clone_url":"https://github.com/keeratsingh/corefx.git","svn_url":"https://github.com/keeratsingh/corefx","homepage":"https://github.com/dotnet/core","size":178750,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"1f59cb91f9350732c747e6d60422c9c579e1dfed","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2018-05-24T14:39:31Z","pushed_at":"2018-05-24T19:35:04Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://github.com/dotnet/core","size":178669,"stargazers_count":14007,"watchers_count":14007,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4047,"mirror_url":null,"archived":false,"open_issues_count":2254,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":4047,"open_issues":2254,"watchers":14007,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/29879"},"html":{"href":"https://github.com/dotnet/corefx/pull/29879"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/29879"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/29879/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/29879/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/29879/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/51fedd274c4d8b1b206c6cc58775e499b10532a3"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"JeremyKuhne"}}