{"action":"created","comment":{"url":"https://api.github.com/repos/uc-cdis/fence/pulls/comments/202824197","pull_request_review_id":137596383,"id":202824197,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjgyNDE5Nw==","diff_hunk":"@@ -0,0 +1,45 @@\n+from fence.resources.google.access_utils import (\n+    is_valid_service_account_type,\n+)\n+from cirrus.google_cloud import (\n+    COMPUTE_ENGINE_DEFAULT_SERVICE_ACCOUNT,\n+    COMPUTE_ENGINE_API_SERVICE_ACCOUNT,\n+    GOOGLE_API_SERVICE_ACCOUNT,\n+    USER_MANAGED_SERVICE_ACCOUNT,\n+)\n+\n+\n+def test_is_valid_service_account_type_compute_engine_default(cloud_manager):\n+","path":"tests/google/test_access_utils.py","position":13,"original_position":13,"commit_id":"868ef20940b8c82c7aaa2685014da153d8878c0f","original_commit_id":"868ef20940b8c82c7aaa2685014da153d8878c0f","user":{"login":"Avantol13","id":9382451,"node_id":"MDQ6VXNlcjkzODI0NTE=","avatar_url":"https://avatars0.githubusercontent.com/u/9382451?v=4","gravatar_id":"","url":"https://api.github.com/users/Avantol13","html_url":"https://github.com/Avantol13","followers_url":"https://api.github.com/users/Avantol13/followers","following_url":"https://api.github.com/users/Avantol13/following{/other_user}","gists_url":"https://api.github.com/users/Avantol13/gists{/gist_id}","starred_url":"https://api.github.com/users/Avantol13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Avantol13/subscriptions","organizations_url":"https://api.github.com/users/Avantol13/orgs","repos_url":"https://api.github.com/users/Avantol13/repos","events_url":"https://api.github.com/users/Avantol13/events{/privacy}","received_events_url":"https://api.github.com/users/Avantol13/received_events","type":"User","site_admin":false},"body":"some quick docstrings here please. `\"\"\"Test that.. blah blah\"\"\"`","created_at":"2018-07-16T21:04:05Z","updated_at":"2018-07-16T21:04:12Z","html_url":"https://github.com/uc-cdis/fence/pull/311#discussion_r202824197","pull_request_url":"https://api.github.com/repos/uc-cdis/fence/pulls/311","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/uc-cdis/fence/pulls/comments/202824197"},"html":{"href":"https://github.com/uc-cdis/fence/pull/311#discussion_r202824197"},"pull_request":{"href":"https://api.github.com/repos/uc-cdis/fence/pulls/311"}}},"pull_request":{"url":"https://api.github.com/repos/uc-cdis/fence/pulls/311","id":201116509,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMTE2NTA5","html_url":"https://github.com/uc-cdis/fence/pull/311","diff_url":"https://github.com/uc-cdis/fence/pull/311.diff","patch_url":"https://github.com/uc-cdis/fence/pull/311.patch","issue_url":"https://api.github.com/repos/uc-cdis/fence/issues/311","number":311,"state":"open","locked":false,"title":"PXD-250 is_valid_service_account_type","user":{"login":"benJrohrer","id":10444310,"node_id":"MDQ6VXNlcjEwNDQ0MzEw","avatar_url":"https://avatars3.githubusercontent.com/u/10444310?v=4","gravatar_id":"","url":"https://api.github.com/users/benJrohrer","html_url":"https://github.com/benJrohrer","followers_url":"https://api.github.com/users/benJrohrer/followers","following_url":"https://api.github.com/users/benJrohrer/following{/other_user}","gists_url":"https://api.github.com/users/benJrohrer/gists{/gist_id}","starred_url":"https://api.github.com/users/benJrohrer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benJrohrer/subscriptions","organizations_url":"https://api.github.com/users/benJrohrer/orgs","repos_url":"https://api.github.com/users/benJrohrer/repos","events_url":"https://api.github.com/users/benJrohrer/events{/privacy}","received_events_url":"https://api.github.com/users/benJrohrer/received_events","type":"User","site_admin":false},"body":"*added access_utils.py\r\n*added is_valid_service_account_type","created_at":"2018-07-12T20:28:33Z","updated_at":"2018-07-16T21:04:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ca93547fe135e5ea59996843c9091db1df373e7b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/uc-cdis/fence/pulls/311/commits","review_comments_url":"https://api.github.com/repos/uc-cdis/fence/pulls/311/comments","review_comment_url":"https://api.github.com/repos/uc-cdis/fence/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uc-cdis/fence/issues/311/comments","statuses_url":"https://api.github.com/repos/uc-cdis/fence/statuses/868ef20940b8c82c7aaa2685014da153d8878c0f","head":{"label":"uc-cdis:feat/is-valid-service-account-type","ref":"feat/is-valid-service-account-type","sha":"868ef20940b8c82c7aaa2685014da153d8878c0f","user":{"login":"uc-cdis","id":15327655,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MzI3NjU1","avatar_url":"https://avatars0.githubusercontent.com/u/15327655?v=4","gravatar_id":"","url":"https://api.github.com/users/uc-cdis","html_url":"https://github.com/uc-cdis","followers_url":"https://api.github.com/users/uc-cdis/followers","following_url":"https://api.github.com/users/uc-cdis/following{/other_user}","gists_url":"https://api.github.com/users/uc-cdis/gists{/gist_id}","starred_url":"https://api.github.com/users/uc-cdis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uc-cdis/subscriptions","organizations_url":"https://api.github.com/users/uc-cdis/orgs","repos_url":"https://api.github.com/users/uc-cdis/repos","events_url":"https://api.github.com/users/uc-cdis/events{/privacy}","received_events_url":"https://api.github.com/users/uc-cdis/received_events","type":"Organization","site_admin":false},"repo":{"id":102788001,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI3ODgwMDE=","name":"fence","full_name":"uc-cdis/fence","owner":{"login":"uc-cdis","id":15327655,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MzI3NjU1","avatar_url":"https://avatars0.githubusercontent.com/u/15327655?v=4","gravatar_id":"","url":"https://api.github.com/users/uc-cdis","html_url":"https://github.com/uc-cdis","followers_url":"https://api.github.com/users/uc-cdis/followers","following_url":"https://api.github.com/users/uc-cdis/following{/other_user}","gists_url":"https://api.github.com/users/uc-cdis/gists{/gist_id}","starred_url":"https://api.github.com/users/uc-cdis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uc-cdis/subscriptions","organizations_url":"https://api.github.com/users/uc-cdis/orgs","repos_url":"https://api.github.com/users/uc-cdis/repos","events_url":"https://api.github.com/users/uc-cdis/events{/privacy}","received_events_url":"https://api.github.com/users/uc-cdis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uc-cdis/fence","description":"AuthN/AuthZ OIDC Service","fork":false,"url":"https://api.github.com/repos/uc-cdis/fence","forks_url":"https://api.github.com/repos/uc-cdis/fence/forks","keys_url":"https://api.github.com/repos/uc-cdis/fence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uc-cdis/fence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uc-cdis/fence/teams","hooks_url":"https://api.github.com/repos/uc-cdis/fence/hooks","issue_events_url":"https://api.github.com/repos/uc-cdis/fence/issues/events{/number}","events_url":"https://api.github.com/repos/uc-cdis/fence/events","assignees_url":"https://api.github.com/repos/uc-cdis/fence/assignees{/user}","branches_url":"https://api.github.com/repos/uc-cdis/fence/branches{/branch}","tags_url":"https://api.github.com/repos/uc-cdis/fence/tags","blobs_url":"https://api.github.com/repos/uc-cdis/fence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uc-cdis/fence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uc-cdis/fence/git/refs{/sha}","trees_url":"https://api.github.com/repos/uc-cdis/fence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uc-cdis/fence/statuses/{sha}","languages_url":"https://api.github.com/repos/uc-cdis/fence/languages","stargazers_url":"https://api.github.com/repos/uc-cdis/fence/stargazers","contributors_url":"https://api.github.com/repos/uc-cdis/fence/contributors","subscribers_url":"https://api.github.com/repos/uc-cdis/fence/subscribers","subscription_url":"https://api.github.com/repos/uc-cdis/fence/subscription","commits_url":"https://api.github.com/repos/uc-cdis/fence/commits{/sha}","git_commits_url":"https://api.github.com/repos/uc-cdis/fence/git/commits{/sha}","comments_url":"https://api.github.com/repos/uc-cdis/fence/comments{/number}","issue_comment_url":"https://api.github.com/repos/uc-cdis/fence/issues/comments{/number}","contents_url":"https://api.github.com/repos/uc-cdis/fence/contents/{+path}","compare_url":"https://api.github.com/repos/uc-cdis/fence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uc-cdis/fence/merges","archive_url":"https://api.github.com/repos/uc-cdis/fence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uc-cdis/fence/downloads","issues_url":"https://api.github.com/repos/uc-cdis/fence/issues{/number}","pulls_url":"https://api.github.com/repos/uc-cdis/fence/pulls{/number}","milestones_url":"https://api.github.com/repos/uc-cdis/fence/milestones{/number}","notifications_url":"https://api.github.com/repos/uc-cdis/fence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uc-cdis/fence/labels{/name}","releases_url":"https://api.github.com/repos/uc-cdis/fence/releases{/id}","deployments_url":"https://api.github.com/repos/uc-cdis/fence/deployments","created_at":"2017-09-07T21:36:42Z","updated_at":"2018-07-16T20:04:02Z","pushed_at":"2018-07-16T20:39:02Z","git_url":"git://github.com/uc-cdis/fence.git","ssh_url":"git@github.com:uc-cdis/fence.git","clone_url":"https://github.com/uc-cdis/fence.git","svn_url":"https://github.com/uc-cdis/fence","homepage":"","size":1946,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":62,"license":null,"forks":1,"open_issues":62,"watchers":1,"default_branch":"master"}},"base":{"label":"uc-cdis:master","ref":"master","sha":"655b7381d8170c6b4758687e800a0fb8c62f687a","user":{"login":"uc-cdis","id":15327655,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MzI3NjU1","avatar_url":"https://avatars0.githubusercontent.com/u/15327655?v=4","gravatar_id":"","url":"https://api.github.com/users/uc-cdis","html_url":"https://github.com/uc-cdis","followers_url":"https://api.github.com/users/uc-cdis/followers","following_url":"https://api.github.com/users/uc-cdis/following{/other_user}","gists_url":"https://api.github.com/users/uc-cdis/gists{/gist_id}","starred_url":"https://api.github.com/users/uc-cdis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uc-cdis/subscriptions","organizations_url":"https://api.github.com/users/uc-cdis/orgs","repos_url":"https://api.github.com/users/uc-cdis/repos","events_url":"https://api.github.com/users/uc-cdis/events{/privacy}","received_events_url":"https://api.github.com/users/uc-cdis/received_events","type":"Organization","site_admin":false},"repo":{"id":102788001,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI3ODgwMDE=","name":"fence","full_name":"uc-cdis/fence","owner":{"login":"uc-cdis","id":15327655,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MzI3NjU1","avatar_url":"https://avatars0.githubusercontent.com/u/15327655?v=4","gravatar_id":"","url":"https://api.github.com/users/uc-cdis","html_url":"https://github.com/uc-cdis","followers_url":"https://api.github.com/users/uc-cdis/followers","following_url":"https://api.github.com/users/uc-cdis/following{/other_user}","gists_url":"https://api.github.com/users/uc-cdis/gists{/gist_id}","starred_url":"https://api.github.com/users/uc-cdis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uc-cdis/subscriptions","organizations_url":"https://api.github.com/users/uc-cdis/orgs","repos_url":"https://api.github.com/users/uc-cdis/repos","events_url":"https://api.github.com/users/uc-cdis/events{/privacy}","received_events_url":"https://api.github.com/users/uc-cdis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uc-cdis/fence","description":"AuthN/AuthZ OIDC Service","fork":false,"url":"https://api.github.com/repos/uc-cdis/fence","forks_url":"https://api.github.com/repos/uc-cdis/fence/forks","keys_url":"https://api.github.com/repos/uc-cdis/fence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uc-cdis/fence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uc-cdis/fence/teams","hooks_url":"https://api.github.com/repos/uc-cdis/fence/hooks","issue_events_url":"https://api.github.com/repos/uc-cdis/fence/issues/events{/number}","events_url":"https://api.github.com/repos/uc-cdis/fence/events","assignees_url":"https://api.github.com/repos/uc-cdis/fence/assignees{/user}","branches_url":"https://api.github.com/repos/uc-cdis/fence/branches{/branch}","tags_url":"https://api.github.com/repos/uc-cdis/fence/tags","blobs_url":"https://api.github.com/repos/uc-cdis/fence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uc-cdis/fence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uc-cdis/fence/git/refs{/sha}","trees_url":"https://api.github.com/repos/uc-cdis/fence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uc-cdis/fence/statuses/{sha}","languages_url":"https://api.github.com/repos/uc-cdis/fence/languages","stargazers_url":"https://api.github.com/repos/uc-cdis/fence/stargazers","contributors_url":"https://api.github.com/repos/uc-cdis/fence/contributors","subscribers_url":"https://api.github.com/repos/uc-cdis/fence/subscribers","subscription_url":"https://api.github.com/repos/uc-cdis/fence/subscription","commits_url":"https://api.github.com/repos/uc-cdis/fence/commits{/sha}","git_commits_url":"https://api.github.com/repos/uc-cdis/fence/git/commits{/sha}","comments_url":"https://api.github.com/repos/uc-cdis/fence/comments{/number}","issue_comment_url":"https://api.github.com/repos/uc-cdis/fence/issues/comments{/number}","contents_url":"https://api.github.com/repos/uc-cdis/fence/contents/{+path}","compare_url":"https://api.github.com/repos/uc-cdis/fence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uc-cdis/fence/merges","archive_url":"https://api.github.com/repos/uc-cdis/fence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uc-cdis/fence/downloads","issues_url":"https://api.github.com/repos/uc-cdis/fence/issues{/number}","pulls_url":"https://api.github.com/repos/uc-cdis/fence/pulls{/number}","milestones_url":"https://api.github.com/repos/uc-cdis/fence/milestones{/number}","notifications_url":"https://api.github.com/repos/uc-cdis/fence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uc-cdis/fence/labels{/name}","releases_url":"https://api.github.com/repos/uc-cdis/fence/releases{/id}","deployments_url":"https://api.github.com/repos/uc-cdis/fence/deployments","created_at":"2017-09-07T21:36:42Z","updated_at":"2018-07-16T20:04:02Z","pushed_at":"2018-07-16T20:39:02Z","git_url":"git://github.com/uc-cdis/fence.git","ssh_url":"git@github.com:uc-cdis/fence.git","clone_url":"https://github.com/uc-cdis/fence.git","svn_url":"https://github.com/uc-cdis/fence","homepage":"","size":1946,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":62,"license":null,"forks":1,"open_issues":62,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uc-cdis/fence/pulls/311"},"html":{"href":"https://github.com/uc-cdis/fence/pull/311"},"issue":{"href":"https://api.github.com/repos/uc-cdis/fence/issues/311"},"comments":{"href":"https://api.github.com/repos/uc-cdis/fence/issues/311/comments"},"review_comments":{"href":"https://api.github.com/repos/uc-cdis/fence/pulls/311/comments"},"review_comment":{"href":"https://api.github.com/repos/uc-cdis/fence/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uc-cdis/fence/pulls/311/commits"},"statuses":{"href":"https://api.github.com/repos/uc-cdis/fence/statuses/868ef20940b8c82c7aaa2685014da153d8878c0f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Avantol13"}}