{"action":"created","comment":{"url":"https://api.github.com/repos/hyperledger/iroha/pulls/comments/240948362","pull_request_review_id":184087181,"id":240948362,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDk0ODM2Mg==","diff_hunk":"@@ -128,21 +107,49 @@ namespace iroha {\n          */\n         void nextProcessingState(const Round &round);\n \n+        /// Get the highest commit, if any, otherwise boost::none.\n+        boost::optional<CommitMessage> getLastCommit() const;\n+\n+        /// Get the outcome of given round, if any, otherwise boost::none.\n+        boost::optional<Answer> getRoundOutcome(const Round &round) const;","path":"irohad/consensus/yac/storage/yac_vote_storage.hpp","position":46,"original_position":46,"commit_id":"c01cada0fa2792fdf155c82518515109b5ac6cde","original_commit_id":"c01cada0fa2792fdf155c82518515109b5ac6cde","user":{"login":"muratovv","id":7502801,"node_id":"MDQ6VXNlcjc1MDI4MDE=","avatar_url":"https://avatars2.githubusercontent.com/u/7502801?v=4","gravatar_id":"","url":"https://api.github.com/users/muratovv","html_url":"https://github.com/muratovv","followers_url":"https://api.github.com/users/muratovv/followers","following_url":"https://api.github.com/users/muratovv/following{/other_user}","gists_url":"https://api.github.com/users/muratovv/gists{/gist_id}","starred_url":"https://api.github.com/users/muratovv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muratovv/subscriptions","organizations_url":"https://api.github.com/users/muratovv/orgs","repos_url":"https://api.github.com/users/muratovv/repos","events_url":"https://api.github.com/users/muratovv/events{/privacy}","received_events_url":"https://api.github.com/users/muratovv/received_events","type":"User","site_admin":false},"body":"Seems that this method should be private, isn't it?","created_at":"2018-12-12T10:01:03Z","updated_at":"2018-12-12T10:01:21Z","html_url":"https://github.com/hyperledger/iroha/pull/1931#discussion_r240948362","pull_request_url":"https://api.github.com/repos/hyperledger/iroha/pulls/1931","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/comments/240948362"},"html":{"href":"https://github.com/hyperledger/iroha/pull/1931#discussion_r240948362"},"pull_request":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/1931"}}},"pull_request":{"url":"https://api.github.com/repos/hyperledger/iroha/pulls/1931","id":237358291,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MzU4Mjkx","html_url":"https://github.com/hyperledger/iroha/pull/1931","diff_url":"https://github.com/hyperledger/iroha/pull/1931.diff","patch_url":"https://github.com/hyperledger/iroha/pull/1931.patch","issue_url":"https://api.github.com/repos/hyperledger/iroha/issues/1931","number":1931,"state":"open","locked":false,"title":"YAC shares last outcome with laggy peer","user":{"login":"MBoldyrev","id":11086641,"node_id":"MDQ6VXNlcjExMDg2NjQx","avatar_url":"https://avatars0.githubusercontent.com/u/11086641?v=4","gravatar_id":"","url":"https://api.github.com/users/MBoldyrev","html_url":"https://github.com/MBoldyrev","followers_url":"https://api.github.com/users/MBoldyrev/followers","following_url":"https://api.github.com/users/MBoldyrev/following{/other_user}","gists_url":"https://api.github.com/users/MBoldyrev/gists{/gist_id}","starred_url":"https://api.github.com/users/MBoldyrev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MBoldyrev/subscriptions","organizations_url":"https://api.github.com/users/MBoldyrev/orgs","repos_url":"https://api.github.com/users/MBoldyrev/repos","events_url":"https://api.github.com/users/MBoldyrev/events{/privacy}","received_events_url":"https://api.github.com/users/MBoldyrev/received_events","type":"User","site_admin":false},"body":"[IR-95](https://jira.hyperledger.org/browse/IR-95)\r\n\r\n### Description of the Change\r\n\r\nBefore this change, if peer A sends vote with round {3, 0} to peer B while is is in round {5,2}, then peer B sends back the outcome for round {3, 0}. After this change the peer B will send the outcome for {5,2}.\r\n\r\n### Benefits\r\n\r\nCorrect behaviour. Faster synchronization.","created_at":"2018-12-10T15:21:17Z","updated_at":"2018-12-12T10:01:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"097d4b3b8e54a66eb16cf6430f71248bb265407c","assignee":{"login":"MBoldyrev","id":11086641,"node_id":"MDQ6VXNlcjExMDg2NjQx","avatar_url":"https://avatars0.githubusercontent.com/u/11086641?v=4","gravatar_id":"","url":"https://api.github.com/users/MBoldyrev","html_url":"https://github.com/MBoldyrev","followers_url":"https://api.github.com/users/MBoldyrev/followers","following_url":"https://api.github.com/users/MBoldyrev/following{/other_user}","gists_url":"https://api.github.com/users/MBoldyrev/gists{/gist_id}","starred_url":"https://api.github.com/users/MBoldyrev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MBoldyrev/subscriptions","organizations_url":"https://api.github.com/users/MBoldyrev/orgs","repos_url":"https://api.github.com/users/MBoldyrev/repos","events_url":"https://api.github.com/users/MBoldyrev/events{/privacy}","received_events_url":"https://api.github.com/users/MBoldyrev/received_events","type":"User","site_admin":false},"assignees":[{"login":"MBoldyrev","id":11086641,"node_id":"MDQ6VXNlcjExMDg2NjQx","avatar_url":"https://avatars0.githubusercontent.com/u/11086641?v=4","gravatar_id":"","url":"https://api.github.com/users/MBoldyrev","html_url":"https://github.com/MBoldyrev","followers_url":"https://api.github.com/users/MBoldyrev/followers","following_url":"https://api.github.com/users/MBoldyrev/following{/other_user}","gists_url":"https://api.github.com/users/MBoldyrev/gists{/gist_id}","starred_url":"https://api.github.com/users/MBoldyrev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MBoldyrev/subscriptions","organizations_url":"https://api.github.com/users/MBoldyrev/orgs","repos_url":"https://api.github.com/users/MBoldyrev/repos","events_url":"https://api.github.com/users/MBoldyrev/events{/privacy}","received_events_url":"https://api.github.com/users/MBoldyrev/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1067317765,"node_id":"MDU6TGFiZWwxMDY3MzE3NzY1","url":"https://api.github.com/repos/hyperledger/iroha/labels/consensus","name":"consensus","color":"1d76db","default":false},{"id":684699993,"node_id":"MDU6TGFiZWw2ODQ2OTk5OTM=","url":"https://api.github.com/repos/hyperledger/iroha/labels/needs-review","name":"needs-review","color":"f9d0c4","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/hyperledger/iroha/pulls/1931/commits","review_comments_url":"https://api.github.com/repos/hyperledger/iroha/pulls/1931/comments","review_comment_url":"https://api.github.com/repos/hyperledger/iroha/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperledger/iroha/issues/1931/comments","statuses_url":"https://api.github.com/repos/hyperledger/iroha/statuses/c01cada0fa2792fdf155c82518515109b5ac6cde","head":{"label":"hyperledger:feature/yac-shares-last-outcome","ref":"feature/yac-shares-last-outcome","sha":"c01cada0fa2792fdf155c82518515109b5ac6cde","user":{"login":"hyperledger","id":7657900,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2NTc5MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"repo":{"id":67340575,"node_id":"MDEwOlJlcG9zaXRvcnk2NzM0MDU3NQ==","name":"iroha","full_name":"hyperledger/iroha","private":false,"owner":{"login":"hyperledger","id":7657900,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2NTc5MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hyperledger/iroha","description":"Iroha - A simple, decentralized ledger","fork":false,"url":"https://api.github.com/repos/hyperledger/iroha","forks_url":"https://api.github.com/repos/hyperledger/iroha/forks","keys_url":"https://api.github.com/repos/hyperledger/iroha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperledger/iroha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperledger/iroha/teams","hooks_url":"https://api.github.com/repos/hyperledger/iroha/hooks","issue_events_url":"https://api.github.com/repos/hyperledger/iroha/issues/events{/number}","events_url":"https://api.github.com/repos/hyperledger/iroha/events","assignees_url":"https://api.github.com/repos/hyperledger/iroha/assignees{/user}","branches_url":"https://api.github.com/repos/hyperledger/iroha/branches{/branch}","tags_url":"https://api.github.com/repos/hyperledger/iroha/tags","blobs_url":"https://api.github.com/repos/hyperledger/iroha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperledger/iroha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperledger/iroha/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperledger/iroha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperledger/iroha/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperledger/iroha/languages","stargazers_url":"https://api.github.com/repos/hyperledger/iroha/stargazers","contributors_url":"https://api.github.com/repos/hyperledger/iroha/contributors","subscribers_url":"https://api.github.com/repos/hyperledger/iroha/subscribers","subscription_url":"https://api.github.com/repos/hyperledger/iroha/subscription","commits_url":"https://api.github.com/repos/hyperledger/iroha/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperledger/iroha/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperledger/iroha/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperledger/iroha/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperledger/iroha/contents/{+path}","compare_url":"https://api.github.com/repos/hyperledger/iroha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperledger/iroha/merges","archive_url":"https://api.github.com/repos/hyperledger/iroha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperledger/iroha/downloads","issues_url":"https://api.github.com/repos/hyperledger/iroha/issues{/number}","pulls_url":"https://api.github.com/repos/hyperledger/iroha/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperledger/iroha/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperledger/iroha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperledger/iroha/labels{/name}","releases_url":"https://api.github.com/repos/hyperledger/iroha/releases{/id}","deployments_url":"https://api.github.com/repos/hyperledger/iroha/deployments","created_at":"2016-09-04T11:17:53Z","updated_at":"2018-12-11T12:25:37Z","pushed_at":"2018-12-12T09:40:12Z","git_url":"git://github.com/hyperledger/iroha.git","ssh_url":"git@github.com:hyperledger/iroha.git","clone_url":"https://github.com/hyperledger/iroha.git","svn_url":"https://github.com/hyperledger/iroha","homepage":"http://iroha.tech","size":52376,"stargazers_count":980,"watchers_count":980,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":307,"mirror_url":null,"archived":false,"open_issues_count":64,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":307,"open_issues":64,"watchers":980,"default_branch":"master"}},"base":{"label":"hyperledger:dev","ref":"dev","sha":"74296b7e7f6580bf4ab8ad85f9cfea650d5658c2","user":{"login":"hyperledger","id":7657900,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2NTc5MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"repo":{"id":67340575,"node_id":"MDEwOlJlcG9zaXRvcnk2NzM0MDU3NQ==","name":"iroha","full_name":"hyperledger/iroha","private":false,"owner":{"login":"hyperledger","id":7657900,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2NTc5MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hyperledger/iroha","description":"Iroha - A simple, decentralized ledger","fork":false,"url":"https://api.github.com/repos/hyperledger/iroha","forks_url":"https://api.github.com/repos/hyperledger/iroha/forks","keys_url":"https://api.github.com/repos/hyperledger/iroha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperledger/iroha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperledger/iroha/teams","hooks_url":"https://api.github.com/repos/hyperledger/iroha/hooks","issue_events_url":"https://api.github.com/repos/hyperledger/iroha/issues/events{/number}","events_url":"https://api.github.com/repos/hyperledger/iroha/events","assignees_url":"https://api.github.com/repos/hyperledger/iroha/assignees{/user}","branches_url":"https://api.github.com/repos/hyperledger/iroha/branches{/branch}","tags_url":"https://api.github.com/repos/hyperledger/iroha/tags","blobs_url":"https://api.github.com/repos/hyperledger/iroha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperledger/iroha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperledger/iroha/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperledger/iroha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperledger/iroha/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperledger/iroha/languages","stargazers_url":"https://api.github.com/repos/hyperledger/iroha/stargazers","contributors_url":"https://api.github.com/repos/hyperledger/iroha/contributors","subscribers_url":"https://api.github.com/repos/hyperledger/iroha/subscribers","subscription_url":"https://api.github.com/repos/hyperledger/iroha/subscription","commits_url":"https://api.github.com/repos/hyperledger/iroha/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperledger/iroha/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperledger/iroha/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperledger/iroha/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperledger/iroha/contents/{+path}","compare_url":"https://api.github.com/repos/hyperledger/iroha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperledger/iroha/merges","archive_url":"https://api.github.com/repos/hyperledger/iroha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperledger/iroha/downloads","issues_url":"https://api.github.com/repos/hyperledger/iroha/issues{/number}","pulls_url":"https://api.github.com/repos/hyperledger/iroha/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperledger/iroha/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperledger/iroha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperledger/iroha/labels{/name}","releases_url":"https://api.github.com/repos/hyperledger/iroha/releases{/id}","deployments_url":"https://api.github.com/repos/hyperledger/iroha/deployments","created_at":"2016-09-04T11:17:53Z","updated_at":"2018-12-11T12:25:37Z","pushed_at":"2018-12-12T09:40:12Z","git_url":"git://github.com/hyperledger/iroha.git","ssh_url":"git@github.com:hyperledger/iroha.git","clone_url":"https://github.com/hyperledger/iroha.git","svn_url":"https://github.com/hyperledger/iroha","homepage":"http://iroha.tech","size":52376,"stargazers_count":980,"watchers_count":980,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":307,"mirror_url":null,"archived":false,"open_issues_count":64,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":307,"open_issues":64,"watchers":980,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/1931"},"html":{"href":"https://github.com/hyperledger/iroha/pull/1931"},"issue":{"href":"https://api.github.com/repos/hyperledger/iroha/issues/1931"},"comments":{"href":"https://api.github.com/repos/hyperledger/iroha/issues/1931/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/1931/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/1931/commits"},"statuses":{"href":"https://api.github.com/repos/hyperledger/iroha/statuses/c01cada0fa2792fdf155c82518515109b5ac6cde"}},"author_association":"NONE"}}
{"actor":{"display_login":"muratovv"}}