{"action":"created","issue":{"url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/issues/2280","repository_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline","labels_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/issues/2280/labels{/name}","comments_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/issues/2280/comments","events_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/issues/2280/events","html_url":"https://github.com/Unity-Technologies/ScriptableRenderPipeline/pull/2280","id":374035967,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1ODI5MjIz","number":2280,"title":"Screen space refraction settings cleanup and share fade function with SSR","user":{"login":"FrancescoC-unity","id":43168857,"node_id":"MDQ6VXNlcjQzMTY4ODU3","avatar_url":"https://avatars3.githubusercontent.com/u/43168857?v=4","gravatar_id":"","url":"https://api.github.com/users/FrancescoC-unity","html_url":"https://github.com/FrancescoC-unity","followers_url":"https://api.github.com/users/FrancescoC-unity/followers","following_url":"https://api.github.com/users/FrancescoC-unity/following{/other_user}","gists_url":"https://api.github.com/users/FrancescoC-unity/gists{/gist_id}","starred_url":"https://api.github.com/users/FrancescoC-unity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FrancescoC-unity/subscriptions","organizations_url":"https://api.github.com/users/FrancescoC-unity/orgs","repos_url":"https://api.github.com/users/FrancescoC-unity/repos","events_url":"https://api.github.com/users/FrancescoC-unity/events{/privacy}","received_events_url":"https://api.github.com/users/FrancescoC-unity/received_events","type":"User","site_admin":false},"labels":[{"id":862572140,"node_id":"MDU6TGFiZWw4NjI1NzIxNDA=","url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/labels/HDRP","name":"HDRP","color":"dd75a6","default":false}],"state":"open","locked":false,"assignee":{"login":"FrancescoC-unity","id":43168857,"node_id":"MDQ6VXNlcjQzMTY4ODU3","avatar_url":"https://avatars3.githubusercontent.com/u/43168857?v=4","gravatar_id":"","url":"https://api.github.com/users/FrancescoC-unity","html_url":"https://github.com/FrancescoC-unity","followers_url":"https://api.github.com/users/FrancescoC-unity/followers","following_url":"https://api.github.com/users/FrancescoC-unity/following{/other_user}","gists_url":"https://api.github.com/users/FrancescoC-unity/gists{/gist_id}","starred_url":"https://api.github.com/users/FrancescoC-unity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FrancescoC-unity/subscriptions","organizations_url":"https://api.github.com/users/FrancescoC-unity/orgs","repos_url":"https://api.github.com/users/FrancescoC-unity/repos","events_url":"https://api.github.com/users/FrancescoC-unity/events{/privacy}","received_events_url":"https://api.github.com/users/FrancescoC-unity/received_events","type":"User","site_admin":false},"assignees":[{"login":"FrancescoC-unity","id":43168857,"node_id":"MDQ6VXNlcjQzMTY4ODU3","avatar_url":"https://avatars3.githubusercontent.com/u/43168857?v=4","gravatar_id":"","url":"https://api.github.com/users/FrancescoC-unity","html_url":"https://github.com/FrancescoC-unity","followers_url":"https://api.github.com/users/FrancescoC-unity/followers","following_url":"https://api.github.com/users/FrancescoC-unity/following{/other_user}","gists_url":"https://api.github.com/users/FrancescoC-unity/gists{/gist_id}","starred_url":"https://api.github.com/users/FrancescoC-unity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FrancescoC-unity/subscriptions","organizations_url":"https://api.github.com/users/FrancescoC-unity/orgs","repos_url":"https://api.github.com/users/FrancescoC-unity/repos","events_url":"https://api.github.com/users/FrancescoC-unity/events{/privacy}","received_events_url":"https://api.github.com/users/FrancescoC-unity/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-10-25T16:41:23Z","updated_at":"2018-10-26T12:15:27Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/pulls/2280","html_url":"https://github.com/Unity-Technologies/ScriptableRenderPipeline/pull/2280","diff_url":"https://github.com/Unity-Technologies/ScriptableRenderPipeline/pull/2280.diff","patch_url":"https://github.com/Unity-Technologies/ScriptableRenderPipeline/pull/2280.patch"},"body":"### Purpose of this PR\r\n\r\nThis PR has few of changes in: \r\n\r\n- Cleaning up screen space refraction settings (removing old HiZ stuff) \r\n- Decoupling SSR and Screen Space Refraction settings (getting rid of ScreenSpaceLighting settings).\r\n- Renaming the \"Plane\" Refraction model to \"Box\" as it is more intuitive. \r\n- Sharing of Fade function between SSR and Screen Space Refraction. \r\n\r\n---\r\n### Release Notes\r\n\r\nRemove unused refraction settings and use same fade function for refraction and reflection. \r\n\r\n---\r\n### Testing status\r\n**Katana Tests**:  https://katana.bf.unity3d.com/projects/com.unity.render-pipelines/builders?ScriptableRenderLoop_branch=refraction-cleanup-and-fade-sharing-with-ssr&automation-tools_branch=add-platform-filter&unity_branch=2018.3%2Fstaging [Just kicked off] \r\n\r\n---\r\n### Overall Product Risks\r\n**Technical Risk**:  Low\r\n\r\n**Halo Effect**: Low\r\n"},"comment":{"url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/issues/comments/433387846","html_url":"https://github.com/Unity-Technologies/ScriptableRenderPipeline/pull/2280#issuecomment-433387846","issue_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/issues/2280","id":433387846,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzM4Nzg0Ng==","user":{"login":"EvgeniiG","id":23363056,"node_id":"MDQ6VXNlcjIzMzYzMDU2","avatar_url":"https://avatars3.githubusercontent.com/u/23363056?v=4","gravatar_id":"","url":"https://api.github.com/users/EvgeniiG","html_url":"https://github.com/EvgeniiG","followers_url":"https://api.github.com/users/EvgeniiG/followers","following_url":"https://api.github.com/users/EvgeniiG/following{/other_user}","gists_url":"https://api.github.com/users/EvgeniiG/gists{/gist_id}","starred_url":"https://api.github.com/users/EvgeniiG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EvgeniiG/subscriptions","organizations_url":"https://api.github.com/users/EvgeniiG/orgs","repos_url":"https://api.github.com/users/EvgeniiG/repos","events_url":"https://api.github.com/users/EvgeniiG/events{/privacy}","received_events_url":"https://api.github.com/users/EvgeniiG/received_events","type":"User","site_admin":false},"created_at":"2018-10-26T12:15:27Z","updated_at":"2018-10-26T12:15:27Z","author_association":"CONTRIBUTOR","body":"Maybe ScreenSpaceLighting.hlsl."}}
{"actor":{"display_login":"EvgeniiG"}}