{"action":"created","issue":{"url":"https://api.github.com/repos/grafana/grafana/issues/10948","repository_url":"https://api.github.com/repos/grafana/grafana","labels_url":"https://api.github.com/repos/grafana/grafana/issues/10948/labels{/name}","comments_url":"https://api.github.com/repos/grafana/grafana/issues/10948/comments","events_url":"https://api.github.com/repos/grafana/grafana/issues/10948/events","html_url":"https://github.com/grafana/grafana/pull/10948","id":297872536,"number":10948,"title":"migrate panels in collapsed rows","user":{"login":"mtanda","id":224552,"avatar_url":"https://avatars2.githubusercontent.com/u/224552?v=4","gravatar_id":"","url":"https://api.github.com/users/mtanda","html_url":"https://github.com/mtanda","followers_url":"https://api.github.com/users/mtanda/followers","following_url":"https://api.github.com/users/mtanda/following{/other_user}","gists_url":"https://api.github.com/users/mtanda/gists{/gist_id}","starred_url":"https://api.github.com/users/mtanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtanda/subscriptions","organizations_url":"https://api.github.com/users/mtanda/orgs","repos_url":"https://api.github.com/users/mtanda/repos","events_url":"https://api.github.com/users/mtanda/events{/privacy}","received_events_url":"https://api.github.com/users/mtanda/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-16T18:05:28Z","updated_at":"2018-02-16T18:12:42Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/grafana/grafana/pulls/10948","html_url":"https://github.com/grafana/grafana/pull/10948","diff_url":"https://github.com/grafana/grafana/pull/10948.diff","patch_url":"https://github.com/grafana/grafana/pull/10948.patch"},"body":"I notice that pretty old scripted dashboard cause error in Grafana 5.x.\r\nWhen I open a collapsed row, dashboard cause this error.\r\n![image](https://user-images.githubusercontent.com/224552/36321880-b18f7842-138e-11e8-82a5-19a78a763c58.png)\r\n\r\nAfter debugging, I found that the panel doesn't have `id`, and cause an error in this line.\r\nhttps://github.com/grafana/grafana/blob/v5.0.0-beta3/public/app/features/dashboard/dashgrid/DashboardGrid.tsx#L97\r\n\r\nI guess the root cause is, migration code doesn't care about panels in collapsed rows.\r\n\r\n@torkelo How do you think this fix.\r\n"},"comment":{"url":"https://api.github.com/repos/grafana/grafana/issues/comments/366314573","html_url":"https://github.com/grafana/grafana/pull/10948#issuecomment-366314573","issue_url":"https://api.github.com/repos/grafana/grafana/issues/10948","id":366314573,"user":{"login":"mtanda","id":224552,"avatar_url":"https://avatars2.githubusercontent.com/u/224552?v=4","gravatar_id":"","url":"https://api.github.com/users/mtanda","html_url":"https://github.com/mtanda","followers_url":"https://api.github.com/users/mtanda/followers","following_url":"https://api.github.com/users/mtanda/following{/other_user}","gists_url":"https://api.github.com/users/mtanda/gists{/gist_id}","starred_url":"https://api.github.com/users/mtanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtanda/subscriptions","organizations_url":"https://api.github.com/users/mtanda/orgs","repos_url":"https://api.github.com/users/mtanda/repos","events_url":"https://api.github.com/users/mtanda/events{/privacy}","received_events_url":"https://api.github.com/users/mtanda/received_events","type":"User","site_admin":false},"created_at":"2018-02-16T18:12:42Z","updated_at":"2018-02-16T18:12:42Z","author_association":"CONTRIBUTOR","body":"You can replicate the error by this dashboard.\r\n```diff\r\ndiff --git a/public/dashboards/scripted.js b/public/dashboards/scripted.js\r\nindex d78e2a688..1acf653a4 100644\r\n--- a/public/dashboards/scripted.js\r\n+++ b/public/dashboards/scripted.js\r\n@@ -53,6 +53,7 @@ for (var i = 0; i < rows; i++) {\r\n\r\n   dashboard.rows.push({\r\n     title: 'Chart',\r\n+    collapse: true,\r\n     height: '300px',\r\n     panels: [\r\n       {\r\n```"}}
{"actor":{"display_login":"mtanda"}}