{"action":"created","comment":{"url":"https://api.github.com/repos/pantheon-systems/solr-power/pulls/comments/197593471","pull_request_review_id":131375015,"id":197593471,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzU5MzQ3MQ==","diff_hunk":"@@ -195,12 +195,14 @@ public function test_wp_query_by_post__in() {\n \n \tpublic function test_wp_query_by_post__not_in_arr() {\n \t\t$post_id = $this->__create_test_post();\n+\t\t$post_id2 = $this->__create_test_post();\n \t\tSolrPower_Sync::get_instance()->load_all_posts( 0, 'post', 100, false );\n \t\t$args  = array(\n \t\t\t'solr_integrate' => true,\n \t\t\t'post__not_in'   => array( $post_id ),\n \t\t);\n \t\t$query = new WP_Query( $args );\n-\t\t$this->assertEquals( 0, $query->post_count );\n+\t\t$this->assertEquals( 1, $query->post_count );\n+\t\t$this->assertEquals( $post_id2, $query->post->ID );\n \t}","path":"tests/phpunit/wp_query/test-wp-query.php","position":null,"original_position":14,"commit_id":"24c9c16914ce2cc8e3b519ef09d8f57b63cb95f8","original_commit_id":"24c9c16914ce2cc8e3b519ef09d8f57b63cb95f8","user":{"login":"ghamok","id":40301523,"node_id":"MDQ6VXNlcjQwMzAxNTIz","avatar_url":"https://avatars2.githubusercontent.com/u/40301523?v=4","gravatar_id":"","url":"https://api.github.com/users/ghamok","html_url":"https://github.com/ghamok","followers_url":"https://api.github.com/users/ghamok/followers","following_url":"https://api.github.com/users/ghamok/following{/other_user}","gists_url":"https://api.github.com/users/ghamok/gists{/gist_id}","starred_url":"https://api.github.com/users/ghamok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghamok/subscriptions","organizations_url":"https://api.github.com/users/ghamok/orgs","repos_url":"https://api.github.com/users/ghamok/repos","events_url":"https://api.github.com/users/ghamok/events{/privacy}","received_events_url":"https://api.github.com/users/ghamok/received_events","type":"User","site_admin":false},"body":"`post__not_in` test currently fails where the `post_count` is zero instead of one. Currently trying to find out why, but my main concern is that a result of zero usually only occurred on my own solr instance (not this project's testing instance) when the !ID syntax was left uncorrected.","created_at":"2018-06-22T23:57:36Z","updated_at":"2018-06-22T23:57:37Z","html_url":"https://github.com/pantheon-systems/solr-power/pull/368#discussion_r197593471","pull_request_url":"https://api.github.com/repos/pantheon-systems/solr-power/pulls/368","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/pantheon-systems/solr-power/pulls/comments/197593471"},"html":{"href":"https://github.com/pantheon-systems/solr-power/pull/368#discussion_r197593471"},"pull_request":{"href":"https://api.github.com/repos/pantheon-systems/solr-power/pulls/368"}}},"pull_request":{"url":"https://api.github.com/repos/pantheon-systems/solr-power/pulls/368","id":195852025,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1ODUyMDI1","html_url":"https://github.com/pantheon-systems/solr-power/pull/368","diff_url":"https://github.com/pantheon-systems/solr-power/pull/368.diff","patch_url":"https://github.com/pantheon-systems/solr-power/pull/368.patch","issue_url":"https://api.github.com/repos/pantheon-systems/solr-power/issues/368","number":368,"state":"open","locked":false,"title":"Added post__in and post__not_in support","user":{"login":"ghamok","id":40301523,"node_id":"MDQ6VXNlcjQwMzAxNTIz","avatar_url":"https://avatars2.githubusercontent.com/u/40301523?v=4","gravatar_id":"","url":"https://api.github.com/users/ghamok","html_url":"https://github.com/ghamok","followers_url":"https://api.github.com/users/ghamok/followers","following_url":"https://api.github.com/users/ghamok/following{/other_user}","gists_url":"https://api.github.com/users/ghamok/gists{/gist_id}","starred_url":"https://api.github.com/users/ghamok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghamok/subscriptions","organizations_url":"https://api.github.com/users/ghamok/orgs","repos_url":"https://api.github.com/users/ghamok/repos","events_url":"https://api.github.com/users/ghamok/events{/privacy}","received_events_url":"https://api.github.com/users/ghamok/received_events","type":"User","site_admin":false},"body":"Added in missing `post__in` and `post__not_in` WP_Query args using the approach described by @rdanamcd. However, I generalized the approach to account for other possible NOT queries and formatted code to meet project's code standards.\r\n\r\nCases That Should Now Work:\r\n1. WP_Query with post_in arg (will work with array lengths of 1 or more)\r\n2. WP_Query with post__not_in arg (will work with array lengths of 1 or more)","created_at":"2018-06-19T14:41:35Z","updated_at":"2018-06-22T23:57:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"284614eb1adcaad8264390b87eba461f79164cf1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pantheon-systems/solr-power/pulls/368/commits","review_comments_url":"https://api.github.com/repos/pantheon-systems/solr-power/pulls/368/comments","review_comment_url":"https://api.github.com/repos/pantheon-systems/solr-power/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pantheon-systems/solr-power/issues/368/comments","statuses_url":"https://api.github.com/repos/pantheon-systems/solr-power/statuses/24c9c16914ce2cc8e3b519ef09d8f57b63cb95f8","head":{"label":"ghamok:issue/180","ref":"issue/180","sha":"24c9c16914ce2cc8e3b519ef09d8f57b63cb95f8","user":{"login":"ghamok","id":40301523,"node_id":"MDQ6VXNlcjQwMzAxNTIz","avatar_url":"https://avatars2.githubusercontent.com/u/40301523?v=4","gravatar_id":"","url":"https://api.github.com/users/ghamok","html_url":"https://github.com/ghamok","followers_url":"https://api.github.com/users/ghamok/followers","following_url":"https://api.github.com/users/ghamok/following{/other_user}","gists_url":"https://api.github.com/users/ghamok/gists{/gist_id}","starred_url":"https://api.github.com/users/ghamok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghamok/subscriptions","organizations_url":"https://api.github.com/users/ghamok/orgs","repos_url":"https://api.github.com/users/ghamok/repos","events_url":"https://api.github.com/users/ghamok/events{/privacy}","received_events_url":"https://api.github.com/users/ghamok/received_events","type":"User","site_admin":false},"repo":{"id":137512004,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc1MTIwMDQ=","name":"solr-power","full_name":"ghamok/solr-power","owner":{"login":"ghamok","id":40301523,"node_id":"MDQ6VXNlcjQwMzAxNTIz","avatar_url":"https://avatars2.githubusercontent.com/u/40301523?v=4","gravatar_id":"","url":"https://api.github.com/users/ghamok","html_url":"https://github.com/ghamok","followers_url":"https://api.github.com/users/ghamok/followers","following_url":"https://api.github.com/users/ghamok/following{/other_user}","gists_url":"https://api.github.com/users/ghamok/gists{/gist_id}","starred_url":"https://api.github.com/users/ghamok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghamok/subscriptions","organizations_url":"https://api.github.com/users/ghamok/orgs","repos_url":"https://api.github.com/users/ghamok/repos","events_url":"https://api.github.com/users/ghamok/events{/privacy}","received_events_url":"https://api.github.com/users/ghamok/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ghamok/solr-power","description":"An open source plugin to connect to Pantheon's Apache Solr search infrastructure, or your own!","fork":true,"url":"https://api.github.com/repos/ghamok/solr-power","forks_url":"https://api.github.com/repos/ghamok/solr-power/forks","keys_url":"https://api.github.com/repos/ghamok/solr-power/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ghamok/solr-power/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ghamok/solr-power/teams","hooks_url":"https://api.github.com/repos/ghamok/solr-power/hooks","issue_events_url":"https://api.github.com/repos/ghamok/solr-power/issues/events{/number}","events_url":"https://api.github.com/repos/ghamok/solr-power/events","assignees_url":"https://api.github.com/repos/ghamok/solr-power/assignees{/user}","branches_url":"https://api.github.com/repos/ghamok/solr-power/branches{/branch}","tags_url":"https://api.github.com/repos/ghamok/solr-power/tags","blobs_url":"https://api.github.com/repos/ghamok/solr-power/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ghamok/solr-power/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ghamok/solr-power/git/refs{/sha}","trees_url":"https://api.github.com/repos/ghamok/solr-power/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ghamok/solr-power/statuses/{sha}","languages_url":"https://api.github.com/repos/ghamok/solr-power/languages","stargazers_url":"https://api.github.com/repos/ghamok/solr-power/stargazers","contributors_url":"https://api.github.com/repos/ghamok/solr-power/contributors","subscribers_url":"https://api.github.com/repos/ghamok/solr-power/subscribers","subscription_url":"https://api.github.com/repos/ghamok/solr-power/subscription","commits_url":"https://api.github.com/repos/ghamok/solr-power/commits{/sha}","git_commits_url":"https://api.github.com/repos/ghamok/solr-power/git/commits{/sha}","comments_url":"https://api.github.com/repos/ghamok/solr-power/comments{/number}","issue_comment_url":"https://api.github.com/repos/ghamok/solr-power/issues/comments{/number}","contents_url":"https://api.github.com/repos/ghamok/solr-power/contents/{+path}","compare_url":"https://api.github.com/repos/ghamok/solr-power/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ghamok/solr-power/merges","archive_url":"https://api.github.com/repos/ghamok/solr-power/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ghamok/solr-power/downloads","issues_url":"https://api.github.com/repos/ghamok/solr-power/issues{/number}","pulls_url":"https://api.github.com/repos/ghamok/solr-power/pulls{/number}","milestones_url":"https://api.github.com/repos/ghamok/solr-power/milestones{/number}","notifications_url":"https://api.github.com/repos/ghamok/solr-power/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ghamok/solr-power/labels{/name}","releases_url":"https://api.github.com/repos/ghamok/solr-power/releases{/id}","deployments_url":"https://api.github.com/repos/ghamok/solr-power/deployments","created_at":"2018-06-15T16:52:06Z","updated_at":"2018-06-15T16:52:08Z","pushed_at":"2018-06-22T23:27:23Z","git_url":"git://github.com/ghamok/solr-power.git","ssh_url":"git@github.com:ghamok/solr-power.git","clone_url":"https://github.com/ghamok/solr-power.git","svn_url":"https://github.com/ghamok/solr-power","homepage":"https://pantheon.io/wordpress","size":3288,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pantheon-systems:master","ref":"master","sha":"c6cb85c0bba37ea0db877d14ebc838145598c363","user":{"login":"pantheon-systems","id":513357,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxMzM1Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/513357?v=4","gravatar_id":"","url":"https://api.github.com/users/pantheon-systems","html_url":"https://github.com/pantheon-systems","followers_url":"https://api.github.com/users/pantheon-systems/followers","following_url":"https://api.github.com/users/pantheon-systems/following{/other_user}","gists_url":"https://api.github.com/users/pantheon-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/pantheon-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pantheon-systems/subscriptions","organizations_url":"https://api.github.com/users/pantheon-systems/orgs","repos_url":"https://api.github.com/users/pantheon-systems/repos","events_url":"https://api.github.com/users/pantheon-systems/events{/privacy}","received_events_url":"https://api.github.com/users/pantheon-systems/received_events","type":"Organization","site_admin":false},"repo":{"id":31395449,"node_id":"MDEwOlJlcG9zaXRvcnkzMTM5NTQ0OQ==","name":"solr-power","full_name":"pantheon-systems/solr-power","owner":{"login":"pantheon-systems","id":513357,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxMzM1Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/513357?v=4","gravatar_id":"","url":"https://api.github.com/users/pantheon-systems","html_url":"https://github.com/pantheon-systems","followers_url":"https://api.github.com/users/pantheon-systems/followers","following_url":"https://api.github.com/users/pantheon-systems/following{/other_user}","gists_url":"https://api.github.com/users/pantheon-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/pantheon-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pantheon-systems/subscriptions","organizations_url":"https://api.github.com/users/pantheon-systems/orgs","repos_url":"https://api.github.com/users/pantheon-systems/repos","events_url":"https://api.github.com/users/pantheon-systems/events{/privacy}","received_events_url":"https://api.github.com/users/pantheon-systems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pantheon-systems/solr-power","description":"An open source plugin to connect to Pantheon's Apache Solr search infrastructure, or your own!","fork":false,"url":"https://api.github.com/repos/pantheon-systems/solr-power","forks_url":"https://api.github.com/repos/pantheon-systems/solr-power/forks","keys_url":"https://api.github.com/repos/pantheon-systems/solr-power/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pantheon-systems/solr-power/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pantheon-systems/solr-power/teams","hooks_url":"https://api.github.com/repos/pantheon-systems/solr-power/hooks","issue_events_url":"https://api.github.com/repos/pantheon-systems/solr-power/issues/events{/number}","events_url":"https://api.github.com/repos/pantheon-systems/solr-power/events","assignees_url":"https://api.github.com/repos/pantheon-systems/solr-power/assignees{/user}","branches_url":"https://api.github.com/repos/pantheon-systems/solr-power/branches{/branch}","tags_url":"https://api.github.com/repos/pantheon-systems/solr-power/tags","blobs_url":"https://api.github.com/repos/pantheon-systems/solr-power/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pantheon-systems/solr-power/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pantheon-systems/solr-power/git/refs{/sha}","trees_url":"https://api.github.com/repos/pantheon-systems/solr-power/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pantheon-systems/solr-power/statuses/{sha}","languages_url":"https://api.github.com/repos/pantheon-systems/solr-power/languages","stargazers_url":"https://api.github.com/repos/pantheon-systems/solr-power/stargazers","contributors_url":"https://api.github.com/repos/pantheon-systems/solr-power/contributors","subscribers_url":"https://api.github.com/repos/pantheon-systems/solr-power/subscribers","subscription_url":"https://api.github.com/repos/pantheon-systems/solr-power/subscription","commits_url":"https://api.github.com/repos/pantheon-systems/solr-power/commits{/sha}","git_commits_url":"https://api.github.com/repos/pantheon-systems/solr-power/git/commits{/sha}","comments_url":"https://api.github.com/repos/pantheon-systems/solr-power/comments{/number}","issue_comment_url":"https://api.github.com/repos/pantheon-systems/solr-power/issues/comments{/number}","contents_url":"https://api.github.com/repos/pantheon-systems/solr-power/contents/{+path}","compare_url":"https://api.github.com/repos/pantheon-systems/solr-power/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pantheon-systems/solr-power/merges","archive_url":"https://api.github.com/repos/pantheon-systems/solr-power/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pantheon-systems/solr-power/downloads","issues_url":"https://api.github.com/repos/pantheon-systems/solr-power/issues{/number}","pulls_url":"https://api.github.com/repos/pantheon-systems/solr-power/pulls{/number}","milestones_url":"https://api.github.com/repos/pantheon-systems/solr-power/milestones{/number}","notifications_url":"https://api.github.com/repos/pantheon-systems/solr-power/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pantheon-systems/solr-power/labels{/name}","releases_url":"https://api.github.com/repos/pantheon-systems/solr-power/releases{/id}","deployments_url":"https://api.github.com/repos/pantheon-systems/solr-power/deployments","created_at":"2015-02-27T00:06:57Z","updated_at":"2018-06-12T21:38:14Z","pushed_at":"2018-06-22T23:27:24Z","git_url":"git://github.com/pantheon-systems/solr-power.git","ssh_url":"git@github.com:pantheon-systems/solr-power.git","clone_url":"https://github.com/pantheon-systems/solr-power.git","svn_url":"https://github.com/pantheon-systems/solr-power","homepage":"https://pantheon.io/wordpress","size":3265,"stargazers_count":88,"watchers_count":88,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":34,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":33,"open_issues":34,"watchers":88,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pantheon-systems/solr-power/pulls/368"},"html":{"href":"https://github.com/pantheon-systems/solr-power/pull/368"},"issue":{"href":"https://api.github.com/repos/pantheon-systems/solr-power/issues/368"},"comments":{"href":"https://api.github.com/repos/pantheon-systems/solr-power/issues/368/comments"},"review_comments":{"href":"https://api.github.com/repos/pantheon-systems/solr-power/pulls/368/comments"},"review_comment":{"href":"https://api.github.com/repos/pantheon-systems/solr-power/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pantheon-systems/solr-power/pulls/368/commits"},"statuses":{"href":"https://api.github.com/repos/pantheon-systems/solr-power/statuses/24c9c16914ce2cc8e3b519ef09d8f57b63cb95f8"}},"author_association":"NONE"}}
{"actor":{"display_login":"ghamok"}}