{"action":"opened","number":18515,"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/18515","id":206249393,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MjQ5Mzkz","html_url":"https://github.com/apple/swift/pull/18515","diff_url":"https://github.com/apple/swift/pull/18515.diff","patch_url":"https://github.com/apple/swift/pull/18515.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/18515","number":18515,"state":"open","locked":false,"title":"Add StringTensorHandle support","user":{"login":"njjiang","id":10748625,"node_id":"MDQ6VXNlcjEwNzQ4NjI1","avatar_url":"https://avatars2.githubusercontent.com/u/10748625?v=4","gravatar_id":"","url":"https://api.github.com/users/njjiang","html_url":"https://github.com/njjiang","followers_url":"https://api.github.com/users/njjiang/followers","following_url":"https://api.github.com/users/njjiang/following{/other_user}","gists_url":"https://api.github.com/users/njjiang/gists{/gist_id}","starred_url":"https://api.github.com/users/njjiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njjiang/subscriptions","organizations_url":"https://api.github.com/users/njjiang/orgs","repos_url":"https://api.github.com/users/njjiang/repos","events_url":"https://api.github.com/users/njjiang/events{/privacy}","received_events_url":"https://api.github.com/users/njjiang/received_events","type":"User","site_admin":false},"body":"This patch adds Swift support for String Tensors by adding an opaque handle `StringTensorHandle` and refactoring relevant code in `visitGraphOperationInst`. \r\n\r\nOriginally `visitGraphOperationInst` only supported tensor attributes of Int and Float types, by casting both to`APInt` and call `convertValuesToTensor` to construct a `TF_Tensor`. Since we need to support String tensors, we use the `SymbolicValue` type directly and let `convertValuesToTensor` perform the specific logic for converting Int, Float or String to a tensor with the corresponding `dtype`.","created_at":"2018-08-05T17:31:33Z","updated_at":"2018-08-05T17:31:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/18515/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/18515/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/18515/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/0a18c0e60304ff75f0d74d864023b511924ecbb2","head":{"label":"njjiang:string","ref":"string","sha":"0a18c0e60304ff75f0d74d864023b511924ecbb2","user":{"login":"njjiang","id":10748625,"node_id":"MDQ6VXNlcjEwNzQ4NjI1","avatar_url":"https://avatars2.githubusercontent.com/u/10748625?v=4","gravatar_id":"","url":"https://api.github.com/users/njjiang","html_url":"https://github.com/njjiang","followers_url":"https://api.github.com/users/njjiang/followers","following_url":"https://api.github.com/users/njjiang/following{/other_user}","gists_url":"https://api.github.com/users/njjiang/gists{/gist_id}","starred_url":"https://api.github.com/users/njjiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njjiang/subscriptions","organizations_url":"https://api.github.com/users/njjiang/orgs","repos_url":"https://api.github.com/users/njjiang/repos","events_url":"https://api.github.com/users/njjiang/events{/privacy}","received_events_url":"https://api.github.com/users/njjiang/received_events","type":"User","site_admin":false},"repo":{"id":64886363,"node_id":"MDEwOlJlcG9zaXRvcnk2NDg4NjM2Mw==","name":"swift","full_name":"njjiang/swift","owner":{"login":"njjiang","id":10748625,"node_id":"MDQ6VXNlcjEwNzQ4NjI1","avatar_url":"https://avatars2.githubusercontent.com/u/10748625?v=4","gravatar_id":"","url":"https://api.github.com/users/njjiang","html_url":"https://github.com/njjiang","followers_url":"https://api.github.com/users/njjiang/followers","following_url":"https://api.github.com/users/njjiang/following{/other_user}","gists_url":"https://api.github.com/users/njjiang/gists{/gist_id}","starred_url":"https://api.github.com/users/njjiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njjiang/subscriptions","organizations_url":"https://api.github.com/users/njjiang/orgs","repos_url":"https://api.github.com/users/njjiang/repos","events_url":"https://api.github.com/users/njjiang/events{/privacy}","received_events_url":"https://api.github.com/users/njjiang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/njjiang/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/njjiang/swift","forks_url":"https://api.github.com/repos/njjiang/swift/forks","keys_url":"https://api.github.com/repos/njjiang/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/njjiang/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/njjiang/swift/teams","hooks_url":"https://api.github.com/repos/njjiang/swift/hooks","issue_events_url":"https://api.github.com/repos/njjiang/swift/issues/events{/number}","events_url":"https://api.github.com/repos/njjiang/swift/events","assignees_url":"https://api.github.com/repos/njjiang/swift/assignees{/user}","branches_url":"https://api.github.com/repos/njjiang/swift/branches{/branch}","tags_url":"https://api.github.com/repos/njjiang/swift/tags","blobs_url":"https://api.github.com/repos/njjiang/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/njjiang/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/njjiang/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/njjiang/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/njjiang/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/njjiang/swift/languages","stargazers_url":"https://api.github.com/repos/njjiang/swift/stargazers","contributors_url":"https://api.github.com/repos/njjiang/swift/contributors","subscribers_url":"https://api.github.com/repos/njjiang/swift/subscribers","subscription_url":"https://api.github.com/repos/njjiang/swift/subscription","commits_url":"https://api.github.com/repos/njjiang/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/njjiang/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/njjiang/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/njjiang/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/njjiang/swift/contents/{+path}","compare_url":"https://api.github.com/repos/njjiang/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/njjiang/swift/merges","archive_url":"https://api.github.com/repos/njjiang/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/njjiang/swift/downloads","issues_url":"https://api.github.com/repos/njjiang/swift/issues{/number}","pulls_url":"https://api.github.com/repos/njjiang/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/njjiang/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/njjiang/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/njjiang/swift/labels{/name}","releases_url":"https://api.github.com/repos/njjiang/swift/releases{/id}","deployments_url":"https://api.github.com/repos/njjiang/swift/deployments","created_at":"2016-08-03T23:32:33Z","updated_at":"2016-08-03T23:32:57Z","pushed_at":"2018-08-05T11:00:40Z","git_url":"git://github.com/njjiang/swift.git","ssh_url":"git@github.com:njjiang/swift.git","clone_url":"https://github.com/njjiang/swift.git","svn_url":"https://github.com/njjiang/swift","homepage":"https://swift.org/","size":293432,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:tensorflow","ref":"tensorflow","sha":"fa69bf24de77e0f654d3345eda6ad934b363ad93","user":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"node_id":"MDEwOlJlcG9zaXRvcnk0NDgzODk0OQ==","name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2018-08-05T16:28:40Z","pushed_at":"2018-08-05T16:57:13Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":322461,"stargazers_count":44748,"watchers_count":44748,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7055,"mirror_url":null,"archived":false,"open_issues_count":365,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7055,"open_issues":365,"watchers":44748,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/18515"},"html":{"href":"https://github.com/apple/swift/pull/18515"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/18515"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/18515/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/18515/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/18515/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/0a18c0e60304ff75f0d74d864023b511924ecbb2"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":133,"deletions":56,"changed_files":7}}
{"actor":{"display_login":"njjiang"}}