{"action":"opened","number":447,"pull_request":{"url":"https://api.github.com/repos/rust-lang/regex/pulls/447","id":168283586,"html_url":"https://github.com/rust-lang/regex/pull/447","diff_url":"https://github.com/rust-lang/regex/pull/447.diff","patch_url":"https://github.com/rust-lang/regex/pull/447.patch","issue_url":"https://api.github.com/repos/rust-lang/regex/issues/447","number":447,"state":"open","locked":false,"title":"Closes #446","user":{"login":"ethanpailes","id":4305381,"avatar_url":"https://avatars2.githubusercontent.com/u/4305381?v=4","gravatar_id":"","url":"https://api.github.com/users/ethanpailes","html_url":"https://github.com/ethanpailes","followers_url":"https://api.github.com/users/ethanpailes/followers","following_url":"https://api.github.com/users/ethanpailes/following{/other_user}","gists_url":"https://api.github.com/users/ethanpailes/gists{/gist_id}","starred_url":"https://api.github.com/users/ethanpailes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethanpailes/subscriptions","organizations_url":"https://api.github.com/users/ethanpailes/orgs","repos_url":"https://api.github.com/users/ethanpailes/repos","events_url":"https://api.github.com/users/ethanpailes/events{/privacy}","received_events_url":"https://api.github.com/users/ethanpailes/received_events","type":"User","site_admin":false},"body":"Thanks @BurntSushi for doing all the legwork on cutting down the failing test case and laying out a clear set of execution steps. It really helped me zero in on the bug.\r\n\r\nThis patch fixes an issue where skip resolution would go strait\r\nto the default value (the md2_shift) on a match failure after\r\nthe shift_loop. Now we do the right thing, and first check in\r\nthe skip table. The problem with going strait to the md2_shift\r\nis that you can accidentally shift to far when `window_end`\r\nactually is in the pattern (as is the case for the failing\r\nmatch).\r\n\r\nIn the issue thread I promised better modularity, but it turns\r\nout that shift resolution was a bit too decomposed in the other\r\nplaces I had mentioned. Sorry :(.","created_at":"2018-02-09T16:26:42Z","updated_at":"2018-02-09T16:26:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/regex/pulls/447/commits","review_comments_url":"https://api.github.com/repos/rust-lang/regex/pulls/447/comments","review_comment_url":"https://api.github.com/repos/rust-lang/regex/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/regex/issues/447/comments","statuses_url":"https://api.github.com/repos/rust-lang/regex/statuses/edac559ea668821b9ad4abaf35baa8f2c9d08384","head":{"label":"ethanpailes:issue-446","ref":"issue-446","sha":"edac559ea668821b9ad4abaf35baa8f2c9d08384","user":{"login":"ethanpailes","id":4305381,"avatar_url":"https://avatars2.githubusercontent.com/u/4305381?v=4","gravatar_id":"","url":"https://api.github.com/users/ethanpailes","html_url":"https://github.com/ethanpailes","followers_url":"https://api.github.com/users/ethanpailes/followers","following_url":"https://api.github.com/users/ethanpailes/following{/other_user}","gists_url":"https://api.github.com/users/ethanpailes/gists{/gist_id}","starred_url":"https://api.github.com/users/ethanpailes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethanpailes/subscriptions","organizations_url":"https://api.github.com/users/ethanpailes/orgs","repos_url":"https://api.github.com/users/ethanpailes/repos","events_url":"https://api.github.com/users/ethanpailes/events{/privacy}","received_events_url":"https://api.github.com/users/ethanpailes/received_events","type":"User","site_admin":false},"repo":{"id":108599534,"name":"regex","full_name":"ethanpailes/regex","owner":{"login":"ethanpailes","id":4305381,"avatar_url":"https://avatars2.githubusercontent.com/u/4305381?v=4","gravatar_id":"","url":"https://api.github.com/users/ethanpailes","html_url":"https://github.com/ethanpailes","followers_url":"https://api.github.com/users/ethanpailes/followers","following_url":"https://api.github.com/users/ethanpailes/following{/other_user}","gists_url":"https://api.github.com/users/ethanpailes/gists{/gist_id}","starred_url":"https://api.github.com/users/ethanpailes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethanpailes/subscriptions","organizations_url":"https://api.github.com/users/ethanpailes/orgs","repos_url":"https://api.github.com/users/ethanpailes/repos","events_url":"https://api.github.com/users/ethanpailes/events{/privacy}","received_events_url":"https://api.github.com/users/ethanpailes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ethanpailes/regex","description":"An implementation of regular expressions for Rust. This implementation uses finite automata and guarantees linear time matching on all inputs.","fork":true,"url":"https://api.github.com/repos/ethanpailes/regex","forks_url":"https://api.github.com/repos/ethanpailes/regex/forks","keys_url":"https://api.github.com/repos/ethanpailes/regex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethanpailes/regex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethanpailes/regex/teams","hooks_url":"https://api.github.com/repos/ethanpailes/regex/hooks","issue_events_url":"https://api.github.com/repos/ethanpailes/regex/issues/events{/number}","events_url":"https://api.github.com/repos/ethanpailes/regex/events","assignees_url":"https://api.github.com/repos/ethanpailes/regex/assignees{/user}","branches_url":"https://api.github.com/repos/ethanpailes/regex/branches{/branch}","tags_url":"https://api.github.com/repos/ethanpailes/regex/tags","blobs_url":"https://api.github.com/repos/ethanpailes/regex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethanpailes/regex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethanpailes/regex/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethanpailes/regex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethanpailes/regex/statuses/{sha}","languages_url":"https://api.github.com/repos/ethanpailes/regex/languages","stargazers_url":"https://api.github.com/repos/ethanpailes/regex/stargazers","contributors_url":"https://api.github.com/repos/ethanpailes/regex/contributors","subscribers_url":"https://api.github.com/repos/ethanpailes/regex/subscribers","subscription_url":"https://api.github.com/repos/ethanpailes/regex/subscription","commits_url":"https://api.github.com/repos/ethanpailes/regex/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethanpailes/regex/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethanpailes/regex/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethanpailes/regex/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethanpailes/regex/contents/{+path}","compare_url":"https://api.github.com/repos/ethanpailes/regex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethanpailes/regex/merges","archive_url":"https://api.github.com/repos/ethanpailes/regex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethanpailes/regex/downloads","issues_url":"https://api.github.com/repos/ethanpailes/regex/issues{/number}","pulls_url":"https://api.github.com/repos/ethanpailes/regex/pulls{/number}","milestones_url":"https://api.github.com/repos/ethanpailes/regex/milestones{/number}","notifications_url":"https://api.github.com/repos/ethanpailes/regex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethanpailes/regex/labels{/name}","releases_url":"https://api.github.com/repos/ethanpailes/regex/releases{/id}","deployments_url":"https://api.github.com/repos/ethanpailes/regex/deployments","created_at":"2017-10-27T21:58:57Z","updated_at":"2017-11-10T16:53:30Z","pushed_at":"2018-02-09T16:24:38Z","git_url":"git://github.com/ethanpailes/regex.git","ssh_url":"git@github.com:ethanpailes/regex.git","clone_url":"https://github.com/ethanpailes/regex.git","svn_url":"https://github.com/ethanpailes/regex","homepage":"http://doc.rust-lang.org/regex","size":8349,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":9,"license":null,"forks":0,"open_issues":9,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"3182b23f34a49582b199602cbc2410d1f2b030eb","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":27890669,"name":"regex","full_name":"rust-lang/regex","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/regex","description":"An implementation of regular expressions for Rust. This implementation uses finite automata and guarantees linear time matching on all inputs.","fork":false,"url":"https://api.github.com/repos/rust-lang/regex","forks_url":"https://api.github.com/repos/rust-lang/regex/forks","keys_url":"https://api.github.com/repos/rust-lang/regex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/regex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/regex/teams","hooks_url":"https://api.github.com/repos/rust-lang/regex/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/regex/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/regex/events","assignees_url":"https://api.github.com/repos/rust-lang/regex/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/regex/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/regex/tags","blobs_url":"https://api.github.com/repos/rust-lang/regex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/regex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/regex/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/regex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/regex/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/regex/languages","stargazers_url":"https://api.github.com/repos/rust-lang/regex/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/regex/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/regex/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/regex/subscription","commits_url":"https://api.github.com/repos/rust-lang/regex/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/regex/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/regex/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/regex/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/regex/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/regex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/regex/merges","archive_url":"https://api.github.com/repos/rust-lang/regex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/regex/downloads","issues_url":"https://api.github.com/repos/rust-lang/regex/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/regex/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/regex/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/regex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/regex/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/regex/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/regex/deployments","created_at":"2014-12-11T20:39:09Z","updated_at":"2018-02-08T20:38:19Z","pushed_at":"2018-02-09T16:26:44Z","git_url":"git://github.com/rust-lang/regex.git","ssh_url":"git@github.com:rust-lang/regex.git","clone_url":"https://github.com/rust-lang/regex.git","svn_url":"https://github.com/rust-lang/regex","homepage":"https://docs.rs/regex","size":12181,"stargazers_count":625,"watchers_count":625,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":130,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":130,"open_issues":24,"watchers":625,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/regex/pulls/447"},"html":{"href":"https://github.com/rust-lang/regex/pull/447"},"issue":{"href":"https://api.github.com/repos/rust-lang/regex/issues/447"},"comments":{"href":"https://api.github.com/repos/rust-lang/regex/issues/447/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/regex/pulls/447/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/regex/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/regex/pulls/447/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/regex/statuses/edac559ea668821b9ad4abaf35baa8f2c9d08384"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":3,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"ethanpailes"}}