{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/171962495","pull_request_review_id":100913236,"id":171962495,"diff_hunk":"@@ -215,11 +214,7 @@ impl RegionValues {\n                 RegionVid::new(num_region_variables),\n                 RegionElementIndex::new(elements.num_elements()),\n             ),\n-            causes: if track_causes.0 {\n-                Some(CauseMap::default())\n-            } else {\n-                None\n-            },\n+            causes: Some(CauseMap::default()),","path":"src/librustc_mir/borrow_check/nll/region_infer/values.rs","position":26,"original_position":26,"commit_id":"ca649892bad390e32e5355c0ca222d64d169fab2","original_commit_id":"ca649892bad390e32e5355c0ca222d64d169fab2","user":{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"body":"This seems ok but mildly surprising -- that is, I think we should adjust some comments. I guess I would like a comment on `new` like this:\r\n\r\n---\r\n\r\nCreates a new set of \"region values\" that tracks causal information. Each of the regions in `num_region_variables` will be initialized with an empty set of points and no causal information.\r\n\r\n---\r\n\r\nThen I would expect to remove the `Clone` impl and add a new method like:\r\n\r\n```\r\n// This is what we use at first...\r\nfn clone_not_tracking_causes(&self) -> Self { .. }\r\n\r\n// ...this is what `clone` is today\r\nfn clone_tracking_causes(&self) -> Self { .. }\r\n```","created_at":"2018-03-02T21:05:42Z","updated_at":"2018-03-02T21:08:45Z","html_url":"https://github.com/rust-lang/rust/pull/48682#discussion_r171962495","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/48682","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/171962495"},"html":{"href":"https://github.com/rust-lang/rust/pull/48682#discussion_r171962495"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/48682"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/48682","id":172593067,"html_url":"https://github.com/rust-lang/rust/pull/48682","diff_url":"https://github.com/rust-lang/rust/pull/48682.diff","patch_url":"https://github.com/rust-lang/rust/pull/48682.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/48682","number":48682,"state":"open","locked":false,"title":"[NLL] [WIP] Make causal tracking lazy","user":{"login":"spastorino","id":52642,"avatar_url":"https://avatars0.githubusercontent.com/u/52642?v=4","gravatar_id":"","url":"https://api.github.com/users/spastorino","html_url":"https://github.com/spastorino","followers_url":"https://api.github.com/users/spastorino/followers","following_url":"https://api.github.com/users/spastorino/following{/other_user}","gists_url":"https://api.github.com/users/spastorino/gists{/gist_id}","starred_url":"https://api.github.com/users/spastorino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spastorino/subscriptions","organizations_url":"https://api.github.com/users/spastorino/orgs","repos_url":"https://api.github.com/users/spastorino/repos","events_url":"https://api.github.com/users/spastorino/events{/privacy}","received_events_url":"https://api.github.com/users/spastorino/received_events","type":"User","site_admin":false},"body":"**This is work in progress**\r\n\r\nClose #46590\r\n\r\ncc @nikomatsakis ","created_at":"2018-03-02T20:09:04Z","updated_at":"2018-03-02T21:08:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f5b70b65805f23a1445c40c4c1f26516e058e81","assignee":{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"assignees":[{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":583426710,"url":"https://api.github.com/repos/rust-lang/rust/labels/S-waiting-on-review","name":"S-waiting-on-review","color":"d3dddd","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/48682/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/48682/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/48682/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/ca649892bad390e32e5355c0ca222d64d169fab2","head":{"label":"spastorino:make_causal_lazy","ref":"make_causal_lazy","sha":"ca649892bad390e32e5355c0ca222d64d169fab2","user":{"login":"spastorino","id":52642,"avatar_url":"https://avatars0.githubusercontent.com/u/52642?v=4","gravatar_id":"","url":"https://api.github.com/users/spastorino","html_url":"https://github.com/spastorino","followers_url":"https://api.github.com/users/spastorino/followers","following_url":"https://api.github.com/users/spastorino/following{/other_user}","gists_url":"https://api.github.com/users/spastorino/gists{/gist_id}","starred_url":"https://api.github.com/users/spastorino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spastorino/subscriptions","organizations_url":"https://api.github.com/users/spastorino/orgs","repos_url":"https://api.github.com/users/spastorino/repos","events_url":"https://api.github.com/users/spastorino/events{/privacy}","received_events_url":"https://api.github.com/users/spastorino/received_events","type":"User","site_admin":false},"repo":{"id":24008505,"name":"rust","full_name":"spastorino/rust","owner":{"login":"spastorino","id":52642,"avatar_url":"https://avatars0.githubusercontent.com/u/52642?v=4","gravatar_id":"","url":"https://api.github.com/users/spastorino","html_url":"https://github.com/spastorino","followers_url":"https://api.github.com/users/spastorino/followers","following_url":"https://api.github.com/users/spastorino/following{/other_user}","gists_url":"https://api.github.com/users/spastorino/gists{/gist_id}","starred_url":"https://api.github.com/users/spastorino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spastorino/subscriptions","organizations_url":"https://api.github.com/users/spastorino/orgs","repos_url":"https://api.github.com/users/spastorino/repos","events_url":"https://api.github.com/users/spastorino/events{/privacy}","received_events_url":"https://api.github.com/users/spastorino/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/spastorino/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/spastorino/rust","forks_url":"https://api.github.com/repos/spastorino/rust/forks","keys_url":"https://api.github.com/repos/spastorino/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spastorino/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spastorino/rust/teams","hooks_url":"https://api.github.com/repos/spastorino/rust/hooks","issue_events_url":"https://api.github.com/repos/spastorino/rust/issues/events{/number}","events_url":"https://api.github.com/repos/spastorino/rust/events","assignees_url":"https://api.github.com/repos/spastorino/rust/assignees{/user}","branches_url":"https://api.github.com/repos/spastorino/rust/branches{/branch}","tags_url":"https://api.github.com/repos/spastorino/rust/tags","blobs_url":"https://api.github.com/repos/spastorino/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spastorino/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spastorino/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/spastorino/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spastorino/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/spastorino/rust/languages","stargazers_url":"https://api.github.com/repos/spastorino/rust/stargazers","contributors_url":"https://api.github.com/repos/spastorino/rust/contributors","subscribers_url":"https://api.github.com/repos/spastorino/rust/subscribers","subscription_url":"https://api.github.com/repos/spastorino/rust/subscription","commits_url":"https://api.github.com/repos/spastorino/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/spastorino/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/spastorino/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/spastorino/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/spastorino/rust/contents/{+path}","compare_url":"https://api.github.com/repos/spastorino/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spastorino/rust/merges","archive_url":"https://api.github.com/repos/spastorino/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spastorino/rust/downloads","issues_url":"https://api.github.com/repos/spastorino/rust/issues{/number}","pulls_url":"https://api.github.com/repos/spastorino/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/spastorino/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/spastorino/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spastorino/rust/labels{/name}","releases_url":"https://api.github.com/repos/spastorino/rust/releases{/id}","deployments_url":"https://api.github.com/repos/spastorino/rust/deployments","created_at":"2014-09-13T23:22:11Z","updated_at":"2017-09-22T20:25:55Z","pushed_at":"2018-03-02T20:06:56Z","git_url":"git://github.com/spastorino/rust.git","ssh_url":"git@github.com:spastorino/rust.git","clone_url":"https://github.com/spastorino/rust.git","svn_url":"https://github.com/spastorino/rust","homepage":"http://www.rust-lang.org","size":346935,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"9cb18a92ad87852c4c5d6726b8fbe8c38deda4ba","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2018-03-02T20:59:08Z","pushed_at":"2018-03-02T21:00:26Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":349785,"stargazers_count":26755,"watchers_count":26755,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4748,"mirror_url":null,"archived":false,"open_issues_count":3464,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":4748,"open_issues":3464,"watchers":26755,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/48682"},"html":{"href":"https://github.com/rust-lang/rust/pull/48682"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/48682"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/48682/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/48682/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/48682/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/ca649892bad390e32e5355c0ca222d64d169fab2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"nikomatsakis"}}