{"action":"closed","number":1350,"pull_request":{"url":"https://api.github.com/repos/confluentinc/ksql/pulls/1350","id":191173449,"html_url":"https://github.com/confluentinc/ksql/pull/1350","diff_url":"https://github.com/confluentinc/ksql/pull/1350.diff","patch_url":"https://github.com/confluentinc/ksql/pull/1350.patch","issue_url":"https://api.github.com/repos/confluentinc/ksql/issues/1350","number":1350,"state":"closed","locked":false,"title":"Child first class loader for UDFs","user":{"login":"dguy","id":54829,"avatar_url":"https://avatars2.githubusercontent.com/u/54829?v=4","gravatar_id":"","url":"https://api.github.com/users/dguy","html_url":"https://github.com/dguy","followers_url":"https://api.github.com/users/dguy/followers","following_url":"https://api.github.com/users/dguy/following{/other_user}","gists_url":"https://api.github.com/users/dguy/gists{/gist_id}","starred_url":"https://api.github.com/users/dguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dguy/subscriptions","organizations_url":"https://api.github.com/users/dguy/orgs","repos_url":"https://api.github.com/users/dguy/repos","events_url":"https://api.github.com/users/dguy/events{/privacy}","received_events_url":"https://api.github.com/users/dguy/received_events","type":"User","site_admin":false},"body":"### Description \r\nA child first class loader for loading custom UDFs. Each udf jar will get it's own class loader.\r\n\r\n### Testing done \r\nAdded a jar that contains some custom code and also classes that are in the ksql system class path. Test that classes are loaded from the appropriate class loader. Also test that any blacklisted classes will throw a ClassNotFoundException\r\n\r\n### Reviewer checklist\r\n- [ ] Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).\r\n- [ ] Ensure relevant issues are linked (description should include text like \"Fixes #<issue number>\")\r\n\r\n","created_at":"2018-05-29T14:52:00Z","updated_at":"2018-05-30T10:58:52Z","closed_at":"2018-05-30T10:58:51Z","merged_at":"2018-05-30T10:58:51Z","merge_commit_sha":"d41c2aaceee56121cd8a2ade7cc59099289c701e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/confluentinc/ksql/pulls/1350/commits","review_comments_url":"https://api.github.com/repos/confluentinc/ksql/pulls/1350/comments","review_comment_url":"https://api.github.com/repos/confluentinc/ksql/pulls/comments{/number}","comments_url":"https://api.github.com/repos/confluentinc/ksql/issues/1350/comments","statuses_url":"https://api.github.com/repos/confluentinc/ksql/statuses/eda19ea8e14b76c3a881adfd31b31f06d3b53a02","head":{"label":"dguy:udf-class-loader","ref":"udf-class-loader","sha":"eda19ea8e14b76c3a881adfd31b31f06d3b53a02","user":{"login":"dguy","id":54829,"avatar_url":"https://avatars2.githubusercontent.com/u/54829?v=4","gravatar_id":"","url":"https://api.github.com/users/dguy","html_url":"https://github.com/dguy","followers_url":"https://api.github.com/users/dguy/followers","following_url":"https://api.github.com/users/dguy/following{/other_user}","gists_url":"https://api.github.com/users/dguy/gists{/gist_id}","starred_url":"https://api.github.com/users/dguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dguy/subscriptions","organizations_url":"https://api.github.com/users/dguy/orgs","repos_url":"https://api.github.com/users/dguy/repos","events_url":"https://api.github.com/users/dguy/events{/privacy}","received_events_url":"https://api.github.com/users/dguy/received_events","type":"User","site_admin":false},"repo":{"id":105937514,"name":"ksql","full_name":"dguy/ksql","owner":{"login":"dguy","id":54829,"avatar_url":"https://avatars2.githubusercontent.com/u/54829?v=4","gravatar_id":"","url":"https://api.github.com/users/dguy","html_url":"https://github.com/dguy","followers_url":"https://api.github.com/users/dguy/followers","following_url":"https://api.github.com/users/dguy/following{/other_user}","gists_url":"https://api.github.com/users/dguy/gists{/gist_id}","starred_url":"https://api.github.com/users/dguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dguy/subscriptions","organizations_url":"https://api.github.com/users/dguy/orgs","repos_url":"https://api.github.com/users/dguy/repos","events_url":"https://api.github.com/users/dguy/events{/privacy}","received_events_url":"https://api.github.com/users/dguy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dguy/ksql","description":"KSQL - a Streaming SQL Engine for Apache Kafka ","fork":true,"url":"https://api.github.com/repos/dguy/ksql","forks_url":"https://api.github.com/repos/dguy/ksql/forks","keys_url":"https://api.github.com/repos/dguy/ksql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dguy/ksql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dguy/ksql/teams","hooks_url":"https://api.github.com/repos/dguy/ksql/hooks","issue_events_url":"https://api.github.com/repos/dguy/ksql/issues/events{/number}","events_url":"https://api.github.com/repos/dguy/ksql/events","assignees_url":"https://api.github.com/repos/dguy/ksql/assignees{/user}","branches_url":"https://api.github.com/repos/dguy/ksql/branches{/branch}","tags_url":"https://api.github.com/repos/dguy/ksql/tags","blobs_url":"https://api.github.com/repos/dguy/ksql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dguy/ksql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dguy/ksql/git/refs{/sha}","trees_url":"https://api.github.com/repos/dguy/ksql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dguy/ksql/statuses/{sha}","languages_url":"https://api.github.com/repos/dguy/ksql/languages","stargazers_url":"https://api.github.com/repos/dguy/ksql/stargazers","contributors_url":"https://api.github.com/repos/dguy/ksql/contributors","subscribers_url":"https://api.github.com/repos/dguy/ksql/subscribers","subscription_url":"https://api.github.com/repos/dguy/ksql/subscription","commits_url":"https://api.github.com/repos/dguy/ksql/commits{/sha}","git_commits_url":"https://api.github.com/repos/dguy/ksql/git/commits{/sha}","comments_url":"https://api.github.com/repos/dguy/ksql/comments{/number}","issue_comment_url":"https://api.github.com/repos/dguy/ksql/issues/comments{/number}","contents_url":"https://api.github.com/repos/dguy/ksql/contents/{+path}","compare_url":"https://api.github.com/repos/dguy/ksql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dguy/ksql/merges","archive_url":"https://api.github.com/repos/dguy/ksql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dguy/ksql/downloads","issues_url":"https://api.github.com/repos/dguy/ksql/issues{/number}","pulls_url":"https://api.github.com/repos/dguy/ksql/pulls{/number}","milestones_url":"https://api.github.com/repos/dguy/ksql/milestones{/number}","notifications_url":"https://api.github.com/repos/dguy/ksql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dguy/ksql/labels{/name}","releases_url":"https://api.github.com/repos/dguy/ksql/releases{/id}","deployments_url":"https://api.github.com/repos/dguy/ksql/deployments","created_at":"2017-10-05T20:33:32Z","updated_at":"2017-10-05T20:33:35Z","pushed_at":"2018-05-30T10:21:56Z","git_url":"git://github.com/dguy/ksql.git","ssh_url":"git@github.com:dguy/ksql.git","clone_url":"https://github.com/dguy/ksql.git","svn_url":"https://github.com/dguy/ksql","homepage":"","size":7493,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"0.1.x"}},"base":{"label":"confluentinc:master","ref":"master","sha":"8a904a21dcf27fe62e9f618707c9cb821f1d8b56","user":{"login":"confluentinc","id":9439498,"avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"repo":{"id":69400326,"name":"ksql","full_name":"confluentinc/ksql","owner":{"login":"confluentinc","id":9439498,"avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/confluentinc/ksql","description":"KSQL - the Streaming SQL Engine for Apache Kafka ","fork":false,"url":"https://api.github.com/repos/confluentinc/ksql","forks_url":"https://api.github.com/repos/confluentinc/ksql/forks","keys_url":"https://api.github.com/repos/confluentinc/ksql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/confluentinc/ksql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/confluentinc/ksql/teams","hooks_url":"https://api.github.com/repos/confluentinc/ksql/hooks","issue_events_url":"https://api.github.com/repos/confluentinc/ksql/issues/events{/number}","events_url":"https://api.github.com/repos/confluentinc/ksql/events","assignees_url":"https://api.github.com/repos/confluentinc/ksql/assignees{/user}","branches_url":"https://api.github.com/repos/confluentinc/ksql/branches{/branch}","tags_url":"https://api.github.com/repos/confluentinc/ksql/tags","blobs_url":"https://api.github.com/repos/confluentinc/ksql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/confluentinc/ksql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/confluentinc/ksql/git/refs{/sha}","trees_url":"https://api.github.com/repos/confluentinc/ksql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/confluentinc/ksql/statuses/{sha}","languages_url":"https://api.github.com/repos/confluentinc/ksql/languages","stargazers_url":"https://api.github.com/repos/confluentinc/ksql/stargazers","contributors_url":"https://api.github.com/repos/confluentinc/ksql/contributors","subscribers_url":"https://api.github.com/repos/confluentinc/ksql/subscribers","subscription_url":"https://api.github.com/repos/confluentinc/ksql/subscription","commits_url":"https://api.github.com/repos/confluentinc/ksql/commits{/sha}","git_commits_url":"https://api.github.com/repos/confluentinc/ksql/git/commits{/sha}","comments_url":"https://api.github.com/repos/confluentinc/ksql/comments{/number}","issue_comment_url":"https://api.github.com/repos/confluentinc/ksql/issues/comments{/number}","contents_url":"https://api.github.com/repos/confluentinc/ksql/contents/{+path}","compare_url":"https://api.github.com/repos/confluentinc/ksql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/confluentinc/ksql/merges","archive_url":"https://api.github.com/repos/confluentinc/ksql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/confluentinc/ksql/downloads","issues_url":"https://api.github.com/repos/confluentinc/ksql/issues{/number}","pulls_url":"https://api.github.com/repos/confluentinc/ksql/pulls{/number}","milestones_url":"https://api.github.com/repos/confluentinc/ksql/milestones{/number}","notifications_url":"https://api.github.com/repos/confluentinc/ksql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/confluentinc/ksql/labels{/name}","releases_url":"https://api.github.com/repos/confluentinc/ksql/releases{/id}","deployments_url":"https://api.github.com/repos/confluentinc/ksql/deployments","created_at":"2016-09-27T21:30:15Z","updated_at":"2018-05-30T07:56:02Z","pushed_at":"2018-05-30T10:58:51Z","git_url":"git://github.com/confluentinc/ksql.git","ssh_url":"git@github.com:confluentinc/ksql.git","clone_url":"https://github.com/confluentinc/ksql.git","svn_url":"https://github.com/confluentinc/ksql","homepage":"","size":7520,"stargazers_count":1692,"watchers_count":1692,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":313,"mirror_url":null,"archived":false,"open_issues_count":282,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":313,"open_issues":282,"watchers":1692,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/1350"},"html":{"href":"https://github.com/confluentinc/ksql/pull/1350"},"issue":{"href":"https://api.github.com/repos/confluentinc/ksql/issues/1350"},"comments":{"href":"https://api.github.com/repos/confluentinc/ksql/issues/1350/comments"},"review_comments":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/1350/comments"},"review_comment":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/1350/commits"},"statuses":{"href":"https://api.github.com/repos/confluentinc/ksql/statuses/eda19ea8e14b76c3a881adfd31b31f06d3b53a02"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"dguy","id":54829,"avatar_url":"https://avatars2.githubusercontent.com/u/54829?v=4","gravatar_id":"","url":"https://api.github.com/users/dguy","html_url":"https://github.com/dguy","followers_url":"https://api.github.com/users/dguy/followers","following_url":"https://api.github.com/users/dguy/following{/other_user}","gists_url":"https://api.github.com/users/dguy/gists{/gist_id}","starred_url":"https://api.github.com/users/dguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dguy/subscriptions","organizations_url":"https://api.github.com/users/dguy/orgs","repos_url":"https://api.github.com/users/dguy/repos","events_url":"https://api.github.com/users/dguy/events{/privacy}","received_events_url":"https://api.github.com/users/dguy/received_events","type":"User","site_admin":false},"comments":0,"review_comments":8,"maintainer_can_modify":false,"commits":4,"additions":163,"deletions":0,"changed_files":3}}
{"actor":{"display_login":"dguy"}}