{"action":"created","comment":{"url":"https://api.github.com/repos/lbfm-rwth/GaussPar/pulls/comments/231959154","pull_request_review_id":173047768,"id":231959154,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTk1OTE1NA==","diff_hunk":"@@ -26,55 +23,80 @@ GAUSS_prepare := function(nrAvailableThreads)\n     fi;\n end;\n \n-GAUSS_compute := function(A, q, numberChops)\n-    return GAUSS_GET_REAL_TIME_OF_FUNCTION_CALL(Chief,\n+GAUSS_compute := function(A, q, numberChops, showOutput)\n+    if (showOutput) then\n+        Print(\"Starting the parallel execution.\\n\");\n+    fi;\n+    res := GAUSS_GET_REAL_TIME_OF_FUNCTION_CALL(Chief,","path":"gap/measure_contention.g","position":18,"original_position":17,"commit_id":"9bbd95fad98a32023ace98fed56b3d5e1353e68d","original_commit_id":"3737b43ffef129770a7fbf142f1b56808f23fd28","user":{"login":"ssiccha","id":11617763,"node_id":"MDQ6VXNlcjExNjE3NzYz","avatar_url":"https://avatars1.githubusercontent.com/u/11617763?v=4","gravatar_id":"","url":"https://api.github.com/users/ssiccha","html_url":"https://github.com/ssiccha","followers_url":"https://api.github.com/users/ssiccha/followers","following_url":"https://api.github.com/users/ssiccha/following{/other_user}","gists_url":"https://api.github.com/users/ssiccha/gists{/gist_id}","starred_url":"https://api.github.com/users/ssiccha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssiccha/subscriptions","organizations_url":"https://api.github.com/users/ssiccha/orgs","repos_url":"https://api.github.com/users/ssiccha/repos","events_url":"https://api.github.com/users/ssiccha/events{/privacy}","received_events_url":"https://api.github.com/users/ssiccha/received_events","type":"User","site_admin":false},"body":"I amended the commit.","created_at":"2018-11-08T16:21:31Z","updated_at":"2018-11-08T16:21:31Z","html_url":"https://github.com/lbfm-rwth/GaussPar/pull/84#discussion_r231959154","pull_request_url":"https://api.github.com/repos/lbfm-rwth/GaussPar/pulls/84","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/lbfm-rwth/GaussPar/pulls/comments/231959154"},"html":{"href":"https://github.com/lbfm-rwth/GaussPar/pull/84#discussion_r231959154"},"pull_request":{"href":"https://api.github.com/repos/lbfm-rwth/GaussPar/pulls/84"}},"in_reply_to_id":231898389},"pull_request":{"url":"https://api.github.com/repos/lbfm-rwth/GaussPar/pulls/84","id":226551868,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NTUxODY4","html_url":"https://github.com/lbfm-rwth/GaussPar/pull/84","diff_url":"https://github.com/lbfm-rwth/GaussPar/pull/84.diff","patch_url":"https://github.com/lbfm-rwth/GaussPar/pull/84.patch","issue_url":"https://api.github.com/repos/lbfm-rwth/GaussPar/issues/84","number":84,"state":"open","locked":false,"title":"Improve MeasureContention","user":{"login":"ssiccha","id":11617763,"node_id":"MDQ6VXNlcjExNjE3NzYz","avatar_url":"https://avatars1.githubusercontent.com/u/11617763?v=4","gravatar_id":"","url":"https://api.github.com/users/ssiccha","html_url":"https://github.com/ssiccha","followers_url":"https://api.github.com/users/ssiccha/followers","following_url":"https://api.github.com/users/ssiccha/following{/other_user}","gists_url":"https://api.github.com/users/ssiccha/gists{/gist_id}","starred_url":"https://api.github.com/users/ssiccha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssiccha/subscriptions","organizations_url":"https://api.github.com/users/ssiccha/orgs","repos_url":"https://api.github.com/users/ssiccha/repos","events_url":"https://api.github.com/users/ssiccha/events{/privacy}","received_events_url":"https://api.github.com/users/ssiccha/received_events","type":"User","site_admin":false},"body":"Print the message that one should use -m to increase the\r\npreallocated memory. If the user is not aware of this,\r\nour code may run slower than the standard single threaded\r\ngauss.\r\n\r\nImproves a few general things:\r\n- move code such that all parallel things are done first\r\n- move storing measured CPU time into GAUSS_compute\r\n- rename 'visible' to 'showOutput'\r\n- don't use the optional 'showOutput' argument in README.md,\r\n  we only need it for testing anyways\r\n\r\nImproves printing:\r\n- use ms instead of microseconds\r\n- add some print statements\r\n- print information directly after a calculation is done","created_at":"2018-10-29T13:06:31Z","updated_at":"2018-11-08T16:21:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf8c6528038cda2069289343a58159c5e544fa8f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lbfm-rwth/GaussPar/pulls/84/commits","review_comments_url":"https://api.github.com/repos/lbfm-rwth/GaussPar/pulls/84/comments","review_comment_url":"https://api.github.com/repos/lbfm-rwth/GaussPar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lbfm-rwth/GaussPar/issues/84/comments","statuses_url":"https://api.github.com/repos/lbfm-rwth/GaussPar/statuses/9bbd95fad98a32023ace98fed56b3d5e1353e68d","head":{"label":"ssiccha:ss/measure_contention","ref":"ss/measure_contention","sha":"9bbd95fad98a32023ace98fed56b3d5e1353e68d","user":{"login":"ssiccha","id":11617763,"node_id":"MDQ6VXNlcjExNjE3NzYz","avatar_url":"https://avatars1.githubusercontent.com/u/11617763?v=4","gravatar_id":"","url":"https://api.github.com/users/ssiccha","html_url":"https://github.com/ssiccha","followers_url":"https://api.github.com/users/ssiccha/followers","following_url":"https://api.github.com/users/ssiccha/following{/other_user}","gists_url":"https://api.github.com/users/ssiccha/gists{/gist_id}","starred_url":"https://api.github.com/users/ssiccha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssiccha/subscriptions","organizations_url":"https://api.github.com/users/ssiccha/orgs","repos_url":"https://api.github.com/users/ssiccha/repos","events_url":"https://api.github.com/users/ssiccha/events{/privacy}","received_events_url":"https://api.github.com/users/ssiccha/received_events","type":"User","site_admin":false},"repo":{"id":130204502,"node_id":"MDEwOlJlcG9zaXRvcnkxMzAyMDQ1MDI=","name":"GaussPar","full_name":"ssiccha/GaussPar","private":false,"owner":{"login":"ssiccha","id":11617763,"node_id":"MDQ6VXNlcjExNjE3NzYz","avatar_url":"https://avatars1.githubusercontent.com/u/11617763?v=4","gravatar_id":"","url":"https://api.github.com/users/ssiccha","html_url":"https://github.com/ssiccha","followers_url":"https://api.github.com/users/ssiccha/followers","following_url":"https://api.github.com/users/ssiccha/following{/other_user}","gists_url":"https://api.github.com/users/ssiccha/gists{/gist_id}","starred_url":"https://api.github.com/users/ssiccha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssiccha/subscriptions","organizations_url":"https://api.github.com/users/ssiccha/orgs","repos_url":"https://api.github.com/users/ssiccha/repos","events_url":"https://api.github.com/users/ssiccha/events{/privacy}","received_events_url":"https://api.github.com/users/ssiccha/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ssiccha/GaussPar","description":"A parallel implementation of the Gaussian algorithm over finite fields","fork":true,"url":"https://api.github.com/repos/ssiccha/GaussPar","forks_url":"https://api.github.com/repos/ssiccha/GaussPar/forks","keys_url":"https://api.github.com/repos/ssiccha/GaussPar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ssiccha/GaussPar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ssiccha/GaussPar/teams","hooks_url":"https://api.github.com/repos/ssiccha/GaussPar/hooks","issue_events_url":"https://api.github.com/repos/ssiccha/GaussPar/issues/events{/number}","events_url":"https://api.github.com/repos/ssiccha/GaussPar/events","assignees_url":"https://api.github.com/repos/ssiccha/GaussPar/assignees{/user}","branches_url":"https://api.github.com/repos/ssiccha/GaussPar/branches{/branch}","tags_url":"https://api.github.com/repos/ssiccha/GaussPar/tags","blobs_url":"https://api.github.com/repos/ssiccha/GaussPar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ssiccha/GaussPar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ssiccha/GaussPar/git/refs{/sha}","trees_url":"https://api.github.com/repos/ssiccha/GaussPar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ssiccha/GaussPar/statuses/{sha}","languages_url":"https://api.github.com/repos/ssiccha/GaussPar/languages","stargazers_url":"https://api.github.com/repos/ssiccha/GaussPar/stargazers","contributors_url":"https://api.github.com/repos/ssiccha/GaussPar/contributors","subscribers_url":"https://api.github.com/repos/ssiccha/GaussPar/subscribers","subscription_url":"https://api.github.com/repos/ssiccha/GaussPar/subscription","commits_url":"https://api.github.com/repos/ssiccha/GaussPar/commits{/sha}","git_commits_url":"https://api.github.com/repos/ssiccha/GaussPar/git/commits{/sha}","comments_url":"https://api.github.com/repos/ssiccha/GaussPar/comments{/number}","issue_comment_url":"https://api.github.com/repos/ssiccha/GaussPar/issues/comments{/number}","contents_url":"https://api.github.com/repos/ssiccha/GaussPar/contents/{+path}","compare_url":"https://api.github.com/repos/ssiccha/GaussPar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ssiccha/GaussPar/merges","archive_url":"https://api.github.com/repos/ssiccha/GaussPar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ssiccha/GaussPar/downloads","issues_url":"https://api.github.com/repos/ssiccha/GaussPar/issues{/number}","pulls_url":"https://api.github.com/repos/ssiccha/GaussPar/pulls{/number}","milestones_url":"https://api.github.com/repos/ssiccha/GaussPar/milestones{/number}","notifications_url":"https://api.github.com/repos/ssiccha/GaussPar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ssiccha/GaussPar/labels{/name}","releases_url":"https://api.github.com/repos/ssiccha/GaussPar/releases{/id}","deployments_url":"https://api.github.com/repos/ssiccha/GaussPar/deployments","created_at":"2018-04-19T11:18:27Z","updated_at":"2018-10-25T08:07:18Z","pushed_at":"2018-11-08T16:20:57Z","git_url":"git://github.com/ssiccha/GaussPar.git","ssh_url":"git@github.com:ssiccha/GaussPar.git","clone_url":"https://github.com/ssiccha/GaussPar.git","svn_url":"https://github.com/ssiccha/GaussPar","homepage":"","size":677,"stargazers_count":0,"watchers_count":0,"language":"GAP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lbfm-rwth:master","ref":"master","sha":"45e1b1922feca44c82f092a11f794749fbea9a61","user":{"login":"lbfm-rwth","id":36504973,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTA0OTcz","avatar_url":"https://avatars2.githubusercontent.com/u/36504973?v=4","gravatar_id":"","url":"https://api.github.com/users/lbfm-rwth","html_url":"https://github.com/lbfm-rwth","followers_url":"https://api.github.com/users/lbfm-rwth/followers","following_url":"https://api.github.com/users/lbfm-rwth/following{/other_user}","gists_url":"https://api.github.com/users/lbfm-rwth/gists{/gist_id}","starred_url":"https://api.github.com/users/lbfm-rwth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbfm-rwth/subscriptions","organizations_url":"https://api.github.com/users/lbfm-rwth/orgs","repos_url":"https://api.github.com/users/lbfm-rwth/repos","events_url":"https://api.github.com/users/lbfm-rwth/events{/privacy}","received_events_url":"https://api.github.com/users/lbfm-rwth/received_events","type":"Organization","site_admin":false},"repo":{"id":114449777,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ0NDk3Nzc=","name":"GaussPar","full_name":"lbfm-rwth/GaussPar","private":false,"owner":{"login":"lbfm-rwth","id":36504973,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTA0OTcz","avatar_url":"https://avatars2.githubusercontent.com/u/36504973?v=4","gravatar_id":"","url":"https://api.github.com/users/lbfm-rwth","html_url":"https://github.com/lbfm-rwth","followers_url":"https://api.github.com/users/lbfm-rwth/followers","following_url":"https://api.github.com/users/lbfm-rwth/following{/other_user}","gists_url":"https://api.github.com/users/lbfm-rwth/gists{/gist_id}","starred_url":"https://api.github.com/users/lbfm-rwth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbfm-rwth/subscriptions","organizations_url":"https://api.github.com/users/lbfm-rwth/orgs","repos_url":"https://api.github.com/users/lbfm-rwth/repos","events_url":"https://api.github.com/users/lbfm-rwth/events{/privacy}","received_events_url":"https://api.github.com/users/lbfm-rwth/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/lbfm-rwth/GaussPar","description":"A parallel implementation of the Gaussian algorithm over finite fields","fork":false,"url":"https://api.github.com/repos/lbfm-rwth/GaussPar","forks_url":"https://api.github.com/repos/lbfm-rwth/GaussPar/forks","keys_url":"https://api.github.com/repos/lbfm-rwth/GaussPar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lbfm-rwth/GaussPar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lbfm-rwth/GaussPar/teams","hooks_url":"https://api.github.com/repos/lbfm-rwth/GaussPar/hooks","issue_events_url":"https://api.github.com/repos/lbfm-rwth/GaussPar/issues/events{/number}","events_url":"https://api.github.com/repos/lbfm-rwth/GaussPar/events","assignees_url":"https://api.github.com/repos/lbfm-rwth/GaussPar/assignees{/user}","branches_url":"https://api.github.com/repos/lbfm-rwth/GaussPar/branches{/branch}","tags_url":"https://api.github.com/repos/lbfm-rwth/GaussPar/tags","blobs_url":"https://api.github.com/repos/lbfm-rwth/GaussPar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lbfm-rwth/GaussPar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lbfm-rwth/GaussPar/git/refs{/sha}","trees_url":"https://api.github.com/repos/lbfm-rwth/GaussPar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lbfm-rwth/GaussPar/statuses/{sha}","languages_url":"https://api.github.com/repos/lbfm-rwth/GaussPar/languages","stargazers_url":"https://api.github.com/repos/lbfm-rwth/GaussPar/stargazers","contributors_url":"https://api.github.com/repos/lbfm-rwth/GaussPar/contributors","subscribers_url":"https://api.github.com/repos/lbfm-rwth/GaussPar/subscribers","subscription_url":"https://api.github.com/repos/lbfm-rwth/GaussPar/subscription","commits_url":"https://api.github.com/repos/lbfm-rwth/GaussPar/commits{/sha}","git_commits_url":"https://api.github.com/repos/lbfm-rwth/GaussPar/git/commits{/sha}","comments_url":"https://api.github.com/repos/lbfm-rwth/GaussPar/comments{/number}","issue_comment_url":"https://api.github.com/repos/lbfm-rwth/GaussPar/issues/comments{/number}","contents_url":"https://api.github.com/repos/lbfm-rwth/GaussPar/contents/{+path}","compare_url":"https://api.github.com/repos/lbfm-rwth/GaussPar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lbfm-rwth/GaussPar/merges","archive_url":"https://api.github.com/repos/lbfm-rwth/GaussPar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lbfm-rwth/GaussPar/downloads","issues_url":"https://api.github.com/repos/lbfm-rwth/GaussPar/issues{/number}","pulls_url":"https://api.github.com/repos/lbfm-rwth/GaussPar/pulls{/number}","milestones_url":"https://api.github.com/repos/lbfm-rwth/GaussPar/milestones{/number}","notifications_url":"https://api.github.com/repos/lbfm-rwth/GaussPar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lbfm-rwth/GaussPar/labels{/name}","releases_url":"https://api.github.com/repos/lbfm-rwth/GaussPar/releases{/id}","deployments_url":"https://api.github.com/repos/lbfm-rwth/GaussPar/deployments","created_at":"2017-12-16T09:43:07Z","updated_at":"2018-10-28T22:03:45Z","pushed_at":"2018-11-08T16:20:59Z","git_url":"git://github.com/lbfm-rwth/GaussPar.git","ssh_url":"git@github.com:lbfm-rwth/GaussPar.git","clone_url":"https://github.com/lbfm-rwth/GaussPar.git","svn_url":"https://github.com/lbfm-rwth/GaussPar","homepage":"","size":675,"stargazers_count":1,"watchers_count":1,"language":"GAP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":36,"license":null,"forks":5,"open_issues":36,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lbfm-rwth/GaussPar/pulls/84"},"html":{"href":"https://github.com/lbfm-rwth/GaussPar/pull/84"},"issue":{"href":"https://api.github.com/repos/lbfm-rwth/GaussPar/issues/84"},"comments":{"href":"https://api.github.com/repos/lbfm-rwth/GaussPar/issues/84/comments"},"review_comments":{"href":"https://api.github.com/repos/lbfm-rwth/GaussPar/pulls/84/comments"},"review_comment":{"href":"https://api.github.com/repos/lbfm-rwth/GaussPar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lbfm-rwth/GaussPar/pulls/84/commits"},"statuses":{"href":"https://api.github.com/repos/lbfm-rwth/GaussPar/statuses/9bbd95fad98a32023ace98fed56b3d5e1353e68d"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"ssiccha"}}