{"action":"created","issue":{"url":"https://api.github.com/repos/NVIDIAGameWorks/Falcor/issues/46","repository_url":"https://api.github.com/repos/NVIDIAGameWorks/Falcor","labels_url":"https://api.github.com/repos/NVIDIAGameWorks/Falcor/issues/46/labels{/name}","comments_url":"https://api.github.com/repos/NVIDIAGameWorks/Falcor/issues/46/comments","events_url":"https://api.github.com/repos/NVIDIAGameWorks/Falcor/issues/46/events","html_url":"https://github.com/NVIDIAGameWorks/Falcor/pull/46","id":301230037,"number":46,"title":"Test fixes","user":{"login":"clavelleNV","id":24660786,"avatar_url":"https://avatars3.githubusercontent.com/u/24660786?v=4","gravatar_id":"","url":"https://api.github.com/users/clavelleNV","html_url":"https://github.com/clavelleNV","followers_url":"https://api.github.com/users/clavelleNV/followers","following_url":"https://api.github.com/users/clavelleNV/following{/other_user}","gists_url":"https://api.github.com/users/clavelleNV/gists{/gist_id}","starred_url":"https://api.github.com/users/clavelleNV/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clavelleNV/subscriptions","organizations_url":"https://api.github.com/users/clavelleNV/orgs","repos_url":"https://api.github.com/users/clavelleNV/repos","events_url":"https://api.github.com/users/clavelleNV/events{/privacy}","received_events_url":"https://api.github.com/users/clavelleNV/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-28T23:59:18Z","updated_at":"2018-04-03T01:01:46Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/NVIDIAGameWorks/Falcor/pulls/46","html_url":"https://github.com/NVIDIAGameWorks/Falcor/pull/46","diff_url":"https://github.com/NVIDIAGameWorks/Falcor/pull/46.diff","patch_url":"https://github.com/NVIDIAGameWorks/Falcor/pull/46.patch"},"body":"These are changes to fix running check in tests\r\nAdded additional args to RunTestSet.py so you can specify a reference branch and machine to compare against \r\nAlso needed to change some things about have references are stored and overwritten on the network to facilitate this. \r\n\r\nSpecifically, references aren't stored at\r\n...\\References\\\\[MachineName]\\\\[BranchName]\\\\[TestConfigName]\\\\[TestSetName]\r\n\r\nand are instead stored at \r\n...\\References\\\\[MachineName]\\\\[BranchName]\\\\[TestSetName]\r\n\r\nbecause RunTestSet.py, and therefore the check-in batch files as well, have no concept of a test config \r\n"},"comment":{"url":"https://api.github.com/repos/NVIDIAGameWorks/Falcor/issues/comments/378094676","html_url":"https://github.com/NVIDIAGameWorks/Falcor/pull/46#issuecomment-378094676","issue_url":"https://api.github.com/repos/NVIDIAGameWorks/Falcor/issues/46","id":378094676,"user":{"login":"clavelleNV","id":24660786,"avatar_url":"https://avatars3.githubusercontent.com/u/24660786?v=4","gravatar_id":"","url":"https://api.github.com/users/clavelleNV","html_url":"https://github.com/clavelleNV","followers_url":"https://api.github.com/users/clavelleNV/followers","following_url":"https://api.github.com/users/clavelleNV/following{/other_user}","gists_url":"https://api.github.com/users/clavelleNV/gists{/gist_id}","starred_url":"https://api.github.com/users/clavelleNV/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clavelleNV/subscriptions","organizations_url":"https://api.github.com/users/clavelleNV/orgs","repos_url":"https://api.github.com/users/clavelleNV/repos","events_url":"https://api.github.com/users/clavelleNV/events{/privacy}","received_events_url":"https://api.github.com/users/clavelleNV/received_events","type":"User","site_admin":false},"created_at":"2018-04-03T01:01:46Z","updated_at":"2018-04-03T01:01:46Z","author_association":"COLLABORATOR","body":"Made @kyaoNV's requested changes. Doesn't necessarily mean testing is up and running but at least in this branch, the check in test batch files are fixed, which was the point of this branch. I think it would probably be fine to merge now but I can also merge dev-3.0 into this branch and make sure it's still all good after I get testing back up and running this week. "}}
{"actor":{"display_login":"clavelleNV"}}