{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/195626288","pull_request_review_id":129033881,"id":195626288,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTYyNjI4OA==","diff_hunk":"@@ -39,6 +39,12 @@ without blocking the Node.js event loop. The [`child_process.spawnSync()`][]\n function provides equivalent functionality in a synchronous manner that blocks\n the event loop until the spawned process either exits or is terminated.\n \n+*Note*: On some operating systems, the [`child_process.spawn()`][] method\n+performs memory operations synchronously before decoupling the event loop","path":"doc/api/child_process.md","position":null,"original_position":5,"commit_id":"217acc416e28b4a1d82f3bd012ad7fb0bfc2982d","original_commit_id":"3119e9bd037d705c7da74efec69be7e48171ab46","user":{"login":"davisjam","id":22822319,"node_id":"MDQ6VXNlcjIyODIyMzE5","avatar_url":"https://avatars0.githubusercontent.com/u/22822319?v=4","gravatar_id":"","url":"https://api.github.com/users/davisjam","html_url":"https://github.com/davisjam","followers_url":"https://api.github.com/users/davisjam/followers","following_url":"https://api.github.com/users/davisjam/following{/other_user}","gists_url":"https://api.github.com/users/davisjam/gists{/gist_id}","starred_url":"https://api.github.com/users/davisjam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davisjam/subscriptions","organizations_url":"https://api.github.com/users/davisjam/orgs","repos_url":"https://api.github.com/users/davisjam/repos","events_url":"https://api.github.com/users/davisjam/events{/privacy}","received_events_url":"https://api.github.com/users/davisjam/received_events","type":"User","site_admin":false},"body":"I like \"UNIX-like\", but I don't think we need to go into detail on the root cause. The V8 link explains things.","created_at":"2018-06-15T03:33:27Z","updated_at":"2018-06-15T03:33:27Z","html_url":"https://github.com/nodejs/node/pull/21234#discussion_r195626288","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/21234","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/195626288"},"html":{"href":"https://github.com/nodejs/node/pull/21234#discussion_r195626288"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/21234"}},"in_reply_to_id":194249465},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/21234","id":193791101,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNzkxMTAx","html_url":"https://github.com/nodejs/node/pull/21234","diff_url":"https://github.com/nodejs/node/pull/21234.diff","patch_url":"https://github.com/nodejs/node/pull/21234.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/21234","number":21234,"state":"open","locked":false,"title":"doc: note synchronous part of child_process.spawn","user":{"login":"davisjam","id":22822319,"node_id":"MDQ6VXNlcjIyODIyMzE5","avatar_url":"https://avatars0.githubusercontent.com/u/22822319?v=4","gravatar_id":"","url":"https://api.github.com/users/davisjam","html_url":"https://github.com/davisjam","followers_url":"https://api.github.com/users/davisjam/followers","following_url":"https://api.github.com/users/davisjam/following{/other_user}","gists_url":"https://api.github.com/users/davisjam/gists{/gist_id}","starred_url":"https://api.github.com/users/davisjam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davisjam/subscriptions","organizations_url":"https://api.github.com/users/davisjam/orgs","repos_url":"https://api.github.com/users/davisjam/repos","events_url":"https://api.github.com/users/davisjam/events{/privacy}","received_events_url":"https://api.github.com/users/davisjam/received_events","type":"User","site_admin":false},"body":"If an application has a large RSS (MB-GB), @jorangreef observed that `child_process.spawn` will block the event loop for milliseconds to seconds.\r\n\r\nThis is surprising behavior and merits documentation.\r\n\r\nSee discussion on #14917.\r\n\r\n##### Checklist\r\n\r\n- [X] documentation is changed or added\r\n- [X] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n","created_at":"2018-06-09T18:44:18Z","updated_at":"2018-06-15T03:33:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7319dc122ab3c751d35be31a98afc52550d90c64","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":155267478,"node_id":"MDU6TGFiZWwxNTUyNjc0Nzg=","url":"https://api.github.com/repos/nodejs/node/labels/child_process","name":"child_process","color":"f7c6c7","default":false},{"id":155267517,"node_id":"MDU6TGFiZWwxNTUyNjc1MTc=","url":"https://api.github.com/repos/nodejs/node/labels/doc","name":"doc","color":"006b75","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/21234/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/21234/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/21234/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/217acc416e28b4a1d82f3bd012ad7fb0bfc2982d","head":{"label":"davisjam:DocAsyncSpawnHazard","ref":"DocAsyncSpawnHazard","sha":"217acc416e28b4a1d82f3bd012ad7fb0bfc2982d","user":{"login":"davisjam","id":22822319,"node_id":"MDQ6VXNlcjIyODIyMzE5","avatar_url":"https://avatars0.githubusercontent.com/u/22822319?v=4","gravatar_id":"","url":"https://api.github.com/users/davisjam","html_url":"https://github.com/davisjam","followers_url":"https://api.github.com/users/davisjam/followers","following_url":"https://api.github.com/users/davisjam/following{/other_user}","gists_url":"https://api.github.com/users/davisjam/gists{/gist_id}","starred_url":"https://api.github.com/users/davisjam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davisjam/subscriptions","organizations_url":"https://api.github.com/users/davisjam/orgs","repos_url":"https://api.github.com/users/davisjam/repos","events_url":"https://api.github.com/users/davisjam/events{/privacy}","received_events_url":"https://api.github.com/users/davisjam/received_events","type":"User","site_admin":false},"repo":{"id":90649658,"node_id":"MDEwOlJlcG9zaXRvcnk5MDY0OTY1OA==","name":"node","full_name":"davisjam/node","owner":{"login":"davisjam","id":22822319,"node_id":"MDQ6VXNlcjIyODIyMzE5","avatar_url":"https://avatars0.githubusercontent.com/u/22822319?v=4","gravatar_id":"","url":"https://api.github.com/users/davisjam","html_url":"https://github.com/davisjam","followers_url":"https://api.github.com/users/davisjam/followers","following_url":"https://api.github.com/users/davisjam/following{/other_user}","gists_url":"https://api.github.com/users/davisjam/gists{/gist_id}","starred_url":"https://api.github.com/users/davisjam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davisjam/subscriptions","organizations_url":"https://api.github.com/users/davisjam/orgs","repos_url":"https://api.github.com/users/davisjam/repos","events_url":"https://api.github.com/users/davisjam/events{/privacy}","received_events_url":"https://api.github.com/users/davisjam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davisjam/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/davisjam/node","forks_url":"https://api.github.com/repos/davisjam/node/forks","keys_url":"https://api.github.com/repos/davisjam/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davisjam/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davisjam/node/teams","hooks_url":"https://api.github.com/repos/davisjam/node/hooks","issue_events_url":"https://api.github.com/repos/davisjam/node/issues/events{/number}","events_url":"https://api.github.com/repos/davisjam/node/events","assignees_url":"https://api.github.com/repos/davisjam/node/assignees{/user}","branches_url":"https://api.github.com/repos/davisjam/node/branches{/branch}","tags_url":"https://api.github.com/repos/davisjam/node/tags","blobs_url":"https://api.github.com/repos/davisjam/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davisjam/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davisjam/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/davisjam/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davisjam/node/statuses/{sha}","languages_url":"https://api.github.com/repos/davisjam/node/languages","stargazers_url":"https://api.github.com/repos/davisjam/node/stargazers","contributors_url":"https://api.github.com/repos/davisjam/node/contributors","subscribers_url":"https://api.github.com/repos/davisjam/node/subscribers","subscription_url":"https://api.github.com/repos/davisjam/node/subscription","commits_url":"https://api.github.com/repos/davisjam/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/davisjam/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/davisjam/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/davisjam/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/davisjam/node/contents/{+path}","compare_url":"https://api.github.com/repos/davisjam/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davisjam/node/merges","archive_url":"https://api.github.com/repos/davisjam/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davisjam/node/downloads","issues_url":"https://api.github.com/repos/davisjam/node/issues{/number}","pulls_url":"https://api.github.com/repos/davisjam/node/pulls{/number}","milestones_url":"https://api.github.com/repos/davisjam/node/milestones{/number}","notifications_url":"https://api.github.com/repos/davisjam/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davisjam/node/labels{/name}","releases_url":"https://api.github.com/repos/davisjam/node/releases{/id}","deployments_url":"https://api.github.com/repos/davisjam/node/deployments","created_at":"2017-05-08T16:29:52Z","updated_at":"2018-06-09T18:37:22Z","pushed_at":"2018-06-15T03:32:31Z","git_url":"git://github.com/davisjam/node.git","ssh_url":"git@github.com:davisjam/node.git","clone_url":"https://github.com/davisjam/node.git","svn_url":"https://github.com/davisjam/node","homepage":"https://nodejs.org","size":363476,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"baadc7ade3184560c5fbffe0be6c2446541936f5","user":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"node_id":"MDEwOlJlcG9zaXRvcnkyNzE5Mzc3OQ==","name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-06-15T03:27:56Z","pushed_at":"2018-06-15T03:32:35Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":384993,"stargazers_count":50299,"watchers_count":50299,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10567,"mirror_url":null,"archived":false,"open_issues_count":717,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":10567,"open_issues":717,"watchers":50299,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/21234"},"html":{"href":"https://github.com/nodejs/node/pull/21234"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/21234"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/21234/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/21234/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/21234/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/217acc416e28b4a1d82f3bd012ad7fb0bfc2982d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"davisjam"}}