{"action":"created","issue":{"url":"https://api.github.com/repos/ExpeditionRPG/expedition-app/issues/718","repository_url":"https://api.github.com/repos/ExpeditionRPG/expedition-app","labels_url":"https://api.github.com/repos/ExpeditionRPG/expedition-app/issues/718/labels{/name}","comments_url":"https://api.github.com/repos/ExpeditionRPG/expedition-app/issues/718/comments","events_url":"https://api.github.com/repos/ExpeditionRPG/expedition-app/issues/718/events","html_url":"https://github.com/ExpeditionRPG/expedition-app/issues/718","id":328339344,"node_id":"MDU6SXNzdWUzMjgzMzkzNDQ=","number":718,"title":"Add spinner to quest search ","user":{"login":"smartin015","id":607666,"node_id":"MDQ6VXNlcjYwNzY2Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/607666?v=4","gravatar_id":"","url":"https://api.github.com/users/smartin015","html_url":"https://github.com/smartin015","followers_url":"https://api.github.com/users/smartin015/followers","following_url":"https://api.github.com/users/smartin015/following{/other_user}","gists_url":"https://api.github.com/users/smartin015/gists{/gist_id}","starred_url":"https://api.github.com/users/smartin015/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartin015/subscriptions","organizations_url":"https://api.github.com/users/smartin015/orgs","repos_url":"https://api.github.com/users/smartin015/repos","events_url":"https://api.github.com/users/smartin015/events{/privacy}","received_events_url":"https://api.github.com/users/smartin015/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-06-01T00:18:46Z","updated_at":"2018-06-16T15:38:58Z","closed_at":null,"author_association":"COLLABORATOR","body":"Should move to the next card the moment the search button has been pressed, and show a spinner until the results have been received. Otherwise it feels like the UI is slow - even to the point of feeling like the app has crashed on a slow connection.\r\n\r\nNote that this can happen both from the filters page (if you were logged out or you change the filters) and from the main menu -> search (if you're already logged in)"},"comment":{"url":"https://api.github.com/repos/ExpeditionRPG/expedition-app/issues/comments/397820409","html_url":"https://github.com/ExpeditionRPG/expedition-app/issues/718#issuecomment-397820409","issue_url":"https://api.github.com/repos/ExpeditionRPG/expedition-app/issues/718","id":397820409,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NzgyMDQwOQ==","user":{"login":"ezittel","id":16277302,"node_id":"MDQ6VXNlcjE2Mjc3MzAy","avatar_url":"https://avatars0.githubusercontent.com/u/16277302?v=4","gravatar_id":"","url":"https://api.github.com/users/ezittel","html_url":"https://github.com/ezittel","followers_url":"https://api.github.com/users/ezittel/followers","following_url":"https://api.github.com/users/ezittel/following{/other_user}","gists_url":"https://api.github.com/users/ezittel/gists{/gist_id}","starred_url":"https://api.github.com/users/ezittel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezittel/subscriptions","organizations_url":"https://api.github.com/users/ezittel/orgs","repos_url":"https://api.github.com/users/ezittel/repos","events_url":"https://api.github.com/users/ezittel/events{/privacy}","received_events_url":"https://api.github.com/users/ezittel/received_events","type":"User","site_admin":false},"created_at":"2018-06-16T15:38:58Z","updated_at":"2018-06-16T15:38:58Z","author_association":"CONTRIBUTOR","body":"` {results.length === 0 && props.searching && <div className=\"lds-ellipsis\"><div></div><div></div><div></div><div></div></div>}`\r\n\r\n(I wondered what that did, now I'm understanding what this is for)\r\nWe're waiting for the asynchronous call to complete.  \r\nUntil it does, show \"...\"\r\nThen show results.\r\n\r\nSo this is saying:\r\nif the results.length is null or 0...\r\n\r\nbut we want:\r\nWHILE the results.length is still null or 0...\r\n\r\nSo is it possible to refactor this as a promise, and is that even the right concept to be using?\r\nThere is also the onUnmount() event in the component I saw being leveraged, something like this:\r\nhttps://stackoverflow.com/questions/36985738/how-to-unmount-unrender-or-remove-a-component-from-itself-in-react\r\n\r\n"}}
{"actor":{"display_login":"ezittel"}}