{"action":"created","comment":{"url":"https://api.github.com/repos/jaegertracing/jaeger/pulls/comments/223820151","pull_request_review_id":163041771,"id":223820151,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzgyMDE1MQ==","diff_hunk":"@@ -57,12 +57,12 @@ func TestRateLimiterNoLimit(t *testing.T) {\n \tr := newRateLimiter(creditsPerSecond)\n \tdefer r.Stop()\n \n-\tconst maxInterval = time.Microsecond\n+\tconst maxInterval = time.Millisecond\n \tacquireStart := time.Now()\n \tfor i := 0; i < iterations; i++ {","path":"cmd/ingester/app/consumer/rate_limiter_test.go","position":62,"original_position":7,"commit_id":"1c1befc300bfbe76e8164de0deaddfec87add18c","original_commit_id":"1c1befc300bfbe76e8164de0deaddfec87add18c","user":{"login":"isaachier","id":2578297,"node_id":"MDQ6VXNlcjI1NzgyOTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2578297?v=4","gravatar_id":"","url":"https://api.github.com/users/isaachier","html_url":"https://github.com/isaachier","followers_url":"https://api.github.com/users/isaachier/followers","following_url":"https://api.github.com/users/isaachier/following{/other_user}","gists_url":"https://api.github.com/users/isaachier/gists{/gist_id}","starred_url":"https://api.github.com/users/isaachier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaachier/subscriptions","organizations_url":"https://api.github.com/users/isaachier/orgs","repos_url":"https://api.github.com/users/isaachier/repos","events_url":"https://api.github.com/users/isaachier/events{/privacy}","received_events_url":"https://api.github.com/users/isaachier/received_events","type":"User","site_admin":false},"body":"Good catch. Guess I missed the most important line here.","created_at":"2018-10-09T18:47:36Z","updated_at":"2018-10-09T18:47:36Z","html_url":"https://github.com/jaegertracing/jaeger/pull/1101#discussion_r223820151","pull_request_url":"https://api.github.com/repos/jaegertracing/jaeger/pulls/1101","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/jaegertracing/jaeger/pulls/comments/223820151"},"html":{"href":"https://github.com/jaegertracing/jaeger/pull/1101#discussion_r223820151"},"pull_request":{"href":"https://api.github.com/repos/jaegertracing/jaeger/pulls/1101"}},"in_reply_to_id":223805419},"pull_request":{"url":"https://api.github.com/repos/jaegertracing/jaeger/pulls/1101","id":220471209,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNDcxMjA5","html_url":"https://github.com/jaegertracing/jaeger/pull/1101","diff_url":"https://github.com/jaegertracing/jaeger/pull/1101.diff","patch_url":"https://github.com/jaegertracing/jaeger/pull/1101.patch","issue_url":"https://api.github.com/repos/jaegertracing/jaeger/issues/1101","number":1101,"state":"open","locked":false,"title":"Add rate limiting to Kafka ingester","user":{"login":"isaachier","id":2578297,"node_id":"MDQ6VXNlcjI1NzgyOTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2578297?v=4","gravatar_id":"","url":"https://api.github.com/users/isaachier","html_url":"https://github.com/isaachier","followers_url":"https://api.github.com/users/isaachier/followers","following_url":"https://api.github.com/users/isaachier/following{/other_user}","gists_url":"https://api.github.com/users/isaachier/gists{/gist_id}","starred_url":"https://api.github.com/users/isaachier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaachier/subscriptions","organizations_url":"https://api.github.com/users/isaachier/orgs","repos_url":"https://api.github.com/users/isaachier/repos","events_url":"https://api.github.com/users/isaachier/events{/privacy}","received_events_url":"https://api.github.com/users/isaachier/received_events","type":"User","site_admin":false},"body":"<!--\nWe appreciate your contribution to the Jaeger project! 👋🎉\n\nBefore creating a pull request, please make sure:\n- Your PR is solving one problem\n- You have read the guide for contributing\n  - See https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING.md\n- You signed all your commits (otherwise we won't be able to merge the PR)\n  - See https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING.md#sign-your-work\n- You added unit tests for the new functionality\n- You mention in the PR description which issue it is addressing, e.g. \"Resolves #123\"\n-->\n\n- Resolves #1100.\n\n- Add rate-limiting channel to Kafka ingester.\n- Fix typo in consumer.","created_at":"2018-10-04T18:17:43Z","updated_at":"2018-10-09T18:47:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e77883e8e1fa31485c2e09424331fd7bf87321db","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jpkrohling","id":13387,"node_id":"MDQ6VXNlcjEzMzg3","avatar_url":"https://avatars2.githubusercontent.com/u/13387?v=4","gravatar_id":"","url":"https://api.github.com/users/jpkrohling","html_url":"https://github.com/jpkrohling","followers_url":"https://api.github.com/users/jpkrohling/followers","following_url":"https://api.github.com/users/jpkrohling/following{/other_user}","gists_url":"https://api.github.com/users/jpkrohling/gists{/gist_id}","starred_url":"https://api.github.com/users/jpkrohling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpkrohling/subscriptions","organizations_url":"https://api.github.com/users/jpkrohling/orgs","repos_url":"https://api.github.com/users/jpkrohling/repos","events_url":"https://api.github.com/users/jpkrohling/events{/privacy}","received_events_url":"https://api.github.com/users/jpkrohling/received_events","type":"User","site_admin":false},{"login":"pavolloffay","id":5618424,"node_id":"MDQ6VXNlcjU2MTg0MjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/5618424?v=4","gravatar_id":"","url":"https://api.github.com/users/pavolloffay","html_url":"https://github.com/pavolloffay","followers_url":"https://api.github.com/users/pavolloffay/followers","following_url":"https://api.github.com/users/pavolloffay/following{/other_user}","gists_url":"https://api.github.com/users/pavolloffay/gists{/gist_id}","starred_url":"https://api.github.com/users/pavolloffay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavolloffay/subscriptions","organizations_url":"https://api.github.com/users/pavolloffay/orgs","repos_url":"https://api.github.com/users/pavolloffay/repos","events_url":"https://api.github.com/users/pavolloffay/events{/privacy}","received_events_url":"https://api.github.com/users/pavolloffay/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jaegertracing/jaeger/pulls/1101/commits","review_comments_url":"https://api.github.com/repos/jaegertracing/jaeger/pulls/1101/comments","review_comment_url":"https://api.github.com/repos/jaegertracing/jaeger/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jaegertracing/jaeger/issues/1101/comments","statuses_url":"https://api.github.com/repos/jaegertracing/jaeger/statuses/1c1befc300bfbe76e8164de0deaddfec87add18c","head":{"label":"isaachier:ingester-rate-limit","ref":"ingester-rate-limit","sha":"1c1befc300bfbe76e8164de0deaddfec87add18c","user":{"login":"isaachier","id":2578297,"node_id":"MDQ6VXNlcjI1NzgyOTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2578297?v=4","gravatar_id":"","url":"https://api.github.com/users/isaachier","html_url":"https://github.com/isaachier","followers_url":"https://api.github.com/users/isaachier/followers","following_url":"https://api.github.com/users/isaachier/following{/other_user}","gists_url":"https://api.github.com/users/isaachier/gists{/gist_id}","starred_url":"https://api.github.com/users/isaachier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaachier/subscriptions","organizations_url":"https://api.github.com/users/isaachier/orgs","repos_url":"https://api.github.com/users/isaachier/repos","events_url":"https://api.github.com/users/isaachier/events{/privacy}","received_events_url":"https://api.github.com/users/isaachier/received_events","type":"User","site_admin":false},"repo":{"id":99865999,"node_id":"MDEwOlJlcG9zaXRvcnk5OTg2NTk5OQ==","name":"jaeger","full_name":"isaachier/jaeger","private":false,"owner":{"login":"isaachier","id":2578297,"node_id":"MDQ6VXNlcjI1NzgyOTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2578297?v=4","gravatar_id":"","url":"https://api.github.com/users/isaachier","html_url":"https://github.com/isaachier","followers_url":"https://api.github.com/users/isaachier/followers","following_url":"https://api.github.com/users/isaachier/following{/other_user}","gists_url":"https://api.github.com/users/isaachier/gists{/gist_id}","starred_url":"https://api.github.com/users/isaachier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaachier/subscriptions","organizations_url":"https://api.github.com/users/isaachier/orgs","repos_url":"https://api.github.com/users/isaachier/repos","events_url":"https://api.github.com/users/isaachier/events{/privacy}","received_events_url":"https://api.github.com/users/isaachier/received_events","type":"User","site_admin":false},"html_url":"https://github.com/isaachier/jaeger","description":"Jaeger, a Distributed Tracing System","fork":true,"url":"https://api.github.com/repos/isaachier/jaeger","forks_url":"https://api.github.com/repos/isaachier/jaeger/forks","keys_url":"https://api.github.com/repos/isaachier/jaeger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/isaachier/jaeger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/isaachier/jaeger/teams","hooks_url":"https://api.github.com/repos/isaachier/jaeger/hooks","issue_events_url":"https://api.github.com/repos/isaachier/jaeger/issues/events{/number}","events_url":"https://api.github.com/repos/isaachier/jaeger/events","assignees_url":"https://api.github.com/repos/isaachier/jaeger/assignees{/user}","branches_url":"https://api.github.com/repos/isaachier/jaeger/branches{/branch}","tags_url":"https://api.github.com/repos/isaachier/jaeger/tags","blobs_url":"https://api.github.com/repos/isaachier/jaeger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/isaachier/jaeger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/isaachier/jaeger/git/refs{/sha}","trees_url":"https://api.github.com/repos/isaachier/jaeger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/isaachier/jaeger/statuses/{sha}","languages_url":"https://api.github.com/repos/isaachier/jaeger/languages","stargazers_url":"https://api.github.com/repos/isaachier/jaeger/stargazers","contributors_url":"https://api.github.com/repos/isaachier/jaeger/contributors","subscribers_url":"https://api.github.com/repos/isaachier/jaeger/subscribers","subscription_url":"https://api.github.com/repos/isaachier/jaeger/subscription","commits_url":"https://api.github.com/repos/isaachier/jaeger/commits{/sha}","git_commits_url":"https://api.github.com/repos/isaachier/jaeger/git/commits{/sha}","comments_url":"https://api.github.com/repos/isaachier/jaeger/comments{/number}","issue_comment_url":"https://api.github.com/repos/isaachier/jaeger/issues/comments{/number}","contents_url":"https://api.github.com/repos/isaachier/jaeger/contents/{+path}","compare_url":"https://api.github.com/repos/isaachier/jaeger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/isaachier/jaeger/merges","archive_url":"https://api.github.com/repos/isaachier/jaeger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/isaachier/jaeger/downloads","issues_url":"https://api.github.com/repos/isaachier/jaeger/issues{/number}","pulls_url":"https://api.github.com/repos/isaachier/jaeger/pulls{/number}","milestones_url":"https://api.github.com/repos/isaachier/jaeger/milestones{/number}","notifications_url":"https://api.github.com/repos/isaachier/jaeger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/isaachier/jaeger/labels{/name}","releases_url":"https://api.github.com/repos/isaachier/jaeger/releases{/id}","deployments_url":"https://api.github.com/repos/isaachier/jaeger/deployments","created_at":"2017-08-10T01:05:50Z","updated_at":"2018-10-09T16:43:10Z","pushed_at":"2018-10-09T17:17:03Z","git_url":"git://github.com/isaachier/jaeger.git","ssh_url":"git@github.com:isaachier/jaeger.git","clone_url":"https://github.com/isaachier/jaeger.git","svn_url":"https://github.com/isaachier/jaeger","homepage":"http://uber.github.io/jaeger/","size":17097,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jaegertracing:master","ref":"master","sha":"7105fa95ed88a94c9a2bd4414946ac38f13dd456","user":{"login":"jaegertracing","id":28545596,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTQ1NTk2","avatar_url":"https://avatars1.githubusercontent.com/u/28545596?v=4","gravatar_id":"","url":"https://api.github.com/users/jaegertracing","html_url":"https://github.com/jaegertracing","followers_url":"https://api.github.com/users/jaegertracing/followers","following_url":"https://api.github.com/users/jaegertracing/following{/other_user}","gists_url":"https://api.github.com/users/jaegertracing/gists{/gist_id}","starred_url":"https://api.github.com/users/jaegertracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaegertracing/subscriptions","organizations_url":"https://api.github.com/users/jaegertracing/orgs","repos_url":"https://api.github.com/users/jaegertracing/repos","events_url":"https://api.github.com/users/jaegertracing/events{/privacy}","received_events_url":"https://api.github.com/users/jaegertracing/received_events","type":"Organization","site_admin":false},"repo":{"id":56342508,"node_id":"MDEwOlJlcG9zaXRvcnk1NjM0MjUwOA==","name":"jaeger","full_name":"jaegertracing/jaeger","private":false,"owner":{"login":"jaegertracing","id":28545596,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTQ1NTk2","avatar_url":"https://avatars1.githubusercontent.com/u/28545596?v=4","gravatar_id":"","url":"https://api.github.com/users/jaegertracing","html_url":"https://github.com/jaegertracing","followers_url":"https://api.github.com/users/jaegertracing/followers","following_url":"https://api.github.com/users/jaegertracing/following{/other_user}","gists_url":"https://api.github.com/users/jaegertracing/gists{/gist_id}","starred_url":"https://api.github.com/users/jaegertracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaegertracing/subscriptions","organizations_url":"https://api.github.com/users/jaegertracing/orgs","repos_url":"https://api.github.com/users/jaegertracing/repos","events_url":"https://api.github.com/users/jaegertracing/events{/privacy}","received_events_url":"https://api.github.com/users/jaegertracing/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/jaegertracing/jaeger","description":"CNCF Jaeger, a Distributed Tracing System","fork":false,"url":"https://api.github.com/repos/jaegertracing/jaeger","forks_url":"https://api.github.com/repos/jaegertracing/jaeger/forks","keys_url":"https://api.github.com/repos/jaegertracing/jaeger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jaegertracing/jaeger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jaegertracing/jaeger/teams","hooks_url":"https://api.github.com/repos/jaegertracing/jaeger/hooks","issue_events_url":"https://api.github.com/repos/jaegertracing/jaeger/issues/events{/number}","events_url":"https://api.github.com/repos/jaegertracing/jaeger/events","assignees_url":"https://api.github.com/repos/jaegertracing/jaeger/assignees{/user}","branches_url":"https://api.github.com/repos/jaegertracing/jaeger/branches{/branch}","tags_url":"https://api.github.com/repos/jaegertracing/jaeger/tags","blobs_url":"https://api.github.com/repos/jaegertracing/jaeger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jaegertracing/jaeger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jaegertracing/jaeger/git/refs{/sha}","trees_url":"https://api.github.com/repos/jaegertracing/jaeger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jaegertracing/jaeger/statuses/{sha}","languages_url":"https://api.github.com/repos/jaegertracing/jaeger/languages","stargazers_url":"https://api.github.com/repos/jaegertracing/jaeger/stargazers","contributors_url":"https://api.github.com/repos/jaegertracing/jaeger/contributors","subscribers_url":"https://api.github.com/repos/jaegertracing/jaeger/subscribers","subscription_url":"https://api.github.com/repos/jaegertracing/jaeger/subscription","commits_url":"https://api.github.com/repos/jaegertracing/jaeger/commits{/sha}","git_commits_url":"https://api.github.com/repos/jaegertracing/jaeger/git/commits{/sha}","comments_url":"https://api.github.com/repos/jaegertracing/jaeger/comments{/number}","issue_comment_url":"https://api.github.com/repos/jaegertracing/jaeger/issues/comments{/number}","contents_url":"https://api.github.com/repos/jaegertracing/jaeger/contents/{+path}","compare_url":"https://api.github.com/repos/jaegertracing/jaeger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jaegertracing/jaeger/merges","archive_url":"https://api.github.com/repos/jaegertracing/jaeger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jaegertracing/jaeger/downloads","issues_url":"https://api.github.com/repos/jaegertracing/jaeger/issues{/number}","pulls_url":"https://api.github.com/repos/jaegertracing/jaeger/pulls{/number}","milestones_url":"https://api.github.com/repos/jaegertracing/jaeger/milestones{/number}","notifications_url":"https://api.github.com/repos/jaegertracing/jaeger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jaegertracing/jaeger/labels{/name}","releases_url":"https://api.github.com/repos/jaegertracing/jaeger/releases{/id}","deployments_url":"https://api.github.com/repos/jaegertracing/jaeger/deployments","created_at":"2016-04-15T18:49:02Z","updated_at":"2018-10-09T17:32:24Z","pushed_at":"2018-10-09T17:17:05Z","git_url":"git://github.com/jaegertracing/jaeger.git","ssh_url":"git@github.com:jaegertracing/jaeger.git","clone_url":"https://github.com/jaegertracing/jaeger.git","svn_url":"https://github.com/jaegertracing/jaeger","homepage":"https://jaegertracing.io/","size":17201,"stargazers_count":5983,"watchers_count":5983,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":518,"mirror_url":null,"archived":false,"open_issues_count":245,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":518,"open_issues":245,"watchers":5983,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jaegertracing/jaeger/pulls/1101"},"html":{"href":"https://github.com/jaegertracing/jaeger/pull/1101"},"issue":{"href":"https://api.github.com/repos/jaegertracing/jaeger/issues/1101"},"comments":{"href":"https://api.github.com/repos/jaegertracing/jaeger/issues/1101/comments"},"review_comments":{"href":"https://api.github.com/repos/jaegertracing/jaeger/pulls/1101/comments"},"review_comment":{"href":"https://api.github.com/repos/jaegertracing/jaeger/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jaegertracing/jaeger/pulls/1101/commits"},"statuses":{"href":"https://api.github.com/repos/jaegertracing/jaeger/statuses/1c1befc300bfbe76e8164de0deaddfec87add18c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"isaachier"}}