{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/231527126","pull_request_review_id":172510191,"id":231527126,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTUyNzEyNg==","diff_hunk":"@@ -0,0 +1,18 @@\n+// Copyright 2018 The Rust Project Developers. See the COPYRIGHT\n+// file at the top-level directory of this distribution and at\n+// http://rust-lang.org/COPYRIGHT.\n+//\n+// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or\n+// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license\n+// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your\n+// option. This file may not be copied, modified, or distributed\n+// except according to those terms.\n+\n+#![feature(trait_alias)]\n+\n+trait I32Iterator = Iterator<Item = i32>;\n+trait I32Iterator2 = I32Iterator<Item = i32>; //~ ERROR E0719","path":"src/test/ui/error-codes/E0719-trait-alias.rs","position":14,"original_position":14,"commit_id":"c4a63903815baec47010d9011d69b2a3f271cf8d","original_commit_id":"c4a63903815baec47010d9011d69b2a3f271cf8d","user":{"login":"scalexm","id":1173131,"node_id":"MDQ6VXNlcjExNzMxMzE=","avatar_url":"https://avatars1.githubusercontent.com/u/1173131?v=4","gravatar_id":"","url":"https://api.github.com/users/scalexm","html_url":"https://github.com/scalexm","followers_url":"https://api.github.com/users/scalexm/followers","following_url":"https://api.github.com/users/scalexm/following{/other_user}","gists_url":"https://api.github.com/users/scalexm/gists{/gist_id}","starred_url":"https://api.github.com/users/scalexm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalexm/subscriptions","organizations_url":"https://api.github.com/users/scalexm/orgs","repos_url":"https://api.github.com/users/scalexm/repos","events_url":"https://api.github.com/users/scalexm/events{/privacy}","received_events_url":"https://api.github.com/users/scalexm/received_events","type":"User","site_admin":false},"body":"This one and the one below shouldn't be treated as errors (at least for now) as we discussed.","created_at":"2018-11-07T14:33:20Z","updated_at":"2018-11-07T14:36:31Z","html_url":"https://github.com/rust-lang/rust/pull/55687#discussion_r231527126","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/55687","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/231527126"},"html":{"href":"https://github.com/rust-lang/rust/pull/55687#discussion_r231527126"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/55687"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/55687","id":228232585,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MjMyNTg1","html_url":"https://github.com/rust-lang/rust/pull/55687","diff_url":"https://github.com/rust-lang/rust/pull/55687.diff","patch_url":"https://github.com/rust-lang/rust/pull/55687.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/55687","number":55687,"state":"open","locked":false,"title":"Take supertraits into account when calculating associated types","user":{"login":"alexreg","id":67036,"node_id":"MDQ6VXNlcjY3MDM2","avatar_url":"https://avatars3.githubusercontent.com/u/67036?v=4","gravatar_id":"","url":"https://api.github.com/users/alexreg","html_url":"https://github.com/alexreg","followers_url":"https://api.github.com/users/alexreg/followers","following_url":"https://api.github.com/users/alexreg/following{/other_user}","gists_url":"https://api.github.com/users/alexreg/gists{/gist_id}","starred_url":"https://api.github.com/users/alexreg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexreg/subscriptions","organizations_url":"https://api.github.com/users/alexreg/orgs","repos_url":"https://api.github.com/users/alexreg/repos","events_url":"https://api.github.com/users/alexreg/events{/privacy}","received_events_url":"https://api.github.com/users/alexreg/received_events","type":"User","site_admin":false},"body":"Fixes #24010 and #23856. Applies to trait aliases too.\n\nAs a by-product, this PR also makes repeated bindings of the same associated item in the same definition a hard error. This was previously a warning with a note about it becoming a hard error in the future. See #50589 for more info.\n\nI talked about this with @nikomatsakis recently, but only very superficially, so this shouldn't stop anyone from assigning it to themself to review and r+.\n\nN.B. The \"WIP\" commits represent imperfect attempts to solve the problem just for trait objects, but I've left them in for reference for the sake of whomever is reviewing this.\n\nCC @carllerche @theemathas @durka @mbrubeck","created_at":"2018-11-05T03:37:49Z","updated_at":"2018-11-07T14:36:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b4a9425d0f166fb996e391937911a904c29578eb","assignee":{"login":"nikomatsakis","id":155238,"node_id":"MDQ6VXNlcjE1NTIzOA==","avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"assignees":[{"login":"nikomatsakis","id":155238,"node_id":"MDQ6VXNlcjE1NTIzOA==","avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":281249002,"node_id":"MDU6TGFiZWwyODEyNDkwMDI=","url":"https://api.github.com/repos/rust-lang/rust/labels/S-waiting-on-crater","name":"S-waiting-on-crater","color":"c2cccc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/55687/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/55687/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/55687/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/c4a63903815baec47010d9011d69b2a3f271cf8d","head":{"label":"alexreg:fix-24010","ref":"fix-24010","sha":"c4a63903815baec47010d9011d69b2a3f271cf8d","user":{"login":"alexreg","id":67036,"node_id":"MDQ6VXNlcjY3MDM2","avatar_url":"https://avatars3.githubusercontent.com/u/67036?v=4","gravatar_id":"","url":"https://api.github.com/users/alexreg","html_url":"https://github.com/alexreg","followers_url":"https://api.github.com/users/alexreg/followers","following_url":"https://api.github.com/users/alexreg/following{/other_user}","gists_url":"https://api.github.com/users/alexreg/gists{/gist_id}","starred_url":"https://api.github.com/users/alexreg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexreg/subscriptions","organizations_url":"https://api.github.com/users/alexreg/orgs","repos_url":"https://api.github.com/users/alexreg/repos","events_url":"https://api.github.com/users/alexreg/events{/privacy}","received_events_url":"https://api.github.com/users/alexreg/received_events","type":"User","site_admin":false},"repo":{"id":115889469,"node_id":"MDEwOlJlcG9zaXRvcnkxMTU4ODk0Njk=","name":"rust","full_name":"alexreg/rust","private":false,"owner":{"login":"alexreg","id":67036,"node_id":"MDQ6VXNlcjY3MDM2","avatar_url":"https://avatars3.githubusercontent.com/u/67036?v=4","gravatar_id":"","url":"https://api.github.com/users/alexreg","html_url":"https://github.com/alexreg","followers_url":"https://api.github.com/users/alexreg/followers","following_url":"https://api.github.com/users/alexreg/following{/other_user}","gists_url":"https://api.github.com/users/alexreg/gists{/gist_id}","starred_url":"https://api.github.com/users/alexreg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexreg/subscriptions","organizations_url":"https://api.github.com/users/alexreg/orgs","repos_url":"https://api.github.com/users/alexreg/repos","events_url":"https://api.github.com/users/alexreg/events{/privacy}","received_events_url":"https://api.github.com/users/alexreg/received_events","type":"User","site_admin":false},"html_url":"https://github.com/alexreg/rust","description":"A safe, concurrent, practical language.","fork":true,"url":"https://api.github.com/repos/alexreg/rust","forks_url":"https://api.github.com/repos/alexreg/rust/forks","keys_url":"https://api.github.com/repos/alexreg/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexreg/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexreg/rust/teams","hooks_url":"https://api.github.com/repos/alexreg/rust/hooks","issue_events_url":"https://api.github.com/repos/alexreg/rust/issues/events{/number}","events_url":"https://api.github.com/repos/alexreg/rust/events","assignees_url":"https://api.github.com/repos/alexreg/rust/assignees{/user}","branches_url":"https://api.github.com/repos/alexreg/rust/branches{/branch}","tags_url":"https://api.github.com/repos/alexreg/rust/tags","blobs_url":"https://api.github.com/repos/alexreg/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexreg/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexreg/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexreg/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexreg/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/alexreg/rust/languages","stargazers_url":"https://api.github.com/repos/alexreg/rust/stargazers","contributors_url":"https://api.github.com/repos/alexreg/rust/contributors","subscribers_url":"https://api.github.com/repos/alexreg/rust/subscribers","subscription_url":"https://api.github.com/repos/alexreg/rust/subscription","commits_url":"https://api.github.com/repos/alexreg/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexreg/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexreg/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexreg/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexreg/rust/contents/{+path}","compare_url":"https://api.github.com/repos/alexreg/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexreg/rust/merges","archive_url":"https://api.github.com/repos/alexreg/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexreg/rust/downloads","issues_url":"https://api.github.com/repos/alexreg/rust/issues{/number}","pulls_url":"https://api.github.com/repos/alexreg/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/alexreg/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/alexreg/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexreg/rust/labels{/name}","releases_url":"https://api.github.com/repos/alexreg/rust/releases{/id}","deployments_url":"https://api.github.com/repos/alexreg/rust/deployments","created_at":"2017-12-31T23:10:36Z","updated_at":"2017-12-31T23:10:58Z","pushed_at":"2018-11-07T00:17:54Z","git_url":"git://github.com/alexreg/rust.git","ssh_url":"git@github.com:alexreg/rust.git","clone_url":"https://github.com/alexreg/rust.git","svn_url":"https://github.com/alexreg/rust","homepage":"https://www.rust-lang.org","size":400934,"stargazers_count":1,"watchers_count":1,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"15d770400eed9018f18bddf83dd65cb7789280a5","user":{"login":"rust-lang","id":5430905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MzA5MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"node_id":"MDEwOlJlcG9zaXRvcnk3MjQ3MTI=","name":"rust","full_name":"rust-lang/rust","private":false,"owner":{"login":"rust-lang","id":5430905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MzA5MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2018-11-07T14:25:21Z","pushed_at":"2018-11-07T14:35:42Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":402094,"stargazers_count":31571,"watchers_count":31571,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5273,"mirror_url":null,"archived":false,"open_issues_count":4530,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5273,"open_issues":4530,"watchers":31571,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/55687"},"html":{"href":"https://github.com/rust-lang/rust/pull/55687"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/55687"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/55687/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/55687/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/55687/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/c4a63903815baec47010d9011d69b2a3f271cf8d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"scalexm"}}