{"action":"created","issue":{"url":"https://api.github.com/repos/ReactiveX/RxSwift/issues/1783","repository_url":"https://api.github.com/repos/ReactiveX/RxSwift","labels_url":"https://api.github.com/repos/ReactiveX/RxSwift/issues/1783/labels{/name}","comments_url":"https://api.github.com/repos/ReactiveX/RxSwift/issues/1783/comments","events_url":"https://api.github.com/repos/ReactiveX/RxSwift/issues/1783/events","html_url":"https://github.com/ReactiveX/RxSwift/pull/1783","id":374685012,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MzIxMjM0","number":1783,"title":"Add takeUntil(_ predicate:) and takeUntil(_ element:)","user":{"login":"freak4pc","id":605076,"node_id":"MDQ6VXNlcjYwNTA3Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/605076?v=4","gravatar_id":"","url":"https://api.github.com/users/freak4pc","html_url":"https://github.com/freak4pc","followers_url":"https://api.github.com/users/freak4pc/followers","following_url":"https://api.github.com/users/freak4pc/following{/other_user}","gists_url":"https://api.github.com/users/freak4pc/gists{/gist_id}","starred_url":"https://api.github.com/users/freak4pc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freak4pc/subscriptions","organizations_url":"https://api.github.com/users/freak4pc/orgs","repos_url":"https://api.github.com/users/freak4pc/repos","events_url":"https://api.github.com/users/freak4pc/events{/privacy}","received_events_url":"https://api.github.com/users/freak4pc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-10-27T20:22:44Z","updated_at":"2018-12-26T21:07:45Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/ReactiveX/RxSwift/pulls/1783","html_url":"https://github.com/ReactiveX/RxSwift/pull/1783","diff_url":"https://github.com/ReactiveX/RxSwift/pull/1783.diff","patch_url":"https://github.com/ReactiveX/RxSwift/pull/1783.patch"},"body":"The first variation - `takeUntil(_ predicate:)` - is the inverse of `takeWhile(_ predicate:)`. \r\n\r\nIn RxJava, and other implementations, `takeUntil(predicate:)` is one of the most popular usages of this operator (compared to the `takeUntil(secondObservable)` variation) and I feel I always have to \"flip around terms\" (or use different terminology compared to android co-workers). I usually wouldn't bother adding operators just for the sake of alignment but in this case I think its quite valuable. \r\n\r\nThe second version - `takeUntil(_ element:)` is simply syntactic sugar but I think it's quite helpful. I'm not religious to having it but I think it's an extremely common use case. \r\n\r\nAppreciate any opinions / thoughts :) "},"comment":{"url":"https://api.github.com/repos/ReactiveX/RxSwift/issues/comments/450026530","html_url":"https://github.com/ReactiveX/RxSwift/pull/1783#issuecomment-450026530","issue_url":"https://api.github.com/repos/ReactiveX/RxSwift/issues/1783","id":450026530,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDAyNjUzMA==","user":{"login":"freak4pc","id":605076,"node_id":"MDQ6VXNlcjYwNTA3Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/605076?v=4","gravatar_id":"","url":"https://api.github.com/users/freak4pc","html_url":"https://github.com/freak4pc","followers_url":"https://api.github.com/users/freak4pc/followers","following_url":"https://api.github.com/users/freak4pc/following{/other_user}","gists_url":"https://api.github.com/users/freak4pc/gists{/gist_id}","starred_url":"https://api.github.com/users/freak4pc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freak4pc/subscriptions","organizations_url":"https://api.github.com/users/freak4pc/orgs","repos_url":"https://api.github.com/users/freak4pc/repos","events_url":"https://api.github.com/users/freak4pc/events{/privacy}","received_events_url":"https://api.github.com/users/freak4pc/received_events","type":"User","site_admin":false},"created_at":"2018-12-26T21:07:45Z","updated_at":"2018-12-26T21:07:45Z","author_association":"COLLABORATOR","body":"Hey @kzaher - Thanks for taking a look.\r\n\r\n@yikuo123 is correct. My initial thought was using an inverted version of `takeWhile` - but that one is exclusive of the last element, and this one is inclusive which is extremely important. \r\n\r\nLet me know your thoughts :) "}}
{"actor":{"display_login":"freak4pc"}}