{"action":"created","comment":{"url":"https://api.github.com/repos/helm/charts/pulls/comments/229865263","pull_request_review_id":170469207,"id":229865263,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTg2NTI2Mw==","diff_hunk":"@@ -0,0 +1,52 @@\n+apiVersion: apps/v1beta2\n+kind: DaemonSet\n+metadata:\n+  name: {{ template \"kube-ingress-aws-controller.fullname\" . }}\n+  labels:\n+    app: {{ template \"kube-ingress-aws-controller.name\" . }}\n+    chart: {{ template \"kube-ingress-aws-controller.chart\" . }}\n+    heritage: {{ .Release.Service }}\n+    release: {{ .Release.Name }}","path":"stable/kube-ingress-aws-controller/templates/daemonset.yaml","position":9,"original_position":9,"commit_id":"22bfacaa15a60c2dc73d05efe325630f661c8dc7","original_commit_id":"d223e6bcef45f2fdc73a02df7ebc98cc8c0e2d5f","user":{"login":"julianxhokaxhiu","id":1237070,"node_id":"MDQ6VXNlcjEyMzcwNzA=","avatar_url":"https://avatars2.githubusercontent.com/u/1237070?v=4","gravatar_id":"","url":"https://api.github.com/users/julianxhokaxhiu","html_url":"https://github.com/julianxhokaxhiu","followers_url":"https://api.github.com/users/julianxhokaxhiu/followers","following_url":"https://api.github.com/users/julianxhokaxhiu/following{/other_user}","gists_url":"https://api.github.com/users/julianxhokaxhiu/gists{/gist_id}","starred_url":"https://api.github.com/users/julianxhokaxhiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julianxhokaxhiu/subscriptions","organizations_url":"https://api.github.com/users/julianxhokaxhiu/orgs","repos_url":"https://api.github.com/users/julianxhokaxhiu/repos","events_url":"https://api.github.com/users/julianxhokaxhiu/events{/privacy}","received_events_url":"https://api.github.com/users/julianxhokaxhiu/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2018-10-31T20:57:10Z","updated_at":"2018-10-31T20:57:10Z","html_url":"https://github.com/helm/charts/pull/4538#discussion_r229865263","pull_request_url":"https://api.github.com/repos/helm/charts/pulls/4538","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/helm/charts/pulls/comments/229865263"},"html":{"href":"https://github.com/helm/charts/pull/4538#discussion_r229865263"},"pull_request":{"href":"https://api.github.com/repos/helm/charts/pulls/4538"}},"in_reply_to_id":229861804},"pull_request":{"url":"https://api.github.com/repos/helm/charts/pulls/4538","id":178595004,"node_id":"MDExOlB1bGxSZXF1ZXN0MTc4NTk1MDA0","html_url":"https://github.com/helm/charts/pull/4538","diff_url":"https://github.com/helm/charts/pull/4538.diff","patch_url":"https://github.com/helm/charts/pull/4538.patch","issue_url":"https://api.github.com/repos/helm/charts/issues/4538","number":4538,"state":"open","locked":false,"title":"[stable/kube-ingress-aws-controller] Chart v0.0.1","user":{"login":"julianxhokaxhiu","id":1237070,"node_id":"MDQ6VXNlcjEyMzcwNzA=","avatar_url":"https://avatars2.githubusercontent.com/u/1237070?v=4","gravatar_id":"","url":"https://api.github.com/users/julianxhokaxhiu","html_url":"https://github.com/julianxhokaxhiu","followers_url":"https://api.github.com/users/julianxhokaxhiu/followers","following_url":"https://api.github.com/users/julianxhokaxhiu/following{/other_user}","gists_url":"https://api.github.com/users/julianxhokaxhiu/gists{/gist_id}","starred_url":"https://api.github.com/users/julianxhokaxhiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julianxhokaxhiu/subscriptions","organizations_url":"https://api.github.com/users/julianxhokaxhiu/orgs","repos_url":"https://api.github.com/users/julianxhokaxhiu/repos","events_url":"https://api.github.com/users/julianxhokaxhiu/events{/privacy}","received_events_url":"https://api.github.com/users/julianxhokaxhiu/received_events","type":"User","site_admin":false},"body":"Fully working Chart with RBAC support. Tested on Kubernetes 1.8+\r\n\r\n<!--\r\nThank you for contributing to kubernetes/charts. Before you submit this PR we'd like to\r\nmake sure you are aware of our technical requirements and best practices:\r\n\r\n* https://github.com/kubernetes/charts/blob/master/CONTRIBUTING.md#technical-requirements\r\n* https://github.com/kubernetes/helm/tree/master/docs/chart_best_practices\r\n\r\nFor a quick overview across what we will look at reviewing your PR, please read\r\nour review guidelines:\r\n\r\n* https://github.com/kubernetes/charts/blob/master/REVIEW_GUIDELINES.md\r\n\r\nFollowing our best practices right from the start will accelerate the review process and\r\nhelp get your PR merged quicker.\r\n\r\nWhen updates to your PR are requested, please add new commits and do not squash the\r\nhistory. This will make it easier to identify new changes. The PR will be squashed\r\nanyways when it is merged. Thanks.\r\n\r\nFor fast feedback, please @-mention maintainers that are listed in the Chart.yaml file.\r\n\r\nPlease make sure you test your changes before you push them. Once pushed, a CircleCI\r\nwill run across your changes and do some initial checks and linting. These checks run\r\nvery quickly. Please check the results. We would like these checks to pass before we\r\neven continue reviewing your changes.\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\nI developed this yesterday because of various needs, and as I saw nothing around with full RBAC support,\r\nI thought would be cool to share. Feel free to approach me if you have any question.\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #\r\nI hope it enables other Kubernetes and Helm consumers to spawn easily this awesome Ingress Controller when working with AWS.\r\n\r\n**Special notes for your reviewer**:\r\n","created_at":"2018-03-30T16:51:52Z","updated_at":"2018-10-31T20:57:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c68595bfcc841efd1b8c2a4261203240fa6ba1ad","assignee":{"login":"unguiculus","id":925412,"node_id":"MDQ6VXNlcjkyNTQxMg==","avatar_url":"https://avatars1.githubusercontent.com/u/925412?v=4","gravatar_id":"","url":"https://api.github.com/users/unguiculus","html_url":"https://github.com/unguiculus","followers_url":"https://api.github.com/users/unguiculus/followers","following_url":"https://api.github.com/users/unguiculus/following{/other_user}","gists_url":"https://api.github.com/users/unguiculus/gists{/gist_id}","starred_url":"https://api.github.com/users/unguiculus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unguiculus/subscriptions","organizations_url":"https://api.github.com/users/unguiculus/orgs","repos_url":"https://api.github.com/users/unguiculus/repos","events_url":"https://api.github.com/users/unguiculus/events{/privacy}","received_events_url":"https://api.github.com/users/unguiculus/received_events","type":"User","site_admin":false},"assignees":[{"login":"unguiculus","id":925412,"node_id":"MDQ6VXNlcjkyNTQxMg==","avatar_url":"https://avatars1.githubusercontent.com/u/925412?v=4","gravatar_id":"","url":"https://api.github.com/users/unguiculus","html_url":"https://github.com/unguiculus","followers_url":"https://api.github.com/users/unguiculus/followers","following_url":"https://api.github.com/users/unguiculus/following{/other_user}","gists_url":"https://api.github.com/users/unguiculus/gists{/gist_id}","starred_url":"https://api.github.com/users/unguiculus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unguiculus/subscriptions","organizations_url":"https://api.github.com/users/unguiculus/orgs","repos_url":"https://api.github.com/users/unguiculus/repos","events_url":"https://api.github.com/users/unguiculus/events{/privacy}","received_events_url":"https://api.github.com/users/unguiculus/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":484586588,"node_id":"MDU6TGFiZWw0ODQ1ODY1ODg=","url":"https://api.github.com/repos/helm/charts/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":676596499,"node_id":"MDU6TGFiZWw2NzY1OTY0OTk=","url":"https://api.github.com/repos/helm/charts/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/helm/charts/pulls/4538/commits","review_comments_url":"https://api.github.com/repos/helm/charts/pulls/4538/comments","review_comment_url":"https://api.github.com/repos/helm/charts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/helm/charts/issues/4538/comments","statuses_url":"https://api.github.com/repos/helm/charts/statuses/22bfacaa15a60c2dc73d05efe325630f661c8dc7","head":{"label":"julianxhokaxhiu:master","ref":"master","sha":"22bfacaa15a60c2dc73d05efe325630f661c8dc7","user":{"login":"julianxhokaxhiu","id":1237070,"node_id":"MDQ6VXNlcjEyMzcwNzA=","avatar_url":"https://avatars2.githubusercontent.com/u/1237070?v=4","gravatar_id":"","url":"https://api.github.com/users/julianxhokaxhiu","html_url":"https://github.com/julianxhokaxhiu","followers_url":"https://api.github.com/users/julianxhokaxhiu/followers","following_url":"https://api.github.com/users/julianxhokaxhiu/following{/other_user}","gists_url":"https://api.github.com/users/julianxhokaxhiu/gists{/gist_id}","starred_url":"https://api.github.com/users/julianxhokaxhiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julianxhokaxhiu/subscriptions","organizations_url":"https://api.github.com/users/julianxhokaxhiu/orgs","repos_url":"https://api.github.com/users/julianxhokaxhiu/repos","events_url":"https://api.github.com/users/julianxhokaxhiu/events{/privacy}","received_events_url":"https://api.github.com/users/julianxhokaxhiu/received_events","type":"User","site_admin":false},"repo":{"id":127448236,"node_id":"MDEwOlJlcG9zaXRvcnkxMjc0NDgyMzY=","name":"charts","full_name":"julianxhokaxhiu/charts","private":false,"owner":{"login":"julianxhokaxhiu","id":1237070,"node_id":"MDQ6VXNlcjEyMzcwNzA=","avatar_url":"https://avatars2.githubusercontent.com/u/1237070?v=4","gravatar_id":"","url":"https://api.github.com/users/julianxhokaxhiu","html_url":"https://github.com/julianxhokaxhiu","followers_url":"https://api.github.com/users/julianxhokaxhiu/followers","following_url":"https://api.github.com/users/julianxhokaxhiu/following{/other_user}","gists_url":"https://api.github.com/users/julianxhokaxhiu/gists{/gist_id}","starred_url":"https://api.github.com/users/julianxhokaxhiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julianxhokaxhiu/subscriptions","organizations_url":"https://api.github.com/users/julianxhokaxhiu/orgs","repos_url":"https://api.github.com/users/julianxhokaxhiu/repos","events_url":"https://api.github.com/users/julianxhokaxhiu/events{/privacy}","received_events_url":"https://api.github.com/users/julianxhokaxhiu/received_events","type":"User","site_admin":false},"html_url":"https://github.com/julianxhokaxhiu/charts","description":"Curated applications for Kubernetes","fork":true,"url":"https://api.github.com/repos/julianxhokaxhiu/charts","forks_url":"https://api.github.com/repos/julianxhokaxhiu/charts/forks","keys_url":"https://api.github.com/repos/julianxhokaxhiu/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/julianxhokaxhiu/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/julianxhokaxhiu/charts/teams","hooks_url":"https://api.github.com/repos/julianxhokaxhiu/charts/hooks","issue_events_url":"https://api.github.com/repos/julianxhokaxhiu/charts/issues/events{/number}","events_url":"https://api.github.com/repos/julianxhokaxhiu/charts/events","assignees_url":"https://api.github.com/repos/julianxhokaxhiu/charts/assignees{/user}","branches_url":"https://api.github.com/repos/julianxhokaxhiu/charts/branches{/branch}","tags_url":"https://api.github.com/repos/julianxhokaxhiu/charts/tags","blobs_url":"https://api.github.com/repos/julianxhokaxhiu/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/julianxhokaxhiu/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/julianxhokaxhiu/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/julianxhokaxhiu/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/julianxhokaxhiu/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/julianxhokaxhiu/charts/languages","stargazers_url":"https://api.github.com/repos/julianxhokaxhiu/charts/stargazers","contributors_url":"https://api.github.com/repos/julianxhokaxhiu/charts/contributors","subscribers_url":"https://api.github.com/repos/julianxhokaxhiu/charts/subscribers","subscription_url":"https://api.github.com/repos/julianxhokaxhiu/charts/subscription","commits_url":"https://api.github.com/repos/julianxhokaxhiu/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/julianxhokaxhiu/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/julianxhokaxhiu/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/julianxhokaxhiu/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/julianxhokaxhiu/charts/contents/{+path}","compare_url":"https://api.github.com/repos/julianxhokaxhiu/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/julianxhokaxhiu/charts/merges","archive_url":"https://api.github.com/repos/julianxhokaxhiu/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/julianxhokaxhiu/charts/downloads","issues_url":"https://api.github.com/repos/julianxhokaxhiu/charts/issues{/number}","pulls_url":"https://api.github.com/repos/julianxhokaxhiu/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/julianxhokaxhiu/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/julianxhokaxhiu/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/julianxhokaxhiu/charts/labels{/name}","releases_url":"https://api.github.com/repos/julianxhokaxhiu/charts/releases{/id}","deployments_url":"https://api.github.com/repos/julianxhokaxhiu/charts/deployments","created_at":"2018-03-30T16:15:40Z","updated_at":"2018-10-31T20:57:07Z","pushed_at":"2018-10-31T20:57:04Z","git_url":"git://github.com/julianxhokaxhiu/charts.git","ssh_url":"git@github.com:julianxhokaxhiu/charts.git","clone_url":"https://github.com/julianxhokaxhiu/charts.git","svn_url":"https://github.com/julianxhokaxhiu/charts","homepage":"","size":13361,"stargazers_count":0,"watchers_count":0,"language":"Smarty","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"helm:master","ref":"master","sha":"893a6229c3b3b97f58af8251805b78f926d67f70","user":{"login":"helm","id":15859888,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODU5ODg4","avatar_url":"https://avatars2.githubusercontent.com/u/15859888?v=4","gravatar_id":"","url":"https://api.github.com/users/helm","html_url":"https://github.com/helm","followers_url":"https://api.github.com/users/helm/followers","following_url":"https://api.github.com/users/helm/following{/other_user}","gists_url":"https://api.github.com/users/helm/gists{/gist_id}","starred_url":"https://api.github.com/users/helm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helm/subscriptions","organizations_url":"https://api.github.com/users/helm/orgs","repos_url":"https://api.github.com/users/helm/repos","events_url":"https://api.github.com/users/helm/events{/privacy}","received_events_url":"https://api.github.com/users/helm/received_events","type":"Organization","site_admin":false},"repo":{"id":46806184,"node_id":"MDEwOlJlcG9zaXRvcnk0NjgwNjE4NA==","name":"charts","full_name":"helm/charts","private":false,"owner":{"login":"helm","id":15859888,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODU5ODg4","avatar_url":"https://avatars2.githubusercontent.com/u/15859888?v=4","gravatar_id":"","url":"https://api.github.com/users/helm","html_url":"https://github.com/helm","followers_url":"https://api.github.com/users/helm/followers","following_url":"https://api.github.com/users/helm/following{/other_user}","gists_url":"https://api.github.com/users/helm/gists{/gist_id}","starred_url":"https://api.github.com/users/helm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helm/subscriptions","organizations_url":"https://api.github.com/users/helm/orgs","repos_url":"https://api.github.com/users/helm/repos","events_url":"https://api.github.com/users/helm/events{/privacy}","received_events_url":"https://api.github.com/users/helm/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/helm/charts","description":"Curated applications for Kubernetes","fork":false,"url":"https://api.github.com/repos/helm/charts","forks_url":"https://api.github.com/repos/helm/charts/forks","keys_url":"https://api.github.com/repos/helm/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/helm/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/helm/charts/teams","hooks_url":"https://api.github.com/repos/helm/charts/hooks","issue_events_url":"https://api.github.com/repos/helm/charts/issues/events{/number}","events_url":"https://api.github.com/repos/helm/charts/events","assignees_url":"https://api.github.com/repos/helm/charts/assignees{/user}","branches_url":"https://api.github.com/repos/helm/charts/branches{/branch}","tags_url":"https://api.github.com/repos/helm/charts/tags","blobs_url":"https://api.github.com/repos/helm/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/helm/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/helm/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/helm/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/helm/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/helm/charts/languages","stargazers_url":"https://api.github.com/repos/helm/charts/stargazers","contributors_url":"https://api.github.com/repos/helm/charts/contributors","subscribers_url":"https://api.github.com/repos/helm/charts/subscribers","subscription_url":"https://api.github.com/repos/helm/charts/subscription","commits_url":"https://api.github.com/repos/helm/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/helm/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/helm/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/helm/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/helm/charts/contents/{+path}","compare_url":"https://api.github.com/repos/helm/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/helm/charts/merges","archive_url":"https://api.github.com/repos/helm/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/helm/charts/downloads","issues_url":"https://api.github.com/repos/helm/charts/issues{/number}","pulls_url":"https://api.github.com/repos/helm/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/helm/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/helm/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/helm/charts/labels{/name}","releases_url":"https://api.github.com/repos/helm/charts/releases{/id}","deployments_url":"https://api.github.com/repos/helm/charts/deployments","created_at":"2015-11-24T17:05:28Z","updated_at":"2018-10-31T20:46:13Z","pushed_at":"2018-10-31T20:57:06Z","git_url":"git://github.com/helm/charts.git","ssh_url":"git@github.com:helm/charts.git","clone_url":"https://github.com/helm/charts.git","svn_url":"https://github.com/helm/charts","homepage":"","size":13396,"stargazers_count":5372,"watchers_count":5372,"language":"Smarty","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4780,"mirror_url":null,"archived":false,"open_issues_count":620,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4780,"open_issues":620,"watchers":5372,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/helm/charts/pulls/4538"},"html":{"href":"https://github.com/helm/charts/pull/4538"},"issue":{"href":"https://api.github.com/repos/helm/charts/issues/4538"},"comments":{"href":"https://api.github.com/repos/helm/charts/issues/4538/comments"},"review_comments":{"href":"https://api.github.com/repos/helm/charts/pulls/4538/comments"},"review_comment":{"href":"https://api.github.com/repos/helm/charts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/helm/charts/pulls/4538/commits"},"statuses":{"href":"https://api.github.com/repos/helm/charts/statuses/22bfacaa15a60c2dc73d05efe325630f661c8dc7"}},"author_association":"NONE"}}
{"actor":{"display_login":"julianxhokaxhiu"}}