{"action":"created","comment":{"url":"https://api.github.com/repos/cyberark/conjur/pulls/comments/184727562","pull_request_review_id":115986411,"id":184727562,"diff_hunk":"@@ -1,7 +1,109 @@\n @logged-in\n Feature: Rules which govern the visibility of resources to roles.\n \n-  Scenario: Resources from a foreign account are not visible\n+  Scenario: Resources from a foreign account are not visible without a permission\n     Given I create a new resource in a foreign account\n+    And I create a new user \"alice\"\n+\n+    When I login as \"alice\"\n+    And I successfully GET \"/resources\"\n+\n+    Then the resource list should not include the newest resource\n+\n+  Scenario: Resources from a foreign account can be visible\n+    Given I create a new resource in a foreign account\n+    And I create a new user \"alice\"\n+    And I permit user \"alice\" to \"try\" it\n+\n+    When I login as \"alice\"\n+    And I successfully GET \"/resources\"\n+    Then the resource list should include the newest resource\n+\n+    When I successfully GET \"/resources/cucumber\"\n+    Then the resource list should not include the newest resource\n+\n+  Scenario: Resources without permissions or ownership are not visible\n+    Given I create a new resource called \"probe\"\n+    And I create a new user \"alice\"\n+\n+    When I login as \"alice\"\n     And I successfully GET \"/resources/cucumber\"","path":"cucumber/api/features/resource_visibility.feature","position":31,"original_position":31,"commit_id":"d4c39231cc6adbe82d09bd5a63a1d0ea68294f1b","original_commit_id":"d4c39231cc6adbe82d09bd5a63a1d0ea68294f1b","user":{"login":"kgilpin","id":86395,"avatar_url":"https://avatars0.githubusercontent.com/u/86395?v=4","gravatar_id":"","url":"https://api.github.com/users/kgilpin","html_url":"https://github.com/kgilpin","followers_url":"https://api.github.com/users/kgilpin/followers","following_url":"https://api.github.com/users/kgilpin/following{/other_user}","gists_url":"https://api.github.com/users/kgilpin/gists{/gist_id}","starred_url":"https://api.github.com/users/kgilpin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kgilpin/subscriptions","organizations_url":"https://api.github.com/users/kgilpin/orgs","repos_url":"https://api.github.com/users/kgilpin/repos","events_url":"https://api.github.com/users/kgilpin/events{/privacy}","received_events_url":"https://api.github.com/users/kgilpin/received_events","type":"User","site_admin":false},"body":"Again, account as parameter rather than path component.","created_at":"2018-04-27T15:44:21Z","updated_at":"2018-04-27T15:46:24Z","html_url":"https://github.com/cyberark/conjur/pull/534#discussion_r184727562","pull_request_url":"https://api.github.com/repos/cyberark/conjur/pulls/534","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/cyberark/conjur/pulls/comments/184727562"},"html":{"href":"https://github.com/cyberark/conjur/pull/534#discussion_r184727562"},"pull_request":{"href":"https://api.github.com/repos/cyberark/conjur/pulls/534"}}},"pull_request":{"url":"https://api.github.com/repos/cyberark/conjur/pulls/534","id":184364038,"html_url":"https://github.com/cyberark/conjur/pull/534","diff_url":"https://github.com/cyberark/conjur/pull/534.diff","patch_url":"https://github.com/cyberark/conjur/pull/534.patch","issue_url":"https://api.github.com/repos/cyberark/conjur/issues/534","number":534,"state":"open","locked":false,"title":"Resource visibility restrictions","user":{"login":"dividedmind","id":823636,"avatar_url":"https://avatars2.githubusercontent.com/u/823636?v=4","gravatar_id":"","url":"https://api.github.com/users/dividedmind","html_url":"https://github.com/dividedmind","followers_url":"https://api.github.com/users/dividedmind/followers","following_url":"https://api.github.com/users/dividedmind/following{/other_user}","gists_url":"https://api.github.com/users/dividedmind/gists{/gist_id}","starred_url":"https://api.github.com/users/dividedmind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dividedmind/subscriptions","organizations_url":"https://api.github.com/users/dividedmind/orgs","repos_url":"https://api.github.com/users/dividedmind/repos","events_url":"https://api.github.com/users/dividedmind/events{/privacy}","received_events_url":"https://api.github.com/users/dividedmind/received_events","type":"User","site_admin":false},"body":"This pull request makes it so resources are only visible to users which hold a permission on them or own them. Since we don't need the account visibility cutoff anymore, I also added a `/resources` route which searches all resources the user might see, regardless of the account.","created_at":"2018-04-26T14:43:06Z","updated_at":"2018-04-27T15:46:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27753739d4a8d4126a78bc5d1ce358ed93b03e6b","assignee":{"login":"dividedmind","id":823636,"avatar_url":"https://avatars2.githubusercontent.com/u/823636?v=4","gravatar_id":"","url":"https://api.github.com/users/dividedmind","html_url":"https://github.com/dividedmind","followers_url":"https://api.github.com/users/dividedmind/followers","following_url":"https://api.github.com/users/dividedmind/following{/other_user}","gists_url":"https://api.github.com/users/dividedmind/gists{/gist_id}","starred_url":"https://api.github.com/users/dividedmind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dividedmind/subscriptions","organizations_url":"https://api.github.com/users/dividedmind/orgs","repos_url":"https://api.github.com/users/dividedmind/repos","events_url":"https://api.github.com/users/dividedmind/events{/privacy}","received_events_url":"https://api.github.com/users/dividedmind/received_events","type":"User","site_admin":false},"assignees":[{"login":"dividedmind","id":823636,"avatar_url":"https://avatars2.githubusercontent.com/u/823636?v=4","gravatar_id":"","url":"https://api.github.com/users/dividedmind","html_url":"https://github.com/dividedmind","followers_url":"https://api.github.com/users/dividedmind/followers","following_url":"https://api.github.com/users/dividedmind/following{/other_user}","gists_url":"https://api.github.com/users/dividedmind/gists{/gist_id}","starred_url":"https://api.github.com/users/dividedmind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dividedmind/subscriptions","organizations_url":"https://api.github.com/users/dividedmind/orgs","repos_url":"https://api.github.com/users/dividedmind/repos","events_url":"https://api.github.com/users/dividedmind/events{/privacy}","received_events_url":"https://api.github.com/users/dividedmind/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"jtuttle","id":18331203,"avatar_url":"https://avatars3.githubusercontent.com/u/18331203?v=4","gravatar_id":"","url":"https://api.github.com/users/jtuttle","html_url":"https://github.com/jtuttle","followers_url":"https://api.github.com/users/jtuttle/followers","following_url":"https://api.github.com/users/jtuttle/following{/other_user}","gists_url":"https://api.github.com/users/jtuttle/gists{/gist_id}","starred_url":"https://api.github.com/users/jtuttle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtuttle/subscriptions","organizations_url":"https://api.github.com/users/jtuttle/orgs","repos_url":"https://api.github.com/users/jtuttle/repos","events_url":"https://api.github.com/users/jtuttle/events{/privacy}","received_events_url":"https://api.github.com/users/jtuttle/received_events","type":"User","site_admin":false},{"login":"izgeri","id":26872683,"avatar_url":"https://avatars3.githubusercontent.com/u/26872683?v=4","gravatar_id":"","url":"https://api.github.com/users/izgeri","html_url":"https://github.com/izgeri","followers_url":"https://api.github.com/users/izgeri/followers","following_url":"https://api.github.com/users/izgeri/following{/other_user}","gists_url":"https://api.github.com/users/izgeri/gists{/gist_id}","starred_url":"https://api.github.com/users/izgeri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/izgeri/subscriptions","organizations_url":"https://api.github.com/users/izgeri/orgs","repos_url":"https://api.github.com/users/izgeri/repos","events_url":"https://api.github.com/users/izgeri/events{/privacy}","received_events_url":"https://api.github.com/users/izgeri/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":631459098,"url":"https://api.github.com/repos/cyberark/conjur/labels/in%20progress","name":"in progress","color":"ededed","default":false},{"id":631567910,"url":"https://api.github.com/repos/cyberark/conjur/labels/review","name":"review","color":"908ee0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cyberark/conjur/pulls/534/commits","review_comments_url":"https://api.github.com/repos/cyberark/conjur/pulls/534/comments","review_comment_url":"https://api.github.com/repos/cyberark/conjur/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cyberark/conjur/issues/534/comments","statuses_url":"https://api.github.com/repos/cyberark/conjur/statuses/d4c39231cc6adbe82d09bd5a63a1d0ea68294f1b","head":{"label":"cyberark:resource-visibility","ref":"resource-visibility","sha":"d4c39231cc6adbe82d09bd5a63a1d0ea68294f1b","user":{"login":"cyberark","id":30869256,"avatar_url":"https://avatars3.githubusercontent.com/u/30869256?v=4","gravatar_id":"","url":"https://api.github.com/users/cyberark","html_url":"https://github.com/cyberark","followers_url":"https://api.github.com/users/cyberark/followers","following_url":"https://api.github.com/users/cyberark/following{/other_user}","gists_url":"https://api.github.com/users/cyberark/gists{/gist_id}","starred_url":"https://api.github.com/users/cyberark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyberark/subscriptions","organizations_url":"https://api.github.com/users/cyberark/orgs","repos_url":"https://api.github.com/users/cyberark/repos","events_url":"https://api.github.com/users/cyberark/events{/privacy}","received_events_url":"https://api.github.com/users/cyberark/received_events","type":"Organization","site_admin":false},"repo":{"id":62174977,"name":"conjur","full_name":"cyberark/conjur","owner":{"login":"cyberark","id":30869256,"avatar_url":"https://avatars3.githubusercontent.com/u/30869256?v=4","gravatar_id":"","url":"https://api.github.com/users/cyberark","html_url":"https://github.com/cyberark","followers_url":"https://api.github.com/users/cyberark/followers","following_url":"https://api.github.com/users/cyberark/following{/other_user}","gists_url":"https://api.github.com/users/cyberark/gists{/gist_id}","starred_url":"https://api.github.com/users/cyberark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyberark/subscriptions","organizations_url":"https://api.github.com/users/cyberark/orgs","repos_url":"https://api.github.com/users/cyberark/repos","events_url":"https://api.github.com/users/cyberark/events{/privacy}","received_events_url":"https://api.github.com/users/cyberark/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cyberark/conjur","description":"CyberArk Conjur automatically secures secrets used by privileged users and machine identities","fork":false,"url":"https://api.github.com/repos/cyberark/conjur","forks_url":"https://api.github.com/repos/cyberark/conjur/forks","keys_url":"https://api.github.com/repos/cyberark/conjur/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cyberark/conjur/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cyberark/conjur/teams","hooks_url":"https://api.github.com/repos/cyberark/conjur/hooks","issue_events_url":"https://api.github.com/repos/cyberark/conjur/issues/events{/number}","events_url":"https://api.github.com/repos/cyberark/conjur/events","assignees_url":"https://api.github.com/repos/cyberark/conjur/assignees{/user}","branches_url":"https://api.github.com/repos/cyberark/conjur/branches{/branch}","tags_url":"https://api.github.com/repos/cyberark/conjur/tags","blobs_url":"https://api.github.com/repos/cyberark/conjur/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cyberark/conjur/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cyberark/conjur/git/refs{/sha}","trees_url":"https://api.github.com/repos/cyberark/conjur/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cyberark/conjur/statuses/{sha}","languages_url":"https://api.github.com/repos/cyberark/conjur/languages","stargazers_url":"https://api.github.com/repos/cyberark/conjur/stargazers","contributors_url":"https://api.github.com/repos/cyberark/conjur/contributors","subscribers_url":"https://api.github.com/repos/cyberark/conjur/subscribers","subscription_url":"https://api.github.com/repos/cyberark/conjur/subscription","commits_url":"https://api.github.com/repos/cyberark/conjur/commits{/sha}","git_commits_url":"https://api.github.com/repos/cyberark/conjur/git/commits{/sha}","comments_url":"https://api.github.com/repos/cyberark/conjur/comments{/number}","issue_comment_url":"https://api.github.com/repos/cyberark/conjur/issues/comments{/number}","contents_url":"https://api.github.com/repos/cyberark/conjur/contents/{+path}","compare_url":"https://api.github.com/repos/cyberark/conjur/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cyberark/conjur/merges","archive_url":"https://api.github.com/repos/cyberark/conjur/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cyberark/conjur/downloads","issues_url":"https://api.github.com/repos/cyberark/conjur/issues{/number}","pulls_url":"https://api.github.com/repos/cyberark/conjur/pulls{/number}","milestones_url":"https://api.github.com/repos/cyberark/conjur/milestones{/number}","notifications_url":"https://api.github.com/repos/cyberark/conjur/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cyberark/conjur/labels{/name}","releases_url":"https://api.github.com/repos/cyberark/conjur/releases{/id}","deployments_url":"https://api.github.com/repos/cyberark/conjur/deployments","created_at":"2016-06-28T21:18:07Z","updated_at":"2018-04-27T12:25:32Z","pushed_at":"2018-04-27T12:25:29Z","git_url":"git://github.com/cyberark/conjur.git","ssh_url":"git@github.com:cyberark/conjur.git","clone_url":"https://github.com/cyberark/conjur.git","svn_url":"https://github.com/cyberark/conjur","homepage":"https://conjur.org","size":3470,"stargazers_count":124,"watchers_count":124,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":60,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":25,"open_issues":60,"watchers":124,"default_branch":"master"}},"base":{"label":"cyberark:master","ref":"master","sha":"dc4206c9daea507f81211baf23d72cecdda73aa9","user":{"login":"cyberark","id":30869256,"avatar_url":"https://avatars3.githubusercontent.com/u/30869256?v=4","gravatar_id":"","url":"https://api.github.com/users/cyberark","html_url":"https://github.com/cyberark","followers_url":"https://api.github.com/users/cyberark/followers","following_url":"https://api.github.com/users/cyberark/following{/other_user}","gists_url":"https://api.github.com/users/cyberark/gists{/gist_id}","starred_url":"https://api.github.com/users/cyberark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyberark/subscriptions","organizations_url":"https://api.github.com/users/cyberark/orgs","repos_url":"https://api.github.com/users/cyberark/repos","events_url":"https://api.github.com/users/cyberark/events{/privacy}","received_events_url":"https://api.github.com/users/cyberark/received_events","type":"Organization","site_admin":false},"repo":{"id":62174977,"name":"conjur","full_name":"cyberark/conjur","owner":{"login":"cyberark","id":30869256,"avatar_url":"https://avatars3.githubusercontent.com/u/30869256?v=4","gravatar_id":"","url":"https://api.github.com/users/cyberark","html_url":"https://github.com/cyberark","followers_url":"https://api.github.com/users/cyberark/followers","following_url":"https://api.github.com/users/cyberark/following{/other_user}","gists_url":"https://api.github.com/users/cyberark/gists{/gist_id}","starred_url":"https://api.github.com/users/cyberark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyberark/subscriptions","organizations_url":"https://api.github.com/users/cyberark/orgs","repos_url":"https://api.github.com/users/cyberark/repos","events_url":"https://api.github.com/users/cyberark/events{/privacy}","received_events_url":"https://api.github.com/users/cyberark/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cyberark/conjur","description":"CyberArk Conjur automatically secures secrets used by privileged users and machine identities","fork":false,"url":"https://api.github.com/repos/cyberark/conjur","forks_url":"https://api.github.com/repos/cyberark/conjur/forks","keys_url":"https://api.github.com/repos/cyberark/conjur/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cyberark/conjur/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cyberark/conjur/teams","hooks_url":"https://api.github.com/repos/cyberark/conjur/hooks","issue_events_url":"https://api.github.com/repos/cyberark/conjur/issues/events{/number}","events_url":"https://api.github.com/repos/cyberark/conjur/events","assignees_url":"https://api.github.com/repos/cyberark/conjur/assignees{/user}","branches_url":"https://api.github.com/repos/cyberark/conjur/branches{/branch}","tags_url":"https://api.github.com/repos/cyberark/conjur/tags","blobs_url":"https://api.github.com/repos/cyberark/conjur/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cyberark/conjur/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cyberark/conjur/git/refs{/sha}","trees_url":"https://api.github.com/repos/cyberark/conjur/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cyberark/conjur/statuses/{sha}","languages_url":"https://api.github.com/repos/cyberark/conjur/languages","stargazers_url":"https://api.github.com/repos/cyberark/conjur/stargazers","contributors_url":"https://api.github.com/repos/cyberark/conjur/contributors","subscribers_url":"https://api.github.com/repos/cyberark/conjur/subscribers","subscription_url":"https://api.github.com/repos/cyberark/conjur/subscription","commits_url":"https://api.github.com/repos/cyberark/conjur/commits{/sha}","git_commits_url":"https://api.github.com/repos/cyberark/conjur/git/commits{/sha}","comments_url":"https://api.github.com/repos/cyberark/conjur/comments{/number}","issue_comment_url":"https://api.github.com/repos/cyberark/conjur/issues/comments{/number}","contents_url":"https://api.github.com/repos/cyberark/conjur/contents/{+path}","compare_url":"https://api.github.com/repos/cyberark/conjur/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cyberark/conjur/merges","archive_url":"https://api.github.com/repos/cyberark/conjur/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cyberark/conjur/downloads","issues_url":"https://api.github.com/repos/cyberark/conjur/issues{/number}","pulls_url":"https://api.github.com/repos/cyberark/conjur/pulls{/number}","milestones_url":"https://api.github.com/repos/cyberark/conjur/milestones{/number}","notifications_url":"https://api.github.com/repos/cyberark/conjur/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cyberark/conjur/labels{/name}","releases_url":"https://api.github.com/repos/cyberark/conjur/releases{/id}","deployments_url":"https://api.github.com/repos/cyberark/conjur/deployments","created_at":"2016-06-28T21:18:07Z","updated_at":"2018-04-27T12:25:32Z","pushed_at":"2018-04-27T12:25:29Z","git_url":"git://github.com/cyberark/conjur.git","ssh_url":"git@github.com:cyberark/conjur.git","clone_url":"https://github.com/cyberark/conjur.git","svn_url":"https://github.com/cyberark/conjur","homepage":"https://conjur.org","size":3470,"stargazers_count":124,"watchers_count":124,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":60,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":25,"open_issues":60,"watchers":124,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cyberark/conjur/pulls/534"},"html":{"href":"https://github.com/cyberark/conjur/pull/534"},"issue":{"href":"https://api.github.com/repos/cyberark/conjur/issues/534"},"comments":{"href":"https://api.github.com/repos/cyberark/conjur/issues/534/comments"},"review_comments":{"href":"https://api.github.com/repos/cyberark/conjur/pulls/534/comments"},"review_comment":{"href":"https://api.github.com/repos/cyberark/conjur/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cyberark/conjur/pulls/534/commits"},"statuses":{"href":"https://api.github.com/repos/cyberark/conjur/statuses/d4c39231cc6adbe82d09bd5a63a1d0ea68294f1b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kgilpin"}}