{"action":"created","comment":{"url":"https://api.github.com/repos/Khan/wonder-blocks/pulls/comments/183916097","pull_request_review_id":115007367,"id":183916097,"diff_hunk":"@@ -99,12 +99,42 @@ Additionally, there are the following available components which will likely be\n \n Currently Grids are available at the following sizes (with their columns, gutter size, and margin sizes changing based on the size):\n \n-| Size          | Columns | Gutter | Margin | Breakpoint                                                                                                                       |\n-| ------------- | ------- | ------ | ------ | -------------------------------------------------------------------------------------------------------------------------------- |\n-| small         | 4       | 16px   | 16px   | `max-width: 767px`                                                                                                               |\n-| medium        | 8       | 32px   | 24px   | `min-width: 768px and max-width: 1023px`                                                                                         |\n-| large         | 12      | 32px   | 24px   | `min-width: 1024px` (maximum content width: `20px`, after which the margins will continue to expand and content remain centered) |\n-| internalTools | 12      | 32px   | 16px   | No breakpoint, must be explicitly specified in the `size` prop. Also no maximum content width.                                   |\n+**Default Sizes (`GRID_DEFAULT_SIZES`)**\n+\n+| Size   | Columns | Gutter | Margin | Breakpoint                                                                                                                         |\n+| ------ | ------- | ------ | ------ | ---------------------------------------------------------------------------------------------------------------------------------- |\n+| small  | 4       | 16px   | 16px   | `max-width: 767px`                                                                                                                 |\n+| medium | 8       | 32px   | 24px   | `min-width: 768px and max-width: 1023px`                                                                                           |\n+| large  | 12      | 32px   | 24px   | `min-width: 1024px` (maximum content width: `1120px`, after which the margins will continue to expand and content remain centered) |\n+\n+Additionally, the following grid sizes are also available:\n+\n+**Internal Tools (`GRID_INTERNAL_SIZES`)**\n+\n+| Size  | Columns | Gutter | Margin | Breakpoint                                   |\n+| ----- | ------- | ------ | ------ | -------------------------------------------- |\n+| large | 12      | 32px   | 16px   | `min-width: 1px` (No maximum content width.) |\n+\n+**12-Column Modal (`GRID_MODAL_12_SIZES`)**\n+\n+| Size  | Columns | Gutter | Margin | Breakpoint                                     |\n+| ----- | ------- | ------ | ------ | ---------------------------------------------- |\n+| small | 4       | 16px   | 16px   | `max-width: 767px`                             |\n+| large | 12      | 32px   | 64px   | `min-width: 768px` (No maximum content width.) |","path":"packages/wonder-blocks-grid/docs.md","position":31,"original_position":31,"commit_id":"a8c2ef7696a74a9ad6be0606e66a67da93e6025e","original_commit_id":"a8c2ef7696a74a9ad6be0606e66a67da93e6025e","user":{"login":"kevinbarabash","id":1044413,"avatar_url":"https://avatars3.githubusercontent.com/u/1044413?v=4","gravatar_id":"","url":"https://api.github.com/users/kevinbarabash","html_url":"https://github.com/kevinbarabash","followers_url":"https://api.github.com/users/kevinbarabash/followers","following_url":"https://api.github.com/users/kevinbarabash/following{/other_user}","gists_url":"https://api.github.com/users/kevinbarabash/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinbarabash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinbarabash/subscriptions","organizations_url":"https://api.github.com/users/kevinbarabash/orgs","repos_url":"https://api.github.com/users/kevinbarabash/repos","events_url":"https://api.github.com/users/kevinbarabash/events{/privacy}","received_events_url":"https://api.github.com/users/kevinbarabash/received_events","type":"User","site_admin":false},"body":"Is this correct?  It feels like either the grid should have a max width or the modal itself should have a max width.","created_at":"2018-04-25T00:18:58Z","updated_at":"2018-04-25T00:30:45Z","html_url":"https://github.com/Khan/wonder-blocks/pull/44#discussion_r183916097","pull_request_url":"https://api.github.com/repos/Khan/wonder-blocks/pulls/44","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/Khan/wonder-blocks/pulls/comments/183916097"},"html":{"href":"https://github.com/Khan/wonder-blocks/pull/44#discussion_r183916097"},"pull_request":{"href":"https://api.github.com/repos/Khan/wonder-blocks/pulls/44"}}},"pull_request":{"url":"https://api.github.com/repos/Khan/wonder-blocks/pulls/44","id":183777771,"html_url":"https://github.com/Khan/wonder-blocks/pull/44","diff_url":"https://github.com/Khan/wonder-blocks/pull/44.diff","patch_url":"https://github.com/Khan/wonder-blocks/pull/44.patch","issue_url":"https://api.github.com/repos/Khan/wonder-blocks/issues/44","number":44,"state":"open","locked":false,"title":"Switch to uses a new system for Grid Sizes.","user":{"login":"jeresig","id":1615,"avatar_url":"https://avatars0.githubusercontent.com/u/1615?v=4","gravatar_id":"","url":"https://api.github.com/users/jeresig","html_url":"https://github.com/jeresig","followers_url":"https://api.github.com/users/jeresig/followers","following_url":"https://api.github.com/users/jeresig/following{/other_user}","gists_url":"https://api.github.com/users/jeresig/gists{/gist_id}","starred_url":"https://api.github.com/users/jeresig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeresig/subscriptions","organizations_url":"https://api.github.com/users/jeresig/orgs","repos_url":"https://api.github.com/users/jeresig/repos","events_url":"https://api.github.com/users/jeresig/events{/privacy}","received_events_url":"https://api.github.com/users/jeresig/received_events","type":"User","site_admin":false},"body":"This introduces a new system for setting the possible sizes of the Grid based on a setting to the `Grid` component. There are a bunch of pre-defined sizes based on the spec. Docs have been updated as well.\r\n\r\nI had to include some new ignores in `.prettierignore`. Specifically the `*.md` files were being parsed using the `flow` parser which was breaking. It seems like we can fix this by doing something like the following, but we need to update Prettier to a newer version first:\r\n\r\n```\r\n    \"overrides\": [\r\n        {\r\n            \"files\": \"*.json\",\r\n            \"options\": { \"parser\": \"json\" }\r\n        },\r\n        {\r\n            \"files\": \"*.md\",\r\n            \"options\": { \"parser\": \"markdown\" }\r\n        }\r\n    ]\r\n```\r\n\r\nAdditionally, I saw that we were formatting the built docs files, which doesn't feel right to me, so I added them to the ignore too.","created_at":"2018-04-24T15:32:30Z","updated_at":"2018-04-25T00:30:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e3af22165a212f185dc18f9752c35de6a17a511","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Khan/wonder-blocks/pulls/44/commits","review_comments_url":"https://api.github.com/repos/Khan/wonder-blocks/pulls/44/comments","review_comment_url":"https://api.github.com/repos/Khan/wonder-blocks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Khan/wonder-blocks/issues/44/comments","statuses_url":"https://api.github.com/repos/Khan/wonder-blocks/statuses/a8c2ef7696a74a9ad6be0606e66a67da93e6025e","head":{"label":"Khan:grid-sizes","ref":"grid-sizes","sha":"a8c2ef7696a74a9ad6be0606e66a67da93e6025e","user":{"login":"Khan","id":15455,"avatar_url":"https://avatars1.githubusercontent.com/u/15455?v=4","gravatar_id":"","url":"https://api.github.com/users/Khan","html_url":"https://github.com/Khan","followers_url":"https://api.github.com/users/Khan/followers","following_url":"https://api.github.com/users/Khan/following{/other_user}","gists_url":"https://api.github.com/users/Khan/gists{/gist_id}","starred_url":"https://api.github.com/users/Khan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Khan/subscriptions","organizations_url":"https://api.github.com/users/Khan/orgs","repos_url":"https://api.github.com/users/Khan/repos","events_url":"https://api.github.com/users/Khan/events{/privacy}","received_events_url":"https://api.github.com/users/Khan/received_events","type":"Organization","site_admin":false},"repo":{"id":123198469,"name":"wonder-blocks","full_name":"Khan/wonder-blocks","owner":{"login":"Khan","id":15455,"avatar_url":"https://avatars1.githubusercontent.com/u/15455?v=4","gravatar_id":"","url":"https://api.github.com/users/Khan","html_url":"https://github.com/Khan","followers_url":"https://api.github.com/users/Khan/followers","following_url":"https://api.github.com/users/Khan/following{/other_user}","gists_url":"https://api.github.com/users/Khan/gists{/gist_id}","starred_url":"https://api.github.com/users/Khan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Khan/subscriptions","organizations_url":"https://api.github.com/users/Khan/orgs","repos_url":"https://api.github.com/users/Khan/repos","events_url":"https://api.github.com/users/Khan/events{/privacy}","received_events_url":"https://api.github.com/users/Khan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Khan/wonder-blocks","description":"React components for Wonder Blocks design system.","fork":false,"url":"https://api.github.com/repos/Khan/wonder-blocks","forks_url":"https://api.github.com/repos/Khan/wonder-blocks/forks","keys_url":"https://api.github.com/repos/Khan/wonder-blocks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Khan/wonder-blocks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Khan/wonder-blocks/teams","hooks_url":"https://api.github.com/repos/Khan/wonder-blocks/hooks","issue_events_url":"https://api.github.com/repos/Khan/wonder-blocks/issues/events{/number}","events_url":"https://api.github.com/repos/Khan/wonder-blocks/events","assignees_url":"https://api.github.com/repos/Khan/wonder-blocks/assignees{/user}","branches_url":"https://api.github.com/repos/Khan/wonder-blocks/branches{/branch}","tags_url":"https://api.github.com/repos/Khan/wonder-blocks/tags","blobs_url":"https://api.github.com/repos/Khan/wonder-blocks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Khan/wonder-blocks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Khan/wonder-blocks/git/refs{/sha}","trees_url":"https://api.github.com/repos/Khan/wonder-blocks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Khan/wonder-blocks/statuses/{sha}","languages_url":"https://api.github.com/repos/Khan/wonder-blocks/languages","stargazers_url":"https://api.github.com/repos/Khan/wonder-blocks/stargazers","contributors_url":"https://api.github.com/repos/Khan/wonder-blocks/contributors","subscribers_url":"https://api.github.com/repos/Khan/wonder-blocks/subscribers","subscription_url":"https://api.github.com/repos/Khan/wonder-blocks/subscription","commits_url":"https://api.github.com/repos/Khan/wonder-blocks/commits{/sha}","git_commits_url":"https://api.github.com/repos/Khan/wonder-blocks/git/commits{/sha}","comments_url":"https://api.github.com/repos/Khan/wonder-blocks/comments{/number}","issue_comment_url":"https://api.github.com/repos/Khan/wonder-blocks/issues/comments{/number}","contents_url":"https://api.github.com/repos/Khan/wonder-blocks/contents/{+path}","compare_url":"https://api.github.com/repos/Khan/wonder-blocks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Khan/wonder-blocks/merges","archive_url":"https://api.github.com/repos/Khan/wonder-blocks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Khan/wonder-blocks/downloads","issues_url":"https://api.github.com/repos/Khan/wonder-blocks/issues{/number}","pulls_url":"https://api.github.com/repos/Khan/wonder-blocks/pulls{/number}","milestones_url":"https://api.github.com/repos/Khan/wonder-blocks/milestones{/number}","notifications_url":"https://api.github.com/repos/Khan/wonder-blocks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Khan/wonder-blocks/labels{/name}","releases_url":"https://api.github.com/repos/Khan/wonder-blocks/releases{/id}","deployments_url":"https://api.github.com/repos/Khan/wonder-blocks/deployments","created_at":"2018-02-27T22:50:41Z","updated_at":"2018-04-24T21:05:12Z","pushed_at":"2018-04-24T23:18:24Z","git_url":"git://github.com/Khan/wonder-blocks.git","ssh_url":"git@github.com:Khan/wonder-blocks.git","clone_url":"https://github.com/Khan/wonder-blocks.git","svn_url":"https://github.com/Khan/wonder-blocks","homepage":"https://khan.github.io/wonder-blocks","size":3425,"stargazers_count":13,"watchers_count":13,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":0,"open_issues":4,"watchers":13,"default_branch":"master"}},"base":{"label":"Khan:master","ref":"master","sha":"2bc247ae9828afc08c65ce210ef7e57cb1ced085","user":{"login":"Khan","id":15455,"avatar_url":"https://avatars1.githubusercontent.com/u/15455?v=4","gravatar_id":"","url":"https://api.github.com/users/Khan","html_url":"https://github.com/Khan","followers_url":"https://api.github.com/users/Khan/followers","following_url":"https://api.github.com/users/Khan/following{/other_user}","gists_url":"https://api.github.com/users/Khan/gists{/gist_id}","starred_url":"https://api.github.com/users/Khan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Khan/subscriptions","organizations_url":"https://api.github.com/users/Khan/orgs","repos_url":"https://api.github.com/users/Khan/repos","events_url":"https://api.github.com/users/Khan/events{/privacy}","received_events_url":"https://api.github.com/users/Khan/received_events","type":"Organization","site_admin":false},"repo":{"id":123198469,"name":"wonder-blocks","full_name":"Khan/wonder-blocks","owner":{"login":"Khan","id":15455,"avatar_url":"https://avatars1.githubusercontent.com/u/15455?v=4","gravatar_id":"","url":"https://api.github.com/users/Khan","html_url":"https://github.com/Khan","followers_url":"https://api.github.com/users/Khan/followers","following_url":"https://api.github.com/users/Khan/following{/other_user}","gists_url":"https://api.github.com/users/Khan/gists{/gist_id}","starred_url":"https://api.github.com/users/Khan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Khan/subscriptions","organizations_url":"https://api.github.com/users/Khan/orgs","repos_url":"https://api.github.com/users/Khan/repos","events_url":"https://api.github.com/users/Khan/events{/privacy}","received_events_url":"https://api.github.com/users/Khan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Khan/wonder-blocks","description":"React components for Wonder Blocks design system.","fork":false,"url":"https://api.github.com/repos/Khan/wonder-blocks","forks_url":"https://api.github.com/repos/Khan/wonder-blocks/forks","keys_url":"https://api.github.com/repos/Khan/wonder-blocks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Khan/wonder-blocks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Khan/wonder-blocks/teams","hooks_url":"https://api.github.com/repos/Khan/wonder-blocks/hooks","issue_events_url":"https://api.github.com/repos/Khan/wonder-blocks/issues/events{/number}","events_url":"https://api.github.com/repos/Khan/wonder-blocks/events","assignees_url":"https://api.github.com/repos/Khan/wonder-blocks/assignees{/user}","branches_url":"https://api.github.com/repos/Khan/wonder-blocks/branches{/branch}","tags_url":"https://api.github.com/repos/Khan/wonder-blocks/tags","blobs_url":"https://api.github.com/repos/Khan/wonder-blocks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Khan/wonder-blocks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Khan/wonder-blocks/git/refs{/sha}","trees_url":"https://api.github.com/repos/Khan/wonder-blocks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Khan/wonder-blocks/statuses/{sha}","languages_url":"https://api.github.com/repos/Khan/wonder-blocks/languages","stargazers_url":"https://api.github.com/repos/Khan/wonder-blocks/stargazers","contributors_url":"https://api.github.com/repos/Khan/wonder-blocks/contributors","subscribers_url":"https://api.github.com/repos/Khan/wonder-blocks/subscribers","subscription_url":"https://api.github.com/repos/Khan/wonder-blocks/subscription","commits_url":"https://api.github.com/repos/Khan/wonder-blocks/commits{/sha}","git_commits_url":"https://api.github.com/repos/Khan/wonder-blocks/git/commits{/sha}","comments_url":"https://api.github.com/repos/Khan/wonder-blocks/comments{/number}","issue_comment_url":"https://api.github.com/repos/Khan/wonder-blocks/issues/comments{/number}","contents_url":"https://api.github.com/repos/Khan/wonder-blocks/contents/{+path}","compare_url":"https://api.github.com/repos/Khan/wonder-blocks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Khan/wonder-blocks/merges","archive_url":"https://api.github.com/repos/Khan/wonder-blocks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Khan/wonder-blocks/downloads","issues_url":"https://api.github.com/repos/Khan/wonder-blocks/issues{/number}","pulls_url":"https://api.github.com/repos/Khan/wonder-blocks/pulls{/number}","milestones_url":"https://api.github.com/repos/Khan/wonder-blocks/milestones{/number}","notifications_url":"https://api.github.com/repos/Khan/wonder-blocks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Khan/wonder-blocks/labels{/name}","releases_url":"https://api.github.com/repos/Khan/wonder-blocks/releases{/id}","deployments_url":"https://api.github.com/repos/Khan/wonder-blocks/deployments","created_at":"2018-02-27T22:50:41Z","updated_at":"2018-04-24T21:05:12Z","pushed_at":"2018-04-24T23:18:24Z","git_url":"git://github.com/Khan/wonder-blocks.git","ssh_url":"git@github.com:Khan/wonder-blocks.git","clone_url":"https://github.com/Khan/wonder-blocks.git","svn_url":"https://github.com/Khan/wonder-blocks","homepage":"https://khan.github.io/wonder-blocks","size":3425,"stargazers_count":13,"watchers_count":13,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":0,"open_issues":4,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Khan/wonder-blocks/pulls/44"},"html":{"href":"https://github.com/Khan/wonder-blocks/pull/44"},"issue":{"href":"https://api.github.com/repos/Khan/wonder-blocks/issues/44"},"comments":{"href":"https://api.github.com/repos/Khan/wonder-blocks/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/Khan/wonder-blocks/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/Khan/wonder-blocks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Khan/wonder-blocks/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/Khan/wonder-blocks/statuses/a8c2ef7696a74a9ad6be0606e66a67da93e6025e"}},"author_association":"OWNER"}}
{"actor":{"display_login":"kevinbarabash"}}