{"action":"created","issue":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/5408","repository_url":"https://api.github.com/repos/ARMmbed/mbed-os","labels_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/5408/labels{/name}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/5408/comments","events_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/5408/events","html_url":"https://github.com/ARMmbed/mbed-os/pull/5408","id":269900490,"number":5408,"title":"Added static allocator option to mbed_trace module","user":{"login":"ryankurte","id":860620,"avatar_url":"https://avatars0.githubusercontent.com/u/860620?v=4","gravatar_id":"","url":"https://api.github.com/users/ryankurte","html_url":"https://github.com/ryankurte","followers_url":"https://api.github.com/users/ryankurte/followers","following_url":"https://api.github.com/users/ryankurte/following{/other_user}","gists_url":"https://api.github.com/users/ryankurte/gists{/gist_id}","starred_url":"https://api.github.com/users/ryankurte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryankurte/subscriptions","organizations_url":"https://api.github.com/users/ryankurte/orgs","repos_url":"https://api.github.com/users/ryankurte/repos","events_url":"https://api.github.com/users/ryankurte/events{/privacy}","received_events_url":"https://api.github.com/users/ryankurte/received_events","type":"User","site_admin":false},"labels":[{"id":147112891,"url":"https://api.github.com/repos/ARMmbed/mbed-os/labels/needs:%20review","name":"needs: review","color":"fbca04","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2017-10-31T10:04:23Z","updated_at":"2018-03-06T03:28:24Z","closed_at":"2018-03-06T03:28:24Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/5408","html_url":"https://github.com/ARMmbed/mbed-os/pull/5408","diff_url":"https://github.com/ARMmbed/mbed-os/pull/5408.diff","patch_url":"https://github.com/ARMmbed/mbed-os/pull/5408.patch"},"body":"## Description\r\nAdds a static allocator option to mbed_trace module, setting the `MBED_TRACE_STATIC` macro will cause memory to be statically allocated for trace use rather than calling malloc within the init function. No changes to existing operation without the macro.\r\n\r\nThis is useful so that trace memory is shown in the allocated static ram, trace can be used when debugging heap issues.\r\n\r\n(I guess the only reason for dynamic is so that it's only allocated if `mbed_trace_init` is called, but, there's also the `\"mbed-trace.enable\": true,` configuration option anyway, so it might be redundant?).\r\n\r\nAlso as a sidenote, it's not clear whether this should be submitted here or to ARMMbed/mbed-trace?\r\n\r\n## Status\r\n**IN DEVELOPMENT**\r\n"},"comment":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/comments/370650312","html_url":"https://github.com/ARMmbed/mbed-os/pull/5408#issuecomment-370650312","issue_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/5408","id":370650312,"user":{"login":"cmonr","id":260086,"avatar_url":"https://avatars1.githubusercontent.com/u/260086?v=4","gravatar_id":"","url":"https://api.github.com/users/cmonr","html_url":"https://github.com/cmonr","followers_url":"https://api.github.com/users/cmonr/followers","following_url":"https://api.github.com/users/cmonr/following{/other_user}","gists_url":"https://api.github.com/users/cmonr/gists{/gist_id}","starred_url":"https://api.github.com/users/cmonr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmonr/subscriptions","organizations_url":"https://api.github.com/users/cmonr/orgs","repos_url":"https://api.github.com/users/cmonr/repos","events_url":"https://api.github.com/users/cmonr/events{/privacy}","received_events_url":"https://api.github.com/users/cmonr/received_events","type":"User","site_admin":false},"created_at":"2018-03-06T03:28:24Z","updated_at":"2018-03-06T03:28:24Z","author_association":"CONTRIBUTOR","body":"Closing this PR for now.\r\n\r\nWe'll reopen if @ryankurte confirms that he's waiting for feedback and/or @SeppoTakalo @jupe reply with feedback to the PR."}}
{"actor":{"display_login":"cmonr"}}