{"action":"created","comment":{"url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/pulls/comments/185434952","pull_request_review_id":116820251,"id":185434952,"diff_hunk":"@@ -26,10 +44,29 @@ public function checkout(CheckedOutRepository $sourceRepository, Revision $revis\n \n     /**\n      * {@inheritDoc}\n-     * @throws RuntimeException\n+     * @throws ProcessRuntimeException\n      */\n     public function remove(CheckedOutRepository $checkedOutRepository) : void\n     {\n         (new Process(['rm', '-rf', (string) $checkedOutRepository]))->mustRun();\n     }\n+\n+    /**\n+     * @throws RuntimeException\n+     */\n+    private function generateTemporaryPathFor(Revision $revision) : string\n+    {\n+        $uniquePathGenerator = $this->uniquenessFunction;\n+        $checkoutDirectory   = sys_get_temp_dir() . '/api-compare-' . $uniquePathGenerator((string) $revision . '_');\n+\n+        if (file_exists($checkoutDirectory) || is_dir($checkoutDirectory)) {\n+            throw new RuntimeException(sprintf(\n+                'Tried to check out revision %s to directory %s which already exists',","path":"src/Git/GitCheckoutRevisionToTemporaryPath.php","position":63,"original_position":63,"commit_id":"266b1e417468bd04aad91871b93e5b15f0eae9c9","original_commit_id":"266b1e417468bd04aad91871b93e5b15f0eae9c9","user":{"login":"Ocramius","id":154256,"avatar_url":"https://avatars2.githubusercontent.com/u/154256?v=4","gravatar_id":"","url":"https://api.github.com/users/Ocramius","html_url":"https://github.com/Ocramius","followers_url":"https://api.github.com/users/Ocramius/followers","following_url":"https://api.github.com/users/Ocramius/following{/other_user}","gists_url":"https://api.github.com/users/Ocramius/gists{/gist_id}","starred_url":"https://api.github.com/users/Ocramius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ocramius/subscriptions","organizations_url":"https://api.github.com/users/Ocramius/orgs","repos_url":"https://api.github.com/users/Ocramius/repos","events_url":"https://api.github.com/users/Ocramius/events{/privacy}","received_events_url":"https://api.github.com/users/Ocramius/received_events","type":"User","site_admin":false},"body":"Put quotes around the `%s` here. Also: exception type seems to be incorrect. Can we use our own please?","created_at":"2018-05-02T09:08:26Z","updated_at":"2018-05-02T09:08:38Z","html_url":"https://github.com/Roave/BackwardCompatibilityCheck/pull/58#discussion_r185434952","pull_request_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/pulls/58","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/pulls/comments/185434952"},"html":{"href":"https://github.com/Roave/BackwardCompatibilityCheck/pull/58#discussion_r185434952"},"pull_request":{"href":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/pulls/58"}}},"pull_request":{"url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/pulls/58","id":185365611,"html_url":"https://github.com/Roave/BackwardCompatibilityCheck/pull/58","diff_url":"https://github.com/Roave/BackwardCompatibilityCheck/pull/58.diff","patch_url":"https://github.com/Roave/BackwardCompatibilityCheck/pull/58.patch","issue_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/issues/58","number":58,"state":"open","locked":false,"title":"Add uniqueness to GitCheckoutRevisionToTemporaryPath to avoid collisions when checking out the same revision from/to","user":{"login":"asgrim","id":496145,"avatar_url":"https://avatars3.githubusercontent.com/u/496145?v=4","gravatar_id":"","url":"https://api.github.com/users/asgrim","html_url":"https://github.com/asgrim","followers_url":"https://api.github.com/users/asgrim/followers","following_url":"https://api.github.com/users/asgrim/following{/other_user}","gists_url":"https://api.github.com/users/asgrim/gists{/gist_id}","starred_url":"https://api.github.com/users/asgrim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asgrim/subscriptions","organizations_url":"https://api.github.com/users/asgrim/orgs","repos_url":"https://api.github.com/users/asgrim/repos","events_url":"https://api.github.com/users/asgrim/events{/privacy}","received_events_url":"https://api.github.com/users/asgrim/received_events","type":"User","site_admin":false},"body":"Fixes #53 \r\n\r\nMaybe a little over engineered, but I think this is fairly bulletproof now :grin: at least we have tests!","created_at":"2018-05-02T08:18:14Z","updated_at":"2018-05-02T09:08:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a0cb998f3d2fe20747b607223fe1f7ed7bd009d1","assignee":{"login":"Ocramius","id":154256,"avatar_url":"https://avatars2.githubusercontent.com/u/154256?v=4","gravatar_id":"","url":"https://api.github.com/users/Ocramius","html_url":"https://github.com/Ocramius","followers_url":"https://api.github.com/users/Ocramius/followers","following_url":"https://api.github.com/users/Ocramius/following{/other_user}","gists_url":"https://api.github.com/users/Ocramius/gists{/gist_id}","starred_url":"https://api.github.com/users/Ocramius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ocramius/subscriptions","organizations_url":"https://api.github.com/users/Ocramius/orgs","repos_url":"https://api.github.com/users/Ocramius/repos","events_url":"https://api.github.com/users/Ocramius/events{/privacy}","received_events_url":"https://api.github.com/users/Ocramius/received_events","type":"User","site_admin":false},"assignees":[{"login":"Ocramius","id":154256,"avatar_url":"https://avatars2.githubusercontent.com/u/154256?v=4","gravatar_id":"","url":"https://api.github.com/users/Ocramius","html_url":"https://github.com/Ocramius","followers_url":"https://api.github.com/users/Ocramius/followers","following_url":"https://api.github.com/users/Ocramius/following{/other_user}","gists_url":"https://api.github.com/users/Ocramius/gists{/gist_id}","starred_url":"https://api.github.com/users/Ocramius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ocramius/subscriptions","organizations_url":"https://api.github.com/users/Ocramius/orgs","repos_url":"https://api.github.com/users/Ocramius/repos","events_url":"https://api.github.com/users/Ocramius/events{/privacy}","received_events_url":"https://api.github.com/users/Ocramius/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":732785775,"url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/labels/bug","name":"bug","color":"ee0701","default":true}],"milestone":{"url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/milestones/1","html_url":"https://github.com/Roave/BackwardCompatibilityCheck/milestone/1","labels_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/milestones/1/labels","id":3123851,"number":1,"title":"0.0.1","description":"","creator":{"login":"asgrim","id":496145,"avatar_url":"https://avatars3.githubusercontent.com/u/496145?v=4","gravatar_id":"","url":"https://api.github.com/users/asgrim","html_url":"https://github.com/asgrim","followers_url":"https://api.github.com/users/asgrim/followers","following_url":"https://api.github.com/users/asgrim/following{/other_user}","gists_url":"https://api.github.com/users/asgrim/gists{/gist_id}","starred_url":"https://api.github.com/users/asgrim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asgrim/subscriptions","organizations_url":"https://api.github.com/users/asgrim/orgs","repos_url":"https://api.github.com/users/asgrim/repos","events_url":"https://api.github.com/users/asgrim/events{/privacy}","received_events_url":"https://api.github.com/users/asgrim/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":32,"state":"open","created_at":"2018-02-17T10:48:18Z","updated_at":"2018-05-02T08:18:14Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/pulls/58/commits","review_comments_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/pulls/58/comments","review_comment_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/issues/58/comments","statuses_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/statuses/266b1e417468bd04aad91871b93e5b15f0eae9c9","head":{"label":"Roave:feature/prevent-path-collisions-when-cloning-repo","ref":"feature/prevent-path-collisions-when-cloning-repo","sha":"266b1e417468bd04aad91871b93e5b15f0eae9c9","user":{"login":"Roave","id":3029050,"avatar_url":"https://avatars0.githubusercontent.com/u/3029050?v=4","gravatar_id":"","url":"https://api.github.com/users/Roave","html_url":"https://github.com/Roave","followers_url":"https://api.github.com/users/Roave/followers","following_url":"https://api.github.com/users/Roave/following{/other_user}","gists_url":"https://api.github.com/users/Roave/gists{/gist_id}","starred_url":"https://api.github.com/users/Roave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Roave/subscriptions","organizations_url":"https://api.github.com/users/Roave/orgs","repos_url":"https://api.github.com/users/Roave/repos","events_url":"https://api.github.com/users/Roave/events{/privacy}","received_events_url":"https://api.github.com/users/Roave/received_events","type":"Organization","site_admin":false},"repo":{"id":108544542,"name":"BackwardCompatibilityCheck","full_name":"Roave/BackwardCompatibilityCheck","owner":{"login":"Roave","id":3029050,"avatar_url":"https://avatars0.githubusercontent.com/u/3029050?v=4","gravatar_id":"","url":"https://api.github.com/users/Roave","html_url":"https://github.com/Roave","followers_url":"https://api.github.com/users/Roave/followers","following_url":"https://api.github.com/users/Roave/following{/other_user}","gists_url":"https://api.github.com/users/Roave/gists{/gist_id}","starred_url":"https://api.github.com/users/Roave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Roave/subscriptions","organizations_url":"https://api.github.com/users/Roave/orgs","repos_url":"https://api.github.com/users/Roave/repos","events_url":"https://api.github.com/users/Roave/events{/privacy}","received_events_url":"https://api.github.com/users/Roave/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Roave/BackwardCompatibilityCheck","description":":ab: Tool to compare two revisions of a class API to check for BC breaks","fork":false,"url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck","forks_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/forks","keys_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/teams","hooks_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/hooks","issue_events_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/issues/events{/number}","events_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/events","assignees_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/assignees{/user}","branches_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/branches{/branch}","tags_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/tags","blobs_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/git/refs{/sha}","trees_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/statuses/{sha}","languages_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/languages","stargazers_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/stargazers","contributors_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/contributors","subscribers_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/subscribers","subscription_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/subscription","commits_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/commits{/sha}","git_commits_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/git/commits{/sha}","comments_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/comments{/number}","issue_comment_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/issues/comments{/number}","contents_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/contents/{+path}","compare_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/merges","archive_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/downloads","issues_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/issues{/number}","pulls_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/pulls{/number}","milestones_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/milestones{/number}","notifications_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/labels{/name}","releases_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/releases{/id}","deployments_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/deployments","created_at":"2017-10-27T12:40:27Z","updated_at":"2018-05-01T11:05:39Z","pushed_at":"2018-05-02T08:59:23Z","git_url":"git://github.com/Roave/BackwardCompatibilityCheck.git","ssh_url":"git@github.com:Roave/BackwardCompatibilityCheck.git","clone_url":"https://github.com/Roave/BackwardCompatibilityCheck.git","svn_url":"https://github.com/Roave/BackwardCompatibilityCheck","homepage":"","size":520,"stargazers_count":70,"watchers_count":70,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":11,"watchers":70,"default_branch":"master"}},"base":{"label":"Roave:master","ref":"master","sha":"7ca287a699976266da5da5e9c3ab6b2d9db4bfd6","user":{"login":"Roave","id":3029050,"avatar_url":"https://avatars0.githubusercontent.com/u/3029050?v=4","gravatar_id":"","url":"https://api.github.com/users/Roave","html_url":"https://github.com/Roave","followers_url":"https://api.github.com/users/Roave/followers","following_url":"https://api.github.com/users/Roave/following{/other_user}","gists_url":"https://api.github.com/users/Roave/gists{/gist_id}","starred_url":"https://api.github.com/users/Roave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Roave/subscriptions","organizations_url":"https://api.github.com/users/Roave/orgs","repos_url":"https://api.github.com/users/Roave/repos","events_url":"https://api.github.com/users/Roave/events{/privacy}","received_events_url":"https://api.github.com/users/Roave/received_events","type":"Organization","site_admin":false},"repo":{"id":108544542,"name":"BackwardCompatibilityCheck","full_name":"Roave/BackwardCompatibilityCheck","owner":{"login":"Roave","id":3029050,"avatar_url":"https://avatars0.githubusercontent.com/u/3029050?v=4","gravatar_id":"","url":"https://api.github.com/users/Roave","html_url":"https://github.com/Roave","followers_url":"https://api.github.com/users/Roave/followers","following_url":"https://api.github.com/users/Roave/following{/other_user}","gists_url":"https://api.github.com/users/Roave/gists{/gist_id}","starred_url":"https://api.github.com/users/Roave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Roave/subscriptions","organizations_url":"https://api.github.com/users/Roave/orgs","repos_url":"https://api.github.com/users/Roave/repos","events_url":"https://api.github.com/users/Roave/events{/privacy}","received_events_url":"https://api.github.com/users/Roave/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Roave/BackwardCompatibilityCheck","description":":ab: Tool to compare two revisions of a class API to check for BC breaks","fork":false,"url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck","forks_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/forks","keys_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/teams","hooks_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/hooks","issue_events_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/issues/events{/number}","events_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/events","assignees_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/assignees{/user}","branches_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/branches{/branch}","tags_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/tags","blobs_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/git/refs{/sha}","trees_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/statuses/{sha}","languages_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/languages","stargazers_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/stargazers","contributors_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/contributors","subscribers_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/subscribers","subscription_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/subscription","commits_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/commits{/sha}","git_commits_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/git/commits{/sha}","comments_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/comments{/number}","issue_comment_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/issues/comments{/number}","contents_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/contents/{+path}","compare_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/merges","archive_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/downloads","issues_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/issues{/number}","pulls_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/pulls{/number}","milestones_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/milestones{/number}","notifications_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/labels{/name}","releases_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/releases{/id}","deployments_url":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/deployments","created_at":"2017-10-27T12:40:27Z","updated_at":"2018-05-01T11:05:39Z","pushed_at":"2018-05-02T08:59:23Z","git_url":"git://github.com/Roave/BackwardCompatibilityCheck.git","ssh_url":"git@github.com:Roave/BackwardCompatibilityCheck.git","clone_url":"https://github.com/Roave/BackwardCompatibilityCheck.git","svn_url":"https://github.com/Roave/BackwardCompatibilityCheck","homepage":"","size":520,"stargazers_count":70,"watchers_count":70,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":11,"watchers":70,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/pulls/58"},"html":{"href":"https://github.com/Roave/BackwardCompatibilityCheck/pull/58"},"issue":{"href":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/issues/58"},"comments":{"href":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/issues/58/comments"},"review_comments":{"href":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/pulls/58/comments"},"review_comment":{"href":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/pulls/58/commits"},"statuses":{"href":"https://api.github.com/repos/Roave/BackwardCompatibilityCheck/statuses/266b1e417468bd04aad91871b93e5b15f0eae9c9"}},"author_association":"OWNER"}}
{"actor":{"display_login":"Ocramius"}}