{"push_id":2533342540,"size":15,"distinct_size":1,"ref":"refs/heads/chromium-export-cl-1038888","head":"44b4bfcfde0012f194ba6bb63afaaa3f2e427ea9","before":"5b94dc0e5b6efd1530fea83771d24ddb3f598254","commits":[{"sha":"b80e34cf9ff791e051b2cd3978cf8c5514aef4df","author":{"name":"Vince Falconi","email":"8a69349750d4d0b526594957adec4a6cf262e3cd@gmail.com"},"message":"CSS_flexbox: Add test for first-letter","distinct":false,"url":"https://api.github.com/repos/w3c/web-platform-tests/commits/b80e34cf9ff791e051b2cd3978cf8c5514aef4df"},{"sha":"39563cf141605683bb8d76abb74eaa0c764d6c65","author":{"name":"Morten Stenshorne","email":"f0c0567e887539ebd0e817b4f3eeaf2dd3286d90@chromium.org"},"message":"[LayoutNG] Improve handling of adjoining floats.\n\nA float always needs to be positioned by its block parent, so passing\nthem around to children, parents or siblings really shouldn't be\nnecessary (and it *was* somewhat confusing, since nobody but the direct\nfloat parent is allowed to touch them anyway, apart from placing them\ninto temporary exclusion spaces). The main reason for passing them\naround like that, was for other blocks to determine, based on the list\nof floats being empty or not, the need for relayout once the BFC offset\nwas resolved.\n\nInstead, confine the list of unpositioned floats to the block parent of\nthose floats, and introduce the concept of adjoining float types (none,\nleft, right, both). Adjoining floats occur when the BFC offset is\nunknown, meaning that their position may be affected by the current\nlayout algorithm.\n\nAdjoining float types will now be the thing that's both input to and\noutput from the layout algorithms. Having something other than \"none\"\nmeans that a block's BFC offset is unknown, but that doesn't\nautomatically mean that we have to abort and re-layout if the BFC offset\ngets resolved. If the \"floats BFC offset\" is known, for instance, those\nadjoining floats may be positioned right away. Still we need to know\nabout them (positioned or not), to get clearance correct.\n\nWe're going to need to treat adjoining floats specially when applying\nclearance. Will deal with that in a later CL. For now, we just keep\ntrack of the adjoining float types, so that the clearance machinery can\ntell that there are floats there that may not yet be positioned. That\nused to be taken care of the list of unpositioned floats, but, as\npreviously stated, adjoining floats are special, and we need to know\nabout them, whether they are positioned or not. This is a preparatory CL\nfor that.\n\nEach time we add an unpositioned float, we need to update the types of\nadjoining floats, so that these can be returned from the algorithm if\nnecessary. Whether they end up being positioned right away or not isn't\nrelevant. Adjoining is adjoining.\n\nNote that we don't have to #include the header file for unpositioned\nfloats as much as before now, but I'll clean that up in a follow-up CL,\nbecause it turned out that there were quite a few translation units that\ngot stuff for free via that header file, instead of explicitly including\nwhat they need.\n\nHad to rewrite how we deal with floats in HandleNewFormattingContext()\nand LayoutNewFormattingContext(), since those depended on a list of all\npreceding unpositioned floats to place them into a temporary exclusion\nspace, to figure out whether to let the child's margin be adjoining with\nthe current margin strut or not. Instead of using a temporary exclusion\nspace, we now position floats via the regular mechanisms, and initially\nassume that the child's margin is going to be adjoining. This means that\nwe have to abort and roll back if there are preceding unpositioned\nfloats. This is no different from how we lay out regular blocks, though.\nWhat *is* different is that if it turns out that the child's margin has\nto be separated from the strut, we'll have to abort and roll back\nonce *again* (but only once).\n\nThe algorithms now need to keep track of whether they need to abort if\nthe BFC offset *changes*, rather than if it is *resolved*. We only allow\nthe offset to resolve and optionally change *once* afterwards, though.\n\nCq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng\nChange-Id: Ie527d659213049f180ebedc764e1d7f4926a5876\nReviewed-on: https://chromium-review.googlesource.com/1030191\nCommit-Queue: Morten Stenshorne <mstensho@chromium.org>\nReviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>\nReviewed-by: Koji Ishii <kojii@chromium.org>\nCr-Commit-Position: refs/heads/master@{#555314}","distinct":false,"url":"https://api.github.com/repos/w3c/web-platform-tests/commits/39563cf141605683bb8d76abb74eaa0c764d6c65"},{"sha":"e47396d5c643c6a0bc4782045a8cc77233df3514","author":{"name":"Anne van Kesteren","email":"dd68526ae718778765570fcfc846202490c91492@annevk.nl"},"message":"Fetch: fix and cleanup api/cors\n\ncors-multiple-origins went against the specification and required support for multiple origins listed in Access-Control-Allow-Origin.","distinct":false,"url":"https://api.github.com/repos/w3c/web-platform-tests/commits/e47396d5c643c6a0bc4782045a8cc77233df3514"},{"sha":"27a3aebab97421d95a14c7fd7b3d051773cfd199","author":{"name":"Anne van Kesteren","email":"dd68526ae718778765570fcfc846202490c91492@annevk.nl"},"message":"Fetch: cleanup api/redirect","distinct":false,"url":"https://api.github.com/repos/w3c/web-platform-tests/commits/27a3aebab97421d95a14c7fd7b3d051773cfd199"},{"sha":"a13c9f65c007ddde78fe6c99c0f173dbc87cd245","author":{"name":"Anne van Kesteren","email":"dd68526ae718778765570fcfc846202490c91492@annevk.nl"},"message":"Correct document.domain setter test\n\nFixes #10695.","distinct":false,"url":"https://api.github.com/repos/w3c/web-platform-tests/commits/a13c9f65c007ddde78fe6c99c0f173dbc87cd245"},{"sha":"dce95ec0d867129a8f4810330b473eca3e515cea","author":{"name":"Chris Nardi","email":"b325611ab072bcce600826f236927c17d5a2c0e5@hotmail.com"},"message":"Cleanup CSSOM View interfaces test\n\nThe CSSOM View interfaces test added the Geometry IDL as untested, but it is never needed (removing it does not affect test results). Removing it means that less IDL needs to be parsed, speeding up the test.\n\nThe test also adds Document as an object twice, and refers to the CSSOM spec instead of the CSSOM View spec. This change fixes both of these issues as well.","distinct":false,"url":"https://api.github.com/repos/w3c/web-platform-tests/commits/dce95ec0d867129a8f4810330b473eca3e515cea"},{"sha":"9574f8f71a72f87a44c21de5019f49bee8993aed","author":{"name":"Geoffrey Sneddon","email":"b1c1d8736f20db3fb6c1c66bb1455ed43909f0d8@gsnedders.com"},"message":"Delete CNAME","distinct":false,"url":"https://api.github.com/repos/w3c/web-platform-tests/commits/9574f8f71a72f87a44c21de5019f49bee8993aed"},{"sha":"e11c5ceb5501452b51067687b5532c8966970f70","author":{"name":"Geoffrey Sneddon","email":"b1c1d8736f20db3fb6c1c66bb1455ed43909f0d8@gsnedders.com"},"message":"Create CNAME","distinct":false,"url":"https://api.github.com/repos/w3c/web-platform-tests/commits/e11c5ceb5501452b51067687b5532c8966970f70"},{"sha":"615504bd195b931a43a7a2ba6403c67dd29bdfd7","author":{"name":"Ms2ger","email":"172bd0bc5aaf2802c05d15febe8a8a88b46ca9e9@gmail.com"},"message":"Remove unused css-mode argument to the lint. (#10765)","distinct":false,"url":"https://api.github.com/repos/w3c/web-platform-tests/commits/615504bd195b931a43a7a2ba6403c67dd29bdfd7"},{"sha":"538eedafb15733c6113b44998170a6bbdae7518b","author":{"name":"Manuel Rego Casasnovas","email":"426c54bf154ff8d1bfecfdb0f393e8e07cde8f7a@igalia.com"},"message":"[css-grid] Subtract scrollbar in ComputeReplacedLogicalHeightUsing()\n\nIn LayoutBox::ComputeReplacedLogicalHeightUsing() we were using\nthe OverrideContentLogicalHeight() plus scrollbar height,\nthat was wrong and we should subtract the scrollbar too.\nThis caused issues to resolve the percentage heights on grid item\nreplaced children, if the grid item has a scrollbar.\n\nTo fix the issue we just need to follow the suggestion in the TODO\nand use OverrideContentLogicalHeight() directly.\n\nThis was the last place using OverrideContentAndScrollbarLogicalHeight()\nso we can get rid of it. The patch removes that method together with\nOverrideContentAndScrollbarLogicalWidth() that was no longer used.\n\nBUG=837141\nTEST=external/wpt/css/css-grid/grid-items/percentage-size-replaced-subitems-001.html\n\nChange-Id: I28cf6e65c21e6314808c4430515f06c07d4a739e\nReviewed-on: https://chromium-review.googlesource.com/1035003\nReviewed-by: Morten Stenshorne <mstensho@chromium.org>\nCommit-Queue: Manuel Rego Casasnovas <rego@igalia.com>\nCr-Commit-Position: refs/heads/master@{#554834}","distinct":false,"url":"https://api.github.com/repos/w3c/web-platform-tests/commits/538eedafb15733c6113b44998170a6bbdae7518b"},{"sha":"a7a988cbb5edb58b50f200a66057a0d5620209a8","author":{"name":"Simon Pieters","email":"ee8926a0d0f2578e82ffd5ea01334d3f052a5e96@gmail.com"},"message":"Add old-tests/OWNERS (#10759)","distinct":false,"url":"https://api.github.com/repos/w3c/web-platform-tests/commits/a7a988cbb5edb58b50f200a66057a0d5620209a8"},{"sha":"923d852c61cb50cb3be540dcbf54f2d5ec1518e1","author":{"name":"Anne van Kesteren","email":"dd68526ae718778765570fcfc846202490c91492@annevk.nl"},"message":"HTML: document.open() event listener removal\n\nFor https://github.com/whatwg/html/pull/3653.","distinct":false,"url":"https://api.github.com/repos/w3c/web-platform-tests/commits/923d852c61cb50cb3be540dcbf54f2d5ec1518e1"},{"sha":"a6fdca312f0774eda1fcf6c524bc2de47941ede9","author":{"name":"Greg Whitworth","email":"60fd6aaf4ee37ef7de21cc91982c02b1f44d9cad@outlook.com"},"message":"Merge pull request #10625 from vfalconi/add_flexbox_first-letter_test\n\nCSS-Flexbox: Add test for first-letter","distinct":false,"url":"https://api.github.com/repos/w3c/web-platform-tests/commits/a6fdca312f0774eda1fcf6c524bc2de47941ede9"},{"sha":"a253aa374f4b9cb0ca05bd6c37143774fa725f96","author":{"name":"Ms2ger","email":"172bd0bc5aaf2802c05d15febe8a8a88b46ca9e9@gmail.com"},"message":"Fix typo in documentation of SourceFile.content_is_css_visual(). (#10786)","distinct":false,"url":"https://api.github.com/repos/w3c/web-platform-tests/commits/a253aa374f4b9cb0ca05bd6c37143774fa725f96"},{"sha":"44b4bfcfde0012f194ba6bb63afaaa3f2e427ea9","author":{"name":"Joe Downing","email":"ec60c9caac61b7b5fc3a33aa56187c818f16d116@chromium.org"},"message":"[KeyboardLock] Ensure API is called from a top-level browsing context\n\nThis change adds some checks to the keyboard lock API to ensure it was\ncalled from within a supported context, otherwise it now rejects the\npromise.\n\nBUG=680809\n\nChange-Id: I3d127422c640d16e43c22adb14755b65eb2cdc6a\nReviewed-on: https://chromium-review.googlesource.com/1038888\nReviewed-by: Gary Kacmarcik <garykac@chromium.org>\nCommit-Queue: Joe Downing <joedow@chromium.org>\nCr-Commit-Position: refs/heads/master@{#555417}","distinct":true,"url":"https://api.github.com/repos/w3c/web-platform-tests/commits/44b4bfcfde0012f194ba6bb63afaaa3f2e427ea9"}]}
{"actor":{"display_login":"chromium-wpt-export-bot"}}