{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/magento/bulk-api-ce/pulls/1","id":163753745,"html_url":"https://github.com/magento/bulk-api-ce/pull/1","diff_url":"https://github.com/magento/bulk-api-ce/pull/1.diff","patch_url":"https://github.com/magento/bulk-api-ce/pull/1.patch","issue_url":"https://api.github.com/repos/magento/bulk-api-ce/issues/1","number":1,"state":"closed","locked":false,"title":"Change Webapi extension to use Inject Pool logic ","user":{"login":"nuzil","id":1667889,"avatar_url":"https://avatars0.githubusercontent.com/u/1667889?v=4","gravatar_id":"","url":"https://api.github.com/users/nuzil","html_url":"https://github.com/nuzil","followers_url":"https://api.github.com/users/nuzil/followers","following_url":"https://api.github.com/users/nuzil/following{/other_user}","gists_url":"https://api.github.com/users/nuzil/gists{/gist_id}","starred_url":"https://api.github.com/users/nuzil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuzil/subscriptions","organizations_url":"https://api.github.com/users/nuzil/orgs","repos_url":"https://api.github.com/users/nuzil/repos","events_url":"https://api.github.com/users/nuzil/events{/privacy}","received_events_url":"https://api.github.com/users/nuzil/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\nWe extended Magento/Webapi extension. This allowed us to use Request Processors Pool and avoid of using if/else statements in \\Magento\\Webapi\\Controller\\Rest.php\r\n\r\nSo now any new processor can be easily added via webapi_rest/di.xml file in any extension.\r\n\r\nThis modification will add much more flexibility in Magento customisations. \r\n\r\n### Manual testing scenarios\r\nHere is no new feature developed, so Manual test will be in testing default Magento API calls\r\n","created_at":"2018-01-18T16:08:58Z","updated_at":"2018-03-21T21:41:38Z","closed_at":"2018-03-21T21:41:38Z","merged_at":"2018-03-21T21:41:38Z","merge_commit_sha":"e736b7a2111d024943ad70fa01a7ed2bb1f4e447","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/magento/bulk-api-ce/pulls/1/commits","review_comments_url":"https://api.github.com/repos/magento/bulk-api-ce/pulls/1/comments","review_comment_url":"https://api.github.com/repos/magento/bulk-api-ce/pulls/comments{/number}","comments_url":"https://api.github.com/repos/magento/bulk-api-ce/issues/1/comments","statuses_url":"https://api.github.com/repos/magento/bulk-api-ce/statuses/e736b7a2111d024943ad70fa01a7ed2bb1f4e447","head":{"label":"comwrap:feature/bulk-7","ref":"feature/bulk-7","sha":"e736b7a2111d024943ad70fa01a7ed2bb1f4e447","user":{"login":"comwrap","id":6358844,"avatar_url":"https://avatars0.githubusercontent.com/u/6358844?v=4","gravatar_id":"","url":"https://api.github.com/users/comwrap","html_url":"https://github.com/comwrap","followers_url":"https://api.github.com/users/comwrap/followers","following_url":"https://api.github.com/users/comwrap/following{/other_user}","gists_url":"https://api.github.com/users/comwrap/gists{/gist_id}","starred_url":"https://api.github.com/users/comwrap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/comwrap/subscriptions","organizations_url":"https://api.github.com/users/comwrap/orgs","repos_url":"https://api.github.com/users/comwrap/repos","events_url":"https://api.github.com/users/comwrap/events{/privacy}","received_events_url":"https://api.github.com/users/comwrap/received_events","type":"Organization","site_admin":false},"repo":{"id":117983385,"name":"bulk-api-ce","full_name":"comwrap/bulk-api-ce","owner":{"login":"comwrap","id":6358844,"avatar_url":"https://avatars0.githubusercontent.com/u/6358844?v=4","gravatar_id":"","url":"https://api.github.com/users/comwrap","html_url":"https://github.com/comwrap","followers_url":"https://api.github.com/users/comwrap/followers","following_url":"https://api.github.com/users/comwrap/following{/other_user}","gists_url":"https://api.github.com/users/comwrap/gists{/gist_id}","starred_url":"https://api.github.com/users/comwrap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/comwrap/subscriptions","organizations_url":"https://api.github.com/users/comwrap/orgs","repos_url":"https://api.github.com/users/comwrap/repos","events_url":"https://api.github.com/users/comwrap/events{/privacy}","received_events_url":"https://api.github.com/users/comwrap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/comwrap/bulk-api-ce","description":"Magento 2 CE repository dedicated for implementation of the Bulk API","fork":true,"url":"https://api.github.com/repos/comwrap/bulk-api-ce","forks_url":"https://api.github.com/repos/comwrap/bulk-api-ce/forks","keys_url":"https://api.github.com/repos/comwrap/bulk-api-ce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/comwrap/bulk-api-ce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/comwrap/bulk-api-ce/teams","hooks_url":"https://api.github.com/repos/comwrap/bulk-api-ce/hooks","issue_events_url":"https://api.github.com/repos/comwrap/bulk-api-ce/issues/events{/number}","events_url":"https://api.github.com/repos/comwrap/bulk-api-ce/events","assignees_url":"https://api.github.com/repos/comwrap/bulk-api-ce/assignees{/user}","branches_url":"https://api.github.com/repos/comwrap/bulk-api-ce/branches{/branch}","tags_url":"https://api.github.com/repos/comwrap/bulk-api-ce/tags","blobs_url":"https://api.github.com/repos/comwrap/bulk-api-ce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/comwrap/bulk-api-ce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/comwrap/bulk-api-ce/git/refs{/sha}","trees_url":"https://api.github.com/repos/comwrap/bulk-api-ce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/comwrap/bulk-api-ce/statuses/{sha}","languages_url":"https://api.github.com/repos/comwrap/bulk-api-ce/languages","stargazers_url":"https://api.github.com/repos/comwrap/bulk-api-ce/stargazers","contributors_url":"https://api.github.com/repos/comwrap/bulk-api-ce/contributors","subscribers_url":"https://api.github.com/repos/comwrap/bulk-api-ce/subscribers","subscription_url":"https://api.github.com/repos/comwrap/bulk-api-ce/subscription","commits_url":"https://api.github.com/repos/comwrap/bulk-api-ce/commits{/sha}","git_commits_url":"https://api.github.com/repos/comwrap/bulk-api-ce/git/commits{/sha}","comments_url":"https://api.github.com/repos/comwrap/bulk-api-ce/comments{/number}","issue_comment_url":"https://api.github.com/repos/comwrap/bulk-api-ce/issues/comments{/number}","contents_url":"https://api.github.com/repos/comwrap/bulk-api-ce/contents/{+path}","compare_url":"https://api.github.com/repos/comwrap/bulk-api-ce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/comwrap/bulk-api-ce/merges","archive_url":"https://api.github.com/repos/comwrap/bulk-api-ce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/comwrap/bulk-api-ce/downloads","issues_url":"https://api.github.com/repos/comwrap/bulk-api-ce/issues{/number}","pulls_url":"https://api.github.com/repos/comwrap/bulk-api-ce/pulls{/number}","milestones_url":"https://api.github.com/repos/comwrap/bulk-api-ce/milestones{/number}","notifications_url":"https://api.github.com/repos/comwrap/bulk-api-ce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/comwrap/bulk-api-ce/labels{/name}","releases_url":"https://api.github.com/repos/comwrap/bulk-api-ce/releases{/id}","deployments_url":"https://api.github.com/repos/comwrap/bulk-api-ce/deployments","created_at":"2018-01-18T13:00:28Z","updated_at":"2018-03-20T08:17:25Z","pushed_at":"2018-03-20T19:14:14Z","git_url":"git://github.com/comwrap/bulk-api-ce.git","ssh_url":"git@github.com:comwrap/bulk-api-ce.git","clone_url":"https://github.com/comwrap/bulk-api-ce.git","svn_url":"https://github.com/comwrap/bulk-api-ce","homepage":null,"size":333641,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"2.3-develop"}},"base":{"label":"magento:2.3-develop","ref":"2.3-develop","sha":"57f4ad239f8600c8e69e6e1e7c456b16accab423","user":{"login":"magento","id":168457,"avatar_url":"https://avatars2.githubusercontent.com/u/168457?v=4","gravatar_id":"","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"repo":{"id":116662799,"name":"bulk-api-ce","full_name":"magento/bulk-api-ce","owner":{"login":"magento","id":168457,"avatar_url":"https://avatars2.githubusercontent.com/u/168457?v=4","gravatar_id":"","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/magento/bulk-api-ce","description":"Magento 2 CE repository dedicated for implementation of the Bulk API","fork":false,"url":"https://api.github.com/repos/magento/bulk-api-ce","forks_url":"https://api.github.com/repos/magento/bulk-api-ce/forks","keys_url":"https://api.github.com/repos/magento/bulk-api-ce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magento/bulk-api-ce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magento/bulk-api-ce/teams","hooks_url":"https://api.github.com/repos/magento/bulk-api-ce/hooks","issue_events_url":"https://api.github.com/repos/magento/bulk-api-ce/issues/events{/number}","events_url":"https://api.github.com/repos/magento/bulk-api-ce/events","assignees_url":"https://api.github.com/repos/magento/bulk-api-ce/assignees{/user}","branches_url":"https://api.github.com/repos/magento/bulk-api-ce/branches{/branch}","tags_url":"https://api.github.com/repos/magento/bulk-api-ce/tags","blobs_url":"https://api.github.com/repos/magento/bulk-api-ce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magento/bulk-api-ce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magento/bulk-api-ce/git/refs{/sha}","trees_url":"https://api.github.com/repos/magento/bulk-api-ce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magento/bulk-api-ce/statuses/{sha}","languages_url":"https://api.github.com/repos/magento/bulk-api-ce/languages","stargazers_url":"https://api.github.com/repos/magento/bulk-api-ce/stargazers","contributors_url":"https://api.github.com/repos/magento/bulk-api-ce/contributors","subscribers_url":"https://api.github.com/repos/magento/bulk-api-ce/subscribers","subscription_url":"https://api.github.com/repos/magento/bulk-api-ce/subscription","commits_url":"https://api.github.com/repos/magento/bulk-api-ce/commits{/sha}","git_commits_url":"https://api.github.com/repos/magento/bulk-api-ce/git/commits{/sha}","comments_url":"https://api.github.com/repos/magento/bulk-api-ce/comments{/number}","issue_comment_url":"https://api.github.com/repos/magento/bulk-api-ce/issues/comments{/number}","contents_url":"https://api.github.com/repos/magento/bulk-api-ce/contents/{+path}","compare_url":"https://api.github.com/repos/magento/bulk-api-ce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magento/bulk-api-ce/merges","archive_url":"https://api.github.com/repos/magento/bulk-api-ce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magento/bulk-api-ce/downloads","issues_url":"https://api.github.com/repos/magento/bulk-api-ce/issues{/number}","pulls_url":"https://api.github.com/repos/magento/bulk-api-ce/pulls{/number}","milestones_url":"https://api.github.com/repos/magento/bulk-api-ce/milestones{/number}","notifications_url":"https://api.github.com/repos/magento/bulk-api-ce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magento/bulk-api-ce/labels{/name}","releases_url":"https://api.github.com/repos/magento/bulk-api-ce/releases{/id}","deployments_url":"https://api.github.com/repos/magento/bulk-api-ce/deployments","created_at":"2018-01-08T10:30:09Z","updated_at":"2018-03-20T19:40:29Z","pushed_at":"2018-03-21T21:41:36Z","git_url":"git://github.com/magento/bulk-api-ce.git","ssh_url":"git@github.com:magento/bulk-api-ce.git","clone_url":"https://github.com/magento/bulk-api-ce.git","svn_url":"https://github.com/magento/bulk-api-ce","homepage":null,"size":333901,"stargazers_count":6,"watchers_count":6,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3,"open_issues":4,"watchers":6,"default_branch":"2.3-develop"}},"_links":{"self":{"href":"https://api.github.com/repos/magento/bulk-api-ce/pulls/1"},"html":{"href":"https://github.com/magento/bulk-api-ce/pull/1"},"issue":{"href":"https://api.github.com/repos/magento/bulk-api-ce/issues/1"},"comments":{"href":"https://api.github.com/repos/magento/bulk-api-ce/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/magento/bulk-api-ce/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/magento/bulk-api-ce/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/magento/bulk-api-ce/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/magento/bulk-api-ce/statuses/e736b7a2111d024943ad70fa01a7ed2bb1f4e447"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"vrann","id":2277722,"avatar_url":"https://avatars2.githubusercontent.com/u/2277722?v=4","gravatar_id":"","url":"https://api.github.com/users/vrann","html_url":"https://github.com/vrann","followers_url":"https://api.github.com/users/vrann/followers","following_url":"https://api.github.com/users/vrann/following{/other_user}","gists_url":"https://api.github.com/users/vrann/gists{/gist_id}","starred_url":"https://api.github.com/users/vrann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrann/subscriptions","organizations_url":"https://api.github.com/users/vrann/orgs","repos_url":"https://api.github.com/users/vrann/repos","events_url":"https://api.github.com/users/vrann/events{/privacy}","received_events_url":"https://api.github.com/users/vrann/received_events","type":"User","site_admin":false},"comments":1,"review_comments":36,"maintainer_can_modify":false,"commits":19,"additions":503,"deletions":220,"changed_files":8}}
{"actor":{"display_login":"vrann"}}