{"action":"created","comment":{"url":"https://api.github.com/repos/NSLS-II/ophyd/pulls/comments/193072345","pull_request_review_id":125969531,"id":193072345,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzA3MjM0NQ==","diff_hunk":"@@ -632,6 +633,56 @@ class ROIPlugin(PluginBase):\n                   doc='Minimum size of the ROI in XYZ',\n                   default_read_attrs=('min_x', 'min_y', 'min_z'))\n \n+    def set(self, region):\n+        ''' This functions allows for the ROI regions to be set.\n+\n+        This function takes in an ROI_number, and a dictionary of tuples and sets the ROI region.\n+\n+        PARAMETERS\n+        ----------\n+        region: dictionary.\n+            A dictionary defining the region to be set, which has the structure:\n+            { 'x':[min, size], 'y':[min, size], 'z':[min, size]}. \n+            Any of the keywords can be ommitted, and they will be ignored.\n+        '''\n+        if region is not None:\n+            for direction, value in region.items():\n+                getattr(self, f'min_xyz.min_{direction}').put(value[0])","path":"ophyd/areadetector/plugins.py","position":26,"original_position":26,"commit_id":"1c6e350edd8d3b269dd222b36b7a93b20450381d","original_commit_id":"1c6e350edd8d3b269dd222b36b7a93b20450381d","user":{"login":"tacaswell","id":199813,"node_id":"MDQ6VXNlcjE5OTgxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/199813?v=4","gravatar_id":"","url":"https://api.github.com/users/tacaswell","html_url":"https://github.com/tacaswell","followers_url":"https://api.github.com/users/tacaswell/followers","following_url":"https://api.github.com/users/tacaswell/following{/other_user}","gists_url":"https://api.github.com/users/tacaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/tacaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tacaswell/subscriptions","organizations_url":"https://api.github.com/users/tacaswell/orgs","repos_url":"https://api.github.com/users/tacaswell/repos","events_url":"https://api.github.com/users/tacaswell/events{/privacy}","received_events_url":"https://api.github.com/users/tacaswell/received_events","type":"User","site_admin":false},"body":"we should use `set` and `&` all of the status object together instead of returning `NullStatus` here.","created_at":"2018-06-05T13:32:17Z","updated_at":"2018-06-05T13:32:17Z","html_url":"https://github.com/NSLS-II/ophyd/pull/568#discussion_r193072345","pull_request_url":"https://api.github.com/repos/NSLS-II/ophyd/pulls/568","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/NSLS-II/ophyd/pulls/comments/193072345"},"html":{"href":"https://github.com/NSLS-II/ophyd/pull/568#discussion_r193072345"},"pull_request":{"href":"https://api.github.com/repos/NSLS-II/ophyd/pulls/568"}}},"pull_request":{"url":"https://api.github.com/repos/NSLS-II/ophyd/pulls/568","id":192667696,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyNjY3Njk2","html_url":"https://github.com/NSLS-II/ophyd/pull/568","diff_url":"https://github.com/NSLS-II/ophyd/pull/568.diff","patch_url":"https://github.com/NSLS-II/ophyd/pull/568.patch","issue_url":"https://api.github.com/repos/NSLS-II/ophyd/issues/568","number":568,"state":"open","locked":false,"title":"ROIplugin update to include 'set', 'read' and 'describe' attributes ","user":{"login":"awalter-bnl","id":25772709,"node_id":"MDQ6VXNlcjI1NzcyNzA5","avatar_url":"https://avatars3.githubusercontent.com/u/25772709?v=4","gravatar_id":"","url":"https://api.github.com/users/awalter-bnl","html_url":"https://github.com/awalter-bnl","followers_url":"https://api.github.com/users/awalter-bnl/followers","following_url":"https://api.github.com/users/awalter-bnl/following{/other_user}","gists_url":"https://api.github.com/users/awalter-bnl/gists{/gist_id}","starred_url":"https://api.github.com/users/awalter-bnl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awalter-bnl/subscriptions","organizations_url":"https://api.github.com/users/awalter-bnl/orgs","repos_url":"https://api.github.com/users/awalter-bnl/repos","events_url":"https://api.github.com/users/awalter-bnl/events{/privacy}","received_events_url":"https://api.github.com/users/awalter-bnl/received_events","type":"User","site_admin":false},"body":"This adds the set, read and describe attributes to the ROIplugin class. This allows the ROI regions to be 'set' and 'read' like normal positioners, and hence allows them to be included into 'log_pos' an 'baseline' readings as well as being set in 'mv(....)' plans.\r\nThis was added after seeing that a beamline had made some changes to allow this functionality in there startup file.\r\n\r\n","created_at":"2018-06-05T10:58:32Z","updated_at":"2018-06-05T13:32:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ef66ebc0282f77eaf0f780cabdd7fba3183a3c5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/NSLS-II/ophyd/pulls/568/commits","review_comments_url":"https://api.github.com/repos/NSLS-II/ophyd/pulls/568/comments","review_comment_url":"https://api.github.com/repos/NSLS-II/ophyd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NSLS-II/ophyd/issues/568/comments","statuses_url":"https://api.github.com/repos/NSLS-II/ophyd/statuses/1c6e350edd8d3b269dd222b36b7a93b20450381d","head":{"label":"awalter-bnl:ADbase_ROI_update","ref":"ADbase_ROI_update","sha":"1c6e350edd8d3b269dd222b36b7a93b20450381d","user":{"login":"awalter-bnl","id":25772709,"node_id":"MDQ6VXNlcjI1NzcyNzA5","avatar_url":"https://avatars3.githubusercontent.com/u/25772709?v=4","gravatar_id":"","url":"https://api.github.com/users/awalter-bnl","html_url":"https://github.com/awalter-bnl","followers_url":"https://api.github.com/users/awalter-bnl/followers","following_url":"https://api.github.com/users/awalter-bnl/following{/other_user}","gists_url":"https://api.github.com/users/awalter-bnl/gists{/gist_id}","starred_url":"https://api.github.com/users/awalter-bnl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awalter-bnl/subscriptions","organizations_url":"https://api.github.com/users/awalter-bnl/orgs","repos_url":"https://api.github.com/users/awalter-bnl/repos","events_url":"https://api.github.com/users/awalter-bnl/events{/privacy}","received_events_url":"https://api.github.com/users/awalter-bnl/received_events","type":"User","site_admin":false},"repo":{"id":134284792,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQyODQ3OTI=","name":"ophyd","full_name":"awalter-bnl/ophyd","owner":{"login":"awalter-bnl","id":25772709,"node_id":"MDQ6VXNlcjI1NzcyNzA5","avatar_url":"https://avatars3.githubusercontent.com/u/25772709?v=4","gravatar_id":"","url":"https://api.github.com/users/awalter-bnl","html_url":"https://github.com/awalter-bnl","followers_url":"https://api.github.com/users/awalter-bnl/followers","following_url":"https://api.github.com/users/awalter-bnl/following{/other_user}","gists_url":"https://api.github.com/users/awalter-bnl/gists{/gist_id}","starred_url":"https://api.github.com/users/awalter-bnl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awalter-bnl/subscriptions","organizations_url":"https://api.github.com/users/awalter-bnl/orgs","repos_url":"https://api.github.com/users/awalter-bnl/repos","events_url":"https://api.github.com/users/awalter-bnl/events{/privacy}","received_events_url":"https://api.github.com/users/awalter-bnl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/awalter-bnl/ophyd","description":"Python/EPICS-based device abstraction","fork":true,"url":"https://api.github.com/repos/awalter-bnl/ophyd","forks_url":"https://api.github.com/repos/awalter-bnl/ophyd/forks","keys_url":"https://api.github.com/repos/awalter-bnl/ophyd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awalter-bnl/ophyd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awalter-bnl/ophyd/teams","hooks_url":"https://api.github.com/repos/awalter-bnl/ophyd/hooks","issue_events_url":"https://api.github.com/repos/awalter-bnl/ophyd/issues/events{/number}","events_url":"https://api.github.com/repos/awalter-bnl/ophyd/events","assignees_url":"https://api.github.com/repos/awalter-bnl/ophyd/assignees{/user}","branches_url":"https://api.github.com/repos/awalter-bnl/ophyd/branches{/branch}","tags_url":"https://api.github.com/repos/awalter-bnl/ophyd/tags","blobs_url":"https://api.github.com/repos/awalter-bnl/ophyd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awalter-bnl/ophyd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awalter-bnl/ophyd/git/refs{/sha}","trees_url":"https://api.github.com/repos/awalter-bnl/ophyd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awalter-bnl/ophyd/statuses/{sha}","languages_url":"https://api.github.com/repos/awalter-bnl/ophyd/languages","stargazers_url":"https://api.github.com/repos/awalter-bnl/ophyd/stargazers","contributors_url":"https://api.github.com/repos/awalter-bnl/ophyd/contributors","subscribers_url":"https://api.github.com/repos/awalter-bnl/ophyd/subscribers","subscription_url":"https://api.github.com/repos/awalter-bnl/ophyd/subscription","commits_url":"https://api.github.com/repos/awalter-bnl/ophyd/commits{/sha}","git_commits_url":"https://api.github.com/repos/awalter-bnl/ophyd/git/commits{/sha}","comments_url":"https://api.github.com/repos/awalter-bnl/ophyd/comments{/number}","issue_comment_url":"https://api.github.com/repos/awalter-bnl/ophyd/issues/comments{/number}","contents_url":"https://api.github.com/repos/awalter-bnl/ophyd/contents/{+path}","compare_url":"https://api.github.com/repos/awalter-bnl/ophyd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awalter-bnl/ophyd/merges","archive_url":"https://api.github.com/repos/awalter-bnl/ophyd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awalter-bnl/ophyd/downloads","issues_url":"https://api.github.com/repos/awalter-bnl/ophyd/issues{/number}","pulls_url":"https://api.github.com/repos/awalter-bnl/ophyd/pulls{/number}","milestones_url":"https://api.github.com/repos/awalter-bnl/ophyd/milestones{/number}","notifications_url":"https://api.github.com/repos/awalter-bnl/ophyd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awalter-bnl/ophyd/labels{/name}","releases_url":"https://api.github.com/repos/awalter-bnl/ophyd/releases{/id}","deployments_url":"https://api.github.com/repos/awalter-bnl/ophyd/deployments","created_at":"2018-05-21T15:03:50Z","updated_at":"2018-05-21T15:03:52Z","pushed_at":"2018-06-05T10:52:57Z","git_url":"git://github.com/awalter-bnl/ophyd.git","ssh_url":"git@github.com:awalter-bnl/ophyd.git","clone_url":"https://github.com/awalter-bnl/ophyd.git","svn_url":"https://github.com/awalter-bnl/ophyd","homepage":"http://nsls-ii.github.io/ophyd","size":2341,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NSLS-II:master","ref":"master","sha":"55f1db5e518342353f64f702da7242cc912c081d","user":{"login":"NSLS-II","id":8700262,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg3MDAyNjI=","avatar_url":"https://avatars3.githubusercontent.com/u/8700262?v=4","gravatar_id":"","url":"https://api.github.com/users/NSLS-II","html_url":"https://github.com/NSLS-II","followers_url":"https://api.github.com/users/NSLS-II/followers","following_url":"https://api.github.com/users/NSLS-II/following{/other_user}","gists_url":"https://api.github.com/users/NSLS-II/gists{/gist_id}","starred_url":"https://api.github.com/users/NSLS-II/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NSLS-II/subscriptions","organizations_url":"https://api.github.com/users/NSLS-II/orgs","repos_url":"https://api.github.com/users/NSLS-II/repos","events_url":"https://api.github.com/users/NSLS-II/events{/privacy}","received_events_url":"https://api.github.com/users/NSLS-II/received_events","type":"Organization","site_admin":false},"repo":{"id":26235440,"node_id":"MDEwOlJlcG9zaXRvcnkyNjIzNTQ0MA==","name":"ophyd","full_name":"NSLS-II/ophyd","owner":{"login":"NSLS-II","id":8700262,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg3MDAyNjI=","avatar_url":"https://avatars3.githubusercontent.com/u/8700262?v=4","gravatar_id":"","url":"https://api.github.com/users/NSLS-II","html_url":"https://github.com/NSLS-II","followers_url":"https://api.github.com/users/NSLS-II/followers","following_url":"https://api.github.com/users/NSLS-II/following{/other_user}","gists_url":"https://api.github.com/users/NSLS-II/gists{/gist_id}","starred_url":"https://api.github.com/users/NSLS-II/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NSLS-II/subscriptions","organizations_url":"https://api.github.com/users/NSLS-II/orgs","repos_url":"https://api.github.com/users/NSLS-II/repos","events_url":"https://api.github.com/users/NSLS-II/events{/privacy}","received_events_url":"https://api.github.com/users/NSLS-II/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NSLS-II/ophyd","description":"Python/EPICS-based device abstraction","fork":false,"url":"https://api.github.com/repos/NSLS-II/ophyd","forks_url":"https://api.github.com/repos/NSLS-II/ophyd/forks","keys_url":"https://api.github.com/repos/NSLS-II/ophyd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NSLS-II/ophyd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NSLS-II/ophyd/teams","hooks_url":"https://api.github.com/repos/NSLS-II/ophyd/hooks","issue_events_url":"https://api.github.com/repos/NSLS-II/ophyd/issues/events{/number}","events_url":"https://api.github.com/repos/NSLS-II/ophyd/events","assignees_url":"https://api.github.com/repos/NSLS-II/ophyd/assignees{/user}","branches_url":"https://api.github.com/repos/NSLS-II/ophyd/branches{/branch}","tags_url":"https://api.github.com/repos/NSLS-II/ophyd/tags","blobs_url":"https://api.github.com/repos/NSLS-II/ophyd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NSLS-II/ophyd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NSLS-II/ophyd/git/refs{/sha}","trees_url":"https://api.github.com/repos/NSLS-II/ophyd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NSLS-II/ophyd/statuses/{sha}","languages_url":"https://api.github.com/repos/NSLS-II/ophyd/languages","stargazers_url":"https://api.github.com/repos/NSLS-II/ophyd/stargazers","contributors_url":"https://api.github.com/repos/NSLS-II/ophyd/contributors","subscribers_url":"https://api.github.com/repos/NSLS-II/ophyd/subscribers","subscription_url":"https://api.github.com/repos/NSLS-II/ophyd/subscription","commits_url":"https://api.github.com/repos/NSLS-II/ophyd/commits{/sha}","git_commits_url":"https://api.github.com/repos/NSLS-II/ophyd/git/commits{/sha}","comments_url":"https://api.github.com/repos/NSLS-II/ophyd/comments{/number}","issue_comment_url":"https://api.github.com/repos/NSLS-II/ophyd/issues/comments{/number}","contents_url":"https://api.github.com/repos/NSLS-II/ophyd/contents/{+path}","compare_url":"https://api.github.com/repos/NSLS-II/ophyd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NSLS-II/ophyd/merges","archive_url":"https://api.github.com/repos/NSLS-II/ophyd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NSLS-II/ophyd/downloads","issues_url":"https://api.github.com/repos/NSLS-II/ophyd/issues{/number}","pulls_url":"https://api.github.com/repos/NSLS-II/ophyd/pulls{/number}","milestones_url":"https://api.github.com/repos/NSLS-II/ophyd/milestones{/number}","notifications_url":"https://api.github.com/repos/NSLS-II/ophyd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NSLS-II/ophyd/labels{/name}","releases_url":"https://api.github.com/repos/NSLS-II/ophyd/releases{/id}","deployments_url":"https://api.github.com/repos/NSLS-II/ophyd/deployments","created_at":"2014-11-05T19:20:01Z","updated_at":"2018-05-31T22:24:44Z","pushed_at":"2018-06-05T10:58:33Z","git_url":"git://github.com/NSLS-II/ophyd.git","ssh_url":"git@github.com:NSLS-II/ophyd.git","clone_url":"https://github.com/NSLS-II/ophyd.git","svn_url":"https://github.com/NSLS-II/ophyd","homepage":"http://nsls-ii.github.io/ophyd","size":2312,"stargazers_count":14,"watchers_count":14,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":23,"open_issues":49,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NSLS-II/ophyd/pulls/568"},"html":{"href":"https://github.com/NSLS-II/ophyd/pull/568"},"issue":{"href":"https://api.github.com/repos/NSLS-II/ophyd/issues/568"},"comments":{"href":"https://api.github.com/repos/NSLS-II/ophyd/issues/568/comments"},"review_comments":{"href":"https://api.github.com/repos/NSLS-II/ophyd/pulls/568/comments"},"review_comment":{"href":"https://api.github.com/repos/NSLS-II/ophyd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NSLS-II/ophyd/pulls/568/commits"},"statuses":{"href":"https://api.github.com/repos/NSLS-II/ophyd/statuses/1c6e350edd8d3b269dd222b36b7a93b20450381d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tacaswell"}}