{"action":"created","issue":{"url":"https://api.github.com/repos/nico3333fr/jquery-accessible-carrousel-aria/issues/18","repository_url":"https://api.github.com/repos/nico3333fr/jquery-accessible-carrousel-aria","labels_url":"https://api.github.com/repos/nico3333fr/jquery-accessible-carrousel-aria/issues/18/labels{/name}","comments_url":"https://api.github.com/repos/nico3333fr/jquery-accessible-carrousel-aria/issues/18/comments","events_url":"https://api.github.com/repos/nico3333fr/jquery-accessible-carrousel-aria/issues/18/events","html_url":"https://github.com/nico3333fr/jquery-accessible-carrousel-aria/issues/18","id":351174738,"node_id":"MDU6SXNzdWUzNTExNzQ3Mzg=","number":18,"title":"When there are multiple instances of the carrousel on one page, the logic for hiding controls when a carrousel only contains one item fails","user":{"login":"martijnv","id":1055652,"node_id":"MDQ6VXNlcjEwNTU2NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1055652?v=4","gravatar_id":"","url":"https://api.github.com/users/martijnv","html_url":"https://github.com/martijnv","followers_url":"https://api.github.com/users/martijnv/followers","following_url":"https://api.github.com/users/martijnv/following{/other_user}","gists_url":"https://api.github.com/users/martijnv/gists{/gist_id}","starred_url":"https://api.github.com/users/martijnv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martijnv/subscriptions","organizations_url":"https://api.github.com/users/martijnv/orgs","repos_url":"https://api.github.com/users/martijnv/repos","events_url":"https://api.github.com/users/martijnv/events{/privacy}","received_events_url":"https://api.github.com/users/martijnv/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-16T12:00:37Z","updated_at":"2018-08-16T12:16:34Z","closed_at":null,"author_association":"NONE","body":"When there are multiple instances of the carrousel on one page, the logic for hiding controls when a carrousel only contains one item fails.\r\n\r\nI suspect the line:\r\n\r\n`if ($carrousel_container.length && $carrousel_content.length > 1)` \r\n\r\nis incorrect or insufficient because carrousel_content.length is checked on the entire document instead of on a per carrousel-instance basis. When you have multiple carrousel instances in a document, the carrousel_content.length will always be > 1."},"comment":{"url":"https://api.github.com/repos/nico3333fr/jquery-accessible-carrousel-aria/issues/comments/413525740","html_url":"https://github.com/nico3333fr/jquery-accessible-carrousel-aria/issues/18#issuecomment-413525740","issue_url":"https://api.github.com/repos/nico3333fr/jquery-accessible-carrousel-aria/issues/18","id":413525740,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzUyNTc0MA==","user":{"login":"martijnv","id":1055652,"node_id":"MDQ6VXNlcjEwNTU2NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1055652?v=4","gravatar_id":"","url":"https://api.github.com/users/martijnv","html_url":"https://github.com/martijnv","followers_url":"https://api.github.com/users/martijnv/followers","following_url":"https://api.github.com/users/martijnv/following{/other_user}","gists_url":"https://api.github.com/users/martijnv/gists{/gist_id}","starred_url":"https://api.github.com/users/martijnv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martijnv/subscriptions","organizations_url":"https://api.github.com/users/martijnv/orgs","repos_url":"https://api.github.com/users/martijnv/repos","events_url":"https://api.github.com/users/martijnv/events{/privacy}","received_events_url":"https://api.github.com/users/martijnv/received_events","type":"User","site_admin":false},"created_at":"2018-08-16T12:16:34Z","updated_at":"2018-08-16T12:16:34Z","author_association":"NONE","body":"And you can probably revert line 25 (remove the \"> 1\")."}}
{"actor":{"display_login":"martijnv"}}