{"action":"created","issue":{"url":"https://api.github.com/repos/commons-app/apps-android-commons/issues/1644","repository_url":"https://api.github.com/repos/commons-app/apps-android-commons","labels_url":"https://api.github.com/repos/commons-app/apps-android-commons/issues/1644/labels{/name}","comments_url":"https://api.github.com/repos/commons-app/apps-android-commons/issues/1644/comments","events_url":"https://api.github.com/repos/commons-app/apps-android-commons/issues/1644/events","html_url":"https://github.com/commons-app/apps-android-commons/pull/1644","id":333628973,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1Nzk0Mzkx","number":1644,"title":"Remove current location retrieval from upload process entirely","user":{"login":"misaochan","id":3611199,"node_id":"MDQ6VXNlcjM2MTExOTk=","avatar_url":"https://avatars1.githubusercontent.com/u/3611199?v=4","gravatar_id":"","url":"https://api.github.com/users/misaochan","html_url":"https://github.com/misaochan","followers_url":"https://api.github.com/users/misaochan/followers","following_url":"https://api.github.com/users/misaochan/following{/other_user}","gists_url":"https://api.github.com/users/misaochan/gists{/gist_id}","starred_url":"https://api.github.com/users/misaochan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misaochan/subscriptions","organizations_url":"https://api.github.com/users/misaochan/orgs","repos_url":"https://api.github.com/users/misaochan/repos","events_url":"https://api.github.com/users/misaochan/events{/privacy}","received_events_url":"https://api.github.com/users/misaochan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-19T11:24:23Z","updated_at":"2018-06-20T09:32:17Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/commons-app/apps-android-commons/pulls/1644","html_url":"https://github.com/commons-app/apps-android-commons/pull/1644","diff_url":"https://github.com/commons-app/apps-android-commons/pull/1644.diff","patch_url":"https://github.com/commons-app/apps-android-commons/pull/1644.patch"},"body":"Temporary fix for #1599 . We are concerned that people who enabled the \"automatically get current location\" setting prior to the subtext change may not realize that their location is being added to the image's location template. This removes current location retrieval entirely from the upload process, and removes the Setting as well.\r\n\r\nWhere possible, I have left methods intact so that in the future if we decide to reimplement this (retrieving current location solely for category suggestions but not adding it to the template), we will not need to rewrite code. However, I have removed most of the method calls, and methods that would affect the user (e.g. the snackbar requesting location permissions).\r\n\r\nAs an added bonus, this should fix #1515 since the LocationListener will not be registered in ShareActivity.\r\n\r\nTested on Nexus S emulator running API 25 on betaDebug. To test:\r\n- Make sure GPS is on and your image has no geotagged coordinates\r\n- Upload that image\r\n- Check your uploaded image and make sure no location template was added to it"},"comment":{"url":"https://api.github.com/repos/commons-app/apps-android-commons/issues/comments/398686556","html_url":"https://github.com/commons-app/apps-android-commons/pull/1644#issuecomment-398686556","issue_url":"https://api.github.com/repos/commons-app/apps-android-commons/issues/1644","id":398686556,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODY4NjU1Ng==","user":{"login":"whym","id":10674,"node_id":"MDQ6VXNlcjEwNjc0","avatar_url":"https://avatars3.githubusercontent.com/u/10674?v=4","gravatar_id":"","url":"https://api.github.com/users/whym","html_url":"https://github.com/whym","followers_url":"https://api.github.com/users/whym/followers","following_url":"https://api.github.com/users/whym/following{/other_user}","gists_url":"https://api.github.com/users/whym/gists{/gist_id}","starred_url":"https://api.github.com/users/whym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whym/subscriptions","organizations_url":"https://api.github.com/users/whym/orgs","repos_url":"https://api.github.com/users/whym/repos","events_url":"https://api.github.com/users/whym/events{/privacy}","received_events_url":"https://api.github.com/users/whym/received_events","type":"User","site_admin":false},"created_at":"2018-06-20T09:32:17Z","updated_at":"2018-06-20T09:32:17Z","author_association":"COLLABORATOR","body":"Tested on real device (API 24) and it worked fine. [An upload with no EXIF location info has no location template](https://commons.wikimedia.beta.wmflabs.org/wiki/File:CommonsAppTest_12.jpg) and [an upload with EXIF location ifo has one](\r\nhttps://commons.wikimedia.beta.wmflabs.org/wiki/File:CommonsAppTest_14.jpg)."}}
{"actor":{"display_login":"whym"}}