{"action":"created","comment":{"url":"https://api.github.com/repos/paritytech/parity-ethereum/pulls/comments/215250313","pull_request_review_id":152471182,"id":215250313,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTI1MDMxMw==","diff_hunk":"@@ -222,33 +222,28 @@ publish-linux-snap-amd64:          &publish_snap\n     BUILD_ARCH:                    amd64\n   dependencies:\n     - package-linux-snap-amd64\n+  allow_failure:                   true","path":".gitlab-ci.yml","position":4,"original_position":4,"commit_id":"cac5598c6879a95270a56236bd02ee375a0d36ce","original_commit_id":"cac5598c6879a95270a56236bd02ee375a0d36ce","user":{"login":"gabreal","id":3957222,"node_id":"MDQ6VXNlcjM5NTcyMjI=","avatar_url":"https://avatars0.githubusercontent.com/u/3957222?v=4","gravatar_id":"","url":"https://api.github.com/users/gabreal","html_url":"https://github.com/gabreal","followers_url":"https://api.github.com/users/gabreal/followers","following_url":"https://api.github.com/users/gabreal/following{/other_user}","gists_url":"https://api.github.com/users/gabreal/gists{/gist_id}","starred_url":"https://api.github.com/users/gabreal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabreal/subscriptions","organizations_url":"https://api.github.com/users/gabreal/orgs","repos_url":"https://api.github.com/users/gabreal/repos","events_url":"https://api.github.com/users/gabreal/events{/privacy}","received_events_url":"https://api.github.com/users/gabreal/received_events","type":"User","site_admin":false},"body":"The upload only fails for uploads of exactly the same snap for the same version/architecture. So if there are no changes in the code nightly builds will still produce a snap which will be upload and hash check on snapcraft refuses it then. I found no way of changing this behaviour.\r\n\r\nIMHO the easiest way to fix this would be to have a version like the current timestamp (e.g. 20180905) or git commit like before: https://imgur.com/a/bgpoG7T","created_at":"2018-09-05T12:33:37Z","updated_at":"2018-09-05T12:33:37Z","html_url":"https://github.com/paritytech/parity-ethereum/pull/9479#discussion_r215250313","pull_request_url":"https://api.github.com/repos/paritytech/parity-ethereum/pulls/9479","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/paritytech/parity-ethereum/pulls/comments/215250313"},"html":{"href":"https://github.com/paritytech/parity-ethereum/pull/9479#discussion_r215250313"},"pull_request":{"href":"https://api.github.com/repos/paritytech/parity-ethereum/pulls/9479"}},"in_reply_to_id":215219040},"pull_request":{"url":"https://api.github.com/repos/paritytech/parity-ethereum/pulls/9479","id":213229212,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMjI5MjEy","html_url":"https://github.com/paritytech/parity-ethereum/pull/9479","diff_url":"https://github.com/paritytech/parity-ethereum/pull/9479.diff","patch_url":"https://github.com/paritytech/parity-ethereum/pull/9479.patch","issue_url":"https://api.github.com/repos/paritytech/parity-ethereum/issues/9479","number":9479,"state":"open","locked":false,"title":"upload will fail if a file with the same hash is already up","user":{"login":"gabreal","id":3957222,"node_id":"MDQ6VXNlcjM5NTcyMjI=","avatar_url":"https://avatars0.githubusercontent.com/u/3957222?v=4","gravatar_id":"","url":"https://api.github.com/users/gabreal","html_url":"https://github.com/gabreal","followers_url":"https://api.github.com/users/gabreal/followers","following_url":"https://api.github.com/users/gabreal/following{/other_user}","gists_url":"https://api.github.com/users/gabreal/gists{/gist_id}","starred_url":"https://api.github.com/users/gabreal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabreal/subscriptions","organizations_url":"https://api.github.com/users/gabreal/orgs","repos_url":"https://api.github.com/users/gabreal/repos","events_url":"https://api.github.com/users/gabreal/events{/privacy}","received_events_url":"https://api.github.com/users/gabreal/received_events","type":"User","site_admin":false},"body":"still about this issue: https://gitlab.parity.io/parity/parity-ethereum/-/jobs/96821\r\n\r\nwhich happens if a snap with the same checksum is already uploaded. allow_failure here will at least the pipeline proceed to the next stage.\r\n\r\n(the before_script statements with *determine_version are duplicate)","created_at":"2018-09-05T09:37:15Z","updated_at":"2018-09-05T12:33:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7b5e07fcfeed08405e96c6231289d27332a053b7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"General-Beck","id":818533,"node_id":"MDQ6VXNlcjgxODUzMw==","avatar_url":"https://avatars0.githubusercontent.com/u/818533?v=4","gravatar_id":"","url":"https://api.github.com/users/General-Beck","html_url":"https://github.com/General-Beck","followers_url":"https://api.github.com/users/General-Beck/followers","following_url":"https://api.github.com/users/General-Beck/following{/other_user}","gists_url":"https://api.github.com/users/General-Beck/gists{/gist_id}","starred_url":"https://api.github.com/users/General-Beck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/General-Beck/subscriptions","organizations_url":"https://api.github.com/users/General-Beck/orgs","repos_url":"https://api.github.com/users/General-Beck/repos","events_url":"https://api.github.com/users/General-Beck/events{/privacy}","received_events_url":"https://api.github.com/users/General-Beck/received_events","type":"User","site_admin":false},{"login":"ddorgan","id":11941563,"node_id":"MDQ6VXNlcjExOTQxNTYz","avatar_url":"https://avatars1.githubusercontent.com/u/11941563?v=4","gravatar_id":"","url":"https://api.github.com/users/ddorgan","html_url":"https://github.com/ddorgan","followers_url":"https://api.github.com/users/ddorgan/followers","following_url":"https://api.github.com/users/ddorgan/following{/other_user}","gists_url":"https://api.github.com/users/ddorgan/gists{/gist_id}","starred_url":"https://api.github.com/users/ddorgan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddorgan/subscriptions","organizations_url":"https://api.github.com/users/ddorgan/orgs","repos_url":"https://api.github.com/users/ddorgan/repos","events_url":"https://api.github.com/users/ddorgan/events{/privacy}","received_events_url":"https://api.github.com/users/ddorgan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":315686233,"node_id":"MDU6TGFiZWwzMTU2ODYyMzM=","url":"https://api.github.com/repos/paritytech/parity-ethereum/labels/A5-grumble%20%F0%9F%94%A5","name":"A5-grumble 🔥","color":"fcdfc3","default":false},{"id":475248079,"node_id":"MDU6TGFiZWw0NzUyNDgwNzk=","url":"https://api.github.com/repos/paritytech/parity-ethereum/labels/M1-ci%20%F0%9F%99%89","name":"M1-ci 🙉","color":"fff4ed","default":false}],"milestone":{"url":"https://api.github.com/repos/paritytech/parity-ethereum/milestones/22","html_url":"https://github.com/paritytech/parity-ethereum/milestone/22","labels_url":"https://api.github.com/repos/paritytech/parity-ethereum/milestones/22/labels","id":3153051,"node_id":"MDk6TWlsZXN0b25lMzE1MzA1MQ==","number":22,"title":"2.1","description":"","creator":{"login":"5chdn","id":15729797,"node_id":"MDQ6VXNlcjE1NzI5Nzk3","avatar_url":"https://avatars3.githubusercontent.com/u/15729797?v=4","gravatar_id":"","url":"https://api.github.com/users/5chdn","html_url":"https://github.com/5chdn","followers_url":"https://api.github.com/users/5chdn/followers","following_url":"https://api.github.com/users/5chdn/following{/other_user}","gists_url":"https://api.github.com/users/5chdn/gists{/gist_id}","starred_url":"https://api.github.com/users/5chdn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/5chdn/subscriptions","organizations_url":"https://api.github.com/users/5chdn/orgs","repos_url":"https://api.github.com/users/5chdn/repos","events_url":"https://api.github.com/users/5chdn/events{/privacy}","received_events_url":"https://api.github.com/users/5chdn/received_events","type":"User","site_admin":false},"open_issues":170,"closed_issues":387,"state":"open","created_at":"2018-03-01T09:29:12Z","updated_at":"2018-09-05T11:14:09Z","due_on":"2018-09-17T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/paritytech/parity-ethereum/pulls/9479/commits","review_comments_url":"https://api.github.com/repos/paritytech/parity-ethereum/pulls/9479/comments","review_comment_url":"https://api.github.com/repos/paritytech/parity-ethereum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/paritytech/parity-ethereum/issues/9479/comments","statuses_url":"https://api.github.com/repos/paritytech/parity-ethereum/statuses/cac5598c6879a95270a56236bd02ee375a0d36ce","head":{"label":"paritytech:allow-snap-publishing-fail","ref":"allow-snap-publishing-fail","sha":"cac5598c6879a95270a56236bd02ee375a0d36ce","user":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"repo":{"id":46714939,"node_id":"MDEwOlJlcG9zaXRvcnk0NjcxNDkzOQ==","name":"parity-ethereum","full_name":"paritytech/parity-ethereum","owner":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/paritytech/parity-ethereum","description":"The fast, light, and robust EVM and WASM client.","fork":false,"url":"https://api.github.com/repos/paritytech/parity-ethereum","forks_url":"https://api.github.com/repos/paritytech/parity-ethereum/forks","keys_url":"https://api.github.com/repos/paritytech/parity-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paritytech/parity-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paritytech/parity-ethereum/teams","hooks_url":"https://api.github.com/repos/paritytech/parity-ethereum/hooks","issue_events_url":"https://api.github.com/repos/paritytech/parity-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/paritytech/parity-ethereum/events","assignees_url":"https://api.github.com/repos/paritytech/parity-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/paritytech/parity-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/paritytech/parity-ethereum/tags","blobs_url":"https://api.github.com/repos/paritytech/parity-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paritytech/parity-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paritytech/parity-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/paritytech/parity-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paritytech/parity-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/paritytech/parity-ethereum/languages","stargazers_url":"https://api.github.com/repos/paritytech/parity-ethereum/stargazers","contributors_url":"https://api.github.com/repos/paritytech/parity-ethereum/contributors","subscribers_url":"https://api.github.com/repos/paritytech/parity-ethereum/subscribers","subscription_url":"https://api.github.com/repos/paritytech/parity-ethereum/subscription","commits_url":"https://api.github.com/repos/paritytech/parity-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/paritytech/parity-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/paritytech/parity-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/paritytech/parity-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/paritytech/parity-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/paritytech/parity-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paritytech/parity-ethereum/merges","archive_url":"https://api.github.com/repos/paritytech/parity-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paritytech/parity-ethereum/downloads","issues_url":"https://api.github.com/repos/paritytech/parity-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/paritytech/parity-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/paritytech/parity-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/paritytech/parity-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paritytech/parity-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/paritytech/parity-ethereum/releases{/id}","deployments_url":"https://api.github.com/repos/paritytech/parity-ethereum/deployments","created_at":"2015-11-23T11:07:32Z","updated_at":"2018-09-05T10:42:23Z","pushed_at":"2018-09-05T12:26:40Z","git_url":"git://github.com/paritytech/parity-ethereum.git","ssh_url":"git@github.com:paritytech/parity-ethereum.git","clone_url":"https://github.com/paritytech/parity-ethereum.git","svn_url":"https://github.com/paritytech/parity-ethereum","homepage":"https://parity.io","size":57307,"stargazers_count":4766,"watchers_count":4766,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1005,"mirror_url":null,"archived":false,"open_issues_count":258,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1005,"open_issues":258,"watchers":4766,"default_branch":"master"}},"base":{"label":"paritytech:master","ref":"master","sha":"72fd1fa58dbf9bfebc82f01b0e750c622568b8b2","user":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"repo":{"id":46714939,"node_id":"MDEwOlJlcG9zaXRvcnk0NjcxNDkzOQ==","name":"parity-ethereum","full_name":"paritytech/parity-ethereum","owner":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/paritytech/parity-ethereum","description":"The fast, light, and robust EVM and WASM client.","fork":false,"url":"https://api.github.com/repos/paritytech/parity-ethereum","forks_url":"https://api.github.com/repos/paritytech/parity-ethereum/forks","keys_url":"https://api.github.com/repos/paritytech/parity-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paritytech/parity-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paritytech/parity-ethereum/teams","hooks_url":"https://api.github.com/repos/paritytech/parity-ethereum/hooks","issue_events_url":"https://api.github.com/repos/paritytech/parity-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/paritytech/parity-ethereum/events","assignees_url":"https://api.github.com/repos/paritytech/parity-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/paritytech/parity-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/paritytech/parity-ethereum/tags","blobs_url":"https://api.github.com/repos/paritytech/parity-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paritytech/parity-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paritytech/parity-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/paritytech/parity-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paritytech/parity-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/paritytech/parity-ethereum/languages","stargazers_url":"https://api.github.com/repos/paritytech/parity-ethereum/stargazers","contributors_url":"https://api.github.com/repos/paritytech/parity-ethereum/contributors","subscribers_url":"https://api.github.com/repos/paritytech/parity-ethereum/subscribers","subscription_url":"https://api.github.com/repos/paritytech/parity-ethereum/subscription","commits_url":"https://api.github.com/repos/paritytech/parity-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/paritytech/parity-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/paritytech/parity-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/paritytech/parity-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/paritytech/parity-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/paritytech/parity-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paritytech/parity-ethereum/merges","archive_url":"https://api.github.com/repos/paritytech/parity-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paritytech/parity-ethereum/downloads","issues_url":"https://api.github.com/repos/paritytech/parity-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/paritytech/parity-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/paritytech/parity-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/paritytech/parity-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paritytech/parity-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/paritytech/parity-ethereum/releases{/id}","deployments_url":"https://api.github.com/repos/paritytech/parity-ethereum/deployments","created_at":"2015-11-23T11:07:32Z","updated_at":"2018-09-05T10:42:23Z","pushed_at":"2018-09-05T12:26:40Z","git_url":"git://github.com/paritytech/parity-ethereum.git","ssh_url":"git@github.com:paritytech/parity-ethereum.git","clone_url":"https://github.com/paritytech/parity-ethereum.git","svn_url":"https://github.com/paritytech/parity-ethereum","homepage":"https://parity.io","size":57307,"stargazers_count":4766,"watchers_count":4766,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1005,"mirror_url":null,"archived":false,"open_issues_count":258,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1005,"open_issues":258,"watchers":4766,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/paritytech/parity-ethereum/pulls/9479"},"html":{"href":"https://github.com/paritytech/parity-ethereum/pull/9479"},"issue":{"href":"https://api.github.com/repos/paritytech/parity-ethereum/issues/9479"},"comments":{"href":"https://api.github.com/repos/paritytech/parity-ethereum/issues/9479/comments"},"review_comments":{"href":"https://api.github.com/repos/paritytech/parity-ethereum/pulls/9479/comments"},"review_comment":{"href":"https://api.github.com/repos/paritytech/parity-ethereum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/paritytech/parity-ethereum/pulls/9479/commits"},"statuses":{"href":"https://api.github.com/repos/paritytech/parity-ethereum/statuses/cac5598c6879a95270a56236bd02ee375a0d36ce"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gabreal"}}