{"action":"created","issue":{"url":"https://api.github.com/repos/video-dev/hls.js/issues/1992","repository_url":"https://api.github.com/repos/video-dev/hls.js","labels_url":"https://api.github.com/repos/video-dev/hls.js/issues/1992/labels{/name}","comments_url":"https://api.github.com/repos/video-dev/hls.js/issues/1992/comments","events_url":"https://api.github.com/repos/video-dev/hls.js/issues/1992/events","html_url":"https://github.com/video-dev/hls.js/pull/1992","id":378974846,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NTUzMDQz","number":1992,"title":"Fix for issue 1978.  ","user":{"login":"dsparacio","id":7864462,"node_id":"MDQ6VXNlcjc4NjQ0NjI=","avatar_url":"https://avatars2.githubusercontent.com/u/7864462?v=4","gravatar_id":"","url":"https://api.github.com/users/dsparacio","html_url":"https://github.com/dsparacio","followers_url":"https://api.github.com/users/dsparacio/followers","following_url":"https://api.github.com/users/dsparacio/following{/other_user}","gists_url":"https://api.github.com/users/dsparacio/gists{/gist_id}","starred_url":"https://api.github.com/users/dsparacio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsparacio/subscriptions","organizations_url":"https://api.github.com/users/dsparacio/orgs","repos_url":"https://api.github.com/users/dsparacio/repos","events_url":"https://api.github.com/users/dsparacio/events{/privacy}","received_events_url":"https://api.github.com/users/dsparacio/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-09T00:29:52Z","updated_at":"2018-11-09T00:46:11Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/video-dev/hls.js/pulls/1992","html_url":"https://github.com/video-dev/hls.js/pull/1992","diff_url":"https://github.com/video-dev/hls.js/pull/1992.diff","patch_url":"https://github.com/video-dev/hls.js/pull/1992.patch"},"body":"### This PR will...\r\nCheck what the SourceBuffer reports as start time for the first fragment appended and If within the threshold of maxBufferHole, adjust this.startPosition for _seekToStartPos. This happens on the first tick in checkBuffer. \r\n\r\n### Why is this Pull Request needed?\r\nFixes an issue with Edge where it will not start (when autoStartLoad is false) if seek at start position is only set to the value we calculate for the live + latency position. \r\nE.g.\r\nmedia seeked to 6.000 VS media seeking to 6.014\r\n\r\nIn v8.9 and previously, hls.js looked at buffer.start value on first tick in checkBuffer method,  but that was lost in subsequent releases.  \r\n\r\nWith this PR,  it restores it in the new code base to get live streams on Edge with non zero pts playing again.  \r\n\r\n### Are there any points in the code the reviewer needs to double check?\r\nWould like to know if there was a solid reason for removing this in 0.9.0 in order to avoid regressions. \r\n\r\n### Resolves issues:\r\n#1978 \r\n\r\n### Checklist\r\n\r\n- [ X] changes have been done against master branch, and PR does not conflict\r\n- [ ] new unit / functional tests have been added (whenever applicable)\r\n- [ ] API or design changes are documented in API.md\r\n"},"comment":{"url":"https://api.github.com/repos/video-dev/hls.js/issues/comments/437209624","html_url":"https://github.com/video-dev/hls.js/pull/1992#issuecomment-437209624","issue_url":"https://api.github.com/repos/video-dev/hls.js/issues/1992","id":437209624,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzIwOTYyNA==","user":{"login":"dsparacio","id":7864462,"node_id":"MDQ6VXNlcjc4NjQ0NjI=","avatar_url":"https://avatars2.githubusercontent.com/u/7864462?v=4","gravatar_id":"","url":"https://api.github.com/users/dsparacio","html_url":"https://github.com/dsparacio","followers_url":"https://api.github.com/users/dsparacio/followers","following_url":"https://api.github.com/users/dsparacio/following{/other_user}","gists_url":"https://api.github.com/users/dsparacio/gists{/gist_id}","starred_url":"https://api.github.com/users/dsparacio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsparacio/subscriptions","organizations_url":"https://api.github.com/users/dsparacio/orgs","repos_url":"https://api.github.com/users/dsparacio/repos","events_url":"https://api.github.com/users/dsparacio/events{/privacy}","received_events_url":"https://api.github.com/users/dsparacio/received_events","type":"User","site_admin":false},"created_at":"2018-11-09T00:46:11Z","updated_at":"2018-11-09T00:46:11Z","author_association":"COLLABORATOR","body":"will add and/or fix unit test for pr. "}}
{"actor":{"display_login":"dsparacio"}}