{"action":"closed","number":4656,"pull_request":{"url":"https://api.github.com/repos/SickRage/SickRage/pulls/4656","id":186521836,"html_url":"https://github.com/SickRage/SickRage/pull/4656","diff_url":"https://github.com/SickRage/SickRage/pull/4656.diff","patch_url":"https://github.com/SickRage/SickRage/pull/4656.patch","issue_url":"https://api.github.com/repos/SickRage/SickRage/issues/4656","number":4656,"state":"closed","locked":false,"title":"Fix javascript library included in the build twice","user":{"login":"dpedu","id":1266188,"avatar_url":"https://avatars3.githubusercontent.com/u/1266188?v=4","gravatar_id":"","url":"https://api.github.com/users/dpedu","html_url":"https://github.com/dpedu","followers_url":"https://api.github.com/users/dpedu/followers","following_url":"https://api.github.com/users/dpedu/following{/other_user}","gists_url":"https://api.github.com/users/dpedu/gists{/gist_id}","starred_url":"https://api.github.com/users/dpedu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpedu/subscriptions","organizations_url":"https://api.github.com/users/dpedu/orgs","repos_url":"https://api.github.com/users/dpedu/repos","events_url":"https://api.github.com/users/dpedu/events{/privacy}","received_events_url":"https://api.github.com/users/dpedu/received_events","type":"User","site_admin":false},"body":"The \"columnSelector\" and \"stickyHeaders\" addons for the js tablesorter library in use were explicitly concatenated in the Gruntfile, but also included is a combined version of the library that contains these addons already.\r\n\r\nProposed changes in this pull request:\r\n- Don't include the libraries twice\r\n\r\n- [Y] PR is based on the DEVELOP branch\r\n- [Y] Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review\r\n- [Y] Read [contribution guide](https://github.com/SickRage/SickRage/blob/master/.github/CONTRIBUTING.md)\r\n","created_at":"2018-05-08T04:08:18Z","updated_at":"2018-05-08T04:08:37Z","closed_at":"2018-05-08T04:08:37Z","merged_at":null,"merge_commit_sha":"93405f60887fd06cdde2d3bd11ca2cd512409154","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SickRage/SickRage/pulls/4656/commits","review_comments_url":"https://api.github.com/repos/SickRage/SickRage/pulls/4656/comments","review_comment_url":"https://api.github.com/repos/SickRage/SickRage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SickRage/SickRage/issues/4656/comments","statuses_url":"https://api.github.com/repos/SickRage/SickRage/statuses/4e9f81335e94e9a18f478535b69e59fcdcc3208c","head":{"label":"dpedu:dpedu/double-include","ref":"dpedu/double-include","sha":"4e9f81335e94e9a18f478535b69e59fcdcc3208c","user":{"login":"dpedu","id":1266188,"avatar_url":"https://avatars3.githubusercontent.com/u/1266188?v=4","gravatar_id":"","url":"https://api.github.com/users/dpedu","html_url":"https://github.com/dpedu","followers_url":"https://api.github.com/users/dpedu/followers","following_url":"https://api.github.com/users/dpedu/following{/other_user}","gists_url":"https://api.github.com/users/dpedu/gists{/gist_id}","starred_url":"https://api.github.com/users/dpedu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpedu/subscriptions","organizations_url":"https://api.github.com/users/dpedu/orgs","repos_url":"https://api.github.com/users/dpedu/repos","events_url":"https://api.github.com/users/dpedu/events{/privacy}","received_events_url":"https://api.github.com/users/dpedu/received_events","type":"User","site_admin":false},"repo":{"id":132538530,"name":"SickRage","full_name":"dpedu/SickRage","owner":{"login":"dpedu","id":1266188,"avatar_url":"https://avatars3.githubusercontent.com/u/1266188?v=4","gravatar_id":"","url":"https://api.github.com/users/dpedu","html_url":"https://github.com/dpedu","followers_url":"https://api.github.com/users/dpedu/followers","following_url":"https://api.github.com/users/dpedu/following{/other_user}","gists_url":"https://api.github.com/users/dpedu/gists{/gist_id}","starred_url":"https://api.github.com/users/dpedu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpedu/subscriptions","organizations_url":"https://api.github.com/users/dpedu/orgs","repos_url":"https://api.github.com/users/dpedu/repos","events_url":"https://api.github.com/users/dpedu/events{/privacy}","received_events_url":"https://api.github.com/users/dpedu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dpedu/SickRage","description":"The new home of the SickRage community","fork":true,"url":"https://api.github.com/repos/dpedu/SickRage","forks_url":"https://api.github.com/repos/dpedu/SickRage/forks","keys_url":"https://api.github.com/repos/dpedu/SickRage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dpedu/SickRage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dpedu/SickRage/teams","hooks_url":"https://api.github.com/repos/dpedu/SickRage/hooks","issue_events_url":"https://api.github.com/repos/dpedu/SickRage/issues/events{/number}","events_url":"https://api.github.com/repos/dpedu/SickRage/events","assignees_url":"https://api.github.com/repos/dpedu/SickRage/assignees{/user}","branches_url":"https://api.github.com/repos/dpedu/SickRage/branches{/branch}","tags_url":"https://api.github.com/repos/dpedu/SickRage/tags","blobs_url":"https://api.github.com/repos/dpedu/SickRage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dpedu/SickRage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dpedu/SickRage/git/refs{/sha}","trees_url":"https://api.github.com/repos/dpedu/SickRage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dpedu/SickRage/statuses/{sha}","languages_url":"https://api.github.com/repos/dpedu/SickRage/languages","stargazers_url":"https://api.github.com/repos/dpedu/SickRage/stargazers","contributors_url":"https://api.github.com/repos/dpedu/SickRage/contributors","subscribers_url":"https://api.github.com/repos/dpedu/SickRage/subscribers","subscription_url":"https://api.github.com/repos/dpedu/SickRage/subscription","commits_url":"https://api.github.com/repos/dpedu/SickRage/commits{/sha}","git_commits_url":"https://api.github.com/repos/dpedu/SickRage/git/commits{/sha}","comments_url":"https://api.github.com/repos/dpedu/SickRage/comments{/number}","issue_comment_url":"https://api.github.com/repos/dpedu/SickRage/issues/comments{/number}","contents_url":"https://api.github.com/repos/dpedu/SickRage/contents/{+path}","compare_url":"https://api.github.com/repos/dpedu/SickRage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dpedu/SickRage/merges","archive_url":"https://api.github.com/repos/dpedu/SickRage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dpedu/SickRage/downloads","issues_url":"https://api.github.com/repos/dpedu/SickRage/issues{/number}","pulls_url":"https://api.github.com/repos/dpedu/SickRage/pulls{/number}","milestones_url":"https://api.github.com/repos/dpedu/SickRage/milestones{/number}","notifications_url":"https://api.github.com/repos/dpedu/SickRage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dpedu/SickRage/labels{/name}","releases_url":"https://api.github.com/repos/dpedu/SickRage/releases{/id}","deployments_url":"https://api.github.com/repos/dpedu/SickRage/deployments","created_at":"2018-05-08T01:50:18Z","updated_at":"2018-05-08T01:50:23Z","pushed_at":"2018-05-08T04:04:04Z","git_url":"git://github.com/dpedu/SickRage.git","ssh_url":"git@github.com:dpedu/SickRage.git","clone_url":"https://github.com/dpedu/SickRage.git","svn_url":"https://github.com/dpedu/SickRage","homepage":"https://sickrage.github.io","size":103786,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SickRage:master","ref":"master","sha":"a7602639bd525f27475f1eeb2fc504111a14b51c","user":{"login":"SickRage","id":15840255,"avatar_url":"https://avatars3.githubusercontent.com/u/15840255?v=4","gravatar_id":"","url":"https://api.github.com/users/SickRage","html_url":"https://github.com/SickRage","followers_url":"https://api.github.com/users/SickRage/followers","following_url":"https://api.github.com/users/SickRage/following{/other_user}","gists_url":"https://api.github.com/users/SickRage/gists{/gist_id}","starred_url":"https://api.github.com/users/SickRage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SickRage/subscriptions","organizations_url":"https://api.github.com/users/SickRage/orgs","repos_url":"https://api.github.com/users/SickRage/repos","events_url":"https://api.github.com/users/SickRage/events{/privacy}","received_events_url":"https://api.github.com/users/SickRage/received_events","type":"Organization","site_admin":false},"repo":{"id":46151823,"name":"SickRage","full_name":"SickRage/SickRage","owner":{"login":"SickRage","id":15840255,"avatar_url":"https://avatars3.githubusercontent.com/u/15840255?v=4","gravatar_id":"","url":"https://api.github.com/users/SickRage","html_url":"https://github.com/SickRage","followers_url":"https://api.github.com/users/SickRage/followers","following_url":"https://api.github.com/users/SickRage/following{/other_user}","gists_url":"https://api.github.com/users/SickRage/gists{/gist_id}","starred_url":"https://api.github.com/users/SickRage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SickRage/subscriptions","organizations_url":"https://api.github.com/users/SickRage/orgs","repos_url":"https://api.github.com/users/SickRage/repos","events_url":"https://api.github.com/users/SickRage/events{/privacy}","received_events_url":"https://api.github.com/users/SickRage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SickRage/SickRage","description":"The new home of the SickRage community","fork":false,"url":"https://api.github.com/repos/SickRage/SickRage","forks_url":"https://api.github.com/repos/SickRage/SickRage/forks","keys_url":"https://api.github.com/repos/SickRage/SickRage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SickRage/SickRage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SickRage/SickRage/teams","hooks_url":"https://api.github.com/repos/SickRage/SickRage/hooks","issue_events_url":"https://api.github.com/repos/SickRage/SickRage/issues/events{/number}","events_url":"https://api.github.com/repos/SickRage/SickRage/events","assignees_url":"https://api.github.com/repos/SickRage/SickRage/assignees{/user}","branches_url":"https://api.github.com/repos/SickRage/SickRage/branches{/branch}","tags_url":"https://api.github.com/repos/SickRage/SickRage/tags","blobs_url":"https://api.github.com/repos/SickRage/SickRage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SickRage/SickRage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SickRage/SickRage/git/refs{/sha}","trees_url":"https://api.github.com/repos/SickRage/SickRage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SickRage/SickRage/statuses/{sha}","languages_url":"https://api.github.com/repos/SickRage/SickRage/languages","stargazers_url":"https://api.github.com/repos/SickRage/SickRage/stargazers","contributors_url":"https://api.github.com/repos/SickRage/SickRage/contributors","subscribers_url":"https://api.github.com/repos/SickRage/SickRage/subscribers","subscription_url":"https://api.github.com/repos/SickRage/SickRage/subscription","commits_url":"https://api.github.com/repos/SickRage/SickRage/commits{/sha}","git_commits_url":"https://api.github.com/repos/SickRage/SickRage/git/commits{/sha}","comments_url":"https://api.github.com/repos/SickRage/SickRage/comments{/number}","issue_comment_url":"https://api.github.com/repos/SickRage/SickRage/issues/comments{/number}","contents_url":"https://api.github.com/repos/SickRage/SickRage/contents/{+path}","compare_url":"https://api.github.com/repos/SickRage/SickRage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SickRage/SickRage/merges","archive_url":"https://api.github.com/repos/SickRage/SickRage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SickRage/SickRage/downloads","issues_url":"https://api.github.com/repos/SickRage/SickRage/issues{/number}","pulls_url":"https://api.github.com/repos/SickRage/SickRage/pulls{/number}","milestones_url":"https://api.github.com/repos/SickRage/SickRage/milestones{/number}","notifications_url":"https://api.github.com/repos/SickRage/SickRage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SickRage/SickRage/labels{/name}","releases_url":"https://api.github.com/repos/SickRage/SickRage/releases{/id}","deployments_url":"https://api.github.com/repos/SickRage/SickRage/deployments","created_at":"2015-11-13T23:01:22Z","updated_at":"2018-05-07T22:00:49Z","pushed_at":"2018-05-08T04:08:18Z","git_url":"git://github.com/SickRage/SickRage.git","ssh_url":"git@github.com:SickRage/SickRage.git","clone_url":"https://github.com/SickRage/SickRage.git","svn_url":"https://github.com/SickRage/SickRage","homepage":"https://sickrage.github.io","size":103786,"stargazers_count":1385,"watchers_count":1385,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":505,"mirror_url":null,"archived":false,"open_issues_count":468,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":505,"open_issues":468,"watchers":1385,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SickRage/SickRage/pulls/4656"},"html":{"href":"https://github.com/SickRage/SickRage/pull/4656"},"issue":{"href":"https://api.github.com/repos/SickRage/SickRage/issues/4656"},"comments":{"href":"https://api.github.com/repos/SickRage/SickRage/issues/4656/comments"},"review_comments":{"href":"https://api.github.com/repos/SickRage/SickRage/pulls/4656/comments"},"review_comment":{"href":"https://api.github.com/repos/SickRage/SickRage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SickRage/SickRage/pulls/4656/commits"},"statuses":{"href":"https://api.github.com/repos/SickRage/SickRage/statuses/4e9f81335e94e9a18f478535b69e59fcdcc3208c"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":12,"additions":826,"deletions":983,"changed_files":43}}
{"actor":{"display_login":"dpedu"}}