{"action":"created","issue":{"url":"https://api.github.com/repos/dlang/phobos/issues/6633","repository_url":"https://api.github.com/repos/dlang/phobos","labels_url":"https://api.github.com/repos/dlang/phobos/issues/6633/labels{/name}","comments_url":"https://api.github.com/repos/dlang/phobos/issues/6633/comments","events_url":"https://api.github.com/repos/dlang/phobos/issues/6633/events","html_url":"https://github.com/dlang/phobos/pull/6633","id":340173168,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNjQ2ODAz","number":6633,"title":"Extend std.conv.parse for strings to full ieeeQuadruple precision and other fixes","user":{"login":"joakim-noah","id":5930876,"node_id":"MDQ6VXNlcjU5MzA4NzY=","avatar_url":"https://avatars1.githubusercontent.com/u/5930876?v=4","gravatar_id":"","url":"https://api.github.com/users/joakim-noah","html_url":"https://github.com/joakim-noah","followers_url":"https://api.github.com/users/joakim-noah/followers","following_url":"https://api.github.com/users/joakim-noah/following{/other_user}","gists_url":"https://api.github.com/users/joakim-noah/gists{/gist_id}","starred_url":"https://api.github.com/users/joakim-noah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joakim-noah/subscriptions","organizations_url":"https://api.github.com/users/joakim-noah/orgs","repos_url":"https://api.github.com/users/joakim-noah/repos","events_url":"https://api.github.com/users/joakim-noah/events{/privacy}","received_events_url":"https://api.github.com/users/joakim-noah/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":17,"created_at":"2018-07-11T09:58:06Z","updated_at":"2018-07-22T07:59:33Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/dlang/phobos/pulls/6633","html_url":"https://github.com/dlang/phobos/pull/6633","diff_url":"https://github.com/dlang/phobos/pull/6633.diff","patch_url":"https://github.com/dlang/phobos/pull/6633.patch"},"body":"This pull was tested with ldc on linux/x64, Android/AArch64, and Android/ARM, exercising 80-bit, 128-bit, and 64-bit reals. The new decimal test was off by one bit on the first and last platforms, but strangely matched exactly for the most precise, AArch64. Putting this up early to see what the CI says on other platforms, ~will~ have also extended the hex parser ~if all goes well~."},"comment":{"url":"https://api.github.com/repos/dlang/phobos/issues/comments/406848424","html_url":"https://github.com/dlang/phobos/pull/6633#issuecomment-406848424","issue_url":"https://api.github.com/repos/dlang/phobos/issues/6633","id":406848424,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjg0ODQyNA==","user":{"login":"jondegenhardt","id":18296518,"node_id":"MDQ6VXNlcjE4Mjk2NTE4","avatar_url":"https://avatars0.githubusercontent.com/u/18296518?v=4","gravatar_id":"","url":"https://api.github.com/users/jondegenhardt","html_url":"https://github.com/jondegenhardt","followers_url":"https://api.github.com/users/jondegenhardt/followers","following_url":"https://api.github.com/users/jondegenhardt/following{/other_user}","gists_url":"https://api.github.com/users/jondegenhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/jondegenhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jondegenhardt/subscriptions","organizations_url":"https://api.github.com/users/jondegenhardt/orgs","repos_url":"https://api.github.com/users/jondegenhardt/repos","events_url":"https://api.github.com/users/jondegenhardt/events{/privacy}","received_events_url":"https://api.github.com/users/jondegenhardt/received_events","type":"User","site_admin":false},"created_at":"2018-07-22T07:59:33Z","updated_at":"2018-07-22T07:59:33Z","author_association":"CONTRIBUTOR","body":"Yes, the first two commits are faster. It's very significant when not using LTO/PGO. It's also significant when using LTO/PGO. For `tsv-summarize` it's faster than stock by 12%, faster than the full PR by 18%. It'd be great if you can preserve this.\r\n\r\nTimes with `-release -O3 -boundscheck=off`, but no LTO, no PGO (3 runs):\r\n\r\nBenchmark | Tool  |  current LDC master | current LDC master w/ PR 6633 | current LDC master w/ PR 6633 first 2 commits\r\n----------- | ----  | ----------------- | ------------ | -----------------\r\nNumeric row filter | tsv-filter | 5.75, 5.74, 5.73 | 7.10, 7.10, 7.07 | 5.69, 5.67, 5.68\r\nSummary Statistics | tsv-summarize | 30.07, 30.18, 30.03 | 44.14, 44.14, 44.17 | 29.51, 29.46, 29.52\r\n\r\nTimes with LTO & PGO (3 runs):\r\n\r\nBenchmark | Tool  |  current LDC master | current LDC master w/ PR 6633 | current LDC master w/ PR 6633 first 2 commits\r\n----------- | ----  | ----------------- | ------------ | -----------------\r\nNumeric row filter | tsv-filter | 3.59, 3.61, 3.60 | 3.66, 3.67, 3.66 | 3.53, 3.54, 3.54\r\nSummary Statistics | tsv-summarize | 11.96, 11.93, 11.93 | 12.92, 12.89, 12.82 | 10.42, 10.44, 10.46\r\n"}}
{"actor":{"display_login":"jondegenhardt"}}