{"action":"created","comment":{"url":"https://api.github.com/repos/badoo/Chatto/pulls/comments/240162574","pull_request_review_id":183125887,"id":240162574,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDE2MjU3NA==","diff_hunk":"@@ -230,7 +231,6 @@ open class BaseChatViewController: UIViewController, UICollectionViewDataSource,\n     }\n \n     open func handleKeyboardPositionChange(bottomMargin: CGFloat, keyboardStatus: KeyboardStatus) {\n-        guard self.inputContainerBottomConstraint.constant != bottomMargin else { return }","path":"Chatto/Source/ChatController/BaseChatViewController.swift","position":90,"original_position":90,"commit_id":"eb0ea2fbfa42a8de106ed38bdbbb87973681fb7f","original_commit_id":"eb0ea2fbfa42a8de106ed38bdbbb87973681fb7f","user":{"login":"AntonPalich","id":1708330,"node_id":"MDQ6VXNlcjE3MDgzMzA=","avatar_url":"https://avatars0.githubusercontent.com/u/1708330?v=4","gravatar_id":"","url":"https://api.github.com/users/AntonPalich","html_url":"https://github.com/AntonPalich","followers_url":"https://api.github.com/users/AntonPalich/followers","following_url":"https://api.github.com/users/AntonPalich/following{/other_user}","gists_url":"https://api.github.com/users/AntonPalich/gists{/gist_id}","starred_url":"https://api.github.com/users/AntonPalich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AntonPalich/subscriptions","organizations_url":"https://api.github.com/users/AntonPalich/orgs","repos_url":"https://api.github.com/users/AntonPalich/repos","events_url":"https://api.github.com/users/AntonPalich/events{/privacy}","received_events_url":"https://api.github.com/users/AntonPalich/received_events","type":"User","site_admin":false},"body":"Please, revert this change","created_at":"2018-12-10T10:47:28Z","updated_at":"2018-12-10T10:50:20Z","html_url":"https://github.com/badoo/Chatto/pull/538#discussion_r240162574","pull_request_url":"https://api.github.com/repos/badoo/Chatto/pulls/538","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/badoo/Chatto/pulls/comments/240162574"},"html":{"href":"https://github.com/badoo/Chatto/pull/538#discussion_r240162574"},"pull_request":{"href":"https://api.github.com/repos/badoo/Chatto/pulls/538"}}},"pull_request":{"url":"https://api.github.com/repos/badoo/Chatto/pulls/538","id":236153056,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MTUzMDU2","html_url":"https://github.com/badoo/Chatto/pull/538","diff_url":"https://github.com/badoo/Chatto/pull/538.diff","patch_url":"https://github.com/badoo/Chatto/pull/538.patch","issue_url":"https://api.github.com/repos/badoo/Chatto/issues/538","number":538,"state":"open","locked":false,"title":"Fix force unwrap in BaseCollectionViewController","user":{"login":"alaija","id":12547275,"node_id":"MDQ6VXNlcjEyNTQ3Mjc1","avatar_url":"https://avatars2.githubusercontent.com/u/12547275?v=4","gravatar_id":"","url":"https://api.github.com/users/alaija","html_url":"https://github.com/alaija","followers_url":"https://api.github.com/users/alaija/followers","following_url":"https://api.github.com/users/alaija/following{/other_user}","gists_url":"https://api.github.com/users/alaija/gists{/gist_id}","starred_url":"https://api.github.com/users/alaija/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alaija/subscriptions","organizations_url":"https://api.github.com/users/alaija/orgs","repos_url":"https://api.github.com/users/alaija/repos","events_url":"https://api.github.com/users/alaija/events{/privacy}","received_events_url":"https://api.github.com/users/alaija/received_events","type":"User","site_admin":false},"body":"Force unwrap leads to crash in cases when ViewController addresses to collectionview before it was loaded. e.g. You can try to rotate device when chat is initialized inside unopened tab inside UITabBarController.","created_at":"2018-12-05T12:17:12Z","updated_at":"2018-12-10T10:50:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d6bf61f4302c2ea7bc2101f8a059f5868e361920","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/badoo/Chatto/pulls/538/commits","review_comments_url":"https://api.github.com/repos/badoo/Chatto/pulls/538/comments","review_comment_url":"https://api.github.com/repos/badoo/Chatto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/badoo/Chatto/issues/538/comments","statuses_url":"https://api.github.com/repos/badoo/Chatto/statuses/eb0ea2fbfa42a8de106ed38bdbbb87973681fb7f","head":{"label":"alaija:bugfix/force_unwrap_collectionview","ref":"bugfix/force_unwrap_collectionview","sha":"eb0ea2fbfa42a8de106ed38bdbbb87973681fb7f","user":{"login":"alaija","id":12547275,"node_id":"MDQ6VXNlcjEyNTQ3Mjc1","avatar_url":"https://avatars2.githubusercontent.com/u/12547275?v=4","gravatar_id":"","url":"https://api.github.com/users/alaija","html_url":"https://github.com/alaija","followers_url":"https://api.github.com/users/alaija/followers","following_url":"https://api.github.com/users/alaija/following{/other_user}","gists_url":"https://api.github.com/users/alaija/gists{/gist_id}","starred_url":"https://api.github.com/users/alaija/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alaija/subscriptions","organizations_url":"https://api.github.com/users/alaija/orgs","repos_url":"https://api.github.com/users/alaija/repos","events_url":"https://api.github.com/users/alaija/events{/privacy}","received_events_url":"https://api.github.com/users/alaija/received_events","type":"User","site_admin":false},"repo":{"id":160508035,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA1MDgwMzU=","name":"Chatto","full_name":"alaija/Chatto","private":false,"owner":{"login":"alaija","id":12547275,"node_id":"MDQ6VXNlcjEyNTQ3Mjc1","avatar_url":"https://avatars2.githubusercontent.com/u/12547275?v=4","gravatar_id":"","url":"https://api.github.com/users/alaija","html_url":"https://github.com/alaija","followers_url":"https://api.github.com/users/alaija/followers","following_url":"https://api.github.com/users/alaija/following{/other_user}","gists_url":"https://api.github.com/users/alaija/gists{/gist_id}","starred_url":"https://api.github.com/users/alaija/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alaija/subscriptions","organizations_url":"https://api.github.com/users/alaija/orgs","repos_url":"https://api.github.com/users/alaija/repos","events_url":"https://api.github.com/users/alaija/events{/privacy}","received_events_url":"https://api.github.com/users/alaija/received_events","type":"User","site_admin":false},"html_url":"https://github.com/alaija/Chatto","description":"A lightweight framework to build chat applications, made in Swift","fork":true,"url":"https://api.github.com/repos/alaija/Chatto","forks_url":"https://api.github.com/repos/alaija/Chatto/forks","keys_url":"https://api.github.com/repos/alaija/Chatto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alaija/Chatto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alaija/Chatto/teams","hooks_url":"https://api.github.com/repos/alaija/Chatto/hooks","issue_events_url":"https://api.github.com/repos/alaija/Chatto/issues/events{/number}","events_url":"https://api.github.com/repos/alaija/Chatto/events","assignees_url":"https://api.github.com/repos/alaija/Chatto/assignees{/user}","branches_url":"https://api.github.com/repos/alaija/Chatto/branches{/branch}","tags_url":"https://api.github.com/repos/alaija/Chatto/tags","blobs_url":"https://api.github.com/repos/alaija/Chatto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alaija/Chatto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alaija/Chatto/git/refs{/sha}","trees_url":"https://api.github.com/repos/alaija/Chatto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alaija/Chatto/statuses/{sha}","languages_url":"https://api.github.com/repos/alaija/Chatto/languages","stargazers_url":"https://api.github.com/repos/alaija/Chatto/stargazers","contributors_url":"https://api.github.com/repos/alaija/Chatto/contributors","subscribers_url":"https://api.github.com/repos/alaija/Chatto/subscribers","subscription_url":"https://api.github.com/repos/alaija/Chatto/subscription","commits_url":"https://api.github.com/repos/alaija/Chatto/commits{/sha}","git_commits_url":"https://api.github.com/repos/alaija/Chatto/git/commits{/sha}","comments_url":"https://api.github.com/repos/alaija/Chatto/comments{/number}","issue_comment_url":"https://api.github.com/repos/alaija/Chatto/issues/comments{/number}","contents_url":"https://api.github.com/repos/alaija/Chatto/contents/{+path}","compare_url":"https://api.github.com/repos/alaija/Chatto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alaija/Chatto/merges","archive_url":"https://api.github.com/repos/alaija/Chatto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alaija/Chatto/downloads","issues_url":"https://api.github.com/repos/alaija/Chatto/issues{/number}","pulls_url":"https://api.github.com/repos/alaija/Chatto/pulls{/number}","milestones_url":"https://api.github.com/repos/alaija/Chatto/milestones{/number}","notifications_url":"https://api.github.com/repos/alaija/Chatto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alaija/Chatto/labels{/name}","releases_url":"https://api.github.com/repos/alaija/Chatto/releases{/id}","deployments_url":"https://api.github.com/repos/alaija/Chatto/deployments","created_at":"2018-12-05T11:27:01Z","updated_at":"2018-12-05T11:27:04Z","pushed_at":"2018-12-07T12:03:48Z","git_url":"git://github.com/alaija/Chatto.git","ssh_url":"git@github.com:alaija/Chatto.git","clone_url":"https://github.com/alaija/Chatto.git","svn_url":"https://github.com/alaija/Chatto","homepage":"","size":2781,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"badoo:master","ref":"master","sha":"baf2a761bf384cc2104f21ad4e544efae3cc6f9e","user":{"login":"badoo","id":1277442,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzc0NDI=","avatar_url":"https://avatars3.githubusercontent.com/u/1277442?v=4","gravatar_id":"","url":"https://api.github.com/users/badoo","html_url":"https://github.com/badoo","followers_url":"https://api.github.com/users/badoo/followers","following_url":"https://api.github.com/users/badoo/following{/other_user}","gists_url":"https://api.github.com/users/badoo/gists{/gist_id}","starred_url":"https://api.github.com/users/badoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/badoo/subscriptions","organizations_url":"https://api.github.com/users/badoo/orgs","repos_url":"https://api.github.com/users/badoo/repos","events_url":"https://api.github.com/users/badoo/events{/privacy}","received_events_url":"https://api.github.com/users/badoo/received_events","type":"Organization","site_admin":false},"repo":{"id":46873579,"node_id":"MDEwOlJlcG9zaXRvcnk0Njg3MzU3OQ==","name":"Chatto","full_name":"badoo/Chatto","private":false,"owner":{"login":"badoo","id":1277442,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzc0NDI=","avatar_url":"https://avatars3.githubusercontent.com/u/1277442?v=4","gravatar_id":"","url":"https://api.github.com/users/badoo","html_url":"https://github.com/badoo","followers_url":"https://api.github.com/users/badoo/followers","following_url":"https://api.github.com/users/badoo/following{/other_user}","gists_url":"https://api.github.com/users/badoo/gists{/gist_id}","starred_url":"https://api.github.com/users/badoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/badoo/subscriptions","organizations_url":"https://api.github.com/users/badoo/orgs","repos_url":"https://api.github.com/users/badoo/repos","events_url":"https://api.github.com/users/badoo/events{/privacy}","received_events_url":"https://api.github.com/users/badoo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/badoo/Chatto","description":"A lightweight framework to build chat applications, made in Swift","fork":false,"url":"https://api.github.com/repos/badoo/Chatto","forks_url":"https://api.github.com/repos/badoo/Chatto/forks","keys_url":"https://api.github.com/repos/badoo/Chatto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/badoo/Chatto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/badoo/Chatto/teams","hooks_url":"https://api.github.com/repos/badoo/Chatto/hooks","issue_events_url":"https://api.github.com/repos/badoo/Chatto/issues/events{/number}","events_url":"https://api.github.com/repos/badoo/Chatto/events","assignees_url":"https://api.github.com/repos/badoo/Chatto/assignees{/user}","branches_url":"https://api.github.com/repos/badoo/Chatto/branches{/branch}","tags_url":"https://api.github.com/repos/badoo/Chatto/tags","blobs_url":"https://api.github.com/repos/badoo/Chatto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/badoo/Chatto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/badoo/Chatto/git/refs{/sha}","trees_url":"https://api.github.com/repos/badoo/Chatto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/badoo/Chatto/statuses/{sha}","languages_url":"https://api.github.com/repos/badoo/Chatto/languages","stargazers_url":"https://api.github.com/repos/badoo/Chatto/stargazers","contributors_url":"https://api.github.com/repos/badoo/Chatto/contributors","subscribers_url":"https://api.github.com/repos/badoo/Chatto/subscribers","subscription_url":"https://api.github.com/repos/badoo/Chatto/subscription","commits_url":"https://api.github.com/repos/badoo/Chatto/commits{/sha}","git_commits_url":"https://api.github.com/repos/badoo/Chatto/git/commits{/sha}","comments_url":"https://api.github.com/repos/badoo/Chatto/comments{/number}","issue_comment_url":"https://api.github.com/repos/badoo/Chatto/issues/comments{/number}","contents_url":"https://api.github.com/repos/badoo/Chatto/contents/{+path}","compare_url":"https://api.github.com/repos/badoo/Chatto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/badoo/Chatto/merges","archive_url":"https://api.github.com/repos/badoo/Chatto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/badoo/Chatto/downloads","issues_url":"https://api.github.com/repos/badoo/Chatto/issues{/number}","pulls_url":"https://api.github.com/repos/badoo/Chatto/pulls{/number}","milestones_url":"https://api.github.com/repos/badoo/Chatto/milestones{/number}","notifications_url":"https://api.github.com/repos/badoo/Chatto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/badoo/Chatto/labels{/name}","releases_url":"https://api.github.com/repos/badoo/Chatto/releases{/id}","deployments_url":"https://api.github.com/repos/badoo/Chatto/deployments","created_at":"2015-11-25T16:30:26Z","updated_at":"2018-12-10T03:20:46Z","pushed_at":"2018-12-07T12:03:50Z","git_url":"git://github.com/badoo/Chatto.git","ssh_url":"git@github.com:badoo/Chatto.git","clone_url":"https://github.com/badoo/Chatto.git","svn_url":"https://github.com/badoo/Chatto","homepage":"","size":2778,"stargazers_count":3617,"watchers_count":3617,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":482,"mirror_url":null,"archived":false,"open_issues_count":127,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":482,"open_issues":127,"watchers":3617,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/badoo/Chatto/pulls/538"},"html":{"href":"https://github.com/badoo/Chatto/pull/538"},"issue":{"href":"https://api.github.com/repos/badoo/Chatto/issues/538"},"comments":{"href":"https://api.github.com/repos/badoo/Chatto/issues/538/comments"},"review_comments":{"href":"https://api.github.com/repos/badoo/Chatto/pulls/538/comments"},"review_comment":{"href":"https://api.github.com/repos/badoo/Chatto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/badoo/Chatto/pulls/538/commits"},"statuses":{"href":"https://api.github.com/repos/badoo/Chatto/statuses/eb0ea2fbfa42a8de106ed38bdbbb87973681fb7f"}},"author_association":"NONE"}}
{"actor":{"display_login":"AntonPalich"}}