{"action":"created","comment":{"url":"https://api.github.com/repos/OCA/server-tools/pulls/comments/211972841","pull_request_review_id":148501311,"id":211972841,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTk3Mjg0MQ==","diff_hunk":"@@ -2,73 +2,70 @@\n # © 2016 Therp BV <http://therp.nl>\n # © 2016 Antonio Espinosa <antonio.espinosa@tecnativa.com>\n # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).\n-import os\n+from os.path import join, isdir, isfile\n+from os import makedirs\n+from odoo import _, api, models, exceptions\n+from odoo.tools import config\n import logging\n-import urllib2\n import urlparse\n import subprocess\n-import tempfile\n-from odoo import _, api, models, exceptions\n-from odoo.tools import config\n+import requests\n+import base64\n+_logger = logging.getLogger(__name__)\n+\n+try:\n+    from cryptography.hazmat.backends import default_backend\n+    import josepy as jose\n+    from cryptography.hazmat.primitives.asymmetric import rsa\n+    from cryptography.hazmat.primitives import serialization\n+    from acme import client, crypto_util\n+    from acme.messages import NewRegistration\n+    import IPy\n+except ImportError as e:\n+    _logger.error(e)","path":"letsencrypt/models/letsencrypt.py","position":29,"original_position":29,"commit_id":"349647e59d5b45f6485cec46ba77e3c8f4815881","original_commit_id":"349647e59d5b45f6485cec46ba77e3c8f4815881","user":{"login":"hbrunn","id":2563186,"node_id":"MDQ6VXNlcjI1NjMxODY=","avatar_url":"https://avatars2.githubusercontent.com/u/2563186?v=4","gravatar_id":"","url":"https://api.github.com/users/hbrunn","html_url":"https://github.com/hbrunn","followers_url":"https://api.github.com/users/hbrunn/followers","following_url":"https://api.github.com/users/hbrunn/following{/other_user}","gists_url":"https://api.github.com/users/hbrunn/gists{/gist_id}","starred_url":"https://api.github.com/users/hbrunn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hbrunn/subscriptions","organizations_url":"https://api.github.com/users/hbrunn/orgs","repos_url":"https://api.github.com/users/hbrunn/repos","events_url":"https://api.github.com/users/hbrunn/events{/privacy}","received_events_url":"https://api.github.com/users/hbrunn/received_events","type":"User","site_admin":false},"body":"make this a debug message, as addons are loaded python wise even when they aren't installed","created_at":"2018-08-22T14:21:20Z","updated_at":"2018-08-22T14:39:00Z","html_url":"https://github.com/OCA/server-tools/pull/1194#discussion_r211972841","pull_request_url":"https://api.github.com/repos/OCA/server-tools/pulls/1194","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/OCA/server-tools/pulls/comments/211972841"},"html":{"href":"https://github.com/OCA/server-tools/pull/1194#discussion_r211972841"},"pull_request":{"href":"https://api.github.com/repos/OCA/server-tools/pulls/1194"}}},"pull_request":{"url":"https://api.github.com/repos/OCA/server-tools/pulls/1194","id":176143225,"node_id":"MDExOlB1bGxSZXF1ZXN0MTc2MTQzMjI1","html_url":"https://github.com/OCA/server-tools/pull/1194","diff_url":"https://github.com/OCA/server-tools/pull/1194.diff","patch_url":"https://github.com/OCA/server-tools/pull/1194.patch","issue_url":"https://api.github.com/repos/OCA/server-tools/issues/1194","number":1194,"state":"open","locked":false,"title":"[WIP] Use acme official client","user":{"login":"daramousk","id":3503159,"node_id":"MDQ6VXNlcjM1MDMxNTk=","avatar_url":"https://avatars3.githubusercontent.com/u/3503159?v=4","gravatar_id":"","url":"https://api.github.com/users/daramousk","html_url":"https://github.com/daramousk","followers_url":"https://api.github.com/users/daramousk/followers","following_url":"https://api.github.com/users/daramousk/following{/other_user}","gists_url":"https://api.github.com/users/daramousk/gists{/gist_id}","starred_url":"https://api.github.com/users/daramousk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daramousk/subscriptions","organizations_url":"https://api.github.com/users/daramousk/orgs","repos_url":"https://api.github.com/users/daramousk/repos","events_url":"https://api.github.com/users/daramousk/events{/privacy}","received_events_url":"https://api.github.com/users/daramousk/received_events","type":"User","site_admin":false},"body":"This is a work in progress, Mostly I am concerted with the usage of acme client libraries, I seem to have difficulties with their usage. There is a TODO on the code which I was not able to resolve so far, input over this will be greatly appreciated\r\n\r\ncc @hbrunn ","created_at":"2018-03-20T10:17:24Z","updated_at":"2018-08-22T14:38:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"190db0784f4bed34d11e6a78a5c88967b578aed4","assignee":{"login":"hbrunn","id":2563186,"node_id":"MDQ6VXNlcjI1NjMxODY=","avatar_url":"https://avatars2.githubusercontent.com/u/2563186?v=4","gravatar_id":"","url":"https://api.github.com/users/hbrunn","html_url":"https://github.com/hbrunn","followers_url":"https://api.github.com/users/hbrunn/followers","following_url":"https://api.github.com/users/hbrunn/following{/other_user}","gists_url":"https://api.github.com/users/hbrunn/gists{/gist_id}","starred_url":"https://api.github.com/users/hbrunn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hbrunn/subscriptions","organizations_url":"https://api.github.com/users/hbrunn/orgs","repos_url":"https://api.github.com/users/hbrunn/repos","events_url":"https://api.github.com/users/hbrunn/events{/privacy}","received_events_url":"https://api.github.com/users/hbrunn/received_events","type":"User","site_admin":false},"assignees":[{"login":"hbrunn","id":2563186,"node_id":"MDQ6VXNlcjI1NjMxODY=","avatar_url":"https://avatars2.githubusercontent.com/u/2563186?v=4","gravatar_id":"","url":"https://api.github.com/users/hbrunn","html_url":"https://github.com/hbrunn","followers_url":"https://api.github.com/users/hbrunn/followers","following_url":"https://api.github.com/users/hbrunn/following{/other_user}","gists_url":"https://api.github.com/users/hbrunn/gists{/gist_id}","starred_url":"https://api.github.com/users/hbrunn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hbrunn/subscriptions","organizations_url":"https://api.github.com/users/hbrunn/orgs","repos_url":"https://api.github.com/users/hbrunn/repos","events_url":"https://api.github.com/users/hbrunn/events{/privacy}","received_events_url":"https://api.github.com/users/hbrunn/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":116644613,"node_id":"MDU6TGFiZWwxMTY2NDQ2MTM=","url":"https://api.github.com/repos/OCA/server-tools/labels/needs%20review","name":"needs review","color":"fbca04","default":false}],"milestone":{"url":"https://api.github.com/repos/OCA/server-tools/milestones/5","html_url":"https://github.com/OCA/server-tools/milestone/5","labels_url":"https://api.github.com/repos/OCA/server-tools/milestones/5/labels","id":2052382,"node_id":"MDk6TWlsZXN0b25lMjA1MjM4Mg==","number":5,"title":"10.0","description":null,"creator":{"login":"pedrobaeza","id":7165771,"node_id":"MDQ6VXNlcjcxNjU3NzE=","avatar_url":"https://avatars2.githubusercontent.com/u/7165771?v=4","gravatar_id":"","url":"https://api.github.com/users/pedrobaeza","html_url":"https://github.com/pedrobaeza","followers_url":"https://api.github.com/users/pedrobaeza/followers","following_url":"https://api.github.com/users/pedrobaeza/following{/other_user}","gists_url":"https://api.github.com/users/pedrobaeza/gists{/gist_id}","starred_url":"https://api.github.com/users/pedrobaeza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedrobaeza/subscriptions","organizations_url":"https://api.github.com/users/pedrobaeza/orgs","repos_url":"https://api.github.com/users/pedrobaeza/repos","events_url":"https://api.github.com/users/pedrobaeza/events{/privacy}","received_events_url":"https://api.github.com/users/pedrobaeza/received_events","type":"User","site_admin":false},"open_issues":44,"closed_issues":134,"state":"open","created_at":"2016-10-06T14:08:32Z","updated_at":"2018-08-12T15:07:11Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/OCA/server-tools/pulls/1194/commits","review_comments_url":"https://api.github.com/repos/OCA/server-tools/pulls/1194/comments","review_comment_url":"https://api.github.com/repos/OCA/server-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OCA/server-tools/issues/1194/comments","statuses_url":"https://api.github.com/repos/OCA/server-tools/statuses/349647e59d5b45f6485cec46ba77e3c8f4815881","head":{"label":"daramousk:10.0-use-acme-client","ref":"10.0-use-acme-client","sha":"349647e59d5b45f6485cec46ba77e3c8f4815881","user":{"login":"daramousk","id":3503159,"node_id":"MDQ6VXNlcjM1MDMxNTk=","avatar_url":"https://avatars3.githubusercontent.com/u/3503159?v=4","gravatar_id":"","url":"https://api.github.com/users/daramousk","html_url":"https://github.com/daramousk","followers_url":"https://api.github.com/users/daramousk/followers","following_url":"https://api.github.com/users/daramousk/following{/other_user}","gists_url":"https://api.github.com/users/daramousk/gists{/gist_id}","starred_url":"https://api.github.com/users/daramousk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daramousk/subscriptions","organizations_url":"https://api.github.com/users/daramousk/orgs","repos_url":"https://api.github.com/users/daramousk/repos","events_url":"https://api.github.com/users/daramousk/events{/privacy}","received_events_url":"https://api.github.com/users/daramousk/received_events","type":"User","site_admin":false},"repo":{"id":89379727,"node_id":"MDEwOlJlcG9zaXRvcnk4OTM3OTcyNw==","name":"server-tools","full_name":"daramousk/server-tools","owner":{"login":"daramousk","id":3503159,"node_id":"MDQ6VXNlcjM1MDMxNTk=","avatar_url":"https://avatars3.githubusercontent.com/u/3503159?v=4","gravatar_id":"","url":"https://api.github.com/users/daramousk","html_url":"https://github.com/daramousk","followers_url":"https://api.github.com/users/daramousk/followers","following_url":"https://api.github.com/users/daramousk/following{/other_user}","gists_url":"https://api.github.com/users/daramousk/gists{/gist_id}","starred_url":"https://api.github.com/users/daramousk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daramousk/subscriptions","organizations_url":"https://api.github.com/users/daramousk/orgs","repos_url":"https://api.github.com/users/daramousk/repos","events_url":"https://api.github.com/users/daramousk/events{/privacy}","received_events_url":"https://api.github.com/users/daramousk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/daramousk/server-tools","description":"Tools for Odoo Administrators to improve some technical features on Odoo.","fork":true,"url":"https://api.github.com/repos/daramousk/server-tools","forks_url":"https://api.github.com/repos/daramousk/server-tools/forks","keys_url":"https://api.github.com/repos/daramousk/server-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/daramousk/server-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/daramousk/server-tools/teams","hooks_url":"https://api.github.com/repos/daramousk/server-tools/hooks","issue_events_url":"https://api.github.com/repos/daramousk/server-tools/issues/events{/number}","events_url":"https://api.github.com/repos/daramousk/server-tools/events","assignees_url":"https://api.github.com/repos/daramousk/server-tools/assignees{/user}","branches_url":"https://api.github.com/repos/daramousk/server-tools/branches{/branch}","tags_url":"https://api.github.com/repos/daramousk/server-tools/tags","blobs_url":"https://api.github.com/repos/daramousk/server-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/daramousk/server-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/daramousk/server-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/daramousk/server-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/daramousk/server-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/daramousk/server-tools/languages","stargazers_url":"https://api.github.com/repos/daramousk/server-tools/stargazers","contributors_url":"https://api.github.com/repos/daramousk/server-tools/contributors","subscribers_url":"https://api.github.com/repos/daramousk/server-tools/subscribers","subscription_url":"https://api.github.com/repos/daramousk/server-tools/subscription","commits_url":"https://api.github.com/repos/daramousk/server-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/daramousk/server-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/daramousk/server-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/daramousk/server-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/daramousk/server-tools/contents/{+path}","compare_url":"https://api.github.com/repos/daramousk/server-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/daramousk/server-tools/merges","archive_url":"https://api.github.com/repos/daramousk/server-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/daramousk/server-tools/downloads","issues_url":"https://api.github.com/repos/daramousk/server-tools/issues{/number}","pulls_url":"https://api.github.com/repos/daramousk/server-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/daramousk/server-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/daramousk/server-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/daramousk/server-tools/labels{/name}","releases_url":"https://api.github.com/repos/daramousk/server-tools/releases{/id}","deployments_url":"https://api.github.com/repos/daramousk/server-tools/deployments","created_at":"2017-04-25T15:57:05Z","updated_at":"2017-04-25T15:57:11Z","pushed_at":"2018-07-30T13:22:21Z","git_url":"git://github.com/daramousk/server-tools.git","ssh_url":"git@github.com:daramousk/server-tools.git","clone_url":"https://github.com/daramousk/server-tools.git","svn_url":"https://github.com/daramousk/server-tools","homepage":"https://odoo-community.org/project/tools-maintainers-30","size":16961,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"10.0"}},"base":{"label":"OCA:10.0","ref":"10.0","sha":"87f1dea29796dfd6ce1235426a808a7477c73715","user":{"login":"OCA","id":7600578,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MDA1Nzg=","avatar_url":"https://avatars1.githubusercontent.com/u/7600578?v=4","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"repo":{"id":20896532,"node_id":"MDEwOlJlcG9zaXRvcnkyMDg5NjUzMg==","name":"server-tools","full_name":"OCA/server-tools","owner":{"login":"OCA","id":7600578,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MDA1Nzg=","avatar_url":"https://avatars1.githubusercontent.com/u/7600578?v=4","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OCA/server-tools","description":"Tools for Odoo Administrators to improve some technical features on Odoo.","fork":false,"url":"https://api.github.com/repos/OCA/server-tools","forks_url":"https://api.github.com/repos/OCA/server-tools/forks","keys_url":"https://api.github.com/repos/OCA/server-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OCA/server-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OCA/server-tools/teams","hooks_url":"https://api.github.com/repos/OCA/server-tools/hooks","issue_events_url":"https://api.github.com/repos/OCA/server-tools/issues/events{/number}","events_url":"https://api.github.com/repos/OCA/server-tools/events","assignees_url":"https://api.github.com/repos/OCA/server-tools/assignees{/user}","branches_url":"https://api.github.com/repos/OCA/server-tools/branches{/branch}","tags_url":"https://api.github.com/repos/OCA/server-tools/tags","blobs_url":"https://api.github.com/repos/OCA/server-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OCA/server-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OCA/server-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/OCA/server-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OCA/server-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/OCA/server-tools/languages","stargazers_url":"https://api.github.com/repos/OCA/server-tools/stargazers","contributors_url":"https://api.github.com/repos/OCA/server-tools/contributors","subscribers_url":"https://api.github.com/repos/OCA/server-tools/subscribers","subscription_url":"https://api.github.com/repos/OCA/server-tools/subscription","commits_url":"https://api.github.com/repos/OCA/server-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/OCA/server-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/OCA/server-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/OCA/server-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/OCA/server-tools/contents/{+path}","compare_url":"https://api.github.com/repos/OCA/server-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OCA/server-tools/merges","archive_url":"https://api.github.com/repos/OCA/server-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OCA/server-tools/downloads","issues_url":"https://api.github.com/repos/OCA/server-tools/issues{/number}","pulls_url":"https://api.github.com/repos/OCA/server-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/OCA/server-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/OCA/server-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OCA/server-tools/labels{/name}","releases_url":"https://api.github.com/repos/OCA/server-tools/releases{/id}","deployments_url":"https://api.github.com/repos/OCA/server-tools/deployments","created_at":"2014-06-16T18:52:44Z","updated_at":"2018-08-20T10:53:21Z","pushed_at":"2018-08-22T13:29:00Z","git_url":"git://github.com/OCA/server-tools.git","ssh_url":"git@github.com:OCA/server-tools.git","clone_url":"https://github.com/OCA/server-tools.git","svn_url":"https://github.com/OCA/server-tools","homepage":"https://odoo-community.org/project/tools-maintainers-30","size":21415,"stargazers_count":244,"watchers_count":244,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":721,"mirror_url":null,"archived":false,"open_issues_count":247,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":721,"open_issues":247,"watchers":244,"default_branch":"11.0"}},"_links":{"self":{"href":"https://api.github.com/repos/OCA/server-tools/pulls/1194"},"html":{"href":"https://github.com/OCA/server-tools/pull/1194"},"issue":{"href":"https://api.github.com/repos/OCA/server-tools/issues/1194"},"comments":{"href":"https://api.github.com/repos/OCA/server-tools/issues/1194/comments"},"review_comments":{"href":"https://api.github.com/repos/OCA/server-tools/pulls/1194/comments"},"review_comment":{"href":"https://api.github.com/repos/OCA/server-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OCA/server-tools/pulls/1194/commits"},"statuses":{"href":"https://api.github.com/repos/OCA/server-tools/statuses/349647e59d5b45f6485cec46ba77e3c8f4815881"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"hbrunn"}}