{"action":"created","issue":{"url":"https://api.github.com/repos/scikit-image/scikit-image/issues/3469","repository_url":"https://api.github.com/repos/scikit-image/scikit-image","labels_url":"https://api.github.com/repos/scikit-image/scikit-image/issues/3469/labels{/name}","comments_url":"https://api.github.com/repos/scikit-image/scikit-image/issues/3469/comments","events_url":"https://api.github.com/repos/scikit-image/scikit-image/issues/3469/events","html_url":"https://github.com/scikit-image/scikit-image/pull/3469","id":369208161,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMjA1NDAy","number":3469,"title":"[WIP] Add fused types, attempt to use in denoise","user":{"login":"AetherUnbound","id":10214785,"node_id":"MDQ6VXNlcjEwMjE0Nzg1","avatar_url":"https://avatars0.githubusercontent.com/u/10214785?v=4","gravatar_id":"","url":"https://api.github.com/users/AetherUnbound","html_url":"https://github.com/AetherUnbound","followers_url":"https://api.github.com/users/AetherUnbound/followers","following_url":"https://api.github.com/users/AetherUnbound/following{/other_user}","gists_url":"https://api.github.com/users/AetherUnbound/gists{/gist_id}","starred_url":"https://api.github.com/users/AetherUnbound/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AetherUnbound/subscriptions","organizations_url":"https://api.github.com/users/AetherUnbound/orgs","repos_url":"https://api.github.com/users/AetherUnbound/repos","events_url":"https://api.github.com/users/AetherUnbound/events{/privacy}","received_events_url":"https://api.github.com/users/AetherUnbound/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":18,"created_at":"2018-10-11T16:40:24Z","updated_at":"2018-10-12T18:32:14Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/scikit-image/scikit-image/pulls/3469","html_url":"https://github.com/scikit-image/scikit-image/pull/3469","diff_url":"https://github.com/scikit-image/scikit-image/pull/3469.diff","patch_url":"https://github.com/scikit-image/scikit-image/pull/3469.patch"},"body":"## Description\r\nThis is my first stab at adding the fused types from #3253 in order to fix the issue identified in #3449. I'm totally new to Cython as a whole, so I'm open to assistance with this one! \r\n\r\n## Checklist\r\n- [ ] Clean style in [the spirit of PEP8](https://www.python.org/dev/peps/pep-0008/)\r\n- [ ] [Docstrings for all functions](https://github.com/numpy/numpy/blob/master/doc/example.py)\r\n- [ ] Gallery example in `./doc/examples` (new features only)\r\n- [ ] Benchmark in `./benchmarks`, if your changes aren't covered by an\r\n  existing benchmark\r\n- [ ] Unit tests\r\n\r\n\r\n## For reviewers\r\n\r\n(Don't remove the checklist below.)\r\n\r\n- [ ] Check that the PR title is short, concise, and will make sense 1 year\r\n  later.\r\n- [ ] Check that new functions are imported in corresponding `__init__.py`.\r\n- [ ] Check that new features, API changes, and deprecations are mentioned in\r\n      `doc/release/release_dev.rst`.\r\n- [ ] Consider backporting the PR with `@meeseeksdev backport to v0.14.x`\r\n"},"comment":{"url":"https://api.github.com/repos/scikit-image/scikit-image/issues/comments/429418795","html_url":"https://github.com/scikit-image/scikit-image/pull/3469#issuecomment-429418795","issue_url":"https://api.github.com/repos/scikit-image/scikit-image/issues/3469","id":429418795,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTQxODc5NQ==","user":{"login":"AetherUnbound","id":10214785,"node_id":"MDQ6VXNlcjEwMjE0Nzg1","avatar_url":"https://avatars0.githubusercontent.com/u/10214785?v=4","gravatar_id":"","url":"https://api.github.com/users/AetherUnbound","html_url":"https://github.com/AetherUnbound","followers_url":"https://api.github.com/users/AetherUnbound/followers","following_url":"https://api.github.com/users/AetherUnbound/following{/other_user}","gists_url":"https://api.github.com/users/AetherUnbound/gists{/gist_id}","starred_url":"https://api.github.com/users/AetherUnbound/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AetherUnbound/subscriptions","organizations_url":"https://api.github.com/users/AetherUnbound/orgs","repos_url":"https://api.github.com/users/AetherUnbound/repos","events_url":"https://api.github.com/users/AetherUnbound/events{/privacy}","received_events_url":"https://api.github.com/users/AetherUnbound/received_events","type":"User","site_admin":false},"created_at":"2018-10-12T18:32:14Z","updated_at":"2018-10-12T18:32:14Z","author_association":"NONE","body":"Turns out I wasn't close at all (cause I was checking if the parameter passed in was `np.float32`, not if it's type was `np.float32`). Here's where I'm at now: \r\n```\r\ncdef inline np_floats[:] _np_empty(Py_ssize_t size, np_floats dtype):\r\n    if np_floats is np.float32:\r\n        return np.empty(size, np.float32)\r\n    else:\r\n        return np.empty(size, np.float64)\r\n\r\n\r\ncdef inline np_floats[:, :, ::1] _np_zeros(tuple shape, np_floats[:, :, ::1] dtype):\r\n    if np_floats is np.float32:\r\n        return np.zeros(shape, np.float32)\r\n    else:\r\n        return np.zeros(shape, np.double)\r\n```"}}
{"actor":{"display_login":"AetherUnbound"}}