{"action":"created","comment":{"url":"https://api.github.com/repos/weaveworks/eksctl/pulls/comments/225604947","pull_request_review_id":165241269,"id":225604947,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTYwNDk0Nw==","diff_hunk":"@@ -220,3 +249,61 @@ func (c *StackCollection) DescribeStackEvents(i *Stack) ([]*cloudformation.Stack\n \t}\n \treturn resp.StackEvents, nil\n }\n+\n+func (c *StackCollection) doCreateChangesetRequest(i *Stack, action string, description string, templateBody []byte,\n+\tparameters map[string]string, withIAM bool) (string, error) {\n+\n+\tchangesetName := fmt.Sprintf(\"eksctl-%s-%d\", action, time.Now().Unix())","path":"pkg/cfn/manager/api.go","position":58,"original_position":58,"commit_id":"ade0f542270c59fe2133c8e02b11626f704d1e78","original_commit_id":"ade0f542270c59fe2133c8e02b11626f704d1e78","user":{"login":"richardcase","id":198425,"node_id":"MDQ6VXNlcjE5ODQyNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/198425?v=4","gravatar_id":"","url":"https://api.github.com/users/richardcase","html_url":"https://github.com/richardcase","followers_url":"https://api.github.com/users/richardcase/followers","following_url":"https://api.github.com/users/richardcase/following{/other_user}","gists_url":"https://api.github.com/users/richardcase/gists{/gist_id}","starred_url":"https://api.github.com/users/richardcase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardcase/subscriptions","organizations_url":"https://api.github.com/users/richardcase/orgs","repos_url":"https://api.github.com/users/richardcase/repos","events_url":"https://api.github.com/users/richardcase/events{/privacy}","received_events_url":"https://api.github.com/users/richardcase/received_events","type":"User","site_admin":false},"body":"I'll add and push a new change tomorrow\r\n","created_at":"2018-10-16T16:00:06Z","updated_at":"2018-10-16T16:00:06Z","html_url":"https://github.com/weaveworks/eksctl/pull/254#discussion_r225604947","pull_request_url":"https://api.github.com/repos/weaveworks/eksctl/pulls/254","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/weaveworks/eksctl/pulls/comments/225604947"},"html":{"href":"https://github.com/weaveworks/eksctl/pull/254#discussion_r225604947"},"pull_request":{"href":"https://api.github.com/repos/weaveworks/eksctl/pulls/254"}},"in_reply_to_id":225597684},"pull_request":{"url":"https://api.github.com/repos/weaveworks/eksctl/pulls/254","id":222635946,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNjM1OTQ2","html_url":"https://github.com/weaveworks/eksctl/pull/254","diff_url":"https://github.com/weaveworks/eksctl/pull/254.diff","patch_url":"https://github.com/weaveworks/eksctl/pull/254.patch","issue_url":"https://api.github.com/repos/weaveworks/eksctl/issues/254","number":254,"state":"open","locked":false,"title":"Nodegroup scaling ","user":{"login":"richardcase","id":198425,"node_id":"MDQ6VXNlcjE5ODQyNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/198425?v=4","gravatar_id":"","url":"https://api.github.com/users/richardcase","html_url":"https://github.com/richardcase","followers_url":"https://api.github.com/users/richardcase/followers","following_url":"https://api.github.com/users/richardcase/following{/other_user}","gists_url":"https://api.github.com/users/richardcase/gists{/gist_id}","starred_url":"https://api.github.com/users/richardcase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardcase/subscriptions","organizations_url":"https://api.github.com/users/richardcase/orgs","repos_url":"https://api.github.com/users/richardcase/repos","events_url":"https://api.github.com/users/richardcase/events{/privacy}","received_events_url":"https://api.github.com/users/richardcase/received_events","type":"User","site_admin":false},"body":"### Description\r\nInitial version of nodegroup scaling has been added. This scales\r\nby modifying the CloudFormation template for the nodegroup. The\r\nmodified template is used to create a changeset that is then\r\nexecuted.\r\n\r\nWhen scaling down/in (i.e. reducing the number of nodes) we rely\r\nsolely on the the resulting change to the ASG. This means that\r\nthe node(s) that are to be terminated aren't drained and so pods\r\nrunning on the terminating nodes may cause errors. In the future\r\nwe may consider picking the EC2 instances to be terminated and then\r\ndrain the nodes and then create a termination policy to ensure those\r\nnodes are killed.\r\n\r\nThis supercedes #191 and it relates to issue #116.\r\n\r\nTodo:\r\n- [x] Cloudformation template modification\r\n- [x] Changeset implementation\r\n- [x] Workload testing whilst scaling up\r\n- [x] Workload testing whilst scaling down  \r\n\r\n\r\n### Checklist\r\n- [x] Code compiles correctly (i.e `make build`)\r\n- [ ] Added tests that cover your change (if possible)\r\n- [x] All tests passing (i.e. `make test`)\r\n- [ ] Added/modified documentation as required (such as the README)\r\n- [ ] Added yourself to the `humans.txt` file\r\n","created_at":"2018-10-13T08:16:08Z","updated_at":"2018-10-16T16:00:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cac41f8aa127a2e46c24b17056bae4204b652f3e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/weaveworks/eksctl/pulls/254/commits","review_comments_url":"https://api.github.com/repos/weaveworks/eksctl/pulls/254/comments","review_comment_url":"https://api.github.com/repos/weaveworks/eksctl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/weaveworks/eksctl/issues/254/comments","statuses_url":"https://api.github.com/repos/weaveworks/eksctl/statuses/ade0f542270c59fe2133c8e02b11626f704d1e78","head":{"label":"weaveworks:nodegroup-scaling","ref":"nodegroup-scaling","sha":"ade0f542270c59fe2133c8e02b11626f704d1e78","user":{"login":"weaveworks","id":9976052,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NzYwNTI=","avatar_url":"https://avatars1.githubusercontent.com/u/9976052?v=4","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"repo":{"id":134539560,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ1Mzk1NjA=","name":"eksctl","full_name":"weaveworks/eksctl","private":false,"owner":{"login":"weaveworks","id":9976052,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NzYwNTI=","avatar_url":"https://avatars1.githubusercontent.com/u/9976052?v=4","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/weaveworks/eksctl","description":"a CLI for Amazon EKS","fork":false,"url":"https://api.github.com/repos/weaveworks/eksctl","forks_url":"https://api.github.com/repos/weaveworks/eksctl/forks","keys_url":"https://api.github.com/repos/weaveworks/eksctl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weaveworks/eksctl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weaveworks/eksctl/teams","hooks_url":"https://api.github.com/repos/weaveworks/eksctl/hooks","issue_events_url":"https://api.github.com/repos/weaveworks/eksctl/issues/events{/number}","events_url":"https://api.github.com/repos/weaveworks/eksctl/events","assignees_url":"https://api.github.com/repos/weaveworks/eksctl/assignees{/user}","branches_url":"https://api.github.com/repos/weaveworks/eksctl/branches{/branch}","tags_url":"https://api.github.com/repos/weaveworks/eksctl/tags","blobs_url":"https://api.github.com/repos/weaveworks/eksctl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weaveworks/eksctl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weaveworks/eksctl/git/refs{/sha}","trees_url":"https://api.github.com/repos/weaveworks/eksctl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weaveworks/eksctl/statuses/{sha}","languages_url":"https://api.github.com/repos/weaveworks/eksctl/languages","stargazers_url":"https://api.github.com/repos/weaveworks/eksctl/stargazers","contributors_url":"https://api.github.com/repos/weaveworks/eksctl/contributors","subscribers_url":"https://api.github.com/repos/weaveworks/eksctl/subscribers","subscription_url":"https://api.github.com/repos/weaveworks/eksctl/subscription","commits_url":"https://api.github.com/repos/weaveworks/eksctl/commits{/sha}","git_commits_url":"https://api.github.com/repos/weaveworks/eksctl/git/commits{/sha}","comments_url":"https://api.github.com/repos/weaveworks/eksctl/comments{/number}","issue_comment_url":"https://api.github.com/repos/weaveworks/eksctl/issues/comments{/number}","contents_url":"https://api.github.com/repos/weaveworks/eksctl/contents/{+path}","compare_url":"https://api.github.com/repos/weaveworks/eksctl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weaveworks/eksctl/merges","archive_url":"https://api.github.com/repos/weaveworks/eksctl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weaveworks/eksctl/downloads","issues_url":"https://api.github.com/repos/weaveworks/eksctl/issues{/number}","pulls_url":"https://api.github.com/repos/weaveworks/eksctl/pulls{/number}","milestones_url":"https://api.github.com/repos/weaveworks/eksctl/milestones{/number}","notifications_url":"https://api.github.com/repos/weaveworks/eksctl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weaveworks/eksctl/labels{/name}","releases_url":"https://api.github.com/repos/weaveworks/eksctl/releases{/id}","deployments_url":"https://api.github.com/repos/weaveworks/eksctl/deployments","created_at":"2018-05-23T08:41:03Z","updated_at":"2018-10-16T15:48:54Z","pushed_at":"2018-10-16T15:48:51Z","git_url":"git://github.com/weaveworks/eksctl.git","ssh_url":"git@github.com:weaveworks/eksctl.git","clone_url":"https://github.com/weaveworks/eksctl.git","svn_url":"https://github.com/weaveworks/eksctl","homepage":"https://eksctl.io","size":21487,"stargazers_count":557,"watchers_count":557,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":80,"mirror_url":null,"archived":false,"open_issues_count":76,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":80,"open_issues":76,"watchers":557,"default_branch":"master"}},"base":{"label":"weaveworks:master","ref":"master","sha":"d435854a25027c527b8ee0c9153a9a4448631927","user":{"login":"weaveworks","id":9976052,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NzYwNTI=","avatar_url":"https://avatars1.githubusercontent.com/u/9976052?v=4","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"repo":{"id":134539560,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ1Mzk1NjA=","name":"eksctl","full_name":"weaveworks/eksctl","private":false,"owner":{"login":"weaveworks","id":9976052,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NzYwNTI=","avatar_url":"https://avatars1.githubusercontent.com/u/9976052?v=4","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/weaveworks/eksctl","description":"a CLI for Amazon EKS","fork":false,"url":"https://api.github.com/repos/weaveworks/eksctl","forks_url":"https://api.github.com/repos/weaveworks/eksctl/forks","keys_url":"https://api.github.com/repos/weaveworks/eksctl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weaveworks/eksctl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weaveworks/eksctl/teams","hooks_url":"https://api.github.com/repos/weaveworks/eksctl/hooks","issue_events_url":"https://api.github.com/repos/weaveworks/eksctl/issues/events{/number}","events_url":"https://api.github.com/repos/weaveworks/eksctl/events","assignees_url":"https://api.github.com/repos/weaveworks/eksctl/assignees{/user}","branches_url":"https://api.github.com/repos/weaveworks/eksctl/branches{/branch}","tags_url":"https://api.github.com/repos/weaveworks/eksctl/tags","blobs_url":"https://api.github.com/repos/weaveworks/eksctl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weaveworks/eksctl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weaveworks/eksctl/git/refs{/sha}","trees_url":"https://api.github.com/repos/weaveworks/eksctl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weaveworks/eksctl/statuses/{sha}","languages_url":"https://api.github.com/repos/weaveworks/eksctl/languages","stargazers_url":"https://api.github.com/repos/weaveworks/eksctl/stargazers","contributors_url":"https://api.github.com/repos/weaveworks/eksctl/contributors","subscribers_url":"https://api.github.com/repos/weaveworks/eksctl/subscribers","subscription_url":"https://api.github.com/repos/weaveworks/eksctl/subscription","commits_url":"https://api.github.com/repos/weaveworks/eksctl/commits{/sha}","git_commits_url":"https://api.github.com/repos/weaveworks/eksctl/git/commits{/sha}","comments_url":"https://api.github.com/repos/weaveworks/eksctl/comments{/number}","issue_comment_url":"https://api.github.com/repos/weaveworks/eksctl/issues/comments{/number}","contents_url":"https://api.github.com/repos/weaveworks/eksctl/contents/{+path}","compare_url":"https://api.github.com/repos/weaveworks/eksctl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weaveworks/eksctl/merges","archive_url":"https://api.github.com/repos/weaveworks/eksctl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weaveworks/eksctl/downloads","issues_url":"https://api.github.com/repos/weaveworks/eksctl/issues{/number}","pulls_url":"https://api.github.com/repos/weaveworks/eksctl/pulls{/number}","milestones_url":"https://api.github.com/repos/weaveworks/eksctl/milestones{/number}","notifications_url":"https://api.github.com/repos/weaveworks/eksctl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weaveworks/eksctl/labels{/name}","releases_url":"https://api.github.com/repos/weaveworks/eksctl/releases{/id}","deployments_url":"https://api.github.com/repos/weaveworks/eksctl/deployments","created_at":"2018-05-23T08:41:03Z","updated_at":"2018-10-16T15:48:54Z","pushed_at":"2018-10-16T15:48:51Z","git_url":"git://github.com/weaveworks/eksctl.git","ssh_url":"git@github.com:weaveworks/eksctl.git","clone_url":"https://github.com/weaveworks/eksctl.git","svn_url":"https://github.com/weaveworks/eksctl","homepage":"https://eksctl.io","size":21487,"stargazers_count":557,"watchers_count":557,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":80,"mirror_url":null,"archived":false,"open_issues_count":76,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":80,"open_issues":76,"watchers":557,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/weaveworks/eksctl/pulls/254"},"html":{"href":"https://github.com/weaveworks/eksctl/pull/254"},"issue":{"href":"https://api.github.com/repos/weaveworks/eksctl/issues/254"},"comments":{"href":"https://api.github.com/repos/weaveworks/eksctl/issues/254/comments"},"review_comments":{"href":"https://api.github.com/repos/weaveworks/eksctl/pulls/254/comments"},"review_comment":{"href":"https://api.github.com/repos/weaveworks/eksctl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/weaveworks/eksctl/pulls/254/commits"},"statuses":{"href":"https://api.github.com/repos/weaveworks/eksctl/statuses/ade0f542270c59fe2133c8e02b11626f704d1e78"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"richardcase"}}