{"action":"created","issue":{"url":"https://api.github.com/repos/OpenLightingProject/ola/issues/1412","repository_url":"https://api.github.com/repos/OpenLightingProject/ola","labels_url":"https://api.github.com/repos/OpenLightingProject/ola/issues/1412/labels{/name}","comments_url":"https://api.github.com/repos/OpenLightingProject/ola/issues/1412/comments","events_url":"https://api.github.com/repos/OpenLightingProject/ola/issues/1412/events","html_url":"https://github.com/OpenLightingProject/ola/issues/1412","id":319461513,"node_id":"MDU6SXNzdWUzMTk0NjE1MTM=","number":1412,"title":"StreamRpcChannel uses root logger","user":{"login":"shenghaoyang","id":10371596,"node_id":"MDQ6VXNlcjEwMzcxNTk2","avatar_url":"https://avatars0.githubusercontent.com/u/10371596?v=4","gravatar_id":"","url":"https://api.github.com/users/shenghaoyang","html_url":"https://github.com/shenghaoyang","followers_url":"https://api.github.com/users/shenghaoyang/followers","following_url":"https://api.github.com/users/shenghaoyang/following{/other_user}","gists_url":"https://api.github.com/users/shenghaoyang/gists{/gist_id}","starred_url":"https://api.github.com/users/shenghaoyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shenghaoyang/subscriptions","organizations_url":"https://api.github.com/users/shenghaoyang/orgs","repos_url":"https://api.github.com/users/shenghaoyang/repos","events_url":"https://api.github.com/users/shenghaoyang/events{/privacy}","received_events_url":"https://api.github.com/users/shenghaoyang/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/OpenLightingProject/ola/milestones/9","html_url":"https://github.com/OpenLightingProject/ola/milestone/9","labels_url":"https://api.github.com/repos/OpenLightingProject/ola/milestones/9/labels","id":1457508,"node_id":"MDk6TWlsZXN0b25lMTQ1NzUwOA==","number":9,"title":"0.11.0","description":"New features","creator":{"login":"peternewman","id":6216436,"node_id":"MDQ6VXNlcjYyMTY0MzY=","avatar_url":"https://avatars0.githubusercontent.com/u/6216436?v=4","gravatar_id":"","url":"https://api.github.com/users/peternewman","html_url":"https://github.com/peternewman","followers_url":"https://api.github.com/users/peternewman/followers","following_url":"https://api.github.com/users/peternewman/following{/other_user}","gists_url":"https://api.github.com/users/peternewman/gists{/gist_id}","starred_url":"https://api.github.com/users/peternewman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peternewman/subscriptions","organizations_url":"https://api.github.com/users/peternewman/orgs","repos_url":"https://api.github.com/users/peternewman/repos","events_url":"https://api.github.com/users/peternewman/events{/privacy}","received_events_url":"https://api.github.com/users/peternewman/received_events","type":"User","site_admin":false},"open_issues":19,"closed_issues":147,"state":"open","created_at":"2015-12-12T22:03:07Z","updated_at":"2018-06-10T13:59:03Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2018-05-02T08:37:31Z","updated_at":"2018-06-10T13:59:03Z","closed_at":"2018-06-10T13:59:03Z","author_association":"CONTRIBUTOR","body":"Hello, \r\n\r\nI've been trying to use the python library to access OLA without using the wrapper class (so I can integrate the client into my own event loop). \r\n\r\nWhile going over the source code to figure out how the client works, I've found multiple logging calls that send log messages straight to the root logger in  ``ola/python/ola/rpc/StreamRpcChannel.py``.\r\n\r\nExample: \r\n```\r\n  def SocketReady(self):\r\n    \"\"\"Read data from the socket and handle when we get a full message.\r\n    Returns:\r\n      True if the socket remains connected, False if it was closed.\r\n    \"\"\"\r\n    data = self._socket.recv(self.RECEIVE_BUFFER_SIZE)\r\n    if data == '':\r\n      logging.info('OLAD Server Socket closed')\r\n      if self._close_callback is not None:\r\n```\r\n\r\nIs this intentional? There's no _clean_ way to prevent the OLA library from polluting the logs with its own messages, because OLA does not source a logger for itself. I could source my own logger for the main application and change the handler for the root logger to the null handler, but I don't think OLA should be directly logging to the root logger in the first place.\r\n\r\nRegards, \r\n\r\nShenghao Yang"},"comment":{"url":"https://api.github.com/repos/OpenLightingProject/ola/issues/comments/396051157","html_url":"https://github.com/OpenLightingProject/ola/issues/1412#issuecomment-396051157","issue_url":"https://api.github.com/repos/OpenLightingProject/ola/issues/1412","id":396051157,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NjA1MTE1Nw==","user":{"login":"shenghaoyang","id":10371596,"node_id":"MDQ6VXNlcjEwMzcxNTk2","avatar_url":"https://avatars0.githubusercontent.com/u/10371596?v=4","gravatar_id":"","url":"https://api.github.com/users/shenghaoyang","html_url":"https://github.com/shenghaoyang","followers_url":"https://api.github.com/users/shenghaoyang/followers","following_url":"https://api.github.com/users/shenghaoyang/following{/other_user}","gists_url":"https://api.github.com/users/shenghaoyang/gists{/gist_id}","starred_url":"https://api.github.com/users/shenghaoyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shenghaoyang/subscriptions","organizations_url":"https://api.github.com/users/shenghaoyang/orgs","repos_url":"https://api.github.com/users/shenghaoyang/repos","events_url":"https://api.github.com/users/shenghaoyang/events{/privacy}","received_events_url":"https://api.github.com/users/shenghaoyang/received_events","type":"User","site_admin":false},"created_at":"2018-06-10T13:59:02Z","updated_at":"2018-06-10T13:59:02Z","author_association":"CONTRIBUTOR","body":"Resolved in #1415 "}}
{"actor":{"display_login":"shenghaoyang"}}