{"action":"created","issue":{"url":"https://api.github.com/repos/nanodbc/nanodbc/issues/176","repository_url":"https://api.github.com/repos/nanodbc/nanodbc","labels_url":"https://api.github.com/repos/nanodbc/nanodbc/issues/176/labels{/name}","comments_url":"https://api.github.com/repos/nanodbc/nanodbc/issues/176/comments","events_url":"https://api.github.com/repos/nanodbc/nanodbc/issues/176/events","html_url":"https://github.com/nanodbc/nanodbc/pull/176","id":331482293,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MTk4Njcy","number":176,"title":"Use strlen(buffer) to determine break and append size","user":{"login":"renkun-ken","id":4662568,"node_id":"MDQ6VXNlcjQ2NjI1Njg=","avatar_url":"https://avatars2.githubusercontent.com/u/4662568?v=4","gravatar_id":"","url":"https://api.github.com/users/renkun-ken","html_url":"https://github.com/renkun-ken","followers_url":"https://api.github.com/users/renkun-ken/followers","following_url":"https://api.github.com/users/renkun-ken/following{/other_user}","gists_url":"https://api.github.com/users/renkun-ken/gists{/gist_id}","starred_url":"https://api.github.com/users/renkun-ken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renkun-ken/subscriptions","organizations_url":"https://api.github.com/users/renkun-ken/orgs","repos_url":"https://api.github.com/users/renkun-ken/repos","events_url":"https://api.github.com/users/renkun-ken/events{/privacy}","received_events_url":"https://api.github.com/users/renkun-ken/received_events","type":"User","site_admin":false},"labels":[{"id":779169446,"node_id":"MDU6TGFiZWw3NzkxNjk0NDY=","url":"https://api.github.com/repos/nanodbc/nanodbc/labels/category/annoyance","name":"category/annoyance","color":"e102d8","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-06-12T08:12:33Z","updated_at":"2018-06-12T10:40:56Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/nanodbc/nanodbc/pulls/176","html_url":"https://github.com/nanodbc/nanodbc/pull/176","diff_url":"https://github.com/nanodbc/nanodbc/pull/176.diff","patch_url":"https://github.com/nanodbc/nanodbc/pull/176.patch"},"body":"## What does this PR do?\r\n\r\nFix text truncation caused by multiple trailing zeros in buffer (#174) and possible infinite looping when fetching text into buffer (#175).\r\n\r\n## What are related issues/pull requests?\r\n\r\nCloses #174.\r\nCloses #175.\r\n\r\n## Tasklist\r\n\r\n - [x] ~Add test case(s)~ Comment on rationale for the fix (see discussion below)\r\n - [x] Review\r\n - [x] Adjust for comments\r\n - [ ] All CI builds and checks have passed\r\n"},"comment":{"url":"https://api.github.com/repos/nanodbc/nanodbc/issues/comments/396545802","html_url":"https://github.com/nanodbc/nanodbc/pull/176#issuecomment-396545802","issue_url":"https://api.github.com/repos/nanodbc/nanodbc/issues/176","id":396545802,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NjU0NTgwMg==","user":{"login":"renkun-ken","id":4662568,"node_id":"MDQ6VXNlcjQ2NjI1Njg=","avatar_url":"https://avatars2.githubusercontent.com/u/4662568?v=4","gravatar_id":"","url":"https://api.github.com/users/renkun-ken","html_url":"https://github.com/renkun-ken","followers_url":"https://api.github.com/users/renkun-ken/followers","following_url":"https://api.github.com/users/renkun-ken/following{/other_user}","gists_url":"https://api.github.com/users/renkun-ken/gists{/gist_id}","starred_url":"https://api.github.com/users/renkun-ken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renkun-ken/subscriptions","organizations_url":"https://api.github.com/users/renkun-ken/orgs","repos_url":"https://api.github.com/users/renkun-ken/repos","events_url":"https://api.github.com/users/renkun-ken/events{/privacy}","received_events_url":"https://api.github.com/users/renkun-ken/received_events","type":"User","site_admin":false},"created_at":"2018-06-12T10:40:56Z","updated_at":"2018-06-12T10:40:56Z","author_association":"NONE","body":"The test case I added is subject to the choice of `buffer_size` (currently 1024). If it is changed, then this test case will sadly break. "}}
{"actor":{"display_login":"renkun-ken"}}