{"action":"created","issue":{"url":"https://api.github.com/repos/drupal-graphql/graphql/issues/687","repository_url":"https://api.github.com/repos/drupal-graphql/graphql","labels_url":"https://api.github.com/repos/drupal-graphql/graphql/issues/687/labels{/name}","comments_url":"https://api.github.com/repos/drupal-graphql/graphql/issues/687/comments","events_url":"https://api.github.com/repos/drupal-graphql/graphql/issues/687/events","html_url":"https://github.com/drupal-graphql/graphql/pull/687","id":365335730,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5Mjc5NjUx","number":687,"title":"Check for link attributes that are arrays and implode them.","user":{"login":"pavlosdan","id":5995324,"node_id":"MDQ6VXNlcjU5OTUzMjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5995324?v=4","gravatar_id":"","url":"https://api.github.com/users/pavlosdan","html_url":"https://github.com/pavlosdan","followers_url":"https://api.github.com/users/pavlosdan/followers","following_url":"https://api.github.com/users/pavlosdan/following{/other_user}","gists_url":"https://api.github.com/users/pavlosdan/gists{/gist_id}","starred_url":"https://api.github.com/users/pavlosdan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavlosdan/subscriptions","organizations_url":"https://api.github.com/users/pavlosdan/orgs","repos_url":"https://api.github.com/users/pavlosdan/repos","events_url":"https://api.github.com/users/pavlosdan/events{/privacy}","received_events_url":"https://api.github.com/users/pavlosdan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-01T07:18:21Z","updated_at":"2018-10-01T07:45:18Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/drupal-graphql/graphql/pulls/687","html_url":"https://github.com/drupal-graphql/graphql/pull/687","diff_url":"https://github.com/drupal-graphql/graphql/pull/687.diff","patch_url":"https://github.com/drupal-graphql/graphql/pull/687.patch"},"body":"The Link Attributes module recently implemented a change where it stores classes as an array instead of a string: https://www.drupal.org/project/link_attributes/issues/2900624\r\n\r\nThis breaks the MenuLinkAttribute and LinkAttribute fields which yield a string. Check if the attribute we are trying to yield is an array and implode it with a space if it is."},"comment":{"url":"https://api.github.com/repos/drupal-graphql/graphql/issues/comments/425817254","html_url":"https://github.com/drupal-graphql/graphql/pull/687#issuecomment-425817254","issue_url":"https://api.github.com/repos/drupal-graphql/graphql/issues/687","id":425817254,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTgxNzI1NA==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-10-01T07:45:18Z","updated_at":"2018-10-01T07:45:18Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/drupal-graphql/graphql/pull/687?src=pr&el=h1) Report\n> Merging [#687](https://codecov.io/gh/drupal-graphql/graphql/pull/687?src=pr&el=desc) into [8.x-3.x](https://codecov.io/gh/drupal-graphql/graphql/commit/46e0bc62f70bc394d5ac71e19acdaa4ef34bdab3?src=pr&el=desc) will **decrease** coverage by `0.02%`.\n> The diff coverage is `75%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/drupal-graphql/graphql/pull/687/graphs/tree.svg?width=650&token=n9Tbef3wbn&height=150&src=pr)](https://codecov.io/gh/drupal-graphql/graphql/pull/687?src=pr&el=tree)\n\n```diff\n@@              Coverage Diff              @@\n##             8.x-3.x     #687      +/-   ##\n=============================================\n- Coverage      79.89%   79.87%   -0.03%     \n- Complexity      1257     1259       +2     \n=============================================\n  Files            192      192              \n  Lines           3119     3125       +6     \n=============================================\n+ Hits            2492     2496       +4     \n- Misses           627      629       +2\n```\n\n\n| [Impacted Files](https://codecov.io/gh/drupal-graphql/graphql/pull/687?src=pr&el=tree) | Coverage Δ | Complexity Δ | |\n|---|---|---|---|\n| [...ugin/GraphQL/Fields/MenuLink/MenuLinkAttribute.php](https://codecov.io/gh/drupal-graphql/graphql/pull/687/diff?src=pr&el=tree#diff-bW9kdWxlcy9ncmFwaHFsX2NvcmUvc3JjL1BsdWdpbi9HcmFwaFFML0ZpZWxkcy9NZW51TGluay9NZW51TGlua0F0dHJpYnV0ZS5waHA=) | `85.71% <75%> (-14.29%)` | `3 <0> (+1)` | |\n| [...raphQL/Fields/Entity/Fields/Link/LinkAttribute.php](https://codecov.io/gh/drupal-graphql/graphql/pull/687/diff?src=pr&el=tree#diff-bW9kdWxlcy9ncmFwaHFsX2NvcmUvc3JjL1BsdWdpbi9HcmFwaFFML0ZpZWxkcy9FbnRpdHkvRmllbGRzL0xpbmsvTGlua0F0dHJpYnV0ZS5waHA=) | `85.71% <75%> (-14.29%)` | `3 <0> (+1)` | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/drupal-graphql/graphql/pull/687?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/drupal-graphql/graphql/pull/687?src=pr&el=footer). Last update [46e0bc6...02698df](https://codecov.io/gh/drupal-graphql/graphql/pull/687?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}