{"action":"created","issue":{"url":"https://api.github.com/repos/jethrokuan/fzf/issues/85","repository_url":"https://api.github.com/repos/jethrokuan/fzf","labels_url":"https://api.github.com/repos/jethrokuan/fzf/issues/85/labels{/name}","comments_url":"https://api.github.com/repos/jethrokuan/fzf/issues/85/comments","events_url":"https://api.github.com/repos/jethrokuan/fzf/issues/85/events","html_url":"https://github.com/jethrokuan/fzf/pull/85","id":367457857,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwODg2ODM1","number":85,"title":"Fisher V3 support","user":{"login":"jorgebucaran","id":56996,"node_id":"MDQ6VXNlcjU2OTk2","avatar_url":"https://avatars1.githubusercontent.com/u/56996?v=4","gravatar_id":"","url":"https://api.github.com/users/jorgebucaran","html_url":"https://github.com/jorgebucaran","followers_url":"https://api.github.com/users/jorgebucaran/followers","following_url":"https://api.github.com/users/jorgebucaran/following{/other_user}","gists_url":"https://api.github.com/users/jorgebucaran/gists{/gist_id}","starred_url":"https://api.github.com/users/jorgebucaran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorgebucaran/subscriptions","organizations_url":"https://api.github.com/users/jorgebucaran/orgs","repos_url":"https://api.github.com/users/jorgebucaran/repos","events_url":"https://api.github.com/users/jorgebucaran/events{/privacy}","received_events_url":"https://api.github.com/users/jorgebucaran/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-10-06T13:37:51Z","updated_at":"2018-10-17T02:27:58Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/jethrokuan/fzf/pulls/85","html_url":"https://github.com/jethrokuan/fzf/pull/85","diff_url":"https://github.com/jethrokuan/fzf/pull/85.diff","patch_url":"https://github.com/jethrokuan/fzf/pull/85.patch"},"body":"@jethrokuan This PR adds support for fisher V3. I'm not done yet. We need to add one dependency to support key bindings. This depedency is not yet up on GitHub, but I already have the implementation, see below.\r\n\r\nFor fish 2.x we'll need it. But the good news is fish >=3.0 lets you `bind` inside config.fish and configuration snippets, so we won't need it by then. 🎉 \r\n\r\n\r\n```\r\nfish-user-key-bindings\r\n└── conf.d\r\n    └── fish_user_key_bindings.fish\r\n```\r\n```fish\r\nif functions -q fish_user_key_bindings\r\n    if not functions -q _keybinder_fish_user_key_bindings\r\n        functions -c fish_user_key_bindings _keybinder_fish_user_key_bindings\r\n    end\r\nend\r\n\r\ntest -z \"$XDG_CONFIG_HOME\"; and set XDG_CONFIG_HOME ~/.config\r\n\r\nfunction fish_user_key_bindings\r\n    for file in $XDG_CONFIG_HOME/fish/conf.d/*_key_bindings.fish\r\n        source $file\r\n    end\r\n    if functions -q _keybinder_fish_user_key_bindings\r\n        _keybinder_fish_user_key_bindings\r\n    end\r\nend\r\n```\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/jethrokuan/fzf/issues/comments/430467273","html_url":"https://github.com/jethrokuan/fzf/pull/85#issuecomment-430467273","issue_url":"https://api.github.com/repos/jethrokuan/fzf/issues/85","id":430467273,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMDQ2NzI3Mw==","user":{"login":"jorgebucaran","id":56996,"node_id":"MDQ6VXNlcjU2OTk2","avatar_url":"https://avatars1.githubusercontent.com/u/56996?v=4","gravatar_id":"","url":"https://api.github.com/users/jorgebucaran","html_url":"https://github.com/jorgebucaran","followers_url":"https://api.github.com/users/jorgebucaran/followers","following_url":"https://api.github.com/users/jorgebucaran/following{/other_user}","gists_url":"https://api.github.com/users/jorgebucaran/gists{/gist_id}","starred_url":"https://api.github.com/users/jorgebucaran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorgebucaran/subscriptions","organizations_url":"https://api.github.com/users/jorgebucaran/orgs","repos_url":"https://api.github.com/users/jorgebucaran/repos","events_url":"https://api.github.com/users/jorgebucaran/events{/privacy}","received_events_url":"https://api.github.com/users/jorgebucaran/received_events","type":"User","site_admin":false},"created_at":"2018-10-17T02:27:58Z","updated_at":"2018-10-17T02:27:58Z","author_association":"CONTRIBUTOR","body":"Let's avoid a fisher _vs_ oh-my-fish confrontation here. I'm merely fixing fzf so that it uses the shell's canonical way to run fish code on shell startup which fisher adheres to.\r\n\r\nDoes oh-my-fish support configuration snippets? That's beside the point.\r\n\r\n\r\n> What if we just started another branch on this that fisher users can use until things get resolved?\r\n\r\nThe default behavior should be to support configuration snippets, so a branch should be prepared for oh-my-fish users instead if @jethrokuan wants.\r\n\r\nfzf does not need to do any extra work to be installed with fisher, on the contrary, it's oh-my-fish that (at the time of this writing) needs special treatment, therefore creating a special branch for fisher users is absurd."}}
{"actor":{"display_login":"jorgebucaran"}}