{"action":"created","comment":{"url":"https://api.github.com/repos/FEniCS/ffcx/pulls/comments/201869001","pull_request_review_id":136456257,"id":201869001,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTg2OTAwMQ==","diff_hunk":"@@ -96,13 +96,6 @@ def default_parameters():\n def default_jit_parameters():\n     parameters = default_parameters()\n \n-    # TODO: This is not in the above parameters dict.\n-    #       There are other parameters like this.\n-    #       This is confusing, which parameters are available? What are the defaults?\n-    # Skip evaluation of basis derivatives in elements by default because it's costly\n-    # FIXME: Make this False when we have elements generated once instead of for each form\n-    parameters[\"no-evaluate_basis_derivatives\"] = True","path":"ffc/parameters.py","position":9,"original_position":9,"commit_id":"f00a15dea1f3edd7eedd271d80713b1cf9f192eb","original_commit_id":"f00a15dea1f3edd7eedd271d80713b1cf9f192eb","user":{"login":"blechta","id":7361643,"node_id":"MDQ6VXNlcjczNjE2NDM=","avatar_url":"https://avatars3.githubusercontent.com/u/7361643?v=4","gravatar_id":"","url":"https://api.github.com/users/blechta","html_url":"https://github.com/blechta","followers_url":"https://api.github.com/users/blechta/followers","following_url":"https://api.github.com/users/blechta/following{/other_user}","gists_url":"https://api.github.com/users/blechta/gists{/gist_id}","starred_url":"https://api.github.com/users/blechta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blechta/subscriptions","organizations_url":"https://api.github.com/users/blechta/orgs","repos_url":"https://api.github.com/users/blechta/repos","events_url":"https://api.github.com/users/blechta/events{/privacy}","received_events_url":"https://api.github.com/users/blechta/received_events","type":"User","site_admin":false},"body":"Nevertheless that's not import for the purpose of this PR.","created_at":"2018-07-11T23:21:33Z","updated_at":"2018-07-11T23:21:33Z","html_url":"https://github.com/FEniCS/ffcx/pull/45#discussion_r201869001","pull_request_url":"https://api.github.com/repos/FEniCS/ffcx/pulls/45","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/FEniCS/ffcx/pulls/comments/201869001"},"html":{"href":"https://github.com/FEniCS/ffcx/pull/45#discussion_r201869001"},"pull_request":{"href":"https://api.github.com/repos/FEniCS/ffcx/pulls/45"}},"in_reply_to_id":201867292},"pull_request":{"url":"https://api.github.com/repos/FEniCS/ffcx/pulls/45","id":200834372,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwODM0Mzcy","html_url":"https://github.com/FEniCS/ffcx/pull/45","diff_url":"https://github.com/FEniCS/ffcx/pull/45.diff","patch_url":"https://github.com/FEniCS/ffcx/pull/45.patch","issue_url":"https://api.github.com/repos/FEniCS/ffcx/issues/45","number":45,"state":"open","locked":false,"title":"Use argparse in place of getopts","user":{"login":"garth-wells","id":3431333,"node_id":"MDQ6VXNlcjM0MzEzMzM=","avatar_url":"https://avatars0.githubusercontent.com/u/3431333?v=4","gravatar_id":"","url":"https://api.github.com/users/garth-wells","html_url":"https://github.com/garth-wells","followers_url":"https://api.github.com/users/garth-wells/followers","following_url":"https://api.github.com/users/garth-wells/following{/other_user}","gists_url":"https://api.github.com/users/garth-wells/gists{/gist_id}","starred_url":"https://api.github.com/users/garth-wells/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garth-wells/subscriptions","organizations_url":"https://api.github.com/users/garth-wells/orgs","repos_url":"https://api.github.com/users/garth-wells/repos","events_url":"https://api.github.com/users/garth-wells/events{/privacy}","received_events_url":"https://api.github.com/users/garth-wells/received_events","type":"User","site_admin":false},"body":"Fixes #17.","created_at":"2018-07-11T21:45:18Z","updated_at":"2018-07-11T23:21:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"48594a16814dd8a0dfb4ed87cfcb8cb5562cda4f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/FEniCS/ffcx/pulls/45/commits","review_comments_url":"https://api.github.com/repos/FEniCS/ffcx/pulls/45/comments","review_comment_url":"https://api.github.com/repos/FEniCS/ffcx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FEniCS/ffcx/issues/45/comments","statuses_url":"https://api.github.com/repos/FEniCS/ffcx/statuses/f00a15dea1f3edd7eedd271d80713b1cf9f192eb","head":{"label":"FEniCS:garth/use-argparse","ref":"garth/use-argparse","sha":"f00a15dea1f3edd7eedd271d80713b1cf9f192eb","user":{"login":"FEniCS","id":3868708,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4Njg3MDg=","avatar_url":"https://avatars2.githubusercontent.com/u/3868708?v=4","gravatar_id":"","url":"https://api.github.com/users/FEniCS","html_url":"https://github.com/FEniCS","followers_url":"https://api.github.com/users/FEniCS/followers","following_url":"https://api.github.com/users/FEniCS/following{/other_user}","gists_url":"https://api.github.com/users/FEniCS/gists{/gist_id}","starred_url":"https://api.github.com/users/FEniCS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FEniCS/subscriptions","organizations_url":"https://api.github.com/users/FEniCS/orgs","repos_url":"https://api.github.com/users/FEniCS/repos","events_url":"https://api.github.com/users/FEniCS/events{/privacy}","received_events_url":"https://api.github.com/users/FEniCS/received_events","type":"Organization","site_admin":false},"repo":{"id":128215037,"node_id":"MDEwOlJlcG9zaXRvcnkxMjgyMTUwMzc=","name":"ffcx","full_name":"FEniCS/ffcx","owner":{"login":"FEniCS","id":3868708,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4Njg3MDg=","avatar_url":"https://avatars2.githubusercontent.com/u/3868708?v=4","gravatar_id":"","url":"https://api.github.com/users/FEniCS","html_url":"https://github.com/FEniCS","followers_url":"https://api.github.com/users/FEniCS/followers","following_url":"https://api.github.com/users/FEniCS/following{/other_user}","gists_url":"https://api.github.com/users/FEniCS/gists{/gist_id}","starred_url":"https://api.github.com/users/FEniCS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FEniCS/subscriptions","organizations_url":"https://api.github.com/users/FEniCS/orgs","repos_url":"https://api.github.com/users/FEniCS/repos","events_url":"https://api.github.com/users/FEniCS/events{/privacy}","received_events_url":"https://api.github.com/users/FEniCS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FEniCS/ffcx","description":"Next generation FEniCS Form Compiler","fork":false,"url":"https://api.github.com/repos/FEniCS/ffcx","forks_url":"https://api.github.com/repos/FEniCS/ffcx/forks","keys_url":"https://api.github.com/repos/FEniCS/ffcx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FEniCS/ffcx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FEniCS/ffcx/teams","hooks_url":"https://api.github.com/repos/FEniCS/ffcx/hooks","issue_events_url":"https://api.github.com/repos/FEniCS/ffcx/issues/events{/number}","events_url":"https://api.github.com/repos/FEniCS/ffcx/events","assignees_url":"https://api.github.com/repos/FEniCS/ffcx/assignees{/user}","branches_url":"https://api.github.com/repos/FEniCS/ffcx/branches{/branch}","tags_url":"https://api.github.com/repos/FEniCS/ffcx/tags","blobs_url":"https://api.github.com/repos/FEniCS/ffcx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FEniCS/ffcx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FEniCS/ffcx/git/refs{/sha}","trees_url":"https://api.github.com/repos/FEniCS/ffcx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FEniCS/ffcx/statuses/{sha}","languages_url":"https://api.github.com/repos/FEniCS/ffcx/languages","stargazers_url":"https://api.github.com/repos/FEniCS/ffcx/stargazers","contributors_url":"https://api.github.com/repos/FEniCS/ffcx/contributors","subscribers_url":"https://api.github.com/repos/FEniCS/ffcx/subscribers","subscription_url":"https://api.github.com/repos/FEniCS/ffcx/subscription","commits_url":"https://api.github.com/repos/FEniCS/ffcx/commits{/sha}","git_commits_url":"https://api.github.com/repos/FEniCS/ffcx/git/commits{/sha}","comments_url":"https://api.github.com/repos/FEniCS/ffcx/comments{/number}","issue_comment_url":"https://api.github.com/repos/FEniCS/ffcx/issues/comments{/number}","contents_url":"https://api.github.com/repos/FEniCS/ffcx/contents/{+path}","compare_url":"https://api.github.com/repos/FEniCS/ffcx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FEniCS/ffcx/merges","archive_url":"https://api.github.com/repos/FEniCS/ffcx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FEniCS/ffcx/downloads","issues_url":"https://api.github.com/repos/FEniCS/ffcx/issues{/number}","pulls_url":"https://api.github.com/repos/FEniCS/ffcx/pulls{/number}","milestones_url":"https://api.github.com/repos/FEniCS/ffcx/milestones{/number}","notifications_url":"https://api.github.com/repos/FEniCS/ffcx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FEniCS/ffcx/labels{/name}","releases_url":"https://api.github.com/repos/FEniCS/ffcx/releases{/id}","deployments_url":"https://api.github.com/repos/FEniCS/ffcx/deployments","created_at":"2018-04-05T14:06:14Z","updated_at":"2018-07-03T14:09:46Z","pushed_at":"2018-07-11T21:47:15Z","git_url":"git://github.com/FEniCS/ffcx.git","ssh_url":"git@github.com:FEniCS/ffcx.git","clone_url":"https://github.com/FEniCS/ffcx.git","svn_url":"https://github.com/FEniCS/ffcx","homepage":"","size":9593,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2,"open_issues":17,"watchers":5,"default_branch":"master"}},"base":{"label":"FEniCS:master","ref":"master","sha":"99f2648663954a7a93d3768a7af05906f2a28e48","user":{"login":"FEniCS","id":3868708,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4Njg3MDg=","avatar_url":"https://avatars2.githubusercontent.com/u/3868708?v=4","gravatar_id":"","url":"https://api.github.com/users/FEniCS","html_url":"https://github.com/FEniCS","followers_url":"https://api.github.com/users/FEniCS/followers","following_url":"https://api.github.com/users/FEniCS/following{/other_user}","gists_url":"https://api.github.com/users/FEniCS/gists{/gist_id}","starred_url":"https://api.github.com/users/FEniCS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FEniCS/subscriptions","organizations_url":"https://api.github.com/users/FEniCS/orgs","repos_url":"https://api.github.com/users/FEniCS/repos","events_url":"https://api.github.com/users/FEniCS/events{/privacy}","received_events_url":"https://api.github.com/users/FEniCS/received_events","type":"Organization","site_admin":false},"repo":{"id":128215037,"node_id":"MDEwOlJlcG9zaXRvcnkxMjgyMTUwMzc=","name":"ffcx","full_name":"FEniCS/ffcx","owner":{"login":"FEniCS","id":3868708,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4Njg3MDg=","avatar_url":"https://avatars2.githubusercontent.com/u/3868708?v=4","gravatar_id":"","url":"https://api.github.com/users/FEniCS","html_url":"https://github.com/FEniCS","followers_url":"https://api.github.com/users/FEniCS/followers","following_url":"https://api.github.com/users/FEniCS/following{/other_user}","gists_url":"https://api.github.com/users/FEniCS/gists{/gist_id}","starred_url":"https://api.github.com/users/FEniCS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FEniCS/subscriptions","organizations_url":"https://api.github.com/users/FEniCS/orgs","repos_url":"https://api.github.com/users/FEniCS/repos","events_url":"https://api.github.com/users/FEniCS/events{/privacy}","received_events_url":"https://api.github.com/users/FEniCS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FEniCS/ffcx","description":"Next generation FEniCS Form Compiler","fork":false,"url":"https://api.github.com/repos/FEniCS/ffcx","forks_url":"https://api.github.com/repos/FEniCS/ffcx/forks","keys_url":"https://api.github.com/repos/FEniCS/ffcx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FEniCS/ffcx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FEniCS/ffcx/teams","hooks_url":"https://api.github.com/repos/FEniCS/ffcx/hooks","issue_events_url":"https://api.github.com/repos/FEniCS/ffcx/issues/events{/number}","events_url":"https://api.github.com/repos/FEniCS/ffcx/events","assignees_url":"https://api.github.com/repos/FEniCS/ffcx/assignees{/user}","branches_url":"https://api.github.com/repos/FEniCS/ffcx/branches{/branch}","tags_url":"https://api.github.com/repos/FEniCS/ffcx/tags","blobs_url":"https://api.github.com/repos/FEniCS/ffcx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FEniCS/ffcx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FEniCS/ffcx/git/refs{/sha}","trees_url":"https://api.github.com/repos/FEniCS/ffcx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FEniCS/ffcx/statuses/{sha}","languages_url":"https://api.github.com/repos/FEniCS/ffcx/languages","stargazers_url":"https://api.github.com/repos/FEniCS/ffcx/stargazers","contributors_url":"https://api.github.com/repos/FEniCS/ffcx/contributors","subscribers_url":"https://api.github.com/repos/FEniCS/ffcx/subscribers","subscription_url":"https://api.github.com/repos/FEniCS/ffcx/subscription","commits_url":"https://api.github.com/repos/FEniCS/ffcx/commits{/sha}","git_commits_url":"https://api.github.com/repos/FEniCS/ffcx/git/commits{/sha}","comments_url":"https://api.github.com/repos/FEniCS/ffcx/comments{/number}","issue_comment_url":"https://api.github.com/repos/FEniCS/ffcx/issues/comments{/number}","contents_url":"https://api.github.com/repos/FEniCS/ffcx/contents/{+path}","compare_url":"https://api.github.com/repos/FEniCS/ffcx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FEniCS/ffcx/merges","archive_url":"https://api.github.com/repos/FEniCS/ffcx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FEniCS/ffcx/downloads","issues_url":"https://api.github.com/repos/FEniCS/ffcx/issues{/number}","pulls_url":"https://api.github.com/repos/FEniCS/ffcx/pulls{/number}","milestones_url":"https://api.github.com/repos/FEniCS/ffcx/milestones{/number}","notifications_url":"https://api.github.com/repos/FEniCS/ffcx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FEniCS/ffcx/labels{/name}","releases_url":"https://api.github.com/repos/FEniCS/ffcx/releases{/id}","deployments_url":"https://api.github.com/repos/FEniCS/ffcx/deployments","created_at":"2018-04-05T14:06:14Z","updated_at":"2018-07-03T14:09:46Z","pushed_at":"2018-07-11T21:47:15Z","git_url":"git://github.com/FEniCS/ffcx.git","ssh_url":"git@github.com:FEniCS/ffcx.git","clone_url":"https://github.com/FEniCS/ffcx.git","svn_url":"https://github.com/FEniCS/ffcx","homepage":"","size":9593,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2,"open_issues":17,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FEniCS/ffcx/pulls/45"},"html":{"href":"https://github.com/FEniCS/ffcx/pull/45"},"issue":{"href":"https://api.github.com/repos/FEniCS/ffcx/issues/45"},"comments":{"href":"https://api.github.com/repos/FEniCS/ffcx/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/FEniCS/ffcx/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/FEniCS/ffcx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FEniCS/ffcx/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/FEniCS/ffcx/statuses/f00a15dea1f3edd7eedd271d80713b1cf9f192eb"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"blechta"}}