{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/28366","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/28366/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/28366/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/28366/events","html_url":"https://github.com/cockroachdb/cockroach/pull/28366","id":348580840,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2ODk2Nzgw","number":28366,"title":"sql: ceil no longer returns -0 for decimals","user":{"login":"mjibson","id":41181,"node_id":"MDQ6VXNlcjQxMTgx","avatar_url":"https://avatars1.githubusercontent.com/u/41181?v=4","gravatar_id":"","url":"https://api.github.com/users/mjibson","html_url":"https://github.com/mjibson","followers_url":"https://api.github.com/users/mjibson/followers","following_url":"https://api.github.com/users/mjibson/following{/other_user}","gists_url":"https://api.github.com/users/mjibson/gists{/gist_id}","starred_url":"https://api.github.com/users/mjibson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjibson/subscriptions","organizations_url":"https://api.github.com/users/mjibson/orgs","repos_url":"https://api.github.com/users/mjibson/repos","events_url":"https://api.github.com/users/mjibson/events{/privacy}","received_events_url":"https://api.github.com/users/mjibson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-08-08T05:32:28Z","updated_at":"2018-08-08T14:38:58Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/28366","html_url":"https://github.com/cockroachdb/cockroach/pull/28366","diff_url":"https://github.com/cockroachdb/cockroach/pull/28366.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/28366.patch"},"body":"This matches the postgres behavior (the float variant still returns -0\r\nboth here and in postgres).\r\n\r\nFixes #28363\r\n\r\nRelease note (sql change): The ceil and ceiling functions now return 0\r\nwhere they would have returned -0 previously."},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/411429463","html_url":"https://github.com/cockroachdb/cockroach/pull/28366#issuecomment-411429463","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/28366","id":411429463,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMTQyOTQ2Mw==","user":{"login":"knz","id":642886,"node_id":"MDQ6VXNlcjY0Mjg4Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/642886?v=4","gravatar_id":"","url":"https://api.github.com/users/knz","html_url":"https://github.com/knz","followers_url":"https://api.github.com/users/knz/followers","following_url":"https://api.github.com/users/knz/following{/other_user}","gists_url":"https://api.github.com/users/knz/gists{/gist_id}","starred_url":"https://api.github.com/users/knz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knz/subscriptions","organizations_url":"https://api.github.com/users/knz/orgs","repos_url":"https://api.github.com/users/knz/repos","events_url":"https://api.github.com/users/knz/events{/privacy}","received_events_url":"https://api.github.com/users/knz/received_events","type":"User","site_admin":false},"created_at":"2018-08-08T14:38:58Z","updated_at":"2018-08-08T14:38:58Z","author_association":"MEMBER","body":"@mjibson is there a way to have a flag in the `apd.Context` that makes the various functions flatten negative zeros to positive automatically? so that we don't have to hunt them down in cockroachdb."}}
{"actor":{"display_login":"knz"}}