{"action":"created","comment":{"url":"https://api.github.com/repos/eventespresso/event-espresso-core/pulls/comments/207312890","pull_request_review_id":142900700,"id":207312890,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzMxMjg5MA==","diff_hunk":"@@ -42,13 +42,13 @@ public static function load_textdomain()\n \n \n     /**\n-     * The purpose of this method is to sideload the lang file for the given WPLANG locale (if necessary).\n+     * The purpose of this method is to sideload all of the lang files for EE, this includes the POT file and also the PO/MO files for the given WPLANG locale (if necessary).\n      *\n      * @access private\n      * @static\n      * @return void\n      */\n-    private static function _maybe_get_langfile()\n+    private static function _maybe_get_langfiles()","path":"core/EE_Load_Textdomain.core.php","position":21,"original_position":21,"commit_id":"19fd02eeb4fa70f0693564992b979c85bade08b6","original_commit_id":"19fd02eeb4fa70f0693564992b979c85bade08b6","user":{"login":"tn3rb","id":1751030,"node_id":"MDQ6VXNlcjE3NTEwMzA=","avatar_url":"https://avatars1.githubusercontent.com/u/1751030?v=4","gravatar_id":"","url":"https://api.github.com/users/tn3rb","html_url":"https://github.com/tn3rb","followers_url":"https://api.github.com/users/tn3rb/followers","following_url":"https://api.github.com/users/tn3rb/following{/other_user}","gists_url":"https://api.github.com/users/tn3rb/gists{/gist_id}","starred_url":"https://api.github.com/users/tn3rb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tn3rb/subscriptions","organizations_url":"https://api.github.com/users/tn3rb/orgs","repos_url":"https://api.github.com/users/tn3rb/repos","events_url":"https://api.github.com/users/tn3rb/events{/privacy}","received_events_url":"https://api.github.com/users/tn3rb/received_events","type":"User","site_admin":false},"body":"same issue, can't rename public functions","created_at":"2018-08-02T17:38:33Z","updated_at":"2018-08-02T17:38:39Z","html_url":"https://github.com/eventespresso/event-espresso-core/pull/616#discussion_r207312890","pull_request_url":"https://api.github.com/repos/eventespresso/event-espresso-core/pulls/616","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/eventespresso/event-espresso-core/pulls/comments/207312890"},"html":{"href":"https://github.com/eventespresso/event-espresso-core/pull/616#discussion_r207312890"},"pull_request":{"href":"https://api.github.com/repos/eventespresso/event-espresso-core/pulls/616"}}},"pull_request":{"url":"https://api.github.com/repos/eventespresso/event-espresso-core/pulls/616","id":205748672,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NzQ4Njcy","html_url":"https://github.com/eventespresso/event-espresso-core/pull/616","diff_url":"https://github.com/eventespresso/event-espresso-core/pull/616.diff","patch_url":"https://github.com/eventespresso/event-espresso-core/pull/616.patch","issue_url":"https://api.github.com/repos/eventespresso/event-espresso-core/issues/616","number":616,"state":"open","locked":false,"title":"Sideload all language files (POT, PO and MO) rather than just the MO file","user":{"login":"Pebblo","id":4345417,"node_id":"MDQ6VXNlcjQzNDU0MTc=","avatar_url":"https://avatars0.githubusercontent.com/u/4345417?v=4","gravatar_id":"","url":"https://api.github.com/users/Pebblo","html_url":"https://github.com/Pebblo","followers_url":"https://api.github.com/users/Pebblo/followers","following_url":"https://api.github.com/users/Pebblo/following{/other_user}","gists_url":"https://api.github.com/users/Pebblo/gists{/gist_id}","starred_url":"https://api.github.com/users/Pebblo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pebblo/subscriptions","organizations_url":"https://api.github.com/users/Pebblo/orgs","repos_url":"https://api.github.com/users/Pebblo/repos","events_url":"https://api.github.com/users/Pebblo/events{/privacy}","received_events_url":"https://api.github.com/users/Pebblo/received_events","type":"User","site_admin":false},"body":"## Problem this Pull Request solves\r\nThis just makes it easier for translators, especially if using a tool such as [Loco Translate](https://wordpress.org/plugins/loco-translate/)\r\n\r\n## Why do you think these changes are needed in Event Espresso core instead of being put in an add-on?\r\nThe changes are to a function within core used to load language files, this wouldn't be any use in an add-on.\r\n\r\n## How has this been tested\r\nLoad the site using English US and look within event-espresso-core-reg/languages/\r\nYou should see at least event_espresso.pot\r\n\r\nLoad the site using any other language and you should see `event_espresso.pot`, `event_espresso-{locale}.po` and `event_espresso-{locale}.mo`\r\n\r\n## Checklist\r\n\r\n* [ ] I have added a changelog entry for this pull request\r\n* [x] I have read the documentation relating to systems affected by this pull request, see https://github.com/eventespresso/event-espresso-core/tree/master/docs\r\n* [x] User input is adequately validated and sanitized\r\n* [x] all publicly displayed strings are internationalized (usually using `esc_html__()`, see https://codex.wordpress.org/I18n_for_WordPress_Developers)\r\n* [x] My code is tested.\r\n* [x] My code follows the Event Espresso code style.\r\n* [x] My code has proper inline documentation.\r\n* [x] My code accounts for when the site is Maintenance Mode (MM2 especially disallows usage of models)\r\n","created_at":"2018-08-02T14:11:05Z","updated_at":"2018-08-02T17:38:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e824d151bf592c912d558e927f2175810e6fc795","assignee":{"login":"tn3rb","id":1751030,"node_id":"MDQ6VXNlcjE3NTEwMzA=","avatar_url":"https://avatars1.githubusercontent.com/u/1751030?v=4","gravatar_id":"","url":"https://api.github.com/users/tn3rb","html_url":"https://github.com/tn3rb","followers_url":"https://api.github.com/users/tn3rb/followers","following_url":"https://api.github.com/users/tn3rb/following{/other_user}","gists_url":"https://api.github.com/users/tn3rb/gists{/gist_id}","starred_url":"https://api.github.com/users/tn3rb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tn3rb/subscriptions","organizations_url":"https://api.github.com/users/tn3rb/orgs","repos_url":"https://api.github.com/users/tn3rb/repos","events_url":"https://api.github.com/users/tn3rb/events{/privacy}","received_events_url":"https://api.github.com/users/tn3rb/received_events","type":"User","site_admin":false},"assignees":[{"login":"tn3rb","id":1751030,"node_id":"MDQ6VXNlcjE3NTEwMzA=","avatar_url":"https://avatars1.githubusercontent.com/u/1751030?v=4","gravatar_id":"","url":"https://api.github.com/users/tn3rb","html_url":"https://github.com/tn3rb","followers_url":"https://api.github.com/users/tn3rb/followers","following_url":"https://api.github.com/users/tn3rb/following{/other_user}","gists_url":"https://api.github.com/users/tn3rb/gists{/gist_id}","starred_url":"https://api.github.com/users/tn3rb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tn3rb/subscriptions","organizations_url":"https://api.github.com/users/tn3rb/orgs","repos_url":"https://api.github.com/users/tn3rb/repos","events_url":"https://api.github.com/users/tn3rb/events{/privacy}","received_events_url":"https://api.github.com/users/tn3rb/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":906208204,"node_id":"MDU6TGFiZWw5MDYyMDgyMDQ=","url":"https://api.github.com/repos/eventespresso/event-espresso-core/labels/status:review","name":"status:review","color":"f7d500","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/eventespresso/event-espresso-core/pulls/616/commits","review_comments_url":"https://api.github.com/repos/eventespresso/event-espresso-core/pulls/616/comments","review_comment_url":"https://api.github.com/repos/eventespresso/event-espresso-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eventespresso/event-espresso-core/issues/616/comments","statuses_url":"https://api.github.com/repos/eventespresso/event-espresso-core/statuses/19fd02eeb4fa70f0693564992b979c85bade08b6","head":{"label":"eventespresso:sideload-all-language-files","ref":"sideload-all-language-files","sha":"19fd02eeb4fa70f0693564992b979c85bade08b6","user":{"login":"eventespresso","id":3077278,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNzcyNzg=","avatar_url":"https://avatars2.githubusercontent.com/u/3077278?v=4","gravatar_id":"","url":"https://api.github.com/users/eventespresso","html_url":"https://github.com/eventespresso","followers_url":"https://api.github.com/users/eventespresso/followers","following_url":"https://api.github.com/users/eventespresso/following{/other_user}","gists_url":"https://api.github.com/users/eventespresso/gists{/gist_id}","starred_url":"https://api.github.com/users/eventespresso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eventespresso/subscriptions","organizations_url":"https://api.github.com/users/eventespresso/orgs","repos_url":"https://api.github.com/users/eventespresso/repos","events_url":"https://api.github.com/users/eventespresso/events{/privacy}","received_events_url":"https://api.github.com/users/eventespresso/received_events","type":"Organization","site_admin":false},"repo":{"id":7252233,"node_id":"MDEwOlJlcG9zaXRvcnk3MjUyMjMz","name":"event-espresso-core","full_name":"eventespresso/event-espresso-core","owner":{"login":"eventespresso","id":3077278,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNzcyNzg=","avatar_url":"https://avatars2.githubusercontent.com/u/3077278?v=4","gravatar_id":"","url":"https://api.github.com/users/eventespresso","html_url":"https://github.com/eventespresso","followers_url":"https://api.github.com/users/eventespresso/followers","following_url":"https://api.github.com/users/eventespresso/following{/other_user}","gists_url":"https://api.github.com/users/eventespresso/gists{/gist_id}","starred_url":"https://api.github.com/users/eventespresso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eventespresso/subscriptions","organizations_url":"https://api.github.com/users/eventespresso/orgs","repos_url":"https://api.github.com/users/eventespresso/repos","events_url":"https://api.github.com/users/eventespresso/events{/privacy}","received_events_url":"https://api.github.com/users/eventespresso/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eventespresso/event-espresso-core","description":"Event Espresso 4 Core for WordPress: Build an Event Ticketing Website Today!","fork":false,"url":"https://api.github.com/repos/eventespresso/event-espresso-core","forks_url":"https://api.github.com/repos/eventespresso/event-espresso-core/forks","keys_url":"https://api.github.com/repos/eventespresso/event-espresso-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eventespresso/event-espresso-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eventespresso/event-espresso-core/teams","hooks_url":"https://api.github.com/repos/eventespresso/event-espresso-core/hooks","issue_events_url":"https://api.github.com/repos/eventespresso/event-espresso-core/issues/events{/number}","events_url":"https://api.github.com/repos/eventespresso/event-espresso-core/events","assignees_url":"https://api.github.com/repos/eventespresso/event-espresso-core/assignees{/user}","branches_url":"https://api.github.com/repos/eventespresso/event-espresso-core/branches{/branch}","tags_url":"https://api.github.com/repos/eventespresso/event-espresso-core/tags","blobs_url":"https://api.github.com/repos/eventespresso/event-espresso-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eventespresso/event-espresso-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eventespresso/event-espresso-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/eventespresso/event-espresso-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eventespresso/event-espresso-core/statuses/{sha}","languages_url":"https://api.github.com/repos/eventespresso/event-espresso-core/languages","stargazers_url":"https://api.github.com/repos/eventespresso/event-espresso-core/stargazers","contributors_url":"https://api.github.com/repos/eventespresso/event-espresso-core/contributors","subscribers_url":"https://api.github.com/repos/eventespresso/event-espresso-core/subscribers","subscription_url":"https://api.github.com/repos/eventespresso/event-espresso-core/subscription","commits_url":"https://api.github.com/repos/eventespresso/event-espresso-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/eventespresso/event-espresso-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/eventespresso/event-espresso-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/eventespresso/event-espresso-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/eventespresso/event-espresso-core/contents/{+path}","compare_url":"https://api.github.com/repos/eventespresso/event-espresso-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eventespresso/event-espresso-core/merges","archive_url":"https://api.github.com/repos/eventespresso/event-espresso-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eventespresso/event-espresso-core/downloads","issues_url":"https://api.github.com/repos/eventespresso/event-espresso-core/issues{/number}","pulls_url":"https://api.github.com/repos/eventespresso/event-espresso-core/pulls{/number}","milestones_url":"https://api.github.com/repos/eventespresso/event-espresso-core/milestones{/number}","notifications_url":"https://api.github.com/repos/eventespresso/event-espresso-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eventespresso/event-espresso-core/labels{/name}","releases_url":"https://api.github.com/repos/eventespresso/event-espresso-core/releases{/id}","deployments_url":"https://api.github.com/repos/eventespresso/event-espresso-core/deployments","created_at":"2012-12-20T04:38:57Z","updated_at":"2018-08-01T20:08:52Z","pushed_at":"2018-08-02T16:57:44Z","git_url":"git://github.com/eventespresso/event-espresso-core.git","ssh_url":"git@github.com:eventespresso/event-espresso-core.git","clone_url":"https://github.com/eventespresso/event-espresso-core.git","svn_url":"https://github.com/eventespresso/event-espresso-core","homepage":"https://eventespresso.com","size":107757,"stargazers_count":85,"watchers_count":85,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"archived":false,"open_issues_count":94,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":55,"open_issues":94,"watchers":85,"default_branch":"master"}},"base":{"label":"eventespresso:master","ref":"master","sha":"d2932eeae0ff646406d3f0a243181960527a9de4","user":{"login":"eventespresso","id":3077278,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNzcyNzg=","avatar_url":"https://avatars2.githubusercontent.com/u/3077278?v=4","gravatar_id":"","url":"https://api.github.com/users/eventespresso","html_url":"https://github.com/eventespresso","followers_url":"https://api.github.com/users/eventespresso/followers","following_url":"https://api.github.com/users/eventespresso/following{/other_user}","gists_url":"https://api.github.com/users/eventespresso/gists{/gist_id}","starred_url":"https://api.github.com/users/eventespresso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eventespresso/subscriptions","organizations_url":"https://api.github.com/users/eventespresso/orgs","repos_url":"https://api.github.com/users/eventespresso/repos","events_url":"https://api.github.com/users/eventespresso/events{/privacy}","received_events_url":"https://api.github.com/users/eventespresso/received_events","type":"Organization","site_admin":false},"repo":{"id":7252233,"node_id":"MDEwOlJlcG9zaXRvcnk3MjUyMjMz","name":"event-espresso-core","full_name":"eventespresso/event-espresso-core","owner":{"login":"eventespresso","id":3077278,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNzcyNzg=","avatar_url":"https://avatars2.githubusercontent.com/u/3077278?v=4","gravatar_id":"","url":"https://api.github.com/users/eventespresso","html_url":"https://github.com/eventespresso","followers_url":"https://api.github.com/users/eventespresso/followers","following_url":"https://api.github.com/users/eventespresso/following{/other_user}","gists_url":"https://api.github.com/users/eventespresso/gists{/gist_id}","starred_url":"https://api.github.com/users/eventespresso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eventespresso/subscriptions","organizations_url":"https://api.github.com/users/eventespresso/orgs","repos_url":"https://api.github.com/users/eventespresso/repos","events_url":"https://api.github.com/users/eventespresso/events{/privacy}","received_events_url":"https://api.github.com/users/eventespresso/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eventespresso/event-espresso-core","description":"Event Espresso 4 Core for WordPress: Build an Event Ticketing Website Today!","fork":false,"url":"https://api.github.com/repos/eventespresso/event-espresso-core","forks_url":"https://api.github.com/repos/eventespresso/event-espresso-core/forks","keys_url":"https://api.github.com/repos/eventespresso/event-espresso-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eventespresso/event-espresso-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eventespresso/event-espresso-core/teams","hooks_url":"https://api.github.com/repos/eventespresso/event-espresso-core/hooks","issue_events_url":"https://api.github.com/repos/eventespresso/event-espresso-core/issues/events{/number}","events_url":"https://api.github.com/repos/eventespresso/event-espresso-core/events","assignees_url":"https://api.github.com/repos/eventespresso/event-espresso-core/assignees{/user}","branches_url":"https://api.github.com/repos/eventespresso/event-espresso-core/branches{/branch}","tags_url":"https://api.github.com/repos/eventespresso/event-espresso-core/tags","blobs_url":"https://api.github.com/repos/eventespresso/event-espresso-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eventespresso/event-espresso-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eventespresso/event-espresso-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/eventespresso/event-espresso-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eventespresso/event-espresso-core/statuses/{sha}","languages_url":"https://api.github.com/repos/eventespresso/event-espresso-core/languages","stargazers_url":"https://api.github.com/repos/eventespresso/event-espresso-core/stargazers","contributors_url":"https://api.github.com/repos/eventespresso/event-espresso-core/contributors","subscribers_url":"https://api.github.com/repos/eventespresso/event-espresso-core/subscribers","subscription_url":"https://api.github.com/repos/eventespresso/event-espresso-core/subscription","commits_url":"https://api.github.com/repos/eventespresso/event-espresso-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/eventespresso/event-espresso-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/eventespresso/event-espresso-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/eventespresso/event-espresso-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/eventespresso/event-espresso-core/contents/{+path}","compare_url":"https://api.github.com/repos/eventespresso/event-espresso-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eventespresso/event-espresso-core/merges","archive_url":"https://api.github.com/repos/eventespresso/event-espresso-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eventespresso/event-espresso-core/downloads","issues_url":"https://api.github.com/repos/eventespresso/event-espresso-core/issues{/number}","pulls_url":"https://api.github.com/repos/eventespresso/event-espresso-core/pulls{/number}","milestones_url":"https://api.github.com/repos/eventespresso/event-espresso-core/milestones{/number}","notifications_url":"https://api.github.com/repos/eventespresso/event-espresso-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eventespresso/event-espresso-core/labels{/name}","releases_url":"https://api.github.com/repos/eventespresso/event-espresso-core/releases{/id}","deployments_url":"https://api.github.com/repos/eventespresso/event-espresso-core/deployments","created_at":"2012-12-20T04:38:57Z","updated_at":"2018-08-01T20:08:52Z","pushed_at":"2018-08-02T16:57:44Z","git_url":"git://github.com/eventespresso/event-espresso-core.git","ssh_url":"git@github.com:eventespresso/event-espresso-core.git","clone_url":"https://github.com/eventespresso/event-espresso-core.git","svn_url":"https://github.com/eventespresso/event-espresso-core","homepage":"https://eventespresso.com","size":107757,"stargazers_count":85,"watchers_count":85,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"archived":false,"open_issues_count":94,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":55,"open_issues":94,"watchers":85,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eventespresso/event-espresso-core/pulls/616"},"html":{"href":"https://github.com/eventespresso/event-espresso-core/pull/616"},"issue":{"href":"https://api.github.com/repos/eventespresso/event-espresso-core/issues/616"},"comments":{"href":"https://api.github.com/repos/eventespresso/event-espresso-core/issues/616/comments"},"review_comments":{"href":"https://api.github.com/repos/eventespresso/event-espresso-core/pulls/616/comments"},"review_comment":{"href":"https://api.github.com/repos/eventespresso/event-espresso-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eventespresso/event-espresso-core/pulls/616/commits"},"statuses":{"href":"https://api.github.com/repos/eventespresso/event-espresso-core/statuses/19fd02eeb4fa70f0693564992b979c85bade08b6"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"tn3rb"}}