{"action":"closed","number":2046,"pull_request":{"url":"https://api.github.com/repos/dmlc/tvm/pulls/2046","id":227473980,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NDczOTgw","html_url":"https://github.com/dmlc/tvm/pull/2046","diff_url":"https://github.com/dmlc/tvm/pull/2046.diff","patch_url":"https://github.com/dmlc/tvm/pull/2046.patch","issue_url":"https://api.github.com/repos/dmlc/tvm/issues/2046","number":2046,"state":"closed","locked":false,"title":"[Cleanliness] [Easy] Make TVM leak-sanitizer and Wnon-virtual-dtor clean.","user":{"login":"ajtulloch","id":1121581,"node_id":"MDQ6VXNlcjExMjE1ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/1121581?v=4","gravatar_id":"","url":"https://api.github.com/users/ajtulloch","html_url":"https://github.com/ajtulloch","followers_url":"https://api.github.com/users/ajtulloch/followers","following_url":"https://api.github.com/users/ajtulloch/following{/other_user}","gists_url":"https://api.github.com/users/ajtulloch/gists{/gist_id}","starred_url":"https://api.github.com/users/ajtulloch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajtulloch/subscriptions","organizations_url":"https://api.github.com/users/ajtulloch/orgs","repos_url":"https://api.github.com/users/ajtulloch/repos","events_url":"https://api.github.com/users/ajtulloch/events{/privacy}","received_events_url":"https://api.github.com/users/ajtulloch/received_events","type":"User","site_admin":false},"body":"This is a minor set of commits to make TVM leak-sanitizer and Wnon-virtual-dtor clean. These are:\r\n\r\n- Stop leaking the `llvm::TargetMachine` instance (`Target::createTargetMachine` returns a raw pointer with owning semantics, so the caller is responsible for free'ing it). Instead, it is now owned by the `LLVMModule` instance.\r\n- Leak the `Manager::Global` singleton, instead of deleting it at program exit. This stops LSAN complaining about the leaked Registry* instances in `Manager::fmap`.\r\n- Add virtual destructors to `runtime::DSLAPI` and `codegen::CodeGenSourceBase`, to avoid LLVM complaining when `-Wnon-virtual-dtor` is passed (I think this is a useful flag to enable in CI as well).\r\n\r\nAfter these commits, TVM built with e.g. `-fsanitize=leak` raises no errors on `./tests/scripts/task_cpp_unittest.sh`.","created_at":"2018-10-31T23:41:42Z","updated_at":"2018-11-01T02:34:00Z","closed_at":"2018-11-01T02:34:00Z","merged_at":"2018-11-01T02:34:00Z","merge_commit_sha":"0319f99d248e39521abd304690dcbc8d26d075c0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dmlc/tvm/pulls/2046/commits","review_comments_url":"https://api.github.com/repos/dmlc/tvm/pulls/2046/comments","review_comment_url":"https://api.github.com/repos/dmlc/tvm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dmlc/tvm/issues/2046/comments","statuses_url":"https://api.github.com/repos/dmlc/tvm/statuses/4e02bf06d67c68d45a6d5fa13291e952a064e275","head":{"label":"ajtulloch:tvm-memory-leaks","ref":"tvm-memory-leaks","sha":"4e02bf06d67c68d45a6d5fa13291e952a064e275","user":{"login":"ajtulloch","id":1121581,"node_id":"MDQ6VXNlcjExMjE1ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/1121581?v=4","gravatar_id":"","url":"https://api.github.com/users/ajtulloch","html_url":"https://github.com/ajtulloch","followers_url":"https://api.github.com/users/ajtulloch/followers","following_url":"https://api.github.com/users/ajtulloch/following{/other_user}","gists_url":"https://api.github.com/users/ajtulloch/gists{/gist_id}","starred_url":"https://api.github.com/users/ajtulloch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajtulloch/subscriptions","organizations_url":"https://api.github.com/users/ajtulloch/orgs","repos_url":"https://api.github.com/users/ajtulloch/repos","events_url":"https://api.github.com/users/ajtulloch/events{/privacy}","received_events_url":"https://api.github.com/users/ajtulloch/received_events","type":"User","site_admin":false},"repo":{"id":137101191,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcxMDExOTE=","name":"tvm","full_name":"ajtulloch/tvm","private":false,"owner":{"login":"ajtulloch","id":1121581,"node_id":"MDQ6VXNlcjExMjE1ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/1121581?v=4","gravatar_id":"","url":"https://api.github.com/users/ajtulloch","html_url":"https://github.com/ajtulloch","followers_url":"https://api.github.com/users/ajtulloch/followers","following_url":"https://api.github.com/users/ajtulloch/following{/other_user}","gists_url":"https://api.github.com/users/ajtulloch/gists{/gist_id}","starred_url":"https://api.github.com/users/ajtulloch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajtulloch/subscriptions","organizations_url":"https://api.github.com/users/ajtulloch/orgs","repos_url":"https://api.github.com/users/ajtulloch/repos","events_url":"https://api.github.com/users/ajtulloch/events{/privacy}","received_events_url":"https://api.github.com/users/ajtulloch/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ajtulloch/tvm","description":"Open deep learning compiler stack for cpu, gpu and specialized accelerators","fork":true,"url":"https://api.github.com/repos/ajtulloch/tvm","forks_url":"https://api.github.com/repos/ajtulloch/tvm/forks","keys_url":"https://api.github.com/repos/ajtulloch/tvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ajtulloch/tvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ajtulloch/tvm/teams","hooks_url":"https://api.github.com/repos/ajtulloch/tvm/hooks","issue_events_url":"https://api.github.com/repos/ajtulloch/tvm/issues/events{/number}","events_url":"https://api.github.com/repos/ajtulloch/tvm/events","assignees_url":"https://api.github.com/repos/ajtulloch/tvm/assignees{/user}","branches_url":"https://api.github.com/repos/ajtulloch/tvm/branches{/branch}","tags_url":"https://api.github.com/repos/ajtulloch/tvm/tags","blobs_url":"https://api.github.com/repos/ajtulloch/tvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ajtulloch/tvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ajtulloch/tvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/ajtulloch/tvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ajtulloch/tvm/statuses/{sha}","languages_url":"https://api.github.com/repos/ajtulloch/tvm/languages","stargazers_url":"https://api.github.com/repos/ajtulloch/tvm/stargazers","contributors_url":"https://api.github.com/repos/ajtulloch/tvm/contributors","subscribers_url":"https://api.github.com/repos/ajtulloch/tvm/subscribers","subscription_url":"https://api.github.com/repos/ajtulloch/tvm/subscription","commits_url":"https://api.github.com/repos/ajtulloch/tvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/ajtulloch/tvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/ajtulloch/tvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/ajtulloch/tvm/issues/comments{/number}","contents_url":"https://api.github.com/repos/ajtulloch/tvm/contents/{+path}","compare_url":"https://api.github.com/repos/ajtulloch/tvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ajtulloch/tvm/merges","archive_url":"https://api.github.com/repos/ajtulloch/tvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ajtulloch/tvm/downloads","issues_url":"https://api.github.com/repos/ajtulloch/tvm/issues{/number}","pulls_url":"https://api.github.com/repos/ajtulloch/tvm/pulls{/number}","milestones_url":"https://api.github.com/repos/ajtulloch/tvm/milestones{/number}","notifications_url":"https://api.github.com/repos/ajtulloch/tvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ajtulloch/tvm/labels{/name}","releases_url":"https://api.github.com/repos/ajtulloch/tvm/releases{/id}","deployments_url":"https://api.github.com/repos/ajtulloch/tvm/deployments","created_at":"2018-06-12T16:43:45Z","updated_at":"2018-06-12T16:43:49Z","pushed_at":"2018-10-31T23:33:59Z","git_url":"git://github.com/ajtulloch/tvm.git","ssh_url":"git@github.com:ajtulloch/tvm.git","clone_url":"https://github.com/ajtulloch/tvm.git","svn_url":"https://github.com/ajtulloch/tvm","homepage":"https://tvm.ai","size":14065,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dmlc:master","ref":"master","sha":"add1f90e4c5c4701c3a55f26b7c5b4ac85283ff6","user":{"login":"dmlc","id":11508361,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTA4MzYx","avatar_url":"https://avatars2.githubusercontent.com/u/11508361?v=4","gravatar_id":"","url":"https://api.github.com/users/dmlc","html_url":"https://github.com/dmlc","followers_url":"https://api.github.com/users/dmlc/followers","following_url":"https://api.github.com/users/dmlc/following{/other_user}","gists_url":"https://api.github.com/users/dmlc/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlc/subscriptions","organizations_url":"https://api.github.com/users/dmlc/orgs","repos_url":"https://api.github.com/users/dmlc/repos","events_url":"https://api.github.com/users/dmlc/events{/privacy}","received_events_url":"https://api.github.com/users/dmlc/received_events","type":"Organization","site_admin":false},"repo":{"id":70746484,"node_id":"MDEwOlJlcG9zaXRvcnk3MDc0NjQ4NA==","name":"tvm","full_name":"dmlc/tvm","private":false,"owner":{"login":"dmlc","id":11508361,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTA4MzYx","avatar_url":"https://avatars2.githubusercontent.com/u/11508361?v=4","gravatar_id":"","url":"https://api.github.com/users/dmlc","html_url":"https://github.com/dmlc","followers_url":"https://api.github.com/users/dmlc/followers","following_url":"https://api.github.com/users/dmlc/following{/other_user}","gists_url":"https://api.github.com/users/dmlc/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlc/subscriptions","organizations_url":"https://api.github.com/users/dmlc/orgs","repos_url":"https://api.github.com/users/dmlc/repos","events_url":"https://api.github.com/users/dmlc/events{/privacy}","received_events_url":"https://api.github.com/users/dmlc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dmlc/tvm","description":"Open deep learning compiler stack for cpu, gpu and specialized accelerators","fork":false,"url":"https://api.github.com/repos/dmlc/tvm","forks_url":"https://api.github.com/repos/dmlc/tvm/forks","keys_url":"https://api.github.com/repos/dmlc/tvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmlc/tvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmlc/tvm/teams","hooks_url":"https://api.github.com/repos/dmlc/tvm/hooks","issue_events_url":"https://api.github.com/repos/dmlc/tvm/issues/events{/number}","events_url":"https://api.github.com/repos/dmlc/tvm/events","assignees_url":"https://api.github.com/repos/dmlc/tvm/assignees{/user}","branches_url":"https://api.github.com/repos/dmlc/tvm/branches{/branch}","tags_url":"https://api.github.com/repos/dmlc/tvm/tags","blobs_url":"https://api.github.com/repos/dmlc/tvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmlc/tvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmlc/tvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmlc/tvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmlc/tvm/statuses/{sha}","languages_url":"https://api.github.com/repos/dmlc/tvm/languages","stargazers_url":"https://api.github.com/repos/dmlc/tvm/stargazers","contributors_url":"https://api.github.com/repos/dmlc/tvm/contributors","subscribers_url":"https://api.github.com/repos/dmlc/tvm/subscribers","subscription_url":"https://api.github.com/repos/dmlc/tvm/subscription","commits_url":"https://api.github.com/repos/dmlc/tvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmlc/tvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmlc/tvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmlc/tvm/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmlc/tvm/contents/{+path}","compare_url":"https://api.github.com/repos/dmlc/tvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmlc/tvm/merges","archive_url":"https://api.github.com/repos/dmlc/tvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmlc/tvm/downloads","issues_url":"https://api.github.com/repos/dmlc/tvm/issues{/number}","pulls_url":"https://api.github.com/repos/dmlc/tvm/pulls{/number}","milestones_url":"https://api.github.com/repos/dmlc/tvm/milestones{/number}","notifications_url":"https://api.github.com/repos/dmlc/tvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmlc/tvm/labels{/name}","releases_url":"https://api.github.com/repos/dmlc/tvm/releases{/id}","deployments_url":"https://api.github.com/repos/dmlc/tvm/deployments","created_at":"2016-10-12T22:20:28Z","updated_at":"2018-11-01T01:54:06Z","pushed_at":"2018-11-01T02:34:00Z","git_url":"git://github.com/dmlc/tvm.git","ssh_url":"git@github.com:dmlc/tvm.git","clone_url":"https://github.com/dmlc/tvm.git","svn_url":"https://github.com/dmlc/tvm","homepage":"https://tvm.ai","size":8433,"stargazers_count":2255,"watchers_count":2255,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":529,"mirror_url":null,"archived":false,"open_issues_count":61,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":529,"open_issues":61,"watchers":2255,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dmlc/tvm/pulls/2046"},"html":{"href":"https://github.com/dmlc/tvm/pull/2046"},"issue":{"href":"https://api.github.com/repos/dmlc/tvm/issues/2046"},"comments":{"href":"https://api.github.com/repos/dmlc/tvm/issues/2046/comments"},"review_comments":{"href":"https://api.github.com/repos/dmlc/tvm/pulls/2046/comments"},"review_comment":{"href":"https://api.github.com/repos/dmlc/tvm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dmlc/tvm/pulls/2046/commits"},"statuses":{"href":"https://api.github.com/repos/dmlc/tvm/statuses/4e02bf06d67c68d45a6d5fa13291e952a064e275"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"tqchen","id":2577440,"node_id":"MDQ6VXNlcjI1Nzc0NDA=","avatar_url":"https://avatars3.githubusercontent.com/u/2577440?v=4","gravatar_id":"","url":"https://api.github.com/users/tqchen","html_url":"https://github.com/tqchen","followers_url":"https://api.github.com/users/tqchen/followers","following_url":"https://api.github.com/users/tqchen/following{/other_user}","gists_url":"https://api.github.com/users/tqchen/gists{/gist_id}","starred_url":"https://api.github.com/users/tqchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tqchen/subscriptions","organizations_url":"https://api.github.com/users/tqchen/orgs","repos_url":"https://api.github.com/users/tqchen/repos","events_url":"https://api.github.com/users/tqchen/events{/privacy}","received_events_url":"https://api.github.com/users/tqchen/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":20,"deletions":15,"changed_files":8}}
{"actor":{"display_login":"tqchen"}}