{"action":"created","issue":{"url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/11398","repository_url":"https://api.github.com/repos/Yoast/wordpress-seo","labels_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/11398/labels{/name}","comments_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/11398/comments","events_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/11398/events","html_url":"https://github.com/Yoast/wordpress-seo/pull/11398","id":373427101,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MzU5MDQ5","number":11398,"title":"(new) Improve the upsell button caret icon position in RTL languages","user":{"login":"afercia","id":1682452,"node_id":"MDQ6VXNlcjE2ODI0NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1682452?v=4","gravatar_id":"","url":"https://api.github.com/users/afercia","html_url":"https://github.com/afercia","followers_url":"https://api.github.com/users/afercia/followers","following_url":"https://api.github.com/users/afercia/following{/other_user}","gists_url":"https://api.github.com/users/afercia/gists{/gist_id}","starred_url":"https://api.github.com/users/afercia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afercia/subscriptions","organizations_url":"https://api.github.com/users/afercia/orgs","repos_url":"https://api.github.com/users/afercia/repos","events_url":"https://api.github.com/users/afercia/events{/privacy}","received_events_url":"https://api.github.com/users/afercia/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-10-24T11:05:44Z","updated_at":"2018-10-29T12:47:51Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/11398","html_url":"https://github.com/Yoast/wordpress-seo/pull/11398","diff_url":"https://github.com/Yoast/wordpress-seo/pull/11398.diff","patch_url":"https://github.com/Yoast/wordpress-seo/pull/11398.patch"},"body":"## Summary\r\n\r\nThis PR can be summarized in the following changelog entry:\r\n\r\n* N/A\r\n\r\n## Relevant technical choices:\r\n\r\n- introduces a new (left) caret icon \r\n- instead of using background images directly on the button, use the image as background of an inline `<span>` element so it behaves like inline content\r\n- refactors the CSS to use `inline-flex` so the text and the icon are better aligned vertically\r\n- the upsell button can now be used also without an icon (if necessary) so it's better reusable\r\n- reuses the `yoast-button-upsell` also in the Extensions page\r\n- adds the \"new tab message\" to all links that open in a new tab in the extensions page\r\n- incorporates the line-height fix from #11334 \r\n\r\n## Test instructions\r\nThe upsell button needs to be checked everywhere it appears, and also in the responsive view. As far as I know, it is used:\r\n- in the notice when trashing a published post\r\n- in the Help Center > Get support\r\n- in the sidebar in the admin pages\r\n- at the bottom of the admin pages: the upsell block\r\n- in the extensions page (SEO > Premium) also known as \"licenses\" page `wp-admin/admin.php?page=wpseo_licenses`\r\n- Additional keywords upsell modal\r\n- Additional keywords upsell section\r\n- Synonyms upsell modal\r\n\r\nAll these places need to be tested in LTR and RTL.\r\n\r\nExample screenshot:\r\n\r\n<img width=\"508\" alt=\"screen shot 2018-10-18 at 15 51 44\" src=\"https://user-images.githubusercontent.com/1682452/47159298-d5273a00-d2ed-11e8-912a-2849cc6b004f.png\">\r\n\r\nFixes #11174\r\n"},"comment":{"url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/comments/433897064","html_url":"https://github.com/Yoast/wordpress-seo/pull/11398#issuecomment-433897064","issue_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/11398","id":433897064,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzg5NzA2NA==","user":{"login":"afercia","id":1682452,"node_id":"MDQ6VXNlcjE2ODI0NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1682452?v=4","gravatar_id":"","url":"https://api.github.com/users/afercia","html_url":"https://github.com/afercia","followers_url":"https://api.github.com/users/afercia/followers","following_url":"https://api.github.com/users/afercia/following{/other_user}","gists_url":"https://api.github.com/users/afercia/gists{/gist_id}","starred_url":"https://api.github.com/users/afercia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afercia/subscriptions","organizations_url":"https://api.github.com/users/afercia/orgs","repos_url":"https://api.github.com/users/afercia/repos","events_url":"https://api.github.com/users/afercia/events{/privacy}","received_events_url":"https://api.github.com/users/afercia/received_events","type":"User","site_admin":false},"created_at":"2018-10-29T12:47:51Z","updated_at":"2018-10-29T12:47:51Z","author_association":"COLLABORATOR","body":"I've committed a temporary fix to not use \"Open Sans\" on the Upsell button. We should consider to remove any non-default-system-font, will create a new issue."}}
{"actor":{"display_login":"afercia"}}