{"action":"created","issue":{"url":"https://api.github.com/repos/magento/magento2/issues/14468","repository_url":"https://api.github.com/repos/magento/magento2","labels_url":"https://api.github.com/repos/magento/magento2/issues/14468/labels{/name}","comments_url":"https://api.github.com/repos/magento/magento2/issues/14468/comments","events_url":"https://api.github.com/repos/magento/magento2/issues/14468/events","html_url":"https://github.com/magento/magento2/pull/14468","id":310074236,"number":14468,"title":"Try to fix calculation #10790","user":{"login":"ilnytskyi","id":3192770,"avatar_url":"https://avatars0.githubusercontent.com/u/3192770?v=4","gravatar_id":"","url":"https://api.github.com/users/ilnytskyi","html_url":"https://github.com/ilnytskyi","followers_url":"https://api.github.com/users/ilnytskyi/followers","following_url":"https://api.github.com/users/ilnytskyi/following{/other_user}","gists_url":"https://api.github.com/users/ilnytskyi/gists{/gist_id}","starred_url":"https://api.github.com/users/ilnytskyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilnytskyi/subscriptions","organizations_url":"https://api.github.com/users/ilnytskyi/orgs","repos_url":"https://api.github.com/users/ilnytskyi/repos","events_url":"https://api.github.com/users/ilnytskyi/events{/privacy}","received_events_url":"https://api.github.com/users/ilnytskyi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-30T14:04:22Z","updated_at":"2018-03-30T14:04:25Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/14468","html_url":"https://github.com/magento/magento2/pull/14468","diff_url":"https://github.com/magento/magento2/pull/14468.diff","patch_url":"https://github.com/magento/magento2/pull/14468.patch"},"body":"Removed rounding of $priceInclTax\r\n\r\n### Description\r\nRemoved rounding for $priceInclTax in app/code/Magento/Tax/Model/Calculation/AbstractAggregateCalculator.php:151 to have correct price and row_total value to apply a discount correctly.\r\nI suppose rounding is applied later.\r\n\r\n### Fixed Issues (if relevant)\r\n\r\n1. magento/magento2#10790 Tax rate + 100% discount results in negative grand total\r\n\r\n### Manual testing scenarios\r\n1. Create product A with price = 2 762,71\r\n2. Create product B with price = 2 542,37\r\n3. Setup tax rule 18%\r\n4. Create coupon code that adds 100% discount.\r\n5. Add both products to the cart with qty = 2\r\n6. Apply coupon code\r\n7. Total Order should be 0\r\n\r\n### Contribution checklist\r\n - [ ] Pull request has a meaningful description of its purpose\r\n - [ ] All commits are accompanied by meaningful commit messages\r\n - [ ] All new or changed code is covered with unit/integration tests (if applicable)\r\n - [ ] All automated tests passed successfully (all builds on Travis CI are green)\r\n"},"comment":{"url":"https://api.github.com/repos/magento/magento2/issues/comments/377531084","html_url":"https://github.com/magento/magento2/pull/14468#issuecomment-377531084","issue_url":"https://api.github.com/repos/magento/magento2/issues/14468","id":377531084,"user":{"login":"magento-cicd2","id":14279950,"avatar_url":"https://avatars2.githubusercontent.com/u/14279950?v=4","gravatar_id":"","url":"https://api.github.com/users/magento-cicd2","html_url":"https://github.com/magento-cicd2","followers_url":"https://api.github.com/users/magento-cicd2/followers","following_url":"https://api.github.com/users/magento-cicd2/following{/other_user}","gists_url":"https://api.github.com/users/magento-cicd2/gists{/gist_id}","starred_url":"https://api.github.com/users/magento-cicd2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento-cicd2/subscriptions","organizations_url":"https://api.github.com/users/magento-cicd2/orgs","repos_url":"https://api.github.com/users/magento-cicd2/repos","events_url":"https://api.github.com/users/magento-cicd2/events{/privacy}","received_events_url":"https://api.github.com/users/magento-cicd2/received_events","type":"User","site_admin":false},"created_at":"2018-03-30T14:04:25Z","updated_at":"2018-03-30T14:04:25Z","author_association":"CONTRIBUTOR","body":"[![CLA assistant check](https://cla.dev.magento.com/pull/badge/not_signed)](https://cla.dev.magento.com/magento/magento2?pullRequest=14468) <br/>Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our [Contributor License Agreement](https://cla.dev.magento.com/magento/magento2?pullRequest=14468) before we can accept your contribution.<br/>"}}
{"actor":{"display_login":"magento-cicd2"}}