{"action":"created","comment":{"url":"https://api.github.com/repos/transloadit/uppy/pulls/comments/226066980","pull_request_review_id":165800926,"id":226066980,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjA2Njk4MA==","diff_hunk":"@@ -65,7 +65,9 @@ module.exports = class Transloadit extends Plugin {\n     this._onRestored = this._onRestored.bind(this)\n     this._getPersistentData = this._getPersistentData.bind(this)\n \n-    if (this.opts.params) {\n+    if (this.opts.params ||\n+        // No params _and_ no custom getAssemblyOptions is an early error.\n+        this.opts.getAssemblyOptions === defaultOptions.getAssemblyOptions) {\n       AssemblyOptions.validateParams(this.opts.params)","path":"packages/@uppy/transloadit/src/index.js","position":8,"original_position":8,"commit_id":"b18743836d46208795f0ab685dd971d4ed162b0a","original_commit_id":"b18743836d46208795f0ab685dd971d4ed162b0a","user":{"login":"arturi","id":1199054,"node_id":"MDQ6VXNlcjExOTkwNTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1199054?v=4","gravatar_id":"","url":"https://api.github.com/users/arturi","html_url":"https://github.com/arturi","followers_url":"https://api.github.com/users/arturi/followers","following_url":"https://api.github.com/users/arturi/following{/other_user}","gists_url":"https://api.github.com/users/arturi/gists{/gist_id}","starred_url":"https://api.github.com/users/arturi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arturi/subscriptions","organizations_url":"https://api.github.com/users/arturi/orgs","repos_url":"https://api.github.com/users/arturi/repos","events_url":"https://api.github.com/users/arturi/events{/privacy}","received_events_url":"https://api.github.com/users/arturi/received_events","type":"User","site_admin":false},"body":"Ok, I think I get it now :) thanks for the explanation! 👍","created_at":"2018-10-17T19:34:58Z","updated_at":"2018-10-17T19:34:58Z","html_url":"https://github.com/transloadit/uppy/pull/1103#discussion_r226066980","pull_request_url":"https://api.github.com/repos/transloadit/uppy/pulls/1103","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/transloadit/uppy/pulls/comments/226066980"},"html":{"href":"https://github.com/transloadit/uppy/pull/1103#discussion_r226066980"},"pull_request":{"href":"https://api.github.com/repos/transloadit/uppy/pulls/1103"}},"in_reply_to_id":226063509},"pull_request":{"url":"https://api.github.com/repos/transloadit/uppy/pulls/1103","id":222842971,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyODQyOTcx","html_url":"https://github.com/transloadit/uppy/pull/1103","diff_url":"https://github.com/transloadit/uppy/pull/1103.diff","patch_url":"https://github.com/transloadit/uppy/pull/1103.patch","issue_url":"https://api.github.com/repos/transloadit/uppy/issues/1103","number":1103,"state":"open","locked":false,"title":"transloadit: Error tweaks","user":{"login":"goto-bus-stop","id":1006268,"node_id":"MDQ6VXNlcjEwMDYyNjg=","avatar_url":"https://avatars1.githubusercontent.com/u/1006268?v=4","gravatar_id":"","url":"https://api.github.com/users/goto-bus-stop","html_url":"https://github.com/goto-bus-stop","followers_url":"https://api.github.com/users/goto-bus-stop/followers","following_url":"https://api.github.com/users/goto-bus-stop/following{/other_user}","gists_url":"https://api.github.com/users/goto-bus-stop/gists{/gist_id}","starred_url":"https://api.github.com/users/goto-bus-stop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goto-bus-stop/subscriptions","organizations_url":"https://api.github.com/users/goto-bus-stop/orgs","repos_url":"https://api.github.com/users/goto-bus-stop/repos","events_url":"https://api.github.com/users/goto-bus-stop/events{/privacy}","received_events_url":"https://api.github.com/users/goto-bus-stop/received_events","type":"User","site_admin":false},"body":"- Update API key URL in the `auth.key` error message. The old URL still worked but not having to redirect is nice\r\n- Error early if neither `params` nor `getAssemblyOptions` are given.","created_at":"2018-10-15T09:44:29Z","updated_at":"2018-10-17T19:34:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c858091fd26af527ba0a3a91fc4dddf2470941a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/transloadit/uppy/pulls/1103/commits","review_comments_url":"https://api.github.com/repos/transloadit/uppy/pulls/1103/comments","review_comment_url":"https://api.github.com/repos/transloadit/uppy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/transloadit/uppy/issues/1103/comments","statuses_url":"https://api.github.com/repos/transloadit/uppy/statuses/b18743836d46208795f0ab685dd971d4ed162b0a","head":{"label":"transloadit:chore/tl-tweaks","ref":"chore/tl-tweaks","sha":"b18743836d46208795f0ab685dd971d4ed162b0a","user":{"login":"transloadit","id":125754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTc1NA==","avatar_url":"https://avatars2.githubusercontent.com/u/125754?v=4","gravatar_id":"","url":"https://api.github.com/users/transloadit","html_url":"https://github.com/transloadit","followers_url":"https://api.github.com/users/transloadit/followers","following_url":"https://api.github.com/users/transloadit/following{/other_user}","gists_url":"https://api.github.com/users/transloadit/gists{/gist_id}","starred_url":"https://api.github.com/users/transloadit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transloadit/subscriptions","organizations_url":"https://api.github.com/users/transloadit/orgs","repos_url":"https://api.github.com/users/transloadit/repos","events_url":"https://api.github.com/users/transloadit/events{/privacy}","received_events_url":"https://api.github.com/users/transloadit/received_events","type":"Organization","site_admin":false},"repo":{"id":46273445,"node_id":"MDEwOlJlcG9zaXRvcnk0NjI3MzQ0NQ==","name":"uppy","full_name":"transloadit/uppy","private":false,"owner":{"login":"transloadit","id":125754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTc1NA==","avatar_url":"https://avatars2.githubusercontent.com/u/125754?v=4","gravatar_id":"","url":"https://api.github.com/users/transloadit","html_url":"https://github.com/transloadit","followers_url":"https://api.github.com/users/transloadit/followers","following_url":"https://api.github.com/users/transloadit/following{/other_user}","gists_url":"https://api.github.com/users/transloadit/gists{/gist_id}","starred_url":"https://api.github.com/users/transloadit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transloadit/subscriptions","organizations_url":"https://api.github.com/users/transloadit/orgs","repos_url":"https://api.github.com/users/transloadit/repos","events_url":"https://api.github.com/users/transloadit/events{/privacy}","received_events_url":"https://api.github.com/users/transloadit/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/transloadit/uppy","description":"The next open source file uploader for web browsers :dog: ","fork":false,"url":"https://api.github.com/repos/transloadit/uppy","forks_url":"https://api.github.com/repos/transloadit/uppy/forks","keys_url":"https://api.github.com/repos/transloadit/uppy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/transloadit/uppy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/transloadit/uppy/teams","hooks_url":"https://api.github.com/repos/transloadit/uppy/hooks","issue_events_url":"https://api.github.com/repos/transloadit/uppy/issues/events{/number}","events_url":"https://api.github.com/repos/transloadit/uppy/events","assignees_url":"https://api.github.com/repos/transloadit/uppy/assignees{/user}","branches_url":"https://api.github.com/repos/transloadit/uppy/branches{/branch}","tags_url":"https://api.github.com/repos/transloadit/uppy/tags","blobs_url":"https://api.github.com/repos/transloadit/uppy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/transloadit/uppy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/transloadit/uppy/git/refs{/sha}","trees_url":"https://api.github.com/repos/transloadit/uppy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/transloadit/uppy/statuses/{sha}","languages_url":"https://api.github.com/repos/transloadit/uppy/languages","stargazers_url":"https://api.github.com/repos/transloadit/uppy/stargazers","contributors_url":"https://api.github.com/repos/transloadit/uppy/contributors","subscribers_url":"https://api.github.com/repos/transloadit/uppy/subscribers","subscription_url":"https://api.github.com/repos/transloadit/uppy/subscription","commits_url":"https://api.github.com/repos/transloadit/uppy/commits{/sha}","git_commits_url":"https://api.github.com/repos/transloadit/uppy/git/commits{/sha}","comments_url":"https://api.github.com/repos/transloadit/uppy/comments{/number}","issue_comment_url":"https://api.github.com/repos/transloadit/uppy/issues/comments{/number}","contents_url":"https://api.github.com/repos/transloadit/uppy/contents/{+path}","compare_url":"https://api.github.com/repos/transloadit/uppy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/transloadit/uppy/merges","archive_url":"https://api.github.com/repos/transloadit/uppy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/transloadit/uppy/downloads","issues_url":"https://api.github.com/repos/transloadit/uppy/issues{/number}","pulls_url":"https://api.github.com/repos/transloadit/uppy/pulls{/number}","milestones_url":"https://api.github.com/repos/transloadit/uppy/milestones{/number}","notifications_url":"https://api.github.com/repos/transloadit/uppy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/transloadit/uppy/labels{/name}","releases_url":"https://api.github.com/repos/transloadit/uppy/releases{/id}","deployments_url":"https://api.github.com/repos/transloadit/uppy/deployments","created_at":"2015-11-16T12:32:33Z","updated_at":"2018-10-17T19:26:32Z","pushed_at":"2018-10-17T10:28:32Z","git_url":"git://github.com/transloadit/uppy.git","ssh_url":"git@github.com:transloadit/uppy.git","clone_url":"https://github.com/transloadit/uppy.git","svn_url":"https://github.com/transloadit/uppy","homepage":"https://uppy.io","size":215951,"stargazers_count":12128,"watchers_count":12128,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":529,"mirror_url":null,"archived":false,"open_issues_count":104,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":529,"open_issues":104,"watchers":12128,"default_branch":"master"}},"base":{"label":"transloadit:master","ref":"master","sha":"32c197056ac4bf77e6db3eb4f66b74f490d6d1d3","user":{"login":"transloadit","id":125754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTc1NA==","avatar_url":"https://avatars2.githubusercontent.com/u/125754?v=4","gravatar_id":"","url":"https://api.github.com/users/transloadit","html_url":"https://github.com/transloadit","followers_url":"https://api.github.com/users/transloadit/followers","following_url":"https://api.github.com/users/transloadit/following{/other_user}","gists_url":"https://api.github.com/users/transloadit/gists{/gist_id}","starred_url":"https://api.github.com/users/transloadit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transloadit/subscriptions","organizations_url":"https://api.github.com/users/transloadit/orgs","repos_url":"https://api.github.com/users/transloadit/repos","events_url":"https://api.github.com/users/transloadit/events{/privacy}","received_events_url":"https://api.github.com/users/transloadit/received_events","type":"Organization","site_admin":false},"repo":{"id":46273445,"node_id":"MDEwOlJlcG9zaXRvcnk0NjI3MzQ0NQ==","name":"uppy","full_name":"transloadit/uppy","private":false,"owner":{"login":"transloadit","id":125754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTc1NA==","avatar_url":"https://avatars2.githubusercontent.com/u/125754?v=4","gravatar_id":"","url":"https://api.github.com/users/transloadit","html_url":"https://github.com/transloadit","followers_url":"https://api.github.com/users/transloadit/followers","following_url":"https://api.github.com/users/transloadit/following{/other_user}","gists_url":"https://api.github.com/users/transloadit/gists{/gist_id}","starred_url":"https://api.github.com/users/transloadit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transloadit/subscriptions","organizations_url":"https://api.github.com/users/transloadit/orgs","repos_url":"https://api.github.com/users/transloadit/repos","events_url":"https://api.github.com/users/transloadit/events{/privacy}","received_events_url":"https://api.github.com/users/transloadit/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/transloadit/uppy","description":"The next open source file uploader for web browsers :dog: ","fork":false,"url":"https://api.github.com/repos/transloadit/uppy","forks_url":"https://api.github.com/repos/transloadit/uppy/forks","keys_url":"https://api.github.com/repos/transloadit/uppy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/transloadit/uppy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/transloadit/uppy/teams","hooks_url":"https://api.github.com/repos/transloadit/uppy/hooks","issue_events_url":"https://api.github.com/repos/transloadit/uppy/issues/events{/number}","events_url":"https://api.github.com/repos/transloadit/uppy/events","assignees_url":"https://api.github.com/repos/transloadit/uppy/assignees{/user}","branches_url":"https://api.github.com/repos/transloadit/uppy/branches{/branch}","tags_url":"https://api.github.com/repos/transloadit/uppy/tags","blobs_url":"https://api.github.com/repos/transloadit/uppy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/transloadit/uppy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/transloadit/uppy/git/refs{/sha}","trees_url":"https://api.github.com/repos/transloadit/uppy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/transloadit/uppy/statuses/{sha}","languages_url":"https://api.github.com/repos/transloadit/uppy/languages","stargazers_url":"https://api.github.com/repos/transloadit/uppy/stargazers","contributors_url":"https://api.github.com/repos/transloadit/uppy/contributors","subscribers_url":"https://api.github.com/repos/transloadit/uppy/subscribers","subscription_url":"https://api.github.com/repos/transloadit/uppy/subscription","commits_url":"https://api.github.com/repos/transloadit/uppy/commits{/sha}","git_commits_url":"https://api.github.com/repos/transloadit/uppy/git/commits{/sha}","comments_url":"https://api.github.com/repos/transloadit/uppy/comments{/number}","issue_comment_url":"https://api.github.com/repos/transloadit/uppy/issues/comments{/number}","contents_url":"https://api.github.com/repos/transloadit/uppy/contents/{+path}","compare_url":"https://api.github.com/repos/transloadit/uppy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/transloadit/uppy/merges","archive_url":"https://api.github.com/repos/transloadit/uppy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/transloadit/uppy/downloads","issues_url":"https://api.github.com/repos/transloadit/uppy/issues{/number}","pulls_url":"https://api.github.com/repos/transloadit/uppy/pulls{/number}","milestones_url":"https://api.github.com/repos/transloadit/uppy/milestones{/number}","notifications_url":"https://api.github.com/repos/transloadit/uppy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/transloadit/uppy/labels{/name}","releases_url":"https://api.github.com/repos/transloadit/uppy/releases{/id}","deployments_url":"https://api.github.com/repos/transloadit/uppy/deployments","created_at":"2015-11-16T12:32:33Z","updated_at":"2018-10-17T19:26:32Z","pushed_at":"2018-10-17T10:28:32Z","git_url":"git://github.com/transloadit/uppy.git","ssh_url":"git@github.com:transloadit/uppy.git","clone_url":"https://github.com/transloadit/uppy.git","svn_url":"https://github.com/transloadit/uppy","homepage":"https://uppy.io","size":215951,"stargazers_count":12128,"watchers_count":12128,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":529,"mirror_url":null,"archived":false,"open_issues_count":104,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":529,"open_issues":104,"watchers":12128,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/transloadit/uppy/pulls/1103"},"html":{"href":"https://github.com/transloadit/uppy/pull/1103"},"issue":{"href":"https://api.github.com/repos/transloadit/uppy/issues/1103"},"comments":{"href":"https://api.github.com/repos/transloadit/uppy/issues/1103/comments"},"review_comments":{"href":"https://api.github.com/repos/transloadit/uppy/pulls/1103/comments"},"review_comment":{"href":"https://api.github.com/repos/transloadit/uppy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/transloadit/uppy/pulls/1103/commits"},"statuses":{"href":"https://api.github.com/repos/transloadit/uppy/statuses/b18743836d46208795f0ab685dd971d4ed162b0a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"arturi"}}