{"action":"created","issue":{"url":"https://api.github.com/repos/owncloud/core/issues/31164","repository_url":"https://api.github.com/repos/owncloud/core","labels_url":"https://api.github.com/repos/owncloud/core/issues/31164/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/core/issues/31164/comments","events_url":"https://api.github.com/repos/owncloud/core/issues/31164/events","html_url":"https://github.com/owncloud/core/pull/31164","id":314996864,"number":31164,"title":"Revert \"[stable10] Fix failure of shares which are already moved with transfer-ownership","user":{"login":"PVince81","id":277525,"avatar_url":"https://avatars2.githubusercontent.com/u/277525?v=4","gravatar_id":"","url":"https://api.github.com/users/PVince81","html_url":"https://github.com/PVince81","followers_url":"https://api.github.com/users/PVince81/followers","following_url":"https://api.github.com/users/PVince81/following{/other_user}","gists_url":"https://api.github.com/users/PVince81/gists{/gist_id}","starred_url":"https://api.github.com/users/PVince81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PVince81/subscriptions","organizations_url":"https://api.github.com/users/PVince81/orgs","repos_url":"https://api.github.com/users/PVince81/repos","events_url":"https://api.github.com/users/PVince81/events{/privacy}","received_events_url":"https://api.github.com/users/PVince81/received_events","type":"User","site_admin":false},"labels":[{"id":17709846,"url":"https://api.github.com/repos/owncloud/core/labels/3%20-%20To%20Review","name":"3 - To Review","color":"ededed","default":false},{"id":298283285,"url":"https://api.github.com/repos/owncloud/core/labels/p2-high","name":"p2-high","color":"fc2929","default":false}],"state":"open","locked":false,"assignee":{"login":"PVince81","id":277525,"avatar_url":"https://avatars2.githubusercontent.com/u/277525?v=4","gravatar_id":"","url":"https://api.github.com/users/PVince81","html_url":"https://github.com/PVince81","followers_url":"https://api.github.com/users/PVince81/followers","following_url":"https://api.github.com/users/PVince81/following{/other_user}","gists_url":"https://api.github.com/users/PVince81/gists{/gist_id}","starred_url":"https://api.github.com/users/PVince81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PVince81/subscriptions","organizations_url":"https://api.github.com/users/PVince81/orgs","repos_url":"https://api.github.com/users/PVince81/repos","events_url":"https://api.github.com/users/PVince81/events{/privacy}","received_events_url":"https://api.github.com/users/PVince81/received_events","type":"User","site_admin":false},"assignees":[{"login":"PVince81","id":277525,"avatar_url":"https://avatars2.githubusercontent.com/u/277525?v=4","gravatar_id":"","url":"https://api.github.com/users/PVince81","html_url":"https://github.com/PVince81","followers_url":"https://api.github.com/users/PVince81/followers","following_url":"https://api.github.com/users/PVince81/following{/other_user}","gists_url":"https://api.github.com/users/PVince81/gists{/gist_id}","starred_url":"https://api.github.com/users/PVince81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PVince81/subscriptions","organizations_url":"https://api.github.com/users/PVince81/orgs","repos_url":"https://api.github.com/users/PVince81/repos","events_url":"https://api.github.com/users/PVince81/events{/privacy}","received_events_url":"https://api.github.com/users/PVince81/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/owncloud/core/milestones/119","html_url":"https://github.com/owncloud/core/milestone/119","labels_url":"https://api.github.com/repos/owncloud/core/milestones/119/labels","id":2827584,"number":119,"title":"QA","description":"10.0.8","creator":{"login":"PVince81","id":277525,"avatar_url":"https://avatars2.githubusercontent.com/u/277525?v=4","gravatar_id":"","url":"https://api.github.com/users/PVince81","html_url":"https://github.com/PVince81","followers_url":"https://api.github.com/users/PVince81/followers","following_url":"https://api.github.com/users/PVince81/following{/other_user}","gists_url":"https://api.github.com/users/PVince81/gists{/gist_id}","starred_url":"https://api.github.com/users/PVince81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PVince81/subscriptions","organizations_url":"https://api.github.com/users/PVince81/orgs","repos_url":"https://api.github.com/users/PVince81/repos","events_url":"https://api.github.com/users/PVince81/events{/privacy}","received_events_url":"https://api.github.com/users/PVince81/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":677,"state":"open","created_at":"2017-10-10T13:37:01Z","updated_at":"2018-04-17T10:28:12Z","due_on":"2018-04-09T07:00:00Z","closed_at":null},"comments":1,"created_at":"2018-04-17T10:21:55Z","updated_at":"2018-04-17T10:43:36Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/31164","html_url":"https://github.com/owncloud/core/pull/31164","diff_url":"https://github.com/owncloud/core/pull/31164.diff","patch_url":"https://github.com/owncloud/core/pull/31164.patch"},"body":"Reverts https://github.com/owncloud/core/pull/30161\r\n\r\nHad to adjust the test reverting as the test file moved to a new location since the original PR"},"comment":{"url":"https://api.github.com/repos/owncloud/core/issues/comments/381943827","html_url":"https://github.com/owncloud/core/pull/31164#issuecomment-381943827","issue_url":"https://api.github.com/repos/owncloud/core/issues/31164","id":381943827,"user":{"login":"sharidas","id":3600427,"avatar_url":"https://avatars1.githubusercontent.com/u/3600427?v=4","gravatar_id":"","url":"https://api.github.com/users/sharidas","html_url":"https://github.com/sharidas","followers_url":"https://api.github.com/users/sharidas/followers","following_url":"https://api.github.com/users/sharidas/following{/other_user}","gists_url":"https://api.github.com/users/sharidas/gists{/gist_id}","starred_url":"https://api.github.com/users/sharidas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharidas/subscriptions","organizations_url":"https://api.github.com/users/sharidas/orgs","repos_url":"https://api.github.com/users/sharidas/repos","events_url":"https://api.github.com/users/sharidas/events{/privacy}","received_events_url":"https://api.github.com/users/sharidas/received_events","type":"User","site_admin":false},"created_at":"2018-04-17T10:43:36Z","updated_at":"2018-04-17T10:43:36Z","author_association":"MEMBER","body":"Below are the steps done to verify the change.\r\nThe command fails, as expected:\r\n```\r\n➜  owncloud3 git:(stable10-revert-transfer-ownership-share) ✗ ./occ files:transfer-ownership admin user1                                                       \r\nCannot load Xdebug - it was already loaded\r\nAnalysing files of admin ...\r\n    1 [============================]\r\nCollecting all share information for files and folder of admin ...\r\n    2 [============================]\r\nTransferring files to user1/files/transferred from admin on 20180417_102837 ...\r\nRestoring shares ...\r\n 1/2 [==============>-------------]  50%Could not restore share with id 2:#0 /home/sujith/test/owncloud3/lib/private/Share20/Manager.php(1108): OC\\Share20\\DefaultShareProvider->getShareById('2', NULL)\r\n#1 /home/sujith/test/owncloud3/lib/private/Share20/Manager.php(691): OC\\Share20\\Manager->getShareById('2')\r\n#2 /home/sujith/test/owncloud3/apps/files/lib/Command/TransferOwnership.php(317): OC\\Share20\\Manager->updateShare(Object(OC\\Share20\\Share))\r\n#3 /home/sujith/test/owncloud3/apps/files/lib/Command/TransferOwnership.php(171): OCA\\Files\\Command\\TransferOwnership->restoreShares(Object(Symfony\\Component\\Console\\Output\\ConsoleOutput))\r\n#4 /home/sujith/test/owncloud3/lib/composer/symfony/console/Command/Command.php(252): OCA\\Files\\Command\\TransferOwnership->execute(Object(Symfony\\Component\\Console\\Input\\ArgvInput), Object(Symfony\\Component\\Console\\Output\\ConsoleOutput))\r\n#5 /home/sujith/test/owncloud3/lib/composer/symfony/console/Application.php(946): Symfony\\Component\\Console\\Command\\Command->run(Object(Symfony\\Component\\Console\\Input\\ArgvInput), Object(Symfony\\Component\\Console\\Output\\ConsoleOutput))\r\n#6 /home/sujith/test/owncloud3/lib/composer/symfony/console/Application.php(248): Symfony\\Component\\Console\\Application->doRunCommand(Object(OCA\\Files\\Command\\TransferOwnership), Object(Symfony\\Component\\Console\\Input\\ArgvInput), Object(Symfony\\Component\\Console\\Output\\ConsoleOutput))\r\n#7 /home/sujith/test/owncloud3/lib/composer/symfony/console/Application.php(148): Symfony\\Component\\Console\\Application->doRun(Object(Symfony\\Component\\Console\\Input\\ArgvInput), Object(Symfony\\Component\\Console\\Output\\ConsoleOutput))\r\n#8 /home/sujith/test/owncloud3/lib/private/Console/Application.php(161): Symfony\\Component\\Console\\Application->run(Object(Symfony\\Component\\Console\\Input\\ArgvInput), Object(Symfony\\Component\\Console\\Output\\ConsoleOutput))\r\n#9 /home/sujith/test/owncloud3/console.php(106): OC\\Console\\Application->run()\r\n#10 /home/sujith/test/owncloud3/occ(11): require_once('/home/sujith/te...')\r\n#11 {main}\r\n 2/2 [============================] 100%\r\n➜  owncloud3 git:(stable10-revert-transfer-ownership-share) ✗ git show\r\n➜  owncloud3 git:(stable10-revert-transfer-ownership-share) ✗\r\n```\r\n\r\nThe folder foo/test is created as `admin` user. 'foo/test' is shared to user `user1`. And as `user1` create public link. After this command is run,\r\n- the folder foo/test is available under transferred folder\r\n- the public share link doesn't work. User has to create a new link.\r\n\r\nTried with private link in `user1`. And after running the command, when user tries to open the link,\r\nit opens the folder from transferred folder."}}
{"actor":{"display_login":"sharidas"}}