{"action":"created","comment":{"url":"https://api.github.com/repos/DeclarativeHub/Bond/pulls/comments/181550504","pull_request_review_id":112205762,"id":181550504,"diff_hunk":"@@ -0,0 +1,94 @@\n+//\n+//  The MIT License (MIT)\n+//\n+//  Copyright (c) 2018 Tony Arnold (@tonyarnold)\n+//\n+//  Permission is hereby granted, free of charge, to any person obtaining a copy\n+//  of this software and associated documentation files (the \"Software\"), to deal\n+//  in the Software without restriction, including without limitation the rights\n+//  to use, copy, modify, merge, publish, distribute, sublicense, and/or sell\n+//  copies of the Software, and to permit persons to whom the Software is\n+//  furnished to do so, subject to the following conditions:\n+//\n+//  The above copyright notice and this permission notice shall be included in\n+//  all copies or substantial portions of the Software.\n+//\n+//  THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR\n+//  IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,\n+//  FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE\n+//  AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER\n+//  LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,\n+//  OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN\n+//  THE SOFTWARE.\n+//\n+\n+import Differ\n+import ReactiveKit\n+\n+public class ObservableCollection<UnderlyingCollection: Collection>: SignalProtocol {\n+\n+    public internal(set) var collection: UnderlyingCollection\n+    internal let subject = PublishSubject<ObservableCollectionEvent<UnderlyingCollection>, NoError>()","path":"Sources/Bond/ObservableCollection/ObservableCollection.swift","position":31,"original_position":31,"commit_id":"7a3a89c429cc2e766c6c8c5f5be828f1a4ba8d50","original_commit_id":"468eb89b408f90fdd12ade88c5fee6d7d8e913da","user":{"login":"srdanrasic","id":1660804,"avatar_url":"https://avatars1.githubusercontent.com/u/1660804?v=4","gravatar_id":"","url":"https://api.github.com/users/srdanrasic","html_url":"https://github.com/srdanrasic","followers_url":"https://api.github.com/users/srdanrasic/followers","following_url":"https://api.github.com/users/srdanrasic/following{/other_user}","gists_url":"https://api.github.com/users/srdanrasic/gists{/gist_id}","starred_url":"https://api.github.com/users/srdanrasic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srdanrasic/subscriptions","organizations_url":"https://api.github.com/users/srdanrasic/orgs","repos_url":"https://api.github.com/users/srdanrasic/repos","events_url":"https://api.github.com/users/srdanrasic/events{/privacy}","received_events_url":"https://api.github.com/users/srdanrasic/received_events","type":"User","site_admin":false},"body":"Thanks for that, I see now where the problem is! I'll try to fix it today.","created_at":"2018-04-14T12:01:23Z","updated_at":"2018-04-14T12:01:23Z","html_url":"https://github.com/DeclarativeHub/Bond/pull/514#discussion_r181550504","pull_request_url":"https://api.github.com/repos/DeclarativeHub/Bond/pulls/514","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DeclarativeHub/Bond/pulls/comments/181550504"},"html":{"href":"https://github.com/DeclarativeHub/Bond/pull/514#discussion_r181550504"},"pull_request":{"href":"https://api.github.com/repos/DeclarativeHub/Bond/pulls/514"}},"in_reply_to_id":179943871},"pull_request":{"url":"https://api.github.com/repos/DeclarativeHub/Bond/pulls/514","id":178838388,"html_url":"https://github.com/DeclarativeHub/Bond/pull/514","diff_url":"https://github.com/DeclarativeHub/Bond/pull/514.diff","patch_url":"https://github.com/DeclarativeHub/Bond/pull/514.patch","issue_url":"https://api.github.com/repos/DeclarativeHub/Bond/issues/514","number":514,"state":"open","locked":false,"title":"[WIP] ObservableCollection implementation","user":{"login":"srdanrasic","id":1660804,"avatar_url":"https://avatars1.githubusercontent.com/u/1660804?v=4","gravatar_id":"","url":"https://api.github.com/users/srdanrasic","html_url":"https://github.com/srdanrasic","followers_url":"https://api.github.com/users/srdanrasic/followers","following_url":"https://api.github.com/users/srdanrasic/following{/other_user}","gists_url":"https://api.github.com/users/srdanrasic/gists{/gist_id}","starred_url":"https://api.github.com/users/srdanrasic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srdanrasic/subscriptions","organizations_url":"https://api.github.com/users/srdanrasic/orgs","repos_url":"https://api.github.com/users/srdanrasic/repos","events_url":"https://api.github.com/users/srdanrasic/events{/privacy}","received_events_url":"https://api.github.com/users/srdanrasic/received_events","type":"User","site_admin":false},"body":"This PR adds a new `ObservableCollection` type that was proposed in #493. \r\n\r\nTo do:\r\n\r\n- [x] Refactor ObservableCollectionEvent to better handle diff/patch updates\r\n- [ ] Write some tests\r\n- [ ] Flesh out some documentation on how to extend `ObservableCollection`\r\n- [ ] Deprecate/typealias `ObservableArray` to this new class","created_at":"2018-04-02T13:22:40Z","updated_at":"2018-04-14T12:01:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0e42a5a41264dcfa4a9f5a82f6bdec47ab7c0fdc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DeclarativeHub/Bond/pulls/514/commits","review_comments_url":"https://api.github.com/repos/DeclarativeHub/Bond/pulls/514/comments","review_comment_url":"https://api.github.com/repos/DeclarativeHub/Bond/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DeclarativeHub/Bond/issues/514/comments","statuses_url":"https://api.github.com/repos/DeclarativeHub/Bond/statuses/7a3a89c429cc2e766c6c8c5f5be828f1a4ba8d50","head":{"label":"DeclarativeHub:observable-collection","ref":"observable-collection","sha":"7a3a89c429cc2e766c6c8c5f5be828f1a4ba8d50","user":{"login":"DeclarativeHub","id":35670541,"avatar_url":"https://avatars1.githubusercontent.com/u/35670541?v=4","gravatar_id":"","url":"https://api.github.com/users/DeclarativeHub","html_url":"https://github.com/DeclarativeHub","followers_url":"https://api.github.com/users/DeclarativeHub/followers","following_url":"https://api.github.com/users/DeclarativeHub/following{/other_user}","gists_url":"https://api.github.com/users/DeclarativeHub/gists{/gist_id}","starred_url":"https://api.github.com/users/DeclarativeHub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeclarativeHub/subscriptions","organizations_url":"https://api.github.com/users/DeclarativeHub/orgs","repos_url":"https://api.github.com/users/DeclarativeHub/repos","events_url":"https://api.github.com/users/DeclarativeHub/events{/privacy}","received_events_url":"https://api.github.com/users/DeclarativeHub/received_events","type":"Organization","site_admin":false},"repo":{"id":30039066,"name":"Bond","full_name":"DeclarativeHub/Bond","owner":{"login":"DeclarativeHub","id":35670541,"avatar_url":"https://avatars1.githubusercontent.com/u/35670541?v=4","gravatar_id":"","url":"https://api.github.com/users/DeclarativeHub","html_url":"https://github.com/DeclarativeHub","followers_url":"https://api.github.com/users/DeclarativeHub/followers","following_url":"https://api.github.com/users/DeclarativeHub/following{/other_user}","gists_url":"https://api.github.com/users/DeclarativeHub/gists{/gist_id}","starred_url":"https://api.github.com/users/DeclarativeHub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeclarativeHub/subscriptions","organizations_url":"https://api.github.com/users/DeclarativeHub/orgs","repos_url":"https://api.github.com/users/DeclarativeHub/repos","events_url":"https://api.github.com/users/DeclarativeHub/events{/privacy}","received_events_url":"https://api.github.com/users/DeclarativeHub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DeclarativeHub/Bond","description":"A Swift binding framework","fork":false,"url":"https://api.github.com/repos/DeclarativeHub/Bond","forks_url":"https://api.github.com/repos/DeclarativeHub/Bond/forks","keys_url":"https://api.github.com/repos/DeclarativeHub/Bond/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DeclarativeHub/Bond/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DeclarativeHub/Bond/teams","hooks_url":"https://api.github.com/repos/DeclarativeHub/Bond/hooks","issue_events_url":"https://api.github.com/repos/DeclarativeHub/Bond/issues/events{/number}","events_url":"https://api.github.com/repos/DeclarativeHub/Bond/events","assignees_url":"https://api.github.com/repos/DeclarativeHub/Bond/assignees{/user}","branches_url":"https://api.github.com/repos/DeclarativeHub/Bond/branches{/branch}","tags_url":"https://api.github.com/repos/DeclarativeHub/Bond/tags","blobs_url":"https://api.github.com/repos/DeclarativeHub/Bond/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DeclarativeHub/Bond/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DeclarativeHub/Bond/git/refs{/sha}","trees_url":"https://api.github.com/repos/DeclarativeHub/Bond/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DeclarativeHub/Bond/statuses/{sha}","languages_url":"https://api.github.com/repos/DeclarativeHub/Bond/languages","stargazers_url":"https://api.github.com/repos/DeclarativeHub/Bond/stargazers","contributors_url":"https://api.github.com/repos/DeclarativeHub/Bond/contributors","subscribers_url":"https://api.github.com/repos/DeclarativeHub/Bond/subscribers","subscription_url":"https://api.github.com/repos/DeclarativeHub/Bond/subscription","commits_url":"https://api.github.com/repos/DeclarativeHub/Bond/commits{/sha}","git_commits_url":"https://api.github.com/repos/DeclarativeHub/Bond/git/commits{/sha}","comments_url":"https://api.github.com/repos/DeclarativeHub/Bond/comments{/number}","issue_comment_url":"https://api.github.com/repos/DeclarativeHub/Bond/issues/comments{/number}","contents_url":"https://api.github.com/repos/DeclarativeHub/Bond/contents/{+path}","compare_url":"https://api.github.com/repos/DeclarativeHub/Bond/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DeclarativeHub/Bond/merges","archive_url":"https://api.github.com/repos/DeclarativeHub/Bond/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DeclarativeHub/Bond/downloads","issues_url":"https://api.github.com/repos/DeclarativeHub/Bond/issues{/number}","pulls_url":"https://api.github.com/repos/DeclarativeHub/Bond/pulls{/number}","milestones_url":"https://api.github.com/repos/DeclarativeHub/Bond/milestones{/number}","notifications_url":"https://api.github.com/repos/DeclarativeHub/Bond/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DeclarativeHub/Bond/labels{/name}","releases_url":"https://api.github.com/repos/DeclarativeHub/Bond/releases{/id}","deployments_url":"https://api.github.com/repos/DeclarativeHub/Bond/deployments","created_at":"2015-01-29T20:13:25Z","updated_at":"2018-04-14T09:07:13Z","pushed_at":"2018-04-14T09:44:23Z","git_url":"git://github.com/DeclarativeHub/Bond.git","ssh_url":"git@github.com:DeclarativeHub/Bond.git","clone_url":"https://github.com/DeclarativeHub/Bond.git","svn_url":"https://github.com/DeclarativeHub/Bond","homepage":null,"size":1648,"stargazers_count":3480,"watchers_count":3480,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":288,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":288,"open_issues":11,"watchers":3480,"default_branch":"master"}},"base":{"label":"DeclarativeHub:master","ref":"master","sha":"e730789c16187ba073d4c5b7e67c65381777ce92","user":{"login":"DeclarativeHub","id":35670541,"avatar_url":"https://avatars1.githubusercontent.com/u/35670541?v=4","gravatar_id":"","url":"https://api.github.com/users/DeclarativeHub","html_url":"https://github.com/DeclarativeHub","followers_url":"https://api.github.com/users/DeclarativeHub/followers","following_url":"https://api.github.com/users/DeclarativeHub/following{/other_user}","gists_url":"https://api.github.com/users/DeclarativeHub/gists{/gist_id}","starred_url":"https://api.github.com/users/DeclarativeHub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeclarativeHub/subscriptions","organizations_url":"https://api.github.com/users/DeclarativeHub/orgs","repos_url":"https://api.github.com/users/DeclarativeHub/repos","events_url":"https://api.github.com/users/DeclarativeHub/events{/privacy}","received_events_url":"https://api.github.com/users/DeclarativeHub/received_events","type":"Organization","site_admin":false},"repo":{"id":30039066,"name":"Bond","full_name":"DeclarativeHub/Bond","owner":{"login":"DeclarativeHub","id":35670541,"avatar_url":"https://avatars1.githubusercontent.com/u/35670541?v=4","gravatar_id":"","url":"https://api.github.com/users/DeclarativeHub","html_url":"https://github.com/DeclarativeHub","followers_url":"https://api.github.com/users/DeclarativeHub/followers","following_url":"https://api.github.com/users/DeclarativeHub/following{/other_user}","gists_url":"https://api.github.com/users/DeclarativeHub/gists{/gist_id}","starred_url":"https://api.github.com/users/DeclarativeHub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeclarativeHub/subscriptions","organizations_url":"https://api.github.com/users/DeclarativeHub/orgs","repos_url":"https://api.github.com/users/DeclarativeHub/repos","events_url":"https://api.github.com/users/DeclarativeHub/events{/privacy}","received_events_url":"https://api.github.com/users/DeclarativeHub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DeclarativeHub/Bond","description":"A Swift binding framework","fork":false,"url":"https://api.github.com/repos/DeclarativeHub/Bond","forks_url":"https://api.github.com/repos/DeclarativeHub/Bond/forks","keys_url":"https://api.github.com/repos/DeclarativeHub/Bond/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DeclarativeHub/Bond/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DeclarativeHub/Bond/teams","hooks_url":"https://api.github.com/repos/DeclarativeHub/Bond/hooks","issue_events_url":"https://api.github.com/repos/DeclarativeHub/Bond/issues/events{/number}","events_url":"https://api.github.com/repos/DeclarativeHub/Bond/events","assignees_url":"https://api.github.com/repos/DeclarativeHub/Bond/assignees{/user}","branches_url":"https://api.github.com/repos/DeclarativeHub/Bond/branches{/branch}","tags_url":"https://api.github.com/repos/DeclarativeHub/Bond/tags","blobs_url":"https://api.github.com/repos/DeclarativeHub/Bond/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DeclarativeHub/Bond/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DeclarativeHub/Bond/git/refs{/sha}","trees_url":"https://api.github.com/repos/DeclarativeHub/Bond/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DeclarativeHub/Bond/statuses/{sha}","languages_url":"https://api.github.com/repos/DeclarativeHub/Bond/languages","stargazers_url":"https://api.github.com/repos/DeclarativeHub/Bond/stargazers","contributors_url":"https://api.github.com/repos/DeclarativeHub/Bond/contributors","subscribers_url":"https://api.github.com/repos/DeclarativeHub/Bond/subscribers","subscription_url":"https://api.github.com/repos/DeclarativeHub/Bond/subscription","commits_url":"https://api.github.com/repos/DeclarativeHub/Bond/commits{/sha}","git_commits_url":"https://api.github.com/repos/DeclarativeHub/Bond/git/commits{/sha}","comments_url":"https://api.github.com/repos/DeclarativeHub/Bond/comments{/number}","issue_comment_url":"https://api.github.com/repos/DeclarativeHub/Bond/issues/comments{/number}","contents_url":"https://api.github.com/repos/DeclarativeHub/Bond/contents/{+path}","compare_url":"https://api.github.com/repos/DeclarativeHub/Bond/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DeclarativeHub/Bond/merges","archive_url":"https://api.github.com/repos/DeclarativeHub/Bond/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DeclarativeHub/Bond/downloads","issues_url":"https://api.github.com/repos/DeclarativeHub/Bond/issues{/number}","pulls_url":"https://api.github.com/repos/DeclarativeHub/Bond/pulls{/number}","milestones_url":"https://api.github.com/repos/DeclarativeHub/Bond/milestones{/number}","notifications_url":"https://api.github.com/repos/DeclarativeHub/Bond/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DeclarativeHub/Bond/labels{/name}","releases_url":"https://api.github.com/repos/DeclarativeHub/Bond/releases{/id}","deployments_url":"https://api.github.com/repos/DeclarativeHub/Bond/deployments","created_at":"2015-01-29T20:13:25Z","updated_at":"2018-04-14T09:07:13Z","pushed_at":"2018-04-14T09:44:23Z","git_url":"git://github.com/DeclarativeHub/Bond.git","ssh_url":"git@github.com:DeclarativeHub/Bond.git","clone_url":"https://github.com/DeclarativeHub/Bond.git","svn_url":"https://github.com/DeclarativeHub/Bond","homepage":null,"size":1648,"stargazers_count":3480,"watchers_count":3480,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":288,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":288,"open_issues":11,"watchers":3480,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DeclarativeHub/Bond/pulls/514"},"html":{"href":"https://github.com/DeclarativeHub/Bond/pull/514"},"issue":{"href":"https://api.github.com/repos/DeclarativeHub/Bond/issues/514"},"comments":{"href":"https://api.github.com/repos/DeclarativeHub/Bond/issues/514/comments"},"review_comments":{"href":"https://api.github.com/repos/DeclarativeHub/Bond/pulls/514/comments"},"review_comment":{"href":"https://api.github.com/repos/DeclarativeHub/Bond/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DeclarativeHub/Bond/pulls/514/commits"},"statuses":{"href":"https://api.github.com/repos/DeclarativeHub/Bond/statuses/7a3a89c429cc2e766c6c8c5f5be828f1a4ba8d50"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"srdanrasic"}}