{"action":"created","comment":{"url":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/comments/183238434","pull_request_review_id":114202520,"id":183238434,"diff_hunk":"@@ -12,10 +12,27 @@ namespace Service::NFP {\n Module::Interface::Interface(std::shared_ptr<Module> module, const char* name)\n     : ServiceFramework(name), module(std::move(module)) {}\n \n-void Module::Interface::Unknown(Kernel::HLERequestContext& ctx) {\n+class IUser final : public ServiceFramework<IUser> {\n+public:\n+    IUser() : ServiceFramework(\"IUser\") {\n+        static const FunctionInfo functions[] = {\n+            {0, &IUser::Initialize, \"Initialize\"},","path":"src/core/hle/service/nfp/nfp.cpp","position":9,"original_position":9,"commit_id":"df669bc540d0ffec4afd298fdeb7767c3a4ea242","original_commit_id":"df669bc540d0ffec4afd298fdeb7767c3a4ea242","user":{"login":"Hexagon12","id":25362478,"avatar_url":"https://avatars3.githubusercontent.com/u/25362478?v=4","gravatar_id":"","url":"https://api.github.com/users/Hexagon12","html_url":"https://github.com/Hexagon12","followers_url":"https://api.github.com/users/Hexagon12/followers","following_url":"https://api.github.com/users/Hexagon12/following{/other_user}","gists_url":"https://api.github.com/users/Hexagon12/gists{/gist_id}","starred_url":"https://api.github.com/users/Hexagon12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hexagon12/subscriptions","organizations_url":"https://api.github.com/users/Hexagon12/orgs","repos_url":"https://api.github.com/users/Hexagon12/repos","events_url":"https://api.github.com/users/Hexagon12/events{/privacy}","received_events_url":"https://api.github.com/users/Hexagon12/received_events","type":"User","site_admin":false},"body":"It would be nice of you to actually include all known services here as nullptrs. (24 are known in IUser)","created_at":"2018-04-22T14:16:04Z","updated_at":"2018-04-22T14:16:15Z","html_url":"https://github.com/yuzu-emu/yuzu/pull/380#discussion_r183238434","pull_request_url":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/380","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/comments/183238434"},"html":{"href":"https://github.com/yuzu-emu/yuzu/pull/380#discussion_r183238434"},"pull_request":{"href":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/380"}}},"pull_request":{"url":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/380","id":183255998,"html_url":"https://github.com/yuzu-emu/yuzu/pull/380","diff_url":"https://github.com/yuzu-emu/yuzu/pull/380.diff","patch_url":"https://github.com/yuzu-emu/yuzu/pull/380.patch","issue_url":"https://api.github.com/repos/yuzu-emu/yuzu/issues/380","number":380,"state":"open","locked":false,"title":"Implemented some useful interfaces needed for games.","user":{"login":"ogniK5377","id":25727384,"avatar_url":"https://avatars3.githubusercontent.com/u/25727384?v=4","gravatar_id":"","url":"https://api.github.com/users/ogniK5377","html_url":"https://github.com/ogniK5377","followers_url":"https://api.github.com/users/ogniK5377/followers","following_url":"https://api.github.com/users/ogniK5377/following{/other_user}","gists_url":"https://api.github.com/users/ogniK5377/gists{/gist_id}","starred_url":"https://api.github.com/users/ogniK5377/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogniK5377/subscriptions","organizations_url":"https://api.github.com/users/ogniK5377/orgs","repos_url":"https://api.github.com/users/ogniK5377/repos","events_url":"https://api.github.com/users/ogniK5377/events{/privacy}","received_events_url":"https://api.github.com/users/ogniK5377/received_events","type":"User","site_admin":false},"body":"Just implemented a few services","created_at":"2018-04-22T05:09:20Z","updated_at":"2018-04-22T14:16:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e85c54b07d0aa43e8baaf4bac809a1b1ba6f537","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/380/commits","review_comments_url":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/380/comments","review_comment_url":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yuzu-emu/yuzu/issues/380/comments","statuses_url":"https://api.github.com/repos/yuzu-emu/yuzu/statuses/df669bc540d0ffec4afd298fdeb7767c3a4ea242","head":{"label":"ogniK5377:service-impl","ref":"service-impl","sha":"df669bc540d0ffec4afd298fdeb7767c3a4ea242","user":{"login":"ogniK5377","id":25727384,"avatar_url":"https://avatars3.githubusercontent.com/u/25727384?v=4","gravatar_id":"","url":"https://api.github.com/users/ogniK5377","html_url":"https://github.com/ogniK5377","followers_url":"https://api.github.com/users/ogniK5377/followers","following_url":"https://api.github.com/users/ogniK5377/following{/other_user}","gists_url":"https://api.github.com/users/ogniK5377/gists{/gist_id}","starred_url":"https://api.github.com/users/ogniK5377/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogniK5377/subscriptions","organizations_url":"https://api.github.com/users/ogniK5377/orgs","repos_url":"https://api.github.com/users/ogniK5377/repos","events_url":"https://api.github.com/users/ogniK5377/events{/privacy}","received_events_url":"https://api.github.com/users/ogniK5377/received_events","type":"User","site_admin":false},"repo":{"id":117499487,"name":"yuzu","full_name":"ogniK5377/yuzu","owner":{"login":"ogniK5377","id":25727384,"avatar_url":"https://avatars3.githubusercontent.com/u/25727384?v=4","gravatar_id":"","url":"https://api.github.com/users/ogniK5377","html_url":"https://github.com/ogniK5377","followers_url":"https://api.github.com/users/ogniK5377/followers","following_url":"https://api.github.com/users/ogniK5377/following{/other_user}","gists_url":"https://api.github.com/users/ogniK5377/gists{/gist_id}","starred_url":"https://api.github.com/users/ogniK5377/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogniK5377/subscriptions","organizations_url":"https://api.github.com/users/ogniK5377/orgs","repos_url":"https://api.github.com/users/ogniK5377/repos","events_url":"https://api.github.com/users/ogniK5377/events{/privacy}","received_events_url":"https://api.github.com/users/ogniK5377/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ogniK5377/yuzu","description":"Nintendo Switch Emulator","fork":true,"url":"https://api.github.com/repos/ogniK5377/yuzu","forks_url":"https://api.github.com/repos/ogniK5377/yuzu/forks","keys_url":"https://api.github.com/repos/ogniK5377/yuzu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ogniK5377/yuzu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ogniK5377/yuzu/teams","hooks_url":"https://api.github.com/repos/ogniK5377/yuzu/hooks","issue_events_url":"https://api.github.com/repos/ogniK5377/yuzu/issues/events{/number}","events_url":"https://api.github.com/repos/ogniK5377/yuzu/events","assignees_url":"https://api.github.com/repos/ogniK5377/yuzu/assignees{/user}","branches_url":"https://api.github.com/repos/ogniK5377/yuzu/branches{/branch}","tags_url":"https://api.github.com/repos/ogniK5377/yuzu/tags","blobs_url":"https://api.github.com/repos/ogniK5377/yuzu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ogniK5377/yuzu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ogniK5377/yuzu/git/refs{/sha}","trees_url":"https://api.github.com/repos/ogniK5377/yuzu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ogniK5377/yuzu/statuses/{sha}","languages_url":"https://api.github.com/repos/ogniK5377/yuzu/languages","stargazers_url":"https://api.github.com/repos/ogniK5377/yuzu/stargazers","contributors_url":"https://api.github.com/repos/ogniK5377/yuzu/contributors","subscribers_url":"https://api.github.com/repos/ogniK5377/yuzu/subscribers","subscription_url":"https://api.github.com/repos/ogniK5377/yuzu/subscription","commits_url":"https://api.github.com/repos/ogniK5377/yuzu/commits{/sha}","git_commits_url":"https://api.github.com/repos/ogniK5377/yuzu/git/commits{/sha}","comments_url":"https://api.github.com/repos/ogniK5377/yuzu/comments{/number}","issue_comment_url":"https://api.github.com/repos/ogniK5377/yuzu/issues/comments{/number}","contents_url":"https://api.github.com/repos/ogniK5377/yuzu/contents/{+path}","compare_url":"https://api.github.com/repos/ogniK5377/yuzu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ogniK5377/yuzu/merges","archive_url":"https://api.github.com/repos/ogniK5377/yuzu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ogniK5377/yuzu/downloads","issues_url":"https://api.github.com/repos/ogniK5377/yuzu/issues{/number}","pulls_url":"https://api.github.com/repos/ogniK5377/yuzu/pulls{/number}","milestones_url":"https://api.github.com/repos/ogniK5377/yuzu/milestones{/number}","notifications_url":"https://api.github.com/repos/ogniK5377/yuzu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ogniK5377/yuzu/labels{/name}","releases_url":"https://api.github.com/repos/ogniK5377/yuzu/releases{/id}","deployments_url":"https://api.github.com/repos/ogniK5377/yuzu/deployments","created_at":"2018-01-15T05:04:16Z","updated_at":"2018-02-19T18:59:45Z","pushed_at":"2018-04-22T07:07:57Z","git_url":"git://github.com/ogniK5377/yuzu.git","ssh_url":"git@github.com:ogniK5377/yuzu.git","clone_url":"https://github.com/ogniK5377/yuzu.git","svn_url":"https://github.com/ogniK5377/yuzu","homepage":"","size":18305,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"yuzu-emu:master","ref":"master","sha":"ebb8e06df0bb21aa1c61ab6113c4c3d45dec8506","user":{"login":"yuzu-emu","id":35075882,"avatar_url":"https://avatars1.githubusercontent.com/u/35075882?v=4","gravatar_id":"","url":"https://api.github.com/users/yuzu-emu","html_url":"https://github.com/yuzu-emu","followers_url":"https://api.github.com/users/yuzu-emu/followers","following_url":"https://api.github.com/users/yuzu-emu/following{/other_user}","gists_url":"https://api.github.com/users/yuzu-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/yuzu-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuzu-emu/subscriptions","organizations_url":"https://api.github.com/users/yuzu-emu/orgs","repos_url":"https://api.github.com/users/yuzu-emu/repos","events_url":"https://api.github.com/users/yuzu-emu/events{/privacy}","received_events_url":"https://api.github.com/users/yuzu-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":116167731,"name":"yuzu","full_name":"yuzu-emu/yuzu","owner":{"login":"yuzu-emu","id":35075882,"avatar_url":"https://avatars1.githubusercontent.com/u/35075882?v=4","gravatar_id":"","url":"https://api.github.com/users/yuzu-emu","html_url":"https://github.com/yuzu-emu","followers_url":"https://api.github.com/users/yuzu-emu/followers","following_url":"https://api.github.com/users/yuzu-emu/following{/other_user}","gists_url":"https://api.github.com/users/yuzu-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/yuzu-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuzu-emu/subscriptions","organizations_url":"https://api.github.com/users/yuzu-emu/orgs","repos_url":"https://api.github.com/users/yuzu-emu/repos","events_url":"https://api.github.com/users/yuzu-emu/events{/privacy}","received_events_url":"https://api.github.com/users/yuzu-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yuzu-emu/yuzu","description":"Nintendo Switch Emulator","fork":false,"url":"https://api.github.com/repos/yuzu-emu/yuzu","forks_url":"https://api.github.com/repos/yuzu-emu/yuzu/forks","keys_url":"https://api.github.com/repos/yuzu-emu/yuzu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yuzu-emu/yuzu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yuzu-emu/yuzu/teams","hooks_url":"https://api.github.com/repos/yuzu-emu/yuzu/hooks","issue_events_url":"https://api.github.com/repos/yuzu-emu/yuzu/issues/events{/number}","events_url":"https://api.github.com/repos/yuzu-emu/yuzu/events","assignees_url":"https://api.github.com/repos/yuzu-emu/yuzu/assignees{/user}","branches_url":"https://api.github.com/repos/yuzu-emu/yuzu/branches{/branch}","tags_url":"https://api.github.com/repos/yuzu-emu/yuzu/tags","blobs_url":"https://api.github.com/repos/yuzu-emu/yuzu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yuzu-emu/yuzu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yuzu-emu/yuzu/git/refs{/sha}","trees_url":"https://api.github.com/repos/yuzu-emu/yuzu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yuzu-emu/yuzu/statuses/{sha}","languages_url":"https://api.github.com/repos/yuzu-emu/yuzu/languages","stargazers_url":"https://api.github.com/repos/yuzu-emu/yuzu/stargazers","contributors_url":"https://api.github.com/repos/yuzu-emu/yuzu/contributors","subscribers_url":"https://api.github.com/repos/yuzu-emu/yuzu/subscribers","subscription_url":"https://api.github.com/repos/yuzu-emu/yuzu/subscription","commits_url":"https://api.github.com/repos/yuzu-emu/yuzu/commits{/sha}","git_commits_url":"https://api.github.com/repos/yuzu-emu/yuzu/git/commits{/sha}","comments_url":"https://api.github.com/repos/yuzu-emu/yuzu/comments{/number}","issue_comment_url":"https://api.github.com/repos/yuzu-emu/yuzu/issues/comments{/number}","contents_url":"https://api.github.com/repos/yuzu-emu/yuzu/contents/{+path}","compare_url":"https://api.github.com/repos/yuzu-emu/yuzu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yuzu-emu/yuzu/merges","archive_url":"https://api.github.com/repos/yuzu-emu/yuzu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yuzu-emu/yuzu/downloads","issues_url":"https://api.github.com/repos/yuzu-emu/yuzu/issues{/number}","pulls_url":"https://api.github.com/repos/yuzu-emu/yuzu/pulls{/number}","milestones_url":"https://api.github.com/repos/yuzu-emu/yuzu/milestones{/number}","notifications_url":"https://api.github.com/repos/yuzu-emu/yuzu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yuzu-emu/yuzu/labels{/name}","releases_url":"https://api.github.com/repos/yuzu-emu/yuzu/releases{/id}","deployments_url":"https://api.github.com/repos/yuzu-emu/yuzu/deployments","created_at":"2018-01-03T18:13:57Z","updated_at":"2018-04-22T14:14:56Z","pushed_at":"2018-04-22T07:07:57Z","git_url":"git://github.com/yuzu-emu/yuzu.git","ssh_url":"git@github.com:yuzu-emu/yuzu.git","clone_url":"https://github.com/yuzu-emu/yuzu.git","svn_url":"https://github.com/yuzu-emu/yuzu","homepage":"","size":18159,"stargazers_count":4352,"watchers_count":4352,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":204,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":204,"open_issues":17,"watchers":4352,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/380"},"html":{"href":"https://github.com/yuzu-emu/yuzu/pull/380"},"issue":{"href":"https://api.github.com/repos/yuzu-emu/yuzu/issues/380"},"comments":{"href":"https://api.github.com/repos/yuzu-emu/yuzu/issues/380/comments"},"review_comments":{"href":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/380/comments"},"review_comment":{"href":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/380/commits"},"statuses":{"href":"https://api.github.com/repos/yuzu-emu/yuzu/statuses/df669bc540d0ffec4afd298fdeb7767c3a4ea242"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Hexagon12"}}