{"action":"created","comment":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/216898875","pull_request_review_id":154486475,"id":216898875,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjg5ODg3NQ==","diff_hunk":"@@ -58,8 +58,8 @@\n                if (clusteringConfiguration.cacheMode().needsStateTransfer()) {\n                   int segments = clusteringConfiguration.hash().numSegments();\n                   Supplier mapSupplier = () -> {\n-                     OffHeapEntryFactory entryFactory = componentRegistry.getComponent(OffHeapEntryFactory.class);\n-                     OffHeapMemoryAllocator memoryAllocator = componentRegistry.getComponent(OffHeapMemoryAllocator.class);\n+                     OffHeapEntryFactory entryFactory = componentRegistry.getOrCreateComponent(OffHeapEntryFactory.class);\n+                     OffHeapMemoryAllocator memoryAllocator = componentRegistry.getOrCreateComponent(OffHeapMemoryAllocator.class);","path":"core/src/main/java/org/infinispan/factories/DataContainerFactory.java","position":7,"original_position":7,"commit_id":"4e2c734e1e86a353aca1940917a112e651038ecc","original_commit_id":"4e2c734e1e86a353aca1940917a112e651038ecc","user":{"login":"danberindei","id":504907,"node_id":"MDQ6VXNlcjUwNDkwNw==","avatar_url":"https://avatars2.githubusercontent.com/u/504907?v=4","gravatar_id":"","url":"https://api.github.com/users/danberindei","html_url":"https://github.com/danberindei","followers_url":"https://api.github.com/users/danberindei/followers","following_url":"https://api.github.com/users/danberindei/following{/other_user}","gists_url":"https://api.github.com/users/danberindei/gists{/gist_id}","starred_url":"https://api.github.com/users/danberindei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danberindei/subscriptions","organizations_url":"https://api.github.com/users/danberindei/orgs","repos_url":"https://api.github.com/users/danberindei/repos","events_url":"https://api.github.com/users/danberindei/events{/privacy}","received_events_url":"https://api.github.com/users/danberindei/received_events","type":"User","site_admin":false},"body":"I must say I don't like `getOrCreateComponent` here, IMO the logic in the supplier can be implemented in `DefaultSegmentedDataContainer` directly.","created_at":"2018-09-12T05:14:39Z","updated_at":"2018-09-12T05:14:39Z","html_url":"https://github.com/infinispan/infinispan/pull/6249#discussion_r216898875","pull_request_url":"https://api.github.com/repos/infinispan/infinispan/pulls/6249","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/216898875"},"html":{"href":"https://github.com/infinispan/infinispan/pull/6249#discussion_r216898875"},"pull_request":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/6249"}}},"pull_request":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/6249","id":214739800,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NzM5ODAw","html_url":"https://github.com/infinispan/infinispan/pull/6249","diff_url":"https://github.com/infinispan/infinispan/pull/6249.diff","patch_url":"https://github.com/infinispan/infinispan/pull/6249.patch","issue_url":"https://api.github.com/repos/infinispan/infinispan/issues/6249","number":6249,"state":"open","locked":false,"title":"ISPN-9505 Off-heap data container puts all the entries in a single","user":{"login":"wburns","id":648175,"node_id":"MDQ6VXNlcjY0ODE3NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/648175?v=4","gravatar_id":"","url":"https://api.github.com/users/wburns","html_url":"https://github.com/wburns","followers_url":"https://api.github.com/users/wburns/followers","following_url":"https://api.github.com/users/wburns/following{/other_user}","gists_url":"https://api.github.com/users/wburns/gists{/gist_id}","starred_url":"https://api.github.com/users/wburns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wburns/subscriptions","organizations_url":"https://api.github.com/users/wburns/orgs","repos_url":"https://api.github.com/users/wburns/repos","events_url":"https://api.github.com/users/wburns/events{/privacy}","received_events_url":"https://api.github.com/users/wburns/received_events","type":"User","site_admin":false},"body":"bucket\r\n\r\n* Make sure buckets are address count not scaled to CPU\r\n\r\nhttps://issues.jboss.org/browse/ISPN-9505","created_at":"2018-09-11T19:26:07Z","updated_at":"2018-09-12T05:14:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da4e70d9f18247b3dbe8c18d28165f14b2948cb9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/infinispan/infinispan/milestones/107","html_url":"https://github.com/infinispan/infinispan/milestone/107","labels_url":"https://api.github.com/repos/infinispan/infinispan/milestones/107/labels","id":3438164,"node_id":"MDk6TWlsZXN0b25lMzQzODE2NA==","number":107,"title":"9.4.0.Final","description":"","creator":{"login":"tristantarrant","id":392478,"node_id":"MDQ6VXNlcjM5MjQ3OA==","avatar_url":"https://avatars0.githubusercontent.com/u/392478?v=4","gravatar_id":"","url":"https://api.github.com/users/tristantarrant","html_url":"https://github.com/tristantarrant","followers_url":"https://api.github.com/users/tristantarrant/followers","following_url":"https://api.github.com/users/tristantarrant/following{/other_user}","gists_url":"https://api.github.com/users/tristantarrant/gists{/gist_id}","starred_url":"https://api.github.com/users/tristantarrant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tristantarrant/subscriptions","organizations_url":"https://api.github.com/users/tristantarrant/orgs","repos_url":"https://api.github.com/users/tristantarrant/repos","events_url":"https://api.github.com/users/tristantarrant/events{/privacy}","received_events_url":"https://api.github.com/users/tristantarrant/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":10,"state":"open","created_at":"2018-06-20T09:09:02Z","updated_at":"2018-09-11T19:26:07Z","due_on":"2018-09-14T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/infinispan/infinispan/pulls/6249/commits","review_comments_url":"https://api.github.com/repos/infinispan/infinispan/pulls/6249/comments","review_comment_url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/infinispan/infinispan/issues/6249/comments","statuses_url":"https://api.github.com/repos/infinispan/infinispan/statuses/4e2c734e1e86a353aca1940917a112e651038ecc","head":{"label":"wburns:ISPN-9505_local_bucket","ref":"ISPN-9505_local_bucket","sha":"4e2c734e1e86a353aca1940917a112e651038ecc","user":{"login":"wburns","id":648175,"node_id":"MDQ6VXNlcjY0ODE3NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/648175?v=4","gravatar_id":"","url":"https://api.github.com/users/wburns","html_url":"https://github.com/wburns","followers_url":"https://api.github.com/users/wburns/followers","following_url":"https://api.github.com/users/wburns/following{/other_user}","gists_url":"https://api.github.com/users/wburns/gists{/gist_id}","starred_url":"https://api.github.com/users/wburns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wburns/subscriptions","organizations_url":"https://api.github.com/users/wburns/orgs","repos_url":"https://api.github.com/users/wburns/repos","events_url":"https://api.github.com/users/wburns/events{/privacy}","received_events_url":"https://api.github.com/users/wburns/received_events","type":"User","site_admin":false},"repo":{"id":2681545,"node_id":"MDEwOlJlcG9zaXRvcnkyNjgxNTQ1","name":"infinispan","full_name":"wburns/infinispan","owner":{"login":"wburns","id":648175,"node_id":"MDQ6VXNlcjY0ODE3NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/648175?v=4","gravatar_id":"","url":"https://api.github.com/users/wburns","html_url":"https://github.com/wburns","followers_url":"https://api.github.com/users/wburns/followers","following_url":"https://api.github.com/users/wburns/following{/other_user}","gists_url":"https://api.github.com/users/wburns/gists{/gist_id}","starred_url":"https://api.github.com/users/wburns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wburns/subscriptions","organizations_url":"https://api.github.com/users/wburns/orgs","repos_url":"https://api.github.com/users/wburns/repos","events_url":"https://api.github.com/users/wburns/events{/privacy}","received_events_url":"https://api.github.com/users/wburns/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wburns/infinispan","description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","fork":true,"url":"https://api.github.com/repos/wburns/infinispan","forks_url":"https://api.github.com/repos/wburns/infinispan/forks","keys_url":"https://api.github.com/repos/wburns/infinispan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wburns/infinispan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wburns/infinispan/teams","hooks_url":"https://api.github.com/repos/wburns/infinispan/hooks","issue_events_url":"https://api.github.com/repos/wburns/infinispan/issues/events{/number}","events_url":"https://api.github.com/repos/wburns/infinispan/events","assignees_url":"https://api.github.com/repos/wburns/infinispan/assignees{/user}","branches_url":"https://api.github.com/repos/wburns/infinispan/branches{/branch}","tags_url":"https://api.github.com/repos/wburns/infinispan/tags","blobs_url":"https://api.github.com/repos/wburns/infinispan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wburns/infinispan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wburns/infinispan/git/refs{/sha}","trees_url":"https://api.github.com/repos/wburns/infinispan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wburns/infinispan/statuses/{sha}","languages_url":"https://api.github.com/repos/wburns/infinispan/languages","stargazers_url":"https://api.github.com/repos/wburns/infinispan/stargazers","contributors_url":"https://api.github.com/repos/wburns/infinispan/contributors","subscribers_url":"https://api.github.com/repos/wburns/infinispan/subscribers","subscription_url":"https://api.github.com/repos/wburns/infinispan/subscription","commits_url":"https://api.github.com/repos/wburns/infinispan/commits{/sha}","git_commits_url":"https://api.github.com/repos/wburns/infinispan/git/commits{/sha}","comments_url":"https://api.github.com/repos/wburns/infinispan/comments{/number}","issue_comment_url":"https://api.github.com/repos/wburns/infinispan/issues/comments{/number}","contents_url":"https://api.github.com/repos/wburns/infinispan/contents/{+path}","compare_url":"https://api.github.com/repos/wburns/infinispan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wburns/infinispan/merges","archive_url":"https://api.github.com/repos/wburns/infinispan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wburns/infinispan/downloads","issues_url":"https://api.github.com/repos/wburns/infinispan/issues{/number}","pulls_url":"https://api.github.com/repos/wburns/infinispan/pulls{/number}","milestones_url":"https://api.github.com/repos/wburns/infinispan/milestones{/number}","notifications_url":"https://api.github.com/repos/wburns/infinispan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wburns/infinispan/labels{/name}","releases_url":"https://api.github.com/repos/wburns/infinispan/releases{/id}","deployments_url":"https://api.github.com/repos/wburns/infinispan/deployments","created_at":"2011-10-31T15:31:04Z","updated_at":"2018-09-11T15:05:24Z","pushed_at":"2018-09-11T21:14:46Z","git_url":"git://github.com/wburns/infinispan.git","ssh_url":"git@github.com:wburns/infinispan.git","clone_url":"https://github.com/wburns/infinispan.git","svn_url":"https://github.com/wburns/infinispan","homepage":"http://www.infinispan.org","size":104619,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"infinispan:master","ref":"master","sha":"72c2df0ec78b949a4a7c2078c33b37c4bdcc0fc5","user":{"login":"infinispan","id":458093,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1ODA5Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/458093?v=4","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"repo":{"id":1050944,"node_id":"MDEwOlJlcG9zaXRvcnkxMDUwOTQ0","name":"infinispan","full_name":"infinispan/infinispan","owner":{"login":"infinispan","id":458093,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1ODA5Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/458093?v=4","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/infinispan/infinispan","description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","fork":false,"url":"https://api.github.com/repos/infinispan/infinispan","forks_url":"https://api.github.com/repos/infinispan/infinispan/forks","keys_url":"https://api.github.com/repos/infinispan/infinispan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/infinispan/infinispan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/infinispan/infinispan/teams","hooks_url":"https://api.github.com/repos/infinispan/infinispan/hooks","issue_events_url":"https://api.github.com/repos/infinispan/infinispan/issues/events{/number}","events_url":"https://api.github.com/repos/infinispan/infinispan/events","assignees_url":"https://api.github.com/repos/infinispan/infinispan/assignees{/user}","branches_url":"https://api.github.com/repos/infinispan/infinispan/branches{/branch}","tags_url":"https://api.github.com/repos/infinispan/infinispan/tags","blobs_url":"https://api.github.com/repos/infinispan/infinispan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/infinispan/infinispan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/infinispan/infinispan/git/refs{/sha}","trees_url":"https://api.github.com/repos/infinispan/infinispan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/infinispan/infinispan/statuses/{sha}","languages_url":"https://api.github.com/repos/infinispan/infinispan/languages","stargazers_url":"https://api.github.com/repos/infinispan/infinispan/stargazers","contributors_url":"https://api.github.com/repos/infinispan/infinispan/contributors","subscribers_url":"https://api.github.com/repos/infinispan/infinispan/subscribers","subscription_url":"https://api.github.com/repos/infinispan/infinispan/subscription","commits_url":"https://api.github.com/repos/infinispan/infinispan/commits{/sha}","git_commits_url":"https://api.github.com/repos/infinispan/infinispan/git/commits{/sha}","comments_url":"https://api.github.com/repos/infinispan/infinispan/comments{/number}","issue_comment_url":"https://api.github.com/repos/infinispan/infinispan/issues/comments{/number}","contents_url":"https://api.github.com/repos/infinispan/infinispan/contents/{+path}","compare_url":"https://api.github.com/repos/infinispan/infinispan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/infinispan/infinispan/merges","archive_url":"https://api.github.com/repos/infinispan/infinispan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/infinispan/infinispan/downloads","issues_url":"https://api.github.com/repos/infinispan/infinispan/issues{/number}","pulls_url":"https://api.github.com/repos/infinispan/infinispan/pulls{/number}","milestones_url":"https://api.github.com/repos/infinispan/infinispan/milestones{/number}","notifications_url":"https://api.github.com/repos/infinispan/infinispan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/infinispan/infinispan/labels{/name}","releases_url":"https://api.github.com/repos/infinispan/infinispan/releases{/id}","deployments_url":"https://api.github.com/repos/infinispan/infinispan/deployments","created_at":"2010-11-04T12:33:19Z","updated_at":"2018-09-12T01:36:29Z","pushed_at":"2018-09-11T21:14:48Z","git_url":"git://github.com/infinispan/infinispan.git","ssh_url":"git@github.com:infinispan/infinispan.git","clone_url":"https://github.com/infinispan/infinispan.git","svn_url":"https://github.com/infinispan/infinispan","homepage":"http://www.infinispan.org","size":112085,"stargazers_count":679,"watchers_count":679,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":449,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":449,"open_issues":19,"watchers":679,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/6249"},"html":{"href":"https://github.com/infinispan/infinispan/pull/6249"},"issue":{"href":"https://api.github.com/repos/infinispan/infinispan/issues/6249"},"comments":{"href":"https://api.github.com/repos/infinispan/infinispan/issues/6249/comments"},"review_comments":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/6249/comments"},"review_comment":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/6249/commits"},"statuses":{"href":"https://api.github.com/repos/infinispan/infinispan/statuses/4e2c734e1e86a353aca1940917a112e651038ecc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"danberindei"}}