{"action":"created","issue":{"url":"https://api.github.com/repos/certbot/certbot/issues/6578","repository_url":"https://api.github.com/repos/certbot/certbot","labels_url":"https://api.github.com/repos/certbot/certbot/issues/6578/labels{/name}","comments_url":"https://api.github.com/repos/certbot/certbot/issues/6578/comments","events_url":"https://api.github.com/repos/certbot/certbot/issues/6578/events","html_url":"https://github.com/certbot/certbot/pull/6578","id":389452549,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NDM5NTEw","number":6578,"title":"[Unix] Create a framework for certbot integration tests: PART 1","user":{"login":"adferrand","id":9728851,"node_id":"MDQ6VXNlcjk3Mjg4NTE=","avatar_url":"https://avatars0.githubusercontent.com/u/9728851?v=4","gravatar_id":"","url":"https://api.github.com/users/adferrand","html_url":"https://github.com/adferrand","followers_url":"https://api.github.com/users/adferrand/followers","following_url":"https://api.github.com/users/adferrand/following{/other_user}","gists_url":"https://api.github.com/users/adferrand/gists{/gist_id}","starred_url":"https://api.github.com/users/adferrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adferrand/subscriptions","organizations_url":"https://api.github.com/users/adferrand/orgs","repos_url":"https://api.github.com/users/adferrand/repos","events_url":"https://api.github.com/users/adferrand/events{/privacy}","received_events_url":"https://api.github.com/users/adferrand/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-12-10T19:31:33Z","updated_at":"2018-12-13T09:50:16Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/certbot/certbot/pulls/6578","html_url":"https://github.com/certbot/certbot/pull/6578","diff_url":"https://github.com/certbot/certbot/pull/6578.diff","patch_url":"https://github.com/certbot/certbot/pull/6578.patch"},"body":"Following discussions in #6541, I splitted my PR into several parts to make it reviewable. \r\n\r\nThis is part 1, and concerns the paralleled setup of several acme server instances, in order to drastically speed up the integration tests. This is done by orchestrating the pytest execution with an ad-hoc cli, that will make the work before passing the distributed configuration of acme servers to pytest and launch its execution.\r\n\r\nThe code is functional, in a sense where all the setup is done, and only dummy tests without any fixtures are executed. This will come in the future parts. \r\n\r\nIntegrations tests can be executed using the tox target env `integration`. Customizations can be done using directly the cli `launch-integration-tests.py`: it uses argparse to process arguments, and so contains a complete online help. \r\n\r\ncc @ohemorange @bmw \r\n"},"comment":{"url":"https://api.github.com/repos/certbot/certbot/issues/comments/446906973","html_url":"https://github.com/certbot/certbot/pull/6578#issuecomment-446906973","issue_url":"https://api.github.com/repos/certbot/certbot/issues/6578","id":446906973,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjkwNjk3Mw==","user":{"login":"adferrand","id":9728851,"node_id":"MDQ6VXNlcjk3Mjg4NTE=","avatar_url":"https://avatars0.githubusercontent.com/u/9728851?v=4","gravatar_id":"","url":"https://api.github.com/users/adferrand","html_url":"https://github.com/adferrand","followers_url":"https://api.github.com/users/adferrand/followers","following_url":"https://api.github.com/users/adferrand/following{/other_user}","gists_url":"https://api.github.com/users/adferrand/gists{/gist_id}","starred_url":"https://api.github.com/users/adferrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adferrand/subscriptions","organizations_url":"https://api.github.com/users/adferrand/orgs","repos_url":"https://api.github.com/users/adferrand/repos","events_url":"https://api.github.com/users/adferrand/events{/privacy}","received_events_url":"https://api.github.com/users/adferrand/received_events","type":"User","site_admin":false},"created_at":"2018-12-13T09:50:16Z","updated_at":"2018-12-13T09:50:16Z","author_association":"COLLABORATOR","body":"That said, about the specific needs of improving the current integration tests executed continuously, you need to consider that this work is not a refactoring, but a full new piece of software. As so, bad design decisions will be made, inevitably, because of future needs that no one is aware of a this time.\r\n\r\nSo you will need to accept, for a reasonable amount of course, to leak theses unknown bad design decisions into the source code, and trust me about the fact I will stay committed to make the necessary modifications in future PRs. To sum up, yes, this code will not be perfect, and will contain questionable design decisions, but it will improve over the time."}}
{"actor":{"display_login":"adferrand"}}