{"action":"created","comment":{"url":"https://api.github.com/repos/azatoth/twinkle/pulls/comments/242306249","pull_request_review_id":185786115,"id":242306249,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjMwNjI0OQ==","diff_hunk":"@@ -60,28 +60,30 @@ Twinkle.xfd.callback = function twinklexfdCallback() {\n \t\t\ttooltip: 'When activated, a default choice is made, based on what namespace you are in. This default should be the most appropriate',\n \t\t\tevent: Twinkle.xfd.callback.change_category\n \t\t} );\n+\tvar namespace = mw.config.get('wgNamespaceNumber');\n+\t\n \tcategories.append( {\n \t\t\ttype: 'option',\n \t\t\tlabel: 'AfD (Articles for deletion)',\n-\t\t\tselected: mw.config.get('wgNamespaceNumber') === 0,  // Main namespace\n+\t\t\tselected: namespace === 0,  // Main namespace\n \t\t\tvalue: 'afd'\n \t\t} );\n \tcategories.append( {\n \t\t\ttype: 'option',\n \t\t\tlabel: 'TfD (Templates for discussion)',\n-\t\t\tselected: [ 10, 828 ].indexOf( mw.config.get('wgNamespaceNumber') ) !== -1,  // Template and module namespaces\n+\t\t\tselected: [ 10, 828 ].indexOf(namespace) !== -1,  // Template and module namespaces\n \t\t\tvalue: 'tfd'\n \t\t} );\n \tcategories.append( {\n \t\t\ttype: 'option',\n \t\t\tlabel: 'FfD (Files for discussion)',\n-\t\t\tselected: mw.config.get('wgNamespaceNumber') === 6,  // File namespace\n+\t\t\tselected: namespace === 6,  // File namespace\n \t\t\tvalue: 'ffd'\n \t\t} );\n \tcategories.append( {\n \t\t\ttype: 'option',\n \t\t\tlabel: 'CfD (Categories for discussion)',\n-\t\t\tselected: mw.config.get('wgNamespaceNumber') === 14,  // Category namespace\n+\t\t\tselected: namespace === 14,","path":"modules/twinklexfd.js","position":31,"original_position":31,"commit_id":"822c43356b28a529ff8874342d908d72338735cf","original_commit_id":"822c43356b28a529ff8874342d908d72338735cf","user":{"login":"Amorymeltzer","id":480724,"node_id":"MDQ6VXNlcjQ4MDcyNA==","avatar_url":"https://avatars0.githubusercontent.com/u/480724?v=4","gravatar_id":"","url":"https://api.github.com/users/Amorymeltzer","html_url":"https://github.com/Amorymeltzer","followers_url":"https://api.github.com/users/Amorymeltzer/followers","following_url":"https://api.github.com/users/Amorymeltzer/following{/other_user}","gists_url":"https://api.github.com/users/Amorymeltzer/gists{/gist_id}","starred_url":"https://api.github.com/users/Amorymeltzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Amorymeltzer/subscriptions","organizations_url":"https://api.github.com/users/Amorymeltzer/orgs","repos_url":"https://api.github.com/users/Amorymeltzer/repos","events_url":"https://api.github.com/users/Amorymeltzer/events{/privacy}","received_events_url":"https://api.github.com/users/Amorymeltzer/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n\t\t\tselected: namespace === 14,  // Category namespace\r\n```","created_at":"2018-12-17T20:34:03Z","updated_at":"2018-12-17T20:34:03Z","html_url":"https://github.com/azatoth/twinkle/pull/459#discussion_r242306249","pull_request_url":"https://api.github.com/repos/azatoth/twinkle/pulls/459","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/azatoth/twinkle/pulls/comments/242306249"},"html":{"href":"https://github.com/azatoth/twinkle/pull/459#discussion_r242306249"},"pull_request":{"href":"https://api.github.com/repos/azatoth/twinkle/pulls/459"}}},"pull_request":{"url":"https://api.github.com/repos/azatoth/twinkle/pulls/459","id":229968476,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5OTY4NDc2","html_url":"https://github.com/azatoth/twinkle/pull/459","diff_url":"https://github.com/azatoth/twinkle/pull/459.diff","patch_url":"https://github.com/azatoth/twinkle/pull/459.patch","issue_url":"https://api.github.com/repos/azatoth/twinkle/issues/459","number":459,"state":"open","locked":false,"title":"xfd: automate correct venue selection for userbox templates ","user":{"login":"siddharthvp","id":31818903,"node_id":"MDQ6VXNlcjMxODE4OTAz","avatar_url":"https://avatars1.githubusercontent.com/u/31818903?v=4","gravatar_id":"","url":"https://api.github.com/users/siddharthvp","html_url":"https://github.com/siddharthvp","followers_url":"https://api.github.com/users/siddharthvp/followers","following_url":"https://api.github.com/users/siddharthvp/following{/other_user}","gists_url":"https://api.github.com/users/siddharthvp/gists{/gist_id}","starred_url":"https://api.github.com/users/siddharthvp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siddharthvp/subscriptions","organizations_url":"https://api.github.com/users/siddharthvp/orgs","repos_url":"https://api.github.com/users/siddharthvp/repos","events_url":"https://api.github.com/users/siddharthvp/events{/privacy}","received_events_url":"https://api.github.com/users/siddharthvp/received_events","type":"User","site_admin":false},"body":"Per policy, the xfd venue for stub templates (\"Template:xxx-stub\") is CfD, and for userboxes (\"Template:User xxx\") is MfD. I updated the automatic xfd venue selection process to accommodate these special cases.","created_at":"2018-11-11T18:16:48Z","updated_at":"2018-12-17T20:34:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"85fd1eb3c137409ada4d468bba4a1ac7fd7799be","assignee":{"login":"Amorymeltzer","id":480724,"node_id":"MDQ6VXNlcjQ4MDcyNA==","avatar_url":"https://avatars0.githubusercontent.com/u/480724?v=4","gravatar_id":"","url":"https://api.github.com/users/Amorymeltzer","html_url":"https://github.com/Amorymeltzer","followers_url":"https://api.github.com/users/Amorymeltzer/followers","following_url":"https://api.github.com/users/Amorymeltzer/following{/other_user}","gists_url":"https://api.github.com/users/Amorymeltzer/gists{/gist_id}","starred_url":"https://api.github.com/users/Amorymeltzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Amorymeltzer/subscriptions","organizations_url":"https://api.github.com/users/Amorymeltzer/orgs","repos_url":"https://api.github.com/users/Amorymeltzer/repos","events_url":"https://api.github.com/users/Amorymeltzer/events{/privacy}","received_events_url":"https://api.github.com/users/Amorymeltzer/received_events","type":"User","site_admin":false},"assignees":[{"login":"Amorymeltzer","id":480724,"node_id":"MDQ6VXNlcjQ4MDcyNA==","avatar_url":"https://avatars0.githubusercontent.com/u/480724?v=4","gravatar_id":"","url":"https://api.github.com/users/Amorymeltzer","html_url":"https://github.com/Amorymeltzer","followers_url":"https://api.github.com/users/Amorymeltzer/followers","following_url":"https://api.github.com/users/Amorymeltzer/following{/other_user}","gists_url":"https://api.github.com/users/Amorymeltzer/gists{/gist_id}","starred_url":"https://api.github.com/users/Amorymeltzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Amorymeltzer/subscriptions","organizations_url":"https://api.github.com/users/Amorymeltzer/orgs","repos_url":"https://api.github.com/users/Amorymeltzer/repos","events_url":"https://api.github.com/users/Amorymeltzer/events{/privacy}","received_events_url":"https://api.github.com/users/Amorymeltzer/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/azatoth/twinkle/pulls/459/commits","review_comments_url":"https://api.github.com/repos/azatoth/twinkle/pulls/459/comments","review_comment_url":"https://api.github.com/repos/azatoth/twinkle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/azatoth/twinkle/issues/459/comments","statuses_url":"https://api.github.com/repos/azatoth/twinkle/statuses/822c43356b28a529ff8874342d908d72338735cf","head":{"label":"siddharthvp:xfd","ref":"xfd","sha":"822c43356b28a529ff8874342d908d72338735cf","user":{"login":"siddharthvp","id":31818903,"node_id":"MDQ6VXNlcjMxODE4OTAz","avatar_url":"https://avatars1.githubusercontent.com/u/31818903?v=4","gravatar_id":"","url":"https://api.github.com/users/siddharthvp","html_url":"https://github.com/siddharthvp","followers_url":"https://api.github.com/users/siddharthvp/followers","following_url":"https://api.github.com/users/siddharthvp/following{/other_user}","gists_url":"https://api.github.com/users/siddharthvp/gists{/gist_id}","starred_url":"https://api.github.com/users/siddharthvp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siddharthvp/subscriptions","organizations_url":"https://api.github.com/users/siddharthvp/orgs","repos_url":"https://api.github.com/users/siddharthvp/repos","events_url":"https://api.github.com/users/siddharthvp/events{/privacy}","received_events_url":"https://api.github.com/users/siddharthvp/received_events","type":"User","site_admin":false},"repo":{"id":148209418,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgyMDk0MTg=","name":"twinkle","full_name":"siddharthvp/twinkle","private":false,"owner":{"login":"siddharthvp","id":31818903,"node_id":"MDQ6VXNlcjMxODE4OTAz","avatar_url":"https://avatars1.githubusercontent.com/u/31818903?v=4","gravatar_id":"","url":"https://api.github.com/users/siddharthvp","html_url":"https://github.com/siddharthvp","followers_url":"https://api.github.com/users/siddharthvp/followers","following_url":"https://api.github.com/users/siddharthvp/following{/other_user}","gists_url":"https://api.github.com/users/siddharthvp/gists{/gist_id}","starred_url":"https://api.github.com/users/siddharthvp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siddharthvp/subscriptions","organizations_url":"https://api.github.com/users/siddharthvp/orgs","repos_url":"https://api.github.com/users/siddharthvp/repos","events_url":"https://api.github.com/users/siddharthvp/events{/privacy}","received_events_url":"https://api.github.com/users/siddharthvp/received_events","type":"User","site_admin":false},"html_url":"https://github.com/siddharthvp/twinkle","description":"The wikipedia twinkle javascript helper","fork":true,"url":"https://api.github.com/repos/siddharthvp/twinkle","forks_url":"https://api.github.com/repos/siddharthvp/twinkle/forks","keys_url":"https://api.github.com/repos/siddharthvp/twinkle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/siddharthvp/twinkle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/siddharthvp/twinkle/teams","hooks_url":"https://api.github.com/repos/siddharthvp/twinkle/hooks","issue_events_url":"https://api.github.com/repos/siddharthvp/twinkle/issues/events{/number}","events_url":"https://api.github.com/repos/siddharthvp/twinkle/events","assignees_url":"https://api.github.com/repos/siddharthvp/twinkle/assignees{/user}","branches_url":"https://api.github.com/repos/siddharthvp/twinkle/branches{/branch}","tags_url":"https://api.github.com/repos/siddharthvp/twinkle/tags","blobs_url":"https://api.github.com/repos/siddharthvp/twinkle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/siddharthvp/twinkle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/siddharthvp/twinkle/git/refs{/sha}","trees_url":"https://api.github.com/repos/siddharthvp/twinkle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/siddharthvp/twinkle/statuses/{sha}","languages_url":"https://api.github.com/repos/siddharthvp/twinkle/languages","stargazers_url":"https://api.github.com/repos/siddharthvp/twinkle/stargazers","contributors_url":"https://api.github.com/repos/siddharthvp/twinkle/contributors","subscribers_url":"https://api.github.com/repos/siddharthvp/twinkle/subscribers","subscription_url":"https://api.github.com/repos/siddharthvp/twinkle/subscription","commits_url":"https://api.github.com/repos/siddharthvp/twinkle/commits{/sha}","git_commits_url":"https://api.github.com/repos/siddharthvp/twinkle/git/commits{/sha}","comments_url":"https://api.github.com/repos/siddharthvp/twinkle/comments{/number}","issue_comment_url":"https://api.github.com/repos/siddharthvp/twinkle/issues/comments{/number}","contents_url":"https://api.github.com/repos/siddharthvp/twinkle/contents/{+path}","compare_url":"https://api.github.com/repos/siddharthvp/twinkle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/siddharthvp/twinkle/merges","archive_url":"https://api.github.com/repos/siddharthvp/twinkle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/siddharthvp/twinkle/downloads","issues_url":"https://api.github.com/repos/siddharthvp/twinkle/issues{/number}","pulls_url":"https://api.github.com/repos/siddharthvp/twinkle/pulls{/number}","milestones_url":"https://api.github.com/repos/siddharthvp/twinkle/milestones{/number}","notifications_url":"https://api.github.com/repos/siddharthvp/twinkle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/siddharthvp/twinkle/labels{/name}","releases_url":"https://api.github.com/repos/siddharthvp/twinkle/releases{/id}","deployments_url":"https://api.github.com/repos/siddharthvp/twinkle/deployments","created_at":"2018-09-10T19:41:25Z","updated_at":"2018-11-15T15:42:16Z","pushed_at":"2018-12-17T09:46:27Z","git_url":"git://github.com/siddharthvp/twinkle.git","ssh_url":"git@github.com:siddharthvp/twinkle.git","clone_url":"https://github.com/siddharthvp/twinkle.git","svn_url":"https://github.com/siddharthvp/twinkle","homepage":"http://en.wikipedia.org/wiki/Wikipedia:Twinkle","size":3034,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"azatoth:master","ref":"master","sha":"71d17d0f170dcafc8605caafe16990eef9881b1f","user":{"login":"azatoth","id":146477,"node_id":"MDQ6VXNlcjE0NjQ3Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/146477?v=4","gravatar_id":"","url":"https://api.github.com/users/azatoth","html_url":"https://github.com/azatoth","followers_url":"https://api.github.com/users/azatoth/followers","following_url":"https://api.github.com/users/azatoth/following{/other_user}","gists_url":"https://api.github.com/users/azatoth/gists{/gist_id}","starred_url":"https://api.github.com/users/azatoth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azatoth/subscriptions","organizations_url":"https://api.github.com/users/azatoth/orgs","repos_url":"https://api.github.com/users/azatoth/repos","events_url":"https://api.github.com/users/azatoth/events{/privacy}","received_events_url":"https://api.github.com/users/azatoth/received_events","type":"User","site_admin":false},"repo":{"id":1444509,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ0NTA5","name":"twinkle","full_name":"azatoth/twinkle","private":false,"owner":{"login":"azatoth","id":146477,"node_id":"MDQ6VXNlcjE0NjQ3Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/146477?v=4","gravatar_id":"","url":"https://api.github.com/users/azatoth","html_url":"https://github.com/azatoth","followers_url":"https://api.github.com/users/azatoth/followers","following_url":"https://api.github.com/users/azatoth/following{/other_user}","gists_url":"https://api.github.com/users/azatoth/gists{/gist_id}","starred_url":"https://api.github.com/users/azatoth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azatoth/subscriptions","organizations_url":"https://api.github.com/users/azatoth/orgs","repos_url":"https://api.github.com/users/azatoth/repos","events_url":"https://api.github.com/users/azatoth/events{/privacy}","received_events_url":"https://api.github.com/users/azatoth/received_events","type":"User","site_admin":false},"html_url":"https://github.com/azatoth/twinkle","description":"The wikipedia twinkle javascript helper","fork":false,"url":"https://api.github.com/repos/azatoth/twinkle","forks_url":"https://api.github.com/repos/azatoth/twinkle/forks","keys_url":"https://api.github.com/repos/azatoth/twinkle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/azatoth/twinkle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/azatoth/twinkle/teams","hooks_url":"https://api.github.com/repos/azatoth/twinkle/hooks","issue_events_url":"https://api.github.com/repos/azatoth/twinkle/issues/events{/number}","events_url":"https://api.github.com/repos/azatoth/twinkle/events","assignees_url":"https://api.github.com/repos/azatoth/twinkle/assignees{/user}","branches_url":"https://api.github.com/repos/azatoth/twinkle/branches{/branch}","tags_url":"https://api.github.com/repos/azatoth/twinkle/tags","blobs_url":"https://api.github.com/repos/azatoth/twinkle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/azatoth/twinkle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/azatoth/twinkle/git/refs{/sha}","trees_url":"https://api.github.com/repos/azatoth/twinkle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/azatoth/twinkle/statuses/{sha}","languages_url":"https://api.github.com/repos/azatoth/twinkle/languages","stargazers_url":"https://api.github.com/repos/azatoth/twinkle/stargazers","contributors_url":"https://api.github.com/repos/azatoth/twinkle/contributors","subscribers_url":"https://api.github.com/repos/azatoth/twinkle/subscribers","subscription_url":"https://api.github.com/repos/azatoth/twinkle/subscription","commits_url":"https://api.github.com/repos/azatoth/twinkle/commits{/sha}","git_commits_url":"https://api.github.com/repos/azatoth/twinkle/git/commits{/sha}","comments_url":"https://api.github.com/repos/azatoth/twinkle/comments{/number}","issue_comment_url":"https://api.github.com/repos/azatoth/twinkle/issues/comments{/number}","contents_url":"https://api.github.com/repos/azatoth/twinkle/contents/{+path}","compare_url":"https://api.github.com/repos/azatoth/twinkle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/azatoth/twinkle/merges","archive_url":"https://api.github.com/repos/azatoth/twinkle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/azatoth/twinkle/downloads","issues_url":"https://api.github.com/repos/azatoth/twinkle/issues{/number}","pulls_url":"https://api.github.com/repos/azatoth/twinkle/pulls{/number}","milestones_url":"https://api.github.com/repos/azatoth/twinkle/milestones{/number}","notifications_url":"https://api.github.com/repos/azatoth/twinkle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/azatoth/twinkle/labels{/name}","releases_url":"https://api.github.com/repos/azatoth/twinkle/releases{/id}","deployments_url":"https://api.github.com/repos/azatoth/twinkle/deployments","created_at":"2011-03-05T21:51:07Z","updated_at":"2018-12-13T22:01:18Z","pushed_at":"2018-12-17T09:46:29Z","git_url":"git://github.com/azatoth/twinkle.git","ssh_url":"git@github.com:azatoth/twinkle.git","clone_url":"https://github.com/azatoth/twinkle.git","svn_url":"https://github.com/azatoth/twinkle","homepage":"http://en.wikipedia.org/wiki/Wikipedia:Twinkle","size":2991,"stargazers_count":81,"watchers_count":81,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":86,"mirror_url":null,"archived":false,"open_issues_count":109,"license":null,"forks":86,"open_issues":109,"watchers":81,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/azatoth/twinkle/pulls/459"},"html":{"href":"https://github.com/azatoth/twinkle/pull/459"},"issue":{"href":"https://api.github.com/repos/azatoth/twinkle/issues/459"},"comments":{"href":"https://api.github.com/repos/azatoth/twinkle/issues/459/comments"},"review_comments":{"href":"https://api.github.com/repos/azatoth/twinkle/pulls/459/comments"},"review_comment":{"href":"https://api.github.com/repos/azatoth/twinkle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/azatoth/twinkle/pulls/459/commits"},"statuses":{"href":"https://api.github.com/repos/azatoth/twinkle/statuses/822c43356b28a529ff8874342d908d72338735cf"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Amorymeltzer"}}