{"push_id":3096736028,"size":109,"distinct_size":0,"ref":"refs/heads/immut-desc","head":"5b6eeb155b1d1fa756dd9e1236b1a160ce01e811","before":"243c966d4461bfa082415d7001f899f92176f383","commits":[{"sha":"431b2d8ab521fb01039aa7717902b5e35b21336b","author":{"name":"Raphael 'kena' Poss","email":"ffa74aa72f5ed5e720c03212554d1e38d8a2905e@cockroachlabs.com"},"message":"scripts: add missing names to the release notes script\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/eriktrinh/cockroach/commits/431b2d8ab521fb01039aa7717902b5e35b21336b"},{"sha":"942b0f5e7a731e37816c64b313adf9b9d016d1cc","author":{"name":"Raphael 'kena' Poss","email":"ffa74aa72f5ed5e720c03212554d1e38d8a2905e@cockroachlabs.com"},"message":"scripts: update title capitalization in rn script tests\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/eriktrinh/cockroach/commits/942b0f5e7a731e37816c64b313adf9b9d016d1cc"},{"sha":"92a04a9ab58af297f3febfdde994c0b4a391a2d6","author":{"name":"Raphael 'kena' Poss","email":"ffa74aa72f5ed5e720c03212554d1e38d8a2905e@cockroachlabs.com"},"message":"scripts: enhance the release notes\n\nWith this patch, the release notes script learns how to exclude\nlisting release notes that are also present on a different range (e.g\nbranch) of commits.\n\nThis can be used to e.g. exclude all commits already on the first\nversion of a release branch (eg v2.1.0) when releasing an alpha (eg\nv2.2-alpha).\n\nUsage:\n\n```\n\npython3.6 scripts/release-notes.py \\\n    --from v2.2.0-alpha.00000000 --until <Candidate 2.2 SHA> \\\n    --exclude-from v2.2.0-alpha.00000000 --exclude-until v2.1.0\n```\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/eriktrinh/cockroach/commits/92a04a9ab58af297f3febfdde994c0b4a391a2d6"},{"sha":"cf73c7eb01caead33661fb82407c0aec2ab38394","author":{"name":"Raphael 'kena' Poss","email":"ffa74aa72f5ed5e720c03212554d1e38d8a2905e@cockroachlabs.com"},"message":"scripts: add copy/paste include in docker image section\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/eriktrinh/cockroach/commits/cf73c7eb01caead33661fb82407c0aec2ab38394"},{"sha":"26d1d9d9062bbcd7d781bb62b462a6f6cc60d655","author":{"name":"Raphael 'kena' Poss","email":"ffa74aa72f5ed5e720c03212554d1e38d8a2905e@cockroachlabs.com"},"message":"scripts: add an option --one-line to the release note script\n\nThis new option unwraps every release note in the output document.\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/eriktrinh/cockroach/commits/26d1d9d9062bbcd7d781bb62b462a6f6cc60d655"},{"sha":"8cb12f33de9a4bb38f3926b191e155514621853a","author":{"name":"Raphael 'kena' Poss","email":"ffa74aa72f5ed5e720c03212554d1e38d8a2905e@cockroachlabs.com"},"message":"scripts: additional improvements to the release notes script\n\n... as requested by @jseldess.\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/eriktrinh/cockroach/commits/8cb12f33de9a4bb38f3926b191e155514621853a"},{"sha":"abf2f4d88e187604503ce00787f87328dfe111d9","author":{"name":"Daniel Harrison","email":"3a2f0da2a0c450062f2df795b8346ad513a9734a@gmail.com"},"message":"changefeedccl: add metrics for performance debugging\n\nI've been running a branch with a bunch of extra metrics while debugging\nissue #32104. PR'ing the ones that have proven useful in case someone\nhas performance issues in the wild.\n\nRelease note (enterprise change): Added timeseries metrics for debugging\nCHANGEFEED performance issues.","distinct":false,"url":"https://api.github.com/repos/eriktrinh/cockroach/commits/abf2f4d88e187604503ce00787f87328dfe111d9"},{"sha":"f55db977d4bd14596491c21fa1ddc873600f0738","author":{"name":"Masha Schneider","email":"9a19271f701eeb7a4e6dffa6a484ec27a6e51a66@cockroachlabs.com"},"message":"roachprod: change AWS VPCs in us-west and eu-west\n\nThis change replaces existing subnets and security groups in the AWS\nconfiguration. It will now create nodes in a different VPCs for Europe\nand US West that have connection peering with each other. This will\nallow nodes across AWS regions to talk to each other without using the\ninternet.\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/eriktrinh/cockroach/commits/f55db977d4bd14596491c21fa1ddc873600f0738"},{"sha":"c9d51fd9e1eb3adf85ea731246392b7fe1830840","author":{"name":"Solon Gordon","email":"d094ebad5aad5ff73e8bc3d2d3255e9c9f2f189a@cockroachlabs.com"},"message":"distsql: preserve input ordering in joinreader\n\nThe optimizer presumes the lookup joins preserve the input ordering, but\nthis was not always the case in the implementation. Specifically in the\ncase of left joins, joinreader was emitting matched rows prior to\nunmatched rows. I fixed this by maintaining a map from input rows to\nlookup rows, which we now iterate over in order when emitting rows.\n\nFurthermore, I found that the distsql physical planner was failing to\npropagate physical properties for lookup join nodes, so an ordered\nsynchronizer was not being planned. I fixed this oversight and made the\n`planPhysicalProps` function more explicit so we don't make this mistake\nagain if new plan nodes are added in the future.\n\nRelease note (bug fix): Lookup joins now properly preserve ordering for\nouter joins. Prior to this fix, LEFT JOIN queries under specific\nconditions could produce results which did not respect the ORDER BY\nclause.\n\nFixes #32108","distinct":false,"url":"https://api.github.com/repos/eriktrinh/cockroach/commits/c9d51fd9e1eb3adf85ea731246392b7fe1830840"},{"sha":"a8b00ed9070dacbd5e3dc3bb1d13807cbcd7a8c3","author":{"name":"Ridwan Sharif","email":"6a050273963a48d1fca66b1e2cc60bdfaaa4660d@cockroachlabs.com"},"message":"storage: partially deflake TestSystemZoneConfigs\n\nI doubt this fixes #32511 completely, but this does address the\nsplits Andrei saw with the same test. With the scan interval\nbeing so low, there are about 20 scans, each of which with ~ 20\nreplicas per scan, and they hit ~ 10 queues. If the queues do a meta\nlookup or any other system lookup, it is possible that the QPS threshold\nfor splits is exceeded. To fix this, we turn off LBS in such tests\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/eriktrinh/cockroach/commits/a8b00ed9070dacbd5e3dc3bb1d13807cbcd7a8c3"},{"sha":"26d16bbafc70d60aadd8d0ce8d28ea9a4a82c3a0","author":{"name":"craig[bot]","email":"3a2c29237f73c7cf88424b80e427b1884f346b35@cockroachlabs.com"},"message":"Merge #32642\n\n32642: storage: partially deflake TestSystemZoneConfigs r=ridwanmsharif a=ridwanmsharif\n\nI doubt this fixes #32511 completely, but this does address the\r\nsplits Andrei saw with the same test. With the scan interval\r\nbeing so low, there are about 20 scans, each of which with ~ 20\r\nreplicas per scan, and they hit ~ 10 queues. If the queues do a meta\r\nlookup or any other system lookup, it is possible that the QPS threshold\r\nfor splits is exceeded. To fix this, we turn off LBS in such tests\r\n\r\nRelease note: None\n\nCo-authored-by: Ridwan Sharif <ridwan@cockroachlabs.com>","distinct":false,"url":"https://api.github.com/repos/eriktrinh/cockroach/commits/26d16bbafc70d60aadd8d0ce8d28ea9a4a82c3a0"},{"sha":"b9c8ee1c6e3d521d171a1bf5e1bc37384ae9178d","author":{"name":"craig[bot]","email":"3a2c29237f73c7cf88424b80e427b1884f346b35@cockroachlabs.com"},"message":"Merge #32603\n\n32603: sql: introduce ImmutableTableDescriptor struct r=eriktrinh a=eriktrinh\n\nCreate new ImmutableTableDescriptor struct which embeds a table schema\r\nand increase usage of it. The ImmutableTableDescriptor will also contain\r\nvarious data structures which will make the CRUD code path cleaner and\r\nalso improve lookup times for table schema elements (for example: col ID\r\nto ordinal index map, compute exprs, col ID/name to descriptors).\r\n\r\nRelated to #22275.\n\nCo-authored-by: Erik Trinh <erik@cockroachlabs.com>","distinct":false,"url":"https://api.github.com/repos/eriktrinh/cockroach/commits/b9c8ee1c6e3d521d171a1bf5e1bc37384ae9178d"},{"sha":"5fb5dcd41517d8de142a2aa0aae218ccc8052aef","author":{"name":"Matt Jibson","email":"314fe2776746d1cb8b8611e1e315a38b2017bbff@gmail.com"},"message":"pgwire: decode bpchar OIDs\n\nUsing cmd/generate-binary I was able to verify that bpchar has the same\nbinary and text encodings as text and varchar, and so my best guess is\nthat it's correct to add it to this list.\n\nNo test has been added because the existing tests only test the T_text\ndecoding. That is: T_varchar was already untested, so having T_bpchar\nalso be untested is ok for now. I've opened #32653 to track this.\n\nFixes #32625\n\nRelease note (sql change): allow bpchar OIDs from client connections.","distinct":false,"url":"https://api.github.com/repos/eriktrinh/cockroach/commits/5fb5dcd41517d8de142a2aa0aae218ccc8052aef"},{"sha":"b08715d912e6a104c190eb02986d9aae19f6fe4f","author":{"name":"Jordan Lewis","email":"d6a9c9ceebab0a60eea8692fb0aa04be2d19ee67@gmail.com"},"message":"distsql: bugfix to distsql planning of subqueries\n\nPreviously, some subqueries could crash the server when distributed,\nbecause of incorrect accounting for the PlanToStreamColMap final\nprojection on the result types of the subquery. Now, that final\nprojection is properly applied.\n\nRelease note (bug fix): prevent crash when running certain subqueries\nthat get planned in a distributed fashion.","distinct":false,"url":"https://api.github.com/repos/eriktrinh/cockroach/commits/b08715d912e6a104c190eb02986d9aae19f6fe4f"},{"sha":"9d9cfae045909b7943d3cc76dfb7f4f951c3c502","author":{"name":"craig[bot]","email":"3a2c29237f73c7cf88424b80e427b1884f346b35@cockroachlabs.com"},"message":"Merge #32652\n\n32652: distsql: bugfix to distsql planning of subqueries r=jordanlewis a=jordanlewis\n\nPreviously, some subqueries could crash the server when distributed,\r\nbecause of incorrect accounting for the PlanToStreamColMap final\r\nprojection on the result types of the subquery. Now, that final\r\nprojection is properly applied.\r\n\r\nFixes #32650.\r\n\r\nRelease note (bug fix): prevent crash when running certain subqueries\r\nthat get planned in a distributed fashion.\n\nCo-authored-by: Jordan Lewis <jordanthelewis@gmail.com>","distinct":false,"url":"https://api.github.com/repos/eriktrinh/cockroach/commits/9d9cfae045909b7943d3cc76dfb7f4f951c3c502"},{"sha":"027f231ab758f7aec151c744b9c715e50b313feb","author":{"name":"craig[bot]","email":"3a2c29237f73c7cf88424b80e427b1884f346b35@cockroachlabs.com"},"message":"Merge #32654\n\n32654: pgwire: decode bpchar OIDs r=mjibson a=mjibson\n\nUsing cmd/generate-binary I was able to verify that bpchar has the same\r\nbinary and text encodings as text and varchar, and so my best guess is\r\nthat it's correct to add it to this list.\r\n\r\nNo test has been added because the existing tests only test the T_text\r\ndecoding. That is: T_varchar was already untested, so having T_bpchar\r\nalso be untested is ok for now. I've opened #32653 to track this.\r\n\r\nFixes #32625\r\n\r\nRelease note (sql change): allow bpchar OIDs from client connections.\n\nCo-authored-by: Matt Jibson <matt.jibson@gmail.com>","distinct":false,"url":"https://api.github.com/repos/eriktrinh/cockroach/commits/027f231ab758f7aec151c744b9c715e50b313feb"},{"sha":"822eee296d94faf1ce914e1ce7675be200a7a8ba","author":{"name":"Tobias Schottdorf","email":"25fad7a39062a81fcaf88abd782f9f69679c0bdf@gmail.com"},"message":"engine: return ErrNotExist from DeleteFile on Windows\n\nFixes #32593.\n\nRelease note (bug fix): Fixed a crash that could occur during or after a\ndata import on Windows.","distinct":false,"url":"https://api.github.com/repos/eriktrinh/cockroach/commits/822eee296d94faf1ce914e1ce7675be200a7a8ba"},{"sha":"531c19d1048156cef3a9536025c959457d55a1d5","author":{"name":"craig[bot]","email":"3a2c29237f73c7cf88424b80e427b1884f346b35@cockroachlabs.com"},"message":"Merge #32664\n\n32664: engine: return ErrNotExist from DeleteFile on Windows r=petermattis a=tbg\n\nFixes #32593.\n\nRelease note (bug fix): Fixed a crash that could occur during or after a\ndata import on Windows.\n\nCo-authored-by: Tobias Schottdorf <tobias.schottdorf@gmail.com>","distinct":false,"url":"https://api.github.com/repos/eriktrinh/cockroach/commits/531c19d1048156cef3a9536025c959457d55a1d5"},{"sha":"cf700ef1822449dbc0df2cedba10d7d3f12d746a","author":{"name":"Nikhil Benesch","email":"0e70f566aa977bafe6ad237291a2aeff1c9dbb46@gmail.com"},"message":"storage: prettify error when change replicas races with a merge\n\nWhen a change replicas request races with a split or merge, the result\nis an ugly ConditionFailedError that reads\n\n    unexpected value: <gobleddygook>\n\nWe attempt to convert that ugly error into a prettier error of the form\n\n    descriptor changed: [expected] <desc> != [actual] <desc>\n\nbut the prettification code was not handling the case where the actual\ndescriptor is nil, i.e., because the range in question has been\nsubsumed. This commit updates the code to produce the following prettier\nerror:\n\n    descriptor changed: [expected] <desc> != [actual] nil (range subsumed)\n\nThis has the added benefit of fixing #32604, which sniffs out the\n\"descriptor changed\" message to determine whether an error is expected\nor not.\n\nFixes #32604.\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/eriktrinh/cockroach/commits/cf700ef1822449dbc0df2cedba10d7d3f12d746a"},{"sha":"de734380de9b3a001209f5a8d8964958071940de","author":{"name":"Nikhil Benesch","email":"0e70f566aa977bafe6ad237291a2aeff1c9dbb46@gmail.com"},"message":"storage/engine: wrap long lines in tests\n\nThe tests in this package were a case study in how to wrap code for\nmaximum illegibility. Enforce a line limit of 100 characters, except\nwhere exceeding the limit by a few characters makes the code\nsubstantially more readable.\n\nThe primary tool employed is extracting calls to context.Background()\ninto a per-test ctx variable.\n\nAll changes in this patch are straightforward reformattings with no\nbehavior changes.\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/eriktrinh/cockroach/commits/de734380de9b3a001209f5a8d8964958071940de"}]}
{"actor":{"display_login":"eriktrinh"}}