{"action":"created","comment":{"url":"https://api.github.com/repos/vatesfr/xen-orchestra/pulls/comments/200595223","pull_request_review_id":134923608,"id":200595223,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDU5NTIyMw==","diff_hunk":"@@ -958,11 +958,14 @@ export const copyVm = (vm, sr, name, compress) => {\n         title: _('copyVm'),\n         body: <CopyVmModalBody vm={vm} />,\n       }).then(params => {\n-        if (!params.sr) {\n+        const fullCopy = params.copyMode === 'fullCopy'\n+        if (fullCopy && !params.sr) {\n           error('copyVmsNoTargetSr', 'copyVmsNoTargetSrMessage')\n           return\n         }\n-        return _call('vm.copy', { vm: vmId, ...params })\n+        return fullCopy\n+          ? _call('vm.copy', { vm: vmId, ...params })\n+          : cloneVm({ id: vmId, name_label: params.name })","path":"packages/xo-web/src/common/xo/index.js","position":13,"original_position":13,"commit_id":"87f677d4d905462df6a75f91eb7ae83b7695926b","original_commit_id":"87f677d4d905462df6a75f91eb7ae83b7695926b","user":{"login":"pdonias","id":10992860,"node_id":"MDQ6VXNlcjEwOTkyODYw","avatar_url":"https://avatars1.githubusercontent.com/u/10992860?v=4","gravatar_id":"","url":"https://api.github.com/users/pdonias","html_url":"https://github.com/pdonias","followers_url":"https://api.github.com/users/pdonias/followers","following_url":"https://api.github.com/users/pdonias/following{/other_user}","gists_url":"https://api.github.com/users/pdonias/gists{/gist_id}","starred_url":"https://api.github.com/users/pdonias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdonias/subscriptions","organizations_url":"https://api.github.com/users/pdonias/orgs","repos_url":"https://api.github.com/users/pdonias/repos","events_url":"https://api.github.com/users/pdonias/events{/privacy}","received_events_url":"https://api.github.com/users/pdonias/received_events","type":"User","site_admin":false},"body":"This is weird. There's a high-level call with a low-level call. Maybe we should have a simple `copyVm` without modal prompts like `cloneVm` and then handle all the modal stuff in the high-level function. What do you think?","created_at":"2018-07-06T09:12:58Z","updated_at":"2018-07-06T09:17:54Z","html_url":"https://github.com/vatesfr/xen-orchestra/pull/3136#discussion_r200595223","pull_request_url":"https://api.github.com/repos/vatesfr/xen-orchestra/pulls/3136","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/vatesfr/xen-orchestra/pulls/comments/200595223"},"html":{"href":"https://github.com/vatesfr/xen-orchestra/pull/3136#discussion_r200595223"},"pull_request":{"href":"https://api.github.com/repos/vatesfr/xen-orchestra/pulls/3136"}}},"pull_request":{"url":"https://api.github.com/repos/vatesfr/xen-orchestra/pulls/3136","id":199004153,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MDA0MTUz","html_url":"https://github.com/vatesfr/xen-orchestra/pull/3136","diff_url":"https://github.com/vatesfr/xen-orchestra/pull/3136.diff","patch_url":"https://github.com/vatesfr/xen-orchestra/pull/3136.patch","issue_url":"https://api.github.com/repos/vatesfr/xen-orchestra/issues/3136","number":3136,"state":"open","locked":false,"title":"[VM/Snapshots]: add fast clone option when creating a VM","user":{"login":"Rajaa-BARHTAOUI","id":7724491,"node_id":"MDQ6VXNlcjc3MjQ0OTE=","avatar_url":"https://avatars2.githubusercontent.com/u/7724491?v=4","gravatar_id":"","url":"https://api.github.com/users/Rajaa-BARHTAOUI","html_url":"https://github.com/Rajaa-BARHTAOUI","followers_url":"https://api.github.com/users/Rajaa-BARHTAOUI/followers","following_url":"https://api.github.com/users/Rajaa-BARHTAOUI/following{/other_user}","gists_url":"https://api.github.com/users/Rajaa-BARHTAOUI/gists{/gist_id}","starred_url":"https://api.github.com/users/Rajaa-BARHTAOUI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rajaa-BARHTAOUI/subscriptions","organizations_url":"https://api.github.com/users/Rajaa-BARHTAOUI/orgs","repos_url":"https://api.github.com/users/Rajaa-BARHTAOUI/repos","events_url":"https://api.github.com/users/Rajaa-BARHTAOUI/events{/privacy}","received_events_url":"https://api.github.com/users/Rajaa-BARHTAOUI/received_events","type":"User","site_admin":false},"body":"\r\n![clone__1](https://user-images.githubusercontent.com/7724491/42278581-99625432-7f9b-11e8-9ea1-57b00bade233.png)\r\n\r\n- [x] Fixes #3120\r\n- [x] if UI changes, a screenshot has been added to the PR\r\n- [x] CHANGELOG:\r\n   - enhancement entry added\r\n   - list of packages to release updated (`${name} v${new version}`)\r\n- [ ] documentation updated","created_at":"2018-07-03T15:34:24Z","updated_at":"2018-07-06T09:17:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"187e3588ab0c52267f5d93e7467bbce3de259e30","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vatesfr/xen-orchestra/pulls/3136/commits","review_comments_url":"https://api.github.com/repos/vatesfr/xen-orchestra/pulls/3136/comments","review_comment_url":"https://api.github.com/repos/vatesfr/xen-orchestra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vatesfr/xen-orchestra/issues/3136/comments","statuses_url":"https://api.github.com/repos/vatesfr/xen-orchestra/statuses/87f677d4d905462df6a75f91eb7ae83b7695926b","head":{"label":"Rajaa-BARHTAOUI:option-fast-clone","ref":"option-fast-clone","sha":"87f677d4d905462df6a75f91eb7ae83b7695926b","user":{"login":"Rajaa-BARHTAOUI","id":7724491,"node_id":"MDQ6VXNlcjc3MjQ0OTE=","avatar_url":"https://avatars2.githubusercontent.com/u/7724491?v=4","gravatar_id":"","url":"https://api.github.com/users/Rajaa-BARHTAOUI","html_url":"https://github.com/Rajaa-BARHTAOUI","followers_url":"https://api.github.com/users/Rajaa-BARHTAOUI/followers","following_url":"https://api.github.com/users/Rajaa-BARHTAOUI/following{/other_user}","gists_url":"https://api.github.com/users/Rajaa-BARHTAOUI/gists{/gist_id}","starred_url":"https://api.github.com/users/Rajaa-BARHTAOUI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rajaa-BARHTAOUI/subscriptions","organizations_url":"https://api.github.com/users/Rajaa-BARHTAOUI/orgs","repos_url":"https://api.github.com/users/Rajaa-BARHTAOUI/repos","events_url":"https://api.github.com/users/Rajaa-BARHTAOUI/events{/privacy}","received_events_url":"https://api.github.com/users/Rajaa-BARHTAOUI/received_events","type":"User","site_admin":false},"repo":{"id":106420206,"node_id":"MDEwOlJlcG9zaXRvcnkxMDY0MjAyMDY=","name":"xo-web","full_name":"Rajaa-BARHTAOUI/xo-web","owner":{"login":"Rajaa-BARHTAOUI","id":7724491,"node_id":"MDQ6VXNlcjc3MjQ0OTE=","avatar_url":"https://avatars2.githubusercontent.com/u/7724491?v=4","gravatar_id":"","url":"https://api.github.com/users/Rajaa-BARHTAOUI","html_url":"https://github.com/Rajaa-BARHTAOUI","followers_url":"https://api.github.com/users/Rajaa-BARHTAOUI/followers","following_url":"https://api.github.com/users/Rajaa-BARHTAOUI/following{/other_user}","gists_url":"https://api.github.com/users/Rajaa-BARHTAOUI/gists{/gist_id}","starred_url":"https://api.github.com/users/Rajaa-BARHTAOUI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rajaa-BARHTAOUI/subscriptions","organizations_url":"https://api.github.com/users/Rajaa-BARHTAOUI/orgs","repos_url":"https://api.github.com/users/Rajaa-BARHTAOUI/repos","events_url":"https://api.github.com/users/Rajaa-BARHTAOUI/events{/privacy}","received_events_url":"https://api.github.com/users/Rajaa-BARHTAOUI/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Rajaa-BARHTAOUI/xo-web","description":"Interface part of Xen Orchestra.","fork":true,"url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web","forks_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/forks","keys_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/teams","hooks_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/hooks","issue_events_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/issues/events{/number}","events_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/events","assignees_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/assignees{/user}","branches_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/branches{/branch}","tags_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/tags","blobs_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/statuses/{sha}","languages_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/languages","stargazers_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/stargazers","contributors_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/contributors","subscribers_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/subscribers","subscription_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/subscription","commits_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/contents/{+path}","compare_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/merges","archive_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/downloads","issues_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/issues{/number}","pulls_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/pulls{/number}","milestones_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/milestones{/number}","notifications_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/labels{/name}","releases_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/releases{/id}","deployments_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/deployments","created_at":"2017-10-10T13:23:32Z","updated_at":"2018-07-04T08:58:13Z","pushed_at":"2018-07-04T13:18:03Z","git_url":"git://github.com/Rajaa-BARHTAOUI/xo-web.git","ssh_url":"git@github.com:Rajaa-BARHTAOUI/xo-web.git","clone_url":"https://github.com/Rajaa-BARHTAOUI/xo-web.git","svn_url":"https://github.com/Rajaa-BARHTAOUI/xo-web","homepage":"","size":27780,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vatesfr:master","ref":"master","sha":"76f3bc07581e47b7f69874a83bf42ebe61da5340","user":{"login":"vatesfr","id":2064170,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjQxNzA=","avatar_url":"https://avatars2.githubusercontent.com/u/2064170?v=4","gravatar_id":"","url":"https://api.github.com/users/vatesfr","html_url":"https://github.com/vatesfr","followers_url":"https://api.github.com/users/vatesfr/followers","following_url":"https://api.github.com/users/vatesfr/following{/other_user}","gists_url":"https://api.github.com/users/vatesfr/gists{/gist_id}","starred_url":"https://api.github.com/users/vatesfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vatesfr/subscriptions","organizations_url":"https://api.github.com/users/vatesfr/orgs","repos_url":"https://api.github.com/users/vatesfr/repos","events_url":"https://api.github.com/users/vatesfr/events{/privacy}","received_events_url":"https://api.github.com/users/vatesfr/received_events","type":"Organization","site_admin":false},"repo":{"id":8077957,"node_id":"MDEwOlJlcG9zaXRvcnk4MDc3OTU3","name":"xen-orchestra","full_name":"vatesfr/xen-orchestra","owner":{"login":"vatesfr","id":2064170,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjQxNzA=","avatar_url":"https://avatars2.githubusercontent.com/u/2064170?v=4","gravatar_id":"","url":"https://api.github.com/users/vatesfr","html_url":"https://github.com/vatesfr","followers_url":"https://api.github.com/users/vatesfr/followers","following_url":"https://api.github.com/users/vatesfr/following{/other_user}","gists_url":"https://api.github.com/users/vatesfr/gists{/gist_id}","starred_url":"https://api.github.com/users/vatesfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vatesfr/subscriptions","organizations_url":"https://api.github.com/users/vatesfr/orgs","repos_url":"https://api.github.com/users/vatesfr/repos","events_url":"https://api.github.com/users/vatesfr/events{/privacy}","received_events_url":"https://api.github.com/users/vatesfr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vatesfr/xen-orchestra","description":"The complete web solution for XenServer/XCP-ng","fork":false,"url":"https://api.github.com/repos/vatesfr/xen-orchestra","forks_url":"https://api.github.com/repos/vatesfr/xen-orchestra/forks","keys_url":"https://api.github.com/repos/vatesfr/xen-orchestra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vatesfr/xen-orchestra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vatesfr/xen-orchestra/teams","hooks_url":"https://api.github.com/repos/vatesfr/xen-orchestra/hooks","issue_events_url":"https://api.github.com/repos/vatesfr/xen-orchestra/issues/events{/number}","events_url":"https://api.github.com/repos/vatesfr/xen-orchestra/events","assignees_url":"https://api.github.com/repos/vatesfr/xen-orchestra/assignees{/user}","branches_url":"https://api.github.com/repos/vatesfr/xen-orchestra/branches{/branch}","tags_url":"https://api.github.com/repos/vatesfr/xen-orchestra/tags","blobs_url":"https://api.github.com/repos/vatesfr/xen-orchestra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vatesfr/xen-orchestra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vatesfr/xen-orchestra/git/refs{/sha}","trees_url":"https://api.github.com/repos/vatesfr/xen-orchestra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vatesfr/xen-orchestra/statuses/{sha}","languages_url":"https://api.github.com/repos/vatesfr/xen-orchestra/languages","stargazers_url":"https://api.github.com/repos/vatesfr/xen-orchestra/stargazers","contributors_url":"https://api.github.com/repos/vatesfr/xen-orchestra/contributors","subscribers_url":"https://api.github.com/repos/vatesfr/xen-orchestra/subscribers","subscription_url":"https://api.github.com/repos/vatesfr/xen-orchestra/subscription","commits_url":"https://api.github.com/repos/vatesfr/xen-orchestra/commits{/sha}","git_commits_url":"https://api.github.com/repos/vatesfr/xen-orchestra/git/commits{/sha}","comments_url":"https://api.github.com/repos/vatesfr/xen-orchestra/comments{/number}","issue_comment_url":"https://api.github.com/repos/vatesfr/xen-orchestra/issues/comments{/number}","contents_url":"https://api.github.com/repos/vatesfr/xen-orchestra/contents/{+path}","compare_url":"https://api.github.com/repos/vatesfr/xen-orchestra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vatesfr/xen-orchestra/merges","archive_url":"https://api.github.com/repos/vatesfr/xen-orchestra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vatesfr/xen-orchestra/downloads","issues_url":"https://api.github.com/repos/vatesfr/xen-orchestra/issues{/number}","pulls_url":"https://api.github.com/repos/vatesfr/xen-orchestra/pulls{/number}","milestones_url":"https://api.github.com/repos/vatesfr/xen-orchestra/milestones{/number}","notifications_url":"https://api.github.com/repos/vatesfr/xen-orchestra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vatesfr/xen-orchestra/labels{/name}","releases_url":"https://api.github.com/repos/vatesfr/xen-orchestra/releases{/id}","deployments_url":"https://api.github.com/repos/vatesfr/xen-orchestra/deployments","created_at":"2013-02-07T17:43:01Z","updated_at":"2018-07-05T15:15:11Z","pushed_at":"2018-07-06T08:57:45Z","git_url":"git://github.com/vatesfr/xen-orchestra.git","ssh_url":"git@github.com:vatesfr/xen-orchestra.git","clone_url":"https://github.com/vatesfr/xen-orchestra.git","svn_url":"https://github.com/vatesfr/xen-orchestra","homepage":"","size":27808,"stargazers_count":142,"watchers_count":142,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":56,"mirror_url":null,"archived":false,"open_issues_count":351,"license":null,"forks":56,"open_issues":351,"watchers":142,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vatesfr/xen-orchestra/pulls/3136"},"html":{"href":"https://github.com/vatesfr/xen-orchestra/pull/3136"},"issue":{"href":"https://api.github.com/repos/vatesfr/xen-orchestra/issues/3136"},"comments":{"href":"https://api.github.com/repos/vatesfr/xen-orchestra/issues/3136/comments"},"review_comments":{"href":"https://api.github.com/repos/vatesfr/xen-orchestra/pulls/3136/comments"},"review_comment":{"href":"https://api.github.com/repos/vatesfr/xen-orchestra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vatesfr/xen-orchestra/pulls/3136/commits"},"statuses":{"href":"https://api.github.com/repos/vatesfr/xen-orchestra/statuses/87f677d4d905462df6a75f91eb7ae83b7695926b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pdonias"}}