{"action":"created","comment":{"url":"https://api.github.com/repos/ARM-software/lisa/pulls/comments/173524957","pull_request_review_id":102737248,"id":173524957,"diff_hunk":"@@ -943,7 +943,7 @@ class _PELTTaskGroupsTest(LisaTest):\n         'modules': ['cpufreq', 'cgroups'],\n     }\n     # Allowed error margin\n-    allowed_util_margin = 0.02\n+    allowed_util_margin = 0.04","path":"tests/eas/load_tracking.py","position":5,"original_position":5,"commit_id":"b765d1418a93c8d913141c0a21c270cfc8c07a53","original_commit_id":"b765d1418a93c8d913141c0a21c270cfc8c07a53","user":{"login":"derkling","id":63746,"avatar_url":"https://avatars3.githubusercontent.com/u/63746?v=4","gravatar_id":"","url":"https://api.github.com/users/derkling","html_url":"https://github.com/derkling","followers_url":"https://api.github.com/users/derkling/followers","following_url":"https://api.github.com/users/derkling/following{/other_user}","gists_url":"https://api.github.com/users/derkling/gists{/gist_id}","starred_url":"https://api.github.com/users/derkling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derkling/subscriptions","organizations_url":"https://api.github.com/users/derkling/orgs","repos_url":"https://api.github.com/users/derkling/repos","events_url":"https://api.github.com/users/derkling/events{/privacy}","received_events_url":"https://api.github.com/users/derkling/received_events","type":"User","site_admin":false},"body":"Well, it's seems to be used also for PELT realted tests, in `PELTTasksTest`... but, in any case, maybe we can keep this bit for another time.","created_at":"2018-03-09T18:10:15Z","updated_at":"2018-03-09T18:10:15Z","html_url":"https://github.com/ARM-software/lisa/pull/574#discussion_r173524957","pull_request_url":"https://api.github.com/repos/ARM-software/lisa/pulls/574","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ARM-software/lisa/pulls/comments/173524957"},"html":{"href":"https://github.com/ARM-software/lisa/pull/574#discussion_r173524957"},"pull_request":{"href":"https://api.github.com/repos/ARM-software/lisa/pulls/574"}},"in_reply_to_id":173517771},"pull_request":{"url":"https://api.github.com/repos/ARM-software/lisa/pulls/574","id":174033897,"html_url":"https://github.com/ARM-software/lisa/pull/574","diff_url":"https://github.com/ARM-software/lisa/pull/574.diff","patch_url":"https://github.com/ARM-software/lisa/pull/574.patch","issue_url":"https://api.github.com/repos/ARM-software/lisa/issues/574","number":574,"state":"open","locked":false,"title":"load_tracking.py: Remove root group util test","user":{"login":"douglas-raillard-arm","id":23336875,"avatar_url":"https://avatars0.githubusercontent.com/u/23336875?v=4","gravatar_id":"","url":"https://api.github.com/users/douglas-raillard-arm","html_url":"https://github.com/douglas-raillard-arm","followers_url":"https://api.github.com/users/douglas-raillard-arm/followers","following_url":"https://api.github.com/users/douglas-raillard-arm/following{/other_user}","gists_url":"https://api.github.com/users/douglas-raillard-arm/gists{/gist_id}","starred_url":"https://api.github.com/users/douglas-raillard-arm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/douglas-raillard-arm/subscriptions","organizations_url":"https://api.github.com/users/douglas-raillard-arm/orgs","repos_url":"https://api.github.com/users/douglas-raillard-arm/repos","events_url":"https://api.github.com/users/douglas-raillard-arm/events{/privacy}","received_events_url":"https://api.github.com/users/douglas-raillard-arm/received_events","type":"User","site_admin":false},"body":"The root group contains more tasks than what we put in it, and we cannot\r\ncompletely control when they execute. This leads to test failure because\r\nthe measured utilization in this group is higher than expected. Since\r\nthe kind of children (tasks and groups) the root group has are also\r\nfound in other groups we fully control, we can simply drop these tests\r\nwithout reducing coverage.","created_at":"2018-03-09T15:30:33Z","updated_at":"2018-03-09T18:10:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e616409283431463375c8261c3a69b92eeb2006b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ARM-software/lisa/pulls/574/commits","review_comments_url":"https://api.github.com/repos/ARM-software/lisa/pulls/574/comments","review_comment_url":"https://api.github.com/repos/ARM-software/lisa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARM-software/lisa/issues/574/comments","statuses_url":"https://api.github.com/repos/ARM-software/lisa/statuses/b765d1418a93c8d913141c0a21c270cfc8c07a53","head":{"label":"douglas-raillard-arm:fix_root_group_util","ref":"fix_root_group_util","sha":"b765d1418a93c8d913141c0a21c270cfc8c07a53","user":{"login":"douglas-raillard-arm","id":23336875,"avatar_url":"https://avatars0.githubusercontent.com/u/23336875?v=4","gravatar_id":"","url":"https://api.github.com/users/douglas-raillard-arm","html_url":"https://github.com/douglas-raillard-arm","followers_url":"https://api.github.com/users/douglas-raillard-arm/followers","following_url":"https://api.github.com/users/douglas-raillard-arm/following{/other_user}","gists_url":"https://api.github.com/users/douglas-raillard-arm/gists{/gist_id}","starred_url":"https://api.github.com/users/douglas-raillard-arm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/douglas-raillard-arm/subscriptions","organizations_url":"https://api.github.com/users/douglas-raillard-arm/orgs","repos_url":"https://api.github.com/users/douglas-raillard-arm/repos","events_url":"https://api.github.com/users/douglas-raillard-arm/events{/privacy}","received_events_url":"https://api.github.com/users/douglas-raillard-arm/received_events","type":"User","site_admin":false},"repo":{"id":119572068,"name":"lisa","full_name":"douglas-raillard-arm/lisa","owner":{"login":"douglas-raillard-arm","id":23336875,"avatar_url":"https://avatars0.githubusercontent.com/u/23336875?v=4","gravatar_id":"","url":"https://api.github.com/users/douglas-raillard-arm","html_url":"https://github.com/douglas-raillard-arm","followers_url":"https://api.github.com/users/douglas-raillard-arm/followers","following_url":"https://api.github.com/users/douglas-raillard-arm/following{/other_user}","gists_url":"https://api.github.com/users/douglas-raillard-arm/gists{/gist_id}","starred_url":"https://api.github.com/users/douglas-raillard-arm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/douglas-raillard-arm/subscriptions","organizations_url":"https://api.github.com/users/douglas-raillard-arm/orgs","repos_url":"https://api.github.com/users/douglas-raillard-arm/repos","events_url":"https://api.github.com/users/douglas-raillard-arm/events{/privacy}","received_events_url":"https://api.github.com/users/douglas-raillard-arm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/douglas-raillard-arm/lisa","description":"Linux Integrated System Analysis","fork":true,"url":"https://api.github.com/repos/douglas-raillard-arm/lisa","forks_url":"https://api.github.com/repos/douglas-raillard-arm/lisa/forks","keys_url":"https://api.github.com/repos/douglas-raillard-arm/lisa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/douglas-raillard-arm/lisa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/douglas-raillard-arm/lisa/teams","hooks_url":"https://api.github.com/repos/douglas-raillard-arm/lisa/hooks","issue_events_url":"https://api.github.com/repos/douglas-raillard-arm/lisa/issues/events{/number}","events_url":"https://api.github.com/repos/douglas-raillard-arm/lisa/events","assignees_url":"https://api.github.com/repos/douglas-raillard-arm/lisa/assignees{/user}","branches_url":"https://api.github.com/repos/douglas-raillard-arm/lisa/branches{/branch}","tags_url":"https://api.github.com/repos/douglas-raillard-arm/lisa/tags","blobs_url":"https://api.github.com/repos/douglas-raillard-arm/lisa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/douglas-raillard-arm/lisa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/douglas-raillard-arm/lisa/git/refs{/sha}","trees_url":"https://api.github.com/repos/douglas-raillard-arm/lisa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/douglas-raillard-arm/lisa/statuses/{sha}","languages_url":"https://api.github.com/repos/douglas-raillard-arm/lisa/languages","stargazers_url":"https://api.github.com/repos/douglas-raillard-arm/lisa/stargazers","contributors_url":"https://api.github.com/repos/douglas-raillard-arm/lisa/contributors","subscribers_url":"https://api.github.com/repos/douglas-raillard-arm/lisa/subscribers","subscription_url":"https://api.github.com/repos/douglas-raillard-arm/lisa/subscription","commits_url":"https://api.github.com/repos/douglas-raillard-arm/lisa/commits{/sha}","git_commits_url":"https://api.github.com/repos/douglas-raillard-arm/lisa/git/commits{/sha}","comments_url":"https://api.github.com/repos/douglas-raillard-arm/lisa/comments{/number}","issue_comment_url":"https://api.github.com/repos/douglas-raillard-arm/lisa/issues/comments{/number}","contents_url":"https://api.github.com/repos/douglas-raillard-arm/lisa/contents/{+path}","compare_url":"https://api.github.com/repos/douglas-raillard-arm/lisa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/douglas-raillard-arm/lisa/merges","archive_url":"https://api.github.com/repos/douglas-raillard-arm/lisa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/douglas-raillard-arm/lisa/downloads","issues_url":"https://api.github.com/repos/douglas-raillard-arm/lisa/issues{/number}","pulls_url":"https://api.github.com/repos/douglas-raillard-arm/lisa/pulls{/number}","milestones_url":"https://api.github.com/repos/douglas-raillard-arm/lisa/milestones{/number}","notifications_url":"https://api.github.com/repos/douglas-raillard-arm/lisa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/douglas-raillard-arm/lisa/labels{/name}","releases_url":"https://api.github.com/repos/douglas-raillard-arm/lisa/releases{/id}","deployments_url":"https://api.github.com/repos/douglas-raillard-arm/lisa/deployments","created_at":"2018-01-30T17:47:19Z","updated_at":"2018-01-30T17:47:24Z","pushed_at":"2018-03-09T15:29:03Z","git_url":"git://github.com/douglas-raillard-arm/lisa.git","ssh_url":"git@github.com:douglas-raillard-arm/lisa.git","clone_url":"https://github.com/douglas-raillard-arm/lisa.git","svn_url":"https://github.com/douglas-raillard-arm/lisa","homepage":"","size":76695,"stargazers_count":0,"watchers_count":0,"language":"Jupyter Notebook","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ARM-software:master","ref":"master","sha":"2672b7f46f59bf6a0e0f4843c66c6d8d42aca68f","user":{"login":"ARM-software","id":5690313,"avatar_url":"https://avatars1.githubusercontent.com/u/5690313?v=4","gravatar_id":"","url":"https://api.github.com/users/ARM-software","html_url":"https://github.com/ARM-software","followers_url":"https://api.github.com/users/ARM-software/followers","following_url":"https://api.github.com/users/ARM-software/following{/other_user}","gists_url":"https://api.github.com/users/ARM-software/gists{/gist_id}","starred_url":"https://api.github.com/users/ARM-software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARM-software/subscriptions","organizations_url":"https://api.github.com/users/ARM-software/orgs","repos_url":"https://api.github.com/users/ARM-software/repos","events_url":"https://api.github.com/users/ARM-software/events{/privacy}","received_events_url":"https://api.github.com/users/ARM-software/received_events","type":"Organization","site_admin":false},"repo":{"id":47548304,"name":"lisa","full_name":"ARM-software/lisa","owner":{"login":"ARM-software","id":5690313,"avatar_url":"https://avatars1.githubusercontent.com/u/5690313?v=4","gravatar_id":"","url":"https://api.github.com/users/ARM-software","html_url":"https://github.com/ARM-software","followers_url":"https://api.github.com/users/ARM-software/followers","following_url":"https://api.github.com/users/ARM-software/following{/other_user}","gists_url":"https://api.github.com/users/ARM-software/gists{/gist_id}","starred_url":"https://api.github.com/users/ARM-software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARM-software/subscriptions","organizations_url":"https://api.github.com/users/ARM-software/orgs","repos_url":"https://api.github.com/users/ARM-software/repos","events_url":"https://api.github.com/users/ARM-software/events{/privacy}","received_events_url":"https://api.github.com/users/ARM-software/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARM-software/lisa","description":"Linux Integrated System Analysis","fork":false,"url":"https://api.github.com/repos/ARM-software/lisa","forks_url":"https://api.github.com/repos/ARM-software/lisa/forks","keys_url":"https://api.github.com/repos/ARM-software/lisa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARM-software/lisa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARM-software/lisa/teams","hooks_url":"https://api.github.com/repos/ARM-software/lisa/hooks","issue_events_url":"https://api.github.com/repos/ARM-software/lisa/issues/events{/number}","events_url":"https://api.github.com/repos/ARM-software/lisa/events","assignees_url":"https://api.github.com/repos/ARM-software/lisa/assignees{/user}","branches_url":"https://api.github.com/repos/ARM-software/lisa/branches{/branch}","tags_url":"https://api.github.com/repos/ARM-software/lisa/tags","blobs_url":"https://api.github.com/repos/ARM-software/lisa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARM-software/lisa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARM-software/lisa/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARM-software/lisa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARM-software/lisa/statuses/{sha}","languages_url":"https://api.github.com/repos/ARM-software/lisa/languages","stargazers_url":"https://api.github.com/repos/ARM-software/lisa/stargazers","contributors_url":"https://api.github.com/repos/ARM-software/lisa/contributors","subscribers_url":"https://api.github.com/repos/ARM-software/lisa/subscribers","subscription_url":"https://api.github.com/repos/ARM-software/lisa/subscription","commits_url":"https://api.github.com/repos/ARM-software/lisa/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARM-software/lisa/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARM-software/lisa/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARM-software/lisa/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARM-software/lisa/contents/{+path}","compare_url":"https://api.github.com/repos/ARM-software/lisa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARM-software/lisa/merges","archive_url":"https://api.github.com/repos/ARM-software/lisa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARM-software/lisa/downloads","issues_url":"https://api.github.com/repos/ARM-software/lisa/issues{/number}","pulls_url":"https://api.github.com/repos/ARM-software/lisa/pulls{/number}","milestones_url":"https://api.github.com/repos/ARM-software/lisa/milestones{/number}","notifications_url":"https://api.github.com/repos/ARM-software/lisa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARM-software/lisa/labels{/name}","releases_url":"https://api.github.com/repos/ARM-software/lisa/releases{/id}","deployments_url":"https://api.github.com/repos/ARM-software/lisa/deployments","created_at":"2015-12-07T11:32:56Z","updated_at":"2018-02-24T09:56:28Z","pushed_at":"2018-03-09T15:30:33Z","git_url":"git://github.com/ARM-software/lisa.git","ssh_url":"git@github.com:ARM-software/lisa.git","clone_url":"https://github.com/ARM-software/lisa.git","svn_url":"https://github.com/ARM-software/lisa","homepage":"","size":76692,"stargazers_count":47,"watchers_count":47,"language":"Jupyter Notebook","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"archived":false,"open_issues_count":72,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":47,"open_issues":72,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARM-software/lisa/pulls/574"},"html":{"href":"https://github.com/ARM-software/lisa/pull/574"},"issue":{"href":"https://api.github.com/repos/ARM-software/lisa/issues/574"},"comments":{"href":"https://api.github.com/repos/ARM-software/lisa/issues/574/comments"},"review_comments":{"href":"https://api.github.com/repos/ARM-software/lisa/pulls/574/comments"},"review_comment":{"href":"https://api.github.com/repos/ARM-software/lisa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARM-software/lisa/pulls/574/commits"},"statuses":{"href":"https://api.github.com/repos/ARM-software/lisa/statuses/b765d1418a93c8d913141c0a21c270cfc8c07a53"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"derkling"}}