{"action":"opened","number":190,"pull_request":{"url":"https://api.github.com/repos/tweecode/twine/pulls/190","id":214121865,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MTIxODY1","html_url":"https://github.com/tweecode/twine/pull/190","diff_url":"https://github.com/tweecode/twine/pull/190.diff","patch_url":"https://github.com/tweecode/twine/pull/190.patch","issue_url":"https://api.github.com/repos/tweecode/twine/issues/190","number":190,"state":"open","locked":false,"title":"Fix performance issue in Wikifier.parse","user":{"login":"dmchurch","id":605817,"node_id":"MDQ6VXNlcjYwNTgxNw==","avatar_url":"https://avatars2.githubusercontent.com/u/605817?v=4","gravatar_id":"","url":"https://api.github.com/users/dmchurch","html_url":"https://github.com/dmchurch","followers_url":"https://api.github.com/users/dmchurch/followers","following_url":"https://api.github.com/users/dmchurch/following{/other_user}","gists_url":"https://api.github.com/users/dmchurch/gists{/gist_id}","starred_url":"https://api.github.com/users/dmchurch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmchurch/subscriptions","organizations_url":"https://api.github.com/users/dmchurch/orgs","repos_url":"https://api.github.com/users/dmchurch/repos","events_url":"https://api.github.com/users/dmchurch/events{/privacy}","received_events_url":"https://api.github.com/users/dmchurch/received_events","type":"User","site_admin":false},"body":"The Wikifier.textPrimitives.unquoted method of parsing quoted strings is very slow when dealing with long strings that look like variable names, since it has to test each initial substring to see if it qualifies as \"unquoted\". This fixes the problem by removing all quoted strings from the input before parsing and restoring them after all of the calls to alter().\r\n\r\nThis can be tested by calling another passage as a macro and passing a very long variable-looking name inside a string, for example;\r\n\r\n`<<SomePassage \"$this_is_a_very_long_variable_name\">>`","created_at":"2018-09-09T01:01:33Z","updated_at":"2018-09-09T01:01:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tweecode/twine/pulls/190/commits","review_comments_url":"https://api.github.com/repos/tweecode/twine/pulls/190/comments","review_comment_url":"https://api.github.com/repos/tweecode/twine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tweecode/twine/issues/190/comments","statuses_url":"https://api.github.com/repos/tweecode/twine/statuses/46f8f79489102c558747d66e26ca094abaa1abb5","head":{"label":"dmchurch:master","ref":"master","sha":"46f8f79489102c558747d66e26ca094abaa1abb5","user":{"login":"dmchurch","id":605817,"node_id":"MDQ6VXNlcjYwNTgxNw==","avatar_url":"https://avatars2.githubusercontent.com/u/605817?v=4","gravatar_id":"","url":"https://api.github.com/users/dmchurch","html_url":"https://github.com/dmchurch","followers_url":"https://api.github.com/users/dmchurch/followers","following_url":"https://api.github.com/users/dmchurch/following{/other_user}","gists_url":"https://api.github.com/users/dmchurch/gists{/gist_id}","starred_url":"https://api.github.com/users/dmchurch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmchurch/subscriptions","organizations_url":"https://api.github.com/users/dmchurch/orgs","repos_url":"https://api.github.com/users/dmchurch/repos","events_url":"https://api.github.com/users/dmchurch/events{/privacy}","received_events_url":"https://api.github.com/users/dmchurch/received_events","type":"User","site_admin":false},"repo":{"id":147980716,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc5ODA3MTY=","name":"twine","full_name":"dmchurch/twine","owner":{"login":"dmchurch","id":605817,"node_id":"MDQ6VXNlcjYwNTgxNw==","avatar_url":"https://avatars2.githubusercontent.com/u/605817?v=4","gravatar_id":"","url":"https://api.github.com/users/dmchurch","html_url":"https://github.com/dmchurch","followers_url":"https://api.github.com/users/dmchurch/followers","following_url":"https://api.github.com/users/dmchurch/following{/other_user}","gists_url":"https://api.github.com/users/dmchurch/gists{/gist_id}","starred_url":"https://api.github.com/users/dmchurch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmchurch/subscriptions","organizations_url":"https://api.github.com/users/dmchurch/orgs","repos_url":"https://api.github.com/users/dmchurch/repos","events_url":"https://api.github.com/users/dmchurch/events{/privacy}","received_events_url":"https://api.github.com/users/dmchurch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dmchurch/twine","description":"UI for creating hypertext stories","fork":true,"url":"https://api.github.com/repos/dmchurch/twine","forks_url":"https://api.github.com/repos/dmchurch/twine/forks","keys_url":"https://api.github.com/repos/dmchurch/twine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmchurch/twine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmchurch/twine/teams","hooks_url":"https://api.github.com/repos/dmchurch/twine/hooks","issue_events_url":"https://api.github.com/repos/dmchurch/twine/issues/events{/number}","events_url":"https://api.github.com/repos/dmchurch/twine/events","assignees_url":"https://api.github.com/repos/dmchurch/twine/assignees{/user}","branches_url":"https://api.github.com/repos/dmchurch/twine/branches{/branch}","tags_url":"https://api.github.com/repos/dmchurch/twine/tags","blobs_url":"https://api.github.com/repos/dmchurch/twine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmchurch/twine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmchurch/twine/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmchurch/twine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmchurch/twine/statuses/{sha}","languages_url":"https://api.github.com/repos/dmchurch/twine/languages","stargazers_url":"https://api.github.com/repos/dmchurch/twine/stargazers","contributors_url":"https://api.github.com/repos/dmchurch/twine/contributors","subscribers_url":"https://api.github.com/repos/dmchurch/twine/subscribers","subscription_url":"https://api.github.com/repos/dmchurch/twine/subscription","commits_url":"https://api.github.com/repos/dmchurch/twine/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmchurch/twine/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmchurch/twine/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmchurch/twine/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmchurch/twine/contents/{+path}","compare_url":"https://api.github.com/repos/dmchurch/twine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmchurch/twine/merges","archive_url":"https://api.github.com/repos/dmchurch/twine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmchurch/twine/downloads","issues_url":"https://api.github.com/repos/dmchurch/twine/issues{/number}","pulls_url":"https://api.github.com/repos/dmchurch/twine/pulls{/number}","milestones_url":"https://api.github.com/repos/dmchurch/twine/milestones{/number}","notifications_url":"https://api.github.com/repos/dmchurch/twine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmchurch/twine/labels{/name}","releases_url":"https://api.github.com/repos/dmchurch/twine/releases{/id}","deployments_url":"https://api.github.com/repos/dmchurch/twine/deployments","created_at":"2018-09-09T00:39:35Z","updated_at":"2018-09-09T00:59:58Z","pushed_at":"2018-09-09T00:59:56Z","git_url":"git://github.com/dmchurch/twine.git","ssh_url":"git@github.com:dmchurch/twine.git","clone_url":"https://github.com/dmchurch/twine.git","svn_url":"https://github.com/dmchurch/twine","homepage":"http://twinery.org","size":3114,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tweecode:master","ref":"master","sha":"f0e6caf4b3857cccdb4043313997dda36f55dd06","user":{"login":"tweecode","id":1532191,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MzIxOTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1532191?v=4","gravatar_id":"","url":"https://api.github.com/users/tweecode","html_url":"https://github.com/tweecode","followers_url":"https://api.github.com/users/tweecode/followers","following_url":"https://api.github.com/users/tweecode/following{/other_user}","gists_url":"https://api.github.com/users/tweecode/gists{/gist_id}","starred_url":"https://api.github.com/users/tweecode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tweecode/subscriptions","organizations_url":"https://api.github.com/users/tweecode/orgs","repos_url":"https://api.github.com/users/tweecode/repos","events_url":"https://api.github.com/users/tweecode/events{/privacy}","received_events_url":"https://api.github.com/users/tweecode/received_events","type":"Organization","site_admin":false},"repo":{"id":3705117,"node_id":"MDEwOlJlcG9zaXRvcnkzNzA1MTE3","name":"twine","full_name":"tweecode/twine","owner":{"login":"tweecode","id":1532191,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MzIxOTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1532191?v=4","gravatar_id":"","url":"https://api.github.com/users/tweecode","html_url":"https://github.com/tweecode","followers_url":"https://api.github.com/users/tweecode/followers","following_url":"https://api.github.com/users/tweecode/following{/other_user}","gists_url":"https://api.github.com/users/tweecode/gists{/gist_id}","starred_url":"https://api.github.com/users/tweecode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tweecode/subscriptions","organizations_url":"https://api.github.com/users/tweecode/orgs","repos_url":"https://api.github.com/users/tweecode/repos","events_url":"https://api.github.com/users/tweecode/events{/privacy}","received_events_url":"https://api.github.com/users/tweecode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tweecode/twine","description":"UI for creating hypertext stories","fork":false,"url":"https://api.github.com/repos/tweecode/twine","forks_url":"https://api.github.com/repos/tweecode/twine/forks","keys_url":"https://api.github.com/repos/tweecode/twine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tweecode/twine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tweecode/twine/teams","hooks_url":"https://api.github.com/repos/tweecode/twine/hooks","issue_events_url":"https://api.github.com/repos/tweecode/twine/issues/events{/number}","events_url":"https://api.github.com/repos/tweecode/twine/events","assignees_url":"https://api.github.com/repos/tweecode/twine/assignees{/user}","branches_url":"https://api.github.com/repos/tweecode/twine/branches{/branch}","tags_url":"https://api.github.com/repos/tweecode/twine/tags","blobs_url":"https://api.github.com/repos/tweecode/twine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tweecode/twine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tweecode/twine/git/refs{/sha}","trees_url":"https://api.github.com/repos/tweecode/twine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tweecode/twine/statuses/{sha}","languages_url":"https://api.github.com/repos/tweecode/twine/languages","stargazers_url":"https://api.github.com/repos/tweecode/twine/stargazers","contributors_url":"https://api.github.com/repos/tweecode/twine/contributors","subscribers_url":"https://api.github.com/repos/tweecode/twine/subscribers","subscription_url":"https://api.github.com/repos/tweecode/twine/subscription","commits_url":"https://api.github.com/repos/tweecode/twine/commits{/sha}","git_commits_url":"https://api.github.com/repos/tweecode/twine/git/commits{/sha}","comments_url":"https://api.github.com/repos/tweecode/twine/comments{/number}","issue_comment_url":"https://api.github.com/repos/tweecode/twine/issues/comments{/number}","contents_url":"https://api.github.com/repos/tweecode/twine/contents/{+path}","compare_url":"https://api.github.com/repos/tweecode/twine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tweecode/twine/merges","archive_url":"https://api.github.com/repos/tweecode/twine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tweecode/twine/downloads","issues_url":"https://api.github.com/repos/tweecode/twine/issues{/number}","pulls_url":"https://api.github.com/repos/tweecode/twine/pulls{/number}","milestones_url":"https://api.github.com/repos/tweecode/twine/milestones{/number}","notifications_url":"https://api.github.com/repos/tweecode/twine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tweecode/twine/labels{/name}","releases_url":"https://api.github.com/repos/tweecode/twine/releases{/id}","deployments_url":"https://api.github.com/repos/tweecode/twine/deployments","created_at":"2012-03-13T09:47:45Z","updated_at":"2018-09-04T01:12:47Z","pushed_at":"2017-10-08T14:26:01Z","git_url":"git://github.com/tweecode/twine.git","ssh_url":"git@github.com:tweecode/twine.git","clone_url":"https://github.com/tweecode/twine.git","svn_url":"https://github.com/tweecode/twine","homepage":"http://twinery.org","size":3114,"stargazers_count":436,"watchers_count":436,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":89,"mirror_url":null,"archived":false,"open_issues_count":37,"license":null,"forks":89,"open_issues":37,"watchers":436,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tweecode/twine/pulls/190"},"html":{"href":"https://github.com/tweecode/twine/pull/190"},"issue":{"href":"https://api.github.com/repos/tweecode/twine/issues/190"},"comments":{"href":"https://api.github.com/repos/tweecode/twine/issues/190/comments"},"review_comments":{"href":"https://api.github.com/repos/tweecode/twine/pulls/190/comments"},"review_comment":{"href":"https://api.github.com/repos/tweecode/twine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tweecode/twine/pulls/190/commits"},"statuses":{"href":"https://api.github.com/repos/tweecode/twine/statuses/46f8f79489102c558747d66e26ca094abaa1abb5"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":10,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"dmchurch"}}