{"action":"created","comment":{"url":"https://api.github.com/repos/qgis/QGIS/pulls/comments/190799782","pull_request_review_id":123254485,"id":190799782,"diff_hunk":"@@ -432,7 +432,7 @@ QgsDataItem *QgsWmsDataItemProvider::createDataItem( const QString &path, QgsDat\n     if ( QgsWMSConnection::connectionList().contains( connectionName ) )\n     {\n       QgsWMSConnection connection( connectionName );\n-      return new QgsWMSConnectionItem( parentItem, QStringLiteral( \"WMS\" ), path, connection.uri().encodedUri() );\n+      return new QgsWMSConnectionItem( parentItem, QStringLiteral( \"WMS/WMTS\" ), path, connection.uri().encodedUri() );","path":"src/providers/wms/qgswmsdataitems.cpp","position":14,"original_position":14,"commit_id":"3e436094f6dede200d934583424d4b559b89258f","original_commit_id":"3e436094f6dede200d934583424d4b559b89258f","user":{"login":"rouault","id":1192433,"avatar_url":"https://avatars2.githubusercontent.com/u/1192433?v=4","gravatar_id":"","url":"https://api.github.com/users/rouault","html_url":"https://github.com/rouault","followers_url":"https://api.github.com/users/rouault/followers","following_url":"https://api.github.com/users/rouault/following{/other_user}","gists_url":"https://api.github.com/users/rouault/gists{/gist_id}","starred_url":"https://api.github.com/users/rouault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rouault/subscriptions","organizations_url":"https://api.github.com/users/rouault/orgs","repos_url":"https://api.github.com/users/rouault/repos","events_url":"https://api.github.com/users/rouault/events{/privacy}","received_events_url":"https://api.github.com/users/rouault/received_events","type":"User","site_admin":false},"body":"> I guess we can just remove those from the translatable string list.\r\n\r\nNot sure to follow you: remove what from where ?\r\nIn the 'QString text() const override' method of qgswmsprovider.cpp. But all other providers use translate strings for that method","created_at":"2018-05-25T06:19:27Z","updated_at":"2018-05-25T06:19:27Z","html_url":"https://github.com/qgis/QGIS/pull/7061#discussion_r190799782","pull_request_url":"https://api.github.com/repos/qgis/QGIS/pulls/7061","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/comments/190799782"},"html":{"href":"https://github.com/qgis/QGIS/pull/7061#discussion_r190799782"},"pull_request":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/7061"}},"in_reply_to_id":190629259},"pull_request":{"url":"https://api.github.com/repos/qgis/QGIS/pulls/7061","id":190255843,"html_url":"https://github.com/qgis/QGIS/pull/7061","diff_url":"https://github.com/qgis/QGIS/pull/7061.diff","patch_url":"https://github.com/qgis/QGIS/pull/7061.patch","issue_url":"https://api.github.com/repos/qgis/QGIS/issues/7061","number":7061,"state":"open","locked":false,"title":"WMS provider: use 'WMS/WMTS' instead of 'WMS' in various UI labels (fixes #18883)","user":{"login":"rouault","id":1192433,"avatar_url":"https://avatars2.githubusercontent.com/u/1192433?v=4","gravatar_id":"","url":"https://api.github.com/users/rouault","html_url":"https://github.com/rouault","followers_url":"https://api.github.com/users/rouault/followers","following_url":"https://api.github.com/users/rouault/following{/other_user}","gists_url":"https://api.github.com/users/rouault/gists{/gist_id}","starred_url":"https://api.github.com/users/rouault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rouault/subscriptions","organizations_url":"https://api.github.com/users/rouault/orgs","repos_url":"https://api.github.com/users/rouault/repos","events_url":"https://api.github.com/users/rouault/events{/privacy}","received_events_url":"https://api.github.com/users/rouault/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-24T11:26:40Z","updated_at":"2018-05-25T06:19:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"757fdf0a412c15a772d0a29e9b0c23ce743fbe80","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/qgis/QGIS/pulls/7061/commits","review_comments_url":"https://api.github.com/repos/qgis/QGIS/pulls/7061/comments","review_comment_url":"https://api.github.com/repos/qgis/QGIS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qgis/QGIS/issues/7061/comments","statuses_url":"https://api.github.com/repos/qgis/QGIS/statuses/3e436094f6dede200d934583424d4b559b89258f","head":{"label":"rouault:wms_wmts","ref":"wms_wmts","sha":"3e436094f6dede200d934583424d4b559b89258f","user":{"login":"rouault","id":1192433,"avatar_url":"https://avatars2.githubusercontent.com/u/1192433?v=4","gravatar_id":"","url":"https://api.github.com/users/rouault","html_url":"https://github.com/rouault","followers_url":"https://api.github.com/users/rouault/followers","following_url":"https://api.github.com/users/rouault/following{/other_user}","gists_url":"https://api.github.com/users/rouault/gists{/gist_id}","starred_url":"https://api.github.com/users/rouault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rouault/subscriptions","organizations_url":"https://api.github.com/users/rouault/orgs","repos_url":"https://api.github.com/users/rouault/repos","events_url":"https://api.github.com/users/rouault/events{/privacy}","received_events_url":"https://api.github.com/users/rouault/received_events","type":"User","site_admin":false},"repo":{"id":2815827,"name":"Quantum-GIS","full_name":"rouault/Quantum-GIS","owner":{"login":"rouault","id":1192433,"avatar_url":"https://avatars2.githubusercontent.com/u/1192433?v=4","gravatar_id":"","url":"https://api.github.com/users/rouault","html_url":"https://github.com/rouault","followers_url":"https://api.github.com/users/rouault/followers","following_url":"https://api.github.com/users/rouault/following{/other_user}","gists_url":"https://api.github.com/users/rouault/gists{/gist_id}","starred_url":"https://api.github.com/users/rouault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rouault/subscriptions","organizations_url":"https://api.github.com/users/rouault/orgs","repos_url":"https://api.github.com/users/rouault/repos","events_url":"https://api.github.com/users/rouault/events{/privacy}","received_events_url":"https://api.github.com/users/rouault/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rouault/Quantum-GIS","description":"QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)","fork":true,"url":"https://api.github.com/repos/rouault/Quantum-GIS","forks_url":"https://api.github.com/repos/rouault/Quantum-GIS/forks","keys_url":"https://api.github.com/repos/rouault/Quantum-GIS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rouault/Quantum-GIS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rouault/Quantum-GIS/teams","hooks_url":"https://api.github.com/repos/rouault/Quantum-GIS/hooks","issue_events_url":"https://api.github.com/repos/rouault/Quantum-GIS/issues/events{/number}","events_url":"https://api.github.com/repos/rouault/Quantum-GIS/events","assignees_url":"https://api.github.com/repos/rouault/Quantum-GIS/assignees{/user}","branches_url":"https://api.github.com/repos/rouault/Quantum-GIS/branches{/branch}","tags_url":"https://api.github.com/repos/rouault/Quantum-GIS/tags","blobs_url":"https://api.github.com/repos/rouault/Quantum-GIS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rouault/Quantum-GIS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rouault/Quantum-GIS/git/refs{/sha}","trees_url":"https://api.github.com/repos/rouault/Quantum-GIS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rouault/Quantum-GIS/statuses/{sha}","languages_url":"https://api.github.com/repos/rouault/Quantum-GIS/languages","stargazers_url":"https://api.github.com/repos/rouault/Quantum-GIS/stargazers","contributors_url":"https://api.github.com/repos/rouault/Quantum-GIS/contributors","subscribers_url":"https://api.github.com/repos/rouault/Quantum-GIS/subscribers","subscription_url":"https://api.github.com/repos/rouault/Quantum-GIS/subscription","commits_url":"https://api.github.com/repos/rouault/Quantum-GIS/commits{/sha}","git_commits_url":"https://api.github.com/repos/rouault/Quantum-GIS/git/commits{/sha}","comments_url":"https://api.github.com/repos/rouault/Quantum-GIS/comments{/number}","issue_comment_url":"https://api.github.com/repos/rouault/Quantum-GIS/issues/comments{/number}","contents_url":"https://api.github.com/repos/rouault/Quantum-GIS/contents/{+path}","compare_url":"https://api.github.com/repos/rouault/Quantum-GIS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rouault/Quantum-GIS/merges","archive_url":"https://api.github.com/repos/rouault/Quantum-GIS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rouault/Quantum-GIS/downloads","issues_url":"https://api.github.com/repos/rouault/Quantum-GIS/issues{/number}","pulls_url":"https://api.github.com/repos/rouault/Quantum-GIS/pulls{/number}","milestones_url":"https://api.github.com/repos/rouault/Quantum-GIS/milestones{/number}","notifications_url":"https://api.github.com/repos/rouault/Quantum-GIS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rouault/Quantum-GIS/labels{/name}","releases_url":"https://api.github.com/repos/rouault/Quantum-GIS/releases{/id}","deployments_url":"https://api.github.com/repos/rouault/Quantum-GIS/deployments","created_at":"2011-11-20T21:27:47Z","updated_at":"2018-03-13T07:17:59Z","pushed_at":"2018-05-24T11:26:12Z","git_url":"git://github.com/rouault/Quantum-GIS.git","ssh_url":"git@github.com:rouault/Quantum-GIS.git","clone_url":"https://github.com/rouault/Quantum-GIS.git","svn_url":"https://github.com/rouault/Quantum-GIS","homepage":"http://qgis.org","size":1307416,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"qgis:master","ref":"master","sha":"dde895d14964897a0701ee489e44f41c59c32619","user":{"login":"qgis","id":483444,"avatar_url":"https://avatars3.githubusercontent.com/u/483444?v=4","gravatar_id":"","url":"https://api.github.com/users/qgis","html_url":"https://github.com/qgis","followers_url":"https://api.github.com/users/qgis/followers","following_url":"https://api.github.com/users/qgis/following{/other_user}","gists_url":"https://api.github.com/users/qgis/gists{/gist_id}","starred_url":"https://api.github.com/users/qgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgis/subscriptions","organizations_url":"https://api.github.com/users/qgis/orgs","repos_url":"https://api.github.com/users/qgis/repos","events_url":"https://api.github.com/users/qgis/events{/privacy}","received_events_url":"https://api.github.com/users/qgis/received_events","type":"Organization","site_admin":false},"repo":{"id":1690480,"name":"QGIS","full_name":"qgis/QGIS","owner":{"login":"qgis","id":483444,"avatar_url":"https://avatars3.githubusercontent.com/u/483444?v=4","gravatar_id":"","url":"https://api.github.com/users/qgis","html_url":"https://github.com/qgis","followers_url":"https://api.github.com/users/qgis/followers","following_url":"https://api.github.com/users/qgis/following{/other_user}","gists_url":"https://api.github.com/users/qgis/gists{/gist_id}","starred_url":"https://api.github.com/users/qgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgis/subscriptions","organizations_url":"https://api.github.com/users/qgis/orgs","repos_url":"https://api.github.com/users/qgis/repos","events_url":"https://api.github.com/users/qgis/events{/privacy}","received_events_url":"https://api.github.com/users/qgis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qgis/QGIS","description":"QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)","fork":false,"url":"https://api.github.com/repos/qgis/QGIS","forks_url":"https://api.github.com/repos/qgis/QGIS/forks","keys_url":"https://api.github.com/repos/qgis/QGIS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qgis/QGIS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qgis/QGIS/teams","hooks_url":"https://api.github.com/repos/qgis/QGIS/hooks","issue_events_url":"https://api.github.com/repos/qgis/QGIS/issues/events{/number}","events_url":"https://api.github.com/repos/qgis/QGIS/events","assignees_url":"https://api.github.com/repos/qgis/QGIS/assignees{/user}","branches_url":"https://api.github.com/repos/qgis/QGIS/branches{/branch}","tags_url":"https://api.github.com/repos/qgis/QGIS/tags","blobs_url":"https://api.github.com/repos/qgis/QGIS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qgis/QGIS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qgis/QGIS/git/refs{/sha}","trees_url":"https://api.github.com/repos/qgis/QGIS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qgis/QGIS/statuses/{sha}","languages_url":"https://api.github.com/repos/qgis/QGIS/languages","stargazers_url":"https://api.github.com/repos/qgis/QGIS/stargazers","contributors_url":"https://api.github.com/repos/qgis/QGIS/contributors","subscribers_url":"https://api.github.com/repos/qgis/QGIS/subscribers","subscription_url":"https://api.github.com/repos/qgis/QGIS/subscription","commits_url":"https://api.github.com/repos/qgis/QGIS/commits{/sha}","git_commits_url":"https://api.github.com/repos/qgis/QGIS/git/commits{/sha}","comments_url":"https://api.github.com/repos/qgis/QGIS/comments{/number}","issue_comment_url":"https://api.github.com/repos/qgis/QGIS/issues/comments{/number}","contents_url":"https://api.github.com/repos/qgis/QGIS/contents/{+path}","compare_url":"https://api.github.com/repos/qgis/QGIS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qgis/QGIS/merges","archive_url":"https://api.github.com/repos/qgis/QGIS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qgis/QGIS/downloads","issues_url":"https://api.github.com/repos/qgis/QGIS/issues{/number}","pulls_url":"https://api.github.com/repos/qgis/QGIS/pulls{/number}","milestones_url":"https://api.github.com/repos/qgis/QGIS/milestones{/number}","notifications_url":"https://api.github.com/repos/qgis/QGIS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qgis/QGIS/labels{/name}","releases_url":"https://api.github.com/repos/qgis/QGIS/releases{/id}","deployments_url":"https://api.github.com/repos/qgis/QGIS/deployments","created_at":"2011-05-02T08:06:26Z","updated_at":"2018-05-25T06:10:57Z","pushed_at":"2018-05-25T05:59:51Z","git_url":"git://github.com/qgis/QGIS.git","ssh_url":"git@github.com:qgis/QGIS.git","clone_url":"https://github.com/qgis/QGIS.git","svn_url":"https://github.com/qgis/QGIS","homepage":"http://qgis.org","size":1415929,"stargazers_count":2033,"watchers_count":2033,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1251,"mirror_url":null,"archived":false,"open_issues_count":66,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":1251,"open_issues":66,"watchers":2033,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/7061"},"html":{"href":"https://github.com/qgis/QGIS/pull/7061"},"issue":{"href":"https://api.github.com/repos/qgis/QGIS/issues/7061"},"comments":{"href":"https://api.github.com/repos/qgis/QGIS/issues/7061/comments"},"review_comments":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/7061/comments"},"review_comment":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/7061/commits"},"statuses":{"href":"https://api.github.com/repos/qgis/QGIS/statuses/3e436094f6dede200d934583424d4b559b89258f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rouault"}}