{"action":"created","comment":{"url":"https://api.github.com/repos/jakubroztocil/rrule/pulls/comments/207076435","pull_request_review_id":142615514,"id":207076435,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzA3NjQzNQ==","diff_hunk":"@@ -1,26 +1,33 @@\n-import IterResult from './iterresult'\n-import {\n-  contains\n-} from './helpers'\n+import IterResult, { IterArgs } from './iterresult'\n+import { contains } from './helpers'\n \n /**\n  * IterResult subclass that calls a callback function on each add,\n  * and stops iterating when the callback returns false.\n  */\n export default class CallbackIterResult extends IterResult {\n-  constructor (method, args, iterator) {\n+  private iterator: (d: Date, len: number) => boolean\n+\n+  constructor (\n+    method: string,\n+    args: Partial<IterArgs>,\n+    iterator: (d: Date, len: number) => boolean\n+  ) {\n     const allowedMethods = ['all', 'between']\n     if (!contains(allowedMethods, method)) {\n-      throw new Error('Invalid method \"' + method +\n-        '\". Only all and between works with iterator.')\n+      throw new Error(","path":"src/callbackiterresult.ts","position":null,"original_position":25,"commit_id":"ed63fd0293128d1a9fc031bc960a6125c0be8756","original_commit_id":"1d498b44f1d8bd9eb5ebde323b80b2816f5d1262","user":{"login":"davidgoli","id":44666,"node_id":"MDQ6VXNlcjQ0NjY2","avatar_url":"https://avatars3.githubusercontent.com/u/44666?v=4","gravatar_id":"","url":"https://api.github.com/users/davidgoli","html_url":"https://github.com/davidgoli","followers_url":"https://api.github.com/users/davidgoli/followers","following_url":"https://api.github.com/users/davidgoli/following{/other_user}","gists_url":"https://api.github.com/users/davidgoli/gists{/gist_id}","starred_url":"https://api.github.com/users/davidgoli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidgoli/subscriptions","organizations_url":"https://api.github.com/users/davidgoli/orgs","repos_url":"https://api.github.com/users/davidgoli/repos","events_url":"https://api.github.com/users/davidgoli/events{/privacy}","received_events_url":"https://api.github.com/users/davidgoli/received_events","type":"User","site_admin":false},"body":"I scrapped that bit altogether. Thanks, Typescript!","created_at":"2018-08-02T01:09:40Z","updated_at":"2018-08-02T01:09:40Z","html_url":"https://github.com/jakubroztocil/rrule/pull/228#discussion_r207076435","pull_request_url":"https://api.github.com/repos/jakubroztocil/rrule/pulls/228","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/jakubroztocil/rrule/pulls/comments/207076435"},"html":{"href":"https://github.com/jakubroztocil/rrule/pull/228#discussion_r207076435"},"pull_request":{"href":"https://api.github.com/repos/jakubroztocil/rrule/pulls/228"}},"in_reply_to_id":206980013},"pull_request":{"url":"https://api.github.com/repos/jakubroztocil/rrule/pulls/228","id":205251639,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MjUxNjM5","html_url":"https://github.com/jakubroztocil/rrule/pull/228","diff_url":"https://github.com/jakubroztocil/rrule/pull/228.diff","patch_url":"https://github.com/jakubroztocil/rrule/pull/228.patch","issue_url":"https://api.github.com/repos/jakubroztocil/rrule/issues/228","number":228,"state":"open","locked":false,"title":"Convert to Typescript","user":{"login":"davidgoli","id":44666,"node_id":"MDQ6VXNlcjQ0NjY2","avatar_url":"https://avatars3.githubusercontent.com/u/44666?v=4","gravatar_id":"","url":"https://api.github.com/users/davidgoli","html_url":"https://github.com/davidgoli","followers_url":"https://api.github.com/users/davidgoli/followers","following_url":"https://api.github.com/users/davidgoli/following{/other_user}","gists_url":"https://api.github.com/users/davidgoli/gists{/gist_id}","starred_url":"https://api.github.com/users/davidgoli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidgoli/subscriptions","organizations_url":"https://api.github.com/users/davidgoli/orgs","repos_url":"https://api.github.com/users/davidgoli/repos","events_url":"https://api.github.com/users/davidgoli/events{/privacy}","received_events_url":"https://api.github.com/users/davidgoli/received_events","type":"User","site_admin":false},"body":"Addresses #229 \r\n\r\nNote there is a breaking change here: the types exported from `dist/es6/index.d.ts` do not conform to the structure in the original `index.d.ts`. Using `RRule` as both a namespace and a class seemed overly complicated, so I simplified it, but open to discussion.","created_at":"2018-07-31T21:45:31Z","updated_at":"2018-08-02T01:09:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c42853df1c723af9d9e4650aa3e76adb87002479","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jakubroztocil/rrule/pulls/228/commits","review_comments_url":"https://api.github.com/repos/jakubroztocil/rrule/pulls/228/comments","review_comment_url":"https://api.github.com/repos/jakubroztocil/rrule/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jakubroztocil/rrule/issues/228/comments","statuses_url":"https://api.github.com/repos/jakubroztocil/rrule/statuses/ed63fd0293128d1a9fc031bc960a6125c0be8756","head":{"label":"substantial:convert-to-typescript","ref":"convert-to-typescript","sha":"ed63fd0293128d1a9fc031bc960a6125c0be8756","user":{"login":"substantial","id":79686,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5Njg2","avatar_url":"https://avatars3.githubusercontent.com/u/79686?v=4","gravatar_id":"","url":"https://api.github.com/users/substantial","html_url":"https://github.com/substantial","followers_url":"https://api.github.com/users/substantial/followers","following_url":"https://api.github.com/users/substantial/following{/other_user}","gists_url":"https://api.github.com/users/substantial/gists{/gist_id}","starred_url":"https://api.github.com/users/substantial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/substantial/subscriptions","organizations_url":"https://api.github.com/users/substantial/orgs","repos_url":"https://api.github.com/users/substantial/repos","events_url":"https://api.github.com/users/substantial/events{/privacy}","received_events_url":"https://api.github.com/users/substantial/received_events","type":"Organization","site_admin":false},"repo":{"id":142079359,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIwNzkzNTk=","name":"rrule","full_name":"substantial/rrule","owner":{"login":"substantial","id":79686,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5Njg2","avatar_url":"https://avatars3.githubusercontent.com/u/79686?v=4","gravatar_id":"","url":"https://api.github.com/users/substantial","html_url":"https://github.com/substantial","followers_url":"https://api.github.com/users/substantial/followers","following_url":"https://api.github.com/users/substantial/following{/other_user}","gists_url":"https://api.github.com/users/substantial/gists{/gist_id}","starred_url":"https://api.github.com/users/substantial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/substantial/subscriptions","organizations_url":"https://api.github.com/users/substantial/orgs","repos_url":"https://api.github.com/users/substantial/repos","events_url":"https://api.github.com/users/substantial/events{/privacy}","received_events_url":"https://api.github.com/users/substantial/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/substantial/rrule","description":"JavaScript library for working with recurrence rules for calendar dates. Demo: https://jakubroztocil.github.io/rrule","fork":true,"url":"https://api.github.com/repos/substantial/rrule","forks_url":"https://api.github.com/repos/substantial/rrule/forks","keys_url":"https://api.github.com/repos/substantial/rrule/keys{/key_id}","collaborators_url":"https://api.github.com/repos/substantial/rrule/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/substantial/rrule/teams","hooks_url":"https://api.github.com/repos/substantial/rrule/hooks","issue_events_url":"https://api.github.com/repos/substantial/rrule/issues/events{/number}","events_url":"https://api.github.com/repos/substantial/rrule/events","assignees_url":"https://api.github.com/repos/substantial/rrule/assignees{/user}","branches_url":"https://api.github.com/repos/substantial/rrule/branches{/branch}","tags_url":"https://api.github.com/repos/substantial/rrule/tags","blobs_url":"https://api.github.com/repos/substantial/rrule/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/substantial/rrule/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/substantial/rrule/git/refs{/sha}","trees_url":"https://api.github.com/repos/substantial/rrule/git/trees{/sha}","statuses_url":"https://api.github.com/repos/substantial/rrule/statuses/{sha}","languages_url":"https://api.github.com/repos/substantial/rrule/languages","stargazers_url":"https://api.github.com/repos/substantial/rrule/stargazers","contributors_url":"https://api.github.com/repos/substantial/rrule/contributors","subscribers_url":"https://api.github.com/repos/substantial/rrule/subscribers","subscription_url":"https://api.github.com/repos/substantial/rrule/subscription","commits_url":"https://api.github.com/repos/substantial/rrule/commits{/sha}","git_commits_url":"https://api.github.com/repos/substantial/rrule/git/commits{/sha}","comments_url":"https://api.github.com/repos/substantial/rrule/comments{/number}","issue_comment_url":"https://api.github.com/repos/substantial/rrule/issues/comments{/number}","contents_url":"https://api.github.com/repos/substantial/rrule/contents/{+path}","compare_url":"https://api.github.com/repos/substantial/rrule/compare/{base}...{head}","merges_url":"https://api.github.com/repos/substantial/rrule/merges","archive_url":"https://api.github.com/repos/substantial/rrule/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/substantial/rrule/downloads","issues_url":"https://api.github.com/repos/substantial/rrule/issues{/number}","pulls_url":"https://api.github.com/repos/substantial/rrule/pulls{/number}","milestones_url":"https://api.github.com/repos/substantial/rrule/milestones{/number}","notifications_url":"https://api.github.com/repos/substantial/rrule/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/substantial/rrule/labels{/name}","releases_url":"https://api.github.com/repos/substantial/rrule/releases{/id}","deployments_url":"https://api.github.com/repos/substantial/rrule/deployments","created_at":"2018-07-23T23:20:13Z","updated_at":"2018-07-31T19:51:52Z","pushed_at":"2018-08-02T01:07:01Z","git_url":"git://github.com/substantial/rrule.git","ssh_url":"git@github.com:substantial/rrule.git","clone_url":"https://github.com/substantial/rrule.git","svn_url":"https://github.com/substantial/rrule","homepage":"https://twitter.com/jakubroztocil","size":2217,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jakubroztocil:master","ref":"master","sha":"b5e1ab8a6ae9a9438e1900f3309f4669c8a04dc9","user":{"login":"jakubroztocil","id":326885,"node_id":"MDQ6VXNlcjMyNjg4NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/326885?v=4","gravatar_id":"","url":"https://api.github.com/users/jakubroztocil","html_url":"https://github.com/jakubroztocil","followers_url":"https://api.github.com/users/jakubroztocil/followers","following_url":"https://api.github.com/users/jakubroztocil/following{/other_user}","gists_url":"https://api.github.com/users/jakubroztocil/gists{/gist_id}","starred_url":"https://api.github.com/users/jakubroztocil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakubroztocil/subscriptions","organizations_url":"https://api.github.com/users/jakubroztocil/orgs","repos_url":"https://api.github.com/users/jakubroztocil/repos","events_url":"https://api.github.com/users/jakubroztocil/events{/privacy}","received_events_url":"https://api.github.com/users/jakubroztocil/received_events","type":"User","site_admin":false},"repo":{"id":5430389,"node_id":"MDEwOlJlcG9zaXRvcnk1NDMwMzg5","name":"rrule","full_name":"jakubroztocil/rrule","owner":{"login":"jakubroztocil","id":326885,"node_id":"MDQ6VXNlcjMyNjg4NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/326885?v=4","gravatar_id":"","url":"https://api.github.com/users/jakubroztocil","html_url":"https://github.com/jakubroztocil","followers_url":"https://api.github.com/users/jakubroztocil/followers","following_url":"https://api.github.com/users/jakubroztocil/following{/other_user}","gists_url":"https://api.github.com/users/jakubroztocil/gists{/gist_id}","starred_url":"https://api.github.com/users/jakubroztocil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakubroztocil/subscriptions","organizations_url":"https://api.github.com/users/jakubroztocil/orgs","repos_url":"https://api.github.com/users/jakubroztocil/repos","events_url":"https://api.github.com/users/jakubroztocil/events{/privacy}","received_events_url":"https://api.github.com/users/jakubroztocil/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jakubroztocil/rrule","description":"JavaScript library for working with recurrence rules for calendar dates. Demo: https://jakubroztocil.github.io/rrule","fork":false,"url":"https://api.github.com/repos/jakubroztocil/rrule","forks_url":"https://api.github.com/repos/jakubroztocil/rrule/forks","keys_url":"https://api.github.com/repos/jakubroztocil/rrule/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jakubroztocil/rrule/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jakubroztocil/rrule/teams","hooks_url":"https://api.github.com/repos/jakubroztocil/rrule/hooks","issue_events_url":"https://api.github.com/repos/jakubroztocil/rrule/issues/events{/number}","events_url":"https://api.github.com/repos/jakubroztocil/rrule/events","assignees_url":"https://api.github.com/repos/jakubroztocil/rrule/assignees{/user}","branches_url":"https://api.github.com/repos/jakubroztocil/rrule/branches{/branch}","tags_url":"https://api.github.com/repos/jakubroztocil/rrule/tags","blobs_url":"https://api.github.com/repos/jakubroztocil/rrule/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jakubroztocil/rrule/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jakubroztocil/rrule/git/refs{/sha}","trees_url":"https://api.github.com/repos/jakubroztocil/rrule/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jakubroztocil/rrule/statuses/{sha}","languages_url":"https://api.github.com/repos/jakubroztocil/rrule/languages","stargazers_url":"https://api.github.com/repos/jakubroztocil/rrule/stargazers","contributors_url":"https://api.github.com/repos/jakubroztocil/rrule/contributors","subscribers_url":"https://api.github.com/repos/jakubroztocil/rrule/subscribers","subscription_url":"https://api.github.com/repos/jakubroztocil/rrule/subscription","commits_url":"https://api.github.com/repos/jakubroztocil/rrule/commits{/sha}","git_commits_url":"https://api.github.com/repos/jakubroztocil/rrule/git/commits{/sha}","comments_url":"https://api.github.com/repos/jakubroztocil/rrule/comments{/number}","issue_comment_url":"https://api.github.com/repos/jakubroztocil/rrule/issues/comments{/number}","contents_url":"https://api.github.com/repos/jakubroztocil/rrule/contents/{+path}","compare_url":"https://api.github.com/repos/jakubroztocil/rrule/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jakubroztocil/rrule/merges","archive_url":"https://api.github.com/repos/jakubroztocil/rrule/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jakubroztocil/rrule/downloads","issues_url":"https://api.github.com/repos/jakubroztocil/rrule/issues{/number}","pulls_url":"https://api.github.com/repos/jakubroztocil/rrule/pulls{/number}","milestones_url":"https://api.github.com/repos/jakubroztocil/rrule/milestones{/number}","notifications_url":"https://api.github.com/repos/jakubroztocil/rrule/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jakubroztocil/rrule/labels{/name}","releases_url":"https://api.github.com/repos/jakubroztocil/rrule/releases{/id}","deployments_url":"https://api.github.com/repos/jakubroztocil/rrule/deployments","created_at":"2012-08-15T19:14:02Z","updated_at":"2018-08-01T22:25:45Z","pushed_at":"2018-08-02T01:07:03Z","git_url":"git://github.com/jakubroztocil/rrule.git","ssh_url":"git@github.com:jakubroztocil/rrule.git","clone_url":"https://github.com/jakubroztocil/rrule.git","svn_url":"https://github.com/jakubroztocil/rrule","homepage":"https://twitter.com/jakubroztocil","size":1147,"stargazers_count":1082,"watchers_count":1082,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":258,"mirror_url":null,"archived":false,"open_issues_count":75,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":258,"open_issues":75,"watchers":1082,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jakubroztocil/rrule/pulls/228"},"html":{"href":"https://github.com/jakubroztocil/rrule/pull/228"},"issue":{"href":"https://api.github.com/repos/jakubroztocil/rrule/issues/228"},"comments":{"href":"https://api.github.com/repos/jakubroztocil/rrule/issues/228/comments"},"review_comments":{"href":"https://api.github.com/repos/jakubroztocil/rrule/pulls/228/comments"},"review_comment":{"href":"https://api.github.com/repos/jakubroztocil/rrule/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jakubroztocil/rrule/pulls/228/commits"},"statuses":{"href":"https://api.github.com/repos/jakubroztocil/rrule/statuses/ed63fd0293128d1a9fc031bc960a6125c0be8756"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"davidgoli"}}