{"action":"created","issue":{"url":"https://api.github.com/repos/openfaas/faas-netes/issues/221","repository_url":"https://api.github.com/repos/openfaas/faas-netes","labels_url":"https://api.github.com/repos/openfaas/faas-netes/issues/221/labels{/name}","comments_url":"https://api.github.com/repos/openfaas/faas-netes/issues/221/comments","events_url":"https://api.github.com/repos/openfaas/faas-netes/issues/221/events","html_url":"https://github.com/openfaas/faas-netes/issues/221","id":333021934,"node_id":"MDU6SXNzdWUzMzMwMjE5MzQ=","number":221,"title":"Store labels in annotations, not in Deployment labels","user":{"login":"alexellis","id":6358735,"node_id":"MDQ6VXNlcjYzNTg3MzU=","avatar_url":"https://avatars1.githubusercontent.com/u/6358735?v=4","gravatar_id":"","url":"https://api.github.com/users/alexellis","html_url":"https://github.com/alexellis","followers_url":"https://api.github.com/users/alexellis/followers","following_url":"https://api.github.com/users/alexellis/following{/other_user}","gists_url":"https://api.github.com/users/alexellis/gists{/gist_id}","starred_url":"https://api.github.com/users/alexellis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexellis/subscriptions","organizations_url":"https://api.github.com/users/alexellis/orgs","repos_url":"https://api.github.com/users/alexellis/repos","events_url":"https://api.github.com/users/alexellis/events{/privacy}","received_events_url":"https://api.github.com/users/alexellis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-06-16T23:17:55Z","updated_at":"2018-06-17T15:00:22Z","closed_at":null,"author_association":"MEMBER","body":"Kubernetes has a preference for storing labels and metadata in \"annotations\" rather than in labels as we do currently.\r\n\r\nOpenFaaS is an abstraction which has a top-level concept of labels which can store metadata - therefore we can just create our labels in annotations and retrieve them from annotations without affecting the interface to OpenFaaS.\r\n\r\n## Example:\r\n\r\nThe following are abstract examples to show how this change should take place:\r\n\r\nOpenFaaS Function:\r\n\r\n```\r\nName: fn-1\r\nLabels:\r\n - Git-Owner=alexellis\r\n```\r\n\r\nKubernetes Deployment before:\r\n\r\n```\r\nName: fn-1\r\nLabels:\r\n - Git-Owner=alexellis\r\nAnnotations:\r\n - None\r\n```\r\n\r\nKubernetes Deployment after:\r\n\r\n```\r\nName: fn-1\r\nLabels:\r\n - None\r\nAnnotations\r\n - Git-Owner=alexellis\r\n```\r\n\r\nThe annotations may need to be scoped with a prefix such as `com.openfaas.` or placed inside a metadata object such as a map with a well-known key: `com.openfaas.labels: [ \"k=v\", \"k1=v1\" ]`"},"comment":{"url":"https://api.github.com/repos/openfaas/faas-netes/issues/comments/397884647","html_url":"https://github.com/openfaas/faas-netes/issues/221#issuecomment-397884647","issue_url":"https://api.github.com/repos/openfaas/faas-netes/issues/221","id":397884647,"node_id":"MDEyOklzc3VlQ29tbWVudDM5Nzg4NDY0Nw==","user":{"login":"LucasRoesler","id":891889,"node_id":"MDQ6VXNlcjg5MTg4OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/891889?v=4","gravatar_id":"","url":"https://api.github.com/users/LucasRoesler","html_url":"https://github.com/LucasRoesler","followers_url":"https://api.github.com/users/LucasRoesler/followers","following_url":"https://api.github.com/users/LucasRoesler/following{/other_user}","gists_url":"https://api.github.com/users/LucasRoesler/gists{/gist_id}","starred_url":"https://api.github.com/users/LucasRoesler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LucasRoesler/subscriptions","organizations_url":"https://api.github.com/users/LucasRoesler/orgs","repos_url":"https://api.github.com/users/LucasRoesler/repos","events_url":"https://api.github.com/users/LucasRoesler/events{/privacy}","received_events_url":"https://api.github.com/users/LucasRoesler/received_events","type":"User","site_admin":false},"created_at":"2018-06-17T15:00:22Z","updated_at":"2018-06-17T15:00:22Z","author_association":"CONTRIBUTOR","body":"@dkozlov  Both `constraints` and resource `requests` and `limits` are supported already for functions see #104 and #81 for example. Both are supported in Swarm and K8S with full support in the in the stack.yaml schema https://github.com/openfaas/faas-cli/blob/master/stack/schema.go\r\n\r\nCurrently, these optinos are not configurable for the core components (gateway etc) when deployed by the helm chart, but there is an issue for this #213 "}}
{"actor":{"display_login":"LucasRoesler"}}