{"action":"created","comment":{"url":"https://api.github.com/repos/caicloud/nirvana/pulls/comments/179944745","pull_request_review_id":110284312,"id":179944745,"diff_hunk":"@@ -154,7 +154,7 @@ func (i *inspector) conflictCheck(c *executor) error {\n \tcMap := c.ctMap()\n \tfor k, vs := range cMap {\n \t\tfor _, v := range vs {\n-\t\t\tif !ctMap[k+\":\"+v] {\n+\t\t\tif ctMap[k+\":\"+v] {","path":"service/executor.go","position":5,"original_position":5,"commit_id":"a8577272d6775ed2de857afb16bf4b3c60e4c323","original_commit_id":"a8577272d6775ed2de857afb16bf4b3c60e4c323","user":{"login":"kdada","id":13895988,"avatar_url":"https://avatars2.githubusercontent.com/u/13895988?v=4","gravatar_id":"","url":"https://api.github.com/users/kdada","html_url":"https://github.com/kdada","followers_url":"https://api.github.com/users/kdada/followers","following_url":"https://api.github.com/users/kdada/following{/other_user}","gists_url":"https://api.github.com/users/kdada/gists{/gist_id}","starred_url":"https://api.github.com/users/kdada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kdada/subscriptions","organizations_url":"https://api.github.com/users/kdada/orgs","repos_url":"https://api.github.com/users/kdada/repos","events_url":"https://api.github.com/users/kdada/events{/privacy}","received_events_url":"https://api.github.com/users/kdada/received_events","type":"User","site_admin":false},"body":"```go\r\n\r\n \t\t{\r\n  \t\t\tdefinition.Definition{\r\n  \t\t\t\tMethod:   definition.Get,\r\n  \t\t\t\tConsumes: []string{definition.MIMENone},\r\n -\t\t\t\tProduces: []string{definition.MIMEXML},\r\n +\t\t\t\tProduces: []string{definition.MIMEJSON},\r\n  \t\t\t\tFunction: func() {\r\n  \t\t\t\t},\r\n  \t\t\t},\r\n \t\t\tdefinitionConflict,\r\n \t\t},\r\n```","created_at":"2018-04-08T11:39:08Z","updated_at":"2018-04-08T11:39:08Z","html_url":"https://github.com/caicloud/nirvana/pull/199#discussion_r179944745","pull_request_url":"https://api.github.com/repos/caicloud/nirvana/pulls/199","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/caicloud/nirvana/pulls/comments/179944745"},"html":{"href":"https://github.com/caicloud/nirvana/pull/199#discussion_r179944745"},"pull_request":{"href":"https://api.github.com/repos/caicloud/nirvana/pulls/199"}},"in_reply_to_id":179942855},"pull_request":{"url":"https://api.github.com/repos/caicloud/nirvana/pulls/199","id":179308456,"html_url":"https://github.com/caicloud/nirvana/pull/199","diff_url":"https://github.com/caicloud/nirvana/pull/199.diff","patch_url":"https://github.com/caicloud/nirvana/pull/199.patch","issue_url":"https://api.github.com/repos/caicloud/nirvana/issues/199","number":199,"state":"open","locked":false,"title":"fix(service): fix wrong conflict definition check","user":{"login":"kdada","id":13895988,"avatar_url":"https://avatars2.githubusercontent.com/u/13895988?v=4","gravatar_id":"","url":"https://api.github.com/users/kdada","html_url":"https://github.com/kdada","followers_url":"https://api.github.com/users/kdada/followers","following_url":"https://api.github.com/users/kdada/following{/other_user}","gists_url":"https://api.github.com/users/kdada/gists{/gist_id}","starred_url":"https://api.github.com/users/kdada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kdada/subscriptions","organizations_url":"https://api.github.com/users/kdada/orgs","repos_url":"https://api.github.com/users/kdada/repos","events_url":"https://api.github.com/users/kdada/events{/privacy}","received_events_url":"https://api.github.com/users/kdada/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request! See below for tips! -->\r\n\r\n**What this PR does / why we need it**:\r\n\r\nFix wrong conflict definition check\r\n\r\n**Which issue(s) this PR fixes** *(optional, close the issue(s) when PR gets merged)*:\r\n\r\nFixes #198\r\n\r\n**Special notes for your reviewer**:\r\n\r\n/cc @zjj2wry \r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n\r\n```release-note\r\nNONE\r\n```\r\n\r\n<!--  Thanks for sending a pull request! Here are some tips:\r\n\r\n1. https://github.com/caicloud/engineering/blob/master/docs/review_conventions.md  <-- what is the review process looks like\r\n2. https://github.com/caicloud/engineering/blob/master/docs/commit_conventions.md  <-- how to structure your git commit\r\n3. https://github.com/caicloud/engineering/blob/master/docs/caicloud_bot.md        <-- how to work with caicloud bot\r\n\r\nOther tips from Kubernetes cmomunity:\r\n\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n4. If the PR is unfinished, see how to mark it: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n","created_at":"2018-04-04T07:53:07Z","updated_at":"2018-04-08T11:39:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21773a99ad94fcbd1ad90baf27a6ac8ceae4149a","assignee":{"login":"zjj2wry","id":18045633,"avatar_url":"https://avatars2.githubusercontent.com/u/18045633?v=4","gravatar_id":"","url":"https://api.github.com/users/zjj2wry","html_url":"https://github.com/zjj2wry","followers_url":"https://api.github.com/users/zjj2wry/followers","following_url":"https://api.github.com/users/zjj2wry/following{/other_user}","gists_url":"https://api.github.com/users/zjj2wry/gists{/gist_id}","starred_url":"https://api.github.com/users/zjj2wry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zjj2wry/subscriptions","organizations_url":"https://api.github.com/users/zjj2wry/orgs","repos_url":"https://api.github.com/users/zjj2wry/repos","events_url":"https://api.github.com/users/zjj2wry/events{/privacy}","received_events_url":"https://api.github.com/users/zjj2wry/received_events","type":"User","site_admin":false},"assignees":[{"login":"ddysher","id":2191361,"avatar_url":"https://avatars1.githubusercontent.com/u/2191361?v=4","gravatar_id":"","url":"https://api.github.com/users/ddysher","html_url":"https://github.com/ddysher","followers_url":"https://api.github.com/users/ddysher/followers","following_url":"https://api.github.com/users/ddysher/following{/other_user}","gists_url":"https://api.github.com/users/ddysher/gists{/gist_id}","starred_url":"https://api.github.com/users/ddysher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddysher/subscriptions","organizations_url":"https://api.github.com/users/ddysher/orgs","repos_url":"https://api.github.com/users/ddysher/repos","events_url":"https://api.github.com/users/ddysher/events{/privacy}","received_events_url":"https://api.github.com/users/ddysher/received_events","type":"User","site_admin":false},{"login":"zjj2wry","id":18045633,"avatar_url":"https://avatars2.githubusercontent.com/u/18045633?v=4","gravatar_id":"","url":"https://api.github.com/users/zjj2wry","html_url":"https://github.com/zjj2wry","followers_url":"https://api.github.com/users/zjj2wry/followers","following_url":"https://api.github.com/users/zjj2wry/following{/other_user}","gists_url":"https://api.github.com/users/zjj2wry/gists{/gist_id}","starred_url":"https://api.github.com/users/zjj2wry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zjj2wry/subscriptions","organizations_url":"https://api.github.com/users/zjj2wry/orgs","repos_url":"https://api.github.com/users/zjj2wry/repos","events_url":"https://api.github.com/users/zjj2wry/events{/privacy}","received_events_url":"https://api.github.com/users/zjj2wry/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"zjj2wry","id":18045633,"avatar_url":"https://avatars2.githubusercontent.com/u/18045633?v=4","gravatar_id":"","url":"https://api.github.com/users/zjj2wry","html_url":"https://github.com/zjj2wry","followers_url":"https://api.github.com/users/zjj2wry/followers","following_url":"https://api.github.com/users/zjj2wry/following{/other_user}","gists_url":"https://api.github.com/users/zjj2wry/gists{/gist_id}","starred_url":"https://api.github.com/users/zjj2wry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zjj2wry/subscriptions","organizations_url":"https://api.github.com/users/zjj2wry/orgs","repos_url":"https://api.github.com/users/zjj2wry/repos","events_url":"https://api.github.com/users/zjj2wry/events{/privacy}","received_events_url":"https://api.github.com/users/zjj2wry/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":804869272,"url":"https://api.github.com/repos/caicloud/nirvana/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":845943425,"url":"https://api.github.com/repos/caicloud/nirvana/labels/caicloud-cla:%20yes","name":"caicloud-cla: yes","color":"bfe5bf","default":false},{"id":801433420,"url":"https://api.github.com/repos/caicloud/nirvana/labels/size/XS","name":"size/XS","color":"009900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/caicloud/nirvana/pulls/199/commits","review_comments_url":"https://api.github.com/repos/caicloud/nirvana/pulls/199/comments","review_comment_url":"https://api.github.com/repos/caicloud/nirvana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/caicloud/nirvana/issues/199/comments","statuses_url":"https://api.github.com/repos/caicloud/nirvana/statuses/a8577272d6775ed2de857afb16bf4b3c60e4c323","head":{"label":"kdada:master","ref":"master","sha":"a8577272d6775ed2de857afb16bf4b3c60e4c323","user":{"login":"kdada","id":13895988,"avatar_url":"https://avatars2.githubusercontent.com/u/13895988?v=4","gravatar_id":"","url":"https://api.github.com/users/kdada","html_url":"https://github.com/kdada","followers_url":"https://api.github.com/users/kdada/followers","following_url":"https://api.github.com/users/kdada/following{/other_user}","gists_url":"https://api.github.com/users/kdada/gists{/gist_id}","starred_url":"https://api.github.com/users/kdada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kdada/subscriptions","organizations_url":"https://api.github.com/users/kdada/orgs","repos_url":"https://api.github.com/users/kdada/repos","events_url":"https://api.github.com/users/kdada/events{/privacy}","received_events_url":"https://api.github.com/users/kdada/received_events","type":"User","site_admin":false},"repo":{"id":110627074,"name":"nirvana","full_name":"kdada/nirvana","owner":{"login":"kdada","id":13895988,"avatar_url":"https://avatars2.githubusercontent.com/u/13895988?v=4","gravatar_id":"","url":"https://api.github.com/users/kdada","html_url":"https://github.com/kdada","followers_url":"https://api.github.com/users/kdada/followers","following_url":"https://api.github.com/users/kdada/following{/other_user}","gists_url":"https://api.github.com/users/kdada/gists{/gist_id}","starred_url":"https://api.github.com/users/kdada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kdada/subscriptions","organizations_url":"https://api.github.com/users/kdada/orgs","repos_url":"https://api.github.com/users/kdada/repos","events_url":"https://api.github.com/users/kdada/events{/privacy}","received_events_url":"https://api.github.com/users/kdada/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kdada/nirvana","description":"Golang Restful API Framework for Productivity","fork":true,"url":"https://api.github.com/repos/kdada/nirvana","forks_url":"https://api.github.com/repos/kdada/nirvana/forks","keys_url":"https://api.github.com/repos/kdada/nirvana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kdada/nirvana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kdada/nirvana/teams","hooks_url":"https://api.github.com/repos/kdada/nirvana/hooks","issue_events_url":"https://api.github.com/repos/kdada/nirvana/issues/events{/number}","events_url":"https://api.github.com/repos/kdada/nirvana/events","assignees_url":"https://api.github.com/repos/kdada/nirvana/assignees{/user}","branches_url":"https://api.github.com/repos/kdada/nirvana/branches{/branch}","tags_url":"https://api.github.com/repos/kdada/nirvana/tags","blobs_url":"https://api.github.com/repos/kdada/nirvana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kdada/nirvana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kdada/nirvana/git/refs{/sha}","trees_url":"https://api.github.com/repos/kdada/nirvana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kdada/nirvana/statuses/{sha}","languages_url":"https://api.github.com/repos/kdada/nirvana/languages","stargazers_url":"https://api.github.com/repos/kdada/nirvana/stargazers","contributors_url":"https://api.github.com/repos/kdada/nirvana/contributors","subscribers_url":"https://api.github.com/repos/kdada/nirvana/subscribers","subscription_url":"https://api.github.com/repos/kdada/nirvana/subscription","commits_url":"https://api.github.com/repos/kdada/nirvana/commits{/sha}","git_commits_url":"https://api.github.com/repos/kdada/nirvana/git/commits{/sha}","comments_url":"https://api.github.com/repos/kdada/nirvana/comments{/number}","issue_comment_url":"https://api.github.com/repos/kdada/nirvana/issues/comments{/number}","contents_url":"https://api.github.com/repos/kdada/nirvana/contents/{+path}","compare_url":"https://api.github.com/repos/kdada/nirvana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kdada/nirvana/merges","archive_url":"https://api.github.com/repos/kdada/nirvana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kdada/nirvana/downloads","issues_url":"https://api.github.com/repos/kdada/nirvana/issues{/number}","pulls_url":"https://api.github.com/repos/kdada/nirvana/pulls{/number}","milestones_url":"https://api.github.com/repos/kdada/nirvana/milestones{/number}","notifications_url":"https://api.github.com/repos/kdada/nirvana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kdada/nirvana/labels{/name}","releases_url":"https://api.github.com/repos/kdada/nirvana/releases{/id}","deployments_url":"https://api.github.com/repos/kdada/nirvana/deployments","created_at":"2017-11-14T02:01:31Z","updated_at":"2018-04-04T07:52:15Z","pushed_at":"2018-04-04T07:52:14Z","git_url":"git://github.com/kdada/nirvana.git","ssh_url":"git@github.com:kdada/nirvana.git","clone_url":"https://github.com/kdada/nirvana.git","svn_url":"https://github.com/kdada/nirvana","homepage":"https://caicloud.github.io/nirvana/","size":7965,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"caicloud:master","ref":"master","sha":"3ee1c0eb18424590052c2ad180695eafdee3a0c0","user":{"login":"caicloud","id":12522124,"avatar_url":"https://avatars2.githubusercontent.com/u/12522124?v=4","gravatar_id":"","url":"https://api.github.com/users/caicloud","html_url":"https://github.com/caicloud","followers_url":"https://api.github.com/users/caicloud/followers","following_url":"https://api.github.com/users/caicloud/following{/other_user}","gists_url":"https://api.github.com/users/caicloud/gists{/gist_id}","starred_url":"https://api.github.com/users/caicloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caicloud/subscriptions","organizations_url":"https://api.github.com/users/caicloud/orgs","repos_url":"https://api.github.com/users/caicloud/repos","events_url":"https://api.github.com/users/caicloud/events{/privacy}","received_events_url":"https://api.github.com/users/caicloud/received_events","type":"Organization","site_admin":false},"repo":{"id":103636193,"name":"nirvana","full_name":"caicloud/nirvana","owner":{"login":"caicloud","id":12522124,"avatar_url":"https://avatars2.githubusercontent.com/u/12522124?v=4","gravatar_id":"","url":"https://api.github.com/users/caicloud","html_url":"https://github.com/caicloud","followers_url":"https://api.github.com/users/caicloud/followers","following_url":"https://api.github.com/users/caicloud/following{/other_user}","gists_url":"https://api.github.com/users/caicloud/gists{/gist_id}","starred_url":"https://api.github.com/users/caicloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caicloud/subscriptions","organizations_url":"https://api.github.com/users/caicloud/orgs","repos_url":"https://api.github.com/users/caicloud/repos","events_url":"https://api.github.com/users/caicloud/events{/privacy}","received_events_url":"https://api.github.com/users/caicloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caicloud/nirvana","description":"Golang Restful API Framework for Productivity","fork":false,"url":"https://api.github.com/repos/caicloud/nirvana","forks_url":"https://api.github.com/repos/caicloud/nirvana/forks","keys_url":"https://api.github.com/repos/caicloud/nirvana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caicloud/nirvana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caicloud/nirvana/teams","hooks_url":"https://api.github.com/repos/caicloud/nirvana/hooks","issue_events_url":"https://api.github.com/repos/caicloud/nirvana/issues/events{/number}","events_url":"https://api.github.com/repos/caicloud/nirvana/events","assignees_url":"https://api.github.com/repos/caicloud/nirvana/assignees{/user}","branches_url":"https://api.github.com/repos/caicloud/nirvana/branches{/branch}","tags_url":"https://api.github.com/repos/caicloud/nirvana/tags","blobs_url":"https://api.github.com/repos/caicloud/nirvana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caicloud/nirvana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caicloud/nirvana/git/refs{/sha}","trees_url":"https://api.github.com/repos/caicloud/nirvana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caicloud/nirvana/statuses/{sha}","languages_url":"https://api.github.com/repos/caicloud/nirvana/languages","stargazers_url":"https://api.github.com/repos/caicloud/nirvana/stargazers","contributors_url":"https://api.github.com/repos/caicloud/nirvana/contributors","subscribers_url":"https://api.github.com/repos/caicloud/nirvana/subscribers","subscription_url":"https://api.github.com/repos/caicloud/nirvana/subscription","commits_url":"https://api.github.com/repos/caicloud/nirvana/commits{/sha}","git_commits_url":"https://api.github.com/repos/caicloud/nirvana/git/commits{/sha}","comments_url":"https://api.github.com/repos/caicloud/nirvana/comments{/number}","issue_comment_url":"https://api.github.com/repos/caicloud/nirvana/issues/comments{/number}","contents_url":"https://api.github.com/repos/caicloud/nirvana/contents/{+path}","compare_url":"https://api.github.com/repos/caicloud/nirvana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caicloud/nirvana/merges","archive_url":"https://api.github.com/repos/caicloud/nirvana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caicloud/nirvana/downloads","issues_url":"https://api.github.com/repos/caicloud/nirvana/issues{/number}","pulls_url":"https://api.github.com/repos/caicloud/nirvana/pulls{/number}","milestones_url":"https://api.github.com/repos/caicloud/nirvana/milestones{/number}","notifications_url":"https://api.github.com/repos/caicloud/nirvana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caicloud/nirvana/labels{/name}","releases_url":"https://api.github.com/repos/caicloud/nirvana/releases{/id}","deployments_url":"https://api.github.com/repos/caicloud/nirvana/deployments","created_at":"2017-09-15T08:56:03Z","updated_at":"2018-04-08T08:40:03Z","pushed_at":"2018-04-04T07:53:07Z","git_url":"git://github.com/caicloud/nirvana.git","ssh_url":"git@github.com:caicloud/nirvana.git","clone_url":"https://github.com/caicloud/nirvana.git","svn_url":"https://github.com/caicloud/nirvana","homepage":"","size":7946,"stargazers_count":30,"watchers_count":30,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":13,"open_issues":24,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/caicloud/nirvana/pulls/199"},"html":{"href":"https://github.com/caicloud/nirvana/pull/199"},"issue":{"href":"https://api.github.com/repos/caicloud/nirvana/issues/199"},"comments":{"href":"https://api.github.com/repos/caicloud/nirvana/issues/199/comments"},"review_comments":{"href":"https://api.github.com/repos/caicloud/nirvana/pulls/199/comments"},"review_comment":{"href":"https://api.github.com/repos/caicloud/nirvana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/caicloud/nirvana/pulls/199/commits"},"statuses":{"href":"https://api.github.com/repos/caicloud/nirvana/statuses/a8577272d6775ed2de857afb16bf4b3c60e4c323"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"kdada"}}