{"action":"created","issue":{"url":"https://api.github.com/repos/MetaMask/KeyringController/issues/16","repository_url":"https://api.github.com/repos/MetaMask/KeyringController","labels_url":"https://api.github.com/repos/MetaMask/KeyringController/issues/16/labels{/name}","comments_url":"https://api.github.com/repos/MetaMask/KeyringController/issues/16/comments","events_url":"https://api.github.com/repos/MetaMask/KeyringController/issues/16/events","html_url":"https://github.com/MetaMask/KeyringController/pull/16","id":315958792,"number":16,"title":"Fix #persistAllKeyrings password binding","user":{"login":"whymarrh","id":1623628,"avatar_url":"https://avatars1.githubusercontent.com/u/1623628?v=4","gravatar_id":"","url":"https://api.github.com/users/whymarrh","html_url":"https://github.com/whymarrh","followers_url":"https://api.github.com/users/whymarrh/followers","following_url":"https://api.github.com/users/whymarrh/following{/other_user}","gists_url":"https://api.github.com/users/whymarrh/gists{/gist_id}","starred_url":"https://api.github.com/users/whymarrh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whymarrh/subscriptions","organizations_url":"https://api.github.com/users/whymarrh/orgs","repos_url":"https://api.github.com/users/whymarrh/repos","events_url":"https://api.github.com/users/whymarrh/events{/privacy}","received_events_url":"https://api.github.com/users/whymarrh/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-04-19T16:50:47Z","updated_at":"2018-04-20T21:07:29Z","closed_at":"2018-04-19T17:47:15Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/MetaMask/KeyringController/pulls/16","html_url":"https://github.com/MetaMask/KeyringController/pull/16","diff_url":"https://github.com/MetaMask/KeyringController/pull/16.diff","patch_url":"https://github.com/MetaMask/KeyringController/pull/16.patch"},"body":"This PR fixes the way the password value is bound for calls to `KeyringController#persistAllKeyrings`. The password argument was supposed to take on `this.password` when it was undefined, but `null` was being passed through via `#createFirstKeyTree`.\r\n\r\nIn the test cases, the call arg history for `#persistAllKeyrings` looked like so:\r\n\r\n```\r\n[ [ 'password123', [] ],\r\n  [ 'password123', [ [Object] ] ],\r\n  [ null, [ [Object] ] ],\r\n  [ 'password123', [ [Object] ] ],\r\n  [ 'password123', [ [Object] ] ],\r\n  [ null, [ [Object] ] ],\r\n  [ 'password123', [] ],\r\n  [ 'password123', [ [Object] ] ],\r\n  [ null, [ [Object] ] ],\r\n  [ 'password123', [ [Object] ] ],\r\n  [ 'password123', [ [Object] ] ],\r\n  [ null, [ [Object] ] ] ]\r\n```"},"comment":{"url":"https://api.github.com/repos/MetaMask/KeyringController/issues/comments/383222732","html_url":"https://github.com/MetaMask/KeyringController/pull/16#issuecomment-383222732","issue_url":"https://api.github.com/repos/MetaMask/KeyringController/issues/16","id":383222732,"user":{"login":"danfinlay","id":542863,"avatar_url":"https://avatars0.githubusercontent.com/u/542863?v=4","gravatar_id":"","url":"https://api.github.com/users/danfinlay","html_url":"https://github.com/danfinlay","followers_url":"https://api.github.com/users/danfinlay/followers","following_url":"https://api.github.com/users/danfinlay/following{/other_user}","gists_url":"https://api.github.com/users/danfinlay/gists{/gist_id}","starred_url":"https://api.github.com/users/danfinlay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danfinlay/subscriptions","organizations_url":"https://api.github.com/users/danfinlay/orgs","repos_url":"https://api.github.com/users/danfinlay/repos","events_url":"https://api.github.com/users/danfinlay/events{/privacy}","received_events_url":"https://api.github.com/users/danfinlay/received_events","type":"User","site_admin":false},"created_at":"2018-04-20T21:07:29Z","updated_at":"2018-04-20T21:07:29Z","author_association":"CONTRIBUTOR","body":"Published as `3.1.1`."}}
{"actor":{"display_login":"danfinlay"}}