{"action":"created","issue":{"url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/issues/1319","repository_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui","labels_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/issues/1319/labels{/name}","comments_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/issues/1319/comments","events_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/issues/1319/events","html_url":"https://github.com/pentaho/pentaho-platform-plugin-common-ui/pull/1319","id":365691630,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NTUyNTE5","number":1319,"title":"[BACKLOG-24643] Continuous axis for Simple Dates and Numbers in Scatter in Analyzer","user":{"login":"dcleao","id":284983,"node_id":"MDQ6VXNlcjI4NDk4Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/284983?v=4","gravatar_id":"","url":"https://api.github.com/users/dcleao","html_url":"https://github.com/dcleao","followers_url":"https://api.github.com/users/dcleao/followers","following_url":"https://api.github.com/users/dcleao/following{/other_user}","gists_url":"https://api.github.com/users/dcleao/gists{/gist_id}","starred_url":"https://api.github.com/users/dcleao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcleao/subscriptions","organizations_url":"https://api.github.com/users/dcleao/orgs","repos_url":"https://api.github.com/users/dcleao/repos","events_url":"https://api.github.com/users/dcleao/events{/privacy}","received_events_url":"https://api.github.com/users/dcleao/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-10-02T00:18:20Z","updated_at":"2018-10-04T20:42:48Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/pulls/1319","html_url":"https://github.com/pentaho/pentaho-platform-plugin-common-ui/pull/1319","diff_url":"https://github.com/pentaho/pentaho-platform-plugin-common-ui/pull/1319.diff","patch_url":"https://github.com/pentaho/pentaho-platform-plugin-common-ui/pull/1319.patch"},"body":"Viz API\r\n======\r\n- Added `pentaho/visual/role/util`\r\n  - Contains methods, adapted from DET's codebase, that allow testing for the validity of adding a field to a visual role (`testAddField` and `testAddFieldAtAutoPosition`).\r\n  - Also, these can discover the multiple valid visual roles where a field can be added to (`getValidRolesForAddingField`)and score the possibilities using an internal heuristic (`getBestRoleForAddingField`).\r\n- vizApi.conf.js\r\n  - Added configuration rule for `AbstractProperty`, to not allow key table columns in non-key visual roles (and vice-versa),\r\n    when the visualization has visualKeyType = dataKey.\r\n    This was added as a configuration rule, for Analyzer and DET, and not as direct code in `AbstractProperty`,\r\n    because, in CDF, data tables do not have the `isKey` column metadata.\r\n\r\nProperties Panel\r\n=============\r\n- Refactored the `GemBarUI` code (and of its accompanying classes, `GemBarUISource` and `PlaceholderSource`).\r\n- Removed a lot of dead code.\r\n- Removed code that was doing things already offered by the base class\r\n  (like using `current` and `before`, instead of `_getNodeUnderMouse` and `gravity`;\r\n  or using `onDraggingOver` and `onDraggingOut` instead of re-implementing these by overriding `onMouseOver`, `onMouseMove` and `onMouseOut`).\r\n- Simplified the code by replacing the drop-indicator line event redirection bits by much simpler CSS alternatives (`pointer-events:none`).\r\n- Fixed bug where drop indicator line would remain visible even after leaving the drop zone area, sometimes leading to multiple visible drop-indicator lines.\r\n- Fixed bug where the gem bar's over background color (_showOver) would not be activated until the mouse moved to a gem free area.\r\n- Fixed bug where the vertical position of the indicator line would change, whether it was closer to the before or the after gem;\r\n  it is now positioned exactly between the gems free space.\r\n- Fixed (leak) bug where for each mouse move, new, identical topic handlers were added to `dnd/cancel` and `dnd/drop` (see old `showIndicatorIfReorder`).\r\n- Adapted the `checkAcceptance` methods so that the drop position is passed through, so that position validation code can use it (as needed by the Viz. API).\r\n- Reduced the number of times that `checkAcceptance` code is called by only checking when the drop position actually changes, and not on every mouse move.\r\n- Removed dependency on Analyzer's `cv.util.gravity`.\r\n- Tidied up some cryptically written code.\r\n- Linted somewhat (like removing uses of the evil `with` operator!).\r\n- LayoutPanel.css\r\n  - Added `pointer-events:none` to drop-indicator line.\r\n  - Added padding-bottom: 0.1 to the gembar drop zone, to force it to contain the margins of the contained gems (collapsed margins).\r\n  - Fixed position of the ruler of the drop line indicator, which appeared slightly over the bullet.\r\n  - Exchanged most of the gembar's top padding by the gem's margin-top. This way, dragging starts sooner, when coming from above.\r\n\r\n@bennychow, @pentaho/millenniumfalcon please review.\r\n\r\nMerge with:\r\n* https://github.com/pentaho/pentaho-analyzer/pull/1854\r\n* https://github.com/pentaho/pentaho-commons-gwt-modules/pull/694\r\n\r\nUnit tests are still needed."},"comment":{"url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/issues/comments/427162279","html_url":"https://github.com/pentaho/pentaho-platform-plugin-common-ui/pull/1319#issuecomment-427162279","issue_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/issues/1319","id":427162279,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzE2MjI3OQ==","user":{"login":"wingman-pentaho","id":18704365,"node_id":"MDQ6VXNlcjE4NzA0MzY1","avatar_url":"https://avatars1.githubusercontent.com/u/18704365?v=4","gravatar_id":"","url":"https://api.github.com/users/wingman-pentaho","html_url":"https://github.com/wingman-pentaho","followers_url":"https://api.github.com/users/wingman-pentaho/followers","following_url":"https://api.github.com/users/wingman-pentaho/following{/other_user}","gists_url":"https://api.github.com/users/wingman-pentaho/gists{/gist_id}","starred_url":"https://api.github.com/users/wingman-pentaho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wingman-pentaho/subscriptions","organizations_url":"https://api.github.com/users/wingman-pentaho/orgs","repos_url":"https://api.github.com/users/wingman-pentaho/repos","events_url":"https://api.github.com/users/wingman-pentaho/events{/privacy}","received_events_url":"https://api.github.com/users/wingman-pentaho/received_events","type":"User","site_admin":false},"created_at":"2018-10-04T20:42:48Z","updated_at":"2018-10-04T20:42:48Z","author_association":"NONE","body":"### Build Completed\n\n:white_check_mark: This pull request has passed all validations.\n\n#### Build Commands\n\n```sh\nmvn -B -f 'pom.xml' -pl 'impl/client' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install\n```\n\n#### Cleanup Commands\n```sh\nmvn -B -f 'pom.xml' -pl 'impl/client' -P '!assemblies' -amd build-helper:remove-project-artifact\n```\n\n#### Changed files\n\n```console\n  assemblies/webpackage/src/main/resources-filtered/common-ui/preconfig.js\n  impl/client/src/main/doc-js/pentaho/visual/role/IAddUsage.jsdoc\n  impl/client/src/main/javascript/web/dojo/dijit/themes/pentaho/layout/LayoutPanel.css\n  impl/client/src/main/javascript/web/dojo/pentaho/common/propertiesPanel/Configuration.js\n  impl/client/src/main/javascript/web/dojo/pentaho/common/propertiesPanel/Panel.js\n  impl/client/src/main/javascript/web/pentaho/platformBundle.js\n  impl/client/src/main/javascript/web/pentaho/type/List.js\n  impl/client/src/main/javascript/web/pentaho/visual/config/vizApi.conf.js\n  impl/client/src/main/javascript/web/pentaho/visual/role/AbstractProperty.js\n  impl/client/src/main/javascript/web/pentaho/visual/role/util.js\n  impl/client/src/main/resources-filtered/web/common-ui-require-js-cfg.js\n  impl/client/src/test/javascript/pentaho/visual/role/util.spec.js\n```"}}
{"actor":{"display_login":"wingman-pentaho"}}