{"action":"created","comment":{"url":"https://api.github.com/repos/aws/amazon-ecs-cli/pulls/comments/204570058","pull_request_review_id":139671778,"id":204570058,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDU3MDA1OA==","diff_hunk":"@@ -0,0 +1,82 @@\n+// Copyright 2015-2017 Amazon.com, Inc. or its affiliates. All Rights Reserved.\n+//\n+// Licensed under the Apache License, Version 2.0 (the \"License\"). You may\n+// not use this file except in compliance with the License. A copy of the\n+// License is located at\n+//\n+//  http://aws.amazon.com/apache2.0/\n+//\n+// or in the \"license\" file accompanying this file. This file is distributed\n+// on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either\n+// express or implied. See the License for the specific language governing\n+// permissions and limitations under the License.\n+\n+package cloudformation\n+\n+func GetSDSTemplate() string {\n+\treturn sds_template\n+}\n+\n+var sds_template = `\n+{\n+  \"AWSTemplateFormatVersion\": \"2010-09-09\",\n+  \"Description\": \"AWS CloudFormation template to create a private dns namespace to enable ECS Service Discovery.\",\n+  \"Parameters\": {\n+    \"SDSDescription\": {\n+      \"Type\": \"String\",\n+      \"Description\": \"The description of the private dns namespace\",\n+      \"Default\": \"Created by the Amazon ECS CLI\"\n+    },\n+    \"SDSName\": {\n+      \"Type\": \"String\",\n+      \"Description\": \"The name of the Service Discovery Service\",\n+      \"Default\": \"\"\n+    },\n+    \"NamespaceID\": {\n+      \"Type\": \"String\",\n+      \"Description\": \"The ID of the namespace that you want to use for DNS configuration\",\n+      \"Default\": \"\"\n+    },\n+    \"DNSType\": {\n+      \"Type\": \"String\",\n+      \"Description\": \"The DNS type of the record that you want Route 53 to create.\",\n+      \"Default\": \"\"\n+    },\n+    \"DNSTTL\": {\n+      \"Type\": \"String\",\n+      \"Description\": \"The amount of time, in seconds, that you want DNS resolvers to cache the settings for this record.\",\n+      \"Default\": \"\"","path":"ecs-cli/modules/clients/aws/cloudformation/sds_template.go","position":48,"original_position":48,"commit_id":"1173c9093074a4275792a0e6542120ce152c568a","original_commit_id":"1173c9093074a4275792a0e6542120ce152c568a","user":{"login":"SoManyHs","id":29964746,"node_id":"MDQ6VXNlcjI5OTY0NzQ2","avatar_url":"https://avatars0.githubusercontent.com/u/29964746?v=4","gravatar_id":"","url":"https://api.github.com/users/SoManyHs","html_url":"https://github.com/SoManyHs","followers_url":"https://api.github.com/users/SoManyHs/followers","following_url":"https://api.github.com/users/SoManyHs/following{/other_user}","gists_url":"https://api.github.com/users/SoManyHs/gists{/gist_id}","starred_url":"https://api.github.com/users/SoManyHs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SoManyHs/subscriptions","organizations_url":"https://api.github.com/users/SoManyHs/orgs","repos_url":"https://api.github.com/users/SoManyHs/repos","events_url":"https://api.github.com/users/SoManyHs/events{/privacy}","received_events_url":"https://api.github.com/users/SoManyHs/received_events","type":"User","site_admin":false},"body":"Default is 60?","created_at":"2018-07-23T22:12:40Z","updated_at":"2018-07-23T22:13:34Z","html_url":"https://github.com/aws/amazon-ecs-cli/pull/566#discussion_r204570058","pull_request_url":"https://api.github.com/repos/aws/amazon-ecs-cli/pulls/566","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/aws/amazon-ecs-cli/pulls/comments/204570058"},"html":{"href":"https://github.com/aws/amazon-ecs-cli/pull/566#discussion_r204570058"},"pull_request":{"href":"https://api.github.com/repos/aws/amazon-ecs-cli/pulls/566"}}},"pull_request":{"url":"https://api.github.com/repos/aws/amazon-ecs-cli/pulls/566","id":203318097,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMzE4MDk3","html_url":"https://github.com/aws/amazon-ecs-cli/pull/566","diff_url":"https://github.com/aws/amazon-ecs-cli/pull/566.diff","patch_url":"https://github.com/aws/amazon-ecs-cli/pull/566.patch","issue_url":"https://api.github.com/repos/aws/amazon-ecs-cli/issues/566","number":566,"state":"open","locked":false,"title":"Refactor CFN Client and add Service Discovery CFN templates","user":{"login":"PettitWesley","id":29443996,"node_id":"MDQ6VXNlcjI5NDQzOTk2","avatar_url":"https://avatars0.githubusercontent.com/u/29443996?v=4","gravatar_id":"","url":"https://api.github.com/users/PettitWesley","html_url":"https://github.com/PettitWesley","followers_url":"https://api.github.com/users/PettitWesley/followers","following_url":"https://api.github.com/users/PettitWesley/following{/other_user}","gists_url":"https://api.github.com/users/PettitWesley/gists{/gist_id}","starred_url":"https://api.github.com/users/PettitWesley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PettitWesley/subscriptions","organizations_url":"https://api.github.com/users/PettitWesley/orgs","repos_url":"https://api.github.com/users/PettitWesley/repos","events_url":"https://api.github.com/users/PettitWesley/events{/privacy}","received_events_url":"https://api.github.com/users/PettitWesley/received_events","type":"User","site_admin":false},"body":"*Description of changes:*\r\nRefactored CloudFormation client and params to be generic so that they can be used by the service discovery implementation- previously they were specific to the cluster up workflow. Also added the CFN templates for private dns namespace and service discovery service.\r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.\r\n","created_at":"2018-07-23T19:23:09Z","updated_at":"2018-07-23T22:13:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bbf93877bed2353e1fd794f8f40b6248cd3b75a9","assignee":null,"assignees":[],"requested_reviewers":[{"login":"allisaurus","id":34254888,"node_id":"MDQ6VXNlcjM0MjU0ODg4","avatar_url":"https://avatars1.githubusercontent.com/u/34254888?v=4","gravatar_id":"","url":"https://api.github.com/users/allisaurus","html_url":"https://github.com/allisaurus","followers_url":"https://api.github.com/users/allisaurus/followers","following_url":"https://api.github.com/users/allisaurus/following{/other_user}","gists_url":"https://api.github.com/users/allisaurus/gists{/gist_id}","starred_url":"https://api.github.com/users/allisaurus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allisaurus/subscriptions","organizations_url":"https://api.github.com/users/allisaurus/orgs","repos_url":"https://api.github.com/users/allisaurus/repos","events_url":"https://api.github.com/users/allisaurus/events{/privacy}","received_events_url":"https://api.github.com/users/allisaurus/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aws/amazon-ecs-cli/pulls/566/commits","review_comments_url":"https://api.github.com/repos/aws/amazon-ecs-cli/pulls/566/comments","review_comment_url":"https://api.github.com/repos/aws/amazon-ecs-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aws/amazon-ecs-cli/issues/566/comments","statuses_url":"https://api.github.com/repos/aws/amazon-ecs-cli/statuses/1173c9093074a4275792a0e6542120ce152c568a","head":{"label":"aws:sdcloudformation","ref":"sdcloudformation","sha":"1173c9093074a4275792a0e6542120ce152c568a","user":{"login":"aws","id":2232217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzIyMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"repo":{"id":43446846,"node_id":"MDEwOlJlcG9zaXRvcnk0MzQ0Njg0Ng==","name":"amazon-ecs-cli","full_name":"aws/amazon-ecs-cli","owner":{"login":"aws","id":2232217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzIyMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aws/amazon-ecs-cli","description":"A custom Amazon ECS CLI that eases up the cluster setup process, enables users to run their applications locally or on ECS using the same Docker Compose file format and familiar Compose commands. ","fork":false,"url":"https://api.github.com/repos/aws/amazon-ecs-cli","forks_url":"https://api.github.com/repos/aws/amazon-ecs-cli/forks","keys_url":"https://api.github.com/repos/aws/amazon-ecs-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aws/amazon-ecs-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aws/amazon-ecs-cli/teams","hooks_url":"https://api.github.com/repos/aws/amazon-ecs-cli/hooks","issue_events_url":"https://api.github.com/repos/aws/amazon-ecs-cli/issues/events{/number}","events_url":"https://api.github.com/repos/aws/amazon-ecs-cli/events","assignees_url":"https://api.github.com/repos/aws/amazon-ecs-cli/assignees{/user}","branches_url":"https://api.github.com/repos/aws/amazon-ecs-cli/branches{/branch}","tags_url":"https://api.github.com/repos/aws/amazon-ecs-cli/tags","blobs_url":"https://api.github.com/repos/aws/amazon-ecs-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aws/amazon-ecs-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aws/amazon-ecs-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/aws/amazon-ecs-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aws/amazon-ecs-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/aws/amazon-ecs-cli/languages","stargazers_url":"https://api.github.com/repos/aws/amazon-ecs-cli/stargazers","contributors_url":"https://api.github.com/repos/aws/amazon-ecs-cli/contributors","subscribers_url":"https://api.github.com/repos/aws/amazon-ecs-cli/subscribers","subscription_url":"https://api.github.com/repos/aws/amazon-ecs-cli/subscription","commits_url":"https://api.github.com/repos/aws/amazon-ecs-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/aws/amazon-ecs-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/aws/amazon-ecs-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/aws/amazon-ecs-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/aws/amazon-ecs-cli/contents/{+path}","compare_url":"https://api.github.com/repos/aws/amazon-ecs-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aws/amazon-ecs-cli/merges","archive_url":"https://api.github.com/repos/aws/amazon-ecs-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aws/amazon-ecs-cli/downloads","issues_url":"https://api.github.com/repos/aws/amazon-ecs-cli/issues{/number}","pulls_url":"https://api.github.com/repos/aws/amazon-ecs-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/aws/amazon-ecs-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/aws/amazon-ecs-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aws/amazon-ecs-cli/labels{/name}","releases_url":"https://api.github.com/repos/aws/amazon-ecs-cli/releases{/id}","deployments_url":"https://api.github.com/repos/aws/amazon-ecs-cli/deployments","created_at":"2015-09-30T17:11:40Z","updated_at":"2018-07-22T09:56:54Z","pushed_at":"2018-07-23T19:23:09Z","git_url":"git://github.com/aws/amazon-ecs-cli.git","ssh_url":"git@github.com:aws/amazon-ecs-cli.git","clone_url":"https://github.com/aws/amazon-ecs-cli.git","svn_url":"https://github.com/aws/amazon-ecs-cli","homepage":null,"size":10629,"stargazers_count":947,"watchers_count":947,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":161,"mirror_url":null,"archived":false,"open_issues_count":53,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":161,"open_issues":53,"watchers":947,"default_branch":"master"}},"base":{"label":"aws:dev","ref":"dev","sha":"8d2b4b334f37a72ce1444e253db21aba566064a9","user":{"login":"aws","id":2232217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzIyMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"repo":{"id":43446846,"node_id":"MDEwOlJlcG9zaXRvcnk0MzQ0Njg0Ng==","name":"amazon-ecs-cli","full_name":"aws/amazon-ecs-cli","owner":{"login":"aws","id":2232217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzIyMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aws/amazon-ecs-cli","description":"A custom Amazon ECS CLI that eases up the cluster setup process, enables users to run their applications locally or on ECS using the same Docker Compose file format and familiar Compose commands. ","fork":false,"url":"https://api.github.com/repos/aws/amazon-ecs-cli","forks_url":"https://api.github.com/repos/aws/amazon-ecs-cli/forks","keys_url":"https://api.github.com/repos/aws/amazon-ecs-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aws/amazon-ecs-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aws/amazon-ecs-cli/teams","hooks_url":"https://api.github.com/repos/aws/amazon-ecs-cli/hooks","issue_events_url":"https://api.github.com/repos/aws/amazon-ecs-cli/issues/events{/number}","events_url":"https://api.github.com/repos/aws/amazon-ecs-cli/events","assignees_url":"https://api.github.com/repos/aws/amazon-ecs-cli/assignees{/user}","branches_url":"https://api.github.com/repos/aws/amazon-ecs-cli/branches{/branch}","tags_url":"https://api.github.com/repos/aws/amazon-ecs-cli/tags","blobs_url":"https://api.github.com/repos/aws/amazon-ecs-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aws/amazon-ecs-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aws/amazon-ecs-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/aws/amazon-ecs-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aws/amazon-ecs-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/aws/amazon-ecs-cli/languages","stargazers_url":"https://api.github.com/repos/aws/amazon-ecs-cli/stargazers","contributors_url":"https://api.github.com/repos/aws/amazon-ecs-cli/contributors","subscribers_url":"https://api.github.com/repos/aws/amazon-ecs-cli/subscribers","subscription_url":"https://api.github.com/repos/aws/amazon-ecs-cli/subscription","commits_url":"https://api.github.com/repos/aws/amazon-ecs-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/aws/amazon-ecs-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/aws/amazon-ecs-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/aws/amazon-ecs-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/aws/amazon-ecs-cli/contents/{+path}","compare_url":"https://api.github.com/repos/aws/amazon-ecs-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aws/amazon-ecs-cli/merges","archive_url":"https://api.github.com/repos/aws/amazon-ecs-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aws/amazon-ecs-cli/downloads","issues_url":"https://api.github.com/repos/aws/amazon-ecs-cli/issues{/number}","pulls_url":"https://api.github.com/repos/aws/amazon-ecs-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/aws/amazon-ecs-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/aws/amazon-ecs-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aws/amazon-ecs-cli/labels{/name}","releases_url":"https://api.github.com/repos/aws/amazon-ecs-cli/releases{/id}","deployments_url":"https://api.github.com/repos/aws/amazon-ecs-cli/deployments","created_at":"2015-09-30T17:11:40Z","updated_at":"2018-07-22T09:56:54Z","pushed_at":"2018-07-23T19:23:09Z","git_url":"git://github.com/aws/amazon-ecs-cli.git","ssh_url":"git@github.com:aws/amazon-ecs-cli.git","clone_url":"https://github.com/aws/amazon-ecs-cli.git","svn_url":"https://github.com/aws/amazon-ecs-cli","homepage":null,"size":10629,"stargazers_count":947,"watchers_count":947,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":161,"mirror_url":null,"archived":false,"open_issues_count":53,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":161,"open_issues":53,"watchers":947,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aws/amazon-ecs-cli/pulls/566"},"html":{"href":"https://github.com/aws/amazon-ecs-cli/pull/566"},"issue":{"href":"https://api.github.com/repos/aws/amazon-ecs-cli/issues/566"},"comments":{"href":"https://api.github.com/repos/aws/amazon-ecs-cli/issues/566/comments"},"review_comments":{"href":"https://api.github.com/repos/aws/amazon-ecs-cli/pulls/566/comments"},"review_comment":{"href":"https://api.github.com/repos/aws/amazon-ecs-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aws/amazon-ecs-cli/pulls/566/commits"},"statuses":{"href":"https://api.github.com/repos/aws/amazon-ecs-cli/statuses/1173c9093074a4275792a0e6542120ce152c568a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"SoManyHs"}}