{"action":"created","comment":{"url":"https://api.github.com/repos/DGtal-team/DGtal/pulls/comments/245481966","pull_request_review_id":189601438,"id":245481966,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTQ4MTk2Ng==","diff_hunk":"@@ -240,7 +242,7 @@ class VoxelComplex : public CubicalComplex<TKSpace, TCellContainer> {\n      * Insert cell (voxel) in the khalimsky space AND in the object set.\n      *\n      * @param kcell input voxel\n-     * @param close_it if true, apply @ref voxelClose.\n+     * @param close_it if true, apply @voxelClose.","path":"src/DGtal/topology/VoxelComplex.h","position":104,"original_position":104,"commit_id":"b2c35c1a0ac3e1ae1ad85ef12f93937a80226a81","original_commit_id":"b2c35c1a0ac3e1ae1ad85ef12f93937a80226a81","user":{"login":"dcoeurjo","id":700165,"node_id":"MDQ6VXNlcjcwMDE2NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/700165?v=4","gravatar_id":"","url":"https://api.github.com/users/dcoeurjo","html_url":"https://github.com/dcoeurjo","followers_url":"https://api.github.com/users/dcoeurjo/followers","following_url":"https://api.github.com/users/dcoeurjo/following{/other_user}","gists_url":"https://api.github.com/users/dcoeurjo/gists{/gist_id}","starred_url":"https://api.github.com/users/dcoeurjo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcoeurjo/subscriptions","organizations_url":"https://api.github.com/users/dcoeurjo/orgs","repos_url":"https://api.github.com/users/dcoeurjo/repos","events_url":"https://api.github.com/users/dcoeurjo/events{/privacy}","received_events_url":"https://api.github.com/users/dcoeurjo/received_events","type":"User","site_admin":false},"body":"Not working apparently. You should keep the @ref.\r\n\r\n<img width=\"512\" alt=\"capture d ecran 2019-01-05 a 17 33 22\" src=\"https://user-images.githubusercontent.com/700165/50726618-01de3700-1110-11e9-9ecf-9b4d8f13e134.png\">\r\n","created_at":"2019-01-05T16:34:04Z","updated_at":"2019-01-05T16:34:04Z","html_url":"https://github.com/DGtal-team/DGtal/pull/1369#discussion_r245481966","pull_request_url":"https://api.github.com/repos/DGtal-team/DGtal/pulls/1369","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/DGtal-team/DGtal/pulls/comments/245481966"},"html":{"href":"https://github.com/DGtal-team/DGtal/pull/1369#discussion_r245481966"},"pull_request":{"href":"https://api.github.com/repos/DGtal-team/DGtal/pulls/1369"}},"in_reply_to_id":245481469},"pull_request":{"url":"https://api.github.com/repos/DGtal-team/DGtal/pulls/1369","id":234786558,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0Nzg2NTU4","html_url":"https://github.com/DGtal-team/DGtal/pull/1369","diff_url":"https://github.com/DGtal-team/DGtal/pull/1369.diff","patch_url":"https://github.com/DGtal-team/DGtal/pull/1369.patch","issue_url":"https://api.github.com/repos/DGtal-team/DGtal/issues/1369","number":1369,"state":"open","locked":false,"title":"Remove Object from VoxelComplex","user":{"login":"phcerdan","id":3021667,"node_id":"MDQ6VXNlcjMwMjE2Njc=","avatar_url":"https://avatars1.githubusercontent.com/u/3021667?v=4","gravatar_id":"","url":"https://api.github.com/users/phcerdan","html_url":"https://github.com/phcerdan","followers_url":"https://api.github.com/users/phcerdan/followers","following_url":"https://api.github.com/users/phcerdan/following{/other_user}","gists_url":"https://api.github.com/users/phcerdan/gists{/gist_id}","starred_url":"https://api.github.com/users/phcerdan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phcerdan/subscriptions","organizations_url":"https://api.github.com/users/phcerdan/orgs","repos_url":"https://api.github.com/users/phcerdan/repos","events_url":"https://api.github.com/users/phcerdan/events{/privacy}","received_events_url":"https://api.github.com/users/phcerdan/received_events","type":"User","site_admin":false},"body":"This drops the runtime by ~4x (orientative)\r\nAnd the memory usage (not quantified).\r\n\r\nAlso reduce time of testing. Fix #1347\r\n\r\n- [x] Unit-test of your feature with [Catch](http://dgtal.org/doc/stable/moduleCatch.html).\r\n- [NA] Doxygen documentation of the code completed (classes, methods, types, members...)\r\n- [x] Documentation module page added or updated.\r\n- [x] New entry in the [ChangeLog.md](https://github.com/DGtal-team/DGtal/blob/master/ChangeLog.md) added.\r\n- [x] No warning raised in Debug ```cmake``` mode (otherwise, Travis C.I. will fail).\r\n- [x] All continuous integration tests pass (Travis & appveyor)","created_at":"2018-11-29T21:08:16Z","updated_at":"2019-01-05T16:34:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c2085d6531c4fe2602fcc3d3d2b7b88daa0c8be","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":105407,"node_id":"MDU6TGFiZWwxMDU0MDc=","url":"https://api.github.com/repos/DGtal-team/DGtal/labels/Topology","name":"Topology","color":"0b02e1","default":false},{"id":180300329,"node_id":"MDU6TGFiZWwxODAzMDAzMjk=","url":"https://api.github.com/repos/DGtal-team/DGtal/labels/waiting%20author%20feedbacks","name":"waiting author feedbacks","color":"eb6420","default":false}],"milestone":{"url":"https://api.github.com/repos/DGtal-team/DGtal/milestones/6","html_url":"https://github.com/DGtal-team/DGtal/milestone/6","labels_url":"https://api.github.com/repos/DGtal-team/DGtal/milestones/6/labels","id":232409,"node_id":"MDk6TWlsZXN0b25lMjMyNDA5","number":6,"title":"1.0","description":"","creator":{"login":"dcoeurjo","id":700165,"node_id":"MDQ6VXNlcjcwMDE2NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/700165?v=4","gravatar_id":"","url":"https://api.github.com/users/dcoeurjo","html_url":"https://github.com/dcoeurjo","followers_url":"https://api.github.com/users/dcoeurjo/followers","following_url":"https://api.github.com/users/dcoeurjo/following{/other_user}","gists_url":"https://api.github.com/users/dcoeurjo/gists{/gist_id}","starred_url":"https://api.github.com/users/dcoeurjo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcoeurjo/subscriptions","organizations_url":"https://api.github.com/users/dcoeurjo/orgs","repos_url":"https://api.github.com/users/dcoeurjo/repos","events_url":"https://api.github.com/users/dcoeurjo/events{/privacy}","received_events_url":"https://api.github.com/users/dcoeurjo/received_events","type":"User","site_admin":false},"open_issues":28,"closed_issues":23,"state":"open","created_at":"2012-12-19T09:20:29Z","updated_at":"2019-01-05T16:21:53Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/DGtal-team/DGtal/pulls/1369/commits","review_comments_url":"https://api.github.com/repos/DGtal-team/DGtal/pulls/1369/comments","review_comment_url":"https://api.github.com/repos/DGtal-team/DGtal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DGtal-team/DGtal/issues/1369/comments","statuses_url":"https://api.github.com/repos/DGtal-team/DGtal/statuses/b2c35c1a0ac3e1ae1ad85ef12f93937a80226a81","head":{"label":"phcerdan:remove_object_from_voxel_complex","ref":"remove_object_from_voxel_complex","sha":"b2c35c1a0ac3e1ae1ad85ef12f93937a80226a81","user":{"login":"phcerdan","id":3021667,"node_id":"MDQ6VXNlcjMwMjE2Njc=","avatar_url":"https://avatars1.githubusercontent.com/u/3021667?v=4","gravatar_id":"","url":"https://api.github.com/users/phcerdan","html_url":"https://github.com/phcerdan","followers_url":"https://api.github.com/users/phcerdan/followers","following_url":"https://api.github.com/users/phcerdan/following{/other_user}","gists_url":"https://api.github.com/users/phcerdan/gists{/gist_id}","starred_url":"https://api.github.com/users/phcerdan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phcerdan/subscriptions","organizations_url":"https://api.github.com/users/phcerdan/orgs","repos_url":"https://api.github.com/users/phcerdan/repos","events_url":"https://api.github.com/users/phcerdan/events{/privacy}","received_events_url":"https://api.github.com/users/phcerdan/received_events","type":"User","site_admin":false},"repo":{"id":49093672,"node_id":"MDEwOlJlcG9zaXRvcnk0OTA5MzY3Mg==","name":"DGtal","full_name":"phcerdan/DGtal","private":false,"owner":{"login":"phcerdan","id":3021667,"node_id":"MDQ6VXNlcjMwMjE2Njc=","avatar_url":"https://avatars1.githubusercontent.com/u/3021667?v=4","gravatar_id":"","url":"https://api.github.com/users/phcerdan","html_url":"https://github.com/phcerdan","followers_url":"https://api.github.com/users/phcerdan/followers","following_url":"https://api.github.com/users/phcerdan/following{/other_user}","gists_url":"https://api.github.com/users/phcerdan/gists{/gist_id}","starred_url":"https://api.github.com/users/phcerdan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phcerdan/subscriptions","organizations_url":"https://api.github.com/users/phcerdan/orgs","repos_url":"https://api.github.com/users/phcerdan/repos","events_url":"https://api.github.com/users/phcerdan/events{/privacy}","received_events_url":"https://api.github.com/users/phcerdan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/phcerdan/DGtal","description":"Digital Geometry Tools and Algorithm Library","fork":true,"url":"https://api.github.com/repos/phcerdan/DGtal","forks_url":"https://api.github.com/repos/phcerdan/DGtal/forks","keys_url":"https://api.github.com/repos/phcerdan/DGtal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phcerdan/DGtal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phcerdan/DGtal/teams","hooks_url":"https://api.github.com/repos/phcerdan/DGtal/hooks","issue_events_url":"https://api.github.com/repos/phcerdan/DGtal/issues/events{/number}","events_url":"https://api.github.com/repos/phcerdan/DGtal/events","assignees_url":"https://api.github.com/repos/phcerdan/DGtal/assignees{/user}","branches_url":"https://api.github.com/repos/phcerdan/DGtal/branches{/branch}","tags_url":"https://api.github.com/repos/phcerdan/DGtal/tags","blobs_url":"https://api.github.com/repos/phcerdan/DGtal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phcerdan/DGtal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phcerdan/DGtal/git/refs{/sha}","trees_url":"https://api.github.com/repos/phcerdan/DGtal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phcerdan/DGtal/statuses/{sha}","languages_url":"https://api.github.com/repos/phcerdan/DGtal/languages","stargazers_url":"https://api.github.com/repos/phcerdan/DGtal/stargazers","contributors_url":"https://api.github.com/repos/phcerdan/DGtal/contributors","subscribers_url":"https://api.github.com/repos/phcerdan/DGtal/subscribers","subscription_url":"https://api.github.com/repos/phcerdan/DGtal/subscription","commits_url":"https://api.github.com/repos/phcerdan/DGtal/commits{/sha}","git_commits_url":"https://api.github.com/repos/phcerdan/DGtal/git/commits{/sha}","comments_url":"https://api.github.com/repos/phcerdan/DGtal/comments{/number}","issue_comment_url":"https://api.github.com/repos/phcerdan/DGtal/issues/comments{/number}","contents_url":"https://api.github.com/repos/phcerdan/DGtal/contents/{+path}","compare_url":"https://api.github.com/repos/phcerdan/DGtal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phcerdan/DGtal/merges","archive_url":"https://api.github.com/repos/phcerdan/DGtal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phcerdan/DGtal/downloads","issues_url":"https://api.github.com/repos/phcerdan/DGtal/issues{/number}","pulls_url":"https://api.github.com/repos/phcerdan/DGtal/pulls{/number}","milestones_url":"https://api.github.com/repos/phcerdan/DGtal/milestones{/number}","notifications_url":"https://api.github.com/repos/phcerdan/DGtal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phcerdan/DGtal/labels{/name}","releases_url":"https://api.github.com/repos/phcerdan/DGtal/releases{/id}","deployments_url":"https://api.github.com/repos/phcerdan/DGtal/deployments","created_at":"2016-01-05T21:25:11Z","updated_at":"2018-12-30T18:41:13Z","pushed_at":"2018-12-30T18:57:24Z","git_url":"git://github.com/phcerdan/DGtal.git","ssh_url":"git@github.com:phcerdan/DGtal.git","clone_url":"https://github.com/phcerdan/DGtal.git","svn_url":"https://github.com/phcerdan/DGtal","homepage":"http://dgtal.org","size":196615,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DGtal-team:master","ref":"master","sha":"60e0e2b16cfefe0ac883bb343296d58f13eed105","user":{"login":"DGtal-team","id":1013900,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTM5MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/1013900?v=4","gravatar_id":"","url":"https://api.github.com/users/DGtal-team","html_url":"https://github.com/DGtal-team","followers_url":"https://api.github.com/users/DGtal-team/followers","following_url":"https://api.github.com/users/DGtal-team/following{/other_user}","gists_url":"https://api.github.com/users/DGtal-team/gists{/gist_id}","starred_url":"https://api.github.com/users/DGtal-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DGtal-team/subscriptions","organizations_url":"https://api.github.com/users/DGtal-team/orgs","repos_url":"https://api.github.com/users/DGtal-team/repos","events_url":"https://api.github.com/users/DGtal-team/events{/privacy}","received_events_url":"https://api.github.com/users/DGtal-team/received_events","type":"Organization","site_admin":false},"repo":{"id":1709095,"node_id":"MDEwOlJlcG9zaXRvcnkxNzA5MDk1","name":"DGtal","full_name":"DGtal-team/DGtal","private":false,"owner":{"login":"DGtal-team","id":1013900,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTM5MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/1013900?v=4","gravatar_id":"","url":"https://api.github.com/users/DGtal-team","html_url":"https://github.com/DGtal-team","followers_url":"https://api.github.com/users/DGtal-team/followers","following_url":"https://api.github.com/users/DGtal-team/following{/other_user}","gists_url":"https://api.github.com/users/DGtal-team/gists{/gist_id}","starred_url":"https://api.github.com/users/DGtal-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DGtal-team/subscriptions","organizations_url":"https://api.github.com/users/DGtal-team/orgs","repos_url":"https://api.github.com/users/DGtal-team/repos","events_url":"https://api.github.com/users/DGtal-team/events{/privacy}","received_events_url":"https://api.github.com/users/DGtal-team/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DGtal-team/DGtal","description":"Digital Geometry Tools and Algorithm Library","fork":false,"url":"https://api.github.com/repos/DGtal-team/DGtal","forks_url":"https://api.github.com/repos/DGtal-team/DGtal/forks","keys_url":"https://api.github.com/repos/DGtal-team/DGtal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DGtal-team/DGtal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DGtal-team/DGtal/teams","hooks_url":"https://api.github.com/repos/DGtal-team/DGtal/hooks","issue_events_url":"https://api.github.com/repos/DGtal-team/DGtal/issues/events{/number}","events_url":"https://api.github.com/repos/DGtal-team/DGtal/events","assignees_url":"https://api.github.com/repos/DGtal-team/DGtal/assignees{/user}","branches_url":"https://api.github.com/repos/DGtal-team/DGtal/branches{/branch}","tags_url":"https://api.github.com/repos/DGtal-team/DGtal/tags","blobs_url":"https://api.github.com/repos/DGtal-team/DGtal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DGtal-team/DGtal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DGtal-team/DGtal/git/refs{/sha}","trees_url":"https://api.github.com/repos/DGtal-team/DGtal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DGtal-team/DGtal/statuses/{sha}","languages_url":"https://api.github.com/repos/DGtal-team/DGtal/languages","stargazers_url":"https://api.github.com/repos/DGtal-team/DGtal/stargazers","contributors_url":"https://api.github.com/repos/DGtal-team/DGtal/contributors","subscribers_url":"https://api.github.com/repos/DGtal-team/DGtal/subscribers","subscription_url":"https://api.github.com/repos/DGtal-team/DGtal/subscription","commits_url":"https://api.github.com/repos/DGtal-team/DGtal/commits{/sha}","git_commits_url":"https://api.github.com/repos/DGtal-team/DGtal/git/commits{/sha}","comments_url":"https://api.github.com/repos/DGtal-team/DGtal/comments{/number}","issue_comment_url":"https://api.github.com/repos/DGtal-team/DGtal/issues/comments{/number}","contents_url":"https://api.github.com/repos/DGtal-team/DGtal/contents/{+path}","compare_url":"https://api.github.com/repos/DGtal-team/DGtal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DGtal-team/DGtal/merges","archive_url":"https://api.github.com/repos/DGtal-team/DGtal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DGtal-team/DGtal/downloads","issues_url":"https://api.github.com/repos/DGtal-team/DGtal/issues{/number}","pulls_url":"https://api.github.com/repos/DGtal-team/DGtal/pulls{/number}","milestones_url":"https://api.github.com/repos/DGtal-team/DGtal/milestones{/number}","notifications_url":"https://api.github.com/repos/DGtal-team/DGtal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DGtal-team/DGtal/labels{/name}","releases_url":"https://api.github.com/repos/DGtal-team/DGtal/releases{/id}","deployments_url":"https://api.github.com/repos/DGtal-team/DGtal/deployments","created_at":"2011-05-06T00:20:52Z","updated_at":"2019-01-02T07:40:23Z","pushed_at":"2018-12-30T18:57:25Z","git_url":"git://github.com/DGtal-team/DGtal.git","ssh_url":"git@github.com:DGtal-team/DGtal.git","clone_url":"https://github.com/DGtal-team/DGtal.git","svn_url":"https://github.com/DGtal-team/DGtal","homepage":"http://dgtal.org","size":195219,"stargazers_count":116,"watchers_count":116,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":63,"mirror_url":null,"archived":false,"open_issues_count":55,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":63,"open_issues":55,"watchers":116,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DGtal-team/DGtal/pulls/1369"},"html":{"href":"https://github.com/DGtal-team/DGtal/pull/1369"},"issue":{"href":"https://api.github.com/repos/DGtal-team/DGtal/issues/1369"},"comments":{"href":"https://api.github.com/repos/DGtal-team/DGtal/issues/1369/comments"},"review_comments":{"href":"https://api.github.com/repos/DGtal-team/DGtal/pulls/1369/comments"},"review_comment":{"href":"https://api.github.com/repos/DGtal-team/DGtal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DGtal-team/DGtal/pulls/1369/commits"},"statuses":{"href":"https://api.github.com/repos/DGtal-team/DGtal/statuses/b2c35c1a0ac3e1ae1ad85ef12f93937a80226a81"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"dcoeurjo"}}