{"action":"created","issue":{"url":"https://api.github.com/repos/PKISharp/ACMESharpCore/issues/5","repository_url":"https://api.github.com/repos/PKISharp/ACMESharpCore","labels_url":"https://api.github.com/repos/PKISharp/ACMESharpCore/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/PKISharp/ACMESharpCore/issues/5/comments","events_url":"https://api.github.com/repos/PKISharp/ACMESharpCore/issues/5/events","html_url":"https://github.com/PKISharp/ACMESharpCore/issues/5","id":339219712,"node_id":"MDU6SXNzdWUzMzkyMTk3MTI=","number":5,"title":"Implement proper Factory-Pattern for IJwsTool","user":{"login":"glatzert","id":10154376,"node_id":"MDQ6VXNlcjEwMTU0Mzc2","avatar_url":"https://avatars1.githubusercontent.com/u/10154376?v=4","gravatar_id":"","url":"https://api.github.com/users/glatzert","html_url":"https://github.com/glatzert","followers_url":"https://api.github.com/users/glatzert/followers","following_url":"https://api.github.com/users/glatzert/following{/other_user}","gists_url":"https://api.github.com/users/glatzert/gists{/gist_id}","starred_url":"https://api.github.com/users/glatzert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glatzert/subscriptions","organizations_url":"https://api.github.com/users/glatzert/orgs","repos_url":"https://api.github.com/users/glatzert/repos","events_url":"https://api.github.com/users/glatzert/events{/privacy}","received_events_url":"https://api.github.com/users/glatzert/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-07-08T11:52:12Z","updated_at":"2018-07-12T16:35:44Z","closed_at":null,"author_association":"NONE","body":"I think the JwsTool could need some refactoring.\r\n\r\nThere should be a proper JwsTool::Create, to create the matching Signer.\r\nI'll submit a proposal, if you agree. That'll also make it easily usable for PS-Core scenarios."},"comment":{"url":"https://api.github.com/repos/PKISharp/ACMESharpCore/issues/comments/404573416","html_url":"https://github.com/PKISharp/ACMESharpCore/issues/5#issuecomment-404573416","issue_url":"https://api.github.com/repos/PKISharp/ACMESharpCore/issues/5","id":404573416,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDU3MzQxNg==","user":{"login":"glatzert","id":10154376,"node_id":"MDQ6VXNlcjEwMTU0Mzc2","avatar_url":"https://avatars1.githubusercontent.com/u/10154376?v=4","gravatar_id":"","url":"https://api.github.com/users/glatzert","html_url":"https://github.com/glatzert","followers_url":"https://api.github.com/users/glatzert/followers","following_url":"https://api.github.com/users/glatzert/following{/other_user}","gists_url":"https://api.github.com/users/glatzert/gists{/gist_id}","starred_url":"https://api.github.com/users/glatzert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glatzert/subscriptions","organizations_url":"https://api.github.com/users/glatzert/orgs","repos_url":"https://api.github.com/users/glatzert/repos","events_url":"https://api.github.com/users/glatzert/events{/privacy}","received_events_url":"https://api.github.com/users/glatzert/received_events","type":"User","site_admin":false},"created_at":"2018-07-12T16:35:43Z","updated_at":"2018-07-12T16:35:43Z","author_association":"NONE","body":"I am nearly happy with the implementation now.\r\nUnfortunately it imposes an Dependency on Newtonsoft.Json on the PS-Module. The dependency could be removed, if the PublicJWK would be an object and not a string.\r\nI'd probably be able to port over the JwsSigner to PS. This does not look too hard …\r\n\r\nIndependent of the PSModule, I think this PR would be worth joining, since it removes Default signers and makes the Keys a little bit more visible. I also made sure, that a constructed object is well initialized.\r\nAnd Renamed some functions to be more clear About the Purpose."}}
{"actor":{"display_login":"glatzert"}}