{"action":"created","comment":{"url":"https://api.github.com/repos/ryanwersal/MorseL/pulls/comments/226311995","pull_request_review_id":166102614,"id":226311995,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjMxMTk5NQ==","diff_hunk":"@@ -0,0 +1,71 @@\n+﻿using System;\n+using System.Collections.Generic;\n+using System.Linq;\n+using System.Reflection;\n+using Microsoft.Extensions.Logging;\n+\n+namespace MorseL.Internal\n+{\n+    internal class HubMethodDiscoverer<THub, TClient> where THub : Hub<TClient>","path":"src/MorseL/Internal/HubMethodDiscoverer.cs","position":9,"original_position":9,"commit_id":"f5ef8c7471237acdd3f504f0728c1eb60b2e409d","original_commit_id":"f5ef8c7471237acdd3f504f0728c1eb60b2e409d","user":{"login":"berdon","id":898462,"node_id":"MDQ6VXNlcjg5ODQ2Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/898462?v=4","gravatar_id":"","url":"https://api.github.com/users/berdon","html_url":"https://github.com/berdon","followers_url":"https://api.github.com/users/berdon/followers","following_url":"https://api.github.com/users/berdon/following{/other_user}","gists_url":"https://api.github.com/users/berdon/gists{/gist_id}","starred_url":"https://api.github.com/users/berdon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/berdon/subscriptions","organizations_url":"https://api.github.com/users/berdon/orgs","repos_url":"https://api.github.com/users/berdon/repos","events_url":"https://api.github.com/users/berdon/events{/privacy}","received_events_url":"https://api.github.com/users/berdon/received_events","type":"User","site_admin":false},"body":"I like this abstraction - could potentially derive an interface from its methods for mocking and testing?","created_at":"2018-10-18T13:49:43Z","updated_at":"2018-10-18T13:50:40Z","html_url":"https://github.com/ryanwersal/MorseL/pull/45#discussion_r226311995","pull_request_url":"https://api.github.com/repos/ryanwersal/MorseL/pulls/45","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ryanwersal/MorseL/pulls/comments/226311995"},"html":{"href":"https://github.com/ryanwersal/MorseL/pull/45#discussion_r226311995"},"pull_request":{"href":"https://api.github.com/repos/ryanwersal/MorseL/pulls/45"}}},"pull_request":{"url":"https://api.github.com/repos/ryanwersal/MorseL/pulls/45","id":223459803,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNDU5ODAz","html_url":"https://github.com/ryanwersal/MorseL/pull/45","diff_url":"https://github.com/ryanwersal/MorseL/pull/45.diff","patch_url":"https://github.com/ryanwersal/MorseL/pull/45.patch","issue_url":"https://api.github.com/repos/ryanwersal/MorseL/issues/45","number":45,"state":"open","locked":false,"title":"Refactor and add tests for hub method discovery","user":{"login":"ryanwersal","id":604125,"node_id":"MDQ6VXNlcjYwNDEyNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/604125?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanwersal","html_url":"https://github.com/ryanwersal","followers_url":"https://api.github.com/users/ryanwersal/followers","following_url":"https://api.github.com/users/ryanwersal/following{/other_user}","gists_url":"https://api.github.com/users/ryanwersal/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanwersal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanwersal/subscriptions","organizations_url":"https://api.github.com/users/ryanwersal/orgs","repos_url":"https://api.github.com/users/ryanwersal/repos","events_url":"https://api.github.com/users/ryanwersal/events{/privacy}","received_events_url":"https://api.github.com/users/ryanwersal/received_events","type":"User","site_admin":false},"body":"This branch is based off the other PR.\r\n\r\nWhile I was looking closely at the web socket handler I noticed that there wasn't much testing around the hub method discovery so I looked at adding some.\r\n\r\nI opted to factor out the code into a separate internal class so that it could be more readily tested independently (though it still uses the `ServicesMocker` from the other PR for the logger factory).\r\n\r\nI did discover, through this testing, that the discovery process picked up a few methods from `object` that I updated the code to ignore using the same method as ignoring `Hub<>` methods.","created_at":"2018-10-17T03:43:31Z","updated_at":"2018-10-18T13:50:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ccfec072196d782ca733dea29c231e379f2a475e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ryanwersal/MorseL/pulls/45/commits","review_comments_url":"https://api.github.com/repos/ryanwersal/MorseL/pulls/45/comments","review_comment_url":"https://api.github.com/repos/ryanwersal/MorseL/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ryanwersal/MorseL/issues/45/comments","statuses_url":"https://api.github.com/repos/ryanwersal/MorseL/statuses/f5ef8c7471237acdd3f504f0728c1eb60b2e409d","head":{"label":"ryanwersal:refine-hub-method-discover","ref":"refine-hub-method-discover","sha":"f5ef8c7471237acdd3f504f0728c1eb60b2e409d","user":{"login":"ryanwersal","id":604125,"node_id":"MDQ6VXNlcjYwNDEyNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/604125?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanwersal","html_url":"https://github.com/ryanwersal","followers_url":"https://api.github.com/users/ryanwersal/followers","following_url":"https://api.github.com/users/ryanwersal/following{/other_user}","gists_url":"https://api.github.com/users/ryanwersal/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanwersal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanwersal/subscriptions","organizations_url":"https://api.github.com/users/ryanwersal/orgs","repos_url":"https://api.github.com/users/ryanwersal/repos","events_url":"https://api.github.com/users/ryanwersal/events{/privacy}","received_events_url":"https://api.github.com/users/ryanwersal/received_events","type":"User","site_admin":false},"repo":{"id":89548967,"node_id":"MDEwOlJlcG9zaXRvcnk4OTU0ODk2Nw==","name":"MorseL","full_name":"ryanwersal/MorseL","private":false,"owner":{"login":"ryanwersal","id":604125,"node_id":"MDQ6VXNlcjYwNDEyNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/604125?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanwersal","html_url":"https://github.com/ryanwersal","followers_url":"https://api.github.com/users/ryanwersal/followers","following_url":"https://api.github.com/users/ryanwersal/following{/other_user}","gists_url":"https://api.github.com/users/ryanwersal/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanwersal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanwersal/subscriptions","organizations_url":"https://api.github.com/users/ryanwersal/orgs","repos_url":"https://api.github.com/users/ryanwersal/repos","events_url":"https://api.github.com/users/ryanwersal/events{/privacy}","received_events_url":"https://api.github.com/users/ryanwersal/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ryanwersal/MorseL","description":null,"fork":false,"url":"https://api.github.com/repos/ryanwersal/MorseL","forks_url":"https://api.github.com/repos/ryanwersal/MorseL/forks","keys_url":"https://api.github.com/repos/ryanwersal/MorseL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ryanwersal/MorseL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ryanwersal/MorseL/teams","hooks_url":"https://api.github.com/repos/ryanwersal/MorseL/hooks","issue_events_url":"https://api.github.com/repos/ryanwersal/MorseL/issues/events{/number}","events_url":"https://api.github.com/repos/ryanwersal/MorseL/events","assignees_url":"https://api.github.com/repos/ryanwersal/MorseL/assignees{/user}","branches_url":"https://api.github.com/repos/ryanwersal/MorseL/branches{/branch}","tags_url":"https://api.github.com/repos/ryanwersal/MorseL/tags","blobs_url":"https://api.github.com/repos/ryanwersal/MorseL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ryanwersal/MorseL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ryanwersal/MorseL/git/refs{/sha}","trees_url":"https://api.github.com/repos/ryanwersal/MorseL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ryanwersal/MorseL/statuses/{sha}","languages_url":"https://api.github.com/repos/ryanwersal/MorseL/languages","stargazers_url":"https://api.github.com/repos/ryanwersal/MorseL/stargazers","contributors_url":"https://api.github.com/repos/ryanwersal/MorseL/contributors","subscribers_url":"https://api.github.com/repos/ryanwersal/MorseL/subscribers","subscription_url":"https://api.github.com/repos/ryanwersal/MorseL/subscription","commits_url":"https://api.github.com/repos/ryanwersal/MorseL/commits{/sha}","git_commits_url":"https://api.github.com/repos/ryanwersal/MorseL/git/commits{/sha}","comments_url":"https://api.github.com/repos/ryanwersal/MorseL/comments{/number}","issue_comment_url":"https://api.github.com/repos/ryanwersal/MorseL/issues/comments{/number}","contents_url":"https://api.github.com/repos/ryanwersal/MorseL/contents/{+path}","compare_url":"https://api.github.com/repos/ryanwersal/MorseL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ryanwersal/MorseL/merges","archive_url":"https://api.github.com/repos/ryanwersal/MorseL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ryanwersal/MorseL/downloads","issues_url":"https://api.github.com/repos/ryanwersal/MorseL/issues{/number}","pulls_url":"https://api.github.com/repos/ryanwersal/MorseL/pulls{/number}","milestones_url":"https://api.github.com/repos/ryanwersal/MorseL/milestones{/number}","notifications_url":"https://api.github.com/repos/ryanwersal/MorseL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ryanwersal/MorseL/labels{/name}","releases_url":"https://api.github.com/repos/ryanwersal/MorseL/releases{/id}","deployments_url":"https://api.github.com/repos/ryanwersal/MorseL/deployments","created_at":"2017-04-27T02:53:01Z","updated_at":"2018-10-12T14:29:58Z","pushed_at":"2018-10-18T06:06:24Z","git_url":"git://github.com/ryanwersal/MorseL.git","ssh_url":"git@github.com:ryanwersal/MorseL.git","clone_url":"https://github.com/ryanwersal/MorseL.git","svn_url":"https://github.com/ryanwersal/MorseL","homepage":null,"size":374,"stargazers_count":3,"watchers_count":3,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":13,"watchers":3,"default_branch":"master"}},"base":{"label":"ryanwersal:handler-create-release-tests","ref":"handler-create-release-tests","sha":"07fe925775afea7324ba478577341b593c1c3213","user":{"login":"ryanwersal","id":604125,"node_id":"MDQ6VXNlcjYwNDEyNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/604125?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanwersal","html_url":"https://github.com/ryanwersal","followers_url":"https://api.github.com/users/ryanwersal/followers","following_url":"https://api.github.com/users/ryanwersal/following{/other_user}","gists_url":"https://api.github.com/users/ryanwersal/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanwersal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanwersal/subscriptions","organizations_url":"https://api.github.com/users/ryanwersal/orgs","repos_url":"https://api.github.com/users/ryanwersal/repos","events_url":"https://api.github.com/users/ryanwersal/events{/privacy}","received_events_url":"https://api.github.com/users/ryanwersal/received_events","type":"User","site_admin":false},"repo":{"id":89548967,"node_id":"MDEwOlJlcG9zaXRvcnk4OTU0ODk2Nw==","name":"MorseL","full_name":"ryanwersal/MorseL","private":false,"owner":{"login":"ryanwersal","id":604125,"node_id":"MDQ6VXNlcjYwNDEyNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/604125?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanwersal","html_url":"https://github.com/ryanwersal","followers_url":"https://api.github.com/users/ryanwersal/followers","following_url":"https://api.github.com/users/ryanwersal/following{/other_user}","gists_url":"https://api.github.com/users/ryanwersal/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanwersal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanwersal/subscriptions","organizations_url":"https://api.github.com/users/ryanwersal/orgs","repos_url":"https://api.github.com/users/ryanwersal/repos","events_url":"https://api.github.com/users/ryanwersal/events{/privacy}","received_events_url":"https://api.github.com/users/ryanwersal/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ryanwersal/MorseL","description":null,"fork":false,"url":"https://api.github.com/repos/ryanwersal/MorseL","forks_url":"https://api.github.com/repos/ryanwersal/MorseL/forks","keys_url":"https://api.github.com/repos/ryanwersal/MorseL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ryanwersal/MorseL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ryanwersal/MorseL/teams","hooks_url":"https://api.github.com/repos/ryanwersal/MorseL/hooks","issue_events_url":"https://api.github.com/repos/ryanwersal/MorseL/issues/events{/number}","events_url":"https://api.github.com/repos/ryanwersal/MorseL/events","assignees_url":"https://api.github.com/repos/ryanwersal/MorseL/assignees{/user}","branches_url":"https://api.github.com/repos/ryanwersal/MorseL/branches{/branch}","tags_url":"https://api.github.com/repos/ryanwersal/MorseL/tags","blobs_url":"https://api.github.com/repos/ryanwersal/MorseL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ryanwersal/MorseL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ryanwersal/MorseL/git/refs{/sha}","trees_url":"https://api.github.com/repos/ryanwersal/MorseL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ryanwersal/MorseL/statuses/{sha}","languages_url":"https://api.github.com/repos/ryanwersal/MorseL/languages","stargazers_url":"https://api.github.com/repos/ryanwersal/MorseL/stargazers","contributors_url":"https://api.github.com/repos/ryanwersal/MorseL/contributors","subscribers_url":"https://api.github.com/repos/ryanwersal/MorseL/subscribers","subscription_url":"https://api.github.com/repos/ryanwersal/MorseL/subscription","commits_url":"https://api.github.com/repos/ryanwersal/MorseL/commits{/sha}","git_commits_url":"https://api.github.com/repos/ryanwersal/MorseL/git/commits{/sha}","comments_url":"https://api.github.com/repos/ryanwersal/MorseL/comments{/number}","issue_comment_url":"https://api.github.com/repos/ryanwersal/MorseL/issues/comments{/number}","contents_url":"https://api.github.com/repos/ryanwersal/MorseL/contents/{+path}","compare_url":"https://api.github.com/repos/ryanwersal/MorseL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ryanwersal/MorseL/merges","archive_url":"https://api.github.com/repos/ryanwersal/MorseL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ryanwersal/MorseL/downloads","issues_url":"https://api.github.com/repos/ryanwersal/MorseL/issues{/number}","pulls_url":"https://api.github.com/repos/ryanwersal/MorseL/pulls{/number}","milestones_url":"https://api.github.com/repos/ryanwersal/MorseL/milestones{/number}","notifications_url":"https://api.github.com/repos/ryanwersal/MorseL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ryanwersal/MorseL/labels{/name}","releases_url":"https://api.github.com/repos/ryanwersal/MorseL/releases{/id}","deployments_url":"https://api.github.com/repos/ryanwersal/MorseL/deployments","created_at":"2017-04-27T02:53:01Z","updated_at":"2018-10-12T14:29:58Z","pushed_at":"2018-10-18T06:06:24Z","git_url":"git://github.com/ryanwersal/MorseL.git","ssh_url":"git@github.com:ryanwersal/MorseL.git","clone_url":"https://github.com/ryanwersal/MorseL.git","svn_url":"https://github.com/ryanwersal/MorseL","homepage":null,"size":374,"stargazers_count":3,"watchers_count":3,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":13,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ryanwersal/MorseL/pulls/45"},"html":{"href":"https://github.com/ryanwersal/MorseL/pull/45"},"issue":{"href":"https://api.github.com/repos/ryanwersal/MorseL/issues/45"},"comments":{"href":"https://api.github.com/repos/ryanwersal/MorseL/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/ryanwersal/MorseL/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/ryanwersal/MorseL/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ryanwersal/MorseL/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/ryanwersal/MorseL/statuses/f5ef8c7471237acdd3f504f0728c1eb60b2e409d"}},"author_association":"OWNER"}}
{"actor":{"display_login":"berdon"}}