{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corert/pulls/comments/195545337","pull_request_review_id":128937378,"id":195545337,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTU0NTMzNw==","diff_hunk":"@@ -0,0 +1,49 @@\n+﻿// Licensed to the .NET Foundation under one or more agreements.\n+// The .NET Foundation licenses this file to you under the MIT license.\n+// See the LICENSE file in the project root for more information.\n+\n+using System;\n+using ILCompiler.DependencyAnalysisFramework;\n+using Internal.TypeSystem;\n+\n+namespace ILCompiler.DependencyAnalysis\n+{\n+    public sealed class ReadyToRunCodegenNodeFactory : NodeFactory\n+    {\n+        ","path":"src/ILCompiler.ReadyToRun/src/Compiler/DependencyAnalysis/ReadyToRunCodegenNodeFactory.cs","position":13,"original_position":13,"commit_id":"f2c187ba3a7d4c1c1686eb857bb8e63d752b2694","original_commit_id":"f2c187ba3a7d4c1c1686eb857bb8e63d752b2694","user":{"login":"MichalStrehovsky","id":13110571,"node_id":"MDQ6VXNlcjEzMTEwNTcx","avatar_url":"https://avatars0.githubusercontent.com/u/13110571?v=4","gravatar_id":"","url":"https://api.github.com/users/MichalStrehovsky","html_url":"https://github.com/MichalStrehovsky","followers_url":"https://api.github.com/users/MichalStrehovsky/followers","following_url":"https://api.github.com/users/MichalStrehovsky/following{/other_user}","gists_url":"https://api.github.com/users/MichalStrehovsky/gists{/gist_id}","starred_url":"https://api.github.com/users/MichalStrehovsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichalStrehovsky/subscriptions","organizations_url":"https://api.github.com/users/MichalStrehovsky/orgs","repos_url":"https://api.github.com/users/MichalStrehovsky/repos","events_url":"https://api.github.com/users/MichalStrehovsky/events{/privacy}","received_events_url":"https://api.github.com/users/MichalStrehovsky/received_events","type":"User","site_admin":false},"body":"Nit: extra line","created_at":"2018-06-14T19:34:03Z","updated_at":"2018-06-14T19:43:33Z","html_url":"https://github.com/dotnet/corert/pull/5943#discussion_r195545337","pull_request_url":"https://api.github.com/repos/dotnet/corert/pulls/5943","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corert/pulls/comments/195545337"},"html":{"href":"https://github.com/dotnet/corert/pull/5943#discussion_r195545337"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corert/pulls/5943"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corert/pulls/5943","id":194989634,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0OTg5NjM0","html_url":"https://github.com/dotnet/corert/pull/5943","diff_url":"https://github.com/dotnet/corert/pull/5943.diff","patch_url":"https://github.com/dotnet/corert/pull/5943.patch","issue_url":"https://api.github.com/repos/dotnet/corert/issues/5943","number":5943,"state":"open","locked":false,"title":"Add ReadyToRun mode to ILCompiler","user":{"login":"nattress","id":116900,"node_id":"MDQ6VXNlcjExNjkwMA==","avatar_url":"https://avatars2.githubusercontent.com/u/116900?v=4","gravatar_id":"","url":"https://api.github.com/users/nattress","html_url":"https://github.com/nattress","followers_url":"https://api.github.com/users/nattress/followers","following_url":"https://api.github.com/users/nattress/following{/other_user}","gists_url":"https://api.github.com/users/nattress/gists{/gist_id}","starred_url":"https://api.github.com/users/nattress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nattress/subscriptions","organizations_url":"https://api.github.com/users/nattress/orgs","repos_url":"https://api.github.com/users/nattress/repos","events_url":"https://api.github.com/users/nattress/events{/privacy}","received_events_url":"https://api.github.com/users/nattress/received_events","type":"User","site_admin":false},"body":"Adds a ready-to-run compilation mode to ILCompiler which will live in ILCompiler.ReadyToRun library. Created separate versions of a few main classes (NodeFactory, Compilation, CompilationBuilder) specific to ready-to-run, whose implementations will be filled out as we build out ready-to-run support.\r\n\r\nAlso includes Tomas' PE file builder, which currently produces a valid executable round tripped from an input IL assembly.","created_at":"2018-06-14T19:08:43Z","updated_at":"2018-06-14T19:43:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b66532a1ccfd5cca2d727e7b84d91ff9d35bdfe5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corert/pulls/5943/commits","review_comments_url":"https://api.github.com/repos/dotnet/corert/pulls/5943/comments","review_comment_url":"https://api.github.com/repos/dotnet/corert/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corert/issues/5943/comments","statuses_url":"https://api.github.com/repos/dotnet/corert/statuses/f2c187ba3a7d4c1c1686eb857bb8e63d752b2694","head":{"label":"nattress:r2r_fix","ref":"r2r_fix","sha":"f2c187ba3a7d4c1c1686eb857bb8e63d752b2694","user":{"login":"nattress","id":116900,"node_id":"MDQ6VXNlcjExNjkwMA==","avatar_url":"https://avatars2.githubusercontent.com/u/116900?v=4","gravatar_id":"","url":"https://api.github.com/users/nattress","html_url":"https://github.com/nattress","followers_url":"https://api.github.com/users/nattress/followers","following_url":"https://api.github.com/users/nattress/following{/other_user}","gists_url":"https://api.github.com/users/nattress/gists{/gist_id}","starred_url":"https://api.github.com/users/nattress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nattress/subscriptions","organizations_url":"https://api.github.com/users/nattress/orgs","repos_url":"https://api.github.com/users/nattress/repos","events_url":"https://api.github.com/users/nattress/events{/privacy}","received_events_url":"https://api.github.com/users/nattress/received_events","type":"User","site_admin":false},"repo":{"id":46596706,"node_id":"MDEwOlJlcG9zaXRvcnk0NjU5NjcwNg==","name":"corert","full_name":"nattress/corert","owner":{"login":"nattress","id":116900,"node_id":"MDQ6VXNlcjExNjkwMA==","avatar_url":"https://avatars2.githubusercontent.com/u/116900?v=4","gravatar_id":"","url":"https://api.github.com/users/nattress","html_url":"https://github.com/nattress","followers_url":"https://api.github.com/users/nattress/followers","following_url":"https://api.github.com/users/nattress/following{/other_user}","gists_url":"https://api.github.com/users/nattress/gists{/gist_id}","starred_url":"https://api.github.com/users/nattress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nattress/subscriptions","organizations_url":"https://api.github.com/users/nattress/orgs","repos_url":"https://api.github.com/users/nattress/repos","events_url":"https://api.github.com/users/nattress/events{/privacy}","received_events_url":"https://api.github.com/users/nattress/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nattress/corert","description":"This repo contains CoreRT, a .NET Core runtime optimized for AOT (ahead of time compilation) scenarios, with the accompanying .NET Native compiler toolchain.","fork":true,"url":"https://api.github.com/repos/nattress/corert","forks_url":"https://api.github.com/repos/nattress/corert/forks","keys_url":"https://api.github.com/repos/nattress/corert/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nattress/corert/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nattress/corert/teams","hooks_url":"https://api.github.com/repos/nattress/corert/hooks","issue_events_url":"https://api.github.com/repos/nattress/corert/issues/events{/number}","events_url":"https://api.github.com/repos/nattress/corert/events","assignees_url":"https://api.github.com/repos/nattress/corert/assignees{/user}","branches_url":"https://api.github.com/repos/nattress/corert/branches{/branch}","tags_url":"https://api.github.com/repos/nattress/corert/tags","blobs_url":"https://api.github.com/repos/nattress/corert/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nattress/corert/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nattress/corert/git/refs{/sha}","trees_url":"https://api.github.com/repos/nattress/corert/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nattress/corert/statuses/{sha}","languages_url":"https://api.github.com/repos/nattress/corert/languages","stargazers_url":"https://api.github.com/repos/nattress/corert/stargazers","contributors_url":"https://api.github.com/repos/nattress/corert/contributors","subscribers_url":"https://api.github.com/repos/nattress/corert/subscribers","subscription_url":"https://api.github.com/repos/nattress/corert/subscription","commits_url":"https://api.github.com/repos/nattress/corert/commits{/sha}","git_commits_url":"https://api.github.com/repos/nattress/corert/git/commits{/sha}","comments_url":"https://api.github.com/repos/nattress/corert/comments{/number}","issue_comment_url":"https://api.github.com/repos/nattress/corert/issues/comments{/number}","contents_url":"https://api.github.com/repos/nattress/corert/contents/{+path}","compare_url":"https://api.github.com/repos/nattress/corert/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nattress/corert/merges","archive_url":"https://api.github.com/repos/nattress/corert/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nattress/corert/downloads","issues_url":"https://api.github.com/repos/nattress/corert/issues{/number}","pulls_url":"https://api.github.com/repos/nattress/corert/pulls{/number}","milestones_url":"https://api.github.com/repos/nattress/corert/milestones{/number}","notifications_url":"https://api.github.com/repos/nattress/corert/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nattress/corert/labels{/name}","releases_url":"https://api.github.com/repos/nattress/corert/releases{/id}","deployments_url":"https://api.github.com/repos/nattress/corert/deployments","created_at":"2015-11-21T01:52:47Z","updated_at":"2018-06-14T01:51:13Z","pushed_at":"2018-06-14T19:19:19Z","git_url":"git://github.com/nattress/corert.git","ssh_url":"git@github.com:nattress/corert.git","clone_url":"https://github.com/nattress/corert.git","svn_url":"https://github.com/nattress/corert","homepage":"http://dotnet.github.io/","size":27896,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dotnet:r2r","ref":"r2r","sha":"80000c509b76c3920e780a993f376b21e0cb9a82","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":42552143,"node_id":"MDEwOlJlcG9zaXRvcnk0MjU1MjE0Mw==","name":"corert","full_name":"dotnet/corert","owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corert","description":"This repo contains CoreRT, a .NET Core runtime optimized for AOT (ahead of time compilation) scenarios, with the accompanying .NET native compiler toolchain.","fork":false,"url":"https://api.github.com/repos/dotnet/corert","forks_url":"https://api.github.com/repos/dotnet/corert/forks","keys_url":"https://api.github.com/repos/dotnet/corert/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corert/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corert/teams","hooks_url":"https://api.github.com/repos/dotnet/corert/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corert/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corert/events","assignees_url":"https://api.github.com/repos/dotnet/corert/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corert/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corert/tags","blobs_url":"https://api.github.com/repos/dotnet/corert/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corert/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corert/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corert/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corert/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corert/languages","stargazers_url":"https://api.github.com/repos/dotnet/corert/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corert/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corert/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corert/subscription","commits_url":"https://api.github.com/repos/dotnet/corert/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corert/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corert/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corert/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corert/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corert/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corert/merges","archive_url":"https://api.github.com/repos/dotnet/corert/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corert/downloads","issues_url":"https://api.github.com/repos/dotnet/corert/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corert/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corert/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corert/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corert/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corert/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corert/deployments","created_at":"2015-09-15T23:10:53Z","updated_at":"2018-06-14T17:08:14Z","pushed_at":"2018-06-14T19:08:44Z","git_url":"git://github.com/dotnet/corert.git","ssh_url":"git@github.com:dotnet/corert.git","clone_url":"https://github.com/dotnet/corert.git","svn_url":"https://github.com/dotnet/corert","homepage":"http://dot.net","size":27939,"stargazers_count":1327,"watchers_count":1327,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":312,"mirror_url":null,"archived":false,"open_issues_count":261,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":312,"open_issues":261,"watchers":1327,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corert/pulls/5943"},"html":{"href":"https://github.com/dotnet/corert/pull/5943"},"issue":{"href":"https://api.github.com/repos/dotnet/corert/issues/5943"},"comments":{"href":"https://api.github.com/repos/dotnet/corert/issues/5943/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corert/pulls/5943/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corert/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corert/pulls/5943/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corert/statuses/f2c187ba3a7d4c1c1686eb857bb8e63d752b2694"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"MichalStrehovsky"}}