{"push_id":2786016884,"size":5,"distinct_size":5,"ref":"refs/heads/master","head":"f328da79969437aee7de1c3ac77b3eca2b7a3c0a","before":"bca53d3699c0587f52f629b8abc836f47cf7e688","commits":[{"sha":"d81ce040ffbc2e9311843e7a21fab9063d98b2dd","author":{"name":"Andrii Shyshkalov","email":"a30c74fa30536fe7ea81ed6dec202e35e149e1fd@chromium.org"},"message":"Revert \"Omnibox UI: Trivial refactor of redundant logic.\"\n\nThis reverts commit eb0754126c4ea3ef3aa55b65e607fe8204b6e197.\n\nReason for revert: Due to Gerrit outage http://crbug.com/872722, we are reverting this CL. Please, re-land it after all clear is given. If you have questions, please ask on the bug. Sorry for the inconvenience.\n\nOriginal change's description:\n> Omnibox UI: Trivial refactor of redundant logic.\n> \n> Bug: NONE\n> Change-Id: I081af3892dc52f73d7d92aed9b417defa862f8be\n> Reviewed-on: https://chromium-review.googlesource.com/1168512\n> Reviewed-by: Kevin Bailey <krb@chromium.org>\n\nTBR=krb@chromium.org,tommycli@chromium.org\n\nChange-Id: I44d70e49cdf404a616483f04af6915066f9d8b45\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nBug: NONE\nReviewed-on: https://chromium-review.googlesource.com/1169788\nReviewed-by: Andrii Shyshkalov <tandrii@chromium.org>","distinct":true,"url":"https://api.github.com/repos/chromium/chromium/commits/d81ce040ffbc2e9311843e7a21fab9063d98b2dd"},{"sha":"23b998cb1f5ce77f7143a4b6bc96f2f13bf973e4","author":{"name":"Andrii Shyshkalov","email":"a30c74fa30536fe7ea81ed6dec202e35e149e1fd@chromium.org"},"message":"Revert \"Omnibox Refresh UI: Hide placeholder text when keyword is selected\"\n\nThis reverts commit af3a6bdc31c29746d749ba0ab9e7181c49c11642.\n\nReason for revert: Due to Gerrit outage http://crbug.com/872722, we are reverting this CL. Please, re-land it after all clear is given. If you have questions, please ask on the bug. Sorry for the inconvenience.\n\nOriginal change's description:\n> Omnibox Refresh UI: Hide placeholder text when keyword is selected\n> \n> Previously, when a keyword was selected, i.e. \"Search Yahoo\", we would\n> still show the placeholder text in the Omnibox when unfocused, like:\n> \"Search Google or enter a URL\".\n> \n> That is plainly not applicable to the selected keyword case. We don't\n> need to show placeholder text at all when there is a selected keyword,\n> since the selected keyword label itself gives ample instruction to the\n> user.\n> \n> Bug: 872327\n> Change-Id: I84fd06964808554e5c606d2f2f371bea9c44b465\n> Reviewed-on: https://chromium-review.googlesource.com/1168506\n> Reviewed-by: Kevin Bailey <krb@chromium.org>\n\nTBR=krb@chromium.org,tommycli@chromium.org\n\nChange-Id: Ibbc17b665c1e4be7f167de40d39a584f867f7f2b\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nBug: 872327\nReviewed-on: https://chromium-review.googlesource.com/1169842\nReviewed-by: Andrii Shyshkalov <tandrii@chromium.org>","distinct":true,"url":"https://api.github.com/repos/chromium/chromium/commits/23b998cb1f5ce77f7143a4b6bc96f2f13bf973e4"},{"sha":"4af14ca3c99bd7edbf100e05db93564b7107cc62","author":{"name":"Andrii Shyshkalov","email":"a30c74fa30536fe7ea81ed6dec202e35e149e1fd@chromium.org"},"message":"Revert \"Deflake inspector-protocol/input/dispatchKeyEvent-focus.js\"\n\nThis reverts commit 27378e0364b705643275c861f4ba64b70572dff1.\n\nReason for revert: Due to Gerrit outage http://crbug.com/872722, we are reverting this CL. Please, re-land it after all clear is given. If you have questions, please ask on the bug. Sorry for the inconvenience.\n\nOriginal change's description:\n> Deflake inspector-protocol/input/dispatchKeyEvent-focus.js\n> \n> The keystrokes injected via Input.dispatchKeyEvent through the browser are\n> racing against Runtime.evaluate in the renderer, so we need to wait for\n> the async completion of the last dispatchKeyEvent before validating the\n> tests results with evaluate.\n> \n> Bug: 872081\n> Change-Id: Ic5ef41feba6a877c76c05de2e09e019a826756a1\n> Reviewed-on: https://chromium-review.googlesource.com/1168200\n> Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>\n\nTBR=dgozman@chromium.org,lushnikov@chromium.org,caseq@chromium.org\n\nChange-Id: I6f7e8e41eab2c756875103cae24576c37784baf3\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nBug: 872081\nReviewed-on: https://chromium-review.googlesource.com/1169789\nReviewed-by: Andrii Shyshkalov <tandrii@chromium.org>","distinct":true,"url":"https://api.github.com/repos/chromium/chromium/commits/4af14ca3c99bd7edbf100e05db93564b7107cc62"},{"sha":"bbe0692bd9283569546670318df6e3d8e605be8c","author":{"name":"Andrii Shyshkalov","email":"a30c74fa30536fe7ea81ed6dec202e35e149e1fd@chromium.org"},"message":"Reland \"[SessionStorageS13N] Enabling mojo SessionStorage by default\"\n\nThis reverts commit 304663b467d33fbe0a7e552565aceb5a59d8b2b0.\n\nReason for revert: Due to Gerrit outage http://crbug.com/872722, we are reverting this CL. Please, re-land it after all clear is given. If you have questions, please ask on the bug. Sorry for the inconvenience.\n\nOriginal change's description:\n> Revert \"[SessionStorageS13N] Enabling mojo SessionStorage by default\"\n> \n> This reverts commit 1bd58466eab023e8c734d1e63bd997daed4b3e30.\n> \n> Reason for revert: The crashes are still happening, and we aren't\n>                    closer to finding the cause. Changing focus to the\n>                    onion-souping effort.\n> \n> Bug: 859464, 857464, 867850, 866827\n> \n> Original change's description:\n> > [SessionStorageS13N] Enabling mojo SessionStorage by default\n> > \n> > Bug: 716490\n> > Change-Id: I08c9bc35d1e9f8f86adc6c88fb7ab8069bcf7e8f\n> > Reviewed-on: https://chromium-review.googlesource.com/1072918\n> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>\n> > Reviewed-by: John Abd-El-Malek <jam@chromium.org>\n> > Commit-Queue: Daniel Murphy <dmurph@chromium.org>\n> > Cr-Commit-Position: refs/heads/master@{#563169}\n> \n> TBR=dmurph@chromium.org,jam@chromium.org,mek@chromium.org\n> \n> # Not skipping CQ checks because original CL landed > 1 day ago.\n> \n> Bug: 716490\n> Change-Id: Ic5223ccbff4d61264c070b3518cf63ddb83deeb0\n> Reviewed-on: https://chromium-review.googlesource.com/1157446\n> Reviewed-by: Daniel Murphy <dmurph@chromium.org>\n\nTBR=dmurph@chromium.org,jam@chromium.org,mek@chromium.org\n\nChange-Id: Ia063033d68cd05bc46ca9259ed9f49e5ee06bab9\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nBug: 859464, 857464, 867850, 866827, 716490\nReviewed-on: https://chromium-review.googlesource.com/1169843\nReviewed-by: Andrii Shyshkalov <tandrii@chromium.org>","distinct":true,"url":"https://api.github.com/repos/chromium/chromium/commits/bbe0692bd9283569546670318df6e3d8e605be8c"},{"sha":"f328da79969437aee7de1c3ac77b3eca2b7a3c0a","author":{"name":"Alexei Filippov","email":"52e51c43e283548b762e3c9dd9a4600768db9fb4@chromium.org"},"message":"Reland \"[sampling heap profiler] Implement CreateModuleForAddress for Win platform.\"\n\nThis is a reland of abf1475f425aa7cb6c00aa3a8d953dee03c1f9f9\nIntended as a revert of Findit's revert of the above in CL\nhttps://us1-mirror-chromium-review.googlesource.com/c/chromium/src/+/1169502\nRational: Due to Gerrit outage http://crbug.com/872722,\nwe are reverting this CL. Please, re-land it after all clear is given.\nIf you have questions, please ask on the bug. Sorry for the inconvenience.\n\n\nOriginal change's description:\n> [sampling heap profiler] Implement CreateModuleForAddress for Win platform.\n>\n> Also move the function and its helpers to ModuleCache.\n>\n> BUG=803276\n> TBR=dcheng@chromium.org\n>\n> Change-Id: I4a7e868f2c65e2da67d362a97ab2d92fe1d0c120\n> Reviewed-on: https://chromium-review.googlesource.com/1166206\n> Reviewed-by: Mike Wittman <wittman@chromium.org>\n\nBug: 803276\nChange-Id: Ie12a8be575005ce35de284907dd7cb5c4959eaf4\nReviewed-on: https://chromium-review.googlesource.com/1169844\nReviewed-by: Andrii Shyshkalov <tandrii@chromium.org>","distinct":true,"url":"https://api.github.com/repos/chromium/chromium/commits/f328da79969437aee7de1c3ac77b3eca2b7a3c0a"}]}
{"actor":{"display_login":"aarongable"}}