{"action":"created","comment":{"url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/pulls/comments/237910001","pull_request_review_id":180330739,"id":237910001,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzkxMDAwMQ==","diff_hunk":"@@ -19,11 +19,7 @@ open class CALayer {\n     /// the view sets this value to match the screen.\n     open var contentsScale: CGFloat = 1.0\n \n-    internal var contentsGravityEnum: ContentsGravity = .resize\n-    open var contentsGravity: String {\n-        get { return contentsGravityEnum.rawValue }\n-        set { contentsGravityEnum = ContentsGravity(rawValue: newValue) ?? .center } // matches iOS\n-    }\n+    open var contentsGravity: CALayerContentsGravity = .resize","path":"Sources/CALayer.swift","position":9,"original_position":9,"commit_id":"f0b41fe33c9298fda07238706b6022cb351e324a","original_commit_id":"e2d4c3be14c5e0c24574cf0b91482ce9fe436d42","user":{"login":"rikner","id":2410252,"node_id":"MDQ6VXNlcjI0MTAyNTI=","avatar_url":"https://avatars1.githubusercontent.com/u/2410252?v=4","gravatar_id":"","url":"https://api.github.com/users/rikner","html_url":"https://github.com/rikner","followers_url":"https://api.github.com/users/rikner/followers","following_url":"https://api.github.com/users/rikner/following{/other_user}","gists_url":"https://api.github.com/users/rikner/gists{/gist_id}","starred_url":"https://api.github.com/users/rikner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rikner/subscriptions","organizations_url":"https://api.github.com/users/rikner/orgs","repos_url":"https://api.github.com/users/rikner/repos","events_url":"https://api.github.com/users/rikner/events{/privacy}","received_events_url":"https://api.github.com/users/rikner/received_events","type":"User","site_admin":false},"body":"like this? feels very strange:\r\nf0b41fe33c9298fda07238706b6022cb351e324a","created_at":"2018-11-30T16:01:32Z","updated_at":"2018-11-30T16:01:32Z","html_url":"https://github.com/flowkey/UIKit-cross-platform/pull/269#discussion_r237910001","pull_request_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/pulls/269","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/flowkey/UIKit-cross-platform/pulls/comments/237910001"},"html":{"href":"https://github.com/flowkey/UIKit-cross-platform/pull/269#discussion_r237910001"},"pull_request":{"href":"https://api.github.com/repos/flowkey/UIKit-cross-platform/pulls/269"}},"in_reply_to_id":237875080},"pull_request":{"url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/pulls/269","id":227372493,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MzcyNDkz","html_url":"https://github.com/flowkey/UIKit-cross-platform/pull/269","diff_url":"https://github.com/flowkey/UIKit-cross-platform/pull/269.diff","patch_url":"https://github.com/flowkey/UIKit-cross-platform/pull/269.patch","issue_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/issues/269","number":269,"state":"open","locked":false,"title":"Adapt latest UIKit API (as of Xcode 10.1)","user":{"login":"rikner","id":2410252,"node_id":"MDQ6VXNlcjI0MTAyNTI=","avatar_url":"https://avatars1.githubusercontent.com/u/2410252?v=4","gravatar_id":"","url":"https://api.github.com/users/rikner","html_url":"https://github.com/rikner","followers_url":"https://api.github.com/users/rikner/followers","following_url":"https://api.github.com/users/rikner/following{/other_user}","gists_url":"https://api.github.com/users/rikner/gists{/gist_id}","starred_url":"https://api.github.com/users/rikner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rikner/subscriptions","organizations_url":"https://api.github.com/users/rikner/orgs","repos_url":"https://api.github.com/users/rikner/repos","events_url":"https://api.github.com/users/rikner/events{/privacy}","received_events_url":"https://api.github.com/users/rikner/received_events","type":"User","site_admin":false},"body":"**Type of change:** Maintenance and API compatibility\r\n\r\n## Motivation (current vs expected behavior):\r\nThere were some small API Changes in Apples UIKit introduced with Mojave / Xcode 10 / Swift 4.2.\r\nTo me it seems like Apple adapted our `CALayerContentsGravity` ;-)\r\n\r\n## Please check if the PR fulfills these requirements\r\n- [x] Self-review: I am confident this is the simplest and clearest way to achieve the expected behaviour\r\n- [x] There are no dependencies on other PRs or I have linked dependencies through Zenhub\r\n- [x] The commit messages are clean and understandable\r\n- [ ] Tests for the changes have been added (for bug fixes / features)\r\n","created_at":"2018-10-31T17:14:39Z","updated_at":"2018-11-30T16:01:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b2ab5cba2d75abb21f4c2a8ce93f1bd8a590f88e","assignee":{"login":"rikner","id":2410252,"node_id":"MDQ6VXNlcjI0MTAyNTI=","avatar_url":"https://avatars1.githubusercontent.com/u/2410252?v=4","gravatar_id":"","url":"https://api.github.com/users/rikner","html_url":"https://github.com/rikner","followers_url":"https://api.github.com/users/rikner/followers","following_url":"https://api.github.com/users/rikner/following{/other_user}","gists_url":"https://api.github.com/users/rikner/gists{/gist_id}","starred_url":"https://api.github.com/users/rikner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rikner/subscriptions","organizations_url":"https://api.github.com/users/rikner/orgs","repos_url":"https://api.github.com/users/rikner/repos","events_url":"https://api.github.com/users/rikner/events{/privacy}","received_events_url":"https://api.github.com/users/rikner/received_events","type":"User","site_admin":false},"assignees":[{"login":"rikner","id":2410252,"node_id":"MDQ6VXNlcjI0MTAyNTI=","avatar_url":"https://avatars1.githubusercontent.com/u/2410252?v=4","gravatar_id":"","url":"https://api.github.com/users/rikner","html_url":"https://github.com/rikner","followers_url":"https://api.github.com/users/rikner/followers","following_url":"https://api.github.com/users/rikner/following{/other_user}","gists_url":"https://api.github.com/users/rikner/gists{/gist_id}","starred_url":"https://api.github.com/users/rikner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rikner/subscriptions","organizations_url":"https://api.github.com/users/rikner/orgs","repos_url":"https://api.github.com/users/rikner/repos","events_url":"https://api.github.com/users/rikner/events{/privacy}","received_events_url":"https://api.github.com/users/rikner/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"michaelknoch","id":5617793,"node_id":"MDQ6VXNlcjU2MTc3OTM=","avatar_url":"https://avatars2.githubusercontent.com/u/5617793?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelknoch","html_url":"https://github.com/michaelknoch","followers_url":"https://api.github.com/users/michaelknoch/followers","following_url":"https://api.github.com/users/michaelknoch/following{/other_user}","gists_url":"https://api.github.com/users/michaelknoch/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelknoch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelknoch/subscriptions","organizations_url":"https://api.github.com/users/michaelknoch/orgs","repos_url":"https://api.github.com/users/michaelknoch/repos","events_url":"https://api.github.com/users/michaelknoch/events{/privacy}","received_events_url":"https://api.github.com/users/michaelknoch/received_events","type":"User","site_admin":false},{"login":"cshg","id":10008938,"node_id":"MDQ6VXNlcjEwMDA4OTM4","avatar_url":"https://avatars2.githubusercontent.com/u/10008938?v=4","gravatar_id":"","url":"https://api.github.com/users/cshg","html_url":"https://github.com/cshg","followers_url":"https://api.github.com/users/cshg/followers","following_url":"https://api.github.com/users/cshg/following{/other_user}","gists_url":"https://api.github.com/users/cshg/gists{/gist_id}","starred_url":"https://api.github.com/users/cshg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cshg/subscriptions","organizations_url":"https://api.github.com/users/cshg/orgs","repos_url":"https://api.github.com/users/cshg/repos","events_url":"https://api.github.com/users/cshg/events{/privacy}","received_events_url":"https://api.github.com/users/cshg/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/pulls/269/commits","review_comments_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/pulls/269/comments","review_comment_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/issues/269/comments","statuses_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/statuses/f0b41fe33c9298fda07238706b6022cb351e324a","head":{"label":"flowkey:api-update","ref":"api-update","sha":"f0b41fe33c9298fda07238706b6022cb351e324a","user":{"login":"flowkey","id":5815111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4MTUxMTE=","avatar_url":"https://avatars3.githubusercontent.com/u/5815111?v=4","gravatar_id":"","url":"https://api.github.com/users/flowkey","html_url":"https://github.com/flowkey","followers_url":"https://api.github.com/users/flowkey/followers","following_url":"https://api.github.com/users/flowkey/following{/other_user}","gists_url":"https://api.github.com/users/flowkey/gists{/gist_id}","starred_url":"https://api.github.com/users/flowkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flowkey/subscriptions","organizations_url":"https://api.github.com/users/flowkey/orgs","repos_url":"https://api.github.com/users/flowkey/repos","events_url":"https://api.github.com/users/flowkey/events{/privacy}","received_events_url":"https://api.github.com/users/flowkey/received_events","type":"Organization","site_admin":false},"repo":{"id":93588967,"node_id":"MDEwOlJlcG9zaXRvcnk5MzU4ODk2Nw==","name":"UIKit-cross-platform","full_name":"flowkey/UIKit-cross-platform","private":false,"owner":{"login":"flowkey","id":5815111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4MTUxMTE=","avatar_url":"https://avatars3.githubusercontent.com/u/5815111?v=4","gravatar_id":"","url":"https://api.github.com/users/flowkey","html_url":"https://github.com/flowkey","followers_url":"https://api.github.com/users/flowkey/followers","following_url":"https://api.github.com/users/flowkey/following{/other_user}","gists_url":"https://api.github.com/users/flowkey/gists{/gist_id}","starred_url":"https://api.github.com/users/flowkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flowkey/subscriptions","organizations_url":"https://api.github.com/users/flowkey/orgs","repos_url":"https://api.github.com/users/flowkey/repos","events_url":"https://api.github.com/users/flowkey/events{/privacy}","received_events_url":"https://api.github.com/users/flowkey/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/flowkey/UIKit-cross-platform","description":"Cross-platform Swift implementation of UIKit, mostly for Android","fork":false,"url":"https://api.github.com/repos/flowkey/UIKit-cross-platform","forks_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/forks","keys_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/teams","hooks_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/hooks","issue_events_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/issues/events{/number}","events_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/events","assignees_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/assignees{/user}","branches_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/branches{/branch}","tags_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/tags","blobs_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/languages","stargazers_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/stargazers","contributors_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/contributors","subscribers_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/subscribers","subscription_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/subscription","commits_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/contents/{+path}","compare_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/merges","archive_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/downloads","issues_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/issues{/number}","pulls_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/labels{/name}","releases_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/releases{/id}","deployments_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/deployments","created_at":"2017-06-07T03:34:07Z","updated_at":"2018-11-30T13:36:00Z","pushed_at":"2018-11-30T16:01:01Z","git_url":"git://github.com/flowkey/UIKit-cross-platform.git","ssh_url":"git@github.com:flowkey/UIKit-cross-platform.git","clone_url":"https://github.com/flowkey/UIKit-cross-platform.git","svn_url":"https://github.com/flowkey/UIKit-cross-platform","homepage":"","size":10368,"stargazers_count":162,"watchers_count":162,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":7,"open_issues":18,"watchers":162,"default_branch":"master"}},"base":{"label":"flowkey:master","ref":"master","sha":"be7191b17d267814154d661aba29e497eb9c3371","user":{"login":"flowkey","id":5815111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4MTUxMTE=","avatar_url":"https://avatars3.githubusercontent.com/u/5815111?v=4","gravatar_id":"","url":"https://api.github.com/users/flowkey","html_url":"https://github.com/flowkey","followers_url":"https://api.github.com/users/flowkey/followers","following_url":"https://api.github.com/users/flowkey/following{/other_user}","gists_url":"https://api.github.com/users/flowkey/gists{/gist_id}","starred_url":"https://api.github.com/users/flowkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flowkey/subscriptions","organizations_url":"https://api.github.com/users/flowkey/orgs","repos_url":"https://api.github.com/users/flowkey/repos","events_url":"https://api.github.com/users/flowkey/events{/privacy}","received_events_url":"https://api.github.com/users/flowkey/received_events","type":"Organization","site_admin":false},"repo":{"id":93588967,"node_id":"MDEwOlJlcG9zaXRvcnk5MzU4ODk2Nw==","name":"UIKit-cross-platform","full_name":"flowkey/UIKit-cross-platform","private":false,"owner":{"login":"flowkey","id":5815111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4MTUxMTE=","avatar_url":"https://avatars3.githubusercontent.com/u/5815111?v=4","gravatar_id":"","url":"https://api.github.com/users/flowkey","html_url":"https://github.com/flowkey","followers_url":"https://api.github.com/users/flowkey/followers","following_url":"https://api.github.com/users/flowkey/following{/other_user}","gists_url":"https://api.github.com/users/flowkey/gists{/gist_id}","starred_url":"https://api.github.com/users/flowkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flowkey/subscriptions","organizations_url":"https://api.github.com/users/flowkey/orgs","repos_url":"https://api.github.com/users/flowkey/repos","events_url":"https://api.github.com/users/flowkey/events{/privacy}","received_events_url":"https://api.github.com/users/flowkey/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/flowkey/UIKit-cross-platform","description":"Cross-platform Swift implementation of UIKit, mostly for Android","fork":false,"url":"https://api.github.com/repos/flowkey/UIKit-cross-platform","forks_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/forks","keys_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/teams","hooks_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/hooks","issue_events_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/issues/events{/number}","events_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/events","assignees_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/assignees{/user}","branches_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/branches{/branch}","tags_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/tags","blobs_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/languages","stargazers_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/stargazers","contributors_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/contributors","subscribers_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/subscribers","subscription_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/subscription","commits_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/contents/{+path}","compare_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/merges","archive_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/downloads","issues_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/issues{/number}","pulls_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/labels{/name}","releases_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/releases{/id}","deployments_url":"https://api.github.com/repos/flowkey/UIKit-cross-platform/deployments","created_at":"2017-06-07T03:34:07Z","updated_at":"2018-11-30T13:36:00Z","pushed_at":"2018-11-30T16:01:01Z","git_url":"git://github.com/flowkey/UIKit-cross-platform.git","ssh_url":"git@github.com:flowkey/UIKit-cross-platform.git","clone_url":"https://github.com/flowkey/UIKit-cross-platform.git","svn_url":"https://github.com/flowkey/UIKit-cross-platform","homepage":"","size":10368,"stargazers_count":162,"watchers_count":162,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":7,"open_issues":18,"watchers":162,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flowkey/UIKit-cross-platform/pulls/269"},"html":{"href":"https://github.com/flowkey/UIKit-cross-platform/pull/269"},"issue":{"href":"https://api.github.com/repos/flowkey/UIKit-cross-platform/issues/269"},"comments":{"href":"https://api.github.com/repos/flowkey/UIKit-cross-platform/issues/269/comments"},"review_comments":{"href":"https://api.github.com/repos/flowkey/UIKit-cross-platform/pulls/269/comments"},"review_comment":{"href":"https://api.github.com/repos/flowkey/UIKit-cross-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flowkey/UIKit-cross-platform/pulls/269/commits"},"statuses":{"href":"https://api.github.com/repos/flowkey/UIKit-cross-platform/statuses/f0b41fe33c9298fda07238706b6022cb351e324a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rikner"}}