{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/215817331","pull_request_review_id":153170023,"id":215817331,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTgxNzMzMQ==","diff_hunk":"@@ -1571,8 +1571,9 @@ Pattern *Traversal::visitTypedPattern(TypedPattern *P) {\n   else\n     return nullptr;\n   if (!P->isImplicit())\n-    if (doIt(P->getTypeLoc()))\n-      return nullptr;\n+    if (auto *TR = P->getTypeRepr())\n+      if (doIt(TR))\n+        return nullptr;","path":"lib/AST/ASTWalker.cpp","position":8,"original_position":8,"commit_id":"a6734a99ba8f7a41003b67f90b8dc0c3716377bd","original_commit_id":"a182172ea0c1509f6a63e1e6fb828621282b5dc2","user":{"login":"jrose-apple","id":15097531,"node_id":"MDQ6VXNlcjE1MDk3NTMx","avatar_url":"https://avatars2.githubusercontent.com/u/15097531?v=4","gravatar_id":"","url":"https://api.github.com/users/jrose-apple","html_url":"https://github.com/jrose-apple","followers_url":"https://api.github.com/users/jrose-apple/followers","following_url":"https://api.github.com/users/jrose-apple/following{/other_user}","gists_url":"https://api.github.com/users/jrose-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/jrose-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrose-apple/subscriptions","organizations_url":"https://api.github.com/users/jrose-apple/orgs","repos_url":"https://api.github.com/users/jrose-apple/repos","events_url":"https://api.github.com/users/jrose-apple/events{/privacy}","received_events_url":"https://api.github.com/users/jrose-apple/received_events","type":"User","site_admin":false},"body":"I don't see a single walkToTypeLoc(Pre|Post) in our repo that would care, so I think you should just go ahead with this.","created_at":"2018-09-07T00:39:16Z","updated_at":"2018-09-07T00:39:16Z","html_url":"https://github.com/apple/swift/pull/19175#discussion_r215817331","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/19175","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/215817331"},"html":{"href":"https://github.com/apple/swift/pull/19175#discussion_r215817331"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/19175"}},"in_reply_to_id":215811440},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/19175","id":213772373,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNzcyMzcz","html_url":"https://github.com/apple/swift/pull/19175","diff_url":"https://github.com/apple/swift/pull/19175.diff","patch_url":"https://github.com/apple/swift/pull/19175.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/19175","number":19175,"state":"open","locked":false,"title":"[AST] Remove stored TypeLoc from TypedPattern","user":{"login":"harlanhaskins","id":853032,"node_id":"MDQ6VXNlcjg1MzAzMg==","avatar_url":"https://avatars1.githubusercontent.com/u/853032?v=4","gravatar_id":"","url":"https://api.github.com/users/harlanhaskins","html_url":"https://github.com/harlanhaskins","followers_url":"https://api.github.com/users/harlanhaskins/followers","following_url":"https://api.github.com/users/harlanhaskins/following{/other_user}","gists_url":"https://api.github.com/users/harlanhaskins/gists{/gist_id}","starred_url":"https://api.github.com/users/harlanhaskins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harlanhaskins/subscriptions","organizations_url":"https://api.github.com/users/harlanhaskins/orgs","repos_url":"https://api.github.com/users/harlanhaskins/repos","events_url":"https://api.github.com/users/harlanhaskins/events{/privacy}","received_events_url":"https://api.github.com/users/harlanhaskins/received_events","type":"User","site_admin":false},"body":"TypedPattern was only using this TypeLoc as a means to a TypeRepr, which\r\ncaused it to store the pattern type twice (through the superclass and through\r\nthe TypeLoc itself.)\r\n\r\nThis also fixes a bug where deserializing a TypedPattern doesn't store\r\nthe type correctly and generally cleans up TypedPattern initialization.\r\n\r\nResolves rdar://44144435","created_at":"2018-09-06T22:53:52Z","updated_at":"2018-09-07T00:39:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e34e871e3da924e71956f504572dde67d6fe6fbe","assignee":null,"assignees":[],"requested_reviewers":[{"login":"DougGregor","id":989428,"node_id":"MDQ6VXNlcjk4OTQyOA==","avatar_url":"https://avatars3.githubusercontent.com/u/989428?v=4","gravatar_id":"","url":"https://api.github.com/users/DougGregor","html_url":"https://github.com/DougGregor","followers_url":"https://api.github.com/users/DougGregor/followers","following_url":"https://api.github.com/users/DougGregor/following{/other_user}","gists_url":"https://api.github.com/users/DougGregor/gists{/gist_id}","starred_url":"https://api.github.com/users/DougGregor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DougGregor/subscriptions","organizations_url":"https://api.github.com/users/DougGregor/orgs","repos_url":"https://api.github.com/users/DougGregor/repos","events_url":"https://api.github.com/users/DougGregor/events{/privacy}","received_events_url":"https://api.github.com/users/DougGregor/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/19175/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/19175/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/19175/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/a6734a99ba8f7a41003b67f90b8dc0c3716377bd","head":{"label":"harlanhaskins:typelocn't","ref":"typelocn't","sha":"a6734a99ba8f7a41003b67f90b8dc0c3716377bd","user":{"login":"harlanhaskins","id":853032,"node_id":"MDQ6VXNlcjg1MzAzMg==","avatar_url":"https://avatars1.githubusercontent.com/u/853032?v=4","gravatar_id":"","url":"https://api.github.com/users/harlanhaskins","html_url":"https://github.com/harlanhaskins","followers_url":"https://api.github.com/users/harlanhaskins/followers","following_url":"https://api.github.com/users/harlanhaskins/following{/other_user}","gists_url":"https://api.github.com/users/harlanhaskins/gists{/gist_id}","starred_url":"https://api.github.com/users/harlanhaskins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harlanhaskins/subscriptions","organizations_url":"https://api.github.com/users/harlanhaskins/orgs","repos_url":"https://api.github.com/users/harlanhaskins/repos","events_url":"https://api.github.com/users/harlanhaskins/events{/privacy}","received_events_url":"https://api.github.com/users/harlanhaskins/received_events","type":"User","site_admin":false},"repo":{"id":50544638,"node_id":"MDEwOlJlcG9zaXRvcnk1MDU0NDYzOA==","name":"swift","full_name":"harlanhaskins/swift","owner":{"login":"harlanhaskins","id":853032,"node_id":"MDQ6VXNlcjg1MzAzMg==","avatar_url":"https://avatars1.githubusercontent.com/u/853032?v=4","gravatar_id":"","url":"https://api.github.com/users/harlanhaskins","html_url":"https://github.com/harlanhaskins","followers_url":"https://api.github.com/users/harlanhaskins/followers","following_url":"https://api.github.com/users/harlanhaskins/following{/other_user}","gists_url":"https://api.github.com/users/harlanhaskins/gists{/gist_id}","starred_url":"https://api.github.com/users/harlanhaskins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harlanhaskins/subscriptions","organizations_url":"https://api.github.com/users/harlanhaskins/orgs","repos_url":"https://api.github.com/users/harlanhaskins/repos","events_url":"https://api.github.com/users/harlanhaskins/events{/privacy}","received_events_url":"https://api.github.com/users/harlanhaskins/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/harlanhaskins/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/harlanhaskins/swift","forks_url":"https://api.github.com/repos/harlanhaskins/swift/forks","keys_url":"https://api.github.com/repos/harlanhaskins/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/harlanhaskins/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/harlanhaskins/swift/teams","hooks_url":"https://api.github.com/repos/harlanhaskins/swift/hooks","issue_events_url":"https://api.github.com/repos/harlanhaskins/swift/issues/events{/number}","events_url":"https://api.github.com/repos/harlanhaskins/swift/events","assignees_url":"https://api.github.com/repos/harlanhaskins/swift/assignees{/user}","branches_url":"https://api.github.com/repos/harlanhaskins/swift/branches{/branch}","tags_url":"https://api.github.com/repos/harlanhaskins/swift/tags","blobs_url":"https://api.github.com/repos/harlanhaskins/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/harlanhaskins/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/harlanhaskins/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/harlanhaskins/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/harlanhaskins/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/harlanhaskins/swift/languages","stargazers_url":"https://api.github.com/repos/harlanhaskins/swift/stargazers","contributors_url":"https://api.github.com/repos/harlanhaskins/swift/contributors","subscribers_url":"https://api.github.com/repos/harlanhaskins/swift/subscribers","subscription_url":"https://api.github.com/repos/harlanhaskins/swift/subscription","commits_url":"https://api.github.com/repos/harlanhaskins/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/harlanhaskins/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/harlanhaskins/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/harlanhaskins/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/harlanhaskins/swift/contents/{+path}","compare_url":"https://api.github.com/repos/harlanhaskins/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/harlanhaskins/swift/merges","archive_url":"https://api.github.com/repos/harlanhaskins/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/harlanhaskins/swift/downloads","issues_url":"https://api.github.com/repos/harlanhaskins/swift/issues{/number}","pulls_url":"https://api.github.com/repos/harlanhaskins/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/harlanhaskins/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/harlanhaskins/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/harlanhaskins/swift/labels{/name}","releases_url":"https://api.github.com/repos/harlanhaskins/swift/releases{/id}","deployments_url":"https://api.github.com/repos/harlanhaskins/swift/deployments","created_at":"2016-01-27T23:09:47Z","updated_at":"2018-09-06T16:59:31Z","pushed_at":"2018-09-07T00:29:44Z","git_url":"git://github.com/harlanhaskins/swift.git","ssh_url":"git@github.com:harlanhaskins/swift.git","clone_url":"https://github.com/harlanhaskins/swift.git","svn_url":"https://github.com/harlanhaskins/swift","homepage":"https://swift.org/","size":313143,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"35602c4d29fde201bce2abdf691879cba5021bb3","user":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"node_id":"MDEwOlJlcG9zaXRvcnk0NDgzODk0OQ==","name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2018-09-07T00:34:26Z","pushed_at":"2018-09-07T00:35:37Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org","size":337540,"stargazers_count":45103,"watchers_count":45103,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7113,"mirror_url":null,"archived":false,"open_issues_count":373,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7113,"open_issues":373,"watchers":45103,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/19175"},"html":{"href":"https://github.com/apple/swift/pull/19175"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/19175"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/19175/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/19175/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/19175/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/a6734a99ba8f7a41003b67f90b8dc0c3716377bd"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jrose-apple"}}