{"action":"opened","number":937,"pull_request":{"url":"https://api.github.com/repos/datawire/ambassador/pulls/937","id":226121593,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MTIxNTkz","html_url":"https://github.com/datawire/ambassador/pull/937","diff_url":"https://github.com/datawire/ambassador/pull/937.diff","patch_url":"https://github.com/datawire/ambassador/pull/937.patch","issue_url":"https://api.github.com/repos/datawire/ambassador/issues/937","number":937,"state":"open","locked":false,"title":"Fix Helm charts Nodeport setup by setting Nodeport on HTTPS side","user":{"login":"n1koo","id":1556937,"node_id":"MDQ6VXNlcjE1NTY5Mzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1556937?v=4","gravatar_id":"","url":"https://api.github.com/users/n1koo","html_url":"https://github.com/n1koo","followers_url":"https://api.github.com/users/n1koo/followers","following_url":"https://api.github.com/users/n1koo/following{/other_user}","gists_url":"https://api.github.com/users/n1koo/gists{/gist_id}","starred_url":"https://api.github.com/users/n1koo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n1koo/subscriptions","organizations_url":"https://api.github.com/users/n1koo/orgs","repos_url":"https://api.github.com/users/n1koo/repos","events_url":"https://api.github.com/users/n1koo/events{/privacy}","received_events_url":"https://api.github.com/users/n1koo/received_events","type":"User","site_admin":false},"body":"**What**\r\n\r\n- Add `nodePort` to `https` side in the k8s service\r\n- Make both `http` and `https` ports configurable rather than hardcoding latter to 443\r\n\r\n**Why**\r\n\r\nWithout a dedicated `nodePort` per `port` k8s will just choose one randomly and most likely it will be orphaned from the actual backend\r\n\r\nThe latter change for having 443 configurable is more of a nicety, but usually people being behind ELB's and such don't use 80/443 here.","created_at":"2018-10-26T14:37:51Z","updated_at":"2018-10-26T14:37:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/datawire/ambassador/pulls/937/commits","review_comments_url":"https://api.github.com/repos/datawire/ambassador/pulls/937/comments","review_comment_url":"https://api.github.com/repos/datawire/ambassador/pulls/comments{/number}","comments_url":"https://api.github.com/repos/datawire/ambassador/issues/937/comments","statuses_url":"https://api.github.com/repos/datawire/ambassador/statuses/e1facaab48b7d89918ac4c4c607b4240cf12875a","head":{"label":"n1koo:fix_nodeport_svc","ref":"fix_nodeport_svc","sha":"e1facaab48b7d89918ac4c4c607b4240cf12875a","user":{"login":"n1koo","id":1556937,"node_id":"MDQ6VXNlcjE1NTY5Mzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1556937?v=4","gravatar_id":"","url":"https://api.github.com/users/n1koo","html_url":"https://github.com/n1koo","followers_url":"https://api.github.com/users/n1koo/followers","following_url":"https://api.github.com/users/n1koo/following{/other_user}","gists_url":"https://api.github.com/users/n1koo/gists{/gist_id}","starred_url":"https://api.github.com/users/n1koo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n1koo/subscriptions","organizations_url":"https://api.github.com/users/n1koo/orgs","repos_url":"https://api.github.com/users/n1koo/repos","events_url":"https://api.github.com/users/n1koo/events{/privacy}","received_events_url":"https://api.github.com/users/n1koo/received_events","type":"User","site_admin":false},"repo":{"id":154525140,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ1MjUxNDA=","name":"ambassador","full_name":"n1koo/ambassador","private":false,"owner":{"login":"n1koo","id":1556937,"node_id":"MDQ6VXNlcjE1NTY5Mzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1556937?v=4","gravatar_id":"","url":"https://api.github.com/users/n1koo","html_url":"https://github.com/n1koo","followers_url":"https://api.github.com/users/n1koo/followers","following_url":"https://api.github.com/users/n1koo/following{/other_user}","gists_url":"https://api.github.com/users/n1koo/gists{/gist_id}","starred_url":"https://api.github.com/users/n1koo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n1koo/subscriptions","organizations_url":"https://api.github.com/users/n1koo/orgs","repos_url":"https://api.github.com/users/n1koo/repos","events_url":"https://api.github.com/users/n1koo/events{/privacy}","received_events_url":"https://api.github.com/users/n1koo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/n1koo/ambassador","description":"open source Kubernetes-native API gateway for microservices built on the Envoy Proxy","fork":true,"url":"https://api.github.com/repos/n1koo/ambassador","forks_url":"https://api.github.com/repos/n1koo/ambassador/forks","keys_url":"https://api.github.com/repos/n1koo/ambassador/keys{/key_id}","collaborators_url":"https://api.github.com/repos/n1koo/ambassador/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/n1koo/ambassador/teams","hooks_url":"https://api.github.com/repos/n1koo/ambassador/hooks","issue_events_url":"https://api.github.com/repos/n1koo/ambassador/issues/events{/number}","events_url":"https://api.github.com/repos/n1koo/ambassador/events","assignees_url":"https://api.github.com/repos/n1koo/ambassador/assignees{/user}","branches_url":"https://api.github.com/repos/n1koo/ambassador/branches{/branch}","tags_url":"https://api.github.com/repos/n1koo/ambassador/tags","blobs_url":"https://api.github.com/repos/n1koo/ambassador/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/n1koo/ambassador/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/n1koo/ambassador/git/refs{/sha}","trees_url":"https://api.github.com/repos/n1koo/ambassador/git/trees{/sha}","statuses_url":"https://api.github.com/repos/n1koo/ambassador/statuses/{sha}","languages_url":"https://api.github.com/repos/n1koo/ambassador/languages","stargazers_url":"https://api.github.com/repos/n1koo/ambassador/stargazers","contributors_url":"https://api.github.com/repos/n1koo/ambassador/contributors","subscribers_url":"https://api.github.com/repos/n1koo/ambassador/subscribers","subscription_url":"https://api.github.com/repos/n1koo/ambassador/subscription","commits_url":"https://api.github.com/repos/n1koo/ambassador/commits{/sha}","git_commits_url":"https://api.github.com/repos/n1koo/ambassador/git/commits{/sha}","comments_url":"https://api.github.com/repos/n1koo/ambassador/comments{/number}","issue_comment_url":"https://api.github.com/repos/n1koo/ambassador/issues/comments{/number}","contents_url":"https://api.github.com/repos/n1koo/ambassador/contents/{+path}","compare_url":"https://api.github.com/repos/n1koo/ambassador/compare/{base}...{head}","merges_url":"https://api.github.com/repos/n1koo/ambassador/merges","archive_url":"https://api.github.com/repos/n1koo/ambassador/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/n1koo/ambassador/downloads","issues_url":"https://api.github.com/repos/n1koo/ambassador/issues{/number}","pulls_url":"https://api.github.com/repos/n1koo/ambassador/pulls{/number}","milestones_url":"https://api.github.com/repos/n1koo/ambassador/milestones{/number}","notifications_url":"https://api.github.com/repos/n1koo/ambassador/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/n1koo/ambassador/labels{/name}","releases_url":"https://api.github.com/repos/n1koo/ambassador/releases{/id}","deployments_url":"https://api.github.com/repos/n1koo/ambassador/deployments","created_at":"2018-10-24T15:30:19Z","updated_at":"2018-10-25T12:29:23Z","pushed_at":"2018-10-26T14:35:32Z","git_url":"git://github.com/n1koo/ambassador.git","ssh_url":"git@github.com:n1koo/ambassador.git","clone_url":"https://github.com/n1koo/ambassador.git","svn_url":"https://github.com/n1koo/ambassador","homepage":"https://www.getambassador.io","size":11872,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"datawire:master","ref":"master","sha":"212754165c7392c88db5f62bd1fba9c5239d7fa4","user":{"login":"datawire","id":9270257,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNzAyNTc=","avatar_url":"https://avatars0.githubusercontent.com/u/9270257?v=4","gravatar_id":"","url":"https://api.github.com/users/datawire","html_url":"https://github.com/datawire","followers_url":"https://api.github.com/users/datawire/followers","following_url":"https://api.github.com/users/datawire/following{/other_user}","gists_url":"https://api.github.com/users/datawire/gists{/gist_id}","starred_url":"https://api.github.com/users/datawire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datawire/subscriptions","organizations_url":"https://api.github.com/users/datawire/orgs","repos_url":"https://api.github.com/users/datawire/repos","events_url":"https://api.github.com/users/datawire/events{/privacy}","received_events_url":"https://api.github.com/users/datawire/received_events","type":"Organization","site_admin":false},"repo":{"id":86740149,"node_id":"MDEwOlJlcG9zaXRvcnk4Njc0MDE0OQ==","name":"ambassador","full_name":"datawire/ambassador","private":false,"owner":{"login":"datawire","id":9270257,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNzAyNTc=","avatar_url":"https://avatars0.githubusercontent.com/u/9270257?v=4","gravatar_id":"","url":"https://api.github.com/users/datawire","html_url":"https://github.com/datawire","followers_url":"https://api.github.com/users/datawire/followers","following_url":"https://api.github.com/users/datawire/following{/other_user}","gists_url":"https://api.github.com/users/datawire/gists{/gist_id}","starred_url":"https://api.github.com/users/datawire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datawire/subscriptions","organizations_url":"https://api.github.com/users/datawire/orgs","repos_url":"https://api.github.com/users/datawire/repos","events_url":"https://api.github.com/users/datawire/events{/privacy}","received_events_url":"https://api.github.com/users/datawire/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/datawire/ambassador","description":"open source Kubernetes-native API gateway for microservices built on the Envoy Proxy","fork":false,"url":"https://api.github.com/repos/datawire/ambassador","forks_url":"https://api.github.com/repos/datawire/ambassador/forks","keys_url":"https://api.github.com/repos/datawire/ambassador/keys{/key_id}","collaborators_url":"https://api.github.com/repos/datawire/ambassador/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/datawire/ambassador/teams","hooks_url":"https://api.github.com/repos/datawire/ambassador/hooks","issue_events_url":"https://api.github.com/repos/datawire/ambassador/issues/events{/number}","events_url":"https://api.github.com/repos/datawire/ambassador/events","assignees_url":"https://api.github.com/repos/datawire/ambassador/assignees{/user}","branches_url":"https://api.github.com/repos/datawire/ambassador/branches{/branch}","tags_url":"https://api.github.com/repos/datawire/ambassador/tags","blobs_url":"https://api.github.com/repos/datawire/ambassador/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/datawire/ambassador/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/datawire/ambassador/git/refs{/sha}","trees_url":"https://api.github.com/repos/datawire/ambassador/git/trees{/sha}","statuses_url":"https://api.github.com/repos/datawire/ambassador/statuses/{sha}","languages_url":"https://api.github.com/repos/datawire/ambassador/languages","stargazers_url":"https://api.github.com/repos/datawire/ambassador/stargazers","contributors_url":"https://api.github.com/repos/datawire/ambassador/contributors","subscribers_url":"https://api.github.com/repos/datawire/ambassador/subscribers","subscription_url":"https://api.github.com/repos/datawire/ambassador/subscription","commits_url":"https://api.github.com/repos/datawire/ambassador/commits{/sha}","git_commits_url":"https://api.github.com/repos/datawire/ambassador/git/commits{/sha}","comments_url":"https://api.github.com/repos/datawire/ambassador/comments{/number}","issue_comment_url":"https://api.github.com/repos/datawire/ambassador/issues/comments{/number}","contents_url":"https://api.github.com/repos/datawire/ambassador/contents/{+path}","compare_url":"https://api.github.com/repos/datawire/ambassador/compare/{base}...{head}","merges_url":"https://api.github.com/repos/datawire/ambassador/merges","archive_url":"https://api.github.com/repos/datawire/ambassador/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/datawire/ambassador/downloads","issues_url":"https://api.github.com/repos/datawire/ambassador/issues{/number}","pulls_url":"https://api.github.com/repos/datawire/ambassador/pulls{/number}","milestones_url":"https://api.github.com/repos/datawire/ambassador/milestones{/number}","notifications_url":"https://api.github.com/repos/datawire/ambassador/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/datawire/ambassador/labels{/name}","releases_url":"https://api.github.com/repos/datawire/ambassador/releases{/id}","deployments_url":"https://api.github.com/repos/datawire/ambassador/deployments","created_at":"2017-03-30T19:22:52Z","updated_at":"2018-10-26T13:34:03Z","pushed_at":"2018-10-26T12:29:25Z","git_url":"git://github.com/datawire/ambassador.git","ssh_url":"git@github.com:datawire/ambassador.git","clone_url":"https://github.com/datawire/ambassador.git","svn_url":"https://github.com/datawire/ambassador","homepage":"https://www.getambassador.io","size":11916,"stargazers_count":1246,"watchers_count":1246,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":149,"mirror_url":null,"archived":false,"open_issues_count":190,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":149,"open_issues":190,"watchers":1246,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/datawire/ambassador/pulls/937"},"html":{"href":"https://github.com/datawire/ambassador/pull/937"},"issue":{"href":"https://api.github.com/repos/datawire/ambassador/issues/937"},"comments":{"href":"https://api.github.com/repos/datawire/ambassador/issues/937/comments"},"review_comments":{"href":"https://api.github.com/repos/datawire/ambassador/pulls/937/comments"},"review_comment":{"href":"https://api.github.com/repos/datawire/ambassador/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/datawire/ambassador/pulls/937/commits"},"statuses":{"href":"https://api.github.com/repos/datawire/ambassador/statuses/e1facaab48b7d89918ac4c4c607b4240cf12875a"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":10,"deletions":5,"changed_files":2}}
{"actor":{"display_login":"n1koo"}}