{"action":"opened","number":1428,"pull_request":{"url":"https://api.github.com/repos/broadinstitute/firecloud-ui/pulls/1428","id":219019045,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MDE5MDQ1","html_url":"https://github.com/broadinstitute/firecloud-ui/pull/1428","diff_url":"https://github.com/broadinstitute/firecloud-ui/pull/1428.diff","patch_url":"https://github.com/broadinstitute/firecloud-ui/pull/1428.patch","issue_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/issues/1428","number":1428,"state":"open","locked":false,"title":"remove infinite spinner on method-not-found in agora [risk: low]","user":{"login":"davidangb","id":6041577,"node_id":"MDQ6VXNlcjYwNDE1Nzc=","avatar_url":"https://avatars1.githubusercontent.com/u/6041577?v=4","gravatar_id":"","url":"https://api.github.com/users/davidangb","html_url":"https://github.com/davidangb","followers_url":"https://api.github.com/users/davidangb/followers","following_url":"https://api.github.com/users/davidangb/following{/other_user}","gists_url":"https://api.github.com/users/davidangb/gists{/gist_id}","starred_url":"https://api.github.com/users/davidangb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidangb/subscriptions","organizations_url":"https://api.github.com/users/davidangb/orgs","repos_url":"https://api.github.com/users/davidangb/repos","events_url":"https://api.github.com/users/davidangb/events{/privacy}","received_events_url":"https://api.github.com/users/davidangb/received_events","type":"User","site_admin":false},"body":"source bug: DataBiosphere/firecloud-app#67\r\nrelated: broadinstitute/agora#266\r\n\r\nIf you manually specify a namespace/name/snapshotId that does not exist when viewing a method's details - for instance, you had a bookmark that is no longer valid - you get an infinite spinner. This PR fixes that; it removes the spinner while keeping the underlying error message as-is.\r\n\r\nThis UI PR only removes the infinite spinner. broadinstitute/agora#266 improves the underlying error message to be more helpful to the end user.\r\n\r\n-----\r\n\r\n- [ ] **Submitter**: Include the JIRA issue number in the PR description\r\n- [ ] **Submitter**: Check documentation and code comments. Add explanatory PR comments if helpful.\r\n- [ ] **Submitter**: If you changed a URL that is used elsewhere (e.g. in an email), comment about where it is used and ensure the dependent code is updated.\r\n- [ ] **Submitter**: JIRA ticket checks:\r\n  * Acceptance criteria exists and is met\r\n  * Note any changes to implementation from the description\r\n  * To Demo flag is set\r\n  * Release Summary is filled out, if applicable\r\n  * Add notes on how to QA\r\n- [ ] **Submitter**: Update RC_XXX release ticket with any config or environment changes necessary\r\n- [ ] **Submitter**: Update FISMA documentation if changes to:\r\n  * Authentication\r\n  * Authorization\r\n  * Encryption\r\n  * Audit trails\r\n- [ ] **Submitter**: If you're adding new libraries, sign us up to security updates for them\r\n- [ ] **Submitter**: If you're adding new automated UI tests, review the test plan with QA\r\n* Review cycle:\r\n  * LR reviews\r\n  * Rest of team may comment on PR at will\r\n  * **LR assigns to submitter** for feedback fixes\r\n  * Submitter rebases to develop again if necessary\r\n  * Submitter makes further commits. DO NOT SQUASH\r\n  * Submitter updates documentation as needed\r\n  * Submitter **reassigns to LR** for further feedback\r\n- [ ] **TL** sign off\r\n- [ ] **LR** sign off\r\n- [ ] **Product Owner** sign off\r\n- [ ] **Submitter**: Verify all tests go green, including CI tests and automated UI tests.\r\n- [ ] **Submitter**: Squash commits and merge to develop. If adding test code, merge application code and test code at the same time.\r\n- [ ] **Submitter**: Delete branch after merge\r\n- [ ] **Submitter**: **Test this change works on dev environment after deployment**. YOU own getting it fixed if dev isn't working for ANY reason!\r\n- [ ] **Submitter**: Mark JIRA issue as resolved once this checklist is completed\r\n","created_at":"2018-09-28T16:16:44Z","updated_at":"2018-09-28T16:16:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/pulls/1428/commits","review_comments_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/pulls/1428/comments","review_comment_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/issues/1428/comments","statuses_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/statuses/69ffc12dcd709c5aa97aeab0dd741fa4beb7c43c","head":{"label":"broadinstitute:da_67_methodNotFound","ref":"da_67_methodNotFound","sha":"69ffc12dcd709c5aa97aeab0dd741fa4beb7c43c","user":{"login":"broadinstitute","id":393552,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MzU1Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":37272584,"node_id":"MDEwOlJlcG9zaXRvcnkzNzI3MjU4NA==","name":"firecloud-ui","full_name":"broadinstitute/firecloud-ui","private":false,"owner":{"login":"broadinstitute","id":393552,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MzU1Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/broadinstitute/firecloud-ui","description":"FireCloud user interface for web browsers.","fork":false,"url":"https://api.github.com/repos/broadinstitute/firecloud-ui","forks_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/forks","keys_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/teams","hooks_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/events","assignees_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/tags","blobs_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/subscription","commits_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/merges","archive_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/downloads","issues_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/releases{/id}","deployments_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/deployments","created_at":"2015-06-11T16:26:05Z","updated_at":"2018-09-26T21:06:30Z","pushed_at":"2018-09-28T16:00:49Z","git_url":"git://github.com/broadinstitute/firecloud-ui.git","ssh_url":"git@github.com:broadinstitute/firecloud-ui.git","clone_url":"https://github.com/broadinstitute/firecloud-ui.git","svn_url":"https://github.com/broadinstitute/firecloud-ui","homepage":"https://portal.firecloud.org","size":5876,"stargazers_count":17,"watchers_count":17,"language":"Clojure","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":5,"open_issues":7,"watchers":17,"default_branch":"develop"}},"base":{"label":"broadinstitute:develop","ref":"develop","sha":"d87ac9bddb11b4d2f055243be74f103c17c4b52a","user":{"login":"broadinstitute","id":393552,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MzU1Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":37272584,"node_id":"MDEwOlJlcG9zaXRvcnkzNzI3MjU4NA==","name":"firecloud-ui","full_name":"broadinstitute/firecloud-ui","private":false,"owner":{"login":"broadinstitute","id":393552,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MzU1Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/broadinstitute/firecloud-ui","description":"FireCloud user interface for web browsers.","fork":false,"url":"https://api.github.com/repos/broadinstitute/firecloud-ui","forks_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/forks","keys_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/teams","hooks_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/events","assignees_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/tags","blobs_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/subscription","commits_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/merges","archive_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/downloads","issues_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/releases{/id}","deployments_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/deployments","created_at":"2015-06-11T16:26:05Z","updated_at":"2018-09-26T21:06:30Z","pushed_at":"2018-09-28T16:00:49Z","git_url":"git://github.com/broadinstitute/firecloud-ui.git","ssh_url":"git@github.com:broadinstitute/firecloud-ui.git","clone_url":"https://github.com/broadinstitute/firecloud-ui.git","svn_url":"https://github.com/broadinstitute/firecloud-ui","homepage":"https://portal.firecloud.org","size":5876,"stargazers_count":17,"watchers_count":17,"language":"Clojure","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":5,"open_issues":7,"watchers":17,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/firecloud-ui/pulls/1428"},"html":{"href":"https://github.com/broadinstitute/firecloud-ui/pull/1428"},"issue":{"href":"https://api.github.com/repos/broadinstitute/firecloud-ui/issues/1428"},"comments":{"href":"https://api.github.com/repos/broadinstitute/firecloud-ui/issues/1428/comments"},"review_comments":{"href":"https://api.github.com/repos/broadinstitute/firecloud-ui/pulls/1428/comments"},"review_comment":{"href":"https://api.github.com/repos/broadinstitute/firecloud-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/broadinstitute/firecloud-ui/pulls/1428/commits"},"statuses":{"href":"https://api.github.com/repos/broadinstitute/firecloud-ui/statuses/69ffc12dcd709c5aa97aeab0dd741fa4beb7c43c"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"davidangb"}}