{"action":"created","comment":{"url":"https://api.github.com/repos/ashcrow/container-linux-update-operator/pulls/comments/181508114","pull_request_review_id":112156923,"id":181508114,"diff_hunk":"@@ -87,6 +94,31 @@ func (c *Client) Close() error {\n \treturn nil\n }\n \n+const (\n+\tdbusSdName      = \"org.freedesktop.systemd1\"\n+\tdbusSdManager   = \"/org/freedesktop/systemd1\"\n+\tdbusSdManagerIf = \"org.freedesktop.systemd1.Manager\"\n+)\n+\n+func (c *Client) disableRPMOSTreeAutoUpdates() error {\n+\t// for now, just mask the systemd service -- alternatively, also mount\n+\t// /etc/rpm-ostreed.conf and turn off setting permanently?\n+\tmgr := c.conn.Object(dbusSdName, dbus.ObjectPath(dbusSdManager))\n+\n+\terr := mgr.Call(dbusMember(dbusSdManagerIf, \"MaskUnitFiles\"), 0,\n+\t                [1]string{\"rpm-ostreed-automatic.service\"}, false, true).Err\n+\tif err != nil {\n+\t\treturn err\n+\t}\n+\n+\terr = mgr.Call(dbusMember(dbusSdManagerIf, \"Reload\"), 0).Err","path":"pkg/updateengine/client.go","position":null,"original_position":35,"commit_id":"1d73ab162af744fe42a85fcd0b4805737f0f5b9a","original_commit_id":"1d73ab162af744fe42a85fcd0b4805737f0f5b9a","user":{"login":"cgwalters","id":244096,"avatar_url":"https://avatars0.githubusercontent.com/u/244096?v=4","gravatar_id":"","url":"https://api.github.com/users/cgwalters","html_url":"https://github.com/cgwalters","followers_url":"https://api.github.com/users/cgwalters/followers","following_url":"https://api.github.com/users/cgwalters/following{/other_user}","gists_url":"https://api.github.com/users/cgwalters/gists{/gist_id}","starred_url":"https://api.github.com/users/cgwalters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgwalters/subscriptions","organizations_url":"https://api.github.com/users/cgwalters/orgs","repos_url":"https://api.github.com/users/cgwalters/repos","events_url":"https://api.github.com/users/cgwalters/events{/privacy}","received_events_url":"https://api.github.com/users/cgwalters/received_events","type":"User","site_admin":false},"body":"Fine for now, down the line it's probably better to only do this reload if we detect the unit isn't already masked or so.","created_at":"2018-04-13T20:56:28Z","updated_at":"2018-04-13T21:04:24Z","html_url":"https://github.com/ashcrow/container-linux-update-operator/pull/2#discussion_r181508114","pull_request_url":"https://api.github.com/repos/ashcrow/container-linux-update-operator/pulls/2","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ashcrow/container-linux-update-operator/pulls/comments/181508114"},"html":{"href":"https://github.com/ashcrow/container-linux-update-operator/pull/2#discussion_r181508114"},"pull_request":{"href":"https://api.github.com/repos/ashcrow/container-linux-update-operator/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/ashcrow/container-linux-update-operator/pulls/2","id":181592061,"html_url":"https://github.com/ashcrow/container-linux-update-operator/pull/2","diff_url":"https://github.com/ashcrow/container-linux-update-operator/pull/2.diff","patch_url":"https://github.com/ashcrow/container-linux-update-operator/pull/2.patch","issue_url":"https://api.github.com/repos/ashcrow/container-linux-update-operator/issues/2","number":2,"state":"open","locked":false,"title":"Don't rely on timer, directly call Upgrade()","user":{"login":"jlebon","id":11934099,"avatar_url":"https://avatars3.githubusercontent.com/u/11934099?v=4","gravatar_id":"","url":"https://api.github.com/users/jlebon","html_url":"https://github.com/jlebon","followers_url":"https://api.github.com/users/jlebon/followers","following_url":"https://api.github.com/users/jlebon/following{/other_user}","gists_url":"https://api.github.com/users/jlebon/gists{/gist_id}","starred_url":"https://api.github.com/users/jlebon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlebon/subscriptions","organizations_url":"https://api.github.com/users/jlebon/orgs","repos_url":"https://api.github.com/users/jlebon/repos","events_url":"https://api.github.com/users/jlebon/events{/privacy}","received_events_url":"https://api.github.com/users/jlebon/received_events","type":"User","site_admin":false},"body":"As discussed, let's switch our agent from relying on the shipped rpm-ostree timer and doing the upgrades itself. There are a bunch of obvious issues and enhancements lingering in this code (marked as `XXX` :)), but I've confirmed that it works as intended. It seems \"good enough\" for POC purposes.","created_at":"2018-04-13T20:45:19Z","updated_at":"2018-04-13T21:04:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e017bfceebf91be5d27a7b5feaec8a0e7e4b4a72","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ashcrow/container-linux-update-operator/pulls/2/commits","review_comments_url":"https://api.github.com/repos/ashcrow/container-linux-update-operator/pulls/2/comments","review_comment_url":"https://api.github.com/repos/ashcrow/container-linux-update-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ashcrow/container-linux-update-operator/issues/2/comments","statuses_url":"https://api.github.com/repos/ashcrow/container-linux-update-operator/statuses/1d73ab162af744fe42a85fcd0b4805737f0f5b9a","head":{"label":"jlebon:pr/self-update","ref":"pr/self-update","sha":"1d73ab162af744fe42a85fcd0b4805737f0f5b9a","user":{"login":"jlebon","id":11934099,"avatar_url":"https://avatars3.githubusercontent.com/u/11934099?v=4","gravatar_id":"","url":"https://api.github.com/users/jlebon","html_url":"https://github.com/jlebon","followers_url":"https://api.github.com/users/jlebon/followers","following_url":"https://api.github.com/users/jlebon/following{/other_user}","gists_url":"https://api.github.com/users/jlebon/gists{/gist_id}","starred_url":"https://api.github.com/users/jlebon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlebon/subscriptions","organizations_url":"https://api.github.com/users/jlebon/orgs","repos_url":"https://api.github.com/users/jlebon/repos","events_url":"https://api.github.com/users/jlebon/events{/privacy}","received_events_url":"https://api.github.com/users/jlebon/received_events","type":"User","site_admin":false},"repo":{"id":127324281,"name":"container-linux-update-operator","full_name":"jlebon/container-linux-update-operator","owner":{"login":"jlebon","id":11934099,"avatar_url":"https://avatars3.githubusercontent.com/u/11934099?v=4","gravatar_id":"","url":"https://api.github.com/users/jlebon","html_url":"https://github.com/jlebon","followers_url":"https://api.github.com/users/jlebon/followers","following_url":"https://api.github.com/users/jlebon/following{/other_user}","gists_url":"https://api.github.com/users/jlebon/gists{/gist_id}","starred_url":"https://api.github.com/users/jlebon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlebon/subscriptions","organizations_url":"https://api.github.com/users/jlebon/orgs","repos_url":"https://api.github.com/users/jlebon/repos","events_url":"https://api.github.com/users/jlebon/events{/privacy}","received_events_url":"https://api.github.com/users/jlebon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jlebon/container-linux-update-operator","description":"A Kubernetes operator to manage updates of Container Linux by CoreOS ","fork":true,"url":"https://api.github.com/repos/jlebon/container-linux-update-operator","forks_url":"https://api.github.com/repos/jlebon/container-linux-update-operator/forks","keys_url":"https://api.github.com/repos/jlebon/container-linux-update-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jlebon/container-linux-update-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jlebon/container-linux-update-operator/teams","hooks_url":"https://api.github.com/repos/jlebon/container-linux-update-operator/hooks","issue_events_url":"https://api.github.com/repos/jlebon/container-linux-update-operator/issues/events{/number}","events_url":"https://api.github.com/repos/jlebon/container-linux-update-operator/events","assignees_url":"https://api.github.com/repos/jlebon/container-linux-update-operator/assignees{/user}","branches_url":"https://api.github.com/repos/jlebon/container-linux-update-operator/branches{/branch}","tags_url":"https://api.github.com/repos/jlebon/container-linux-update-operator/tags","blobs_url":"https://api.github.com/repos/jlebon/container-linux-update-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jlebon/container-linux-update-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jlebon/container-linux-update-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/jlebon/container-linux-update-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jlebon/container-linux-update-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/jlebon/container-linux-update-operator/languages","stargazers_url":"https://api.github.com/repos/jlebon/container-linux-update-operator/stargazers","contributors_url":"https://api.github.com/repos/jlebon/container-linux-update-operator/contributors","subscribers_url":"https://api.github.com/repos/jlebon/container-linux-update-operator/subscribers","subscription_url":"https://api.github.com/repos/jlebon/container-linux-update-operator/subscription","commits_url":"https://api.github.com/repos/jlebon/container-linux-update-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/jlebon/container-linux-update-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/jlebon/container-linux-update-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/jlebon/container-linux-update-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/jlebon/container-linux-update-operator/contents/{+path}","compare_url":"https://api.github.com/repos/jlebon/container-linux-update-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jlebon/container-linux-update-operator/merges","archive_url":"https://api.github.com/repos/jlebon/container-linux-update-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jlebon/container-linux-update-operator/downloads","issues_url":"https://api.github.com/repos/jlebon/container-linux-update-operator/issues{/number}","pulls_url":"https://api.github.com/repos/jlebon/container-linux-update-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/jlebon/container-linux-update-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/jlebon/container-linux-update-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jlebon/container-linux-update-operator/labels{/name}","releases_url":"https://api.github.com/repos/jlebon/container-linux-update-operator/releases{/id}","deployments_url":"https://api.github.com/repos/jlebon/container-linux-update-operator/deployments","created_at":"2018-03-29T17:21:53Z","updated_at":"2018-03-29T17:21:56Z","pushed_at":"2018-04-13T20:39:51Z","git_url":"git://github.com/jlebon/container-linux-update-operator.git","ssh_url":"git@github.com:jlebon/container-linux-update-operator.git","clone_url":"https://github.com/jlebon/container-linux-update-operator.git","svn_url":"https://github.com/jlebon/container-linux-update-operator","homepage":"","size":33342,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ashcrow:spike","ref":"spike","sha":"10df0f845e925191fe765425ba3305c4c71174f0","user":{"login":"ashcrow","id":22706,"avatar_url":"https://avatars3.githubusercontent.com/u/22706?v=4","gravatar_id":"","url":"https://api.github.com/users/ashcrow","html_url":"https://github.com/ashcrow","followers_url":"https://api.github.com/users/ashcrow/followers","following_url":"https://api.github.com/users/ashcrow/following{/other_user}","gists_url":"https://api.github.com/users/ashcrow/gists{/gist_id}","starred_url":"https://api.github.com/users/ashcrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashcrow/subscriptions","organizations_url":"https://api.github.com/users/ashcrow/orgs","repos_url":"https://api.github.com/users/ashcrow/repos","events_url":"https://api.github.com/users/ashcrow/events{/privacy}","received_events_url":"https://api.github.com/users/ashcrow/received_events","type":"User","site_admin":false},"repo":{"id":126202532,"name":"container-linux-update-operator","full_name":"ashcrow/container-linux-update-operator","owner":{"login":"ashcrow","id":22706,"avatar_url":"https://avatars3.githubusercontent.com/u/22706?v=4","gravatar_id":"","url":"https://api.github.com/users/ashcrow","html_url":"https://github.com/ashcrow","followers_url":"https://api.github.com/users/ashcrow/followers","following_url":"https://api.github.com/users/ashcrow/following{/other_user}","gists_url":"https://api.github.com/users/ashcrow/gists{/gist_id}","starred_url":"https://api.github.com/users/ashcrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashcrow/subscriptions","organizations_url":"https://api.github.com/users/ashcrow/orgs","repos_url":"https://api.github.com/users/ashcrow/repos","events_url":"https://api.github.com/users/ashcrow/events{/privacy}","received_events_url":"https://api.github.com/users/ashcrow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ashcrow/container-linux-update-operator","description":"A Kubernetes operator to manage updates of Container Linux by CoreOS ","fork":true,"url":"https://api.github.com/repos/ashcrow/container-linux-update-operator","forks_url":"https://api.github.com/repos/ashcrow/container-linux-update-operator/forks","keys_url":"https://api.github.com/repos/ashcrow/container-linux-update-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ashcrow/container-linux-update-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ashcrow/container-linux-update-operator/teams","hooks_url":"https://api.github.com/repos/ashcrow/container-linux-update-operator/hooks","issue_events_url":"https://api.github.com/repos/ashcrow/container-linux-update-operator/issues/events{/number}","events_url":"https://api.github.com/repos/ashcrow/container-linux-update-operator/events","assignees_url":"https://api.github.com/repos/ashcrow/container-linux-update-operator/assignees{/user}","branches_url":"https://api.github.com/repos/ashcrow/container-linux-update-operator/branches{/branch}","tags_url":"https://api.github.com/repos/ashcrow/container-linux-update-operator/tags","blobs_url":"https://api.github.com/repos/ashcrow/container-linux-update-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ashcrow/container-linux-update-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ashcrow/container-linux-update-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/ashcrow/container-linux-update-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ashcrow/container-linux-update-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/ashcrow/container-linux-update-operator/languages","stargazers_url":"https://api.github.com/repos/ashcrow/container-linux-update-operator/stargazers","contributors_url":"https://api.github.com/repos/ashcrow/container-linux-update-operator/contributors","subscribers_url":"https://api.github.com/repos/ashcrow/container-linux-update-operator/subscribers","subscription_url":"https://api.github.com/repos/ashcrow/container-linux-update-operator/subscription","commits_url":"https://api.github.com/repos/ashcrow/container-linux-update-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/ashcrow/container-linux-update-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/ashcrow/container-linux-update-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/ashcrow/container-linux-update-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/ashcrow/container-linux-update-operator/contents/{+path}","compare_url":"https://api.github.com/repos/ashcrow/container-linux-update-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ashcrow/container-linux-update-operator/merges","archive_url":"https://api.github.com/repos/ashcrow/container-linux-update-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ashcrow/container-linux-update-operator/downloads","issues_url":"https://api.github.com/repos/ashcrow/container-linux-update-operator/issues{/number}","pulls_url":"https://api.github.com/repos/ashcrow/container-linux-update-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/ashcrow/container-linux-update-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/ashcrow/container-linux-update-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ashcrow/container-linux-update-operator/labels{/name}","releases_url":"https://api.github.com/repos/ashcrow/container-linux-update-operator/releases{/id}","deployments_url":"https://api.github.com/repos/ashcrow/container-linux-update-operator/deployments","created_at":"2018-03-21T15:44:25Z","updated_at":"2018-03-21T15:44:27Z","pushed_at":"2018-04-13T20:45:19Z","git_url":"git://github.com/ashcrow/container-linux-update-operator.git","ssh_url":"git@github.com:ashcrow/container-linux-update-operator.git","clone_url":"https://github.com/ashcrow/container-linux-update-operator.git","svn_url":"https://github.com/ashcrow/container-linux-update-operator","homepage":"","size":33353,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ashcrow/container-linux-update-operator/pulls/2"},"html":{"href":"https://github.com/ashcrow/container-linux-update-operator/pull/2"},"issue":{"href":"https://api.github.com/repos/ashcrow/container-linux-update-operator/issues/2"},"comments":{"href":"https://api.github.com/repos/ashcrow/container-linux-update-operator/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/ashcrow/container-linux-update-operator/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/ashcrow/container-linux-update-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ashcrow/container-linux-update-operator/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/ashcrow/container-linux-update-operator/statuses/1d73ab162af744fe42a85fcd0b4805737f0f5b9a"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"cgwalters"}}