{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/65900","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/65900/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/65900/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/65900/events","html_url":"https://github.com/kubernetes/kubernetes/pull/65900","id":338904238,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NzIwMDQy","number":65900,"title":"don't validate CRI socket with ValidateAbsolutePath","user":{"login":"bart0sh","id":13677519,"node_id":"MDQ6VXNlcjEzNjc3NTE5","avatar_url":"https://avatars2.githubusercontent.com/u/13677519?v=4","gravatar_id":"","url":"https://api.github.com/users/bart0sh","html_url":"https://github.com/bart0sh","followers_url":"https://api.github.com/users/bart0sh/followers","following_url":"https://api.github.com/users/bart0sh/following{/other_user}","gists_url":"https://api.github.com/users/bart0sh/gists{/gist_id}","starred_url":"https://api.github.com/users/bart0sh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bart0sh/subscriptions","organizations_url":"https://api.github.com/users/bart0sh/orgs","repos_url":"https://api.github.com/users/bart0sh/repos","events_url":"https://api.github.com/users/bart0sh/events{/privacy}","received_events_url":"https://api.github.com/users/bart0sh/received_events","type":"User","site_admin":false},"labels":[{"id":451459590,"node_id":"MDU6TGFiZWw0NTE0NTk1OTA=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/kubeadm","name":"area/kubeadm","color":"0052cc","default":false},{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":573014062,"node_id":"MDU6TGFiZWw1NzMwMTQwNjI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"b60205","default":false},{"id":349530249,"node_id":"MDU6TGFiZWwzNDk1MzAyNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":173494222,"node_id":"MDU6TGFiZWwxNzM0OTQyMjI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/cluster-lifecycle","name":"sig/cluster-lifecycle","color":"d2b48c","default":false},{"id":253450793,"node_id":"MDU6TGFiZWwyNTM0NTA3OTM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XS","name":"size/XS","color":"009900","default":false}],"state":"open","locked":false,"assignee":{"login":"kad","id":41858,"node_id":"MDQ6VXNlcjQxODU4","avatar_url":"https://avatars1.githubusercontent.com/u/41858?v=4","gravatar_id":"","url":"https://api.github.com/users/kad","html_url":"https://github.com/kad","followers_url":"https://api.github.com/users/kad/followers","following_url":"https://api.github.com/users/kad/following{/other_user}","gists_url":"https://api.github.com/users/kad/gists{/gist_id}","starred_url":"https://api.github.com/users/kad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kad/subscriptions","organizations_url":"https://api.github.com/users/kad/orgs","repos_url":"https://api.github.com/users/kad/repos","events_url":"https://api.github.com/users/kad/events{/privacy}","received_events_url":"https://api.github.com/users/kad/received_events","type":"User","site_admin":false},"assignees":[{"login":"kad","id":41858,"node_id":"MDQ6VXNlcjQxODU4","avatar_url":"https://avatars1.githubusercontent.com/u/41858?v=4","gravatar_id":"","url":"https://api.github.com/users/kad","html_url":"https://github.com/kad","followers_url":"https://api.github.com/users/kad/followers","following_url":"https://api.github.com/users/kad/following{/other_user}","gists_url":"https://api.github.com/users/kad/gists{/gist_id}","starred_url":"https://api.github.com/users/kad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kad/subscriptions","organizations_url":"https://api.github.com/users/kad/orgs","repos_url":"https://api.github.com/users/kad/repos","events_url":"https://api.github.com/users/kad/events{/privacy}","received_events_url":"https://api.github.com/users/kad/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2018-07-06T11:27:11Z","updated_at":"2018-07-06T12:14:44Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/65900","html_url":"https://github.com/kubernetes/kubernetes/pull/65900","diff_url":"https://github.com/kubernetes/kubernetes/pull/65900.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/65900.patch"},"body":"**What this PR does / why we need it**:\r\n\r\nCRI socket doesn't have to be an absolute path, it should be an url.\r\nHowever, attempt to use it as an url in 'kubeadm init' command line\r\ncauses this validation error:\r\n\r\n$ sudo ./kubeadm init --cri-socket unix:///var/run/crio/crio.sock\r\nnodeRegistration.criSocket: Invalid value:\r\n\"unix:///var/run/crio/crio.sock\": path is not absolute\r\n\r\nRemoving this validation check should fix the issue.\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\n\r\nIt partly fixes this issue https://github.com/kubernetes/kubeadm/issues/928\r\n\r\n**Release note**:\r\n```release-note\r\nNONE\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/403016558","html_url":"https://github.com/kubernetes/kubernetes/pull/65900#issuecomment-403016558","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/65900","id":403016558,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMzAxNjU1OA==","user":{"login":"dims","id":23304,"node_id":"MDQ6VXNlcjIzMzA0","avatar_url":"https://avatars2.githubusercontent.com/u/23304?v=4","gravatar_id":"","url":"https://api.github.com/users/dims","html_url":"https://github.com/dims","followers_url":"https://api.github.com/users/dims/followers","following_url":"https://api.github.com/users/dims/following{/other_user}","gists_url":"https://api.github.com/users/dims/gists{/gist_id}","starred_url":"https://api.github.com/users/dims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dims/subscriptions","organizations_url":"https://api.github.com/users/dims/orgs","repos_url":"https://api.github.com/users/dims/repos","events_url":"https://api.github.com/users/dims/events{/privacy}","received_events_url":"https://api.github.com/users/dims/received_events","type":"User","site_admin":false},"created_at":"2018-07-06T12:14:44Z","updated_at":"2018-07-06T12:14:44Z","author_association":"MEMBER","body":"/ok-to-test"}}
{"actor":{"display_login":"dims"}}