{"action":"created","comment":{"url":"https://api.github.com/repos/salesforce/Argus/pulls/comments/172631184","pull_request_review_id":101681723,"id":172631184,"diff_hunk":"@@ -524,24 +534,27 @@ public void onSuccess(Response response) {\n \t\t\t\t\ttry {\n \t\t\t\t\t\tPutResponse putResponse = new ObjectMapper().readValue(extractResponse(response), PutResponse.class);\n \t\t\t\t\t\tif(putResponse.errors) {\n+\t\t\t\t\t\t\t_removeFromTrie(metrics);\n \t\t\t\t\t\t\tfor(Item item : putResponse.items) {\n \t\t\t\t\t\t\t\tif(item.create != null && item.create.status != HttpStatus.SC_CONFLICT && item.create.status != HttpStatus.SC_CREATED) {\n-\t\t\t\t\t\t\t\t\tthrow new SystemException(\"Failed to index metric. Reason: \" + new ObjectMapper().writeValueAsString(item.create.errorMap));\n+\t\t\t\t\t\t\t\t\t_logger.warn(\"Failed to index metric. Reason: \" + new ObjectMapper().writeValueAsString(item.create.errorMap));\n \t\t\t\t\t\t\t\t}\n \t\t\t\t\t\t\t\t\n \t\t\t\t\t\t\t\tif(item.index != null && item.index.status == HttpStatus.SC_NOT_FOUND) {\n-\t\t\t\t\t\t\t\t\tthrow new SystemException(\"Index does not exist. Error: \" + new ObjectMapper().writeValueAsString(item.index.errorMap));\n+\t\t\t\t\t\t\t\t\t_logger.warn(\"Index does not exist. Error: \" + new ObjectMapper().writeValueAsString(item.index.errorMap));\n \t\t\t\t\t\t\t\t}\n \t\t\t\t\t\t\t}\n \t\t\t\t\t\t}\n \t\t\t\t\t} catch(IOException e) {","path":"ArgusCore/src/main/java/com/salesforce/dva/argus/service/schema/ElasticSearchSchemaService.java","position":99,"original_position":99,"commit_id":"a1c2625aaa0a3cfb147c148f17d88ff41718207f","original_commit_id":"8e3ae14cc21cc2df1487807356388d458a976aaa","user":{"login":"bsura","id":15331712,"avatar_url":"https://avatars2.githubusercontent.com/u/15331712?v=4","gravatar_id":"","url":"https://api.github.com/users/bsura","html_url":"https://github.com/bsura","followers_url":"https://api.github.com/users/bsura/followers","following_url":"https://api.github.com/users/bsura/following{/other_user}","gists_url":"https://api.github.com/users/bsura/gists{/gist_id}","starred_url":"https://api.github.com/users/bsura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsura/subscriptions","organizations_url":"https://api.github.com/users/bsura/orgs","repos_url":"https://api.github.com/users/bsura/repos","events_url":"https://api.github.com/users/bsura/events{/privacy}","received_events_url":"https://api.github.com/users/bsura/received_events","type":"User","site_admin":false},"body":"I realized there's no point throwing exceptions from an async method, since they wouldn't be actionable. Hence we are only logging it. ","created_at":"2018-03-06T19:24:57Z","updated_at":"2018-03-06T19:24:57Z","html_url":"https://github.com/salesforce/Argus/pull/724#discussion_r172631184","pull_request_url":"https://api.github.com/repos/salesforce/Argus/pulls/724","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/salesforce/Argus/pulls/comments/172631184"},"html":{"href":"https://github.com/salesforce/Argus/pull/724#discussion_r172631184"},"pull_request":{"href":"https://api.github.com/repos/salesforce/Argus/pulls/724"}},"in_reply_to_id":172628905},"pull_request":{"url":"https://api.github.com/repos/salesforce/Argus/pulls/724","id":171818901,"html_url":"https://github.com/salesforce/Argus/pull/724","diff_url":"https://github.com/salesforce/Argus/pull/724.diff","patch_url":"https://github.com/salesforce/Argus/pull/724.patch","issue_url":"https://api.github.com/repos/salesforce/Argus/issues/724","number":724,"state":"open","locked":false,"title":"Refactor ESSchemaService and FILL Transform bug fix","user":{"login":"bsura","id":15331712,"avatar_url":"https://avatars2.githubusercontent.com/u/15331712?v=4","gravatar_id":"","url":"https://api.github.com/users/bsura","html_url":"https://github.com/bsura","followers_url":"https://api.github.com/users/bsura/followers","following_url":"https://api.github.com/users/bsura/following{/other_user}","gists_url":"https://api.github.com/users/bsura/gists{/gist_id}","starred_url":"https://api.github.com/users/bsura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsura/subscriptions","organizations_url":"https://api.github.com/users/bsura/orgs","repos_url":"https://api.github.com/users/bsura/repos","events_url":"https://api.github.com/users/bsura/events{/privacy}","received_events_url":"https://api.github.com/users/bsura/received_events","type":"User","site_admin":false},"body":"PR contains following changes:\r\n- FILL Transform bug fix when a metric expression returns empty datapoint set. Also add the ability to distinguish between FILL(expr, #constants#) and FILL(#constants#) by adding a constantsOnly flag\r\n-  Cleanup ESSchemaService exception handling and logging. Also remove records from TRIE if an exception occurs while indexing schema records\r\n- Increase DefaultDiscoveryService schema records fetch size from 500 to 10000. ","created_at":"2018-02-27T23:51:17Z","updated_at":"2018-03-06T19:24:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5bd1a0467f66baf1efee80b490af4828b6e94d08","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/salesforce/Argus/pulls/724/commits","review_comments_url":"https://api.github.com/repos/salesforce/Argus/pulls/724/comments","review_comment_url":"https://api.github.com/repos/salesforce/Argus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/salesforce/Argus/issues/724/comments","statuses_url":"https://api.github.com/repos/salesforce/Argus/statuses/a1c2625aaa0a3cfb147c148f17d88ff41718207f","head":{"label":"bsura:release/2.12.0","ref":"release/2.12.0","sha":"a1c2625aaa0a3cfb147c148f17d88ff41718207f","user":{"login":"bsura","id":15331712,"avatar_url":"https://avatars2.githubusercontent.com/u/15331712?v=4","gravatar_id":"","url":"https://api.github.com/users/bsura","html_url":"https://github.com/bsura","followers_url":"https://api.github.com/users/bsura/followers","following_url":"https://api.github.com/users/bsura/following{/other_user}","gists_url":"https://api.github.com/users/bsura/gists{/gist_id}","starred_url":"https://api.github.com/users/bsura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsura/subscriptions","organizations_url":"https://api.github.com/users/bsura/orgs","repos_url":"https://api.github.com/users/bsura/repos","events_url":"https://api.github.com/users/bsura/events{/privacy}","received_events_url":"https://api.github.com/users/bsura/received_events","type":"User","site_admin":false},"repo":{"id":53439661,"name":"Argus","full_name":"bsura/Argus","owner":{"login":"bsura","id":15331712,"avatar_url":"https://avatars2.githubusercontent.com/u/15331712?v=4","gravatar_id":"","url":"https://api.github.com/users/bsura","html_url":"https://github.com/bsura","followers_url":"https://api.github.com/users/bsura/followers","following_url":"https://api.github.com/users/bsura/following{/other_user}","gists_url":"https://api.github.com/users/bsura/gists{/gist_id}","starred_url":"https://api.github.com/users/bsura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsura/subscriptions","organizations_url":"https://api.github.com/users/bsura/orgs","repos_url":"https://api.github.com/users/bsura/repos","events_url":"https://api.github.com/users/bsura/events{/privacy}","received_events_url":"https://api.github.com/users/bsura/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bsura/Argus","description":"Time series monitoring and alerting platform.","fork":true,"url":"https://api.github.com/repos/bsura/Argus","forks_url":"https://api.github.com/repos/bsura/Argus/forks","keys_url":"https://api.github.com/repos/bsura/Argus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bsura/Argus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bsura/Argus/teams","hooks_url":"https://api.github.com/repos/bsura/Argus/hooks","issue_events_url":"https://api.github.com/repos/bsura/Argus/issues/events{/number}","events_url":"https://api.github.com/repos/bsura/Argus/events","assignees_url":"https://api.github.com/repos/bsura/Argus/assignees{/user}","branches_url":"https://api.github.com/repos/bsura/Argus/branches{/branch}","tags_url":"https://api.github.com/repos/bsura/Argus/tags","blobs_url":"https://api.github.com/repos/bsura/Argus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bsura/Argus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bsura/Argus/git/refs{/sha}","trees_url":"https://api.github.com/repos/bsura/Argus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bsura/Argus/statuses/{sha}","languages_url":"https://api.github.com/repos/bsura/Argus/languages","stargazers_url":"https://api.github.com/repos/bsura/Argus/stargazers","contributors_url":"https://api.github.com/repos/bsura/Argus/contributors","subscribers_url":"https://api.github.com/repos/bsura/Argus/subscribers","subscription_url":"https://api.github.com/repos/bsura/Argus/subscription","commits_url":"https://api.github.com/repos/bsura/Argus/commits{/sha}","git_commits_url":"https://api.github.com/repos/bsura/Argus/git/commits{/sha}","comments_url":"https://api.github.com/repos/bsura/Argus/comments{/number}","issue_comment_url":"https://api.github.com/repos/bsura/Argus/issues/comments{/number}","contents_url":"https://api.github.com/repos/bsura/Argus/contents/{+path}","compare_url":"https://api.github.com/repos/bsura/Argus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bsura/Argus/merges","archive_url":"https://api.github.com/repos/bsura/Argus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bsura/Argus/downloads","issues_url":"https://api.github.com/repos/bsura/Argus/issues{/number}","pulls_url":"https://api.github.com/repos/bsura/Argus/pulls{/number}","milestones_url":"https://api.github.com/repos/bsura/Argus/milestones{/number}","notifications_url":"https://api.github.com/repos/bsura/Argus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bsura/Argus/labels{/name}","releases_url":"https://api.github.com/repos/bsura/Argus/releases{/id}","deployments_url":"https://api.github.com/repos/bsura/Argus/deployments","created_at":"2016-03-08T19:36:38Z","updated_at":"2016-10-27T23:38:37Z","pushed_at":"2018-03-06T19:16:07Z","git_url":"git://github.com/bsura/Argus.git","ssh_url":"git@github.com:bsura/Argus.git","clone_url":"https://github.com/bsura/Argus.git","svn_url":"https://github.com/bsura/Argus","homepage":"","size":4528,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"salesforce:develop","ref":"develop","sha":"a66ce7621c9300794fd79b6c6e72cb4a83b83fca","user":{"login":"salesforce","id":453694,"avatar_url":"https://avatars3.githubusercontent.com/u/453694?v=4","gravatar_id":"","url":"https://api.github.com/users/salesforce","html_url":"https://github.com/salesforce","followers_url":"https://api.github.com/users/salesforce/followers","following_url":"https://api.github.com/users/salesforce/following{/other_user}","gists_url":"https://api.github.com/users/salesforce/gists{/gist_id}","starred_url":"https://api.github.com/users/salesforce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salesforce/subscriptions","organizations_url":"https://api.github.com/users/salesforce/orgs","repos_url":"https://api.github.com/users/salesforce/repos","events_url":"https://api.github.com/users/salesforce/events{/privacy}","received_events_url":"https://api.github.com/users/salesforce/received_events","type":"Organization","site_admin":false},"repo":{"id":44994636,"name":"Argus","full_name":"salesforce/Argus","owner":{"login":"salesforce","id":453694,"avatar_url":"https://avatars3.githubusercontent.com/u/453694?v=4","gravatar_id":"","url":"https://api.github.com/users/salesforce","html_url":"https://github.com/salesforce","followers_url":"https://api.github.com/users/salesforce/followers","following_url":"https://api.github.com/users/salesforce/following{/other_user}","gists_url":"https://api.github.com/users/salesforce/gists{/gist_id}","starred_url":"https://api.github.com/users/salesforce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salesforce/subscriptions","organizations_url":"https://api.github.com/users/salesforce/orgs","repos_url":"https://api.github.com/users/salesforce/repos","events_url":"https://api.github.com/users/salesforce/events{/privacy}","received_events_url":"https://api.github.com/users/salesforce/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/salesforce/Argus","description":"Time series monitoring and alerting platform.","fork":false,"url":"https://api.github.com/repos/salesforce/Argus","forks_url":"https://api.github.com/repos/salesforce/Argus/forks","keys_url":"https://api.github.com/repos/salesforce/Argus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/salesforce/Argus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/salesforce/Argus/teams","hooks_url":"https://api.github.com/repos/salesforce/Argus/hooks","issue_events_url":"https://api.github.com/repos/salesforce/Argus/issues/events{/number}","events_url":"https://api.github.com/repos/salesforce/Argus/events","assignees_url":"https://api.github.com/repos/salesforce/Argus/assignees{/user}","branches_url":"https://api.github.com/repos/salesforce/Argus/branches{/branch}","tags_url":"https://api.github.com/repos/salesforce/Argus/tags","blobs_url":"https://api.github.com/repos/salesforce/Argus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/salesforce/Argus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/salesforce/Argus/git/refs{/sha}","trees_url":"https://api.github.com/repos/salesforce/Argus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/salesforce/Argus/statuses/{sha}","languages_url":"https://api.github.com/repos/salesforce/Argus/languages","stargazers_url":"https://api.github.com/repos/salesforce/Argus/stargazers","contributors_url":"https://api.github.com/repos/salesforce/Argus/contributors","subscribers_url":"https://api.github.com/repos/salesforce/Argus/subscribers","subscription_url":"https://api.github.com/repos/salesforce/Argus/subscription","commits_url":"https://api.github.com/repos/salesforce/Argus/commits{/sha}","git_commits_url":"https://api.github.com/repos/salesforce/Argus/git/commits{/sha}","comments_url":"https://api.github.com/repos/salesforce/Argus/comments{/number}","issue_comment_url":"https://api.github.com/repos/salesforce/Argus/issues/comments{/number}","contents_url":"https://api.github.com/repos/salesforce/Argus/contents/{+path}","compare_url":"https://api.github.com/repos/salesforce/Argus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/salesforce/Argus/merges","archive_url":"https://api.github.com/repos/salesforce/Argus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/salesforce/Argus/downloads","issues_url":"https://api.github.com/repos/salesforce/Argus/issues{/number}","pulls_url":"https://api.github.com/repos/salesforce/Argus/pulls{/number}","milestones_url":"https://api.github.com/repos/salesforce/Argus/milestones{/number}","notifications_url":"https://api.github.com/repos/salesforce/Argus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/salesforce/Argus/labels{/name}","releases_url":"https://api.github.com/repos/salesforce/Argus/releases{/id}","deployments_url":"https://api.github.com/repos/salesforce/Argus/deployments","created_at":"2015-10-26T20:17:17Z","updated_at":"2018-03-04T19:25:46Z","pushed_at":"2018-03-06T19:16:08Z","git_url":"git://github.com/salesforce/Argus.git","ssh_url":"git@github.com:salesforce/Argus.git","clone_url":"https://github.com/salesforce/Argus.git","svn_url":"https://github.com/salesforce/Argus","homepage":"","size":6695,"stargazers_count":314,"watchers_count":314,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":88,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":88,"open_issues":23,"watchers":314,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/salesforce/Argus/pulls/724"},"html":{"href":"https://github.com/salesforce/Argus/pull/724"},"issue":{"href":"https://api.github.com/repos/salesforce/Argus/issues/724"},"comments":{"href":"https://api.github.com/repos/salesforce/Argus/issues/724/comments"},"review_comments":{"href":"https://api.github.com/repos/salesforce/Argus/pulls/724/comments"},"review_comment":{"href":"https://api.github.com/repos/salesforce/Argus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/salesforce/Argus/pulls/724/commits"},"statuses":{"href":"https://api.github.com/repos/salesforce/Argus/statuses/a1c2625aaa0a3cfb147c148f17d88ff41718207f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bsura"}}