{"action":"created","issue":{"url":"https://api.github.com/repos/ONSdigital/response-operations-ui/issues/232","repository_url":"https://api.github.com/repos/ONSdigital/response-operations-ui","labels_url":"https://api.github.com/repos/ONSdigital/response-operations-ui/issues/232/labels{/name}","comments_url":"https://api.github.com/repos/ONSdigital/response-operations-ui/issues/232/comments","events_url":"https://api.github.com/repos/ONSdigital/response-operations-ui/issues/232/events","html_url":"https://github.com/ONSdigital/response-operations-ui/pull/232","id":356495326,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNzQwNjE1","number":232,"title":"Dynamically populate secure messaging drop down","user":{"login":"ryangrundy7","id":35301276,"node_id":"MDQ6VXNlcjM1MzAxMjc2","avatar_url":"https://avatars2.githubusercontent.com/u/35301276?v=4","gravatar_id":"","url":"https://api.github.com/users/ryangrundy7","html_url":"https://github.com/ryangrundy7","followers_url":"https://api.github.com/users/ryangrundy7/followers","following_url":"https://api.github.com/users/ryangrundy7/following{/other_user}","gists_url":"https://api.github.com/users/ryangrundy7/gists{/gist_id}","starred_url":"https://api.github.com/users/ryangrundy7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryangrundy7/subscriptions","organizations_url":"https://api.github.com/users/ryangrundy7/orgs","repos_url":"https://api.github.com/users/ryangrundy7/repos","events_url":"https://api.github.com/users/ryangrundy7/events{/privacy}","received_events_url":"https://api.github.com/users/ryangrundy7/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-03T12:55:58Z","updated_at":"2018-09-03T13:15:25Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ONSdigital/response-operations-ui/pulls/232","html_url":"https://github.com/ONSdigital/response-operations-ui/pull/232","diff_url":"https://github.com/ONSdigital/response-operations-ui/pull/232.diff","patch_url":"https://github.com/ONSdigital/response-operations-ui/pull/232.patch"},"body":"# Motivation and Context\r\nAt present every time we onboard a new survey we manually have to update the dropdown box in r-ops to reflect the change so secure messaging can be used. The box should be dynamic and call from the survey service to populate it. \r\n\r\n# What has changed\r\n- Secure-message dropdown now gets populated from the survey service\r\n- FDI Grouping happens in Config instead of its own file.\r\n- Added specific FDI create message and messages page tests\r\n\r\n# How to test?\r\n- Run r-ops tests and the acceptance tests\r\n- Check the secure-message dropdown works and is populated with every survey\r\n- Set a FDI survey collection exercise to ready to live, send a message and you should be directed to the FDI messages screen. Try with multiple FDI surveys.\r\n- Create a survey using `/surveys/create` and it should be put into the surveys dropdown box\r\n# Links\r\n[Trello Card](https://trello.com/c/Xfc0UL3i/326-dynamically-populate-secure-messaging-drop-down-m)"},"comment":{"url":"https://api.github.com/repos/ONSdigital/response-operations-ui/issues/comments/418112178","html_url":"https://github.com/ONSdigital/response-operations-ui/pull/232#issuecomment-418112178","issue_url":"https://api.github.com/repos/ONSdigital/response-operations-ui/issues/232","id":418112178,"node_id":"MDEyOklzc3VlQ29tbWVudDQxODExMjE3OA==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-09-03T13:15:25Z","updated_at":"2018-09-03T13:15:25Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/ONSdigital/response-operations-ui/pull/232?src=pr&el=h1) Report\n> Merging [#232](https://codecov.io/gh/ONSdigital/response-operations-ui/pull/232?src=pr&el=desc) into [master](https://codecov.io/gh/ONSdigital/response-operations-ui/commit/205b613aeada8fda1ff50422e13ff4250b7770da?src=pr&el=desc) will **increase** coverage by `0.06%`.\n> The diff coverage is `100%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/ONSdigital/response-operations-ui/pull/232/graphs/tree.svg?width=650&token=UmVXqKXO6D&height=150&src=pr)](https://codecov.io/gh/ONSdigital/response-operations-ui/pull/232?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master     #232      +/-   ##\n==========================================\n+ Coverage   96.32%   96.39%   +0.06%     \n==========================================\n  Files          40       39       -1     \n  Lines        2149     2133      -16     \n==========================================\n- Hits         2070     2056      -14     \n+ Misses         79       77       -2\n```\n\n\n| [Impacted Files](https://codecov.io/gh/ONSdigital/response-operations-ui/pull/232?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [response\\_operations\\_ui/views/messages.py](https://codecov.io/gh/ONSdigital/response-operations-ui/pull/232/diff?src=pr&el=tree#diff-cmVzcG9uc2Vfb3BlcmF0aW9uc191aS92aWV3cy9tZXNzYWdlcy5weQ==) | `94.54% <100%> (+0.96%)` | :arrow_up: |\n| [...se\\_operations\\_ui/controllers/survey\\_controllers.py](https://codecov.io/gh/ONSdigital/response-operations-ui/pull/232/diff?src=pr&el=tree#diff-cmVzcG9uc2Vfb3BlcmF0aW9uc191aS9jb250cm9sbGVycy9zdXJ2ZXlfY29udHJvbGxlcnMucHk=) | `96.2% <100%> (+0.07%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/ONSdigital/response-operations-ui/pull/232?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/ONSdigital/response-operations-ui/pull/232?src=pr&el=footer). Last update [205b613...714a292](https://codecov.io/gh/ONSdigital/response-operations-ui/pull/232?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}