{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-superset/pulls/comments/185432004","pull_request_review_id":116817072,"id":185432004,"diff_hunk":"@@ -2375,6 +2375,35 @@ def get_data(self, df):\n         return result\n \n \n+class SpiderRadarViz(BaseViz):\n+    \"\"\"\n+    A spider / radar chart.\n+    \"\"\"\n+\n+    viz_type = 'spider_radar'\n+    verbose_name = _('Spider Radar Diagram')\n+    credits = (\n+        '<a href=https://www.visualcinnamon.com/>Nadieh Bremer, Data Viz Expert</a>')\n+    is_timeseries = False\n+\n+    def get_data(self, df):","path":"superset/viz.py","position":15,"original_position":15,"commit_id":"d17a836745b14883aa350600cb99a26d64ca940c","original_commit_id":"d17a836745b14883aa350600cb99a26d64ca940c","user":{"login":"peter-stuart-turner","id":34794246,"avatar_url":"https://avatars1.githubusercontent.com/u/34794246?v=4","gravatar_id":"","url":"https://api.github.com/users/peter-stuart-turner","html_url":"https://github.com/peter-stuart-turner","followers_url":"https://api.github.com/users/peter-stuart-turner/followers","following_url":"https://api.github.com/users/peter-stuart-turner/following{/other_user}","gists_url":"https://api.github.com/users/peter-stuart-turner/gists{/gist_id}","starred_url":"https://api.github.com/users/peter-stuart-turner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peter-stuart-turner/subscriptions","organizations_url":"https://api.github.com/users/peter-stuart-turner/orgs","repos_url":"https://api.github.com/users/peter-stuart-turner/repos","events_url":"https://api.github.com/users/peter-stuart-turner/events{/privacy}","received_events_url":"https://api.github.com/users/peter-stuart-turner/received_events","type":"User","site_admin":false},"body":"Any chance I can get some help writing this unit test? I'm struggling to get it to run with tox - tox keeps failing in installing the dependencies. I'm runnning:\r\n\r\ntox -e pylint -- tests/viz_tests.py\r\n\r\n","created_at":"2018-05-02T08:56:59Z","updated_at":"2018-05-02T08:56:59Z","html_url":"https://github.com/apache/incubator-superset/pull/4871#discussion_r185432004","pull_request_url":"https://api.github.com/repos/apache/incubator-superset/pulls/4871","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-superset/pulls/comments/185432004"},"html":{"href":"https://github.com/apache/incubator-superset/pull/4871#discussion_r185432004"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-superset/pulls/4871"}},"in_reply_to_id":184784593},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-superset/pulls/4871","id":183710837,"html_url":"https://github.com/apache/incubator-superset/pull/4871","diff_url":"https://github.com/apache/incubator-superset/pull/4871.diff","patch_url":"https://github.com/apache/incubator-superset/pull/4871.patch","issue_url":"https://api.github.com/repos/apache/incubator-superset/issues/4871","number":4871,"state":"open","locked":false,"title":"Add spider/radar chart ","user":{"login":"peter-stuart-turner","id":34794246,"avatar_url":"https://avatars1.githubusercontent.com/u/34794246?v=4","gravatar_id":"","url":"https://api.github.com/users/peter-stuart-turner","html_url":"https://github.com/peter-stuart-turner","followers_url":"https://api.github.com/users/peter-stuart-turner/followers","following_url":"https://api.github.com/users/peter-stuart-turner/following{/other_user}","gists_url":"https://api.github.com/users/peter-stuart-turner/gists{/gist_id}","starred_url":"https://api.github.com/users/peter-stuart-turner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peter-stuart-turner/subscriptions","organizations_url":"https://api.github.com/users/peter-stuart-turner/orgs","repos_url":"https://api.github.com/users/peter-stuart-turner/repos","events_url":"https://api.github.com/users/peter-stuart-turner/events{/privacy}","received_events_url":"https://api.github.com/users/peter-stuart-turner/received_events","type":"User","site_admin":false},"body":"Added a visualization: Spider/Radar chart (using D3) \r\n\r\nIt has options to 'group by' selected columns, and compare the categories on a single metric for all of those columns. The comparisons are shown on the axis of the graph, each axis represents a category. \r\n\r\nThere is also functionality to set the max value of the graph (outermost circle), this 'stretches' the axes on which the metric's values are plotted. \r\n\r\nI have not added any tests, as I am unsure of what I need to test, and how I need to do this - more than happy to add, just need some help there. \r\n\r\nCredit to Nadieh Bremer for the original JS and CSS, https://www.visualcinnamon.com \r\n\r\n(picture below)\r\n\r\n<img width=\"657\" alt=\"screen shot 2018-04-24 at 1 45 53 pm\" src=\"https://user-images.githubusercontent.com/34794246/39185017-f124b8b2-47c5-11e8-9bfd-693de6e678e1.png\">\r\n\r\n","created_at":"2018-04-24T11:54:47Z","updated_at":"2018-05-02T08:56:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b2570a3f195c7250bd7fd790356e33e1016d41fb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-superset/pulls/4871/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-superset/pulls/4871/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-superset/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-superset/issues/4871/comments","statuses_url":"https://api.github.com/repos/apache/incubator-superset/statuses/d17a836745b14883aa350600cb99a26d64ca940c","head":{"label":"peter-stuart-turner:spider","ref":"spider","sha":"d17a836745b14883aa350600cb99a26d64ca940c","user":{"login":"peter-stuart-turner","id":34794246,"avatar_url":"https://avatars1.githubusercontent.com/u/34794246?v=4","gravatar_id":"","url":"https://api.github.com/users/peter-stuart-turner","html_url":"https://github.com/peter-stuart-turner","followers_url":"https://api.github.com/users/peter-stuart-turner/followers","following_url":"https://api.github.com/users/peter-stuart-turner/following{/other_user}","gists_url":"https://api.github.com/users/peter-stuart-turner/gists{/gist_id}","starred_url":"https://api.github.com/users/peter-stuart-turner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peter-stuart-turner/subscriptions","organizations_url":"https://api.github.com/users/peter-stuart-turner/orgs","repos_url":"https://api.github.com/users/peter-stuart-turner/repos","events_url":"https://api.github.com/users/peter-stuart-turner/events{/privacy}","received_events_url":"https://api.github.com/users/peter-stuart-turner/received_events","type":"User","site_admin":false},"repo":{"id":129748101,"name":"incubator-superset","full_name":"peter-stuart-turner/incubator-superset","owner":{"login":"peter-stuart-turner","id":34794246,"avatar_url":"https://avatars1.githubusercontent.com/u/34794246?v=4","gravatar_id":"","url":"https://api.github.com/users/peter-stuart-turner","html_url":"https://github.com/peter-stuart-turner","followers_url":"https://api.github.com/users/peter-stuart-turner/followers","following_url":"https://api.github.com/users/peter-stuart-turner/following{/other_user}","gists_url":"https://api.github.com/users/peter-stuart-turner/gists{/gist_id}","starred_url":"https://api.github.com/users/peter-stuart-turner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peter-stuart-turner/subscriptions","organizations_url":"https://api.github.com/users/peter-stuart-turner/orgs","repos_url":"https://api.github.com/users/peter-stuart-turner/repos","events_url":"https://api.github.com/users/peter-stuart-turner/events{/privacy}","received_events_url":"https://api.github.com/users/peter-stuart-turner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/peter-stuart-turner/incubator-superset","description":"Apache Superset (incubating) is a modern, enterprise-ready business intelligence web application","fork":true,"url":"https://api.github.com/repos/peter-stuart-turner/incubator-superset","forks_url":"https://api.github.com/repos/peter-stuart-turner/incubator-superset/forks","keys_url":"https://api.github.com/repos/peter-stuart-turner/incubator-superset/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peter-stuart-turner/incubator-superset/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peter-stuart-turner/incubator-superset/teams","hooks_url":"https://api.github.com/repos/peter-stuart-turner/incubator-superset/hooks","issue_events_url":"https://api.github.com/repos/peter-stuart-turner/incubator-superset/issues/events{/number}","events_url":"https://api.github.com/repos/peter-stuart-turner/incubator-superset/events","assignees_url":"https://api.github.com/repos/peter-stuart-turner/incubator-superset/assignees{/user}","branches_url":"https://api.github.com/repos/peter-stuart-turner/incubator-superset/branches{/branch}","tags_url":"https://api.github.com/repos/peter-stuart-turner/incubator-superset/tags","blobs_url":"https://api.github.com/repos/peter-stuart-turner/incubator-superset/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peter-stuart-turner/incubator-superset/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peter-stuart-turner/incubator-superset/git/refs{/sha}","trees_url":"https://api.github.com/repos/peter-stuart-turner/incubator-superset/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peter-stuart-turner/incubator-superset/statuses/{sha}","languages_url":"https://api.github.com/repos/peter-stuart-turner/incubator-superset/languages","stargazers_url":"https://api.github.com/repos/peter-stuart-turner/incubator-superset/stargazers","contributors_url":"https://api.github.com/repos/peter-stuart-turner/incubator-superset/contributors","subscribers_url":"https://api.github.com/repos/peter-stuart-turner/incubator-superset/subscribers","subscription_url":"https://api.github.com/repos/peter-stuart-turner/incubator-superset/subscription","commits_url":"https://api.github.com/repos/peter-stuart-turner/incubator-superset/commits{/sha}","git_commits_url":"https://api.github.com/repos/peter-stuart-turner/incubator-superset/git/commits{/sha}","comments_url":"https://api.github.com/repos/peter-stuart-turner/incubator-superset/comments{/number}","issue_comment_url":"https://api.github.com/repos/peter-stuart-turner/incubator-superset/issues/comments{/number}","contents_url":"https://api.github.com/repos/peter-stuart-turner/incubator-superset/contents/{+path}","compare_url":"https://api.github.com/repos/peter-stuart-turner/incubator-superset/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peter-stuart-turner/incubator-superset/merges","archive_url":"https://api.github.com/repos/peter-stuart-turner/incubator-superset/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peter-stuart-turner/incubator-superset/downloads","issues_url":"https://api.github.com/repos/peter-stuart-turner/incubator-superset/issues{/number}","pulls_url":"https://api.github.com/repos/peter-stuart-turner/incubator-superset/pulls{/number}","milestones_url":"https://api.github.com/repos/peter-stuart-turner/incubator-superset/milestones{/number}","notifications_url":"https://api.github.com/repos/peter-stuart-turner/incubator-superset/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peter-stuart-turner/incubator-superset/labels{/name}","releases_url":"https://api.github.com/repos/peter-stuart-turner/incubator-superset/releases{/id}","deployments_url":"https://api.github.com/repos/peter-stuart-turner/incubator-superset/deployments","created_at":"2018-04-16T13:30:11Z","updated_at":"2018-04-16T13:30:17Z","pushed_at":"2018-04-24T13:09:20Z","git_url":"git://github.com/peter-stuart-turner/incubator-superset.git","ssh_url":"git@github.com:peter-stuart-turner/incubator-superset.git","clone_url":"https://github.com/peter-stuart-turner/incubator-superset.git","svn_url":"https://github.com/peter-stuart-turner/incubator-superset","homepage":"","size":81801,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"7193a4719d7f37dc223148baf2bed7c7c6187ac4","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":39464018,"name":"incubator-superset","full_name":"apache/incubator-superset","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-superset","description":"Apache Superset (incubating) is a modern, enterprise-ready business intelligence web application","fork":false,"url":"https://api.github.com/repos/apache/incubator-superset","forks_url":"https://api.github.com/repos/apache/incubator-superset/forks","keys_url":"https://api.github.com/repos/apache/incubator-superset/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-superset/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-superset/teams","hooks_url":"https://api.github.com/repos/apache/incubator-superset/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-superset/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-superset/events","assignees_url":"https://api.github.com/repos/apache/incubator-superset/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-superset/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-superset/tags","blobs_url":"https://api.github.com/repos/apache/incubator-superset/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-superset/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-superset/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-superset/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-superset/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-superset/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-superset/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-superset/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-superset/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-superset/subscription","commits_url":"https://api.github.com/repos/apache/incubator-superset/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-superset/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-superset/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-superset/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-superset/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-superset/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-superset/merges","archive_url":"https://api.github.com/repos/apache/incubator-superset/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-superset/downloads","issues_url":"https://api.github.com/repos/apache/incubator-superset/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-superset/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-superset/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-superset/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-superset/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-superset/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-superset/deployments","created_at":"2015-07-21T18:55:34Z","updated_at":"2018-05-02T08:47:26Z","pushed_at":"2018-05-02T04:28:28Z","git_url":"git://github.com/apache/incubator-superset.git","ssh_url":"git@github.com:apache/incubator-superset.git","clone_url":"https://github.com/apache/incubator-superset.git","svn_url":"https://github.com/apache/incubator-superset","homepage":"","size":83705,"stargazers_count":18971,"watchers_count":18971,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":3173,"mirror_url":null,"archived":false,"open_issues_count":636,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":3173,"open_issues":636,"watchers":18971,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-superset/pulls/4871"},"html":{"href":"https://github.com/apache/incubator-superset/pull/4871"},"issue":{"href":"https://api.github.com/repos/apache/incubator-superset/issues/4871"},"comments":{"href":"https://api.github.com/repos/apache/incubator-superset/issues/4871/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-superset/pulls/4871/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-superset/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-superset/pulls/4871/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-superset/statuses/d17a836745b14883aa350600cb99a26d64ca940c"}},"author_association":"NONE"}}
{"actor":{"display_login":"peter-stuart-turner"}}